fix: use utils.Ptr()

Author: philross

internal/cmd/auth/activate-service-account/activate_service_account_test.go

@@ -4,6 +4,7 @@ import (
 	"testing"
 
 	"github.com/stackitcloud/stackit-cli/internal/pkg/testutils"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/utils"
 
 	"github.com/spf13/viper"
 	"github.com/zalando/go-keyring"
@@ -14,10 +15,6 @@ import (
 
 var testTokenCustomEndpoint = "token_url"
 
-func boolPtr(v bool) *bool {
-	return &v
-}
-
 func fixtureFlagValues(mods ...func(flagValues map[string]string)) map[string]string {
 	flagValues := map[string]string{
 		serviceAccountTokenFlag:   "token",
@@ -37,7 +34,7 @@ func fixtureInputModel(mods ...func(model *inputModel)) *inputModel {
 		ServiceAccountToken:   "token",
 		ServiceAccountKeyPath: "sa_key",
 		PrivateKeyPath:        "private_key",
-		UseOIDC:               boolPtr(true),
+		UseOIDC:               utils.Ptr(true),
 		OnlyPrintAccessToken:  true,
 	}
 	for _, mod := range mods {
@@ -97,7 +94,7 @@ func TestParseInput(t *testing.T) {
 			}),
 			isValid: true,
 			expectedModel: fixtureInputModel(func(model *inputModel) {
-				model.UseOIDC = boolPtr(true)
+				model.UseOIDC = utils.Ptr(true)
 			}),
 		},
 		{
@@ -107,7 +104,7 @@ func TestParseInput(t *testing.T) {
 			}),
 			isValid: true,
 			expectedModel: fixtureInputModel(func(model *inputModel) {
-				model.UseOIDC = boolPtr(false)
+				model.UseOIDC = utils.Ptr(false)
 			}),
 		},
 		{

internal/pkg/auth/oidc_test.go

@@ -8,12 +8,9 @@ import (
 	"testing"
 
 	"github.com/stackitcloud/stackit-cli/internal/pkg/auth"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/utils"
 )
 
-func boolPtr(v bool) *bool {
-	return &v
-}
-
 func TestIsEnabled(t *testing.T) {
 	tests := []struct {
 		value    string
@@ -61,13 +58,13 @@ func TestIsOIDCEnabledWithOverride(t *testing.T) {
 		{
 			description: "override true wins over env false",
 			envUseOIDC:  "0",
-			override:    boolPtr(true),
+			override:    utils.Ptr(true),
 			expected:    true,
 		},
 		{
 			description: "override false wins over env true",
 			envUseOIDC:  "1",
-			override:    boolPtr(false),
+			override:    utils.Ptr(false),
 			expected:    false,
 		},
 	}