[6.x] Remove pt-4 as the default padding for a Group fieldtype#14708
Open
martyf wants to merge 1 commit into
Open
[6.x] Remove pt-4 as the default padding for a Group fieldtype#14708martyf wants to merge 1 commit into
pt-4 as the default padding for a Group fieldtype#14708martyf wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Group fieldtype has no border, there is a
pt-4applied to the top.With a border, it becomes
py-4.The space it creates is not aesthetically pleasing.
This PR removes
pt-4from a border-less Group fieldtype.These examples are two Group fields, the top with the label hidden, and the bottom with the label visible. There are no field actions in this configuration, including disabling full screen.
Before:
After:
There is still unnecessary space above the field, but will see #14707 for this.