test: fix upper-tail fixture iteration and edge-case assertions in JS tests

Author: Planeshifter

lib/node_modules/@stdlib/math/base/special/gammaincinv/test/test.js

@@ -25,6 +25,7 @@ var incrspace = require( '@stdlib/array/base/incrspace' );
 var isfinite = require( '@stdlib/math/base/assert/is-finite' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var abs = require( '@stdlib/math/base/special/abs' );
+var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' );
 var PINF = require( '@stdlib/constants/float64/pinf' );
 var gammaincinv = require( './../lib' );
 
@@ -116,54 +117,54 @@ tape( 'the function returns `NaN` if provided `p` outside the interval `[0,1]`',
 	t.end();
 });
 
-tape( 'the function returns `0` if provided `p = 1`', function test( t ) {
+tape( 'the function returns `+Infinity` if provided `p = 1`', function test( t ) {
 	var val;
 	var a;
 	var i;
 
-	a = incrspace( 0, 100, 10 );
+	a = incrspace( 10, 100, 10 );
 	for ( i = 0; i < a.length; i++ ) {
 		val = gammaincinv( 1, a[ i ] );
-		t.notOk( val === 0, 'returns expected value' );
+		t.strictEqual( val, PINF, 'returns expected value' );
 	}
 	t.end();
 });
 
-tape( 'the function returns `+Infinity` if provided `p = 0`', function test( t ) {
+tape( 'the function returns `0` if provided `p = 0`', function test( t ) {
 	var val;
 	var a;
 	var i;
 
-	a = incrspace( 0, 100, 10 );
+	a = incrspace( 10, 100, 10 );
 	for ( i = 0; i < a.length; i++ ) {
 		val = gammaincinv( 0, a[ i ] );
-		t.notOk( val === PINF, 'returns expected value' );
+		t.strictEqual( val, 0.0, 'returns expected value' );
 	}
 	t.end();
 });
 
-tape( 'the function returns `0` if provided `p = 0` when `upper = true`', function test( t ) {
+tape( 'the function returns `+Infinity` if provided `p = 0` when `upper = true`', function test( t ) {
 	var val;
 	var a;
 	var i;
 
-	a = incrspace( 0, 100, 10 );
+	a = incrspace( 10, 100, 10 );
 	for ( i = 0; i < a.length; i++ ) {
 		val = gammaincinv( 0, a[ i ], true );
-		t.notOk( val === 0, 'returns expected value' );
+		t.strictEqual( val, PINF, 'returns expected value' );
 	}
 	t.end();
 });
 
-tape( 'the function returns `+Infinity` if provided `p = 1` when `upper = true`', function test( t ) {
+tape( 'the function returns `0` if provided `p = 1` when `upper = true`', function test( t ) {
 	var val;
 	var a;
 	var i;
 
-	a = incrspace( 0, 100, 10 );
+	a = incrspace( 10, 100, 10 );
 	for ( i = 0; i < a.length; i++ ) {
 		val = gammaincinv( 1, a[ i ], true );
-		t.notOk( val === PINF, 'returns expected value' );
+		t.strictEqual( val, 0.0, 'returns expected value' );
 	}
 	t.end();
 });
@@ -195,18 +196,18 @@ tape( 'the function inverts the upper incomplete gamma function when `upper=true
 	var b1;
 	var b2;
 	var i;
-	for ( i = 0; i < arg1.length; i++ ) {
+	for ( i = 0; i < upperArg1.length; i++ ) {
 		actual = gammaincinv( upperArg1[ i ], upperArg2[ i ], true );
 
 		b1 = isfinite( actual );
 		b2 = isfinite( upperExpected[ i ] );
 		t.strictEqual( b1, b2, 'returned result is ' + ( (b2) ? 'finite' : 'not finite' ) );
 
 		b1 = isnan( actual );
-		b2 = isnan( expected[ i ] );
+		b2 = isnan( upperExpected[ i ] );
 		t.strictEqual( b1, b2, 'returned result is ' + ( (b1) ? '' : 'not' ) + ' NaN' );
 		if ( !b1 || !b2 ) {
-			t.ok( abs( actual - upperExpected[ i ] ) < 5e-14, 'returned result is within tolerance. actual: ' + actual + '; expected: ' + upperExpected[ i ] + '.' );
+			t.strictEqual( isAlmostSameValue( actual, upperExpected[ i ], 40.0 ), true, 'returned result is within tolerance. actual: ' + actual + '; expected: ' + upperExpected[ i ] + '.' );
 		}
 	}
 	t.end();