From c0a2321dee375e86408dafa0f6466cd442b12e53 Mon Sep 17 00:00:00 2001 From: John Jenkins Date: Mon, 13 Apr 2026 19:15:42 +0100 Subject: [PATCH 1/4] chore: v5-add-other-dist-artifacts-to-skipInDev --- packages/cli/src/migrations/rules/build-dist-docs.ts | 2 +- packages/core/src/compiler/config/outputs/validate-dist.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/cli/src/migrations/rules/build-dist-docs.ts b/packages/cli/src/migrations/rules/build-dist-docs.ts index 1e68ff84576..837661a1682 100644 --- a/packages/cli/src/migrations/rules/build-dist-docs.ts +++ b/packages/cli/src/migrations/rules/build-dist-docs.ts @@ -60,7 +60,7 @@ export const buildDistDocsRule: MigrationRule = { if (isTrue) { if (propName === 'buildDist') { - targetTypesNeedingSkipInDev.push('dist-custom-elements', 'dist-hydrate-script'); + targetTypesNeedingSkipInDev.push('dist', 'dist-custom-elements', 'dist-hydrate-script'); } else if (propName === 'buildDocs') { targetTypesNeedingSkipInDev.push( 'docs-readme', diff --git a/packages/core/src/compiler/config/outputs/validate-dist.ts b/packages/core/src/compiler/config/outputs/validate-dist.ts index b428949bff4..6e631b18380 100644 --- a/packages/core/src/compiler/config/outputs/validate-dist.ts +++ b/packages/core/src/compiler/config/outputs/validate-dist.ts @@ -145,8 +145,8 @@ const validateOutputTargetDist = ( : true, isPrimaryPackageOutputTarget: o.isPrimaryPackageOutputTarget ?? false, cjs: isBoolean(o.cjs) ? o.cjs : false, - // dist always builds by default (skipInDev: false) - skipInDev: isBoolean(o.skipInDev) ? o.skipInDev : false, + // dist skips distribution artifacts in dev mode by default, but always builds browser/CDN output + skipInDev: isBoolean(o.skipInDev) ? o.skipInDev : true, } satisfies Required; if (!isAbsolute(outputTarget.buildDir)) { From 0225f4f73bdc7b6c1a3c6bb1105aa9c0144b86ff Mon Sep 17 00:00:00 2001 From: John Jenkins Date: Mon, 13 Apr 2026 19:23:41 +0100 Subject: [PATCH 2/4] chore: --- .../src/compiler/config/_test_/validate-output-dist.spec.ts | 6 +++--- .../output-targets/_test_/output-lazy-loader.spec.ts | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/core/src/compiler/config/_test_/validate-output-dist.spec.ts b/packages/core/src/compiler/config/_test_/validate-output-dist.spec.ts index 1fb1c5067ca..8524154c5d0 100644 --- a/packages/core/src/compiler/config/_test_/validate-output-dist.spec.ts +++ b/packages/core/src/compiler/config/_test_/validate-output-dist.spec.ts @@ -39,7 +39,7 @@ describe('validateDistOutputTarget', () => { typesDir: join(rootDir, 'my-dist', 'types'), transformAliasedImportPathsInCollection: true, isPrimaryPackageOutputTarget: false, - skipInDev: false, + skipInDev: true, }, { esmDir: join(rootDir, 'my-dist', 'my-build', 'testing'), @@ -135,7 +135,7 @@ describe('validateDistOutputTarget', () => { typesDir: join(rootDir, 'my-dist', 'types'), transformAliasedImportPathsInCollection: true, isPrimaryPackageOutputTarget: false, - skipInDev: false, + skipInDev: true, }, { esmDir: join(rootDir, 'my-dist', 'my-build', 'testing'), @@ -215,7 +215,7 @@ describe('validateDistOutputTarget', () => { typesDir: join(rootDir, 'my-dist', 'types'), transformAliasedImportPathsInCollection: true, isPrimaryPackageOutputTarget: true, - skipInDev: false, + skipInDev: true, }, { esmDir: join(rootDir, 'my-dist', 'my-build', 'testing'), diff --git a/packages/core/src/compiler/output-targets/_test_/output-lazy-loader.spec.ts b/packages/core/src/compiler/output-targets/_test_/output-lazy-loader.spec.ts index 831fa0177c3..28b5798ce9d 100644 --- a/packages/core/src/compiler/output-targets/_test_/output-lazy-loader.spec.ts +++ b/packages/core/src/compiler/output-targets/_test_/output-lazy-loader.spec.ts @@ -23,6 +23,7 @@ function setup(configOverrides: Partial = {}) { type: DIST, dir: 'my-test-dir', cjs: true, + skipInDev: false, }, ], srcDir: '/src', From 896cbbd975b30c21d42fe771f202e74641162123 Mon Sep 17 00:00:00 2001 From: John Jenkins Date: Mon, 13 Apr 2026 19:31:36 +0100 Subject: [PATCH 3/4] chore: --- .../_test_/validate-output-dist.spec.ts | 103 +----------------- 1 file changed, 1 insertion(+), 102 deletions(-) diff --git a/packages/core/src/compiler/config/_test_/validate-output-dist.spec.ts b/packages/core/src/compiler/config/_test_/validate-output-dist.spec.ts index 8524154c5d0..fa917ed80c0 100644 --- a/packages/core/src/compiler/config/_test_/validate-output-dist.spec.ts +++ b/packages/core/src/compiler/config/_test_/validate-output-dist.spec.ts @@ -41,6 +41,7 @@ describe('validateDistOutputTarget', () => { isPrimaryPackageOutputTarget: false, skipInDev: true, }, + { esmDir: join(rootDir, 'my-dist', 'my-build', 'testing'), empty: false, @@ -57,40 +58,6 @@ describe('validateDistOutputTarget', () => { file: join(rootDir, 'my-dist', 'my-build', 'testing', 'testing.css'), type: 'dist-global-styles', }, - { - dir: join(rootDir, 'my-dist'), - type: 'dist-types', - typesDir: join(rootDir, 'my-dist', 'types'), - }, - { - collectionDir: join(rootDir, 'my-dist', 'collection'), - dir: join(rootDir, '/my-dist'), - empty: false, - transformAliasedImportPaths: true, - type: 'dist-collection', - }, - { - copy: [{ src: '**/*.svg' }, { src: '**/*.js' }], - copyAssets: 'collection', - dir: join(rootDir, 'my-dist', 'collection'), - type: 'copy', - }, - { - type: 'dist-lazy', - cjsDir: join(rootDir, 'my-dist', 'cjs'), - cjsIndexFile: join(rootDir, 'my-dist', 'index.cjs.js'), - empty: false, - esmDir: join(rootDir, 'my-dist', 'esm'), - esmIndexFile: join(rootDir, 'my-dist', 'index.js'), - }, - { - cjsDir: join(rootDir, 'my-dist', 'cjs'), - componentDts: join(rootDir, 'my-dist', 'types', 'components.d.ts'), - dir: join(rootDir, 'my-dist', 'loader'), - empty: false, - esmDir: join(rootDir, 'my-dist', 'esm'), - type: 'dist-lazy-loader', - }, ]); }); @@ -153,40 +120,6 @@ describe('validateDistOutputTarget', () => { file: join(rootDir, 'my-dist', 'my-build', 'testing', 'testing.css'), type: 'dist-global-styles', }, - { - dir: join(rootDir, 'my-dist'), - type: 'dist-types', - typesDir: join(rootDir, 'my-dist', 'types'), - }, - { - collectionDir: join(rootDir, 'my-dist', 'collection'), - dir: join(rootDir, '/my-dist'), - empty: false, - transformAliasedImportPaths: true, - type: 'dist-collection', - }, - { - copy: [{ src: '**/*.svg' }, { src: '**/*.js' }], - copyAssets: 'collection', - dir: join(rootDir, 'my-dist', 'collection'), - type: 'copy', - }, - { - type: 'dist-lazy', - cjsDir: join(rootDir, 'my-dist', 'cjs'), - cjsIndexFile: join(rootDir, 'my-dist', 'index.cjs.js'), - empty: false, - esmDir: join(rootDir, 'my-dist', 'esm'), - esmIndexFile: join(rootDir, 'my-dist', 'index.js'), - }, - { - cjsDir: join(rootDir, 'my-dist', 'cjs'), - componentDts: join(rootDir, 'my-dist', 'types', 'components.d.ts'), - dir: join(rootDir, 'my-dist', 'loader'), - empty: false, - esmDir: join(rootDir, 'my-dist', 'esm'), - type: 'dist-lazy-loader', - }, ]); }); @@ -233,40 +166,6 @@ describe('validateDistOutputTarget', () => { file: join(rootDir, 'my-dist', 'my-build', 'testing', 'testing.css'), type: 'dist-global-styles', }, - { - dir: join(rootDir, 'my-dist'), - type: 'dist-types', - typesDir: join(rootDir, 'my-dist', 'types'), - }, - { - collectionDir: join(rootDir, 'my-dist', 'collection'), - dir: join(rootDir, '/my-dist'), - empty: false, - transformAliasedImportPaths: true, - type: 'dist-collection', - }, - { - copy: [{ src: '**/*.svg' }, { src: '**/*.js' }], - copyAssets: 'collection', - dir: join(rootDir, 'my-dist', 'collection'), - type: 'copy', - }, - { - type: 'dist-lazy', - cjsDir: join(rootDir, 'my-dist', 'cjs'), - cjsIndexFile: join(rootDir, 'my-dist', 'index.cjs.js'), - empty: false, - esmDir: join(rootDir, 'my-dist', 'esm'), - esmIndexFile: join(rootDir, 'my-dist', 'index.js'), - }, - { - cjsDir: join(rootDir, 'my-dist', 'cjs'), - componentDts: join(rootDir, 'my-dist', 'types', 'components.d.ts'), - dir: join(rootDir, 'my-dist', 'loader'), - empty: false, - esmDir: join(rootDir, 'my-dist', 'esm'), - type: 'dist-lazy-loader', - }, ]); }); }); From baf53a5afc60a1d023f4225912c589eadc34cc03 Mon Sep 17 00:00:00 2001 From: John Jenkins Date: Mon, 13 Apr 2026 19:38:10 +0100 Subject: [PATCH 4/4] chore: --- .../src/compiler/config/_test_/validate-output-dist.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/src/compiler/config/_test_/validate-output-dist.spec.ts b/packages/core/src/compiler/config/_test_/validate-output-dist.spec.ts index fa917ed80c0..34cb77e9241 100644 --- a/packages/core/src/compiler/config/_test_/validate-output-dist.spec.ts +++ b/packages/core/src/compiler/config/_test_/validate-output-dist.spec.ts @@ -41,7 +41,7 @@ describe('validateDistOutputTarget', () => { isPrimaryPackageOutputTarget: false, skipInDev: true, }, - + { esmDir: join(rootDir, 'my-dist', 'my-build', 'testing'), empty: false,