From 82e566768b0953ca342723f977ebdbdb0adf90d4 Mon Sep 17 00:00:00 2001 From: george garama Date: Wed, 13 Mar 2024 17:52:29 +0200 Subject: [PATCH 1/4] add position 0 case + tests --- modules/riseBidAdapter.js | 2 +- test/spec/modules/riseBidAdapter_spec.js | 57 ++++++++++++++++++++++++ 2 files changed, 58 insertions(+), 1 deletion(-) diff --git a/modules/riseBidAdapter.js b/modules/riseBidAdapter.js index 82790805303..6781f7af8e0 100644 --- a/modules/riseBidAdapter.js +++ b/modules/riseBidAdapter.js @@ -316,7 +316,7 @@ function generateBidParameters(bid, bidderRequest) { }; const pos = deepAccess(bid, `mediaTypes.${mediaType}.pos`); - if (pos) { + if (pos || pos === 0) { bidObject.pos = pos; } diff --git a/test/spec/modules/riseBidAdapter_spec.js b/test/spec/modules/riseBidAdapter_spec.js index ec9309fd4ae..c573561393f 100644 --- a/test/spec/modules/riseBidAdapter_spec.js +++ b/test/spec/modules/riseBidAdapter_spec.js @@ -28,6 +28,63 @@ describe('riseAdapter', function () { }); }); + describe('isBidPosition Passed', function () { + let mediaType = BANNER + let bidObject = {}; + const bid = { + bidder: 'rise', + mediaTypes: { + banner: { + pos: 1, + sizes: [ + [ + 300, + 250 + ], + [ + 320, + 480 + ] + ] + } + } + } + function assignPos (bidObject, bid) { + const pos = utils.deepAccess(bid, `mediaTypes.${mediaType}.pos`); + if (pos || pos === 0) { + bidObject.pos = pos; + } + return pos; + } + + it('bidObject should own pos property', function() { + const pos = assignPos(bidObject, bid); + expect(bidObject.pos).to.equal(pos); + }) + it('bidObject should own pos property 0', function() { + bid.mediaTypes.banner.pos = 0; + const pos = assignPos(bidObject, bid); + expect(bidObject.pos).to.equal(pos); + }) + it('bidObject should not own pos property', function() { + bidObject = {}; + bid.mediaTypes.banner = { + sizes: [ + [ + 300, + 250 + ], + [ + 320, + 480 + ] + ] + } + const pos = assignPos(bidObject, bid); + expect(bidObject.pos).to.equal(pos); + }) + }) + describe('isBidRequestValid', function () { const bid = { 'bidder': spec.code, From bc2c7b435fb9adf458dc83d54f22046b008cfc80 Mon Sep 17 00:00:00 2001 From: george garama Date: Sun, 17 Mar 2024 13:58:51 +0200 Subject: [PATCH 2/4] add position 0 case + tests --- test/spec/modules/riseBidAdapter_spec.js | 72 +++++------------------- 1 file changed, 14 insertions(+), 58 deletions(-) diff --git a/test/spec/modules/riseBidAdapter_spec.js b/test/spec/modules/riseBidAdapter_spec.js index c573561393f..0a00c4884c7 100644 --- a/test/spec/modules/riseBidAdapter_spec.js +++ b/test/spec/modules/riseBidAdapter_spec.js @@ -28,63 +28,6 @@ describe('riseAdapter', function () { }); }); - describe('isBidPosition Passed', function () { - let mediaType = BANNER - let bidObject = {}; - const bid = { - bidder: 'rise', - mediaTypes: { - banner: { - pos: 1, - sizes: [ - [ - 300, - 250 - ], - [ - 320, - 480 - ] - ] - } - } - } - function assignPos (bidObject, bid) { - const pos = utils.deepAccess(bid, `mediaTypes.${mediaType}.pos`); - if (pos || pos === 0) { - bidObject.pos = pos; - } - return pos; - } - - it('bidObject should own pos property', function() { - const pos = assignPos(bidObject, bid); - expect(bidObject.pos).to.equal(pos); - }) - it('bidObject should own pos property 0', function() { - bid.mediaTypes.banner.pos = 0; - const pos = assignPos(bidObject, bid); - expect(bidObject.pos).to.equal(pos); - }) - it('bidObject should not own pos property', function() { - bidObject = {}; - bid.mediaTypes.banner = { - sizes: [ - [ - 300, - 250 - ], - [ - 320, - 480 - ] - ] - } - const pos = assignPos(bidObject, bid); - expect(bidObject.pos).to.equal(pos); - }) - }) - describe('isBidRequestValid', function () { const bid = { 'bidder': spec.code, @@ -126,7 +69,8 @@ describe('riseAdapter', function () { 'video': { 'playerSize': [[640, 480]], 'context': 'instream', - 'plcmt': 1 + 'plcmt': 1, + 'pos': 0 } }, 'vastXml': '"..."' @@ -173,6 +117,7 @@ describe('riseAdapter', function () { const api = [1, 2]; const mimes = ['application/javascript', 'video/mp4', 'video/quicktime']; const protocols = [2, 3, 5, 6]; + const pos = 4; it('sends the placementId to ENDPOINT via POST', function () { bidRequests[0].params.placementId = placementId; @@ -501,6 +446,17 @@ describe('riseAdapter', function () { expect(request.data.bids[0].sua).to.not.exist; }); + it('should send right position of the bid', function() { + const bid = utils.deepClone(bidRequests[1]); + const mediaType = bid.mediaTypes && bid.mediaTypes.banner ? BANNER : VIDEO; + bid.mediaTypes[mediaType].pos = pos; + const request = spec.buildRequests([bidRequests[0], bidRequests[1], bid], bidderRequest); + console.log(request.data.bids); + expect(request.data.bids[0].pos).to.equal(0); + expect(request.data.bids[1].pos).to.equal(undefined); + expect(request.data.bids[2].pos).to.equal(pos); + }); + describe('COPPA Param', function() { it('should set coppa equal 0 in bid request if coppa is set to false', function() { const request = spec.buildRequests(bidRequests, bidderRequest); From 8e3779bde31eec6339cbbdcf29703327896a4845 Mon Sep 17 00:00:00 2001 From: george garama Date: Sun, 17 Mar 2024 14:07:03 +0200 Subject: [PATCH 3/4] add position 0 case + tests --- test/spec/modules/riseBidAdapter_spec.js | 1 - 1 file changed, 1 deletion(-) diff --git a/test/spec/modules/riseBidAdapter_spec.js b/test/spec/modules/riseBidAdapter_spec.js index 0a00c4884c7..9b12855eadf 100644 --- a/test/spec/modules/riseBidAdapter_spec.js +++ b/test/spec/modules/riseBidAdapter_spec.js @@ -451,7 +451,6 @@ describe('riseAdapter', function () { const mediaType = bid.mediaTypes && bid.mediaTypes.banner ? BANNER : VIDEO; bid.mediaTypes[mediaType].pos = pos; const request = spec.buildRequests([bidRequests[0], bidRequests[1], bid], bidderRequest); - console.log(request.data.bids); expect(request.data.bids[0].pos).to.equal(0); expect(request.data.bids[1].pos).to.equal(undefined); expect(request.data.bids[2].pos).to.equal(pos); From 4605e4189d9228887813fa20373a7d7207a9127f Mon Sep 17 00:00:00 2001 From: george garama Date: Sun, 7 Apr 2024 18:34:13 +0300 Subject: [PATCH 4/4] remove unnecessary logic --- test/spec/modules/riseBidAdapter_spec.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/spec/modules/riseBidAdapter_spec.js b/test/spec/modules/riseBidAdapter_spec.js index 9b12855eadf..2687b6f1400 100644 --- a/test/spec/modules/riseBidAdapter_spec.js +++ b/test/spec/modules/riseBidAdapter_spec.js @@ -448,8 +448,7 @@ describe('riseAdapter', function () { it('should send right position of the bid', function() { const bid = utils.deepClone(bidRequests[1]); - const mediaType = bid.mediaTypes && bid.mediaTypes.banner ? BANNER : VIDEO; - bid.mediaTypes[mediaType].pos = pos; + bid.mediaTypes.banner.pos = pos; const request = spec.buildRequests([bidRequests[0], bidRequests[1], bid], bidderRequest); expect(request.data.bids[0].pos).to.equal(0); expect(request.data.bids[1].pos).to.equal(undefined);