diff --git a/.circleci/config.yml b/.circleci/config.yml index a8329c002fe..8eb8b28c570 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -1,111 +1,12 @@ -# Javascript Node CircleCI 2.0 configuration file -# -# Check https://circleci.com/docs/2.0/language-javascript/ for more details -# - -aliases: - - &environment - docker: - # specify the version you desire here - - image: cimg/node:20.14.0 - resource_class: medium - # Specify service dependencies here if necessary - # CircleCI maintains a library of pre-built images - # documented at https://circleci.com/docs/2.0/circleci-images/ - # - image: circleci/mongo:3.4.4 - working_directory: ~/Prebid.js - - - &restore_dep_cache - keys: - - v1-dependencies-{{ checksum "package.json" }} - - - &restore_babel_cache - keys: - - v1-babel-cache-{{ checksum "package.json" }} - - - &save_dep_cache - paths: - - node_modules - key: v1-dependencies-{{ checksum "package.json" }} - - - &save_babel_cache - paths: - - .cache - key: v1-babel-cache-{{ checksum "package.json" }} - - - &install - name: Install gulp cli - command: sudo npm install -g gulp-cli - - - &run_unit_test - name: BrowserStack testing - command: gulp test --browserstack --nolintfix --nolint - - - &run_endtoend_test - name: BrowserStack End to end testing - command: gulp e2e-test - - - &unit_test_steps - - checkout - - restore_cache: *restore_dep_cache - - restore_cache: *restore_babel_cache - - run: npm ci - - save_cache: *save_dep_cache - - save_cache: *save_babel_cache - - run: *install - - run: *run_unit_test - - - &endtoend_test_steps - - checkout - - restore_cache: *restore_dep_cache - - restore_cache: *restore_babel_cache - - run: npm install - - save_cache: *save_dep_cache - - save_cache: *save_babel_cache - - run: *install - - run: *run_endtoend_test - -version: 2 +version: 2.1 jobs: - build: - <<: *environment - steps: *unit_test_steps - serial-group: "browserstack" - - lint: - <<: *environment + noop: + docker: + - image: cimg/base:stable steps: - - checkout - - restore_cache: *restore_dep_cache - - run: npm ci - - save_cache: *save_dep_cache - - restore_cache: - keys: - - eslint-cache-{{ checksum "package-lock.json" }}-{{ checksum "eslint.config.js" }}-{{ checksum ".gitignore" }} - - run: - name: 'Run ESLint' - command: echo 'linting ...' && npx eslint --cache --cache-strategy content - - save_cache: - key: eslint-cache-{{ checksum "package-lock.json" }}-{{ checksum "eslint.config.js" }}-{{ checksum ".gitignore" }} - paths: - - .eslintcache - - e2etest: - <<: *environment - steps: *endtoend_test_steps - serial-group: "browserstack" - + - run: echo "CircleCI build skipped - using GitHub Actions. This job can be removed once 9.x is no longer supported." workflows: version: 2 - commit: + default: jobs: - - lint - - build: - requires: - - lint - - e2etest: - requires: - - build - -experimental: - pipelines: true + - noop diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 7fc6f7e57fa..df503e367e1 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -17,15 +17,41 @@ jobs: name: "Check out source and install dependencies" timeout-minutes: 2 runs-on: ubuntu-latest + outputs: + ref: ${{ steps.info.outputs.ref }} + commit: ${{ steps.info.outputs.commit }} + branch: ${{ steps.info.outputs.branch }} + fork: ${{ steps.info.outputs.fork }} + base-branch: ${{ steps.info.outputs.base-branch }} + base-commit: ${{ steps.info.outputs.base-commit }} steps: - name: Set up Node.js uses: actions/setup-node@v4 with: node-version: '20' - - name: Checkout code + - name: Checkout code (PR) + id: checkout-pr + if: ${{ github.event_name == 'pull_request_target' }} + uses: actions/checkout@v4 + with: + ref: refs/pull/${{ github.event.pull_request.number }}/head + + - name: Checkout code (push) + id: checkout-push + if: ${{ github.event_name == 'push' }} uses: actions/checkout@v4 + - name: Commit info + id: info + run: | + echo ref="${{ steps.checkout-pr.outputs.ref || steps.checkout-push.outputs.ref }}" >> $GITHUB_OUTPUT + echo commit="${{ steps.checkout-pr.outputs.commit || steps.checkout-push.outputs.commit }}" >> $GITHUB_OUTPUT + echo branch="${{ github.head_ref || github.ref }}" >> $GITHUB_OUTPUT + echo fork="${{ (github.event.pull_request && github.event.pull_request.head.repo.owner.login != github.repository_owner) && github.event.pull_request.head.repo.owner.login || null }}" >> $GITHUB_OUTPUT + echo base-branch="${{ github.event.pull_request.base.ref || github.ref }}" >> $GITHUB_OUTPUT + echo base-commit="${{ github.event.pull_request.base.sha || github.event.before }}" >> $GITHUB_OUTPUT + - name: Install dependencies run: npm ci @@ -51,7 +77,8 @@ jobs: key: source-${{ github.run_id }} fail-on-cache-miss: true - name: lint - run: npx eslint + run: | + npx eslint test-no-features: name: "Unit tests (all features disabled)" @@ -106,7 +133,7 @@ jobs: coveralls: name: Update coveralls - needs: test + needs: [checkout, test] runs-on: ubuntu-latest steps: - name: Restore working directory @@ -117,3 +144,8 @@ jobs: fail-on-cache-miss: true - name: Coveralls uses: coverallsapp/github-action@v2 + with: + git-branch: ${{ needs.checkout.outputs.fork && format('{0}:{1}', needs.checkout.outputs.fork, needs.checkout.outputs.branch) || needs.checkout.outputs.branch }} + git-commit: ${{ needs.checkout.outputs.commit }} + compare-ref: ${{ needs.checkout.outputs.base-branch }} + compare-sha: ${{ needs.checkout.outputs.base-commit }} diff --git a/PR_REVIEW.md b/PR_REVIEW.md index 08505197b07..94fe06c0f0c 100644 --- a/PR_REVIEW.md +++ b/PR_REVIEW.md @@ -23,7 +23,7 @@ General gulp commands include separate commands for serving the codebase on a bu - Checkout the branch (these instructions are available on the GitHub PR page as well). - Verify PR is a single change type. Example, refactor OR bugfix. If more than 1 type, ask submitter to break out requests. - Verify code under review has at least 80% unit test coverage. If legacy code doesn't have enough unit test coverage, require that additional unit tests to be included in the PR. -- Verify tests are green in circle-ci + local build by running `gulp serve` | `gulp test` +- Verify tests are green in Github Actions + local build by running `gulp serve` | `gulp test` - Verify no code quality violations are present from linting (should be reported in terminal) - Make sure the code is not setting cookies or localstorage directly -- it must use the `StorageManager`. - Review for obvious errors or bad coding practice / use best judgement here. diff --git a/README.md b/README.md index 3e68640d907..ba7735f14d9 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,3 @@ -[![Build Status](https://circleci.com/gh/prebid/Prebid.js.svg?style=svg)](https://circleci.com/gh/prebid/Prebid.js) [![Percentage of issues still open](http://isitmaintained.com/badge/open/prebid/Prebid.js.svg)](https://isitmaintained.com/project/prebid/Prebid.js "Percentage of issues still open") [![Coverage Status](https://coveralls.io/repos/github/prebid/Prebid.js/badge.svg?branch=master)](https://coveralls.io/github/prebid/Prebid.js?branch=master) diff --git a/RELEASE_SCHEDULE.md b/RELEASE_SCHEDULE.md index 016e3e71cfc..283107a6376 100644 --- a/RELEASE_SCHEDULE.md +++ b/RELEASE_SCHEDULE.md @@ -26,7 +26,7 @@ Announcements regarding releases will be made to the #prebid-js channel in prebi ### 2. Make sure all browserstack tests are passing - On PR merge to master, CircleCI will run unit tests on browserstack. Checking the last CircleCI build [here](https://circleci.com/gh/prebid/Prebid.js) for master branch will show you detailed results.** + On PR merge to master, Github Actions will run unit tests on browserstack. Checking the last build for master branch will show you detailed results.** In case of failure do following, - Try to fix the failing tests. diff --git a/eslint.config.js b/eslint.config.js index 490770c951f..08b0e1cdce7 100644 --- a/eslint.config.js +++ b/eslint.config.js @@ -136,7 +136,6 @@ module.exports = [ 'no-empty': 'off', 'no-void': 'off', 'array-callback-return': 'off', - 'import-x/no-named-default': 'off', 'prefer-const': 'off', 'no-prototype-builtins': 'off', 'object-shorthand': 'off', @@ -237,12 +236,8 @@ module.exports = [ 'no-unused-vars': 'off', 'import/extensions': 'off', 'camelcase': 'off', - 'import-x/no-duplicates': 'off', - 'no-loss-of-precision': 'off', - 'no-redeclare': 'off', 'no-global-assign': 'off', - 'default-case-last': 'off', - '@stylistic/no-trailing-spaces': 'error', + 'default-case-last': 'off' } }, { diff --git a/integrationExamples/gpt/x-domain/creative.html b/integrationExamples/gpt/x-domain/creative.html index d98376d92e3..967147b34ba 100644 --- a/integrationExamples/gpt/x-domain/creative.html +++ b/integrationExamples/gpt/x-domain/creative.html @@ -2,7 +2,7 @@ // creative will be rendered, e.g. GAM delivering a SafeFrame // this code is autogenerated, also available in 'build/creative/creative.js' - + ` diff --git a/modules/adhashBidAdapter.js b/modules/adhashBidAdapter.js index 9982621eafd..51daba683a8 100644 --- a/modules/adhashBidAdapter.js +++ b/modules/adhashBidAdapter.js @@ -268,14 +268,14 @@ export const spec = { if (storage.localStorageIsEnabled()) { const prefix = request.bidRequest.params.prefix || 'adHash'; - let recentAdsPrebid = JSON.parse(storage.getDataFromLocalStorage(prefix + 'recentAdsPrebid') || '[]'); + const recentAdsPrebid = JSON.parse(storage.getDataFromLocalStorage(prefix + 'recentAdsPrebid') || '[]'); recentAdsPrebid.push([ (new Date().getTime() / 1000) | 0, responseBody.creatives[0].advertiserId, responseBody.creatives[0].budgetId, responseBody.creatives[0].expectedHashes.length ? responseBody.creatives[0].expectedHashes[0] : '', ]); - let recentAdsPrebidFinal = JSON.stringify(recentAdsPrebid.slice(-100)); + const recentAdsPrebidFinal = JSON.stringify(recentAdsPrebid.slice(-100)); storage.setDataInLocalStorage(prefix + 'recentAdsPrebid', recentAdsPrebidFinal); } diff --git a/modules/adkernelAdnAnalyticsAdapter.js b/modules/adkernelAdnAnalyticsAdapter.js index c4a612ce95a..f7cfecbf76c 100644 --- a/modules/adkernelAdnAnalyticsAdapter.js +++ b/modules/adkernelAdnAnalyticsAdapter.js @@ -43,7 +43,7 @@ function buildRequestTemplate(pubId) { } } -let analyticsAdapter = Object.assign(adapter({analyticsType: 'endpoint'}), +const analyticsAdapter = Object.assign(adapter({analyticsType: 'endpoint'}), { track({eventType, args}) { if (!analyticsAdapter.context) { @@ -75,7 +75,7 @@ let analyticsAdapter = Object.assign(adapter({analyticsType: 'endpoint'}), break; } if (handler) { - let events = handler(args); + const events = handler(args); if (analyticsAdapter.context.queue) { analyticsAdapter.context.queue.push(events); } @@ -113,9 +113,9 @@ adapterManager.registerAnalyticsAdapter({ export default analyticsAdapter; function sendAll() { - let events = analyticsAdapter.context.queue.popAll(); + const events = analyticsAdapter.context.queue.popAll(); if (events.length !== 0) { - let req = Object.assign({}, analyticsAdapter.context.requestTemplate, {hb_ev: events}); + const req = Object.assign({}, analyticsAdapter.context.requestTemplate, {hb_ev: events}); analyticsAdapter.ajaxCall(JSON.stringify(req)); } } @@ -158,7 +158,7 @@ function trackBidTimeout(args) { } function createHbEvent(adapter, event, tagid = undefined, value = 0, time = 0) { - let ev = {event: event}; + const ev = {event: event}; if (adapter) { ev.adapter = adapter } @@ -181,7 +181,7 @@ const DIRECT = '(direct)'; const REFERRAL = '(referral)'; const ORGANIC = '(organic)'; -export let storage = { +export const storage = { getItem: (name) => { return storageObj.getDataFromLocalStorage(name); }, @@ -191,16 +191,16 @@ export let storage = { }; export function getUmtSource(pageUrl, referrer) { - let prevUtm = getPreviousTrafficSource(); - let currUtm = getCurrentTrafficSource(pageUrl, referrer); - let [updated, actual] = chooseActualUtm(prevUtm, currUtm); + const prevUtm = getPreviousTrafficSource(); + const currUtm = getCurrentTrafficSource(pageUrl, referrer); + const [updated, actual] = chooseActualUtm(prevUtm, currUtm); if (updated) { storeUtm(actual); } return actual; function getPreviousTrafficSource() { - let val = storage.getItem(ADKERNEL_PREBID_KEY); + const val = storage.getItem(ADKERNEL_PREBID_KEY); if (!val) { return getDirect(); } @@ -213,12 +213,12 @@ export function getUmtSource(pageUrl, referrer) { return source; } if (referrer) { - let se = getSearchEngine(referrer); + const se = getSearchEngine(referrer); if (se) { return asUtm(se, ORGANIC, ORGANIC); } - let parsedUrl = parseUrl(pageUrl); - let [refHost, refPath] = getReferrer(referrer); + const parsedUrl = parseUrl(pageUrl); + const [refHost, refPath] = getReferrer(referrer); if (refHost && refHost !== parsedUrl.hostname) { return asUtm(refHost, REFERRAL, REFERRAL, '', refPath); } @@ -227,7 +227,7 @@ export function getUmtSource(pageUrl, referrer) { } function getSearchEngine(pageUrl) { - let engines = { + const engines = { 'google': /^https?\:\/\/(?:www\.)?(?:google\.(?:com?\.)?(?:com|cat|[a-z]{2})|g.cn)\//i, 'yandex': /^https?\:\/\/(?:www\.)?ya(?:ndex\.(?:com|net)?\.?(?:asia|mobi|org|[a-z]{2})?|\.ru)\//i, 'bing': /^https?\:\/\/(?:www\.)?bing\.com\//i, @@ -236,7 +236,7 @@ export function getUmtSource(pageUrl, referrer) { 'yahoo': /^https?\:\/\/(?:[-a-z]+\.)?(?:search\.)?yahoo\.com\//i }; - for (let engine in engines) { + for (const engine in engines) { if (engines.hasOwnProperty(engine) && engines[engine].test(pageUrl)) { return engine; } @@ -244,18 +244,18 @@ export function getUmtSource(pageUrl, referrer) { } function getReferrer(referrer) { - let ref = parseUrl(referrer); + const ref = parseUrl(referrer); return [ref.hostname, ref.pathname]; } function getUTM(pageUrl) { - let urlParameters = parseUrl(pageUrl).search; + const urlParameters = parseUrl(pageUrl).search; if (!urlParameters['utm_campaign'] || !urlParameters['utm_source']) { return; } - let utmArgs = []; + const utmArgs = []; _each(UTM_TAGS, (utmTagName) => { - let utmValue = urlParameters[utmTagName] || ''; + const utmValue = urlParameters[utmTagName] || ''; utmArgs.push(utmValue); }); return asUtm.apply(this, utmArgs); @@ -266,12 +266,12 @@ export function getUmtSource(pageUrl, referrer) { } function storeUtm(utm) { - let val = JSON.stringify(utm); + const val = JSON.stringify(utm); storage.setItem(ADKERNEL_PREBID_KEY, val); } function asUtm(source, medium, campaign, term = '', content = '', c1 = '', c2 = '', c3 = '', c4 = '', c5 = '') { - let result = { + const result = { source: source, medium: medium, campaign: campaign @@ -355,7 +355,7 @@ export function ExpiringQueue(callback, ttl) { }; this.popAll = () => { - let result = queue; + const result = queue; queue = []; reset(); return result; @@ -400,7 +400,7 @@ function getLocationAndReferrer(win) { } function initPrivacy(template, requests) { - let consent = requests[0].gdprConsent; + const consent = requests[0].gdprConsent; if (consent && consent.gdprApplies) { template.user.gdpr = ~~consent.gdprApplies; } diff --git a/modules/adkernelAdnBidAdapter.js b/modules/adkernelAdnBidAdapter.js index ae5528f2aeb..d7053120ae6 100644 --- a/modules/adkernelAdnBidAdapter.js +++ b/modules/adkernelAdnBidAdapter.js @@ -15,21 +15,21 @@ function isRtbDebugEnabled(refInfo) { } function buildImp(bidRequest) { - let imp = { + const imp = { id: bidRequest.bidId, tagid: bidRequest.adUnitCode }; let mediaType; - let bannerReq = deepAccess(bidRequest, `mediaTypes.banner`); - let videoReq = deepAccess(bidRequest, `mediaTypes.video`); + const bannerReq = deepAccess(bidRequest, `mediaTypes.banner`); + const videoReq = deepAccess(bidRequest, `mediaTypes.video`); if (bannerReq) { - let sizes = canonicalizeSizesArray(bannerReq.sizes); + const sizes = canonicalizeSizesArray(bannerReq.sizes); imp.banner = { format: parseSizesInput(sizes) }; mediaType = BANNER; } else if (videoReq) { - let size = canonicalizeSizesArray(videoReq.playerSize)[0]; + const size = canonicalizeSizesArray(videoReq.playerSize)[0]; imp.video = { w: size[0], h: size[1], @@ -39,7 +39,7 @@ function buildImp(bidRequest) { }; mediaType = VIDEO; } - let bidFloor = getBidFloor(bidRequest, mediaType, '*'); + const bidFloor = getBidFloor(bidRequest, mediaType, '*'); if (bidFloor) { imp.bidfloor = bidFloor; } @@ -59,8 +59,8 @@ function canonicalizeSizesArray(sizes) { } function buildRequestParams(tags, bidderRequest) { - let {gdprConsent, uspConsent, refererInfo, ortb2} = bidderRequest; - let req = { + const {gdprConsent, uspConsent, refererInfo, ortb2} = bidderRequest; + const req = { id: bidderRequest.bidderRequestId, // TODO: root-level `tid` is not ORTB; is this intentional? tid: ortb2?.source?.tid, @@ -90,7 +90,7 @@ function buildSite(refInfo) { secure: ~~(refInfo.page && refInfo.page.startsWith('https')), ref: refInfo.ref } - let keywords = document.getElementsByTagName('meta')['keywords']; + const keywords = document.getElementsByTagName('meta')['keywords']; if (keywords && keywords.content) { result.keywords = keywords.content; } @@ -98,7 +98,7 @@ function buildSite(refInfo) { } function buildBid(tag) { - let bid = { + const bid = { requestId: tag.impid, cpm: tag.bid, creativeId: tag.crid, @@ -159,21 +159,21 @@ export const spec = { }, buildRequests: function(bidRequests, bidderRequest) { - let dispatch = bidRequests.map(buildImp) + const dispatch = bidRequests.map(buildImp) .reduce((acc, curr, index) => { - let bidRequest = bidRequests[index]; - let pubId = bidRequest.params.pubId; - let host = bidRequest.params.host || DEFAULT_ADKERNEL_DSP_DOMAIN; + const bidRequest = bidRequests[index]; + const pubId = bidRequest.params.pubId; + const host = bidRequest.params.host || DEFAULT_ADKERNEL_DSP_DOMAIN; acc[host] = acc[host] || {}; acc[host][pubId] = acc[host][pubId] || []; acc[host][pubId].push(curr); return acc; }, {}); - let requests = []; + const requests = []; Object.keys(dispatch).forEach(host => { Object.keys(dispatch[host]).forEach(pubId => { - let request = buildRequestParams(dispatch[host][pubId], bidderRequest); + const request = buildRequestParams(dispatch[host][pubId], bidderRequest); requests.push({ method: 'POST', url: `https://${host}/tag?account=${pubId}&pb=1${isRtbDebugEnabled(bidderRequest.refererInfo) ? '&debug=1' : ''}`, @@ -185,7 +185,7 @@ export const spec = { }, interpretResponse: function(serverResponse) { - let response = serverResponse.body; + const response = serverResponse.body; if (!response.tags) { return []; } diff --git a/modules/adkernelBidAdapter.js b/modules/adkernelBidAdapter.js index b7f61dcbbdb..6dda6cc6bd9 100644 --- a/modules/adkernelBidAdapter.js +++ b/modules/adkernelBidAdapter.js @@ -131,11 +131,11 @@ export const spec = { * @returns {ServerRequest[]} */ buildRequests: function (bidRequests, bidderRequest) { - let impGroups = groupImpressionsByHostZone(bidRequests, bidderRequest.refererInfo); - let requests = []; - let schain = bidRequests[0]?.ortb2?.source?.ext?.schain; + const impGroups = groupImpressionsByHostZone(bidRequests, bidderRequest.refererInfo); + const requests = []; + const schain = bidRequests[0]?.ortb2?.source?.ext?.schain; _each(impGroups, impGroup => { - let {host, zoneId, imps} = impGroup; + const {host, zoneId, imps} = impGroup; const request = buildRtbRequest(imps, bidderRequest, schain); requests.push({ method: 'POST', @@ -153,19 +153,19 @@ export const spec = { * @returns {Bid[]} */ interpretResponse: function (serverResponse, serverRequest) { - let response = serverResponse.body; + const response = serverResponse.body; if (!response.seatbid) { return []; } - let rtbRequest = JSON.parse(serverRequest.data); - let rtbBids = response.seatbid + const rtbRequest = JSON.parse(serverRequest.data); + const rtbBids = response.seatbid .map(seatbid => seatbid.bid) .reduce((a, b) => a.concat(b), []); return rtbBids.map(rtbBid => { - let imp = ((rtbRequest.imp) || []).find(imp => imp.id === rtbBid.impid); - let prBid = { + const imp = ((rtbRequest.imp) || []).find(imp => imp.id === rtbBid.impid); + const prBid = { requestId: rtbBid.impid, cpm: rtbBid.price, creativeId: rtbBid.crid, @@ -259,13 +259,13 @@ registerBidder(spec); * @param refererInfo {refererInfo} */ function groupImpressionsByHostZone(bidRequests, refererInfo) { - let secure = (refererInfo && refererInfo.page?.indexOf('https:') === 0); + const secure = (refererInfo && refererInfo.page?.indexOf('https:') === 0); return Object.values( bidRequests.map(bidRequest => buildImps(bidRequest, secure)) .reduce((acc, curr, index) => { - let bidRequest = bidRequests[index]; - let {zoneId, host} = bidRequest.params; - let key = `${host}_${zoneId}`; + const bidRequest = bidRequests[index]; + const {zoneId, host} = bidRequest.params; + const key = `${host}_${zoneId}`; acc[key] = acc[key] || {host: host, zoneId: zoneId, imps: []}; acc[key].imps.push(...curr); return acc; @@ -279,7 +279,7 @@ function groupImpressionsByHostZone(bidRequests, refererInfo) { * @param secure {boolean} */ function buildImps(bidRequest, secure) { - let imp = { + const imp = { 'id': bidRequest.bidId, 'tagid': bidRequest.adUnitCode }; @@ -287,9 +287,9 @@ function buildImps(bidRequest, secure) { imp.secure = bidRequest.ortb2Imp?.secure ?? 1; } var sizes = []; - let mediaTypes = bidRequest.mediaTypes; - let isMultiformat = (~~!!mediaTypes?.banner + ~~!!mediaTypes?.video + ~~!!mediaTypes?.native) > 1; - let result = []; + const mediaTypes = bidRequest.mediaTypes; + const isMultiformat = (~~!!mediaTypes?.banner + ~~!!mediaTypes?.video + ~~!!mediaTypes?.native) > 1; + const result = []; let typedImp; if (mediaTypes?.banner) { @@ -300,7 +300,7 @@ function buildImps(bidRequest, secure) { typedImp = imp; } sizes = getAdUnitSizes(bidRequest); - let pbBanner = mediaTypes.banner; + const pbBanner = mediaTypes.banner; typedImp.banner = { ...getDefinedParamsOrEmpty(bidRequest.ortb2Imp, BANNER_FPD), ...getDefinedParamsOrEmpty(pbBanner, BANNER_PARAMS), @@ -318,7 +318,7 @@ function buildImps(bidRequest, secure) { } else { typedImp = imp; } - let pbVideo = mediaTypes.video; + const pbVideo = mediaTypes.video; typedImp.video = { ...getDefinedParamsOrEmpty(bidRequest.ortb2Imp, VIDEO_FPD), ...getDefinedParamsOrEmpty(pbVideo, VIDEO_PARAMS) @@ -352,7 +352,7 @@ function buildImps(bidRequest, secure) { } function initImpBidfloor(imp, bid, sizes, mediaType) { - let bidfloor = getBidFloor(bid, mediaType, sizes); + const bidfloor = getBidFloor(bid, mediaType, sizes); if (bidfloor) { imp.bidfloor = bidfloor; } @@ -375,8 +375,8 @@ function isSyncMethodAllowed(syncRule, bidderCode) { if (!syncRule) { return false; } - let bidders = isArray(syncRule.bidders) ? syncRule.bidders : [bidderCode]; - let rule = syncRule.filter === 'include'; + const bidders = isArray(syncRule.bidders) ? syncRule.bidders : [bidderCode]; + const rule = syncRule.filter === 'include'; return contains(bidders, bidderCode) === rule; } @@ -389,7 +389,7 @@ function getAllowedSyncMethod(bidderCode) { if (!config.getConfig('userSync.syncEnabled')) { return; } - let filterConfig = config.getConfig('userSync.filterSettings'); + const filterConfig = config.getConfig('userSync.filterSettings'); if (isSyncMethodAllowed(filterConfig.all, bidderCode) || isSyncMethodAllowed(filterConfig.iframe, bidderCode)) { return SYNC_IFRAME; } else if (isSyncMethodAllowed(filterConfig.image, bidderCode)) { @@ -403,7 +403,7 @@ function getAllowedSyncMethod(bidderCode) { * @returns {{device: Object}} */ function makeDevice(fpd) { - let device = mergeDeep({ + const device = mergeDeep({ 'ip': 'caller', 'ipv6': 'caller', 'ua': 'caller', @@ -423,8 +423,8 @@ function makeDevice(fpd) { * @returns {{site: Object}|{app: Object}} */ function makeSiteOrApp(bidderRequest, fpd) { - let {refererInfo} = bidderRequest; - let appConfig = config.getConfig('app'); + const {refererInfo} = bidderRequest; + const appConfig = config.getConfig('app'); if (isEmpty(appConfig)) { return {site: createSite(refererInfo, fpd)} } else { @@ -439,12 +439,12 @@ function makeSiteOrApp(bidderRequest, fpd) { * @returns {{user: Object} | undefined} */ function makeUser(bidderRequest, fpd) { - let {gdprConsent} = bidderRequest; - let user = fpd.user || {}; + const {gdprConsent} = bidderRequest; + const user = fpd.user || {}; if (gdprConsent && gdprConsent.consentString !== undefined) { deepSetValue(user, 'ext.consent', gdprConsent.consentString); } - let eids = getExtendedUserIds(bidderRequest); + const eids = getExtendedUserIds(bidderRequest); if (eids) { deepSetValue(user, 'ext.eids', eids); } @@ -459,8 +459,8 @@ function makeUser(bidderRequest, fpd) { * @returns {{regs: Object} | undefined} */ function makeRegulations(bidderRequest) { - let {gdprConsent, uspConsent, gppConsent} = bidderRequest; - let regs = {}; + const {gdprConsent, uspConsent, gppConsent} = bidderRequest; + const regs = {}; if (gdprConsent) { if (gdprConsent.gdprApplies !== undefined) { deepSetValue(regs, 'regs.ext.gdpr', ~~gdprConsent.gdprApplies); @@ -489,7 +489,7 @@ function makeRegulations(bidderRequest) { * @returns */ function makeBaseRequest(bidderRequest, imps, fpd) { - let request = { + const request = { 'id': bidderRequest.bidderRequestId, 'imp': imps, 'at': 1, @@ -509,10 +509,10 @@ function makeBaseRequest(bidderRequest, imps, fpd) { * @param bidderRequest {BidderRequest} */ function makeSyncInfo(bidderRequest) { - let {bidderCode} = bidderRequest; - let syncMethod = getAllowedSyncMethod(bidderCode); + const {bidderCode} = bidderRequest; + const syncMethod = getAllowedSyncMethod(bidderCode); if (syncMethod) { - let res = {}; + const res = {}; deepSetValue(res, 'ext.adk_usersync', syncMethod); return res; } @@ -526,9 +526,9 @@ function makeSyncInfo(bidderRequest) { * @return {Object} Complete rtb request */ function buildRtbRequest(imps, bidderRequest, schain) { - let fpd = bidderRequest.ortb2 || {}; + const fpd = bidderRequest.ortb2 || {}; - let req = mergeDeep( + const req = mergeDeep( makeBaseRequest(bidderRequest, imps, fpd), makeDevice(fpd), makeSiteOrApp(bidderRequest, fpd), @@ -555,7 +555,7 @@ function getLanguage() { * Creates site description object */ function createSite(refInfo, fpd) { - let site = { + const site = { 'domain': refInfo.domain, 'page': refInfo.page }; @@ -569,7 +569,7 @@ function createSite(refInfo, fpd) { } function getExtendedUserIds(bidderRequest) { - let eids = deepAccess(bidderRequest, 'bids.0.userIdAsEids'); + const eids = deepAccess(bidderRequest, 'bids.0.userIdAsEids'); if (isArray(eids)) { return eids; } diff --git a/modules/adlooxAnalyticsAdapter.js b/modules/adlooxAnalyticsAdapter.js index 8a505d51016..123da0f96d6 100644 --- a/modules/adlooxAnalyticsAdapter.js +++ b/modules/adlooxAnalyticsAdapter.js @@ -80,7 +80,7 @@ const PARAMS_DEFAULT = { 'id11': '$ADLOOX_WEBSITE' }; -let analyticsAdapter = Object.assign(adapter({ analyticsType: 'endpoint' }), { +const analyticsAdapter = Object.assign(adapter({ analyticsType: 'endpoint' }), { track({ eventType, args }) { if (!analyticsAdapter[`handle_${eventType}`]) return; diff --git a/modules/admaticBidAdapter.js b/modules/admaticBidAdapter.js index eae365d4383..107e9be6b7a 100644 --- a/modules/admaticBidAdapter.js +++ b/modules/admaticBidAdapter.js @@ -373,13 +373,13 @@ function getSizes(bid) { } function concatSizes(bid) { - let playerSize = deepAccess(bid, 'mediaTypes.video.playerSize'); - let videoSizes = deepAccess(bid, 'mediaTypes.video.sizes'); - let nativeSizes = deepAccess(bid, 'mediaTypes.native.sizes'); - let bannerSizes = deepAccess(bid, 'mediaTypes.banner.sizes'); + const playerSize = deepAccess(bid, 'mediaTypes.video.playerSize'); + const videoSizes = deepAccess(bid, 'mediaTypes.video.sizes'); + const nativeSizes = deepAccess(bid, 'mediaTypes.native.sizes'); + const bannerSizes = deepAccess(bid, 'mediaTypes.banner.sizes'); if (isArray(bannerSizes) || isArray(playerSize) || isArray(videoSizes)) { - let mediaTypesSizes = [bannerSizes, videoSizes, nativeSizes, playerSize]; + const mediaTypesSizes = [bannerSizes, videoSizes, nativeSizes, playerSize]; return mediaTypesSizes .reduce(function (acc, currSize) { if (isArray(currSize)) { diff --git a/modules/admediaBidAdapter.js b/modules/admediaBidAdapter.js index 5ea3e27b0d9..e1cdbb86567 100644 --- a/modules/admediaBidAdapter.js +++ b/modules/admediaBidAdapter.js @@ -43,7 +43,7 @@ export const spec = { var tagData = []; for (var i = 0, j = sizes.length; i < j; i++) { - let tag = {}; + const tag = {}; tag.sizes = []; tag.id = bidRequest.params.placementId; tag.aid = bidRequest.params.aid; diff --git a/modules/admixerBidAdapter.js b/modules/admixerBidAdapter.js index 92631a0fca6..b07e5b92d47 100644 --- a/modules/admixerBidAdapter.js +++ b/modules/admixerBidAdapter.js @@ -73,17 +73,17 @@ export const spec = { } } validRequest.forEach((bid) => { - let imp = {}; + const imp = {}; Object.keys(bid).forEach(key => imp[key] = bid[key]); imp.ortb2 && delete imp.ortb2; - let bidFloor = getBidFloor(bid); + const bidFloor = getBidFloor(bid); if (bidFloor) { imp.bidFloor = bidFloor; } payload.imps.push(imp); }); - let urlForRequest = endpointUrl || getEndpointUrl(bidderRequest.bidderCode) + const urlForRequest = endpointUrl || getEndpointUrl(bidderRequest.bidderCode) return { method: 'POST', url: urlForRequest, diff --git a/modules/adnowBidAdapter.js b/modules/adnowBidAdapter.js index 579afa89be8..23b65a783e2 100644 --- a/modules/adnowBidAdapter.js +++ b/modules/adnowBidAdapter.js @@ -77,7 +77,7 @@ export const spec = { } else { data.width = data.height = 200; - let sizes = deepAccess(req, 'mediaTypes.native.image.sizes', []); + const sizes = deepAccess(req, 'mediaTypes.native.image.sizes', []); if (sizes.length > 0) { const size = Array.isArray(sizes[0]) ? sizes[0] : sizes; @@ -108,7 +108,7 @@ export const spec = { */ interpretResponse(response, request) { const bidObj = request.bidRequest; - let bid = response.body; + const bid = response.body; if (!bid || !bid.currency || !bid.cpm) { return []; diff --git a/modules/adnuntiusAnalyticsAdapter.js b/modules/adnuntiusAnalyticsAdapter.js index c5913e94ad0..6de06332e3e 100644 --- a/modules/adnuntiusAnalyticsAdapter.js +++ b/modules/adnuntiusAnalyticsAdapter.js @@ -91,7 +91,7 @@ const adnAnalyticsAdapter = Object.assign(adapter({url: '', analyticsType: 'endp case EVENTS.BIDDER_DONE: logInfo('ADN_BIDDER_DONE:', args); args.bids.forEach(doneBid => { - let bid = cache.auctions[doneBid.auctionId].bids[doneBid.bidId || doneBid.requestId]; + const bid = cache.auctions[doneBid.auctionId].bids[doneBid.bidId || doneBid.requestId]; if (!bid.ttr) { bid.ttr = time - bid.start; } @@ -183,7 +183,7 @@ function getSentRequests() { const auctionIdPos = getAuctionIdPos(auctionIds, auctionId); Object.keys(cache.auctions[auctionId].bids).forEach(bidId => { - let bid = auction.bids[bidId]; + const bid = auction.bids[bidId]; if (!(bid.sendStatus & REQUEST_SENT)) { bid.sendStatus |= REQUEST_SENT; @@ -210,14 +210,14 @@ function getResponses(gdpr, auctionIds) { Object.keys(cache.auctions).forEach(auctionId => { Object.keys(cache.auctions[auctionId].bids).forEach(bidId => { - let auction = cache.auctions[auctionId]; - let gdprPos = getGdprPos(gdpr, auction); - let auctionIdPos = getAuctionIdPos(auctionIds, auctionId) - let bid = auction.bids[bidId]; + const auction = cache.auctions[auctionId]; + const gdprPos = getGdprPos(gdpr, auction); + const auctionIdPos = getAuctionIdPos(auctionIds, auctionId) + const bid = auction.bids[bidId]; if (bid.readyToSend && !(bid.sendStatus & RESPONSE_SENT) && !bid.timeout) { bid.sendStatus |= RESPONSE_SENT; - let response = getResponseObject(auction, bid, gdprPos, auctionIdPos); + const response = getResponseObject(auction, bid, gdprPos, auctionIdPos); responses.push(response); } @@ -336,7 +336,7 @@ function getTimeouts(gdpr, auctionIds) { if (!(bid.sendStatus & TIMEOUT_SENT) && bid.timeout) { bid.sendStatus |= TIMEOUT_SENT; - let timeout = getResponseObject(auction, bid, gdprPos, auctionIdPos); + const timeout = getResponseObject(auction, bid, gdprPos, auctionIdPos); timeouts.push(timeout); } diff --git a/modules/adnuntiusBidAdapter.js b/modules/adnuntiusBidAdapter.js index 782b1ca5bb7..40e73d62b12 100644 --- a/modules/adnuntiusBidAdapter.js +++ b/modules/adnuntiusBidAdapter.js @@ -211,7 +211,7 @@ const storageTool = (function () { const targetingTool = (function() { const getSegmentsFromOrtb = function(bidderRequest) { const userData = deepAccess(bidderRequest.ortb2 || {}, 'user.data'); - let segments = []; + const segments = []; if (userData && Array.isArray(userData)) { userData.forEach(userdat => { if (userdat.segment) { diff --git a/modules/adpartnerBidAdapter.js b/modules/adpartnerBidAdapter.js index 504809afa87..9ca976aac96 100644 --- a/modules/adpartnerBidAdapter.js +++ b/modules/adpartnerBidAdapter.js @@ -87,7 +87,7 @@ export const spec = { return syncs; } - let appendGdprParams = function (url, gdprParams) { + const appendGdprParams = function (url, gdprParams) { if (gdprParams === null) { return url; } @@ -107,7 +107,7 @@ export const spec = { serverResponses.forEach(resp => { if (resp.body) { Object.keys(resp.body).map(function(key, index) { - let respObject = resp.body[key]; + const respObject = resp.body[key]; if (respObject['syncs'] !== undefined && Array.isArray(respObject.syncs) && respObject.syncs.length > 0) { diff --git a/modules/adplayerproVideoProvider.js b/modules/adplayerproVideoProvider.js index d6097b68e4f..2b4cedebe5e 100644 --- a/modules/adplayerproVideoProvider.js +++ b/modules/adplayerproVideoProvider.js @@ -43,10 +43,10 @@ const setupFailMessage = 'Failed to instantiate the player'; export function AdPlayerProProvider(config, adPlayerPro_, callbackStorage_, utils) { const adPlayerPro = adPlayerPro_; let player = null; - let playerVersion = null; + const playerVersion = null; const playerConfig = config.playerConfig; const divId = config.divId; - let callbackStorage = callbackStorage_; + const callbackStorage = callbackStorage_; let supportedMediaTypes = null; let setupCompleteCallbacks = []; let setupFailedCallbacks = []; @@ -394,7 +394,7 @@ export function callbackStorageFactory() { } function getCallback(eventType, callback) { - let eventHandlers = storage[eventType]; + const eventHandlers = storage[eventType]; if (eventHandlers) { return eventHandlers[callback]; } @@ -406,7 +406,7 @@ export function callbackStorageFactory() { delete storageHandlers[eventType]; return; } - let eventHandlers = storage[eventType]; + const eventHandlers = storage[eventType]; if (eventHandlers) { const eventHandler = eventHandlers[callback]; if (eventHandler) { @@ -440,7 +440,7 @@ export function callbackStorageFactory() { } function addAllCallbacks(functionOnPlayer) { - for (let eventType in storageHandlers) { + for (const eventType in storageHandlers) { storageHandlers[eventType].forEach(handler => functionOnPlayer(eventType, handler)); } } diff --git a/modules/adpod.js b/modules/adpod.js index bbaa63b4e17..4c920ca0bc2 100644 --- a/modules/adpod.js +++ b/modules/adpod.js @@ -44,14 +44,14 @@ const TARGETING_KEY_CACHE_ID = 'hb_cache_id'; let queueTimeDelay = 50; let queueSizeLimit = 5; -let bidCacheRegistry = createBidCacheRegistry(); +const bidCacheRegistry = createBidCacheRegistry(); /** * Create a registry object that stores/manages bids while be held in queue for Prebid Cache. * @returns registry object with defined accessor functions */ function createBidCacheRegistry() { - let registry = {}; + const registry = {}; function setupRegistrySlot(auctionId) { registry[auctionId] = {}; @@ -126,7 +126,7 @@ function createDispatcher(timeoutDuration) { function getPricePartForAdpodKey(bid) { let pricePart - let prioritizeDeals = config.getConfig('adpod.prioritizeDeals'); + const prioritizeDeals = config.getConfig('adpod.prioritizeDeals'); if (prioritizeDeals && deepAccess(bid, 'video.dealTier')) { const adpodDealPrefix = config.getConfig(`adpod.dealTier.${bid.bidderCode}.prefix`); pricePart = (adpodDealPrefix) ? adpodDealPrefix + deepAccess(bid, 'video.dealTier') : deepAccess(bid, 'video.dealTier'); @@ -143,13 +143,13 @@ function getPricePartForAdpodKey(bid) { * @param {Boolean} brandCategoryExclusion value read from setConfig; influences whether category is required or not */ function attachPriceIndustryDurationKeyToBid(bid, brandCategoryExclusion) { - let initialCacheKey = bidCacheRegistry.getInitialCacheKey(bid); - let duration = deepAccess(bid, 'video.durationBucket'); + const initialCacheKey = bidCacheRegistry.getInitialCacheKey(bid); + const duration = deepAccess(bid, 'video.durationBucket'); const pricePart = getPricePartForAdpodKey(bid); let pcd; if (brandCategoryExclusion) { - let category = deepAccess(bid, 'meta.adServerCatId'); + const category = deepAccess(bid, 'meta.adServerCatId'); pcd = `${pricePart}_${category}_${duration}s`; } else { pcd = `${pricePart}_${duration}s`; @@ -172,12 +172,12 @@ function attachPriceIndustryDurationKeyToBid(bid, brandCategoryExclusion) { * @param {Function} afterBidAdded callback function used when Prebid Cache responds */ function updateBidQueue(auctionInstance, bidResponse, afterBidAdded) { - let bidListIter = bidCacheRegistry.getBids(bidResponse); + const bidListIter = bidCacheRegistry.getBids(bidResponse); if (bidListIter) { - let bidListArr = Array.from(bidListIter); - let callDispatcher = bidCacheRegistry.getQueueDispatcher(bidResponse); - let killQueue = !!(auctionInstance.getAuctionStatus() !== AUCTION_IN_PROGRESS); + const bidListArr = Array.from(bidListIter); + const callDispatcher = bidCacheRegistry.getQueueDispatcher(bidResponse); + const killQueue = !!(auctionInstance.getAuctionStatus() !== AUCTION_IN_PROGRESS); callDispatcher(auctionInstance, bidListArr, afterBidAdded, killQueue); } else { logWarn('Attempted to cache a bid from an unknown auction. Bid:', bidResponse); @@ -233,8 +233,8 @@ function firePrebidCacheCall(auctionInstance, bidList, afterBidAdded) { */ export function callPrebidCacheHook(fn, auctionInstance, bidResponse, afterBidAdded, videoConfig) { if (videoConfig && videoConfig.context === ADPOD) { - let brandCategoryExclusion = config.getConfig('adpod.brandCategoryExclusion'); - let adServerCatId = deepAccess(bidResponse, 'meta.adServerCatId'); + const brandCategoryExclusion = config.getConfig('adpod.brandCategoryExclusion'); + const adServerCatId = deepAccess(bidResponse, 'meta.adServerCatId'); if (!adServerCatId && brandCategoryExclusion) { logWarn('Detected a bid without meta.adServerCatId while setConfig({adpod.brandCategoryExclusion}) was enabled. This bid has been rejected:', bidResponse); afterBidAdded(); @@ -267,9 +267,9 @@ export function callPrebidCacheHook(fn, auctionInstance, bidResponse, afterBidAd * @returns {Array[Object]} list of adUnits that passed the check */ export function checkAdUnitSetupHook(fn, adUnits) { - let goodAdUnits = adUnits.filter(adUnit => { - let mediaTypes = deepAccess(adUnit, 'mediaTypes'); - let videoConfig = deepAccess(mediaTypes, 'video'); + const goodAdUnits = adUnits.filter(adUnit => { + const mediaTypes = deepAccess(adUnit, 'mediaTypes'); + const videoConfig = deepAccess(mediaTypes, 'video'); if (videoConfig && videoConfig.context === ADPOD) { // run check to see if other mediaTypes are defined (ie multi-format); reject adUnit if so if (Object.keys(mediaTypes).length > 1) { @@ -279,7 +279,7 @@ export function checkAdUnitSetupHook(fn, adUnits) { let errMsg = `Detected missing or incorrectly setup fields for an adpod adUnit. Please review the following fields of adUnitCode: ${adUnit.code}. This adUnit will be removed from the auction.`; - let playerSize = !!( + const playerSize = !!( ( videoConfig.playerSize && ( isArrayOfNums(videoConfig.playerSize, 2) || ( @@ -288,8 +288,8 @@ export function checkAdUnitSetupHook(fn, adUnits) { ) ) || (videoConfig.sizeConfig) ); - let adPodDurationSec = !!(videoConfig.adPodDurationSec && isNumber(videoConfig.adPodDurationSec) && videoConfig.adPodDurationSec > 0); - let durationRangeSec = !!(videoConfig.durationRangeSec && isArrayOfNums(videoConfig.durationRangeSec) && videoConfig.durationRangeSec.every(range => range > 0)); + const adPodDurationSec = !!(videoConfig.adPodDurationSec && isNumber(videoConfig.adPodDurationSec) && videoConfig.adPodDurationSec > 0); + const durationRangeSec = !!(videoConfig.durationRangeSec && isArrayOfNums(videoConfig.durationRangeSec) && videoConfig.durationRangeSec.every(range => range > 0)); if (!playerSize || !adPodDurationSec || !durationRangeSec) { errMsg += (!playerSize) ? '\nmediaTypes.video.playerSize' : ''; @@ -321,14 +321,14 @@ export function checkAdUnitSetupHook(fn, adUnits) { */ function checkBidDuration(videoMediaType, bidResponse) { const buffer = 2; - let bidDuration = deepAccess(bidResponse, 'video.durationSeconds'); - let adUnitRanges = videoMediaType.durationRangeSec; + const bidDuration = deepAccess(bidResponse, 'video.durationSeconds'); + const adUnitRanges = videoMediaType.durationRangeSec; adUnitRanges.sort((a, b) => a - b); // ensure the ranges are sorted in numeric order if (!videoMediaType.requireExactDuration) { - let max = Math.max(...adUnitRanges); + const max = Math.max(...adUnitRanges); if (bidDuration <= (max + buffer)) { - let nextHighestRange = ((adUnitRanges) || []).find(range => (range + buffer) >= bidDuration); + const nextHighestRange = ((adUnitRanges) || []).find(range => (range + buffer) >= bidDuration); bidResponse.video.durationBucket = nextHighestRange; } else { logWarn(`Detected a bid with a duration value outside the accepted ranges specified in adUnit.mediaTypes.video.durationRangeSec. Rejecting bid: `, bidResponse); @@ -358,7 +358,7 @@ function checkBidDuration(videoMediaType, bidResponse) { export function checkVideoBidSetupHook(fn, bid, adUnit, videoMediaType, context) { if (context === ADPOD) { let result = true; - let brandCategoryExclusion = config.getConfig('adpod.brandCategoryExclusion'); + const brandCategoryExclusion = config.getConfig('adpod.brandCategoryExclusion'); if (brandCategoryExclusion && !deepAccess(bid, 'meta.primaryCatId')) { result = false; } @@ -371,7 +371,7 @@ export function checkVideoBidSetupHook(fn, bid, adUnit, videoMediaType, context) if (!deepAccess(bid, 'video.durationSeconds') || bid.video.durationSeconds <= 0) { result = false; } else { - let isBidGood = checkBidDuration(videoMediaType, bid); + const isBidGood = checkBidDuration(videoMediaType, bid); if (!isBidGood) result = false; } } @@ -439,7 +439,7 @@ export function callPrebidCacheAfterAuction(bids, callback) { if (error) { callback(error, null); } else { - let successfulCachedBids = []; + const successfulCachedBids = []; for (let i = 0; i < cacheIds.length; i++) { if (cacheIds[i] !== '') { successfulCachedBids.push(bids[i]); @@ -485,11 +485,11 @@ export function getTargeting({ codes, callback } = {}) { let bids = getBidsForAdpod(bidsReceived, adPodAdUnits); bids = (competiveExclusionEnabled || deferCachingEnabled) ? getExclusiveBids(bids) : bids; - let prioritizeDeals = config.getConfig('adpod.prioritizeDeals'); + const prioritizeDeals = config.getConfig('adpod.prioritizeDeals'); if (prioritizeDeals) { - let [otherBids, highPriorityDealBids] = bids.reduce((partitions, bid) => { - let bidDealTier = deepAccess(bid, 'video.dealTier'); - let minDealTier = config.getConfig(`adpod.dealTier.${bid.bidderCode}.minDealTier`); + const [otherBids, highPriorityDealBids] = bids.reduce((partitions, bid) => { + const bidDealTier = deepAccess(bid, 'video.dealTier'); + const minDealTier = config.getConfig(`adpod.dealTier.${bid.bidderCode}.minDealTier`); if (minDealTier && bidDealTier) { if (bidDealTier >= minDealTier) { partitions[1].push(bid) @@ -510,10 +510,10 @@ export function getTargeting({ codes, callback } = {}) { bids.sort(sortByPricePerSecond); } - let targeting = {}; + const targeting = {}; if (deferCachingEnabled === false) { adPodAdUnits.forEach((adUnit) => { - let adPodTargeting = []; + const adPodTargeting = []; let adPodDurationSeconds = deepAccess(adUnit, 'mediaTypes.video.adPodDurationSec'); bids @@ -536,7 +536,7 @@ export function getTargeting({ codes, callback } = {}) { callback(null, targeting); } else { - let bidsToCache = []; + const bidsToCache = []; adPodAdUnits.forEach((adUnit) => { let adPodDurationSeconds = deepAccess(adUnit, 'mediaTypes.video.adPodDurationSec'); @@ -554,9 +554,9 @@ export function getTargeting({ codes, callback } = {}) { if (error) { callback(error, null); } else { - let groupedBids = groupBy(bidsSuccessfullyCached, 'adUnitCode'); + const groupedBids = groupBy(bidsSuccessfullyCached, 'adUnitCode'); Object.keys(groupedBids).forEach((adUnitCode) => { - let adPodTargeting = []; + const adPodTargeting = []; groupedBids[adUnitCode].forEach((bid, index, arr) => { adPodTargeting.push({ @@ -616,7 +616,7 @@ function getExclusiveBids(bidsReceived) { let bids = bidsReceived .map((bid) => Object.assign({}, bid, { [TARGETING_KEY_PB_CAT_DUR]: bid.adserverTargeting[TARGETING_KEY_PB_CAT_DUR] })); bids = groupBy(bids, TARGETING_KEY_PB_CAT_DUR); - let filteredBids = []; + const filteredBids = []; Object.keys(bids).forEach((targetingKey) => { bids[targetingKey].sort(compareOn('responseTimestamp')); filteredBids.push(bids[targetingKey][0]); @@ -631,7 +631,7 @@ function getExclusiveBids(bidsReceived) { * @returns {Array[Object]} bids of mediaType adpod */ function getBidsForAdpod(bidsReceived, adPodAdUnits) { - let adUnitCodes = adPodAdUnits.map((adUnit) => adUnit.code); + const adUnitCodes = adPodAdUnits.map((adUnit) => adUnit.code); return bidsReceived .filter((bid) => adUnitCodes.indexOf(bid.adUnitCode) != -1 && (bid.video && bid.video.context === ADPOD)) } @@ -649,7 +649,7 @@ module('adpod', function shareAdpodUtilities(...args) { return; } function addMethods(object, func) { - for (let name in func) { + for (const name in func) { object[name] = func[name]; } } diff --git a/modules/adqueryBidAdapter.js b/modules/adqueryBidAdapter.js index f19cf020ca8..b0770d3e45e 100644 --- a/modules/adqueryBidAdapter.js +++ b/modules/adqueryBidAdapter.js @@ -43,7 +43,7 @@ export const spec = { buildRequests: (bidRequests, bidderRequest) => { const requests = []; - let adqueryRequestUrl = buildUrl({ + const adqueryRequestUrl = buildUrl({ protocol: ADQUERY_BIDDER_DOMAIN_PROTOCOL, hostname: ADQUERY_BIDDER_DOMAIN, pathname: '/prebid/bid', @@ -75,7 +75,7 @@ export const spec = { logMessage(response); const res = response && response.body && response.body.data; - let bidResponses = []; + const bidResponses = []; if (!res) { return []; @@ -113,14 +113,14 @@ export const spec = { return; } logInfo('onTimeout ', timeoutData); - let params = { + const params = { bidder: timeoutData.bidder, bId: timeoutData.bidId, adUnitCode: timeoutData.adUnitCode, timeout: timeoutData.timeout, auctionId: timeoutData.auctionId, }; - let adqueryRequestUrl = buildUrl({ + const adqueryRequestUrl = buildUrl({ protocol: ADQUERY_BIDDER_DOMAIN_PROTOCOL, hostname: ADQUERY_BIDDER_DOMAIN, pathname: '/prebid/eventTimeout', @@ -134,15 +134,15 @@ export const spec = { */ onBidWon: (bid) => { logInfo('onBidWon', bid); - let copyOfBid = { ...bid } + const copyOfBid = { ...bid } delete copyOfBid.ad const shortBidString = JSON.stringify(copyOfBid); const encodedBuf = window.btoa(shortBidString); - let params = { + const params = { q: encodedBuf, }; - let adqueryRequestUrl = buildUrl({ + const adqueryRequestUrl = buildUrl({ protocol: ADQUERY_BIDDER_DOMAIN_PROTOCOL, hostname: ADQUERY_BIDDER_DOMAIN, pathname: '/prebid/eventBidWon', @@ -157,7 +157,7 @@ export const spec = { onSetTargeting: (bid) => { logInfo('onSetTargeting', bid); - let params = { + const params = { bidder: bid.bidder, width: bid.width, height: bid.height, @@ -168,7 +168,7 @@ export const spec = { adUnitCode: bid.adUnitCode }; - let adqueryRequestUrl = buildUrl({ + const adqueryRequestUrl = buildUrl({ protocol: ADQUERY_BIDDER_DOMAIN_PROTOCOL, hostname: ADQUERY_BIDDER_DOMAIN, pathname: '/prebid/eventSetTargeting', @@ -187,7 +187,7 @@ export const spec = { */ getUserSyncs: (syncOptions, serverResponses, gdprConsent, uspConsent) => { logMessage('getUserSyncs', syncOptions, serverResponses, gdprConsent, uspConsent); - let syncData = { + const syncData = { 'gdpr': gdprConsent && gdprConsent.gdprApplies ? 1 : 0, 'gdpr_consent': gdprConsent && gdprConsent.consentString ? gdprConsent.consentString : '', 'ccpa_consent': uspConsent && uspConsent.uspConsent ? uspConsent.uspConsent : '', @@ -197,7 +197,7 @@ export const spec = { syncData.qid = window.qid; } - let syncUrlObject = { + const syncUrlObject = { protocol: ADQUERY_BIDDER_DOMAIN_PROTOCOL, hostname: ADQUERY_USER_SYNC_DOMAIN, pathname: '/prebid/userSync', @@ -223,7 +223,7 @@ export const spec = { }; function buildRequest(validBidRequests, bidderRequest) { - let bid = validBidRequests; + const bid = validBidRequests; logInfo('buildRequest: ', bid); let userId = null; diff --git a/modules/adqueryIdSystem.js b/modules/adqueryIdSystem.js index 43795b3caba..3f324506b45 100644 --- a/modules/adqueryIdSystem.js +++ b/modules/adqueryIdSystem.js @@ -68,7 +68,7 @@ export const adqueryIdSubmodule = { getId(config) { logMessage('adqueryIdSubmodule getId'); - let qid = storage.getDataFromLocalStorage('qid'); + const qid = storage.getDataFromLocalStorage('qid'); if (qid) { return { @@ -110,7 +110,7 @@ export const adqueryIdSubmodule = { } } if (responseObj.qid) { - let myQid = responseObj.qid; + const myQid = responseObj.qid; storage.setDataInLocalStorage('qid', myQid); return callback(myQid); } diff --git a/modules/adrelevantisBidAdapter.js b/modules/adrelevantisBidAdapter.js index f12391b3cf5..d057fa65b93 100644 --- a/modules/adrelevantisBidAdapter.js +++ b/modules/adrelevantisBidAdapter.js @@ -134,7 +134,7 @@ export const spec = { } if (bidderRequest && bidderRequest.refererInfo) { - let refererinfo = { + const refererinfo = { // TODO: this sends everything it finds to the backend, except for canonicalUrl rd_ref: encodeURIComponent(bidderRequest.refererInfo.topmostLocation), rd_top: bidderRequest.refererInfo.reachedTop, @@ -335,7 +335,7 @@ function newBid(serverBid, rtbBid, bidderRequest) { // setting up the jsTracker: // we put it as a data-src attribute so that the tracker isn't called // until we have the adId (see onBidWon) - let jsTrackerDisarmed = rtbBid.viewability.config.replace('src=', 'data-src='); + const jsTrackerDisarmed = rtbBid.viewability.config.replace('src=', 'data-src='); let jsTrackers = nativeAd.javascript_trackers; @@ -417,7 +417,7 @@ function bidToTag(bid) { if (bid.params.position) { tag.position = {'above': 1, 'below': 2}[bid.params.position] || 0; } else { - let mediaTypePos = deepAccess(bid, `mediaTypes.banner.pos`) || deepAccess(bid, `mediaTypes.video.pos`); + const mediaTypePos = deepAccess(bid, `mediaTypes.banner.pos`) || deepAccess(bid, `mediaTypes.video.pos`); // only support unknown, atf, and btf values for position at this time if (mediaTypePos === 0 || mediaTypePos === 1 || mediaTypePos === 3) { // ortb spec treats btf === 3, but our system interprets btf === 2; so converting the ortb value here for consistency @@ -520,7 +520,7 @@ function buildNativeRequest(params) { // convert the sizes of image/icon assets to proper format (if needed) const isImageAsset = !!(requestKey === NATIVE_MAPPING.image.serverName || requestKey === NATIVE_MAPPING.icon.serverName); if (isImageAsset && request[requestKey].sizes) { - let sizes = request[requestKey].sizes; + const sizes = request[requestKey].sizes; if (isArrayOfNums(sizes) || (isArray(sizes) && sizes.length > 0 && sizes.every(sz => isArrayOfNums(sz)))) { request[requestKey].sizes = transformSizes(request[requestKey].sizes); } diff --git a/modules/adrinoBidAdapter.js b/modules/adrinoBidAdapter.js index c8c50f25414..bc3c929cd5a 100644 --- a/modules/adrinoBidAdapter.js +++ b/modules/adrinoBidAdapter.js @@ -31,9 +31,9 @@ export const spec = { // convert Native ORTB definition to old-style prebid native definition validBidRequests = convertOrtbRequestToProprietaryNative(validBidRequests); - let bids = []; + const bids = []; for (let i = 0; i < validBidRequests.length; i++) { - let requestData = { + const requestData = { adUnitCode: validBidRequests[i].adUnitCode, bidId: validBidRequests[i].bidId, placementHash: validBidRequests[i].params.hash, @@ -60,8 +60,8 @@ export const spec = { bids.push(requestData); } - let host = this.getBidderConfig('host') || BIDDER_HOST; - let bidRequests = []; + const host = this.getBidderConfig('host') || BIDDER_HOST; + const bidRequests = []; bidRequests.push({ method: REQUEST_METHOD, url: host + '/bidder/bids/', @@ -92,7 +92,7 @@ export const spec = { onBidWon: function (bid) { if (bid['requestId']) { - let host = this.getBidderConfig('host') || BIDDER_HOST; + const host = this.getBidderConfig('host') || BIDDER_HOST; triggerPixel(host + '/bidder/won/' + bid['requestId']); } } diff --git a/modules/adriverBidAdapter.js b/modules/adriverBidAdapter.js index 7ac8e4fb728..541d8e733eb 100644 --- a/modules/adriverBidAdapter.js +++ b/modules/adriverBidAdapter.js @@ -22,9 +22,9 @@ export const spec = { }, buildRequests: function (validBidRequests, bidderRequest) { - let win = getWindowLocation(); - let customID = Math.round(Math.random() * 999999999) + '-' + Math.round(new Date() / 1000) + '-1-46-'; - let siteId = getBidIdParameter('siteid', validBidRequests[0].params) + ''; + const win = getWindowLocation(); + const customID = Math.round(Math.random() * 999999999) + '-' + Math.round(new Date() / 1000) + '-1-46-'; + const siteId = getBidIdParameter('siteid', validBidRequests[0].params) + ''; let currency = getBidIdParameter('currency', validBidRequests[0].params); currency = 'RUB'; @@ -63,10 +63,10 @@ export const spec = { let height; let par; - let floorAndCurrency = _getFloor(bid, currency, sizes); + const floorAndCurrency = _getFloor(bid, currency, sizes); - let bidFloor = floorAndCurrency.floor; - let dealId = getBidIdParameter('dealid', bid.params); + const bidFloor = floorAndCurrency.floor; + const dealId = getBidIdParameter('dealid', bid.params); if (typeof sizes[0] === 'number' && typeof sizes[1] === 'number') { width = sizes[0]; height = sizes[1]; @@ -97,7 +97,7 @@ export const spec = { }); }); - let adrcidCookie = storage.getDataFromLocalStorage('adrcid') || validBidRequests[0].userId?.adrcid; + const adrcidCookie = storage.getDataFromLocalStorage('adrcid') || validBidRequests[0].userId?.adrcid; if (adrcidCookie) { payload.user.buyerid = adrcidCookie; } @@ -124,7 +124,7 @@ export const spec = { } if (bid.price >= 0 && bid.impid !== undefined && nurl !== 0 && bid.dealid === undefined) { - let bidResponse = { + const bidResponse = { requestId: bid.ext || undefined, cpm: bid.price, width: bid.w, diff --git a/modules/adriverIdSystem.js b/modules/adriverIdSystem.js index 2dab76b7862..7e659e914b0 100644 --- a/modules/adriverIdSystem.js +++ b/modules/adriverIdSystem.js @@ -50,8 +50,8 @@ export const adriverIdSubmodule = { } const url = 'https://ad.adriver.ru/cgi-bin/json.cgi?sid=1&ad=719473&bt=55&pid=3198680&bid=7189165&bn=7189165&tuid=1&cfa=1'; const resp = function (callback) { - let creationDate = storage.getDataFromLocalStorage('adrcid_cd') || storage.getCookie('adrcid_cd'); - let cookie = storage.getDataFromLocalStorage('adrcid') || storage.getCookie('adrcid'); + const creationDate = storage.getDataFromLocalStorage('adrcid_cd') || storage.getCookie('adrcid_cd'); + const cookie = storage.getDataFromLocalStorage('adrcid') || storage.getCookie('adrcid'); if (cookie && creationDate && ((new Date().getTime() - creationDate) < 86400000)) { const responseObj = cookie; @@ -66,7 +66,7 @@ export const adriverIdSubmodule = { } catch (error) { logError(error); } - let now = new Date(); + const now = new Date(); now.setTime(now.getTime() + 86400 * 1825 * 1000); storage.setCookie('adrcid', responseObj, now.toUTCString(), 'Lax'); storage.setDataInLocalStorage('adrcid', responseObj); @@ -80,7 +80,7 @@ export const adriverIdSubmodule = { callback(); } }; - let newUrl = url + '&cid=' + (storage.getDataFromLocalStorage('adrcid') || storage.getCookie('adrcid')); + const newUrl = url + '&cid=' + (storage.getDataFromLocalStorage('adrcid') || storage.getCookie('adrcid')); ajax(newUrl, callbacks, undefined, {method: 'GET'}); } }; diff --git a/modules/adspiritBidAdapter.js b/modules/adspiritBidAdapter.js index 39fd0917bad..c895be45a74 100644 --- a/modules/adspiritBidAdapter.js +++ b/modules/adspiritBidAdapter.js @@ -13,7 +13,7 @@ export const spec = { supportedMediaTypes: [BANNER, NATIVE], isBidRequestValid: function (bid) { - let host = spec.getBidderHost(bid); + const host = spec.getBidderHost(bid); if (!host || !bid.params.placementId) { return false; } @@ -23,15 +23,15 @@ export const spec = { return SCRIPT_URL; }, buildRequests: function (validBidRequests, bidderRequest) { - let requests = []; - let prebidVersion = getGlobal().version; + const requests = []; + const prebidVersion = getGlobal().version; const win = getWinDimensions(); for (let i = 0; i < validBidRequests.length; i++) { - let bidRequest = validBidRequests[i]; + const bidRequest = validBidRequests[i]; bidRequest.adspiritConId = spec.genAdConId(bidRequest); let reqUrl = spec.getBidderHost(bidRequest); - let placementId = utils.getBidIdParameter('placementId', bidRequest.params); + const placementId = utils.getBidIdParameter('placementId', bidRequest.params); const eids = spec.getEids(bidRequest); reqUrl = '//' + reqUrl + RTB_URL + @@ -44,14 +44,14 @@ export const spec = { '&async=' + bidRequest.adspiritConId + '&t=' + Math.round(Math.random() * 100000); - let gdprApplies = bidderRequest.gdprConsent ? (bidderRequest.gdprConsent.gdprApplies ? 1 : 0) : 0; - let gdprConsentString = bidderRequest.gdprConsent ? encodeURIComponent(bidderRequest.gdprConsent.consentString) : ''; + const gdprApplies = bidderRequest.gdprConsent ? (bidderRequest.gdprConsent.gdprApplies ? 1 : 0) : 0; + const gdprConsentString = bidderRequest.gdprConsent ? encodeURIComponent(bidderRequest.gdprConsent.consentString) : ''; if (bidderRequest.gdprConsent) { reqUrl += '&gdpr=' + gdprApplies + '&gdpr_consent=' + gdprConsentString; } - let openRTBRequest = { + const openRTBRequest = { id: bidderRequest.auctionId, at: 1, cur: ['EUR'], @@ -156,7 +156,7 @@ export const spec = { interpretResponse: function (serverResponse, bidRequest) { const bidResponses = []; const bidObj = bidRequest.bidRequest; - let host = spec.getBidderHost(bidObj); + const host = spec.getBidderHost(bidObj); if (!serverResponse || !serverResponse.body) { utils.logWarn(`adspirit: Empty response from bidder`); @@ -244,8 +244,8 @@ export const spec = { }); }); } else { - let adData = serverResponse.body; - let cpm = adData.cpm; + const adData = serverResponse.body; + const cpm = adData.cpm; if (!cpm) return []; const bidResponse = { @@ -261,7 +261,7 @@ export const spec = { advertiserDomains: adData.adomain || [] } }; - let adm = '' + adData.adm; + const adm = '' + adData.adm; bidResponse.ad = adm; bidResponse.mediaType = BANNER; diff --git a/modules/adtelligentBidAdapter.js b/modules/adtelligentBidAdapter.js index cd00f0ae136..2e7065d2672 100644 --- a/modules/adtelligentBidAdapter.js +++ b/modules/adtelligentBidAdapter.js @@ -32,8 +32,8 @@ const HOST_GETTERS = { indicue: () => 'ghb.console.indicue.com', stellormedia: () => 'ghb.ads.stellormedia.com'} const getUri = function (bidderCode) { - let bidderWithoutSuffix = bidderCode.split('_')[0]; - let getter = HOST_GETTERS[bidderWithoutSuffix] || HOST_GETTERS['default']; + const bidderWithoutSuffix = bidderCode.split('_')[0]; + const getter = HOST_GETTERS[bidderWithoutSuffix] || HOST_GETTERS['default']; return PROTOCOL + getter() + AUCTION_PATH } const OUTSTREAM_SRC = 'https://player.adtelligent.com/outstream-unit/2.01/outstream.min.js'; diff --git a/modules/adtelligentIdSystem.js b/modules/adtelligentIdSystem.js index bb5e1f82129..08d8a056dac 100644 --- a/modules/adtelligentIdSystem.js +++ b/modules/adtelligentIdSystem.js @@ -21,7 +21,7 @@ const syncUrl = 'https://idrs.adtelligent.com/get'; function buildUrl(opts) { const queryPairs = []; - for (let key in opts) { + for (const key in opts) { queryPairs.push(`${key}=${encodeURIComponent(opts[key])}`); } return `${syncUrl}?${queryPairs.join('&')}`; diff --git a/modules/adtrgtmeBidAdapter.js b/modules/adtrgtmeBidAdapter.js index 537ec2817d6..344f35b70a6 100644 --- a/modules/adtrgtmeBidAdapter.js +++ b/modules/adtrgtmeBidAdapter.js @@ -61,7 +61,7 @@ function createORTB(bR, bid) { const consentString = gdpr ? bR.gdprConsent?.consentString : ''; const usPrivacy = bR.uspConsent || ''; - let oR = { + const oR = { id: generateUUID(), cur: [currency], imp: [], @@ -217,7 +217,7 @@ export const spec = { sR.body.seatbid.forEach((sb) => { try { - let b = sb.bid[0]; + const b = sb.bid[0]; res.push({ adId: b?.adId ? b.adId : b.impid || b.crid, diff --git a/modules/adtrueBidAdapter.js b/modules/adtrueBidAdapter.js index c9037aeb743..0dbb15aabdd 100644 --- a/modules/adtrueBidAdapter.js +++ b/modules/adtrueBidAdapter.js @@ -17,7 +17,7 @@ const DEFAULT_HEIGHT = 0; const NET_REVENUE = false; let publisherId = 0; let zoneId = 0; -let NATIVE_ASSET_ID_TO_KEY_MAP = {}; +const NATIVE_ASSET_ID_TO_KEY_MAP = {}; const DATA_TYPES = { 'NUMBER': 'number', 'STRING': 'string', @@ -74,12 +74,12 @@ const NATIVE_ASSETS = { }; function _getDomainFromURL(url) { - let anchor = document.createElement('a'); + const anchor = document.createElement('a'); anchor.href = url; return anchor.hostname; } -let platform = (function getPlatform() { +const platform = (function getPlatform() { var ua = navigator.userAgent; if (ua.indexOf('Android') > -1 || ua.indexOf('Adr') > -1) { return 'Android' @@ -459,8 +459,8 @@ export const spec = { if (bidderRequest && bidderRequest.refererInfo) { refererInfo = bidderRequest.refererInfo; } - let conf = _initConf(refererInfo); - let payload = _createOrtbTemplate(conf); + const conf = _initConf(refererInfo); + const payload = _createOrtbTemplate(conf); let bidCurrency = ''; let bid; validBidRequests.forEach(originalBid => { @@ -543,8 +543,8 @@ export const spec = { interpretResponse: function (serverResponses, bidderRequest) { const bidResponses = []; var respCur = ADTRUE_CURRENCY; - let parsedRequest = JSON.parse(bidderRequest.data); - let parsedReferrer = parsedRequest.site && parsedRequest.site.ref ? parsedRequest.site.ref : ''; + const parsedRequest = JSON.parse(bidderRequest.data); + const parsedReferrer = parsedRequest.site && parsedRequest.site.ref ? parsedRequest.site.ref : ''; try { if (serverResponses.body && serverResponses.body.seatbid && isArray(serverResponses.body.seatbid)) { // Supporting multiple bid responses for same adSize @@ -553,7 +553,7 @@ export const spec = { seatbidder.bid && isArray(seatbidder.bid) && seatbidder.bid.forEach(bid => { - let newBid = { + const newBid = { requestId: bid.impid, cpm: (parseFloat(bid.price) || 0).toFixed(2), width: bid.w, @@ -614,9 +614,9 @@ export const spec = { return []; } return responses.reduce((accum, rsp) => { - let cookieSyncs = deepAccess(rsp, 'body.ext.cookie_sync'); + const cookieSyncs = deepAccess(rsp, 'body.ext.cookie_sync'); if (cookieSyncs) { - let cookieSyncObjects = cookieSyncs.map(cookieSync => { + const cookieSyncObjects = cookieSyncs.map(cookieSync => { return { type: SYNC_TYPES[cookieSync.type], url: cookieSync.url + diff --git a/modules/advRedAnalyticsAdapter.js b/modules/advRedAnalyticsAdapter.js index 8ad30ed351d..933d9bdc584 100644 --- a/modules/advRedAnalyticsAdapter.js +++ b/modules/advRedAnalyticsAdapter.js @@ -10,13 +10,13 @@ import {getRefererInfo} from '../src/refererDetection.js'; */ const DEFAULT_EVENT_URL = 'https://api.adv.red/api/event' -let ajax = ajaxBuilder(10000) +const ajax = ajaxBuilder(10000) let pwId let initOptions let flushInterval let queue = [] -let advRedAnalytics = Object.assign(adapter({url: DEFAULT_EVENT_URL, analyticsType: 'endpoint'}), { +const advRedAnalytics = Object.assign(adapter({url: DEFAULT_EVENT_URL, analyticsType: 'endpoint'}), { track({eventType, args}) { handleEvent(eventType, args) } @@ -70,7 +70,7 @@ function convertBid(bid) { } function convertAuctionInit(origEvent) { - let shortEvent = {} + const shortEvent = {} shortEvent.auctionId = origEvent.auctionId shortEvent.timeout = origEvent.timeout shortEvent.adUnits = origEvent.adUnits && origEvent.adUnits.map(convertAdUnit) @@ -78,7 +78,7 @@ function convertAuctionInit(origEvent) { } function convertBidRequested(origEvent) { - let shortEvent = {} + const shortEvent = {} shortEvent.bidderCode = origEvent.bidderCode shortEvent.bids = origEvent.bids && origEvent.bids.map(convertBid) shortEvent.timeout = origEvent.timeout @@ -86,19 +86,19 @@ function convertBidRequested(origEvent) { } function convertBidTimeout(origEvent) { - let shortEvent = {} + const shortEvent = {} shortEvent.bids = origEvent && origEvent.map ? origEvent.map(convertBid) : origEvent return shortEvent } function convertBidderError(origEvent) { - let shortEvent = {} + const shortEvent = {} shortEvent.bids = origEvent.bidderRequest && origEvent.bidderRequest.bids && origEvent.bidderRequest.bids.map(convertBid) return shortEvent } function convertAuctionEnd(origEvent) { - let shortEvent = {} + const shortEvent = {} shortEvent.adUnitCodes = origEvent.adUnitCodes shortEvent.bidsReceived = origEvent.bidsReceived && origEvent.bidsReceived.map(convertBid) shortEvent.noBids = origEvent.noBids && origEvent.noBids.map(convertBid) @@ -106,7 +106,7 @@ function convertAuctionEnd(origEvent) { } function convertBidWon(origEvent) { - let shortEvent = {} + const shortEvent = {} shortEvent.adUnitCode = origEvent.adUnitCode shortEvent.bidderCode = origEvent.bidderCode shortEvent.mediaType = origEvent.mediaType diff --git a/modules/advangelistsBidAdapter.js b/modules/advangelistsBidAdapter.js index 1d0d987b07d..316dd38fd22 100755 --- a/modules/advangelistsBidAdapter.js +++ b/modules/advangelistsBidAdapter.js @@ -25,9 +25,9 @@ export const spec = { }, buildRequests(bids, bidderRequest) { - let requests = []; - let videoBids = bids.filter(bid => isVideoBidValid(bid)); - let bannerBids = bids.filter(bid => isBannerBidValid(bid)); + const requests = []; + const videoBids = bids.filter(bid => isVideoBidValid(bid)); + const bannerBids = bids.filter(bid => isBannerBidValid(bid)); videoBids.forEach(bid => { pubid = getVideoBidParam(bid, 'pubid'); requests.push({ @@ -51,10 +51,10 @@ export const spec = { }, interpretResponse(serverResponse, { bidRequest }) { - let response = serverResponse.body; + const response = serverResponse.body; if (response !== null && isEmpty(response) === false) { if (isVideoBid(bidRequest)) { - let bidResponse = { + const bidResponse = { requestId: response.id, cpm: response.seatbid[0].bid[0].price, width: response.seatbid[0].bid[0].w, diff --git a/modules/advertisingBidAdapter.js b/modules/advertisingBidAdapter.js index 665096fb19d..3bc8015c25d 100644 --- a/modules/advertisingBidAdapter.js +++ b/modules/advertisingBidAdapter.js @@ -139,8 +139,8 @@ export const spec = { }, buildBannerImpressions: function (adSizes, bid, tagIdOrPlacementId, pos, videoOrBannerKey) { - let format = []; - let imps = []; + const format = []; + const imps = []; adSizes.forEach((size, i) => { if (!size || size.length !== 2) { return; @@ -174,7 +174,7 @@ export const spec = { }, buildVideoImpressions: function(adSizes, bid, tagIdOrPlacementId, pos, videoOrBannerKey) { - let imps = []; + const imps = []; adSizes.forEach((size, i) => { if (!size || size.length != 2) { return; @@ -228,7 +228,7 @@ export const spec = { return; } const {id, seatbid: seatbids} = serverResponse.body; - let bids = []; + const bids = []; if (id && seatbids) { seatbids.forEach(seatbid => { seatbid.bid.forEach(bid => { @@ -337,7 +337,7 @@ function getBidFloor(bid, mediaType, size) { if (!isFn(bid.getFloor)) { return bid.params.bidfloor ? parseFloat(bid.params.bidfloor) : null; } - let floor = bid.getFloor({ + const floor = bid.getFloor({ currency: 'USD', mediaType, size diff --git a/modules/adxcgAnalyticsAdapter.js b/modules/adxcgAnalyticsAdapter.js index 7538e2962cc..34570a8dd71 100644 --- a/modules/adxcgAnalyticsAdapter.js +++ b/modules/adxcgAnalyticsAdapter.js @@ -40,7 +40,7 @@ var adxcgAnalyticsAdapter = Object.assign(adapter( adxcgAnalyticsAdapter.context.events.bidResponses.push(mapBidResponse(args, eventType)); break; case EVENTS.BID_WON: - let outData2 = {bidWons: mapBidWon(args)}; + const outData2 = {bidWons: mapBidWon(args)}; send(outData2); break; case EVENTS.AUCTION_END: @@ -112,7 +112,7 @@ function mapBidWon (bidResponse) { } function send (data) { - let adxcgAnalyticsRequestUrl = buildUrl({ + const adxcgAnalyticsRequestUrl = buildUrl({ protocol: 'https', hostname: adxcgAnalyticsAdapter.context.host, pathname: '/pbrx/v2', diff --git a/modules/adxcgBidAdapter.js b/modules/adxcgBidAdapter.js index a0e99572809..952e10b1daa 100644 --- a/modules/adxcgBidAdapter.js +++ b/modules/adxcgBidAdapter.js @@ -61,9 +61,9 @@ export const spec = { getUserSyncs: (syncOptions, responses, gdprConsent, uspConsent) => { const syncs = []; - let syncUrl = config.getConfig('adxcg.usersyncUrl'); + const syncUrl = config.getConfig('adxcg.usersyncUrl'); - let query = []; + const query = []; if (syncOptions.pixelEnabled && syncUrl) { if (gdprConsent) { query.push('gdpr=' + (gdprConsent.gdprApplies & 1)); diff --git a/modules/adxpremiumAnalyticsAdapter.js b/modules/adxpremiumAnalyticsAdapter.js index ffdda244263..d2a2e8531ad 100644 --- a/modules/adxpremiumAnalyticsAdapter.js +++ b/modules/adxpremiumAnalyticsAdapter.js @@ -7,7 +7,7 @@ import { EVENTS } from '../src/constants.js'; const analyticsType = 'endpoint'; const defaultUrl = 'https://adxpremium.services/graphql'; -let reqCountry = window.reqCountry || null; +const reqCountry = window.reqCountry || null; // Events needed const { @@ -19,13 +19,13 @@ const { AUCTION_END } = EVENTS; -let timeoutBased = false; +const timeoutBased = false; let requestSent = false; let requestDelivered = false; let elementIds = []; // Memory objects -let completeObject = { +const completeObject = { publisher_id: null, auction_id: null, referer: null, @@ -38,7 +38,7 @@ let completeObject = { // Upgraded object let upgradedObject = null; -let adxpremiumAnalyticsAdapter = Object.assign(adapter({ defaultUrl, analyticsType }), { +const adxpremiumAnalyticsAdapter = Object.assign(adapter({ defaultUrl, analyticsType }), { track({ eventType, args }) { switch (eventType) { case AUCTION_INIT: @@ -66,7 +66,7 @@ let adxpremiumAnalyticsAdapter = Object.assign(adapter({ defaultUrl, analyticsTy }); // DFP support -let googletag = window.googletag || {}; +const googletag = window.googletag || {}; googletag.cmd = googletag.cmd || []; googletag.cmd.push(function() { googletag.pubads().addEventListener('slotRenderEnded', args => { @@ -100,7 +100,7 @@ function auctionInit(args) { completeObject.device_type = deviceType(); } function bidRequested(args) { - let tmpObject = { + const tmpObject = { type: 'REQUEST', bidder_code: args.bidderCode, event_timestamp: args.start, @@ -116,7 +116,7 @@ function bidRequested(args) { } function bidResponse(args) { - let tmpObject = { + const tmpObject = { type: 'RESPONSE', bidder_code: args.bidderCode, event_timestamp: args.responseTimestamp, @@ -133,7 +133,7 @@ function bidResponse(args) { } function bidWon(args) { - let eventIndex = bidResponsesMapper[args.requestId]; + const eventIndex = bidResponsesMapper[args.requestId]; if (eventIndex !== undefined) { if (requestDelivered) { if (completeObject.events[eventIndex]) { @@ -152,7 +152,7 @@ function bidWon(args) { } } else { logInfo('AdxPremium Analytics - Response not found, creating new one.'); - let tmpObject = { + const tmpObject = { type: 'RESPONSE', bidder_code: args.bidderCode, event_timestamp: args.responseTimestamp, @@ -165,23 +165,23 @@ function bidWon(args) { is_winning: true, is_lost: true }; - let lostObject = deepClone(completeObject); + const lostObject = deepClone(completeObject); lostObject.events = [tmpObject]; sendEvent(lostObject); // send lost object } } function bidTimeout(args) { - let timeoutObject = deepClone(completeObject); + const timeoutObject = deepClone(completeObject); timeoutObject.events = []; - let usedRequestIds = []; + const usedRequestIds = []; args.forEach(bid => { - let pulledRequestId = bidMapper[bid.bidId]; - let eventIndex = bidRequestsMapper[pulledRequestId]; + const pulledRequestId = bidMapper[bid.bidId]; + const eventIndex = bidRequestsMapper[pulledRequestId]; if (eventIndex !== undefined && completeObject.events[eventIndex] && usedRequestIds.indexOf(pulledRequestId) == -1) { // mark as timeouted - let tempEventIndex = timeoutObject.events.push(completeObject.events[eventIndex]) - 1; + const tempEventIndex = timeoutObject.events.push(completeObject.events[eventIndex]) - 1; timeoutObject.events[tempEventIndex]['type'] = 'TIMEOUT'; usedRequestIds.push(pulledRequestId); // mark as used } @@ -233,9 +233,9 @@ function sendEvent(completeObject) { if (!adxpremiumAnalyticsAdapter.enabled) return; requestDelivered = true; try { - let responseEvents = btoa(JSON.stringify(completeObject)); - let mutation = `mutation {createEvent(input: {event: {eventData: "${responseEvents}"}}) {event {createTime } } }`; - let dataToSend = JSON.stringify({ query: mutation }); + const responseEvents = btoa(JSON.stringify(completeObject)); + const mutation = `mutation {createEvent(input: {event: {eventData: "${responseEvents}"}}) {event {createTime } } }`; + const dataToSend = JSON.stringify({ query: mutation }); let ajaxEndpoint = defaultUrl; if (adxpremiumAnalyticsAdapter.initOptions.sid) { ajaxEndpoint = 'https://' + adxpremiumAnalyticsAdapter.initOptions.sid + '.adxpremium.services/graphql' diff --git a/modules/adyoulikeBidAdapter.js b/modules/adyoulikeBidAdapter.js index 4d9ca1be7b6..370fbc1b716 100644 --- a/modules/adyoulikeBidAdapter.js +++ b/modules/adyoulikeBidAdapter.js @@ -75,9 +75,9 @@ export const spec = { const payload = { Version: VERSION, Bids: bidRequests.reduce((accumulator, bidReq) => { - let mediatype = getMediatype(bidReq); - let sizesArray = getSizeArray(bidReq); - let size = getSize(sizesArray); + const mediatype = getMediatype(bidReq); + const sizesArray = getSizeArray(bidReq); + const size = getSize(sizesArray); accumulator[bidReq.bidId] = {}; accumulator[bidReq.bidId].PlacementID = bidReq.params.placement; accumulator[bidReq.bidId].TransactionID = bidReq.ortb2Imp?.ext?.tid; @@ -228,7 +228,7 @@ export const spec = { /* Get hostname from bids */ function getHostname(bidderRequest) { - let dcHostname = ((bidderRequest) || []).find(bid => bid.params.DC); + const dcHostname = ((bidderRequest) || []).find(bid => bid.params.DC); if (dcHostname) { return ('-' + dcHostname.params.DC); } @@ -273,7 +273,7 @@ function getPageRefreshed() { /* Create endpoint url */ function createEndpoint(bidRequests, bidderRequest, hasVideo) { - let host = getHostname(bidRequests); + const host = getHostname(bidRequests); const endpoint = hasVideo ? '/hb-api/prebid-video/v1' : '/hb-api/prebid/v1'; return buildUrl({ protocol: 'https', diff --git a/modules/aidemBidAdapter.js b/modules/aidemBidAdapter.js index 2f2c46942de..79a99e8a944 100644 --- a/modules/aidemBidAdapter.js +++ b/modules/aidemBidAdapter.js @@ -108,7 +108,7 @@ function recur(obj) { } function getRegs(bidderRequest) { - let regs = {}; + const regs = {}; const euConsentManagement = bidderRequest.gdprConsent; const usConsentManagement = bidderRequest.uspConsent; const coppa = config.getConfig('coppa'); @@ -186,7 +186,7 @@ function hasValidVideoParameters(bidRequest) { let valid = true; const adUnitsParameters = deepAccess(bidRequest, 'mediaTypes.video'); const bidderParameter = deepAccess(bidRequest, 'params.video'); - for (let property of REQUIRED_VIDEO_PARAMS) { + for (const property of REQUIRED_VIDEO_PARAMS) { const hasAdUnitParameter = adUnitsParameters.hasOwnProperty(property); const hasBidderParameter = bidderParameter && bidderParameter.hasOwnProperty(property); if (!hasAdUnitParameter && !hasBidderParameter) { diff --git a/modules/ajaBidAdapter.js b/modules/ajaBidAdapter.js index a06c1a873fc..75944516c2d 100644 --- a/modules/ajaBidAdapter.js +++ b/modules/ajaBidAdapter.js @@ -194,7 +194,7 @@ export const spec = { } function pickAdFormats(bidRequest) { - let sizes = bidRequest.sizes || [] + const sizes = bidRequest.sizes || [] sizes.push(...(bidRequest.mediaTypes?.banner?.sizes || [])) const adFormatIDs = []; diff --git a/modules/alkimiBidAdapter.js b/modules/alkimiBidAdapter.js index 36a2600294c..14131c07840 100644 --- a/modules/alkimiBidAdapter.js +++ b/modules/alkimiBidAdapter.js @@ -21,11 +21,11 @@ export const spec = { }, buildRequests: function (validBidRequests, bidderRequest) { - let bids = []; - let bidIds = []; + const bids = []; + const bidIds = []; let eids; validBidRequests.forEach(bidRequest => { - let formatTypes = getFormatType(bidRequest) + const formatTypes = getFormatType(bidRequest) if (bidRequest.userIdAsEids) { eids = eids || bidRequest.userIdAsEids @@ -58,7 +58,7 @@ export const spec = { const userParams = alkimiConfig && alkimiConfig.userParams const user = (walletID != undefined || userParams != undefined || id != undefined) ? { id, ext: { walletID, userParams } } : undefined - let payload = { + const payload = { requestId: generateUUID(), signRequest: {bids, randomUUID: alkimiConfig && alkimiConfig.randomUUID}, bidIds, @@ -128,9 +128,9 @@ export const spec = { return []; } - let bids = []; + const bids = []; prebidResponse.forEach(bidResponse => { - let bid = deepClone(bidResponse); + const bid = deepClone(bidResponse); bid.cpm = parseFloat(bidResponse.cpm); // banner or video @@ -200,7 +200,7 @@ function getBidFloor(bidRequest, formatTypes) { } const getFormatType = bidRequest => { - let formats = [] + const formats = [] if (deepAccess(bidRequest, 'mediaTypes.banner')) formats.push('Banner') if (deepAccess(bidRequest, 'mediaTypes.video')) formats.push('Video') return formats diff --git a/modules/ampliffyBidAdapter.js b/modules/ampliffyBidAdapter.js index e79b04ab4c4..95ede0b1897 100644 --- a/modules/ampliffyBidAdapter.js +++ b/modules/ampliffyBidAdapter.js @@ -101,7 +101,7 @@ const getCurrentURLEncoded = () => encodeURIComponent(getCurrentURL()); function getServerURL(server, sizes, iu, queryParams) { const random = getCacheBuster(); const size = sizes[0] + 'x' + sizes[1]; - let serverURL = '//' + server + '/gampad/ads'; + const serverURL = '//' + server + '/gampad/ads'; queryParams.sz = size; queryParams.iu = iu; queryParams.url = getCurrentURL(); @@ -131,7 +131,7 @@ function interpretResponse(serverResponse, bidRequest) { bidResponse.meta = { advertiserDomains: [], }; - let xmlStr = serverResponse.body; + const xmlStr = serverResponse.body; const xml = new window.DOMParser().parseFromString(xmlStr, 'text/xml'); const xmlData = parseXML(xml, bidResponse); logInfo(LOG_PREFIX + 'Response from: ' + bidRequest.url + ': ' + JSON.stringify(xmlData), bidRequest.bidRequest.adUnitCode); @@ -219,7 +219,7 @@ function extractCT(xml) { function extractCPM(htmlContent, ct, cpm) { const cpmMapDiv = htmlContent.querySelectorAll('[cpmMap]')[0]; if (cpmMapDiv) { - let cpmMapJSON = JSON.parse(cpmMapDiv.getAttribute('cpmMap')); + const cpmMapJSON = JSON.parse(cpmMapDiv.getAttribute('cpmMap')); if ((cpmMapJSON)) { if (cpmMapJSON[ct]) { cpm = cpmMapJSON[ct]; @@ -330,7 +330,7 @@ export function isAllowedToBidUp(html, currentURL) { if (excludedURL) { const excludedURLsString = domainsMap.getAttribute('excludedURLs'); if (excludedURLsString !== '') { - let excluded = JSON.parse(excludedURLsString); + const excluded = JSON.parse(excludedURLsString); excluded.forEach((d) => { if (currentURL.includes(d)) allowedToPush = false; }) diff --git a/modules/amxBidAdapter.js b/modules/amxBidAdapter.js index 8afab28378f..ae94ec60c96 100644 --- a/modules/amxBidAdapter.js +++ b/modules/amxBidAdapter.js @@ -462,7 +462,7 @@ export const spec = { setUIDSafe(response.am); } - let { bidderSettings } = getGlobal(); + const { bidderSettings } = getGlobal(); const currentBidder = config.getCurrentBidder(); const allowAlternateBidderCodes = alternateCodesAllowed(bidderSettings ?? {}, currentBidder) || alternateCodesAllowed(config.getConfig('bidderSettings') ?? {}, currentBidder); diff --git a/modules/apacdexBidAdapter.js b/modules/apacdexBidAdapter.js index 912f37e35c8..ca0d5215dd2 100644 --- a/modules/apacdexBidAdapter.js +++ b/modules/apacdexBidAdapter.js @@ -43,7 +43,7 @@ export const spec = { let eids; let geo; let test; - let bids = []; + const bids = []; test = config.getConfig('debug'); @@ -81,7 +81,7 @@ export const spec = { bySlotTargetKey[bidReq.adUnitCode] = targetKey; bidReq.targetKey = targetKey; - let bidFloor = getBidFloor(bidReq); + const bidFloor = getBidFloor(bidReq); if (bidFloor) { bidReq.bidFloor = bidFloor; } @@ -335,7 +335,7 @@ function getBidFloor(bid) { return (bid.params.floorPrice) ? bid.params.floorPrice : null; } - let floor = bid.getFloor({ + const floor = bid.getFloor({ currency: 'USD', mediaType: '*', size: '*' diff --git a/modules/appierAnalyticsAdapter.js b/modules/appierAnalyticsAdapter.js index 3664c49c424..4773945d85c 100644 --- a/modules/appierAnalyticsAdapter.js +++ b/modules/appierAnalyticsAdapter.js @@ -35,7 +35,7 @@ export const getCpmInUsd = function (bid) { const analyticsOptions = {}; export const parseBidderCode = function (bid) { - let bidderCode = bid.bidderCode || bid.bidder; + const bidderCode = bid.bidderCode || bid.bidder; return bidderCode.toLowerCase(); }; diff --git a/modules/appnexusBidAdapter.js b/modules/appnexusBidAdapter.js index 5eb33fd6b6d..3d4b166d194 100644 --- a/modules/appnexusBidAdapter.js +++ b/modules/appnexusBidAdapter.js @@ -164,9 +164,9 @@ export const spec = { Object.keys(userObjBid.params.user) .filter(param => USER_PARAMS.includes(param)) .forEach((param) => { - let uparam = convertCamelToUnderscore(param); + const uparam = convertCamelToUnderscore(param); if (param === 'segments' && isArray(userObjBid.params.user[param])) { - let segs = []; + const segs = []; userObjBid.params.user[param].forEach(val => { if (isNumber(val)) { segs.push({'id': val}); @@ -199,7 +199,7 @@ export const spec = { } let debugObj = {}; - let debugObjParams = {}; + const debugObjParams = {}; const debugCookieName = 'apn_prebid_debug'; const debugCookie = storage.getCookie(debugCookieName) || null; @@ -211,7 +211,7 @@ export const spec = { } } else { Object.keys(DEBUG_QUERY_PARAM_MAP).forEach(qparam => { - let qval = getParameterByName(qparam); + const qval = getParameterByName(qparam); if (isStr(qval) && qval !== '') { debugObj[DEBUG_QUERY_PARAM_MAP[qparam]] = qval; debugObj.enabled = true; @@ -276,10 +276,10 @@ export const spec = { } // grab the ortb2 keyword data (if it exists) and convert from the comma list string format to object format - let ortb2 = deepClone(bidderRequest && bidderRequest.ortb2); + const ortb2 = deepClone(bidderRequest && bidderRequest.ortb2); - let anAuctionKeywords = deepClone(config.getConfig('appnexusAuctionKeywords')) || {}; - let auctionKeywords = getANKeywordParam(ortb2, anAuctionKeywords) + const anAuctionKeywords = deepClone(config.getConfig('appnexusAuctionKeywords')) || {}; + const auctionKeywords = getANKeywordParam(ortb2, anAuctionKeywords) if (auctionKeywords.length > 0) { payload.keywords = auctionKeywords; } @@ -313,9 +313,9 @@ export const spec = { }; if (bidderRequest.gdprConsent.addtlConsent && bidderRequest.gdprConsent.addtlConsent.indexOf('~') !== -1) { - let ac = bidderRequest.gdprConsent.addtlConsent; + const ac = bidderRequest.gdprConsent.addtlConsent; // pull only the ids from the string (after the ~) and convert them to an array of ints - let acStr = ac.substring(ac.indexOf('~') + 1); + const acStr = ac.substring(ac.indexOf('~') + 1); payload.gdpr_consent.addtl_consent = acStr.split('.').map(id => parseInt(id, 10)); } } @@ -337,14 +337,14 @@ export const spec = { } if (bidderRequest && bidderRequest.refererInfo) { - let refererinfo = { + const refererinfo = { // TODO: are these the correct referer values? rd_ref: encodeURIComponent(bidderRequest.refererInfo.topmostLocation), rd_top: bidderRequest.refererInfo.reachedTop, rd_ifs: bidderRequest.refererInfo.numIframes, rd_stk: bidderRequest.refererInfo.stack.map((url) => encodeURIComponent(url)).join(',') }; - let pubPageUrl = bidderRequest.refererInfo.canonicalUrl; + const pubPageUrl = bidderRequest.refererInfo.canonicalUrl; if (isStr(pubPageUrl) && pubPageUrl !== '') { refererinfo.rd_can = pubPageUrl; } @@ -364,11 +364,11 @@ export const spec = { } if (bidRequests[0].userIdAsEids?.length > 0) { - let eids = []; + const eids = []; bidRequests[0].userIdAsEids.forEach(eid => { if (!eid || !eid.uids || eid.uids.length < 1) { return; } eid.uids.forEach(uid => { - let tmp = {'source': eid.source, 'id': uid.id}; + const tmp = {'source': eid.source, 'id': uid.id}; if (eid.source == 'adserver.org') { tmp.rti_partner = 'TDID'; } else if (eid.source == 'uidapi.com') { @@ -446,7 +446,7 @@ export const spec = { } if (serverResponse.debug && serverResponse.debug.debug_info) { - let debugHeader = 'AppNexus Debug Auction for Prebid\n\n' + const debugHeader = 'AppNexus Debug Auction for Prebid\n\n' let debugText = debugHeader + serverResponse.debug.debug_info debugText = debugText .replace(/(|)/gm, '\t') // Tables @@ -485,18 +485,18 @@ export const spec = { function strIsAppnexusViewabilityScript(str) { if (!str || str === '') return false; - let regexMatchUrlStart = str.match(VIEWABILITY_URL_START); - let viewUrlStartInStr = regexMatchUrlStart != null && regexMatchUrlStart.length >= 1; + const regexMatchUrlStart = str.match(VIEWABILITY_URL_START); + const viewUrlStartInStr = regexMatchUrlStart != null && regexMatchUrlStart.length >= 1; - let regexMatchFileName = str.match(VIEWABILITY_FILE_NAME); - let fileNameInStr = regexMatchFileName != null && regexMatchFileName.length >= 1; + const regexMatchFileName = str.match(VIEWABILITY_FILE_NAME); + const fileNameInStr = regexMatchFileName != null && regexMatchFileName.length >= 1; return str.startsWith(SCRIPT_TAG_START) && fileNameInStr && viewUrlStartInStr; } function formatRequest(payload, bidderRequest) { let request = []; - let options = { + const options = { withCredentials: true }; @@ -607,7 +607,7 @@ function newBid(serverBid, rtbBid, bidderRequest) { // temporary function; may remove at later date if/when adserver fully supports dchain function setupDChain(rtbBid) { - let dchain = { + const dchain = { ver: '1.0', complete: 0, nodes: [{ @@ -670,7 +670,7 @@ function newBid(serverBid, rtbBid, bidderRequest) { let viewScript; if (strIsAppnexusViewabilityScript(rtbBid.viewability.config)) { - let prebidParams = 'pbjs_adid=' + adId + ';pbjs_auc=' + bidRequest.adUnitCode; + const prebidParams = 'pbjs_adid=' + adId + ';pbjs_auc=' + bidRequest.adUnitCode; viewScript = rtbBid.viewability.config.replace('dom_id=%native_dom_id%', prebidParams); } @@ -848,7 +848,7 @@ function newBid(serverBid, rtbBid, bidderRequest) { function bidToTag(bid) { const tag = {}; Object.keys(bid.params).forEach(paramKey => { - let convertedKey = convertCamelToUnderscore(paramKey); + const convertedKey = convertCamelToUnderscore(paramKey); if (convertedKey !== paramKey) { bid.params[convertedKey] = bid.params[paramKey]; delete bid.params[paramKey]; @@ -880,14 +880,14 @@ function bidToTag(bid) { : (typeof bid.params.use_pmt_rule === 'boolean') ? bid.params.use_pmt_rule : false; tag.prebid = true; tag.disable_psa = true; - let bidFloor = getBidFloor(bid); + const bidFloor = getBidFloor(bid); if (bidFloor) { tag.reserve = bidFloor; } if (bid.params.position) { tag.position = { 'above': 1, 'below': 2 }[bid.params.position] || 0; } else { - let mediaTypePos = deepAccess(bid, `mediaTypes.banner.pos`) || deepAccess(bid, `mediaTypes.video.pos`); + const mediaTypePos = deepAccess(bid, `mediaTypes.banner.pos`) || deepAccess(bid, `mediaTypes.video.pos`); // only support unknown, atf, and btf values for position at this time if (mediaTypePos === 0 || mediaTypePos === 1 || mediaTypePos === 3) { // ortb spec treats btf === 3, but our system interprets btf === 2; so converting the ortb value here for consistency @@ -921,12 +921,12 @@ function bidToTag(bid) { tag.keywords = auKeywords; } - let gpid = deepAccess(bid, 'ortb2Imp.ext.gpid'); + const gpid = deepAccess(bid, 'ortb2Imp.ext.gpid'); if (gpid) { tag.gpid = gpid; } - let tid = deepAccess(bid, 'ortb2Imp.ext.tid'); + const tid = deepAccess(bid, 'ortb2Imp.ext.tid'); if (tid) { tag.tid = tid; } @@ -1018,8 +1018,8 @@ function bidToTag(bid) { case 'api': if (!tag['video_frameworks'] && isArray(videoMediaType[param])) { // need to read thru array; remove 6 (we don't support it), swap 4 <> 5 if found (to match our adserver mapping for these specific values) - let apiTmp = videoMediaType[param].map(val => { - let v = (val === 4) ? 5 : (val === 5) ? 4 : val; + const apiTmp = videoMediaType[param].map(val => { + const v = (val === 4) ? 5 : (val === 5) ? 4 : val; if (v >= 1 && v <= 5) { return v; @@ -1067,7 +1067,7 @@ function bidToTag(bid) { /* Turn bid request sizes into ut-compatible format */ function transformSizes(requestSizes) { - let sizes = []; + const sizes = []; let sizeObj = {}; if (isArray(requestSizes) && requestSizes.length === 2 && @@ -1077,7 +1077,7 @@ function transformSizes(requestSizes) { sizes.push(sizeObj); } else if (typeof requestSizes === 'object') { for (let i = 0; i < requestSizes.length; i++) { - let size = requestSizes[i]; + const size = requestSizes[i]; sizeObj = {}; sizeObj.width = parseInt(size[0], 10); sizeObj.height = parseInt(size[1], 10); @@ -1199,7 +1199,7 @@ function createAdPodRequest(tags, adPodBid) { const maxDuration = Math.max(...durationRangeSec); const tagToDuplicate = tags.filter(tag => tag.uuid === adPodBid.bidId); - let request = fill(...tagToDuplicate, numberOfPlacements); + const request = fill(...tagToDuplicate, numberOfPlacements); if (requireExactDuration) { const divider = Math.ceil(numberOfPlacements / durationRangeSec.length); @@ -1261,7 +1261,7 @@ function buildNativeRequest(params) { // convert the sizes of image/icon assets to proper format (if needed) const isImageAsset = !!(requestKey === NATIVE_MAPPING.image.serverName || requestKey === NATIVE_MAPPING.icon.serverName); if (isImageAsset && request[requestKey].sizes) { - let sizes = request[requestKey].sizes; + const sizes = request[requestKey].sizes; if (isArrayOfNums(sizes) || (isArray(sizes) && sizes.length > 0 && sizes.every(sz => isArrayOfNums(sz)))) { request[requestKey].sizes = transformSizes(request[requestKey].sizes); } @@ -1339,7 +1339,7 @@ function getBidFloor(bid) { return (bid.params.reserve) ? bid.params.reserve : null; } - let floor = bid.getFloor({ + const floor = bid.getFloor({ currency: 'USD', mediaType: '*', size: '*' diff --git a/modules/apstreamBidAdapter.js b/modules/apstreamBidAdapter.js index 37e2bde44c1..b8bd4bfb080 100644 --- a/modules/apstreamBidAdapter.js +++ b/modules/apstreamBidAdapter.js @@ -292,12 +292,12 @@ function getConsentStringFromPrebid(gdprConsentConfig) { return null; } - let vendorConsents = ( + const vendorConsents = ( gdprConsentConfig.vendorData.vendorConsents || (gdprConsentConfig.vendorData.vendor || {}).consents || {} ); - let isConsentGiven = !!vendorConsents[CONSTANTS.GVLID.toString(10)]; + const isConsentGiven = !!vendorConsents[CONSTANTS.GVLID.toString(10)]; return isConsentGiven ? consentString : null; } @@ -376,7 +376,7 @@ function getBids(bids) { }; function getEndpointsGroups(bidRequests) { - let endpoints = []; + const endpoints = []; const getEndpoint = bid => { const publisherId = bid.params.publisherId || config.getConfig('apstream.publisherId'); const isTestConfig = bid.params.test || config.getConfig('apstream.test'); @@ -462,7 +462,7 @@ function buildRequests(bidRequests, bidderRequest) { } function interpretResponse(serverResponse) { - let bidResponses = serverResponse && serverResponse.body; + const bidResponses = serverResponse && serverResponse.body; if (!bidResponses || !bidResponses.length) { return []; diff --git a/modules/asoBidAdapter.js b/modules/asoBidAdapter.js index 388eee86fe2..b67372f4c56 100644 --- a/modules/asoBidAdapter.js +++ b/modules/asoBidAdapter.js @@ -27,7 +27,7 @@ export const spec = { }, buildRequests: (bidRequests, bidderRequest) => { - let requests = []; + const requests = []; bidRequests.forEach(bid => { const data = converter.toORTB({bidRequests: [bid], bidderRequest}); @@ -150,7 +150,7 @@ function getEndpoint(bidRequest) { function getConsentsIds(gdprConsent) { const consents = deepAccess(gdprConsent, 'vendorData.purpose.consents', []); - let consentsIds = []; + const consentsIds = []; Object.keys(consents).forEach(key => { if (consents[key] === true) { diff --git a/modules/asteriobidAnalyticsAdapter.js b/modules/asteriobidAnalyticsAdapter.js index 73752d77009..e4f7ee2a767 100644 --- a/modules/asteriobidAnalyticsAdapter.js +++ b/modules/asteriobidAnalyticsAdapter.js @@ -17,17 +17,17 @@ const analyticsType = 'endpoint' const analyticsName = 'AsterioBid Analytics' const _VERSION = 1 -let ajax = ajaxBuilder(20000) +const ajax = ajaxBuilder(20000) let initOptions -let auctionStarts = {} -let auctionTimeouts = {} +const auctionStarts = {} +const auctionTimeouts = {} let sampling let pageViewId let flushInterval let eventQueue = [] let asteriobidAnalyticsEnabled = false -let asteriobidAnalytics = Object.assign(adapter({ url: DEFAULT_EVENT_URL, analyticsType }), { +const asteriobidAnalytics = Object.assign(adapter({ url: DEFAULT_EVENT_URL, analyticsType }), { track({ eventType, args }) { handleEvent(eventType, args) } diff --git a/modules/atsAnalyticsAdapter.js b/modules/atsAnalyticsAdapter.js index eaeead6a249..e09c045e479 100644 --- a/modules/atsAnalyticsAdapter.js +++ b/modules/atsAnalyticsAdapter.js @@ -21,11 +21,11 @@ const preflightUrl = 'https://check.analytics.rlcdn.com/check/'; export const analyticsUrl = 'https://analytics.rlcdn.com'; let handlerRequest = []; -let handlerResponse = []; +const handlerResponse = []; -let atsAnalyticsAdapterVersion = 3; +const atsAnalyticsAdapterVersion = 3; -let browsersList = [ +const browsersList = [ /* Googlebot */ { test: /googlebot/i, @@ -207,11 +207,11 @@ let browsersList = [ }, ]; -let listOfSupportedBrowsers = ['Safari', 'Chrome', 'Firefox', 'Microsoft Edge']; +const listOfSupportedBrowsers = ['Safari', 'Chrome', 'Firefox', 'Microsoft Edge']; function bidRequestedHandler(args) { - let envelopeSourceCookieValue = storage.getCookie('_lr_env_src_ats'); - let envelopeSource = envelopeSourceCookieValue === 'true'; + const envelopeSourceCookieValue = storage.getCookie('_lr_env_src_ats'); + const envelopeSource = envelopeSourceCookieValue === 'true'; let requests; requests = args.bids.map(function(bid) { return { @@ -243,12 +243,12 @@ function bidResponseHandler(args) { } export function parseBrowser() { - let ua = atsAnalyticsAdapter.getUserAgent(); + const ua = atsAnalyticsAdapter.getUserAgent(); try { - let result = browsersList.filter(function(obj) { + const result = browsersList.filter(function(obj) { return obj.test.test(ua); }); - let browserName = result && result.length ? result[0].name : ''; + const browserName = result && result.length ? result[0].name : ''; return (listOfSupportedBrowsers.indexOf(browserName) >= 0) ? browserName : 'Unknown'; } catch (err) { logError('ATS Analytics - Error while checking user browser!', err); @@ -258,8 +258,8 @@ export function parseBrowser() { function sendDataToAnalytic (events) { // send data to ats analytic endpoint try { - let dataToSend = {'Data': events}; - let strJSON = JSON.stringify(dataToSend); + const dataToSend = {'Data': events}; + const strJSON = JSON.stringify(dataToSend); logInfo('ATS Analytics - tried to send analytics data!'); ajax(analyticsUrl, function () { logInfo('ATS Analytics - events sent successfully!'); @@ -275,11 +275,11 @@ function preflightRequest (events) { ajax(preflightUrl + atsAnalyticsAdapter.context.pid, { success: function (data) { - let samplingRateObject = JSON.parse(data); + const samplingRateObject = JSON.parse(data); logInfo('ATS Analytics - Sampling Rate: ', samplingRateObject); - let samplingRate = samplingRateObject.samplingRate; + const samplingRate = samplingRateObject.samplingRate; atsAnalyticsAdapter.setSamplingCookie(samplingRate); - let samplingRateNumber = Number(samplingRate); + const samplingRateNumber = Number(samplingRate); if (data && samplingRate && atsAnalyticsAdapter.shouldFireRequest(samplingRateNumber)) { logInfo('ATS Analytics - events to send: ', events); sendDataToAnalytic(events); @@ -292,7 +292,7 @@ function preflightRequest (events) { }, undefined, {method: 'GET', crossOrigin: true}); } -let atsAnalyticsAdapter = Object.assign(adapter( +const atsAnalyticsAdapter = Object.assign(adapter( { analyticsType }), @@ -310,7 +310,7 @@ atsAnalyticsAdapter.originEnableAnalytics = atsAnalyticsAdapter.enableAnalytics; // add check to not fire request every time, but instead to send 1/100 atsAnalyticsAdapter.shouldFireRequest = function (samplingRate) { if (samplingRate !== 0) { - let shouldFireRequestValue = (Math.floor((Math.random() * 100 + 1)) === 100); + const shouldFireRequestValue = (Math.floor((Math.random() * 100 + 1)) === 100); logInfo('ATS Analytics - Should Fire Request: ', shouldFireRequestValue); return shouldFireRequestValue; } else { @@ -340,7 +340,7 @@ atsAnalyticsAdapter.enableAnalytics = function (config) { pid: config.options.pid, bidWonTimeout: config.options.bidWonTimeout }; - let initOptions = config.options; + const initOptions = config.options; logInfo('ATS Analytics - adapter enabled! '); atsAnalyticsAdapter.originEnableAnalytics(initOptions); // call the base class function }; @@ -352,14 +352,14 @@ atsAnalyticsAdapter.callHandler = function (evtype, args) { handlerResponse.push(bidResponseHandler(args)); } if (evtype === EVENTS.AUCTION_END) { - let bidWonTimeout = atsAnalyticsAdapter.context.bidWonTimeout ? atsAnalyticsAdapter.context.bidWonTimeout : 2000; + const bidWonTimeout = atsAnalyticsAdapter.context.bidWonTimeout ? atsAnalyticsAdapter.context.bidWonTimeout : 2000; let events = []; setTimeout(() => { - let winningBids = getGlobal().getAllWinningBids(); + const winningBids = getGlobal().getAllWinningBids(); logInfo('ATS Analytics - winning bids: ', winningBids) // prepare format data for sending to analytics endpoint if (handlerRequest.length) { - let wonEvent = {}; + const wonEvent = {}; if (handlerResponse.length) { events = handlerRequest.filter(request => handlerResponse.filter(function (response) { if (request.bid_id === response.bid_id) { @@ -380,7 +380,7 @@ atsAnalyticsAdapter.callHandler = function (evtype, args) { } // check should we send data to analytics or not, check first cookie value _lr_sampling_rate try { - let samplingRateCookie = storage.getCookie('_lr_sampling_rate'); + const samplingRateCookie = storage.getCookie('_lr_sampling_rate'); if (!samplingRateCookie) { preflightRequest(events); } else { diff --git a/modules/automatadAnalyticsAdapter.js b/modules/automatadAnalyticsAdapter.js index 97f4d0ffd6d..e27061150c6 100644 --- a/modules/automatadAnalyticsAdapter.js +++ b/modules/automatadAnalyticsAdapter.js @@ -197,8 +197,8 @@ const initializeQueue = () => { // ANALYTICS ADAPTER -let baseAdapter = adapter({analyticsType: 'bundle'}); -let atmtdAdapter = Object.assign({}, baseAdapter, { +const baseAdapter = adapter({analyticsType: 'bundle'}); +const atmtdAdapter = Object.assign({}, baseAdapter, { disableAnalytics() { baseAdapter.disableAnalytics.apply(this, arguments); diff --git a/modules/axisBidAdapter.js b/modules/axisBidAdapter.js index 162910076a4..f3fe83a4f78 100644 --- a/modules/axisBidAdapter.js +++ b/modules/axisBidAdapter.js @@ -50,7 +50,7 @@ export const spec = { interpretResponse, getUserSyncs: (syncOptions, serverResponses, gdprConsent, uspConsent, gppConsent) => { - let syncType = syncOptions.iframeEnabled ? 'iframe' : 'image'; + const syncType = syncOptions.iframeEnabled ? 'iframe' : 'image'; let syncUrl = SYNC_URL + `/${syncType}?pbjs=1`; if (gdprConsent && gdprConsent.consentString) { if (typeof gdprConsent.gdprApplies === 'boolean') { diff --git a/modules/axonixBidAdapter.js b/modules/axonixBidAdapter.js index 2eefb617636..42f187fb1db 100644 --- a/modules/axonixBidAdapter.js +++ b/modules/axonixBidAdapter.js @@ -44,7 +44,7 @@ function isConnectedTV() { } function getURL(params, path) { - let { supplyId, region, endpoint } = params; + const { supplyId, region, endpoint } = params; let url; if (endpoint) { @@ -80,7 +80,7 @@ export const spec = { buildRequests: function(validBidRequests, bidderRequest) { // device.connectiontype - let connection = window.navigator && (window.navigator.connection || window.navigator.mozConnection || window.navigator.webkitConnection) + const connection = window.navigator && (window.navigator.connection || window.navigator.mozConnection || window.navigator.webkitConnection) let connectionType = 'unknown'; let effectiveType = ''; diff --git a/modules/beachfrontBidAdapter.js b/modules/beachfrontBidAdapter.js index 7cbd5f8a65a..f592620c3f8 100644 --- a/modules/beachfrontBidAdapter.js +++ b/modules/beachfrontBidAdapter.js @@ -66,9 +66,9 @@ export const spec = { }, buildRequests(bids, bidderRequest) { - let requests = []; - let videoBids = bids.filter(bid => isVideoBidValid(bid)); - let bannerBids = bids.filter(bid => isBannerBidValid(bid)); + const requests = []; + const videoBids = bids.filter(bid => isVideoBidValid(bid)); + const bannerBids = bids.filter(bid => isBannerBidValid(bid)); videoBids.forEach(bid => { appId = getVideoBidParam(bid, 'appId'); requests.push({ @@ -98,12 +98,12 @@ export const spec = { logWarn(`No valid video bids from ${spec.code} bidder`); return []; } - let sizes = getVideoSizes(bidRequest); - let firstSize = getFirstSize(sizes); - let context = deepAccess(bidRequest, 'mediaTypes.video.context'); - let responseType = getVideoBidParam(bidRequest, 'responseType') || 'both'; - let responseMeta = Object.assign({ mediaType: VIDEO, advertiserDomains: [] }, response.meta); - let bidResponse = { + const sizes = getVideoSizes(bidRequest); + const firstSize = getFirstSize(sizes); + const context = deepAccess(bidRequest, 'mediaTypes.video.context'); + const responseType = getVideoBidParam(bidRequest, 'responseType') || 'both'; + const responseMeta = Object.assign({ mediaType: VIDEO, advertiserDomains: [] }, response.meta); + const bidResponse = { requestId: bidRequest.bidId, cpm: response.bidPrice, width: firstSize.w, @@ -134,8 +134,8 @@ export const spec = { return response .filter(bid => bid.adm) .map((bid) => { - let request = ((bidRequest) || []).find(req => req.adUnitCode === bid.slot); - let responseMeta = Object.assign({ mediaType: BANNER, advertiserDomains: [] }, bid.meta); + const request = ((bidRequest) || []).find(req => req.adUnitCode === bid.slot); + const responseMeta = Object.assign({ mediaType: BANNER, advertiserDomains: [] }, bid.meta); return { requestId: request.bidId, bidderCode: spec.code, @@ -155,12 +155,12 @@ export const spec = { }, getUserSyncs(syncOptions, serverResponses = [], gdprConsent = {}, uspConsent = '', gppConsent = {}) { - let { gdprApplies, consentString = '' } = gdprConsent; - let { gppString = '', applicableSections = [] } = gppConsent; - let bannerResponse = ((serverResponses) || []).find((res) => isArray(res.body)); + const { gdprApplies, consentString = '' } = gdprConsent; + const { gppString = '', applicableSections = [] } = gppConsent; + const bannerResponse = ((serverResponses) || []).find((res) => isArray(res.body)); - let syncs = []; - let params = { + const syncs = []; + const params = { id: appId, gdpr: gdprApplies ? 1 : 0, gc: consentString, @@ -230,7 +230,7 @@ function getBannerBidParam(bid, key) { } function getPlayerBidParam(bid, key, defaultValue) { - let param = deepAccess(bid, 'params.player.' + key); + const param = deepAccess(bid, 'params.player.' + key); return param === undefined ? defaultValue : param; } @@ -250,13 +250,13 @@ function getEids(bid) { function getUserId(bid) { return ({ key, source, rtiPartner, atype }) => { - let id = deepAccess(bid, `userId.${key}`); + const id = deepAccess(bid, `userId.${key}`); return id ? formatEid(id, source, rtiPartner, atype) : null; }; } function formatEid(id, source, rtiPartner, atype) { - let uid = { id }; + const uid = { id }; if (rtiPartner) { uid.ext = { rtiPartner }; } @@ -270,16 +270,16 @@ function formatEid(id, source, rtiPartner, atype) { } function createVideoRequestData(bid, bidderRequest) { - let sizes = getVideoSizes(bid); - let firstSize = getFirstSize(sizes); - let video = getVideoTargetingParams(bid, VIDEO_TARGETING); - let appId = getVideoBidParam(bid, 'appId'); - let bidfloor = getVideoBidFloor(bid); - let tagid = getVideoBidParam(bid, 'tagid'); - let topLocation = getTopWindowLocation(bidderRequest); - let eids = getEids(bid); - let ortb2 = deepClone(bidderRequest.ortb2); - let payload = { + const sizes = getVideoSizes(bid); + const firstSize = getFirstSize(sizes); + const video = getVideoTargetingParams(bid, VIDEO_TARGETING); + const appId = getVideoBidParam(bid, 'appId'); + const bidfloor = getVideoBidFloor(bid); + const tagid = getVideoBidParam(bid, 'tagid'); + const topLocation = getTopWindowLocation(bidderRequest); + const eids = getEids(bid); + const ortb2 = deepClone(bidderRequest.ortb2); + const payload = { isPrebid: true, appId: appId, domain: document.location.hostname, @@ -319,13 +319,13 @@ function createVideoRequestData(bid, bidderRequest) { } if (bidderRequest && bidderRequest.gdprConsent) { - let { gdprApplies, consentString } = bidderRequest.gdprConsent; + const { gdprApplies, consentString } = bidderRequest.gdprConsent; deepSetValue(payload, 'regs.ext.gdpr', gdprApplies ? 1 : 0); deepSetValue(payload, 'user.ext.consent', consentString); } if (bidderRequest && bidderRequest.gppConsent) { - let { gppString, applicableSections } = bidderRequest.gppConsent; + const { gppString, applicableSections } = bidderRequest.gppConsent; deepSetValue(payload, 'regs.gpp', gppString); deepSetValue(payload, 'regs.gpp_sid', applicableSections); } @@ -339,7 +339,7 @@ function createVideoRequestData(bid, bidderRequest) { deepSetValue(payload, 'user.ext.eids', eids); } - let connection = navigator.connection || navigator.webkitConnection; + const connection = navigator.connection || navigator.webkitConnection; if (connection && connection.effectiveType) { deepSetValue(payload, 'device.connectiontype', connection.effectiveType); } @@ -348,9 +348,9 @@ function createVideoRequestData(bid, bidderRequest) { } function createBannerRequestData(bids, bidderRequest) { - let topLocation = getTopWindowLocation(bidderRequest); - let topReferrer = bidderRequest.refererInfo?.ref; - let slots = bids.map(bid => { + const topLocation = getTopWindowLocation(bidderRequest); + const topReferrer = bidderRequest.refererInfo?.ref; + const slots = bids.map(bid => { return { slot: bid.adUnitCode, id: getBannerBidParam(bid, 'appId'), @@ -359,8 +359,8 @@ function createBannerRequestData(bids, bidderRequest) { sizes: getBannerSizes(bid) }; }); - let ortb2 = deepClone(bidderRequest.ortb2); - let payload = { + const ortb2 = deepClone(bidderRequest.ortb2); + const payload = { slots: slots, ortb2: ortb2, page: topLocation.href, @@ -381,13 +381,13 @@ function createBannerRequestData(bids, bidderRequest) { } if (bidderRequest && bidderRequest.gdprConsent) { - let { gdprApplies, consentString } = bidderRequest.gdprConsent; + const { gdprApplies, consentString } = bidderRequest.gdprConsent; payload.gdpr = gdprApplies ? 1 : 0; payload.gdprConsent = consentString; } if (bidderRequest && bidderRequest.gppConsent) { - let { gppString, applicableSections } = bidderRequest.gppConsent; + const { gppString, applicableSections } = bidderRequest.gppConsent; payload.gpp = gppString; payload.gppSid = applicableSections; } @@ -398,7 +398,7 @@ function createBannerRequestData(bids, bidderRequest) { } SUPPORTED_USER_IDS.forEach(({ key, queryParam }) => { - let id = deepAccess(bids, `0.userId.${key}`) + const id = deepAccess(bids, `0.userId.${key}`) if (id) { payload[queryParam] = id; } diff --git a/modules/bedigitechBidAdapter.js b/modules/bedigitechBidAdapter.js index 9e59a2509a6..0baeea7470f 100644 --- a/modules/bedigitechBidAdapter.js +++ b/modules/bedigitechBidAdapter.js @@ -40,7 +40,7 @@ export const spec = { buildRequests: (bidRequests) => { return bidRequests.map(bid => { - let url = BEDIGITECH_ENDPOINT; + const url = BEDIGITECH_ENDPOINT; const data = {'pid': bid.params.placementId}; return { method: BEDIGITECH_REQUEST_METHOD, @@ -56,7 +56,7 @@ export const spec = { }, interpretResponse: function(serverResponse) { - let bids = []; + const bids = []; if (isArray(serverResponse.body)) { _each(serverResponse.body, function(placementResponse) { interpretResponse(placementResponse, bids); diff --git a/modules/beopBidAdapter.js b/modules/beopBidAdapter.js index e58cf0f1708..b7e6bb49ac5 100644 --- a/modules/beopBidAdapter.js +++ b/modules/beopBidAdapter.js @@ -66,14 +66,14 @@ export const spec = { const gdpr = bidderRequest.gdprConsent; const firstSlot = slots[0]; const kwdsFromRequest = firstSlot.kwds; - let keywords = getAllOrtbKeywords(bidderRequest.ortb2, kwdsFromRequest); + const keywords = getAllOrtbKeywords(bidderRequest.ortb2, kwdsFromRequest); let beopid = ''; if (storage.cookiesAreEnabled) { beopid = storage.getCookie(COOKIE_NAME, undefined); if (!beopid) { beopid = generateUUID(); - let expirationDate = new Date(); + const expirationDate = new Date(); expirationDate.setTime(expirationDate.getTime() + 86400 * 183 * 1000); storage.setCookie(COOKIE_NAME, beopid, expirationDate.toUTCString()); } @@ -118,7 +118,7 @@ export const spec = { return; } - let trackingParams = buildTrackingParams(timeoutData, 'timeout', timeoutData.timeout); + const trackingParams = buildTrackingParams(timeoutData, 'timeout', timeoutData.timeout); logWarn(BIDDER_CODE + ': timed out request'); triggerPixel(buildUrl({ @@ -132,7 +132,7 @@ export const spec = { if (bid === null || typeof bid === 'undefined' || Object.keys(bid).length === 0) { return; } - let trackingParams = buildTrackingParams(bid, 'won', bid.cpm); + const trackingParams = buildTrackingParams(bid, 'won', bid.cpm); logInfo(BIDDER_CODE + ': won request'); triggerPixel(buildUrl({ @@ -174,7 +174,7 @@ export const spec = { } function buildTrackingParams(data, info, value) { - let params = Array.isArray(data.params) ? data.params[0] : data.params; + const params = Array.isArray(data.params) ? data.params[0] : data.params; const pageUrl = getPageUrl(null, window); return { pid: params.accountId ?? (data.ad?.match(/account: \“([a-f\d]{24})\“/)?.[1] ?? ''), diff --git a/modules/betweenBidAdapter.js b/modules/betweenBidAdapter.js index 24d3ad22480..4ae4d525036 100644 --- a/modules/betweenBidAdapter.js +++ b/modules/betweenBidAdapter.js @@ -14,7 +14,7 @@ import {getAdUnitSizes} from '../libraries/sizeUtils/sizeUtils.js'; const BIDDER_CODE = 'between'; const GVLID = 724; -let ENDPOINT = 'https://ads.betweendigital.com/adjson?t=prebid'; +const ENDPOINT = 'https://ads.betweendigital.com/adjson?t=prebid'; const CODE_TYPES = ['inpage', 'preroll', 'midroll', 'postroll']; export const spec = { @@ -38,14 +38,14 @@ export const spec = { * @return ServerRequest Info describing the request to the server. */ buildRequests: function(validBidRequests, bidderRequest) { - let requests = []; + const requests = []; const gdprConsent = bidderRequest && bidderRequest.gdprConsent; const refInfo = bidderRequest?.refererInfo; validBidRequests.forEach((i) => { const video = i.mediaTypes && i.mediaTypes.video; - let params = { + const params = { eids: getUsersIds(i), sizes: parseSizesInput(getAdUnitSizes(i)), jst: 'hb', @@ -82,7 +82,7 @@ export const spec = { params.click3rd = i.params.click3rd; } if (i.params.pubdata !== undefined) { - for (let key in i.params.pubdata) { + for (const key in i.params.pubdata) { params['pubside_macro[' + key + ']'] = encodeURIComponent(i.params.pubdata[key]); } } @@ -123,7 +123,7 @@ export const spec = { const bidResponses = []; for (var i = 0; i < serverResponse.body.length; i++) { - let bidResponse = { + const bidResponse = { requestId: serverResponse.body[i].bidid, cpm: serverResponse.body[i].cpm || 0, width: serverResponse.body[i].w, @@ -153,7 +153,7 @@ export const spec = { * @return {UserSync[]} The user syncs which should be dropped. */ getUserSyncs: function(syncOptions, serverResponses) { - let syncs = [] + const syncs = [] /* console.log(syncOptions,serverResponses) if (syncOptions.iframeEnabled) { syncs.push({ diff --git a/modules/bidViewability.js b/modules/bidViewability.js index 57788ccb402..a3970a59f9e 100644 --- a/modules/bidViewability.js +++ b/modules/bidViewability.js @@ -17,11 +17,11 @@ const CONFIG_CUSTOM_MATCH = 'customMatchFunction'; const BID_VURL_ARRAY = 'vurls'; const GPT_IMPRESSION_VIEWABLE_EVENT = 'impressionViewable'; -export let isBidAdUnitCodeMatchingSlot = (bid, slot) => { +export const isBidAdUnitCodeMatchingSlot = (bid, slot) => { return (slot.getAdUnitPath() === bid.adUnitCode || slot.getSlotElementId() === bid.adUnitCode); } -export let getMatchingWinningBidForGPTSlot = (globalModuleConfig, slot) => { +export const getMatchingWinningBidForGPTSlot = (globalModuleConfig, slot) => { return getGlobal().getAllWinningBids().find( // supports custom match function from config bid => isFn(globalModuleConfig[CONFIG_CUSTOM_MATCH]) @@ -30,9 +30,9 @@ export let getMatchingWinningBidForGPTSlot = (globalModuleConfig, slot) => { ) || null; }; -export let fireViewabilityPixels = (globalModuleConfig, bid) => { +export const fireViewabilityPixels = (globalModuleConfig, bid) => { if (globalModuleConfig[CONFIG_FIRE_PIXELS] === true && bid.hasOwnProperty(BID_VURL_ARRAY)) { - let queryParams = gdprParams(); + const queryParams = gdprParams(); const uspConsent = uspDataHandler.getConsentData(); if (uspConsent) { queryParams.us_privacy = uspConsent; } @@ -54,13 +54,13 @@ export let fireViewabilityPixels = (globalModuleConfig, bid) => { } }; -export let logWinningBidNotFound = (slot) => { +export const logWinningBidNotFound = (slot) => { logWarn(`bid details could not be found for ${slot.getSlotElementId()}, probable reasons: a non-prebid bid is served OR check the prebid.AdUnit.code to GPT.AdSlot relation.`); }; -export let impressionViewableHandler = (globalModuleConfig, event) => { +export const impressionViewableHandler = (globalModuleConfig, event) => { const slot = event.slot; - let respectiveBid = getMatchingWinningBidForGPTSlot(globalModuleConfig, slot); + const respectiveBid = getMatchingWinningBidForGPTSlot(globalModuleConfig, slot); if (respectiveBid === null) { logWinningBidNotFound(slot); diff --git a/modules/bidViewabilityIO.js b/modules/bidViewabilityIO.js index 61b8af66bf8..195b551c85b 100644 --- a/modules/bidViewabilityIO.js +++ b/modules/bidViewabilityIO.js @@ -19,16 +19,16 @@ const supportedMediaTypes = [ 'banner' ]; -export let isSupportedMediaType = (bid) => { +export const isSupportedMediaType = (bid) => { return supportedMediaTypes.indexOf(bid.mediaType) > -1; } -let _logMessage = (message) => { +const _logMessage = (message) => { return logMessage(`${MODULE_NAME}: ${message}`); } // returns options for the iO that detects if the ad is viewable -export let getViewableOptions = (bid) => { +export const getViewableOptions = (bid) => { if (bid.mediaType === 'banner') { return { root: null, @@ -39,7 +39,7 @@ export let getViewableOptions = (bid) => { } // markViewed returns a function what will be executed when an ad satisifes the viewable iO -export let markViewed = (bid, entry, observer) => { +export const markViewed = (bid, entry, observer) => { return () => { observer.unobserve(entry.target); events.emit(EVENTS.BID_VIEWABLE, bid); @@ -55,7 +55,7 @@ export let markViewed = (bid, entry, observer) => { // is cancelled, an the bid will not be marked as viewed. There's probably some kind of race-ish // thing going on between IO and setTimeout but this isn't going to be perfect, it's just going to // be pretty good. -export let viewCallbackFactory = (bid) => { +export const viewCallbackFactory = (bid) => { return (entries, observer) => { entries.forEach(entry => { if (entry.isIntersecting) { @@ -72,15 +72,15 @@ export let viewCallbackFactory = (bid) => { }; }; -export let init = () => { +export const init = () => { config.getConfig(MODULE_NAME, conf => { if (conf[MODULE_NAME][CONFIG_ENABLED] && CLIENT_SUPPORTS_IO) { // if the module is enabled and the browser supports Intersection Observer, // then listen to AD_RENDER_SUCCEEDED to setup IO's for supported mediaTypes events.on(EVENTS.AD_RENDER_SUCCEEDED, ({doc, bid, id}) => { if (isSupportedMediaType(bid)) { - let viewable = new IntersectionObserver(viewCallbackFactory(bid), getViewableOptions(bid)); - let element = document.getElementById(bid.adUnitCode); + const viewable = new IntersectionObserver(viewCallbackFactory(bid), getViewableOptions(bid)); + const element = document.getElementById(bid.adUnitCode); viewable.observe(element); } }); diff --git a/modules/bidglassBidAdapter.js b/modules/bidglassBidAdapter.js index 43762162ace..75999a8123e 100644 --- a/modules/bidglassBidAdapter.js +++ b/modules/bidglassBidAdapter.js @@ -49,11 +49,11 @@ export const spec = { }] */ - let imps = []; - let getReferer = function() { + const imps = []; + const getReferer = function() { return window === window.top ? window.location.href : window.parent === window.top ? document.referrer : null; }; - let getOrigins = function() { + const getOrigins = function() { var ori = [window.location.protocol + '//' + window.location.hostname]; if (window.location.ancestorOrigins) { @@ -75,7 +75,7 @@ export const spec = { return ori; }; - let bidglass = window['bidglass']; + const bidglass = window['bidglass']; _each(validBidRequests, function(bid) { bid.sizes = ((isArray(bid.sizes) && isArray(bid.sizes[0])) ? bid.sizes : [bid.sizes]); @@ -88,7 +88,7 @@ export const spec = { // Merge externally set targeting params if (typeof bidglass === 'object' && bidglass.getTargeting) { - let targeting = bidglass.getTargeting(adUnitId, options.targeting); + const targeting = bidglass.getTargeting(adUnitId, options.targeting); if (targeting && Object.keys(targeting).length > 0) options.targeting = targeting; } @@ -129,7 +129,7 @@ export const spec = { : ((ortb2Gpp && ortb2Regs.gpp_sid) || '') }; - let url = 'https://bid.glass/ad/hb.php?' + + const url = 'https://bid.glass/ad/hb.php?' + `src=$$REPO_AND_VERSION$$`; return { @@ -183,7 +183,7 @@ export const spec = { }; if (serverBid.meta) { - let meta = serverBid.meta; + const meta = serverBid.meta; if (meta.advertiserDomains && meta.advertiserDomains.length) { bidResponse.meta.advertiserDomains = meta.advertiserDomains; diff --git a/modules/bidtheatreBidAdapter.js b/modules/bidtheatreBidAdapter.js index 8fb3dc2fd3b..b8d1c075fa3 100644 --- a/modules/bidtheatreBidAdapter.js +++ b/modules/bidtheatreBidAdapter.js @@ -76,7 +76,7 @@ export const spec = { } data.imp.forEach((impObj, index) => { - let publisherId = bidRequests[index].params.publisherId; + const publisherId = bidRequests[index].params.publisherId; if (publisherId) { deepSetValue(impObj, 'ext.bidder.publisherId', publisherId); diff --git a/modules/bitmediaBidAdapter.js b/modules/bitmediaBidAdapter.js index c07c3b4b228..7825c714f46 100644 --- a/modules/bitmediaBidAdapter.js +++ b/modules/bitmediaBidAdapter.js @@ -53,7 +53,7 @@ const _getFidFromBitmediaFid = (bitmediaFid) => { const _getBidFloor = (bid, size) => { logInfo(BIDDER_CODE, '[Bid Floor] Retrieving bid floor for bid:', bid, size); if (isFn(bid.getFloor)) { - let floor = bid.getFloor({ + const floor = bid.getFloor({ currency: DEFAULT_CURRENCY, mediaType: BANNER, size: size || '*' diff --git a/modules/bliinkBidAdapter.js b/modules/bliinkBidAdapter.js index 62c2cc47872..be6faec70b6 100644 --- a/modules/bliinkBidAdapter.js +++ b/modules/bliinkBidAdapter.js @@ -209,7 +209,7 @@ export const buildRequests = (validBidRequests, bidderRequest) => { return request; }); - let request = { + const request = { tags, pageTitle: document.title, pageUrl: deepAccess(bidderRequest, 'refererInfo.page').replace(/\?.*$/, ''), @@ -275,7 +275,7 @@ const interpretResponse = (serverResponse) => { * @return {[{type: string, url: string}]|*[]} */ const getUserSyncs = (syncOptions, serverResponses, gdprConsent, uspConsent) => { - let syncs = []; + const syncs = []; if (syncOptions.pixelEnabled && serverResponses.length > 0) { let gdprParams = '' let uspConsentStr = '' diff --git a/modules/blueBidAdapter.js b/modules/blueBidAdapter.js index 522e855b43e..55daedb7d0f 100644 --- a/modules/blueBidAdapter.js +++ b/modules/blueBidAdapter.js @@ -50,7 +50,7 @@ export const spec = { interpretResponse: (serverResponse) => { if (!serverResponse || isEmpty(serverResponse.body)) return []; - let bids = []; + const bids = []; serverResponse.body.seatbid.forEach((response) => { response.bid.forEach((bid) => { const baseBid = buildBidObjectBase(bid, serverResponse.body, BIDDER_CODE, DEFAULT_CURRENCY); diff --git a/modules/bmsBidAdapter.js b/modules/bmsBidAdapter.js index e432208e3f3..d6c38349ab1 100644 --- a/modules/bmsBidAdapter.js +++ b/modules/bmsBidAdapter.js @@ -51,7 +51,7 @@ export const spec = { interpretResponse: (serverResponse) => { if (!serverResponse || isEmpty(serverResponse.body)) return []; - let bids = []; + const bids = []; serverResponse.body.seatbid.forEach((response) => { response.bid.forEach((bid) => { const baseBid = buildBidObjectBase(bid, serverResponse.body, BIDDER_CODE, DEFAULT_CURRENCY); diff --git a/modules/bmtmBidAdapter.js b/modules/bmtmBidAdapter.js index 1047ec931cc..9346e9c4bc7 100644 --- a/modules/bmtmBidAdapter.js +++ b/modules/bmtmBidAdapter.js @@ -24,9 +24,9 @@ export const spec = { }, buildRequests: (validBidRequests, bidderRequest) => { - let requestData = []; + const requestData = []; let size = [0, 0]; - let oRTBRequest = { + const oRTBRequest = { at: 2, site: buildSite(bidderRequest), device: buildDevice(), @@ -95,7 +95,7 @@ export const spec = { }, interpretResponse: (serverResponse, { bidRequest }) => { - let bidResponse = []; + const bidResponse = []; let bid; let response; @@ -111,7 +111,7 @@ export const spec = { return []; } - let tempResponse = { + const tempResponse = { requestId: bidRequest.bidId, cpm: bid.price, currency: response.cur, @@ -151,7 +151,7 @@ registerBidder(spec); function buildSite(bidderRequest) { // TODO: should name/domain be the domain? - let site = { + const site = { name: window.location.hostname, publisher: { domain: window.location.hostname, @@ -186,7 +186,7 @@ function buildDevice() { } function buildRegs(bidderRequest) { - let regs = { + const regs = { coppa: config.getConfig('coppa') == true ? 1 : 0, }; diff --git a/modules/brainxBidAdapter.js b/modules/brainxBidAdapter.js index 69832987fb7..8770b94b56a 100644 --- a/modules/brainxBidAdapter.js +++ b/modules/brainxBidAdapter.js @@ -55,15 +55,15 @@ export const spec = { } }, interpretResponse(response, request) { - let bids = []; + const bids = []; if (response.body && response.body.seatbid && isArray(response.body.seatbid)) { response.body.seatbid.forEach(function (bidder) { if (isArray(bidder.bid)) { bidder.bid.map((bid) => { - let serverBody = response.body; + const serverBody = response.body; // bidRequest = request.originalBidRequest, - let mediaType = BANNER; - let currency = serverBody.cur || 'USD' + const mediaType = BANNER; + const currency = serverBody.cur || 'USD' const cpm = (parseFloat(bid.price) || 0).toFixed(2); const categories = deepAccess(bid, 'cat', []); diff --git a/modules/bridgewellBidAdapter.js b/modules/bridgewellBidAdapter.js index 62ac2e14e5f..9b7ff2fd0c9 100644 --- a/modules/bridgewellBidAdapter.js +++ b/modules/bridgewellBidAdapter.js @@ -119,12 +119,12 @@ export const spec = { return; } - let matchedResponse = ((serverResponse.body) || []).find(function (res) { + const matchedResponse = ((serverResponse.body) || []).find(function (res) { let valid = false; if (res && !res.consumed) { - let mediaTypes = req.mediaTypes; - let adUnitCode = req.adUnitCode; + const mediaTypes = req.mediaTypes; + const adUnitCode = req.adUnitCode; if (res.adUnitCode) { return res.adUnitCode === adUnitCode; } else if (res.width && res.height && mediaTypes) { @@ -132,9 +132,9 @@ export const spec = { valid = true; } else if (mediaTypes.banner) { if (mediaTypes.banner.sizes) { - let width = res.width; - let height = res.height; - let sizes = mediaTypes.banner.sizes; + const width = res.width; + const height = res.height; + const sizes = mediaTypes.banner.sizes; // check response size validation if (typeof sizes[0] === 'number') { // for foramt Array[Number] check valid = width === sizes[0] && height === sizes[1]; @@ -195,11 +195,11 @@ export const spec = { return; } - let reqNativeLayout = req.mediaTypes.native; - let resNative = matchedResponse.native; + const reqNativeLayout = req.mediaTypes.native; + const resNative = matchedResponse.native; // check title - let title = reqNativeLayout.title; + const title = reqNativeLayout.title; if (title && title.required) { if (typeof resNative.title !== 'string') { return; @@ -209,7 +209,7 @@ export const spec = { } // check body - let body = reqNativeLayout.body; + const body = reqNativeLayout.body; if (body && body.required) { if (typeof resNative.body !== 'string') { return; @@ -217,7 +217,7 @@ export const spec = { } // check image - let image = reqNativeLayout.image; + const image = reqNativeLayout.image; if (image && image.required) { if (resNative.image) { if (typeof resNative.image.url !== 'string') { // check image url @@ -233,7 +233,7 @@ export const spec = { } // check sponsoredBy - let sponsoredBy = reqNativeLayout.sponsoredBy; + const sponsoredBy = reqNativeLayout.sponsoredBy; if (sponsoredBy && sponsoredBy.required) { if (typeof resNative.sponsoredBy !== 'string') { return; @@ -241,7 +241,7 @@ export const spec = { } // check icon - let icon = reqNativeLayout.icon; + const icon = reqNativeLayout.icon; if (icon && icon.required) { if (resNative.icon) { if (typeof resNative.icon.url !== 'string') { // check icon url @@ -262,7 +262,7 @@ export const spec = { } // check clickTracker - let clickTrackers = resNative.clickTrackers; + const clickTrackers = resNative.clickTrackers; if (clickTrackers) { if (clickTrackers.length === 0) { return; @@ -272,7 +272,7 @@ export const spec = { } // check impressionTrackers - let impressionTrackers = resNative.impressionTrackers; + const impressionTrackers = resNative.impressionTrackers; if (impressionTrackers) { if (impressionTrackers.length === 0) { return; diff --git a/modules/browsiAnalyticsAdapter.js b/modules/browsiAnalyticsAdapter.js index 6bf0ba8da5f..fb854eafbad 100644 --- a/modules/browsiAnalyticsAdapter.js +++ b/modules/browsiAnalyticsAdapter.js @@ -13,9 +13,9 @@ const EVENT_SERVER_URL = `https://events.browsiprod.com/events/v2`; /** @type {null|Object} */ let _staticData = null; /** @type {string} */ -let VERSION = getGlobal().version; +const VERSION = getGlobal().version; /** @type {string} */ -let URL = encodeURIComponent(window.location.href); +const URL = encodeURIComponent(window.location.href); const { AUCTION_END, BROWSI_INIT, BROWSI_DATA } = EVENTS; @@ -118,7 +118,7 @@ function sendEvent(event, topic) { } catch (err) { logMessage('Browsi Analytics error') } } -let browsiAnalytics = Object.assign(adapter({ url: EVENT_SERVER_URL, analyticsType }), { +const browsiAnalytics = Object.assign(adapter({ url: EVENT_SERVER_URL, analyticsType }), { track({ eventType, args }) { switch (eventType) { case BROWSI_INIT: diff --git a/modules/browsiRtdProvider.js b/modules/browsiRtdProvider.js index 69d0a1ad33f..7d5611b741c 100644 --- a/modules/browsiRtdProvider.js +++ b/modules/browsiRtdProvider.js @@ -56,7 +56,7 @@ let _browsiData = null; /** @type {null | function} */ let _dataReadyCallback = null; /** @type {null|Object} */ -let _ic = {}; +const _ic = {}; /** @type {null|number} */ let TIMESTAMP = null; @@ -145,7 +145,7 @@ function waitForData(callback) { * @param {Object} data */ export function addBrowsiTag(data) { - let script = loadExternalScript(data.u, MODULE_TYPE_RTD, 'browsi'); + const script = loadExternalScript(data.u, MODULE_TYPE_RTD, 'browsi'); script.async = true; script.setAttribute('data-sitekey', _moduleParams.siteKey); script.setAttribute('data-pubkey', _moduleParams.pubKey); @@ -267,7 +267,7 @@ function getKVObject(k, p) { * @param {string} url server url with query params */ function getPredictionsFromServer(url) { - let ajax = ajaxBuilder(); + const ajax = ajaxBuilder(); ajax(url, { diff --git a/modules/bucksenseBidAdapter.js b/modules/bucksenseBidAdapter.js index e032e40a8c3..9ac8dce80a0 100644 --- a/modules/bucksenseBidAdapter.js +++ b/modules/bucksenseBidAdapter.js @@ -41,7 +41,7 @@ export const spec = { */ buildRequests: function (validBidRequests, bidderRequest) { logInfo(WHO + ' buildRequests() - INPUT validBidRequests:', validBidRequests, 'INPUT bidderRequest:', bidderRequest); - let requests = []; + const requests = []; const len = validBidRequests.length; for (let i = 0; i < len; i++) { var bid = validBidRequests[i]; @@ -108,7 +108,7 @@ export const spec = { nCPM = request.data.params.testcpm; } - let bidResponse = { + const bidResponse = { requestId: sRequestID, cpm: nCPM, width: nWidth, diff --git a/modules/buzzoolaBidAdapter.js b/modules/buzzoolaBidAdapter.js index ae77ee159bc..9cfdf4cddd9 100644 --- a/modules/buzzoolaBidAdapter.js +++ b/modules/buzzoolaBidAdapter.js @@ -27,7 +27,7 @@ export const spec = { * @return {boolean} True if this is a valid bid, and false otherwise. */ isBidRequestValid: function (bid) { - let types = bid.mediaTypes; + const types = bid.mediaTypes; return !!(bid && bid.mediaTypes && (types.banner || types.video || types.native) && bid.params && bid.params.placementId); }, @@ -56,7 +56,7 @@ export const spec = { * @return {Bid[]} An array of bids which were nested inside the server. */ interpretResponse: function ({body}, {data}) { - let requestBids = {}; + const requestBids = {}; let response; try { @@ -70,12 +70,12 @@ export const spec = { data.bids.forEach(bid => requestBids[bid.bidId] = bid); return response.map(bid => { - let requestBid = requestBids[bid.requestId]; - let context = deepAccess(requestBid, 'mediaTypes.video.context'); - let validBid = deepClone(bid); + const requestBid = requestBids[bid.requestId]; + const context = deepAccess(requestBid, 'mediaTypes.video.context'); + const validBid = deepClone(bid); if (validBid.mediaType === VIDEO && context === OUTSTREAM) { - let renderer = Renderer.install({ + const renderer = Renderer.install({ id: validBid.requestId, url: RENDERER_SRC, loaded: false @@ -96,9 +96,9 @@ export const spec = { * @param bid */ function setOutstreamRenderer(bid) { - let adData = JSON.parse(bid.ad); - let unitSettings = deepAccess(adData, 'placement.unit_settings'); - let extendedSettings = { + const adData = JSON.parse(bid.ad); + const unitSettings = deepAccess(adData, 'placement.unit_settings'); + const extendedSettings = { width: '' + bid.width, height: '' + bid.height, container_height: '' + bid.height diff --git a/modules/byDataAnalyticsAdapter.js b/modules/byDataAnalyticsAdapter.js index ce4274c1259..ddc1112796d 100644 --- a/modules/byDataAnalyticsAdapter.js +++ b/modules/byDataAnalyticsAdapter.js @@ -320,7 +320,7 @@ ascAdapter.dataProcess = function (t) { ascAdapter.sendPayload = function (data) { var obj = { 'records': [{ 'value': data }] }; - let strJSON = JSON.stringify(obj); + const strJSON = JSON.stringify(obj); sendDataOnKf(strJSON); } diff --git a/modules/c1xBidAdapter.js b/modules/c1xBidAdapter.js index 6dd3c54e6af..3ead617c2c9 100644 --- a/modules/c1xBidAdapter.js +++ b/modules/c1xBidAdapter.js @@ -51,7 +51,7 @@ export const c1xAdapter = { buildRequests: function (validBidRequests, bidderRequest) { let payload = {}; let tagObj = {}; - let bidRequest = []; + const bidRequest = []; const adunits = validBidRequests.length; const rnd = new Date().getTime(); const c1xTags = validBidRequests.map(bidToTag); @@ -75,7 +75,7 @@ export const c1xAdapter = { } Object.assign(payload, tagObj); - let payloadString = stringifyPayload(payload); + const payloadString = stringifyPayload(payload); // ServerRequest object bidRequest.push({ method: 'GET', @@ -94,7 +94,7 @@ export const c1xAdapter = { let netRevenue = false; if (!serverResponse || serverResponse.error) { - let errorMessage = serverResponse.error; + const errorMessage = serverResponse.error; logError(LOG_MSG.invalidBid + errorMessage); return bidResponses; } else { @@ -184,7 +184,7 @@ function getBidFloor(bidRequest) { }); } - let floor = + const floor = floorInfo?.floor || bidRequest.params.bidfloor || bidRequest.params.floorPriceMap || @@ -201,7 +201,7 @@ function bidToShortTag(bid) { } function stringifyPayload(payload) { - let payloadString = []; + const payloadString = []; for (var key in payload) { if (payload.hasOwnProperty(key)) { payloadString.push(key + '=' + payload[key]); diff --git a/modules/cadent_aperture_mxBidAdapter.js b/modules/cadent_aperture_mxBidAdapter.js index df1e27f7d07..2b80105ed78 100644 --- a/modules/cadent_aperture_mxBidAdapter.js +++ b/modules/cadent_aperture_mxBidAdapter.js @@ -98,7 +98,7 @@ export const cadentAdapter = { }, outstreamRender: (bid) => { bid.renderer.push(function () { - let params = (bid && bid.params && bid.params[0] && bid.params[0].video) ? bid.params[0].video : {}; + const params = (bid && bid.params && bid.params[0] && bid.params[0].video) ? bid.params[0].video : {}; window.emxVideoQueue = window.emxVideoQueue || []; window.queueEmxVideo({ id: bid.adUnitCode, @@ -125,7 +125,7 @@ export const cadentAdapter = { return renderer; }, buildVideo: (bid) => { - let videoObj = Object.assign(bid.mediaTypes.video, bid.params.video); + const videoObj = Object.assign(bid.mediaTypes.video, bid.params.video); if (isArray(bid.mediaTypes.video.playerSize[0])) { videoObj['w'] = bid.mediaTypes.video.playerSize[0][0]; @@ -205,7 +205,7 @@ export const cadentAdapter = { }, getUserId(bidRequests) { return ({ key, source, rtiPartner }) => { - let id = deepAccess(bidRequests, `userId.${key}`); + const id = deepAccess(bidRequests, `userId.${key}`); return id ? cadentAdapter.formatEid(id, source, rtiPartner) : null; }; }, @@ -267,10 +267,10 @@ export const spec = { const site = cadentAdapter.getSite(bidderRequest.refererInfo); _each(validBidRequests, function (bid) { - let tagid = getBidIdParameter('tagid', bid.params); - let bidfloor = parseFloat(getBidFloor(bid)) || 0; - let isVideo = !!bid.mediaTypes.video; - let data = { + const tagid = getBidIdParameter('tagid', bid.params); + const bidfloor = parseFloat(getBidFloor(bid)) || 0; + const isVideo = !!bid.mediaTypes.video; + const data = { id: bid.bidId, tid: bid.ortb2Imp?.ext?.tid, tagid, @@ -278,16 +278,16 @@ export const spec = { }; // adding gpid support - let gpid = + const gpid = deepAccess(bid, 'ortb2Imp.ext.gpid') || deepAccess(bid, 'ortb2Imp.ext.data.adserver.adslot') if (gpid) { data.ext = { gpid: gpid.toString() }; } - let typeSpecifics = isVideo ? { video: cadentAdapter.buildVideo(bid) } : { banner: cadentAdapter.buildBanner(bid) }; - let bidfloorObj = bidfloor > 0 ? { bidfloor, bidfloorcur: DEFAULT_CUR } : {}; - let cadentBid = Object.assign(data, typeSpecifics, bidfloorObj); + const typeSpecifics = isVideo ? { video: cadentAdapter.buildVideo(bid) } : { banner: cadentAdapter.buildBanner(bid) }; + const bidfloorObj = bidfloor > 0 ? { bidfloor, bidfloorcur: DEFAULT_CUR } : {}; + const cadentBid = Object.assign(data, typeSpecifics, bidfloorObj); cadentImps.push(cadentBid); }); @@ -309,7 +309,7 @@ export const spec = { // adding eid support if (bidderRequest.userId) { - let eids = cadentAdapter.getEids(bidderRequest); + const eids = cadentAdapter.getEids(bidderRequest); if (eids.length > 0) { if (cadentData.user && cadentData.user.ext) { cadentData.user.ext.eids = eids; @@ -332,13 +332,13 @@ export const spec = { }; }, interpretResponse: function (serverResponse, bidRequest) { - let cadentBidResponses = []; - let response = serverResponse.body || {}; + const cadentBidResponses = []; + const response = serverResponse.body || {}; if (response.seatbid && response.seatbid.length > 0 && response.seatbid[0].bid) { response.seatbid.forEach(function (cadentBid) { cadentBid = cadentBid.bid[0]; let isVideo = false; - let adm = cadentAdapter.parseResponse(cadentBid.adm) || ''; + const adm = cadentAdapter.parseResponse(cadentBid.adm) || ''; let bidResponse = { requestId: cadentBid.id, cpm: cadentBid.price, @@ -411,7 +411,7 @@ function getBidFloor(bid) { return parseFloat(getBidIdParameter('bidfloor', bid.params)); } - let floor = bid.getFloor({ + const floor = bid.getFloor({ currency: DEFAULT_CUR, mediaType: '*', size: '*' diff --git a/modules/carodaBidAdapter.js b/modules/carodaBidAdapter.js index 75af70da4ff..9c8975542eb 100644 --- a/modules/carodaBidAdapter.js +++ b/modules/carodaBidAdapter.js @@ -154,7 +154,7 @@ function getTopUsableWindow () { function getORTBCommon (bidderRequest) { let app, site; const commonFpd = bidderRequest.ortb2 || {}; - let { user } = commonFpd; + const { user } = commonFpd; if (typeof getConfig('app') === 'object') { app = getConfig('app') || {} if (commonFpd.app) { diff --git a/modules/categoryTranslation.js b/modules/categoryTranslation.js index eb6cb83730a..a0ef902412e 100644 --- a/modules/categoryTranslation.js +++ b/modules/categoryTranslation.js @@ -44,7 +44,7 @@ export const getAdserverCategoryHook = timedBidResponseHook('categoryTranslation return fn.call(this, adUnitCode, bid, reject); } - let localStorageKey = (config.getConfig('brandCategoryTranslation.translationFile')) ? DEFAULT_IAB_TO_FW_MAPPING_KEY_PUB : DEFAULT_IAB_TO_FW_MAPPING_KEY; + const localStorageKey = (config.getConfig('brandCategoryTranslation.translationFile')) ? DEFAULT_IAB_TO_FW_MAPPING_KEY_PUB : DEFAULT_IAB_TO_FW_MAPPING_KEY; if (bid.meta && !bid.meta.adServerCatId) { let mapping = storage.getDataFromLocalStorage(localStorageKey); diff --git a/modules/ccxBidAdapter.js b/modules/ccxBidAdapter.js index 1b1bd7162ae..e564323d059 100644 --- a/modules/ccxBidAdapter.js +++ b/modules/ccxBidAdapter.js @@ -11,7 +11,7 @@ const SUPPORTED_VIDEO_MIMES = ['video/mp4', 'video/x-flv'] const SUPPORTED_VIDEO_PLAYBACK_METHODS = [1, 2, 3, 4] function _getDeviceObj () { - let device = {} + const device = {} device.w = screen.width device.y = screen.height device.ua = navigator.userAgent @@ -19,7 +19,7 @@ function _getDeviceObj () { } function _getSiteObj (bidderRequest) { - let site = {} + const site = {} let url = bidderRequest?.refererInfo?.page || '' if (url.length > 0) { url = url.split('?')[0] @@ -66,11 +66,11 @@ function _validateSizes (sizeObj, type) { } function _buildBid (bid, bidderRequest) { - let placement = {} + const placement = {} placement.id = bid.bidId placement.secure = 1 - let sizes = deepAccess(bid, 'mediaTypes.banner.sizes') || deepAccess(bid, 'mediaTypes.video.playerSize') || deepAccess(bid, 'sizes') + const sizes = deepAccess(bid, 'mediaTypes.banner.sizes') || deepAccess(bid, 'mediaTypes.video.playerSize') || deepAccess(bid, 'sizes') if (deepAccess(bid, 'mediaTypes.banner') || deepAccess(bid, 'mediaType') === 'banner' || (!deepAccess(bid, 'mediaTypes.video') && !deepAccess(bid, 'mediaType'))) { placement.banner = {'format': []} @@ -113,7 +113,7 @@ function _buildBid (bid, bidderRequest) { } function _buildResponse (bid, currency, ttl) { - let resp = { + const resp = { requestId: bid.impid, cpm: bid.price, width: bid.w, @@ -153,19 +153,19 @@ export const spec = { return false } if (deepAccess(bid, 'mediaTypes.banner.sizes')) { - let isValid = _validateSizes(bid.mediaTypes.banner.sizes, 'banner') + const isValid = _validateSizes(bid.mediaTypes.banner.sizes, 'banner') if (!isValid) { logWarn('Bid sizes are invalid.') } return isValid } else if (deepAccess(bid, 'mediaTypes.video.playerSize')) { - let isValid = _validateSizes(bid.mediaTypes.video.playerSize, 'video') + const isValid = _validateSizes(bid.mediaTypes.video.playerSize, 'video') if (!isValid) { logWarn('Bid sizes are invalid.') } return isValid } else if (deepAccess(bid, 'sizes')) { - let isValid = _validateSizes(bid.sizes, 'old') + const isValid = _validateSizes(bid.sizes, 'old') if (!isValid) { logWarn('Bid sizes are invalid.') } @@ -178,7 +178,7 @@ export const spec = { buildRequests: function (validBidRequests, bidderRequest) { // check if validBidRequests is not empty if (validBidRequests.length > 0) { - let requestBody = {} + const requestBody = {} requestBody.imp = [] requestBody.site = _getSiteObj(bidderRequest) requestBody.device = _getDeviceObj() diff --git a/modules/chromeAiRtdProvider.js b/modules/chromeAiRtdProvider.js index 83e730644e3..b48ac505f02 100644 --- a/modules/chromeAiRtdProvider.js +++ b/modules/chromeAiRtdProvider.js @@ -76,7 +76,7 @@ const _createAiApiInstance = async (ApiConstructor, options) => { const mergeModuleConfig = (config) => { // Start with a deep copy of default_config to ensure all keys are present - let newConfig = JSON.parse(JSON.stringify(CONSTANTS.DEFAULT_CONFIG)); + const newConfig = JSON.parse(JSON.stringify(CONSTANTS.DEFAULT_CONFIG)); if (config?.params) { mergeDeep(newConfig, config.params); } diff --git a/modules/colombiaBidAdapter.js b/modules/colombiaBidAdapter.js index 25d925f58b4..f565669e450 100644 --- a/modules/colombiaBidAdapter.js +++ b/modules/colombiaBidAdapter.js @@ -19,7 +19,7 @@ export const spec = { if (validBidRequests.length === 0) { return []; } - let payloadArr = [] + const payloadArr = [] let ctr = 1; validBidRequests = validBidRequests.map(bidRequest => { const params = bidRequest.params; @@ -30,8 +30,8 @@ export const spec = { const cb = Math.floor(Math.random() * 99999999999); const bidId = bidRequest.bidId; const referrer = (bidderRequest && bidderRequest.refererInfo && bidderRequest.refererInfo.referer) ? bidderRequest.refererInfo.referer : ''; - let mediaTypes = {} - let payload = { + const mediaTypes = {} + const payload = { v: 'hb1', p: placementId, pos: '~' + ctr, @@ -76,7 +76,7 @@ export const spec = { const crid = response.creativeId || 0; const width = response.width || 0; const height = response.height || 0; - let cpm = response.cpm || 0; + const cpm = response.cpm || 0; if (cpm <= 0) { return bidResponses; } diff --git a/modules/colossussspBidAdapter.js b/modules/colossussspBidAdapter.js index 66093ddd480..951a4144522 100644 --- a/modules/colossussspBidAdapter.js +++ b/modules/colossussspBidAdapter.js @@ -1,9 +1,14 @@ -import { getWindowTop, deepAccess, logMessage } from '../src/utils.js'; +import { deepAccess } from '../src/utils.js'; import { registerBidder } from '../src/adapters/bidderFactory.js'; import { BANNER, NATIVE, VIDEO } from '../src/mediaTypes.js'; import { ajax } from '../src/ajax.js'; -import { config } from '../src/config.js'; import { convertOrtbRequestToProprietaryNative } from '../src/native.js'; +import { + buildPlacementProcessingFunction, + buildRequestsBase, + interpretResponse, + getUserSyncs +} from '../libraries/teqblazeUtils/bidderUtils.js'; /** * @typedef {import('../src/adapters/bidderFactory.js').BidRequest} BidRequest @@ -14,23 +19,6 @@ const BIDDER_CODE = 'colossusssp'; const G_URL = 'https://colossusssp.com/?c=o&m=multi'; const G_URL_SYNC = 'https://sync.colossusssp.com'; -function isBidResponseValid(bid) { - if (!bid.requestId || !bid.cpm || !bid.creativeId || !bid.ttl || !bid.currency) { - return false; - } - - switch (bid.mediaType) { - case BANNER: - return Boolean(bid.width && bid.height && bid.ad); - case VIDEO: - return Boolean(bid.vastUrl); - case NATIVE: - return Boolean(bid.native); - default: - return false; - } -} - function getUserId(eids, id, source, uidExt) { if (id) { var uid = { id }; @@ -44,6 +32,54 @@ function getUserId(eids, id, source, uidExt) { } } +const addPlacementType = (bid, bidderRequest, placement) => { + placement.placementId = bid.params.placement_id; + placement.groupId = bid.params.group_id; +}; + +const addCustomFieldsToPlacement = (bid, bidderRequest, placement) => { + placement.traffic = placement.adFormat; + delete placement.adFormat; + + if (placement.traffic === VIDEO) { + placement.sizes = placement.playerSize; + } + + placement.tid = bid.ortb2Imp?.ext?.tid; + + const gpid = deepAccess(bid, 'ortb2Imp.ext.gpid') || deepAccess(bid, 'ortb2Imp.ext.data.pbadslot'); + if (gpid) { + placement.gpid = gpid; + } + + placement.eids = placement.eids || []; + if (bid.userId) { + getUserId(placement.eids, bid.userId.idl_env, 'identityLink'); + getUserId(placement.eids, bid.userId.id5id, 'id5-sync.com'); + getUserId(placement.eids, bid.userId.uid2 && bid.userId.uid2.id, 'uidapi.com'); + getUserId(placement.eids, bid.userId.tdid, 'adserver.org', { rtiPartner: 'TDID' }); + } + + placement.floor = {}; + if (typeof bid.getFloor === 'function' && placement.sizes) { + for (let size of placement.sizes) { + const tmpFloor = bid.getFloor({ currency: 'USD', mediaType: placement.traffic, size }); + if (tmpFloor) { + placement.floor[`${size[0]}x${size[1]}`] = tmpFloor.floor; + } + } + } + + delete placement.bidfloor; + delete placement.plcmt; + delete placement.ext; +}; + +const placementProcessingFunction = buildPlacementProcessingFunction({ + addPlacementType, + addCustomFieldsToPlacement +}); + export const spec = { code: BIDDER_CODE, supportedMediaTypes: [BANNER, VIDEO, NATIVE], @@ -66,148 +102,44 @@ export const spec = { * @param {BidRequest[]} validBidRequests A non-empty list of valid bid requests that should be sent to the Server. * @return ServerRequest Info describing the request to the server. */ - buildRequests: (validBidRequests, bidderRequest) => { - // convert Native ORTB definition to old-style prebid native definition + buildRequests: (validBidRequests = [], bidderRequest = {}) => { validBidRequests = convertOrtbRequestToProprietaryNative(validBidRequests); - let deviceWidth = 0; - let deviceHeight = 0; - let winLocation; - - try { - const winTop = getWindowTop(); - deviceWidth = winTop.screen.width; - deviceHeight = winTop.screen.height; - winLocation = winTop.location; - } catch (e) { - logMessage(e); - winLocation = window.location; - } - - const refferUrl = bidderRequest.refererInfo?.page; - let refferLocation; - try { - refferLocation = refferUrl && new URL(refferUrl); - } catch (e) { - logMessage(e); - } + const request = buildRequestsBase({ + adUrl: G_URL, + validBidRequests, + bidderRequest, + placementProcessingFunction + }); + const base = request.data; const firstPartyData = bidderRequest.ortb2 || {}; - const userObj = firstPartyData.user; - const siteObj = firstPartyData.site; - const appObj = firstPartyData.app; - // TODO: does the fallback to window.location make sense? - const location = refferLocation || winLocation; - let placements = []; - let request = { - deviceWidth, - deviceHeight, - language: (navigator && navigator.language) ? navigator.language : '', - secure: location.protocol === 'https:' ? 1 : 0, - host: location.host, - page: location.pathname, - userObj, - siteObj, - appObj, - placements: placements + request.data = { + deviceWidth: base.deviceWidth, + deviceHeight: base.deviceHeight, + language: base.language, + secure: base.secure, + host: base.host, + page: base.page, + placements: base.placements, + ccpa: base.ccpa, + userObj: firstPartyData.user, + siteObj: firstPartyData.site, + appObj: firstPartyData.app }; - if (bidderRequest) { - if (bidderRequest.uspConsent) { - request.ccpa = bidderRequest.uspConsent; - } - if (bidderRequest.gdprConsent) { - request.gdpr_consent = bidderRequest.gdprConsent.consentString || 'ALL'; - request.gdpr_require = bidderRequest.gdprConsent.gdprApplies ? 1 : 0; - } - - // Add GPP consent - if (bidderRequest.gppConsent) { - request.gpp = bidderRequest.gppConsent.gppString; - request.gpp_sid = bidderRequest.gppConsent.applicableSections; - } else if (bidderRequest.ortb2?.regs?.gpp) { - request.gpp = bidderRequest.ortb2.regs.gpp; - request.gpp_sid = bidderRequest.ortb2.regs.gpp_sid; - } + if (bidderRequest.gdprConsent) { + request.data.gdpr_consent = bidderRequest.gdprConsent.consentString || 'ALL'; + request.data.gdpr_require = bidderRequest.gdprConsent.gdprApplies ? 1 : 0; } - for (let i = 0; i < validBidRequests.length; i++) { - let bid = validBidRequests[i]; - const { mediaTypes } = bid; - let placement = { - placementId: bid.params.placement_id, - groupId: bid.params.group_id, - bidId: bid.bidId, - tid: bid.ortb2Imp?.ext?.tid, - eids: bid.userIdAsEids || [], - floor: {} - }; - - const schain = bid?.ortb2?.source?.ext?.schain; - if (schain) { - placement.schain = schain; - } - let gpid = deepAccess(bid, 'ortb2Imp.ext.gpid'); - if (gpid) { - placement.gpid = gpid; - } - if (bid.userId) { - getUserId(placement.eids, bid.userId.idl_env, 'identityLink'); - getUserId(placement.eids, bid.userId.id5id, 'id5-sync.com'); - getUserId(placement.eids, bid.userId.uid2 && bid.userId.uid2.id, 'uidapi.com'); - getUserId(placement.eids, bid.userId.tdid, 'adserver.org', { - rtiPartner: 'TDID' - }); - } - - if (mediaTypes && mediaTypes[BANNER]) { - placement.traffic = BANNER; - placement.sizes = mediaTypes[BANNER].sizes; - } else if (mediaTypes && mediaTypes[VIDEO]) { - placement.traffic = VIDEO; - placement.sizes = mediaTypes[VIDEO].playerSize; - placement.playerSize = mediaTypes[VIDEO].playerSize; - placement.minduration = mediaTypes[VIDEO].minduration; - placement.maxduration = mediaTypes[VIDEO].maxduration; - placement.mimes = mediaTypes[VIDEO].mimes; - placement.protocols = mediaTypes[VIDEO].protocols; - placement.startdelay = mediaTypes[VIDEO].startdelay; - placement.placement = mediaTypes[VIDEO].plcmt; - placement.skip = mediaTypes[VIDEO].skip; - placement.skipafter = mediaTypes[VIDEO].skipafter; - placement.minbitrate = mediaTypes[VIDEO].minbitrate; - placement.maxbitrate = mediaTypes[VIDEO].maxbitrate; - placement.delivery = mediaTypes[VIDEO].delivery; - placement.playbackmethod = mediaTypes[VIDEO].playbackmethod; - placement.api = mediaTypes[VIDEO].api; - placement.linearity = mediaTypes[VIDEO].linearity; - } else if (mediaTypes && mediaTypes[NATIVE]) { - placement.traffic = NATIVE; - placement.native = mediaTypes[NATIVE]; - } - - if (typeof bid.getFloor === 'function') { - let tmpFloor = {}; - for (let size of placement.sizes) { - tmpFloor = bid.getFloor({ - currency: 'USD', - mediaType: placement.traffic, - size: size - }); - if (tmpFloor) { - placement.floor[`${size[0]}x${size[1]}`] = tmpFloor.floor; - } - } - } - - placements.push(placement); + if (base.gpp) { + request.data.gpp = base.gpp; + request.data.gpp_sid = base.gpp_sid; } - return { - method: 'POST', - url: G_URL, - data: request - }; + + return request; }, /** @@ -216,47 +148,8 @@ export const spec = { * @param {*} serverResponse A successful response from the server. * @return {Bid[]} An array of bids which were nested inside the server. */ - interpretResponse: (serverResponse) => { - let response = []; - try { - serverResponse = serverResponse.body; - for (let i = 0; i < serverResponse.length; i++) { - let resItem = serverResponse[i]; - if (isBidResponseValid(resItem)) { - const advertiserDomains = resItem.adomain && resItem.adomain.length ? resItem.adomain : []; - resItem.meta = { ...resItem.meta, advertiserDomains }; - - response.push(resItem); - } - } - } catch (e) { - logMessage(e); - }; - return response; - }, - - getUserSyncs: (syncOptions, serverResponses, gdprConsent, uspConsent) => { - let syncType = syncOptions.iframeEnabled ? 'iframe' : 'image'; - let syncUrl = G_URL_SYNC + `/${syncType}?pbjs=1`; - if (gdprConsent && gdprConsent.consentString) { - if (typeof gdprConsent.gdprApplies === 'boolean') { - syncUrl += `&gdpr=${Number(gdprConsent.gdprApplies)}&gdpr_consent=${gdprConsent.consentString}`; - } else { - syncUrl += `&gdpr=0&gdpr_consent=${gdprConsent.consentString}`; - } - } - if (uspConsent && uspConsent.consentString) { - syncUrl += `&ccpa_consent=${uspConsent.consentString}`; - } - - const coppa = config.getConfig('coppa') ? 1 : 0; - syncUrl += `&coppa=${coppa}`; - - return [{ - type: syncType, - url: syncUrl - }]; - }, + interpretResponse, + getUserSyncs: getUserSyncs(G_URL_SYNC), onBidWon: (bid) => { if (bid.nurl) { diff --git a/modules/concertAnalyticsAdapter.js b/modules/concertAnalyticsAdapter.js index 742646960f3..99a3f037363 100644 --- a/modules/concertAnalyticsAdapter.js +++ b/modules/concertAnalyticsAdapter.js @@ -20,7 +20,7 @@ const { let queue = []; -let concertAnalytics = Object.assign(adapter({url, analyticsType}), { +const concertAnalytics = Object.assign(adapter({url, analyticsType}), { track({ eventType, args }) { switch (eventType) { case BID_RESPONSE: diff --git a/modules/concertBidAdapter.js b/modules/concertBidAdapter.js index 343ef669c48..a83c078ccef 100644 --- a/modules/concertBidAdapter.js +++ b/modules/concertBidAdapter.js @@ -44,7 +44,7 @@ export const spec = { const eids = []; - let payload = { + const payload = { meta: { prebidVersion: '$prebid.version$', pageUrl: bidderRequest.refererInfo.page, @@ -73,7 +73,7 @@ export const spec = { const adUnitElement = document.getElementById(bidRequest.adUnitCode); const coordinates = getOffset(adUnitElement); - let slot = { + const slot = { name: bidRequest.adUnitCode, bidId: bidRequest.bidId, transactionId: bidRequest.ortb2Imp?.ext?.tid, diff --git a/modules/condorxBidAdapter.js b/modules/condorxBidAdapter.js index 92f16c96e25..35374a859d4 100644 --- a/modules/condorxBidAdapter.js +++ b/modules/condorxBidAdapter.js @@ -264,7 +264,7 @@ export const bidderSpec = { const response = serverResponse.body; const isNative = response.pbtypeId === 1; return response.tiles.map(tile => { - let bid = { + const bid = { requestId: response.ireqId, width: response.imageWidth, height: response.imageHeight, diff --git a/modules/connatixBidAdapter.js b/modules/connatixBidAdapter.js index 15b74e1f814..deb717fbe61 100644 --- a/modules/connatixBidAdapter.js +++ b/modules/connatixBidAdapter.js @@ -182,7 +182,7 @@ export function _getBidRequests(validBidRequests) { * Get ids from Prebid User ID Modules and add them to the payload */ function _handleEids(payload, validBidRequests) { - let bidUserIdAsEids = deepAccess(validBidRequests, '0.userIdAsEids'); + const bidUserIdAsEids = deepAccess(validBidRequests, '0.userIdAsEids'); if (isArray(bidUserIdAsEids) && bidUserIdAsEids.length > 0) { deepSetValue(payload, 'userIdList', bidUserIdAsEids); } diff --git a/modules/connectIdSystem.js b/modules/connectIdSystem.js index 343986083f2..5baba26a1c2 100644 --- a/modules/connectIdSystem.js +++ b/modules/connectIdSystem.js @@ -235,7 +235,7 @@ export const connectIdSubmodule = { } } - let topmostLocation = getRefererInfo().topmostLocation; + const topmostLocation = getRefererInfo().topmostLocation; if (typeof topmostLocation === 'string') { data.url = topmostLocation.split('?')[0]; } @@ -290,7 +290,7 @@ export const connectIdSubmodule = { } }; const endpoint = UPS_ENDPOINT.replace(PLACEHOLDER, params.pixelId); - let url = `${params.endpoint || endpoint}?${formatQS(data)}`; + const url = `${params.endpoint || endpoint}?${formatQS(data)}`; connectIdSubmodule.getAjaxFn()(url, callbacks, null, {method: 'GET', withCredentials: true}); }; const result = {callback: resp}; diff --git a/modules/connectadBidAdapter.js b/modules/connectadBidAdapter.js index 5bad4879beb..a804e083f23 100644 --- a/modules/connectadBidAdapter.js +++ b/modules/connectadBidAdapter.js @@ -20,7 +20,7 @@ export const spec = { }, buildRequests: function(validBidRequests, bidderRequest) { - let ret = { + const ret = { method: 'POST', url: '', data: '', @@ -147,7 +147,7 @@ export const spec = { let bids; let bidId; let bidObj; - let bidResponses = []; + const bidResponses = []; bids = bidRequest.bidRequest; @@ -192,7 +192,7 @@ export const spec = { }, getUserSyncs: (syncOptions, responses, gdprConsent, uspConsent, gppConsent) => { - let pixelType = syncOptions.iframeEnabled ? 'iframe' : 'image'; + const pixelType = syncOptions.iframeEnabled ? 'iframe' : 'image'; let syncEndpoint; if (pixelType == 'iframe') { @@ -244,7 +244,7 @@ function getBidFloor(bidRequest) { }); } - let floor = floorInfo?.floor || bidRequest.params.bidfloor || bidRequest.params.floorprice || 0; + const floor = floorInfo?.floor || bidRequest.params.bidfloor || bidRequest.params.floorprice || 0; return floor; } diff --git a/modules/consentManagementUsp.ts b/modules/consentManagementUsp.ts index fcb65bfdfef..37edaf23ac6 100644 --- a/modules/consentManagementUsp.ts +++ b/modules/consentManagementUsp.ts @@ -90,7 +90,7 @@ function lookupUspConsent({onSuccess, onError}) { }; } - let callbackHandler = handleUspApiResponseCallbacks(); + const callbackHandler = handleUspApiResponseCallbacks(); const cmp = cmpClient({ apiName: '__uspapi', diff --git a/modules/consumableBidAdapter.js b/modules/consumableBidAdapter.js index b85322e4eb7..d6d91557762 100644 --- a/modules/consumableBidAdapter.js +++ b/modules/consumableBidAdapter.js @@ -39,7 +39,7 @@ export const spec = { */ buildRequests: function(validBidRequests, bidderRequest) { - let ret = { + const ret = { method: 'POST', url: '', data: '', @@ -130,7 +130,7 @@ export const spec = { let bids; let bidId; let bidObj; - let bidResponses = []; + const bidResponses = []; bids = bidRequest.bidRequest; @@ -316,7 +316,7 @@ function getBidFloor(bid, sizes) { let floor; - let floorInfo = bid.getFloor({ + const floorInfo = bid.getFloor({ currency: 'USD', mediaType: bid.mediaTypes.video ? 'video' : 'banner', size: sizes.length === 1 ? sizes[0] : '*' diff --git a/modules/contxtfulBidAdapter.js b/modules/contxtfulBidAdapter.js index 34186b6413f..c057bd78c05 100644 --- a/modules/contxtfulBidAdapter.js +++ b/modules/contxtfulBidAdapter.js @@ -26,7 +26,7 @@ const converter = ortbConverter({ ttl: DEFAULT_TTL }, imp(buildImp, bidRequest, context) { - let imp = buildImp(bidRequest, context); + const imp = buildImp(bidRequest, context); return imp; }, request(buildRequest, imps, bidderRequest, context) { @@ -96,7 +96,7 @@ const buildRequests = (validBidRequests = [], bidderRequest = {}) => { }); // See https://docs.prebid.org/dev-docs/bidder-adaptor.html - let req = { + const req = { url: adapterUrl, method: 'POST', data: { @@ -153,7 +153,7 @@ const getSamplingRate = (bidderConfig, eventType) => { const logBidderError = ({ error, bidderRequest }) => { if (error) { - let jsonReason = { + const jsonReason = { message: error.reason?.message, stack: error.reason?.stack, }; diff --git a/modules/contxtfulRtdProvider.js b/modules/contxtfulRtdProvider.js index b97e2759df7..34e243d82cf 100644 --- a/modules/contxtfulRtdProvider.js +++ b/modules/contxtfulRtdProvider.js @@ -69,20 +69,20 @@ function getItemFromSessionStorage(key) { } function loadSessionReceptivity(requester) { - let sessionStorageValue = getItemFromSessionStorage(requester); + const sessionStorageValue = getItemFromSessionStorage(requester); if (!sessionStorageValue) { return null; } try { // Check expiration of the cached value - let sessionStorageReceptivity = JSON.parse(sessionStorageValue); - let expiration = parseInt(sessionStorageReceptivity?.exp); + const sessionStorageReceptivity = JSON.parse(sessionStorageValue); + const expiration = parseInt(sessionStorageReceptivity?.exp); if (expiration < new Date().getTime()) { return null; } - let rx = sessionStorageReceptivity?.rx; + const rx = sessionStorageReceptivity?.rx; return rx; } catch { return null; @@ -190,7 +190,7 @@ function addConnectorEventListener(tagId, prebidConfig) { } // Fetch the customer configuration const { rxApiBuilder, fetchConfig } = rxConnector; - let config = await fetchConfig(tagId); + const config = await fetchConfig(tagId); if (!config) { return; } @@ -301,7 +301,7 @@ function getDivIdPosition(divId) { return {}; } - let box = getBoundingClientRect(domElement); + const box = getBoundingClientRect(domElement); const docEl = d.documentElement; const body = d.body; const clientTop = (d.clientTop ?? body.clientTop) ?? 0; @@ -322,7 +322,7 @@ function getDivIdPosition(divId) { } function tryGetDivIdPosition(divIdMethod) { - let divId = divIdMethod(); + const divId = divIdMethod(); if (divId) { const divIdPosition = getDivIdPosition(divId); if (divIdPosition.x !== undefined && divIdPosition.y !== undefined) { @@ -333,7 +333,7 @@ function tryGetDivIdPosition(divIdMethod) { } function tryMultipleDivIdPositions(adUnit) { - let divMethods = [ + const divMethods = [ // ortb2\ () => { adUnit.ortb2Imp = adUnit.ortb2Imp || {}; @@ -347,7 +347,7 @@ function tryMultipleDivIdPositions(adUnit) { ]; for (const divMethod of divMethods) { - let divPosition = tryGetDivIdPosition(divMethod); + const divPosition = tryGetDivIdPosition(divMethod); if (divPosition) { return divPosition; } @@ -355,7 +355,7 @@ function tryMultipleDivIdPositions(adUnit) { } function tryGetAdUnitPosition(adUnit) { - let adUnitPosition = {}; + const adUnitPosition = {}; adUnit.ortb2Imp = adUnit.ortb2Imp || {}; // try to get position with the divId @@ -380,10 +380,10 @@ function tryGetAdUnitPosition(adUnit) { function getAdUnitPositions(bidReqConfig) { const adUnits = bidReqConfig.adUnits || []; - let adUnitPositions = {}; + const adUnitPositions = {}; for (const adUnit of adUnits) { - let adUnitPosition = tryGetAdUnitPosition(adUnit); + const adUnitPosition = tryGetAdUnitPosition(adUnit); if (adUnitPosition) { adUnitPositions[adUnit.code] = adUnitPosition; } @@ -410,20 +410,20 @@ function getBidRequestData(reqBidsConfigObj, onDone, config, userConsent) { } let ortb2Fragment; - let getContxtfulOrtb2Fragment = rxApi?.getOrtb2Fragment; + const getContxtfulOrtb2Fragment = rxApi?.getOrtb2Fragment; if (typeof (getContxtfulOrtb2Fragment) == 'function') { ortb2Fragment = getContxtfulOrtb2Fragment(bidders, reqBidsConfigObj); } else { const adUnitsPositions = getAdUnitPositions(reqBidsConfigObj); - let fromApi = rxApi?.receptivityBatched?.(bidders) || {}; - let fromStorage = prepareBatch(bidders, (bidder) => loadSessionReceptivity(`${config?.params?.customer}_${bidder}`)); + const fromApi = rxApi?.receptivityBatched?.(bidders) || {}; + const fromStorage = prepareBatch(bidders, (bidder) => loadSessionReceptivity(`${config?.params?.customer}_${bidder}`)); - let sources = [fromStorage, fromApi]; + const sources = [fromStorage, fromApi]; - let rxBatch = Object.assign(...sources); + const rxBatch = Object.assign(...sources); - let singlePointEvents = btoa(JSON.stringify({ ui: getUiEvents() })); + const singlePointEvents = btoa(JSON.stringify({ ui: getUiEvents() })); ortb2Fragment = {}; ortb2Fragment.bidder = Object.fromEntries( bidders @@ -467,8 +467,8 @@ function getScreen() { function getInnerSize() { const { innerWidth, innerHeight } = getWinDimensions(); - let w = innerWidth; - let h = innerHeight; + const w = innerWidth; + const h = innerHeight; if (w && h) { return [w, h]; @@ -478,8 +478,8 @@ function getScreen() { function getDocumentSize() { const windowDimensions = getWinDimensions(); - let w = windowDimensions.document.body.clientWidth; - let h = windowDimensions.document.body.clientHeight; + const w = windowDimensions.document.body.clientWidth; + const h = windowDimensions.document.body.clientHeight; if (w && h) { return [w, h]; @@ -488,8 +488,8 @@ function getScreen() { // If we cannot access or cast the window dimensions, we get None. // If we cannot collect the size from the window we try to use the root document dimensions - let [width, height] = getInnerSize() || getDocumentSize() || [0, 0]; - let topLeft = { x: window.scrollX, y: window.scrollY }; + const [width, height] = getInnerSize() || getDocumentSize() || [0, 0]; + const topLeft = { x: window.scrollX, y: window.scrollY }; return { topLeft, @@ -511,7 +511,7 @@ function observeLastCursorPosition() { } function touchEventToPosition(event) { - let touch = event.touches.item(0); + const touch = event.touches.item(0); if (!touch) { return; } @@ -527,7 +527,7 @@ function observeLastCursorPosition() { addListener('touchmove', touchEventToPosition); } -let listeners = {}; +const listeners = {}; function addListener(name, listener) { listeners[name] = listener; diff --git a/modules/conversantBidAdapter.js b/modules/conversantBidAdapter.js index ddbcafbce42..65122b29fcb 100644 --- a/modules/conversantBidAdapter.js +++ b/modules/conversantBidAdapter.js @@ -172,7 +172,7 @@ export const spec = { * Register User Sync. */ getUserSyncs: function(syncOptions, responses, gdprConsent, uspConsent) { - let params = {}; + const params = {}; const syncs = []; // Attaching GDPR Consent Params in UserSync url @@ -195,7 +195,7 @@ export const spec = { }) .map((entry) => { return entry.urls.map((endpoint) => { - let urlInfo = parseUrl(endpoint); + const urlInfo = parseUrl(endpoint); mergeDeep(urlInfo.search, params); if (Object.keys(urlInfo.search).length === 0) { delete urlInfo.search; // empty search object causes buildUrl to add a trailing ? to the url diff --git a/modules/cpmstarBidAdapter.js b/modules/cpmstarBidAdapter.js index b9d61eaf543..52d850f63b9 100755 --- a/modules/cpmstarBidAdapter.js +++ b/modules/cpmstarBidAdapter.js @@ -105,7 +105,7 @@ export const spec = { url.searchParams.set('tfcd', (config.getConfig('coppa') ? 1 : 0)); } - let adUnitCode = bidRequest.adUnitCode; + const adUnitCode = bidRequest.adUnitCode; if (adUnitCode) { body.adUnitCode = adUnitCode; } diff --git a/modules/craftBidAdapter.js b/modules/craftBidAdapter.js index d4b45153fca..3c1bea6cc89 100644 --- a/modules/craftBidAdapter.js +++ b/modules/craftBidAdapter.js @@ -47,7 +47,7 @@ export const spec = { payload.us_privacy = bidderRequest.uspConsent; } if (bidderRequest.refererInfo) { - let refererinfo = { + const refererinfo = { // TODO: this collects everything it finds, except for the canonical URL rd_ref: bidderRequest.refererInfo.topmostLocation, rd_top: bidderRequest.refererInfo.reachedTop, diff --git a/modules/criteoBidAdapter.js b/modules/criteoBidAdapter.js index ca0e8f949fd..e537ef16520 100644 --- a/modules/criteoBidAdapter.js +++ b/modules/criteoBidAdapter.js @@ -56,7 +56,7 @@ const CONVERTER = ortbConverter({ * @returns {Object} The ORTB 2.5 imp object. */ function imp(buildImp, bidRequest, context) { - let imp = buildImp(bidRequest, context); + const imp = buildImp(bidRequest, context); const params = bidRequest.params; imp.tagid = bidRequest.adUnitCode; @@ -100,7 +100,7 @@ function imp(buildImp, bidRequest, context) { } if (imp.native && typeof imp.native.request !== 'undefined') { - let requestNative = JSON.parse(imp.native.request); + const requestNative = JSON.parse(imp.native.request); // We remove the native asset requirements if we used the bypass to generate the imp const hasAssetRequirements = requestNative.assets && @@ -162,7 +162,7 @@ function bidResponse(buildBidResponse, bid, context) { delete bid.adm_native; } - let bidResponse = buildBidResponse(bid, context); + const bidResponse = buildBidResponse(bid, context); const {bidRequest} = context; bidResponse.currency = bid?.ext?.cur; @@ -198,7 +198,7 @@ function bidResponse(buildBidResponse, bid, context) { * @returns * */ function response(buildResponse, bidResponses, ortbResponse, context) { - let response = buildResponse(bidResponses, ortbResponse, context); + const response = buildResponse(bidResponses, ortbResponse, context); const pafTransmission = ortbResponse?.ext?.paf?.transmission; response.bids.forEach(bid => { @@ -219,7 +219,7 @@ export const spec = { supportedMediaTypes: [BANNER, VIDEO, NATIVE], getUserSyncs: function (syncOptions, _, gdprConsent, uspConsent, gppConsent = {}) { - let { gppString = '', applicableSections = [] } = gppConsent; + const { gppString = '', applicableSections = [] } = gppConsent; const refererInfo = getRefererInfo(); const origin = 'criteoPrebidAdapter'; @@ -636,14 +636,14 @@ function createOutstreamVideoRenderer(bid) { } const render = (_, renderDocument) => { - let payload = { + const payload = { slotid: bid.id, vastUrl: bid.ext?.displayurl, vastXml: bid.adm, documentContext: renderDocument, }; - let outstreamConfig = bid.ext.videoPlayerConfig; + const outstreamConfig = bid.ext.videoPlayerConfig; window.CriteoOutStream[bid.ext.videoPlayerType].play(payload, outstreamConfig) }; diff --git a/modules/criteoIdSystem.js b/modules/criteoIdSystem.js index 714083f94e6..544e5a9ea31 100644 --- a/modules/criteoIdSystem.js +++ b/modules/criteoIdSystem.js @@ -228,7 +228,7 @@ export const criteoIdSubmodule = { * @returns {{id: {criteoId: string} | undefined}}} */ getId(submoduleConfig) { - let localData = getCriteoDataFromStorage(submoduleConfig); + const localData = getCriteoDataFromStorage(submoduleConfig); const result = (callback) => callCriteoUserSync(submoduleConfig, localData, callback); diff --git a/modules/currency.ts b/modules/currency.ts index a74f7b89e85..0d44d12b5af 100644 --- a/modules/currency.ts +++ b/modules/currency.ts @@ -256,9 +256,9 @@ export const addBidResponseHook = timedBidResponseHook('currency', function addB return fn.call(this, adUnitCode, bid, reject); // if no bid, call original and let it display warnings } - let bidder = bid.bidderCode || bid.bidder; + const bidder = bid.bidderCode || bid.bidder; if (bidderCurrencyDefault[bidder]) { - let currencyDefault = bidderCurrencyDefault[bidder]; + const currencyDefault = bidderCurrencyDefault[bidder]; if (bid.currency && currencyDefault !== bid.currency) { logWarn(`Currency default '${bidder}: ${currencyDefault}' ignored. adapter specified '${bid.currency}'`); } else { @@ -301,9 +301,9 @@ function processBidResponseQueue() { while (bidResponseQueue.length > 0) { const [fn, ctx, adUnitCode, bid, reject] = bidResponseQueue.shift(); if (bid !== undefined && 'currency' in bid && 'cpm' in bid) { - let fromCurrency = bid.currency; + const fromCurrency = bid.currency; try { - let conversion = getCurrencyConversion(fromCurrency); + const conversion = getCurrencyConversion(fromCurrency); if (conversion !== 1) { bid.cpm = (parseFloat(bid.cpm) * conversion).toFixed(4); bid.currency = adServerCurrency; @@ -322,7 +322,7 @@ function processBidResponseQueue() { function getCurrencyConversion(fromCurrency, toCurrency = adServerCurrency) { var conversionRate = null; var rates; - let cacheKey = `${fromCurrency}->${toCurrency}`; + const cacheKey = `${fromCurrency}->${toCurrency}`; if (cacheKey in conversionCache) { conversionRate = conversionCache[cacheKey]; logMessage('Using conversionCache value ' + conversionRate + ' for ' + cacheKey); diff --git a/modules/cwireBidAdapter.js b/modules/cwireBidAdapter.js index 24070098851..bfdff170e3c 100644 --- a/modules/cwireBidAdapter.js +++ b/modules/cwireBidAdapter.js @@ -40,8 +40,8 @@ export const storage = getStorageManager({ bidderCode: BIDDER_CODE }); * @returns {*&{cwExt: {dimensions: {width: number, height: number}, style: {maxWidth: number, maxHeight: number}}}} */ function slotDimensions(bid) { - let adUnitCode = bid.adUnitCode; - let slotEl = document.getElementById(adUnitCode); + const adUnitCode = bid.adUnitCode; + const slotEl = document.getElementById(adUnitCode); if (slotEl) { logInfo(`Slot element found: ${adUnitCode}`); @@ -78,7 +78,7 @@ function slotDimensions(bid) { * @returns *[] */ function getFeatureFlags() { - let ffParam = getParameterByName("cwfeatures"); + const ffParam = getParameterByName("cwfeatures"); if (ffParam) { return ffParam.split(","); } @@ -98,7 +98,7 @@ function getBidFloor(bid) { return {}; } - let floor = bid.getFloor({ + const floor = bid.getFloor({ currency: "USD", mediaType: "*", size: "*", @@ -210,10 +210,10 @@ export const spec = { */ buildRequests: function (validBidRequests, bidderRequest) { // There are more fields on the refererInfo object - let referrer = bidderRequest?.refererInfo?.page; + const referrer = bidderRequest?.refererInfo?.page; // process bid requests - let processed = validBidRequests + const processed = validBidRequests .map((bid) => slotDimensions(bid)) .map((bid) => { const bidFloor = getBidFloor(bid); @@ -321,7 +321,7 @@ export const spec = { const syncs = []; if (hasPurpose1Consent(gdprConsent) && gdprConsent.consentString) { logInfo("GDPR purpose 1 consent was given, adding user-syncs"); - let type = syncOptions.pixelEnabled + const type = syncOptions.pixelEnabled ? "image" : null ?? syncOptions.iframeEnabled ? "iframe" diff --git a/modules/dailyhuntBidAdapter.js b/modules/dailyhuntBidAdapter.js index 61874015ce5..e4ff57c69b4 100644 --- a/modules/dailyhuntBidAdapter.js +++ b/modules/dailyhuntBidAdapter.js @@ -93,9 +93,9 @@ const flatten = (arr) => { } const createOrtbRequest = (validBidRequests, bidderRequest) => { - let device = createOrtbDeviceObj(validBidRequests); - let user = createOrtbUserObj(validBidRequests) - let site = createOrtbSiteObj(validBidRequests, bidderRequest.refererInfo.page) + const device = createOrtbDeviceObj(validBidRequests); + const user = createOrtbUserObj(validBidRequests) + const site = createOrtbSiteObj(validBidRequests, bidderRequest.refererInfo.page) return { id: bidderRequest.bidderRequestId, imp: [], @@ -106,7 +106,7 @@ const createOrtbRequest = (validBidRequests, bidderRequest) => { } const createOrtbDeviceObj = (validBidRequests) => { - let device = { ...extractKeyInfo(validBidRequests, `device`) }; + const device = { ...extractKeyInfo(validBidRequests, `device`) }; device.ua = navigator.userAgent; return device; } @@ -114,8 +114,8 @@ const createOrtbDeviceObj = (validBidRequests) => { const createOrtbUserObj = (validBidRequests) => ({ ...extractKeyInfo(validBidRequests, `user`) }) const createOrtbSiteObj = (validBidRequests, page) => { - let site = { ...extractKeyInfo(validBidRequests, `site`), page }; - let publisher = createOrtbPublisherObj(validBidRequests); + const site = { ...extractKeyInfo(validBidRequests, `site`), page }; + const publisher = createOrtbPublisherObj(validBidRequests); if (!site.publisher) { site.publisher = publisher } @@ -126,20 +126,20 @@ const createOrtbPublisherObj = (validBidRequests) => ({ ...extractKeyInfo(validB // get bidFloor Function for different creatives function getBidFloor(bid, creative) { - let floorInfo = typeof (bid.getFloor) == 'function' ? bid.getFloor({ currency: 'USD', mediaType: creative, size: '*' }) : {}; + const floorInfo = typeof (bid.getFloor) == 'function' ? bid.getFloor({ currency: 'USD', mediaType: creative, size: '*' }) : {}; return Math.floor(floorInfo?.floor || (bid.params.bidfloor ? bid.params.bidfloor : 0.0)); } const createOrtbImpObj = (bid) => { - let params = bid.params - let testMode = !!bid.params.test_mode + const params = bid.params + const testMode = !!bid.params.test_mode // Validate Banner Request. - let bannerObj = deepAccess(bid.mediaTypes, `banner`); - let nativeObj = deepAccess(bid.mediaTypes, `native`); - let videoObj = deepAccess(bid.mediaTypes, `video`); + const bannerObj = deepAccess(bid.mediaTypes, `banner`); + const nativeObj = deepAccess(bid.mediaTypes, `native`); + const videoObj = deepAccess(bid.mediaTypes, `video`); - let imp = { + const imp = { id: bid.bidId, ext: { dailyhunt: { @@ -175,7 +175,7 @@ const createOrtbImpObj = (bid) => { } const createOrtbImpBannerObj = (bid, bannerObj) => { - let format = []; + const format = []; bannerObj.sizes.forEach(size => format.push({ w: size[0], h: size[1] })) return { @@ -212,7 +212,7 @@ const createOrtbImpNativeObj = (bid, nativeObj) => { return asset; } }).filter(Boolean); - let request = { + const request = { assets, ver: '1,0' } @@ -221,7 +221,7 @@ const createOrtbImpNativeObj = (bid, nativeObj) => { const createOrtbImpVideoObj = (bid, videoObj) => { let obj = {}; - let params = bid.params + const params = bid.params if (!isEmpty(bid.params.video)) { obj = { topframe: 1, @@ -246,8 +246,8 @@ const createOrtbImpVideoObj = (bid, videoObj) => { } export function getProtocols({protocols}) { - let defaultValue = [2, 3, 5, 6, 7, 8]; - let listProtocols = [ + const defaultValue = [2, 3, 5, 6, 7, 8]; + const listProtocols = [ {key: 'VAST_1_0', value: 1}, {key: 'VAST_2_0', value: 2}, {key: 'VAST_3_0', value: 3}, @@ -308,7 +308,7 @@ const createPrebidNativeBid = (bid, bidResponse) => ({ }) const parseNative = (bid) => { - let adm = JSON.parse(bid.adm) + const adm = JSON.parse(bid.adm) const { assets, link, imptrackers, jstracker } = adm.native; const result = { clickUrl: _encodeURIComponent(link.url), @@ -334,7 +334,7 @@ const parseNative = (bid) => { } const createPrebidVideoBid = (bid, bidResponse) => { - let videoBid = { + const videoBid = { requestId: bid.bidId, cpm: bidResponse.price.toFixed(2), creativeId: bidResponse.crid, @@ -348,7 +348,7 @@ const createPrebidVideoBid = (bid, bidResponse) => { adomain: bidResponse.adomain }; - let videoContext = bid.mediaTypes.video.context; + const videoContext = bid.mediaTypes.video.context; switch (videoContext) { case OUTSTREAM: videoBid.vastXml = bidResponse.adm; @@ -362,10 +362,10 @@ const createPrebidVideoBid = (bid, bidResponse) => { } const getQueryVariable = (variable) => { - let query = window.location.search.substring(1); - let vars = query.split('&'); + const query = window.location.search.substring(1); + const vars = query.split('&'); for (var i = 0; i < vars.length; i++) { - let pair = vars[i].split('='); + const pair = vars[i].split('='); if (decodeURIComponent(pair[0]) == variable) { return decodeURIComponent(pair[1]); } @@ -386,13 +386,13 @@ export const spec = { // convert Native ORTB definition to old-style prebid native definition validBidRequests = convertOrtbRequestToProprietaryNative(validBidRequests); - let serverRequests = []; + const serverRequests = []; // ORTB Request. - let ortbReq = createOrtbRequest(validBidRequests, bidderRequest); + const ortbReq = createOrtbRequest(validBidRequests, bidderRequest); validBidRequests.forEach((bid) => { - let imp = createOrtbImpObj(bid) + const imp = createOrtbImpObj(bid) ortbReq.imp.push(imp); }); @@ -403,15 +403,15 @@ export const spec = { interpretResponse: function (serverResponse, request) { const { seatbid } = serverResponse.body; - let bids = request.bids; - let prebidResponse = []; + const bids = request.bids; + const prebidResponse = []; - let seatBids = seatbid[0].bid; + const seatBids = seatbid[0].bid; seatBids.forEach(ortbResponseBid => { - let bidId = ortbResponseBid.impid; - let actualBid = ((bids) || []).find((bid) => bid.bidId === bidId); - let bidMediaType = ortbResponseBid.ext.prebid.type + const bidId = ortbResponseBid.impid; + const actualBid = ((bids) || []).find((bid) => bid.bidId === bidId); + const bidMediaType = ortbResponseBid.ext.prebid.type switch (bidMediaType) { case mediaTypes.BANNER: prebidResponse.push(createPrebidBannerBid(actualBid, ortbResponseBid)); diff --git a/modules/dataControllerModule/index.js b/modules/dataControllerModule/index.js index b1866e3783f..567b31c4247 100644 --- a/modules/dataControllerModule/index.js +++ b/modules/dataControllerModule/index.js @@ -35,7 +35,7 @@ function containsConfiguredEIDS(eidSourcesMap, bidderCode) { if (_dataControllerConfig.filterSDAwhenEID.includes(ALL)) { return true; } - let bidderEIDs = eidSourcesMap.get(bidderCode); + const bidderEIDs = eidSourcesMap.get(bidderCode); if (bidderEIDs == undefined) { return false; } @@ -69,8 +69,8 @@ function hasValue(bidderSegement) { } function getSegmentConfig(ortb2Fragments) { - let bidderSDAMap = new Map(); - let globalObject = deepAccess(ortb2Fragments, 'global') || {}; + const bidderSDAMap = new Map(); + const globalObject = deepAccess(ortb2Fragments, 'global') || {}; collectSegments(bidderSDAMap, GLOBAL, globalObject); if (ortb2Fragments.bidder) { @@ -82,7 +82,7 @@ function getSegmentConfig(ortb2Fragments) { } function collectSegments(bidderSDAMap, key, data) { - let segmentSet = constructSegment(deepAccess(data, 'user.data') || []); + const segmentSet = constructSegment(deepAccess(data, 'user.data') || []); if (segmentSet && segmentSet.size > 0) bidderSDAMap.set(key, segmentSet); } @@ -91,7 +91,7 @@ function constructSegment(userData) { if (userData) { segmentSet = new Set(); for (let i = 0; i < userData.length; i++) { - let segments = userData[i].segment; + const segments = userData[i].segment; let segmentPrefix = ''; if (userData[i].name) { segmentPrefix = userData[i].name + ':'; @@ -110,15 +110,15 @@ function constructSegment(userData) { } function getEIDsSource(adUnits) { - let bidderEIDSMap = new Map(); + const bidderEIDSMap = new Map(); adUnits.forEach(adUnit => { (adUnit.bids || []).forEach(bid => { - let userEIDs = deepAccess(bid, 'userIdAsEids') || []; + const userEIDs = deepAccess(bid, 'userIdAsEids') || []; if (userEIDs) { - let sourceSet = new Set(); + const sourceSet = new Set(); for (let i = 0; i < userEIDs.length; i++) { - let source = userEIDs[i].source; + const source = userEIDs[i].source; sourceSet.add(source); } bidderEIDSMap.set(bid.bidder, sourceSet); @@ -130,10 +130,10 @@ function getEIDsSource(adUnits) { } function filterSDA(adUnits, ortb2Fragments) { - let bidderEIDSMap = getEIDsSource(adUnits); + const bidderEIDSMap = getEIDsSource(adUnits); let resetGlobal = false; for (const [key, value] of Object.entries(ortb2Fragments.bidder)) { - let resetSDA = containsConfiguredEIDS(bidderEIDSMap, key); + const resetSDA = containsConfiguredEIDS(bidderEIDSMap, key); if (resetSDA) { deepSetValue(value, 'user.data', []); resetGlobal = true; @@ -145,18 +145,18 @@ function filterSDA(adUnits, ortb2Fragments) { } function filterEIDs(adUnits, ortb2Fragments) { - let segementMap = getSegmentConfig(ortb2Fragments); + const segementMap = getSegmentConfig(ortb2Fragments); let globalEidUpdate = false; adUnits.forEach(adUnit => { adUnit.bids.forEach(bid => { - let resetEID = containsConfiguredSDA(segementMap, bid.bidder); + const resetEID = containsConfiguredSDA(segementMap, bid.bidder); if (resetEID) { globalEidUpdate = true; bid.userIdAsEids = []; bid.userId = {}; if (ortb2Fragments.bidder) { - let bidderFragment = ortb2Fragments.bidder[bid.bidder]; - let userExt = deepAccess(bidderFragment, 'user.ext.eids') || []; + const bidderFragment = ortb2Fragments.bidder[bid.bidder]; + const userExt = deepAccess(bidderFragment, 'user.ext.eids') || []; if (userExt) { deepSetValue(bidderFragment, 'user.ext.eids', []) } diff --git a/modules/datablocksBidAdapter.js b/modules/datablocksBidAdapter.js index 3a80779fbf5..bc2c9a30d00 100644 --- a/modules/datablocksBidAdapter.js +++ b/modules/datablocksBidAdapter.js @@ -104,7 +104,7 @@ export const spec = { let stored = false; // CREATE 1 YEAR EXPIRY DATE - let d = new Date(); + const d = new Date(); d.setTime(Date.now() + (365 * 24 * 60 * 60 * 1000)); // TRY TO STORE IN COOKIE @@ -138,13 +138,13 @@ export const spec = { // STORE SYNCS IN STORAGE store_syncs: function(syncs) { if (storage.localStorageIsEnabled) { - let syncObj = {}; + const syncObj = {}; syncs.forEach(sync => { syncObj[sync.id] = sync.uid; }); // FETCH EXISTING SYNCS AND MERGE NEW INTO STORAGE - let storedSyncs = this.get_syncs(); + const storedSyncs = this.get_syncs(); storage.setDataInLocalStorage('_db_syncs', JSON.stringify(Object.assign(storedSyncs, syncObj))); return true; @@ -154,7 +154,7 @@ export const spec = { // GET SYNCS FROM STORAGE get_syncs: function() { if (storage.localStorageIsEnabled) { - let syncData = storage.getDataFromLocalStorage('_db_syncs'); + const syncData = storage.getDataFromLocalStorage('_db_syncs'); if (syncData) { return JSON.parse(syncData); } else { @@ -177,7 +177,7 @@ export const spec = { } // SETUP THE TIMER TO FIRE BACK THE DATA - let scope = this; + const scope = this; this.db_obj.metrics_timer = setTimeout(function() { scope.send_metrics(); }, this.db_obj.metrics_queue_time); @@ -201,8 +201,8 @@ export const spec = { // GET BASIC CLIENT INFORMATION get_client_info: function () { - let botTest = new BotClientTests(); - let win = getWindowTop(); + const botTest = new BotClientTests(); + const win = getWindowTop(); const windowDimensions = getWinDimensions(); return { 'wiw': windowDimensions.innerWidth, @@ -229,7 +229,7 @@ export const spec = { this.db_obj.vis_run = true; // ADD GPT EVENT LISTENERS - let scope = this; + const scope = this; if (isGptPubadsDefined()) { if (typeof window['googletag'].pubads().addEventListener == 'function') { // TODO: fix auctionId leak: https://github.com/prebid/Prebid.js/issues/9781 @@ -279,8 +279,8 @@ export const spec = { } if (aRatios && aRatios[0]) { aRatios = aRatios[0]; - let wmin = aRatios.min_width || 0; - let hmin = aRatios.ratio_height * wmin / aRatios.ratio_width | 0; + const wmin = aRatios.min_width || 0; + const hmin = aRatios.ratio_height * wmin / aRatios.ratio_width | 0; assetObj.wmin = wmin; assetObj.hmin = hmin; } @@ -305,11 +305,11 @@ export const spec = { } } } - let imps = []; + const imps = []; // ITERATE THE VALID REQUESTS AND GENERATE IMP OBJECT validRequests.forEach(bidRequest => { // BUILD THE IMP OBJECT - let imp = { + const imp = { id: bidRequest.bidId, tagid: bidRequest.params.tagid || bidRequest.adUnitCode, placement_id: bidRequest.params.placement_id || 0, @@ -329,7 +329,7 @@ export const spec = { // BUILD THE SIZES if (deepAccess(bidRequest, `mediaTypes.banner`)) { - let sizes = getAdUnitSizes(bidRequest); + const sizes = getAdUnitSizes(bidRequest); if (sizes.length) { imp.banner = { w: sizes[0][0], @@ -353,7 +353,7 @@ export const spec = { } // GENERATE SITE OBJECT - let site = { + const site = { domain: window.location.host, // TODO: is 'page' the right value here? page: bidderRequest.refererInfo.page, @@ -373,13 +373,13 @@ export const spec = { } // ADD META KEYWORDS IF FOUND - let keywords = document.getElementsByTagName('meta')['keywords']; + const keywords = document.getElementsByTagName('meta')['keywords']; if (keywords && keywords.content) { site.keywords = keywords.content; } // GENERATE DEVICE OBJECT - let device = { + const device = { ip: 'peer', ua: window.navigator.userAgent, js: 1, @@ -396,8 +396,8 @@ export const spec = { } }; - let sourceId = validRequests[0].params.source_id || 0; - let host = validRequests[0].params.host || 'prebid.dblks.net'; + const sourceId = validRequests[0].params.source_id || 0; + const host = validRequests[0].params.host || 'prebid.dblks.net'; // RETURN WITH THE REQUEST AND PAYLOAD return { @@ -418,8 +418,8 @@ export const spec = { // INITIATE USER SYNCING getUserSyncs: function(options, rtbResponse, gdprConsent) { const syncs = []; - let bidResponse = rtbResponse?.[0]?.body ?? null; - let scope = this; + const bidResponse = rtbResponse?.[0]?.body ?? null; + const scope = this; // LISTEN FOR SYNC DATA FROM IFRAME TYPE SYNC window.addEventListener('message', function (event) { @@ -432,7 +432,7 @@ export const spec = { }); // POPULATE GDPR INFORMATION - let gdprData = { + const gdprData = { gdpr: 0, gdprConsent: '' } @@ -465,8 +465,8 @@ export const spec = { function addParams(sync) { // PARSE THE URL try { - let url = new URL(sync.url); - let urlParams = {}; + const url = new URL(sync.url); + const urlParams = {}; for (const [key, value] of url.searchParams.entries()) { urlParams[key] = value; }; @@ -547,19 +547,19 @@ export const spec = { return result; } - let bids = []; - let resBids = deepAccess(rtbResponse, 'body.seatbid') || []; + const bids = []; + const resBids = deepAccess(rtbResponse, 'body.seatbid') || []; resBids.forEach(bid => { - let resultItem = {requestId: bid.id, cpm: bid.price, creativeId: bid.crid, currency: bid.currency || 'USD', netRevenue: true, ttl: bid.ttl || 360, meta: {advertiserDomains: bid.adomain}}; + const resultItem = {requestId: bid.id, cpm: bid.price, creativeId: bid.crid, currency: bid.currency || 'USD', netRevenue: true, ttl: bid.ttl || 360, meta: {advertiserDomains: bid.adomain}}; - let mediaType = deepAccess(bid, 'ext.mtype') || ''; + const mediaType = deepAccess(bid, 'ext.mtype') || ''; switch (mediaType) { case 'banner': bids.push(Object.assign({}, resultItem, {mediaType: BANNER, width: bid.w, height: bid.h, ad: bid.adm})); break; case 'native': - let nativeResult = JSON.parse(bid.adm); + const nativeResult = JSON.parse(bid.adm); bids.push(Object.assign({}, resultItem, {mediaType: NATIVE, native: parseNative(nativeResult.native)})); break; @@ -590,7 +590,7 @@ export class BotClientTests { let response = false; if (window && document) { - let results = [ + const results = [ 'webdriver' in window, '_Selenium_IDE_Recorder' in window, 'callSelenium' in window, diff --git a/modules/datawrkzBidAdapter.js b/modules/datawrkzBidAdapter.js index edbd374cc25..e28e6c1c4d6 100644 --- a/modules/datawrkzBidAdapter.js +++ b/modules/datawrkzBidAdapter.js @@ -50,7 +50,7 @@ export const spec = { * @return ServerRequest Info describing the request to the server. */ buildRequests: function(validBidRequests, bidderRequest) { - let requests = []; + const requests = []; if (validBidRequests.length > 0) { validBidRequests.forEach(bidRequest => { @@ -76,8 +76,8 @@ export const spec = { */ interpretResponse: function(serverResponse, request) { var bidResponses = []; - let bidRequest = request.bidRequest - let bidResponse = serverResponse.body; + const bidRequest = request.bidRequest + const bidResponse = serverResponse.body; // valid object? if ((!bidResponse || !bidResponse.id) || (!bidResponse.seatbid || bidResponse.seatbid.length === 0 || @@ -98,13 +98,13 @@ export const spec = { /* Generate bid request for banner adunit */ function buildBannerRequest(bidRequest, bidderRequest) { - let bidFloor = getBidFloor(bidRequest); + const bidFloor = getBidFloor(bidRequest); let adW = 0; let adH = 0; - let bannerSizes = deepAccess(bidRequest, 'mediaTypes.banner.sizes'); - let bidSizes = isArray(bannerSizes) ? bannerSizes : bidRequest.sizes; + const bannerSizes = deepAccess(bidRequest, 'mediaTypes.banner.sizes'); + const bidSizes = isArray(bannerSizes) ? bannerSizes : bidRequest.sizes; if (isArray(bidSizes)) { if (bidSizes.length === 2 && typeof bidSizes[0] === 'number' && typeof bidSizes[1] === 'number') { adW = parseInt(bidSizes[0]); @@ -147,36 +147,36 @@ function buildBannerRequest(bidRequest, bidderRequest) { /* Generate bid request for native adunit */ function buildNativeRequest(bidRequest, bidderRequest) { let counter = 0; - let assets = []; + const assets = []; - let bidFloor = getBidFloor(bidRequest); + const bidFloor = getBidFloor(bidRequest); - let title = deepAccess(bidRequest, 'mediaTypes.native.title'); + const title = deepAccess(bidRequest, 'mediaTypes.native.title'); if (title && title.len) { assets.push(generateNativeTitleObj(title, ++counter)); } - let image = deepAccess(bidRequest, 'mediaTypes.native.image'); + const image = deepAccess(bidRequest, 'mediaTypes.native.image'); if (image) { assets.push(generateNativeImgObj(image, 'image', ++counter)); } - let icon = deepAccess(bidRequest, 'mediaTypes.native.icon'); + const icon = deepAccess(bidRequest, 'mediaTypes.native.icon'); if (icon) { assets.push(generateNativeImgObj(icon, 'icon', ++counter)); } - let sponsoredBy = deepAccess(bidRequest, 'mediaTypes.native.sponsoredBy'); + const sponsoredBy = deepAccess(bidRequest, 'mediaTypes.native.sponsoredBy'); if (sponsoredBy) { assets.push(generateNativeDataObj(sponsoredBy, 'sponsored', ++counter)); } - let cta = deepAccess(bidRequest, 'mediaTypes.native.cta'); + const cta = deepAccess(bidRequest, 'mediaTypes.native.cta'); if (cta) { assets.push(generateNativeDataObj(cta, 'cta', ++counter)); } - let body = deepAccess(bidRequest, 'mediaTypes.native.body'); + const body = deepAccess(bidRequest, 'mediaTypes.native.body'); if (body) { assets.push(generateNativeDataObj(body, 'desc', ++counter)); } - let request = JSON.stringify({assets: assets}); + const request = JSON.stringify({assets: assets}); const native = { request: request }; @@ -210,9 +210,9 @@ function buildNativeRequest(bidRequest, bidderRequest) { /* Generate bid request for video adunit */ function buildVideoRequest(bidRequest, bidderRequest) { - let bidFloor = getBidFloor(bidRequest); + const bidFloor = getBidFloor(bidRequest); - let sizeObj = getVideoAdUnitSize(bidRequest); + const sizeObj = getVideoAdUnitSize(bidRequest); const video = { w: sizeObj.adW, @@ -232,7 +232,7 @@ function buildVideoRequest(bidRequest, bidderRequest) { skipafter: deepAccess(bidRequest, 'mediaTypes.video.skipafter') }; - let context = deepAccess(bidRequest, 'mediaTypes.video.context'); + const context = deepAccess(bidRequest, 'mediaTypes.video.context'); if (context == 'outstream' && !bidRequest.renderer) video.mimes = OUTSTREAM_MIMES; var imp = []; @@ -267,7 +267,7 @@ function buildVideoRequest(bidRequest, bidderRequest) { function getVideoAdUnitSize(bidRequest) { var adH = 0; var adW = 0; - let playerSize = deepAccess(bidRequest, 'mediaTypes.video.playerSize'); + const playerSize = deepAccess(bidRequest, 'mediaTypes.video.playerSize'); if (isArray(playerSize)) { if (playerSize.length === 2 && typeof playerSize[0] === 'number' && typeof playerSize[1] === 'number') { adW = parseInt(playerSize[0]); @@ -290,15 +290,15 @@ function getMediaTypeOfResponse(bidRequest) { /* Generate endpoint url */ function generateScriptUrl(bidRequest) { - let queryParams = 'hb=1'; - let siteId = getBidIdParameter('site_id', bidRequest.params); + const queryParams = 'hb=1'; + const siteId = getBidIdParameter('site_id', bidRequest.params); return ENDPOINT_URL + siteId + '?' + queryParams; } /* Generate request payload for the adunit */ function generatePayload(imp, bidderRequest) { - let domain = window.location.host; - let page = window.location.host + window.location.pathname + location.search + location.hash; + const domain = window.location.host; + const page = window.location.host + window.location.pathname + location.search + location.hash; const site = { domain: domain, @@ -306,7 +306,7 @@ function generatePayload(imp, bidderRequest) { publisher: {} }; - let regs = {ext: {}}; + const regs = {ext: {}}; if (bidderRequest.uspConsent) { regs.ext.us_privacy = bidderRequest.uspConsent; @@ -338,7 +338,7 @@ function generatePayload(imp, bidderRequest) { function generateNativeImgObj(obj, type, id) { let adW = 0; let adH = 0; - let bidSizes = obj.sizes; + const bidSizes = obj.sizes; var typeId; if (type == 'icon') typeId = 1; @@ -354,8 +354,8 @@ function generateNativeImgObj(obj, type, id) { } } - let required = obj.required ? 1 : 0; - let image = { + const required = obj.required ? 1 : 0; + const image = { type: parseInt(typeId), w: adW, h: adH @@ -369,8 +369,8 @@ function generateNativeImgObj(obj, type, id) { /* Generate title asset object */ function generateNativeTitleObj(obj, id) { - let required = obj.required ? 1 : 0; - let title = { + const required = obj.required ? 1 : 0; + const title = { len: obj.len }; return { @@ -392,8 +392,8 @@ function generateNativeDataObj(obj, type, id) { break; } - let required = obj.required ? 1 : 0; - let data = { + const required = obj.required ? 1 : 0; + const data = { type: typeId }; if (typeId == 2 && obj.len) { @@ -439,8 +439,8 @@ function buildBannerResponse(bidRequest, bidResponse) { bidResponse.size = bidSizes; bidResponse.width = parseInt(bidderBid.w); bidResponse.height = parseInt(bidderBid.h); - let responseAd = bidderBid.adm; - let responseNurl = ''; + const responseAd = bidderBid.adm; + const responseNurl = ''; bidResponse.ad = decodeURIComponent(responseAd + responseNurl); bidResponse.mediaType = BANNER; bidResponses.push(bidResponse); @@ -457,7 +457,7 @@ function buildNativeResponse(bidRequest, response) { let bidResponse = createBaseBidResponse(bidRequest, bidderBid, bidResponses); if (!bidResponse) return; - let nativeResponse = JSON.parse(bidderBid.adm).native; + const nativeResponse = JSON.parse(bidderBid.adm).native; const native = { clickUrl: nativeResponse.link.url, @@ -465,7 +465,7 @@ function buildNativeResponse(bidRequest, response) { }; nativeResponse.assets.forEach(function(asset) { - let keyVal = getNativeAssestObj(asset, bidRequest.assets); + const keyVal = getNativeAssestObj(asset, bidRequest.assets); native[keyVal.key] = keyVal.value; }); @@ -607,7 +607,7 @@ function getBidFloor(bid) { return (bid.params.bidfloor) ? bid.params.bidfloor : null; } - let floor = bid.getFloor({ + const floor = bid.getFloor({ currency: 'USD', mediaType: '*', size: '*' diff --git a/modules/dchain.ts b/modules/dchain.ts index 3bfdf8197bb..24cab96a54f 100644 --- a/modules/dchain.ts +++ b/modules/dchain.ts @@ -17,8 +17,8 @@ const MODES = []; // an array of modes _each(MODE, mode => MODES.push(mode)); export function checkDchainSyntax(bid, mode) { - let dchainObj = deepClone(bid.meta.dchain); - let failPrefix = 'Detected something wrong in bid.meta.dchain object for bid:'; + const dchainObj = deepClone(bid.meta.dchain); + const failPrefix = 'Detected something wrong in bid.meta.dchain object for bid:'; let failMsg = ''; const dchainPropList = ['ver', 'complete', 'nodes', 'ext']; @@ -34,7 +34,7 @@ export function checkDchainSyntax(bid, mode) { } } - let dchainProps = Object.keys(dchainObj); + const dchainProps = Object.keys(dchainObj); dchainProps.forEach(prop => { if (!dchainPropList.includes(prop)) { appendFailMsg(`dchain.${prop}` + shouldBeValid); @@ -65,7 +65,7 @@ export function checkDchainSyntax(bid, mode) { if (!isPlainObject(node)) { appendFailMsg(`dchain.nodes[${index}]` + shouldBeAnObject); } else { - let nodeProps = Object.keys(node); + const nodeProps = Object.keys(node); nodeProps.forEach(prop => { if (!nodesPropList.includes(prop)) { appendFailMsg(`dchain.nodes[${index}].${prop}` + shouldBeValid); @@ -131,9 +131,9 @@ export const addBidResponseHook = timedBidResponseHook('dchain', function addBid } basicDchain.nodes.push({ name: bid.bidderCode }); - let bidDchain = deepAccess(bid, 'meta.dchain'); + const bidDchain = deepAccess(bid, 'meta.dchain'); if (bidDchain && isPlainObject(bidDchain)) { - let result = isValidDchain(bid); + const result = isValidDchain(bid); if (result) { // extra check in-case mode is OFF and there is a setup issue diff --git a/modules/deepintentBidAdapter.js b/modules/deepintentBidAdapter.js index 9c67eb02fa9..04e27f034e2 100644 --- a/modules/deepintentBidAdapter.js +++ b/modules/deepintentBidAdapter.js @@ -36,14 +36,14 @@ export const spec = { return valid; }, interpretResponse: function(bidResponse, bidRequest) { - let responses = []; + const responses = []; if (bidResponse && bidResponse.body) { try { - let bids = bidResponse.body.seatbid && bidResponse.body.seatbid[0] ? bidResponse.body.seatbid[0].bid : []; + const bids = bidResponse.body.seatbid && bidResponse.body.seatbid[0] ? bidResponse.body.seatbid[0].bid : []; if (bids) { bids.forEach(bidObj => { - let newBid = formatResponse(bidObj); - let mediaType = _checkMediaType(bidObj); + const newBid = formatResponse(bidObj); + const mediaType = _checkMediaType(bidObj); if (mediaType === BANNER) { newBid.mediaType = BANNER; } else if (mediaType === VIDEO) { @@ -119,7 +119,7 @@ export const spec = { }; function _checkMediaType(bid) { - let videoRegex = new RegExp(/VAST\s+version/); + const videoRegex = new RegExp(/VAST\s+version/); let mediaType; if (bid.adm && bid.adm.indexOf('deepintent_wrapper') >= 0) { mediaType = BANNER; @@ -130,7 +130,7 @@ function _checkMediaType(bid) { } function clean(obj) { - for (let propName in obj) { + for (const propName in obj) { if (obj[propName] === null || obj[propName] === undefined) { delete obj[propName]; } @@ -163,7 +163,7 @@ function getFloor(bidRequest) { return bidRequest.params?.bidfloor; } - let floor = bidRequest.getFloor({ + const floor = bidRequest.getFloor({ currency: 'USD', mediaType: '*', size: '*' @@ -241,7 +241,7 @@ function buildBanner(bid) { if (deepAccess(bid, 'mediaTypes.banner')) { // Get Sizes from MediaTypes Object, Will always take first size, will be overrided by params for exact w,h if (deepAccess(bid, 'mediaTypes.banner.sizes') && !bid.params.height && !bid.params.width) { - let sizes = deepAccess(bid, 'mediaTypes.banner.sizes'); + const sizes = deepAccess(bid, 'mediaTypes.banner.sizes'); if (isArray(sizes) && sizes.length > 0) { return { h: sizes[0][1], @@ -260,7 +260,7 @@ function buildBanner(bid) { } function buildSite(bidderRequest) { - let site = {}; + const site = {}; if (bidderRequest && bidderRequest.refererInfo && bidderRequest.refererInfo.page) { site.page = bidderRequest.refererInfo.page; site.domain = bidderRequest.refererInfo.domain; diff --git a/modules/deltaprojectsBidAdapter.js b/modules/deltaprojectsBidAdapter.js index 02d0e21cf9d..fdf22e3d264 100644 --- a/modules/deltaprojectsBidAdapter.js +++ b/modules/deltaprojectsBidAdapter.js @@ -58,7 +58,7 @@ function buildRequests(validBidRequests, bidderRequest) { } // -- build user, reg - let user = { ext: {} }; + const user = { ext: {} }; const regs = { ext: {} }; const gdprConsent = bidderRequest && bidderRequest.gdprConsent; if (gdprConsent) { @@ -69,7 +69,7 @@ function buildRequests(validBidRequests, bidderRequest) { } // -- build tmax - let tmax = (bidderRequest && bidderRequest.timeout > 0) ? bidderRequest.timeout : undefined; + const tmax = (bidderRequest && bidderRequest.timeout > 0) ? bidderRequest.timeout : undefined; // build bid specific return validBidRequests.map(validBidRequest => { diff --git a/modules/dgkeywordRtdProvider.js b/modules/dgkeywordRtdProvider.js index 92f63703f42..0825de8261b 100644 --- a/modules/dgkeywordRtdProvider.js +++ b/modules/dgkeywordRtdProvider.js @@ -37,7 +37,7 @@ export function getDgKeywordsAndSet(reqBidsConfigObj, callback, moduleConfig, us })(callback); let isFinish = false; logMessage('[dgkeyword sub module]', adUnits, timeout); - let setKeywordTargetBidders = getTargetBidderOfDgKeywords(adUnits); + const setKeywordTargetBidders = getTargetBidderOfDgKeywords(adUnits); if (setKeywordTargetBidders.length <= 0) { logMessage('[dgkeyword sub module] no dgkeyword targets.'); callback(); @@ -50,7 +50,7 @@ export function getDgKeywordsAndSet(reqBidsConfigObj, callback, moduleConfig, us if (!isFinish) { logMessage('[dgkeyword sub module] get targets from profile api end.'); if (res) { - let keywords = {}; + const keywords = {}; if (res['s'] != null && res['s'].length > 0) { keywords['opeaud'] = res['s']; } @@ -59,7 +59,7 @@ export function getDgKeywordsAndSet(reqBidsConfigObj, callback, moduleConfig, us } if (Object.keys(keywords).length > 0) { const targetBidKeys = {}; - for (let bid of setKeywordTargetBidders) { + for (const bid of setKeywordTargetBidders) { // set keywords to ortb2Imp deepSetValue(bid, 'ortb2Imp.ext.data.keywords', convertKeywordsToString(keywords)); if (!targetBidKeys[bid.bidder]) { @@ -118,9 +118,9 @@ export function readFpidFromLocalStrage() { * @param {Object} adUnits */ export function getTargetBidderOfDgKeywords(adUnits) { - let setKeywordTargetBidders = []; - for (let adUnit of adUnits) { - for (let bid of adUnit.bids) { + const setKeywordTargetBidders = []; + for (const adUnit of adUnits) { + for (const bid of adUnit.bids) { if (bid.params && bid.params['dgkeyword'] === true) { delete bid.params['dgkeyword']; setKeywordTargetBidders.push(bid); diff --git a/modules/dianomiBidAdapter.js b/modules/dianomiBidAdapter.js index a91c5d777cd..aaf0dc036d2 100644 --- a/modules/dianomiBidAdapter.js +++ b/modules/dianomiBidAdapter.js @@ -83,7 +83,7 @@ export const spec = { let app, site; const commonFpd = bidderRequest.ortb2 || {}; - let { user } = commonFpd; + const { user } = commonFpd; if (typeof getConfig('app') === 'object') { app = getConfig('app') || {}; diff --git a/modules/digitalMatterBidAdapter.js b/modules/digitalMatterBidAdapter.js index e5acd9e98de..70aa80dc6e0 100644 --- a/modules/digitalMatterBidAdapter.js +++ b/modules/digitalMatterBidAdapter.js @@ -156,8 +156,8 @@ export const spec = { const userSync = response.body.ext.usersync; userSync.forEach((element) => { - let url = element.url; - let type = element.type; + const url = element.url; + const type = element.type; if (url) { if ((type === 'image' || type === 'redirect') && syncOptions.pixelEnabled) { @@ -178,7 +178,7 @@ export const spec = { } } -let usersSynced = false; +const usersSynced = false; function hasBannerMediaType(bidRequest) { return !!deepAccess(bidRequest, 'mediaTypes.banner'); diff --git a/modules/discoveryBidAdapter.js b/modules/discoveryBidAdapter.js index fb40eb59853..8992efa9829 100644 --- a/modules/discoveryBidAdapter.js +++ b/modules/discoveryBidAdapter.js @@ -19,8 +19,8 @@ const BIDDER_CODE = 'discovery'; const ENDPOINT_URL = 'https://rtb-jp.mediago.io/api/bid?tn='; const TIME_TO_LIVE = 500; export const storage = getStorageManager({bidderCode: BIDDER_CODE}); -let globals = {}; -let itemMaps = {}; +const globals = {}; +const itemMaps = {}; const MEDIATYPE = [BANNER, NATIVE]; /* ----- _ss_pp_id:start ------ */ @@ -106,7 +106,7 @@ export const getPmgUID = () => { function getKv(obj, ...keys) { let o = obj; - for (let key of keys) { + for (const key of keys) { if (o && o[key]) { o = o[key]; } else { @@ -172,20 +172,20 @@ function getItems(validBidRequests, bidderRequest) { items = validBidRequests.map((req, i) => { let ret = {}; - let mediaTypes = getKv(req, 'mediaTypes'); + const mediaTypes = getKv(req, 'mediaTypes'); const bidFloor = getBidFloor(req); - let id = '' + (i + 1); + const id = '' + (i + 1); if (mediaTypes.native) { ret = { ...NATIVERET, ...{ id, bidFloor } }; } // banner if (mediaTypes.banner) { - let sizes = transformSizes(getKv(req, 'sizes')); + const sizes = transformSizes(getKv(req, 'sizes')); let matchSize; - for (let size of sizes) { + for (const size of sizes) { matchSize = popInAdSize.find( (item) => size.width === item.w && size.height === item.h ); @@ -249,11 +249,11 @@ function getParam(validBidRequests, bidderRequest) { const sharedid = utils.deepAccess(validBidRequests[0], 'crumbs.pubcid'); const eids = validBidRequests[0].userIdAsEids; - let isMobile = getDevice() ? 1 : 0; + const isMobile = getDevice() ? 1 : 0; // input test status by Publisher. more frequently for test true req - let isTest = validBidRequests[0].params.test || 0; - let auctionId = getKv(bidderRequest, 'auctionId'); - let items = getItems(validBidRequests, bidderRequest); + const isTest = validBidRequests[0].params.test || 0; + const auctionId = getKv(bidderRequest, 'auctionId'); + const items = getItems(validBidRequests, bidderRequest); const timeout = bidderRequest.timeout || 2000; @@ -295,7 +295,7 @@ function getParam(validBidRequests, bidderRequest) { } catch (error) { } if (items && items.length) { - let c = { + const c = { // TODO: fix auctionId leak: https://github.com/prebid/Prebid.js/issues/9781 id: 'pp_hbjs_' + auctionId, test: +isTest, @@ -377,7 +377,7 @@ export const spec = { const pbToken = globals['token']; if (!pbToken) return; - let payload = getParam(validBidRequests, bidderRequest); + const payload = getParam(validBidRequests, bidderRequest); const payloadString = JSON.stringify(payload); return { @@ -396,12 +396,12 @@ export const spec = { const bids = getKv(serverResponse, 'body', 'seatbid', 0, 'bid'); const cur = getKv(serverResponse, 'body', 'cur'); const bidResponses = []; - for (let bid of bids) { - let impid = getKv(bid, 'impid'); + for (const bid of bids) { + const impid = getKv(bid, 'impid'); if (itemMaps[impid]) { - let bidId = getKv(itemMaps[impid], 'req', 'bidId'); + const bidId = getKv(itemMaps[impid], 'req', 'bidId'); const mediaType = getKv(bid, 'w') ? 'banner' : 'native'; - let bidResponse = { + const bidResponse = { requestId: bidId, cpm: getKv(bid, 'price'), creativeId: getKv(bid, 'cid'), diff --git a/modules/displayioBidAdapter.js b/modules/displayioBidAdapter.js index 3cdfd3a77cd..0caa84d61d5 100644 --- a/modules/displayioBidAdapter.js +++ b/modules/displayioBidAdapter.js @@ -21,7 +21,7 @@ export const spec = { }, buildRequests: function (bidRequests, bidderRequest) { return bidRequests.map(bid => { - let url = '//' + bid.params.adsSrvDomain + '/srv?method=getPlacement&app=' + + const url = '//' + bid.params.adsSrvDomain + '/srv?method=getPlacement&app=' + bid.params.siteId + '&placement=' + bid.params.placementId; const data = getPayload(bid, bidderRequest); return { @@ -75,8 +75,8 @@ function getPayload (bid, bidderRequest) { let us = storage.getDataFromLocalStorage(US_KEY); if (!us) { us = 'us_web_xxxxxxxxxxxx'.replace(/[x]/g, c => { - let r = Math.random() * 16 | 0; - let v = c === 'x' ? r : (r & 0x3 | 0x8); + const r = Math.random() * 16 | 0; + const v = c === 'x' ? r : (r & 0x3 | 0x8); return v.toString(16); }); storage.setDataInLocalStorage(US_KEY, us); diff --git a/modules/distroscaleBidAdapter.js b/modules/distroscaleBidAdapter.js index 911ac0dba35..aefafea5b73 100644 --- a/modules/distroscaleBidAdapter.js +++ b/modules/distroscaleBidAdapter.js @@ -14,14 +14,14 @@ const UNDEF = undefined; const SUPPORTED_MEDIATYPES = [ BANNER ]; function _getHost(url) { - let a = document.createElement('a'); + const a = document.createElement('a'); a.href = url; return a.hostname; } function _getBidFloor(bid, mType, sz) { if (isFn(bid.getFloor)) { - let floor = bid.getFloor({ + const floor = bid.getFloor({ currency: DEFAULT_CURRENCY, mediaType: mType || '*', size: sz || '*' @@ -250,7 +250,7 @@ export const spec = { seatbidder.bid && isArray(seatbidder.bid) && seatbidder.bid.forEach(bid => { - let newBid = { + const newBid = { requestId: bid.impid, cpm: (parseFloat(bid.price) || 0), currency: DEFAULT_CURRENCY, diff --git a/modules/djaxBidAdapter.js b/modules/djaxBidAdapter.js index 7a9e359f520..775ae146b88 100644 --- a/modules/djaxBidAdapter.js +++ b/modules/djaxBidAdapter.js @@ -98,7 +98,7 @@ export const spec = { }, onBidWon: function(bid) { - let wonBids = []; + const wonBids = []; wonBids.push(bid); wonBids[0].function = 'onBidWon'; sendResponseToServer(wonBids); diff --git a/modules/dspxBidAdapter.js b/modules/dspxBidAdapter.js index 9a49367c0f5..62613dc1d21 100644 --- a/modules/dspxBidAdapter.js +++ b/modules/dspxBidAdapter.js @@ -62,9 +62,9 @@ export const spec = { } } - let mediaTypesInfo = getMediaTypesInfo(bidRequest); - let type = isBannerRequest(bidRequest) ? BANNER : VIDEO; - let sizes = mediaTypesInfo[type]; + const mediaTypesInfo = getMediaTypesInfo(bidRequest); + const type = isBannerRequest(bidRequest) ? BANNER : VIDEO; + const sizes = mediaTypesInfo[type]; payload = { _f: 'auto', @@ -93,7 +93,7 @@ export const spec = { } if (!payload.pfilter.floorprice) { - let bidFloor = getBidFloor(bidRequest); + const bidFloor = getBidFloor(bidRequest); if (bidFloor > 0) { payload.pfilter.floorprice = bidFloor; } @@ -114,16 +114,16 @@ export const spec = { payload.vf = params.vastFormat; } payload.vpl = {}; - let videoParams = deepAccess(bidRequest, 'mediaTypes.video'); + const videoParams = deepAccess(bidRequest, 'mediaTypes.video'); Object.keys(videoParams) .filter(key => VIDEO_ORTB_PARAMS.includes(key)) .forEach(key => payload.vpl[key] = videoParams[key]); } // iab content - let content = deepAccess(bidderRequest, 'ortb2.site.content'); + const content = deepAccess(bidderRequest, 'ortb2.site.content'); if (content) { - let stringContent = siteContentToString(content); + const stringContent = siteContentToString(content); if (stringContent) { payload.pfilter.iab_content = stringContent; } @@ -143,7 +143,7 @@ export const spec = { const schain = bidRequest?.ortb2?.source?.ext?.schain; if (schain && schain.ver && schain.complete && schain.nodes) { let schainString = schain.ver + "," + schain.complete; - for (let node of schain.nodes) { + for (const node of schain.nodes) { schainString += '!' + [ node.asi ?? '', node.sid ?? '', @@ -188,7 +188,7 @@ function outstreamRender(bid) { const inIframe = getBidIdParameter('iframe', bid.renderer.config); if (inIframe && window.document.getElementById(inIframe).nodeName === 'IFRAME') { const iframe = window.document.getElementById(inIframe); - let framedoc = iframe.contentDocument || (iframe.contentWindow && iframe.contentWindow.document); + const framedoc = iframe.contentDocument || (iframe.contentWindow && iframe.contentWindow.document); framedoc.body.appendChild(embedCode); if (typeof window.dspxRender === 'function') { window.dspxRender(bid); @@ -222,7 +222,7 @@ function outstreamRender(bid) { */ function createOutstreamEmbedCode(bid) { const fragment = window.document.createDocumentFragment(); - let div = window.document.createElement('div'); + const div = window.document.createElement('div'); div.innerHTML = deepAccess(bid, 'renderer.config.code', ''); fragment.appendChild(div); diff --git a/modules/dvgroupBidAdapter.js b/modules/dvgroupBidAdapter.js index 9bb21bba6d4..eaf39cd4ccb 100644 --- a/modules/dvgroupBidAdapter.js +++ b/modules/dvgroupBidAdapter.js @@ -29,15 +29,15 @@ export const spec = { code: BIDDER_CODE, isBidRequestValid: function(bid) { - let valid = bid.params.sspId; + const valid = bid.params.sspId; return !!valid; }, buildRequests: function(bids, bidderRequest) { return bids.map((bid) => { - let endpoint = bid.params.endpoint || DEFAULT_ENDPOINT; - let bidMediaType = deepAccess(bid, 'mediaTypes.video'); + const endpoint = bid.params.endpoint || DEFAULT_ENDPOINT; + const bidMediaType = deepAccess(bid, 'mediaTypes.video'); return { method: 'POST', url: `https://${endpoint}/bid?sspuid=${bid.params.sspId}`, diff --git a/modules/dxkultureBidAdapter.js b/modules/dxkultureBidAdapter.js index 3fa064ec3f5..d0b3a738ede 100644 --- a/modules/dxkultureBidAdapter.js +++ b/modules/dxkultureBidAdapter.js @@ -117,7 +117,7 @@ export const spec = { const data = converter.toORTB({ bidRequests: validBidRequests, bidderRequest, context: {contextMediaType} }); let publisherId = validBidRequests[0].params.publisherId; - let placementId = validBidRequests[0].params.placementId; + const placementId = validBidRequests[0].params.placementId; if (validBidRequests[0].params.e2etest) { logMessage('dxkulture: E2E test mode enabled'); @@ -160,7 +160,7 @@ export const spec = { } }); syncDetails.forEach(syncDetails => { - let queryParamStrings = []; + const queryParamStrings = []; let syncUrl = syncDetails.url; if (syncDetails.type === 'iframe') { diff --git a/modules/dynamicAdBoostRtdProvider.js b/modules/dynamicAdBoostRtdProvider.js index b89a33ecb1d..e378d2c6867 100644 --- a/modules/dynamicAdBoostRtdProvider.js +++ b/modules/dynamicAdBoostRtdProvider.js @@ -27,7 +27,7 @@ let dabStartDate; let dabStartTime; // Array of div IDs to track -let dynamicAdBoostAdUnits = {}; +const dynamicAdBoostAdUnits = {}; function init() { dabStartDate = new Date(); @@ -37,13 +37,13 @@ function init() { } // Create an Intersection Observer instance observer = new IntersectionObserver(dabHandleIntersection, dabOptions); - let keyId = 'rtd-' + window.location.hostname; + const keyId = 'rtd-' + window.location.hostname; - let dabInterval = setInterval(function() { - let dabDateNow = new Date(); - let dabTimeNow = dabDateNow.getTime(); - let dabElapsedSeconds = Math.floor((dabTimeNow - dabStartTime) / 1000); - let elapsedThreshold = 0; + const dabInterval = setInterval(function() { + const dabDateNow = new Date(); + const dabTimeNow = dabDateNow.getTime(); + const dabElapsedSeconds = Math.floor((dabTimeNow - dabStartTime) / 1000); + const elapsedThreshold = 0; if (dabElapsedSeconds >= elapsedThreshold) { clearInterval(dabInterval); // Stop @@ -65,7 +65,7 @@ function getBidRequestData(reqBidsConfigObj, callback) { if (Array.isArray(reqAdUnits)) { reqAdUnits.forEach(adunit => { - let gptCode = deepAccess(adunit, 'code'); + const gptCode = deepAccess(adunit, 'code'); if (dynamicAdBoostAdUnits.hasOwnProperty(gptCode)) { // AdUnits has reached target viewablity at some point deepSetValue(adunit, `ortb2Imp.ext.data.${MODULE_NAME}.${gptCode}`, dynamicAdBoostAdUnits[gptCode]); @@ -75,7 +75,7 @@ function getBidRequestData(reqBidsConfigObj, callback) { callback(); } -let markViewed = (entry, observer) => { +const markViewed = (entry, observer) => { return () => { observer.unobserve(entry.target); } diff --git a/modules/eightPodAnalyticsAdapter.js b/modules/eightPodAnalyticsAdapter.js index e91f9412ef5..f9fdb6cc2fa 100644 --- a/modules/eightPodAnalyticsAdapter.js +++ b/modules/eightPodAnalyticsAdapter.js @@ -26,7 +26,7 @@ let context = {}; /** * Create eightPod Analytic adapter */ -let eightPodAnalytics = Object.assign(adapter({url: trackerUrl, analyticsType}), { +const eightPodAnalytics = Object.assign(adapter({url: trackerUrl, analyticsType}), { /** * Execute on bid won - setup basic settings, save context about EightPod's bid. We will send it with our events later */ diff --git a/modules/eightPodBidAdapter.js b/modules/eightPodBidAdapter.js index 536bc4b4036..50b4561d6ec 100644 --- a/modules/eightPodBidAdapter.js +++ b/modules/eightPodBidAdapter.js @@ -47,8 +47,8 @@ function isBidRequestValid(bidRequest) { } function buildRequests(bids, bidderRequest) { - let bannerBids = bids.filter((bid) => isBannerBid(bid)) - let requests = bannerBids.length + const bannerBids = bids.filter((bid) => isBannerBid(bid)) + const requests = bannerBids.length ? createRequest(bannerBids, bidderRequest, BANNER) : [] diff --git a/modules/engageyaBidAdapter.js b/modules/engageyaBidAdapter.js index 2d2fadfe4ca..f832f60da28 100644 --- a/modules/engageyaBidAdapter.js +++ b/modules/engageyaBidAdapter.js @@ -72,7 +72,7 @@ function parseBannerResponse(rec, response) { } let style; try { - let additionalData = JSON.parse(response.widget.additionalData); + const additionalData = JSON.parse(response.widget.additionalData); const css = additionalData.css || ''; style = css ? `` : ''; } catch (e) { @@ -162,7 +162,7 @@ export const spec = { var response = serverResponse.body; var isNative = response.pbtypeId == 1; return response.recs.map(rec => { - let bid = { + const bid = { requestId: response.ireqId, width: response.imageWidth, height: response.imageHeight, diff --git a/modules/eplanningBidAdapter.js b/modules/eplanningBidAdapter.js index a739ddc0e3c..c1ca5805090 100644 --- a/modules/eplanningBidAdapter.js +++ b/modules/eplanningBidAdapter.js @@ -114,7 +114,7 @@ export const spec = { }, interpretResponse: function(serverResponse, request) { const response = serverResponse.body; - let bidResponses = []; + const bidResponses = []; if (response && !isEmpty(response.sp)) { response.sp.forEach(space => { @@ -192,7 +192,7 @@ function getUrlConfig(bidRequests) { return getTestConfig(bidRequests.filter(br => br.params.t)); } - let config = {}; + const config = {}; bidRequests.forEach(bid => { PARAMS.forEach(param => { if (bid.params[param] && !config[param]) { @@ -249,9 +249,9 @@ function getSize(bid, first) { } function getSpacesStruct(bids) { - let e = {}; + const e = {}; bids.forEach(bid => { - let size = getSize(bid, true); + const size = getSize(bid, true); e[size] = e[size] ? e[size] : []; e[size].push(bid); }); @@ -264,7 +264,7 @@ function getFirstSizeVast(sizes) { return undefined; } - let size = Array.isArray(sizes[0]) ? sizes[0] : sizes; + const size = Array.isArray(sizes[0]) ? sizes[0] : sizes; return (Array.isArray(size) && size.length == 2) ? size : undefined; } @@ -275,7 +275,7 @@ function cleanName(name) { function getFloorStr(bid) { if (typeof bid.getFloor === 'function') { - let bidFloor = bid.getFloor({ + const bidFloor = bid.getFloor({ currency: DOLLAR_CODE, mediaType: '*', size: '*' @@ -289,22 +289,22 @@ function getFloorStr(bid) { } function getSpaces(bidRequests, ml) { - let impType = bidRequests.reduce((previousBits, bid) => (bid.mediaTypes && bid.mediaTypes[VIDEO]) ? (bid.mediaTypes[VIDEO].context == 'outstream' ? (previousBits | 2) : (previousBits | 1)) : previousBits, 0); + const impType = bidRequests.reduce((previousBits, bid) => (bid.mediaTypes && bid.mediaTypes[VIDEO]) ? (bid.mediaTypes[VIDEO].context == 'outstream' ? (previousBits | 2) : (previousBits | 1)) : previousBits, 0); // Only one type of auction is supported at a time if (impType) { bidRequests = bidRequests.filter((bid) => bid.mediaTypes && bid.mediaTypes[VIDEO] && (impType & VAST_INSTREAM ? (!bid.mediaTypes[VIDEO].context || bid.mediaTypes[VIDEO].context == 'instream') : (bid.mediaTypes[VIDEO].context == 'outstream'))); } - let spacesStruct = getSpacesStruct(bidRequests); - let es = {str: '', vs: '', map: {}, impType: impType}; + const spacesStruct = getSpacesStruct(bidRequests); + const es = {str: '', vs: '', map: {}, impType: impType}; es.str = Object.keys(spacesStruct).map(size => spacesStruct[size].map((bid, i) => { es.vs += getVs(bid); let name; if (impType) { - let firstSize = getFirstSizeVast(bid.mediaTypes[VIDEO].playerSize); - let sizeVast = firstSize ? firstSize.join('x') : DEFAULT_SIZE_VAST; + const firstSize = getFirstSizeVast(bid.mediaTypes[VIDEO].playerSize); + const sizeVast = firstSize ? firstSize.join('x') : DEFAULT_SIZE_VAST; name = 'video_' + sizeVast + '_' + i; es.map[name] = bid.bidId; return name + ':' + sizeVast + ';1' + getFloorStr(bid); @@ -335,9 +335,9 @@ function getVs(bid) { } function getViewabilityData(bid) { - let r = storage.getDataFromLocalStorage(STORAGE_RENDER_PREFIX + bid.adUnitCode) || 0; - let v = storage.getDataFromLocalStorage(STORAGE_VIEW_PREFIX + bid.adUnitCode) || 0; - let ratio = r > 0 ? (v / r) : 0; + const r = storage.getDataFromLocalStorage(STORAGE_RENDER_PREFIX + bid.adUnitCode) || 0; + const v = storage.getDataFromLocalStorage(STORAGE_VIEW_PREFIX + bid.adUnitCode) || 0; + const ratio = r > 0 ? (v / r) : 0; return { render: r, ratio: window.parseInt(ratio * 10, 10) @@ -364,7 +364,7 @@ function waitForElementsPresent(elements) { adView = ad; if (index < 0) { elements.forEach(code => { - let div = _getAdSlotHTMLElement(code); + const div = _getAdSlotHTMLElement(code); if (div && div.contains(ad) && getBoundingClientRect(div).width > 0) { index = elements.indexOf(div.id); adView = div; @@ -423,9 +423,9 @@ function _getAdSlotHTMLElement(adUnitCode) { } function registerViewabilityAllBids(bids) { - let elementsNotPresent = []; + const elementsNotPresent = []; bids.forEach(bid => { - let div = _getAdSlotHTMLElement(bid.adUnitCode); + const div = _getAdSlotHTMLElement(bid.adUnitCode); if (div) { registerViewability(div, bid.adUnitCode); } else { @@ -438,12 +438,12 @@ function registerViewabilityAllBids(bids) { } function getViewabilityTracker() { - let TIME_PARTITIONS = 5; - let VIEWABILITY_TIME = 1000; - let VIEWABILITY_MIN_RATIO = 0.5; + const TIME_PARTITIONS = 5; + const VIEWABILITY_TIME = 1000; + const VIEWABILITY_MIN_RATIO = 0.5; let publicApi; let observer; - let visibilityAds = {}; + const visibilityAds = {}; function intersectionCallback(entries) { entries.forEach(function(entry) { @@ -473,7 +473,7 @@ function getViewabilityTracker() { } } function processIntervalVisibilityStatus(elapsedVisibleIntervals, element, callback) { - let visibleIntervals = observedElementIsVisible(element) ? (elapsedVisibleIntervals + 1) : 0; + const visibleIntervals = observedElementIsVisible(element) ? (elapsedVisibleIntervals + 1) : 0; if (visibleIntervals === TIME_PARTITIONS) { stopObserveViewability(element) callback(); diff --git a/modules/equativBidAdapter.js b/modules/equativBidAdapter.js index 267283ee47a..5e5de2ee9b9 100644 --- a/modules/equativBidAdapter.js +++ b/modules/equativBidAdapter.js @@ -21,10 +21,10 @@ const LOG_PREFIX = 'Equativ:'; const OUTSTREAM_RENDERER_URL = 'https://apps.sascdn.com/diff/video-outstream/equativ-video-outstream.js'; const PID_STORAGE_NAME = 'eqt_pid'; -let feedbackArray = []; -let impIdMap = {}; +const feedbackArray = []; +const impIdMap = {}; let nwid = 0; -let tokens = {}; +const tokens = {}; /** * Gets value of the local variable impIdMap @@ -246,7 +246,7 @@ export const converter = ortbConverter({ let req = buildRequest(splitImps, bidderRequest, context); - let env = ['ortb2.site.publisher', 'ortb2.app.publisher', 'ortb2.dooh.publisher'].find(propPath => deepAccess(bid, propPath)) || 'ortb2.site.publisher'; + const env = ['ortb2.site.publisher', 'ortb2.app.publisher', 'ortb2.dooh.publisher'].find(propPath => deepAccess(bid, propPath)) || 'ortb2.site.publisher'; nwid = deepAccess(bid, env + '.id') || bid.params.networkId; deepSetValue(req, env.replace('ortb2.', '') + '.id', nwid); diff --git a/modules/eskimiBidAdapter.js b/modules/eskimiBidAdapter.js index 5516656f467..56079a0a652 100644 --- a/modules/eskimiBidAdapter.js +++ b/modules/eskimiBidAdapter.js @@ -141,9 +141,9 @@ function isValidVideoRequest(bidRequest) { * @return ServerRequest Info describing the request to the server. */ function buildRequests(validBidRequests, bidderRequest) { - let videoBids = validBidRequests.filter(bid => isVideoBid(bid)); - let bannerBids = validBidRequests.filter(bid => isBannerBid(bid)); - let requests = []; + const videoBids = validBidRequests.filter(bid => isVideoBid(bid)); + const bannerBids = validBidRequests.filter(bid => isBannerBid(bid)); + const requests = []; bannerBids.forEach(bid => { requests.push(createRequest([bid], bidderRequest, BANNER)); @@ -192,7 +192,7 @@ function buildBannerImp(bidRequest, imp) { const bannerParams = {...bannerAdUnitParams, ...bannerBidderParams}; - let sizes = bidRequest.mediaTypes.banner.sizes; + const sizes = bidRequest.mediaTypes.banner.sizes; if (sizes) { utils.deepSetValue(imp, 'banner.w', sizes[0][0]); @@ -257,9 +257,9 @@ function isBannerBid(bid) { */ function getUserSyncs(syncOptions, responses, gdprConsent, uspConsent, gppConsent) { if ((syncOptions.iframeEnabled || syncOptions.pixelEnabled)) { - let pixelType = syncOptions.iframeEnabled ? 'iframe' : 'image'; - let query = []; - let syncUrl = getUserSyncUrlByRegion(); + const pixelType = syncOptions.iframeEnabled ? 'iframe' : 'image'; + const query = []; + const syncUrl = getUserSyncUrlByRegion(); // GDPR Consent Params in UserSync url if (gdprConsent) { query.push('gdpr=' + (gdprConsent.gdprApplies & 1)); diff --git a/modules/etargetBidAdapter.js b/modules/etargetBidAdapter.js index 1653d849297..523e909553e 100644 --- a/modules/etargetBidAdapter.js +++ b/modules/etargetBidAdapter.js @@ -168,7 +168,7 @@ function getBidFloor(bid) { if (!isFn(bid.getFloor)) { return null; } - let floor = bid.getFloor({ + const floor = bid.getFloor({ currency: 'EUR', mediaType: '*', size: '*' diff --git a/modules/exadsBidAdapter.js b/modules/exadsBidAdapter.js index e50c141f4b0..8b7667f3cfa 100644 --- a/modules/exadsBidAdapter.js +++ b/modules/exadsBidAdapter.js @@ -27,7 +27,7 @@ function handleReqORTB2Dot4(validBidRequest, endpointUrl, bidderRequest) { const envParams = getEnvParams(); // Make a dynamic bid request to the ad partner's endpoint - let bidRequestData = { + const bidRequestData = { 'id': validBidRequest.bidId, // NOT bid.bidderRequestId or bid.auctionId 'at': 1, 'imp': [], @@ -177,7 +177,7 @@ function handleResORTB2Dot4(serverResponse, request, adPartner) { utils.logInfo('on handleResORTB2Dot4 -> request json data:', JSON.parse(request.data)); utils.logInfo('on handleResORTB2Dot4 -> serverResponse:', serverResponse); - let bidResponses = []; + const bidResponses = []; const bidRq = JSON.parse(request.data); if (serverResponse.hasOwnProperty('body') && serverResponse.body.hasOwnProperty('id')) { @@ -302,7 +302,7 @@ function makeBidRequest(url, data) { } function getUrl(adPartner, bid) { - let endpointUrlMapping = { + const endpointUrlMapping = { [PARTNERS.ORTB_2_4]: bid.params.endpoint + '?idzone=' + bid.params.zoneId + '&fid=' + bid.params.fid }; @@ -342,8 +342,8 @@ function getEnvParams() { envParams.osName = 'Unknown'; } - let browserLanguage = navigator.language || navigator.userLanguage; - let acceptLanguage = browserLanguage.replace('_', '-'); + const browserLanguage = navigator.language || navigator.userLanguage; + const acceptLanguage = browserLanguage.replace('_', '-'); envParams.language = acceptLanguage; @@ -447,7 +447,7 @@ export const spec = { return false; } - let adPartner = bid.params.partner; + const adPartner = bid.params.partner; if (adPartnerHandlers[adPartner] && adPartnerHandlers[adPartner]['validation']) { return adPartnerHandlers[adPartner]['validation'](bid); @@ -461,11 +461,11 @@ export const spec = { utils.logInfo('on buildRequests -> bidderRequest:', bidderRequest); return validBidRequests.map(bid => { - let adPartner = bid.params.partner; + const adPartner = bid.params.partner; imps.set(bid.params.impressionId, { adPartner: adPartner, mediaType: null }); - let endpointUrl = getUrl(adPartner, bid); + const endpointUrl = getUrl(adPartner, bid); // Call the handler for the ad partner, passing relevant parameters if (adPartnerHandlers[adPartner]['request']) { diff --git a/modules/excoBidAdapter.js b/modules/excoBidAdapter.js index d0b19a4aeee..5123120be88 100644 --- a/modules/excoBidAdapter.js +++ b/modules/excoBidAdapter.js @@ -263,6 +263,10 @@ export class AdapterHelpers { logInfo(msg); } } + + isDebugEnabled(url = '') { + return config.getConfig('debug') || url.includes('exco_debug=true'); + } } const helpers = new AdapterHelpers(); @@ -279,7 +283,7 @@ export const converter = ortbConverter({ } data.cur = [CURRENCY]; - data.test = config.getConfig('debug') ? 1 : 0; + data.test = helpers.isDebugEnabled(window.location.href) ? 1 : 0; helpers.addOrtbFirstPartyData(data, context.bidRequests || []); diff --git a/modules/fabrickIdSystem.js b/modules/fabrickIdSystem.js index e3bf97d0b5b..34fa990c080 100644 --- a/modules/fabrickIdSystem.js +++ b/modules/fabrickIdSystem.js @@ -59,15 +59,15 @@ export const fabrickIdSubmodule = { } try { let url = _getBaseUrl(configParams); - let keysArr = Object.keys(configParams); - for (let i in keysArr) { - let k = keysArr[i]; + const keysArr = Object.keys(configParams); + for (const i in keysArr) { + const k = keysArr[i]; if (k === 'url' || k === 'refererInfo' || (k.length > 3 && k.substring(0, 3) === 'max')) { continue; } - let v = configParams[k]; + const v = configParams[k]; if (Array.isArray(v)) { - for (let j in v) { + for (const j in v) { if (typeof v[j] === 'string' || typeof v[j] === 'number') { url += `${k}=${v[j]}&`; } diff --git a/modules/fanBidAdapter.js b/modules/fanBidAdapter.js index cdcc8d19889..2c11f635222 100644 --- a/modules/fanBidAdapter.js +++ b/modules/fanBidAdapter.js @@ -96,7 +96,7 @@ export const spec = { */ interpretResponse: function (serverResponse, bidRequest) { const serverBody = serverResponse.body; - let bidResponses = []; + const bidResponses = []; if (!serverBody) { return bidResponses; diff --git a/modules/feedadBidAdapter.js b/modules/feedadBidAdapter.js index 0b72ad49bfd..c8df1498f80 100644 --- a/modules/feedadBidAdapter.js +++ b/modules/feedadBidAdapter.js @@ -231,11 +231,11 @@ function buildRequests(validBidRequests, bidderRequest) { if (!bidderRequest) { return []; } - let acceptableRequests = validBidRequests.filter(request => !isMediaTypesEmpty(filterSupportedMediaTypes(request.mediaTypes))); + const acceptableRequests = validBidRequests.filter(request => !isMediaTypesEmpty(filterSupportedMediaTypes(request.mediaTypes))); if (acceptableRequests.length === 0) { return []; } - let data = Object.assign({}, bidderRequest, { + const data = Object.assign({}, bidderRequest, { bids: acceptableRequests.map(req => { req.params = createApiBidRParams(req); return req; @@ -315,7 +315,7 @@ function trackingHandlerFactory(klass) { if (!data) { return; } - let params = createTrackingParams(data, klass); + const params = createTrackingParams(data, klass); if (params) { ajax(`${API_ENDPOINT}${API_PATH_TRACK_REQUEST}`, null, JSON.stringify(params), { withCredentials: true, diff --git a/modules/finativeBidAdapter.js b/modules/finativeBidAdapter.js index 0cdcae15e61..1b901213d15 100644 --- a/modules/finativeBidAdapter.js +++ b/modules/finativeBidAdapter.js @@ -191,7 +191,7 @@ registerBidder(spec); function parseNative(bid) { const {assets, link, imptrackers} = bid.adm.native; - let clickUrl = link.url.replace(/\$\{AUCTION_PRICE\}/g, bid.price); + const clickUrl = link.url.replace(/\$\{AUCTION_PRICE\}/g, bid.price); if (link.clicktrackers) { link.clicktrackers.forEach(function (clicktracker, index) { diff --git a/modules/fintezaAnalyticsAdapter.js b/modules/fintezaAnalyticsAdapter.js index 78777cd6478..3f5c413d3f5 100644 --- a/modules/fintezaAnalyticsAdapter.js +++ b/modules/fintezaAnalyticsAdapter.js @@ -53,7 +53,7 @@ function getUniqId() { } if (uniq && isUniqFromLS) { - let expires = new Date(); + const expires = new Date(); expires.setFullYear(expires.getFullYear() + 10); try { diff --git a/modules/fluctBidAdapter.js b/modules/fluctBidAdapter.js index 78d574ed43b..61f08919500 100644 --- a/modules/fluctBidAdapter.js +++ b/modules/fluctBidAdapter.js @@ -140,7 +140,7 @@ export const spec = { const callImpBeacon = ``; - let data = { + const data = { requestId: res.id, currency: res.cur, cpm: parseFloat(bid.price) || 0, diff --git a/modules/fpdModule/index.js b/modules/fpdModule/index.js index 608b1763f9b..4beb07b5656 100644 --- a/modules/fpdModule/index.js +++ b/modules/fpdModule/index.js @@ -8,7 +8,7 @@ import {logError} from '../../src/utils.js'; import {PbPromise} from '../../src/utils/promise.js'; import {timedAuctionHook} from '../../src/utils/perfMetrics.js'; -let submodules = []; +const submodules = []; export function registerSubmodules(submodule) { submodules.push(submodule); @@ -19,7 +19,7 @@ export function reset() { } export function processFpd({global = {}, bidder = {}} = {}) { - let modConf = config.getConfig('firstPartyData') || {}; + const modConf = config.getConfig('firstPartyData') || {}; let result = PbPromise.resolve({global, bidder}); submodules.sort((a, b) => { return ((a.queue || 1) - (b.queue || 1)); diff --git a/modules/ftrackIdSystem.js b/modules/ftrackIdSystem.js index 7474703974d..01542783ee2 100644 --- a/modules/ftrackIdSystem.js +++ b/modules/ftrackIdSystem.js @@ -26,7 +26,7 @@ const FTRACK_STORAGE_NAME = 'ftrackId'; const FTRACK_PRIVACY_STORAGE_NAME = `${FTRACK_STORAGE_NAME}_privacy`; const storage = getStorageManager({moduleType: MODULE_TYPE_UID, moduleName: MODULE_NAME}); -let consentInfo = { +const consentInfo = { gdpr: { applies: 0, consentString: null, diff --git a/modules/gamAdServerVideo.js b/modules/gamAdServerVideo.js index f7ebc46f183..538f113f377 100644 --- a/modules/gamAdServerVideo.js +++ b/modules/gamAdServerVideo.js @@ -105,7 +105,7 @@ export function buildGamVideoUrl(options) { derivedParams.sz = urlSzParam + '|' + derivedParams.sz; } - let encodedCustomParams = getCustParams(bid, options, urlSearchComponent && urlSearchComponent.cust_params); + const encodedCustomParams = getCustParams(bid, options, urlSearchComponent && urlSearchComponent.cust_params); const queryParams = Object.assign({}, DEFAULT_GAM_PARAMS, @@ -228,7 +228,7 @@ function getCustParams(bid, options, urlCustParams) { let allTargetingData = {}; const adUnit = options && options.adUnit; if (adUnit) { - let allTargeting = targeting.getAllTargeting(adUnit.code); + const allTargeting = targeting.getAllTargeting(adUnit.code); allTargetingData = (allTargeting) ? allTargeting[adUnit.code] : {}; } diff --git a/modules/gamAdpod.js b/modules/gamAdpod.js index 2ee2a556c0d..c21c71c0c3c 100644 --- a/modules/gamAdpod.js +++ b/modules/gamAdpod.js @@ -35,9 +35,9 @@ export function buildAdpodVideoUrl({code, params, callback} = {}) { }; function getSizeForAdUnit(code) { - let adUnit = auctionManager.getAdUnits() + const adUnit = auctionManager.getAdUnits() .filter((adUnit) => adUnit.code === code) - let sizes = deepAccess(adUnit[0], 'mediaTypes.video.playerSize'); + const sizes = deepAccess(adUnit[0], 'mediaTypes.video.playerSize'); return parseSizesInput(sizes).join('|'); } @@ -52,7 +52,7 @@ export function buildAdpodVideoUrl({code, params, callback} = {}) { return; } - let initialValue = { + const initialValue = { [adpodUtils.TARGETING_KEY_PB_CAT_DUR]: undefined, [adpodUtils.TARGETING_KEY_CACHE_ID]: undefined }; @@ -68,7 +68,7 @@ export function buildAdpodVideoUrl({code, params, callback} = {}) { }, initialValue); } - let encodedCustomParams = encodeURIComponent(formatQS(customParams)); + const encodedCustomParams = encodeURIComponent(formatQS(customParams)); const queryParams = Object.assign({}, DEFAULT_GAM_PARAMS, diff --git a/modules/gamoshiBidAdapter.js b/modules/gamoshiBidAdapter.js index 8a6d6cdca6e..2af6e3d0d93 100644 --- a/modules/gamoshiBidAdapter.js +++ b/modules/gamoshiBidAdapter.js @@ -51,7 +51,7 @@ export const helper = { return bid.params.bidfloor ? bid.params.bidfloor : null; } - let bidFloor = bid.getFloor({ + const bidFloor = bid.getFloor({ mediaType: '*', size: '*', currency: 'USD' @@ -184,7 +184,7 @@ export const spec = { } } - let eids = []; + const eids = []; if (bidRequest && bidRequest.userId) { addExternalUserId(eids, deepAccess(bidRequest, `userId.id5id.uid`), 'id5-sync.com', 'ID5ID'); addExternalUserId(eids, deepAccess(bidRequest, `userId.tdid`), 'adserver.org', 'TDID'); @@ -215,7 +215,7 @@ export const spec = { } const bids = response.seatbid.reduce((acc, seatBid) => acc.concat(seatBid.bid), []); - let outBids = []; + const outBids = []; bids.forEach(bid => { const outBid = { @@ -261,7 +261,7 @@ export const spec = { if (gdprConsent && (typeof gdprConsent.gdprApplies === 'boolean')) { gdprApplies = gdprConsent.gdprApplies; } - let gdpr = gdprApplies ? 1 : 0; + const gdpr = gdprApplies ? 1 : 0; if (gdprApplies && gdprConsent.consentString) { consentString = encodeURIComponent(gdprConsent.consentString); diff --git a/modules/geoedgeRtdProvider.js b/modules/geoedgeRtdProvider.js index 09e717a112f..e25d1b5c4df 100644 --- a/modules/geoedgeRtdProvider.js +++ b/modules/geoedgeRtdProvider.js @@ -45,9 +45,9 @@ const FILE_NAME_CLIENT = 'grumi.js'; /** @type {string} */ const FILE_NAME_INPAGE = 'grumi-ip.js'; /** @type {function} */ -export let getClientUrl = (key) => `${HOST_NAME}/${key}/${FILE_NAME_CLIENT}`; +export const getClientUrl = (key) => `${HOST_NAME}/${key}/${FILE_NAME_CLIENT}`; /** @type {function} */ -export let getInPageUrl = (key) => `${HOST_NAME}/${key}/${FILE_NAME_INPAGE}`; +export const getInPageUrl = (key) => `${HOST_NAME}/${key}/${FILE_NAME_INPAGE}`; /** @type {string} */ export let wrapper /** @type {boolean} */; @@ -55,9 +55,9 @@ let wrapperReady; /** @type {boolean} */; let preloaded; /** @type {object} */; -let refererInfo = getRefererInfo(); +const refererInfo = getRefererInfo(); /** @type {object} */; -let overrides = window.grumi?.overrides; +const overrides = window.grumi?.overrides; /** * fetches the creative wrapper @@ -80,7 +80,7 @@ export function setWrapper(responseText) { } export function getInitialParams(key) { - let params = { + const params = { wver: '1.1.1', wtype: 'pbjs-module', key, @@ -104,11 +104,11 @@ export function markAsLoaded() { * @param {string} key */ export function preloadClient(key) { - let iframe = createInvisibleIframe(); + const iframe = createInvisibleIframe(); iframe.id = 'grumiFrame'; insertElement(iframe); iframe.contentWindow.grumi = getInitialParams(key); - let url = getClientUrl(key); + const url = getClientUrl(key); loadExternalScript(url, MODULE_TYPE_RTD, SUBMODULE_NAME, markAsLoaded, iframe.contentDocument); } @@ -174,7 +174,7 @@ function replaceMacros(wrapper, macros) { * @return {string} */ function buildHtml(bid, wrapper, html, key) { - let macros = getMacros(bid, key); + const macros = getMacros(bid, key); wrapper = replaceMacros(wrapper, macros); return wrapHtml(wrapper, html); } @@ -194,7 +194,7 @@ function mutateBid(bid, ad) { * @param {string} key */ export function wrapBidResponse(bid, key) { - let wrapped = buildHtml(bid, wrapper, bid.ad, key); + const wrapped = buildHtml(bid, wrapper, bid.ad, key); mutateBid(bid, wrapped); } @@ -213,14 +213,14 @@ function isSupportedBidder(bidder, paramsBidders) { * @return {boolean} */ function shouldWrap(bid, params) { - let supportedBidder = isSupportedBidder(bid.bidderCode, params.bidders); - let donePreload = params.wap ? preloaded : true; - let isGPT = params.gpt; + const supportedBidder = isSupportedBidder(bid.bidderCode, params.bidders); + const donePreload = params.wap ? preloaded : true; + const isGPT = params.gpt; return wrapperReady && supportedBidder && donePreload && !isGPT; } function conditionallyWrap(bidResponse, config, userConsent) { - let params = config.params; + const params = config.params; if (shouldWrap(bidResponse, params)) { wrapBidResponse(bidResponse, params.key); } @@ -238,9 +238,9 @@ function isBillingMessage(data, params) { */ function fireBillableEventsForApplicableBids(params) { window.addEventListener('message', function (message) { - let data = message.data; + const data = message.data; if (isBillingMessage(data, params)) { - let winningBid = auctionManager.findBidByAdId(data.adId); + const winningBid = auctionManager.findBidByAdId(data.adId); events.emit(EVENTS.BILLABLE_EVENT, { vendor: SUBMODULE_NAME, billingId: data.impressionId, @@ -264,7 +264,7 @@ function setupInPage(params) { } function init(config, userConsent) { - let params = config.params; + const params = config.params; if (!params || !params.key) { logError('missing key for geoedge RTD module provider'); return false; diff --git a/modules/getintentBidAdapter.js b/modules/getintentBidAdapter.js index 67a0e1e91be..8db40161900 100644 --- a/modules/getintentBidAdapter.js +++ b/modules/getintentBidAdapter.js @@ -56,7 +56,7 @@ export const spec = { */ buildRequests: function(bidRequests) { return bidRequests.map(bidRequest => { - let giBidRequest = buildGiBidRequest(bidRequest); + const giBidRequest = buildGiBidRequest(bidRequest); return { method: 'GET', url: buildUrl(giBidRequest), @@ -73,11 +73,11 @@ export const spec = { * @return {Bid[]} An array of bids which were nested inside the server. */ interpretResponse: function(serverResponse) { - let responseBody = serverResponse.body; + const responseBody = serverResponse.body; const bids = []; if (responseBody && responseBody.no_bid !== 1) { - let size = parseSize(responseBody.size); - let bid = { + const size = parseSize(responseBody.size); + const bid = { requestId: responseBody.bid_id, ttl: BID_RESPONSE_TTL_SEC, netRevenue: IS_NET_REVENUE, @@ -115,7 +115,7 @@ function buildUrl(bid) { * @return {object} GI bid request */ function buildGiBidRequest(bidRequest) { - let giBidRequest = { + const giBidRequest = { bid_id: bidRequest.bidId, pid: bidRequest.params.pid, // required tid: bidRequest.params.tid, // required @@ -165,7 +165,7 @@ function addVideo(videoParams, mediaTypesVideoParams, giBidRequest) { videoParams = videoParams || {}; mediaTypesVideoParams = mediaTypesVideoParams || {}; - for (let videoParam in VIDEO_PROPERTIES) { + for (const videoParam in VIDEO_PROPERTIES) { let paramValue; const mediaTypesVideoParam = VIDEO_PROPERTIES[videoParam]; diff --git a/modules/gjirafaBidAdapter.js b/modules/gjirafaBidAdapter.js index ef19a097062..3218b32732a 100644 --- a/modules/gjirafaBidAdapter.js +++ b/modules/gjirafaBidAdapter.js @@ -50,7 +50,7 @@ export const spec = { let contents = []; let data = {}; - let placements = validBidRequests.map(bidRequest => { + const placements = validBidRequests.map(bidRequest => { if (!propertyId) { propertyId = bidRequest.params.propertyId; } if (!pageViewGuid && bidRequest.params) { pageViewGuid = bidRequest.params.pageViewGuid || ''; } if (!bidderRequestId) { bidderRequestId = bidRequest.bidderRequestId; } @@ -58,9 +58,9 @@ export const spec = { if (!contents.length && bidRequest.params.contents && bidRequest.params.contents.length) { contents = bidRequest.params.contents; } if (Object.keys(data).length === 0 && bidRequest.params.data && Object.keys(bidRequest.params.data).length !== 0) { data = bidRequest.params.data; } - let adUnitId = bidRequest.adUnitCode; - let placementId = bidRequest.params.placementId; - let sizes = generateSizeParam(bidRequest.sizes); + const adUnitId = bidRequest.adUnitCode; + const placementId = bidRequest.params.placementId; + const sizes = generateSizeParam(bidRequest.sizes); return { sizes: sizes, @@ -72,7 +72,7 @@ export const spec = { }; }); - let body = { + const body = { propertyId: propertyId, pageViewGuid: pageViewGuid, storageId: storageId, diff --git a/modules/gmosspBidAdapter.js b/modules/gmosspBidAdapter.js index 52f65187a8e..62d21567280 100644 --- a/modules/gmosspBidAdapter.js +++ b/modules/gmosspBidAdapter.js @@ -165,7 +165,7 @@ function getUrlInfo(refererInfo) { let canonicalLink = refererInfo.canonicalUrl; if (!canonicalLink) { - let metaElements = getMetaElements(); + const metaElements = getMetaElements(); for (let i = 0; i < metaElements.length && !canonicalLink; i++) { if (metaElements[i].getAttribute('property') == 'og:url') { canonicalLink = metaElements[i].content; diff --git a/modules/goldbachBidAdapter.js b/modules/goldbachBidAdapter.js index e5f8b47cfef..3912df96615 100644 --- a/modules/goldbachBidAdapter.js +++ b/modules/goldbachBidAdapter.js @@ -221,7 +221,7 @@ export const spec = { const syncs = [] const uid = ensureUid(gdprConsent); if (hasPurpose1Consent(gdprConsent)) { - let type = (syncOptions.pixelEnabled) ? 'image' : null ?? (syncOptions.iframeEnabled) ? 'iframe' : null + const type = (syncOptions.pixelEnabled) ? 'image' : null ?? (syncOptions.iframeEnabled) ? 'iframe' : null if (type) { syncs.push({ type: type, diff --git a/modules/gptPreAuction.ts b/modules/gptPreAuction.ts index 419945a4be5..2214965875d 100644 --- a/modules/gptPreAuction.ts +++ b/modules/gptPreAuction.ts @@ -140,7 +140,7 @@ export const makeBidRequestsHook = (fn, adUnits, ...args) => { adUnit.ortb2Imp.ext.data = adUnit.ortb2Imp.ext.data || {}; const context = adUnit.ortb2Imp.ext; - let adserverSlot = deepAccess(context, 'data.adserver.adslot'); + const adserverSlot = deepAccess(context, 'data.adserver.adslot'); // @todo: check if should have precedence over customPreAuction and defaultPreAuction if (context.gpid) return; diff --git a/modules/greenbidsBidAdapter.js b/modules/greenbidsBidAdapter.js index 6dc0364df0d..af69016b586 100644 --- a/modules/greenbidsBidAdapter.js +++ b/modules/greenbidsBidAdapter.js @@ -43,7 +43,7 @@ export const spec = { buildRequests: function (validBidRequests, bidderRequest) { const bids = validBidRequests.map(bids => { const reqObj = {}; - let placementId = getValue(bids.params, 'placementId'); + const placementId = getValue(bids.params, 'placementId'); const gpid = deepAccess(bids, 'ortb2Imp.ext.gpid'); reqObj.sizes = getSizes(bids); reqObj.bidId = getBidIdParameter('bidId', bids); @@ -166,8 +166,8 @@ function getSizes(bid) { */ function hydratePayloadWithGppConsentData(payload, gppData) { if (!gppData) { return; } - let isValidConsentString = typeof gppData.gppString === 'string'; - let validateApplicableSections = + const isValidConsentString = typeof gppData.gppString === 'string'; + const validateApplicableSections = Array.isArray(gppData.applicableSections) && gppData.applicableSections.every((section) => typeof (section) === 'number') payload.gpp = { @@ -188,9 +188,9 @@ function hydratePayloadWithGppConsentData(payload, gppData) { */ function hydratePayloadWithGdprConsentData(payload, gdprData) { if (!gdprData) { return; } - let isCmp = typeof gdprData.gdprApplies === 'boolean'; - let isConsentString = typeof gdprData.consentString === 'string'; - let status = isCmp + const isCmp = typeof gdprData.gdprApplies === 'boolean'; + const isConsentString = typeof gdprData.consentString === 'string'; + const status = isCmp ? findGdprStatus(gdprData.gdprApplies, gdprData.vendorData) : gdprStatus.CMP_NOT_FOUND_OR_ERROR; payload.gdpr_iab = { diff --git a/modules/greenbidsRtdProvider.js b/modules/greenbidsRtdProvider.js index 985720cd60c..407f9f0c64e 100644 --- a/modules/greenbidsRtdProvider.js +++ b/modules/greenbidsRtdProvider.js @@ -11,7 +11,7 @@ const ENDPOINT = 'https://t.greenbids.ai'; const rtdOptions = {}; function init(moduleConfig) { - let params = moduleConfig?.params; + const params = moduleConfig?.params; if (!params?.pbuid) { logError('Greenbids pbuid is not set!'); return false; @@ -24,8 +24,8 @@ function init(moduleConfig) { function onAuctionInitEvent(auctionDetails) { /* Emitting one billing event per auction */ - let defaultId = 'default_id'; - let greenbidsId = deepAccess(auctionDetails.adUnits[0], 'ortb2Imp.ext.greenbids.greenbidsId', defaultId); + const defaultId = 'default_id'; + const greenbidsId = deepAccess(auctionDetails.adUnits[0], 'ortb2Imp.ext.greenbids.greenbidsId', defaultId); /* greenbids was successfully called so we emit the event */ if (greenbidsId !== defaultId) { events.emit(EVENTS.BILLABLE_EVENT, { @@ -38,8 +38,8 @@ function onAuctionInitEvent(auctionDetails) { } function getBidRequestData(reqBidsConfigObj, callback, config, userConsent) { - let greenbidsId = generateUUID(); - let promise = createPromise(reqBidsConfigObj, greenbidsId); + const greenbidsId = generateUUID(); + const promise = createPromise(reqBidsConfigObj, greenbidsId); promise.then(callback); } diff --git a/modules/gridBidAdapter.js b/modules/gridBidAdapter.js index e860c292f93..46989610baf 100644 --- a/modules/gridBidAdapter.js +++ b/modules/gridBidAdapter.js @@ -132,7 +132,7 @@ export const spec = { content = jwTargeting.content; } - let impObj = { + const impObj = { id: bidId.toString(), tagid: (secid || uid).toString(), ext: { @@ -412,7 +412,7 @@ export const spec = { } return ''; }); - let currentSource = sources[i] || sp; + const currentSource = sources[i] || sp; const urlWithParams = url + (url.indexOf('?') > -1 ? '&' : '?') + 'no_mapping=1' + (currentSource ? `&sp=${currentSource}` : ''); return { method: 'POST', @@ -626,8 +626,8 @@ function createBannerRequest(bid, mediaType) { const sizes = mediaType.sizes || bid.sizes; if (!sizes || !sizes.length) return; - let format = sizes.map((size) => parseGPTSingleSizeArrayToRtbSize(size)); - let result = parseGPTSingleSizeArrayToRtbSize(sizes[0]); + const format = sizes.map((size) => parseGPTSingleSizeArrayToRtbSize(size)); + const result = parseGPTSingleSizeArrayToRtbSize(sizes[0]); if (format.length) { result.format = format diff --git a/modules/growadsBidAdapter.js b/modules/growadsBidAdapter.js index 58213bfeba4..4b5b97f965a 100644 --- a/modules/growadsBidAdapter.js +++ b/modules/growadsBidAdapter.js @@ -57,7 +57,7 @@ export const spec = { interpretResponse: function (serverResponse, bidRequest) { const request = bidRequest.bidRequest; - let bidResponses = []; + const bidResponses = []; let CPM; let width; let height; @@ -68,7 +68,7 @@ export const spec = { let maxCPM; let bid = {}; - let body = serverResponse.body; + const body = serverResponse.body; try { response = JSON.parse(body); diff --git a/modules/growthCodeAnalyticsAdapter.js b/modules/growthCodeAnalyticsAdapter.js index 0b1f343e4dc..5c936767cdf 100644 --- a/modules/growthCodeAnalyticsAdapter.js +++ b/modules/growthCodeAnalyticsAdapter.js @@ -17,7 +17,7 @@ const ENDPOINT_URL = 'https://analytics.gcprivacy.com/v3/pb/analytics' export const storage = getStorageManager({moduleType: MODULE_TYPE_ANALYTICS, moduleName: MODULE_NAME}); -let sessionId = utils.generateUUID(); +const sessionId = utils.generateUUID(); let trackEvents = []; let pid = DEFAULT_PID; @@ -27,11 +27,11 @@ let eventQueue = []; let startAuction = 0; let bidRequestTimeout = 0; -let analyticsType = 'endpoint'; +const analyticsType = 'endpoint'; -let growthCodeAnalyticsAdapter = Object.assign(adapter({url: url, analyticsType}), { +const growthCodeAnalyticsAdapter = Object.assign(adapter({url: url, analyticsType}), { track({eventType, args}) { - let eventData = args ? utils.deepClone(args) : {}; + const eventData = args ? utils.deepClone(args) : {}; let data = {}; if (!trackEvents.includes(eventType)) return; switch (eventType) { @@ -140,9 +140,9 @@ function logToServer() { if (pid === DEFAULT_PID) return; if (eventQueue.length >= 1) { // Get the correct GCID - let gcid = storage.getDataFromLocalStorage('gcid'); + const gcid = storage.getDataFromLocalStorage('gcid'); - let data = { + const data = { session: sessionId, pid: pid, gcid: gcid, diff --git a/modules/growthCodeIdSystem.js b/modules/growthCodeIdSystem.js index be20ab89130..2da339e1b4a 100644 --- a/modules/growthCodeIdSystem.js +++ b/modules/growthCodeIdSystem.js @@ -47,7 +47,7 @@ export const growthCodeIdSubmodule = { const configParams = (config && config.params) || {}; let ids = []; - let gcid = storage.getDataFromLocalStorage(GCID_KEY, null) + const gcid = storage.getDataFromLocalStorage(GCID_KEY, null) if (gcid !== null) { const gcEid = { @@ -61,9 +61,9 @@ export const growthCodeIdSubmodule = { ids = ids.concat(gcEid) } - let additionalEids = storage.getDataFromLocalStorage(configParams.customerEids, null) + const additionalEids = storage.getDataFromLocalStorage(configParams.customerEids, null) if (additionalEids !== null) { - let data = JSON.parse(additionalEids) + const data = JSON.parse(additionalEids) ids = ids.concat(data) } diff --git a/modules/growthCodeRtdProvider.js b/modules/growthCodeRtdProvider.js index a8893b9648e..807b17f351d 100644 --- a/modules/growthCodeRtdProvider.js +++ b/modules/growthCodeRtdProvider.js @@ -56,7 +56,7 @@ function init(config, userConsent) { } const configParams = (config && config.params) || {}; - let expiresAt = parseInt(storage.getDataFromLocalStorage(RTD_EXPIRE_KEY, null)); + const expiresAt = parseInt(storage.getDataFromLocalStorage(RTD_EXPIRE_KEY, null)); items = tryParse(storage.getDataFromLocalStorage(RTD_CACHE_KEY, null)); @@ -68,14 +68,14 @@ function init(config, userConsent) { } function callServer(configParams, items, expiresAt, userConsent) { // Expire Cache - let now = Math.trunc(Date.now() / 1000); + const now = Math.trunc(Date.now() / 1000); if ((!isNaN(expiresAt)) && (now > expiresAt)) { expiresAt = NaN; storage.removeDataFromLocalStorage(RTD_CACHE_KEY, null) storage.removeDataFromLocalStorage(RTD_EXPIRE_KEY, null) } if ((items === null) && (isNaN(expiresAt))) { - let gcid = storage.getDataFromLocalStorage('gcid') + const gcid = storage.getDataFromLocalStorage('gcid') let url = configParams.url ? configParams.url : ENDPOINT_URL; url = tryAppendQueryString(url, 'pid', configParams.pid); @@ -87,7 +87,7 @@ function callServer(configParams, items, expiresAt, userConsent) { ajax.ajaxBuilder()(url, { success: response => { - let respJson = tryParse(response); + const respJson = tryParse(response); // If response is a valid json and should save is true if (respJson && respJson.results >= 1) { storage.setDataInLocalStorage(RTD_CACHE_KEY, JSON.stringify(respJson.items), null); @@ -109,8 +109,8 @@ function addData(reqBidsConfigObj, items) { let merge = false for (let j = 0; j < items.length; j++) { - let item = items[j] - let data = JSON.parse(item.parameters); + const item = items[j] + const data = JSON.parse(item.parameters); if (item['attachment_point'] === 'data') { mergeDeep(reqBidsConfigObj.ortb2Fragments.bidder, data) merge = true diff --git a/modules/gumgumBidAdapter.js b/modules/gumgumBidAdapter.js index b26dcacae69..a4fdec9dc94 100644 --- a/modules/gumgumBidAdapter.js +++ b/modules/gumgumBidAdapter.js @@ -25,7 +25,7 @@ const TIME_TO_LIVE = 60; const DELAY_REQUEST_TIME = 1800000; // setting to 30 mins const pubProvidedIdSources = ['dac.co.jp', 'audigent.com', 'id5-sync.com', 'liveramp.com', 'intentiq.com', 'liveintent.com', 'crwdcntrl.net', 'quantcast.com', 'adserver.org', 'yahoo.com'] -let invalidRequestIds = {}; +const invalidRequestIds = {}; let pageViewId = null; // TODO: potential 0 values for browserParams sent to ad server @@ -310,8 +310,8 @@ function getGreatestDimensions(sizes) { let maxh = 0; let greatestVal = 0; sizes.forEach(bannerSize => { - let [width, height] = bannerSize; - let greaterSide = width > height ? width : height; + const [width, height] = bannerSize; + const greaterSide = width > height ? width : height; if ((greaterSide > greatestVal) || (greaterSide === greatestVal && width >= maxw && height >= maxh)) { greatestVal = greaterSide; maxw = width; @@ -398,9 +398,9 @@ function buildRequests(validBidRequests, bidderRequest) { } // Send filtered pubProvidedId's if (userId && userId.pubProvidedId) { - let filteredData = userId.pubProvidedId.filter(item => pubProvidedIdSources.includes(item.source)); - let maxLength = 1800; // replace this with your desired maximum length - let truncatedJsonString = jsoStringifynWithMaxLength(filteredData, maxLength); + const filteredData = userId.pubProvidedId.filter(item => pubProvidedIdSources.includes(item.source)); + const maxLength = 1800; // replace this with your desired maximum length + const truncatedJsonString = jsoStringifynWithMaxLength(filteredData, maxLength); data.pubProvidedId = truncatedJsonString } // ADJS-1286 Read id5 id linktype field @@ -526,7 +526,7 @@ export function getCids(site) { return null; } export function setIrisId(data, site, params) { - let irisID = getCids(site); + const irisID = getCids(site); if (irisID) { data.irisid = irisID; } else { @@ -633,11 +633,11 @@ function interpretResponse(serverResponse, bidRequest) { mediaType: type } } = Object.assign(defaultResponse, serverResponseBody); - let data = bidRequest.data || {}; - let product = data.pi; - let mediaType = (product === 6 || product === 7) ? VIDEO : BANNER; - let isTestUnit = (product === 3 && data.si === 9); - let metaData = { + const data = bidRequest.data || {}; + const product = data.pi; + const mediaType = (product === 6 || product === 7) ? VIDEO : BANNER; + const isTestUnit = (product === 3 && data.si === 9); + const metaData = { advertiserDomains: advertiserDomains || [], mediaType: type || mediaType }; @@ -656,7 +656,7 @@ function interpretResponse(serverResponse, bidRequest) { sizes = requestSizesThatMatchResponse.length ? requestSizesThatMatchResponse : parseSizesInput(bidRequest.sizes) } - let [width, height] = sizes[0].split('x'); + const [width, height] = sizes[0].split('x'); if (jcsi) { serverResponseBody.jcsi = JCSI diff --git a/modules/h12mediaBidAdapter.js b/modules/h12mediaBidAdapter.js index 22171ff5c6f..963ae660e57 100644 --- a/modules/h12mediaBidAdapter.js +++ b/modules/h12mediaBidAdapter.js @@ -95,7 +95,7 @@ export const spec = { }, interpretResponse: function(serverResponse, bidRequests) { - let bidResponses = []; + const bidResponses = []; try { const serverBody = serverResponse.body; if (serverBody) { diff --git a/modules/hadronAnalyticsAdapter.js b/modules/hadronAnalyticsAdapter.js index b5f8a7baa33..c01e33bc6a2 100644 --- a/modules/hadronAnalyticsAdapter.js +++ b/modules/hadronAnalyticsAdapter.js @@ -45,9 +45,9 @@ var eventQueue = [ var startAuction = 0; var bidRequestTimeout = 0; -let analyticsType = 'endpoint'; +const analyticsType = 'endpoint'; -let hadronAnalyticsAdapter = Object.assign(adapter({url: HADRON_ANALYTICS_URL, analyticsType}), { +const hadronAnalyticsAdapter = Object.assign(adapter({url: HADRON_ANALYTICS_URL, analyticsType}), { track({eventType, args}) { args = args ? utils.deepClone(args) : {}; var data = {}; diff --git a/modules/hadronRtdProvider.js b/modules/hadronRtdProvider.js index eae85db3c34..0ff11de1a3e 100644 --- a/modules/hadronRtdProvider.js +++ b/modules/hadronRtdProvider.js @@ -147,10 +147,10 @@ export function getRealTimeData(bidConfig, onDone, rtdConfig, userConsent) { }) } if (rtdConfig && isPlainObject(rtdConfig.params) && rtdConfig.params.segmentCache) { - let jsonData = storage.getDataFromLocalStorage(RTD_LOCAL_NAME); + const jsonData = storage.getDataFromLocalStorage(RTD_LOCAL_NAME); if (jsonData) { - let data = JSON.parse(jsonData); + const data = JSON.parse(jsonData); if (data.rtd) { addRealTimeData(bidConfig, data.rtd, rtdConfig); @@ -167,7 +167,7 @@ export function getRealTimeData(bidConfig, onDone, rtdConfig, userConsent) { userIds['hadronId'] = allUserIds.hadronId; logInfo(LOG_PREFIX, 'hadronId user module found', allUserIds.hadronId); } else { - let hadronId = storage.getDataFromLocalStorage(LS_TAM_KEY); + const hadronId = storage.getDataFromLocalStorage(LS_TAM_KEY); if (isStr(hadronId) && hadronId.length > 0) { userIds['hadronId'] = hadronId; logInfo(LOG_PREFIX, 'hadronId TAM found', hadronId); diff --git a/modules/holidBidAdapter.js b/modules/holidBidAdapter.js index 58172e204e1..540cd82257d 100644 --- a/modules/holidBidAdapter.js +++ b/modules/holidBidAdapter.js @@ -15,7 +15,7 @@ const ENDPOINT = 'https://helloworld.holid.io/openrtb2/auction'; const COOKIE_SYNC_ENDPOINT = 'https://null.holid.io/sync.html'; const TIME_TO_LIVE = 300; const TMAX = 500; -let wurlMap = {}; +const wurlMap = {}; export const spec = { code: BIDDER_CODE, @@ -96,7 +96,7 @@ export const spec = { const impId = bid.impid; // Unique identifier matching getImp(bid).id // Build meta object with adomain and networkId, preserving any existing data - let meta = deepAccess(bid, 'ext.prebid.meta', {}) || {}; + const meta = deepAccess(bid, 'ext.prebid.meta', {}) || {}; const adomain = deepAccess(bid, 'adomain', []); if (adomain.length > 0) { meta.adomain = adomain; diff --git a/modules/hybridBidAdapter.js b/modules/hybridBidAdapter.js index 9cc66566a9f..1a9552c1754 100644 --- a/modules/hybridBidAdapter.js +++ b/modules/hybridBidAdapter.js @@ -78,7 +78,7 @@ function buildBid(bidData) { actionUrls: {} } }; - let actionUrls = bid.inImageContent.content.actionUrls; + const actionUrls = bid.inImageContent.content.actionUrls; actionUrls.loadUrls = bidData.inImage.loadtrackers || []; actionUrls.impressionUrls = bidData.inImage.imptrackers || []; actionUrls.scrollActUrls = bidData.inImage.startvisibilitytrackers || []; @@ -87,7 +87,7 @@ function buildBid(bidData) { actionUrls.closeBannerUrls = bidData.inImage.closebannertrackers || []; if (bidData.inImage.but) { - let inImageOptions = bid.inImageContent.content.inImageOptions = {}; + const inImageOptions = bid.inImageContent.content.inImageOptions = {}; inImageOptions.hasButton = true; inImageOptions.buttonLogoUrl = bidData.inImage.but_logo; inImageOptions.buttonProductUrl = bidData.inImage.but_prod; @@ -193,12 +193,12 @@ export const spec = { * @return {Bid[]} An array of bids which were nested inside the server. */ interpretResponse: function(serverResponse, bidRequest) { - let bidRequests = JSON.parse(bidRequest.data).bidRequests; + const bidRequests = JSON.parse(bidRequest.data).bidRequests; const serverBody = serverResponse.body; if (serverBody && serverBody.bids && isArray(serverBody.bids)) { return _map(serverBody.bids, function(bid) { - let rawBid = ((bidRequests) || []).find(function (item) { + const rawBid = ((bidRequests) || []).find(function (item) { return item.bidId === bid.bidId; }); bid.placement = rawBid.placement; diff --git a/modules/hypelabBidAdapter.js b/modules/hypelabBidAdapter.js index e1e6e27af7f..c67b89b592e 100644 --- a/modules/hypelabBidAdapter.js +++ b/modules/hypelabBidAdapter.js @@ -103,7 +103,7 @@ function getBidFloor(bid, sizes) { let floor; - let floorInfo = bid.getFloor({ + const floorInfo = bid.getFloor({ currency: 'USD', mediaType: 'banner', size: sizes.length === 1 ? sizes[0] : '*', diff --git a/modules/iasRtdProvider.js b/modules/iasRtdProvider.js index 5b64089231c..91865fee541 100644 --- a/modules/iasRtdProvider.js +++ b/modules/iasRtdProvider.js @@ -56,7 +56,7 @@ export function init(config, userConsent) { } if (params.hasOwnProperty('keyMappings')) { const keyMappings = params.keyMappings; - for (let prop in keyMappings) { + for (const prop in keyMappings) { if (IAS_KEY_MAPPINGS.hasOwnProperty(prop)) { IAS_KEY_MAPPINGS[prop] = keyMappings[prop] } @@ -114,8 +114,8 @@ function stringifyScreenSize() { } function renameKeyValues(source) { - let result = {}; - for (let prop in IAS_KEY_MAPPINGS) { + const result = {}; + for (const prop in IAS_KEY_MAPPINGS) { if (source.hasOwnProperty(prop)) { result[IAS_KEY_MAPPINGS[prop]] = source[prop]; } @@ -124,7 +124,7 @@ function renameKeyValues(source) { } function formatTargetingData(adUnit) { - let result = {}; + const result = {}; if (iasTargeting[BRAND_SAFETY_OBJECT_FIELD_NAME]) { utils.mergeDeep(result, iasTargeting[BRAND_SAFETY_OBJECT_FIELD_NAME]); } diff --git a/modules/id5AnalyticsAdapter.js b/modules/id5AnalyticsAdapter.js index 10fe8d82ef4..b2b2af6f563 100644 --- a/modules/id5AnalyticsAdapter.js +++ b/modules/id5AnalyticsAdapter.js @@ -36,7 +36,7 @@ const PBJS_VERSION = 'v' + '$prebid.version$'; const ID5_REDACTED = '__ID5_REDACTED__'; const isArray = Array.isArray; -let id5Analytics = Object.assign(buildAdapter({analyticsType: 'endpoint'}), { +const id5Analytics = Object.assign(buildAdapter({analyticsType: 'endpoint'}), { // Keeps an array of events for each auction eventBuffer: {}, diff --git a/modules/id5IdSystem.js b/modules/id5IdSystem.js index dc9ea9747fc..3dd18732ca9 100644 --- a/modules/id5IdSystem.js +++ b/modules/id5IdSystem.js @@ -173,8 +173,8 @@ export const id5IdSubmodule = { const responseObj = {}; const eids = {}; Object.entries(value.ids).forEach(([key, value]) => { - let eid = value.eid; - let uid = eid?.uids?.[0] + const eid = value.eid; + const uid = eid?.uids?.[0] responseObj[key] = { uid: uid?.id, ext: uid?.ext @@ -198,7 +198,7 @@ export const id5IdSubmodule = { return undefined; } this.eids = DEFAULT_EIDS; - let responseObj = { + const responseObj = { id5id: { uid: universalUid, ext: ext @@ -354,7 +354,7 @@ export class IdFetchFlow { } async #callForConfig() { - let url = this.submoduleConfig.params.configUrl || ID5_API_CONFIG_URL; // override for debug/test purposes only + const url = this.submoduleConfig.params.configUrl || ID5_API_CONFIG_URL; // override for debug/test purposes only const response = await fetch(url, { method: 'POST', body: JSON.stringify({ @@ -496,7 +496,7 @@ function validateConfig(config) { const partner = config.params.partner; if (typeof partner === 'string' || partner instanceof String) { - let parsedPartnerId = parseInt(partner); + const parsedPartnerId = parseInt(partner); if (isNaN(parsedPartnerId) || parsedPartnerId < 0) { logError(LOG_PREFIX + 'partner required to be a number or a String parsable to a positive integer'); return false; diff --git a/modules/identityLinkIdSystem.js b/modules/identityLinkIdSystem.js index cff75d5d668..0f02e40a383 100644 --- a/modules/identityLinkIdSystem.js +++ b/modules/identityLinkIdSystem.js @@ -87,7 +87,7 @@ export const identityLinkSubmodule = { }); } else { // try to get envelope directly from storage if ats lib is not present on a page - let envelope = getEnvelopeFromStorage(); + const envelope = getEnvelopeFromStorage(); if (envelope) { utils.logInfo('identityLink: LiveRamp envelope successfully retrieved from storage!'); callback(JSON.parse(envelope).envelope); @@ -137,19 +137,19 @@ function getEnvelope(url, callback, configParams) { } function setRetryCookie() { - let now = new Date(); + const now = new Date(); now.setTime(now.getTime() + 3600000); storage.setCookie('_lr_retry_request', 'true', now.toUTCString()); } function setEnvelopeSource(src) { - let now = new Date(); + const now = new Date(); now.setTime(now.getTime() + 2592000000); storage.setCookie('_lr_env_src_ats', src, now.toUTCString()); } export function getEnvelopeFromStorage() { - let rawEnvelope = storage.getCookie(liverampEnvelopeName) || storage.getDataFromLocalStorage(liverampEnvelopeName); + const rawEnvelope = storage.getCookie(liverampEnvelopeName) || storage.getDataFromLocalStorage(liverampEnvelopeName); if (!rawEnvelope) { return undefined; } diff --git a/modules/impactifyBidAdapter.js b/modules/impactifyBidAdapter.js index 7be716f4089..1e4f6e9dd81 100644 --- a/modules/impactifyBidAdapter.js +++ b/modules/impactifyBidAdapter.js @@ -35,7 +35,7 @@ export const STORAGE_KEY = '_im_str' */ const helpers = { getExtParamsFromBid(bid) { - let ext = { + const ext = { impactify: { appId: bid.params.appId }, @@ -72,7 +72,7 @@ const helpers = { }, createOrtbImpBannerObj(bid, size) { - let sizes = size.split('x'); + const sizes = size.split('x'); return { id: 'banner-' + bid.bidId, @@ -118,7 +118,7 @@ const helpers = { */ function createOpenRtbRequest(validBidRequests, bidderRequest) { // Create request and set imp bids inside - let request = { + const request = { id: bidderRequest.bidderRequestId, validBidRequests, cur: [DEFAULT_CURRENCY], @@ -137,11 +137,11 @@ function createOpenRtbRequest(validBidRequests, bidderRequest) { } // Set SChain in request - let schain = deepAccess(validBidRequests, '0.ortb2.source.ext.schain'); + const schain = deepAccess(validBidRequests, '0.ortb2.source.ext.schain'); if (schain) request.source.ext = { schain: schain }; // Set Eids - let eids = deepAccess(validBidRequests, '0.userIdAsEids'); + const eids = deepAccess(validBidRequests, '0.userIdAsEids'); if (eids && eids.length) { deepSetValue(request, 'user.ext.eids', eids); } @@ -179,9 +179,9 @@ function createOpenRtbRequest(validBidRequests, bidderRequest) { // Create imps with bids validBidRequests.forEach((bid) => { - let bannerObj = deepAccess(bid.mediaTypes, `banner`); + const bannerObj = deepAccess(bid.mediaTypes, `banner`); - let imp = { + const imp = { id: bid.bidId, bidfloor: bid.params.bidfloor ? bid.params.bidfloor : 0, ext: helpers.getExtParamsFromBid(bid) @@ -253,7 +253,7 @@ export const spec = { */ buildRequests: function (validBidRequests, bidderRequest) { // Create a clean openRTB request - let request = createOpenRtbRequest(validBidRequests, bidderRequest); + const request = createOpenRtbRequest(validBidRequests, bidderRequest); const imStr = helpers.getImStrFromLocalStorage(); const options = {} diff --git a/modules/inmobiBidAdapter.js b/modules/inmobiBidAdapter.js index 910c53bf838..2e8be5ad4d0 100644 --- a/modules/inmobiBidAdapter.js +++ b/modules/inmobiBidAdapter.js @@ -48,7 +48,7 @@ const CONVERTER = ortbConverter({ * @returns {Object} The constructed impression object. */ function imp(buildImp, bidRequest, context) { - let imp = buildImp(bidRequest, context); + const imp = buildImp(bidRequest, context); const params = bidRequest.params; imp.tagid = bidRequest.adUnitCode; @@ -115,7 +115,7 @@ function bidResponse(buildBidResponse, bid, context) { const admJson = JSON.parse(bid.adm); bid.adm = JSON.stringify(admJson.native); } - let bidResponse = buildBidResponse(bid, context); + const bidResponse = buildBidResponse(bid, context); if (typeof deepAccess(bid, 'ext') !== 'undefined') { deepSetValue(bidResponse, 'meta', { @@ -137,7 +137,7 @@ function bidResponse(buildBidResponse, bid, context) { * @returns {Object} Prebid.js compatible bid response. */ function response(buildResponse, bidResponses, ortbResponse, context) { - let response = buildResponse(bidResponses, ortbResponse, context); + const response = buildResponse(bidResponses, ortbResponse, context); return response; } diff --git a/modules/innityBidAdapter.js b/modules/innityBidAdapter.js index da5003cd46e..afc840a6292 100644 --- a/modules/innityBidAdapter.js +++ b/modules/innityBidAdapter.js @@ -13,8 +13,8 @@ export const spec = { }, buildRequests: function(validBidRequests, bidderRequest) { return validBidRequests.map(bidRequest => { - let parseSized = parseSizesInput(bidRequest.sizes); - let arrSize = parseSized[0].split('x'); + const parseSized = parseSizesInput(bidRequest.sizes); + const arrSize = parseSized[0].split('x'); return { method: 'GET', url: ENDPOINT, diff --git a/modules/insticatorBidAdapter.js b/modules/insticatorBidAdapter.js index 2aab5a9df03..447947e43a4 100644 --- a/modules/insticatorBidAdapter.js +++ b/modules/insticatorBidAdapter.js @@ -112,7 +112,7 @@ function buildVideo(bidRequest) { const bidRequestVideo = deepAccess(bidRequest, 'mediaTypes.video'); const videoBidderParams = deepAccess(bidRequest, 'params.video', {}); - let optionalParams = {}; + const optionalParams = {}; for (const param in OPTIONAL_VIDEO_PARAMS) { if (bidRequestVideo[param] && OPTIONAL_VIDEO_PARAMS[param](bidRequestVideo[param])) { optionalParams[param] = bidRequestVideo[param]; @@ -135,7 +135,7 @@ function buildVideo(bidRequest) { optionalParams['context'] = context; } - let videoObj = { + const videoObj = { mimes, w, h, @@ -168,7 +168,7 @@ function buildImpression(bidRequest) { deepSetValue(imp, 'ext.prebid.bidder.insticator.publisherId', bidRequest.params.publisherId); } - let bidFloor = parseFloat(deepAccess(bidRequest, 'params.floor')); + const bidFloor = parseFloat(deepAccess(bidRequest, 'params.floor')); if (!isNaN(bidFloor)) { imp.bidfloor = deepAccess(bidRequest, 'params.floor'); @@ -282,7 +282,7 @@ function _getUspConsent(bidderRequest) { } function buildRegs(bidderRequest) { - let regs = { + const regs = { ext: {}, }; if (bidderRequest.gdprConsent) { @@ -458,7 +458,7 @@ function buildBid(bid, bidderRequest) { if (bid.adm && bid.adm.includes(' { + const placements = validBidRequests.map(bidRequest => { if (!propertyId) { propertyId = bidRequest.params.propertyId; } if (!pageViewGuid) { pageViewGuid = bidRequest.params.pageViewGuid || ''; } if (!contents.length && bidRequest.params.contents && bidRequest.params.contents.length) { contents = bidRequest.params.contents; } @@ -83,7 +83,7 @@ export const spec = { deliveryUrl = DEFAULT_ENDPOINT_URL; } - let body = { + const body = { propertyId: propertyId, pageViewGuid: pageViewGuid, storageId: storageId, @@ -150,7 +150,7 @@ export function getBidFloor(bid) { return null; } - let floor = bid.getFloor({ + const floor = bid.getFloor({ currency: 'EUR', mediaType: '*', size: '*' diff --git a/modules/intentIqAnalyticsAdapter.js b/modules/intentIqAnalyticsAdapter.js index e58bb604bcd..576ffedfea7 100644 --- a/modules/intentIqAnalyticsAdapter.js +++ b/modules/intentIqAnalyticsAdapter.js @@ -74,7 +74,7 @@ const getDataForDefineURL = () => { return [iiqConfig, gdprDetected] } -let iiqAnalyticsAnalyticsAdapter = Object.assign(adapter({url: DEFAULT_URL, analyticsType}), { +const iiqAnalyticsAnalyticsAdapter = Object.assign(adapter({url: DEFAULT_URL, analyticsType}), { initOptions: { lsValueInitialized: false, partner: null, @@ -111,7 +111,7 @@ const { function initAdapterConfig() { if (iiqAnalyticsAnalyticsAdapter.initOptions.lsValueInitialized) return; - let iiqConfig = getIntentIqConfig() + const iiqConfig = getIntentIqConfig() if (iiqConfig) { iiqAnalyticsAnalyticsAdapter.initOptions.lsValueInitialized = true; @@ -148,7 +148,7 @@ function initReadLsIds() { if (partnerData) { iiqAnalyticsAnalyticsAdapter.initOptions.lsIdsInitialized = true; - let pData = JSON.parse(partnerData); + const pData = JSON.parse(partnerData); iiqAnalyticsAnalyticsAdapter.initOptions.terminationCause = pData.terminationCause iiqAnalyticsAnalyticsAdapter.initOptions.dataInLs = pData.data; iiqAnalyticsAnalyticsAdapter.initOptions.eidl = pData.eidl || -1; @@ -223,7 +223,7 @@ function getRandom(start, end) { } export function preparePayload(data) { - let result = getDefaultDataObject(); + const result = getDefaultDataObject(); readData(FIRST_PARTY_KEY + '_' + iiqAnalyticsAnalyticsAdapter.initOptions.partner, allowedStorage, storage); result[PARAMS_NAMES.partnerId] = iiqAnalyticsAnalyticsAdapter.initOptions.partner; result[PARAMS_NAMES.prebidVersion] = prebidVersion; @@ -342,7 +342,7 @@ function getDefaultDataObject() { } function constructFullUrl(data) { - let report = []; + const report = []; const reportMethod = iiqAnalyticsAnalyticsAdapter.initOptions.reportMethod; const currentBrowserLowerCase = detectBrowser(); data = btoa(JSON.stringify(data)); diff --git a/modules/intentIqIdSystem.js b/modules/intentIqIdSystem.js index 78f193eda11..c694e2bc870 100644 --- a/modules/intentIqIdSystem.js +++ b/modules/intentIqIdSystem.js @@ -135,8 +135,8 @@ function verifyIdType(value) { } function appendPartnersFirstParty (url, configParams) { - let partnerClientId = typeof configParams.partnerClientId === 'string' ? encodeURIComponent(configParams.partnerClientId) : ''; - let partnerClientIdType = typeof configParams.partnerClientIdType === 'number' ? verifyIdType(configParams.partnerClientIdType) : -1; + const partnerClientId = typeof configParams.partnerClientId === 'string' ? encodeURIComponent(configParams.partnerClientId) : ''; + const partnerClientIdType = typeof configParams.partnerClientIdType === 'number' ? verifyIdType(configParams.partnerClientIdType) : -1; if (partnerClientIdType === -1) return url; if (partnerClientId !== '') { @@ -349,13 +349,13 @@ export const intentIqIdSubmodule = { let callbackFired = false; let runtimeEids = { eids: [] }; - let gamObjectReference = isPlainObject(configParams.gamObjectReference) ? configParams.gamObjectReference : undefined; - let gamParameterName = configParams.gamParameterName ? configParams.gamParameterName : 'intent_iq_group'; - let groupChanged = typeof configParams.groupChanged === 'function' ? configParams.groupChanged : undefined; - let siloEnabled = typeof configParams.siloEnabled === 'boolean' ? configParams.siloEnabled : false; + const gamObjectReference = isPlainObject(configParams.gamObjectReference) ? configParams.gamObjectReference : undefined; + const gamParameterName = configParams.gamParameterName ? configParams.gamParameterName : 'intent_iq_group'; + const groupChanged = typeof configParams.groupChanged === 'function' ? configParams.groupChanged : undefined; + const siloEnabled = typeof configParams.siloEnabled === 'boolean' ? configParams.siloEnabled : false; sourceMetaData = isStr(configParams.sourceMetaData) ? translateMetadata(configParams.sourceMetaData) : ''; sourceMetaDataExternal = isNumber(configParams.sourceMetaDataExternal) ? configParams.sourceMetaDataExternal : undefined; - let additionalParams = configParams.additionalParams ? configParams.additionalParams : undefined; + const additionalParams = configParams.additionalParams ? configParams.additionalParams : undefined; PARTNER_DATA_KEY = `${FIRST_PARTY_KEY}_${configParams.partner}`; const allowedStorage = defineStorageType(config.enabledStorageTypes); @@ -518,7 +518,7 @@ export const intentIqIdSubmodule = { const resp = function (callback) { const callbacks = { success: response => { - let respJson = tryParse(response); + const respJson = tryParse(response); // If response is a valid json and should save is true if (respJson) { partnerData.date = Date.now(); diff --git a/modules/intenzeBidAdapter.js b/modules/intenzeBidAdapter.js index 31e4c69f862..02f893c006c 100644 --- a/modules/intenzeBidAdapter.js +++ b/modules/intenzeBidAdapter.js @@ -78,15 +78,15 @@ export const spec = { validBidRequests = convertOrtbRequestToProprietaryNative(validBidRequests); if (validBidRequests && validBidRequests.length === 0) return [] - let accuontId = validBidRequests[0].params.accountId; + const accuontId = validBidRequests[0].params.accountId; const endpointURL = URL_ENDPOINT.replace(ACCOUNTID_MACROS, accuontId); - let winTop = window; + const winTop = window; let location; location = bidderRequest?.refererInfo ?? null; - let bids = []; - for (let bidRequest of validBidRequests) { - let impObject = prepareImpObject(bidRequest); - let data = { + const bids = []; + for (const bidRequest of validBidRequests) { + const impObject = prepareImpObject(bidRequest); + const data = { id: bidRequest.bidId, test: config.getConfig('debug') ? 1 : 0, cur: ['USD'], @@ -136,13 +136,13 @@ export const spec = { */ interpretResponse: (serverResponse) => { if (!serverResponse || !serverResponse.body) return []; - let responses = serverResponse.body; + const responses = serverResponse.body; - let bids = []; - for (let response of responses) { - let mediaType = response.seatbid[0].bid[0].ext && response.seatbid[0].bid[0].ext.mediaType ? response.seatbid[0].bid[0].ext.mediaType : BANNER; + const bids = []; + for (const response of responses) { + const mediaType = response.seatbid[0].bid[0].ext && response.seatbid[0].bid[0].ext.mediaType ? response.seatbid[0].bid[0].ext.mediaType : BANNER; - let bid = { + const bid = { requestId: response.id, cpm: response.seatbid[0].bid[0].price, width: response.seatbid[0].bid[0].w, @@ -219,7 +219,7 @@ const parseNative = admObject => { } const prepareImpObject = (bidRequest) => { - let impObject = { + const impObject = { id: bidRequest.bidId, secure: 1, ext: { @@ -242,7 +242,7 @@ const prepareImpObject = (bidRequest) => { }; const addNativeParameters = bidRequest => { - let impObject = { + const impObject = { // TODO: this is not an "impObject", and `id` is not part of the ORTB native spec id: bidRequest.bidId, ver: NATIVE_VERSION, @@ -286,7 +286,7 @@ const addNativeParameters = bidRequest => { } const addBannerParameters = (bidRequest) => { - let bannerObject = {}; + const bannerObject = {}; const size = parseSizes(bidRequest, 'banner'); bannerObject.w = size[0]; bannerObject.h = size[1]; @@ -294,7 +294,7 @@ const addBannerParameters = (bidRequest) => { }; const parseSizes = (bid, mediaType) => { - let mediaTypes = bid.mediaTypes; + const mediaTypes = bid.mediaTypes; if (mediaType === 'video') { let size = []; if (mediaTypes.video && mediaTypes.video.w && mediaTypes.video.h) { @@ -322,10 +322,10 @@ const parseSizes = (bid, mediaType) => { } const addVideoParameters = (bidRequest) => { - let videoObj = {}; - let supportParamsList = ['mimes', 'minduration', 'maxduration', 'protocols', 'startdelay', 'skip', 'skipafter', 'minbitrate', 'maxbitrate', 'delivery', 'playbackmethod', 'api', 'linearity'] + const videoObj = {}; + const supportParamsList = ['mimes', 'minduration', 'maxduration', 'protocols', 'startdelay', 'skip', 'skipafter', 'minbitrate', 'maxbitrate', 'delivery', 'playbackmethod', 'api', 'linearity'] - for (let param of supportParamsList) { + for (const param of supportParamsList) { if (bidRequest.mediaTypes.video[param] !== undefined) { videoObj[param] = bidRequest.mediaTypes.video[param]; } diff --git a/modules/interactiveOffersBidAdapter.js b/modules/interactiveOffersBidAdapter.js index bb27239fef4..c1c70f6dc54 100644 --- a/modules/interactiveOffersBidAdapter.js +++ b/modules/interactiveOffersBidAdapter.js @@ -49,8 +49,8 @@ export const spec = { return ret; }, buildRequests: function(validBidRequests, bidderRequest) { - let aux = parseRequestPrebidjsToOpenRTB(bidderRequest, bidderRequest); - let payload = aux.payload; + const aux = parseRequestPrebidjsToOpenRTB(bidderRequest, bidderRequest); + const payload = aux.payload; return { method: 'POST', url: ENDPOINT + aux.partnerId, @@ -72,14 +72,14 @@ export const spec = { }; function parseRequestPrebidjsToOpenRTB(prebidRequest, bidderRequest) { - let ret = { + const ret = { payload: {}, partnerId: null }; // TODO: these should probably look at refererInfo - let pageURL = window.location.href; - let domain = window.location.hostname; - let openRTBRequest = deepClone(DEFAULT['OpenRTBBidRequest']); + const pageURL = window.location.href; + const domain = window.location.hostname; + const openRTBRequest = deepClone(DEFAULT['OpenRTBBidRequest']); openRTBRequest.id = bidderRequest.bidderRequestId; openRTBRequest.ext = { // TODO: please do not send internal data structures over the network @@ -117,7 +117,7 @@ function parseRequestPrebidjsToOpenRTB(prebidRequest, bidderRequest) { if (!ret.partnerId) { ret.partnerId = bid.params.partnerId; } - let imp = deepClone(DEFAULT['OpenRTBBidRequestImp']); + const imp = deepClone(DEFAULT['OpenRTBBidRequestImp']); imp.id = bid.bidId; imp.secure = bid.ortb2Imp?.secure ?? 1; imp.tagid = bid.adUnitCode; @@ -149,13 +149,13 @@ function parseRequestPrebidjsToOpenRTB(prebidRequest, bidderRequest) { return ret; } function parseResponseOpenRTBToPrebidjs(openRTBResponse) { - let prebidResponse = []; + const prebidResponse = []; openRTBResponse.forEach(function(response) { if (response.seatbid && response.seatbid.forEach) { response.seatbid.forEach(function(seatbid) { if (seatbid.bid && seatbid.bid.forEach) { seatbid.bid.forEach(function(bid) { - let prebid = deepClone(DEFAULT['PrebidBid']); + const prebid = deepClone(DEFAULT['PrebidBid']); prebid.requestId = bid.impid; prebid.ad = bid.adm; prebid.creativeId = bid.crid; diff --git a/modules/invibesBidAdapter.js b/modules/invibesBidAdapter.js index 8bb5f5aaac6..77556470a3c 100644 --- a/modules/invibesBidAdapter.js +++ b/modules/invibesBidAdapter.js @@ -53,7 +53,7 @@ registerBidder(spec); // some state info is required: cookie info, unique user visit id const topWin = getTopMostWindow(); -let invibes = topWin.invibes = topWin.invibes || {}; +const invibes = topWin.invibes = topWin.invibes || {}; invibes.purposes = invibes.purposes || [false, false, false, false, false, false, false, false, false, false, false]; invibes.legitimateInterests = invibes.legitimateInterests || [false, false, false, false, false, false, false, false, false, false, false]; invibes.placementBids = invibes.placementBids || []; @@ -88,7 +88,7 @@ function isBidRequestValid(bid) { if (typeof bid.params !== 'object') { return false; } - let params = bid.params; + const params = bid.params; if (params.placementId == null) { return false; @@ -114,7 +114,7 @@ function buildRequest(bidRequests, bidderRequest) { const _placementIds = []; const _adUnitCodes = []; let _customEndpoint, _userId, _domainId; - let _ivAuctionStart = Date.now(); + const _ivAuctionStart = Date.now(); window.invibes = window.invibes || {}; window.invibes.placementIds = window.invibes.placementIds || []; @@ -145,8 +145,8 @@ function buildRequest(bidRequests, bidderRequest) { invibes.visitId = invibes.visitId || generateRandomId(); const currentQueryStringParams = parseQueryStringParams(); - let userIdModel = getUserIds(_userId); - let bidParamsJson = { + const userIdModel = getUserIds(_userId); + const bidParamsJson = { placementIds: _placementIds, adUnitCodes: _adUnitCodes, auctionStartTime: _ivAuctionStart, @@ -155,7 +155,7 @@ function buildRequest(bidRequests, bidderRequest) { if (userIdModel) { bidParamsJson.userId = userIdModel; } - let data = { + const data = { location: getDocumentLocation(bidderRequest), videoAdHtmlId: generateRandomId(), showFallback: currentQueryStringParams['advs'] === '0', @@ -187,17 +187,17 @@ function buildRequest(bidRequests, bidderRequest) { data.pageReferrer = bidderRequest.refererInfo.ref.substring(0, 300); } - let hid = invibes.getCookie('handIid'); + const hid = invibes.getCookie('handIid'); if (hid) { data.handIid = hid; } let lid = readFromLocalStorage('ivbsdid'); if (!lid) { - let str = invibes.getCookie('ivbsdid'); + const str = invibes.getCookie('ivbsdid'); if (str) { try { - let cookieLid = JSON.parse(str); + const cookieLid = JSON.parse(str); lid = cookieLid.id ? cookieLid.id : cookieLid; } catch (e) { } @@ -208,16 +208,16 @@ function buildRequest(bidRequests, bidderRequest) { } const parametersToPassForward = 'videoaddebug,advs,bvci,bvid,istop,trybvid,trybvci'.split(','); - for (let key in currentQueryStringParams) { + for (const key in currentQueryStringParams) { if (currentQueryStringParams.hasOwnProperty(key)) { - let value = currentQueryStringParams[key]; + const value = currentQueryStringParams[key]; if (parametersToPassForward.indexOf(key) > -1 || /^vs|^invib/i.test(key)) { data[key] = value; } } } - let endpoint = createEndpoint(_customEndpoint, _domainId, _placementIds); + const endpoint = createEndpoint(_customEndpoint, _domainId, _placementIds); preventPageViewEvent = true; @@ -267,8 +267,8 @@ function handleResponse(responseObj, bidRequests) { const bidResponses = []; for (let i = 0; i < bidRequests.length; i++) { - let bidRequest = bidRequests[i]; - let usedPlacementId = responseObj.UseAdUnitCode === true + const bidRequest = bidRequests[i]; + const usedPlacementId = responseObj.UseAdUnitCode === true ? bidRequest.params.placementId + '_' + bidRequest.adUnitCode : bidRequest.params.placementId; @@ -280,20 +280,20 @@ function handleResponse(responseObj, bidRequests) { let requestPlacement = null; if (responseObj.AdPlacements != null) { for (let j = 0; j < responseObj.AdPlacements.length; j++) { - let bidModel = responseObj.AdPlacements[j].BidModel; + const bidModel = responseObj.AdPlacements[j].BidModel; if (bidModel != null && bidModel.PlacementId == usedPlacementId) { requestPlacement = responseObj.AdPlacements[j]; break; } } } else { - let bidModel = responseObj.BidModel; + const bidModel = responseObj.BidModel; if (bidModel != null && bidModel.PlacementId == usedPlacementId) { requestPlacement = responseObj; } } - let bid = createBid(bidRequest, requestPlacement, responseObj.MultipositionEnabled, usedPlacementId); + const bid = createBid(bidRequest, requestPlacement, responseObj.MultipositionEnabled, usedPlacementId); if (bid !== null) { invibes.placementBids.push(usedPlacementId); bidResponses.push(bid); @@ -309,8 +309,8 @@ function createBid(bidRequest, requestPlacement, multipositionEnabled, usedPlace return null; } - let bidModel = requestPlacement.BidModel; - let ads = requestPlacement.Ads; + const bidModel = requestPlacement.BidModel; + const ads = requestPlacement.Ads; if (!Array.isArray(ads) || ads.length < 1) { if (requestPlacement.AdReason != null) { logInfo('Invibes Adapter - No ads ' + requestPlacement.AdReason); @@ -320,13 +320,13 @@ function createBid(bidRequest, requestPlacement, multipositionEnabled, usedPlace return null; } - let ad = ads[0]; - let size = getBiggerSize(bidRequest.sizes); + const ad = ads[0]; + const size = getBiggerSize(bidRequest.sizes); if (multipositionEnabled === true) { if (Object.keys(invibes.pushedCids).length > 0) { if (ad.Blcids != null && ad.Blcids.length > 0) { - let blacklistsPushedCids = Object.keys(invibes.pushedCids).some(function(pushedCid) { + const blacklistsPushedCids = Object.keys(invibes.pushedCids).some(function(pushedCid) { return ad.Blcids.indexOf(parseInt(pushedCid)) > -1; }); @@ -336,7 +336,7 @@ function createBid(bidRequest, requestPlacement, multipositionEnabled, usedPlace } } - let isBlacklisted = Object.keys(invibes.pushedCids).some(function(pushedCid) { + const isBlacklisted = Object.keys(invibes.pushedCids).some(function(pushedCid) { return invibes.pushedCids[pushedCid].indexOf(ad.Cid) > -1; }); if (isBlacklisted) { @@ -446,13 +446,13 @@ function getUserIds(bidUserId) { function parseQueryStringParams() { let params = {}; try { - let storedParam = storage.getDataFromLocalStorage('ivbs'); + const storedParam = storage.getDataFromLocalStorage('ivbs'); if (storedParam != null) { params = JSON.parse(storedParam); } } catch (e) { } - let re = /[\\?&]([^=]+)=([^\\?&#]+)/g; + const re = /[\\?&]([^=]+)=([^\\?&#]+)/g; let m; while ((m = re.exec(window.location.href)) != null) { if (m.index === re.lastIndex) { @@ -521,7 +521,7 @@ function getCappedCampaignsAsString() { return ''; } - let loadData = function () { + const loadData = function () { try { return JSON.parse(storage.getDataFromLocalStorage(key)) || {}; } catch (e) { @@ -529,16 +529,16 @@ function getCappedCampaignsAsString() { } }; - let saveData = function (data) { + const saveData = function (data) { storage.setDataInLocalStorage(key, JSON.stringify(data)); }; - let clearExpired = function () { - let now = new Date().getTime(); - let data = loadData(); + const clearExpired = function () { + const now = new Date().getTime(); + const data = loadData(); let dirty = false; Object.keys(data).forEach(function (k) { - let exp = data[k][1]; + const exp = data[k][1]; if (exp <= now) { delete data[k]; dirty = true; @@ -549,9 +549,9 @@ function getCappedCampaignsAsString() { } }; - let getCappedCampaigns = function () { + const getCappedCampaigns = function () { clearExpired(); - let data = loadData(); + const data = loadData(); return Object.keys(data) .filter(function (k) { return data.hasOwnProperty(k); @@ -576,10 +576,10 @@ function buildSyncUrl() { let did = readFromLocalStorage('ivbsdid'); if (!did) { - let str = invibes.getCookie('ivbsdid'); + const str = invibes.getCookie('ivbsdid'); if (str) { try { - let cookieLid = JSON.parse(str); + const cookieLid = JSON.parse(str); did = cookieLid.id ? cookieLid.id : cookieLid; } catch (e) { } @@ -605,23 +605,23 @@ function readGdprConsent(gdprConsent, usConsent) { return 2; } - let purposeConsents = getPurposeConsents(gdprConsent.vendorData); + const purposeConsents = getPurposeConsents(gdprConsent.vendorData); if (purposeConsents == null) { return 0; } - let purposesLength = getPurposeConsentsCounter(gdprConsent.vendorData); + const purposesLength = getPurposeConsentsCounter(gdprConsent.vendorData); if (!tryCopyValueToArray(purposeConsents, invibes.purposes, purposesLength)) { return 0; } - let legitimateInterests = getLegitimateInterests(gdprConsent.vendorData); + const legitimateInterests = getLegitimateInterests(gdprConsent.vendorData); tryCopyValueToArray(legitimateInterests, invibes.legitimateInterests, purposesLength); - let invibesVendorId = CONSTANTS.INVIBES_VENDOR_ID.toString(10); - let vendorConsents = getVendorConsents(gdprConsent.vendorData); - let vendorHasLegitimateInterest = getVendorLegitimateInterest(gdprConsent.vendorData)[invibesVendorId] === true; + const invibesVendorId = CONSTANTS.INVIBES_VENDOR_ID.toString(10); + const vendorConsents = getVendorConsents(gdprConsent.vendorData); + const vendorHasLegitimateInterest = getVendorLegitimateInterest(gdprConsent.vendorData)[invibesVendorId] === true; if (vendorConsents == null || vendorConsents[invibesVendorId] == null) { return 4; } @@ -663,13 +663,13 @@ function tryCopyValueToArray(value, target, length) { } if (typeof value === 'object' && value !== null) { let i = 0; - for (let prop in value) { + for (const prop in value) { if (i === length) { break; } if (value.hasOwnProperty(prop)) { - let parsedProp = parseInt(prop); + const parsedProp = parseInt(prop); if (isNaN(parsedProp)) { target[i] = !((value[prop] === false || value[prop] === 'false' || value[prop] == null)); } else { @@ -749,12 +749,12 @@ function getVendorLegitimateInterest(vendorData) { /// Local domain cookie management ===================== invibes.Uid = { generate: function () { - let maxRand = parseInt('zzzzzz', 36) - let mkRand = function () { + const maxRand = parseInt('zzzzzz', 36) + const mkRand = function () { return Math.floor(Math.random() * maxRand).toString(36); }; - let rand1 = mkRand(); - let rand2 = mkRand(); + const rand1 = mkRand(); + const rand2 = mkRand(); return rand1 + rand2; } }; @@ -771,20 +771,15 @@ invibes.getCookie = function (name) { return storage.getCookie(name); }; -let keywords = (function () { +const keywords = (function () { const cap = 300; - let headTag = document.getElementsByTagName('head')[0]; - let metaTag = headTag ? headTag.getElementsByTagName('meta') : []; + const headTag = document.getElementsByTagName('head')[0]; + const metaTag = headTag ? headTag.getElementsByTagName('meta') : []; function parse(str, cap) { let parsedStr = str.replace(/[<>~|\\"`!@#$%^&*()=+?]/g, ''); - - function onlyUnique(value, index, self) { - return value !== '' && self.indexOf(value) === index; - } - let words = parsedStr.split(/[\s,;.:]+/); - let uniqueWords = words.filter(onlyUnique); + let uniqueWords = Array.from(new Set(words.filter(word => word))); parsedStr = ''; for (let i = 0; i < uniqueWords.length; i++) { @@ -803,7 +798,7 @@ let keywords = (function () { function gt(cap, prefix) { cap = cap || 300; prefix = prefix || ''; - let title = document.title || headTag + const title = document.title || headTag ? headTag.getElementsByTagName('title')[0] ? headTag.getElementsByTagName('title')[0].innerHTML : '' @@ -820,7 +815,7 @@ let keywords = (function () { for (let i = 0; i < metaTag.length; i++) { if (metaTag[i].name && metaTag[i].name.toLowerCase() === metaName.toLowerCase()) { - let kw = prefix + ',' + metaTag[i].content || ''; + const kw = prefix + ',' + metaTag[i].content || ''; return parse(kw, cap); } else if (metaTag[i].name && metaTag[i].name.toLowerCase().indexOf(metaName.toLowerCase()) > -1) { fallbackKw = prefix + ',' + metaTag[i].content || ''; diff --git a/modules/invisiblyAnalyticsAdapter.js b/modules/invisiblyAnalyticsAdapter.js index a2305cc5154..d6b5fc3efef 100644 --- a/modules/invisiblyAnalyticsAdapter.js +++ b/modules/invisiblyAnalyticsAdapter.js @@ -41,7 +41,7 @@ let invisiblyAnalyticsEnabled = false; const { width: x, height: y } = getViewportSize(); -let _pageView = { +const _pageView = { eventType: 'pageView', userAgent: window.navigator.userAgent, timestamp: Date.now(), @@ -53,11 +53,11 @@ let _pageView = { }; // pass only 1% of events & fail the rest 99% -let weightedFilter = { filter: Math.random() > 0.99 }; +const weightedFilter = { filter: Math.random() > 0.99 }; -let _eventQueue = [_pageView]; +const _eventQueue = [_pageView]; -let invisiblyAdapter = Object.assign( +const invisiblyAdapter = Object.assign( adapter({ url: DEFAULT_EVENT_URL, analyticsType }), { track({ eventType, args }) { @@ -99,18 +99,18 @@ function flush() { if (_eventQueue.length > 0) { while (_eventQueue.length) { - let eventFromQue = _eventQueue.shift(); - let eventtype = 'PREBID_' + eventFromQue.eventType; + const eventFromQue = _eventQueue.shift(); + const eventtype = 'PREBID_' + eventFromQue.eventType; delete eventFromQue.eventType; - let data = { + const data = { pageViewId: _pageViewId, ver: _VERSION, bundleId: initOptions.bundleId, ...eventFromQue, }; - let payload = { + const payload = { event_type: eventtype, event_data: { ...data }, }; diff --git a/modules/ipromBidAdapter.js b/modules/ipromBidAdapter.js index 1188af471a7..42c7508915c 100644 --- a/modules/ipromBidAdapter.js +++ b/modules/ipromBidAdapter.js @@ -50,7 +50,7 @@ export const spec = { }, interpretResponse: function (serverResponse, request) { - let bids = serverResponse.body; + const bids = serverResponse.body; const bidResponses = []; diff --git a/modules/ixBidAdapter.js b/modules/ixBidAdapter.js index f21a9915e31..a4292462b86 100644 --- a/modules/ixBidAdapter.js +++ b/modules/ixBidAdapter.js @@ -213,7 +213,7 @@ export function bidToVideoImp(bid) { imp.video = videoParamRef ? deepClone(bid.params.video) : {}; // populate imp level transactionId - let tid = deepAccess(bid, 'ortb2Imp.ext.tid'); + const tid = deepAccess(bid, 'ortb2Imp.ext.tid'); if (tid) { deepSetValue(imp, 'ext.tid', tid); } @@ -305,7 +305,7 @@ export function bidToNativeImp(bid) { }; // populate imp level transactionId - let tid = deepAccess(bid, 'ortb2Imp.ext.tid'); + const tid = deepAccess(bid, 'ortb2Imp.ext.tid'); if (tid) { deepSetValue(imp, 'ext.tid', tid); } @@ -547,7 +547,7 @@ function checkVideoParams(mediaTypeVideoRef, paramsVideoRef) { logWarn('IX Bid Adapter: mediaTypes.video is the preferred location for video params in ad unit'); } - for (let property of REQUIRED_VIDEO_PARAMS) { + for (const property of REQUIRED_VIDEO_PARAMS) { const propInMediaType = mediaTypeVideoRef && mediaTypeVideoRef.hasOwnProperty(property); const propInVideoRef = paramsVideoRef && paramsVideoRef.hasOwnProperty(property); @@ -635,8 +635,8 @@ function getBidRequest(id, impressions, validBidRequests) { * identity info from IX Library) */ function getEidInfo(allEids) { - let toSend = []; - let seenSources = {}; + const toSend = []; + const seenSources = {}; if (isArray(allEids)) { for (const eid of allEids) { const isSourceMapped = SOURCE_RTI_MAPPING.hasOwnProperty(eid.source); @@ -673,10 +673,10 @@ function getEidInfo(allEids) { */ function buildRequest(validBidRequests, bidderRequest, impressions, version) { // Always use secure HTTPS protocol. - let baseUrl = SECURE_BID_URL; + const baseUrl = SECURE_BID_URL; // Get ids from Prebid User ID Modules - let eidInfo = getEidInfo(deepAccess(validBidRequests, '0.userIdAsEids')); - let userEids = eidInfo.toSend; + const eidInfo = getEidInfo(deepAccess(validBidRequests, '0.userIdAsEids')); + const userEids = eidInfo.toSend; // RTI ids will be included in the bid request if the function getIdentityInfo() is loaded // and if the data for the partner exist @@ -692,8 +692,8 @@ function buildRequest(validBidRequests, bidderRequest, impressions, version) { // getting ixdiags for adunits of the video, outstream & multi format (MF) style const fledgeEnabled = deepAccess(bidderRequest, 'paapi.enabled') - let ixdiag = buildIXDiag(validBidRequests, fledgeEnabled); - for (let key in ixdiag) { + const ixdiag = buildIXDiag(validBidRequests, fledgeEnabled); + for (const key in ixdiag) { r.ext.ixdiag[key] = ixdiag[key]; } @@ -701,7 +701,7 @@ function buildRequest(validBidRequests, bidderRequest, impressions, version) { r = applyRegulations(r, bidderRequest); - let payload = {}; + const payload = {}; if (validBidRequests[0].params.siteId) { siteID = validBidRequests[0].params.siteId; payload.s = siteID; @@ -777,14 +777,14 @@ function buildRequest(validBidRequests, bidderRequest, impressions, version) { * @param {Array} eidInfo eidInfo info from prebid */ function addRTI(userEids, eidInfo) { - let identityInfo = window.headertag.getIdentityInfo(); + const identityInfo = window.headertag.getIdentityInfo(); if (identityInfo && typeof identityInfo === 'object') { for (const partnerName in identityInfo) { if (userEids.length >= MAX_EID_SOURCES) { return } if (identityInfo.hasOwnProperty(partnerName)) { - let response = identityInfo[partnerName]; + const response = identityInfo[partnerName]; if (!response.responsePending && response.data && typeof response.data === 'object' && Object.keys(response.data).length && !eidInfo.seenSources[response.data.source]) { userEids.push(response.data); @@ -975,7 +975,7 @@ function addImpressions(impressions, impKeys, r, adUnitIndex) { for (const impId in bannerImpsKeyed) { const bannerImps = bannerImpsKeyed[impId]; const { id, banner: { topframe } } = bannerImps[0]; - let externalID = deepAccess(bannerImps[0], 'ext.externalID'); + const externalID = deepAccess(bannerImps[0], 'ext.externalID'); const _bannerImpression = { id, banner: { @@ -1285,8 +1285,8 @@ function buildIXDiag(validBidRequests, fledgeEnabled) { .map(bidRequest => bidRequest.adUnitCode) .filter((value, index, arr) => arr.indexOf(value) === index); - let allEids = deepAccess(validBidRequests, '0.userIdAsEids', []) - let ixdiag = { + const allEids = deepAccess(validBidRequests, '0.userIdAsEids', []) + const ixdiag = { mfu: 0, bu: 0, iu: 0, @@ -1302,8 +1302,8 @@ function buildIXDiag(validBidRequests, fledgeEnabled) { }; // create ad unit map and collect the required diag properties - for (let adUnit of adUnitMap) { - let bid = validBidRequests.filter(bidRequest => bidRequest.adUnitCode === adUnit)[0]; + for (const adUnit of adUnitMap) { + const bid = validBidRequests.filter(bidRequest => bidRequest.adUnitCode === adUnit)[0]; if (deepAccess(bid, 'mediaTypes')) { if (Object.keys(bid.mediaTypes).length > 1) { @@ -1408,7 +1408,7 @@ function createVideoImps(validBidRequest, videoImps) { * @param {object} bannerImps reference to created banner impressions */ function createBannerImps(validBidRequest, missingBannerSizes, bannerImps, bidderRequest) { - let imp = bidToBannerImp(validBidRequest); + const imp = bidToBannerImp(validBidRequest); const bannerSizeDefined = includesSize(deepAccess(validBidRequest, 'mediaTypes.banner.sizes'), deepAccess(validBidRequest, 'params.size')); @@ -1484,9 +1484,9 @@ function updateMissingSizes(validBidRequest, missingBannerSizes, imp) { } else { // New Ad Unit if (deepAccess(validBidRequest, 'mediaTypes.banner.sizes')) { - let sizeList = deepClone(validBidRequest.mediaTypes.banner.sizes); + const sizeList = deepClone(validBidRequest.mediaTypes.banner.sizes); removeFromSizes(sizeList, validBidRequest.params.size); - let newAdUnitEntry = { + const newAdUnitEntry = { 'missingSizes': sizeList, 'impression': imp }; @@ -1577,7 +1577,7 @@ function isIndexRendererPreferred(bid) { } function isExchangeIdConfigured() { - let exchangeId = config.getConfig('exchangeId'); + const exchangeId = config.getConfig('exchangeId'); if (typeof exchangeId === 'number' && isFinite(exchangeId)) { return true; } @@ -1722,9 +1722,9 @@ export const spec = { }); // Step 2: Update banner impressions with missing sizes - for (let adunitCode in missingBannerSizes) { + for (const adunitCode in missingBannerSizes) { if (missingBannerSizes.hasOwnProperty(adunitCode)) { - let missingSizes = missingBannerSizes[adunitCode].missingSizes; + const missingSizes = missingBannerSizes[adunitCode].missingSizes; if (!bannerImps.hasOwnProperty(adunitCode)) { bannerImps[adunitCode] = {}; @@ -1734,9 +1734,9 @@ export const spec = { bannerImps[adunitCode].missingCount = 0; } - let origImp = missingBannerSizes[adunitCode].impression; + const origImp = missingBannerSizes[adunitCode].impression; for (let i = 0; i < missingSizes.length; i++) { - let newImp = createMissingBannerImp(validBidRequests[0], origImp, missingSizes[i]); + const newImp = createMissingBannerImp(validBidRequests[0], origImp, missingSizes[i]); bannerImps[adunitCode].missingImps.push(newImp); bannerImps[adunitCode].missingCount++; } @@ -1744,7 +1744,7 @@ export const spec = { } // Step 3: Build banner, video & native requests - let allImps = []; + const allImps = []; if (Object.keys(bannerImps).length > 0) { allImps.push(bannerImps); } @@ -1912,7 +1912,7 @@ function buildImgSyncUrl(syncsPerBidder, index) { if (gdprConsent && gdprConsent.hasOwnProperty('consentString')) { consentString = gdprConsent.consentString || ''; } - let siteIdParam = siteID !== 0 ? '&site_id=' + siteID.toString() : ''; + const siteIdParam = siteID !== 0 ? '&site_id=' + siteID.toString() : ''; return IMG_USER_SYNC_URL + siteIdParam + '&p=' + syncsPerBidder.toString() + '&i=' + index.toString() + '&gdpr=' + gdprApplies + '&gdpr_consent=' + consentString + '&us_privacy=' + (usPrivacy || ''); } diff --git a/modules/jixieBidAdapter.js b/modules/jixieBidAdapter.js index b0c47d2f841..750f44c2491 100644 --- a/modules/jixieBidAdapter.js +++ b/modules/jixieBidAdapter.js @@ -26,7 +26,7 @@ function getBidFloor(bid) { if (!isFn(bid.getFloor)) { return null; } - let floor = bid.getFloor({ + const floor = bid.getFloor({ currency: 'USD', mediaType: '*', size: '*' @@ -47,8 +47,8 @@ function setIds_(clientId, sessionId) { dd = window.location.hostname.match(/[^.]*\.[^.]{2,3}(?:\.[^.]{2,3})?$/mg); } catch (err1) {} try { - let expC = (new Date(new Date().setFullYear(new Date().getFullYear() + 1))).toUTCString(); - let expS = (new Date(new Date().setMinutes(new Date().getMinutes() + sidTTLMins_))).toUTCString(); + const expC = (new Date(new Date().setFullYear(new Date().getFullYear() + 1))).toUTCString(); + const expS = (new Date(new Date().setMinutes(new Date().getMinutes() + sidTTLMins_))).toUTCString(); storage.setCookie('_jxx', clientId, expC, 'None', null); storage.setCookie('_jxx', clientId, expC, 'None', dd); @@ -73,7 +73,7 @@ const defaultGenIds_ = [ ]; function fetchIds_(cfg) { - let ret = { + const ret = { client_id_c: '', client_id_ls: '', session_id_c: '', @@ -91,7 +91,7 @@ function fetchIds_(cfg) { tmp = storage.getDataFromLocalStorage('_jxxs'); if (tmp) ret.session_id_ls = tmp; - let arr = cfg.genids ? cfg.genids : defaultGenIds_; + const arr = cfg.genids ? cfg.genids : defaultGenIds_; arr.forEach(function(o) { tmp = storage.getCookie(o.ck ? o.ck : o.id); if (tmp) ret.jxeids[o.id] = tmp; @@ -141,7 +141,7 @@ function createRenderer_(bidAd, scriptUrl, createFcn) { } function getMiscDims_() { - let ret = { + const ret = { pageurl: '', domain: '', device: 'unknown', @@ -149,13 +149,13 @@ function getMiscDims_() { } try { // TODO: this should pick refererInfo from bidderRequest - let refererInfo_ = getRefererInfo(); + const refererInfo_ = getRefererInfo(); // TODO: does the fallback make sense here? - let url_ = refererInfo_?.page || window.location.href + const url_ = refererInfo_?.page || window.location.href ret.pageurl = url_; ret.domain = refererInfo_?.domain || window.location.host ret.device = getDevice_(); - let keywords = document.getElementsByTagName('meta')['keywords']; + const keywords = document.getElementsByTagName('meta')['keywords']; if (keywords && keywords.content) { ret.mkeywords = keywords.content; } @@ -187,10 +187,10 @@ export const spec = { const currencyObj = config.getConfig('currency'); const currency = (currencyObj && currencyObj.adServerCurrency) || 'USD'; - let bids = []; + const bids = []; validBidRequests.forEach(function(one) { - let gpid = deepAccess(one, 'ortb2Imp.ext.gpid', ''); - let tmp = { + const gpid = deepAccess(one, 'ortb2Imp.ext.gpid', ''); + const tmp = { bidId: one.bidId, adUnitCode: one.adUnitCode, mediaTypes: (one.mediaTypes === 'undefined' ? {} : one.mediaTypes), @@ -198,26 +198,26 @@ export const spec = { params: one.params, gpid: gpid }; - let bidFloor = getBidFloor(one); + const bidFloor = getBidFloor(one); if (bidFloor) { tmp.bidFloor = bidFloor; } bids.push(tmp); }); - let jxCfg = config.getConfig('jixie') || {}; + const jxCfg = config.getConfig('jixie') || {}; - let ids = fetchIds_(jxCfg); + const ids = fetchIds_(jxCfg); let eids = []; - let miscDims = internal.getMiscDims(); - let schain = deepAccess(validBidRequests[0], 'ortb2.source.ext.schain'); + const miscDims = internal.getMiscDims(); + const schain = deepAccess(validBidRequests[0], 'ortb2.source.ext.schain'); - let eids1 = validBidRequests[0].userIdAsEids; + const eids1 = validBidRequests[0].userIdAsEids; // all available user ids are sent to our backend in the standard array layout: if (eids1 && eids1.length) { eids = eids1; } // we want to send this blob of info to our backend: - let transformedParams = Object.assign({}, { + const transformedParams = Object.assign({}, { // TODO: fix auctionId leak: https://github.com/prebid/Prebid.js/issues/9781 auctionid: bidderRequest.auctionId || '', aid: jxCfg.aid || '', @@ -265,7 +265,7 @@ export const spec = { if (response && response.body && isArray(response.body.bids)) { const bidResponses = []; response.body.bids.forEach(function(oneBid) { - let bnd = {}; + const bnd = {}; Object.assign(bnd, oneBid); if (oneBid.osplayer) { bnd.adResponse = { @@ -274,7 +274,7 @@ export const spec = { height: oneBid.height, width: oneBid.width }; - let rendererScript = (oneBid.osparams.script ? oneBid.osparams.script : JX_OUTSTREAM_RENDERER_URL); + const rendererScript = (oneBid.osparams.script ? oneBid.osparams.script : JX_OUTSTREAM_RENDERER_URL); bnd.renderer = createRenderer_(oneBid, rendererScript, jxOutstreamRender_); } // a note on advertiserDomains: our adserver is not responding in @@ -301,7 +301,7 @@ export const spec = { if (!serverResponses.length || !serverResponses[0].body || !serverResponses[0].body.userSyncs) { return false; } - let syncs = []; + const syncs = []; serverResponses[0].body.userSyncs.forEach(function(sync) { if (syncOptions.iframeEnabled) { syncs.push(sync.uf ? { url: sync.uf, type: 'iframe' } : { url: sync.up, type: 'image' }); diff --git a/modules/jixieIdSystem.js b/modules/jixieIdSystem.js index f5373c44f7c..02a1850df09 100644 --- a/modules/jixieIdSystem.js +++ b/modules/jixieIdSystem.js @@ -45,7 +45,7 @@ function removeNullProp(obj) { * @param {object} response */ function persistExtInfo(response) { - let o = response; + const o = response; if (o) { const ageMS = (CK_LIFE_DAYS) * 24 * 60 * 60 * 1000; const expireDT = new Date(timestamp() + ageMS).toUTCString(); @@ -65,7 +65,7 @@ function persistExtInfo(response) { * @returns {string} a full url to call by ajax */ function buildIdCallUrl(params, gdprConsent) { - let url = parseUrl(params.idendpoint || TRACKER_EP_FROM_IDMODULE); + const url = parseUrl(params.idendpoint || TRACKER_EP_FROM_IDMODULE); if (gdprConsent) { url.search.gdpr_consent = gdprConsent && gdprConsent.gdprApplies ? gdprConsent.consentString : ''; @@ -104,8 +104,8 @@ function pgHasJxEvtScript() { */ function shouldCallSrv(logstr) { if (!logstr) return true; - let now = Date.now(); - let tsStr = logstr.split('_')[0]; + const now = Date.now(); + const tsStr = logstr.split('_')[0]; let ts = parseInt(tsStr, 10); if (!(tsStr.length == 13 && ts && ts >= (now - ONE_YEAR_IN_MS) && ts <= (now + ONE_YEAR_IN_MS))) { ts = undefined; @@ -152,11 +152,11 @@ export const jixieIdSubmodule = { } // Case of no jixie script runs on this site: jxId = storage.getCookie(PBJS_JXID_KEY); - let idLogStr = storage.getCookie(PBJS_IDLOGSTR_KEY); + const idLogStr = storage.getCookie(PBJS_IDLOGSTR_KEY); if (jxId && !shouldCallSrv(idLogStr)) { callback(jxId); } else { - let handleResponse = function(responseText, xhr) { + const handleResponse = function(responseText, xhr) { if (xhr.status === 200) { let response = JSON.parse(responseText); if (response && response.data && response.data.success) { diff --git a/modules/justpremiumBidAdapter.js b/modules/justpremiumBidAdapter.js index 081a3f44a27..a0973bf83ab 100644 --- a/modules/justpremiumBidAdapter.js +++ b/modules/justpremiumBidAdapter.js @@ -86,12 +86,12 @@ export const spec = { interpretResponse: (serverResponse, bidRequests) => { const body = serverResponse.body - let bidResponses = [] + const bidResponses = [] bidRequests.bids.forEach(adUnit => { - let bid = findBid(adUnit.params, body.bid) + const bid = findBid(adUnit.params, body.bid) if (bid) { - let size = (adUnit.mediaTypes && adUnit.mediaTypes.banner && adUnit.mediaTypes.banner.sizes && adUnit.mediaTypes.banner.sizes.length && adUnit.mediaTypes.banner.sizes[0]) || [] - let bidResponse = { + const size = (adUnit.mediaTypes && adUnit.mediaTypes.banner && adUnit.mediaTypes.banner.sizes && adUnit.mediaTypes.banner.sizes.length && adUnit.mediaTypes.banner.sizes[0]) || [] + const bidResponse = { requestId: adUnit.bidId, creativeId: bid.id, width: size[0] || bid.width, @@ -219,7 +219,7 @@ function preparePubCond (bids) { Object.keys(cond).forEach((zone) => { if (cond[zone] !== 1 && cond[zone][1].length) { cond[zone][0].forEach((r) => { - let idx = cond[zone][1].indexOf(r) + const idx = cond[zone][1].indexOf(r) if (idx > -1) { cond[zone][1].splice(idx, 1) } diff --git a/modules/jwplayerRtdProvider.js b/modules/jwplayerRtdProvider.js index 0712edea841..1865da7b77b 100644 --- a/modules/jwplayerRtdProvider.js +++ b/modules/jwplayerRtdProvider.js @@ -340,7 +340,7 @@ export function getContentData(mediaId, segments) { }; if (mediaId) { - contentData.ext.cids = [mediaId]; + contentData.ext.cids = contentData.cids = [mediaId]; } if (segments) { @@ -356,8 +356,8 @@ export function addOrtbSiteContent(ortb2, contentId, contentData, contentTitle, ortb2 = {}; } - let site = ortb2.site = ortb2.site || {}; - let content = site.content = site.content || {}; + const site = ortb2.site = ortb2.site || {}; + const content = site.content = site.content || {}; if (shouldOverride(content.id, contentId, overrideContentId)) { content.id = contentId; @@ -446,7 +446,7 @@ export function getPlayer(playerDivId) { return; } - let errorMessage = `player Div ID ${playerDivId} did not match any players.`; + const errorMessage = `player Div ID ${playerDivId} did not match any players.`; // If there are multiple instances on the page, we cannot guess which one should be targeted. if (playerOnPageCount > 1) { diff --git a/modules/jwplayerVideoProvider.js b/modules/jwplayerVideoProvider.js index 8b956ab1850..eb910893b01 100644 --- a/modules/jwplayerVideoProvider.js +++ b/modules/jwplayerVideoProvider.js @@ -35,12 +35,12 @@ export function JWPlayerProvider(config, jwplayer_, adState_, timeState_, callba let playerVersion = null; const playerConfig = config.playerConfig; const divId = config.divId; - let adState = adState_; - let timeState = timeState_; - let callbackStorage = callbackStorage_; + const adState = adState_; + const timeState = timeState_; + const callbackStorage = callbackStorage_; let pendingSeek = {}; let supportedMediaTypes = null; - let minimumSupportedPlayerVersion = '8.20.1'; + const minimumSupportedPlayerVersion = '8.20.1'; let setupCompleteCallbacks = []; let setupFailedCallbacks = []; const MEDIA_TYPES = [ @@ -649,7 +649,7 @@ export const utils = { getPlayerSizeFromAspectRatio: function(player, config) { const aspectRatio = config.aspectratio; - let percentageWidth = config.width; + const percentageWidth = config.width; if (typeof aspectRatio !== 'string' || typeof percentageWidth !== 'string') { return {}; @@ -836,7 +836,6 @@ export const utils = { const formattedSegments = jwpsegs.reduce((convertedSegments, rawSegment) => { convertedSegments.push({ id: rawSegment, - value: rawSegment }); return convertedSegments; }, []); @@ -897,7 +896,7 @@ export function callbackStorageFactory() { } function getCallback(eventType, callback) { - let eventHandlers = storage[eventType]; + const eventHandlers = storage[eventType]; if (!eventHandlers) { return; } diff --git a/modules/kargoAnalyticsAdapter.js b/modules/kargoAnalyticsAdapter.js index f8b088eefe8..63c452a8791 100644 --- a/modules/kargoAnalyticsAdapter.js +++ b/modules/kargoAnalyticsAdapter.js @@ -11,13 +11,13 @@ const analyticsType = 'endpoint'; let _initOptions = {}; -let _logBidResponseData = { +const _logBidResponseData = { auctionId: '', auctionTimeout: 0, responseTime: 0, }; -let _bidResponseDataLogged = []; +const _bidResponseDataLogged = []; var kargoAnalyticsAdapter = Object.assign( adapter({ analyticsType }), { diff --git a/modules/kargoBidAdapter.js b/modules/kargoBidAdapter.js index 17fa998bbfd..9ae30522cdc 100644 --- a/modules/kargoBidAdapter.js +++ b/modules/kargoBidAdapter.js @@ -206,7 +206,7 @@ function interpretResponse(response, bidRequest) { } for (const [bidID, adUnit] of Object.entries(bids)) { - let meta = { + const meta = { mediaType: adUnit.mediaType && BIDDER.SUPPORTED_MEDIA_TYPES.includes(adUnit.mediaType) ? adUnit.mediaType : BANNER }; @@ -318,7 +318,7 @@ function getExtensions(ortb2, refererInfo) { } function _getCrb() { - let localStorageCrb = getCrbFromLocalStorage(); + const localStorageCrb = getCrbFromLocalStorage(); if (Object.keys(localStorageCrb).length) { return localStorageCrb; } @@ -336,7 +336,7 @@ function getCrbFromCookie() { try { const crb = JSON.parse(STORAGE.getCookie(CERBERUS.KEY)); if (crb && crb.v) { - let vParsed = JSON.parse(atob(crb.v)); + const vParsed = JSON.parse(atob(crb.v)); if (vParsed) { return vParsed; } diff --git a/modules/kubientBidAdapter.js b/modules/kubientBidAdapter.js index b66b4e851d5..cf25eb57689 100644 --- a/modules/kubientBidAdapter.js +++ b/modules/kubientBidAdapter.js @@ -24,7 +24,7 @@ export const spec = { return; } return validBidRequests.map(function (bid) { - let adSlot = { + const adSlot = { bidId: bid.bidId, zoneId: bid.params.zoneid || '' }; @@ -34,7 +34,7 @@ export const spec = { const sizes = bid.sizes || '*'; const floorInfo = bid.getFloor({currency: 'USD', mediaType: mediaType, size: sizes}); if (isPlainObject(floorInfo) && floorInfo.currency === 'USD') { - let floor = parseFloat(floorInfo.floor) + const floor = parseFloat(floorInfo.floor) if (!isNaN(floor) && floor > 0) { adSlot.floor = parseFloat(floorInfo.floor); } @@ -54,7 +54,7 @@ export const spec = { adSlot.schain = schain; } - let data = { + const data = { v: VERSION, requestId: bid.bidderRequestId, adSlots: [adSlot], @@ -88,9 +88,9 @@ export const spec = { if (!serverResponse || !serverResponse.body || !serverResponse.body.seatbid) { return []; } - let bidResponses = []; + const bidResponses = []; serverResponse.body.seatbid.forEach(seatbid => { - let bids = seatbid.bid || []; + const bids = seatbid.bid || []; bids.forEach(bid => { const bidResponse = { requestId: bid.bidId, @@ -117,13 +117,13 @@ export const spec = { return bidResponses; }, getUserSyncs: function (syncOptions, serverResponses, gdprConsent, uspConsent) { - let kubientSync = kubientGetSyncInclude(config); + const kubientSync = kubientGetSyncInclude(config); if (!syncOptions.pixelEnabled || kubientSync.image === 'exclude') { return []; } - let values = {}; + const values = {}; if (gdprConsent) { if (typeof gdprConsent.gdprApplies === 'boolean') { values['gdpr'] = Number(gdprConsent.gdprApplies); @@ -160,9 +160,9 @@ function kubientGetConsentGiven(gdprConsent) { function kubientGetSyncInclude(config) { try { - let kubientSync = {}; + const kubientSync = {}; if (config.getConfig('userSync').filterSettings != null && typeof config.getConfig('userSync').filterSettings != 'undefined') { - let filterSettings = config.getConfig('userSync').filterSettings + const filterSettings = config.getConfig('userSync').filterSettings if (filterSettings.iframe !== null && typeof filterSettings.iframe !== 'undefined') { kubientSync.iframe = ((isArray(filterSettings.image.bidders) && filterSettings.iframe.bidders.indexOf('kubient') !== -1) || filterSettings.iframe.bidders === '*') ? filterSettings.iframe.filter : 'exclude'; } diff --git a/modules/lemmaDigitalBidAdapter.js b/modules/lemmaDigitalBidAdapter.js index 4e0350233b2..594e1c973fa 100644 --- a/modules/lemmaDigitalBidAdapter.js +++ b/modules/lemmaDigitalBidAdapter.js @@ -105,7 +105,7 @@ export var spec = { * @return {UserSync[]} The user syncs which should be dropped. */ getUserSyncs: (syncOptions, serverResponses) => { - let syncurl = USER_SYNC + 'pid=' + pubId; + const syncurl = USER_SYNC + 'pid=' + pubId; if (syncOptions.iframeEnabled) { return [{ type: 'iframe', @@ -295,9 +295,9 @@ export var spec = { if (typeof bid.getFloor === 'function') { [BANNER, VIDEO].forEach(mediaType => { if (impObj.hasOwnProperty(mediaType)) { - let floorInfo = bid.getFloor({ currency: impObj.bidfloorcur, mediaType: mediaType, size: '*' }); + const floorInfo = bid.getFloor({ currency: impObj.bidfloorcur, mediaType: mediaType, size: '*' }); if (utils.isPlainObject(floorInfo) && floorInfo.currency === impObj.bidfloorcur && !isNaN(parseInt(floorInfo.floor))) { - let mediaTypeFloor = parseFloat(floorInfo.floor); + const mediaTypeFloor = parseFloat(floorInfo.floor); bidFloor = (bidFloor == -1 ? mediaTypeFloor : Math.min(mediaTypeFloor, bidFloor)); } } diff --git a/modules/lifestreetBidAdapter.js b/modules/lifestreetBidAdapter.js index 5b5eb639fcf..16e17ac50b3 100644 --- a/modules/lifestreetBidAdapter.js +++ b/modules/lifestreetBidAdapter.js @@ -23,10 +23,10 @@ function boolToString(value) { */ function template(strings, ...keys) { return function(...values) { - let dict = values[values.length - 1] || {}; - let result = [strings[0]]; + const dict = values[values.length - 1] || {}; + const result = [strings[0]]; keys.forEach(function(key, i) { - let value = isInteger(key) ? values[key] : dict[key]; + const value = isInteger(key) ? values[key] : dict[key]; result.push(value, strings[i + 1]); }); return result.join(''); @@ -102,7 +102,7 @@ export const spec = { interpretResponse: (serverResponse, bidRequest) => { const bidResponses = []; - let response = serverResponse.body; + const response = serverResponse.body; if (!isResponseValid(response)) { return bidResponses; } diff --git a/modules/liveIntentAnalyticsAdapter.js b/modules/liveIntentAnalyticsAdapter.js index a86b6412f8d..f8c6b3ef2d8 100644 --- a/modules/liveIntentAnalyticsAdapter.js +++ b/modules/liveIntentAnalyticsAdapter.js @@ -17,7 +17,7 @@ const INTEGRATION_ID = '$$PREBID_GLOBAL$$'; let partnerIdFromUserIdConfig; let sendAuctionInitEvents; -let liAnalytics = Object.assign(adapter({URL, ANALYTICS_TYPE}), { +const liAnalytics = Object.assign(adapter({URL, ANALYTICS_TYPE}), { track({ eventType, args }) { switch (eventType) { case AUCTION_INIT: diff --git a/modules/livewrappedAnalyticsAdapter.js b/modules/livewrappedAnalyticsAdapter.js index b1c3e92b2f7..48da382febc 100644 --- a/modules/livewrappedAnalyticsAdapter.js +++ b/modules/livewrappedAnalyticsAdapter.js @@ -15,14 +15,14 @@ const TIMEOUTSENT = 8; const ADRENDERFAILEDSENT = 16; let initOptions; -let prebidGlobal = getGlobal(); +const prebidGlobal = getGlobal(); export const BID_WON_TIMEOUT = 500; const cache = { auctions: {} }; -let livewrappedAnalyticsAdapter = Object.assign(adapter({EMPTYURL, ANALYTICSTYPE}), { +const livewrappedAnalyticsAdapter = Object.assign(adapter({EMPTYURL, ANALYTICSTYPE}), { track({eventType, args}) { const time = timestamp(); logInfo('LIVEWRAPPED_EVENT:', [eventType, args]); @@ -40,14 +40,14 @@ let livewrappedAnalyticsAdapter = Object.assign(adapter({EMPTYURL, ANALYTICSTYPE cache.auctions[args.auctionId].gdprApplies = args.gdprConsent ? args.gdprConsent.gdprApplies : undefined; cache.auctions[args.auctionId].gdprConsent = args.gdprConsent ? args.gdprConsent.consentString : undefined; let lwFloor; - let container = document.getElementById(bidRequest.adUnitCode); + const container = document.getElementById(bidRequest.adUnitCode); let adUnitId = container ? container.getAttribute('data-adunitid') : undefined; adUnitId = adUnitId != null ? adUnitId : undefined; if (bidRequest.lwflr) { lwFloor = bidRequest.lwflr.flr; - let buyerFloor = bidRequest.lwflr.bflrs ? bidRequest.lwflr.bflrs[bidRequest.bidder] : undefined; + const buyerFloor = bidRequest.lwflr.bflrs ? bidRequest.lwflr.bflrs[bidRequest.bidder] : undefined; lwFloor = buyerFloor || lwFloor; } @@ -76,7 +76,7 @@ let livewrappedAnalyticsAdapter = Object.assign(adapter({EMPTYURL, ANALYTICSTYPE case EVENTS.BID_RESPONSE: logInfo('LIVEWRAPPED_BID_RESPONSE:', args); - let bidResponse = cache.auctions[args.auctionId].bids[args.requestId]; + const bidResponse = cache.auctions[args.auctionId].bids[args.requestId]; if (bidResponse.cpm > args.cpm) break; // For now we only store the highest bid bidResponse.isBid = true; bidResponse.width = args.width; @@ -105,7 +105,7 @@ let livewrappedAnalyticsAdapter = Object.assign(adapter({EMPTYURL, ANALYTICSTYPE case EVENTS.BIDDER_DONE: logInfo('LIVEWRAPPED_BIDDER_DONE:', args); args.bids.forEach(doneBid => { - let bid = cache.auctions[doneBid.auctionId].bids[doneBid.bidId || doneBid.requestId]; + const bid = cache.auctions[doneBid.auctionId].bids[doneBid.bidId || doneBid.requestId]; if (!bid.ttr) { bid.ttr = time - bid.start; } @@ -114,7 +114,7 @@ let livewrappedAnalyticsAdapter = Object.assign(adapter({EMPTYURL, ANALYTICSTYPE break; case EVENTS.BID_WON: logInfo('LIVEWRAPPED_BID_WON:', args); - let wonBid = cache.auctions[args.auctionId].bids[args.requestId]; + const wonBid = cache.auctions[args.auctionId].bids[args.requestId]; wonBid.won = true; wonBid.width = args.width; wonBid.height = args.height; @@ -131,7 +131,7 @@ let livewrappedAnalyticsAdapter = Object.assign(adapter({EMPTYURL, ANALYTICSTYPE break; case EVENTS.AD_RENDER_FAILED: logInfo('LIVEWRAPPED_AD_RENDER_FAILED:', args); - let adRenderFailedBid = cache.auctions[args.bid.auctionId].bids[args.bid.requestId]; + const adRenderFailedBid = cache.auctions[args.bid.auctionId].bids[args.bid.requestId]; adRenderFailedBid.adRenderFailed = true; adRenderFailedBid.reason = args.reason; adRenderFailedBid.message = args.message; @@ -201,12 +201,12 @@ function getSentRequests() { var auctionIds = []; Object.keys(cache.auctions).forEach(auctionId => { - let auction = cache.auctions[auctionId]; - let gdprPos = getGdprPos(gdpr, auction); - let auctionIdPos = getAuctionIdPos(auctionIds, auctionId); + const auction = cache.auctions[auctionId]; + const gdprPos = getGdprPos(gdpr, auction); + const auctionIdPos = getAuctionIdPos(auctionIds, auctionId); Object.keys(cache.auctions[auctionId].bids).forEach(bidId => { - let bid = auction.bids[bidId]; + const bid = auction.bids[bidId]; if (!(bid.sendStatus & REQUESTSENT)) { bid.sendStatus |= REQUESTSENT; @@ -234,14 +234,14 @@ function getResponses(gdpr, auctionIds) { Object.keys(cache.auctions).forEach(auctionId => { Object.keys(cache.auctions[auctionId].bids).forEach(bidId => { - let auction = cache.auctions[auctionId]; - let gdprPos = getGdprPos(gdpr, auction); - let auctionIdPos = getAuctionIdPos(auctionIds, auctionId) - let bid = auction.bids[bidId]; + const auction = cache.auctions[auctionId]; + const gdprPos = getGdprPos(gdpr, auction); + const auctionIdPos = getAuctionIdPos(auctionIds, auctionId) + const bid = auction.bids[bidId]; if (bid.readyToSend && !(bid.sendStatus & RESPONSESENT) && !bid.timeout) { bid.sendStatus |= RESPONSESENT; - let response = getResponseObject(auction, bid, gdprPos, auctionIdPos); + const response = getResponseObject(auction, bid, gdprPos, auctionIdPos); responses.push(response); } @@ -256,10 +256,10 @@ function getWins(gdpr, auctionIds) { Object.keys(cache.auctions).forEach(auctionId => { Object.keys(cache.auctions[auctionId].bids).forEach(bidId => { - let auction = cache.auctions[auctionId]; - let gdprPos = getGdprPos(gdpr, auction); - let auctionIdPos = getAuctionIdPos(auctionIds, auctionId); - let bid = auction.bids[bidId]; + const auction = cache.auctions[auctionId]; + const gdprPos = getGdprPos(gdpr, auction); + const auctionIdPos = getAuctionIdPos(auctionIds, auctionId); + const bid = auction.bids[bidId]; if (!(bid.sendStatus & WINSENT) && bid.won) { bid.sendStatus |= WINSENT; @@ -351,15 +351,15 @@ function getTimeouts(gdpr, auctionIds) { var timeouts = []; Object.keys(cache.auctions).forEach(auctionId => { - let auctionIdPos = getAuctionIdPos(auctionIds, auctionId); + const auctionIdPos = getAuctionIdPos(auctionIds, auctionId); Object.keys(cache.auctions[auctionId].bids).forEach(bidId => { - let auction = cache.auctions[auctionId]; - let gdprPos = getGdprPos(gdpr, auction); - let bid = auction.bids[bidId]; + const auction = cache.auctions[auctionId]; + const gdprPos = getGdprPos(gdpr, auction); + const bid = auction.bids[bidId]; if (!(bid.sendStatus & TIMEOUTSENT) && bid.timeout) { bid.sendStatus |= TIMEOUTSENT; - let timeout = getResponseObject(auction, bid, gdprPos, auctionIdPos); + const timeout = getResponseObject(auction, bid, gdprPos, auctionIdPos); timeouts.push(timeout); } @@ -373,10 +373,10 @@ function getAdRenderFailed(auctionIds) { var adRenderFails = []; Object.keys(cache.auctions).forEach(auctionId => { - let auctionIdPos = getAuctionIdPos(auctionIds, auctionId); + const auctionIdPos = getAuctionIdPos(auctionIds, auctionId); Object.keys(cache.auctions[auctionId].bids).forEach(bidId => { - let auction = cache.auctions[auctionId]; - let bid = auction.bids[bidId]; + const auction = cache.auctions[auctionId]; + const bid = auction.bids[bidId]; if (!(bid.sendStatus & ADRENDERFAILEDSENT) && bid.adRenderFailed) { bid.sendStatus |= ADRENDERFAILEDSENT; @@ -403,9 +403,9 @@ function getbidAdUnits() { var bidAdUnits = []; Object.keys(cache.auctions).forEach(auctionId => { - let auction = cache.auctions[auctionId]; + const auction = cache.auctions[auctionId]; Object.keys(auction.bidAdUnits).forEach(adUnit => { - let bidAdUnit = auction.bidAdUnits[adUnit]; + const bidAdUnit = auction.bidAdUnits[adUnit]; if (!bidAdUnit.sent) { bidAdUnit.sent = 1; diff --git a/modules/livewrappedBidAdapter.js b/modules/livewrappedBidAdapter.js index cdddfd688e9..1a3f05aff76 100644 --- a/modules/livewrappedBidAdapter.js +++ b/modules/livewrappedBidAdapter.js @@ -169,8 +169,8 @@ export const spec = { getUserSyncs: function(syncOptions, serverResponses) { if (serverResponses.length == 0) return []; - let syncList = []; - let userSync = serverResponses[0].body.pixels || []; + const syncList = []; + const userSync = serverResponses[0].body.pixels || []; userSync.forEach(function(sync) { if (syncOptions.pixelEnabled && sync.type == 'Redirect') { diff --git a/modules/lotamePanoramaIdSystem.js b/modules/lotamePanoramaIdSystem.js index 13cb19d9d93..61401b2c53e 100644 --- a/modules/lotamePanoramaIdSystem.js +++ b/modules/lotamePanoramaIdSystem.js @@ -40,7 +40,7 @@ const DO_NOT_HONOR_CONFIG = false; export const storage = getStorageManager({moduleType: MODULE_TYPE_UID, moduleName: MODULE_NAME}); let cookieDomain; -let appliedConfig = { +const appliedConfig = { name: 'lotamePanoramaId', storage: { type: 'cookie&html5', @@ -54,7 +54,7 @@ let appliedConfig = { */ function setProfileId(profileId) { if (cookiesAreEnabled()) { - let expirationDate = new Date(timestamp() + NINE_MONTHS_MS).toUTCString(); + const expirationDate = new Date(timestamp() + NINE_MONTHS_MS).toUTCString(); storage.setCookie( KEY_PROFILE, profileId, @@ -110,7 +110,7 @@ function saveLotameCache( expirationTimestamp = timestamp() + DAYS_TO_CACHE * DAY_MS ) { if (key && value) { - let expirationDate = new Date(expirationTimestamp).toUTCString(); + const expirationDate = new Date(expirationTimestamp).toUTCString(); if (cookiesAreEnabled()) { storage.setCookie( key, @@ -132,7 +132,7 @@ function saveLotameCache( * @param {Number} clientId */ function getLotameLocalCache(clientId = undefined) { - let cache = { + const cache = { data: getFromStorage(KEY_ID), expiryTimestampMs: 0, clientExpiryTimestampMs: 0, @@ -164,7 +164,7 @@ function getLotameLocalCache(clientId = undefined) { function clearLotameCache(key) { if (key) { if (cookiesAreEnabled(DO_NOT_HONOR_CONFIG)) { - let expirationDate = new Date(0).toUTCString(); + const expirationDate = new Date(0).toUTCString(); storage.setCookie( key, '', @@ -290,7 +290,7 @@ export const lotamePanoramaIdSubmodule = { } const resolveIdFunction = function (callback) { - let queryParams = {}; + const queryParams = {}; if (storedUserId) { queryParams.fp = storedUserId; } @@ -323,7 +323,7 @@ export const lotamePanoramaIdSubmodule = { let coreId; if (response) { try { - let responseObj = JSON.parse(response); + const responseObj = JSON.parse(response); const hasNoConsentErrors = !( isArray(responseObj.errors) && responseObj.errors.indexOf(MISSING_CORE_CONSENT) !== -1 diff --git a/modules/luceadBidAdapter.js b/modules/luceadBidAdapter.js index 703384b9e6d..bb8dfb8c2a3 100755 --- a/modules/luceadBidAdapter.js +++ b/modules/luceadBidAdapter.js @@ -152,7 +152,7 @@ function report(type, data) { function onBidWon(bid) { logInfo('Bid won', bid); - let data = { + const data = { bid_id: bid?.bidId, placement_id: bid.params ? (bid?.params[0]?.placementId || '0') : '0', spent: bid?.cpm, diff --git a/modules/luponmediaBidAdapter.js b/modules/luponmediaBidAdapter.js index 8d3ec123b42..2e22e10d1cd 100755 --- a/modules/luponmediaBidAdapter.js +++ b/modules/luponmediaBidAdapter.js @@ -105,7 +105,7 @@ export const spec = { return converter.fromORTB({response: response.body, request: request.data}).bids; }, getUserSyncs: function (syncOptions, responses) { - let allUserSyncs = []; + const allUserSyncs = []; if (hasSynced) { return allUserSyncs; @@ -126,7 +126,7 @@ export const spec = { const response = csResp.body.ext.usersyncs; const bidders = response.bidder_status; - for (let synci in bidders) { + for (const synci in bidders) { const thisSync = bidders[synci]; if (!thisSync.no_cookie) { diff --git a/modules/madvertiseBidAdapter.js b/modules/madvertiseBidAdapter.js index f2830a8ab9f..73cddf728c4 100644 --- a/modules/madvertiseBidAdapter.js +++ b/modules/madvertiseBidAdapter.js @@ -22,7 +22,7 @@ export const spec = { if (typeof bid.params !== 'object') { return false; } - let sizes = parseSizesInput(bid.sizes); + const sizes = parseSizesInput(bid.sizes); if (!sizes || sizes.length === 0) { return false; } @@ -80,7 +80,7 @@ export const spec = { return []; } - let bid = { + const bid = { requestId: bidRequest.bidId, cpm: responseObj.cpm, width: responseObj.Width, diff --git a/modules/magniteAnalyticsAdapter.js b/modules/magniteAnalyticsAdapter.js index e155a201350..4533a0b05ea 100644 --- a/modules/magniteAnalyticsAdapter.js +++ b/modules/magniteAnalyticsAdapter.js @@ -38,7 +38,7 @@ const DEFAULT_INTEGRATION = 'pbjs'; // List of known rubicon aliases // This gets updated on auction init to account for any custom aliases present -let rubiconAliases = ['rubicon']; +const rubiconAliases = ['rubicon']; const pbsErrorMap = { 1: 'timeout-error', @@ -55,7 +55,7 @@ let accountId; let endpoint; let cookieless; -let prebidGlobal = getGlobal(); +const prebidGlobal = getGlobal(); const { AUCTION_INIT, AUCTION_END, @@ -163,7 +163,7 @@ const sendEvent = payload => { } const sendAuctionEvent = (auctionId, trigger) => { - let auctionCache = cache.auctions[auctionId]; + const auctionCache = cache.auctions[auctionId]; const auctionEvent = formatAuction(auctionCache.auction); auctionCache.sent = true; @@ -183,7 +183,7 @@ const formatAuction = auction => { auctionEvent.adUnits = Object.entries(auctionEvent.adUnits).map(([tid, adUnit]) => { adUnit.bids = Object.entries(adUnit.bids).map(([bidId, bid]) => { // determine adUnit.status from its bid statuses. Use priority below to determine, higher index is better - let statusPriority = ['error', 'no-bid', 'success']; + const statusPriority = ['error', 'no-bid', 'success']; if (statusPriority.indexOf(bid.status) > statusPriority.indexOf(adUnit.status)) { adUnit.status = bid.status; } @@ -211,7 +211,7 @@ const isBillingEventValid = event => { } const formatBillingEvent = event => { - let billingEvent = deepClone(event); + const billingEvent = deepClone(event); // Pass along type if is string and not empty else general billingEvent.type = (typeof event.type === 'string' && event.type) || 'general'; billingEvent.accountId = accountId; @@ -254,7 +254,7 @@ const getBidPrice = bid => { export const parseBidResponse = (bid, previousBidResponse) => { // The current bidResponse for this matching requestId/bidRequestId - let responsePrice = getBidPrice(bid) + const responsePrice = getBidPrice(bid) // we need to compare it with the previous one (if there was one) log highest only // THIS WILL CHANGE WITH ALLOWING MULTIBID BETTER if (previousBidResponse && previousBidResponse.bidPriceUSD > responsePrice) { @@ -316,7 +316,7 @@ const addFloorData = floorData => { } const getTopLevelDetails = () => { - let payload = { + const payload = { channel: 'web', integration: rubiConf.int_type || DEFAULT_INTEGRATION, referrerUri: pageReferer, @@ -375,7 +375,7 @@ export const getHostNameFromReferer = referer => { }; const getRpaCookie = () => { - let encodedCookie = storage.getDataFromLocalStorage(COOKIE_NAME); + const encodedCookie = storage.getDataFromLocalStorage(COOKIE_NAME); if (encodedCookie) { try { return JSON.parse(window.atob(encodedCookie)); @@ -509,7 +509,7 @@ const getRenderingIds = bidWonData => { const gamHasRendered = deepAccess(cache, `auctions.${auction.auctionId}.gamRenders.${adUnit.transactionId}`); return adUnit.adUnitCode === bidWonData.adUnitCode && gamHasRendered; } - let { adUnit, auction } = findMatchingAdUnitFromAuctions(matchingFunction, false); + const { adUnit, auction } = findMatchingAdUnitFromAuctions(matchingFunction, false); // If no match was found, we will use the actual bid won auction id return { renderTransactionId: (adUnit && adUnit.transactionId) || bidWonData.transactionId, @@ -531,9 +531,9 @@ const formatBidWon = bidWonData => { }); // get the bid from the source auction id - let bid = deepAccess(cache, `auctions.${bidWonData.auctionId}.auction.adUnits.${bidWonData.transactionId}.bids.${bidWonData.requestId}`); - let adUnit = deepAccess(cache, `auctions.${bidWonData.auctionId}.auction.adUnits.${bidWonData.transactionId}`); - let bidWon = { + const bid = deepAccess(cache, `auctions.${bidWonData.auctionId}.auction.adUnits.${bidWonData.transactionId}.bids.${bidWonData.requestId}`); + const adUnit = deepAccess(cache, `auctions.${bidWonData.auctionId}.auction.adUnits.${bidWonData.transactionId}`); + const bidWon = { ...bid, sourceAuctionId: bidWonData.auctionId, renderAuctionId, @@ -582,7 +582,7 @@ const subscribeToGamSlots = () => { const gamHasRendered = deepAccess(cache, `auctions.${auction.auctionId}.gamRenders.${adUnit.transactionId}`); return matchesSlot && !gamHasRendered; } - let { adUnit, auction } = findMatchingAdUnitFromAuctions(matchingFunction, true); + const { adUnit, auction } = findMatchingAdUnitFromAuctions(matchingFunction, true); const slotName = `${event.slot.getAdUnitPath()} - ${event.slot.getSlotElementId()}`; @@ -633,7 +633,7 @@ const subscribeToGamSlots = () => { * @returns {string} lazily guessed browser name */ export const detectBrowserFromUa = userAgent => { - let normalizedUa = userAgent.toLowerCase(); + const normalizedUa = userAgent.toLowerCase(); if (normalizedUa.includes('edg')) { return 'Edge'; @@ -649,7 +649,7 @@ export const detectBrowserFromUa = userAgent => { return 'OTHER'; } -let magniteAdapter = adapter({ analyticsType: 'endpoint' }); +const magniteAdapter = adapter({ analyticsType: 'endpoint' }); magniteAdapter.originEnableAnalytics = magniteAdapter.enableAnalytics; function enableMgniAnalytics(config = {}) { @@ -730,7 +730,7 @@ const handleBidResponse = (args, bidStatus) => { // if this came from multibid, there might now be matching bid, so check // THIS logic will change when we support multibid per bid request if (!bid && args.originalRequestId) { - let ogBid = adUnit.bids[args.originalRequestId]; + const ogBid = adUnit.bids[args.originalRequestId]; // create new bid adUnit.bids[args.requestId] = { ...ogBid, @@ -807,7 +807,7 @@ magniteAdapter.track = ({ eventType, args }) => { pageReferer = deepAccess(args, 'bidderRequests.0.refererInfo.page'); // set auction level data - let auctionData = pick(args, [ + const auctionData = pick(args, [ 'auctionId', 'timestamp as auctionStart', 'timeout as clientTimeoutMillis', @@ -862,10 +862,10 @@ magniteAdapter.track = ({ eventType, args }) => { } // lets us keep a map of adunit and wether it had a gam or bid won render yet, used to track when to send events - let gamRenders = {}; + const gamRenders = {}; // adunits saved as map of transactionIds auctionData.adUnits = args.adUnits.reduce((adMap, adUnit) => { - let ad = pick(adUnit, [ + const ad = pick(adUnit, [ 'code as adUnitCode', 'transactionId', 'mediaTypes', mediaTypes => Object.keys(mediaTypes), @@ -935,7 +935,7 @@ magniteAdapter.track = ({ eventType, args }) => { const serverError = deepAccess(args, 'serverErrors.0'); const serverResponseTimeMs = args.serverResponseTimeMs; args.bids.forEach(bid => { - let cachedBid = deepAccess(cache, `auctions.${bid.auctionId}.auction.adUnits.${bid.transactionId}.bids.${bid.bidId}`); + const cachedBid = deepAccess(cache, `auctions.${bid.auctionId}.auction.adUnits.${bid.transactionId}.bids.${bid.bidId}`); if (typeof bid.serverResponseTimeMs !== 'undefined') { cachedBid.serverLatencyMillis = bid.serverResponseTimeMs; } else if (serverResponseTimeMs && bid.source === 's2s') { @@ -971,7 +971,7 @@ magniteAdapter.track = ({ eventType, args }) => { } break; case AUCTION_END: - let auctionCache = cache.auctions[args.auctionId]; + const auctionCache = cache.auctions[args.auctionId]; // if for some reason the auction did not do its normal thing, this could be undefied so bail if (!auctionCache) { break; @@ -996,7 +996,7 @@ magniteAdapter.track = ({ eventType, args }) => { break; case BID_TIMEOUT: args.forEach(badBid => { - let bid = deepAccess(cache, `auctions.${badBid.auctionId}.auction.adUnits.${badBid.transactionId}.bids.${badBid.bidId}`, {}); + const bid = deepAccess(cache, `auctions.${badBid.auctionId}.auction.adUnits.${badBid.transactionId}.bids.${badBid.bidId}`, {}); // might be set already by bidder-done, so do not overwrite if (bid.status !== 'error') { bid.status = 'error'; @@ -1049,7 +1049,7 @@ const handleNonBidEvent = function(seatnonbid, auctionId) { } const adUnits = auction.adUnits; seatnonbid.forEach(seatnonbid => { - let {seat} = seatnonbid; + const {seat} = seatnonbid; seatnonbid.nonbid.forEach(nonbid => { try { const {status, impid} = nonbid; @@ -1080,7 +1080,7 @@ const findTimeoutOptimization = (atag) => { return timeoutOpt; } const setAnalyticsTagData = (values, auction) => { - let data = { + const data = { name: values.scenario, rule: values.rule, value: values.tmax diff --git a/modules/malltvAnalyticsAdapter.js b/modules/malltvAnalyticsAdapter.js index b4fad0976fb..29936d18a0b 100644 --- a/modules/malltvAnalyticsAdapter.js +++ b/modules/malltvAnalyticsAdapter.js @@ -32,7 +32,7 @@ export const getCpmInEur = function (bid) { const analyticsOptions = {} export const parseBidderCode = function (bid) { - let bidderCode = bid.bidderCode || bid.bidder + const bidderCode = bid.bidderCode || bid.bidder return bidderCode.toLowerCase() } diff --git a/modules/malltvBidAdapter.js b/modules/malltvBidAdapter.js index 86db842267e..ef71f367142 100644 --- a/modules/malltvBidAdapter.js +++ b/modules/malltvBidAdapter.js @@ -48,10 +48,10 @@ export const spec = { let url = ''; let contents = []; let data = {}; - let auctionId = bidderRequest ? bidderRequest.auctionId : ''; + const auctionId = bidderRequest ? bidderRequest.auctionId : ''; let gdrpApplies = true; let gdprConsent = ''; - let placements = validBidRequests.map(bidRequest => { + const placements = validBidRequests.map(bidRequest => { if (!propertyId) { propertyId = bidRequest.params.propertyId; } if (!pageViewGuid && bidRequest.params) { pageViewGuid = bidRequest.params.pageViewGuid || ''; } if (!bidderRequestId) { bidderRequestId = bidRequest.bidderRequestId; } @@ -61,9 +61,9 @@ export const spec = { if (Object.keys(data).length === 0 && bidRequest.params.data && Object.keys(bidRequest.params.data).length !== 0) { data = bidRequest.params.data; } if (bidderRequest && bidRequest.gdprConsent) { gdrpApplies = bidderRequest.gdprConsent && bidderRequest.gdprConsent.gdprApplies ? bidderRequest.gdprConsent.gdprApplies : true; } if (bidderRequest && bidRequest.gdprConsent) { gdprConsent = bidderRequest.gdprConsent && bidderRequest.gdprConsent.consentString ? bidderRequest.gdprConsent.consentString : ''; } - let adUnitId = bidRequest.adUnitCode; - let placementId = bidRequest.params.placementId; - let sizes = generateSizeParam(bidRequest.sizes); + const adUnitId = bidRequest.adUnitCode; + const placementId = bidRequest.params.placementId; + const sizes = generateSizeParam(bidRequest.sizes); return { sizes: sizes, @@ -75,7 +75,7 @@ export const spec = { }; }); - let body = { + const body = { // TODO: fix auctionId leak: https://github.com/prebid/Prebid.js/issues/9781 auctionId: auctionId, propertyId: propertyId, diff --git a/modules/marsmediaBidAdapter.js b/modules/marsmediaBidAdapter.js index 8aab9c5c4a4..22ce08f52a8 100644 --- a/modules/marsmediaBidAdapter.js +++ b/modules/marsmediaBidAdapter.js @@ -11,13 +11,13 @@ function MarsmediaAdapter() { this.supportedMediaTypes = [VIDEO, BANNER]; this.gvlid = 776; - let SUPPORTED_VIDEO_PROTOCOLS = [2, 3, 5, 6]; - let SUPPORTED_VIDEO_MIMES = ['video/mp4']; - let SUPPORTED_VIDEO_PLAYBACK_METHODS = [1, 2, 3, 4]; - let SUPPORTED_VIDEO_DELIVERY = [1]; - let SUPPORTED_VIDEO_API = [1, 2, 5]; - let slotsToBids = {}; - let version = '2.5'; + const SUPPORTED_VIDEO_PROTOCOLS = [2, 3, 5, 6]; + const SUPPORTED_VIDEO_MIMES = ['video/mp4']; + const SUPPORTED_VIDEO_PLAYBACK_METHODS = [1, 2, 3, 4]; + const SUPPORTED_VIDEO_DELIVERY = [1]; + const SUPPORTED_VIDEO_API = [1, 2, 5]; + const slotsToBids = {}; + const version = '2.5'; this.isBidRequestValid = function (bid) { return !!(bid.params && bid.params.zoneId); @@ -44,7 +44,7 @@ function MarsmediaAdapter() { impObj.secure = isSecure; if (deepAccess(BRs[i], 'mediaTypes.banner') || deepAccess(BRs[i], 'mediaType') === 'banner') { - let banner = frameBanner(BRs[i]); + const banner = frameBanner(BRs[i]); if (banner) { impObj.banner = banner; } @@ -96,8 +96,8 @@ function MarsmediaAdapter() { } function getValidSizeSet(dimensionList) { - let w = parseInt(dimensionList[0]); - let h = parseInt(dimensionList[1]); + const w = parseInt(dimensionList[0]); + const h = parseInt(dimensionList[1]); // clever check for NaN if (! (w !== w || h !== h)) { // eslint-disable-line return [w, h]; @@ -189,7 +189,7 @@ function MarsmediaAdapter() { } function frameBid(BRs, bidderRequest) { - let bid = { + const bid = { id: BRs[0].bidderRequestId, imp: frameImp(BRs, bidderRequest), site: frameSite(bidderRequest), @@ -230,7 +230,7 @@ function MarsmediaAdapter() { } this.buildRequests = function (BRs, bidderRequest) { - let fallbackZoneId = getFirstParam('zoneId', BRs); + const fallbackZoneId = getFirstParam('zoneId', BRs); if (fallbackZoneId === undefined || BRs.length < 1) { return []; } @@ -275,11 +275,11 @@ function MarsmediaAdapter() { this.interpretResponse = function (serverResponse) { let responses = serverResponse.body || []; - let bids = []; + const bids = []; let i = 0; if (responses.seatbid) { - let temp = []; + const temp = []; for (i = 0; i < responses.seatbid.length; i++) { for (let j = 0; j < responses.seatbid[i].bid.length; j++) { temp.push(responses.seatbid[i].bid[j]); @@ -289,9 +289,9 @@ function MarsmediaAdapter() { } for (i = 0; i < responses.length; i++) { - let bid = responses[i]; - let bidRequest = slotsToBids[bid.impid]; - let bidResponse = { + const bid = responses[i]; + const bidRequest = slotsToBids[bid.impid]; + const bidResponse = { requestId: bidRequest.bidId, cpm: parseFloat(bid.price), width: bid.w, diff --git a/modules/mediaConsortiumBidAdapter.js b/modules/mediaConsortiumBidAdapter.js index a1cd6586735..c0ff1d70c3a 100644 --- a/modules/mediaConsortiumBidAdapter.js +++ b/modules/mediaConsortiumBidAdapter.js @@ -60,7 +60,7 @@ export const spec = { } } - let finalizedMediatypes = deepClone(mediaTypes) + const finalizedMediatypes = deepClone(mediaTypes) if (mediaTypes.video && mediaTypes.video.context !== OUTSTREAM) { logWarn(`Filtering video request for adUnitCode ${adUnitCode} because context is not ${OUTSTREAM}`) diff --git a/modules/mediaeyesBidAdapter.js b/modules/mediaeyesBidAdapter.js index 5c896d87a48..bb0808485fe 100644 --- a/modules/mediaeyesBidAdapter.js +++ b/modules/mediaeyesBidAdapter.js @@ -17,11 +17,11 @@ export const spec = { }, buildRequests: (bidRequests, bidderRequest) => { - let requests = []; + const requests = []; bidRequests.map(bidRequest => { - let {itemId} = bidRequest.params; - let requestData = { + const {itemId} = bidRequest.params; + const requestData = { id: generateUUID(), imp: [cookingImp(bidRequest)], device: bidRequest.ortb2?.device, @@ -38,17 +38,17 @@ export const spec = { }, interpretResponse: (serverResponse, serverRequest) => { - let response = serverResponse.body; + const response = serverResponse.body; if (!response.seatbid) { return []; } - let rtbBids = response.seatbid + const rtbBids = response.seatbid .map(seatbid => seatbid.bid) .reduce((a, b) => a.concat(b), []); - let data = rtbBids.map(rtbBid => { - let prBid = { + const data = rtbBids.map(rtbBid => { + const prBid = { requestId: rtbBid.impid, cpm: rtbBid.price, creativeId: rtbBid.crid, @@ -86,7 +86,7 @@ export const spec = { registerBidder(spec); function cookingImp(bidReq) { - let imp = {}; + const imp = {}; if (bidReq) { const bidfloor = getBidFloor(bidReq); if (bidfloor) { @@ -115,7 +115,7 @@ function getBidFloor(bidRequest) { let bidfloor = deepAccess(bidRequest, 'params.bidFloor', 0) if (!bidfloor && isFn(bidRequest.getFloor)) { - let floor = bidRequest.getFloor({ + const floor = bidRequest.getFloor({ currency: 'USD', mediaType: '*', size: '*' diff --git a/modules/mediaforceBidAdapter.js b/modules/mediaforceBidAdapter.js index ba7b8a8275e..32b3356b30c 100644 --- a/modules/mediaforceBidAdapter.js +++ b/modules/mediaforceBidAdapter.js @@ -151,10 +151,10 @@ export const spec = { let isTest = false; validBidRequests.forEach(bid => { isTest = isTest || bid.params.is_test; - let tagid = bid.params.placement_id; - let bidfloor = resolveFloor(bid); + const tagid = bid.params.placement_id; + const bidfloor = resolveFloor(bid); let validImp = false; - let impObj = { + const impObj = { id: bid.bidId, tagid: tagid, secure: window.location.protocol === 'https:' ? 1 : 0, @@ -318,8 +318,8 @@ function createBannerRequest(bid) { const sizes = bid.mediaTypes.banner.sizes; if (!sizes.length) return; - let format = []; - let r = parseGPTSingleSizeArrayToRtbSize(sizes[0]); + const format = []; + const r = parseGPTSingleSizeArrayToRtbSize(sizes[0]); for (let f = 1; f < sizes.length; f++) { format.push(parseGPTSingleSizeArrayToRtbSize(sizes[f])); } @@ -372,8 +372,8 @@ function createNativeRequest(bid) { } if (aRatios && aRatios[0]) { aRatios = aRatios[0]; - let wmin = aRatios.min_width || 0; - let hmin = aRatios.ratio_height * wmin / aRatios.ratio_width | 0; + const wmin = aRatios.min_width || 0; + const hmin = aRatios.ratio_height * wmin / aRatios.ratio_width | 0; assetObj.wmin = wmin; assetObj.hmin = hmin; } diff --git a/modules/mediafuseBidAdapter.js b/modules/mediafuseBidAdapter.js index 7339700312a..97388b9b63f 100644 --- a/modules/mediafuseBidAdapter.js +++ b/modules/mediafuseBidAdapter.js @@ -124,9 +124,9 @@ export const spec = { Object.keys(userObjBid.params.user) .filter(param => USER_PARAMS.includes(param)) .forEach((param) => { - let uparam = convertCamelToUnderscore(param); + const uparam = convertCamelToUnderscore(param); if (param === 'segments' && isArray(userObjBid.params.user[param])) { - let segs = []; + const segs = []; userObjBid.params.user[param].forEach(val => { if (isNumber(val)) { segs.push({'id': val}); @@ -159,7 +159,7 @@ export const spec = { } let debugObj = {}; - let debugObjParams = {}; + const debugObjParams = {}; const debugCookieName = 'apn_prebid_debug'; const debugCookie = storage.getCookie(debugCookieName) || null; @@ -217,7 +217,7 @@ export const spec = { payload.app = appIdObj; } - let mfKeywords = config.getConfig('mediafuseAuctionKeywords'); + const mfKeywords = config.getConfig('mediafuseAuctionKeywords'); payload.keywords = getANKeywordParam(bidderRequest?.ortb2, mfKeywords); if (config.getConfig('adpod.brandCategoryExclusion')) { @@ -237,9 +237,9 @@ export const spec = { }; if (bidderRequest.gdprConsent.addtlConsent && bidderRequest.gdprConsent.addtlConsent.indexOf('~') !== -1) { - let ac = bidderRequest.gdprConsent.addtlConsent; + const ac = bidderRequest.gdprConsent.addtlConsent; // pull only the ids from the string (after the ~) and convert them to an array of ints - let acStr = ac.substring(ac.indexOf('~') + 1); + const acStr = ac.substring(ac.indexOf('~') + 1); payload.gdpr_consent.addtl_consent = acStr.split('.').map(id => parseInt(id, 10)); } } @@ -249,7 +249,7 @@ export const spec = { } if (bidderRequest && bidderRequest.refererInfo) { - let refererinfo = { + const refererinfo = { // TODO: this collects everything it finds, except for canonicalUrl rd_ref: encodeURIComponent(bidderRequest.refererInfo.topmostLocation), rd_top: bidderRequest.refererInfo.reachedTop, @@ -270,11 +270,11 @@ export const spec = { } if (bidRequests[0].userIdAsEids?.length > 0) { - let eids = []; + const eids = []; bidRequests[0].userIdAsEids.forEach(eid => { if (!eid || !eid.uids || eid.uids.length < 1) { return; } eid.uids.forEach(uid => { - let tmp = {'source': eid.source, 'id': uid.id}; + const tmp = {'source': eid.source, 'id': uid.id}; if (eid.source == 'adserver.org') { tmp.rti_partner = 'TDID'; } else if (eid.source == 'uidapi.com') { @@ -328,7 +328,7 @@ export const spec = { } if (serverResponse.debug && serverResponse.debug.debug_info) { - let debugHeader = 'MediaFuse Debug Auction for Prebid\n\n' + const debugHeader = 'MediaFuse Debug Auction for Prebid\n\n' let debugText = debugHeader + serverResponse.debug.debug_info debugText = debugText .replace(/(|)/gm, '\t') // Tables @@ -366,17 +366,17 @@ export const spec = { }; function reloadViewabilityScriptWithCorrectParameters(bid) { - let viewJsPayload = getMediafuseViewabilityScriptFromJsTrackers(bid.native.javascriptTrackers); + const viewJsPayload = getMediafuseViewabilityScriptFromJsTrackers(bid.native.javascriptTrackers); if (viewJsPayload) { - let prebidParams = 'pbjs_adid=' + bid.adId + ';pbjs_auc=' + bid.adUnitCode; + const prebidParams = 'pbjs_adid=' + bid.adId + ';pbjs_auc=' + bid.adUnitCode; - let jsTrackerSrc = getViewabilityScriptUrlFromPayload(viewJsPayload); + const jsTrackerSrc = getViewabilityScriptUrlFromPayload(viewJsPayload); - let newJsTrackerSrc = jsTrackerSrc.replace('dom_id=%native_dom_id%', prebidParams); + const newJsTrackerSrc = jsTrackerSrc.replace('dom_id=%native_dom_id%', prebidParams); // find iframe containing script tag - let frameArray = document.getElementsByTagName('iframe'); + const frameArray = document.getElementsByTagName('iframe'); // boolean var to modify only one script. That way if there are muliple scripts, // they won't all point to the same creative. @@ -384,16 +384,16 @@ function reloadViewabilityScriptWithCorrectParameters(bid) { // first, loop on all ifames for (let i = 0; i < frameArray.length && !modifiedAScript; i++) { - let currentFrame = frameArray[i]; + const currentFrame = frameArray[i]; try { // IE-compatible, see https://stackoverflow.com/a/3999191/2112089 - let nestedDoc = currentFrame.contentDocument || currentFrame.contentWindow.document; + const nestedDoc = currentFrame.contentDocument || currentFrame.contentWindow.document; if (nestedDoc) { // if the doc is present, we look for our jstracker - let scriptArray = nestedDoc.getElementsByTagName('script'); + const scriptArray = nestedDoc.getElementsByTagName('script'); for (let j = 0; j < scriptArray.length && !modifiedAScript; j++) { - let currentScript = scriptArray[j]; + const currentScript = scriptArray[j]; if (currentScript.getAttribute('data-src') == jsTrackerSrc) { currentScript.setAttribute('src', newJsTrackerSrc); currentScript.setAttribute('data-src', ''); @@ -417,11 +417,11 @@ function reloadViewabilityScriptWithCorrectParameters(bid) { } function strIsMediafuseViewabilityScript(str) { - let regexMatchUrlStart = str.match(VIEWABILITY_URL_START); - let viewUrlStartInStr = regexMatchUrlStart != null && regexMatchUrlStart.length >= 1; + const regexMatchUrlStart = str.match(VIEWABILITY_URL_START); + const viewUrlStartInStr = regexMatchUrlStart != null && regexMatchUrlStart.length >= 1; - let regexMatchFileName = str.match(VIEWABILITY_FILE_NAME); - let fileNameInStr = regexMatchFileName != null && regexMatchFileName.length >= 1; + const regexMatchFileName = str.match(VIEWABILITY_FILE_NAME); + const fileNameInStr = regexMatchFileName != null && regexMatchFileName.length >= 1; return str.startsWith(SCRIPT_TAG_START) && fileNameInStr && viewUrlStartInStr; } @@ -432,7 +432,7 @@ function getMediafuseViewabilityScriptFromJsTrackers(jsTrackerArray) { viewJsPayload = jsTrackerArray; } else if (isArray(jsTrackerArray)) { for (let i = 0; i < jsTrackerArray.length; i++) { - let currentJsTracker = jsTrackerArray[i]; + const currentJsTracker = jsTrackerArray[i]; if (strIsMediafuseViewabilityScript(currentJsTracker)) { viewJsPayload = currentJsTracker; } @@ -444,15 +444,15 @@ function getMediafuseViewabilityScriptFromJsTrackers(jsTrackerArray) { function getViewabilityScriptUrlFromPayload(viewJsPayload) { // extracting the content of the src attribute // -> substring between src=" and " - let indexOfFirstQuote = viewJsPayload.indexOf('src="') + 5; // offset of 5: the length of 'src=' + 1 - let indexOfSecondQuote = viewJsPayload.indexOf('"', indexOfFirstQuote); - let jsTrackerSrc = viewJsPayload.substring(indexOfFirstQuote, indexOfSecondQuote); + const indexOfFirstQuote = viewJsPayload.indexOf('src="') + 5; // offset of 5: the length of 'src=' + 1 + const indexOfSecondQuote = viewJsPayload.indexOf('"', indexOfFirstQuote); + const jsTrackerSrc = viewJsPayload.substring(indexOfFirstQuote, indexOfSecondQuote); return jsTrackerSrc; } function formatRequest(payload, bidderRequest) { let request = []; - let options = { + const options = { withCredentials: true }; @@ -558,7 +558,7 @@ function newBid(serverBid, rtbBid, bidderRequest) { // temporary function; may remove at later date if/when adserver fully supports dchain function setupDChain(rtbBid) { - let dchain = { + const dchain = { ver: '1.0', complete: 0, nodes: [{ @@ -619,7 +619,7 @@ function newBid(serverBid, rtbBid, bidderRequest) { // setting up the jsTracker: // we put it as a data-src attribute so that the tracker isn't called // until we have the adId (see onBidWon) - let jsTrackerDisarmed = rtbBid.viewability.config.replace('src=', 'data-src='); + const jsTrackerDisarmed = rtbBid.viewability.config.replace('src=', 'data-src='); let jsTrackers = nativeAd.javascript_trackers; @@ -702,7 +702,7 @@ function bidToTag(bid) { tag.use_pmt_rule = bid.params.usePaymentRule || false; tag.prebid = true; tag.disable_psa = true; - let bidFloor = getBidFloor(bid); + const bidFloor = getBidFloor(bid); if (bidFloor) { tag.reserve = bidFloor; } @@ -733,7 +733,7 @@ function bidToTag(bid) { if (!isEmpty(bid.params.keywords)) { tag.keywords = getANKewyordParamFromMaps(bid.params.keywords); } - let gpid = deepAccess(bid, 'ortb2Imp.ext.gpid'); + const gpid = deepAccess(bid, 'ortb2Imp.ext.gpid'); if (gpid) { tag.gpid = gpid; } @@ -824,8 +824,8 @@ function bidToTag(bid) { case 'api': if (!tag['video_frameworks'] && isArray(videoMediaType[param])) { // need to read thru array; remove 6 (we don't support it), swap 4 <> 5 if found (to match our adserver mapping for these specific values) - let apiTmp = videoMediaType[param].map(val => { - let v = (val === 4) ? 5 : (val === 5) ? 4 : val; + const apiTmp = videoMediaType[param].map(val => { + const v = (val === 4) ? 5 : (val === 5) ? 4 : val; if (v >= 1 && v <= 5) { return v; @@ -859,7 +859,7 @@ function bidToTag(bid) { /* Turn bid request sizes into ut-compatible format */ function transformSizes(requestSizes) { - let sizes = []; + const sizes = []; let sizeObj = {}; if (isArray(requestSizes) && requestSizes.length === 2 && @@ -869,7 +869,7 @@ function transformSizes(requestSizes) { sizes.push(sizeObj); } else if (typeof requestSizes === 'object') { for (let i = 0; i < requestSizes.length; i++) { - let size = requestSizes[i]; + const size = requestSizes[i]; sizeObj = {}; sizeObj.width = parseInt(size[0], 10); sizeObj.height = parseInt(size[1], 10); @@ -938,7 +938,7 @@ function createAdPodRequest(tags, adPodBid) { const maxDuration = Math.max(...durationRangeSec); const tagToDuplicate = tags.filter(tag => tag.uuid === adPodBid.bidId); - let request = fill(...tagToDuplicate, numberOfPlacements); + const request = fill(...tagToDuplicate, numberOfPlacements); if (requireExactDuration) { const divider = Math.ceil(numberOfPlacements / durationRangeSec.length); @@ -1000,7 +1000,7 @@ function buildNativeRequest(params) { // convert the sizes of image/icon assets to proper format (if needed) const isImageAsset = !!(requestKey === NATIVE_MAPPING.image.serverName || requestKey === NATIVE_MAPPING.icon.serverName); if (isImageAsset && request[requestKey].sizes) { - let sizes = request[requestKey].sizes; + const sizes = request[requestKey].sizes; if (isArrayOfNums(sizes) || (isArray(sizes) && sizes.length > 0 && sizes.every(sz => isArrayOfNums(sz)))) { request[requestKey].sizes = transformSizes(request[requestKey].sizes); } @@ -1084,7 +1084,7 @@ function getBidFloor(bid) { return (bid.params.reserve) ? bid.params.reserve : null; } - let floor = bid.getFloor({ + const floor = bid.getFloor({ currency: 'USD', mediaType: '*', size: '*' diff --git a/modules/mediagoBidAdapter.js b/modules/mediagoBidAdapter.js index 6ac41251a03..7c1db69b869 100644 --- a/modules/mediagoBidAdapter.js +++ b/modules/mediagoBidAdapter.js @@ -32,8 +32,8 @@ const TIME_TO_LIVE = 500; const GVLID = 1020; // const ENDPOINT_URL = '/api/bid?tn='; export const storage = getStorageManager({bidderCode: BIDDER_CODE}); -let globals = {}; -let itemMaps = {}; +const globals = {}; +const itemMaps = {}; /* ----- mguid:start ------ */ export const COOKIE_KEY_MGUID = '__mguid_'; @@ -73,7 +73,7 @@ export const getPmgUID = () => { function getProperty(obj, ...keys) { let o = obj; - for (let key of keys) { + for (const key of keys) { // console.log(key, o); if (o && o[key]) { o = o[key]; @@ -120,13 +120,13 @@ function getItems(validBidRequests, bidderRequest) { let items = []; items = validBidRequests.map((req, i) => { let ret = {}; - let mediaTypes = getProperty(req, 'mediaTypes'); + const mediaTypes = getProperty(req, 'mediaTypes'); - let sizes = transformSizes(getProperty(req, 'sizes')); + const sizes = transformSizes(getProperty(req, 'sizes')); let matchSize; // 确认尺寸是否符合我们要求 - for (let size of sizes) { + for (const size of sizes) { matchSize = mediagoAdSize.find(item => size.width === item.w && size.height === item.h); if (matchSize) { break; @@ -156,7 +156,7 @@ function getItems(validBidRequests, bidderRequest) { // if (mediaTypes.native) {} // banner广告类型 if (mediaTypes.banner) { - let id = '' + (i + 1); + const id = '' + (i + 1); ret = { id: id, bidfloor: bidFloor, @@ -214,11 +214,11 @@ function getParam(validBidRequests, bidderRequest) { const cat = utils.deepAccess(bidderRequest, 'ortb2.site.cat'); reqTimes += 1; - let isMobile = getDevice() ? 1 : 0; + const isMobile = getDevice() ? 1 : 0; // input test status by Publisher. more frequently for test true req - let isTest = validBidRequests[0].params.test || 0; - let auctionId = getProperty(bidderRequest, 'auctionId'); - let items = getItems(validBidRequests, bidderRequest); + const isTest = validBidRequests[0].params.test || 0; + const auctionId = getProperty(bidderRequest, 'auctionId'); + const items = getItems(validBidRequests, bidderRequest); const domain = utils.deepAccess(bidderRequest, 'refererInfo.domain') || document.domain; const location = utils.deepAccess(bidderRequest, 'refererInfo.location'); @@ -232,7 +232,7 @@ function getParam(validBidRequests, bidderRequest) { const keywords = getPageKeywords(); if (items && items.length) { - let c = { + const c = { // TODO: fix auctionId leak: https://github.com/prebid/Prebid.js/issues/9781 id: 'mgprebidjs_' + auctionId, test: +isTest, @@ -323,7 +323,7 @@ export const spec = { * @return ServerRequest Info describing the request to the server. */ buildRequests: function (validBidRequests, bidderRequest) { - let payload = getParam(validBidRequests, bidderRequest); + const payload = getParam(validBidRequests, bidderRequest); const payloadString = JSON.stringify(payload); return { @@ -343,10 +343,10 @@ export const spec = { const cur = getProperty(serverResponse, 'body', 'cur'); const bidResponses = []; - for (let bid of bids) { - let impid = getProperty(bid, 'impid'); + for (const bid of bids) { + const impid = getProperty(bid, 'impid'); if (itemMaps[impid]) { - let bidId = getProperty(itemMaps[impid], 'req', 'bidId'); + const bidId = getProperty(itemMaps[impid], 'req', 'bidId'); const bidResponse = { requestId: bidId, cpm: getProperty(bid, 'price'), diff --git a/modules/mediaimpactBidAdapter.js b/modules/mediaimpactBidAdapter.js index a1f04a44142..bfd701001de 100644 --- a/modules/mediaimpactBidAdapter.js +++ b/modules/mediaimpactBidAdapter.js @@ -85,7 +85,7 @@ export const spec = { return syncs; } - let appendGdprParams = function (url, gdprParams) { + const appendGdprParams = function (url, gdprParams) { if (gdprParams === null) { return url; } @@ -105,7 +105,7 @@ export const spec = { serverResponses.forEach(resp => { if (resp.body) { Object.keys(resp.body).map(function(key, index) { - let respObject = resp.body[key]; + const respObject = resp.body[key]; if (respObject['syncs'] !== undefined && Array.isArray(respObject.syncs) && respObject.syncs.length > 0) { diff --git a/modules/mediakeysBidAdapter.js b/modules/mediakeysBidAdapter.js index f4979bea396..9b361e9cad1 100644 --- a/modules/mediakeysBidAdapter.js +++ b/modules/mediakeysBidAdapter.js @@ -151,7 +151,7 @@ function getFloor(bid, mediaType, size = '*') { function getHighestFloor(bid) { const floors = []; - for (let mediaType in bid.mediaTypes) { + for (const mediaType in bid.mediaTypes) { const floor = getFloor(bid, mediaType); if (isNumber(floor)) { @@ -212,7 +212,7 @@ function createOrtbTemplate() { * @returns {object} */ function createBannerImp(bid) { - let sizes = bid.mediaTypes.banner.sizes; + const sizes = bid.mediaTypes.banner.sizes; const params = deepAccess(bid, 'params', {}); if (!isArray(sizes) || !sizes.length) { @@ -301,7 +301,7 @@ function createNativeImp(bid) { nativeParams.title.len = 90; } - for (let key in nativeParams) { + for (const key in nativeParams) { if (nativeParams.hasOwnProperty(key)) { const internalNativeAsset = ((NATIVE_ASSETS_MAPPING) || []).find(ref => ref.name === key); if (!internalNativeAsset) { @@ -444,7 +444,7 @@ function createImp(bid) { } // Only supports proper mediaTypes definition… - for (let mediaType in bid.mediaTypes) { + for (const mediaType in bid.mediaTypes) { switch (mediaType) { case BANNER: const banner = createBannerImp(bid); @@ -610,7 +610,7 @@ export const spec = { deepSetValue(payload, 'source.tid', bidderRequest.ortb2.source?.tid); validBidRequests.forEach(validBid => { - let bid = deepClone(validBid); + const bid = deepClone(validBid); // No additional params atm. const imp = createImp(bid); diff --git a/modules/medianetAnalyticsAdapter.js b/modules/medianetAnalyticsAdapter.js index 7097cb7bf7c..a64cffb3ddb 100644 --- a/modules/medianetAnalyticsAdapter.js +++ b/modules/medianetAnalyticsAdapter.js @@ -165,7 +165,7 @@ function getQueryString(auctionObj, adUnitCode, logType, winningBidObj) { const commonParams = getCommonParams(auctionObj, adUnitCode, logType); const bidParams = getBidParams(auctionObj, adUnitCode, winningBidObj); const queryString = formatQS(commonParams); - let bidStrings = bidParams.map((bid) => `&${formatQS(bid)}`).join(''); + const bidStrings = bidParams.map((bid) => `&${formatQS(bid)}`).join(''); return `${queryString}${bidStrings}`; } @@ -520,7 +520,7 @@ function getDfpCurrencyInfo(bidResponse) { */ function getCommonParams(auctionObj, adUnitCode, logType) { const adSlotObj = auctionObj.adSlots[adUnitCode] || {}; - let commonParams = Object.assign( + const commonParams = Object.assign( { lgtp: logType }, pick(mnetGlobals.configuration, KeysMap.Log.Globals), pick(auctionObj, KeysMap.Log.Auction), @@ -836,7 +836,7 @@ const eventListeners = { [LoggingEvents.STALE_RENDER]: staleRenderHandler, }; -let medianetAnalytics = Object.assign(adapter({ analyticsType: 'endpoint' }), { +const medianetAnalytics = Object.assign(adapter({ analyticsType: 'endpoint' }), { getlogsQueue() { return mnetGlobals.logsQueue; }, diff --git a/modules/medianetBidAdapter.js b/modules/medianetBidAdapter.js index 9f2cf150d51..8ee8d4f4693 100644 --- a/modules/medianetBidAdapter.js +++ b/modules/medianetBidAdapter.js @@ -62,7 +62,7 @@ getGlobal().medianetGlobals = getGlobal().medianetGlobals || {}; function siteDetails(site, bidderRequest) { const urlData = bidderRequest.refererInfo; site = site || {}; - let siteData = { + const siteData = { domain: site.domain || urlData.domain, page: site.page || urlData.page, ref: getTopWindowReferrer(site.ref), @@ -79,7 +79,7 @@ function getPageMeta() { if (pageMeta) { return pageMeta; } - let canonicalUrl = getUrlFromSelector('link[rel="canonical"]', 'href'); + const canonicalUrl = getUrlFromSelector('link[rel="canonical"]', 'href'); pageMeta = Object.assign({}, canonicalUrl && { 'canonical_url': canonicalUrl }, @@ -89,14 +89,14 @@ function getPageMeta() { } function getUrlFromSelector(selector, attribute) { - let attr = getAttributeFromSelector(selector, attribute); + const attr = getAttributeFromSelector(selector, attribute); return attr && getAbsoluteUrl(attr); } function getAttributeFromSelector(selector, attribute) { try { - let doc = getWindowTop().document; - let element = doc.querySelector(selector); + const doc = getWindowTop().document; + const element = doc.querySelector(selector); if (element !== null && element[attribute]) { return element[attribute]; } @@ -104,7 +104,7 @@ function getAttributeFromSelector(selector, attribute) { } function getAbsoluteUrl(url) { - let aTag = getWindowTop().document.createElement('a'); + const aTag = getWindowTop().document.createElement('a'); aTag.href = url; return aTag.href; @@ -143,7 +143,7 @@ function getCoordinates(adUnitCode) { } if (element) { const rect = getBoundingClientRect(element); - let coordinates = {}; + const coordinates = {}; coordinates.top_left = { y: rect.top, x: rect.left @@ -191,7 +191,7 @@ function extParams(bidRequest, bidderRequests) { function slotParams(bidRequest, bidderRequests) { // check with Media.net Account manager for bid floor and crid parameters - let params = { + const params = { id: bidRequest.bidId, transactionId: bidRequest.ortb2Imp?.ext?.tid, ext: { @@ -205,7 +205,7 @@ function slotParams(bidRequest, bidderRequests) { params.ortb2Imp = bidRequest.ortb2Imp; } - let bannerSizes = deepAccess(bidRequest, 'mediaTypes.banner.sizes') || []; + const bannerSizes = deepAccess(bidRequest, 'mediaTypes.banner.sizes') || []; const videoInMediaType = deepAccess(bidRequest, 'mediaTypes.video') || {}; const videoInParams = deepAccess(bidRequest, 'params.video') || {}; @@ -230,13 +230,13 @@ function slotParams(bidRequest, bidderRequests) { params.tagid = bidRequest.params.crid.toString(); } - let bidFloor = parseFloat(bidRequest.params.bidfloor || bidRequest.params.bidFloor); + const bidFloor = parseFloat(bidRequest.params.bidfloor || bidRequest.params.bidFloor); if (bidFloor) { params.bidfloor = bidFloor; } const coordinates = getCoordinates(bidRequest.adUnitCode); if (coordinates && params.banner && params.banner.length !== 0) { - let normCoordinates = normalizeCoordinates(coordinates); + const normCoordinates = normalizeCoordinates(coordinates); params.ext.coordinates = normCoordinates; params.ext.viewability = getSlotVisibility(coordinates.top_left, getMinSize(params.banner)); if (getSlotVisibility(normCoordinates.top_left, getMinSize(params.banner)) > 0.5) { @@ -258,7 +258,7 @@ function slotParams(bidRequest, bidderRequests) { } function getBidFloorByType(bidRequest) { - let floorInfo = []; + const floorInfo = []; if (typeof bidRequest.getFloor === 'function') { [BANNER, VIDEO, NATIVE].forEach(mediaType => { if (bidRequest.mediaTypes.hasOwnProperty(mediaType)) { @@ -277,7 +277,7 @@ function getBidFloorByType(bidRequest) { return floorInfo; } function setFloorInfo(bidRequest, mediaType, size, floorInfo) { - let floor = bidRequest.getFloor({currency: 'USD', mediaType: mediaType, size: size}) || {}; + const floor = bidRequest.getFloor({currency: 'USD', mediaType: mediaType, size: size}) || {}; if (size.length > 1) floor.size = size; floor.mediaType = mediaType; floorInfo.push(floor); @@ -287,9 +287,9 @@ function getMinSize(sizes) { } function getSlotVisibility(topLeft, size) { - let maxArea = size.w * size.h; - let windowSize = spec.getWindowSize(); - let bottomRight = { + const maxArea = size.w * size.h; + const windowSize = spec.getWindowSize(); + const bottomRight = { x: topLeft.x + size.w, y: topLeft.y + size.h }; @@ -382,7 +382,7 @@ function getLoggingData(bids) { bids = []; } bids.forEach((bid) => { - let bidData = getBidData(bid); + const bidData = getBidData(bid); Object.keys(bidData).forEach((key) => { logData[key] = logData[key] || []; logData[key].push(encodeURIComponent(bidData[key])); @@ -473,7 +473,7 @@ export const spec = { // convert Native ORTB definition to old-style prebid native definition bidRequests = convertOrtbRequestToProprietaryNative(bidRequests); - let payload = generatePayload(bidRequests, bidderRequests); + const payload = generatePayload(bidRequests, bidderRequests); return { method: 'POST', url: getBidderURL(bidderRequests.bidderCode, payload.ext.customer_id), @@ -493,7 +493,7 @@ export const spec = { logInfo(`${BIDDER_CODE} : response is empty`); return validBids; } - let bids = serverResponse.body.bidList; + const bids = serverResponse.body.bidList; if (!isArray(bids) || bids.length === 0) { logInfo(`${BIDDER_CODE} : no bids`); } else { @@ -514,7 +514,7 @@ export const spec = { } }, getUserSyncs: function(syncOptions, serverResponses) { - let cookieSyncUrls = fetchCookieSyncUrls(serverResponses); + const cookieSyncUrls = fetchCookieSyncUrls(serverResponses); if (syncOptions.iframeEnabled) { return filterBidsListByFilters(cookieSyncUrls, {type: 'iframe'}); @@ -530,7 +530,7 @@ export const spec = { */ onTimeout: (timeoutData) => { try { - let eventData = { + const eventData = { name: EVENTS.TIMEOUT_EVENT_NAME, value: timeoutData.length, relatedData: timeoutData[0].timeout || config.getConfig('bidderTimeout') @@ -544,7 +544,7 @@ export const spec = { */ onBidWon: (bid) => { try { - let eventData = { + const eventData = { name: EVENTS.BID_WON_EVENT_NAME, value: bid.cpm }; @@ -554,7 +554,7 @@ export const spec = { onSetTargeting: (bid) => { try { - let eventData = { + const eventData = { name: EVENTS.SET_TARGETING, value: bid.cpm }; @@ -567,7 +567,7 @@ export const spec = { onBidderError: ({error, bidderRequest}) => { try { - let eventData = { + const eventData = { name: EVENTS.BIDDER_ERROR, relatedData: `timedOut:${error.timedOut}|status:${error.status}|message:${error.reason.message}` }; diff --git a/modules/medianetRtdProvider.js b/modules/medianetRtdProvider.js index 2f5f1749dd2..a9a0bb47d63 100644 --- a/modules/medianetRtdProvider.js +++ b/modules/medianetRtdProvider.js @@ -33,7 +33,7 @@ function init(config) { function getBidRequestData(requestBidsProps, callback, config, userConsent) { executeCommand(() => { - let adUnits = getAdUnits(requestBidsProps.adUnits, requestBidsProps.adUnitCodes); + const adUnits = getAdUnits(requestBidsProps.adUnits, requestBidsProps.adUnitCodes); const request = window.mnjs.onPrebidRequestBid({requestBidsProps, config, userConsent}); if (!request) { callback(); diff --git a/modules/mediasniperBidAdapter.js b/modules/mediasniperBidAdapter.js index 796a15e1778..eaf8e0606b2 100644 --- a/modules/mediasniperBidAdapter.js +++ b/modules/mediasniperBidAdapter.js @@ -62,7 +62,7 @@ export const spec = { deepSetValue(payload, 'id', bidderRequest.bidderRequestId); validBidRequests.forEach((validBid) => { - let bid = deepClone(validBid); + const bid = deepClone(validBid); const imp = createImp(bid); payload.imp.push(imp); @@ -211,7 +211,7 @@ function createImp(bid) { } // Only supports proper mediaTypes definition… - for (let mediaType in bid.mediaTypes) { + for (const mediaType in bid.mediaTypes) { switch (mediaType) { case BANNER: imp.banner = createBannerImp(bid); @@ -271,7 +271,7 @@ function getFloor(bid, mediaType, size = '*') { function getMinFloor(bid) { const floors = []; - for (let mediaType in bid.mediaTypes) { + for (const mediaType in bid.mediaTypes) { const floor = getFloor(bid, mediaType); if (isNumber(floor)) { @@ -295,7 +295,7 @@ function getMinFloor(bid) { * @returns {object} */ function createBannerImp(bid) { - let sizes = bid.mediaTypes.banner.sizes; + const sizes = bid.mediaTypes.banner.sizes; const params = deepAccess(bid, 'params', {}); const banner = {}; diff --git a/modules/mediasquareBidAdapter.js b/modules/mediasquareBidAdapter.js index d75cf18e729..c6596a42465 100644 --- a/modules/mediasquareBidAdapter.js +++ b/modules/mediasquareBidAdapter.js @@ -48,13 +48,13 @@ export const spec = { // convert Native ORTB definition to old-style prebid native definition validBidRequests = convertOrtbRequestToProprietaryNative(validBidRequests); - let codes = []; - let endpoint = document.location.search.match(/msq_test=true/) ? BIDDER_URL_TEST : BIDDER_URL_PROD; + const codes = []; + const endpoint = document.location.search.match(/msq_test=true/) ? BIDDER_URL_TEST : BIDDER_URL_PROD; const test = config.getConfig('debug') ? 1 : 0; let adunitValue = null; Object.keys(validBidRequests).forEach(key => { adunitValue = validBidRequests[key]; - let code = { + const code = { owner: adunitValue.params.owner, code: adunitValue.params.code, adunit: adunitValue.adUnitCode, @@ -65,11 +65,11 @@ export const spec = { if (typeof adunitValue.getFloor === 'function') { if (Array.isArray(adunitValue.sizes)) { adunitValue.sizes.forEach(value => { - let tmpFloor = adunitValue.getFloor({currency: 'USD', mediaType: '*', size: value}); + const tmpFloor = adunitValue.getFloor({currency: 'USD', mediaType: '*', size: value}); if (tmpFloor != {}) { code.floor[value.join('x')] = tmpFloor; } }); } - let tmpFloor = adunitValue.getFloor({currency: 'USD', mediaType: '*', size: '*'}); + const tmpFloor = adunitValue.getFloor({currency: 'USD', mediaType: '*', size: '*'}); if (tmpFloor != {}) { code.floor['*'] = tmpFloor; } } if (adunitValue.ortb2Imp) { code.ortb2Imp = adunitValue.ortb2Imp } @@ -133,7 +133,7 @@ export const spec = { } }; if ('dsa' in value) { bidResponse.meta.dsa = value['dsa']; } - let paramsToSearchFor = ['bidder', 'code', 'match', 'hasConsent', 'context', 'increment', 'ova']; + const paramsToSearchFor = ['bidder', 'code', 'match', 'hasConsent', 'context', 'increment', 'ova']; paramsToSearchFor.forEach(param => { if (param in value) { bidResponse['mediasquare'][param] = value[param]; @@ -180,8 +180,8 @@ export const spec = { if (bid.hasOwnProperty('mediaType') && bid.mediaType == 'video') { return; } - let params = { pbjs: '$prebid.version$', referer: encodeURIComponent(getRefererInfo().page || getRefererInfo().topmostLocation) }; - let endpoint = document.location.search.match(/msq_test=true/) ? BIDDER_URL_TEST : BIDDER_URL_PROD; + const params = { pbjs: '$prebid.version$', referer: encodeURIComponent(getRefererInfo().page || getRefererInfo().topmostLocation) }; + const endpoint = document.location.search.match(/msq_test=true/) ? BIDDER_URL_TEST : BIDDER_URL_PROD; let paramsToSearchFor = ['bidder', 'code', 'match', 'hasConsent', 'context', 'increment', 'ova']; if (bid.hasOwnProperty('mediasquare')) { paramsToSearchFor.forEach(param => { diff --git a/modules/merkleIdSystem.js b/modules/merkleIdSystem.js index 86bb0ed7230..cc4bfbf5e98 100644 --- a/modules/merkleIdSystem.js +++ b/modules/merkleIdSystem.js @@ -36,7 +36,7 @@ function getSession(configParams) { } function setCookie(name, value, expires) { - let expTime = new Date(); + const expTime = new Date(); expTime.setTime(expTime.getTime() + expires * 1000 * 60); storage.setCookie(name, value, expTime.toUTCString(), 'Lax'); } diff --git a/modules/mgidBidAdapter.js b/modules/mgidBidAdapter.js index 7a0856a2859..693312c6cb6 100644 --- a/modules/mgidBidAdapter.js +++ b/modules/mgidBidAdapter.js @@ -81,8 +81,8 @@ const NATIVE_MINIMUM_REQUIRED_IMAGE_ASSETS = [ required: true, } ]; -let _NATIVE_ASSET_ID_TO_KEY_MAP = {}; -let _NATIVE_ASSET_KEY_TO_ASSET_MAP = {}; +const _NATIVE_ASSET_ID_TO_KEY_MAP = {}; +const _NATIVE_ASSET_KEY_TO_ASSET_MAP = {}; // loading _NATIVE_ASSET_ID_TO_KEY_MAP _each(NATIVE_ASSETS, anAsset => { _NATIVE_ASSET_ID_TO_KEY_MAP[anAsset.ID] = anAsset.KEY }); @@ -111,8 +111,8 @@ export const spec = { const nativeParams = deepAccess(bid, 'nativeParams'); let assetsCount = 0; if (isPlainObject(nativeParams)) { - for (let k in nativeParams) { - let v = nativeParams[k]; + for (const k in nativeParams) { + const v = nativeParams[k]; const supportProp = spec.NATIVE_ASSET_KEY_TO_ASSET_MAP.hasOwnProperty(k); if (supportProp) { assetsCount++; @@ -133,8 +133,8 @@ export const spec = { bannerOk = sizes[f].length === 2; } } - let acc = Number(bid.params.accountId); - let plcmt = Number(bid.params.placementId); + const acc = Number(bid.params.accountId); + const plcmt = Number(bid.params.placementId); return (bannerOk || nativeOk) && isPlainObject(bid.params) && !!bid.adUnitCode && isStr(bid.adUnitCode) && (plcmt > 0 ? bid.params.placementId.toString().search(spec.reId) === 0 : true) && !!acc && acc > 0 && bid.params.accountId.toString().search(spec.reId) === 0; }, @@ -162,11 +162,11 @@ export const spec = { } const cur = setOnAny(validBidRequests, 'params.currency') || setOnAny(validBidRequests, 'params.cur') || getCurrencyFromBidderRequest(bidderRequest) || DEFAULT_CUR; const secure = window.location.protocol === 'https:' ? 1 : 0; - let imp = []; + const imp = []; validBidRequests.forEach(bid => { let tagid = deepAccess(bid, 'params.placementId') || 0; tagid = !tagid ? bid.adUnitCode : tagid + '/' + bid.adUnitCode; - let impObj = { + const impObj = { id: bid.bidId, tagid, secure, @@ -180,7 +180,7 @@ export const spec = { if (floorData.cur) { impObj.bidfloorcur = floorData.cur; } - for (let mediaTypes in bid.mediaTypes) { + for (const mediaTypes in bid.mediaTypes) { switch (mediaTypes) { case BANNER: impObj.banner = createBannerRequest(bid); @@ -205,7 +205,7 @@ export const spec = { const ortb2Data = bidderRequest?.ortb2 || {}; - let request = { + const request = { id: deepAccess(bidderRequest, 'bidderRequestId'), site: ortb2Data?.site || {}, cur: [cur], @@ -450,7 +450,7 @@ function setLocalStorageSafely(key, val) { function createBannerRequest(bid) { const sizes = deepAccess(bid, 'mediaTypes.banner.sizes'); - let format = []; + const format = []; if (sizes.length > 1) { for (let f = 0; f < sizes.length; f++) { if (sizes[f].length === 2) { @@ -458,7 +458,7 @@ function createBannerRequest(bid) { } } } - let r = { + const r = { w: sizes && sizes[0][0], h: sizes && sizes[0][1], }; @@ -473,11 +473,11 @@ function createBannerRequest(bid) { } function createNativeRequest(params) { - let nativeRequestObject = { + const nativeRequestObject = { plcmtcnt: 1, assets: [] }; - for (let key in params) { + for (const key in params) { let assetObj = {}; if (params.hasOwnProperty(key)) { if (!(nativeRequestObject.assets && nativeRequestObject.assets.length > 0 && nativeRequestObject.assets.hasOwnProperty(key))) { @@ -560,10 +560,10 @@ function createNativeRequest(params) { // for native image adtype prebid has to have few required assests i.e. title,sponsoredBy, image // if any of these are missing from the request then request will not be sent - let requiredAssetCount = NATIVE_MINIMUM_REQUIRED_IMAGE_ASSETS.length; + const requiredAssetCount = NATIVE_MINIMUM_REQUIRED_IMAGE_ASSETS.length; let presentrequiredAssetCount = 0; NATIVE_MINIMUM_REQUIRED_IMAGE_ASSETS.forEach(ele => { - let lengthOfExistingAssets = nativeRequestObject.assets.length; + const lengthOfExistingAssets = nativeRequestObject.assets.length; for (let i = 0; i < lengthOfExistingAssets; i++) { if (ele.id === nativeRequestObject.assets[i].id) { presentrequiredAssetCount++; diff --git a/modules/mgidRtdProvider.js b/modules/mgidRtdProvider.js index 059be4e9103..1ba75d3c343 100644 --- a/modules/mgidRtdProvider.js +++ b/modules/mgidRtdProvider.js @@ -142,10 +142,10 @@ function getContextUrl() { } function getDataForMerge(responseData) { - let siteData = { + const siteData = { name: ORTB2_NAME }; - let userData = { + const userData = { name: ORTB2_NAME }; @@ -167,7 +167,7 @@ function getDataForMerge(responseData) { } } - let result = {}; + const result = {}; if (siteData.segment || siteData.ext) { result.site = { content: { diff --git a/modules/michaoBidAdapter.ts b/modules/michaoBidAdapter.ts index 28c489d3429..57a2ee73e59 100644 --- a/modules/michaoBidAdapter.ts +++ b/modules/michaoBidAdapter.ts @@ -73,7 +73,7 @@ export const spec: BidderSpec = { const bidRequests = []; validBidRequests.forEach((validBidRequest) => { - let bidRequestEachFormat = []; + const bidRequestEachFormat = []; if (validBidRequest.mediaTypes?.banner) { bidRequestEachFormat.push({ diff --git a/modules/microadBidAdapter.js b/modules/microadBidAdapter.js index c9a69028044..4e292afebd2 100644 --- a/modules/microadBidAdapter.js +++ b/modules/microadBidAdapter.js @@ -9,7 +9,7 @@ const ENDPOINT_URLS = { 'production': 'https://s-rtb-pb.send.microad.jp/prebid', 'test': 'https://rtbtest.send.microad.jp/prebid' }; -export let ENVIRONMENT = 'production'; +export const ENVIRONMENT = 'production'; /* eslint-disable no-template-curly-in-string */ const EXT_URL_STRING = '${COMPASS_EXT_URL}'; diff --git a/modules/mobilefuseBidAdapter.js b/modules/mobilefuseBidAdapter.js index 73a2573992c..3d24a6b436a 100644 --- a/modules/mobilefuseBidAdapter.js +++ b/modules/mobilefuseBidAdapter.js @@ -132,7 +132,7 @@ function getBidfloor(bidRequest) { return null; } - let floor = bidRequest.getFloor(); + const floor = bidRequest.getFloor(); if (floor.currency === 'USD') { return floor.floor; } diff --git a/modules/mobkoiAnalyticsAdapter.js b/modules/mobkoiAnalyticsAdapter.js index 93913c19d64..8e24c421cec 100644 --- a/modules/mobkoiAnalyticsAdapter.js +++ b/modules/mobkoiAnalyticsAdapter.js @@ -200,7 +200,7 @@ export class LocalContext { /** * Create a new context object and return it. */ - let newBidContext = new BidContext({ + const newBidContext = new BidContext({ localContext: this, prebidOrOrtbBidResponse: bid, }); @@ -465,7 +465,7 @@ function pickKeyFields(objType, eventArgs) { } } -let mobkoiAnalytics = Object.assign(adapter({analyticsType}), { +const mobkoiAnalytics = Object.assign(adapter({analyticsType}), { localContext: new LocalContext(), async track({ eventType, diff --git a/modules/multibid/index.ts b/modules/multibid/index.ts index 1cd68759bfd..00a9bc832ac 100644 --- a/modules/multibid/index.ts +++ b/modules/multibid/index.ts @@ -82,7 +82,7 @@ config.getConfig(MODULE_NAME, conf => { */ export function validateMultibid(conf) { let check = true; - let duplicate = conf.filter(entry => { + const duplicate = conf.filter(entry => { // Check if entry.bidder is not defined or typeof string, filter entry and reset configuration if ((!entry.bidder || typeof entry.bidder !== 'string') && (!entry.bidders || !Array.isArray(entry.bidders))) { logWarn('Filtering multibid entry. Missing required bidder or bidders property.'); @@ -143,7 +143,7 @@ declare module '../../src/bidfactory' { * @param {Object} bid object */ export const addBidResponseHook = timedBidResponseHook('multibid', function addBidResponseHook(fn, adUnitCode, bid, reject) { - let floor = deepAccess(bid, 'floorData.floorValue'); + const floor = deepAccess(bid, 'floorData.floorValue'); if (!config.getConfig('multibid')) resetMultiConfig(); // Checks if multiconfig exists and bid bidderCode exists within config and is an adpod bid @@ -165,7 +165,7 @@ export const addBidResponseHook = timedBidResponseHook('multibid', function addB bid.requestId = getUniqueIdentifierStr(); multibidUnits[adUnitCode][bid.bidderCode].ads.push(bid); - let length = multibidUnits[adUnitCode][bid.bidderCode].ads.length; + const length = multibidUnits[adUnitCode][bid.bidderCode].ads.length; if (multiConfig[bid.bidderCode].prefix) bid.targetingBidder = multiConfig[bid.bidderCode].prefix + length; if (length === multiConfig[bid.bidderCode].maxbids) multibidUnits[adUnitCode][bid.bidderCode].maxReached = true; @@ -215,13 +215,13 @@ export function targetBidPoolHook(fn, bidsReceived, highestCpmCallback, adUnitBi if (!config.getConfig('multibid')) resetMultiConfig(); if (hasMultibid) { const dealPrioritization = config.getConfig('sendBidsControl.dealPrioritization'); - let modifiedBids = []; - let buckets = groupBy(bidsReceived, 'adUnitCode'); - let bids = [].concat(...Object.keys(buckets).reduce((result, slotId) => { + const modifiedBids = []; + const buckets = groupBy(bidsReceived, 'adUnitCode'); + const bids = [].concat(...Object.keys(buckets).reduce((result, slotId) => { let bucketBids = []; // Get bids and group by property originalBidder - let bidsByBidderName = groupBy(buckets[slotId], 'originalBidder'); - let adjustedBids = [].concat(...Object.keys(bidsByBidderName).map(key => { + const bidsByBidderName = groupBy(buckets[slotId], 'originalBidder'); + const adjustedBids = [].concat(...Object.keys(bidsByBidderName).map(key => { // Reset all bidderCodes to original bidder values and sort by CPM return bidsByBidderName[key].sort((bidA, bidB) => { if (bidA.originalBidder && bidA.originalBidder !== bidA.bidderCode) bidA.bidderCode = bidA.originalBidder; @@ -237,7 +237,7 @@ export function targetBidPoolHook(fn, bidsReceived, highestCpmCallback, adUnitBi }) })); // Get adjustedBids by bidderCode and reduce using highestCpmCallback - let bidsByBidderCode = groupBy(adjustedBids, 'bidderCode'); + const bidsByBidderCode = groupBy(adjustedBids, 'bidderCode'); Object.keys(bidsByBidderCode).forEach(key => bucketBids.push(bidsByBidderCode[key].reduce(highestCpmCallback))); // if adUnitBidLimit is set, pass top N number bids if (adUnitBidLimit > 0) { diff --git a/modules/mwOpenLinkIdSystem.js b/modules/mwOpenLinkIdSystem.js index e2781601ab7..f638f955fd0 100644 --- a/modules/mwOpenLinkIdSystem.js +++ b/modules/mwOpenLinkIdSystem.js @@ -58,7 +58,7 @@ function deserializeMwOlId(mwOlIdStr) { } function serializeMwOlId(mwOlId) { - let components = []; + const components = []; if (mwOlId.eid) { components.push('eid:' + mwOlId.eid); diff --git a/modules/my6senseBidAdapter.js b/modules/my6senseBidAdapter.js index 22683460405..043b88c4d9c 100644 --- a/modules/my6senseBidAdapter.js +++ b/modules/my6senseBidAdapter.js @@ -123,7 +123,7 @@ function buildRequests(validBidRequests, bidderRequest) { // convert Native ORTB definition to old-style prebid native definition validBidRequests = convertOrtbRequestToProprietaryNative(validBidRequests); - let requests = []; + const requests = []; if (validBidRequests && validBidRequests.length) { validBidRequests.forEach(bidRequest => { @@ -132,7 +132,7 @@ function buildRequests(validBidRequests, bidderRequest) { let debug = false; if (bidRequest.params) { - for (let key in bidRequest.params) { + for (const key in bidRequest.params) { // loop over params and remove empty/untouched values if (bidRequest.params.hasOwnProperty(key)) { // if debug we update url string to get core debug version @@ -142,7 +142,7 @@ function buildRequests(validBidRequests, bidderRequest) { continue; } - let fixedObj = fixRequestParamForServer(key, bidRequest.params[key]); + const fixedObj = fixRequestParamForServer(key, bidRequest.params[key]); bidRequest.params[key] = fixedObj.value; // if pageUrl is set by user we should update variable for query string param diff --git a/modules/mygaruIdSystem.js b/modules/mygaruIdSystem.js index e05bcba1ecb..56a114f94a5 100644 --- a/modules/mygaruIdSystem.js +++ b/modules/mygaruIdSystem.js @@ -19,7 +19,7 @@ const syncUrl = 'https://ident.mygaru.com/v2/id'; export function buildUrl(opts) { const queryPairs = []; - for (let key in opts) { + for (const key in opts) { if (opts[key] !== undefined) { queryPairs.push(`${key}=${encodeURIComponent(opts[key])}`); } diff --git a/modules/mytargetBidAdapter.js b/modules/mytargetBidAdapter.js index b9ce8b133d1..a07a4a32d21 100644 --- a/modules/mytargetBidAdapter.js +++ b/modules/mytargetBidAdapter.js @@ -8,9 +8,9 @@ const DEFAULT_CURRENCY = 'RUB'; const DEFAULT_TTL = 180; function buildPlacement(bidRequest) { - let { bidId, params } = bidRequest; - let { placementId, position, response, bidfloor } = params; - let placement = { + const { bidId, params } = bidRequest; + const { placementId, position, response, bidfloor } = params; + const placement = { placementId, id: bidId, position: position || 0, @@ -77,11 +77,11 @@ export const spec = { }, interpretResponse: function(serverResponse, bidRequest) { - let { body } = serverResponse; + const { body } = serverResponse; if (body.bids) { return _map(body.bids, (bid) => { - let bidResponse = { + const bidResponse = { requestId: bid.id, cpm: bid.price, width: bid.size.width, diff --git a/modules/nativoBidAdapter.js b/modules/nativoBidAdapter.js index 6fcd9d6331b..29feb4aad03 100644 --- a/modules/nativoBidAdapter.js +++ b/modules/nativoBidAdapter.js @@ -212,7 +212,7 @@ export const spec = { const adUnitData = buildAdUnitData(validBidRequests) // Build basic required QS Params - let params = [ + const params = [ // Prebid version { key: 'ntv_pbv', @@ -313,7 +313,7 @@ export const spec = { ] const requestUrl = buildRequestUrl(BIDDER_ENDPOINT, qsParamStrings) - let serverRequest = { + const serverRequest = { method: 'POST', url: requestUrl, data: openRTBDataString, @@ -523,7 +523,7 @@ export class RequestData { } processBidRequestData(bidRequest, bidderRequest) { - for (let bidRequestDataSource of this.bidRequestDataSources) { + for (const bidRequestDataSource of this.bidRequestDataSources) { bidRequestDataSource.processBidRequestData(bidRequest, bidderRequest) } } @@ -591,15 +591,15 @@ export function parseFloorPriceData(bidRequest) { if (typeof bidRequest.getFloor !== 'function') return // Setup price floor data per bid request - let bidRequestFloorPriceData = {} - let bidMediaTypes = bidRequest.mediaTypes - let sizeOptions = new Set() + const bidRequestFloorPriceData = {} + const bidMediaTypes = bidRequest.mediaTypes + const sizeOptions = new Set() // Step through meach media type so we can get floor data for each media type per bid request Object.keys(bidMediaTypes).forEach((mediaType) => { // Setup price floor data per media type - let mediaTypeData = bidMediaTypes[mediaType] - let mediaTypeFloorPriceData = {} - let mediaTypeSizes = mediaTypeData.sizes || mediaTypeData.playerSize || [] + const mediaTypeData = bidMediaTypes[mediaType] + const mediaTypeFloorPriceData = {} + const mediaTypeSizes = mediaTypeData.sizes || mediaTypeData.playerSize || [] // Step through each size of the media type so we can get floor data for each size per media type mediaTypeSizes.forEach((size) => { // Get floor price data per the getFloor method and respective media type / size combination diff --git a/modules/newspassidBidAdapter.js b/modules/newspassidBidAdapter.js index fac9841318d..cbde226b5a2 100644 --- a/modules/newspassidBidAdapter.js +++ b/modules/newspassidBidAdapter.js @@ -150,7 +150,7 @@ export const spec = { params.publisher = globalPublisherId; } - let syncs = []; + const syncs = []; // iframe sync syncs.push({ diff --git a/modules/nextMillenniumBidAdapter.js b/modules/nextMillenniumBidAdapter.js index a6f90c272f4..1c1b7e0fef8 100644 --- a/modules/nextMillenniumBidAdapter.js +++ b/modules/nextMillenniumBidAdapter.js @@ -227,7 +227,7 @@ export const spec = { const bidder = bids[0]?.bidder || bids[0]?.bidderCode; if (bidder != BIDDER_CODE) return; - let params = []; + const params = []; _each(bids, bid => { if (bid.params) { params.push(bid.params); @@ -383,7 +383,7 @@ export function setConsentStrings(postBody = {}, bidderRequest) { }; export function setOrtb2Parameters(postBody, ortb2 = {}) { - for (let parameter of ALLOWED_ORTB2_PARAMETERS) { + for (const parameter of ALLOWED_ORTB2_PARAMETERS) { const value = deepAccess(ortb2, parameter); if (value) deepSetValue(postBody, parameter, value); } @@ -431,7 +431,7 @@ function getCurrency(bid = {}) { }; if (typeof bid.getFloor === 'function') { - let floorInfo = bid.getFloor({currency, mediaType, size: '*'}); + const floorInfo = bid.getFloor({currency, mediaType, size: '*'}); mediaTypes[mediaType].bidfloorcur = floorInfo?.currency; mediaTypes[mediaType].bidfloor = floorInfo?.floor; } else { @@ -451,7 +451,7 @@ export function getPlacementId(bid) { const placementId = getBidIdParameter('placement_id', bid.params); if (!groupId) return placementId; - let windowTop = getTopWindow(window); + const windowTop = getTopWindow(window); let sizes = []; if (bid.mediaTypes) { if (bid.mediaTypes.banner) sizes = [...bid.mediaTypes.banner.sizes]; @@ -520,7 +520,7 @@ export function getSourceObj(validBidRequests, bidderRequest) { } function getSua() { - let {brands, mobile, platform} = (window?.navigator?.userAgentData || {}); + const {brands, mobile, platform} = (window?.navigator?.userAgentData || {}); if (!(brands && platform)) return undefined; return { diff --git a/modules/nextrollBidAdapter.js b/modules/nextrollBidAdapter.js index fea3fe48cf5..0b0bf4663af 100644 --- a/modules/nextrollBidAdapter.js +++ b/modules/nextrollBidAdapter.js @@ -49,7 +49,7 @@ export const spec = { // convert Native ORTB definition to old-style prebid native definition validBidRequests = convertOrtbRequestToProprietaryNative(validBidRequests); // TODO: is 'page' the right value here? - let topLocation = parseUrl(deepAccess(bidderRequest, 'refererInfo.page')); + const topLocation = parseUrl(deepAccess(bidderRequest, 'refererInfo.page')); return validBidRequests.map((bidRequest) => { return { @@ -94,22 +94,22 @@ export const spec = { if (!serverResponse.body) { return []; } else { - let response = serverResponse.body - let bids = response.seatbid.reduce((acc, seatbid) => acc.concat(seatbid.bid), []); + const response = serverResponse.body + const bids = response.seatbid.reduce((acc, seatbid) => acc.concat(seatbid.bid), []); return bids.map((bid) => _buildResponse(response, bid)); } } } function _getBanner(bidRequest) { - let sizes = _getSizes(bidRequest); + const sizes = _getSizes(bidRequest); if (sizes === undefined) return undefined; return {format: sizes}; } function _getNative(mediaTypeNative) { if (mediaTypeNative === undefined) return undefined; - let assets = _getNativeAssets(mediaTypeNative); + const assets = _getNativeAssets(mediaTypeNative); if (assets === undefined || assets.length == 0) return undefined; return { request: { @@ -200,7 +200,7 @@ function _getFloor(bidRequest) { return (bidRequest.params.bidfloor) ? bidRequest.params.bidfloor : null; } - let floor = bidRequest.getFloor({ + const floor = bidRequest.getFloor({ currency: 'USD', mediaType: '*', size: '*' @@ -213,7 +213,7 @@ function _getFloor(bidRequest) { } function _buildResponse(bidResponse, bid) { - let response = { + const response = { requestId: bidResponse.id, cpm: bid.price, width: bid.w, @@ -241,7 +241,7 @@ const privacyLink = 'https://app.adroll.com/optout/personalized'; const privacyIcon = 'https://s.adroll.com/j/ad-choices-small.png'; function _getNativeResponse(adm, price) { - let baseResponse = { + const baseResponse = { clickTrackers: (adm.link && adm.link.clicktrackers) || [], jstracker: adm.jstracker || [], clickUrl: replaceAuctionPrice(adm.link.url, price), diff --git a/modules/nobidBidAdapter.js b/modules/nobidBidAdapter.js index 8b7f9cae319..2af7940431c 100644 --- a/modules/nobidBidAdapter.js +++ b/modules/nobidBidAdapter.js @@ -134,9 +134,9 @@ function nobidBuildRequests(bids, bidderRequest) { } var getEIDs = function(eids) { if (isArray(eids) && eids.length > 0) { - let src = []; + const src = []; eids.forEach((eid) => { - let ids = []; + const ids = []; if (eid.uids) { eid.uids.forEach(value => { ids.push({'id': value.id + ''}); @@ -241,7 +241,7 @@ function nobidBuildRequests(bids, bidderRequest) { if (typeof window.nobid.refreshLimit !== 'undefined') { if (window.nobid.refreshLimit < window.nobid.refreshCount) return false; } - let ublock = nobidGetCookie('_ublock'); + const ublock = nobidGetCookie('_ublock'); if (ublock) { log('Request blocked for user. hours: ', ublock); return false; @@ -355,7 +355,7 @@ window.nobid.renderTag = function(doc, id, win) { log('nobid.renderTag() tag NOT FOUND *ERROR*', id); } window.addEventListener('message', function (event) { - let key = event.message ? 'message' : 'data'; + const key = event.message ? 'message' : 'data'; var msg = '' + event[key]; if (msg.substring(0, 'nbTagRenderer.requestAdMarkup|'.length) === 'nbTagRenderer.requestAdMarkup|') { log('Prebid received nbTagRenderer.requestAdMarkup event'); @@ -480,7 +480,7 @@ export const spec = { url: 'https://public.servenobid.com/sync.html' + params }]; } else if (syncOptions.pixelEnabled && serverResponses.length > 0) { - let syncs = []; + const syncs = []; if (serverResponses[0].body.syncs && serverResponses[0].body.syncs.length > 0) { serverResponses[0].body.syncs.forEach(element => { syncs.push({ diff --git a/modules/novatiqIdSystem.js b/modules/novatiqIdSystem.js index b2a7791930c..78cb629596b 100644 --- a/modules/novatiqIdSystem.js +++ b/modules/novatiqIdSystem.js @@ -38,7 +38,7 @@ export const novatiqIdSubmodule = { * @returns {{novatiq: {snowflake: string}}} */ decode(novatiqId, config) { - let responseObj = { + const responseObj = { novatiq: { snowflake: novatiqId } @@ -85,7 +85,7 @@ export const novatiqIdSubmodule = { const sharedStatus = (sharedId != undefined && sharedId != false) ? 'Found' : 'Not Found'; if (useCallbacks) { - let res = this.sendAsyncSyncRequest(novatiqId, url); ; + const res = this.sendAsyncSyncRequest(novatiqId, url); ; res.sharedStatus = sharedStatus; return res; @@ -149,7 +149,7 @@ export const novatiqIdSubmodule = { }, getSyncUrl(sharedId, sspid, urlParams) { - let novatiqId = this.getNovatiqId(urlParams); + const novatiqId = this.getNovatiqId(urlParams); let url = 'https://spadsync.com/sync?' + urlParams.novatiqId + '=' + novatiqId; @@ -158,7 +158,7 @@ export const novatiqIdSubmodule = { } if (urlParams.useSspHost) { - let ssphost = getWindowLocation().hostname; + const ssphost = getWindowLocation().hostname; logInfo('NOVATIQ partner hostname: ' + ssphost); url = url + '&ssphost=' + ssphost; @@ -176,7 +176,7 @@ export const novatiqIdSubmodule = { }, getUrlParams(configParams) { - let urlParams = { + const urlParams = { novatiqId: 'snowflake', useStandardUuid: false, useSspId: true, @@ -224,7 +224,7 @@ export const novatiqIdSubmodule = { getSharedId(configParams) { let sharedId = null; if (this.useSharedId(configParams)) { - let cookieOrStorageID = this.getCookieOrStorageID(configParams); + const cookieOrStorageID = this.getCookieOrStorageID(configParams); const storage = getStorageManager({moduleType: MODULE_TYPE_UID, moduleName: MODULE_NAME}); // first check local storage diff --git a/modules/oguryBidAdapter.js b/modules/oguryBidAdapter.js index 85569d3c254..eed8fae088d 100644 --- a/modules/oguryBidAdapter.js +++ b/modules/oguryBidAdapter.js @@ -134,7 +134,7 @@ function getFloor(bid) { if (!isFn(bid.getFloor)) { return 0; } - let floorResult = bid.getFloor({ + const floorResult = bid.getFloor({ currency: 'USD', mediaType: 'banner', size: '*' diff --git a/modules/omsBidAdapter.js b/modules/omsBidAdapter.js index 2c271c5b475..0d8e68d7410 100644 --- a/modules/omsBidAdapter.js +++ b/modules/omsBidAdapter.js @@ -295,7 +295,7 @@ function _getBidFloor(bid) { return bid.params.bidFloor ? bid.params.bidFloor : null; } - let floor = bid.getFloor({ + const floor = bid.getFloor({ currency: 'USD', mediaType: '*', size: '*' }); if (isPlainObject(floor) && !isNaN(floor.floor) && floor.currency === 'USD') { diff --git a/modules/onetagBidAdapter.js b/modules/onetagBidAdapter.js index d18b875e589..b9717028770 100644 --- a/modules/onetagBidAdapter.js +++ b/modules/onetagBidAdapter.js @@ -421,7 +421,7 @@ function parseVideoSize(bid) { } function parseSizes(bid) { - let ret = []; + const ret = []; if (typeof bid.mediaTypes !== 'undefined' && typeof bid.mediaTypes.banner !== 'undefined' && typeof bid.mediaTypes.banner.sizes !== 'undefined' && Array.isArray(bid.mediaTypes.banner.sizes) && bid.mediaTypes.banner.sizes.length > 0) { return getSizes(bid.mediaTypes.banner.sizes) } @@ -442,7 +442,7 @@ function getSizes(sizes) { } function getUserSyncs(syncOptions, serverResponses, gdprConsent, uspConsent, gppConsent) { - let syncs = []; + const syncs = []; let params = ''; if (gdprConsent) { if (typeof gdprConsent.gdprApplies === 'boolean') { diff --git a/modules/onomagicBidAdapter.js b/modules/onomagicBidAdapter.js index 0b5806a370f..c921f4e3d22 100644 --- a/modules/onomagicBidAdapter.js +++ b/modules/onomagicBidAdapter.js @@ -194,7 +194,7 @@ function _getBidFloor(bid) { return bid.params.bidFloor ? bid.params.bidFloor : null; } - let floor = bid.getFloor({ + const floor = bid.getFloor({ currency: 'USD', mediaType: '*', size: '*' diff --git a/modules/ooloAnalyticsAdapter.js b/modules/ooloAnalyticsAdapter.js index 573fee3b0b3..22b8476ef54 100644 --- a/modules/ooloAnalyticsAdapter.js +++ b/modules/ooloAnalyticsAdapter.js @@ -51,12 +51,12 @@ const SERVER_BID_STATUS = { let auctions = {} let initOptions = {} -let eventsQueue = [] +const eventsQueue = [] const onAuctionInit = (args) => { const { auctionId, adUnits, timestamp } = args - let auction = auctions[auctionId] = { + const auction = auctions[auctionId] = { ...args, adUnits: {}, auctionStart: timestamp, @@ -99,7 +99,7 @@ const onBidResponse = (args) => { const { auctionId, adUnitCode } = args const auction = auctions[auctionId] const bidId = parseBidId(args) - let bid = auction.adUnits[adUnitCode].bids[bidId] + const bid = auction.adUnits[adUnitCode].bids[bidId] Object.assign(bid, args, { bidStatus: SERVER_BID_STATUS.BID_RECEIVED, @@ -113,7 +113,7 @@ const onNoBid = (args) => { const bidId = parseBidId(args) const end = Date.now() const auction = auctions[auctionId] - let bid = auction.adUnits[adUnitCode].bids[bidId] + const bid = auction.adUnits[adUnitCode].bids[bidId] Object.assign(bid, args, { bidStatus: SERVER_BID_STATUS.NO_BID, @@ -148,7 +148,7 @@ const onBidTimeout = (args) => { _each(args, bid => { const { auctionId, adUnitCode } = bid const bidId = parseBidId(bid) - let bidCache = auctions[auctionId].adUnits[adUnitCode].bids[bidId] + const bidCache = auctions[auctionId].adUnits[adUnitCode].bids[bidId] Object.assign(bidCache, bid, { bidStatus: SERVER_BID_STATUS.BID_TIMEDOUT, @@ -233,7 +233,7 @@ function handleEvent(eventType, args) { } function sendEvent(eventType, args, isRaw) { - let data = deepClone(args) + const data = deepClone(args) Object.assign(data, buildCommonDataProperties(), { eventType diff --git a/modules/openxBidAdapter.js b/modules/openxBidAdapter.js index 56752d1302c..e287ad38417 100644 --- a/modules/openxBidAdapter.js +++ b/modules/openxBidAdapter.js @@ -162,12 +162,12 @@ function isBidRequestValid(bidRequest) { } function buildRequests(bidRequests, bidderRequest) { - let videoRequests = bidRequests.filter(bidRequest => isVideoBidRequest(bidRequest)); - let bannerAndNativeRequests = bidRequests.filter(bidRequest => isBannerBidRequest(bidRequest) || isNativeBidRequest(bidRequest)) + const videoRequests = bidRequests.filter(bidRequest => isVideoBidRequest(bidRequest)); + const bannerAndNativeRequests = bidRequests.filter(bidRequest => isBannerBidRequest(bidRequest) || isNativeBidRequest(bidRequest)) // In case of multi-format bids remove `video` from mediaTypes as for video a separate bid request is built .map(bid => ({...bid, mediaTypes: {...bid.mediaTypes, video: undefined}})); - let requests = bannerAndNativeRequests.length ? [createRequest(bannerAndNativeRequests, bidderRequest, null)] : []; + const requests = bannerAndNativeRequests.length ? [createRequest(bannerAndNativeRequests, bidderRequest, null)] : []; videoRequests.forEach(bid => { requests.push(createRequest([bid], bidderRequest, VIDEO)); }); @@ -211,8 +211,8 @@ function interpretResponse(resp, req) { */ function getUserSyncs(syncOptions, responses, gdprConsent, uspConsent) { if (syncOptions.iframeEnabled || syncOptions.pixelEnabled) { - let pixelType = syncOptions.iframeEnabled ? 'iframe' : 'image'; - let queryParamStrings = []; + const pixelType = syncOptions.iframeEnabled ? 'iframe' : 'image'; + const queryParamStrings = []; let syncUrl = SYNC_URL; if (gdprConsent) { queryParamStrings.push('gdpr=' + (gdprConsent.gdprApplies ? 1 : 0)); diff --git a/modules/operaadsBidAdapter.js b/modules/operaadsBidAdapter.js index b30fdb709a6..ef1e402bb06 100644 --- a/modules/operaadsBidAdapter.js +++ b/modules/operaadsBidAdapter.js @@ -680,18 +680,18 @@ function mapNativeImage(image, type) { * @returns {String} userId */ function getUserId(bidRequest) { - let operaId = deepAccess(bidRequest, 'userId.operaId'); + const operaId = deepAccess(bidRequest, 'userId.operaId'); if (operaId) { return operaId; } - let sharedId = deepAccess(bidRequest, 'userId.sharedid.id'); + const sharedId = deepAccess(bidRequest, 'userId.sharedid.id'); if (sharedId) { return sharedId; } for (const idModule of ['pubcid', 'tdid']) { - let userId = deepAccess(bidRequest, `userId.${idModule}`); + const userId = deepAccess(bidRequest, `userId.${idModule}`); if (userId) { return userId; } diff --git a/modules/operaadsIdSystem.js b/modules/operaadsIdSystem.js index 7cf5e2ce5e1..0e8c983d57e 100644 --- a/modules/operaadsIdSystem.js +++ b/modules/operaadsIdSystem.js @@ -22,7 +22,7 @@ const AJAX_OPTIONS = {method: 'GET', withCredentials: true, contentType: 'applic function constructUrl(pairs) { const queries = []; - for (let key in pairs) { + for (const key in pairs) { queries.push(`${key}=${encodeURIComponent(pairs[key])}`); } return `${SYNC_URL}?${queries.join('&')}`; diff --git a/modules/oprxBidAdapter.js b/modules/oprxBidAdapter.js new file mode 100644 index 00000000000..4bc881aab29 --- /dev/null +++ b/modules/oprxBidAdapter.js @@ -0,0 +1,65 @@ +import { BANNER } from '../src/mediaTypes.js'; +import { ortbConverter } from '../libraries/ortbConverter/converter.js'; +import { registerBidder } from '../src/adapters/bidderFactory.js'; +let converterInstance; + +export const spec = { + code: 'oprx', + supportedMediaTypes: [BANNER], + + isBidRequestValid: function (bid) { + return !!(bid?.params?.key && bid?.params?.placement_id); + }, + + buildRequests(bidRequests, bidderRequest) { + if (!bidRequests?.length) return []; + + const bid = bidRequests[0]; + const endpoint = `https://pb.optimizerx.com?placement_id=${bid.params.placement_id}&npi=${bid.params.npi}`; + + const converter = converterInstance || defaultConverter; + + const requestData = converter.toORTB({ + bRequests: bidRequests, + brRequest: bidderRequest, + }); + + return [{ + method: 'POST', + url: endpoint, + data: requestData, + options: { contentType: 'application/json;charset=utf-8' } + }]; + }, + + interpretResponse(serverResponse, request) { + const converter = converterInstance || defaultConverter; + const response = serverResponse?.body || {}; + const requestData = request?.data; + return converter.fromORTB({ response, request: requestData }).bids || []; + } +}; + +// defaultConverter = real one used in prod +const defaultConverter = ortbConverter({ + context: { + netRevenue: true, + ttl: 50, + currency: 'USD', + mediaType: BANNER, + }, + imp(buildImp, bidRequest, context) { + const imp = buildImp(bidRequest, context); + if (bidRequest.params.bid_floor) { + imp.bidfloor = bidRequest.params.bid_floor; + } + return imp; + }, +}); + +// Allow test override +export function __setTestConverter(mockConverter) { + converterInstance = mockConverter; +} + +registerBidder(spec); diff --git a/modules/oprxBidAdapter.md b/modules/oprxBidAdapter.md new file mode 100644 index 00000000000..f2a91f4d9fb --- /dev/null +++ b/modules/oprxBidAdapter.md @@ -0,0 +1,41 @@ +# Overview + +``` +Module Name: OPRx Bidder Adapter +Module Type: Bidder Adapter +Maintainer: adsupport@optimizerx.com +``` + +# Description + +OPRx currently supports the BANNER type ads through prebid js + +Module that connects to OPRx's demand sources. + +# Test Request +``` + var adUnits = [ + { + code: 'oprx-banner-ad', + mediaTypes: { + banner: { + sizes: [[728, 90]], + } + } + bids: [ + { + bidder: 'oprx', + params: { + key: '', // Required parameter + placement_id: 11223344, // Required parameter + width: 728, // Optional parameter + height: 90, // Optional parameter + bid_floor: 0.5, // Optional parameter + npi: '1234567890', // Optional parameter + ndc: '12345678901' // Optional parameter + } + } + ] + } + ]; +``` diff --git a/modules/opscoBidAdapter.js b/modules/opscoBidAdapter.js index 4ddb548c0f1..60cf32dc7a9 100644 --- a/modules/opscoBidAdapter.js +++ b/modules/opscoBidAdapter.js @@ -104,7 +104,7 @@ export const spec = { if (!syncOptions.iframeEnabled && !syncOptions.pixelEnabled) { return []; } - let syncs = []; + const syncs = []; serverResponses.forEach(resp => { const userSync = deepAccess(resp, 'body.ext.usersync'); if (userSync) { diff --git a/modules/optableRtdProvider.js b/modules/optableRtdProvider.js index a8a69ce2345..2ef71ce9d44 100644 --- a/modules/optableRtdProvider.js +++ b/modules/optableRtdProvider.js @@ -15,8 +15,8 @@ const {logMessage, logWarn, logError} = optableLog; */ export const parseConfig = (moduleConfig) => { let bundleUrl = deepAccess(moduleConfig, 'params.bundleUrl', null); - let adserverTargeting = deepAccess(moduleConfig, 'params.adserverTargeting', true); - let handleRtd = deepAccess(moduleConfig, 'params.handleRtd', null); + const adserverTargeting = deepAccess(moduleConfig, 'params.adserverTargeting', true); + const handleRtd = deepAccess(moduleConfig, 'params.handleRtd', null); // If present, trim the bundle URL if (typeof bundleUrl === 'string') { diff --git a/modules/optidigitalBidAdapter.js b/modules/optidigitalBidAdapter.js index 7f86dd93d6c..1330bf2054f 100755 --- a/modules/optidigitalBidAdapter.js +++ b/modules/optidigitalBidAdapter.js @@ -220,12 +220,12 @@ function buildImp(bidRequest, ortb2) { CUR = bidRequest.params.currency; } - let bidFloor = _getFloor(bidRequest, floorSizes, CUR); + const bidFloor = _getFloor(bidRequest, floorSizes, CUR); if (bidFloor) { imp.bidFloor = bidFloor; } - let battr = ortb2.battr || deepAccess(bidRequest, 'params.battr'); + const battr = ortb2.battr || deepAccess(bidRequest, 'params.battr'); if (battr && Array.isArray(battr) && battr.length) { imp.battr = battr; } @@ -241,7 +241,7 @@ function getAdContainer(container) { function _getFloor (bid, sizes, currency) { let floor = null; - let size = sizes.length === 1 ? sizes[0] : '*'; + const size = sizes.length === 1 ? sizes[0] : '*'; if (typeof bid.getFloor === 'function') { try { const floorInfo = bid.getFloor({ diff --git a/modules/optimeraRtdProvider.js b/modules/optimeraRtdProvider.js index 71cd2a3b79b..f5872dbd33b 100644 --- a/modules/optimeraRtdProvider.js +++ b/modules/optimeraRtdProvider.js @@ -187,7 +187,7 @@ export function setScoresURL() { if (apiVersion === 'v1') { newScoresURL = `${baseUrl}api/products/scores?c=${clientID}&h=${optimeraHost}&p=${optimeraPathName}&s=${device}`; } else { - let encoded = encodeURIComponent(`${optimeraHost}${optimeraPathName}`) + const encoded = encodeURIComponent(`${optimeraHost}${optimeraPathName}`) .replaceAll('%2F', '/') .replaceAll('%20', '+'); diff --git a/modules/optoutBidAdapter.js b/modules/optoutBidAdapter.js index 0fbfb0fd0e6..03cd420b0be 100644 --- a/modules/optoutBidAdapter.js +++ b/modules/optoutBidAdapter.js @@ -65,7 +65,7 @@ export const spec = { getUserSyncs: function (syncOptions, responses, gdprConsent) { if (gdprConsent) { - let gdpr = (typeof gdprConsent.gdprApplies === 'boolean') ? Number(gdprConsent.gdprApplies) : 0; + const gdpr = (typeof gdprConsent.gdprApplies === 'boolean') ? Number(gdprConsent.gdprApplies) : 0; if (syncOptions.iframeEnabled && (!gdprConsent.gdprApplies || hasPurpose1Consent(gdprConsent))) { return [{ type: 'iframe', diff --git a/modules/orbidderBidAdapter.js b/modules/orbidderBidAdapter.js index 9b534910af1..55d2af43f47 100644 --- a/modules/orbidderBidAdapter.js +++ b/modules/orbidderBidAdapter.js @@ -98,7 +98,7 @@ export const spec = { bidRequest.params.bidfloor = getBidFloor(bidRequest); - let httpReq = { + const httpReq = { url: `${hostname}/bid`, method: 'POST', options: { withCredentials: true }, diff --git a/modules/orbitsoftBidAdapter.js b/modules/orbitsoftBidAdapter.js index a22afd16a49..7ae2195294d 100644 --- a/modules/orbitsoftBidAdapter.js +++ b/modules/orbitsoftBidAdapter.js @@ -3,7 +3,7 @@ import {registerBidder} from '../src/adapters/bidderFactory.js'; import {getBidIdParameter} from '../src/utils.js'; const BIDDER_CODE = 'orbitsoft'; -let styleParamsMap = { +const styleParamsMap = { 'title.family': 'f1', // headerFont 'title.size': 'fs1', // headerFontSize 'title.weight': 'w1', // headerWeight @@ -42,12 +42,12 @@ export const spec = { }, buildRequests: function (validBidRequests) { let bidRequest; - let serverRequests = []; + const serverRequests = []; for (let i = 0; i < validBidRequests.length; i++) { bidRequest = validBidRequests[i]; - let bidRequestParams = bidRequest.params; - let placementId = getBidIdParameter('placementId', bidRequestParams); - let requestUrl = getBidIdParameter('requestUrl', bidRequestParams); + const bidRequestParams = bidRequest.params; + const placementId = getBidIdParameter('placementId', bidRequestParams); + const requestUrl = getBidIdParameter('requestUrl', bidRequestParams); let referrer = getBidIdParameter('ref', bidRequestParams); let location = getBidIdParameter('loc', bidRequestParams); // Append location & referrer @@ -59,14 +59,14 @@ export const spec = { } // Styles params - let stylesParams = getBidIdParameter('style', bidRequestParams); - let stylesParamsArray = {}; - for (let currentValue in stylesParams) { + const stylesParams = getBidIdParameter('style', bidRequestParams); + const stylesParamsArray = {}; + for (const currentValue in stylesParams) { if (stylesParams.hasOwnProperty(currentValue)) { - let currentStyle = stylesParams[currentValue]; - for (let field in currentStyle) { + const currentStyle = stylesParams[currentValue]; + for (const field in currentStyle) { if (currentStyle.hasOwnProperty(field)) { - let styleField = styleParamsMap[currentValue + '.' + field]; + const styleField = styleParamsMap[currentValue + '.' + field]; if (typeof styleField !== 'undefined') { stylesParamsArray[styleField] = currentStyle[field]; } @@ -75,18 +75,18 @@ export const spec = { } } // Custom params - let customParams = getBidIdParameter('customParams', bidRequestParams); - let customParamsArray = {}; - for (let customField in customParams) { + const customParams = getBidIdParameter('customParams', bidRequestParams); + const customParamsArray = {}; + for (const customField in customParams) { if (customParams.hasOwnProperty(customField)) { customParamsArray['c.' + customField] = customParams[customField]; } } // Sizes params (not supports by server, for future features) - let sizesParams = bidRequest.sizes; - let parsedSizes = utils.parseSizesInput(sizesParams); - let requestData = Object.assign({ + const sizesParams = bidRequest.sizes; + const parsedSizes = utils.parseSizesInput(sizesParams); + const requestData = Object.assign({ 'scid': placementId, 'callback_uid': utils.generateUUID(), 'loc': location, @@ -105,7 +105,7 @@ export const spec = { return serverRequests; }, interpretResponse: function (serverResponse, request) { - let bidResponses = []; + const bidResponses = []; if (!serverResponse || serverResponse.error) { utils.logError(BIDDER_CODE + ': Server response error'); return bidResponses; @@ -124,9 +124,9 @@ export const spec = { const CALLBACK_UID = serverBody.callback_uid; const TIME_TO_LIVE = 60; const REFERER = utils.getWindowTop(); - let bidRequest = request.bidRequest; + const bidRequest = request.bidRequest; if (CPM > 0 && WIDTH > 0 && HEIGHT > 0) { - let bidResponse = { + const bidResponse = { requestId: bidRequest.bidId, cpm: CPM, width: WIDTH, diff --git a/modules/outbrainBidAdapter.js b/modules/outbrainBidAdapter.js index c308cc2e067..37862e9368d 100644 --- a/modules/outbrainBidAdapter.js +++ b/modules/outbrainBidAdapter.js @@ -223,9 +223,9 @@ export const spec = { }, getUserSyncs: (syncOptions, responses, gdprConsent, uspConsent, gppConsent) => { const syncs = []; - let syncUrl = config.getConfig('outbrain.usersyncUrl'); + const syncUrl = config.getConfig('outbrain.usersyncUrl'); - let query = []; + const query = []; if (syncOptions.pixelEnabled && syncUrl) { if (gdprConsent) { query.push('gdpr=' + (gdprConsent.gdprApplies & 1)); diff --git a/modules/ownadxBidAdapter.js b/modules/ownadxBidAdapter.js index 5843735f314..7dc243eab59 100644 --- a/modules/ownadxBidAdapter.js +++ b/modules/ownadxBidAdapter.js @@ -43,9 +43,9 @@ export const spec = { mtype = 2; } - let tkn = bidRequest.params.tokenId; - let seatid = bidRequest.params.seatId; - let sspid = bidRequest.params.sspId; + const tkn = bidRequest.params.tokenId; + const seatid = bidRequest.params.seatId; + const sspid = bidRequest.params.sspId; const payload = { sizes: sizes, diff --git a/modules/oxxionAnalyticsAdapter.js b/modules/oxxionAnalyticsAdapter.js index 9e18c92d25b..db0eb2a392e 100644 --- a/modules/oxxionAnalyticsAdapter.js +++ b/modules/oxxionAnalyticsAdapter.js @@ -16,20 +16,20 @@ const { BID_TIMEOUT, } = EVENTS; -let saveEvents = {} +const saveEvents = {} let allEvents = {} let auctionEnd = {} let initOptions = {} let mode = {}; let endpoint = 'https://default' -let requestsAttributes = ['adUnitCode', 'auctionId', 'bidder', 'bidderCode', 'bidId', 'cpm', 'creativeId', 'currency', 'width', 'height', 'mediaType', 'netRevenue', 'originalCpm', 'originalCurrency', 'requestId', 'size', 'source', 'status', 'timeToRespond', 'transactionId', 'ttl', 'sizes', 'mediaTypes', 'src', 'params', 'userId', 'labelAny', 'bids', 'adId', 'ova']; +const requestsAttributes = ['adUnitCode', 'auctionId', 'bidder', 'bidderCode', 'bidId', 'cpm', 'creativeId', 'currency', 'width', 'height', 'mediaType', 'netRevenue', 'originalCpm', 'originalCurrency', 'requestId', 'size', 'source', 'status', 'timeToRespond', 'transactionId', 'ttl', 'sizes', 'mediaTypes', 'src', 'params', 'userId', 'labelAny', 'bids', 'adId', 'ova']; function getAdapterNameForAlias(aliasName) { return adapterManager.aliasRegistry[aliasName] || aliasName; } function filterAttributes(arg, removead) { - let response = {}; + const response = {}; if (typeof arg == 'object') { if (typeof arg['bidderCode'] == 'string') { response['originalBidder'] = getAdapterNameForAlias(arg['bidderCode']); @@ -66,9 +66,9 @@ function filterAttributes(arg, removead) { } function cleanAuctionEnd(args) { - let response = {}; + const response = {}; let filteredObj; - let objects = ['bidderRequests', 'bidsReceived', 'noBids', 'adUnits']; + const objects = ['bidderRequests', 'bidsReceived', 'noBids', 'adUnits']; objects.forEach((attr) => { if (Array.isArray(args[attr])) { response[attr] = []; @@ -88,7 +88,7 @@ function cleanAuctionEnd(args) { } function cleanCreatives(args) { - let stringArgs = JSON.parse(dereferenceWithoutRenderer(args)); + const stringArgs = JSON.parse(dereferenceWithoutRenderer(args)); return filterAttributes(stringArgs, false); } @@ -104,26 +104,26 @@ function enhanceMediaType(arg) { } function addBidResponse(args) { - let eventType = BID_RESPONSE; - let argsCleaned = cleanCreatives(args); ; + const eventType = BID_RESPONSE; + const argsCleaned = cleanCreatives(args); ; if (allEvents[eventType] == undefined) { allEvents[eventType] = [] } allEvents[eventType].push(argsCleaned); } function addBidRequested(args) { - let eventType = BID_REQUESTED; - let argsCleaned = filterAttributes(args, true); + const eventType = BID_REQUESTED; + const argsCleaned = filterAttributes(args, true); if (saveEvents[eventType] == undefined) { saveEvents[eventType] = [] } saveEvents[eventType].push(argsCleaned); } function addTimeout(args) { - let eventType = BID_TIMEOUT; + const eventType = BID_TIMEOUT; if (saveEvents[eventType] == undefined) { saveEvents[eventType] = [] } saveEvents[eventType].push(args); - let argsCleaned = []; + const argsCleaned = []; let argsDereferenced = {}; - let stringArgs = JSON.parse(dereferenceWithoutRenderer(args)); + const stringArgs = JSON.parse(dereferenceWithoutRenderer(args)); argsDereferenced = stringArgs; argsDereferenced.forEach((attr) => { argsCleaned.push(filterAttributes(deepClone(attr), false)); @@ -134,22 +134,22 @@ function addTimeout(args) { export const dereferenceWithoutRenderer = function(args) { if (args.renderer) { - let tmp = args.renderer; + const tmp = args.renderer; delete args.renderer; - let stringified = JSON.stringify(args); + const stringified = JSON.stringify(args); args['renderer'] = tmp; return stringified; } if (args.bidsReceived) { - let tmp = {} - for (let key in args.bidsReceived) { + const tmp = {} + for (const key in args.bidsReceived) { if (args.bidsReceived[key].renderer) { tmp[key] = args.bidsReceived[key].renderer; delete args.bidsReceived[key].renderer; } } - let stringified = JSON.stringify(args); - for (let key in tmp) { + const stringified = JSON.stringify(args); + for (const key in tmp) { args.bidsReceived[key].renderer = tmp[key]; } return stringified; @@ -158,10 +158,10 @@ export const dereferenceWithoutRenderer = function(args) { } function addAuctionEnd(args) { - let eventType = AUCTION_END; + const eventType = AUCTION_END; if (saveEvents[eventType] == undefined) { saveEvents[eventType] = [] } saveEvents[eventType].push(args); - let argsCleaned = cleanAuctionEnd(JSON.parse(dereferenceWithoutRenderer(args))); + const argsCleaned = cleanAuctionEnd(JSON.parse(dereferenceWithoutRenderer(args))); if (auctionEnd[eventType] == undefined) { auctionEnd[eventType] = [] } auctionEnd[eventType].push(argsCleaned); } @@ -201,11 +201,11 @@ function handleBidWon(args) { function handleAuctionEnd() { ajax(endpoint + '.oxxion.io/analytics/auctions', function (data) { - let list = JSON.parse(data); + const list = JSON.parse(data); if (Array.isArray(list) && typeof allEvents['bidResponse'] != 'undefined') { - let alreadyCalled = []; + const alreadyCalled = []; allEvents['bidResponse'].forEach((bidResponse) => { - let tmpId = bidResponse['originalBidder'] + '_' + bidResponse['creativeId']; + const tmpId = bidResponse['originalBidder'] + '_' + bidResponse['creativeId']; if (list.includes(tmpId) && !alreadyCalled.includes(tmpId)) { alreadyCalled.push(tmpId); ajax(endpoint + '.oxxion.io/analytics/creatives', null, JSON.stringify(bidResponse), {method: 'POST', withCredentials: true}); @@ -217,7 +217,7 @@ function handleAuctionEnd() { auctionEnd = {}; } -let oxxionAnalytics = Object.assign(adapter({url, analyticsType}), { +const oxxionAnalytics = Object.assign(adapter({url, analyticsType}), { track({ eventType, args diff --git a/modules/oxxionRtdProvider.js b/modules/oxxionRtdProvider.js index a0476d8ca0f..857ce6373d8 100644 --- a/modules/oxxionRtdProvider.js +++ b/modules/oxxionRtdProvider.js @@ -101,7 +101,7 @@ function getFilteredAdUnitsOnBidRates (bidsRateInterests, adUnits, params, useSa if (!params.bidders || params.bidders.includes(bid.bidder)) { const index = interestingBidsRates.findIndex(({ id }) => id === bid._id); if (index == -1) { - let tmpBid = bid; + const tmpBid = bid; tmpBid['code'] = adUnits[adUnitIndex].code; tmpBid['mediaTypes'] = adUnits[adUnitIndex].mediaTypes; tmpBid['originalBidder'] = bidderAliasRegistry[bid.bidder] || bid.bidder; diff --git a/modules/ozoneBidAdapter.js b/modules/ozoneBidAdapter.js index 52791e6e907..5653f1a2cba 100644 --- a/modules/ozoneBidAdapter.js +++ b/modules/ozoneBidAdapter.js @@ -63,10 +63,10 @@ export const spec = { return false; }, isBidRequestValid(bid) { - let vf = 'VALIDATION FAILED'; + const vf = 'VALIDATION FAILED'; logInfo('isBidRequestValid : ', config.getConfig(), bid); - let adUnitCode = bid.adUnitCode; - let err1 = `${vf} : missing {param} : siteId, placementId and publisherId are REQUIRED`; + const adUnitCode = bid.adUnitCode; + const err1 = `${vf} : missing {param} : siteId, placementId and publisherId are REQUIRED`; if (!(getBidIdParameter('placementId', bid.params))) { logError(err1.replace('{param}', 'placementId'), adUnitCode); return false; @@ -136,7 +136,7 @@ export const spec = { if (this.blockTheRequest()) { return []; } - let fledgeEnabled = !!bidderRequest.fledgeEnabled; + const fledgeEnabled = !!bidderRequest.fledgeEnabled; let htmlParams = {'publisherId': '', 'siteId': ''}; if (validBidRequests.length > 0) { Object.assign(this.cookieSyncBag.userIdObject, this.findAllUserIdsFromEids(validBidRequests[0])); @@ -147,8 +147,8 @@ export const spec = { logInfo('cookie sync bag', this.cookieSyncBag); let singleRequest = config.getConfig('ozone.singleRequest'); singleRequest = singleRequest !== false; - let ozoneRequest = {}; - let fpd = deepAccess(bidderRequest, 'ortb2', null); + const ozoneRequest = {}; + const fpd = deepAccess(bidderRequest, 'ortb2', null); logInfo('got ortb2 fpd: ', fpd); if (fpd && deepAccess(fpd, 'user')) { logInfo('added FPD user object'); @@ -158,15 +158,15 @@ export const spec = { const wlOztestmodeKey = 'oztestmode'; const isTestMode = getParams[wlOztestmodeKey] || null; ozoneRequest.device = bidderRequest?.ortb2?.device || {}; - let placementIdOverrideFromGetParam = this.getPlacementIdOverrideFromGetParam(); + const placementIdOverrideFromGetParam = this.getPlacementIdOverrideFromGetParam(); let schain = null; var auctionId = deepAccess(validBidRequests, '0.ortb2.source.tid'); if (auctionId === '0') { auctionId = null; } - let tosendtags = validBidRequests.map(ozoneBidRequest => { + const tosendtags = validBidRequests.map(ozoneBidRequest => { var obj = {}; - let placementId = placementIdOverrideFromGetParam || this.getPlacementId(ozoneBidRequest); + const placementId = placementIdOverrideFromGetParam || this.getPlacementId(ozoneBidRequest); obj.id = ozoneBidRequest.bidId; obj.tagid = placementId; obj.secure = parseUrl(getRefererInfo().page).protocol === 'https' ? 1 : 0; @@ -185,13 +185,13 @@ export const spec = { if (ozoneBidRequest.mediaTypes.hasOwnProperty(VIDEO)) { logInfo('openrtb 2.5 compliant video'); if (typeof ozoneBidRequest.mediaTypes[VIDEO] == 'object') { - let childConfig = deepAccess(ozoneBidRequest, 'params.video', {}); + const childConfig = deepAccess(ozoneBidRequest, 'params.video', {}); obj.video = this.unpackVideoConfigIntoIABformat(ozoneBidRequest.mediaTypes[VIDEO], childConfig); obj.video = this.addVideoDefaults(obj.video, ozoneBidRequest.mediaTypes[VIDEO], childConfig); } - let wh = getWidthAndHeightFromVideoObject(obj.video); + const wh = getWidthAndHeightFromVideoObject(obj.video); logInfo(`setting video object ${obj.id} from mediaTypes.video: `, obj.video, 'wh=', wh); - let settingToBe = 'setting obj.video.format to be '; + const settingToBe = 'setting obj.video.format to be '; if (wh && typeof wh === 'object') { obj.video.w = wh['w']; obj.video.h = wh['h']; @@ -236,7 +236,7 @@ export const spec = { obj.ext[bidderKey].customData = ozoneBidRequest.params.customData; } if (ozoneBidRequest.params.hasOwnProperty('ozFloor')) { - let ozFloorParsed = parseFloat(ozoneBidRequest.params.ozFloor); + const ozFloorParsed = parseFloat(ozoneBidRequest.params.ozFloor); if (!isNaN(ozFloorParsed)) { obj.ext[bidderKey].ozFloor = ozFloorParsed; } else { @@ -266,11 +266,11 @@ export const spec = { if (!schain && deepAccess(ozoneBidRequest, 'ortb2.source.ext.schain')) { schain = ozoneBidRequest.ortb2.source.ext.schain; } - let gpid = deepAccess(ozoneBidRequest, 'ortb2Imp.ext.gpid'); + const gpid = deepAccess(ozoneBidRequest, 'ortb2Imp.ext.gpid'); if (gpid) { deepSetValue(obj, 'ext.gpid', gpid); } - let transactionId = deepAccess(ozoneBidRequest, 'ortb2Imp.ext.tid'); + const transactionId = deepAccess(ozoneBidRequest, 'ortb2Imp.ext.tid'); if (transactionId) { obj.ext.tid = transactionId; } @@ -287,32 +287,32 @@ export const spec = { } return obj; }); - let extObj = {}; + const extObj = {}; extObj[bidderKey] = {}; extObj[bidderKey][`${prefix}_pb_v`] = OZONEVERSION; extObj[bidderKey][`${prefix}_rw`] = placementIdOverrideFromGetParam ? 1 : 0; if (validBidRequests.length > 0) { - let userIds = this.cookieSyncBag.userIdObject; + const userIds = this.cookieSyncBag.userIdObject; if (userIds.hasOwnProperty('pubcid.org')) { extObj[bidderKey].pubcid = userIds['pubcid.org']; } } extObj[bidderKey].pv = this.getPageId(); - let ozOmpFloorDollars = config.getConfig('ozone.oz_omp_floor'); + const ozOmpFloorDollars = config.getConfig('ozone.oz_omp_floor'); logInfo(`${prefix}_omp_floor dollar value = `, ozOmpFloorDollars); if (typeof ozOmpFloorDollars === 'number') { extObj[bidderKey][`${prefix}_omp_floor`] = ozOmpFloorDollars; } else if (typeof ozOmpFloorDollars !== 'undefined') { logError(`IF set, ${prefix}_omp_floor must be a number eg. 1.55. Found:` + (typeof ozOmpFloorDollars)); } - let ozWhitelistAdserverKeys = config.getConfig('ozone.oz_whitelist_adserver_keys'); - let useOzWhitelistAdserverKeys = isArray(ozWhitelistAdserverKeys) && ozWhitelistAdserverKeys.length > 0; + const ozWhitelistAdserverKeys = config.getConfig('ozone.oz_whitelist_adserver_keys'); + const useOzWhitelistAdserverKeys = isArray(ozWhitelistAdserverKeys) && ozWhitelistAdserverKeys.length > 0; extObj[bidderKey][prefix + '_kvp_rw'] = useOzWhitelistAdserverKeys ? 1 : 0; const endpointOverride = config.getConfig('ozone.endpointOverride'); if (endpointOverride?.origin || endpointOverride?.auctionUrl) { extObj[bidderKey].origin = endpointOverride.auctionUrl || endpointOverride.origin; } - let userExtEids = deepAccess(validBidRequests, '0.userIdAsEids', []); + const userExtEids = deepAccess(validBidRequests, '0.userIdAsEids', []); ozoneRequest.site = { 'publisher': {'id': htmlParams.publisherId}, 'page': getRefererInfo().page, @@ -321,7 +321,7 @@ export const spec = { ozoneRequest.test = config.getConfig('debug') ? 1 : 0; if (bidderRequest && bidderRequest.gdprConsent) { logInfo('ADDING GDPR'); - let apiVersion = deepAccess(bidderRequest, 'gdprConsent.apiVersion', 1); + const apiVersion = deepAccess(bidderRequest, 'gdprConsent.apiVersion', 1); ozoneRequest.regs = {ext: {gdpr: bidderRequest.gdprConsent.gdprApplies ? 1 : 0, apiVersion: apiVersion}}; if (deepAccess(ozoneRequest, 'regs.ext.gdpr')) { deepSetValue(ozoneRequest, 'user.ext.consent', bidderRequest.gdprConsent.consentString); @@ -350,10 +350,10 @@ export const spec = { } extObj[bidderKey].cookieDeprecationLabel = deepAccess(bidderRequest, 'ortb2.device.ext.cdep', 'none'); logInfo(`cookieDeprecationLabel ortb2.device.ext.cdep = ${extObj[bidderKey].cookieDeprecationLabel}`); - let batchRequestsVal = this.getBatchRequests(); + const batchRequestsVal = this.getBatchRequests(); if (typeof batchRequestsVal === 'number') { logInfo(`Batching = ${batchRequestsVal}`); - let arrRet = []; + const arrRet = []; for (let i = 0; i < tosendtags.length; i += batchRequestsVal) { ozoneRequest.id = generateUUID(); deepSetValue(ozoneRequest, 'user.ext.eids', userExtEids); @@ -395,9 +395,9 @@ export const spec = { logInfo(`buildRequests going to return for single at time ${this.propertyBag.buildRequestsEnd} (took ${this.propertyBag.buildRequestsEnd - this.propertyBag.buildRequestsStart}ms): `, deepClone(ret)); return ret; } - let arrRet = tosendtags.map(imp => { + const arrRet = tosendtags.map(imp => { logInfo('non-single response, working on imp : ', imp); - let ozoneRequestSingle = Object.assign({}, ozoneRequest); + const ozoneRequestSingle = Object.assign({}, ozoneRequest); ozoneRequestSingle.id = generateUUID(); ozoneRequestSingle.imp = [imp]; ozoneRequestSingle.ext = extObj; @@ -424,7 +424,7 @@ export const spec = { native: deepAccess(bidRequestRef, 'mediaTypes.native.image.sizes', null) } logInfo('getFloorObjectForAuction mediaTypesSizes : ', mediaTypesSizes); - let ret = {}; + const ret = {}; if (mediaTypesSizes.banner) { ret.banner = bidRequestRef.getFloor({mediaType: 'banner', currency: 'USD', size: mediaTypesSizes.banner[0]}); } @@ -438,20 +438,20 @@ export const spec = { return ret; }, interpretResponse(serverResponse, request) { - let startTime = new Date().getTime(); + const startTime = new Date().getTime(); const bidderKey = BIDDER_CODE; const prefix = KEY_PREFIX; logInfo(`interpretResponse time: ${startTime} . Time between buildRequests done and interpretResponse start was ${startTime - this.propertyBag.buildRequestsEnd}ms`); logInfo(`serverResponse, request`, deepClone(serverResponse), deepClone(request)); serverResponse = serverResponse.body || {}; - let aucId = serverResponse.id; + const aucId = serverResponse.id; if (!serverResponse.hasOwnProperty('seatbid')) { return []; } if (typeof serverResponse.seatbid !== 'object') { return []; } - let arrAllBids = []; + const arrAllBids = []; let labels; let enhancedAdserverTargeting = config.getConfig('ozone.enhancedAdserverTargeting'); logInfo('enhancedAdserverTargeting', enhancedAdserverTargeting); @@ -461,21 +461,21 @@ export const spec = { logInfo('enhancedAdserverTargeting', enhancedAdserverTargeting); serverResponse.seatbid = injectAdIdsIntoAllBidResponses(serverResponse.seatbid); serverResponse.seatbid = this.removeSingleBidderMultipleBids(serverResponse.seatbid); - let ozOmpFloorDollars = config.getConfig('ozone.oz_omp_floor'); - let addOzOmpFloorDollars = typeof ozOmpFloorDollars === 'number'; - let ozWhitelistAdserverKeys = config.getConfig('ozone.oz_whitelist_adserver_keys'); - let useOzWhitelistAdserverKeys = isArray(ozWhitelistAdserverKeys) && ozWhitelistAdserverKeys.length > 0; + const ozOmpFloorDollars = config.getConfig('ozone.oz_omp_floor'); + const addOzOmpFloorDollars = typeof ozOmpFloorDollars === 'number'; + const ozWhitelistAdserverKeys = config.getConfig('ozone.oz_whitelist_adserver_keys'); + const useOzWhitelistAdserverKeys = isArray(ozWhitelistAdserverKeys) && ozWhitelistAdserverKeys.length > 0; for (let i = 0; i < serverResponse.seatbid.length; i++) { - let sb = serverResponse.seatbid[i]; + const sb = serverResponse.seatbid[i]; for (let j = 0; j < sb.bid.length; j++) { - let thisRequestBid = this.getBidRequestForBidId(sb.bid[j].impid, request.bidderRequest.bids); + const thisRequestBid = this.getBidRequestForBidId(sb.bid[j].impid, request.bidderRequest.bids); logInfo(`seatbid:${i}, bid:${j} Going to set default w h for seatbid/bidRequest`, sb.bid[j], thisRequestBid); - let {defaultWidth, defaultHeight} = defaultSize(thisRequestBid); - let thisBid = ozoneAddStandardProperties(sb.bid[j], defaultWidth, defaultHeight); + const {defaultWidth, defaultHeight} = defaultSize(thisRequestBid); + const thisBid = ozoneAddStandardProperties(sb.bid[j], defaultWidth, defaultHeight); thisBid.meta = {advertiserDomains: thisBid.adomain || []}; let videoContext = null; let isVideo = false; - let bidType = deepAccess(thisBid, 'ext.prebid.type'); + const bidType = deepAccess(thisBid, 'ext.prebid.type'); logInfo(`this bid type is : ${bidType}`); let adserverTargeting = {}; if (bidType === VIDEO) { @@ -491,7 +491,7 @@ export const spec = { logInfo('not an outstream video (presumably instream), will set thisBid.mediaType = VIDEO and thisBid.vastUrl and not attach a renderer'); thisBid.vastUrl = `https://${deepAccess(thisBid, 'ext.prebid.targeting.hb_cache_host', 'missing_host')}${deepAccess(thisBid, 'ext.prebid.targeting.hb_cache_path', 'missing_path')}?uuid=${deepAccess(thisBid, 'ext.prebid.targeting.hb_uuid', 'missing_uuid')}`; if (!thisBid.hasOwnProperty('videoCacheKey')) { - let videoCacheUuid = deepAccess(thisBid, 'ext.prebid.targeting.hb_uuid', 'no_hb_uuid'); + const videoCacheUuid = deepAccess(thisBid, 'ext.prebid.targeting.hb_uuid', 'no_hb_uuid'); logInfo(`Adding videoCacheKey: ${videoCacheUuid}`); thisBid.videoCacheKey = videoCacheUuid; } else { @@ -503,7 +503,7 @@ export const spec = { } adserverTargeting = Object.assign(adserverTargeting, deepAccess(thisBid, 'ext.prebid.targeting', {})); if (enhancedAdserverTargeting) { - let allBidsForThisBidid = ozoneGetAllBidsForBidId(thisBid.bidId, serverResponse.seatbid, defaultWidth, defaultHeight); + const allBidsForThisBidid = ozoneGetAllBidsForBidId(thisBid.bidId, serverResponse.seatbid, defaultWidth, defaultHeight); logInfo('Going to iterate allBidsForThisBidId', deepClone(allBidsForThisBidid)); Object.keys(allBidsForThisBidid).forEach((seat, index, ar2) => { logInfo(`adding adserverTargeting for ${seat} for bidId ${thisBid.bidId}`); @@ -522,11 +522,11 @@ export const spec = { if (isVideo) { adserverTargeting[prefix + '_' + seat + '_vid'] = videoContext; } - let flr = deepAccess(allBidsForThisBidid[seat], `ext.bidder.${bidderKey}.floor`, null); + const flr = deepAccess(allBidsForThisBidid[seat], `ext.bidder.${bidderKey}.floor`, null); if (flr != null) { adserverTargeting[prefix + '_' + seat + '_flr'] = flr; } - let rid = deepAccess(allBidsForThisBidid[seat], `ext.bidder.${bidderKey}.ruleId`, null); + const rid = deepAccess(allBidsForThisBidid[seat], `ext.bidder.${bidderKey}.ruleId`, null); if (rid != null) { adserverTargeting[prefix + '_' + seat + '_rid'] = rid; } @@ -539,7 +539,7 @@ export const spec = { } }); } else { - let perBidInfo = `${bidderKey}.enhancedAdserverTargeting is set to false. No per-bid keys will be sent to adserver.`; + const perBidInfo = `${bidderKey}.enhancedAdserverTargeting is set to false. No per-bid keys will be sent to adserver.`; if (useOzWhitelistAdserverKeys) { logWarn(`Your adserver keys whitelist will be ignored - ${perBidInfo}`); } else { @@ -588,7 +588,7 @@ export const spec = { fledgeAuctionConfigs, }; } - let endTime = new Date().getTime(); + const endTime = new Date().getTime(); logInfo(`interpretResponse going to return at time ${endTime} (took ${endTime - startTime}ms) Time from buildRequests Start -> interpretRequests End = ${endTime - this.propertyBag.buildRequestsStart}ms`); logInfo('will return: ', deepClone(ret)); return ret; @@ -604,7 +604,7 @@ export const spec = { removeSingleBidderMultipleBids(seatbid) { var ret = []; for (let i = 0; i < seatbid.length; i++) { - let sb = seatbid[i]; + const sb = seatbid[i]; var retSeatbid = {'seat': sb.seat, 'bid': []}; var bidIds = []; for (let j = 0; j < sb.bid.length; j++) { @@ -629,9 +629,9 @@ export const spec = { if (!serverResponse || serverResponse.length === 0) { return []; } - let { gppString = '', applicableSections = [] } = gppConsent; + const { gppString = '', applicableSections = [] } = gppConsent; if (optionsType.iframeEnabled) { - let arrQueryString = []; + const arrQueryString = []; if (config.getConfig('debug')) { arrQueryString.push('pbjs_debug=true'); } @@ -666,20 +666,20 @@ export const spec = { return null; }, getVideoContextForBidId(bidId, arrBids) { - let requestBid = this.getBidRequestForBidId(bidId, arrBids); + const requestBid = this.getBidRequestForBidId(bidId, arrBids); if (requestBid != null) { return deepAccess(requestBid, 'mediaTypes.video.context', 'unknown') } return null; }, findAllUserIdsFromEids(bidRequest) { - let ret = {}; + const ret = {}; if (!bidRequest.hasOwnProperty('userIdAsEids')) { logInfo('findAllUserIdsFromEids - no bidRequest.userIdAsEids object was found on the bid!'); this.tryGetPubCidFromOldLocation(ret, bidRequest); return ret; } - for (let obj of bidRequest.userIdAsEids) { + for (const obj of bidRequest.userIdAsEids) { ret[obj.source] = deepAccess(obj, 'uids.0.id'); } this.tryGetPubCidFromOldLocation(ret, bidRequest); @@ -687,7 +687,7 @@ export const spec = { }, tryGetPubCidFromOldLocation(ret, bidRequest) { if (!ret.hasOwnProperty('pubcid')) { - let pubcid = deepAccess(bidRequest, 'crumbs.pubcid'); + const pubcid = deepAccess(bidRequest, 'crumbs.pubcid'); if (pubcid) { ret['pubcid.org'] = pubcid; } @@ -697,7 +697,7 @@ export const spec = { return (bidRequest.params.placementId).toString(); }, getPlacementIdOverrideFromGetParam() { - let arr = this.getGetParametersAsObject(); + const arr = this.getGetParametersAsObject(); if (arr.hasOwnProperty(KEY_PREFIX + 'storedrequest')) { if (this.isValidPlacementId(arr[KEY_PREFIX + 'storedrequest'])) { logInfo(`using GET ${KEY_PREFIX}storedrequest=` + arr[KEY_PREFIX + 'storedrequest'] + ' to replace placementId'); @@ -709,7 +709,7 @@ export const spec = { return null; }, getGetParametersAsObject() { - let parsed = parseUrl(getRefererInfo().location); + const parsed = parseUrl(getRefererInfo().location); logInfo('getGetParametersAsObject found:', parsed.search); return parsed.search; }, @@ -724,7 +724,7 @@ export const spec = { getPageId: function() { if (this.propertyBag.pageId == null) { let randPart = ''; - let allowable = '0123456789abcdefghijklmnopqrstuvwxyz'; + const allowable = '0123456789abcdefghijklmnopqrstuvwxyz'; for (let i = 20; i > 0; i--) { randPart += allowable[Math.floor(Math.random() * 36)]; } @@ -739,7 +739,7 @@ export const spec = { return ret; }, _unpackVideoConfigIntoIABformat(ret, objConfig) { - let arrVideoKeysAllowed = ['mimes', 'minduration', 'maxduration', 'protocols', 'w', 'h', 'startdelay', 'placement', 'plcmt', 'linearity', 'skip', 'skipmin', 'skipafter', 'sequence', 'battr', 'maxextended', 'minbitrate', 'maxbitrate', 'boxingallowed', 'playbackmethod', 'playbackend', 'delivery', 'pos', 'companionad', 'api', 'companiontype']; + const arrVideoKeysAllowed = ['mimes', 'minduration', 'maxduration', 'protocols', 'w', 'h', 'startdelay', 'placement', 'plcmt', 'linearity', 'skip', 'skipmin', 'skipafter', 'sequence', 'battr', 'maxextended', 'minbitrate', 'maxbitrate', 'boxingallowed', 'playbackmethod', 'playbackend', 'delivery', 'pos', 'companionad', 'api', 'companiontype']; for (const key in objConfig) { var found = false; arrVideoKeysAllowed.forEach(function(arg) { @@ -782,7 +782,7 @@ export const spec = { return objRet; }, getLoggableBidObject(bid) { - let logObj = { + const logObj = { ad: bid.ad, adId: bid.adId, adUnitCode: bid.adUnitCode, @@ -817,7 +817,7 @@ export const spec = { export function injectAdIdsIntoAllBidResponses(seatbid) { logInfo('injectAdIdsIntoAllBidResponses', deepClone(seatbid)); for (let i = 0; i < seatbid.length; i++) { - let sb = seatbid[i]; + const sb = seatbid[i]; for (let j = 0; j < sb.bid.length; j++) { sb.bid[j]['adId'] = `${sb.bid[j]['impid']}-${i}-${KEY_PREFIX}-${j}`; } @@ -843,8 +843,8 @@ export function ozoneGetWinnerForRequestBid(requestBidId, serverResponseSeatBid) let thisBidWinner = null; let winningSeat = null; for (let j = 0; j < serverResponseSeatBid.length; j++) { - let theseBids = serverResponseSeatBid[j].bid; - let thisSeat = serverResponseSeatBid[j].seat; + const theseBids = serverResponseSeatBid[j].bid; + const thisSeat = serverResponseSeatBid[j].seat; for (let k = 0; k < theseBids.length; k++) { if (theseBids[k].impid === requestBidId) { if ((thisBidWinner == null) || (thisBidWinner.price < theseBids[k].price)) { @@ -858,10 +858,10 @@ export function ozoneGetWinnerForRequestBid(requestBidId, serverResponseSeatBid) return {'seat': winningSeat, 'bid': thisBidWinner}; } export function ozoneGetAllBidsForBidId(matchBidId, serverResponseSeatBid, defaultWidth, defaultHeight) { - let objBids = {}; + const objBids = {}; for (let j = 0; j < serverResponseSeatBid.length; j++) { - let theseBids = serverResponseSeatBid[j].bid; - let thisSeat = serverResponseSeatBid[j].seat; + const theseBids = serverResponseSeatBid[j].bid; + const thisSeat = serverResponseSeatBid[j].seat; for (let k = 0; k < theseBids.length; k++) { if (theseBids[k].impid === matchBidId) { if (objBids.hasOwnProperty(thisSeat)) { diff --git a/modules/paapi.js b/modules/paapi.js index 3c598cb0902..e67b24bdcfc 100644 --- a/modules/paapi.js +++ b/modules/paapi.js @@ -591,7 +591,7 @@ function callAdapterApi(spec, method, bids, bidderRequest) { */ export function parallelPaapiProcessing(next, spec, bids, bidderRequest, ...args) { function makeDeferrals(defaults = {}) { - let promises = {}; + const promises = {}; const deferrals = Object.fromEntries(ASYNC_SIGNALS.map(signal => { const def = defer({promiseFactory: (resolver) => new Promise(resolver)}); def.default = defaults.hasOwnProperty(signal) ? defaults[signal] : null; diff --git a/modules/pairIdSystem.js b/modules/pairIdSystem.js index 778857bae1c..b71822c5b44 100644 --- a/modules/pairIdSystem.js +++ b/modules/pairIdSystem.js @@ -69,7 +69,7 @@ export const pairIdSubmodule = { const configParams = (config && config.params) || {}; if (configParams && configParams.liveramp) { - let LRStorageLocation = configParams.liveramp.storageKey || DEFAULT_LIVERAMP_PAIR_ID_KEY; + const LRStorageLocation = configParams.liveramp.storageKey || DEFAULT_LIVERAMP_PAIR_ID_KEY; const liverampValue = pairIdFromLocalStorage(LRStorageLocation) || pairIdFromCookie(LRStorageLocation); if (liverampValue) { diff --git a/modules/performaxBidAdapter.js b/modules/performaxBidAdapter.js index a765c4d9d78..48dd4366f1d 100644 --- a/modules/performaxBidAdapter.js +++ b/modules/performaxBidAdapter.js @@ -39,7 +39,7 @@ export const spec = { }, buildRequests: function (bidRequests, bidderRequest) { - let data = converter.toORTB({bidderRequest, bidRequests}) + const data = converter.toORTB({bidderRequest, bidRequests}) return [{ method: 'POST', url: ENDPOINT, diff --git a/modules/permutiveRtdProvider.js b/modules/permutiveRtdProvider.js index 54f14fba027..cd3c45c73eb 100644 --- a/modules/permutiveRtdProvider.js +++ b/modules/permutiveRtdProvider.js @@ -164,7 +164,7 @@ function updateOrtbConfig(bidder, currConfig, segmentIDs, sspSegmentIDs, topics, const ortbConfig = mergeDeep({}, currConfig) const currentUserData = deepAccess(ortbConfig, 'ortb2.user.data') || [] - let topicsUserData = [] + const topicsUserData = [] for (const [k, value] of Object.entries(topics)) { topicsUserData.push({ name, diff --git a/modules/pilotxBidAdapter.js b/modules/pilotxBidAdapter.js index f06f2e71dcc..1aa22231a32 100644 --- a/modules/pilotxBidAdapter.js +++ b/modules/pilotxBidAdapter.js @@ -20,8 +20,8 @@ export const spec = { * @return boolean True if this is a valid bid, and false otherwise. */ isBidRequestValid: function (bid) { - let sizesCheck = !!bid.sizes - let paramSizesCheck = !!bid.params.sizes + const sizesCheck = !!bid.sizes + const paramSizesCheck = !!bid.params.sizes var sizeConfirmed = false if (sizesCheck) { if (bid.sizes.length < 1) { @@ -50,10 +50,10 @@ export const spec = { * @return {Object} Info describing the request to the server. */ buildRequests: function (validBidRequests, bidderRequest) { - let payloadItems = {}; + const payloadItems = {}; validBidRequests.forEach(bidRequest => { - let sizes = []; - let placementId = this.setPlacementID(bidRequest.params.placementId) + const sizes = []; + const placementId = this.setPlacementID(bidRequest.params.placementId) payloadItems[placementId] = {} if (bidRequest.sizes.length > 0) { if (Array.isArray(bidRequest.sizes[0])) { @@ -66,7 +66,7 @@ export const spec = { payloadItems[placementId]['sizes'] = sizes } if (bidRequest.mediaTypes != null) { - for (let i in bidRequest.mediaTypes) { + for (const i in bidRequest.mediaTypes) { payloadItems[placementId][i] = { ...bidRequest.mediaTypes[i] } diff --git a/modules/pixfutureBidAdapter.js b/modules/pixfutureBidAdapter.js index d26a1a1c310..145f85956d7 100644 --- a/modules/pixfutureBidAdapter.js +++ b/modules/pixfutureBidAdapter.js @@ -57,9 +57,9 @@ export const spec = { Object.keys(userObjBid.params.user) .filter(param => USER_PARAMS.includes(param)) .forEach((param) => { - let uparam = convertCamelToUnderscore(param); + const uparam = convertCamelToUnderscore(param); if (param === 'segments' && isArray(userObjBid.params.user[param])) { - let segs = []; + const segs = []; userObjBid.params.user[param].forEach(val => { if (isNumber(val)) { segs.push({'id': val}); @@ -91,7 +91,7 @@ export const spec = { } if (bidderRequest && bidderRequest.refererInfo) { - let refererinfo = { + const refererinfo = { // TODO: this collects everything it finds, except for canonicalUrl rd_ref: encodeURIComponent(bidderRequest.refererInfo.topmostLocation), rd_top: bidderRequest.refererInfo.reachedTop, @@ -102,7 +102,7 @@ export const spec = { } if (validBidRequests[0].userId) { - let eids = []; + const eids = []; addUserId(eids, deepAccess(validBidRequests[0], `userId.criteoId`), 'criteo.com', null); addUserId(eids, deepAccess(validBidRequests[0], `userId.unifiedId`), 'thetradedesk.com', null); @@ -168,8 +168,8 @@ export const spec = { const syncs = []; let syncurl = 'pixid=' + pixID; - let gdpr = (gdprConsent && gdprConsent.gdprApplies) ? 1 : 0; - let consent = gdprConsent ? encodeURIComponent(gdprConsent.consentString || '') : ''; + const gdpr = (gdprConsent && gdprConsent.gdprApplies) ? 1 : 0; + const consent = gdprConsent ? encodeURIComponent(gdprConsent.consentString || '') : ''; // Attaching GDPR Consent Params in UserSync url syncurl += '&gdprconcent=' + gdpr + '&adsync=' + consent; @@ -240,14 +240,14 @@ function bidToTag(bid) { tag.use_pmt_rule = bid.params.usePaymentRule || false; tag.prebid = true; tag.disable_psa = true; - let bidFloor = getBidFloor(bid); + const bidFloor = getBidFloor(bid); if (bidFloor) { tag.reserve = bidFloor; } if (bid.params.position) { tag.position = {'above': 1, 'below': 2}[bid.params.position] || 0; } else { - let mediaTypePos = deepAccess(bid, `mediaTypes.banner.pos`) || deepAccess(bid, `mediaTypes.video.pos`); + const mediaTypePos = deepAccess(bid, `mediaTypes.banner.pos`) || deepAccess(bid, `mediaTypes.video.pos`); // only support unknown, atf, and btf values for position at this time if (mediaTypePos === 0 || mediaTypePos === 1 || mediaTypePos === 3) { // ortb spec treats btf === 3, but our system interprets btf === 2; so converting the ortb value here for consistency @@ -277,7 +277,7 @@ function bidToTag(bid) { } tag.keywords = getANKeywordParam(bid.ortb2, bid.params.keywords) - let gpid = deepAccess(bid, 'ortb2Imp.ext.gpid'); + const gpid = deepAccess(bid, 'ortb2Imp.ext.gpid'); if (gpid) { tag.gpid = gpid; } @@ -290,7 +290,7 @@ function bidToTag(bid) { tag['banner_frameworks'] = bid.params.frameworks; } // TODO: why does this need to iterate through every adUnit? - let adUnit = ((auctionManager.getAdUnits()) || []).find(au => bid.transactionId === au.transactionId); + const adUnit = ((auctionManager.getAdUnits()) || []).find(au => bid.transactionId === au.transactionId); if (adUnit && adUnit.mediaTypes && adUnit.mediaTypes.banner) { tag.ad_types.push(BANNER); } diff --git a/modules/prebidServerBidAdapter/index.ts b/modules/prebidServerBidAdapter/index.ts index f04ca507d05..06c5244f8db 100644 --- a/modules/prebidServerBidAdapter/index.ts +++ b/modules/prebidServerBidAdapter/index.ts @@ -194,7 +194,7 @@ function validateConfigRequiredProps(s2sConfig: S2SConfig) { function formatUrlParams(option) { ['endpoint', 'syncEndpoint'].forEach((prop) => { if (isStr(option[prop])) { - let temp = option[prop]; + const temp = option[prop]; option[prop] = { p1Consent: temp, noP1Consent: temp }; } if (isPlainObject(option[prop]) && (!option[prop].p1Consent || !option[prop].noP1Consent)) { @@ -283,7 +283,7 @@ function queueSync(bidderCodes, gdprConsent, uspConsent, gppConsent, s2sConfig: filterSettings }; - let userSyncLimit = s2sConfig.userSyncLimit; + const userSyncLimit = s2sConfig.userSyncLimit; if (isNumber(userSyncLimit) && userSyncLimit > 0) { payload['limit'] = userSyncLimit; } @@ -394,7 +394,7 @@ function doBidderSync(type, url, bidder, done, timeout) { */ function doClientSideSyncs(bidders, gdprConsent, uspConsent, gppConsent) { bidders.forEach(bidder => { - let clientAdapter = adapterManager.getBidAdapter(bidder); + const clientAdapter = adapterManager.getBidAdapter(bidder); if (clientAdapter && clientAdapter.registerSyncs) { config.runWithBidder( bidder, @@ -478,12 +478,12 @@ export function PrebidServer() { done = adapterMetrics.startTiming('total').stopBefore(done); bidRequests.forEach(req => useMetrics(req.metrics).join(adapterMetrics, {stopPropagation: true})); - let { gdprConsent, uspConsent, gppConsent } = getConsentData(bidRequests); + const { gdprConsent, uspConsent, gppConsent } = getConsentData(bidRequests); if (Array.isArray(_s2sConfigs)) { if (s2sBidRequest.s2sConfig && s2sBidRequest.s2sConfig.syncEndpoint && getMatchingConsentUrl(s2sBidRequest.s2sConfig.syncEndpoint, gdprConsent)) { const s2sAliases = (s2sBidRequest.s2sConfig.extPrebid && s2sBidRequest.s2sConfig.extPrebid.aliases) ?? {}; - let syncBidders = s2sBidRequest.s2sConfig.bidders + const syncBidders = s2sBidRequest.s2sConfig.bidders .map(bidder => adapterManager.aliasRegistry[bidder] || s2sAliases[bidder] || bidder) .filter((bidder, index, array) => (array.indexOf(bidder) === index)); @@ -577,7 +577,7 @@ type PbsRequestData = { * @param onBid {function({})} invoked once for each bid in the response - with the bid as returned by interpretResponse */ export const processPBSRequest = hook('async', function (s2sBidRequest, bidRequests, ajax, {onResponse, onError, onBid, onFledge}) { - let { gdprConsent } = getConsentData(bidRequests); + const { gdprConsent } = getConsentData(bidRequests); const adUnits = deepClone(s2sBidRequest.ad_units); // in case config.bidders contains invalid bidders, we only process those we sent requests for diff --git a/modules/prebidServerBidAdapter/ortbConverter.js b/modules/prebidServerBidAdapter/ortbConverter.js index 003bf2e9235..36c0b9959d1 100644 --- a/modules/prebidServerBidAdapter/ortbConverter.js +++ b/modules/prebidServerBidAdapter/ortbConverter.js @@ -59,7 +59,7 @@ const PBS_CONVERTER = ortbConverter({ if (!imps.length) { logError('Request to Prebid Server rejected due to invalid media type(s) in adUnit.'); } else { - let {s2sBidRequest} = context; + const {s2sBidRequest} = context; const request = buildRequest(imps, proxyBidderRequest, context); request.tmax = Math.floor(s2sBidRequest.s2sConfig.timeout ?? Math.min(s2sBidRequest.requestBidsTimeout * 0.75, s2sBidRequest.s2sConfig.maxTimeout ?? s2sDefaultConfig.maxTimeout)); diff --git a/modules/priceFloors.ts b/modules/priceFloors.ts index b683f39ac34..7e6778b82de 100644 --- a/modules/priceFloors.ts +++ b/modules/priceFloors.ts @@ -135,7 +135,7 @@ function enumeratePossibleFieldValues(floorFields, bidObject, responseObject) { if (!floorFields.length) return []; // generate combination of all exact matches and catch all for each field type return floorFields.reduce((accum, field) => { - let exactMatch = fieldMatchingFunctions[field](bidObject, responseObject) || '*'; + const exactMatch = fieldMatchingFunctions[field](bidObject, responseObject) || '*'; // storing exact matches as lowerCase since we want to compare case insensitively accum.push(exactMatch === '*' ? ['*'] : [exactMatch.toLowerCase(), '*']); return accum; @@ -147,22 +147,22 @@ function enumeratePossibleFieldValues(floorFields, bidObject, responseObject) { * Generates all possible rule matches and picks the first matching one. */ export function getFirstMatchingFloor(floorData, bidObject, responseObject = {}) { - let fieldValues = enumeratePossibleFieldValues(deepAccess(floorData, 'schema.fields') || [], bidObject, responseObject); + const fieldValues = enumeratePossibleFieldValues(deepAccess(floorData, 'schema.fields') || [], bidObject, responseObject); if (!fieldValues.length) { return {matchingFloor: undefined} } // look to see if a request for this context was made already - let matchingInput = fieldValues.map(field => field[0]).join('-'); + const matchingInput = fieldValues.map(field => field[0]).join('-'); // if we already have gotten the matching rule from this matching input then use it! No need to look again - let previousMatch = deepAccess(floorData, `matchingInputs.${matchingInput}`); + const previousMatch = deepAccess(floorData, `matchingInputs.${matchingInput}`); if (previousMatch) { return {...previousMatch}; } - let allPossibleMatches = generatePossibleEnumerations(fieldValues, deepAccess(floorData, 'schema.delimiter') || '|'); - let matchingRule = ((allPossibleMatches) || []).find(hashValue => floorData.values.hasOwnProperty(hashValue)); + const allPossibleMatches = generatePossibleEnumerations(fieldValues, deepAccess(floorData, 'schema.delimiter') || '|'); + const matchingRule = ((allPossibleMatches) || []).find(hashValue => floorData.values.hasOwnProperty(hashValue)); - let matchingData: any = { + const matchingData: any = { floorMin: floorData.floorMin || 0, floorRuleValue: floorData.values[matchingRule], matchingData: allPossibleMatches[0], // the first possible match is an "exact" so contains all data relevant for anlaytics adapters @@ -186,7 +186,7 @@ export function getFirstMatchingFloor(floorData, bidObject, responseObject = {}) */ function generatePossibleEnumerations(arrayOfFields, delimiter) { return arrayOfFields.reduce((accum, currentVal) => { - let ret = []; + const ret = []; accum.map(obj => { currentVal.map(obj1 => { ret.push(obj + delimiter + obj1) @@ -227,7 +227,7 @@ const getMediaTypesSizes = { */ function updateRequestParamsFromContext(bidRequest, requestParams) { // if adapter asks for *'s then we can do some logic to infer if we can get a more specific rule based on context of bid - let mediaTypesOnBid = Object.keys(bidRequest.mediaTypes || {}); + const mediaTypesOnBid = Object.keys(bidRequest.mediaTypes || {}); // if there is only one mediaType then we can just use it if (requestParams.mediaType === '*' && mediaTypesOnBid.length === 1) { requestParams.mediaType = mediaTypesOnBid[0]; @@ -266,12 +266,12 @@ declare module '../src/bidderSettings' { */ export function getFloor(requestParams: GetFloorParams = {currency: 'USD', mediaType: '*', size: '*'}) { // eslint-disable-next-line @typescript-eslint/no-this-alias - let bidRequest = this; - let floorData = _floorDataForAuction[bidRequest.auctionId]; + const bidRequest = this; + const floorData = _floorDataForAuction[bidRequest.auctionId]; if (!floorData || floorData.skipped) return {}; requestParams = updateRequestParamsFromContext(bidRequest, requestParams); - let floorInfo = getFirstMatchingFloor(floorData.data, {...bidRequest}, {mediaType: requestParams.mediaType, size: requestParams.size}); + const floorInfo = getFirstMatchingFloor(floorData.data, {...bidRequest}, {mediaType: requestParams.mediaType, size: requestParams.size}); let currency = requestParams.currency || floorData.data.currency; // if bidder asked for a currency which is not what floors are set in convert @@ -295,7 +295,7 @@ export function getFloor(requestParams: GetFloorParams = {currency: 'USD', media ); floorInfo.matchingFloor = inverseFunction(floorInfo.matchingFloor, bidRequest, definedParams); } else { - let cpmAdjustment = getBiddersCpmAdjustment(floorInfo.matchingFloor, null, bidRequest); + const cpmAdjustment = getBiddersCpmAdjustment(floorInfo.matchingFloor, null, bidRequest); floorInfo.matchingFloor = cpmAdjustment ? calculateAdjustedFloor(floorInfo.matchingFloor, cpmAdjustment) : floorInfo.matchingFloor; } } @@ -316,7 +316,7 @@ export function getFloor(requestParams: GetFloorParams = {currency: 'USD', media * @summary Takes a floorsData object and converts it into a hash map with appropriate keys */ export function getFloorsDataForAuction(floorData, adUnitCode?) { - let auctionFloorData = deepClone(floorData); + const auctionFloorData = deepClone(floorData); auctionFloorData.schema.delimiter = floorData.schema.delimiter || '|'; auctionFloorData.values = normalizeRulesForAuction(auctionFloorData, adUnitCode); // default the currency to USD if not passed in @@ -328,13 +328,13 @@ export function getFloorsDataForAuction(floorData, adUnitCode?) { * @summary if adUnitCode needs to be added to the offset then it will add it else just return the values */ function normalizeRulesForAuction(floorData, adUnitCode) { - let fields = floorData.schema.fields; - let delimiter = floorData.schema.delimiter + const fields = floorData.schema.fields; + const delimiter = floorData.schema.delimiter // if we are building the floor data form an ad unit, we need to append adUnit code as to not cause collisions - let prependAdUnitCode = adUnitCode && fields.indexOf('adUnitCode') === -1 && fields.unshift('adUnitCode'); + const prependAdUnitCode = adUnitCode && fields.indexOf('adUnitCode') === -1 && fields.unshift('adUnitCode'); return Object.keys(floorData.values).reduce((rulesHash, oldKey) => { - let newKey = prependAdUnitCode ? `${adUnitCode}${delimiter}${oldKey}` : oldKey + const newKey = prependAdUnitCode ? `${adUnitCode}${delimiter}${oldKey}` : oldKey // we store the rule keys as lower case for case insensitive compare rulesHash[newKey.toLowerCase()] = floorData.values[oldKey]; return rulesHash; @@ -359,7 +359,7 @@ export function getFloorDataFromAdUnits(adUnits) { accum = getFloorsDataForAuction(floors, adUnit.code); accum.location = 'adUnit'; } else { - let newRules = getFloorsDataForAuction(floors, adUnit.code).values; + const newRules = getFloorsDataForAuction(floors, adUnit.code).values; // copy over the new rules into our values object Object.assign(accum.values, newRules); } @@ -432,16 +432,16 @@ export function pickRandomModel(modelGroups, weightSum) { * @summary Updates the adUnits accordingly and returns the necessary floorsData for the current auction */ export function createFloorsDataForAuction(adUnits, auctionId) { - let resolvedFloorsData = deepClone(_floorsConfig); + const resolvedFloorsData = deepClone(_floorsConfig); // if using schema 2 pick a model here: if (deepAccess(resolvedFloorsData, 'data.floorsSchemaVersion') === 2) { // merge the models specific stuff into the top level data settings (now it looks like floorsSchemaVersion 1!) - let { modelGroups, ...rest } = resolvedFloorsData.data; + const { modelGroups, ...rest } = resolvedFloorsData.data; resolvedFloorsData.data = Object.assign(rest, pickRandomModel(modelGroups, rest.modelWeightSum)); } // if we do not have a floors data set, we will try to use data set on adUnits - let useAdUnitData = Object.keys(deepAccess(resolvedFloorsData, 'data.values') || {}).length === 0; + const useAdUnitData = Object.keys(deepAccess(resolvedFloorsData, 'data.values') || {}).length === 0; if (useAdUnitData) { resolvedFloorsData.data = getFloorDataFromAdUnits(adUnits); } else { @@ -664,7 +664,7 @@ export function generateAndHandleFetch(floorEndpoint) { // if a fetch url is defined and one is not already occurring, fire it! if (floorEndpoint.url && !fetching) { // default to GET and we only support GET for now - let requestMethod = floorEndpoint.method || 'GET'; + const requestMethod = floorEndpoint.method || 'GET'; if (requestMethod !== 'GET') { logError(`${MODULE_NAME}: 'GET' is the only request method supported at this time!`); } else { @@ -904,7 +904,7 @@ function addFloorDataToBid(floorData, floorInfo, bid: Partial, adjustedCpm) matchedFields: {} }; floorData.data.schema.fields.forEach((field, index) => { - let matchedValue = floorInfo.matchingData.split(floorData.data.schema.delimiter)[index]; + const matchedValue = floorInfo.matchingData.split(floorData.data.schema.delimiter)[index]; bid.floorData.matchedFields[field] = matchedValue; }); } @@ -913,9 +913,9 @@ function addFloorDataToBid(floorData, floorInfo, bid: Partial, adjustedCpm) * @summary takes the enforcement flags and the bid itself and determines if it should be floored */ function shouldFloorBid(floorData, floorInfo, bid) { - let enforceJS = deepAccess(floorData, 'enforcement.enforceJS') !== false; - let shouldFloorDeal = deepAccess(floorData, 'enforcement.floorDeals') === true || !bid.dealId; - let bidBelowFloor = bid.floorData.cpmAfterAdjustments < floorInfo.matchingFloor; + const enforceJS = deepAccess(floorData, 'enforcement.enforceJS') !== false; + const shouldFloorDeal = deepAccess(floorData, 'enforcement.floorDeals') === true || !bid.dealId; + const bidBelowFloor = bid.floorData.cpmAfterAdjustments < floorInfo.matchingFloor; return enforceJS && (bidBelowFloor && shouldFloorDeal); } @@ -924,7 +924,7 @@ function shouldFloorBid(floorData, floorInfo, bid) { * And if the rule we find determines a bid should be floored we will do so. */ export const addBidResponseHook = timedBidResponseHook('priceFloors', function addBidResponseHook(fn, adUnitCode, bid, reject) { - let floorData = _floorDataForAuction[bid.auctionId]; + const floorData = _floorDataForAuction[bid.auctionId]; // if no floor data then bail if (!floorData || !bid || floorData.skipped) { return fn.call(this, adUnitCode, bid, reject); @@ -933,7 +933,7 @@ export const addBidResponseHook = timedBidResponseHook('priceFloors', function a const matchingBidRequest = auctionManager.index.getBidRequest(bid); // get the matching rule - let floorInfo = getFirstMatchingFloor(floorData.data, matchingBidRequest, {...bid, size: [bid.width, bid.height]}); + const floorInfo = getFirstMatchingFloor(floorData.data, matchingBidRequest, {...bid, size: [bid.width, bid.height]}); if (!floorInfo.matchingFloor) { if (floorInfo.matchingFloor !== 0) logWarn(`${MODULE_NAME}: unable to determine a matching price floor for bidResponse`, bid); @@ -942,8 +942,8 @@ export const addBidResponseHook = timedBidResponseHook('priceFloors', function a // determine the base cpm to use based on if the currency matches the floor currency let adjustedCpm; - let floorCurrency = floorData.data.currency.toUpperCase(); - let bidResponseCurrency = bid.currency || 'USD'; // if an adapter does not set a bid currency and currency module not on it may come in as undefined + const floorCurrency = floorData.data.currency.toUpperCase(); + const bidResponseCurrency = bid.currency || 'USD'; // if an adapter does not set a bid currency and currency module not on it may come in as undefined if (floorCurrency === bidResponseCurrency.toUpperCase()) { adjustedCpm = bid.cpm; } else if (bid.originalCurrency && floorCurrency === bid.originalCurrency.toUpperCase()) { diff --git a/modules/programmaticaBidAdapter.js b/modules/programmaticaBidAdapter.js index aeca74120d6..efc9450d9b7 100644 --- a/modules/programmaticaBidAdapter.js +++ b/modules/programmaticaBidAdapter.js @@ -13,15 +13,15 @@ export const spec = { code: BIDDER_CODE, isBidRequestValid: function(bid) { - let valid = bid.params.siteId && bid.params.placementId; + const valid = bid.params.siteId && bid.params.placementId; return !!valid; }, buildRequests: function(validBidRequests, bidderRequest) { - let requests = []; + const requests = []; for (const bid of validBidRequests) { - let endpoint = bid.params.endpoint || DEFAULT_ENDPOINT; + const endpoint = bid.params.endpoint || DEFAULT_ENDPOINT; requests.push({ method: 'GET', @@ -51,7 +51,7 @@ export const spec = { let width; let height; - let sizes = getSize(body.size); + const sizes = getSize(body.size); if (isArray(sizes)) { [width, height] = sizes; } diff --git a/modules/pstudioBidAdapter.js b/modules/pstudioBidAdapter.js index cc9310e174b..acb18fb7c77 100644 --- a/modules/pstudioBidAdapter.js +++ b/modules/pstudioBidAdapter.js @@ -80,7 +80,7 @@ export const spec = { serverResponse.body.bids.map((bid) => { const { cpm, width, height, currency, ad, meta } = bid; - let bidResponse = { + const bidResponse = { requestId: id, cpm, width, @@ -132,7 +132,7 @@ export const spec = { }; function buildRequestData(bid, bidderRequest) { - let payloadObject = buildBaseObject(bid, bidderRequest); + const payloadObject = buildBaseObject(bid, bidderRequest); if (bid.mediaTypes.banner) { return buildBannerObject(bid, payloadObject); @@ -371,7 +371,7 @@ function prepareFirstPartyData({ user, device, site, app, regs }) { } function cleanObject(data) { - for (let key in data) { + for (const key in data) { if (typeof data[key] == 'object') { cleanObject(data[key]); diff --git a/modules/pubgeniusBidAdapter.js b/modules/pubgeniusBidAdapter.js index 7cb4d2df127..6267d0c9225 100644 --- a/modules/pubgeniusBidAdapter.js +++ b/modules/pubgeniusBidAdapter.js @@ -117,7 +117,7 @@ export const spec = { const syncs = [] if (syncOptions.iframeEnabled) { - let params = {}; + const params = {}; if (gdprConsent) { params.gdpr = numericBoolean(gdprConsent.gdprApplies); diff --git a/modules/publinkIdSystem.js b/modules/publinkIdSystem.js index 875f6592c04..09981498877 100644 --- a/modules/publinkIdSystem.js +++ b/modules/publinkIdSystem.js @@ -32,7 +32,7 @@ function isHex(s) { } function publinkIdUrl(params, consentData, storedId) { - let url = parseUrl('https://proc.ad.cpe.dotomi.com' + PUBLINK_REFRESH_PATH); + const url = parseUrl('https://proc.ad.cpe.dotomi.com' + PUBLINK_REFRESH_PATH); url.search = { mpn: 'Prebid.js', mpv: '$prebid.version$', @@ -70,9 +70,9 @@ function publinkIdUrl(params, consentData, storedId) { function makeCallback(config = {}, consentData, storedId) { return function(prebidCallback) { const options = {method: 'GET', withCredentials: true}; - let handleResponse = function(responseText, xhr) { + const handleResponse = function(responseText, xhr) { if (xhr.status === 200) { - let response = JSON.parse(responseText); + const response = JSON.parse(responseText); if (response) { prebidCallback(response.publink); } diff --git a/modules/publirBidAdapter.js b/modules/publirBidAdapter.js index 2cf55aa86cb..720c78dfa22 100644 --- a/modules/publirBidAdapter.js +++ b/modules/publirBidAdapter.js @@ -44,7 +44,7 @@ export const spec = { combinedRequestsObject.bids = generateBidsParams(validBidRequests, bidderRequest); combinedRequestsObject.bids.timestamp = timestamp(); - let options = { + const options = { withCredentials: false }; diff --git a/modules/pubmaticAnalyticsAdapter.js b/modules/pubmaticAnalyticsAdapter.js index 2053744bed9..d53e0654d41 100755 --- a/modules/pubmaticAnalyticsAdapter.js +++ b/modules/pubmaticAnalyticsAdapter.js @@ -198,7 +198,7 @@ function parseBidResponse(bid) { } function getDomainFromUrl(url) { - let a = window.document.createElement('a'); + const a = window.document.createElement('a'); a.href = url; return a.hostname; } @@ -249,10 +249,10 @@ function getAdapterNameForAlias(aliasName) { function getAdDomain(bidResponse) { if (bidResponse.meta && bidResponse.meta.advertiserDomains) { - let adomain = bidResponse.meta.advertiserDomains[0] + const adomain = bidResponse.meta.advertiserDomains[0] if (adomain) { try { - let hostname = (new URL(adomain)); + const hostname = (new URL(adomain)); return hostname.hostname.replace('www.', ''); } catch (e) { logWarn(LOG_PRE_FIX + 'Adomain URL (Not a proper URL):', adomain); @@ -299,8 +299,8 @@ function isS2SBidder(bidder) { } function isOWPubmaticBid(adapterName) { - let s2sConf = config.getConfig('s2sConfig'); - let s2sConfArray = s2sConf ? (isArray(s2sConf) ? s2sConf : [s2sConf]) : []; + const s2sConf = config.getConfig('s2sConfig'); + const s2sConfArray = s2sConf ? (isArray(s2sConf) ? s2sConf : [s2sConf]) : []; return s2sConfArray.some(conf => { if (adapterName === ADAPTER_CODE && conf.defaultVendor === VENDOR_OPENWRAP && conf.bidders.indexOf(ADAPTER_CODE) > -1) { @@ -338,7 +338,7 @@ function gatherPartnerBidsForAdUnitForLogger(adUnit, adUnitId, highestBid, e) { highestBid = (highestBid && highestBid.length > 0) ? highestBid[0] : null; return Object.keys(adUnit.bids).reduce(function(partnerBids, bidId) { adUnit.bids[bidId].forEach(function(bid) { - let adapterName = getAdapterNameForAlias(bid.adapterCode || bid.bidder); + const adapterName = getAdapterNameForAlias(bid.adapterCode || bid.bidder); if (isOWPubmaticBid(adapterName) && isS2SBidder(bid.bidder)) { return; } @@ -451,13 +451,13 @@ function getListOfIdentityPartners() { } function executeBidsLoggerCall(e, highestCpmBids) { - let auctionId = e.auctionId; - let referrer = config.getConfig('pageUrl') || cache.auctions[auctionId]?.referer || ''; - let auctionCache = cache.auctions[auctionId]; - let wiid = auctionCache?.wiid || auctionId; - let floorData = auctionCache?.floorData; - let floorFetchStatus = getFloorFetchStatus(floorData); - let outputObj = { s: [] }; + const auctionId = e.auctionId; + const referrer = config.getConfig('pageUrl') || cache.auctions[auctionId]?.referer || ''; + const auctionCache = cache.auctions[auctionId]; + const wiid = auctionCache?.wiid || auctionId; + const floorData = auctionCache?.floorData; + const floorFetchStatus = getFloorFetchStatus(floorData); + const outputObj = { s: [] }; let pixelURL = END_POINT_BID_LOGGER; const country = e.bidderRequests?.length > 0 @@ -504,10 +504,10 @@ function executeBidsLoggerCall(e, highestCpmBids) { } outputObj.s = Object.keys(auctionCache.adUnitCodes).reduce(function(slotsArray, adUnitId) { - let adUnit = auctionCache.adUnitCodes[adUnitId]; - let origAdUnit = getAdUnit(auctionCache.origAdUnits, adUnitId) || {}; + const adUnit = auctionCache.adUnitCodes[adUnitId]; + const origAdUnit = getAdUnit(auctionCache.origAdUnits, adUnitId) || {}; // getGptSlotInfoForAdUnitCode returns gptslot corresponding to adunit provided as input. - let slotObject = { + const slotObject = { 'sn': adUnitId, 'au': origAdUnit.owAdUnitId || getGptSlotInfoForAdUnitCode(adUnitId)?.gptSlot || adUnitId, 'mt': getAdUnitAdFormats(origAdUnit), @@ -551,15 +551,15 @@ function executeBidWonLoggerCall(auctionId, adUnitId) { if (isOWPubmaticBid(adapterName) && isS2SBidder(winningBid.bidder)) { return; } - let origAdUnit = getAdUnit(cache.auctions[auctionId]?.origAdUnits, adUnitId) || {}; - let owAdUnitId = origAdUnit.owAdUnitId || getGptSlotInfoForAdUnitCode(adUnitId)?.gptSlot || adUnitId; - let auctionCache = cache.auctions[auctionId]; - let floorData = auctionCache?.floorData; - let wiid = cache.auctions[auctionId]?.wiid || auctionId; - let referrer = config.getConfig('pageUrl') || cache.auctions[auctionId]?.referer || ''; - let adv = winningBid.bidResponse ? getAdDomain(winningBid.bidResponse) || undefined : undefined; - let fskp = floorData ? (floorData.floorRequestData ? (floorData.floorRequestData.skipped == false ? 0 : 1) : undefined) : undefined; - let pg = window.parseFloat(Number(winningBid?.bidResponse?.adserverTargeting?.hb_pb || winningBid?.bidResponse?.adserverTargeting?.pwtpb)) || undefined; + const origAdUnit = getAdUnit(cache.auctions[auctionId]?.origAdUnits, adUnitId) || {}; + const owAdUnitId = origAdUnit.owAdUnitId || getGptSlotInfoForAdUnitCode(adUnitId)?.gptSlot || adUnitId; + const auctionCache = cache.auctions[auctionId]; + const floorData = auctionCache?.floorData; + const wiid = cache.auctions[auctionId]?.wiid || auctionId; + const referrer = config.getConfig('pageUrl') || cache.auctions[auctionId]?.referer || ''; + const adv = winningBid.bidResponse ? getAdDomain(winningBid.bidResponse) || undefined : undefined; + const fskp = floorData ? (floorData.floorRequestData ? (floorData.floorRequestData.skipped == false ? 0 : 1) : undefined) : undefined; + const pg = window.parseFloat(Number(winningBid?.bidResponse?.adserverTargeting?.hb_pb || winningBid?.bidResponse?.adserverTargeting?.pwtpb)) || undefined; let pixelURL = END_POINT_WIN_BID_LOGGER; pixelURL += 'pubid=' + publisherId; @@ -633,9 +633,9 @@ function executeBidWonLoggerCall(auctionId, adUnitId) { function auctionInitHandler(args) { s2sBidders = (function () { - let s2sBidders = []; + const s2sBidders = []; try { - let s2sConf = config.getConfig('s2sConfig'); + const s2sConf = config.getConfig('s2sConfig'); if (isArray(s2sConf)) { s2sConf.forEach(conf => { if (conf?.bidders) { @@ -650,7 +650,7 @@ function auctionInitHandler(args) { } return s2sBidders || []; }()); - let cacheEntry = pick(args, [ + const cacheEntry = pick(args, [ 'timestamp', 'timeout', 'bidderDonePendingCount', () => args.bidderRequests.length, @@ -686,7 +686,7 @@ function bidResponseHandler(args) { logWarn(LOG_PRE_FIX + 'Got null requestId in bidResponseHandler'); return; } - let requestId = args.originalRequestId || args.requestId; + const requestId = args.originalRequestId || args.requestId; let bid = cache.auctions[args.auctionId].adUnitCodes[args.adUnitCode].bids[requestId][0]; if (!bid) { logError(LOG_PRE_FIX + 'Could not find associated bid request for bid response with requestId: ', args.requestId); @@ -728,7 +728,7 @@ function bidRejectedHandler(args) { function bidderDoneHandler(args) { cache.auctions[args.auctionId].bidderDonePendingCount--; args.bids.forEach(bid => { - let cachedBid = cache.auctions[bid.auctionId].adUnitCodes[bid.adUnitCode].bids[bid.bidId || bid.originalRequestId || bid.requestId]; + const cachedBid = cache.auctions[bid.auctionId].adUnitCodes[bid.adUnitCode].bids[bid.bidId || bid.originalRequestId || bid.requestId]; if (typeof bid.serverResponseTimeMs !== 'undefined') { cachedBid.serverLatencyTimeMs = bid.serverResponseTimeMs; } @@ -742,7 +742,7 @@ function bidderDoneHandler(args) { } function bidWonHandler(args) { - let auctionCache = cache.auctions[args.auctionId]; + const auctionCache = cache.auctions[args.auctionId]; auctionCache.adUnitCodes[args.adUnitCode].bidWon = args.originalRequestId || args.requestId; auctionCache.adUnitCodes[args.adUnitCode].bidWonAdId = args.adId; executeBidWonLoggerCall(args.auctionId, args.adUnitCode); @@ -750,7 +750,7 @@ function bidWonHandler(args) { function auctionEndHandler(args) { // if for the given auction bidderDonePendingCount == 0 then execute logger call sooners - let highestCpmBids = getGlobal().getHighestCpmBids() || []; + const highestCpmBids = getGlobal().getHighestCpmBids() || []; setTimeout(() => { executeBidsLoggerCall.call(this, args, highestCpmBids); }, (cache.auctions[args.auctionId]?.bidderDonePendingCount === 0 ? 500 : SEND_TIMEOUT)); @@ -760,8 +760,8 @@ function bidTimeoutHandler(args) { // db = 1 and t = 1 means bidder did NOT respond with a bid but we got a timeout notification // db = 0 and t = 1 means bidder did respond with a bid but post timeout args.forEach(badBid => { - let auctionCache = cache.auctions[badBid.auctionId]; - let bid = auctionCache.adUnitCodes[badBid.adUnitCode].bids[ badBid.bidId || badBid.originalRequestId || badBid.requestId ][0]; + const auctionCache = cache.auctions[badBid.auctionId]; + const bid = auctionCache.adUnitCodes[badBid.adUnitCode].bids[ badBid.bidId || badBid.originalRequestId || badBid.requestId ][0]; if (bid) { bid.status = ERROR; bid.error = { @@ -775,8 +775,8 @@ function bidTimeoutHandler(args) { /// /////////// ADAPTER DEFINITION ////////////// -let baseAdapter = adapter({analyticsType: 'endpoint'}); -let pubmaticAdapter = Object.assign({}, baseAdapter, { +const baseAdapter = adapter({analyticsType: 'endpoint'}); +const pubmaticAdapter = Object.assign({}, baseAdapter, { enableAnalytics(conf = {}) { let error = false; diff --git a/modules/pubmaticBidAdapter.js b/modules/pubmaticBidAdapter.js index f718d535483..dafe8f5d32d 100644 --- a/modules/pubmaticBidAdapter.js +++ b/modules/pubmaticBidAdapter.js @@ -219,7 +219,7 @@ const handleImageProperties = asset => { const toOrtbNativeRequest = legacyNativeAssets => { const ortb = { ver: '1.2', assets: [] }; - for (let key in legacyNativeAssets) { + for (const key in legacyNativeAssets) { if (NATIVE_KEYS_THAT_ARE_NOT_ASSETS.includes(key)) continue; if (!NATIVE_KEYS.hasOwnProperty(key) && !PREBID_NATIVE_DATA_KEY_VALUES.includes(key)) { logWarn(`${LOG_WARN_PREFIX}: Unrecognized asset: ${key}. Ignored.`); @@ -267,8 +267,8 @@ function removeGranularFloor(imp, mediaTypes) { const setFloorInImp = (imp, bid) => { let bidFloor = -1; - let requestedMediatypes = Object.keys(bid.mediaTypes); - let isMultiFormatRequest = requestedMediatypes.length > 1 + const requestedMediatypes = Object.keys(bid.mediaTypes); + const isMultiFormatRequest = requestedMediatypes.length > 1 if (typeof bid.getFloor === 'function' && !config.getConfig('pubmatic.disableFloors')) { [BANNER, VIDEO, NATIVE].forEach(mediaType => { if (!imp.hasOwnProperty(mediaType)) return; @@ -312,7 +312,7 @@ const setFloorInImp = (imp, bid) => { } const updateBannerImp = (bannerObj, adSlot) => { - let slot = adSlot.split(':'); + const slot = adSlot.split(':'); let splits = slot[0]?.split('@'); splits = splits?.length == 2 ? splits[1].split('x') : splits.length == 3 ? splits[2].split('x') : []; const primarySize = bannerObj.format[0]; @@ -341,7 +341,7 @@ const updateNativeImp = (imp, nativeParams) => { imp.native.request = JSON.stringify(toOrtbNativeRequest(nativeParams)); } if (nativeParams?.ortb) { - let nativeConfig = JSON.parse(imp.native.request); + const nativeConfig = JSON.parse(imp.native.request); const { assets } = nativeConfig; if (!assets?.some(asset => asset.title || asset.img || asset.data || asset.video)) { logWarn(`${LOG_WARN_PREFIX}: Native assets object is empty or contains invalid objects`); @@ -403,7 +403,7 @@ const addPMPDeals = (imp, deals) => { const updateRequestExt = (req, bidderRequest) => { const allBiddersList = ['all']; - let allowedBiddersList = bidderSettings.get(bidderRequest.bidderCode, 'allowedAlternateBidderCodes'); + const allowedBiddersList = bidderSettings.get(bidderRequest.bidderCode, 'allowedAlternateBidderCodes'); const biddersList = isArray(allowedBiddersList) ? allowedBiddersList.map(val => val.trim().toLowerCase()).filter(uniques) : allBiddersList; @@ -564,7 +564,7 @@ const validateBlockedCategories = (bcats) => { } const getConnectionType = () => { - let connection = window.navigator && (window.navigator.connection || window.navigator.mozConnection || window.navigator.webkitConnection); + const connection = window.navigator && (window.navigator.connection || window.navigator.mozConnection || window.navigator.webkitConnection); const types = { ethernet: 1, wifi: 2, 'slow-2g': 4, '2g': 4, '3g': 5, '4g': 6 }; return types[connection?.effectiveType] || 0; } @@ -779,7 +779,7 @@ export const spec = { }) const data = converter.toORTB({ validBidRequests, bidderRequest }); - let serverRequest = { + const serverRequest = { method: 'POST', url: ENDPOINT, data: data, diff --git a/modules/pubmaticRtdProvider.js b/modules/pubmaticRtdProvider.js index bdb7cc47c09..ec0652fc794 100644 --- a/modules/pubmaticRtdProvider.js +++ b/modules/pubmaticRtdProvider.js @@ -79,7 +79,7 @@ let initTime; let _fetchFloorRulesPromise = null; let _fetchConfigPromise = null; export let configMerged; // configMerged is a reference to the function that can resolve configMergedPromise whenever we want -let configMergedPromise = new Promise((resolve) => { configMerged = resolve; }); +const configMergedPromise = new Promise((resolve) => { configMerged = resolve; }); export let _country; // Store multipliers from floors.json, will use default values from CONSTANTS if not available export let _multipliers = null; @@ -455,7 +455,7 @@ export const getFloorsConfig = (floorsData, profileConfigs) => { return undefined; } - let config = { ...dynamicFloors.config }; + const config = { ...dynamicFloors.config }; // default values provided by publisher on profile const defaultValues = config.defaultValues ?? {}; diff --git a/modules/pubwiseAnalyticsAdapter.js b/modules/pubwiseAnalyticsAdapter.js index bf6be03422e..f92c61a53dd 100644 --- a/modules/pubwiseAnalyticsAdapter.js +++ b/modules/pubwiseAnalyticsAdapter.js @@ -31,18 +31,18 @@ Changes in 4.0 Version const analyticsType = 'endpoint'; const analyticsName = 'PubWise:'; const prebidVersion = '$prebid.version$'; -let pubwiseVersion = '4.0.1'; +const pubwiseVersion = '4.0.1'; let configOptions = {site: '', endpoint: 'https://api.pubwise.io/api/v5/event/add/', debug: null}; let pwAnalyticsEnabled = false; -let utmKeys = {utm_source: '', utm_medium: '', utm_campaign: '', utm_term: '', utm_content: ''}; -let sessionData = {sessionId: '', activationId: ''}; -let pwNamespace = 'pubwise'; -let pwEvents = []; +const utmKeys = {utm_source: '', utm_medium: '', utm_campaign: '', utm_term: '', utm_content: ''}; +const sessionData = {sessionId: '', activationId: ''}; +const pwNamespace = 'pubwise'; +const pwEvents = []; let metaData = {}; -let auctionEnded = false; -let sessTimeout = 60 * 30 * 1000; // 30 minutes, G Analytics default session length -let sessName = 'sess_id'; -let sessTimeoutName = 'sess_timeout'; +const auctionEnded = false; +const sessTimeout = 60 * 30 * 1000; // 30 minutes, G Analytics default session length +const sessName = 'sess_id'; +const sessTimeoutName = 'sess_timeout'; function enrichWithSessionInfo(dataBag) { try { @@ -76,7 +76,7 @@ function enrichWithMetrics(dataBag) { function enrichWithUTM(dataBag) { let newUtm = false; try { - for (let prop in utmKeys) { + for (const prop in utmKeys) { utmKeys[prop] = getParameterByName(prop); if (utmKeys[prop]) { newUtm = true; @@ -85,14 +85,14 @@ function enrichWithUTM(dataBag) { } if (newUtm === false) { - for (let prop in utmKeys) { - let itemValue = storage.getDataFromLocalStorage(setNamespace(prop)); + for (const prop in utmKeys) { + const itemValue = storage.getDataFromLocalStorage(setNamespace(prop)); if (itemValue !== null && typeof itemValue !== 'undefined' && itemValue.length !== 0) { dataBag[prop] = itemValue; } } } else { - for (let prop in utmKeys) { + for (const prop in utmKeys) { storage.setDataInLocalStorage(setNamespace(prop), utmKeys[prop]); } } @@ -105,7 +105,7 @@ function enrichWithUTM(dataBag) { function expireUtmData() { pwInfo(`Session Expiring UTM Data`); - for (let prop in utmKeys) { + for (const prop in utmKeys) { storage.removeDataFromLocalStorage(setNamespace(prop)); } } @@ -162,13 +162,13 @@ function userSessionID() { } function sessionExpired() { - let sessLastTime = storage.getDataFromLocalStorage(localStorageSessTimeoutName()); + const sessLastTime = storage.getDataFromLocalStorage(localStorageSessTimeoutName()); return (Date.now() - parseInt(sessLastTime)) > sessTimeout; } function flushEvents() { if (pwEvents.length > 0) { - let dataBag = {metaData: metaData, eventList: pwEvents.splice(0)}; // put all the events together with the metadata and send + const dataBag = {metaData: metaData, eventList: pwEvents.splice(0)}; // put all the events together with the metadata and send ajax(configOptions.endpoint, (result) => pwInfo(`Result`, result), JSON.stringify(dataBag)); } } @@ -197,7 +197,7 @@ function pwInfo(info, context) { } function filterBidResponse(data) { - let modified = Object.assign({}, data); + const modified = Object.assign({}, data); // clean up some properties we don't track in public version if (typeof modified.ad !== 'undefined') { modified.ad = ''; @@ -220,7 +220,7 @@ function filterBidResponse(data) { } function filterAuctionInit(data) { - let modified = Object.assign({}, data); + const modified = Object.assign({}, data); modified.refererInfo = {}; // handle clean referrer, we only need one @@ -254,7 +254,7 @@ function filterAuctionInit(data) { return modified; } -let pubwiseAnalytics = Object.assign(adapter({analyticsType}), { +const pubwiseAnalytics = Object.assign(adapter({analyticsType}), { // Override AnalyticsAdapter functions by supplying custom methods track({eventType, args}) { this.handleEvent(eventType, args); @@ -305,9 +305,9 @@ pubwiseAnalytics.storeSessionID = function (userSessID) { // ensure a session exists, if not make one, always store it pubwiseAnalytics.ensureSession = function () { - let sessionId = userSessionID(); + const sessionId = userSessionID(); if (sessionExpired() === true || sessionId === null || sessionId === '') { - let generatedId = generateUUID(); + const generatedId = generateUUID(); expireUtmData(); this.storeSessionID(generatedId); sessionData.sessionId = generatedId; diff --git a/modules/pwbidBidAdapter.js b/modules/pwbidBidAdapter.js index 9aea154d25b..7a598afa15a 100644 --- a/modules/pwbidBidAdapter.js +++ b/modules/pwbidBidAdapter.js @@ -122,8 +122,8 @@ const NATIVE_MINIMUM_REQUIRED_IMAGE_ASSETS = [ ] let isInvalidNativeRequest = false -let NATIVE_ASSET_ID_TO_KEY_MAP = {}; -let NATIVE_ASSET_KEY_TO_ASSET_MAP = {}; +const NATIVE_ASSET_ID_TO_KEY_MAP = {}; +const NATIVE_ASSET_KEY_TO_ASSET_MAP = {}; // together allows traversal of NATIVE_ASSETS_LIST in any direction // id -> key @@ -154,8 +154,8 @@ export const spec = { // video ad validation if (bid.hasOwnProperty('mediaTypes') && bid.mediaTypes.hasOwnProperty(VIDEO)) { // bid.mediaTypes.video.mimes OR bid.params.video.mimes should be present and must be a non-empty array - let mediaTypesVideoMimes = deepAccess(bid.mediaTypes, 'video.mimes'); - let paramsVideoMimes = deepAccess(bid, 'params.video.mimes'); + const mediaTypesVideoMimes = deepAccess(bid.mediaTypes, 'video.mimes'); + const paramsVideoMimes = deepAccess(bid, 'params.video.mimes'); if (_isNonEmptyArray(mediaTypesVideoMimes) === false && _isNonEmptyArray(paramsVideoMimes) === false) { _logWarn('Error: For video ads, bid.mediaTypes.video.mimes OR bid.params.video.mimes should be present and must be a non-empty array. Call suppressed:', JSON.stringify(bid)); return false; @@ -300,7 +300,7 @@ export const spec = { const bidResponses = []; var respCur = DEFAULT_CURRENCY; _logInfo('interpretResponse request', request); - let parsedRequest = request.data; // not currently stringified + const parsedRequest = request.data; // not currently stringified // let parsedReferrer = parsedRequest.site && parsedRequest.site.ref ? parsedRequest.site.ref : ''; // try { @@ -312,7 +312,7 @@ export const spec = { seatbidder.bid && isArray(seatbidder.bid) && seatbidder.bid.forEach(bid => { - let newBid = { + const newBid = { requestId: bid.impid, cpm: (parseFloat(bid.price) || 0).toFixed(2), width: bid.w, @@ -468,7 +468,7 @@ function _parseNativeResponse(bid, newBid) { } function _getDomainFromURL(url) { - let anchor = document.createElement('a'); + const anchor = document.createElement('a'); anchor.href = url; return anchor.hostname; } @@ -669,9 +669,9 @@ function _addFloorFromFloorModule(impObj, bid) { if (typeof bid.getFloor === 'function' && !config.getConfig('pubwise.disableFloors')) { [BANNER, VIDEO, NATIVE].forEach(mediaType => { if (impObj.hasOwnProperty(mediaType)) { - let floorInfo = bid.getFloor({ currency: impObj.bidFloorCur, mediaType: mediaType, size: '*' }); + const floorInfo = bid.getFloor({ currency: impObj.bidFloorCur, mediaType: mediaType, size: '*' }); if (isPlainObject(floorInfo) && floorInfo.currency === impObj.bidFloorCur && !isNaN(parseInt(floorInfo.floor))) { - let mediaTypeFloor = parseFloat(floorInfo.floor); + const mediaTypeFloor = parseFloat(floorInfo.floor); bidFloor = (bidFloor == -1 ? mediaTypeFloor : Math.min(mediaTypeFloor, bidFloor)) } } diff --git a/modules/quantcastBidAdapter.js b/modules/quantcastBidAdapter.js index 5f82e56ce02..0ee58a927d1 100644 --- a/modules/quantcastBidAdapter.js +++ b/modules/quantcastBidAdapter.js @@ -79,8 +79,8 @@ function makeBannerImp(bid) { } function checkTCF(tcData) { - let restrictions = tcData.publisher ? tcData.publisher.restrictions : {}; - let qcRestriction = restrictions && restrictions[PURPOSE_DATA_COLLECT] + const restrictions = tcData.publisher ? tcData.publisher.restrictions : {}; + const qcRestriction = restrictions && restrictions[PURPOSE_DATA_COLLECT] ? restrictions[PURPOSE_DATA_COLLECT][QUANTCAST_VENDOR_ID] : null; @@ -89,14 +89,14 @@ function checkTCF(tcData) { return false; } - let vendorConsent = tcData.vendor && tcData.vendor.consents && tcData.vendor.consents[QUANTCAST_VENDOR_ID]; - let purposeConsent = tcData.purpose && tcData.purpose.consents && tcData.purpose.consents[PURPOSE_DATA_COLLECT]; + const vendorConsent = tcData.vendor && tcData.vendor.consents && tcData.vendor.consents[QUANTCAST_VENDOR_ID]; + const purposeConsent = tcData.purpose && tcData.purpose.consents && tcData.purpose.consents[PURPOSE_DATA_COLLECT]; return !!(vendorConsent && purposeConsent); } function getQuantcastFPA() { - let fpa = storage.getCookie(QUANTCAST_FPA) + const fpa = storage.getCookie(QUANTCAST_FPA) return fpa || '' } @@ -149,7 +149,7 @@ export const spec = { } } - let bidRequestsList = []; + const bidRequestsList = []; bids.forEach(bid => { let imp; diff --git a/modules/quantcastIdSystem.js b/modules/quantcastIdSystem.js index d980f5316e5..2f0ebbb880b 100644 --- a/modules/quantcastIdSystem.js +++ b/modules/quantcastIdSystem.js @@ -61,7 +61,7 @@ export function firePixel(clientId, cookieExpDays = DEFAULT_COOKIE_EXP_DAYS) { usPrivacyParamString = `&us_privacy=${US_PRIVACY_STRING}`; } - let url = QSERVE_URL + + const url = QSERVE_URL + '?d=' + domain + '&client_id=' + clientId + '&a=' + PREBID_PCODE + @@ -190,7 +190,7 @@ export const quantcastIdSubmodule = { */ getId(config) { // Consent signals are currently checked on the server side. - let fpa = storage.getCookie(QUANTCAST_FPA); + const fpa = storage.getCookie(QUANTCAST_FPA); const coppa = coppaDataHandler.getCoppa(); diff --git a/modules/qwarryBidAdapter.js b/modules/qwarryBidAdapter.js index 73191f099a0..00ebd9ed703 100644 --- a/modules/qwarryBidAdapter.js +++ b/modules/qwarryBidAdapter.js @@ -15,7 +15,7 @@ export const spec = { }, buildRequests: function (validBidRequests, bidderRequest) { - let bids = []; + const bids = []; validBidRequests.forEach(bidRequest => { bids.push({ bidId: bidRequest.bidId, @@ -25,7 +25,7 @@ export const spec = { }) }) - let payload = { + const payload = { requestId: bidderRequest.bidderRequestId, bids, referer: bidderRequest.refererInfo.page, @@ -65,9 +65,9 @@ export const spec = { return []; } - let bids = []; + const bids = []; prebidResponse.forEach(bidResponse => { - let bid = deepClone(bidResponse); + const bid = deepClone(bidResponse); bid.cpm = parseFloat(bidResponse.cpm); // banner or video diff --git a/modules/r2b2AnalyticsAdapter.js b/modules/r2b2AnalyticsAdapter.js index aa909225c4d..f8953232982 100644 --- a/modules/r2b2AnalyticsAdapter.js +++ b/modules/r2b2AnalyticsAdapter.js @@ -65,7 +65,7 @@ let errors = 0; let callDepth = 0; function flushEvents () { - let events = { prebid: { e: eventBuffer, c: adServerCurrency } }; + const events = { prebid: { e: eventBuffer, c: adServerCurrency } }; eventBuffer = []; callDepth++; try { @@ -160,13 +160,13 @@ function reportError (message, params) { function reportEvents (events) { try { let data = 'events=' + JSON.stringify(events); - let url = r2b2Analytics.getUrl() + + const url = r2b2Analytics.getUrl() + `?v=${encodeURIComponent(ADAPTER_VERSION)}` + `&hbDomain=${encodeURIComponent(WEBSITE)}` + (CONFIG_ID ? `&conf=${encodeURIComponent(CONFIG_ID)}` : '') + (CONFIG_VERSION ? `&conf_ver=${encodeURIComponent(CONFIG_VERSION)}` : '') + `&u=${encodeURIComponent(REPORTED_URL)}`; - let headers = { + const headers = { contentType: 'application/x-www-form-urlencoded' } data = data.replace(/&/g, '%26'); @@ -283,7 +283,7 @@ function handleBidTimeout (args) { // console.log('bid timeout:', arguments); const auctionId = args.length ? args[0].auctionId : null; if (auctionId) { - let bidders = args.reduce((result, bid) => { + const bidders = args.reduce((result, bid) => { if (!result[bid.bidder]) { result[bid.bidder] = {} } @@ -358,7 +358,7 @@ function handleBidderDone (args) { function getAuctionUnitsData (auctionObject) { let unitsData = {}; const {bidsReceived, bidsRejected} = auctionObject; - let _unitsDataBidReducer = function(data, bid, key) { + const _unitsDataBidReducer = function(data, bid, key) { const {adUnitCode, bidder} = bid; data[adUnitCode] = data[adUnitCode] || {}; data[adUnitCode][key] = data[adUnitCode][key] || {}; @@ -375,7 +375,7 @@ function getAuctionUnitsData (auctionObject) { return unitsData } function handleEmptyAuction(auction) { - let auctionId = auction.auctionId; + const auctionId = auction.auctionId; if (!auctionsData[auctionId]) { createAuctionData(auction, true); } @@ -513,8 +513,8 @@ function handleBidViewable (args) { processEvent(event); } -let baseAdapter = adapter({analyticsType}); -let r2b2Analytics = Object.assign({}, baseAdapter, { +const baseAdapter = adapter({analyticsType}); +const r2b2Analytics = Object.assign({}, baseAdapter, { getUrl() { return `${DEFAULT_PROTOCOL}://${LOG_SERVER}/${DEFAULT_EVENT_PATH}` }, diff --git a/modules/r2b2BidAdapter.js b/modules/r2b2BidAdapter.js index 15a65e3924c..bb645d49e8c 100644 --- a/modules/r2b2BidAdapter.js +++ b/modules/r2b2BidAdapter.js @@ -32,7 +32,7 @@ export const internal = { mappedParams: {} } -let r2b2Error = function(message, params) { +const r2b2Error = function(message, params) { logError(message, params, BIDDER_CODE) } @@ -118,7 +118,7 @@ function setUpRenderer(adUnitCode, bid) { return sourceDocument; } } - let renderer = Renderer.install({ + const renderer = Renderer.install({ url: RENDERER_URL, config: config, id: bid.requestId, @@ -128,7 +128,7 @@ function setUpRenderer(adUnitCode, bid) { renderer.setRender(function (bid, doc) { doc = renderDoc || doc; window.R2B2 = window.R2B2 || {}; - let main = window.R2B2; + const main = window.R2B2; main.HB = main.HB || {}; main.HB.Render = main.HB.Render || {}; main.HB.Render.queue = main.HB.Render.queue || []; @@ -169,7 +169,7 @@ function createPrebidResponseBid(requestImp, bidResponse, serverResponse, bids) const bidId = requestImp.id; const adUnitCode = bids[0].adUnitCode; const mediaType = bidResponse.ext.prebid.type; - let bidOut = { + const bidOut = { requestId: bidId, cpm: bidResponse.price, creativeId: bidResponse.crid, @@ -228,20 +228,20 @@ export const spec = { interpretResponse: function(serverResponse, request) { // r2b2Error('error message', {params: 1}); - let prebidResponses = []; + const prebidResponses = []; const response = serverResponse.body; if (!response || !response.seatbid || !response.seatbid[0] || !response.seatbid[0].bid) { return prebidResponses; } - let requestImps = request.data.imp || []; + const requestImps = request.data.imp || []; try { response.seatbid.forEach(seat => { - let bids = seat.bid; + const bids = seat.bid; - for (let responseBid of bids) { - let responseImpId = responseBid.impid; - let requestCurrentImp = requestImps.find((requestImp) => requestImp.id === responseImpId); + for (const responseBid of bids) { + const responseImpId = responseBid.impid; + const requestCurrentImp = requestImps.find((requestImp) => requestImp.id === responseImpId); if (!requestCurrentImp) { r2b2Error('Cant match bid response.', {impid: Boolean(responseBid.impid)}); continue;// Skip this iteration if there's no match @@ -302,7 +302,7 @@ export const spec = { triggerEvent(URL_EVENT_ON_TIMEOUT, getIdsFromBids(bids)) }, onBidderError: function(params) { - let { bidderRequest } = params; + const { bidderRequest } = params; triggerEvent(URL_EVENT_ON_BIDDER_ERROR, getIdsFromBids(bidderRequest.bids)) } } diff --git a/modules/reconciliationRtdProvider.js b/modules/reconciliationRtdProvider.js index 2da37f41eb2..46486923c0a 100644 --- a/modules/reconciliationRtdProvider.js +++ b/modules/reconciliationRtdProvider.js @@ -83,7 +83,7 @@ function handleAdMessage(e) { track.trackPost(_moduleParams.impressionUrl, args); // Send response back to the Advertiser tag - let response = { + const response = { type: MessageType.IMPRESSION_RESPONSE, id: data.id, args: Object.assign( @@ -173,10 +173,10 @@ export function getSlotByWin(win) { return ( ((slots) || []).find((s) => { - let slotElement = document.getElementById(s.getSlotElementId()); + const slotElement = document.getElementById(s.getSlotElementId()); if (slotElement) { - let slotIframe = slotElement.querySelector('iframe'); + const slotIframe = slotElement.querySelector('iframe'); if (slotIframe && slotIframe.contentWindow === win) { return true; diff --git a/modules/relaidoBidAdapter.js b/modules/relaidoBidAdapter.js index a55260ba764..93a9f2918c0 100644 --- a/modules/relaidoBidAdapter.js +++ b/modules/relaidoBidAdapter.js @@ -144,7 +144,7 @@ function interpretResponse(serverResponse, bidRequest) { for (const res of body.ads) { const playerUrl = res.playerUrl || bidRequest.player || body.playerUrl; - let bidResponse = { + const bidResponse = { requestId: res.bidId, placementId: res.placementId, width: res.width, @@ -195,7 +195,7 @@ function getUserSyncs(syncOptions, serverResponses) { } function onBidWon(bid) { - let query = parseQueryStringParameters({ + const query = parseQueryStringParameters({ placement_id: deepAccess(bid, 'params.0.placementId'), creative_id: deepAccess(bid, 'creativeId'), price: deepAccess(bid, 'cpm'), @@ -211,7 +211,7 @@ function onBidWon(bid) { } function onTimeout(data) { - let query = parseQueryStringParameters({ + const query = parseQueryStringParameters({ placement_id: deepAccess(data, '0.params.0.placementId'), timeout: deepAccess(data, '0.timeout'), auction_id: deepAccess(data, '0.auctionId'), @@ -327,7 +327,7 @@ function hasVideoMediaType(bid) { } function getValidSizes(sizes) { - let result = []; + const result = []; if (sizes && isArray(sizes) && sizes.length > 0) { for (let i = 0; i < sizes.length; i++) { if (isArray(sizes[i]) && sizes[i].length == 2) { diff --git a/modules/relayBidAdapter.js b/modules/relayBidAdapter.js index eed075aff9f..46f56bfcc09 100644 --- a/modules/relayBidAdapter.js +++ b/modules/relayBidAdapter.js @@ -28,7 +28,7 @@ function buildRequests(bidRequests, bidderRequest) { return accu; }, {}); // Send one overall request with all grouped bids per accountId - let reqs = []; + const reqs = []; for (const [accountId, accountBidRequests] of Object.entries(groupedByAccountId)) { const url = `${ENDPOINT_URL}?a=${accountId}&pb=1&pbv=${prebidVersion}`; const data = CONVERTER.toORTB({ bidRequests: accountBidRequests, bidderRequest }) @@ -51,7 +51,7 @@ function isBidRequestValid(bid) { }; function getUserSyncs(syncOptions, serverResponses, gdprConsent, uspConsent) { - let syncs = [] + const syncs = [] for (const response of serverResponses) { const responseSyncs = ((((response || {}).body || {}).ext || {}).user_syncs || []) // Relay returns user_syncs in the format expected by prebid. If for any diff --git a/modules/relevadRtdProvider.js b/modules/relevadRtdProvider.js index ba5c85b1c1f..1564b8b39cd 100644 --- a/modules/relevadRtdProvider.js +++ b/modules/relevadRtdProvider.js @@ -39,7 +39,7 @@ export function getBidRequestData(reqBidsConfigObj, onDone, moduleConfig, userCo moduleConfig.params = moduleConfig.params || {}; moduleConfig.params.partnerid = moduleConfig.params.partnerid ? moduleConfig.params.partnerid : 1; - let adunitInfo = reqBidsConfigObj.adUnits.map(adunit => { return [adunit.code, adunit.bids.map(bid => { return [bid.bidder, bid.params] })]; }); + const adunitInfo = reqBidsConfigObj.adUnits.map(adunit => { return [adunit.code, adunit.bids.map(bid => { return [bid.bidder, bid.params] })]; }); serverData.page = moduleConfig.params.actualUrl || getRefererInfo().page || ''; const url = (RELEVAD_API_DOMAIN + '/apis/rweb2/' + '?url=' + encodeURIComponent(serverData.page) + @@ -85,7 +85,7 @@ export function getBidRequestData(reqBidsConfigObj, onDone, moduleConfig, userCo */ export function setGlobalOrtb2(ortb2, rtdData) { try { - let addOrtb2 = composeOrtb2Data(rtdData, 'site'); + const addOrtb2 = composeOrtb2Data(rtdData, 'site'); !isEmpty(addOrtb2) && mergeDeep(ortb2, addOrtb2); } catch (e) { logError(e) @@ -103,7 +103,7 @@ function composeOrtb2Data(rtdData, prefix) { const segments = rtdData.segments; const categories = rtdData.categories; const content = rtdData.content; - let addOrtb2 = {}; + const addOrtb2 = {}; !isEmpty(segments) && deepSetValue(addOrtb2, 'user.ext.data.relevad_rtd', segments); !isEmpty(categories.cat) && deepSetValue(addOrtb2, prefix + '.cat', categories.cat); @@ -132,7 +132,7 @@ function composeOrtb2Data(rtdData, prefix) { */ function setBidderSiteAndContent(bidderOrtbFragment, bidder, rtdData) { try { - let addOrtb2 = composeOrtb2Data(rtdData, 'site'); + const addOrtb2 = composeOrtb2Data(rtdData, 'site'); !isEmpty(rtdData.segments) && deepSetValue(addOrtb2, 'user.ext.data.relevad_rtd', rtdData.segments); !isEmpty(rtdData.segments) && deepSetValue(addOrtb2, 'user.ext.data.segments', rtdData.segments); !isEmpty(rtdData.categories) && deepSetValue(addOrtb2, 'user.ext.data.contextual_categories', rtdData.categories.pagecat); @@ -174,7 +174,7 @@ function filterByScore(dict, minscore) { * @return {object} Filtered RTD */ function getFiltered(data, minscore) { - let relevadData = {'segments': []}; + const relevadData = {'segments': []}; minscore = minscore && typeof minscore == 'number' ? minscore : 30; @@ -190,7 +190,7 @@ function getFiltered(data, minscore) { try { if (data && data.segments) { - for (let segId in data.segments) { + for (const segId in data.segments) { if (data.segments.hasOwnProperty(segId)) { relevadData.segments.push(data.segments[segId].toString()); } @@ -225,7 +225,7 @@ export function addRtdData(reqBids, data, moduleConfig) { noWhitelists && setGlobalOrtb2(reqBids.ortb2Fragments?.global, relevadData); // Target GAM/GPT - let setgpt = moduleConfig.params.setgpt || !moduleConfig.params.hasOwnProperty('setgpt'); + const setgpt = moduleConfig.params.setgpt || !moduleConfig.params.hasOwnProperty('setgpt'); if (moduleConfig.dryrun || (typeof window.googletag !== 'undefined' && setgpt)) { try { if (window.googletag && window.googletag.pubads && (typeof window.googletag.pubads === 'function')) { @@ -246,7 +246,7 @@ export function addRtdData(reqBids, data, moduleConfig) { noWhitelists && deepSetValue(adUnit, 'ortb2Imp.ext.data.relevad_rtd', relevadList); adUnit.hasOwnProperty('bids') && adUnit.bids.forEach(bid => { - let bidderIndex = (moduleConfig.params.hasOwnProperty('bidders') ? moduleConfig.params.bidders.findIndex(function (i) { + const bidderIndex = (moduleConfig.params.hasOwnProperty('bidders') ? moduleConfig.params.bidders.findIndex(function (i) { return i.bidder === bid.bidder; }) : false); const indexFound = !!(typeof bidderIndex == 'number' && bidderIndex >= 0); @@ -263,7 +263,7 @@ export function addRtdData(reqBids, data, moduleConfig) { if (!wb && !isEmpty(wl[bid.bidder])) { wb = true; for (const [key, value] of entries(wl[bid.bidder])) { - let params = bid?.params || {}; + const params = bid?.params || {}; wb = wb && (key in params) && params[key] == value; } } @@ -272,7 +272,7 @@ export function addRtdData(reqBids, data, moduleConfig) { setBidderSiteAndContent(bid, 'ortb2', relevadData); deepSetValue(bid, 'params.keywords.relevad_rtd', relevadList); !(bid.params?.target || '').includes('relevad_rtd=') && deepSetValue(bid, 'params.target', [].concat(bid.params?.target ? [bid.params.target] : []).concat(relevadList.map(entry => { return 'relevad_rtd=' + entry; })).join(';')); - let firstPartyData = {}; + const firstPartyData = {}; firstPartyData[bid.bidder] = { firstPartyData: { relevad_rtd: relevadList } }; config.setConfig(firstPartyData); } @@ -294,7 +294,7 @@ export function addRtdData(reqBids, data, moduleConfig) { * @param {object} config Configuraion */ function sendBids(data, config) { - let dataJson = JSON.stringify(data); + const dataJson = JSON.stringify(data); if (!config.dryrun) { ajax(RELEVAD_API_DOMAIN + '/apis/bids/', () => {}, dataJson, AJAX_OPTIONS); @@ -310,8 +310,8 @@ function sendBids(data, config) { * @param {object} userConsent User GDPR consent object */ function onAuctionEnd(auctionDetails, config, userConsent) { - let adunitObj = {}; - let adunits = []; + const adunitObj = {}; + const adunits = []; // Add Bids Received auctionDetails.bidsReceived.forEach((bidObj) => { @@ -332,7 +332,7 @@ function onAuctionEnd(auctionDetails, config, userConsent) { adunits.push({code: adunitCode, bids: bidsReceived}); }); - let data = { + const data = { event: 'bids', adunits: adunits, reledata: serverData.rawdata, diff --git a/modules/resetdigitalBidAdapter.js b/modules/resetdigitalBidAdapter.js index 77f8f44c53b..86ed934706a 100644 --- a/modules/resetdigitalBidAdapter.js +++ b/modules/resetdigitalBidAdapter.js @@ -16,12 +16,12 @@ export const spec = { return !!(bid.params.pubId || bid.params.zoneId); }, buildRequests: function (validBidRequests, bidderRequest) { - let stack = + const stack = bidderRequest.refererInfo && bidderRequest.refererInfo.stack ? bidderRequest.refererInfo.stack : []; - let spb = + const spb = config.getConfig('userSync') && config.getConfig('userSync').syncsPerBidder ? config.getConfig('userSync').syncsPerBidder @@ -94,24 +94,24 @@ export const spec = { 'app.keywords', 'app.content.keywords', ]; - let result = []; + const result = []; fields.forEach((path) => { - let keyStr = deepAccess(ortb2Obj, path); + const keyStr = deepAccess(ortb2Obj, path); if (isStr(keyStr)) result.push(keyStr); }); return result; } - let ortb2 = deepClone(bidderRequest && bidderRequest.ortb2); - let ortb2KeywordsList = getOrtb2Keywords(ortb2); + const ortb2 = deepClone(bidderRequest && bidderRequest.ortb2); + const ortb2KeywordsList = getOrtb2Keywords(ortb2); let metaKeywords = document.getElementsByTagName('meta')['keywords']; if (metaKeywords && metaKeywords.content) { metaKeywords = metaKeywords.content.split(','); } for (let x = 0; x < validBidRequests.length; x++) { - let req = validBidRequests[x]; + const req = validBidRequests[x]; let bidFloor = req.params.bidFloor ? req.params.bidFloor : null; let bidFloorCur = req.params.bidFloor ? req.params.bidFloorCur : null; @@ -141,7 +141,7 @@ export const spec = { paramsKeywords = []; } - let keywords = ortb2KeywordsList + const keywords = ortb2KeywordsList .concat(paramsKeywords) .concat(metaKeywords); @@ -166,8 +166,8 @@ export const spec = { }); } - let params = validBidRequests[0].params; - let url = params.endpoint ? params.endpoint : '//ads.resetsrv.com'; + const params = validBidRequests[0].params; + const url = params.endpoint ? params.endpoint : '//ads.resetsrv.com'; return { method: 'POST', url: url, @@ -181,13 +181,13 @@ export const spec = { return bidResponses; } - let res = serverResponse.body; + const res = serverResponse.body; if (!res.bids || !res.bids.length) { return []; } for (let x = 0; x < serverResponse.body.bids.length; x++) { - let bid = serverResponse.body.bids[x]; + const bid = serverResponse.body.bids[x]; bidResponses.push({ requestId: bid.bid_id, @@ -212,7 +212,7 @@ export const spec = { return bidResponses; }, getUserSyncs: function (syncOptions, serverResponses, gdprConsent) { - let syncs = []; + const syncs = []; if (!serverResponses.length || !serverResponses[0].body) { return syncs; } diff --git a/modules/revcontentBidAdapter.js b/modules/revcontentBidAdapter.js index 33583c8e501..48cb4053307 100644 --- a/modules/revcontentBidAdapter.js +++ b/modules/revcontentBidAdapter.js @@ -49,7 +49,7 @@ export const spec = { host = 'trends.revcontent.com'; } - let serverRequests = []; + const serverRequests = []; var refererInfo; if (bidderRequest && bidderRequest.refererInfo) { refererInfo = bidderRequest.refererInfo.page; @@ -67,7 +67,7 @@ export const spec = { const imp = validBidRequests.map((bid, id) => buildImp(bid, id)); - let data = { + const data = { id: bidderRequest.bidderRequestId, imp: imp, site: { @@ -101,21 +101,21 @@ export const spec = { return serverRequests; }, interpretResponse: function (serverResponse, serverRequest) { - let response = serverResponse.body; + const response = serverResponse.body; if ((!response) || (!response.seatbid)) { return []; } - let rtbRequest = JSON.parse(serverRequest.data); - let rtbBids = response.seatbid + const rtbRequest = JSON.parse(serverRequest.data); + const rtbBids = response.seatbid .map(seatbid => seatbid.bid) .reduce((a, b) => a.concat(b), []); return rtbBids.map(rtbBid => { const bidIndex = +rtbBid.impid - 1; - let imp = rtbRequest.imp.filter(imp => imp.id.toString() === rtbBid.impid)[0]; + const imp = rtbRequest.imp.filter(imp => imp.id.toString() === rtbBid.impid)[0]; - let prBid = { + const prBid = { requestId: serverRequest.bid[bidIndex].bidId, cpm: rtbBid.price, creativeId: rtbBid.crid, @@ -130,8 +130,8 @@ export const spec = { prBid.height = rtbBid.h; prBid.ad = STYLE_EXTRA + rtbBid.adm; } else if ('native' in imp) { - let adm = JSON.parse(rtbBid.adm); - let ad = { + const adm = JSON.parse(rtbBid.adm); + const ad = { clickUrl: adm.link.url }; @@ -214,7 +214,7 @@ function buildImp(bid, id) { bidfloor = deepAccess(bid, `params.bidfloor`) || 0.1; } - let imp = { + const imp = { id: id + 1, tagid: bid.adUnitCode, bidderRequestId: bid.bidderRequestId, @@ -226,10 +226,10 @@ function buildImp(bid, id) { secure: '1' }; - let bannerReq = deepAccess(bid, `mediaTypes.banner`); - let nativeReq = deepAccess(bid, `mediaTypes.native`); + const bannerReq = deepAccess(bid, `mediaTypes.banner`); + const nativeReq = deepAccess(bid, `mediaTypes.native`); if (bannerReq) { - let sizes = getAdUnitSizes(bid); + const sizes = getAdUnitSizes(bid); imp.banner = { w: sizes[0][0], h: sizes[0][1], diff --git a/modules/rhythmoneBidAdapter.js b/modules/rhythmoneBidAdapter.js index bdadc7f1f51..8faf914dfee 100644 --- a/modules/rhythmoneBidAdapter.js +++ b/modules/rhythmoneBidAdapter.js @@ -9,13 +9,13 @@ function RhythmOneBidAdapter() { this.supportedMediaTypes = [VIDEO, BANNER]; this.gvlid = 36; - let SUPPORTED_VIDEO_PROTOCOLS = [2, 3, 5, 6]; - let SUPPORTED_VIDEO_MIMES = ['video/mp4']; - let SUPPORTED_VIDEO_PLAYBACK_METHODS = [1, 2, 3, 4]; - let SUPPORTED_VIDEO_DELIVERY = [1]; - let SUPPORTED_VIDEO_API = [1, 2, 5]; - let slotsToBids = {}; - let version = '2.1'; + const SUPPORTED_VIDEO_PROTOCOLS = [2, 3, 5, 6]; + const SUPPORTED_VIDEO_MIMES = ['video/mp4']; + const SUPPORTED_VIDEO_PLAYBACK_METHODS = [1, 2, 3, 4]; + const SUPPORTED_VIDEO_DELIVERY = [1]; + const SUPPORTED_VIDEO_API = [1, 2, 5]; + const slotsToBids = {}; + const version = '2.1'; this.isBidRequestValid = function (bid) { return !!(bid.params && bid.params.placementId); @@ -42,7 +42,7 @@ function RhythmOneBidAdapter() { impObj.secure = isSecure; if (deepAccess(BRs[i], 'mediaTypes.banner') || deepAccess(BRs[i], 'mediaType') === 'banner') { - let banner = frameBanner(BRs[i]); + const banner = frameBanner(BRs[i]); if (banner) { impObj.banner = banner; } @@ -76,8 +76,8 @@ function RhythmOneBidAdapter() { } function getValidSizeSet(dimensionList) { - let w = parseInt(dimensionList[0]); - let h = parseInt(dimensionList[1]); + const w = parseInt(dimensionList[0]); + const h = parseInt(dimensionList[1]); // clever check for NaN if (! (w !== w || h !== h)) { // eslint-disable-line return [w, h]; @@ -149,7 +149,7 @@ function RhythmOneBidAdapter() { } function frameBid(BRs, bidderRequest) { - let bid = { + const bid = { id: BRs[0].bidderRequestId, imp: frameImp(BRs, bidderRequest), site: frameSite(bidderRequest), @@ -187,7 +187,7 @@ function RhythmOneBidAdapter() { } this.buildRequests = function (BRs, bidderRequest) { - let fallbackPlacementId = getFirstParam('placementId', BRs); + const fallbackPlacementId = getFirstParam('placementId', BRs); if (fallbackPlacementId === undefined || BRs.length < 1) { return []; } @@ -218,11 +218,11 @@ function RhythmOneBidAdapter() { this.interpretResponse = function (serverResponse) { let responses = serverResponse.body || []; - let bids = []; + const bids = []; let i = 0; if (responses.seatbid) { - let temp = []; + const temp = []; for (i = 0; i < responses.seatbid.length; i++) { for (let j = 0; j < responses.seatbid[i].bid.length; j++) { temp.push(responses.seatbid[i].bid[j]); @@ -232,9 +232,9 @@ function RhythmOneBidAdapter() { } for (i = 0; i < responses.length; i++) { - let bid = responses[i]; - let bidRequest = slotsToBids[bid.impid]; - let bidResponse = { + const bid = responses[i]; + const bidRequest = slotsToBids[bid.impid]; + const bidResponse = { requestId: bidRequest.bidId, cpm: parseFloat(bid.price), width: bid.w, diff --git a/modules/richaudienceBidAdapter.js b/modules/richaudienceBidAdapter.js index a241b2fa19e..06db34f5a86 100644 --- a/modules/richaudienceBidAdapter.js +++ b/modules/richaudienceBidAdapter.js @@ -211,7 +211,7 @@ export const spec = { }, onTimeout: function (data) { - let url = raiGetTimeoutURL(data); + const url = raiGetTimeoutURL(data); if (url) { triggerPixel(url); } @@ -273,8 +273,8 @@ function renderer(bid) { } function renderAd(bid) { - let raOutstreamHBPassback = `${bid.vastXml}`; - let raPlayerHB = { + const raOutstreamHBPassback = `${bid.vastXml}`; + const raPlayerHB = { adUnit: bid.adUnitCode }; @@ -300,7 +300,7 @@ function raiSetPbAdSlot(bid) { function raiGetSyncInclude(config) { try { let raConfig = null; - let raiSync = {}; + const raiSync = {}; if (config.getConfig('userSync').filterSettings != null && typeof config.getConfig('userSync').filterSettings != 'undefined') { raConfig = config.getConfig('userSync').filterSettings if (raConfig.iframe != null && typeof raConfig.iframe != 'undefined') { @@ -322,7 +322,7 @@ function raiGetFloor(bid, config) { if (bid.params.bidfloor != null) { raiFloor = bid.params.bidfloor; } else if (typeof bid.getFloor == 'function') { - let floorSpec = bid.getFloor({ + const floorSpec = bid.getFloor({ currency: config.getConfig('floors.data.currency') != null ? config.getConfig('floors.data.currency') : 'USD', mediaType: typeof bid.mediaTypes['banner'] == 'object' ? 'banner' : 'video', size: '*' @@ -337,7 +337,7 @@ function raiGetFloor(bid, config) { } function raiGetTimeoutURL(data) { - let {params, timeout} = data[0] + const {params, timeout} = data[0] let url = 'https://s.richaudience.com/err/?ec=6&ev=[timeout_publisher]&pla=[placement_hash]&int=PREBID&pltfm=&node=&dm=[domain]'; url = url.replace('[timeout_publisher]', timeout) @@ -349,6 +349,6 @@ function raiGetTimeoutURL(data) { } function setDSA(bid) { - let dsa = bid?.ortb2?.regs?.ext?.dsa ? bid?.ortb2?.regs?.ext?.dsa : null; + const dsa = bid?.ortb2?.regs?.ext?.dsa ? bid?.ortb2?.regs?.ext?.dsa : null; return dsa; } diff --git a/modules/ringieraxelspringerBidAdapter.js b/modules/ringieraxelspringerBidAdapter.js index 326fecc9d32..10cccecccf4 100644 --- a/modules/ringieraxelspringerBidAdapter.js +++ b/modules/ringieraxelspringerBidAdapter.js @@ -292,7 +292,7 @@ const getSlots = (bidRequests) => { const getGdprParams = (bidderRequest) => { const gdprApplies = deepAccess(bidderRequest, 'gdprConsent.gdprApplies'); - let consentString = deepAccess(bidderRequest, 'gdprConsent.consentString'); + const consentString = deepAccess(bidderRequest, 'gdprConsent.consentString'); let queryString = ''; if (gdprApplies !== undefined) { queryString += `&gdpr_applies=${encodeURIComponent(gdprApplies)}`; @@ -339,7 +339,7 @@ const getAdUnitCreFormat = (adUnit) => { } let creFormat = 'html'; - let mediaTypes = Object.keys(adUnit.mediaTypes); + const mediaTypes = Object.keys(adUnit.mediaTypes); if (mediaTypes && mediaTypes.length === 1 && mediaTypes.includes('native')) { creFormat = 'native'; diff --git a/modules/rivrAnalyticsAdapter.js b/modules/rivrAnalyticsAdapter.js index c74ce519ab9..476d3d21337 100644 --- a/modules/rivrAnalyticsAdapter.js +++ b/modules/rivrAnalyticsAdapter.js @@ -6,7 +6,7 @@ import {getGlobal} from '../src/prebidGlobal.js'; const analyticsType = 'endpoint'; -let rivrAnalytics = Object.assign(adapter({analyticsType}), { +const rivrAnalytics = Object.assign(adapter({analyticsType}), { track({ eventType, args }) { if (window.rivraddon && window.rivraddon.analytics && window.rivraddon.analytics.getContext() && window.rivraddon.analytics.trackPbjsEvent) { utils.logInfo(`ARGUMENTS FOR TYPE: ============= ${eventType}`, args); diff --git a/modules/rixengineBidAdapter.js b/modules/rixengineBidAdapter.js index b0a419d4282..072521a535f 100644 --- a/modules/rixengineBidAdapter.js +++ b/modules/rixengineBidAdapter.js @@ -48,7 +48,7 @@ export const spec = { }, buildRequests(bidRequests, bidderRequest) { - let data = converter.toORTB({ bidRequests, bidderRequest }); + const data = converter.toORTB({ bidRequests, bidderRequest }); return [ { diff --git a/modules/roxotAnalyticsAdapter.js b/modules/roxotAnalyticsAdapter.js index eaf24135131..9cd2bf72b8e 100644 --- a/modules/roxotAnalyticsAdapter.js +++ b/modules/roxotAnalyticsAdapter.js @@ -11,7 +11,7 @@ const MODULE_CODE = 'roxot'; const storage = getStorageManager({moduleType: MODULE_TYPE_ANALYTICS, moduleName: MODULE_CODE}); -let ajax = ajaxBuilder(0); +const ajax = ajaxBuilder(0); const DEFAULT_EVENT_URL = 'pa.rxthdr.com/v3'; const DEFAULT_SERVER_CONFIG_URL = 'pa.rxthdr.com/v3'; @@ -44,21 +44,21 @@ const ROXOT_EVENTS = { let initOptions = {}; -let localStoragePrefix = 'roxot_analytics_'; +const localStoragePrefix = 'roxot_analytics_'; -let utmTags = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content']; -let utmTtlKey = 'utm_ttl'; -let utmTtl = 60 * 60 * 1000; +const utmTags = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content']; +const utmTtlKey = 'utm_ttl'; +const utmTtl = 60 * 60 * 1000; -let isNewKey = 'is_new_flag'; -let isNewTtl = 60 * 60 * 1000; +const isNewKey = 'is_new_flag'; +const isNewTtl = 60 * 60 * 1000; -let auctionCache = {}; -let auctionTtl = 60 * 60 * 1000; +const auctionCache = {}; +const auctionTtl = 60 * 60 * 1000; -let sendEventCache = []; +const sendEventCache = []; let sendEventTimeoutId = null; -let sendEventTimeoutTime = 1000; +const sendEventTimeoutTime = 1000; function detectDevice() { if ((/ipad|android 3.0|xoom|sch-i800|playbook|tablet|kindle/i.test(navigator.userAgent.toLowerCase()))) { @@ -71,8 +71,8 @@ function detectDevice() { } function checkIsNewFlag() { - let key = buildLocalStorageKey(isNewKey); - let lastUpdate = Number(storage.getDataFromLocalStorage(key)); + const key = buildLocalStorageKey(isNewKey); + const lastUpdate = Number(storage.getDataFromLocalStorage(key)); storage.setDataInLocalStorage(key, Date.now()); return Date.now() - lastUpdate > isNewTtl; } @@ -82,7 +82,7 @@ function updateUtmTimeout() { } function isUtmTimeoutExpired() { - let utmTimestamp = storage.getDataFromLocalStorage(buildLocalStorageKey(utmTtlKey)); + const utmTimestamp = storage.getDataFromLocalStorage(buildLocalStorageKey(utmTtlKey)); return (Date.now() - utmTimestamp) > utmTtl; } @@ -99,8 +99,8 @@ function isSupportedAdUnit(adUnit) { } function deleteOldAuctions() { - for (let auctionId in auctionCache) { - let auction = auctionCache[auctionId]; + for (const auctionId in auctionCache) { + const auction = auctionCache[auctionId]; if (Date.now() - auction.start > auctionTtl) { delete auctionCache[auctionId]; } @@ -190,33 +190,33 @@ function handleAuctionInit(args) { } function handleBidRequested(args) { - let auction = auctionCache[args.auctionId]; + const auction = auctionCache[args.auctionId]; args.bids.forEach(function (bidRequest) { - let adUnitCode = extractAdUnitCode(bidRequest); - let bidder = extractBidder(bidRequest); + const adUnitCode = extractAdUnitCode(bidRequest); + const bidder = extractBidder(bidRequest); if (!isSupportedAdUnit(adUnitCode)) { return; } auction['adUnits'][adUnitCode] = auction['adUnits'][adUnitCode] || buildAdUnitAuctionEntity(auction, bidRequest); - let adUnitAuction = auction['adUnits'][adUnitCode]; + const adUnitAuction = auction['adUnits'][adUnitCode]; adUnitAuction['bidders'][bidder] = adUnitAuction['bidders'][bidder] || buildBidderRequest(auction, bidRequest); }); } function handleBidAdjustment(args) { - let adUnitCode = extractAdUnitCode(args); - let bidder = extractBidder(args); + const adUnitCode = extractAdUnitCode(args); + const bidder = extractBidder(args); if (!isSupportedAdUnit(adUnitCode)) { return; } - let adUnitAuction = auctionCache[args.auctionId]['adUnits'][adUnitCode]; + const adUnitAuction = auctionCache[args.auctionId]['adUnits'][adUnitCode]; if (adUnitAuction.status === AUCTION_STATUS.FINISHED) { handleBidAfterTimeout(adUnitAuction, args); return; } - let bidderRequest = adUnitAuction['bidders'][bidder]; + const bidderRequest = adUnitAuction['bidders'][bidder]; if (bidderRequest.cpm < args.cpm) { bidderRequest.cpm = args.cpm; bidderRequest.finish = args.responseTimestamp; @@ -229,9 +229,9 @@ function handleBidAdjustment(args) { } function handleBidAfterTimeout(adUnitAuction, args) { - let bidder = extractBidder(args); - let bidderRequest = adUnitAuction['bidders'][bidder]; - let bidAfterTimeout = buildBidAfterTimeout(adUnitAuction, args); + const bidder = extractBidder(args); + const bidderRequest = adUnitAuction['bidders'][bidder]; + const bidAfterTimeout = buildBidAfterTimeout(adUnitAuction, args); if (bidAfterTimeout.cpm > bidderRequest.cpm) { bidderRequest.cpm = bidAfterTimeout.cpm; @@ -246,20 +246,20 @@ function handleBidAfterTimeout(adUnitAuction, args) { } function handleBidderDone(args) { - let auction = auctionCache[args.auctionId]; + const auction = auctionCache[args.auctionId]; args.bids.forEach(function (bidDone) { - let adUnitCode = extractAdUnitCode(bidDone); - let bidder = extractBidder(bidDone); + const adUnitCode = extractAdUnitCode(bidDone); + const bidder = extractBidder(bidDone); if (!isSupportedAdUnit(adUnitCode)) { return; } - let adUnitAuction = auction['adUnits'][adUnitCode]; + const adUnitAuction = auction['adUnits'][adUnitCode]; if (adUnitAuction.status === AUCTION_STATUS.FINISHED) { return; } - let bidderRequest = adUnitAuction['bidders'][bidder]; + const bidderRequest = adUnitAuction['bidders'][bidder]; if (bidderRequest.status !== BIDDER_STATUS.REQUESTED) { return; } @@ -271,20 +271,20 @@ function handleBidderDone(args) { } function handleAuctionEnd(args) { - let auction = auctionCache[args.auctionId]; + const auction = auctionCache[args.auctionId]; if (!Object.keys(auction.adUnits).length) { delete auctionCache[args.auctionId]; } - let finish = Date.now(); + const finish = Date.now(); auction.finish = finish; - for (let adUnit in auction.adUnits) { - let adUnitAuction = auction.adUnits[adUnit]; + for (const adUnit in auction.adUnits) { + const adUnitAuction = auction.adUnits[adUnit]; adUnitAuction.finish = finish; adUnitAuction.status = AUCTION_STATUS.FINISHED; - for (let bidder in adUnitAuction.bidders) { - let bidderRequest = adUnitAuction.bidders[bidder]; + for (const bidder in adUnitAuction.bidders) { + const bidderRequest = adUnitAuction.bidders[bidder]; if (bidderRequest.status !== BIDDER_STATUS.REQUESTED) { continue; } @@ -297,12 +297,12 @@ function handleAuctionEnd(args) { } function handleBidWon(args) { - let adUnitCode = extractAdUnitCode(args); + const adUnitCode = extractAdUnitCode(args); if (!isSupportedAdUnit(adUnitCode)) { return; } - let adUnitAuction = auctionCache[args.auctionId]['adUnits'][adUnitCode]; - let impression = buildImpression(adUnitAuction, args); + const adUnitAuction = auctionCache[args.auctionId]['adUnits'][adUnitCode]; + const impression = buildImpression(adUnitAuction, args); registerEvent(ROXOT_EVENTS.IMPRESSION, 'Bid won', impression); } @@ -310,7 +310,7 @@ function handleOtherEvents(eventType, args) { registerEvent(eventType, eventType, args); } -let roxotAdapter = Object.assign(adapter({url: DEFAULT_EVENT_URL, analyticsType}), { +const roxotAdapter = Object.assign(adapter({url: DEFAULT_EVENT_URL, analyticsType}), { track({eventType, args}) { switch (eventType) { case AUCTION_INIT: @@ -349,10 +349,10 @@ roxotAdapter.enableAnalytics = function (config) { }; roxotAdapter.buildUtmTagData = function () { - let utmTagData = {}; + const utmTagData = {}; let utmTagsDetected = false; utmTags.forEach(function (utmTagKey) { - let utmTagValue = getParameterByName(utmTagKey); + const utmTagValue = getParameterByName(utmTagKey); if (utmTagValue !== '') { utmTagsDetected = true; } @@ -400,7 +400,7 @@ roxotAdapter.getOptions = function () { }; function registerEvent(eventType, eventName, data) { - let eventData = { + const eventData = { eventType: eventType, eventName: eventName, data: data @@ -425,8 +425,8 @@ function checkSendEvent() { } while (sendEventCache.length) { - let event = sendEventCache.shift(); - let isNeedSend = initOptions.serverConfig[event.eventType] || 0; + const event = sendEventCache.shift(); + const isNeedSend = initOptions.serverConfig[event.eventType] || 0; if (Number(isNeedSend) === 0) { _logInfo('Skip event ' + event.eventName, event); continue; @@ -444,8 +444,8 @@ function checkEventAfterTimeout() { } function sendEvent(eventType, eventName, data) { - let url = 'https://' + initOptions.server + '/' + eventType + '?publisherId=' + initOptions.publisherId + '&host=' + initOptions.host; - let eventData = { + const url = 'https://' + initOptions.server + '/' + eventType + '?publisherId=' + initOptions.publisherId + '&host=' + initOptions.host; + const eventData = { 'event': eventType, 'eventName': eventName, 'options': initOptions, @@ -467,7 +467,7 @@ function sendEvent(eventType, eventName, data) { } function loadServerConfig() { - let url = 'https://' + initOptions.configServer + '/c' + '?publisherId=' + initOptions.publisherId + '&host=' + initOptions.host; + const url = 'https://' + initOptions.configServer + '/c' + '?publisherId=' + initOptions.publisherId + '&host=' + initOptions.host; ajax( url, { diff --git a/modules/rtbhouseBidAdapter.js b/modules/rtbhouseBidAdapter.js index 9cfb59dc1e7..83536bd0abe 100644 --- a/modules/rtbhouseBidAdapter.js +++ b/modules/rtbhouseBidAdapter.js @@ -87,7 +87,7 @@ export const spec = { }); } - let computedEndpointUrl = ENDPOINT_URL; + const computedEndpointUrl = ENDPOINT_URL; return { method: 'POST', @@ -212,7 +212,7 @@ function mapSite(slot, bidderRequest) { .toString() .slice(0, 50); } - let siteData = { + const siteData = { publisher: { id: pubId.toString(), }, diff --git a/modules/rtbsapeBidAdapter.js b/modules/rtbsapeBidAdapter.js index 502b62c8799..c92d49280b3 100644 --- a/modules/rtbsapeBidAdapter.js +++ b/modules/rtbsapeBidAdapter.js @@ -40,8 +40,8 @@ export const spec = { * @return ServerRequest Info describing the request to the server. */ buildRequests: function (validBidRequests, bidderRequest) { - let tz = (new Date()).getTimezoneOffset() - let padInt = (v) => (v < 10 ? '0' + v : '' + v); + const tz = (new Date()).getTimezoneOffset() + const padInt = (v) => (v < 10 ? '0' + v : '' + v); return { url: ENDPOINT, @@ -70,17 +70,17 @@ export const spec = { return []; } - let bids = {}; + const bids = {}; bidRequest.data.bids.forEach(bid => bids[bid.bidId] = bid); return serverResponse.body.bids .filter(bid => typeof (bid.meta || {}).advertiserDomains !== 'undefined') .map(bid => { - let requestBid = bids[bid.requestId]; - let context = deepAccess(requestBid, 'mediaTypes.video.context'); + const requestBid = bids[bid.requestId]; + const context = deepAccess(requestBid, 'mediaTypes.video.context'); if (context === OUTSTREAM && (bid.vastUrl || bid.vastXml)) { - let renderer = Renderer.install({ + const renderer = Renderer.install({ id: bid.requestId, url: RENDERER_SRC, loaded: false @@ -135,7 +135,7 @@ export const spec = { * @param bid */ function setOutstreamRenderer(bid) { - let props = {}; + const props = {}; if (bid.vastUrl) { props.url = bid.vastUrl; } @@ -143,7 +143,7 @@ function setOutstreamRenderer(bid) { props.xml = bid.vastXml; } bid.renderer.push(() => { - let player = window.sapeRtbPlayerHandler(bid.adUnitCode, bid.width, bid.height, bid.playerMuted, {singleton: true}); + const player = window.sapeRtbPlayerHandler(bid.adUnitCode, bid.width, bid.height, bid.playerMuted, {singleton: true}); props.onComplete = () => player.destroy(); props.onError = () => player.destroy(); player.addSlot(props); diff --git a/modules/rtdModule/index.ts b/modules/rtdModule/index.ts index 40f1b3bc0ee..0e878e3b727 100644 --- a/modules/rtdModule/index.ts +++ b/modules/rtdModule/index.ts @@ -16,7 +16,7 @@ const activityParams = activityParamsBuilder((al) => adapterManager.resolveAlias /** @type {string} */ const MODULE_NAME = 'realTimeData'; -let registeredSubModules = []; +const registeredSubModules = []; export let subModules = []; let _moduleConfig: RealTimeDataConfig; let _dataProviders = []; @@ -117,7 +117,7 @@ function getConsentData() { */ function initSubModules() { _userConsent = getConsentData(); - let subModulesByOrder = []; + const subModulesByOrder = []; _dataProviders.forEach(provider => { const sm = ((registeredSubModules) || []).find(s => s.name === provider.name); const initResponse = sm && sm.init && sm.init(provider, _userConsent); @@ -213,7 +213,7 @@ export function getAdUnitTargeting(auction) { if (!adUnitCodes) { return; } - let targeting = []; + const targeting = []; for (let i = relevantSubModules.length - 1; i >= 0; i--) { const smTargeting = relevantSubModules[i].getTargetingData(adUnitCodes, relevantSubModules[i].config, _userConsent, auction); if (smTargeting && typeof smTargeting === 'object') { diff --git a/modules/rubiconBidAdapter.js b/modules/rubiconBidAdapter.js index fc41d4b28ad..14726e1d2ba 100644 --- a/modules/rubiconBidAdapter.js +++ b/modules/rubiconBidAdapter.js @@ -183,7 +183,7 @@ export const converter = ortbConverter({ deepSetValue(data, 'ext.prebid.targeting.pricegranularity', getPriceGranularity(config)); - let modules = (getGlobal()).installedModules; + const modules = (getGlobal()).installedModules; if (modules && (!modules.length || modules.indexOf('rubiconAnalyticsAdapter') !== -1)) { deepSetValue(data, 'ext.prebid.analytics', {'rubicon': {'client-analytics': true}}); } @@ -232,7 +232,7 @@ export const converter = ortbConverter({ bidResponse.meta.mediaType = deepAccess(bid, 'ext.prebid.type'); const {bidRequest} = context; - let [parseSizeWidth, parseSizeHeight] = bidRequest.mediaTypes.video?.context === 'outstream' ? parseSizes(bidRequest, VIDEO) : [undefined, undefined]; + const [parseSizeWidth, parseSizeHeight] = bidRequest.mediaTypes.video?.context === 'outstream' ? parseSizes(bidRequest, VIDEO) : [undefined, undefined]; // 0 by default to avoid undefined size bidResponse.width = bid.w || parseSizeWidth || bidResponse.playerWidth || 0; bidResponse.height = bid.h || parseSizeHeight || bidResponse.playerHeight || 0; @@ -274,7 +274,7 @@ export const spec = { return false } } - let bidFormats = bidType(bid, true); + const bidFormats = bidType(bid, true); // bidType is undefined? Return false if (!bidFormats.length) { return false; @@ -293,7 +293,7 @@ export const spec = { buildRequests: function (bidRequests, bidderRequest) { // separate video bids because the requests are structured differently let requests = []; - let filteredHttpRequest = []; + const filteredHttpRequest = []; let filteredRequests; filteredRequests = bidRequests.filter(req => { @@ -533,8 +533,8 @@ export const spec = { // add p_pos only if specified and valid // For SRA we need to explicitly put empty semi colons so AE treats it as empty, instead of copying the latter value - let posMapping = {1: 'atf', 3: 'btf'}; - let pos = posMapping[deepAccess(bidRequest, 'mediaTypes.banner.pos')] || ''; + const posMapping = {1: 'atf', 3: 'btf'}; + const pos = posMapping[deepAccess(bidRequest, 'mediaTypes.banner.pos')] || ''; data['p_pos'] = (params.position === 'atf' || params.position === 'btf') ? params.position : pos; // pass publisher provided userId if configured @@ -688,7 +688,7 @@ export const spec = { return []; } - let bids = ads.reduce((bids, ad, i) => { + const bids = ads.reduce((bids, ad, i) => { (ad.impression_id && lastImpId === ad.impression_id) ? multibid++ : lastImpId = ad.impression_id; if (ad.status !== 'ok') { @@ -699,7 +699,7 @@ export const spec = { const associatedBidRequest = Array.isArray(bidRequest) ? bidRequest[i - multibid] : bidRequest; if (associatedBidRequest && typeof associatedBidRequest === 'object') { - let bid = { + const bid = { requestId: associatedBidRequest.bidId, currency: 'USD', creativeId: ad.creative_id || `${ad.network || ''}-${ad.advertiser || ''}`, @@ -758,7 +758,7 @@ export const spec = { return (adB.cpm || 0.0) - (adA.cpm || 0.0); }); - let fledgeAuctionConfigs = responseObj.component_auction_config?.map(config => { + const fledgeAuctionConfigs = responseObj.component_auction_config?.map(config => { return { config, bidId: config.bidId } }); @@ -880,7 +880,7 @@ function outstreamRenderer(rtbBid) { } function parseSizes(bid, mediaType) { - let params = bid.params; + const params = bid.params; if (mediaType === VIDEO) { let size = []; if (params.video && params.video.playerWidth && params.video.playerHeight) { @@ -919,9 +919,9 @@ function applyFPD(bidRequest, mediaType, data) { if (bidRequest.params.keywords) BID_FPD.site.keywords = (isArray(bidRequest.params.keywords)) ? bidRequest.params.keywords.join(',') : bidRequest.params.keywords; - let fpd = mergeDeep({}, bidRequest.ortb2 || {}, BID_FPD); - let impExt = deepAccess(bidRequest.ortb2Imp, 'ext') || {}; - let impExtData = deepAccess(bidRequest.ortb2Imp, 'ext.data') || {}; + const fpd = mergeDeep({}, bidRequest.ortb2 || {}, BID_FPD); + const impExt = deepAccess(bidRequest.ortb2Imp, 'ext') || {}; + const impExtData = deepAccess(bidRequest.ortb2Imp, 'ext.data') || {}; const gpid = deepAccess(bidRequest, 'ortb2Imp.ext.gpid'); const dsa = deepAccess(fpd, 'regs.ext.dsa'); @@ -931,7 +931,7 @@ function applyFPD(bidRequest, mediaType, data) { if (key === 'data' && Array.isArray(prop)) { return prop.filter(name => name.segment && deepAccess(name, 'ext.segtax') && SEGTAX[parentName] && SEGTAX[parentName].indexOf(deepAccess(name, 'ext.segtax')) !== -1).map(value => { - let segments = value.segment.filter(obj => obj.id).reduce((result, obj) => { + const segments = value.segment.filter(obj => obj.id).reduce((result, obj) => { result.push(obj.id); return result; }, []); @@ -948,8 +948,8 @@ function applyFPD(bidRequest, mediaType, data) { } }; const addBannerData = function(obj, name, key, isParent = true) { - let val = validate(obj, key, name); - let loc = (MAP[key] && isParent) ? `${MAP[key]}` : (key === 'data') ? `${MAP[name]}iab` : `${MAP[name]}${key}`; + const val = validate(obj, key, name); + const loc = (MAP[key] && isParent) ? `${MAP[key]}` : (key === 'data') ? `${MAP[name]}iab` : `${MAP[name]}${key}`; data[loc] = (data[loc]) ? data[loc].concat(',', val) : val; }; @@ -1065,10 +1065,10 @@ function addDesiredSegtaxes(bidderRequest, target) { if (rubiConf.readTopics === false) { return; } - let iSegments = [1, 2, 5, 6, 7, 507].concat(rubiConf.sendSiteSegtax?.map(seg => Number(seg)) || []); - let vSegments = [4, 508].concat(rubiConf.sendUserSegtax?.map(seg => Number(seg)) || []); - let userData = bidderRequest.ortb2?.user?.data || []; - let siteData = bidderRequest.ortb2?.site?.content?.data || []; + const iSegments = [1, 2, 5, 6, 7, 507].concat(rubiConf.sendSiteSegtax?.map(seg => Number(seg)) || []); + const vSegments = [4, 508].concat(rubiConf.sendUserSegtax?.map(seg => Number(seg)) || []); + const userData = bidderRequest.ortb2?.user?.data || []; + const siteData = bidderRequest.ortb2?.site?.content?.data || []; userData.forEach(iterateOverSegmentData(target, 'v', vSegments)); siteData.forEach(iterateOverSegmentData(target, 'i', iSegments)); } @@ -1090,7 +1090,7 @@ function mapSizes(sizes) { return parseSizesInput(sizes) // map sizes while excluding non-matches .reduce((result, size) => { - let mappedSize = parseInt(sizeMap[size], 10); + const mappedSize = parseInt(sizeMap[size], 10); if (mappedSize) { result.push(mappedSize); } @@ -1106,9 +1106,9 @@ function mapSizes(sizes) { */ export function classifiedAsVideo(bidRequest) { let isVideo = typeof deepAccess(bidRequest, `mediaTypes.${VIDEO}`) !== 'undefined'; - let isBanner = typeof deepAccess(bidRequest, `mediaTypes.${BANNER}`) !== 'undefined'; - let isBidOnMultiformat = typeof deepAccess(bidRequest, `params.bidonmultiformat`) !== 'undefined'; - let isMissingVideoParams = typeof deepAccess(bidRequest, 'params.video') !== 'object'; + const isBanner = typeof deepAccess(bidRequest, `mediaTypes.${BANNER}`) !== 'undefined'; + const isBidOnMultiformat = typeof deepAccess(bidRequest, `params.bidonmultiformat`) !== 'undefined'; + const isMissingVideoParams = typeof deepAccess(bidRequest, 'params.video') !== 'object'; // If an ad has both video and banner types, a legacy implementation allows choosing video over banner // based on whether or not there is a video object defined in the params // Given this legacy implementation, other code depends on params.video being defined @@ -1133,7 +1133,7 @@ export function classifiedAsVideo(bidRequest) { */ function bidType(bid, log = false) { // Is it considered video ad unit by rubicon - let bidTypes = []; + const bidTypes = []; if (classifiedAsVideo(bid)) { // Removed legacy mediaType support. new way using mediaTypes.video object is now required // We require either context as instream or outstream @@ -1207,7 +1207,7 @@ export function masSizeOrdering(sizes) { export function determineRubiconVideoSizeId(bid) { // If we have size_id in the bid then use it - let rubiconSizeId = parseInt(deepAccess(bid, 'params.video.size_id')); + const rubiconSizeId = parseInt(deepAccess(bid, 'params.video.size_id')); if (!isNaN(rubiconSizeId)) { return rubiconSizeId; } @@ -1245,8 +1245,8 @@ export function getPriceGranularity(config) { export function hasValidVideoParams(bid) { let isValid = true; // incase future javascript changes the string represenation of the array or number classes! - let arrayType = Object.prototype.toString.call([]); - let numberType = Object.prototype.toString.call(0); + const arrayType = Object.prototype.toString.call([]); + const numberType = Object.prototype.toString.call(0); // required params and their associated object type var requiredParams = { mimes: arrayType, @@ -1320,7 +1320,7 @@ function setBidFloors(bidRequest, imp) { } if (!imp.bidfloor) { - let bidFloor = parseFloat(deepAccess(bidRequest, 'params.floor')); + const bidFloor = parseFloat(deepAccess(bidRequest, 'params.floor')); if (!isNaN(bidFloor)) { imp.bidfloor = bidFloor; diff --git a/modules/s2sTesting.js b/modules/s2sTesting.js index 23029daa3cc..18079118ffa 100644 --- a/modules/s2sTesting.js +++ b/modules/s2sTesting.js @@ -71,7 +71,7 @@ s2sTesting.getSource = function(sourceWeights = {}, bidSources = [SERVER, CLIENT // choose a source randomly based on weights var rndWeight = s2sTesting.globalRand * totWeight; for (var i = 0; i < bidSources.length; i++) { - let source = bidSources[i]; + const source = bidSources[i]; // choose the first source with an incremental weight > random weight if (rndWeight < srcIncWeight[source]) return source; } diff --git a/modules/scaleableAnalyticsAdapter.js b/modules/scaleableAnalyticsAdapter.js index 054ccb7db55..cb2fc34737a 100644 --- a/modules/scaleableAnalyticsAdapter.js +++ b/modules/scaleableAnalyticsAdapter.js @@ -10,7 +10,7 @@ import { logMessage } from '../src/utils.js'; const entries = Object.entries || function(obj) { const ownProps = Object.keys(obj); let i = ownProps.length; - let resArray = new Array(i); // preallocate the Array + const resArray = new Array(i); // preallocate the Array while (i--) { resArray[i] = [ownProps[i], obj[ownProps[i]]]; } return resArray; @@ -26,7 +26,7 @@ const ANALYTICS_TYPE = 'endpoint'; let auctionData = {}; -let scaleableAnalytics = Object.assign({}, +const scaleableAnalytics = Object.assign({}, adapter({ URL, ANALYTICS_TYPE @@ -76,8 +76,8 @@ const sendDataToServer = data => ajax(URL, () => {}, JSON.stringify(data)); const onAuctionInit = args => { const config = scaleableAnalytics.config || {options: {}}; - let adunitObj = {}; - let adunits = []; + const adunitObj = {}; + const adunits = []; // Loop through adunit codes first args.adUnitCodes.forEach((code) => { @@ -116,8 +116,8 @@ const onAuctionInit = args => { const onAuctionEnd = args => { const config = scaleableAnalytics.config || {options: {}}; - let adunitObj = {}; - let adunits = []; + const adunitObj = {}; + const adunits = []; // Add Bids Received args.bidsReceived.forEach((bidObj) => { diff --git a/modules/seedingAllianceBidAdapter.js b/modules/seedingAllianceBidAdapter.js index 10bd6183488..8b47f7c9c40 100755 --- a/modules/seedingAllianceBidAdapter.js +++ b/modules/seedingAllianceBidAdapter.js @@ -53,7 +53,7 @@ export const spec = { buildRequests: (validBidRequests = [], bidderRequest) => { const oRtbRequest = converter.toORTB({bidRequests: validBidRequests, bidderRequest}); - let eids = getEids(validBidRequests[0]); + const eids = getEids(validBidRequests[0]); // check for url in params and set in site object validBidRequests.forEach(bidRequest => { @@ -70,7 +70,7 @@ export const spec = { deepSetValue(oRtbRequest, 'user.ext.eids', eids); } - let endpoint = config.getConfig('seedingAlliance.endpoint') || ENDPOINT_URL; + const endpoint = config.getConfig('seedingAlliance.endpoint') || ENDPOINT_URL; return { method: 'POST', @@ -187,7 +187,7 @@ function parseNative(bid, nativeParams) { const { assets, link, imptrackers } = native; - let clickUrl = link.url.replace(/\$\{AUCTION_PRICE\}/g, bid.price); + const clickUrl = link.url.replace(/\$\{AUCTION_PRICE\}/g, bid.price); if (link.clicktrackers) { link.clicktrackers.forEach(function (clicktracker, index) { @@ -208,7 +208,7 @@ function parseNative(bid, nativeParams) { impressionTrackers: imptrackers || undefined }; - let nativeParamKeys = Object.keys(nativeParams); + const nativeParamKeys = Object.keys(nativeParams); let id = 0; nativeParamKeys.forEach(nativeParam => { diff --git a/modules/seedtagBidAdapter.js b/modules/seedtagBidAdapter.js index 502ec705edb..5de6792fc90 100644 --- a/modules/seedtagBidAdapter.js +++ b/modules/seedtagBidAdapter.js @@ -98,7 +98,7 @@ function hasMandatoryDisplayParams(bid) { function hasMandatoryVideoParams(bid) { const videoParams = getVideoParams(bid); - let isValid = + const isValid = !!bid.params.publisherId && !!bid.params.adUnitId && hasVideoMediaType(bid) && @@ -325,7 +325,7 @@ export const spec = { payload.schain = schain; } - let coppa = config.getConfig('coppa'); + const coppa = config.getConfig('coppa'); if (coppa) { payload.coppa = coppa; } diff --git a/modules/sharethroughAnalyticsAdapter.js b/modules/sharethroughAnalyticsAdapter.js index dc621e8da92..0857b600b49 100644 --- a/modules/sharethroughAnalyticsAdapter.js +++ b/modules/sharethroughAnalyticsAdapter.js @@ -35,7 +35,7 @@ var sharethroughAdapter = Object.assign(adapter( const curBidderCode = args.bidderCode; if (curBidderCode !== STR_BIDDER_CODE && (args.adUnitCode in this.placementCodeSet)) { - let strBid = this.placementCodeSet[args.adUnitCode]; + const strBid = this.placementCodeSet[args.adUnitCode]; this.fireLoseBeacon(curBidderCode, args.cpm, strBid.adserverRequestId, 'headerBidLose'); } }, diff --git a/modules/showheroes-bsBidAdapter.js b/modules/showheroes-bsBidAdapter.js index afac0a88567..d6ebcc5ceab 100644 --- a/modules/showheroes-bsBidAdapter.js +++ b/modules/showheroes-bsBidAdapter.js @@ -38,7 +38,7 @@ const converter = ortbConverter({ return imp } - let floor = bidRequest.getFloor({ + const floor = bidRequest.getFloor({ currency: 'EUR', mediaType: '*', size: '*', diff --git a/modules/silverpushBidAdapter.js b/modules/silverpushBidAdapter.js index 70c0e475cc4..97b6e9b794d 100644 --- a/modules/silverpushBidAdapter.js +++ b/modules/silverpushBidAdapter.js @@ -84,7 +84,7 @@ export const CONVERTER = ortbConverter({ } }) - let userAgent = navigator.userAgent; + const userAgent = navigator.userAgent; utils.deepSetValue(req, 'device.os', spec.getOS(userAgent)); utils.deepSetValue(req, 'device.devicetype', _isMobile() ? 1 : _isConnectedTV() ? 3 : 2); @@ -141,7 +141,7 @@ function isBidRequestValid(bidRequest) { } function isPublisherIdValid(bidRequest) { - let pubId = utils.deepAccess(bidRequest, 'params.publisherId'); + const pubId = utils.deepAccess(bidRequest, 'params.publisherId'); return (pubId != null && utils.isStr(pubId) && pubId != ''); } @@ -159,9 +159,9 @@ function isValidVideoRequest(bidRequest) { } function buildRequests(validBids, bidderRequest) { - let videoBids = validBids.filter(bid => isVideoBid(bid)); - let bannerBids = validBids.filter(bid => isBannerBid(bid)); - let requests = []; + const videoBids = validBids.filter(bid => isVideoBid(bid)); + const bannerBids = validBids.filter(bid => isBannerBid(bid)); + const requests = []; bannerBids.forEach(bid => { requests.push(createRequest([bid], bidderRequest, BANNER)); @@ -273,7 +273,7 @@ function _renderer(bid) { }); try { - let vastUrlbt = 'data:text/xml;charset=utf-8;base64,' + btoa(bid.vastUrl.replace(/\\"/g, '"')); + const vastUrlbt = 'data:text/xml;charset=utf-8;base64,' + btoa(bid.vastUrl.replace(/\\"/g, '"')); spoplayer.load(vastUrlbt).then(function() { window.spoplayer = spoplayer; }).catch(function(reason) { diff --git a/modules/sirdataRtdProvider.js b/modules/sirdataRtdProvider.js index 724e3b3d329..77c6f939a95 100644 --- a/modules/sirdataRtdProvider.js +++ b/modules/sirdataRtdProvider.js @@ -99,7 +99,7 @@ let params = { */ export function setCookieOnTopDomain(key, value, hostname, deleteCookie) { const subDomains = hostname.split('.'); - let expTime = new Date(); + const expTime = new Date(); expTime.setTime(expTime.getTime() + (deleteCookie ? -1 : 365 * 24 * 60 * 60 * 1000)); // Set expiration time for (let i = 0; i < subDomains.length; ++i) { // Try to write the cookie on this subdomain (we want it to be stored only on the TLD+1) @@ -121,7 +121,7 @@ export function setCookieOnTopDomain(key, value, hostname, deleteCookie) { */ export function getUidFromStorage() { let cUid = STORAGE.getCookie(EUIDS_STORAGE_NAME, null); - let lsUid = STORAGE.getDataFromLocalStorage(EUIDS_STORAGE_NAME, null); + const lsUid = STORAGE.getDataFromLocalStorage(EUIDS_STORAGE_NAME, null); if (cUid && (!lsUid || cUid !== lsUid)) { STORAGE.setDataInLocalStorage(EUIDS_STORAGE_NAME, cUid, null); } else if (lsUid && !cUid) { @@ -489,7 +489,7 @@ export function pushToOrtb2(ortb2Fragments, bidder, data, segtaxid, cattaxid) { */ export function setOrtb2Sda(ortb2Fragments, bidder, type, segments, segtaxValue) { try { - let ortb2Data = [{ name: ORTB2_NAME, segment: segments.map(segmentId => ({ id: segmentId })) }]; + const ortb2Data = [{ name: ORTB2_NAME, segment: segments.map(segmentId => ({ id: segmentId })) }]; if (segtaxValue) ortb2Data[0].ext = { segtax: segtaxValue }; let ortb2Conf = (type === 'site') ? { site: { content: { data: ortb2Data } } } : { user: { data: ortb2Data } }; if (bidder) ortb2Conf = { [bidder]: ortb2Conf }; @@ -547,16 +547,16 @@ export function loadCustomFunction(todo, adUnit, list, data, bid) { * @returns {Object} - The segments and categories data */ export function getSegAndCatsArray(data, minScore, pid) { - let sirdataData = { segments: [], categories: [], categories_score: {} }; + const sirdataData = { segments: [], categories: [], categories_score: {} }; minScore = typeof minScore === 'number' ? minScore : 30; const { cattaxid, segtaxid, segments } = data; const contextualCategories = data.contextual_categories || {}; // parses contextual categories try { if (contextualCategories) { - for (let catId in contextualCategories) { + for (const catId in contextualCategories) { if (contextualCategories.hasOwnProperty(catId) && contextualCategories[catId]) { - let value = contextualCategories[catId]; + const value = contextualCategories[catId]; if (value >= minScore && !sirdataData.categories.includes(catId)) { if (pid === '27440' && cattaxid) { // Equativ only sirdataData.categories.push(`${pid}cc${catId}`); @@ -574,9 +574,9 @@ export function getSegAndCatsArray(data, minScore, pid) { // parses user-centric segments (empty if no right to access device/process PII) try { if (segments) { - for (let segId in segments) { + for (const segId in segments) { if (segments.hasOwnProperty(segId) && segments[segId]) { - let id = segments[segId].toString(); + const id = segments[segId].toString(); if (pid === '27440' && segtaxid) { // Equativ only sirdataData.segments.push(`${pid}us${id}`); } else { @@ -612,16 +612,16 @@ export function applySdaGetSpecificData(data, sirdataData, biddersParamsExist, r // Only share Publisher SDA data if whitelisted if (!biddersParamsExist || bidderIndex) { // SDA Publisher - let sirdataDataForSDA = getSegAndCatsArray(data, params.contextualMinRelevancyScore, params.partnerId.toString()); + const sirdataDataForSDA = getSegAndCatsArray(data, params.contextualMinRelevancyScore, params.partnerId.toString()); pushToOrtb2(reqBids.ortb2Fragments?.bidder, bid.bidder, sirdataDataForSDA, data.segtaxid, data.cattaxid); } // Always share SDA for curation if (!isEmpty(data.shared_taxonomy)) { - let curationId = (bidderIndex && params.bidders[bidderIndex]?.curationId) || biddersId[aliasActualBidder]; + const curationId = (bidderIndex && params.bidders[bidderIndex]?.curationId) || biddersId[aliasActualBidder]; if (curationId && data.shared_taxonomy[curationId]) { // Seller defined audience & bidder specific data - let curationData = getSegAndCatsArray(data.shared_taxonomy[curationId], params.contextualMinRelevancyScore, curationId.toString()); + const curationData = getSegAndCatsArray(data.shared_taxonomy[curationId], params.contextualMinRelevancyScore, curationId.toString()); if (!isEmpty(curationData)) { pushToOrtb2(reqBids.ortb2Fragments?.bidder, bid.bidder, curationData, data.shared_taxonomy[curationId].segtaxid, data.shared_taxonomy[curationId].cattaxid); mergeDeep(sirdataData, curationData); @@ -643,13 +643,13 @@ export function applySdaGetSpecificData(data, sirdataData, biddersParamsExist, r export function addSegmentData(reqBids, data, adUnits, onDone) { logInfo(LOG_PREFIX, 'Dispatch Segments And Categories'); const minScore = params.contextualMinRelevancyScore || 30; - let sirdataData = getSegAndCatsArray(data, minScore, ''); + const sirdataData = getSegAndCatsArray(data, minScore, ''); const biddersParamsExist = params.bidders.length > 0; // Global ortb2 SDA if (!isEmpty(data.global_taxonomy)) { - for (let i in data.global_taxonomy) { + for (const i in data.global_taxonomy) { let globalData; if (!isEmpty(data.global_taxonomy[i])) { globalData = getSegAndCatsArray(data.global_taxonomy[i], params.contextualMinRelevancyScore, ''); @@ -689,7 +689,7 @@ export function addSegmentData(reqBids, data, adUnits, onDone) { try { const aliasActualBidder = bidderAliasRegistry[bid.bidder] || bid.bidder; if (aliasActualBidder === 'appnexus') { - let xandrData = applySdaGetSpecificData(data, sirdataData, biddersParamsExist, reqBids, bid, bidderIndex, adUnit, aliasActualBidder); + const xandrData = applySdaGetSpecificData(data, sirdataData, biddersParamsExist, reqBids, bid, bidderIndex, adUnit, aliasActualBidder); // Surprisingly, to date Xandr doesn't support SDA, we need to set specific 'keywords' entries if (xandrData.segments.length > 0) { setOrtb2(reqBids.ortb2Fragments?.bidder, bid.bidder, 'user.keywords', `sd_rtd=${xandrData.segments.join(',sd_rtd=')}`); diff --git a/modules/sizeMapping.js b/modules/sizeMapping.js index 06c06eddabc..542dda86a02 100644 --- a/modules/sizeMapping.js +++ b/modules/sizeMapping.js @@ -48,7 +48,7 @@ export function getLabels(bidOrAdUnit, activeLabels) { * @returns {boolean} */ export function sizeSupported(size, configs = sizeConfig) { - let maps = evaluateSizeConfig(configs); + const maps = evaluateSizeConfig(configs); if (!maps.shouldFilter) { return true; } @@ -77,7 +77,7 @@ if (FEATURES.VIDEO) { * @returns {Object} [return.filterResults] - The filter results before and after applying size filtering. */ export function resolveStatus({labels = [], labelAll = false, activeLabels = []} = {}, mediaTypes, configs = sizeConfig) { - let maps = evaluateSizeConfig(configs); + const maps = evaluateSizeConfig(configs); let filtered = false; let hasSize = false; @@ -104,7 +104,7 @@ export function resolveStatus({labels = [], labelAll = false, activeLabels = []} hasSize = Object.values(SIZE_PROPS).find(prop => deepAccess(mediaTypes, prop)?.length) != null } - let results = { + const results = { active: ( !Object.keys(SIZE_PROPS).find(mediaType => mediaTypes.hasOwnProperty(mediaType)) ) || ( @@ -171,7 +171,7 @@ function evaluateSizeConfig(configs) { export function processAdUnitsForLabels(adUnits, activeLabels) { return adUnits.reduce((adUnits, adUnit) => { - let { + const { active, mediaTypes, filterResults @@ -190,7 +190,7 @@ export function processAdUnitsForLabels(adUnits, activeLabels) { adUnit.mediaTypes = mediaTypes; adUnit.bids = adUnit.bids.reduce((bids, bid) => { - let { + const { active, mediaTypes, filterResults diff --git a/modules/sizeMappingV2.js b/modules/sizeMappingV2.js index 64fd59c9062..294adc94038 100644 --- a/modules/sizeMappingV2.js +++ b/modules/sizeMappingV2.js @@ -43,13 +43,13 @@ export function isUsingNewSizeMapping(adUnits) { if (V2_ADUNITS.has(adUnit)) return V2_ADUNITS.get(adUnit); if (adUnit.mediaTypes) { // checks for the presence of sizeConfig property at the adUnit.mediaTypes object - for (let mediaType of Object.keys(adUnit.mediaTypes)) { + for (const mediaType of Object.keys(adUnit.mediaTypes)) { if (adUnit.mediaTypes[mediaType].sizeConfig) { V2_ADUNITS.set(adUnit, true); return true; } } - for (let bid of adUnit.bids && isArray(adUnit.bids) ? adUnit.bids : []) { + for (const bid of adUnit.bids && isArray(adUnit.bids) ? adUnit.bids : []) { if (bid.sizeConfig) { V2_ADUNITS.set(adUnit, true); return true; @@ -329,7 +329,7 @@ export function getFilteredMediaTypes(mediaTypes) { transformedMediaTypes = deepClone(mediaTypes); - let activeSizeBucket = { + const activeSizeBucket = { banner: undefined, video: undefined, native: undefined diff --git a/modules/slimcutBidAdapter.js b/modules/slimcutBidAdapter.js index a95a716556d..2d69f9eddab 100644 --- a/modules/slimcutBidAdapter.js +++ b/modules/slimcutBidAdapter.js @@ -46,10 +46,10 @@ export const spec = { data: bids, deviceWidth: screen.width }; - let gdpr = bidderRequest.gdprConsent; + const gdpr = bidderRequest.gdprConsent; if (bidderRequest && gdpr) { - let isCmp = (typeof gdpr.gdprApplies === 'boolean') - let isConsentString = (typeof gdpr.consentString === 'string') + const isCmp = (typeof gdpr.gdprApplies === 'boolean') + const isConsentString = (typeof gdpr.consentString === 'string') payload.gdpr_iab = { consent: isConsentString ? gdpr.consentString : '', status: isCmp ? gdpr.gdprApplies : -1 @@ -108,7 +108,7 @@ export const spec = { } function buildRequestObject(bid) { const reqObj = {}; - let placementId = getValue(bid.params, 'placementId'); + const placementId = getValue(bid.params, 'placementId'); reqObj.sizes = parseSizesInput(bid.sizes); reqObj.bidId = getBidIdParameter('bidId', bid); reqObj.bidderRequestId = getBidIdParameter('bidderRequestId', bid); diff --git a/modules/smaatoBidAdapter.js b/modules/smaatoBidAdapter.js index cecbd6fa162..9d92a6dc543 100644 --- a/modules/smaatoBidAdapter.js +++ b/modules/smaatoBidAdapter.js @@ -80,7 +80,7 @@ export const spec = { buildRequests: (bidRequests, bidderRequest) => { logInfo('[SMAATO] Client version:', SMAATO_CLIENT); - let requests = []; + const requests = []; bidRequests.forEach(bid => { // separate requests per mediaType SUPPORTED_MEDIA_TYPES.forEach(mediaType => { @@ -128,7 +128,7 @@ export const spec = { const bids = []; response.seatbid.forEach(seatbid => { seatbid.bid.forEach(bid => { - let resultingBid = { + const resultingBid = { requestId: bid.impid, cpm: bid.price || 0, width: bid.w, @@ -438,7 +438,7 @@ function createAdPodImp(imp, videoMediaType) { }; const numberOfPlacements = getAdPodNumberOfPlacements(videoMediaType) - let imps = fill(imp, numberOfPlacements) + const imps = fill(imp, numberOfPlacements) const durationRangeSec = videoMediaType.durationRangeSec if (videoMediaType.requireExactDuration) { diff --git a/modules/smartadserverBidAdapter.js b/modules/smartadserverBidAdapter.js index 73073e3da31..904c02ea1c5 100644 --- a/modules/smartadserverBidAdapter.js +++ b/modules/smartadserverBidAdapter.js @@ -188,7 +188,7 @@ export const spec = { // pull requested transaction ID from bidderRequest.bids[].transactionId return validBidRequests.reduce((bidRequests, bid) => { // Common bid request attributes for banner, outstream and instream. - let payload = { + const payload = { siteid: bid.params.siteId, pageid: bid.params.pageId, formatid: bid.params.formatId, @@ -255,7 +255,7 @@ export const spec = { payload.sizes = spec.adaptBannerSizes(bannerMediaType.sizes); if (isSupportedVideoContext) { - let videoPayload = deepClone(payload); + const videoPayload = deepClone(payload); spec.fillPayloadForVideoBidRequest(videoPayload, videoMediaType, bid.params.video); videoPayload.bidfloor = bid.params.bidfloor || getBidFloor(bid, adServerCurrency, VIDEO); bidRequests.push(spec.createServerRequest(videoPayload, bid.params.domain)); @@ -284,12 +284,12 @@ export const spec = { */ interpretResponse: function (serverResponse, bidRequestString) { const bidResponses = []; - let response = serverResponse.body; + const response = serverResponse.body; try { if (response && !response.isNoAd && (response.ad || response.adUrl)) { const bidRequest = JSON.parse(bidRequestString.data); - let bidResponse = { + const bidResponse = { requestId: bidRequest.bidId, cpm: response.cpm, width: response.width, diff --git a/modules/smartxBidAdapter.js b/modules/smartxBidAdapter.js index 55254e9bd82..95ab767721d 100644 --- a/modules/smartxBidAdapter.js +++ b/modules/smartxBidAdapter.js @@ -120,7 +120,7 @@ export const spec = { const api = getBidIdParameter('api', bid.params) || [2]; const protocols = getBidIdParameter('protocols', bid.params) || [2, 3, 5, 6]; - let smartxReq = [{ + const smartxReq = [{ id: bid.bidId, secure: secure, bidfloor: bidfloor, @@ -287,7 +287,7 @@ export const spec = { _each(serverResponseBody.seatbid, function (bids) { _each(bids.bid, function (smartxBid) { let currentBidRequest = {}; - for (let i in bidderRequest.bidRequest.bids) { + for (const i in bidderRequest.bidRequest.bids) { if (smartxBid.impid == bidderRequest.bidRequest.bids[i].bidId) { currentBidRequest = bidderRequest.bidRequest.bids[i]; } @@ -365,15 +365,15 @@ export const spec = { } function createOutstreamConfig(bid) { - let confMinAdWidth = getBidIdParameter('minAdWidth', bid.renderer.config.outstream_options) || 290; - let confMaxAdWidth = getBidIdParameter('maxAdWidth', bid.renderer.config.outstream_options) || 900; - let confStartOpen = getBidIdParameter('startOpen', bid.renderer.config.outstream_options) - let confEndingScreen = getBidIdParameter('endingScreen', bid.renderer.config.outstream_options) - let confTitle = getBidIdParameter('title', bid.renderer.config.outstream_options); - let confSkipOffset = getBidIdParameter('skipOffset', bid.renderer.config.outstream_options); - let confDesiredBitrate = getBidIdParameter('desiredBitrate', bid.renderer.config.outstream_options); - let confVisibilityThreshold = getBidIdParameter('visibilityThreshold', bid.renderer.config.outstream_options); - let elementId = getBidIdParameter('slot', bid.renderer.config.outstream_options) || bid.adUnitCode; + const confMinAdWidth = getBidIdParameter('minAdWidth', bid.renderer.config.outstream_options) || 290; + const confMaxAdWidth = getBidIdParameter('maxAdWidth', bid.renderer.config.outstream_options) || 900; + const confStartOpen = getBidIdParameter('startOpen', bid.renderer.config.outstream_options) + const confEndingScreen = getBidIdParameter('endingScreen', bid.renderer.config.outstream_options) + const confTitle = getBidIdParameter('title', bid.renderer.config.outstream_options); + const confSkipOffset = getBidIdParameter('skipOffset', bid.renderer.config.outstream_options); + const confDesiredBitrate = getBidIdParameter('desiredBitrate', bid.renderer.config.outstream_options); + const confVisibilityThreshold = getBidIdParameter('visibilityThreshold', bid.renderer.config.outstream_options); + const elementId = getBidIdParameter('slot', bid.renderer.config.outstream_options) || bid.adUnitCode; logMessage('[SMARTX][renderer] Handle SmartX outstream renderer'); @@ -460,7 +460,7 @@ function createOutstreamConfig(bid) { */ function getBidFloor(bid) { let floor = getBidIdParameter('bidfloor', bid.params); - let floorcur = getBidIdParameter('bidfloorcur', bid.params) || 'EUR'; + const floorcur = getBidIdParameter('bidfloorcur', bid.params) || 'EUR'; if (!floor && isFn(bid.getFloor)) { const floorObj = bid.getFloor({ diff --git a/modules/smartyadsAnalyticsAdapter.js b/modules/smartyadsAnalyticsAdapter.js index b6f34058a1d..b887f65beb5 100644 --- a/modules/smartyadsAnalyticsAdapter.js +++ b/modules/smartyadsAnalyticsAdapter.js @@ -21,9 +21,9 @@ const ANALYTICS_TYPE = 'endpoint'; const BIDDER_CODE = 'smartyads'; const GVLID = 534; -let smartyParams = {}; +const smartyParams = {}; -let smartyadsAdapter = Object.assign({}, +const smartyadsAdapter = Object.assign({}, adapter({ url: URL, analyticsType: ANALYTICS_TYPE, @@ -84,7 +84,7 @@ const auctionHandler = (eventType, data) => { } const bidHandler = (eventType, bid) => { - let bids = bid.length ? bid : [ bid ]; + const bids = bid.length ? bid : [ bid ]; for (const bidObj of bids) { let bidToSend; diff --git a/modules/smartyadsBidAdapter.js b/modules/smartyadsBidAdapter.js index 67904d10fe6..23d3aaedabd 100644 --- a/modules/smartyadsBidAdapter.js +++ b/modules/smartyadsBidAdapter.js @@ -23,11 +23,11 @@ export const spec = { // convert Native ORTB definition to old-style prebid native definition validBidRequests = convertOrtbRequestToProprietaryNative(validBidRequests); - let winTop = window; + const winTop = window; let location; location = bidderRequest?.refererInfo ?? null; - let placements = []; - let request = { + const placements = []; + const request = { 'deviceWidth': winTop.screen.width, 'deviceHeight': winTop.screen.height, 'host': location?.domain ?? '', @@ -51,11 +51,11 @@ export const spec = { let adUrl; for (let i = 0; i < len; i++) { - let bid = validBidRequests[i]; + const bid = validBidRequests[i]; if (i === 0) adUrl = getAdUrlByRegion(bid); - let traff = bid.params.traffic || BANNER; + const traff = bid.params.traffic || BANNER; placements.push({ placementId: bid.params.sourceid, bidId: bid.bidId, diff --git a/modules/smartytechBidAdapter.js b/modules/smartytechBidAdapter.js index c081b49c2e6..6f3de10be3c 100644 --- a/modules/smartytechBidAdapter.js +++ b/modules/smartytechBidAdapter.js @@ -55,11 +55,11 @@ export const spec = { const referer = bidderRequest?.refererInfo?.page || window.location.href; const bidRequests = validBidRequests.map((validBidRequest) => { - let video = deepAccess(validBidRequest, 'mediaTypes.video', false); - let banner = deepAccess(validBidRequest, 'mediaTypes.banner', false); - let sizes = validBidRequest.params.sizes; + const video = deepAccess(validBidRequest, 'mediaTypes.video', false); + const banner = deepAccess(validBidRequest, 'mediaTypes.banner', false); + const sizes = validBidRequest.params.sizes; - let oneRequest = { + const oneRequest = { endpointId: validBidRequest.params.endpointId, adUnitCode: validBidRequest.adUnitCode, referer: referer, @@ -83,7 +83,7 @@ export const spec = { return oneRequest }); - let adPartnerRequestUrl = buildUrl({ + const adPartnerRequestUrl = buildUrl({ protocol: ENDPOINT_PROTOCOL, hostname: ENDPOINT_DOMAIN, pathname: ENDPOINT_PATH, diff --git a/modules/smilewantedBidAdapter.js b/modules/smilewantedBidAdapter.js index cbde1229ac8..5e47fe3cf47 100644 --- a/modules/smilewantedBidAdapter.js +++ b/modules/smilewantedBidAdapter.js @@ -120,7 +120,7 @@ export const spec = { if (nativeMediaType) { payload.context = 'native'; payload.nativeParams = nativeMediaType; - let sizes = deepAccess(bid, 'mediaTypes.native.image.sizes', []); + const sizes = deepAccess(bid, 'mediaTypes.native.image.sizes', []); if (sizes.length > 0) { const size = Array.isArray(sizes[0]) ? sizes[0] : sizes; @@ -215,7 +215,7 @@ export const spec = { const syncs = []; if (syncOptions.iframeEnabled) { - let params = []; + const params = []; if (gdprConsent && typeof gdprConsent.consentString === 'string') { // add 'gdpr' only if 'gdprApplies' is defined diff --git a/modules/sonaradsBidAdapter.js b/modules/sonaradsBidAdapter.js index e424d632adc..c53c407c455 100644 --- a/modules/sonaradsBidAdapter.js +++ b/modules/sonaradsBidAdapter.js @@ -75,7 +75,7 @@ const CONVERTER = ortbConverter({ * @returns {Object} The constructed impression object. */ function imp(buildImp, bidRequest, context) { - let imp = buildImp(bidRequest, context); + const imp = buildImp(bidRequest, context); const params = bidRequest.params; imp.tagid = bidRequest.adUnitCode; @@ -114,7 +114,7 @@ function imp(buildImp, bidRequest, context) { * @returns {Object} The complete oRTB request object. */ function request(buildRequest, imps, bidderRequest, context) { - let request = buildRequest(imps, bidderRequest, context); + const request = buildRequest(imps, bidderRequest, context); const siteId = context.bidRequests[0]?.params?.siteId; deepSetValue(request, 'auctionStart', bidderRequest.auctionStart); @@ -218,7 +218,7 @@ export const spec = { return []; } - let pixelType = syncOptions.iframeEnabled ? 'iframe' : 'image'; + const pixelType = syncOptions.iframeEnabled ? 'iframe' : 'image'; let syncUrl = SERVER_PATH_US1_SYNC + '?'; syncUrl = gdprConsent ? tryAppendQueryString(syncUrl, 'gdpr', gdprConsent.gdprApplies ? 1 : 0) : syncUrl; diff --git a/modules/sonobiBidAdapter.js b/modules/sonobiBidAdapter.js index efde29b8cc9..324541ac02f 100644 --- a/modules/sonobiBidAdapter.js +++ b/modules/sonobiBidAdapter.js @@ -82,7 +82,7 @@ export const spec = { } }); - let data = {}; + const data = {}; bids.forEach((bid) => { Object.assign(data, bid); }); const payload = { @@ -143,7 +143,7 @@ export const spec = { payload.eids = JSON.stringify(eids); } - let keywords = getAllOrtbKeywords(bidderRequest.ortb2, ...validBidRequests.map(br => br.params.keywords)).join(','); + const keywords = getAllOrtbKeywords(bidderRequest.ortb2, ...validBidRequests.map(br => br.params.keywords)).join(','); if (keywords) { payload.kw = keywords; @@ -253,7 +253,7 @@ export const spec = { bidRequest, 'renderer.options' )); - let videoSize = deepAccess(bidRequest, 'mediaTypes.video.playerSize'); + const videoSize = deepAccess(bidRequest, 'mediaTypes.video.playerSize'); if (videoSize) { bids.width = videoSize[0]; bids.height = videoSize[1]; @@ -294,7 +294,7 @@ function _findBidderRequest(bidderRequests, bidId) { // This function takes all the possible sizes. // returns string csv. function _validateSize(bid) { - let size = []; + const size = []; if (deepAccess(bid, 'mediaTypes.video.playerSize')) { size.push(deepAccess(bid, 'mediaTypes.video.playerSize')) } @@ -356,11 +356,11 @@ function _validateMediaType(bidRequest) { mediaTypeValidation = `${mediaTypeValidation}pm=${deepAccess(bidRequest, 'mediaTypes.video.playbackmethod').join(':')},`; } if (deepAccess(bidRequest, 'mediaTypes.video.placement')) { - let placement = deepAccess(bidRequest, 'mediaTypes.video.placement'); + const placement = deepAccess(bidRequest, 'mediaTypes.video.placement'); mediaTypeValidation = `${mediaTypeValidation}p=${placement},`; } if (deepAccess(bidRequest, 'mediaTypes.video.plcmt')) { - let plcmt = deepAccess(bidRequest, 'mediaTypes.video.plcmt'); + const plcmt = deepAccess(bidRequest, 'mediaTypes.video.plcmt'); mediaTypeValidation = `${mediaTypeValidation}pl=${plcmt},`; } if (deepAccess(bidRequest, 'mediaTypes.video.protocols')) { @@ -377,35 +377,35 @@ function _validateMediaType(bidRequest) { } if (deepAccess(bidRequest, 'mediaTypes.video.minduration')) { - let minduration = deepAccess(bidRequest, 'mediaTypes.video.minduration'); + const minduration = deepAccess(bidRequest, 'mediaTypes.video.minduration'); mediaTypeValidation = `${mediaTypeValidation}minduration=${minduration},`; } if (deepAccess(bidRequest, 'mediaTypes.video.maxduration')) { - let maxduration = deepAccess(bidRequest, 'mediaTypes.video.maxduration'); + const maxduration = deepAccess(bidRequest, 'mediaTypes.video.maxduration'); mediaTypeValidation = `${mediaTypeValidation}maxduration=${maxduration},`; } if (deepAccess(bidRequest, 'mediaTypes.video.skip')) { - let skip = deepAccess(bidRequest, 'mediaTypes.video.skip'); + const skip = deepAccess(bidRequest, 'mediaTypes.video.skip'); mediaTypeValidation = `${mediaTypeValidation}skip=${skip},`; } if (deepAccess(bidRequest, 'mediaTypes.video.skipafter')) { - let skipafter = deepAccess(bidRequest, 'mediaTypes.video.skipafter'); + const skipafter = deepAccess(bidRequest, 'mediaTypes.video.skipafter'); mediaTypeValidation = `${mediaTypeValidation}skipafter=${skipafter},`; } if (deepAccess(bidRequest, 'mediaTypes.video.startdelay')) { - let startdelay = deepAccess(bidRequest, 'mediaTypes.video.startdelay'); + const startdelay = deepAccess(bidRequest, 'mediaTypes.video.startdelay'); mediaTypeValidation = `${mediaTypeValidation}startdelay=${startdelay},`; } if (deepAccess(bidRequest, 'mediaTypes.video.linearity')) { - let linearity = deepAccess(bidRequest, 'mediaTypes.video.linearity'); + const linearity = deepAccess(bidRequest, 'mediaTypes.video.linearity'); mediaTypeValidation = `${mediaTypeValidation}linearity=${linearity},`; } if (deepAccess(bidRequest, 'mediaTypes.video.minbitrate')) { - let minbitrate = deepAccess(bidRequest, 'mediaTypes.video.minbitrate'); + const minbitrate = deepAccess(bidRequest, 'mediaTypes.video.minbitrate'); mediaTypeValidation = `${mediaTypeValidation}minbitrate=${minbitrate},`; } if (deepAccess(bidRequest, 'mediaTypes.video.maxbitrate')) { - let maxbitrate = deepAccess(bidRequest, 'mediaTypes.video.maxbitrate'); + const maxbitrate = deepAccess(bidRequest, 'mediaTypes.video.maxbitrate'); mediaTypeValidation = `${mediaTypeValidation}maxbitrate=${maxbitrate},`; } } else if (mediaType === 'display') { @@ -565,7 +565,7 @@ function getBidFloor(bid) { return (bid.params.floor) ? bid.params.floor : null; } - let floor = bid.getFloor({ + const floor = bid.getFloor({ currency: 'USD', mediaType: '*', size: '*' diff --git a/modules/sovrnBidAdapter.js b/modules/sovrnBidAdapter.js index d96cf6c2f74..84fc90e72b9 100644 --- a/modules/sovrnBidAdapter.js +++ b/modules/sovrnBidAdapter.js @@ -68,7 +68,7 @@ export const spec = { */ buildRequests: function(bidReqs, bidderRequest) { try { - let sovrnImps = []; + const sovrnImps = []; let iv; let schain; let eids; @@ -223,7 +223,7 @@ export const spec = { if (!id || !seatbid || !Array.isArray(seatbid)) return [] try { - let bids = seatbid + const bids = seatbid .filter(seat => seat) .map(seat => seat.bid.map(sovrnBid => { const bid = { diff --git a/modules/sparteoBidAdapter.js b/modules/sparteoBidAdapter.js index 2bb08707c85..edf4b28f5a5 100644 --- a/modules/sparteoBidAdapter.js +++ b/modules/sparteoBidAdapter.js @@ -70,8 +70,8 @@ export const spec = { * @return boolean True if this is a valid bid, and false otherwise. */ isBidRequestValid: function (bid) { - let bannerParams = deepAccess(bid, 'mediaTypes.banner'); - let videoParams = deepAccess(bid, 'mediaTypes.video'); + const bannerParams = deepAccess(bid, 'mediaTypes.banner'); + const videoParams = deepAccess(bid, 'mediaTypes.video'); if (!bid.params) { logError('The bid params are missing'); @@ -94,7 +94,7 @@ export const spec = { */ if (bannerParams) { - let sizes = bannerParams.sizes; + const sizes = bannerParams.sizes; if (!sizes || parseSizesInput(sizes).length == 0) { logError('mediaTypes.banner.sizes must be set for banner placement at the right format.'); diff --git a/modules/ssmasBidAdapter.js b/modules/ssmasBidAdapter.js index 0b70a80e757..29d3b787ad1 100644 --- a/modules/ssmasBidAdapter.js +++ b/modules/ssmasBidAdapter.js @@ -97,7 +97,7 @@ export const spec = { ) => { const syncs = []; - let params = ['pbjs=1']; + const params = ['pbjs=1']; if (gdprConsent) { if (typeof gdprConsent.gdprApplies === 'boolean') { diff --git a/modules/sspBCBidAdapter.js b/modules/sspBCBidAdapter.js index 4e759ddf4b9..3625b912579 100644 --- a/modules/sspBCBidAdapter.js +++ b/modules/sspBCBidAdapter.js @@ -53,7 +53,7 @@ const getNativeAssetType = id => { } // ...others should be decoded from nativeAssetMap - for (let assetName in nativeAssetMap) { + for (const assetName in nativeAssetMap) { const assetId = nativeAssetMap[assetName]; if (assetId === id) { return assetName; @@ -269,7 +269,7 @@ const applyGdpr = (bidderRequest, ortbRequest) => { */ const getHighestFloor = (slot) => { const currency = requestCurrency - let result = { floor: 0, currency }; + const result = { floor: 0, currency }; if (typeof slot.getFloor === 'function') { let bannerFloor = 0; @@ -793,7 +793,7 @@ const spec = { getUserSyncs(syncOptions, _, gdprConsent = {}) { const {iframeEnabled, pixelEnabled} = syncOptions; const {gdprApplies, consentString = ''} = gdprConsent; - let mySyncs = []; + const mySyncs = []; if (iframeEnabled) { mySyncs.push({ type: 'iframe', diff --git a/modules/stackadaptBidAdapter.js b/modules/stackadaptBidAdapter.js index f6989b24fb3..02494f0003f 100644 --- a/modules/stackadaptBidAdapter.js +++ b/modules/stackadaptBidAdapter.js @@ -185,7 +185,7 @@ function getBidFloor(bidRequest) { } if (isFn(bidRequest.getFloor)) { - let floor = bidRequest.getFloor({ + const floor = bidRequest.getFloor({ currency: CURRENCY, mediaType: '*', size: '*' diff --git a/modules/storageControl.ts b/modules/storageControl.ts index 2b05ab07b33..c57470528c0 100644 --- a/modules/storageControl.ts +++ b/modules/storageControl.ts @@ -56,6 +56,7 @@ export function getDisclosures(params, meta = metadata) { } Object.entries(disclosureURLs).forEach(([componentName, disclosureURL]) => { meta.getStorageDisclosure(disclosureURL) + ?.disclosures ?.filter(disclosure => matches(params, disclosure)) ?.forEach(disclosure => { matchingDisclosures.push({ diff --git a/modules/stvBidAdapter.js b/modules/stvBidAdapter.js index 646ef591246..98caa33fb03 100644 --- a/modules/stvBidAdapter.js +++ b/modules/stvBidAdapter.js @@ -46,13 +46,13 @@ export const spec = { const isDev = params.devMode || false; const pbcode = bidRequest.adUnitCode || false; // div id - let endpoint = isDev ? ENDPOINT_URL_DEV : ENDPOINT_URL; + const endpoint = isDev ? ENDPOINT_URL_DEV : ENDPOINT_URL; - let mediaTypesInfo = getMediaTypesInfo(bidRequest); - let type = isBannerRequest(bidRequest) ? BANNER : VIDEO; - let sizes = mediaTypesInfo[type]; + const mediaTypesInfo = getMediaTypesInfo(bidRequest); + const type = isBannerRequest(bidRequest) ? BANNER : VIDEO; + const sizes = mediaTypesInfo[type]; - let payload = { + const payload = { _f: 'vast2', alternative: 'prebid_js', _ps: placementId, @@ -88,7 +88,7 @@ export const spec = { if (params.devMode !== undefined) { delete payload.pfilter.devMode; } if (payload.pfilter === undefined || !payload.pfilter.floorprice) { - let bidFloor = getBidFloor(bidRequest); + const bidFloor = getBidFloor(bidRequest); if (bidFloor > 0) { if (payload.pfilter !== undefined) { payload.pfilter.floorprice = bidFloor; @@ -100,7 +100,7 @@ export const spec = { } if (mediaTypesInfo[VIDEO] !== undefined) { - let videoParams = deepAccess(bidRequest, 'mediaTypes.video'); + const videoParams = deepAccess(bidRequest, 'mediaTypes.video'); Object.keys(videoParams) .filter(key => Object.keys(VIDEO_ORTB_PARAMS).includes(key) && params[VIDEO_ORTB_PARAMS[key]] === undefined) .forEach(key => payload.pfilter[VIDEO_ORTB_PARAMS[key]] = videoParams[key]); @@ -146,12 +146,12 @@ export const spec = { } function stvObjectToQueryString(obj, prefix) { - let str = []; + const str = []; let p; for (p in obj) { if (obj.hasOwnProperty(p)) { - let k = prefix ? prefix + '[' + p + ']' : p; - let v = obj[p]; + const k = prefix ? prefix + '[' + p + ']' : p; + const v = obj[p]; str.push((v !== null && typeof v === 'object') ? stvObjectToQueryString(v, k) : (k == 'schain' || k == 'uids' ? k + '=' + v : encodeURIComponent(k) + '=' + encodeURIComponent(v))); @@ -167,7 +167,7 @@ function serializeSChain(schain) { ret += ','; ret += encodeURIComponent(schain.complete); - for (let node of schain.nodes) { + for (const node of schain.nodes) { ret += '!'; ret += encodeURIComponent(node.asi); ret += ','; @@ -190,48 +190,48 @@ function serializeSChain(schain) { } function serializeUids(bidRequest) { - let uids = []; + const uids = []; if (bidRequest.userIdAsEids === undefined || !Array.isArray(bidRequest.userIdAsEids)) { return ''; } - let buids = {}; + const buids = {}; bidRequest.userIdAsEids.forEach((src) => (buids[deepAccess(src, 'source')] = deepAccess(src, 'uids.0'))); - let id5 = deepAccess(buids['id5-sync.com'], 'id'); + const id5 = deepAccess(buids['id5-sync.com'], 'id'); if (id5) { uids.push(encodeURIComponent('id5:' + id5)); - let id5Linktype = deepAccess(buids['id5-sync.com'], 'ext.linkType'); + const id5Linktype = deepAccess(buids['id5-sync.com'], 'ext.linkType'); if (id5Linktype) { uids.push(encodeURIComponent('id5_linktype:' + id5Linktype)); } } - let netId = deepAccess(buids['netid.de'], 'id'); + const netId = deepAccess(buids['netid.de'], 'id'); if (netId) { uids.push(encodeURIComponent('netid:' + netId)); } - let uId2 = deepAccess(buids['uidapi.com'], 'id'); + const uId2 = deepAccess(buids['uidapi.com'], 'id'); if (uId2) { uids.push(encodeURIComponent('uid2:' + uId2)); } - let sharedId = deepAccess(buids['pubcid.org'], 'id'); + const sharedId = deepAccess(buids['pubcid.org'], 'id'); if (sharedId) { uids.push(encodeURIComponent('sharedid:' + sharedId)); } - let liverampId = deepAccess(buids['liveramp.com'], 'id'); + const liverampId = deepAccess(buids['liveramp.com'], 'id'); if (liverampId) { uids.push(encodeURIComponent('liverampid:' + liverampId)); } - let criteoId = deepAccess(buids['criteo.com'], 'id'); + const criteoId = deepAccess(buids['criteo.com'], 'id'); if (criteoId) { uids.push(encodeURIComponent('criteoid:' + criteoId)); } - let utiqId = deepAccess(buids['utiq.com'], 'id'); + const utiqId = deepAccess(buids['utiq.com'], 'id'); if (utiqId) { uids.push(encodeURIComponent('utiq:' + utiqId)); } - let euidId = deepAccess(buids['euid.eu'], 'id'); + const euidId = deepAccess(buids['euid.eu'], 'id'); if (euidId) { uids.push(encodeURIComponent('euid:' + euidId)); } diff --git a/modules/symitriAnalyticsAdapter.js b/modules/symitriAnalyticsAdapter.js index 89dc27886e3..4e2d1e070e6 100644 --- a/modules/symitriAnalyticsAdapter.js +++ b/modules/symitriAnalyticsAdapter.js @@ -11,7 +11,7 @@ const { BID_WON } = EVENTS; let initOptions; -let symitriAnalytics = Object.assign(adapter({url, analyticsType}), { +const symitriAnalytics = Object.assign(adapter({url, analyticsType}), { track({ eventType, args }) { switch (eventType) { case BID_WON: @@ -30,7 +30,7 @@ function sendEvent(payload) { if (initOptions.apiAuthToken) { const body = JSON.stringify(payload); logMessage('##### symitriAnalytics :: sendEvent ', payload); - let cb = { + const cb = { success: () => { logMessage('##### symitriAnalytics :: Bid Reported Successfully'); }, diff --git a/modules/symitriDapRtdProvider.js b/modules/symitriDapRtdProvider.js index 51303f772ff..4b6b0c065a3 100644 --- a/modules/symitriDapRtdProvider.js +++ b/modules/symitriDapRtdProvider.js @@ -69,12 +69,12 @@ export function createRtdProvider(moduleName, moduleCode, headerPrefix) { * @param {Object} userConsent */ function getRealTimeData(bidConfig, onDone, rtdConfig, userConsent) { - let entropyDict = JSON.parse(storage.getDataFromLocalStorage(DAP_CLIENT_ENTROPY)); + const entropyDict = JSON.parse(storage.getDataFromLocalStorage(DAP_CLIENT_ENTROPY)); // Attempt to load entroy script if no entropy object exist and entropy config settings are present. // Else if (!entropyDict && rtdConfig && rtdConfig.params && dapUtils.isValidHttpsUrl(rtdConfig.params.dapEntropyUrl)) { - let loadScriptPromise = new Promise((resolve, reject) => { + const loadScriptPromise = new Promise((resolve, reject) => { if (rtdConfig && rtdConfig.params && rtdConfig.params.dapEntropyTimeout && Number.isInteger(rtdConfig.params.dapEntropyTimeout)) { setTimeout(reject, rtdConfig.params.dapEntropyTimeout, Error('DapEntropy script could not be loaded')); } @@ -117,12 +117,12 @@ export function createRtdProvider(moduleName, moduleCode, headerPrefix) { var jsonData = null; if (rtdConfig && isPlainObject(rtdConfig.params)) { if (rtdConfig.params.segtax == 710) { - let encMembership = dapUtils.dapGetEncryptedMembershipFromLocalStorage(); + const encMembership = dapUtils.dapGetEncryptedMembershipFromLocalStorage(); if (encMembership) { jsonData = dapUtils.dapGetEncryptedRtdObj(encMembership, rtdConfig.params.segtax) } } else { - let membership = dapUtils.dapGetMembershipFromLocalStorage(); + const membership = dapUtils.dapGetMembershipFromLocalStorage(); if (membership) { jsonData = dapUtils.dapGetRtdObj(membership, rtdConfig.params.segtax) } @@ -155,13 +155,13 @@ export function createRtdProvider(moduleName, moduleCode, headerPrefix) { function onBidResponse(bidResponse, config, userConsent) { if (bidResponse.dealId && typeof (bidResponse.dealId) != typeof (undefined)) { - let membership = dapUtils.dapGetMembershipFromLocalStorage(); // Get Membership details from Local Storage - let deals = membership.deals; // Get list of Deals the user is mapped to + const membership = dapUtils.dapGetMembershipFromLocalStorage(); // Get Membership details from Local Storage + const deals = membership.deals; // Get list of Deals the user is mapped to deals.forEach((deal) => { deal = JSON.parse(deal); if (bidResponse.dealId == deal.id) { // Check if the bid response deal Id matches to the deals mapped to the user - let token = dapUtils.dapGetTokenFromLocalStorage(); - let url = config.params.pixelUrl + '?token=' + token + '&ad_id=' + bidResponse.adId + '&bidder=' + bidResponse.bidder + '&bidder_code=' + bidResponse.bidderCode + '&cpm=' + bidResponse.cpm + '&creative_id=' + bidResponse.creativeId + '&deal_id=' + bidResponse.dealId + '&media_type=' + bidResponse.mediaType + '&response_timestamp=' + bidResponse.responseTimestamp; + const token = dapUtils.dapGetTokenFromLocalStorage(); + const url = config.params.pixelUrl + '?token=' + token + '&ad_id=' + bidResponse.adId + '&bidder=' + bidResponse.bidder + '&bidder_code=' + bidResponse.bidderCode + '&cpm=' + bidResponse.cpm + '&creative_id=' + bidResponse.creativeId + '&deal_id=' + bidResponse.dealId + '&media_type=' + bidResponse.mediaType + '&response_timestamp=' + bidResponse.responseTimestamp; bidResponse.ad = `${bidResponse.ad} ', cpm: 1.00, @@ -107,7 +107,7 @@ describe('ablidaBidAdapter', function () { }] }; it('should get the correct bid response', function () { - let expectedResponse = [{ + const expectedResponse = [{ ad: '', cpm: 1.00, creativeId: '2b8c4de0116e54', @@ -123,7 +123,7 @@ describe('ablidaBidAdapter', function () { ttl: 3000, width: 300 }]; - let result = spec.interpretResponse(serverResponse, bidRequest[0]); + const result = spec.interpretResponse(serverResponse, bidRequest[0]); expect(Object.keys(result)).to.deep.equal(Object.keys(expectedResponse)); }); }); diff --git a/test/spec/modules/acuityadsBidAdapter_spec.js b/test/spec/modules/acuityadsBidAdapter_spec.js index 587bf01dd38..235bb429251 100644 --- a/test/spec/modules/acuityadsBidAdapter_spec.js +++ b/test/spec/modules/acuityadsBidAdapter_spec.js @@ -132,7 +132,7 @@ describe('AcuityAdsBidAdapter', function () { }); it('Returns general data valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys('deviceWidth', 'deviceHeight', @@ -262,7 +262,7 @@ describe('AcuityAdsBidAdapter', function () { } ]; - let serverRequest = spec.buildRequests(bids, bidderRequest); + const serverRequest = spec.buildRequests(bids, bidderRequest); const { placements } = serverRequest.data; for (let i = 0, len = placements.length; i < len; i++) { @@ -297,7 +297,7 @@ describe('AcuityAdsBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { delete bidderRequest.uspConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('object'); expect(data.gdpr).to.have.property('consentString'); @@ -311,7 +311,7 @@ describe('AcuityAdsBidAdapter', function () { bidderRequest.uspConsent = '1---'; delete bidderRequest.gdprConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -326,8 +326,8 @@ describe('AcuityAdsBidAdapter', function () { applicableSections: [8] }; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -341,8 +341,8 @@ describe('AcuityAdsBidAdapter', function () { bidderRequest.ortb2.regs.gpp = 'abc123'; bidderRequest.ortb2.regs.gpp_sid = [8]; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -372,9 +372,9 @@ describe('AcuityAdsBidAdapter', function () { } }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(banner.body[0].requestId); @@ -406,10 +406,10 @@ describe('AcuityAdsBidAdapter', function () { } }] }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -443,10 +443,10 @@ describe('AcuityAdsBidAdapter', function () { } }] }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys('requestId', 'cpm', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'native', 'meta'); expect(dataItem.native).to.have.keys('clickUrl', 'impressionTrackers', 'title', 'image') expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -477,7 +477,7 @@ describe('AcuityAdsBidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -493,7 +493,7 @@ describe('AcuityAdsBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -510,7 +510,7 @@ describe('AcuityAdsBidAdapter', function () { currency: 'USD', }] }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -523,7 +523,7 @@ describe('AcuityAdsBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/adWMGAnalyticsAdapter_spec.js b/test/spec/modules/adWMGAnalyticsAdapter_spec.js index 92e1fcbe4db..d766a0f8ba3 100644 --- a/test/spec/modules/adWMGAnalyticsAdapter_spec.js +++ b/test/spec/modules/adWMGAnalyticsAdapter_spec.js @@ -3,15 +3,15 @@ import { expect } from 'chai'; import { server } from 'test/mocks/xhr.js'; import {expectEvents} from '../../helpers/analytics.js'; import {EVENTS} from 'src/constants.js'; -let adapterManager = require('src/adapterManager').default; -let events = require('src/events'); +const adapterManager = require('src/adapterManager').default; +const events = require('src/events'); describe('adWMG Analytics', function () { - let timestamp = new Date() - 256; - let auctionId = '5018eb39-f900-4370-b71e-3bb5b48d324f'; - let timeout = 1500; + const timestamp = new Date() - 256; + const auctionId = '5018eb39-f900-4370-b71e-3bb5b48d324f'; + const timeout = 1500; - let bidTimeoutArgs = [ + const bidTimeoutArgs = [ { bidId: '2baa51527bd015', bidder: 'bidderA', @@ -41,7 +41,7 @@ describe('adWMG Analytics', function () { height: 250, }; - let wonRequest = { + const wonRequest = { 'adId': '4587fec4900b81', 'mediaType': 'banner', 'requestId': '4587fec4900b81', @@ -60,7 +60,7 @@ describe('adWMG Analytics', function () { 'size': [300, 250], }; - let expectedBidWonData = { + const expectedBidWonData = { publisher_id: '5abd0543ba45723db49d97ea', site: 'test.com', ad_unit_size: ['300,250'], @@ -88,7 +88,7 @@ describe('adWMG Analytics', function () { ] } - let adUnits = [{ + const adUnits = [{ code: 'ad-slot-1', sizes: [[300, 250]], mediaTypes: { @@ -167,7 +167,7 @@ describe('adWMG Analytics', function () { it('check bidWon data', function () { events.emit(EVENTS.AUCTION_END, {}); events.emit(EVENTS.BID_WON, wonRequest); - let realBidWonData = JSON.parse(server.requests[1].requestBody); + const realBidWonData = JSON.parse(server.requests[1].requestBody); expect(realBidWonData.publisher_id).to.equal(expectedBidWonData.publisher_id); expect(realBidWonData.site).to.equal(expectedBidWonData.site); expect(realBidWonData.ad_unit_type[0]).to.equal(expectedBidWonData.ad_unit_type[0]); diff --git a/test/spec/modules/adWMGBidAdapter_spec.js b/test/spec/modules/adWMGBidAdapter_spec.js index 9e0e3be4f7a..6b0c444fcb3 100644 --- a/test/spec/modules/adWMGBidAdapter_spec.js +++ b/test/spec/modules/adWMGBidAdapter_spec.js @@ -39,32 +39,32 @@ describe('adWMGBidAdapter', function () { }); it('should return correct device type: desktop', function() { - let userDeviceInfo = spec.parseUserAgent(ua_desktop); + const userDeviceInfo = spec.parseUserAgent(ua_desktop); expect(userDeviceInfo.devicetype).to.equal(2); }); it('should return correct device type: TV', function() { - let userDeviceInfo = spec.parseUserAgent(ua_tv); + const userDeviceInfo = spec.parseUserAgent(ua_tv); expect(userDeviceInfo.devicetype).to.equal(3); }); it('should return correct device type: mobile', function() { - let userDeviceInfo = spec.parseUserAgent(ua_mobile); + const userDeviceInfo = spec.parseUserAgent(ua_mobile); expect(userDeviceInfo.devicetype).to.equal(4); }); it('should return correct device type: tablet', function() { - let userDeviceInfo = spec.parseUserAgent(ua_tablet); + const userDeviceInfo = spec.parseUserAgent(ua_tablet); expect(userDeviceInfo.devicetype).to.equal(5); }); it('should return correct OS name', function() { - let userDeviceInfo = spec.parseUserAgent(ua_desktop); + const userDeviceInfo = spec.parseUserAgent(ua_desktop); expect(userDeviceInfo.os).to.equal('Windows'); }); it('should return correct OS version', function() { - let userDeviceInfo = spec.parseUserAgent(ua_desktop); + const userDeviceInfo = spec.parseUserAgent(ua_desktop); expect(userDeviceInfo.osv).to.equal('10.0'); }); }); @@ -121,7 +121,7 @@ describe('adWMGBidAdapter', function () { ]; }); - let bidderRequest = { + const bidderRequest = { refererInfo: { referer: 'https://test.com' }, @@ -136,7 +136,7 @@ describe('adWMGBidAdapter', function () { it('should not contain a sizes when sizes is not set', function() { delete bidRequests[0].sizes; delete bidRequests[1].sizes; - let requests = spec.buildRequests(bidRequests, bidderRequest); + const requests = spec.buildRequests(bidRequests, bidderRequest); expect(JSON.parse(requests[0].data).sizes).to.be.an('undefined'); expect(JSON.parse(requests[1].data).sizes).to.be.an('undefined'); }); @@ -144,31 +144,31 @@ describe('adWMGBidAdapter', function () { it('should not contain a userId when userId is not set', function() { delete bidRequests[0].userId; delete bidRequests[1].userId; - let requests = spec.buildRequests(bidRequests, bidderRequest); + const requests = spec.buildRequests(bidRequests, bidderRequest); expect(JSON.parse(requests[0].data).userId).to.be.an('undefined'); expect(JSON.parse(requests[1].data).userId).to.be.an('undefined'); }); it('should have a post method', function() { - let requests = spec.buildRequests(bidRequests, bidderRequest); + const requests = spec.buildRequests(bidRequests, bidderRequest); expect(requests[0].method).to.equal('POST'); expect(requests[1].method).to.equal('POST'); }); it('should contain a request id equals to the bid id', function() { - let requests = spec.buildRequests(bidRequests, bidderRequest); + const requests = spec.buildRequests(bidRequests, bidderRequest); expect(JSON.parse(requests[0].data).requestId).to.equal(bidRequests[0].bidId); expect(JSON.parse(requests[1].data).requestId).to.equal(bidRequests[1].bidId); }); it('should have an url that match the default endpoint', function() { - let requests = spec.buildRequests(bidRequests, bidderRequest); + const requests = spec.buildRequests(bidRequests, bidderRequest); expect(requests[0].url).to.equal('https://hb.adwmg.com/hb'); expect(requests[1].url).to.equal('https://hb.adwmg.com/hb'); }); it('should contain GDPR consent data if GDPR set', function() { - let requests = spec.buildRequests(bidRequests, bidderRequest); + const requests = spec.buildRequests(bidRequests, bidderRequest); expect(JSON.parse(requests[0].data).gdpr.applies).to.be.true; expect(JSON.parse(requests[0].data).gdpr.consentString).to.equal(bidderRequest.gdprConsent.consentString); expect(JSON.parse(requests[1].data).gdpr.applies).to.be.true; @@ -177,14 +177,14 @@ describe('adWMGBidAdapter', function () { it('should not contain GDPR consent data if GDPR not set', function() { delete bidderRequest.gdprConsent; - let requests = spec.buildRequests(bidRequests, bidderRequest); + const requests = spec.buildRequests(bidRequests, bidderRequest); expect(JSON.parse(requests[0].data).gdpr).to.be.an('undefined'); expect(JSON.parse(requests[1].data).gdpr).to.be.an('undefined'); }) it('should set debug mode in requests if enabled', function() { sinon.stub(config, 'getConfig').withArgs('debug').returns(true); - let requests = spec.buildRequests(bidRequests, bidderRequest); + const requests = spec.buildRequests(bidRequests, bidderRequest); expect(JSON.parse(requests[0].data).debug).to.be.true; expect(JSON.parse(requests[1].data).debug).to.be.true; config.getConfig.restore(); @@ -214,7 +214,7 @@ describe('adWMGBidAdapter', function () { var responses = spec.interpretResponse(serverResponse); expect(responses).to.be.an('array').that.is.not.empty; - let response = responses[0]; + const response = responses[0]; expect(response).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'meta', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency'); expect(response.requestId).to.equal('request-id'); @@ -244,7 +244,7 @@ describe('adWMGBidAdapter', function () { 'pixelEnabled': false }; - let syncs = spec.getUserSyncs(syncOptions); + const syncs = spec.getUserSyncs(syncOptions); expect(syncs).to.deep.equal([]); }); @@ -254,7 +254,7 @@ describe('adWMGBidAdapter', function () { 'pixelEnabled': false }; - let syncs = spec.getUserSyncs(syncOptions); + const syncs = spec.getUserSyncs(syncOptions); expect(syncs[0].type).to.equal('iframe'); expect(syncs[0].url).includes('https://hb.adwmg.com/cphb.html?'); }); @@ -265,7 +265,7 @@ describe('adWMGBidAdapter', function () { 'pixelEnabled': true }; - let syncs = spec.getUserSyncs(syncOptions); + const syncs = spec.getUserSyncs(syncOptions); expect(syncs[0].type).to.equal('iframe'); expect(syncs[0].url).includes('https://hb.adwmg.com/cphb.html?'); }); @@ -282,7 +282,7 @@ describe('adWMGBidAdapter', function () { apiVersion: 2 }; const serverResponse = {}; - let syncs = spec.getUserSyncs(syncOptions, serverResponse, gdprConsent); + const syncs = spec.getUserSyncs(syncOptions, serverResponse, gdprConsent); expect(syncs[0].url).includes('gdpr=1'); expect(syncs[0].url).includes(`gdpr_consent=${gdprConsent.consentString}`); }); @@ -323,7 +323,7 @@ describe('adWMGBidAdapter', function () { apiVersion: 2 }; const serverResponse = {}; - let syncs = spec.getUserSyncs(syncOptions, serverResponse, gdprConsent); + const syncs = spec.getUserSyncs(syncOptions, serverResponse, gdprConsent); expect(syncs[0].url.slice(-1)).to.not.equal('&'); }); }); diff --git a/test/spec/modules/adagioAnalyticsAdapter_spec.js b/test/spec/modules/adagioAnalyticsAdapter_spec.js index d1058170f44..9178d7b532d 100644 --- a/test/spec/modules/adagioAnalyticsAdapter_spec.js +++ b/test/spec/modules/adagioAnalyticsAdapter_spec.js @@ -5,8 +5,8 @@ import { EVENTS } from 'src/constants.js'; import { expect } from 'chai'; import { server } from 'test/mocks/xhr.js'; -let adapterManager = require('src/adapterManager').default; -let events = require('src/events'); +const adapterManager = require('src/adapterManager').default; +const events = require('src/events'); describe('adagio analytics adapter - adagio.js', () => { let sandbox; @@ -53,7 +53,7 @@ describe('adagio analytics adapter - adagio.js', () => { it('builds and sends auction data', () => { const w = utils.getWindowTop(); - let bidRequest = { + const bidRequest = { bids: [{ adUnitCode: 'div-1', params: { @@ -78,7 +78,7 @@ describe('adagio analytics adapter - adagio.js', () => { }, }], }; - let bidResponse = { + const bidResponse = { bidderCode: 'adagio', width: 300, height: 250, diff --git a/test/spec/modules/adagioBidAdapter_spec.js b/test/spec/modules/adagioBidAdapter_spec.js index ba47463bbff..fd7663c1862 100644 --- a/test/spec/modules/adagioBidAdapter_spec.js +++ b/test/spec/modules/adagioBidAdapter_spec.js @@ -294,7 +294,7 @@ describe('Adagio bid adapter', () => { const expectedAuctionId = '373bcda7-9794-4f1c-be2c-0d223d11d579' const bid01 = new BidRequestBuilder().withParams().build(); - let ortb = { + const ortb = { ortb2: { site: { ext: { @@ -1139,7 +1139,7 @@ describe('Adagio bid adapter', () => { }); describe('interpretResponse()', function() { - let serverResponse = { + const serverResponse = { body: { data: { pred: 1 @@ -1165,7 +1165,7 @@ describe('Adagio bid adapter', () => { } }; - let bidRequest = { + const bidRequest = { data: { adUnits: [{ bidder: 'adagio', @@ -1209,7 +1209,7 @@ describe('Adagio bid adapter', () => { }); it('should handle properly a correct bid response', function() { - let expectedResponse = [{ + const expectedResponse = [{ ad: '
', cpm: 1, creativeId: 'creativeId', @@ -1242,7 +1242,7 @@ describe('Adagio bid adapter', () => { const altServerResponse = utils.deepClone(serverResponse); delete altServerResponse.body.bids[0].meta; - let expectedResponse = [{ + const expectedResponse = [{ ad: '
', cpm: 1, creativeId: 'creativeId', @@ -1572,7 +1572,7 @@ describe('Adagio bid adapter', () => { } }]; - let result = spec.getUserSyncs(syncOptions, serverResponses); + const result = spec.getUserSyncs(syncOptions, serverResponses); expect(result[0].type).to.equal('iframe'); expect(result[0].url).contain('setuid'); diff --git a/test/spec/modules/adbutlerBidAdapter_spec.js b/test/spec/modules/adbutlerBidAdapter_spec.js index 6c38de717a3..be96413abd1 100644 --- a/test/spec/modules/adbutlerBidAdapter_spec.js +++ b/test/spec/modules/adbutlerBidAdapter_spec.js @@ -87,7 +87,7 @@ describe('AdButler adapter', function () { const requests = spec.buildRequests(validBidRequests); const request = requests[0]; - let [domain] = request.url.split('/adserve/'); + const [domain] = request.url.split('/adserve/'); expect(domain).to.equal('https://servedbyadbutler.com'); }); diff --git a/test/spec/modules/adfBidAdapter_spec.js b/test/spec/modules/adfBidAdapter_spec.js index 2c789767c14..cd563dbb0ff 100644 --- a/test/spec/modules/adfBidAdapter_spec.js +++ b/test/spec/modules/adfBidAdapter_spec.js @@ -22,7 +22,7 @@ describe('Adf adapter', function () { }); describe('isBidRequestValid', function () { - let bid = { + const bid = { 'bidder': 'adformOpenRTB', 'params': { 'mid': '19910113' @@ -67,13 +67,13 @@ describe('Adf adapter', function () { config.resetConfig(); }); it('should send request with correct structure', function () { - let validBidRequests = [{ + const validBidRequests = [{ bidId: 'bidId', params: { adxDomain: '10.8.57.207' } }]; - let request = spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }); + const request = spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }); assert.equal(request.method, 'POST'); assert.equal(request.url, 'https://10.8.57.207/adx/openrtb'); @@ -83,8 +83,8 @@ describe('Adf adapter', function () { describe('user privacy', function () { it('should send GDPR Consent data to adform', function () { - let validBidRequests = [{ bidId: 'bidId', params: { test: 1 } }]; - let ortb2 = { + const validBidRequests = [{ bidId: 'bidId', params: { test: 1 } }]; + const ortb2 = { regs: { ext: { gdpr: 1 @@ -96,16 +96,16 @@ describe('Adf adapter', function () { } } }; - let bidderRequest = { ortb2, refererInfo: { page: 'page' } }; - let request = JSON.parse(spec.buildRequests(validBidRequests, bidderRequest).data); + const bidderRequest = { ortb2, refererInfo: { page: 'page' } }; + const request = JSON.parse(spec.buildRequests(validBidRequests, bidderRequest).data); assert.equal(request.user.ext.consent, 'consentDataString'); assert.equal(request.regs.ext.gdpr, 1); }); it('should send CCPA Consent data to adform', function () { - let validBidRequests = [{ bidId: 'bidId', params: { test: 1 } }]; - let ortb2 = { + const validBidRequests = [{ bidId: 'bidId', params: { test: 1 } }]; + const ortb2 = { regs: { ext: { us_privacy: '1YA-' @@ -129,9 +129,9 @@ describe('Adf adapter', function () { }); it('should transfer DSA info', function () { - let validBidRequests = [ { bidId: 'bidId', params: { siteId: 'siteId' } } ]; + const validBidRequests = [ { bidId: 'bidId', params: { siteId: 'siteId' } } ]; - let request = JSON.parse( + const request = JSON.parse( spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' }, ortb2: { @@ -173,34 +173,34 @@ describe('Adf adapter', function () { }); it('should add test and is_debug to request, if test is set in parameters', function () { - let validBidRequests = [{ + const validBidRequests = [{ bidId: 'bidId', params: { test: 1 } }]; - let request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data); + const request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data); assert.ok(request.is_debug); assert.equal(request.test, 1); }); it('should have default request structure', function () { - let keys = 'site,user,device,source,ext,imp,regs'.split(','); - let validBidRequests = [{ + const keys = 'site,user,device,source,ext,imp,regs'.split(','); + const validBidRequests = [{ bidId: 'bidId', params: { siteId: 'siteId' } }]; - let request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data); - let data = Object.keys(request); + const request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data); + const data = Object.keys(request); assert.deepEqual(keys, data); }); it('should set request keys correct values', function () { - let validBidRequests = [{ + const validBidRequests = [{ bidId: 'bidId', params: { siteId: 'siteId' }, }]; - let request = JSON.parse(spec.buildRequests(validBidRequests, { + const request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: {page: 'page'}, ortb2: {source: {tid: 'tid'}} }).data); @@ -210,9 +210,9 @@ describe('Adf adapter', function () { }); it('should send coppa flag', function () { - let ortb2 = { regs: { coppa: 1 } }; - let validBidRequests = [{ bidId: 'bidId', params: { test: 1 } }]; - let request = JSON.parse(spec.buildRequests(validBidRequests, { ortb2, refererInfo: { page: 'page' } }).data); + const ortb2 = { regs: { coppa: 1 } }; + const validBidRequests = [{ bidId: 'bidId', params: { test: 1 } }]; + const request = JSON.parse(spec.buildRequests(validBidRequests, { ortb2, refererInfo: { page: 'page' } }).data); assert.equal(request.regs.coppa, 1); }); @@ -221,11 +221,11 @@ describe('Adf adapter', function () { config.setConfig({ device: { w: 100, h: 100 } }); - let validBidRequests = [{ + const validBidRequests = [{ bidId: 'bidId', params: { mid: '1000' } }]; - let request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data); + const request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data); assert.equal(request.device.ua, navigator.userAgent); assert.equal(request.device.w, 100); @@ -236,12 +236,12 @@ describe('Adf adapter', function () { config.setConfig({ device: { w: 100, h: 100 } }); - let validBidRequests = [{ + const validBidRequests = [{ bidId: 'bidId', params: { mid: '1000' } }]; - let ortb2 = { device: { ua: 'customUA', w: 200, geo: { lat: 1, lon: 1 } } }; - let request = JSON.parse(spec.buildRequests(validBidRequests, { ortb2, refererInfo: { page: 'page' } }).data); + const ortb2 = { device: { ua: 'customUA', w: 200, geo: { lat: 1, lon: 1 } } }; + const request = JSON.parse(spec.buildRequests(validBidRequests, { ortb2, refererInfo: { page: 'page' } }).data); assert.equal(request.device.ua, 'customUA'); assert.equal(request.device.w, 200); @@ -254,12 +254,12 @@ describe('Adf adapter', function () { app: { id: 'appid' }, }); const ortb2 = { app: { name: 'appname' } }; - let validBidRequests = [{ + const validBidRequests = [{ bidId: 'bidId', params: { mid: '1000' }, ortb2 }]; - let request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' }, ortb2 }).data); + const request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' }, ortb2 }).data); assert.equal(request.app.id, 'appid'); assert.equal(request.app.name, 'appname'); @@ -282,13 +282,13 @@ describe('Adf adapter', function () { } } }; - let validBidRequests = [{ + const validBidRequests = [{ bidId: 'bidId', params: { mid: '1000' }, ortb2 }]; - let refererInfo = { page: 'page' }; - let request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo, ortb2 }).data); + const refererInfo = { page: 'page' }; + const request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo, ortb2 }).data); assert.deepEqual(request.site, { page: refererInfo.page, @@ -301,7 +301,7 @@ describe('Adf adapter', function () { }); it('should pass extended ids', function () { - let validBidRequests = [{ + const validBidRequests = [{ bidId: 'bidId', params: {}, userIdAsEids: [ @@ -310,24 +310,24 @@ describe('Adf adapter', function () { ] }]; - let request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data); + const request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data); assert.deepEqual(request.user.ext.eids, validBidRequests[0].userIdAsEids); }); it('should send currency if defined', function () { - let validBidRequests = [{ params: {} }]; - let refererInfo = { page: 'page' }; + const validBidRequests = [{ params: {} }]; + const refererInfo = { page: 'page' }; const bidderRequest = { refererInfo }; setCurrencyConfig({ adServerCurrency: 'EUR' }) return addFPDToBidderRequest(bidderRequest).then(res => { - let request = JSON.parse(spec.buildRequests(validBidRequests, res).data); + const request = JSON.parse(spec.buildRequests(validBidRequests, res).data); assert.deepEqual(request.cur, [ 'EUR' ]); setCurrencyConfig({}); }); }); it('should pass supply chain object', function () { - let validBidRequests = [{ + const validBidRequests = [{ bidId: 'bidId', params: {}, ortb2: { @@ -344,7 +344,7 @@ describe('Adf adapter', function () { } }]; - let request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data); + const request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data); assert.deepEqual(request.source.ext.schain, { validation: 'strict', config: { @@ -355,20 +355,20 @@ describe('Adf adapter', function () { describe('priceType', function () { it('should send default priceType', function () { - let validBidRequests = [{ + const validBidRequests = [{ bidId: 'bidId', params: { siteId: 'siteId' } }]; - let request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data); + const request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data); assert.equal(request.ext.pt, 'net'); }); it('should send correct priceType value', function () { - let validBidRequests = [{ + const validBidRequests = [{ bidId: 'bidId', params: { priceType: 'net' } }]; - let request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data); + const request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data); assert.equal(request.ext.pt, 'net'); }); @@ -376,19 +376,19 @@ describe('Adf adapter', function () { describe('bids', function () { it('should add more than one bid to the request', function () { - let validBidRequests = [{ + const validBidRequests = [{ bidId: 'bidId', params: { siteId: 'siteId' } }, { bidId: 'bidId2', params: { siteId: 'siteId' } }]; - let request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data); + const request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data); assert.equal(request.imp.length, 2); }); it('should add incrementing values of id', function () { - let validBidRequests = [{ + const validBidRequests = [{ bidId: 'bidId', params: { mid: '1000' }, mediaTypes: {video: {}} @@ -401,7 +401,7 @@ describe('Adf adapter', function () { params: { mid: '1000' }, mediaTypes: {video: {}} }]; - let imps = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data).imp; + const imps = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data).imp; for (let i = 0; i < 3; i++) { assert.equal(imps[i].id, i + 1); @@ -409,22 +409,22 @@ describe('Adf adapter', function () { }); it('should add mid', function () { - let validBidRequests = [{ bidId: 'bidId', params: {mid: 1000}, mediaTypes: {video: {}} }, + const validBidRequests = [{ bidId: 'bidId', params: {mid: 1000}, mediaTypes: {video: {}} }, { bidId: 'bidId2', params: {mid: 1001}, mediaTypes: {video: {}} }, { bidId: 'bidId3', params: {mid: 1002}, mediaTypes: {video: {}} }]; - let imps = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data).imp; + const imps = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data).imp; for (let i = 0; i < 3; i++) { assert.equal(imps[i].tagid, validBidRequests[i].params.mid); } }); it('should add first party data', function () { - let validBidRequests = [ + const validBidRequests = [ { bidId: 'bidId', params: { mid: 1000 }, mediaTypes: { video: {} }, ortb2Imp: { ext: { data: { some: 'value' } } } }, { bidId: 'bidId2', params: { mid: 1001 }, mediaTypes: { video: {} }, ortb2Imp: { ext: { data: { some: 'value', another: 1 } } } }, { bidId: 'bidId3', params: { mid: 1002 }, mediaTypes: { video: {} }, ortb2Imp: { ext: {} } } ]; - let imps = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data).imp; + const imps = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data).imp; for (let i = 0; i < 3; i++) { assert.deepEqual(imps[i].ext.data, validBidRequests[i].ortb2Imp.ext.data); } @@ -457,7 +457,7 @@ describe('Adf adapter', function () { describe('price floors', function () { it('should not add if floors module not configured', function () { const validBidRequests = [{ bidId: 'bidId', params: {mid: 1000}, mediaTypes: {video: {}} }]; - let imp = getRequestImps(validBidRequests)[0]; + const imp = getRequestImps(validBidRequests)[0]; assert.equal(imp.bidfloor, undefined); assert.equal(imp.bidfloorcur, undefined); @@ -465,7 +465,7 @@ describe('Adf adapter', function () { it('should not add if floor price not defined', function () { const validBidRequests = [ getBidWithFloor() ]; - let imp = getRequestImps(validBidRequests)[0]; + const imp = getRequestImps(validBidRequests)[0]; assert.equal(imp.bidfloor, undefined); assert.equal(imp.bidfloorcur, 'USD'); @@ -485,7 +485,7 @@ describe('Adf adapter', function () { it('should add correct floor values', function () { const expectedFloors = [ 1, 1.3, 0.5 ]; const validBidRequests = expectedFloors.map(getBidWithFloor); - let imps = getRequestImps(validBidRequests); + const imps = getRequestImps(validBidRequests); expectedFloors.forEach((floor, index) => { assert.equal(imps[index].bidfloor, floor); @@ -500,7 +500,7 @@ describe('Adf adapter', function () { } }; const expectedFloors = [ 1, 1.3, 0.5 ]; setCurrencyConfig({ adServerCurrency: 'DKK' }); - let validBidRequests = expectedFloors.map(getBidWithFloorTest); + const validBidRequests = expectedFloors.map(getBidWithFloorTest); return addFPDToBidderRequest(validBidRequests[0]).then(res => { getRequestImps(validBidRequests, res); assert.deepEqual(result, { currency: 'DKK', size: '*', mediaType: '*' }) @@ -554,7 +554,7 @@ describe('Adf adapter', function () { describe('multiple media types', function () { it('should use all configured media types for bidding', function () { - let validBidRequests = [{ + const validBidRequests = [{ bidId: 'bidId', params: { mid: 1000 }, mediaTypes: { @@ -595,7 +595,7 @@ describe('Adf adapter', function () { video: {} } }]; - let [ first, second, third ] = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data).imp; + const [ first, second, third ] = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data).imp; assert.ok(first.banner); assert.ok(first.video); @@ -613,7 +613,7 @@ describe('Adf adapter', function () { describe('banner', function () { it('should convert sizes to openrtb format', function () { - let validBidRequests = [{ + const validBidRequests = [{ bidId: 'bidId', params: { mid: 1000 }, mediaTypes: { @@ -622,7 +622,7 @@ describe('Adf adapter', function () { } } }]; - let { banner } = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data).imp[0]; + const { banner } = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data).imp[0]; assert.deepEqual(banner, { format: [ { w: 100, h: 100 }, { w: 200, h: 300 } ] }); @@ -631,7 +631,7 @@ describe('Adf adapter', function () { describe('video', function () { it('should pass video mediatype config', function () { - let validBidRequests = [{ + const validBidRequests = [{ bidId: 'bidId', params: { mid: 1000 }, mediaTypes: { @@ -642,7 +642,7 @@ describe('Adf adapter', function () { } } }]; - let { video } = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data).imp[0]; + const { video } = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data).imp[0]; assert.deepEqual(video, { playerSize: [640, 480], context: 'outstream', @@ -654,7 +654,7 @@ describe('Adf adapter', function () { describe('native', function () { describe('assets', function () { it('should use nativeOrtbRequest instead of nativeParams or mediaTypes', function () { - let validBidRequests = [{ + const validBidRequests = [{ bidId: 'bidId', params: { mid: 1000 }, nativeParams: { @@ -693,7 +693,7 @@ describe('Adf adapter', function () { } }]; - let assets = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data).imp[0].native.request.assets; + const assets = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data).imp[0].native.request.assets; assert.ok(assets[0].title); assert.equal(assets[0].title.len, 200); assert.deepEqual(assets[1].img, { type: 3, w: 170, h: 70 }); @@ -705,7 +705,7 @@ describe('Adf adapter', function () { }); it('should set correct asset id', function () { - let validBidRequests = [{ + const validBidRequests = [{ bidId: 'bidId', params: { mid: 1000 }, nativeParams: { @@ -745,7 +745,7 @@ describe('Adf adapter', function () { } }]; - let assets = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data).imp[0].native.request.assets; + const assets = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data).imp[0].native.request.assets; assert.equal(assets[0].id, 0); assert.equal(assets[1].id, 1); @@ -753,7 +753,7 @@ describe('Adf adapter', function () { }); it('should add required key if it is necessary', function () { - let validBidRequests = [{ + const validBidRequests = [{ bidId: 'bidId', params: { mid: 1000 }, nativeParams: { @@ -771,7 +771,7 @@ describe('Adf adapter', function () { ] } }]; - let assets = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data).imp[0].native.request.assets; + const assets = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data).imp[0].native.request.assets; assert.equal(assets[0].required, 1); assert.ok(!assets[1].required); @@ -780,7 +780,7 @@ describe('Adf adapter', function () { }); it('should map img and data assets', function () { - let validBidRequests = [{ + const validBidRequests = [{ bidId: 'bidId', params: { mid: 1000 }, nativeParams: { @@ -803,7 +803,7 @@ describe('Adf adapter', function () { } }]; - let assets = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data).imp[0].native.request.assets; + const assets = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data).imp[0].native.request.assets; assert.ok(assets[0].title); assert.equal(assets[0].title.len, 140); assert.deepEqual(assets[1].img, { type: 3, w: 150, h: 50 }); @@ -842,7 +842,7 @@ describe('Adf adapter', function () { } }]; - let assets = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data).imp[0].native.request.assets; + const assets = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data).imp[0].native.request.assets; assert.ok(assets[0].img); assert.equal(assets[0].img.wmin, 100); assert.equal(assets[0].img.hmin, 300); @@ -897,7 +897,7 @@ describe('Adf adapter', function () { } }]; - let assets = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data).imp[0].native.request.assets; + const assets = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data).imp[0].native.request.assets; assert.ok(assets[0].img); assert.ok(!assets[0].img.wmin); assert.ok(!assets[0].img.hmin); @@ -913,13 +913,13 @@ describe('Adf adapter', function () { describe('interpretResponse', function () { it('should return if no body in response', function () { - let serverResponse = {}; - let bidRequest = {}; + const serverResponse = {}; + const bidRequest = {}; assert.ok(!spec.interpretResponse(serverResponse, bidRequest)); }); it('should return more than one bids', function () { - let serverResponse = { + const serverResponse = { body: { seatbid: [{ bid: [{impid: '1', native: {ver: '1.1', link: { url: 'link' }, assets: [{id: 0, title: {text: 'Asset title text'}}]}}] @@ -928,7 +928,7 @@ describe('Adf adapter', function () { }] } }; - let bidRequest = { + const bidRequest = { data: {}, bids: [ { @@ -961,7 +961,7 @@ describe('Adf adapter', function () { }); it('should parse seatbids', function () { - let serverResponse = { + const serverResponse = { body: { seatbid: [{ bid: [ @@ -973,7 +973,7 @@ describe('Adf adapter', function () { }] } }; - let bidRequest = { + const bidRequest = { data: {}, bids: [ { @@ -1033,7 +1033,7 @@ describe('Adf adapter', function () { }); it('should set correct values to bid', function () { - let serverResponse = { + const serverResponse = { body: { id: null, bidid: null, @@ -1071,7 +1071,7 @@ describe('Adf adapter', function () { cur: 'NOK' } }; - let bidRequest = { + const bidRequest = { data: {}, bids: [ { @@ -1193,7 +1193,7 @@ describe('Adf adapter', function () { cur: 'NOK' } }; - let bidRequest = { + const bidRequest = { data: {}, bids: [{ bidId: 'bidId1', @@ -1265,7 +1265,7 @@ describe('Adf adapter', function () { cur: 'NOK' } }; - let bidRequest = { + const bidRequest = { data: {}, bids: [{ bidId: 'bidId1' }] }; @@ -1275,14 +1275,14 @@ describe('Adf adapter', function () { describe('banner', function () { it('should set ad content on response', function () { - let serverResponse = { + const serverResponse = { body: { seatbid: [{ bid: [{ impid: '1', adm: '', ext: { prebid: { type: 'banner' } } }] }] } }; - let bidRequest = { + const bidRequest = { data: {}, bids: [ { @@ -1302,14 +1302,14 @@ describe('Adf adapter', function () { describe('video', function () { it('should set vastXml on response', function () { - let serverResponse = { + const serverResponse = { body: { seatbid: [{ bid: [{ impid: '1', adm: '', ext: { prebid: { type: 'video' } } }] }] } }; - let bidRequest = { + const bidRequest = { data: {}, bids: [ { @@ -1327,15 +1327,15 @@ describe('Adf adapter', function () { }); it('should set vastUrl if nurl is present in response', function () { - let vastUrl = 'http://url.to/vast' - let serverResponse = { + const vastUrl = 'http://url.to/vast' + const serverResponse = { body: { seatbid: [{ bid: [{ impid: '1', adm: '', nurl: vastUrl, ext: { prebid: { type: 'video' } } }] }] } }; - let bidRequest = { + const bidRequest = { data: {}, bids: [ { @@ -1353,14 +1353,14 @@ describe('Adf adapter', function () { }); it('should add renderer for outstream bids', function () { - let serverResponse = { + const serverResponse = { body: { seatbid: [{ bid: [{ impid: '1', adm: '', ext: { prebid: { type: 'video' } } }, { impid: '2', adm: '', ext: { prebid: { type: 'video' } } }] }] } }; - let bidRequest = { + const bidRequest = { data: {}, bids: [ { diff --git a/test/spec/modules/adfusionBidAdapter_spec.js b/test/spec/modules/adfusionBidAdapter_spec.js index 82705b727b4..951670a92be 100644 --- a/test/spec/modules/adfusionBidAdapter_spec.js +++ b/test/spec/modules/adfusionBidAdapter_spec.js @@ -30,7 +30,7 @@ describe('adfusionBidAdapter', function () { }); it('should return false when params.accountID is missing', function () { - let localbid = Object.assign({}, bid); + const localbid = Object.assign({}, bid); delete localbid.params.accountId; expect(spec.isBidRequestValid(bid)).to.equal(false); }); @@ -116,11 +116,11 @@ describe('adfusionBidAdapter', function () { }); it('should add bid floor', function () { - let bidRequest = Object.assign({}, bannerBidRequest); + const bidRequest = Object.assign({}, bannerBidRequest); let payload = spec.buildRequests([bidRequest], bidderRequest)[0].data; expect(payload.imp[0].bidfloorcur).to.not.exist; - let getFloorResponse = { currency: 'USD', floor: 3 }; + const getFloorResponse = { currency: 'USD', floor: 3 }; bidRequest.getFloor = () => getFloorResponse; payload = spec.buildRequests([bidRequest], bidderRequest)[0].data; expect(payload.imp[0].bidfloor).to.equal(3); diff --git a/test/spec/modules/adgenerationBidAdapter_spec.js b/test/spec/modules/adgenerationBidAdapter_spec.js index f49b600c1bf..ab89fc4a364 100644 --- a/test/spec/modules/adgenerationBidAdapter_spec.js +++ b/test/spec/modules/adgenerationBidAdapter_spec.js @@ -30,7 +30,7 @@ describe('AdgenerationAdapter', function () { }); it('should return false when required params are not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = {}; expect(spec.isBidRequestValid(invalidBid)).to.equal(false); diff --git a/test/spec/modules/adgridBidAdapter_spec.js b/test/spec/modules/adgridBidAdapter_spec.js index 4b35b1493c5..5ebab2c6dfa 100644 --- a/test/spec/modules/adgridBidAdapter_spec.js +++ b/test/spec/modules/adgridBidAdapter_spec.js @@ -563,11 +563,11 @@ describe('adgrid bid adapter tests', () => { var syncs = spec.getUserSyncs({}, null, DEFAULT_OPTIONS.gdprConsent, DEFAULT_OPTIONS.uspConsent); expect(syncs).to.eql([]); }); - it('Verifies user sync with no bid body response', () => { - var syncs = spec.getUserSyncs({}, [], DEFAULT_OPTIONS.gdprConsent, DEFAULT_OPTIONS.uspConsent); - expect(syncs).to.eql([]); - var syncs = spec.getUserSyncs({}, [{}], DEFAULT_OPTIONS.gdprConsent, DEFAULT_OPTIONS.uspConsent); - expect(syncs).to.eql([]); - }); + it('Verifies user sync with no bid body response', () => { + let syncs = spec.getUserSyncs({}, [], DEFAULT_OPTIONS.gdprConsent, DEFAULT_OPTIONS.uspConsent); + expect(syncs).to.eql([]); + syncs = spec.getUserSyncs({}, [{}], DEFAULT_OPTIONS.gdprConsent, DEFAULT_OPTIONS.uspConsent); + expect(syncs).to.eql([]); + }); }); }); diff --git a/test/spec/modules/adheseBidAdapter_spec.js b/test/spec/modules/adheseBidAdapter_spec.js index a2e2691c8ba..4c16b774362 100644 --- a/test/spec/modules/adheseBidAdapter_spec.js +++ b/test/spec/modules/adheseBidAdapter_spec.js @@ -6,7 +6,7 @@ const BID_ID = 456; const TTL = 360; const NET_REVENUE = true; -let minimalBid = function() { +const minimalBid = function() { return { 'bidId': BID_ID, 'bidder': 'adhese', @@ -18,8 +18,8 @@ let minimalBid = function() { } }; -let bidWithParams = function(data) { - let bid = minimalBid(); +const bidWithParams = function(data) { + const bid = minimalBid(); bid.params.data = data; return bid; }; @@ -53,7 +53,7 @@ describe('AdheseAdapter', function () { }); it('should return false when required params are not passed', function () { - let bid = Object.assign({}, minimalBid()); + const bid = Object.assign({}, minimalBid()); delete bid.params; bid.params = {}; expect(spec.isBidRequestValid(bid)).to.equal(false); @@ -61,7 +61,7 @@ describe('AdheseAdapter', function () { }); describe('buildRequests', function () { - let bidderRequest = { + const bidderRequest = { gdprConsent: { gdprApplies: true, consentString: 'CONSENT_STRING' @@ -72,68 +72,68 @@ describe('AdheseAdapter', function () { }; it('should include requested slots', function () { - let req = spec.buildRequests([ minimalBid() ], bidderRequest); + const req = spec.buildRequests([ minimalBid() ], bidderRequest); expect(JSON.parse(req.data).slots[0].slotname).to.equal('_main_page_-leaderboard'); }); it('should include all extra bid params', function () { - let req = spec.buildRequests([ bidWithParams({ 'ag': '25' }) ], bidderRequest); + const req = spec.buildRequests([ bidWithParams({ 'ag': '25' }) ], bidderRequest); expect(JSON.parse(req.data).slots[0].parameters).to.deep.include({ 'ag': [ '25' ] }); }); it('should assign bid params per slot', function () { - let req = spec.buildRequests([ bidWithParams({ 'ag': '25' }), bidWithParams({ 'ag': '25', 'ci': 'gent' }) ], bidderRequest); + const req = spec.buildRequests([ bidWithParams({ 'ag': '25' }), bidWithParams({ 'ag': '25', 'ci': 'gent' }) ], bidderRequest); expect(JSON.parse(req.data).slots[0].parameters).to.deep.include({ 'ag': [ '25' ] }).and.not.to.deep.include({ 'ci': [ 'gent' ] }); expect(JSON.parse(req.data).slots[1].parameters).to.deep.include({ 'ag': [ '25' ] }).and.to.deep.include({ 'ci': [ 'gent' ] }); }); it('should split multiple target values', function () { - let req = spec.buildRequests([ bidWithParams({ 'ci': 'london' }), bidWithParams({ 'ci': 'gent' }) ], bidderRequest); + const req = spec.buildRequests([ bidWithParams({ 'ci': 'london' }), bidWithParams({ 'ci': 'gent' }) ], bidderRequest); expect(JSON.parse(req.data).slots[0].parameters).to.deep.include({ 'ci': [ 'london' ] }); expect(JSON.parse(req.data).slots[1].parameters).to.deep.include({ 'ci': [ 'gent' ] }); }); it('should filter out empty params', function () { - let req = spec.buildRequests([ bidWithParams({ 'aa': [], 'bb': null, 'cc': '', 'dd': [ '', '' ], 'ee': [ 0, 1, null ], 'ff': 0, 'gg': [ 'x', 'y', '' ] }) ], bidderRequest); + const req = spec.buildRequests([ bidWithParams({ 'aa': [], 'bb': null, 'cc': '', 'dd': [ '', '' ], 'ee': [ 0, 1, null ], 'ff': 0, 'gg': [ 'x', 'y', '' ] }) ], bidderRequest); - let params = JSON.parse(req.data).slots[0].parameters; + const params = JSON.parse(req.data).slots[0].parameters; expect(params).to.not.have.any.keys('aa', 'bb', 'cc', 'dd'); expect(params).to.deep.include({ 'ee': [ 0, 1 ], 'ff': [ 0 ], 'gg': [ 'x', 'y' ] }); }); it('should include gdpr consent param', function () { - let req = spec.buildRequests([ minimalBid() ], bidderRequest); + const req = spec.buildRequests([ minimalBid() ], bidderRequest); expect(JSON.parse(req.data).parameters).to.deep.include({ 'xt': [ 'CONSENT_STRING' ] }); }); it('should include referer param in base64url format', function () { - let req = spec.buildRequests([ minimalBid() ], bidderRequest); + const req = spec.buildRequests([ minimalBid() ], bidderRequest); expect(JSON.parse(req.data).parameters).to.deep.include({ 'xf': [ 'aHR0cDovL3ByZWJpZC5vcmcvZGV2LWRvY3Mvc3ViamVjdHM_X2Q9MQ' ] }); }); it('should include eids', function () { - let bid = minimalBid(); + const bid = minimalBid(); bid.userIdAsEids = [{ source: 'id5-sync.com', uids: [{ id: 'ID5@59sigaS-...' }] }]; - let req = spec.buildRequests([ bid ], bidderRequest); + const req = spec.buildRequests([ bid ], bidderRequest); expect(JSON.parse(req.data).user.ext.eids).to.deep.equal(bid.userIdAsEids); }); it('should not include eids field when userid module disabled', function () { - let req = spec.buildRequests([ minimalBid() ], bidderRequest); + const req = spec.buildRequests([ minimalBid() ], bidderRequest); expect(JSON.parse(req.data)).to.not.have.key('eids'); }); it('should request vast content as url by default', function () { - let req = spec.buildRequests([ minimalBid() ], bidderRequest); + const req = spec.buildRequests([ minimalBid() ], bidderRequest); expect(JSON.parse(req.data).vastContentAsUrl).to.equal(true); }); @@ -141,34 +141,34 @@ describe('AdheseAdapter', function () { it('should request vast content as markup when configured', function () { sinon.stub(config, 'getConfig').withArgs('adhese').returns({ vastContentAsUrl: false }); - let req = spec.buildRequests([ minimalBid() ], bidderRequest); + const req = spec.buildRequests([ minimalBid() ], bidderRequest); expect(JSON.parse(req.data).vastContentAsUrl).to.equal(false); config.getConfig.restore(); }); it('should include bids', function () { - let bid = minimalBid(); - let req = spec.buildRequests([ bid ], bidderRequest); + const bid = minimalBid(); + const req = spec.buildRequests([ bid ], bidderRequest); expect(req.bids).to.deep.equal([ bid ]); }); it('should make a POST request', function () { - let req = spec.buildRequests([ minimalBid() ], bidderRequest); + const req = spec.buildRequests([ minimalBid() ], bidderRequest); expect(req.method).to.equal('POST'); }); it('should request the json endpoint', function () { - let req = spec.buildRequests([ minimalBid() ], bidderRequest); + const req = spec.buildRequests([ minimalBid() ], bidderRequest); expect(req.url).to.equal('https://ads-demo.adhese.com/json'); }); it('should include params specified in the config', function () { sinon.stub(config, 'getConfig').withArgs('adhese').returns({ globalTargets: { 'tl': [ 'all' ] } }); - let req = spec.buildRequests([ minimalBid() ], bidderRequest); + const req = spec.buildRequests([ minimalBid() ], bidderRequest); expect(JSON.parse(req.data).parameters).to.deep.include({ 'tl': [ 'all' ] }); config.getConfig.restore(); @@ -176,7 +176,7 @@ describe('AdheseAdapter', function () { it('should give priority to bid params over config params', function () { sinon.stub(config, 'getConfig').withArgs('adhese').returns({ globalTargets: { 'xt': ['CONFIG_CONSENT_STRING'] } }); - let req = spec.buildRequests([ minimalBid() ], bidderRequest); + const req = spec.buildRequests([ minimalBid() ], bidderRequest); expect(JSON.parse(req.data).parameters).to.deep.include({ 'xt': [ 'CONSENT_STRING' ] }); config.getConfig.restore(); @@ -184,12 +184,12 @@ describe('AdheseAdapter', function () { }); describe('interpretResponse', () => { - let bidRequest = { + const bidRequest = { bids: [ minimalBid() ] }; it('should get correct ssp banner response', () => { - let sspBannerResponse = { + const sspBannerResponse = { body: [ { origin: 'APPNEXUS', @@ -220,7 +220,7 @@ describe('AdheseAdapter', function () { ] }; - let expectedResponse = [{ + const expectedResponse = [{ requestId: BID_ID, ad: '
', cpm: 1, @@ -257,7 +257,7 @@ describe('AdheseAdapter', function () { }); it('should get correct ssp video response', () => { - let sspVideoResponse = { + const sspVideoResponse = { body: [ { origin: 'RUBICON', @@ -272,7 +272,7 @@ describe('AdheseAdapter', function () { ] }; - let expectedResponse = [{ + const expectedResponse = [{ requestId: BID_ID, vastXml: '', cpm: 2.1, @@ -297,7 +297,7 @@ describe('AdheseAdapter', function () { }); it('should get correct ssp cache video response', () => { - let sspCachedVideoResponse = { + const sspCachedVideoResponse = { body: [ { origin: 'RUBICON', @@ -312,7 +312,7 @@ describe('AdheseAdapter', function () { ] }; - let expectedResponse = [{ + const expectedResponse = [{ requestId: BID_ID, vastUrl: 'https://ads-demo.adhese.com/content/38983ccc-4083-4c24-932c-96f798d969b3', cpm: 2.1, @@ -380,7 +380,7 @@ describe('AdheseAdapter', function () { ] }; - let expectedResponse = [{ + const expectedResponse = [{ requestId: BID_ID, ad: '', adhese: { @@ -447,7 +447,7 @@ describe('AdheseAdapter', function () { ] }; - let expectedResponse = [{ + const expectedResponse = [{ requestId: BID_ID, vastXml: '', adhese: { @@ -514,7 +514,7 @@ describe('AdheseAdapter', function () { ] }; - let expectedResponse = [{ + const expectedResponse = [{ requestId: BID_ID, vastUrl: 'https://ads-demo.adhese.com/content/38983ccc-4083-4c24-932c-96f798d969b3', adhese: { @@ -551,7 +551,7 @@ describe('AdheseAdapter', function () { }); it('should return no bids for empty adserver response', () => { - let adserverResponse = { body: [] }; + const adserverResponse = { body: [] }; expect(spec.interpretResponse(adserverResponse, bidRequest)).to.be.empty; }); }); diff --git a/test/spec/modules/adkernelAdnAnalytics_spec.js b/test/spec/modules/adkernelAdnAnalytics_spec.js index 37fcd711d62..223b6a10212 100644 --- a/test/spec/modules/adkernelAdnAnalytics_spec.js +++ b/test/spec/modules/adkernelAdnAnalytics_spec.js @@ -61,56 +61,56 @@ describe('', function () { it('should parse first direct visit as (direct)', function () { stubGetItem.withArgs('adk_dpt_analytics').returns(undefined); stubSetItem.returns(undefined); - let source = getUmtSource('http://example.com'); + const source = getUmtSource('http://example.com'); expect(source).to.be.eql(DIRECT); }); it('should respect past campaign visits before direct', function () { stubGetItem.withArgs('adk_dpt_analytics').returns(JSON.stringify(CAMPAIGN)); stubSetItem.returns(undefined); - let source = getUmtSource('http://example.com'); + const source = getUmtSource('http://example.com'); expect(source).to.be.eql(CAMPAIGN); }); it('should parse visit from google as organic', function () { stubGetItem.withArgs('adk_dpt_analytics').returns(undefined); stubSetItem.returns(undefined); - let source = getUmtSource('http://example.com', 'https://www.google.com/search?q=pikachu'); + const source = getUmtSource('http://example.com', 'https://www.google.com/search?q=pikachu'); expect(source).to.be.eql(GOOGLE_ORGANIC); }); it('should respect previous campaign visit before organic', function () { stubGetItem.withArgs('adk_dpt_analytics').returns(JSON.stringify(CAMPAIGN)); stubSetItem.returns(undefined); - let source = getUmtSource('http://example.com', 'https://www.google.com/search?q=pikachu'); + const source = getUmtSource('http://example.com', 'https://www.google.com/search?q=pikachu'); expect(source).to.be.eql(CAMPAIGN); }); it('should parse referral visit', function () { stubGetItem.withArgs('adk_dpt_analytics').returns(undefined); stubSetItem.returns(undefined); - let source = getUmtSource('http://example.com', 'http://lander.com/lander.html'); + const source = getUmtSource('http://example.com', 'http://lander.com/lander.html'); expect(source).to.be.eql(REFERRER); }); it('should respect previous campaign visit before referral', function () { stubGetItem.withArgs('adk_dpt_analytics').returns(JSON.stringify(CAMPAIGN)); stubSetItem.returns(undefined); - let source = getUmtSource('http://example.com', 'https://www.google.com/search?q=pikachu'); + const source = getUmtSource('http://example.com', 'https://www.google.com/search?q=pikachu'); expect(source).to.be.eql(CAMPAIGN); }); it('should parse referral visit from same domain as direct', function () { stubGetItem.withArgs('adk_dpt_analytics').returns(undefined); stubSetItem.returns(undefined); - let source = getUmtSource('http://lander.com/news.html', 'http://lander.com/lander.html'); + const source = getUmtSource('http://lander.com/news.html', 'http://lander.com/lander.html'); expect(source).to.be.eql(DIRECT); }); it('should parse campaign visit', function () { stubGetItem.withArgs('adk_dpt_analytics').returns(undefined); stubSetItem.returns(undefined); - let source = getUmtSource('http://lander.com/index.html?utm_campaign=new_campaign&utm_source=adkernel&utm_medium=email&utm_c1=1&utm_c2=2&utm_c3=3&utm_c4=4&utm_c5=5'); + const source = getUmtSource('http://lander.com/index.html?utm_campaign=new_campaign&utm_source=adkernel&utm_medium=email&utm_c1=1&utm_c2=2&utm_c3=3&utm_c4=4&utm_c5=5'); expect(source).to.be.eql(CAMPAIGN); }); }); @@ -125,7 +125,7 @@ describe('', function () { }); it('should notify after timeout period', (done) => { - let queue = new ExpiringQueue(() => { + const queue = new ExpiringQueue(() => { let elements = queue.popAll(); expect(elements).to.be.eql([1, 2, 3, 4]); elements = queue.popAll(); @@ -271,7 +271,7 @@ describe('', function () { events.emit(EVENTS.BID_WON, RESPONSE); timer.tick(4500); expect(ajaxStub.calledTwice).to.be.equal(true); - let ev = JSON.parse(ajaxStub.secondCall.args[0]).hb_ev; + const ev = JSON.parse(ajaxStub.secondCall.args[0]).hb_ev; expect(ev[0]).to.be.eql({event: 'bidWon', adapter: 'adapter', tagid: 'container-1', val: 0.015}); }); }); diff --git a/test/spec/modules/adkernelAdnBidAdapter_spec.js b/test/spec/modules/adkernelAdnBidAdapter_spec.js index cfee5693cf5..42c5db95f44 100644 --- a/test/spec/modules/adkernelAdnBidAdapter_spec.js +++ b/test/spec/modules/adkernelAdnBidAdapter_spec.js @@ -209,19 +209,19 @@ describe('AdkernelAdn adapter', function () { }); function buildRequest(bidRequests, bidderRequestAugments = {}) { - let fullBidderRequest = Object.assign(defaultBidderRequest, bidderRequestAugments); + const fullBidderRequest = Object.assign(defaultBidderRequest, bidderRequestAugments); fullBidderRequest.auctionId = bidRequests[0].auctionId; fullBidderRequest.transactionId = bidRequests[0].transactionId; fullBidderRequest.bidderRequestId = bidRequests[0].bidderRequestId; fullBidderRequest.bids = bidRequests; - let pbRequests = spec.buildRequests(bidRequests, fullBidderRequest); - let tagRequests = pbRequests.map(r => JSON.parse(r.data)); + const pbRequests = spec.buildRequests(bidRequests, fullBidderRequest); + const tagRequests = pbRequests.map(r => JSON.parse(r.data)); return [pbRequests, tagRequests]; } describe('banner request building', function () { - let [_, tagRequests] = buildRequest([bid1_pub1], {ortb2: {source: {tid: 'mock-tid'}}}); - let tagRequest = tagRequests[0]; + const [_, tagRequests] = buildRequest([bid1_pub1], {ortb2: {source: {tid: 'mock-tid'}}}); + const tagRequest = tagRequests[0]; it('should have request id', function () { expect(tagRequest).to.have.property('id'); @@ -254,12 +254,12 @@ describe('AdkernelAdn adapter', function () { }); it('shouldn\'t contain gdpr nor ccpa information for default request', function () { - let [_, tagRequests] = buildRequest([bid1_pub1]); + const [_, tagRequests] = buildRequest([bid1_pub1]); expect(tagRequests[0]).to.not.have.property('user'); }); it('should contain gdpr and ccpa information if consent is configured', function () { - let [_, bidRequests] = buildRequest([bid1_pub1], + const [_, bidRequests] = buildRequest([bid1_pub1], {gdprConsent: {gdprApplies: true, consentString: 'test-consent-string'}, uspConsent: '1YNN'}); expect(bidRequests[0]).to.have.property('user'); expect(bidRequests[0].user).to.have.property('gdpr', 1); @@ -268,7 +268,7 @@ describe('AdkernelAdn adapter', function () { }); it('should\'t contain consent string if gdpr isn\'t applied', function () { - let [_, bidRequests] = buildRequest([bid1_pub1], {gdprConsent: {gdprApplies: false}}); + const [_, bidRequests] = buildRequest([bid1_pub1], {gdprConsent: {gdprApplies: false}}); expect(bidRequests[0]).to.have.property('user'); expect(bidRequests[0].user).to.have.property('gdpr', 0); expect(bidRequests[0].user).to.not.have.property('consent'); @@ -276,28 +276,28 @@ describe('AdkernelAdn adapter', function () { it('should\'t contain consent string if gdpr isn\'t applied', function () { config.setConfig({coppa: true}); - let [_, bidRequests] = buildRequest([bid1_pub1]); + const [_, bidRequests] = buildRequest([bid1_pub1]); config.resetConfig(); expect(bidRequests[0]).to.have.property('user'); expect(bidRequests[0].user).to.have.property('coppa', 1); }); it('should set bidfloor if configured', function() { - let bid = Object.assign({}, bid1_pub1); + const bid = Object.assign({}, bid1_pub1); bid.getFloor = function() { return { currency: 'USD', floor: 0.145 } }; - let [, tagRequests] = buildRequest([bid]); + const [, tagRequests] = buildRequest([bid]); expect(tagRequests[0].imp[0]).to.have.property('bidfloor', 0.145); }); }); describe('video request building', () => { - let [_, tagRequests] = buildRequest([bid_video1, bid_video2]); - let tagRequest = tagRequests[0]; + const [_, tagRequests] = buildRequest([bid_video1, bid_video2]); + const tagRequest = tagRequests[0]; it('should have video object', () => { expect(tagRequest.imp[0]).to.have.property('video'); @@ -327,7 +327,7 @@ describe('AdkernelAdn adapter', function () { }); describe('multiformat request building', function () { - let [_, tagRequests] = buildRequest([bid_multiformat]); + const [_, tagRequests] = buildRequest([bid_multiformat]); it('should contain single request', function () { expect(tagRequests).to.have.length(1); @@ -343,7 +343,7 @@ describe('AdkernelAdn adapter', function () { describe('requests routing', function () { it('should issue a request for each publisher', function () { - let [pbRequests, tagRequests] = buildRequest([bid1_pub1, bid_video1]); + const [pbRequests, tagRequests] = buildRequest([bid1_pub1, bid_video1]); expect(pbRequests).to.have.length(2); expect(pbRequests[0].url).to.have.string(`account=${bid1_pub1.params.pubId}`); expect(pbRequests[1].url).to.have.string(`account=${bid1_pub2.params.pubId}`); @@ -352,7 +352,7 @@ describe('AdkernelAdn adapter', function () { }); it('should issue a request for each host', function () { - let [pbRequests, tagRequests] = buildRequest([bid1_pub1, bid1_pub2]); + const [pbRequests, tagRequests] = buildRequest([bid1_pub1, bid1_pub2]); expect(pbRequests).to.have.length(2); expect(pbRequests[0].url).to.have.string('https://tag.adkernel.com/tag'); expect(pbRequests[1].url).to.have.string(`https://${bid1_pub2.params.host}/tag`); @@ -373,7 +373,7 @@ describe('AdkernelAdn adapter', function () { }); it('should return fully-initialized bid-response', function () { - let resp = responses[0]; + const resp = responses[0]; expect(resp).to.have.property('requestId', '2c5e951baeeadd'); expect(resp).to.have.property('cpm', 5.0); expect(resp).to.have.property('width', 300); @@ -392,7 +392,7 @@ describe('AdkernelAdn adapter', function () { }); it('should return fully-initialized video bid-response', function () { - let resp = responses[2]; + const resp = responses[2]; expect(resp).to.have.property('requestId', '57d602ad1c9545'); expect(resp).to.have.property('cpm', 10.0); expect(resp).to.have.property('creativeId', '108_158802'); @@ -413,13 +413,13 @@ describe('AdkernelAdn adapter', function () { }); it('should handle user-sync only response', function () { - let [pbRequests, tagRequests] = buildRequest([bid1_pub1]); - let resp = spec.interpretResponse({body: usersyncOnlyResponse}, pbRequests[0]); + const [pbRequests, tagRequests] = buildRequest([bid1_pub1]); + const resp = spec.interpretResponse({body: usersyncOnlyResponse}, pbRequests[0]); expect(resp).to.have.length(0); }); it('shouldn\' fail on empty response', function () { - let syncs = spec.getUserSyncs({iframeEnabled: true}, [{body: ''}]); + const syncs = spec.getUserSyncs({iframeEnabled: true}, [{body: ''}]); expect(syncs).to.have.length(0); }); }); diff --git a/test/spec/modules/adkernelBidAdapter_spec.js b/test/spec/modules/adkernelBidAdapter_spec.js index df5d3ed68b2..a8d1a3c4778 100644 --- a/test/spec/modules/adkernelBidAdapter_spec.js +++ b/test/spec/modules/adkernelBidAdapter_spec.js @@ -342,11 +342,11 @@ describe('Adkernel adapter', function () { const DEFAULT_BIDDER_REQUEST = buildBidderRequest(); function buildRequest(bidRequests, bidderRequest = DEFAULT_BIDDER_REQUEST, dnt = true) { - let dntmock = sandbox.stub(utils, 'getDNT').callsFake(() => dnt); + const dntmock = sandbox.stub(utils, 'getDNT').callsFake(() => dnt); bidderRequest.bids = bidRequests; - let pbRequests = spec.buildRequests(bidRequests, bidderRequest); + const pbRequests = spec.buildRequests(bidRequests, bidderRequest); dntmock.restore(); - let rtbRequests = pbRequests.map(r => JSON.parse(r.data)); + const rtbRequests = pbRequests.map(r => JSON.parse(r.data)); return [pbRequests, rtbRequests]; } @@ -432,19 +432,19 @@ describe('Adkernel adapter', function () { }); it('shouldn\'t contain gdpr nor ccpa information for default request', function () { - let [_, bidRequests] = buildRequest([bid1_zone1]); + const [_, bidRequests] = buildRequest([bid1_zone1]); expect(bidRequests[0]).to.not.have.property('regs'); expect(bidRequests[0]).to.not.have.property('user'); }); it('should contain gdpr-related information if consent is configured', function () { - let [_, bidRequests] = buildRequest([bid1_zone1], + const [_, bidRequests] = buildRequest([bid1_zone1], buildBidderRequest('https://example.com/index.html', { gdprConsent: {gdprApplies: true, consentString: 'test-consent-string', vendorData: {}}, uspConsent: '1YNN', gppConsent: {gppString: 'DBABMA~CPXxRfAPXxRfAAfKABENB-CgAAAAAAAAAAYgAAAAAAAA', applicableSections: [2]}} )); - let bidRequest = bidRequests[0]; + const bidRequest = bidRequests[0]; expect(bidRequest).to.have.property('regs'); expect(bidRequest.regs.ext).to.be.eql({'gdpr': 1, 'us_privacy': '1YNN'}); expect(bidRequest.regs.gpp).to.be.eql('DBABMA~CPXxRfAPXxRfAAfKABENB-CgAAAAAAAAAAYgAAAAAAAA'); @@ -455,45 +455,45 @@ describe('Adkernel adapter', function () { it('should contain coppa if configured', function () { config.setConfig({coppa: true}); - let [_, bidRequests] = buildRequest([bid1_zone1]); - let bidRequest = bidRequests[0]; + const [_, bidRequests] = buildRequest([bid1_zone1]); + const bidRequest = bidRequests[0]; expect(bidRequest).to.have.property('regs'); expect(bidRequest.regs).to.have.property('coppa', 1); }); it('should\'t contain consent string if gdpr isn\'t applied', function () { - let [_, bidRequests] = buildRequest([bid1_zone1], buildBidderRequest('https://example.com/index.html', {gdprConsent: {gdprApplies: false}})); - let bidRequest = bidRequests[0]; + const [_, bidRequests] = buildRequest([bid1_zone1], buildBidderRequest('https://example.com/index.html', {gdprConsent: {gdprApplies: false}})); + const bidRequest = bidRequests[0]; expect(bidRequest).to.have.property('regs'); expect(bidRequest.regs.ext).to.be.eql({'gdpr': 0}); expect(bidRequest).to.not.have.property('user'); }); it('should\'t pass dnt if state is unknown', function () { - let [_, bidRequests] = buildRequest([bid1_zone1], DEFAULT_BIDDER_REQUEST, false); + const [_, bidRequests] = buildRequest([bid1_zone1], DEFAULT_BIDDER_REQUEST, false); expect(bidRequests[0].device).to.not.have.property('dnt'); }); it('should forward default bidder timeout', function() { - let [_, bidRequests] = buildRequest([bid1_zone1]); + const [_, bidRequests] = buildRequest([bid1_zone1]); expect(bidRequests[0]).to.have.property('tmax', 3000); }); it('should set bidfloor if configured', function() { - let bid = Object.assign({}, bid1_zone1); + const bid = Object.assign({}, bid1_zone1); bid.getFloor = function() { return { currency: 'USD', floor: 0.145 } }; - let [_, bidRequests] = buildRequest([bid]); + const [_, bidRequests] = buildRequest([bid]); expect(bidRequests[0].imp[0]).to.have.property('bidfloor', 0.145); }); it('should forward user ids if available', function() { - let bid = Object.assign({}, bid2_zone2); - let [_, bidRequests] = buildRequest([bid]); + const bid = Object.assign({}, bid2_zone2); + const [_, bidRequests] = buildRequest([bid]); expect(bidRequests[0]).to.have.property('user'); expect(bidRequests[0].user).to.have.property('ext'); expect(bidRequests[0].user.ext).to.have.property('eids'); @@ -523,7 +523,7 @@ describe('Adkernel adapter', function () { }); it('should have openrtb video impression parameters', function() { - let video = bidRequests[0].imp[0].video; + const video = bidRequests[0].imp[0].video; expect(video).to.have.property('api'); expect(video.api).to.be.eql([1, 2]); expect(video.placement).to.be.eql(1); @@ -551,7 +551,7 @@ describe('Adkernel adapter', function () { expect(bidRequests[0].imp[1].id).to.be.not.eql(bidRequests[0].imp[0].id); }); it('should collect ads back to same requestId', function() { - let bids = spec.interpretResponse({body: multiformat_response}, pbRequests[0]); + const bids = spec.interpretResponse({body: multiformat_response}, pbRequests[0]); expect(bids).to.have.length(2); expect(bids[0].requestId).to.be.eql('Bid_01'); expect(bids[0].mediaType).to.be.eql('banner'); @@ -562,14 +562,14 @@ describe('Adkernel adapter', function () { describe('requests routing', function () { it('should issue a request for each host', function () { - let [pbRequests, _] = buildRequest([bid1_zone1, bid3_host2]); + const [pbRequests, _] = buildRequest([bid1_zone1, bid3_host2]); expect(pbRequests).to.have.length(2); expect(pbRequests[0].url).to.have.string(`https://${bid1_zone1.params.host}/`); expect(pbRequests[1].url).to.have.string(`https://${bid3_host2.params.host}/`); }); it('should issue a request for each zone', function () { - let [pbRequests, _] = buildRequest([bid1_zone1, bid2_zone2]); + const [pbRequests, _] = buildRequest([bid1_zone1, bid2_zone2]); expect(pbRequests).to.have.length(2); expect(pbRequests[0].url).to.include(`zone=${bid1_zone1.params.zoneId}`); expect(pbRequests[1].url).to.include(`zone=${bid2_zone2.params.zoneId}`); @@ -589,7 +589,7 @@ describe('Adkernel adapter', function () { } } }); - let [pbRequests, bidRequests] = buildRequest([bid1_zone1]); + const [pbRequests, bidRequests] = buildRequest([bid1_zone1]); expect(bidRequests).to.have.length(1); expect(bidRequests[0]).to.not.have.property('ext'); }); @@ -606,7 +606,7 @@ describe('Adkernel adapter', function () { } } }); - let [pbRequests, bidRequests] = buildRequest([bid1_zone1]); + const [pbRequests, bidRequests] = buildRequest([bid1_zone1]); expect(bidRequests).to.have.length(1); expect(bidRequests[0].ext).to.have.property('adk_usersync', 1); }); @@ -627,7 +627,7 @@ describe('Adkernel adapter', function () { } } }); - let [pbRequests, bidRequests] = buildRequest([bid1_zone1]); + const [pbRequests, bidRequests] = buildRequest([bid1_zone1]); expect(bidRequests).to.have.length(1); expect(bidRequests[0].ext).to.have.property('adk_usersync', 2); }); @@ -648,7 +648,7 @@ describe('Adkernel adapter', function () { } } }); - let [pbRequests, bidRequests] = buildRequest([bid1_zone1]); + const [pbRequests, bidRequests] = buildRequest([bid1_zone1]); expect(bidRequests).to.have.length(1); expect(bidRequests[0]).to.not.have.property('ext'); }); @@ -656,8 +656,8 @@ describe('Adkernel adapter', function () { describe('responses processing', function () { it('should return fully-initialized banner bid-response', function () { - let [pbRequests, _] = buildRequest([bid1_zone1]); - let resp = spec.interpretResponse({body: bannerBidResponse}, pbRequests[0])[0]; + const [pbRequests, _] = buildRequest([bid1_zone1]); + const resp = spec.interpretResponse({body: bannerBidResponse}, pbRequests[0])[0]; expect(resp).to.have.property('requestId', 'Bid_01'); expect(resp).to.have.property('cpm', 3.01); expect(resp).to.have.property('width', 300); @@ -673,8 +673,8 @@ describe('Adkernel adapter', function () { }); it('should return fully-initialized video bid-response', function () { - let [pbRequests, _] = buildRequest([bid_video]); - let resp = spec.interpretResponse({body: videoBidResponse}, pbRequests[0])[0]; + const [pbRequests, _] = buildRequest([bid_video]); + const resp = spec.interpretResponse({body: videoBidResponse}, pbRequests[0])[0]; expect(resp).to.have.property('requestId', 'Bid_Video'); expect(resp.mediaType).to.equal(VIDEO); expect(resp.cpm).to.equal(0.00145); @@ -684,8 +684,8 @@ describe('Adkernel adapter', function () { }); it('should support vast xml in adm', function () { - let [pbRequests, _] = buildRequest([bid_video]); - let resp = spec.interpretResponse({body: videoBidResponseWithAdm}, pbRequests[0])[0]; + const [pbRequests, _] = buildRequest([bid_video]); + const resp = spec.interpretResponse({body: videoBidResponseWithAdm}, pbRequests[0])[0]; expect(resp).to.have.property('requestId', 'Bid_Video'); expect(resp.mediaType).to.equal(VIDEO); expect(resp.cpm).to.equal(0.00145); @@ -696,15 +696,15 @@ describe('Adkernel adapter', function () { }); it('should add nurl as pixel for banner response', function () { - let [pbRequests, _] = buildRequest([bid1_zone1]); - let resp = spec.interpretResponse({body: bannerBidResponse}, pbRequests[0])[0]; - let expectedNurl = bannerBidResponse.seatbid[0].bid[0].nurl + '&px=1'; + const [pbRequests, _] = buildRequest([bid1_zone1]); + const resp = spec.interpretResponse({body: bannerBidResponse}, pbRequests[0])[0]; + const expectedNurl = bannerBidResponse.seatbid[0].bid[0].nurl + '&px=1'; expect(resp.ad).to.have.string(expectedNurl); }); it('should handle bidresponse with user-sync only', function () { - let [pbRequests, _] = buildRequest([bid1_zone1]); - let resp = spec.interpretResponse({body: usersyncOnlyResponse}, pbRequests[0]); + const [pbRequests, _] = buildRequest([bid1_zone1]); + const resp = spec.interpretResponse({body: usersyncOnlyResponse}, pbRequests[0]); expect(resp).to.have.length(0); }); @@ -740,7 +740,7 @@ describe('Adkernel adapter', function () { expect(bidRequests[0].imp).to.have.length(1); expect(bidRequests[0].imp[0]).to.have.property('native'); expect(bidRequests[0].imp[0].native).to.have.property('request'); - let request = JSON.parse(bidRequests[0].imp[0].native.request); + const request = JSON.parse(bidRequests[0].imp[0].native.request); expect(request).to.have.property('ver', '1.2'); expect(request.assets).to.have.length(10); expect(request.assets[0]).to.be.eql({id: 0, required: 1, title: {len: 80}}); @@ -756,8 +756,8 @@ describe('Adkernel adapter', function () { }); it('native response processing', () => { - let [pbRequests, _] = buildRequest([bid_native]); - let resp = spec.interpretResponse({body: nativeResponse}, pbRequests[0])[0]; + const [pbRequests, _] = buildRequest([bid_native]); + const resp = spec.interpretResponse({body: nativeResponse}, pbRequests[0])[0]; expect(resp).to.have.property('requestId', 'Bid_01'); expect(resp).to.have.property('cpm', 2.25); expect(resp).to.have.property('currency', 'EUR'); @@ -795,8 +795,8 @@ describe('Adkernel adapter', function () { utils.triggerPixel.restore(); }); it('should trigger pixel for nurl', () => { - let [pbRequests, _] = buildRequest([bid_video]); - let bid = spec.interpretResponse({body: videoBidResponseWithAdm}, pbRequests[0])[0]; + const [pbRequests, _] = buildRequest([bid_video]); + const bid = spec.interpretResponse({body: videoBidResponseWithAdm}, pbRequests[0])[0]; spec.onBidWon(bid); expect(utils.triggerPixel.callCount).to.equal(1); }); diff --git a/test/spec/modules/adlooxAdServerVideo_spec.js b/test/spec/modules/adlooxAdServerVideo_spec.js index 17f7056346d..6469f72e59a 100644 --- a/test/spec/modules/adlooxAdServerVideo_spec.js +++ b/test/spec/modules/adlooxAdServerVideo_spec.js @@ -153,9 +153,9 @@ describe('Adloox Ad Server Video', function () { }); it('should require options.adUnit or options.bid', function (done) { - let BID = utils.deepClone(bid); + const BID = utils.deepClone(bid); - let getWinningBidsStub = sinon.stub(targeting, 'getWinningBids') + const getWinningBidsStub = sinon.stub(targeting, 'getWinningBids') getWinningBidsStub.withArgs(adUnit.code).returns([ BID ]); const ret = buildVideoUrl({ url: vastUrl }, function () {}); diff --git a/test/spec/modules/admaruBidAdapter_spec.js b/test/spec/modules/admaruBidAdapter_spec.js index 7862b76b4c7..d51451bf6a3 100644 --- a/test/spec/modules/admaruBidAdapter_spec.js +++ b/test/spec/modules/admaruBidAdapter_spec.js @@ -14,7 +14,7 @@ describe('Admaru Adapter', function () { }); describe('isBidRequestValidForBanner', () => { - let bid = { + const bid = { 'bidder': 'admaru', 'params': { 'pub_id': '1234', @@ -39,7 +39,7 @@ describe('Admaru Adapter', function () { }); it('should return false when required params are not passed', () => { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = { wrong: 'missing pub_id or adspace_id' @@ -49,7 +49,7 @@ describe('Admaru Adapter', function () { }); describe('buildRequestsForBanner', () => { - let bidRequests = [ + const bidRequests = [ { 'bidder': 'admaru', 'params': { @@ -91,7 +91,7 @@ describe('Admaru Adapter', function () { }); describe('interpretResponseForBanner', () => { - let bidRequests = [ + const bidRequests = [ { 'bidder': 'admaru', 'params': { @@ -115,9 +115,9 @@ describe('Admaru Adapter', function () { it('handles nobid responses', () => { var request = spec.buildRequests(bidRequests); - let response = ''; + const response = ''; - let result = spec.interpretResponse(response, request[0]); + const result = spec.interpretResponse(response, request[0]); expect(result.length).to.equal(0); }); }); diff --git a/test/spec/modules/admaticBidAdapter_spec.js b/test/spec/modules/admaticBidAdapter_spec.js index ad8586d4e9d..1fce6a179be 100644 --- a/test/spec/modules/admaticBidAdapter_spec.js +++ b/test/spec/modules/admaticBidAdapter_spec.js @@ -7,7 +7,7 @@ const ENDPOINT = 'https://layer.rtb.admatic.com.tr/pb'; describe('admaticBidAdapter', () => { const adapter = newBidder(spec); - let validRequest = [ { + const validRequest = [ { 'refererInfo': { 'page': 'https://www.admatic.com.tr', 'domain': 'https://www.admatic.com.tr', @@ -242,7 +242,7 @@ describe('admaticBidAdapter', () => { 'bidder': 'admatic' } } ]; - let bidderRequest = { + const bidderRequest = { 'refererInfo': { 'page': 'https://www.admatic.com.tr', 'domain': 'https://www.admatic.com.tr', @@ -556,7 +556,7 @@ describe('admaticBidAdapter', () => { }); describe('isBidRequestValid', function() { - let bid = { + const bid = { 'refererInfo': { 'page': 'https://www.admatic.com.tr', 'domain': 'https://www.admatic.com.tr', @@ -582,7 +582,7 @@ describe('admaticBidAdapter', () => { }); it('should return false when required params are not passed', function() { - let bid2 = {}; + const bid2 = {}; bid2.params = { 'someIncorrectParam': 0 }; @@ -598,7 +598,7 @@ describe('admaticBidAdapter', () => { }); it('should not populate GDPR if for non-EEA users', function () { - let bidRequest = Object.assign([], validRequest); + const bidRequest = Object.assign([], validRequest); const request = spec.buildRequests( bidRequest, Object.assign({}, bidderRequest, { @@ -613,7 +613,7 @@ describe('admaticBidAdapter', () => { }); it('should populate GDPR and empty consent string if available for EEA users without consent string but with consent', function () { - let bidRequest = Object.assign([], validRequest); + const bidRequest = Object.assign([], validRequest); const request = spec.buildRequests( bidRequest, Object.assign({}, bidderRequest, { @@ -627,7 +627,7 @@ describe('admaticBidAdapter', () => { }); it('should properly build a request when coppa flag is true', function () { - let bidRequest = Object.assign([], validRequest); + const bidRequest = Object.assign([], validRequest); const request = spec.buildRequests( bidRequest, Object.assign({}, bidderRequest, { @@ -639,7 +639,7 @@ describe('admaticBidAdapter', () => { }); it('should properly build a request with gpp consent field', function () { - let bidRequest = Object.assign([], validRequest); + const bidRequest = Object.assign([], validRequest); const ortb2 = { regs: { gpp: 'gpp_consent_string', @@ -652,7 +652,7 @@ describe('admaticBidAdapter', () => { }); it('should properly build a request with ccpa consent field', function () { - let bidRequest = Object.assign([], validRequest); + const bidRequest = Object.assign([], validRequest); const request = spec.buildRequests( bidRequest, Object.assign({}, bidderRequest, { @@ -795,7 +795,7 @@ describe('admaticBidAdapter', () => { describe('interpretResponse', function () { it('should get correct bid responses', function() { - let bids = { body: { + const bids = { body: { data: [ { 'id': 1, @@ -854,7 +854,7 @@ describe('admaticBidAdapter', () => { 'status': true }}; - let expectedResponse = [ + const expectedResponse = [ { requestId: 1, cpm: 0.01, @@ -1136,25 +1136,25 @@ describe('admaticBidAdapter', () => { ] }; - let result = spec.interpretResponse(bids, {data: request}); + const result = spec.interpretResponse(bids, {data: request}); expect(result).to.eql(expectedResponse); }); it('handles nobid responses', function () { - let request = { + const request = { ext: { 'cur': 'TRY', 'type': 'admatic' } }; - let bids = { body: { + const bids = { body: { data: [], 'queryId': 'cdnbh24rlv0hhkpfpln0', 'status': true, 'cur': 'TRY' }}; - let result = spec.interpretResponse(bids, {data: request}); + const result = spec.interpretResponse(bids, {data: request}); expect(result.length).to.equal(0); }); }); diff --git a/test/spec/modules/admediaBidAdapter_spec.js b/test/spec/modules/admediaBidAdapter_spec.js index c1e248ff95c..9208468add7 100644 --- a/test/spec/modules/admediaBidAdapter_spec.js +++ b/test/spec/modules/admediaBidAdapter_spec.js @@ -8,7 +8,7 @@ const ENDPOINT_URL = 'https://prebid.admedia.com/bidder/'; describe('admediaBidAdapter', function () { const adapter = newBidder(spec); describe('isBidRequestValid', function () { - let bid = { + const bid = { adUnitCode: 'adunit-code', bidder: 'admedia', bidId: 'g7ghhs78', @@ -26,7 +26,7 @@ describe('admediaBidAdapter', function () { }); }); describe('buildRequests', function () { - let bidRequests = [ + const bidRequests = [ { adUnitCode: 'adunit-code', bidder: 'admedia', @@ -42,7 +42,7 @@ describe('admediaBidAdapter', function () { } ]; - let bidderRequests = { + const bidderRequests = { refererInfo: { page: 'https://test.com', } @@ -55,7 +55,7 @@ describe('admediaBidAdapter', function () { }); describe('interpretResponse', function () { - let bidRequest = { + const bidRequest = { method: 'POST', url: ENDPOINT_URL, data: { @@ -74,7 +74,7 @@ describe('admediaBidAdapter', function () { 'referer': 'https%3A%2F%test.com' } }; - let serverResponse = { + const serverResponse = { body: { 'tags': [ diff --git a/test/spec/modules/admixerBidAdapter_spec.js b/test/spec/modules/admixerBidAdapter_spec.js index 1da6a58bea3..db8dbd0d203 100644 --- a/test/spec/modules/admixerBidAdapter_spec.js +++ b/test/spec/modules/admixerBidAdapter_spec.js @@ -22,7 +22,7 @@ describe('AdmixerAdapter', function () { // inv-nets.admixer.net/adxprebid.1.2.aspx describe('isBidRequestValid', function () { - let bid = { + const bid = { bidder: BIDDER_CODE, params: { zone: ZONE_ID, @@ -37,7 +37,7 @@ describe('AdmixerAdapter', function () { auctionId: '1d1a030790a475', }; - let rtbBid = { + const rtbBid = { bidder: RTB_BIDDER_CODE, params: { tagId: ENDPOINT_ID, @@ -60,7 +60,7 @@ describe('AdmixerAdapter', function () { }); it('should return false when required params are not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = { placementId: 0, @@ -68,7 +68,7 @@ describe('AdmixerAdapter', function () { expect(spec.isBidRequestValid(invalidBid)).to.equal(false); }); it('should return false when params required by RTB are not passed', function () { - let invalidBid = Object.assign({}, rtbBid); + const invalidBid = Object.assign({}, rtbBid); delete invalidBid.params; invalidBid.params = { clientId: 0, @@ -78,7 +78,7 @@ describe('AdmixerAdapter', function () { }); describe('buildRequests', function () { - let validRequest = [ + const validRequest = [ { bidder: BIDDER_CODE, params: { @@ -94,7 +94,7 @@ describe('AdmixerAdapter', function () { auctionId: '1d1a030790a475', }, ]; - let bidderRequest = { + const bidderRequest = { bidderCode: BIDDER_CODE, refererInfo: { page: 'https://example.com', @@ -206,7 +206,7 @@ describe('AdmixerAdapter', function () { }); describe('checkFloorGetting', function () { - let validRequest = [ + const validRequest = [ { bidder: BIDDER_CODE, params: { @@ -219,7 +219,7 @@ describe('AdmixerAdapter', function () { auctionId: '1d1a030790a475', }, ]; - let bidderRequest = { + const bidderRequest = { bidderCode: BIDDER_CODE, refererInfo: { page: 'https://example.com', @@ -236,7 +236,7 @@ describe('AdmixerAdapter', function () { }); describe('interpretResponse', function () { - let response = { + const response = { body: { ads: [ { @@ -262,7 +262,7 @@ describe('AdmixerAdapter', function () { it('should get correct bid response', function () { const ads = response.body.ads; - let expectedResponse = [ + const expectedResponse = [ { requestId: ads[0].requestId, cpm: ads[0].cpm, @@ -282,22 +282,22 @@ describe('AdmixerAdapter', function () { }, ]; - let result = spec.interpretResponse(response); + const result = spec.interpretResponse(response); expect(result[0]).to.deep.equal(expectedResponse[0]); }); it('handles nobid responses', function () { - let response = []; + const response = []; - let result = spec.interpretResponse(response); + const result = spec.interpretResponse(response); expect(result.length).to.equal(0); }); }); describe('getUserSyncs', function () { - let imgUrl = 'https://example.com/img1'; - let frmUrl = 'https://example.com/frm2'; - let responses = [ + const imgUrl = 'https://example.com/img1'; + const frmUrl = 'https://example.com/frm2'; + const responses = [ { body: { cm: { @@ -309,9 +309,9 @@ describe('AdmixerAdapter', function () { ]; it('Returns valid values', function () { - let userSyncAll = spec.getUserSyncs({pixelEnabled: true, iframeEnabled: true}, responses); - let userSyncImg = spec.getUserSyncs({pixelEnabled: true, iframeEnabled: false}, responses); - let userSyncFrm = spec.getUserSyncs({pixelEnabled: false, iframeEnabled: true}, responses); + const userSyncAll = spec.getUserSyncs({pixelEnabled: true, iframeEnabled: true}, responses); + const userSyncImg = spec.getUserSyncs({pixelEnabled: true, iframeEnabled: false}, responses); + const userSyncFrm = spec.getUserSyncs({pixelEnabled: false, iframeEnabled: true}, responses); expect(userSyncAll).to.be.an('array').with.lengthOf(2); expect(userSyncImg).to.be.an('array').with.lengthOf(1); expect(userSyncImg[0].url).to.be.equal(imgUrl); diff --git a/test/spec/modules/admixerIdSystem_spec.js b/test/spec/modules/admixerIdSystem_spec.js index 56c356a153e..af3783558f9 100644 --- a/test/spec/modules/admixerIdSystem_spec.js +++ b/test/spec/modules/admixerIdSystem_spec.js @@ -30,15 +30,15 @@ describe('admixerId tests', function () { }); it('should NOT call the admixer id endpoint if gdpr applies but consent string is missing', function () { - let submoduleCallback = admixerIdSubmodule.getId(getIdParams, {gdpr: { gdprApplies: true }}); + const submoduleCallback = admixerIdSubmodule.getId(getIdParams, {gdpr: { gdprApplies: true }}); expect(submoduleCallback).to.be.undefined; }); it('should call the admixer id endpoint', function () { - let callBackSpy = sinon.spy(); - let submoduleCallback = admixerIdSubmodule.getId(getIdParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = admixerIdSubmodule.getId(getIdParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.be.eq(`https://inv-nets.admixer.net/cntcm.aspx?ssp=${pid}`); request.respond( 200, @@ -49,10 +49,10 @@ describe('admixerId tests', function () { }); it('should call callback with user id', function () { - let callBackSpy = sinon.spy(); - let submoduleCallback = admixerIdSubmodule.getId(getIdParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = admixerIdSubmodule.getId(getIdParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.be.eq(`https://inv-nets.admixer.net/cntcm.aspx?ssp=${pid}`); request.respond( 200, @@ -64,10 +64,10 @@ describe('admixerId tests', function () { }); it('should continue to callback if ajax response 204', function () { - let callBackSpy = sinon.spy(); - let submoduleCallback = admixerIdSubmodule.getId(getIdParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = admixerIdSubmodule.getId(getIdParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.be.eq(`https://inv-nets.admixer.net/cntcm.aspx?ssp=${pid}`); request.respond( 204 diff --git a/test/spec/modules/adnuntiusAnalyticsAdapter_spec.js b/test/spec/modules/adnuntiusAnalyticsAdapter_spec.js index 72a0f744108..f962819e242 100644 --- a/test/spec/modules/adnuntiusAnalyticsAdapter_spec.js +++ b/test/spec/modules/adnuntiusAnalyticsAdapter_spec.js @@ -4,9 +4,9 @@ import { config } from 'src/config.js'; import { server } from 'test/mocks/xhr.js'; import { setConfig } from 'modules/currency.js'; -let events = require('src/events'); -let utils = require('src/utils'); -let adapterManager = require('src/adapterManager').default; +const events = require('src/events'); +const utils = require('src/utils'); +const adapterManager = require('src/adapterManager').default; const { AUCTION_INIT, @@ -294,7 +294,7 @@ describe('Adnuntius analytics adapter', function () { beforeEach(function () { sandbox = sinon.createSandbox(); - let element = { + const element = { getAttribute: function() { return 'adunitid'; } @@ -336,7 +336,7 @@ describe('Adnuntius analytics adapter', function () { clock.tick(BID_WON_TIMEOUT + 1000); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.equal('https://analytics.adnuntius.com/prebid'); @@ -385,7 +385,7 @@ describe('Adnuntius analytics adapter', function () { expect(server.requests.length).to.equal(1); - let message = JSON.parse(server.requests[0].requestBody); + const message = JSON.parse(server.requests[0].requestBody); expect(message.timeouts.length).to.equal(1); expect(message.timeouts[0].bidder).to.equal('adnuntius'); expect(message.timeouts[0].adUnit).to.equal('panorama_d_1'); @@ -424,8 +424,8 @@ describe('Adnuntius analytics adapter', function () { clock.tick(BID_WON_TIMEOUT + 1000); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; - let message = JSON.parse(request.requestBody); + const request = server.requests[0]; + const message = JSON.parse(request.requestBody); expect(message.gdpr.length).to.equal(1); expect(message.gdpr[0].gdprApplies).to.equal(true); @@ -456,8 +456,8 @@ describe('Adnuntius analytics adapter', function () { clock.tick(BID_WON_TIMEOUT + 1000); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; - let message = JSON.parse(request.requestBody); + const request = server.requests[0]; + const message = JSON.parse(request.requestBody); expect(message.wins.length).to.equal(1); expect(message.wins[0].rUp).to.equal('rUpObject'); @@ -490,7 +490,7 @@ describe('Adnuntius analytics adapter', function () { clock.tick(BID_WON_TIMEOUT + 1000); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.equal('https://whitelabeled.com/analytics/10'); }); @@ -524,8 +524,8 @@ describe('Adnuntius analytics adapter', function () { clock.tick(BID_WON_TIMEOUT + 1000); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; - let message = JSON.parse(request.requestBody); + const request = server.requests[0]; + const message = JSON.parse(request.requestBody); expect(message.ext).to.not.equal(null); expect(message.ext.testparam).to.equal(123); diff --git a/test/spec/modules/adnuntiusBidAdapter_spec.js b/test/spec/modules/adnuntiusBidAdapter_spec.js index 58fd93d0cd0..1bf9f4cd287 100644 --- a/test/spec/modules/adnuntiusBidAdapter_spec.js +++ b/test/spec/modules/adnuntiusBidAdapter_spec.js @@ -1280,14 +1280,14 @@ describe('adnuntiusBidAdapter', function () { describe('user privacy', function () { it('should send GDPR Consent data if gdprApplies', function () { - let request = spec.buildRequests(bidderRequests, { gdprConsent: { gdprApplies: true, consentString: 'consentString' } }); + const request = spec.buildRequests(bidderRequests, { gdprConsent: { gdprApplies: true, consentString: 'consentString' } }); expect(request.length).to.equal(1); expect(request[0]).to.have.property('url'); expectUrlsEqual(request[0].url, ENDPOINT_URL_CONSENT); }); it('should not send GDPR Consent data if gdprApplies equals undefined', function () { - let request = spec.buildRequests(bidderRequests, { gdprConsent: { gdprApplies: undefined, consentString: 'consentString' } }); + const request = spec.buildRequests(bidderRequests, { gdprConsent: { gdprApplies: undefined, consentString: 'consentString' } }); expect(request.length).to.equal(1); expect(request[0]).to.have.property('url'); expectUrlsEqual(request[0].url, ENDPOINT_URL); @@ -1423,14 +1423,14 @@ describe('adnuntiusBidAdapter', function () { describe('user privacy', function () { it('should send GDPR Consent data if gdprApplies', function () { - let request = spec.buildRequests(bidderRequests, { gdprConsent: { gdprApplies: true, consentString: 'consentString' } }); + const request = spec.buildRequests(bidderRequests, { gdprConsent: { gdprApplies: true, consentString: 'consentString' } }); expect(request.length).to.equal(1); expect(request[0]).to.have.property('url'); expectUrlsEqual(request[0].url, ENDPOINT_URL_CONSENT); }); it('should not send GDPR Consent data if gdprApplies equals undefined', function () { - let request = spec.buildRequests(bidderRequests, { gdprConsent: { gdprApplies: undefined, consentString: 'consentString' } }); + const request = spec.buildRequests(bidderRequests, { gdprConsent: { gdprApplies: undefined, consentString: 'consentString' } }); expect(request.length).to.equal(1); expect(request[0]).to.have.property('url'); expectUrlsEqual(request[0].url, ENDPOINT_URL); diff --git a/test/spec/modules/adpartnerBidAdapter_spec.js b/test/spec/modules/adpartnerBidAdapter_spec.js index 597974acce8..fdc63bade6d 100644 --- a/test/spec/modules/adpartnerBidAdapter_spec.js +++ b/test/spec/modules/adpartnerBidAdapter_spec.js @@ -16,7 +16,7 @@ describe('AdpartnerAdapter', function () { describe('isBidRequestValid', function () { it('should return true when required params found', function () { - let validRequest = { + const validRequest = { 'params': { 'unitId': 123 } @@ -25,7 +25,7 @@ describe('AdpartnerAdapter', function () { }); it('should return true when required params is srting', function () { - let validRequest = { + const validRequest = { 'params': { 'unitId': '456' } @@ -34,7 +34,7 @@ describe('AdpartnerAdapter', function () { }); it('should return false when required params are not passed', function () { - let validRequest = { + const validRequest = { 'params': { 'unknownId': 123 } @@ -43,7 +43,7 @@ describe('AdpartnerAdapter', function () { }); it('should return false when required params is 0', function () { - let validRequest = { + const validRequest = { 'params': { 'unitId': 0 } @@ -53,9 +53,9 @@ describe('AdpartnerAdapter', function () { }); describe('buildRequests', function () { - let validEndpoint = ENDPOINT_PROTOCOL + '://' + ENDPOINT_DOMAIN + ENDPOINT_PATH + '?tag=123,456&partner=777&sizes=300x250|300x600,728x90,300x250&referer=https%3A%2F%2Ftest.domain'; + const validEndpoint = ENDPOINT_PROTOCOL + '://' + ENDPOINT_DOMAIN + ENDPOINT_PATH + '?tag=123,456&partner=777&sizes=300x250|300x600,728x90,300x250&referer=https%3A%2F%2Ftest.domain'; - let validRequest = [ + const validRequest = [ { 'bidder': BIDDER_CODE, 'params': { @@ -85,7 +85,7 @@ describe('AdpartnerAdapter', function () { } ]; - let bidderRequest = { + const bidderRequest = { refererInfo: { page: 'https://test.domain' } @@ -299,7 +299,7 @@ describe('AdpartnerAdapter', function () { 'pixelEnabled': false }; - let syncs = spec.getUserSyncs(syncOptions); + const syncs = spec.getUserSyncs(syncOptions); expect(syncs).to.deep.equal([]); }); @@ -310,7 +310,7 @@ describe('AdpartnerAdapter', function () { }; const gdprConsent = undefined; - let syncs = spec.getUserSyncs(syncOptions, bidResponse, gdprConsent); + const syncs = spec.getUserSyncs(syncOptions, bidResponse, gdprConsent); expect(syncs.length).to.equal(3); expect(syncs[0].type).to.equal('image'); expect(syncs[0].url).to.equal('https://test.domain/tracker_1.gif'); @@ -328,7 +328,7 @@ describe('AdpartnerAdapter', function () { apiVersion: 2 }; - let syncs = spec.getUserSyncs(syncOptions, bidResponse, gdprConsent); + const syncs = spec.getUserSyncs(syncOptions, bidResponse, gdprConsent); expect(syncs.length).to.equal(3); expect(syncs[0].type).to.equal('image'); expect(syncs[0].url).to.equal('https://test.domain/tracker_1.gif?gdpr=1&gdpr_consent=someString'); diff --git a/test/spec/modules/adplusBidAdapter_spec.js b/test/spec/modules/adplusBidAdapter_spec.js index 840d86c80f1..9c7efd3d347 100644 --- a/test/spec/modules/adplusBidAdapter_spec.js +++ b/test/spec/modules/adplusBidAdapter_spec.js @@ -13,7 +13,7 @@ describe('AplusBidAdapter', function () { describe('isBidRequestValid', function () { it('should return true when required params found', function () { - let validRequest = { + const validRequest = { mediaTypes: { banner: { sizes: [[300, 250]] @@ -28,7 +28,7 @@ describe('AplusBidAdapter', function () { }); it('should return false when required params are not passed', function () { - let validRequest = { + const validRequest = { mediaTypes: { banner: { sizes: [[300, 250]] @@ -42,7 +42,7 @@ describe('AplusBidAdapter', function () { }); it('should return false when required param types are wrong', function () { - let validRequest = { + const validRequest = { mediaTypes: { banner: { sizes: [[300, 250]] @@ -57,7 +57,7 @@ describe('AplusBidAdapter', function () { }); it('should return false when size is not exists', function () { - let validRequest = { + const validRequest = { params: { inventoryId: 30, adUnitId: '1', @@ -67,7 +67,7 @@ describe('AplusBidAdapter', function () { }); it('should return false when size is wrong', function () { - let validRequest = { + const validRequest = { mediaTypes: { banner: { sizes: [[300]] @@ -83,7 +83,7 @@ describe('AplusBidAdapter', function () { }); describe('buildRequests', function () { - let validRequest = [ + const validRequest = [ { bidder: BIDDER_CODE, mediaTypes: { @@ -99,7 +99,7 @@ describe('AplusBidAdapter', function () { }, ]; - let bidderRequest = { + const bidderRequest = { refererInfo: { referer: 'https://test.domain' } diff --git a/test/spec/modules/adpod_spec.js b/test/spec/modules/adpod_spec.js index 14e530c1a9b..96e9cb4567a 100644 --- a/test/spec/modules/adpod_spec.js +++ b/test/spec/modules/adpod_spec.js @@ -6,7 +6,7 @@ import { ADPOD } from 'src/mediaTypes.js'; import { callPrebidCacheHook, checkAdUnitSetupHook, checkVideoBidSetupHook, adpodSetConfig, sortByPricePerSecond } from 'modules/adpod.js'; -let expect = require('chai').expect; +const expect = require('chai').expect; describe('adpod.js', function () { let logErrorStub; @@ -22,18 +22,18 @@ describe('adpod.js', function () { let afterBidAddedSpy; let auctionBids = []; - let callbackFn = function() { + const callbackFn = function() { callbackResult = true; }; - let auctionInstance = { + const auctionInstance = { getAuctionStatus: function() { return auction.AUCTION_IN_PROGRESS; } } const fakeStoreFn = function(bids, callback) { - let payload = []; + const payload = []; bids.forEach(bid => payload.push({uuid: bid.customCacheKey})); callback(null, payload); }; @@ -66,12 +66,12 @@ describe('adpod.js', function () { }) it('should redirect back to the original function if bid is not an adpod video', function () { - let bid = { + const bid = { adId: 'testAdId_123', mediaType: 'video' }; - let videoMT = { + const videoMT = { context: 'outstream' }; @@ -87,7 +87,7 @@ describe('adpod.js', function () { } }); - let bidResponse1 = { + const bidResponse1 = { adId: 'adId01277', auctionId: 'no_defer_123', mediaType: 'video', @@ -106,7 +106,7 @@ describe('adpod.js', function () { } }; - let bidResponse2 = { + const bidResponse2 = { adId: 'adId46547', auctionId: 'no_defer_123', mediaType: 'video', @@ -125,7 +125,7 @@ describe('adpod.js', function () { } }; - let videoMT = { + const videoMT = { context: ADPOD, playerSize: [[300, 300]], adPodDurationSec: 300, @@ -165,7 +165,7 @@ describe('adpod.js', function () { } }); - let bidResponse1 = { + const bidResponse1 = { adId: 'adId123', auctionId: 'full_abc123', mediaType: 'video', @@ -183,7 +183,7 @@ describe('adpod.js', function () { durationBucket: 30 } }; - let bidResponse2 = { + const bidResponse2 = { adId: 'adId234', auctionId: 'full_abc123', mediaType: 'video', @@ -201,7 +201,7 @@ describe('adpod.js', function () { durationBucket: 30 } }; - let videoMT = { + const videoMT = { context: ADPOD, playerSize: [[300, 300]], adPodDurationSec: 120, @@ -239,7 +239,7 @@ describe('adpod.js', function () { } }); - let bidResponse = { + const bidResponse = { adId: 'adId234', auctionId: 'timer_abc234', mediaType: 'video', @@ -257,7 +257,7 @@ describe('adpod.js', function () { durationBucket: 30 } }; - let videoMT = { + const videoMT = { context: ADPOD, playerSize: [[300, 300]], adPodDurationSec: 120, @@ -290,7 +290,7 @@ describe('adpod.js', function () { } }); - let bidResponse1 = { + const bidResponse1 = { adId: 'multi_ad1', auctionId: 'multi_call_abc345', mediaType: 'video', @@ -308,7 +308,7 @@ describe('adpod.js', function () { durationBucket: 15 } }; - let bidResponse2 = { + const bidResponse2 = { adId: 'multi_ad2', auctionId: 'multi_call_abc345', mediaType: 'video', @@ -326,7 +326,7 @@ describe('adpod.js', function () { durationBucket: 15 } }; - let bidResponse3 = { + const bidResponse3 = { adId: 'multi_ad3', auctionId: 'multi_call_abc345', mediaType: 'video', @@ -345,7 +345,7 @@ describe('adpod.js', function () { } }; - let videoMT = { + const videoMT = { context: ADPOD, playerSize: [[300, 300]], adPodDurationSec: 45, @@ -391,7 +391,7 @@ describe('adpod.js', function () { } }); - let bidResponse1 = { + const bidResponse1 = { adId: 'nocat_ad1', auctionId: 'no_category_abc345', mediaType: 'video', @@ -409,7 +409,7 @@ describe('adpod.js', function () { durationBucket: 15 } }; - let bidResponse2 = { + const bidResponse2 = { adId: 'nocat_ad2', auctionId: 'no_category_abc345', mediaType: 'video', @@ -428,7 +428,7 @@ describe('adpod.js', function () { } }; - let videoMT = { + const videoMT = { context: ADPOD, playerSize: [[300, 300]], adPodDurationSec: 45, @@ -467,7 +467,7 @@ describe('adpod.js', function () { } }); - let bidResponse1 = { + const bidResponse1 = { adId: 'missingCat_ad1', auctionId: 'missing_category_abc345', mediaType: 'video', @@ -482,7 +482,7 @@ describe('adpod.js', function () { } }; - let videoMT = { + const videoMT = { context: ADPOD, playerSize: [[300, 300]], adPodDurationSec: 45, @@ -501,7 +501,7 @@ describe('adpod.js', function () { it('should not add bid to auction when Prebid Cache detects an existing key', function () { storeStub.callsFake(function(bids, callback) { - let payload = []; + const payload = []; bids.forEach(bid => payload.push({uuid: bid.customCacheKey})); // fake a duplicate bid response from PBC (sets an empty string for the uuid) @@ -517,7 +517,7 @@ describe('adpod.js', function () { } }); - let bidResponse1 = { + const bidResponse1 = { adId: 'dup_ad_1', auctionId: 'duplicate_def123', mediaType: 'video', @@ -535,7 +535,7 @@ describe('adpod.js', function () { durationBucket: 45 } }; - let bidResponse2 = { + const bidResponse2 = { adId: 'dup_ad_2', auctionId: 'duplicate_def123', mediaType: 'video', @@ -553,7 +553,7 @@ describe('adpod.js', function () { durationBucket: 45 } }; - let videoMT = { + const videoMT = { context: ADPOD, playerSize: [[300, 300]], adPodDurationSec: 120, @@ -578,8 +578,8 @@ describe('adpod.js', function () { it('should not add bids to auction if PBC returns an error', function() { storeStub.callsFake(function(bids, callback) { - let payload = []; - let errmsg = 'invalid json'; + const payload = []; + const errmsg = 'invalid json'; callback(errmsg, payload); }); @@ -592,7 +592,7 @@ describe('adpod.js', function () { } }); - let bidResponse1 = { + const bidResponse1 = { adId: 'err_ad_1', auctionId: 'error_xyz123', mediaType: 'video', @@ -606,7 +606,7 @@ describe('adpod.js', function () { durationBucket: 30 } }; - let bidResponse2 = { + const bidResponse2 = { adId: 'err_ad_2', auctionId: 'error_xyz123', mediaType: 'video', @@ -620,7 +620,7 @@ describe('adpod.js', function () { durationBucket: 30 } }; - let videoMT = { + const videoMT = { context: ADPOD, playerSize: [[300, 300]], adPodDurationSec: 120, @@ -662,7 +662,7 @@ describe('adpod.js', function () { } }); - let bidResponse1 = { + const bidResponse1 = { adId: 'cat_ad1', auctionId: 'test_category_abc345', mediaType: 'video', @@ -686,7 +686,7 @@ describe('adpod.js', function () { } }; - let videoMT = { + const videoMT = { context: ADPOD, playerSize: [[300, 300]], adPodDurationSec: 45, @@ -717,7 +717,7 @@ describe('adpod.js', function () { } }); - let bidResponse1 = { + const bidResponse1 = { adId: 'adId01277', auctionId: 'no_defer_123', mediaType: 'video', @@ -738,7 +738,7 @@ describe('adpod.js', function () { } }; - let bidResponse2 = { + const bidResponse2 = { adId: 'adId46547', auctionId: 'no_defer_123', mediaType: 'video', @@ -758,7 +758,7 @@ describe('adpod.js', function () { } }; - let videoMT = { + const videoMT = { context: ADPOD, playerSize: [[300, 300]], adPodDurationSec: 300, @@ -776,7 +776,7 @@ describe('adpod.js', function () { describe('checkAdUnitSetupHook', function () { let results; - let callbackFn = function (adUnits) { + const callbackFn = function (adUnits) { results = adUnits; }; @@ -790,7 +790,7 @@ describe('adpod.js', function () { }); it('removes an incorrectly setup adpod adunit - required fields are missing', function() { - let adUnits = [{ + const adUnits = [{ code: 'test1', mediaTypes: { video: { @@ -820,7 +820,7 @@ describe('adpod.js', function () { }); it('removes an incorrectly setup adpod adunit - required fields are using invalid values', function() { - let adUnits = [{ + const adUnits = [{ code: 'test1', mediaTypes: { video: { @@ -846,7 +846,7 @@ describe('adpod.js', function () { }); it('removes an incorrectly setup adpod adunit - attempting to use multi-format adUnit', function() { - let adUnits = [{ + const adUnits = [{ code: 'multi_test1', mediaTypes: { banner: { @@ -868,7 +868,7 @@ describe('adpod.js', function () { }); it('accepts mixed set of adunits', function() { - let adUnits = [{ + const adUnits = [{ code: 'test3', mediaTypes: { video: { @@ -962,7 +962,7 @@ describe('adpod.js', function () { }) it('redirects to original function for non-adpod type video bids', function() { - let bannerTestBid = { + const bannerTestBid = { mediaType: 'video' }; checkVideoBidSetupHook(callbackFn, bannerTestBid, {}, {}, 'instream'); @@ -981,7 +981,7 @@ describe('adpod.js', function () { } }); - let goodBid = utils.deepClone(adpodTestBid); + const goodBid = utils.deepClone(adpodTestBid); goodBid.meta.primaryCatId = undefined; checkVideoBidSetupHook(callbackFn, goodBid, adUnitNoExact, adUnitNoExact.mediaTypes.video, ADPOD); expect(callbackResult).to.be.null; @@ -990,7 +990,7 @@ describe('adpod.js', function () { }); it('returns true when adpod bid is missing iab category while brandCategoryExclusion in config is false', function() { - let goodBid = utils.deepClone(adpodTestBid); + const goodBid = utils.deepClone(adpodTestBid); checkVideoBidSetupHook(callbackFn, goodBid, adUnitNoExact, adUnitNoExact.mediaTypes.video, ADPOD); expect(callbackResult).to.be.null; expect(bailResult).to.equal(true); @@ -1005,24 +1005,24 @@ describe('adpod.js', function () { expect(logErrorStub.called).to.equal(shouldErrorBeLogged); } - let noCatBid = utils.deepClone(adpodTestBid); + const noCatBid = utils.deepClone(adpodTestBid); noCatBid.meta.primaryCatId = undefined; testInvalidAdpodBid(noCatBid, false); - let noContextBid = utils.deepClone(adpodTestBid); + const noContextBid = utils.deepClone(adpodTestBid); delete noContextBid.video.context; testInvalidAdpodBid(noContextBid, false); - let wrongContextBid = utils.deepClone(adpodTestBid); + const wrongContextBid = utils.deepClone(adpodTestBid); wrongContextBid.video.context = 'instream'; testInvalidAdpodBid(wrongContextBid, false); - let noDurationBid = utils.deepClone(adpodTestBid); + const noDurationBid = utils.deepClone(adpodTestBid); delete noDurationBid.video.durationSeconds; testInvalidAdpodBid(noDurationBid, false); config.resetConfig(); - let noCacheUrlBid = utils.deepClone(adpodTestBid); + const noCacheUrlBid = utils.deepClone(adpodTestBid); testInvalidAdpodBid(noCacheUrlBid, true); }); @@ -1039,7 +1039,7 @@ describe('adpod.js', function () { }; it('when requireExactDuration is true', function() { - let goodBid = utils.deepClone(basicBid); + const goodBid = utils.deepClone(basicBid); checkVideoBidSetupHook(callbackFn, goodBid, adUnitWithExact, adUnitWithExact.mediaTypes.video, ADPOD); expect(callbackResult).to.be.null; @@ -1047,7 +1047,7 @@ describe('adpod.js', function () { expect(bailResult).to.equal(true); expect(logWarnStub.called).to.equal(false); - let badBid = utils.deepClone(basicBid); + const badBid = utils.deepClone(basicBid); badBid.video.durationSeconds = 14; checkVideoBidSetupHook(callbackFn, badBid, adUnitWithExact, adUnitWithExact.mediaTypes.video, ADPOD); @@ -1066,23 +1066,23 @@ describe('adpod.js', function () { expect(logWarnStub.called).to.equal(false); } - let goodBid45 = utils.deepClone(basicBid); + const goodBid45 = utils.deepClone(basicBid); goodBid45.video.durationSeconds = 45; testRoundingForGoodBId(goodBid45, 45); - let goodBid30 = utils.deepClone(basicBid); + const goodBid30 = utils.deepClone(basicBid); goodBid30.video.durationSeconds = 30; testRoundingForGoodBId(goodBid30, 45); - let goodBid10 = utils.deepClone(basicBid); + const goodBid10 = utils.deepClone(basicBid); goodBid10.video.durationSeconds = 10; testRoundingForGoodBId(goodBid10, 15); - let goodBid16 = utils.deepClone(basicBid); + const goodBid16 = utils.deepClone(basicBid); goodBid16.video.durationSeconds = 16; testRoundingForGoodBId(goodBid16, 15); - let goodBid47 = utils.deepClone(basicBid); + const goodBid47 = utils.deepClone(basicBid); goodBid47.video.durationSeconds = 47; testRoundingForGoodBId(goodBid47, 45); }); @@ -1096,11 +1096,11 @@ describe('adpod.js', function () { expect(logWarnStub.called).to.equal(true); } - let badBid100 = utils.deepClone(basicBid); + const badBid100 = utils.deepClone(basicBid); badBid100.video.durationSeconds = 100; testRoundingForBadBid(badBid100); - let badBid48 = utils.deepClone(basicBid); + const badBid48 = utils.deepClone(basicBid); badBid48.video.durationSeconds = 48; testRoundingForBadBid(badBid48); }); @@ -1149,7 +1149,7 @@ describe('adpod.js', function () { describe('adpod utils', function() { it('should sort bids array', function() { - let bids = [{ + const bids = [{ cpm: 10.12345, adserverTargeting: { hb_pb: '10.00', @@ -1191,7 +1191,7 @@ describe('adpod.js', function () { } }] bids.sort(sortByPricePerSecond); - let sortedBids = [{ + const sortedBids = [{ cpm: 15, adserverTargeting: { hb_pb: '15.00', diff --git a/test/spec/modules/adponeBidAdapter_spec.js b/test/spec/modules/adponeBidAdapter_spec.js index 92fd672df47..f28eecdd6a8 100644 --- a/test/spec/modules/adponeBidAdapter_spec.js +++ b/test/spec/modules/adponeBidAdapter_spec.js @@ -5,7 +5,7 @@ import * as utils from 'src/utils.js'; const EMPTY_ARRAY = []; describe('adponeBidAdapter', function () { - let bid = { + const bid = { bidder: 'adpone', adUnitCode: 'adunit-code', sizes: [[300, 250]], @@ -112,7 +112,7 @@ describe('adponeBidAdapter', function () { }); describe('interpretResponse', function () { let serverResponse; - let bidRequest = { data: {id: '1234'} }; + const bidRequest = { data: {id: '1234'} }; beforeEach(function () { serverResponse = { @@ -194,7 +194,7 @@ describe('adponeBidAdapter', function () { }); it('should add responses if the cpm is valid', function () { serverResponse.body.seatbid[0].bid[0].price = 0.5; - let response = spec.interpretResponse(serverResponse, bidRequest); + const response = spec.interpretResponse(serverResponse, bidRequest); expect(response).to.not.deep.equal([]); }); }); diff --git a/test/spec/modules/adprimeBidAdapter_spec.js b/test/spec/modules/adprimeBidAdapter_spec.js index c185ef3c1ad..743f00b3478 100644 --- a/test/spec/modules/adprimeBidAdapter_spec.js +++ b/test/spec/modules/adprimeBidAdapter_spec.js @@ -132,7 +132,7 @@ describe('AdprimeBidAdapter', function () { }); it('Returns general data valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys('deviceWidth', 'deviceHeight', @@ -202,7 +202,7 @@ describe('AdprimeBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { delete bidderRequest.uspConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('object'); expect(data.gdpr).to.have.property('consentString'); @@ -216,7 +216,7 @@ describe('AdprimeBidAdapter', function () { bidderRequest.uspConsent = '1---'; delete bidderRequest.gdprConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -231,8 +231,8 @@ describe('AdprimeBidAdapter', function () { applicableSections: [8] }; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -246,8 +246,8 @@ describe('AdprimeBidAdapter', function () { bidderRequest.ortb2.regs.gpp = 'abc123'; bidderRequest.ortb2.regs.gpp_sid = [8]; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -277,9 +277,9 @@ describe('AdprimeBidAdapter', function () { } }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(banner.body[0].requestId); @@ -311,10 +311,10 @@ describe('AdprimeBidAdapter', function () { } }] }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -348,10 +348,10 @@ describe('AdprimeBidAdapter', function () { } }] }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys('requestId', 'cpm', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'native', 'meta'); expect(dataItem.native).to.have.keys('clickUrl', 'impressionTrackers', 'title', 'image') expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -382,7 +382,7 @@ describe('AdprimeBidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -398,7 +398,7 @@ describe('AdprimeBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -415,7 +415,7 @@ describe('AdprimeBidAdapter', function () { currency: 'USD', }] }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -428,7 +428,7 @@ describe('AdprimeBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/adqueryBidAdapter_spec.js b/test/spec/modules/adqueryBidAdapter_spec.js index b4aa0992732..53a4ab505c3 100644 --- a/test/spec/modules/adqueryBidAdapter_spec.js +++ b/test/spec/modules/adqueryBidAdapter_spec.js @@ -5,7 +5,7 @@ import * as utils from '../../../src/utils'; describe('adqueryBidAdapter', function () { const adapter = newBidder(spec) - let bidRequest = { + const bidRequest = { bidder: 'adquery', params: { placementId: '6d93f2a0e5f0fe2cc3a6e9e3ade964b43b07f897', @@ -18,7 +18,7 @@ describe('adqueryBidAdapter', function () { } } - let expectedResponse = { + const expectedResponse = { 'body': { 'data': { @@ -61,7 +61,7 @@ describe('adqueryBidAdapter', function () { }) describe('isBidRequestValid', function () { - let inValidBid = Object.assign({}, bidRequest) + const inValidBid = Object.assign({}, bidRequest) delete inValidBid.params it('should return true if all params present', function () { expect(spec.isBidRequestValid(bidRequest)).to.equal(true) @@ -136,7 +136,7 @@ describe('adqueryBidAdapter', function () { describe('interpretResponse', function () { it('should get the correct bid response', function () { - let result = spec.interpretResponse(expectedResponse) + const result = spec.interpretResponse(expectedResponse) expect(result).to.be.an('array') }) @@ -145,17 +145,17 @@ describe('adqueryBidAdapter', function () { expect(newResponse[0].requestId).to.be.equal(1) }); it('handles empty bid response', function () { - let response = { + const response = { body: {} }; - let result = spec.interpretResponse(response); + const result = spec.interpretResponse(response); expect(result.length).to.equal(0); }) }) describe('getUserSyncs', function () { it('should return iframe sync', function () { - let sync = spec.getUserSyncs( + const sync = spec.getUserSyncs( { iframeEnabled: true, pixelEnabled: true, @@ -172,7 +172,7 @@ describe('adqueryBidAdapter', function () { expect(typeof sync[0].url === 'string') }) it('should return image sync', function () { - let sync = spec.getUserSyncs( + const sync = spec.getUserSyncs( { iframeEnabled: false, pixelEnabled: true, diff --git a/test/spec/modules/adrelevantisBidAdapter_spec.js b/test/spec/modules/adrelevantisBidAdapter_spec.js index db637663f39..eb7d81dbd5f 100644 --- a/test/spec/modules/adrelevantisBidAdapter_spec.js +++ b/test/spec/modules/adrelevantisBidAdapter_spec.js @@ -17,7 +17,7 @@ describe('AdrelevantisAdapter', function () { }); describe('isBidRequestValid', function () { - let bid = { + const bid = { 'bidder': 'adrelevantis', 'params': { 'placementId': '10433394' @@ -34,7 +34,7 @@ describe('AdrelevantisAdapter', function () { }); it('should return false when required params are not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = { 'placementId': 0 @@ -44,7 +44,7 @@ describe('AdrelevantisAdapter', function () { }); describe('buildRequests', function () { - let bidRequests = [ + const bidRequests = [ { 'bidder': 'adrelevantis', 'params': { @@ -59,7 +59,7 @@ describe('AdrelevantisAdapter', function () { ]; it('should parse out private sizes', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { @@ -117,7 +117,7 @@ describe('AdrelevantisAdapter', function () { }); it('should attach valid video params to the tag', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { @@ -182,7 +182,7 @@ describe('AdrelevantisAdapter', function () { }); it('should attach valid user params to the tag', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { @@ -205,7 +205,7 @@ describe('AdrelevantisAdapter', function () { }); it('should contain hb_source value for other media', function() { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { mediaType: 'banner', @@ -221,7 +221,7 @@ describe('AdrelevantisAdapter', function () { }); it('adds context data (category and keywords) to request when set', function() { - let bidRequest = Object.assign({}, bidRequests[0]); + const bidRequest = Object.assign({}, bidRequests[0]); const ortb2 = { site: { keywords: 'US Open', @@ -239,7 +239,7 @@ describe('AdrelevantisAdapter', function () { }); it('should attach native params to the request', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { mediaType: 'native', @@ -290,7 +290,7 @@ describe('AdrelevantisAdapter', function () { }); it('should always populated tags[].sizes with 1,1 for native if otherwise not defined', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { mediaType: 'native', @@ -314,7 +314,7 @@ describe('AdrelevantisAdapter', function () { }); it('should convert keyword params to proper form and attaches to request', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { @@ -359,7 +359,7 @@ describe('AdrelevantisAdapter', function () { }); it('should add payment rules to the request', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { @@ -376,8 +376,8 @@ describe('AdrelevantisAdapter', function () { }); it('should add gdpr consent information to the request', function () { - let consentString = 'BOJ8RZsOJ8RZsABAB8AAAAAZ+A=='; - let bidderRequest = { + const consentString = 'BOJ8RZsOJ8RZsABAB8AAAAAZ+A=='; + const bidderRequest = { 'bidderCode': 'adrelevantis', 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', @@ -398,7 +398,7 @@ describe('AdrelevantisAdapter', function () { }); it('supports sending hybrid mobile app parameters', function () { - let appRequest = Object.assign({}, + const appRequest = Object.assign({}, bidRequests[0], { params: { @@ -468,7 +468,7 @@ describe('AdrelevantisAdapter', function () { }); it('should populate coppa if set in config', function () { - let bidRequest = Object.assign({}, bidRequests[0]); + const bidRequest = Object.assign({}, bidRequests[0]); sinon.stub(config, 'getConfig') .withArgs('coppa') .returns(true); @@ -483,7 +483,7 @@ describe('AdrelevantisAdapter', function () { }) describe('interpretResponse', function () { - let response = { + const response = { 'version': '3.0.0', 'tags': [ { @@ -531,7 +531,7 @@ describe('AdrelevantisAdapter', function () { }; it('should get correct bid response', function () { - let expectedResponse = [ + const expectedResponse = [ { 'requestId': '3db3773286ee59', 'cpm': 0.5, @@ -550,18 +550,18 @@ describe('AdrelevantisAdapter', function () { } } ]; - let bidderRequest = { + const bidderRequest = { bids: [{ bidId: '3db3773286ee59', adUnitCode: 'code' }] } - let result = spec.interpretResponse({ body: response }, {bidderRequest}); + const result = spec.interpretResponse({ body: response }, {bidderRequest}); expect(Object.keys(result[0])).to.have.members(Object.keys(expectedResponse[0])); }); it('handles nobid responses', function () { - let response = { + const response = { 'version': '0.0.1', 'tags': [{ 'uuid': '84ab500420319d', @@ -572,12 +572,12 @@ describe('AdrelevantisAdapter', function () { }; let bidderRequest; - let result = spec.interpretResponse({ body: response }, {bidderRequest}); + const result = spec.interpretResponse({ body: response }, {bidderRequest}); expect(result.length).to.equal(0); }); it('handles outstream video responses', function () { - let response = { + const response = { 'tags': [{ 'uuid': '84ab500420319d', 'ads': [{ @@ -593,7 +593,7 @@ describe('AdrelevantisAdapter', function () { }] }] }; - let bidderRequest = { + const bidderRequest = { bids: [{ bidId: '84ab500420319d', adUnitCode: 'code', @@ -605,14 +605,14 @@ describe('AdrelevantisAdapter', function () { }] } - let result = spec.interpretResponse({ body: response }, {bidderRequest}); + const result = spec.interpretResponse({ body: response }, {bidderRequest}); expect(result[0]).to.have.property('vastXml'); expect(result[0]).to.have.property('vastImpUrl'); expect(result[0]).to.have.property('mediaType', 'video'); }); it('handles instream video responses', function () { - let response = { + const response = { 'tags': [{ 'uuid': '84ab500420319d', 'ads': [{ @@ -628,7 +628,7 @@ describe('AdrelevantisAdapter', function () { }] }] }; - let bidderRequest = { + const bidderRequest = { bids: [{ bidId: '84ab500420319d', adUnitCode: 'code', @@ -640,14 +640,14 @@ describe('AdrelevantisAdapter', function () { }] } - let result = spec.interpretResponse({ body: response }, {bidderRequest}); + const result = spec.interpretResponse({ body: response }, {bidderRequest}); expect(result[0]).to.have.property('vastUrl'); expect(result[0]).to.have.property('vastImpUrl'); expect(result[0]).to.have.property('mediaType', 'video'); }); it('handles native responses', function () { - let response1 = deepClone(response); + const response1 = deepClone(response); response1.tags[0].ads[0].ad_type = 'native'; response1.tags[0].ads[0].rtb.native = { 'title': 'Native Creative', @@ -682,14 +682,14 @@ describe('AdrelevantisAdapter', function () { 'privacy_link': 'https://appnexus.com/?url=privacy_url', 'javascriptTrackers': '' }; - let bidderRequest = { + const bidderRequest = { bids: [{ bidId: '3db3773286ee59', adUnitCode: 'code' }] } - let result = spec.interpretResponse({ body: response1 }, {bidderRequest}); + const result = spec.interpretResponse({ body: response1 }, {bidderRequest}); expect(result[0].native.title).to.equal('Native Creative'); expect(result[0].native.body).to.equal('Cool description great stuff'); expect(result[0].native.cta).to.equal('Do it'); @@ -724,31 +724,31 @@ describe('AdrelevantisAdapter', function () { }); it('should add deal_priority and deal_code', function() { - let responseWithDeal = deepClone(response); + const responseWithDeal = deepClone(response); responseWithDeal.tags[0].ads[0].deal_priority = 'high'; responseWithDeal.tags[0].ads[0].deal_code = '123'; - let bidderRequest = { + const bidderRequest = { bids: [{ bidId: '3db3773286ee59', adUnitCode: 'code' }] } - let result = spec.interpretResponse({ body: responseWithDeal }, {bidderRequest}); + const result = spec.interpretResponse({ body: responseWithDeal }, {bidderRequest}); expect(Object.keys(result[0].adrelevantis)).to.include.members(['buyerMemberId', 'dealPriority', 'dealCode']); }); it('should add advertiser id', function() { - let responseAdvertiserId = deepClone(response); + const responseAdvertiserId = deepClone(response); responseAdvertiserId.tags[0].ads[0].advertiser_id = '123'; - let bidderRequest = { + const bidderRequest = { bids: [{ bidId: '3db3773286ee59', adUnitCode: 'code' }] } - let result = spec.interpretResponse({ body: responseAdvertiserId }, {bidderRequest}); + const result = spec.interpretResponse({ body: responseAdvertiserId }, {bidderRequest}); expect(Object.keys(result[0].meta)).to.include.members(['advertiserId']); }) }); diff --git a/test/spec/modules/adriverBidAdapter_spec.js b/test/spec/modules/adriverBidAdapter_spec.js index 94202e96dea..75c786c07eb 100644 --- a/test/spec/modules/adriverBidAdapter_spec.js +++ b/test/spec/modules/adriverBidAdapter_spec.js @@ -220,7 +220,7 @@ describe('adriverAdapter', function () { 'start': 1622465003762 }; - let floorTestData = { + const floorTestData = { 'currency': 'USD', 'floor': floor }; @@ -297,7 +297,7 @@ describe('adriverAdapter', function () { { adrcid: undefined } ] cookieValues.forEach(cookieValue => describe('test cookie exist or not behavior', function () { - let expectedValues = [ + const expectedValues = [ 'buyerid', 'ext' ] @@ -321,7 +321,7 @@ describe('adriverAdapter', function () { }); describe('interpretResponse', function () { - let response = { + const response = { 'id': '221594457-1615288400-1-46-', 'bidid': 'D8JW8XU8-L5m7qFMNQGs7i1gcuPvYMEDOKsktw6e9uLy5Eebo9HftVXb0VpKj4R2dXa93i6QmRhjextJVM4y1SqodMAh5vFOb_eVkHA', 'seatbid': [{ @@ -355,7 +355,7 @@ describe('adriverAdapter', function () { }; it('should get correct bid response', function () { - let expectedResponse = [ + const expectedResponse = [ { requestId: '2c262a7058758d', cpm: 4.29, @@ -371,18 +371,18 @@ describe('adriverAdapter', function () { ad: '' } ]; - let bidderRequest = { + const bidderRequest = { bids: [{ bidId: '3db3773286ee59', adUnitCode: 'code' }] }; - let result = spec.interpretResponse({ body: response }, {bidderRequest}); + const result = spec.interpretResponse({ body: response }, {bidderRequest}); expect(Object.keys(result[0])).to.have.members(Object.keys(expectedResponse[0])); }); it('handles nobid responses', function () { - let response = { + const response = { 'version': '0.0.1', 'tags': [{ 'uuid': '84ab500420319d', @@ -393,13 +393,13 @@ describe('adriverAdapter', function () { }; let bidderRequest; - let result = spec.interpretResponse({ body: response }, {bidderRequest}); + const result = spec.interpretResponse({ body: response }, {bidderRequest}); expect(result.length).to.equal(0); }); }); describe('function _getFloor', function () { - let bidRequests = [ + const bidRequests = [ { bidder: 'adriver', params: { @@ -539,7 +539,7 @@ describe('adriverAdapter', function () { }); describe('user ids', function () { - let bidRequests = [ + const bidRequests = [ { bidder: 'adriver', params: { diff --git a/test/spec/modules/adriverIdSystem_spec.js b/test/spec/modules/adriverIdSystem_spec.js index abc831b67f0..bf73a42b1b1 100644 --- a/test/spec/modules/adriverIdSystem_spec.js +++ b/test/spec/modules/adriverIdSystem_spec.js @@ -63,10 +63,10 @@ describe('AdriverIdSystem', function () { expect(id).to.be.deep.equal(response.adrcid ? response.adrcid : undefined); }); - let request = server.requests[0]; + const request = server.requests[0]; request.respond(200, { 'Content-Type': 'application/json' }, JSON.stringify({ adrcid: response.adrcid })); - let expectedExpiration = new Date(); + const expectedExpiration = new Date(); expectedExpiration.setTime(expectedExpiration.getTime() + 86400 * 1825 * 1000); const minimalDate = new Date(0).toString(); diff --git a/test/spec/modules/ads_interactiveBidAdapter_spec.js b/test/spec/modules/ads_interactiveBidAdapter_spec.js index a0b8c67af93..d43165f9535 100644 --- a/test/spec/modules/ads_interactiveBidAdapter_spec.js +++ b/test/spec/modules/ads_interactiveBidAdapter_spec.js @@ -132,7 +132,7 @@ describe('AdsInteractiveBidAdapter', function () { }); it('Returns general data valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.include.all.keys( 'deviceWidth', @@ -213,7 +213,7 @@ describe('AdsInteractiveBidAdapter', function () { } ]; - let serverRequest = spec.buildRequests(bids, bidderRequest); + const serverRequest = spec.buildRequests(bids, bidderRequest); const { placements } = serverRequest.data; for (let i = 0, len = placements.length; i < len; i++) { @@ -248,7 +248,7 @@ describe('AdsInteractiveBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { delete bidderRequest.uspConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('object'); expect(data.gdpr).to.have.property('consentString'); @@ -262,7 +262,7 @@ describe('AdsInteractiveBidAdapter', function () { bidderRequest.uspConsent = '1---'; delete bidderRequest.gdprConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -277,8 +277,8 @@ describe('AdsInteractiveBidAdapter', function () { applicableSections: [8] }; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -292,8 +292,8 @@ describe('AdsInteractiveBidAdapter', function () { bidderRequest.ortb2.regs.gpp = 'abc123'; bidderRequest.ortb2.regs.gpp_sid = [8]; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -323,9 +323,9 @@ describe('AdsInteractiveBidAdapter', function () { } }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(banner.body[0].requestId); @@ -357,10 +357,10 @@ describe('AdsInteractiveBidAdapter', function () { } }] }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -394,10 +394,10 @@ describe('AdsInteractiveBidAdapter', function () { } }] }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys('requestId', 'cpm', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'native', 'meta'); expect(dataItem.native).to.have.keys('clickUrl', 'impressionTrackers', 'title', 'image') expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -428,7 +428,7 @@ describe('AdsInteractiveBidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -444,7 +444,7 @@ describe('AdsInteractiveBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -461,7 +461,7 @@ describe('AdsInteractiveBidAdapter', function () { currency: 'USD', }] }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -474,7 +474,7 @@ describe('AdsInteractiveBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/adstirBidAdapter_spec.js b/test/spec/modules/adstirBidAdapter_spec.js index cbcb4ea0511..d7f8efc3c88 100644 --- a/test/spec/modules/adstirBidAdapter_spec.js +++ b/test/spec/modules/adstirBidAdapter_spec.js @@ -199,7 +199,7 @@ describe('AdstirAdapter', function () { }); it('when config.pageUrl is not set, ref.topurl equals to refererInfo.reachedTop', function () { - let bidderRequestClone = utils.deepClone(bidderRequest); + const bidderRequestClone = utils.deepClone(bidderRequest); [true, false].forEach(function (reachedTop) { bidderRequestClone.refererInfo.reachedTop = reachedTop; const requests = spec.buildRequests(validBidRequests, bidderRequestClone); @@ -217,7 +217,7 @@ describe('AdstirAdapter', function () { }); it('ref.topurl should be false', function () { - let bidderRequestClone = utils.deepClone(bidderRequest); + const bidderRequestClone = utils.deepClone(bidderRequest); [true, false].forEach(function (reachedTop) { bidderRequestClone.refererInfo.reachedTop = reachedTop; const requests = spec.buildRequests(validBidRequests, bidderRequestClone); @@ -228,7 +228,7 @@ describe('AdstirAdapter', function () { }); it('gdprConsent.gdprApplies is sent', function () { - let bidderRequestClone = utils.deepClone(bidderRequest); + const bidderRequestClone = utils.deepClone(bidderRequest); [true, false].forEach(function (gdprApplies) { bidderRequestClone.gdprConsent = { gdprApplies }; const requests = spec.buildRequests(validBidRequests, bidderRequestClone); @@ -238,7 +238,7 @@ describe('AdstirAdapter', function () { }); it('includes in the request parameters whether CCPA applies', function () { - let bidderRequestClone = utils.deepClone(bidderRequest); + const bidderRequestClone = utils.deepClone(bidderRequest); const cases = [ { uspConsent: '1---', expected: false }, { uspConsent: '1YYY', expected: true }, diff --git a/test/spec/modules/adtargetBidAdapter_spec.js b/test/spec/modules/adtargetBidAdapter_spec.js index fe4752bec5a..ceaf51f9e7e 100644 --- a/test/spec/modules/adtargetBidAdapter_spec.js +++ b/test/spec/modules/adtargetBidAdapter_spec.js @@ -201,16 +201,16 @@ describe('adtargetBidAdapter', () => { }); it('should return false when required params are not passed', () => { - let bid = Object.assign({}, VIDEO_REQUEST); + const bid = Object.assign({}, VIDEO_REQUEST); delete bid.params; expect(spec.isBidRequestValid(bid)).to.equal(false); }); }); describe('buildRequests', () => { - let videoBidRequests = [VIDEO_REQUEST]; - let displayBidRequests = [DISPLAY_REQUEST]; - let videoAndDisplayBidRequests = [DISPLAY_REQUEST, VIDEO_REQUEST]; + const videoBidRequests = [VIDEO_REQUEST]; + const displayBidRequests = [DISPLAY_REQUEST]; + const videoAndDisplayBidRequests = [DISPLAY_REQUEST, VIDEO_REQUEST]; const displayRequest = spec.buildRequests(displayBidRequests, {}); const videoRequest = spec.buildRequests(videoBidRequests, {}); const videoAndDisplayRequests = spec.buildRequests(videoAndDisplayBidRequests, {}); diff --git a/test/spec/modules/adtelligentBidAdapter_spec.js b/test/spec/modules/adtelligentBidAdapter_spec.js index dc861c1def8..18395daf017 100644 --- a/test/spec/modules/adtelligentBidAdapter_spec.js +++ b/test/spec/modules/adtelligentBidAdapter_spec.js @@ -267,16 +267,16 @@ describe('adtelligentBidAdapter', () => { }); it('should return false when required params are not passed', () => { - let bid = Object.assign({}, VIDEO_REQUEST); + const bid = Object.assign({}, VIDEO_REQUEST); delete bid.params; expect(spec.isBidRequestValid(bid)).to.equal(false); }); }); describe('buildRequests', () => { - let videoBidRequests = [VIDEO_REQUEST]; - let displayBidRequests = [DISPLAY_REQUEST]; - let videoAndDisplayBidRequests = [DISPLAY_REQUEST, VIDEO_REQUEST]; + const videoBidRequests = [VIDEO_REQUEST]; + const displayBidRequests = [DISPLAY_REQUEST]; + const videoAndDisplayBidRequests = [DISPLAY_REQUEST, VIDEO_REQUEST]; const displayRequest = spec.buildRequests(displayBidRequests, DEFAULT_ADATPER_REQ); const videoRequest = spec.buildRequests(videoBidRequests, DEFAULT_ADATPER_REQ); const videoAndDisplayRequests = spec.buildRequests(videoAndDisplayBidRequests, DEFAULT_ADATPER_REQ); diff --git a/test/spec/modules/adtrgtmeBidAdapter_spec.js b/test/spec/modules/adtrgtmeBidAdapter_spec.js index fb72f18ee6d..31b5c3eac86 100644 --- a/test/spec/modules/adtrgtmeBidAdapter_spec.js +++ b/test/spec/modules/adtrgtmeBidAdapter_spec.js @@ -35,7 +35,7 @@ const createBidRequest = ({bidId, adUnitCode, bidOverride, zid, ortb2}) => { return bR; } -let createBidderRequest = (arr, code = 'default-code', ortb2 = {}) => { +const createBidderRequest = (arr, code = 'default-code', ortb2 = {}) => { return { adUnitCode: code, auctionId: 'd4c83a3b-18e4-4208-b98b-63848449c7aa', @@ -144,20 +144,20 @@ describe('Adtrgtme Bid Adapter:', () => { }); it('sync check bad url and type in pixels', () => { - let opt = { + const opt = { iframeEnabled: true, pixelEnabled: true }; - let pixels = spec.getUserSyncs(opt, sRs); + const pixels = spec.getUserSyncs(opt, sRs); expect(pixels.length).to.equal(3); }); it('sync check for iframe only', () => { - let opt = { + const opt = { iframeEnabled: true, pixelEnabled: false }; - let pixels = spec.getUserSyncs(opt, sRs); + const pixels = spec.getUserSyncs(opt, sRs); expect(pixels.length).to.equal(2); expect(pixels).to.deep.equal( [ @@ -168,11 +168,11 @@ describe('Adtrgtme Bid Adapter:', () => { }); it('sync check for image only', () => { - let opt = { + const opt = { iframeEnabled: false, pixelEnabled: true }; - let pixels = spec.getUserSyncs(opt, sRs); + const pixels = spec.getUserSyncs(opt, sRs); expect(pixels.length).to.equal(1); expect(pixels).to.deep.equal( [ @@ -182,11 +182,11 @@ describe('Adtrgtme Bid Adapter:', () => { }); it('Sync for iframe and image', () => { - let opt = { + const opt = { iframeEnabled: true, pixelEnabled: true }; - let pixels = spec.getUserSyncs(opt, sRs); + const pixels = spec.getUserSyncs(opt, sRs); expect(pixels.length).to.equal(3); expect(pixels).to.deep.equal( [ @@ -400,7 +400,7 @@ describe('Adtrgtme Bid Adapter:', () => { }); it(`should allow adUnit.ortb2Imp.ext.data object to be added to the bid request`, () => { - let { validBR, bidderRequest } = createRequestMock({}) + const { validBR, bidderRequest } = createRequestMock({}) validBR[0].ortb2Imp = { ext: { data: { @@ -413,7 +413,7 @@ describe('Adtrgtme Bid Adapter:', () => { expect(data.imp[0].ext.data).to.deep.equal(validBR[0].ortb2Imp.ext.data); }); it(`should allow adUnit.ortb2Imp.instl numeric boolean "1" to be added to the bid request`, () => { - let { validBR, bidderRequest } = createRequestMock({}) + const { validBR, bidderRequest } = createRequestMock({}) validBR[0].ortb2Imp = { instl: 1 }; @@ -422,7 +422,7 @@ describe('Adtrgtme Bid Adapter:', () => { }); it(`should prevent adUnit.ortb2Imp.instl boolean "true" to be added to the bid request`, () => { - let { validBR, bidderRequest } = createRequestMock({}) + const { validBR, bidderRequest } = createRequestMock({}) validBR[0].ortb2Imp = { instl: true }; @@ -431,7 +431,7 @@ describe('Adtrgtme Bid Adapter:', () => { }); it(`should prevent adUnit.ortb2Imp.instl boolean false to be added to the bid request`, () => { - let { validBR, bidderRequest } = createRequestMock({}) + const { validBR, bidderRequest } = createRequestMock({}) validBR[0].ortb2Imp = { instl: false }; @@ -526,7 +526,7 @@ describe('Adtrgtme Bid Adapter:', () => { describe('validate request filtering:', () => { it('should return undefined when no bids', function () { - let request = spec.buildRequests([]); + const request = spec.buildRequests([]); expect(request).to.be.undefined; }); @@ -582,14 +582,14 @@ describe('Adtrgtme Bid Adapter:', () => { }); it('should use siteId value as site.id', () => { - let { validBR, bidderRequest } = createRequestMock({pubIdMode: true}); + const { validBR, bidderRequest } = createRequestMock({pubIdMode: true}); validBR[0].params.sid = '9876543210'; const data = spec.buildRequests(validBR, bidderRequest).data; expect(data.site.id).to.equal('9876543210'); }); it('should use placementId value as imp.tagid when using "zid"', () => { - let { validBR, bidderRequest } = createRequestMock({}), + const { validBR, bidderRequest } = createRequestMock({}), TEST_ZID = '54321'; validBR[0].params.zid = TEST_ZID; const data = spec.buildRequests(validBR, bidderRequest).data; diff --git a/test/spec/modules/adtrueBidAdapter_spec.js b/test/spec/modules/adtrueBidAdapter_spec.js index 65159c72a11..ca74c4016c6 100644 --- a/test/spec/modules/adtrueBidAdapter_spec.js +++ b/test/spec/modules/adtrueBidAdapter_spec.js @@ -156,7 +156,7 @@ describe('AdTrueBidAdapter', function () { describe('implementation', function () { describe('Bid validations', function () { it('valid bid case', function () { - let validBid = { + const validBid = { bidder: 'adtrue', params: { zoneId: '21423', @@ -167,7 +167,7 @@ describe('AdTrueBidAdapter', function () { expect(isValid).to.equal(true); }); it('invalid bid case: publisherId not passed', function () { - let validBid = { + const validBid = { bidder: 'adtrue', params: { zoneId: '21423' @@ -177,7 +177,7 @@ describe('AdTrueBidAdapter', function () { expect(isValid).to.equal(false); }); it('valid bid case: zoneId is not passed', function () { - let validBid = { + const validBid = { bidder: 'adtrue', params: { publisherId: '1212' @@ -259,15 +259,15 @@ describe('AdTrueBidAdapter', function () { }); describe('Request formation', function () { it('buildRequests function should not modify original bidRequests object', function () { - let originalBidRequests = utils.deepClone(bidRequests); - let request = spec.buildRequests(bidRequests, { + const originalBidRequests = utils.deepClone(bidRequests); + const request = spec.buildRequests(bidRequests, { auctionId: 'new-auction-id' }); expect(bidRequests).to.deep.equal(originalBidRequests); }); it('Endpoint/method checking', function () { - let request = spec.buildRequests(bidRequests, { + const request = spec.buildRequests(bidRequests, { auctionId: 'new-auction-id' }); expect(request.url).to.equal('https://hb.adtrue.com/prebid/auction'); @@ -275,17 +275,17 @@ describe('AdTrueBidAdapter', function () { }); it('test flag not sent when adtrueTest=true is absent in page url', function () { - let request = spec.buildRequests(bidRequests, { + const request = spec.buildRequests(bidRequests, { auctionId: 'new-auction-id' }); - let data = JSON.parse(request.data); + const data = JSON.parse(request.data); expect(data.test).to.equal(undefined); }); it('Request params check', function () { - let request = spec.buildRequests(bidRequests, { + const request = spec.buildRequests(bidRequests, { auctionId: 'new-auction-id' }); - let data = JSON.parse(request.data); + const data = JSON.parse(request.data); expect(data.at).to.equal(1); // auction type expect(data.cur[0]).to.equal('USD'); // currency expect(data.site.domain).to.be.a('string'); // domain should be set @@ -300,14 +300,14 @@ describe('AdTrueBidAdapter', function () { expect(data.source.ext.schain).to.deep.equal(bidRequests[0].ortb2.source.ext.schain); }); it('Request params check with GDPR Consent', function () { - let bidRequest = { + const bidRequest = { gdprConsent: { consentString: 'kjfdniwjnifwenrif3', gdprApplies: true } }; - let request = spec.buildRequests(bidRequests, bidRequest); - let data = JSON.parse(request.data); + const request = spec.buildRequests(bidRequests, bidRequest); + const data = JSON.parse(request.data); expect(data.user.ext.consent).to.equal('kjfdniwjnifwenrif3'); expect(data.at).to.equal(1); // auction type expect(data.cur[0]).to.equal('USD'); // currency @@ -323,11 +323,11 @@ describe('AdTrueBidAdapter', function () { expect(data.source.ext.schain).to.deep.equal(bidRequests[0].ortb2.source.ext.schain); }); it('Request params check with USP/CCPA Consent', function () { - let bidRequest = { + const bidRequest = { uspConsent: '1NYN' }; - let request = spec.buildRequests(bidRequests, bidRequest); - let data = JSON.parse(request.data); + const request = spec.buildRequests(bidRequests, bidRequest); + const data = JSON.parse(request.data); expect(data.regs.ext.us_privacy).to.equal('1NYN');// USP/CCPAs expect(data.at).to.equal(1); // auction type expect(data.cur[0]).to.equal('USD'); // currency @@ -345,7 +345,7 @@ describe('AdTrueBidAdapter', function () { it('should NOT include coppa flag in bid request if coppa config is not present', () => { const request = spec.buildRequests(bidRequests, {}); - let data = JSON.parse(request.data); + const data = JSON.parse(request.data); if (data.regs) { // in case GDPR is set then data.regs will exist expect(data.regs.coppa).to.equal(undefined); @@ -354,7 +354,7 @@ describe('AdTrueBidAdapter', function () { } }); it('should include coppa flag in bid request if coppa is set to true', () => { - let sandbox = sinon.createSandbox(); + const sandbox = sinon.createSandbox(); sandbox.stub(config, 'getConfig').callsFake(key => { const config = { 'coppa': true @@ -362,12 +362,12 @@ describe('AdTrueBidAdapter', function () { return config[key]; }); const request = spec.buildRequests(bidRequests, {}); - let data = JSON.parse(request.data); + const data = JSON.parse(request.data); expect(data.regs.coppa).to.equal(1); sandbox.restore(); }); it('should NOT include coppa flag in bid request if coppa is set to false', () => { - let sandbox = sinon.createSandbox(); + const sandbox = sinon.createSandbox(); sandbox.stub(config, 'getConfig').callsFake(key => { const config = { 'coppa': false @@ -375,7 +375,7 @@ describe('AdTrueBidAdapter', function () { return config[key]; }); const request = spec.buildRequests(bidRequests, {}); - let data = JSON.parse(request.data); + const data = JSON.parse(request.data); if (data.regs) { // in case GDPR is set then data.regs will exist expect(data.regs.coppa).to.equal(undefined); @@ -388,11 +388,11 @@ describe('AdTrueBidAdapter', function () { }); describe('Response checking', function () { it('should check for valid response values', function () { - let request = spec.buildRequests(bidRequests, { + const request = spec.buildRequests(bidRequests, { auctionId: 'new-auction-id' }); - let data = JSON.parse(request.data); - let response = spec.interpretResponse(bidResponses, request); + const data = JSON.parse(request.data); + const response = spec.interpretResponse(bidResponses, request); expect(response).to.be.an('array').with.length.above(0); expect(response[0].requestId).to.equal(bidResponses.body.seatbid[0].bid[0].impid); expect(response[0].width).to.equal(bidResponses.body.seatbid[0].bid[0].w); diff --git a/test/spec/modules/advRedAnalyticsAdapter_spec.js b/test/spec/modules/advRedAnalyticsAdapter_spec.js index c493710ab53..fd56126d1db 100644 --- a/test/spec/modules/advRedAnalyticsAdapter_spec.js +++ b/test/spec/modules/advRedAnalyticsAdapter_spec.js @@ -5,10 +5,10 @@ import {expectEvents} from '../../helpers/analytics.js'; import { EVENTS } from 'src/constants.js'; import sinon from 'sinon'; -let events = require('src/events'); +const events = require('src/events'); describe('AdvRed Analytics Adapter', function () { - let bidWonEvent = { + const bidWonEvent = { 'bidderCode': 'appnexus', 'width': 300, 'height': 250, @@ -45,7 +45,7 @@ describe('AdvRed Analytics Adapter', function () { }); it('support custom endpoint', function () { - let custom_endpoint = 'custom url'; + const custom_endpoint = 'custom url'; advRedAnalytics.enableAnalytics({ provider: 'advRed', options: { @@ -58,7 +58,7 @@ describe('AdvRed Analytics Adapter', function () { }); it('bid won event', function() { - let publisherId = '1234567890'; + const publisherId = '1234567890'; advRedAnalytics.enableAnalytics({ provider: 'advRed', options: { diff --git a/test/spec/modules/advangelistsBidAdapter_spec.js b/test/spec/modules/advangelistsBidAdapter_spec.js index a8f8beb8e6e..7138d57231e 100755 --- a/test/spec/modules/advangelistsBidAdapter_spec.js +++ b/test/spec/modules/advangelistsBidAdapter_spec.js @@ -64,7 +64,7 @@ describe('advangelistsBidAdapter', function () { describe('spec.interpretResponse', function () { describe('for banner bids', function () { it('should return valid video bid responses', function () { - let _mediaTypes = VIDEO; + const _mediaTypes = VIDEO; const advangelistsbidreqVid = {'bidRequest': {'mediaTypes': {'video': {'w': 320, 'h': 480}}}}; const serverResponseVid = {'cur': 'USD', 'id': '25c6ab92aa0e81', 'seatbid': [{'seat': '3', 'bid': [{'crid': '1855', 'h': 480, 'protocol': 2, 'nurl': 'http://nep.advangelists.com/xp/evt?pp=1MO1wiaMhhq7wLRzZZwwwPkJxxKpYEnM5k5MH4qSGm1HR8rp3Nl7vDocvzZzSAvE4pnREL9mQ1kf5PDjk6E8em6DOk7vVrYUH1TYQyqCucd58PFpJNN7h30RXKHHFg3XaLuQ3PKfMuI1qZATBJ6WHcu875y0hqRdiewn0J4JsCYF53M27uwmcV0HnQxARQZZ72mPqrW95U6wgkZljziwKrICM3aBV07TU6YK5R5AyzJRuD6mtrQ2xtHlQ3jXVYKE5bvWFiUQd90t0jOGhPtYBNoOfP7uQ4ZZj4pyucxbr96orHe9PSOn9UpCSWArdx7s8lOfDpwOvbMuyGxynbStDWm38sDgd4bMHnIt762m5VMDNJfiUyX0vWzp05OsufJDVEaWhAM62i40lQZo7mWP4ipoOWLkmlaAzFIMsTcNaHAHiKKqGEOZLkCEhFNM0SLcvgN2HFRULOOIZvusq7TydOKxuXgCS91dLUDxDDDFUK83BFKlMkTxnCzkLbIR1bd9GKcr1TRryOrulyvRWAKAIhEsUzsc5QWFUhmI2dZ1eqnBQJ0c89TaPcnoaP2WipF68UgyiOstf2CBy0M34858tC5PmuQwQYwXscg6zyqDwR0i9MzGH4FkTyU5yeOlPcsA0ht6UcoCdFpHpumDrLUwAaxwGk1Nj8S6YlYYT5wNuTifDGbg22QKXzZBkUARiyVvgPn9nRtXnrd7WmiMYq596rya9RQj7LC0auQW8bHVQLEe49shsZDnAwZTWr4QuYKqgRGZcXteG7RVJe0ryBZezOq11ha9C0Lv0siNVBahOXE35Wzoq4c4BDaGpqvhaKN7pjeWLGlQR04ufWekwxiMWAvjmfgAfexBJ7HfbYNZpq__', 'adid': '61_1855', 'adomain': ['chevrolet.com'], 'price': 2, 'w': 320, 'iurl': 'https://daf37cpxaja7f.cloudfront.net/c61/creative_url_14922301369663_1.png', 'cat': ['IAB2'], 'id': '7f570b40-aca1-4806-8ea8-818ea679c82b_0', 'attr': [], 'impid': '0', 'cid': '61'}]}], 'bidid': '7f570b40-aca1-4806-8ea8-818ea679c82b'}; const bidResponseVid = spec.interpretResponse({ body: serverResponseVid }, advangelistsbidreqVid); @@ -87,7 +87,7 @@ describe('advangelistsBidAdapter', function () { it('should return valid banner bid responses', function () { const advangelistsbidreq = {bids: {}}; bidRequests.forEach(bid => { - let _mediaTypes = (bid.mediaTypes && bid.mediaTypes.video ? VIDEO : BANNER); + const _mediaTypes = (bid.mediaTypes && bid.mediaTypes.video ? VIDEO : BANNER); advangelistsbidreq.bids[bid.bidId] = {mediaTypes: _mediaTypes, w: _mediaTypes == BANNER ? bid.mediaTypes[_mediaTypes].sizes[0][0] : bid.mediaTypes[_mediaTypes].playerSize[0], h: _mediaTypes == BANNER ? bid.mediaTypes[_mediaTypes].sizes[0][1] : bid.mediaTypes[_mediaTypes].playerSize[1] diff --git a/test/spec/modules/advertisingBidAdapter_spec.js b/test/spec/modules/advertisingBidAdapter_spec.js index 8d85093ac4d..b8eba5d8a66 100644 --- a/test/spec/modules/advertisingBidAdapter_spec.js +++ b/test/spec/modules/advertisingBidAdapter_spec.js @@ -57,7 +57,7 @@ describe('advertisingBidAdapter ', function () { }); describe('impression type', function () { - let nonVideoReq = { + const nonVideoReq = { bidId: '9876abcd', sizes: [[300, 250], [300, 600]], params: { @@ -67,7 +67,7 @@ describe('advertisingBidAdapter ', function () { } }; - let bannerReq = { + const bannerReq = { bidId: '9876abcd', sizes: [[300, 250], [300, 600]], params: { @@ -88,7 +88,7 @@ describe('advertisingBidAdapter ', function () { }, }; - let videoReq = { + const videoReq = { bidId: '9876abcd', sizes: [[640, 480]], params: { @@ -115,7 +115,7 @@ describe('advertisingBidAdapter ', function () { }); }); describe('buildRequests', function () { - let validBidRequestVideo = { + const validBidRequestVideo = { bidder: 'advertising', params: { seatId: 'prebid', @@ -140,7 +140,7 @@ describe('advertisingBidAdapter ', function () { bidRequestsCount: 1 }; - let bidderRequestVideo = { + const bidderRequestVideo = { bidderCode: 'advertising', auctionId: 'VideoAuctionId124', bidderRequestId: '117954d20d7c9c', @@ -156,7 +156,7 @@ describe('advertisingBidAdapter ', function () { }; bidderRequestVideo.bids = validBidRequestVideo; - let expectedDataVideo1 = { + const expectedDataVideo1 = { id: 'v2624fabbb078e8-640x480', tagid: '1234', video: { @@ -167,7 +167,7 @@ describe('advertisingBidAdapter ', function () { } }; - let validBidRequest = { + const validBidRequest = { bidId: '9876abcd', sizes: [[300, 250], [300, 600]], params: { @@ -177,14 +177,14 @@ describe('advertisingBidAdapter ', function () { } }; - let bidderRequest = { + const bidderRequest = { bidderRequestId: 'xyz123', refererInfo: { referer: 'https://test.com/foo/bar' } }; - let bidderRequestWithTimeout = { + const bidderRequestWithTimeout = { auctionId: 'xyz123', refererInfo: { referer: 'https://test.com/foo/bar' @@ -192,7 +192,7 @@ describe('advertisingBidAdapter ', function () { timeout: 3000 }; - let bidderRequestWithUSPInExt = { + const bidderRequestWithUSPInExt = { bidderRequestId: 'xyz123', refererInfo: { referer: 'https://test.com/foo/bar' @@ -206,7 +206,7 @@ describe('advertisingBidAdapter ', function () { } }; - let bidderRequestWithUSPInRegs = { + const bidderRequestWithUSPInRegs = { bidderRequestId: 'xyz123', refererInfo: { referer: 'https://test.com/foo/bar' @@ -218,7 +218,7 @@ describe('advertisingBidAdapter ', function () { } }; - let bidderRequestWithUSPAndOthersInExt = { + const bidderRequestWithUSPAndOthersInExt = { bidderRequestId: 'xyz123', refererInfo: { referer: 'https://test.com/foo/bar' @@ -233,7 +233,7 @@ describe('advertisingBidAdapter ', function () { } }; - let validBidRequestWithUserIds = { + const validBidRequestWithUserIds = { bidId: '9876abcd', sizes: [[300, 250], [300, 600]], params: { @@ -269,7 +269,7 @@ describe('advertisingBidAdapter ', function () { ] }; - let expectedEids = [ + const expectedEids = [ { source: 'pubcid.org', uids: [{ @@ -296,7 +296,7 @@ describe('advertisingBidAdapter ', function () { } ]; - let expectedDataImp1 = { + const expectedDataImp1 = { banner: { format: [ { @@ -317,7 +317,7 @@ describe('advertisingBidAdapter ', function () { it('should return valid request when valid bids are used', function () { // banner test - let req = spec.buildRequests([validBidRequest], bidderRequest); + const req = spec.buildRequests([validBidRequest], bidderRequest); expect(req).be.an('object'); expect(req).to.have.property('method', 'POST'); expect(req).to.have.property('url'); @@ -327,7 +327,7 @@ describe('advertisingBidAdapter ', function () { expect(req.data.imp).to.eql([expectedDataImp1]); // video test - let reqVideo = spec.buildRequests([validBidRequestVideo], bidderRequestVideo); + const reqVideo = spec.buildRequests([validBidRequestVideo], bidderRequestVideo); expect(reqVideo).be.an('object'); expect(reqVideo).to.have.property('method', 'POST'); expect(reqVideo).to.have.property('url'); @@ -337,17 +337,17 @@ describe('advertisingBidAdapter ', function () { }); it('should return no tmax', function () { - let req = spec.buildRequests([validBidRequest], bidderRequest); + const req = spec.buildRequests([validBidRequest], bidderRequest); expect(req.data).to.not.have.property('tmax'); }); it('should return tmax equal to callback timeout', function () { - let req = spec.buildRequests([validBidRequest], bidderRequestWithTimeout); + const req = spec.buildRequests([validBidRequest], bidderRequestWithTimeout); expect(req.data.tmax).to.eql(bidderRequestWithTimeout.timeout); }); it('should return multiple bids when multiple valid requests with the same seatId are used', function () { - let secondBidRequest = { + const secondBidRequest = { bidId: 'foobar', sizes: [[300, 600]], params: { @@ -356,7 +356,7 @@ describe('advertisingBidAdapter ', function () { bidfloor: '0.50' } }; - let req = spec.buildRequests([validBidRequest, secondBidRequest], bidderRequest); + const req = spec.buildRequests([validBidRequest, secondBidRequest], bidderRequest); expect(req).to.exist.and.be.an('object'); expect(req).to.have.property('method', 'POST'); expect(req).to.have.property('url'); @@ -379,7 +379,7 @@ describe('advertisingBidAdapter ', function () { }); it('should return only first bid when different seatIds are used', function () { - let mismatchedSeatBidRequest = { + const mismatchedSeatBidRequest = { bidId: 'foobar', sizes: [[300, 250]], params: { @@ -388,7 +388,7 @@ describe('advertisingBidAdapter ', function () { bidfloor: '0.50' } }; - let req = spec.buildRequests([mismatchedSeatBidRequest, validBidRequest], bidderRequest); + const req = spec.buildRequests([mismatchedSeatBidRequest, validBidRequest], bidderRequest); expect(req).to.have.property('method', 'POST'); expect(req).to.have.property('url'); expect(req.url).to.contain('https://somethingelse.technoratimedia.com/openrtb/bids/somethingelse?'); @@ -412,7 +412,7 @@ describe('advertisingBidAdapter ', function () { }); it('should not use bidfloor when the value is not a number', function () { - let badFloorBidRequest = { + const badFloorBidRequest = { bidId: '9876abcd', sizes: [[300, 250]], params: { @@ -421,7 +421,7 @@ describe('advertisingBidAdapter ', function () { bidfloor: 'abcd' } }; - let req = spec.buildRequests([badFloorBidRequest], bidderRequest); + const req = spec.buildRequests([badFloorBidRequest], bidderRequest); expect(req).to.have.property('method', 'POST'); expect(req).to.have.property('url'); expect(req.url).to.contain('https://prebid.technoratimedia.com/openrtb/bids/prebid?src=pbjs%2F$prebid.version$'); @@ -444,7 +444,7 @@ describe('advertisingBidAdapter ', function () { }); it('should not use bidfloor when there is no value', function () { - let badFloorBidRequest = { + const badFloorBidRequest = { bidId: '9876abcd', sizes: [[300, 250]], params: { @@ -452,7 +452,7 @@ describe('advertisingBidAdapter ', function () { tagId: '1234' } }; - let req = spec.buildRequests([badFloorBidRequest], bidderRequest); + const req = spec.buildRequests([badFloorBidRequest], bidderRequest); expect(req).to.have.property('method', 'POST'); expect(req).to.have.property('url'); expect(req.url).to.contain('https://prebid.technoratimedia.com/openrtb/bids/prebid?src=pbjs%2F$prebid.version$'); @@ -475,7 +475,7 @@ describe('advertisingBidAdapter ', function () { }); it('should use the pos given by the bid request', function () { - let newPosBidRequest = { + const newPosBidRequest = { bidId: '9876abcd', sizes: [[300, 250]], params: { @@ -484,7 +484,7 @@ describe('advertisingBidAdapter ', function () { pos: 1 } }; - let req = spec.buildRequests([newPosBidRequest], bidderRequest); + const req = spec.buildRequests([newPosBidRequest], bidderRequest); expect(req).to.have.property('method', 'POST'); expect(req).to.have.property('url'); expect(req.url).to.contain('https://prebid.technoratimedia.com/openrtb/bids/prebid?src=pbjs%2F$prebid.version$'); @@ -507,7 +507,7 @@ describe('advertisingBidAdapter ', function () { }); it('should use the default pos if none in bid request', function () { - let newPosBidRequest = { + const newPosBidRequest = { bidId: '9876abcd', sizes: [[300, 250]], params: { @@ -515,7 +515,7 @@ describe('advertisingBidAdapter ', function () { tagId: '1234', } }; - let req = spec.buildRequests([newPosBidRequest], bidderRequest); + const req = spec.buildRequests([newPosBidRequest], bidderRequest); expect(req).to.have.property('method', 'POST'); expect(req).to.have.property('url'); expect(req.url).to.contain('https://prebid.technoratimedia.com/openrtb/bids/prebid?src=pbjs%2F$prebid.version$'); @@ -542,7 +542,7 @@ describe('advertisingBidAdapter ', function () { }); it('should return empty impression when there is no valid sizes in bidrequest', function () { - let validBidReqWithoutSize = { + const validBidReqWithoutSize = { bidId: '9876abcd', sizes: [], params: { @@ -552,7 +552,7 @@ describe('advertisingBidAdapter ', function () { } }; - let validBidReqInvalidSize = { + const validBidReqInvalidSize = { bidId: '9876abcd', sizes: [[300]], params: { @@ -562,7 +562,7 @@ describe('advertisingBidAdapter ', function () { } }; - let bidderRequest = { + const bidderRequest = { auctionId: 'xyz123', refererInfo: { referer: 'https://test.com/foo/bar' @@ -575,7 +575,7 @@ describe('advertisingBidAdapter ', function () { assert.isUndefined(req); }); it('should use all the video params in the impression request', function () { - let validBidRequestVideo = { + const validBidRequestVideo = { bidder: 'advertising', params: { seatId: 'prebid', @@ -607,7 +607,7 @@ describe('advertisingBidAdapter ', function () { bidRequestsCount: 1 }; - let req = spec.buildRequests([validBidRequestVideo], bidderRequest); + const req = spec.buildRequests([validBidRequestVideo], bidderRequest); expect(req).to.have.property('method', 'POST'); expect(req).to.have.property('url'); expect(req.url).to.contain('https://prebid.technoratimedia.com/openrtb/bids/prebid?src=pbjs%2F$prebid.version$'); @@ -633,7 +633,7 @@ describe('advertisingBidAdapter ', function () { ]); }); it('should move any video params in the mediaTypes object to params.video object', function () { - let validBidRequestVideo = { + const validBidRequestVideo = { bidder: 'advertising', params: { seatId: 'prebid', @@ -665,7 +665,7 @@ describe('advertisingBidAdapter ', function () { bidRequestsCount: 1 }; - let req = spec.buildRequests([validBidRequestVideo], bidderRequest); + const req = spec.buildRequests([validBidRequestVideo], bidderRequest); expect(req).to.have.property('method', 'POST'); expect(req).to.have.property('url'); expect(req.url).to.contain('https://prebid.technoratimedia.com/openrtb/bids/prebid?src=pbjs%2F$prebid.version$'); @@ -691,7 +691,7 @@ describe('advertisingBidAdapter ', function () { ]); }); it('should create params.video object if not present on bid request and move any video params in the mediaTypes object to it', function () { - let validBidRequestVideo = { + const validBidRequestVideo = { bidder: 'advertising', params: { seatId: 'prebid', @@ -717,7 +717,7 @@ describe('advertisingBidAdapter ', function () { bidRequestsCount: 1 }; - let req = spec.buildRequests([validBidRequestVideo], bidderRequest); + const req = spec.buildRequests([validBidRequestVideo], bidderRequest); expect(req.data.imp).to.eql([ { video: { @@ -735,7 +735,7 @@ describe('advertisingBidAdapter ', function () { ]); }); it('should have us_privacy string in regs instead of regs.ext bidder request', function () { - let req = spec.buildRequests([validBidRequest], bidderRequestWithUSPInExt); + const req = spec.buildRequests([validBidRequest], bidderRequestWithUSPInExt); expect(req).be.an('object'); expect(req).to.have.property('method', 'POST'); expect(req).to.have.property('url'); @@ -748,7 +748,7 @@ describe('advertisingBidAdapter ', function () { }); it('should accept us_privacy string in regs', function () { // banner test - let req = spec.buildRequests([validBidRequest], bidderRequestWithUSPInRegs); + const req = spec.buildRequests([validBidRequest], bidderRequestWithUSPInRegs); expect(req).be.an('object'); expect(req).to.have.property('method', 'POST'); expect(req).to.have.property('url'); @@ -761,7 +761,7 @@ describe('advertisingBidAdapter ', function () { }); it('should not remove regs.ext when moving us_privacy if there are other things in regs.ext', function () { // banner test - let req = spec.buildRequests([validBidRequest], bidderRequestWithUSPAndOthersInExt); + const req = spec.buildRequests([validBidRequest], bidderRequestWithUSPAndOthersInExt); expect(req).be.an('object'); expect(req).to.have.property('method', 'POST'); expect(req).to.have.property('url'); @@ -773,7 +773,7 @@ describe('advertisingBidAdapter ', function () { expect(req.data.imp).to.eql([expectedDataImp1]); }); it('should contain user object when user ids are present in the bidder request', function () { - let req = spec.buildRequests([validBidRequestWithUserIds], bidderRequest); + const req = spec.buildRequests([validBidRequestWithUserIds], bidderRequest); expect(req).be.an('object'); expect(req).to.have.property('method', 'POST'); expect(req).to.have.property('url'); @@ -789,7 +789,7 @@ describe('advertisingBidAdapter ', function () { }); describe('Bid Requests with placementId should be backward compatible ', function () { - let validVideoBidReq = { + const validVideoBidReq = { bidder: 'advertising', params: { seatId: 'prebid', @@ -818,7 +818,7 @@ describe('advertisingBidAdapter ', function () { bidderWinsCount: 0 }; - let validBannerBidRequest = { + const validBannerBidRequest = { bidId: '9876abcd', sizes: [[300, 250]], params: { @@ -827,7 +827,7 @@ describe('advertisingBidAdapter ', function () { } }; - let bidderRequest = { + const bidderRequest = { refererInfo: { referer: 'http://localhost:9999/' }, @@ -836,14 +836,14 @@ describe('advertisingBidAdapter ', function () { }; it('should return valid bid request for banner impression', function () { - let req = spec.buildRequests([validBannerBidRequest], bidderRequest); + const req = spec.buildRequests([validBannerBidRequest], bidderRequest); expect(req).to.have.property('method', 'POST'); expect(req).to.have.property('url'); expect(req.url).to.contain('//prebid.technoratimedia.com/openrtb/bids/prebid?src=pbjs%2F$prebid.version$'); }); it('should return valid bid request for video impression', function () { - let req = spec.buildRequests([validVideoBidReq], bidderRequest); + const req = spec.buildRequests([validVideoBidReq], bidderRequest); expect(req).to.have.property('method', 'POST'); expect(req).to.have.property('url'); expect(req.url).to.contain('//prebid.technoratimedia.com/openrtb/bids/prebid?src=pbjs%2F$prebid.version$'); @@ -851,7 +851,7 @@ describe('advertisingBidAdapter ', function () { }); describe('Bid Requests with schain object ', function () { - let validBidReq = { + const validBidReq = { bidder: 'advertising', params: { seatId: 'prebid', @@ -896,7 +896,7 @@ describe('advertisingBidAdapter ', function () { } } }; - let bidderRequest = { + const bidderRequest = { refererInfo: { referer: 'http://localhost:9999/' }, @@ -949,7 +949,7 @@ describe('advertisingBidAdapter ', function () { }; it('should return valid bid request with schain object', function () { - let req = spec.buildRequests([validBidReq], bidderRequest); + const req = spec.buildRequests([validBidReq], bidderRequest); expect(req).to.have.property('method', 'POST'); expect(req).to.have.property('url'); expect(req.url).to.contain('//prebid.technoratimedia.com/openrtb/bids/prebid?src=pbjs%2F$prebid.version$'); @@ -970,7 +970,7 @@ describe('advertisingBidAdapter ', function () { w: 300, h: 250 }; - let bidResponse2 = { + const bidResponse2 = { id: '10865933907263800~9999~0', impid: 'b9876abcd', price: 1.99, @@ -1040,7 +1040,7 @@ describe('advertisingBidAdapter ', function () { }, url: 'https://prebid.technoratimedia.com/openrtb/bids/prebid?src=prebid_prebid_3.27.0-pre' }; - let serverRespVideo = { + const serverRespVideo = { body: { id: 'abcd1234', seatbid: [ @@ -1067,7 +1067,7 @@ describe('advertisingBidAdapter ', function () { }; // serverResponse.body.seatbid[0].bid.push(bidResponse); - let resp = spec.interpretResponse(serverRespVideo, bidRequest); + const resp = spec.interpretResponse(serverRespVideo, bidRequest); expect(resp).to.be.an('array').to.have.lengthOf(1); expect(resp[0]).to.eql({ requestId: '2da7322b2df61f', @@ -1088,7 +1088,7 @@ describe('advertisingBidAdapter ', function () { it('should return 1 bid when 1 bid is in the response', function () { serverResponse.body.seatbid[0].bid.push(bidResponse); - let resp = spec.interpretResponse(serverResponse, bidRequest); + const resp = spec.interpretResponse(serverResponse, bidRequest); expect(resp).to.be.an('array').to.have.lengthOf(1); expect(resp[0]).to.eql({ requestId: '9876abcd', @@ -1110,7 +1110,7 @@ describe('advertisingBidAdapter ', function () { seat: '9999', bid: [bidResponse2], }); - let resp = spec.interpretResponse(serverResponse, bidRequest); + const resp = spec.interpretResponse(serverResponse, bidRequest); expect(resp).to.be.an('array').to.have.lengthOf(2); expect(resp[0]).to.eql({ requestId: '9876abcd', @@ -1140,7 +1140,7 @@ describe('advertisingBidAdapter ', function () { }); it('should not return a bid when no bid is in the response', function () { - let resp = spec.interpretResponse(serverResponse, bidRequest); + const resp = spec.interpretResponse(serverResponse, bidRequest); expect(resp).to.be.an('array').that.is.empty; }); @@ -1150,8 +1150,8 @@ describe('advertisingBidAdapter ', function () { }); it('should not include videoCacheKey property on the returned response when cache url is present in the config', function () { - let sandbox = sinon.createSandbox(); - let serverRespVideo = { + const sandbox = sinon.createSandbox(); + const serverRespVideo = { body: { id: 'abcd1234', seatbid: [ @@ -1184,7 +1184,7 @@ describe('advertisingBidAdapter ', function () { return config[key]; }); - let resp = spec.interpretResponse(serverRespVideo, bidRequest); + const resp = spec.interpretResponse(serverRespVideo, bidRequest); sandbox.restore(); expect(resp[0].videoCacheKey).to.not.exist; }); @@ -1211,7 +1211,7 @@ describe('advertisingBidAdapter ', function () { url: 'https://prebid.technoratimedia.com/openrtb/bids/prebid?src=prebid_prebid_3.27.0-pre' }; - let serverRespVideo = { + const serverRespVideo = { body: { id: 'abcd1234', seatbid: [ @@ -1234,7 +1234,7 @@ describe('advertisingBidAdapter ', function () { ] } }; - let resp = spec.interpretResponse(serverRespVideo, bidRequest); + const resp = spec.interpretResponse(serverRespVideo, bidRequest); expect(resp).to.be.an('array').to.have.lengthOf(1); expect(resp[0]).to.eql({ requestId: '2da7322b2df61f', @@ -1287,7 +1287,7 @@ describe('advertisingBidAdapter ', function () { }; serverResponse.body.seatbid[0].bid.push(bidResponse); - let resp = spec.interpretResponse(serverResponse, bidRequest); + const resp = spec.interpretResponse(serverResponse, bidRequest); expect(resp).to.be.an('array').to.have.lengthOf(1); expect(resp[0]).to.eql({ requestId: 'abc123', @@ -1313,9 +1313,9 @@ describe('advertisingBidAdapter ', function () { }); it('should return ttl equal to bid.ext["imds.tv"].ttl if it is defined but bid.exp is undefined', function() { - let br = { ext: { 'imds.tv': { ttl: 4321 } }, ...bidResponse }; + const br = { ext: { 'imds.tv': { ttl: 4321 } }, ...bidResponse }; serverResponse.body.seatbid[0].bid.push(br); - let resp = spec.interpretResponse(serverResponse, bidRequest); + const resp = spec.interpretResponse(serverResponse, bidRequest); expect(resp).to.be.an('array').to.have.lengthOf(1); expect(resp[0]).to.have.property('ttl'); expect(resp[0].ttl).to.equal(4321); @@ -1359,7 +1359,7 @@ describe('advertisingBidAdapter ', function () { }); describe('getUserSyncs', function () { it('should return an iframe usersync when iframes is enabled', function () { - let usersyncs = spec.getUserSyncs({ + const usersyncs = spec.getUserSyncs({ iframeEnabled: true }, null); expect(usersyncs).to.be.an('array').with.lengthOf(1); @@ -1369,7 +1369,7 @@ describe('advertisingBidAdapter ', function () { }); it('should return an image usersync when pixels are enabled', function () { - let usersyncs = spec.getUserSyncs({ + const usersyncs = spec.getUserSyncs({ pixelEnabled: true }, null); expect(usersyncs).to.be.an('array').with.lengthOf(1); @@ -1379,7 +1379,7 @@ describe('advertisingBidAdapter ', function () { }); it('should return an iframe usersync when both iframe and pixel are enabled', function () { - let usersyncs = spec.getUserSyncs({ + const usersyncs = spec.getUserSyncs({ iframeEnabled: true, pixelEnabled: true }, null); @@ -1390,7 +1390,7 @@ describe('advertisingBidAdapter ', function () { }); it('should not return a usersync when neither iframes nor pixel are enabled', function () { - let usersyncs = spec.getUserSyncs({ + const usersyncs = spec.getUserSyncs({ iframeEnabled: false, pixelEnabled: false }, null); @@ -1399,7 +1399,7 @@ describe('advertisingBidAdapter ', function () { }); describe('Bid Requests with price module should use if available', function () { - let validVideoBidRequest = { + const validVideoBidRequest = { bidder: 'advertising', params: { bidfloor: '0.50', @@ -1429,7 +1429,7 @@ describe('advertisingBidAdapter ', function () { bidderWinsCount: 0 }; - let validBannerBidRequest = { + const validBannerBidRequest = { bidId: '9876abcd', sizes: [[300, 250]], params: { @@ -1439,7 +1439,7 @@ describe('advertisingBidAdapter ', function () { } }; - let bidderRequest = { + const bidderRequest = { refererInfo: { referer: 'http://localhost:9999/' }, @@ -1454,8 +1454,8 @@ describe('advertisingBidAdapter ', function () { expect(bannerRequest.data.imp[0].bidfloor).to.equal(0.5); expect(videoRequest.data.imp[0].bidfloor).to.equal(0.5); - let priceModuleFloor = 3; - let floorResponse = { currency: 'USD', floor: priceModuleFloor }; + const priceModuleFloor = 3; + const floorResponse = { currency: 'USD', floor: priceModuleFloor }; validBannerBidRequest.getFloor = () => { return floorResponse; }; validVideoBidRequest.getFloor = () => { return floorResponse; }; @@ -1469,7 +1469,7 @@ describe('advertisingBidAdapter ', function () { }); describe('Bid Requests with gpid or anything in bid.ext should use if available', function () { - let validVideoBidRequest = { + const validVideoBidRequest = { bidder: 'advertising', params: { seatId: 'prebid', @@ -1506,7 +1506,7 @@ describe('advertisingBidAdapter ', function () { bidderWinsCount: 0 }; - let validBannerBidRequest = { + const validBannerBidRequest = { bidId: '9876abcd', sizes: [[300, 250]], params: { @@ -1523,7 +1523,7 @@ describe('advertisingBidAdapter ', function () { } }; - let bidderRequest = { + const bidderRequest = { refererInfo: { referer: 'http://localhost:9999/' }, @@ -1532,8 +1532,8 @@ describe('advertisingBidAdapter ', function () { }; it('should return valid gpid and pbadslot', function () { - let videoRequest = spec.buildRequests([validVideoBidRequest], bidderRequest); - let bannerRequest = spec.buildRequests([validBannerBidRequest], bidderRequest); + const videoRequest = spec.buildRequests([validVideoBidRequest], bidderRequest); + const bannerRequest = spec.buildRequests([validBannerBidRequest], bidderRequest); expect(videoRequest.data.imp[0].ext.gpid).to.equal('/1111/homepage-video'); expect(videoRequest.data.imp[0].ext.data.pbadslot).to.equal('/1111/homepage-video'); diff --git a/test/spec/modules/adxcgAnalyticsAdapter_spec.js b/test/spec/modules/adxcgAnalyticsAdapter_spec.js index 40e1347bce3..9efa1085a27 100644 --- a/test/spec/modules/adxcgAnalyticsAdapter_spec.js +++ b/test/spec/modules/adxcgAnalyticsAdapter_spec.js @@ -4,7 +4,7 @@ import adapterManager from 'src/adapterManager.js'; import { server } from 'test/mocks/xhr.js'; import { EVENTS } from 'src/constants.js'; -let events = require('src/events'); +const events = require('src/events'); describe('adxcg analytics adapter', function () { beforeEach(function () { @@ -16,14 +16,14 @@ describe('adxcg analytics adapter', function () { }); describe('track', function () { - let initOptions = { + const initOptions = { publisherId: '42' }; - let auctionTimestamp = 1496510254313; + const auctionTimestamp = 1496510254313; // prepare general auction - request and response - let bidRequest = { + const bidRequest = { 'bidderCode': 'appnexus', 'bids': [{ 'params': { @@ -38,7 +38,7 @@ describe('adxcg analytics adapter', function () { ] }; - let bidResponse = { + const bidResponse = { 'height': 250, 'statusMessage': 'Bid available', 'adId': '2eddfdc0c791dc', @@ -60,7 +60,7 @@ describe('adxcg analytics adapter', function () { }; // what we expect after general auction - let expectedAfterBid = { + const expectedAfterBid = { 'bidRequests': [ { 'bidderCode': 'appnexus', @@ -100,7 +100,7 @@ describe('adxcg analytics adapter', function () { }; // lets simulate that some bidders timeout - let bidTimeoutArgsV1 = [ + const bidTimeoutArgsV1 = [ { bidId: '2baa51527bd015', bidder: 'bidderOne', @@ -116,7 +116,7 @@ describe('adxcg analytics adapter', function () { ]; // now simulate some WIN and RENDERING - let wonRequest = { + const wonRequest = { 'adId': '4587fec4900b81', 'mediaType': 'banner', 'requestId': '4587fec4900b81', @@ -136,7 +136,7 @@ describe('adxcg analytics adapter', function () { 'status': 'rendered' }; - let wonExpect = { + const wonExpect = { 'bidWons': [{ 'bidderCode': 'testbidder4', 'adUnitCode': 'div-gpt-ad-1438287399331-0', @@ -189,7 +189,7 @@ describe('adxcg analytics adapter', function () { expect(server.requests.length).to.equal(1); - let realAfterBid = JSON.parse(server.requests[0].requestBody); + const realAfterBid = JSON.parse(server.requests[0].requestBody); expect(realAfterBid).to.deep.equal(expectedAfterBid); @@ -199,7 +199,7 @@ describe('adxcg analytics adapter', function () { events.emit(EVENTS.BID_WON, wonRequest); expect(server.requests.length).to.equal(2); - let winEventData = JSON.parse(server.requests[1].requestBody); + const winEventData = JSON.parse(server.requests[1].requestBody); expect(winEventData).to.deep.equal(wonExpect); }); diff --git a/test/spec/modules/adxcgBidAdapter_spec.js b/test/spec/modules/adxcgBidAdapter_spec.js index 221f5c036fa..0f14bad94ce 100644 --- a/test/spec/modules/adxcgBidAdapter_spec.js +++ b/test/spec/modules/adxcgBidAdapter_spec.js @@ -9,7 +9,7 @@ import {addFPDToBidderRequest} from '../../helpers/fpd.js'; const utils = require('src/utils'); describe('Adxcg adapter', function () { - let bids = []; + const bids = []; describe('getUserSyncs', function () { const usersyncUrl = 'https://usersync-url.com'; @@ -474,8 +474,8 @@ describe('adxcg v8 oRtbConverter Adapter Tests', function () { } } }; - let request = spec.buildRequests(slotConfigs, bidderRequest); - let ortbRequest = request.data; + const request = spec.buildRequests(slotConfigs, bidderRequest); + const ortbRequest = request.data; expect(ortbRequest).to.not.equal(null); expect(ortbRequest.user).to.not.equal(null); }); @@ -501,8 +501,8 @@ describe('adxcg v8 oRtbConverter Adapter Tests', function () { } } }; - let request = spec.buildRequests(slotConfigs, bidderRequest); - let ortbRequest = request.data; + const request = spec.buildRequests(slotConfigs, bidderRequest); + const ortbRequest = request.data; expect(ortbRequest).to.not.equal(null); expect(ortbRequest.site).to.not.equal(null); expect(ortbRequest.site).to.deep.equal({ @@ -546,8 +546,8 @@ describe('adxcg v8 oRtbConverter Adapter Tests', function () { } } }]; - let request = spec.buildRequests(bidderRequests, bidderRequest); - let ortbRequest = request.data; + const request = spec.buildRequests(bidderRequests, bidderRequest); + const ortbRequest = request.data; expect(ortbRequest).to.not.equal(null); expect(ortbRequest.imp).to.not.equal(null); expect(ortbRequest.imp).to.have.lengthOf(1); diff --git a/test/spec/modules/adxpremiumAnalyticsAdapter_spec.js b/test/spec/modules/adxpremiumAnalyticsAdapter_spec.js index fe453a1c208..479cd601ee3 100644 --- a/test/spec/modules/adxpremiumAnalyticsAdapter_spec.js +++ b/test/spec/modules/adxpremiumAnalyticsAdapter_spec.js @@ -1,11 +1,11 @@ -import adxpremiumAnalyticsAdapter from 'modules/adxpremiumAnalyticsAdapter.js'; -import { testSend } from 'modules/adxpremiumAnalyticsAdapter.js'; +import adxpremiumAnalyticsAdapter, { testSend } from 'modules/adxpremiumAnalyticsAdapter.js'; + import { expect } from 'chai'; import adapterManager from 'src/adapterManager.js'; import { server } from 'test/mocks/xhr.js'; import { EVENTS } from 'src/constants.js'; -let events = require('src/events'); +const events = require('src/events'); describe('AdxPremium analytics adapter', function () { beforeEach(function () { @@ -17,12 +17,12 @@ describe('AdxPremium analytics adapter', function () { }); describe('track', function () { - let initOptions = { + const initOptions = { pubId: 123, sid: 's2' }; - let auctionInit = { + const auctionInit = { 'auctionId': 'c4f0cce0-264c-483a-b2f4-8ac2248a896b', 'timestamp': 1589707613899, 'auctionStatus': 'inProgress', @@ -143,7 +143,7 @@ describe('AdxPremium analytics adapter', function () { }; // requests & responses - let bidRequest = { + const bidRequest = { 'bidderCode': 'luponmedia', 'auctionId': 'c4f0cce0-264c-483a-b2f4-8ac2248a896b', 'bidderRequestId': '18c49b05a23645', @@ -232,7 +232,7 @@ describe('AdxPremium analytics adapter', function () { 'start': 1589707613908 }; - let bidResponse = { + const bidResponse = { 'bidderCode': 'luponmedia', 'width': 300, 'height': 250, @@ -279,7 +279,7 @@ describe('AdxPremium analytics adapter', function () { expectedAfterBidData['screen_resolution'] = window.screen.width + 'x' + window.screen.height; expectedAfterBidData = btoa(JSON.stringify(expectedAfterBidData)); - let expectedAfterBid = { + const expectedAfterBid = { 'query': 'mutation {createEvent(input: {event: {eventData: "' + expectedAfterBidData + '"}}) {event {createTime } } }' }; @@ -289,12 +289,12 @@ describe('AdxPremium analytics adapter', function () { expectedAfterTimeoutData['screen_resolution'] = window.screen.width + 'x' + window.screen.height; expectedAfterTimeoutData = btoa(JSON.stringify(expectedAfterTimeoutData)); - let expectedAfterTimeout = { + const expectedAfterTimeout = { 'query': 'mutation {createEvent(input: {event: {eventData: "' + expectedAfterTimeoutData + '"}}) {event {createTime } } }' }; // lets simulate that some bidders timeout - let bidTimeoutArgsV1 = [ + const bidTimeoutArgsV1 = [ { 'bidId': '284f8e1469246b', 'bidder': 'luponmedia', @@ -304,7 +304,7 @@ describe('AdxPremium analytics adapter', function () { ]; // now simulate some WIN and RENDERING - let wonRequest = { + const wonRequest = { 'bidderCode': 'luponmedia', 'width': 300, 'height': 250, @@ -356,7 +356,7 @@ describe('AdxPremium analytics adapter', function () { wonExpectData['screen_resolution'] = window.screen.width + 'x' + window.screen.height; wonExpectData = btoa(JSON.stringify(wonExpectData)); - let wonExpect = { + const wonExpect = { 'query': 'mutation {createEvent(input: {event: {eventData: "' + wonExpectData + '"}}) {event {createTime } } }' }; @@ -396,7 +396,7 @@ describe('AdxPremium analytics adapter', function () { expect(server.requests.length).to.equal(2); - let realAfterBid = JSON.parse(server.requests[0].requestBody); + const realAfterBid = JSON.parse(server.requests[0].requestBody); expect(realAfterBid).to.deep.equal(expectedAfterBid); @@ -407,7 +407,7 @@ describe('AdxPremium analytics adapter', function () { events.emit(EVENTS.BID_WON, wonRequest); expect(server.requests.length).to.equal(3); - let winEventData = JSON.parse(server.requests[1].requestBody); + const winEventData = JSON.parse(server.requests[1].requestBody); expect(winEventData).to.deep.equal(wonExpect); }); diff --git a/test/spec/modules/adyoulikeBidAdapter_spec.js b/test/spec/modules/adyoulikeBidAdapter_spec.js index c3f33ec3812..337bd6fea75 100644 --- a/test/spec/modules/adyoulikeBidAdapter_spec.js +++ b/test/spec/modules/adyoulikeBidAdapter_spec.js @@ -566,7 +566,7 @@ describe('Adyoulike Adapter', function () { ]; const adapter = newBidder(spec); - let getEndpoint = (dc = defaultDC) => `https://${dc}.omnitagjs.com/hb-api/prebid`; + const getEndpoint = (dc = defaultDC) => `https://${dc}.omnitagjs.com/hb-api/prebid`; describe('inherited functions', function () { it('exists and is a function', function () { @@ -575,7 +575,7 @@ describe('Adyoulike Adapter', function () { }); describe('isBidRequestValid', function () { - let bid = { + const bid = { 'bidId': 'bid_id_1', 'bidder': 'adyoulike', 'placementCode': 'adunit/hb-1', @@ -586,7 +586,7 @@ describe('Adyoulike Adapter', function () { 'transactionId': 'bid_id_1_transaction_id' }; - let bidWSize = { + const bidWSize = { 'bidId': 'bid_id_1', 'bidder': 'adyoulike', 'placementCode': 'adunit/hb-1', @@ -597,7 +597,7 @@ describe('Adyoulike Adapter', function () { 'transactionId': 'bid_id_1_transaction_id' }; - let nativeBid = { + const nativeBid = { 'bidId': 'bid_id_1', 'bidder': 'adyoulike', 'placementCode': 'adunit/hb-1', @@ -625,14 +625,14 @@ describe('Adyoulike Adapter', function () { }); it('should return false when required params are not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.sizes; expect(!!spec.isBidRequestValid(invalidBid)).to.equal(false); }); it('should return false when required params are not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = { 'placement': 0 @@ -666,9 +666,9 @@ describe('Adyoulike Adapter', function () { }); it('should add gdpr/usp consent information and SChain to the request', function () { - let consentString = 'BOJ8RZsOJ8RZsABAB8AAAAAZ+A=='; - let uspConsentData = '1YCC'; - let bidderRequest = { + const consentString = 'BOJ8RZsOJ8RZsABAB8AAAAAZ+A=='; + const uspConsentData = '1YCC'; + const bidderRequest = { 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', 'timeout': 3000, @@ -692,9 +692,9 @@ describe('Adyoulike Adapter', function () { }); it('should not set a default value for gdpr consentRequired', function () { - let consentString = 'BOJ8RZsOJ8RZsABAB8AAAAAZ+A=='; - let uspConsentData = '1YCC'; - let bidderRequest = { + const consentString = 'BOJ8RZsOJ8RZsABAB8AAAAAZ+A=='; + const uspConsentData = '1YCC'; + const bidderRequest = { 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', 'timeout': 3000, @@ -715,7 +715,7 @@ describe('Adyoulike Adapter', function () { }); it('should add eids eids information to the request', function () { - let bidRequest = bidRequestWithSinglePlacement; + const bidRequest = bidRequestWithSinglePlacement; bidRequest[0].userIdAsEids = [{ 'source': 'pubcid.org', 'uids': [{ @@ -820,24 +820,24 @@ describe('Adyoulike Adapter', function () { it('handles 204 responses', function () { serverResponse.body = ''; - let result = spec.interpretResponse(serverResponse, []); + const result = spec.interpretResponse(serverResponse, []); expect(result).deep.equal([]); }); it('handles nobid responses', function () { - let response = [{ + const response = [{ BidID: '123dfsdf', Attempt: '32344fdse1', Placement: '12df1' }]; serverResponse.body = response; - let result = spec.interpretResponse(serverResponse, []); + const result = spec.interpretResponse(serverResponse, []); expect(result).deep.equal([]); }); it('receive reponse with single placement', function () { serverResponse.body = responseWithSinglePlacement; - let result = spec.interpretResponse(serverResponse, {data: '{"Bids":' + JSON.stringify(requestDataOnePlacement) + '}'}); + const result = spec.interpretResponse(serverResponse, {data: '{"Bids":' + JSON.stringify(requestDataOnePlacement) + '}'}); expect(result.length).to.equal(1); expect(result[0].cpm).to.equal(0.5); @@ -849,7 +849,7 @@ describe('Adyoulike Adapter', function () { it('receive reponse with multiple placement', function () { serverResponse.body = responseWithMultiplePlacements; - let result = spec.interpretResponse(serverResponse, {data: '{"Bids":' + JSON.stringify(requestDataMultiPlacement) + '}'}); + const result = spec.interpretResponse(serverResponse, {data: '{"Bids":' + JSON.stringify(requestDataMultiPlacement) + '}'}); expect(result.length).to.equal(2); @@ -866,7 +866,7 @@ describe('Adyoulike Adapter', function () { it('receive reponse with Native from ad markup', function () { serverResponse.body = responseWithSinglePlacement; - let result = spec.interpretResponse(serverResponse, {data: '{"Bids":' + JSON.stringify(sentBidNative) + '}'}); + const result = spec.interpretResponse(serverResponse, {data: '{"Bids":' + JSON.stringify(sentBidNative) + '}'}); expect(result.length).to.equal(1); @@ -875,7 +875,7 @@ describe('Adyoulike Adapter', function () { it('receive reponse with Native ad', function () { serverResponse.body = responseWithSingleNative; - let result = spec.interpretResponse(serverResponse, {data: '{"Bids":' + JSON.stringify(sentBidNative) + '}'}); + const result = spec.interpretResponse(serverResponse, {data: '{"Bids":' + JSON.stringify(sentBidNative) + '}'}); expect(result.length).to.equal(1); @@ -890,7 +890,7 @@ describe('Adyoulike Adapter', function () { it('receive Vast reponse with Video ad', function () { serverResponse.body = responseWithSingleVideo; - let result = spec.interpretResponse(serverResponse, {data: '{"Bids":' + JSON.stringify(sentBidVideo) + '}'}); + const result = spec.interpretResponse(serverResponse, {data: '{"Bids":' + JSON.stringify(sentBidVideo) + '}'}); expect(result.length).to.equal(1); expect(result).to.deep.equal(videoResult); diff --git a/test/spec/modules/agmaAnalyticsAdapter_spec.js b/test/spec/modules/agmaAnalyticsAdapter_spec.js index 6b6727a2a82..2a9b830d1ab 100644 --- a/test/spec/modules/agmaAnalyticsAdapter_spec.js +++ b/test/spec/modules/agmaAnalyticsAdapter_spec.js @@ -1,10 +1,10 @@ -import adapterManager from '../../../src/adapterManager.js'; +import adapterManager, { gdprDataHandler } from '../../../src/adapterManager.js'; import agmaAnalyticsAdapter, { getTiming, getOrtb2Data, getPayload, } from '../../../modules/agmaAnalyticsAdapter.js'; -import { gdprDataHandler } from '../../../src/adapterManager.js'; + import { expect } from 'chai'; import * as events from '../../../src/events.js'; import { EVENTS } from '../../../src/constants.js'; diff --git a/test/spec/modules/ajaBidAdapter_spec.js b/test/spec/modules/ajaBidAdapter_spec.js index 82c6d1bab65..b9acda490e9 100644 --- a/test/spec/modules/ajaBidAdapter_spec.js +++ b/test/spec/modules/ajaBidAdapter_spec.js @@ -7,7 +7,7 @@ describe('AjaAdapter', function () { const adapter = newBidder(spec); describe('isBidRequestValid', function () { - let bid = { + const bid = { 'bidder': 'aja', 'params': { 'asi': '123456' @@ -24,7 +24,7 @@ describe('AjaAdapter', function () { }); it('should return false when required params are not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = { 'asi': 0 @@ -159,7 +159,7 @@ describe('AjaAdapter', function () { describe('interpretResponse', function () { it('should get correct banner bid response', function () { - let response = { + const response = { 'is_ad_return': true, 'ad': { 'ad_type': 1, @@ -184,7 +184,7 @@ describe('AjaAdapter', function () { ] }; - let expectedResponse = [ + const expectedResponse = [ { 'requestId': '51ef8751f9aead', 'cpm': 12.34, @@ -206,18 +206,18 @@ describe('AjaAdapter', function () { ]; let bidderRequest; - let result = spec.interpretResponse({ body: response }, {bidderRequest}); + const result = spec.interpretResponse({ body: response }, {bidderRequest}); expect(Object.keys(result[0])).to.have.members(Object.keys(expectedResponse[0])); }); it('handles nobid responses', function () { - let response = { + const response = { 'is_ad_return': false, 'ad': {} }; let bidderRequest; - let result = spec.interpretResponse({ body: response }, {bidderRequest}); + const result = spec.interpretResponse({ body: response }, {bidderRequest}); expect(result.length).to.equal(0); }); }); diff --git a/test/spec/modules/alkimiBidAdapter_spec.js b/test/spec/modules/alkimiBidAdapter_spec.js index d2a6a4dcada..a6949d5c5a3 100644 --- a/test/spec/modules/alkimiBidAdapter_spec.js +++ b/test/spec/modules/alkimiBidAdapter_spec.js @@ -114,8 +114,8 @@ describe('alkimiBidAdapter', function () { }) describe('buildRequests', function () { - let bidRequests = [REQUEST] - let requestData = { + const bidRequests = [REQUEST] + const requestData = { refererInfo: { page: 'http://test.com/path.html' }, diff --git a/test/spec/modules/ampliffyBidAdapter_spec.js b/test/spec/modules/ampliffyBidAdapter_spec.js index 5b86f692d7e..4c1a170477d 100644 --- a/test/spec/modules/ampliffyBidAdapter_spec.js +++ b/test/spec/modules/ampliffyBidAdapter_spec.js @@ -35,24 +35,24 @@ describe('Ampliffy bid adapter Test', function () { ES `; const xml = new window.DOMParser().parseFromString(xmlStr, 'text/xml'); - let companion = xml.getElementsByTagName('Companion')[0]; - let htmlResource = companion.getElementsByTagName('HTMLResource')[0]; - let htmlContent = document.createElement('html'); + const companion = xml.getElementsByTagName('Companion')[0]; + const htmlResource = companion.getElementsByTagName('HTMLResource')[0]; + const htmlContent = document.createElement('html'); htmlContent.innerHTML = htmlResource.textContent; describe('Is allowed to bid up', function () { it('Should return true using a URL that is in domainMap', () => { - let allowedToBidUp = isAllowedToBidUp(htmlContent, 'https://testSports.com?id=131313&text=aaaaa&foo=foo'); + const allowedToBidUp = isAllowedToBidUp(htmlContent, 'https://testSports.com?id=131313&text=aaaaa&foo=foo'); expect(allowedToBidUp).to.be.true; }) it('Should return false using an url that is not in domainMap', () => { - let allowedToBidUp = isAllowedToBidUp(htmlContent, 'https://test.com'); + const allowedToBidUp = isAllowedToBidUp(htmlContent, 'https://test.com'); expect(allowedToBidUp).to.be.false; }) it('Should return false using an url that is excluded.', () => { - let allowedToBidUp = isAllowedToBidUp(htmlContent, 'https://www.no-allowed.com/busqueda/sexo/sexo?test=1#item1'); + const allowedToBidUp = isAllowedToBidUp(htmlContent, 'https://www.no-allowed.com/busqueda/sexo/sexo?test=1#item1'); expect(allowedToBidUp).to.be.false; }) }) @@ -314,7 +314,7 @@ describe('Ampliffy bid adapter Test', function () { }); }) describe('Interpret response', function () { - let bidRequest = { + const bidRequest = { bidRequest: { adUnitCode: 'div-gpt-ad-1460505748561-0', auctionId: '469bb2e2-351f-4d01-b782-cdbca5e3e0ed', @@ -350,7 +350,7 @@ describe('Ampliffy bid adapter Test', function () { }; it('Should extract a CPM and currency from the xml', () => { - let cpmData = parseXML(xml); + const cpmData = parseXML(xml); expect(cpmData).to.not.be.a('null'); expect(cpmData.cpm).to.equal('.23'); expect(cpmData.currency).to.equal('USD'); @@ -384,7 +384,7 @@ describe('Ampliffy bid adapter Test', function () {
`; - let serverResponse = { + const serverResponse = { 'body': xmlStr1, } const bidResponses = spec.interpretResponse(serverResponse, bidRequest); @@ -415,14 +415,14 @@ describe('Ampliffy bid adapter Test', function () {
`; - let serverResponse = { + const serverResponse = { 'body': xmlStr1, } const bidResponses = spec.interpretResponse(serverResponse, bidRequest); expect(bidResponses.length).to.equal(0); }) it('It should return a banner ad.', () => { - let serverResponse = { + const serverResponse = { 'body': xmlStr, } setCurrentURL('https://www.sports.com'); @@ -432,7 +432,7 @@ describe('Ampliffy bid adapter Test', function () { expect(bidResponses[0].ad).not.to.be.null; }) it('It should return a video ad.', () => { - let serverResponse = { + const serverResponse = { 'body': xmlStr, } setCurrentURL('https://www.sports.com'); diff --git a/test/spec/modules/apacdexBidAdapter_spec.js b/test/spec/modules/apacdexBidAdapter_spec.js index e10b7468695..e821ab55b59 100644 --- a/test/spec/modules/apacdexBidAdapter_spec.js +++ b/test/spec/modules/apacdexBidAdapter_spec.js @@ -182,7 +182,7 @@ describe('ApacdexBidAdapter', function () { afterEach(function () { userSync.canBidderRegisterSync.restore(); }); - let bidRequest = [{ + const bidRequest = [{ 'ortb2': { 'source': { 'ext': { @@ -240,7 +240,7 @@ describe('ApacdexBidAdapter', function () { 'bidId': '30b31c1838de1e', }]; - let bidderRequests = { + const bidderRequests = { 'gdprConsent': { 'consentString': 'BOJ/P2HOJ/P2HABABMAAAAAZ+A==', 'vendorData': {}, @@ -279,7 +279,7 @@ describe('ApacdexBidAdapter', function () { expect(bidRequests.data.gdpr.consentString).to.equal('BOJ/P2HOJ/P2HABABMAAAAAZ+A==') }) it('should return a properly formatted request with GDPR applies set to false with no consent_string param', function () { - let bidderRequests = { + const bidderRequests = { 'gdprConsent': { 'consentString': undefined, 'vendorData': {}, @@ -299,7 +299,7 @@ describe('ApacdexBidAdapter', function () { expect(bidRequests.data.gdpr).to.not.include.keys('consentString') }) it('should return a properly formatted request with GDPR applies set to true with no consentString param', function () { - let bidderRequests = { + const bidderRequests = { 'gdprConsent': { 'consentString': undefined, 'vendorData': {}, @@ -331,7 +331,7 @@ describe('ApacdexBidAdapter', function () { expect(bidRequests.data.us_privacy).to.equal('someCCPAString'); }); it('should attach bidFloor param when either bid param floorPrice or getFloor function exists', function () { - let getFloorResponse = { currency: 'USD', floor: 3 }; + const getFloorResponse = { currency: 'USD', floor: 3 }; let singleBidRequest, request, payload = null; // 1 -> floorPrice not defined, getFloor not defined > empty @@ -532,7 +532,7 @@ describe('ApacdexBidAdapter', function () { ] }; - let serverResponse = { + const serverResponse = { 'body': { 'bids': [ { @@ -591,7 +591,7 @@ describe('ApacdexBidAdapter', function () { } }; - let prebidResponse = [ + const prebidResponse = [ { 'requestId': '3000aa31c41a29c21', 'cpm': 1.07, @@ -657,7 +657,7 @@ describe('ApacdexBidAdapter', function () { }); describe('.getUserSyncs', function () { - let bidResponse = [{ + const bidResponse = [{ 'body': { 'pixel': [{ 'url': 'https://pixel-test', @@ -690,7 +690,7 @@ describe('ApacdexBidAdapter', function () { describe('validateGeoObject', function () { it('should return true if the geo object is valid', () => { - let geoObject = { + const geoObject = { lat: 123.5624234, lon: 23.6712341, accuracy: 20 @@ -699,7 +699,7 @@ describe('ApacdexBidAdapter', function () { }); it('should return false if the geo object is not plain object', () => { - let geoObject = [{ + const geoObject = [{ lat: 123.5624234, lon: 23.6712341, accuracy: 20 @@ -708,7 +708,7 @@ describe('ApacdexBidAdapter', function () { }); it('should return false if the geo object is missing lat attribute', () => { - let geoObject = { + const geoObject = { lon: 23.6712341, accuracy: 20 }; @@ -716,7 +716,7 @@ describe('ApacdexBidAdapter', function () { }); it('should return false if the geo object is missing lon attribute', () => { - let geoObject = { + const geoObject = { lat: 123.5624234, accuracy: 20 }; @@ -724,7 +724,7 @@ describe('ApacdexBidAdapter', function () { }); it('should return false if the geo object is missing accuracy attribute', () => { - let geoObject = { + const geoObject = { lat: 123.5624234, lon: 23.6712341 }; diff --git a/test/spec/modules/appierBidAdapter_spec.js b/test/spec/modules/appierBidAdapter_spec.js index 0ad14b1ec61..93f95fbd182 100644 --- a/test/spec/modules/appierBidAdapter_spec.js +++ b/test/spec/modules/appierBidAdapter_spec.js @@ -13,7 +13,7 @@ describe('AppierAdapter', function () { }); describe('isBidRequestValid', function () { - let bid = { + const bid = { 'bidder': 'appier', 'params': { 'hzid': 'abcd' @@ -30,13 +30,13 @@ describe('AppierAdapter', function () { }); it('should return false when required param zoneId is missing', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); invalidBid.params = {}; expect(spec.isBidRequestValid(invalidBid)).to.equal(false); }); it('should return false when required param zoneId has wrong type', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); invalidBid.params = { 'hzid': null }; diff --git a/test/spec/modules/appnexusBidAdapter_spec.js b/test/spec/modules/appnexusBidAdapter_spec.js index f2d674f57c7..58bf8925efe 100644 --- a/test/spec/modules/appnexusBidAdapter_spec.js +++ b/test/spec/modules/appnexusBidAdapter_spec.js @@ -30,7 +30,7 @@ describe('AppNexusAdapter', function () { } describe('isBidRequestValid', function () { - let bid = { + const bid = { 'bidder': 'appnexus', 'params': { 'placementId': '10433394' @@ -47,7 +47,7 @@ describe('AppNexusAdapter', function () { }); it('should return true when required params found', function () { - let bid1 = deepClone(bid); + const bid1 = deepClone(bid); bid1.params = { 'placement_id': 123423 } @@ -55,7 +55,7 @@ describe('AppNexusAdapter', function () { }); it('should return true when required params found', function () { - let bid1 = deepClone(bid); + const bid1 = deepClone(bid); bid1.params = { 'member': '1234', 'invCode': 'ABCD' @@ -65,7 +65,7 @@ describe('AppNexusAdapter', function () { }); it('should return true when required params found', function () { - let bid1 = deepClone(bid); + const bid1 = deepClone(bid); bid1.params = { 'member': '1234', 'inv_code': 'ABCD' @@ -75,7 +75,7 @@ describe('AppNexusAdapter', function () { }); it('should return false when required params are not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = { 'placementId': 0 @@ -84,7 +84,7 @@ describe('AppNexusAdapter', function () { }); it('should return false when required params are not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = { 'placement_id': 0 @@ -95,7 +95,7 @@ describe('AppNexusAdapter', function () { describe('buildRequests', function () { let getAdUnitsStub; - let bidRequests = [ + const bidRequests = [ { 'bidder': 'appnexus', 'params': { @@ -121,7 +121,7 @@ describe('AppNexusAdapter', function () { }); it('should parse out private sizes', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { @@ -139,7 +139,7 @@ describe('AppNexusAdapter', function () { }); it('should parse out private sizes', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { @@ -206,7 +206,7 @@ describe('AppNexusAdapter', function () { }); it('should add publisher_id in request', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { @@ -224,7 +224,7 @@ describe('AppNexusAdapter', function () { }); it('should add publisher_id in request', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { @@ -252,7 +252,7 @@ describe('AppNexusAdapter', function () { }); it('should populate the ad_types array on all requests', function () { - let adUnits = [{ + const adUnits = [{ code: 'adunit-code', mediaTypes: { banner: { @@ -268,7 +268,7 @@ describe('AppNexusAdapter', function () { transactionId: '04f2659e-c005-4eb1-a57c-fa93145e3843' }]; - let types = ['banner']; + const types = ['banner']; if (FEATURES.NATIVE) { types.push('native'); } @@ -319,7 +319,7 @@ describe('AppNexusAdapter', function () { }); it('should attach valid video params to the tag', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { @@ -343,7 +343,7 @@ describe('AppNexusAdapter', function () { }); it('should include ORTB video values when matching video params were not all set', function () { - let bidRequest = deepClone(bidRequests[0]); + const bidRequest = deepClone(bidRequests[0]); bidRequest.params = { placementId: '1234235', video: { @@ -377,7 +377,7 @@ describe('AppNexusAdapter', function () { }); it('should include ORTB video values when video params is empty - case 1', function () { - let bidRequest = deepClone(bidRequests[0]); + const bidRequest = deepClone(bidRequests[0]); bidRequest.mediaTypes = { video: { playerSize: [640, 480], @@ -404,7 +404,7 @@ describe('AppNexusAdapter', function () { }); it('should include ORTB video values when video params is empty - case 2', function () { - let bidRequest = deepClone(bidRequests[0]); + const bidRequest = deepClone(bidRequests[0]); bidRequest.mediaTypes = { video: { playerSize: [640, 480], @@ -432,7 +432,7 @@ describe('AppNexusAdapter', function () { }); it('should include ORTB video values when video params is empty - case 1', function () { - let bidRequest = deepClone(bidRequests[0]); + const bidRequest = deepClone(bidRequests[0]); bidRequest.mediaTypes = { video: { playerSize: [640, 480], @@ -537,7 +537,7 @@ describe('AppNexusAdapter', function () { }); it('should duplicate adpod placements into batches and set correct maxduration', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { placementId: '14542875' } @@ -570,7 +570,7 @@ describe('AppNexusAdapter', function () { }); it('should round down adpod placements when numbers are uneven', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { placementId: '14542875' } @@ -593,7 +593,7 @@ describe('AppNexusAdapter', function () { }); it('should duplicate adpod placements when requireExactDuration is set', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { placementId: '14542875' } @@ -635,7 +635,7 @@ describe('AppNexusAdapter', function () { }); it('should set durations for placements when requireExactDuration is set and numbers are uneven', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { placementId: '14542875' } @@ -666,7 +666,7 @@ describe('AppNexusAdapter', function () { }); it('should break adpod request into batches', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { placementId: '14542875' } @@ -694,7 +694,7 @@ describe('AppNexusAdapter', function () { }); it('should contain hb_source value for adpod', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { placementId: '14542875' } @@ -723,7 +723,7 @@ describe('AppNexusAdapter', function () { }); it('should attach valid user params to the tag', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { @@ -748,7 +748,7 @@ describe('AppNexusAdapter', function () { }); it('should add debug params from query', function () { - let getParamStub = sinon.stub(utils, 'getParameterByName').callsFake(function(par) { + const getParamStub = sinon.stub(utils, 'getParameterByName').callsFake(function(par) { if (par === 'apn_debug_dongle') return 'abcdef'; if (par === 'apn_debug_member_id') return '1234'; if (par === 'apn_debug_timeout') return '1000'; @@ -756,7 +756,7 @@ describe('AppNexusAdapter', function () { return ''; }); - let bidRequest = deepClone(bidRequests[0]); + const bidRequest = deepClone(bidRequests[0]); const request = spec.buildRequests([bidRequest]); const payload = JSON.parse(request.data); @@ -771,9 +771,9 @@ describe('AppNexusAdapter', function () { }); it('should attach reserve param when either bid param or getFloor function exists', function () { - let getFloorResponse = { currency: 'USD', floor: 3 }; + const getFloorResponse = { currency: 'USD', floor: 3 }; let request, payload = null; - let bidRequest = deepClone(bidRequests[0]); + const bidRequest = deepClone(bidRequests[0]); // 1 -> reserve not defined, getFloor not defined > empty request = spec.buildRequests([bidRequest]); @@ -801,7 +801,7 @@ describe('AppNexusAdapter', function () { }); it('should contain hb_source value for other media', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { mediaType: 'banner', @@ -817,7 +817,7 @@ describe('AppNexusAdapter', function () { }); it('adds brand_category_exclusion to request when set', function () { - let bidRequest = Object.assign({}, bidRequests[0]); + const bidRequest = Object.assign({}, bidRequests[0]); sinon .stub(config, 'getConfig') .withArgs('adpod.brandCategoryExclusion') @@ -832,7 +832,7 @@ describe('AppNexusAdapter', function () { }); it('adds auction level keywords and ortb2 keywords to request when set', function () { - let bidRequest = Object.assign({}, bidRequests[0]); + const bidRequest = Object.assign({}, bidRequests[0]); sinon .stub(config, 'getConfig') .withArgs('appnexusAuctionKeywords') @@ -902,7 +902,7 @@ describe('AppNexusAdapter', function () { }); it('adds ortb2 segments to auction request as keywords', function() { - let bidRequest = Object.assign({}, bidRequests[0]); + const bidRequest = Object.assign({}, bidRequests[0]); const bidderRequest = { ortb2: { site: { @@ -966,7 +966,7 @@ describe('AppNexusAdapter', function () { if (FEATURES.NATIVE) { it('should attach native params to the request', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { mediaType: 'native', @@ -1017,7 +1017,7 @@ describe('AppNexusAdapter', function () { }); it('should always populated tags[].sizes with 1,1 for native if otherwise not defined', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { mediaType: 'native', @@ -1042,7 +1042,7 @@ describe('AppNexusAdapter', function () { } it('should convert keyword params (when there are no ortb keywords) to proper form and attaches to request', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { @@ -1089,7 +1089,7 @@ describe('AppNexusAdapter', function () { }); it('should convert adUnit ortb2 keywords (when there are no bid param keywords) to proper form and attaches to request', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { ortb2Imp: { @@ -1120,7 +1120,7 @@ describe('AppNexusAdapter', function () { }); it('should convert keyword params and adUnit ortb2 keywords to proper form and attaches to request', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { @@ -1177,7 +1177,7 @@ describe('AppNexusAdapter', function () { }); it('should add payment rules to the request', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { @@ -1194,7 +1194,7 @@ describe('AppNexusAdapter', function () { }); it('should add payment rules to the request', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { @@ -1211,8 +1211,8 @@ describe('AppNexusAdapter', function () { }); it('should add preferred gpid to the request', function () { - let testGpid = '/12345/my-gpt-tag-0'; - let bidRequest = deepClone(bidRequests[0]); + const testGpid = '/12345/my-gpt-tag-0'; + const bidRequest = deepClone(bidRequests[0]); bidRequest.ortb2Imp = { ext: { gpid: testGpid } }; const request = spec.buildRequests([bidRequest]); @@ -1222,8 +1222,8 @@ describe('AppNexusAdapter', function () { }); it('should add backup gpid to the request', function () { - let testGpid = '/12345/my-gpt-tag-0'; - let bidRequest = deepClone(bidRequests[0]); + const testGpid = '/12345/my-gpt-tag-0'; + const bidRequest = deepClone(bidRequests[0]); bidRequest.ortb2Imp = { ext: { data: {}, gpid: testGpid } }; const request = spec.buildRequests([bidRequest]); @@ -1234,7 +1234,7 @@ describe('AppNexusAdapter', function () { it('should add tid to the request', function () { const testTid = '1234test'; - let bidRequest = deepClone(bidRequests[0]); + const bidRequest = deepClone(bidRequests[0]); bidRequest.ortb2Imp = { ext: { tid: testTid } }; // bidRequest.ortb2 = { source: { tid: testTid } }; @@ -1259,8 +1259,8 @@ describe('AppNexusAdapter', function () { }); it('should add gdpr consent information to the request', function () { - let consentString = 'BOJ8RZsOJ8RZsABAB8AAAAAZ+A=='; - let bidderRequest = { + const consentString = 'BOJ8RZsOJ8RZsABAB8AAAAAZ+A=='; + const bidderRequest = { 'bidderCode': 'appnexus', 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', @@ -1284,8 +1284,8 @@ describe('AppNexusAdapter', function () { }); it('should add us privacy string to payload', function () { - let consentString = '1YA-'; - let bidderRequest = { + const consentString = '1YA-'; + const bidderRequest = { 'bidderCode': 'appnexus', 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', @@ -1302,8 +1302,8 @@ describe('AppNexusAdapter', function () { }); it('should add gpp information to the request via bidderRequest.gppConsent', function () { - let consentString = 'abc1234'; - let bidderRequest = { + const consentString = 'abc1234'; + const bidderRequest = { 'bidderCode': 'appnexus', 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', @@ -1324,8 +1324,8 @@ describe('AppNexusAdapter', function () { }); it('should add gpp information to the request via bidderRequest.ortb2.regs', function () { - let consentString = 'abc1234'; - let bidderRequest = { + const consentString = 'abc1234'; + const bidderRequest = { 'bidderCode': 'appnexus', 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', @@ -1348,7 +1348,7 @@ describe('AppNexusAdapter', function () { }); it('should add dsa information to the request via bidderRequest.ortb2.regs.ext.dsa', function () { - let bidderRequest = { + const bidderRequest = { 'bidderCode': 'appnexus', 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', @@ -1388,7 +1388,7 @@ describe('AppNexusAdapter', function () { }); it('supports sending hybrid mobile app parameters', function () { - let appRequest = Object.assign({}, + const appRequest = Object.assign({}, bidRequests[0], { params: { @@ -1523,7 +1523,7 @@ describe('AppNexusAdapter', function () { }); it('should populate coppa if set in config', function () { - let bidRequest = Object.assign({}, bidRequests[0]); + const bidRequest = Object.assign({}, bidRequests[0]); sinon.stub(config, 'getConfig') .withArgs('coppa') .returns(true); @@ -1538,10 +1538,10 @@ describe('AppNexusAdapter', function () { describe('ast_override_div', function () { let getParamStub; - let bidRequest = Object.assign({}, bidRequests[0]); - let bidRequest2 = deepClone(bidRequests[0]); + const bidRequest = Object.assign({}, bidRequests[0]); + const bidRequest2 = deepClone(bidRequests[0]); bidRequest2.adUnitCode = 'adUnit_code_2'; - let bidRequest3 = deepClone(bidRequests[0]); + const bidRequest3 = deepClone(bidRequests[0]); bidRequest3.adUnitCode = 'adUnit_code_3'; before(function () { @@ -1619,7 +1619,7 @@ describe('AppNexusAdapter', function () { }); it('should set the X-Is-Test customHeader if test flag is enabled', function () { - let bidRequest = Object.assign({}, bidRequests[0]); + const bidRequest = Object.assign({}, bidRequests[0]); sinon.stub(config, 'getConfig') .withArgs('apn_test') .returns(true); @@ -1631,14 +1631,14 @@ describe('AppNexusAdapter', function () { }); it('should always set withCredentials: true on the request.options', function () { - let bidRequest = Object.assign({}, bidRequests[0]); + const bidRequest = Object.assign({}, bidRequests[0]); const request = spec.buildRequests([bidRequest]); expect(request.options.withCredentials).to.equal(true); }); it('should set simple domain variant if purpose 1 consent is not given', function () { - let consentString = 'BOJ8RZsOJ8RZsABAB8AAAAAZ+A=='; - let bidderRequest = { + const consentString = 'BOJ8RZsOJ8RZsABAB8AAAAAZ+A=='; + const bidderRequest = { 'bidderCode': 'appnexus', 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', @@ -1737,7 +1737,7 @@ describe('AppNexusAdapter', function () { if (FEATURES.VIDEO) { // with bid.params.frameworks - let bidRequest_A = Object.assign({}, bidRequests[0], { + const bidRequest_A = Object.assign({}, bidRequests[0], { params: { frameworks: [1, 2, 5, 6], video: { @@ -1796,7 +1796,7 @@ describe('AppNexusAdapter', function () { $$PREBID_GLOBAL$$.bidderSettings = bidderSettingsStorage; }); - let response = { + const response = { 'version': '3.0.0', 'tags': [ { @@ -1854,7 +1854,7 @@ describe('AppNexusAdapter', function () { }; it('should get correct bid response', function () { - let expectedResponse = [ + const expectedResponse = [ { 'adId': '3a1f23123e', 'requestId': '3db3773286ee59', @@ -1892,25 +1892,25 @@ describe('AppNexusAdapter', function () { } } ]; - let bidderRequest = { + const bidderRequest = { bids: [{ bidId: '3db3773286ee59', adUnitCode: 'code' }] }; - let result = spec.interpretResponse({ body: response }, { bidderRequest }); + const result = spec.interpretResponse({ body: response }, { bidderRequest }); expect(Object.keys(result[0])).to.have.members(Object.keys(expectedResponse[0])); }); it('should reject 0 cpm bids', function () { - let zeroCpmResponse = deepClone(response); + const zeroCpmResponse = deepClone(response); zeroCpmResponse.tags[0].ads[0].cpm = 0; - let bidderRequest = { + const bidderRequest = { bidderCode: 'appnexus' }; - let result = spec.interpretResponse({ body: zeroCpmResponse }, { bidderRequest }); + const result = spec.interpretResponse({ body: zeroCpmResponse }, { bidderRequest }); expect(result.length).to.equal(0); }); @@ -1921,10 +1921,10 @@ describe('AppNexusAdapter', function () { } }; - let zeroCpmResponse = deepClone(response); + const zeroCpmResponse = deepClone(response); zeroCpmResponse.tags[0].ads[0].cpm = 0; - let bidderRequest = { + const bidderRequest = { bidderCode: 'appnexus', bids: [{ bidId: '3db3773286ee59', @@ -1932,13 +1932,13 @@ describe('AppNexusAdapter', function () { }] }; - let result = spec.interpretResponse({ body: zeroCpmResponse }, { bidderRequest }); + const result = spec.interpretResponse({ body: zeroCpmResponse }, { bidderRequest }); expect(result.length).to.equal(1); expect(result[0].cpm).to.equal(0); }); it('handles nobid responses', function () { - let response = { + const response = { 'version': '0.0.1', 'tags': [{ 'uuid': '84ab500420319d', @@ -1949,13 +1949,13 @@ describe('AppNexusAdapter', function () { }; let bidderRequest; - let result = spec.interpretResponse({ body: response }, { bidderRequest }); + const result = spec.interpretResponse({ body: response }, { bidderRequest }); expect(result.length).to.equal(0); }); if (FEATURES.VIDEO) { it('handles outstream video responses', function () { - let response = { + const response = { 'tags': [{ 'uuid': '84ab500420319d', 'ads': [{ @@ -1971,7 +1971,7 @@ describe('AppNexusAdapter', function () { }] }] }; - let bidderRequest = { + const bidderRequest = { bids: [{ bidId: '84ab500420319d', adUnitCode: 'code', @@ -1983,14 +1983,14 @@ describe('AppNexusAdapter', function () { }] } - let result = spec.interpretResponse({ body: response }, { bidderRequest }); + const result = spec.interpretResponse({ body: response }, { bidderRequest }); expect(result[0]).to.have.property('vastXml'); expect(result[0]).to.have.property('vastImpUrl'); expect(result[0]).to.have.property('mediaType', 'video'); }); it('handles instream video responses', function () { - let response = { + const response = { 'tags': [{ 'uuid': '84ab500420319d', 'ads': [{ @@ -2006,7 +2006,7 @@ describe('AppNexusAdapter', function () { }] }] }; - let bidderRequest = { + const bidderRequest = { bids: [{ bidId: '84ab500420319d', adUnitCode: 'code', @@ -2018,14 +2018,14 @@ describe('AppNexusAdapter', function () { }] } - let result = spec.interpretResponse({ body: response }, { bidderRequest }); + const result = spec.interpretResponse({ body: response }, { bidderRequest }); expect(result[0]).to.have.property('vastUrl'); expect(result[0]).to.have.property('vastImpUrl'); expect(result[0]).to.have.property('mediaType', 'video'); }); it('handles adpod responses', function () { - let response = { + const response = { 'tags': [{ 'uuid': '84ab500420319d', 'ads': [{ @@ -2046,7 +2046,7 @@ describe('AppNexusAdapter', function () { }] }; - let bidderRequest = { + const bidderRequest = { bids: [{ bidId: '84ab500420319d', adUnitCode: 'code', @@ -2058,7 +2058,7 @@ describe('AppNexusAdapter', function () { }] }; - let result = spec.interpretResponse({ body: response }, { bidderRequest }); + const result = spec.interpretResponse({ body: response }, { bidderRequest }); expect(result[0]).to.have.property('vastUrl'); expect(result[0].video.context).to.equal('adpod'); expect(result[0].video.durationSeconds).to.equal(30); @@ -2104,17 +2104,17 @@ describe('AppNexusAdapter', function () { }; it('handles native responses', function () { - let response1 = deepClone(response); + const response1 = deepClone(response); response1.tags[0].ads[0].ad_type = 'native'; response1.tags[0].ads[0].rtb.native = BASE_NATIVE; - let bidderRequest = { + const bidderRequest = { bids: [{ bidId: '3db3773286ee59', adUnitCode: 'code' }] } - let result = spec.interpretResponse({ body: response1 }, { bidderRequest }); + const result = spec.interpretResponse({ body: response1 }, { bidderRequest }); expect(result[0].native.title).to.equal('Native Creative'); expect(result[0].native.body).to.equal('Cool description great stuff'); expect(result[0].native.body2).to.equal('Additional body text'); @@ -2126,7 +2126,7 @@ describe('AppNexusAdapter', function () { }); it('handles custom native fields as ext', function () { - let response1 = deepClone(response); + const response1 = deepClone(response); response1.tags[0].ads[0].ad_type = 'native'; response1.tags[0].ads[0].rtb.native = { ...BASE_NATIVE, @@ -2233,14 +2233,14 @@ describe('AppNexusAdapter', function () { 'ctatext4': 'Custom CTA 4', 'ctatext5': 'Custom CTA 5', }; - let bidderRequest = { + const bidderRequest = { bids: [{ bidId: '3db3773286ee59', adUnitCode: 'code' }] } - let result = spec.interpretResponse({ body: response1 }, { bidderRequest }); + const result = spec.interpretResponse({ body: response1 }, { bidderRequest }); expect(result[0].native.ext).to.deep.equal({ 'video': { 'content': '' @@ -2378,7 +2378,7 @@ describe('AppNexusAdapter', function () { }); it('should add deal_priority and deal_code', function () { - let responseWithDeal = deepClone(response); + const responseWithDeal = deepClone(response); responseWithDeal.tags[0].ads[0].ad_type = 'video'; responseWithDeal.tags[0].ads[0].deal_priority = 5; responseWithDeal.tags[0].ads[0].deal_code = '123'; @@ -2388,7 +2388,7 @@ describe('AppNexusAdapter', function () { player_height: 340, }; - let bidderRequest = { + const bidderRequest = { bids: [{ bidId: '3db3773286ee59', adUnitCode: 'code', @@ -2399,51 +2399,51 @@ describe('AppNexusAdapter', function () { } }] } - let result = spec.interpretResponse({ body: responseWithDeal }, { bidderRequest }); + const result = spec.interpretResponse({ body: responseWithDeal }, { bidderRequest }); expect(Object.keys(result[0].appnexus)).to.include.members(['buyerMemberId', 'dealPriority', 'dealCode']); expect(result[0].video.dealTier).to.equal(5); }); } it('should add advertiser id', function () { - let responseAdvertiserId = deepClone(response); + const responseAdvertiserId = deepClone(response); responseAdvertiserId.tags[0].ads[0].advertiser_id = '123'; - let bidderRequest = { + const bidderRequest = { bids: [{ bidId: '3db3773286ee59', adUnitCode: 'code' }] } - let result = spec.interpretResponse({ body: responseAdvertiserId }, { bidderRequest }); + const result = spec.interpretResponse({ body: responseAdvertiserId }, { bidderRequest }); expect(Object.keys(result[0].meta)).to.include.members(['advertiserId']); }); it('should add brand id', function () { - let responseBrandId = deepClone(response); + const responseBrandId = deepClone(response); responseBrandId.tags[0].ads[0].brand_id = 123; - let bidderRequest = { + const bidderRequest = { bids: [{ bidId: '3db3773286ee59', adUnitCode: 'code' }] } - let result = spec.interpretResponse({ body: responseBrandId }, { bidderRequest }); + const result = spec.interpretResponse({ body: responseBrandId }, { bidderRequest }); expect(Object.keys(result[0].meta)).to.include.members(['brandId']); }); it('should add advertiserDomains', function () { - let responseAdvertiserId = deepClone(response); + const responseAdvertiserId = deepClone(response); responseAdvertiserId.tags[0].ads[0].adomain = '123'; - let bidderRequest = { + const bidderRequest = { bids: [{ bidId: '3db3773286ee59', adUnitCode: 'code' }] } - let result = spec.interpretResponse({ body: responseAdvertiserId }, { bidderRequest }); + const result = spec.interpretResponse({ body: responseAdvertiserId }, { bidderRequest }); expect(Object.keys(result[0].meta)).to.include.members(['advertiserDomains']); expect(result[0].meta.advertiserDomains).to.deep.equal(['123']); }); diff --git a/test/spec/modules/appushBidAdapter_spec.js b/test/spec/modules/appushBidAdapter_spec.js index 4e177314749..b6c535c463e 100644 --- a/test/spec/modules/appushBidAdapter_spec.js +++ b/test/spec/modules/appushBidAdapter_spec.js @@ -111,7 +111,7 @@ describe('AppushBidAdapter', function () { }); it('Returns general data valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.include.all.keys( 'deviceWidth', @@ -176,7 +176,7 @@ describe('AppushBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { delete bidderRequest.uspConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('object'); expect(data.gdpr).to.have.property('consentString'); @@ -190,7 +190,7 @@ describe('AppushBidAdapter', function () { bidderRequest.uspConsent = '1---'; delete bidderRequest.gdprConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -199,7 +199,7 @@ describe('AppushBidAdapter', function () { it('Returns empty data if no valid requests are passed', function () { serverRequest = spec.buildRequests([], bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.placements).to.be.an('array').that.is.empty; }); }); @@ -225,9 +225,9 @@ describe('AppushBidAdapter', function () { } }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(banner.body[0].requestId); @@ -259,10 +259,10 @@ describe('AppushBidAdapter', function () { } }] }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -296,10 +296,10 @@ describe('AppushBidAdapter', function () { } }] }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys('requestId', 'cpm', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'native', 'meta'); expect(dataItem.native).to.have.keys('clickUrl', 'impressionTrackers', 'title', 'image') expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -330,7 +330,7 @@ describe('AppushBidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -346,7 +346,7 @@ describe('AppushBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -363,7 +363,7 @@ describe('AppushBidAdapter', function () { currency: 'USD', }] }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -376,7 +376,7 @@ describe('AppushBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/asealBidAdapter_spec.js b/test/spec/modules/asealBidAdapter_spec.js index 1d32df2765f..07e8f30e123 100644 --- a/test/spec/modules/asealBidAdapter_spec.js +++ b/test/spec/modules/asealBidAdapter_spec.js @@ -4,13 +4,12 @@ import { BIDDER_CODE, API_ENDPOINT, HEADER_AOTTER_VERSION, - WEB_SESSION_ID_KEY, + WEB_SESSION_ID_KEY, storage } from 'modules/asealBidAdapter.js'; import { getRefererInfo } from 'src/refererDetection.js'; import { newBidder } from 'src/adapters/bidderFactory.js'; import { config } from 'src/config.js'; import * as utils from 'src/utils.js'; -import { storage } from 'modules/asealBidAdapter.js'; const TEST_CLIENT_ID = 'TEST_CLIENT_ID'; const TEST_WEB_SESSION_ID = 'TEST_WEB_SESSION_ID'; @@ -87,7 +86,7 @@ describe('asealBidAdapter', () => { }); it('should return false when required params are not passed', () => { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = {}; expect(spec.isBidRequestValid(invalidBid)).to.equal(false); diff --git a/test/spec/modules/asteriobidAnalyticsAdapter_spec.js b/test/spec/modules/asteriobidAnalyticsAdapter_spec.js index 7c336d2a885..e8a1cca534b 100644 --- a/test/spec/modules/asteriobidAnalyticsAdapter_spec.js +++ b/test/spec/modules/asteriobidAnalyticsAdapter_spec.js @@ -5,10 +5,10 @@ import * as utils from 'src/utils.js'; import {expectEvents} from '../../helpers/analytics.js'; import { EVENTS } from 'src/constants.js'; -let events = require('src/events'); +const events = require('src/events'); describe('AsterioBid Analytics Adapter', function () { - let bidWonEvent = { + const bidWonEvent = { 'bidderCode': 'appnexus', 'width': 300, 'height': 250, @@ -45,7 +45,7 @@ describe('AsterioBid Analytics Adapter', function () { }); it('support custom endpoint', function () { - let custom_url = 'custom url'; + const custom_url = 'custom url'; asteriobidAnalytics.enableAnalytics({ provider: 'asteriobid', options: { @@ -58,7 +58,7 @@ describe('AsterioBid Analytics Adapter', function () { }); it('bid won event', function() { - let bundleId = 'xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx'; + const bundleId = 'xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx'; asteriobidAnalytics.enableAnalytics({ provider: 'asteriobid', options: { diff --git a/test/spec/modules/atsAnalyticsAdapter_spec.js b/test/spec/modules/atsAnalyticsAdapter_spec.js index d797584b42e..519565a709c 100644 --- a/test/spec/modules/atsAnalyticsAdapter_spec.js +++ b/test/spec/modules/atsAnalyticsAdapter_spec.js @@ -1,19 +1,19 @@ -import atsAnalyticsAdapter from '../../../modules/atsAnalyticsAdapter.js'; +import atsAnalyticsAdapter, {parseBrowser, analyticsUrl} from '../../../modules/atsAnalyticsAdapter.js'; import { expect } from 'chai'; import adapterManager from 'src/adapterManager.js'; import {server} from '../../mocks/xhr.js'; -import {parseBrowser} from '../../../modules/atsAnalyticsAdapter.js'; + import {getCoreStorageManager, getStorageManager} from '../../../src/storageManager.js'; -import {analyticsUrl} from '../../../modules/atsAnalyticsAdapter.js'; + import {EVENTS} from 'src/constants.js'; -let utils = require('src/utils'); -let events = require('src/events'); +const utils = require('src/utils'); +const events = require('src/events'); const storage = getCoreStorageManager(); let sandbox; let clock; -let now = new Date(); +const now = new Date(); describe('ats analytics adapter', function () { beforeEach(function () { @@ -43,13 +43,13 @@ describe('ats analytics adapter', function () { this.timeout(2100); - let initOptions = { + const initOptions = { pid: '10433394' }; - let auctionTimestamp = 1496510254326; + const auctionTimestamp = 1496510254326; // prepare general auction - request - let bidRequest = { + const bidRequest = { 'bidderCode': 'appnexus', 'auctionStart': 1580739265161, 'bids': [{ @@ -71,7 +71,7 @@ describe('ats analytics adapter', function () { 'auctionId': 'a5b849e5-87d7-4205-8300-d063084fcfb7' }; // prepare general auction - response - let bidResponse = { + const bidResponse = { 'height': 250, 'statusMessage': 'Bid available', 'adId': '2eddfdc0c791dc', @@ -93,7 +93,7 @@ describe('ats analytics adapter', function () { }; // what we expect after general auction - let expectedAfterBid = { + const expectedAfterBid = { 'Data': [{ 'has_envelope': true, 'adapter_version': 3, @@ -114,7 +114,7 @@ describe('ats analytics adapter', function () { }] }; - let wonRequest = { + const wonRequest = { 'adId': '2eddfdc0c791dc', 'mediaType': 'banner', 'requestId': '30c77d079cdf17', @@ -134,7 +134,7 @@ describe('ats analytics adapter', function () { }; // lets simulate that some bidders timeout - let bidTimeoutArgsV1 = [ + const bidTimeoutArgsV1 = [ { bidId: '2baa51527bd015', bidder: 'bidderOne', @@ -183,13 +183,13 @@ describe('ats analytics adapter', function () { clock.tick(2000); - let requests = server.requests.filter(req => { + const requests = server.requests.filter(req => { return req.url.indexOf(analyticsUrl) > -1; }); expect(requests.length).to.equal(1); - let realAfterBid = JSON.parse(requests[0].requestBody); + const realAfterBid = JSON.parse(requests[0].requestBody); // Step 7: assert real data after bid and expected data expect(realAfterBid['Data']).to.deep.equal(expectedAfterBid['Data']); @@ -200,51 +200,51 @@ describe('ats analytics adapter', function () { it('check browser is safari', function () { sinon.stub(atsAnalyticsAdapter, 'getUserAgent').returns('Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_5) AppleWebKit/536.25 (KHTML, like Gecko) Version/6.0 Safari/536.25'); sinon.stub(Math, 'random').returns(0.99); - let browser = parseBrowser(); + const browser = parseBrowser(); expect(browser).to.equal('Safari'); }) it('check browser is chrome', function () { sinon.stub(atsAnalyticsAdapter, 'getUserAgent').returns('Mozilla/5.0 (iPhone; CPU iPhone OS 13_3 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) CriOS/80.0.3987.95 Mobile/15E148 Safari/604.1'); sinon.stub(Math, 'random').returns(0.99); - let browser = parseBrowser(); + const browser = parseBrowser(); expect(browser).to.equal('Chrome'); }) it('check browser is edge', function () { sinon.stub(atsAnalyticsAdapter, 'getUserAgent').returns('Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.74 Safari/537.36 Edg/79.0.309.43'); sinon.stub(Math, 'random').returns(0.99); - let browser = parseBrowser(); + const browser = parseBrowser(); expect(browser).to.equal('Microsoft Edge'); }) it('check browser is firefox', function () { sinon.stub(atsAnalyticsAdapter, 'getUserAgent').returns('Mozilla/5.0 (iPhone; CPU OS 13_3_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) FxiOS/23.0 Mobile/15E148 Safari/605.1.15'); sinon.stub(Math, 'random').returns(0.99); - let browser = parseBrowser(); + const browser = parseBrowser(); expect(browser).to.equal('Firefox'); }) it('check browser is unknown', function () { sinon.stub(atsAnalyticsAdapter, 'getUserAgent').returns(undefined); sinon.stub(Math, 'random').returns(0.99); - let browser = parseBrowser(); + const browser = parseBrowser(); expect(browser).to.equal('Unknown'); }) it('should not fire analytics request if sampling rate is 0', function () { sinon.stub(atsAnalyticsAdapter, 'getUserAgent').returns('Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_5) AppleWebKit/536.25 (KHTML, like Gecko) Version/6.0 Safari/536.25'); sinon.stub(Math, 'random').returns(0.99); - let result = atsAnalyticsAdapter.shouldFireRequest(0); + const result = atsAnalyticsAdapter.shouldFireRequest(0); expect(result).to.equal(false); }) it('should fire analytics request', function () { sinon.stub(atsAnalyticsAdapter, 'getUserAgent').returns('Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_5) AppleWebKit/536.25 (KHTML, like Gecko) Version/6.0 Safari/536.25'); sinon.stub(Math, 'random').returns(0.99); // publisher can try to pass anything they want but we will set sampling rate to 100, which means we will have 1% of requests - let result = atsAnalyticsAdapter.shouldFireRequest(8); + const result = atsAnalyticsAdapter.shouldFireRequest(8); expect(result).to.equal(true); }) it('should not fire analytics request if math random is something other then 0.99', function () { sinon.stub(atsAnalyticsAdapter, 'getUserAgent').returns('Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_5) AppleWebKit/536.25 (KHTML, like Gecko) Version/6.0 Safari/536.25'); sinon.stub(Math, 'random').returns(0.98); // publisher can try to pass anything they want but we will set sampling rate to 100, which means we will have 1% of requests - let result = atsAnalyticsAdapter.shouldFireRequest(10); + const result = atsAnalyticsAdapter.shouldFireRequest(10); expect(result).to.equal(false); }) @@ -252,7 +252,7 @@ describe('ats analytics adapter', function () { sinon.stub(atsAnalyticsAdapter, 'getUserAgent').returns('Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_5) AppleWebKit/536.25 (KHTML, like Gecko) Version/6.0 Safari/536.25'); sinon.stub(Math, 'random').returns(0.99); atsAnalyticsAdapter.setSamplingCookie(10); - let samplingRate = storage.getCookie('_lr_sampling_rate'); + const samplingRate = storage.getCookie('_lr_sampling_rate'); expect(samplingRate).to.equal('10'); }) @@ -260,7 +260,7 @@ describe('ats analytics adapter', function () { sinon.stub(atsAnalyticsAdapter, 'getUserAgent').returns('Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_5) AppleWebKit/536.25 (KHTML, like Gecko) Version/6.0 Safari/536.25'); sinon.stub(Math, 'random').returns(0.99); atsAnalyticsAdapter.setSamplingCookie(0); - let samplingRate = storage.getCookie('_lr_sampling_rate'); + const samplingRate = storage.getCookie('_lr_sampling_rate'); expect(samplingRate).to.equal('0'); }) diff --git a/test/spec/modules/audiencerunBidAdapter_spec.js b/test/spec/modules/audiencerunBidAdapter_spec.js index 04a0194af54..56fdaef63d7 100644 --- a/test/spec/modules/audiencerunBidAdapter_spec.js +++ b/test/spec/modules/audiencerunBidAdapter_spec.js @@ -35,7 +35,7 @@ describe('AudienceRun bid adapter tests', function () { }); describe('isBidRequestValid', function () { - let bid = { + const bid = { bidder: 'audiencerun', params: { zoneId: '12345abcde', @@ -60,7 +60,7 @@ describe('AudienceRun bid adapter tests', function () { }); it('should return true when zoneId is valid', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = { zoneId: '12345abcde', @@ -70,7 +70,7 @@ describe('AudienceRun bid adapter tests', function () { }); it('should return false when required params are not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = {}; @@ -142,8 +142,8 @@ describe('AudienceRun bid adapter tests', function () { }); it('should send GDPR to endpoint and honor gdprApplies value', function () { - let consentString = 'bogusConsent'; - let bidderRequest = { + const consentString = 'bogusConsent'; + const bidderRequest = { gdprConsent: { consentString: consentString, gdprApplies: true, @@ -156,7 +156,7 @@ describe('AudienceRun bid adapter tests', function () { expect(payload.gdpr.consent).to.equal(consentString); expect(payload.gdpr.applies).to.equal(true); - let bidderRequest2 = { + const bidderRequest2 = { gdprConsent: { consentString: consentString, gdprApplies: false, @@ -297,7 +297,7 @@ describe('AudienceRun bid adapter tests', function () { ]; it('should get the correct bid response by display ad', function () { - let result = spec.interpretResponse(BID_SERVER_RESPONSE); + const result = spec.interpretResponse(BID_SERVER_RESPONSE); expect(Object.keys(result[0])).to.have.members( Object.keys(expectedResponse[0]) ); @@ -307,7 +307,7 @@ describe('AudienceRun bid adapter tests', function () { const response = { body: {}, }; - let result = spec.interpretResponse(response); + const result = spec.interpretResponse(response); expect(result.length).to.equal(0); }); }); diff --git a/test/spec/modules/automatadBidAdapter_spec.js b/test/spec/modules/automatadBidAdapter_spec.js index e7b68b739c7..050563d721b 100644 --- a/test/spec/modules/automatadBidAdapter_spec.js +++ b/test/spec/modules/automatadBidAdapter_spec.js @@ -5,7 +5,7 @@ import { newBidder } from 'src/adapters/bidderFactory.js' describe('automatadBidAdapter', function () { const adapter = newBidder(spec) - let bidRequestRequiredParams = { + const bidRequestRequiredParams = { bidder: 'automatad', params: {siteId: '123ad'}, mediaTypes: { @@ -23,7 +23,7 @@ describe('automatadBidAdapter', function () { bidRequestsCount: 1 } - let bidRequestAllParams = { + const bidRequestAllParams = { bidder: 'automatad', params: {siteId: '123ad', placementId: '123abc345'}, mediaTypes: { @@ -41,7 +41,7 @@ describe('automatadBidAdapter', function () { bidRequestsCount: 1 } - let expectedResponse = [{ + const expectedResponse = [{ 'body': { 'id': 'abc-123', 'seatbid': [ @@ -77,7 +77,7 @@ describe('automatadBidAdapter', function () { }) describe('isBidRequestValid', function () { - let inValidBid = Object.assign({}, bidRequestRequiredParams) + const inValidBid = Object.assign({}, bidRequestRequiredParams) delete inValidBid.params it('should return true if all params present', function () { expect(spec.isBidRequestValid(bidRequestAllParams)).to.equal(true) @@ -93,7 +93,7 @@ describe('automatadBidAdapter', function () { }) describe('buildRequests', function () { - let req = spec.buildRequests([ bidRequestRequiredParams ], { refererInfo: { } }) + const req = spec.buildRequests([ bidRequestRequiredParams ], { refererInfo: { } }) let rdata it('should have withCredentials option as true', function() { @@ -114,30 +114,30 @@ describe('automatadBidAdapter', function () { }) it('should include siteId', function () { - let r = rdata.imp[0] + const r = rdata.imp[0] expect(r.siteId !== null).to.be.true }) it('should include media types', function () { - let r = rdata.imp[0] + const r = rdata.imp[0] expect(r.media_types !== null).to.be.true }) it('should include adunit code', function () { - let r = rdata.imp[0] + const r = rdata.imp[0] expect(r.adUnitCode !== null).to.be.true }) }) describe('interpretResponse', function () { it('should get the correct bid response', function () { - let result = spec.interpretResponse(expectedResponse[0]) + const result = spec.interpretResponse(expectedResponse[0]) expect(result).to.be.an('array').that.is.not.empty expect(result[0].meta.advertiserDomains[0]).to.equal('someAdDomain'); }) it('should interpret multiple bids in seatbid', function () { - let multipleBidResponse = [{ + const multipleBidResponse = [{ 'body': { 'id': 'abc-321', 'seatbid': [ @@ -177,7 +177,7 @@ describe('automatadBidAdapter', function () { ] } }] - let result = spec.interpretResponse(multipleBidResponse[0]).map(bid => { + const result = spec.interpretResponse(multipleBidResponse[0]).map(bid => { const {requestId} = bid; return [ requestId ]; }); @@ -187,10 +187,10 @@ describe('automatadBidAdapter', function () { }) it('handles empty bid response', function () { - let response = { + const response = { body: '' } - let result = spec.interpretResponse(response) + const result = spec.interpretResponse(response) expect(result.length).to.equal(0) }) }) @@ -220,8 +220,8 @@ describe('automatadBidAdapter', function () { }); describe('onBidWon', function () { - let serverResponses = spec.interpretResponse(expectedResponse[0]) - let wonbid = serverResponses[0] + const serverResponses = spec.interpretResponse(expectedResponse[0]) + const wonbid = serverResponses[0] let ajaxStub beforeEach(() => { diff --git a/test/spec/modules/axisBidAdapter_spec.js b/test/spec/modules/axisBidAdapter_spec.js index 65f1b9cbd94..61ae6776bcd 100644 --- a/test/spec/modules/axisBidAdapter_spec.js +++ b/test/spec/modules/axisBidAdapter_spec.js @@ -140,7 +140,7 @@ describe('AxisBidAdapter', function () { }); it('Returns general data valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys('deviceWidth', 'deviceHeight', @@ -210,7 +210,7 @@ describe('AxisBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { delete bidderRequest.uspConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('object'); expect(data.gdpr).to.have.property('consentString'); @@ -224,7 +224,7 @@ describe('AxisBidAdapter', function () { bidderRequest.uspConsent = '1---'; delete bidderRequest.gdprConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -239,8 +239,8 @@ describe('AxisBidAdapter', function () { applicableSections: [8] }; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -254,8 +254,8 @@ describe('AxisBidAdapter', function () { bidderRequest.ortb2.regs.gpp = 'abc123'; bidderRequest.ortb2.regs.gpp_sid = [8]; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -285,9 +285,9 @@ describe('AxisBidAdapter', function () { } }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(banner.body[0].requestId); @@ -321,10 +321,10 @@ describe('AxisBidAdapter', function () { } }] }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta', 'width', 'height'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -358,10 +358,10 @@ describe('AxisBidAdapter', function () { } }] }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys('requestId', 'cpm', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'native', 'meta'); expect(dataItem.native).to.have.keys('clickUrl', 'impressionTrackers', 'title', 'image') expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -392,7 +392,7 @@ describe('AxisBidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -408,7 +408,7 @@ describe('AxisBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -425,7 +425,7 @@ describe('AxisBidAdapter', function () { currency: 'USD', }] }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -438,7 +438,7 @@ describe('AxisBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/axonixBidAdapter_spec.js b/test/spec/modules/axonixBidAdapter_spec.js index c1cc6d46fb2..5fd28204dac 100644 --- a/test/spec/modules/axonixBidAdapter_spec.js +++ b/test/spec/modules/axonixBidAdapter_spec.js @@ -125,7 +125,7 @@ describe('AxonixBidAdapter', function () { }); describe('isBidRequestValid', function () { - let validBids = [ + const validBids = [ { bidder: 'axonix', params: { @@ -145,7 +145,7 @@ describe('AxonixBidAdapter', function () { }, ]; - let invalidBids = [ + const invalidBids = [ { bidder: 'axonix', params: {}, @@ -156,13 +156,13 @@ describe('AxonixBidAdapter', function () { ]; it('should accept valid bids', function () { - for (let bid of validBids) { + for (const bid of validBids) { expect(spec.isBidRequestValid(bid)).to.equal(true); } }); it('should reject invalid bids', function () { - for (let bid of invalidBids) { + for (const bid of invalidBids) { expect(spec.isBidRequestValid(bid)).to.equal(false); } }); diff --git a/test/spec/modules/bedigitechBidAdapter_spec.js b/test/spec/modules/bedigitechBidAdapter_spec.js index 995a3cf6c17..2454efa63b3 100644 --- a/test/spec/modules/bedigitechBidAdapter_spec.js +++ b/test/spec/modules/bedigitechBidAdapter_spec.js @@ -118,7 +118,7 @@ describe('BedigitechAdapter', function () { ]; const result = spec.interpretResponse(response); expect(result).to.have.lengthOf(1); - let resultKeys = Object.keys(result[0]); + const resultKeys = Object.keys(result[0]); expect(resultKeys.sort()).to.deep.equal(Object.keys(expectedResponse[0]).sort()); resultKeys.forEach(function(k) { if (k === 'ad') { diff --git a/test/spec/modules/beopBidAdapter_spec.js b/test/spec/modules/beopBidAdapter_spec.js index e0acde0aa21..4fb979b149f 100644 --- a/test/spec/modules/beopBidAdapter_spec.js +++ b/test/spec/modules/beopBidAdapter_spec.js @@ -8,7 +8,7 @@ const utils = require('src/utils'); const ENDPOINT = 'https://hb.collectiveaudience.co/bid'; -let validBid = { +const validBid = { 'bidder': 'beop', 'params': { 'accountId': '5a8af500c9e77c00017e4cad' @@ -51,7 +51,7 @@ describe('BeOp Bid Adapter tests', () => { }); it('should return true if no accountId but networkId', function () { - let bid = Object.assign({}, validBid); + const bid = Object.assign({}, validBid); delete bid.params; bid.params = { 'networkId': '5a8af500c9e77c00017e4aaa' @@ -60,7 +60,7 @@ describe('BeOp Bid Adapter tests', () => { }); it('should return false if neither account or network id param found', function () { - let bid = Object.assign({}, validBid); + const bid = Object.assign({}, validBid); delete bid.params; bid.params = { 'someId': '5a8af500c9e77c00017e4aaa' @@ -69,7 +69,7 @@ describe('BeOp Bid Adapter tests', () => { }); it('should return false if account Id param is not an ObjectId', function () { - let bid = Object.assign({}, validBid); + const bid = Object.assign({}, validBid); delete bid.params; bid.params = { 'someId': '12345' @@ -78,7 +78,7 @@ describe('BeOp Bid Adapter tests', () => { }); it('should return false if there is no banner media type', function () { - let bid = Object.assign({}, validBid); + const bid = Object.assign({}, validBid); delete bid.mediaTypes; bid.mediaTypes = { 'native': { @@ -90,7 +90,7 @@ describe('BeOp Bid Adapter tests', () => { }); describe('buildRequests', function () { - let bidRequests = []; + const bidRequests = []; bidRequests.push(validBid); it('should build the request', function () { @@ -118,8 +118,8 @@ describe('BeOp Bid Adapter tests', () => { }); it('should call the endpoint with GDPR consent and pageURL info if found', function () { - let consentString = 'BOJ8RZsOJ8RZsABAB8AAAAAZ+A=='; - let bidderRequest = + const consentString = 'BOJ8RZsOJ8RZsABAB8AAAAAZ+A=='; + const bidderRequest = { 'gdprConsent': { @@ -144,7 +144,7 @@ describe('BeOp Bid Adapter tests', () => { }); it('should call the endpoint with bpsegs (stringified) data if any or [] if none', function () { - let bidderRequest = + const bidderRequest = { 'ortb2': { 'user': { @@ -169,7 +169,7 @@ describe('BeOp Bid Adapter tests', () => { expect(payload.bpsegs).to.include('910'); expect(payload.bpsegs).to.not.include('1'); - let bidderRequest2 = + const bidderRequest2 = { 'ortb2': {} }; @@ -194,7 +194,7 @@ describe('BeOp Bid Adapter tests', () => { }); describe('interpretResponse', function() { - let serverResponse = { + const serverResponse = { 'body': { 'bids': [ { @@ -276,7 +276,7 @@ describe('BeOp Bid Adapter tests', () => { }); it('should work with keywords as an array', function () { - let bid = Object.assign({}, validBid); + const bid = Object.assign({}, validBid); bid.params.keywords = ['a', 'b']; bidRequests.push(bid); config.setConfig({ @@ -291,7 +291,7 @@ describe('BeOp Bid Adapter tests', () => { }); it('should work with keywords as a string', function () { - let bid = Object.assign({}, validBid); + const bid = Object.assign({}, validBid); bid.params.keywords = 'list of keywords'; bidRequests.push(bid); config.setConfig({ @@ -305,7 +305,7 @@ describe('BeOp Bid Adapter tests', () => { }); it('should work with keywords as a string containing a comma', function () { - let bid = Object.assign({}, validBid); + const bid = Object.assign({}, validBid); bid.params.keywords = 'list, of, keywords'; bidRequests.push(bid); config.setConfig({ @@ -328,7 +328,7 @@ describe('BeOp Bid Adapter tests', () => { }); it(`should get eids from bid`, function () { - let bid = Object.assign({}, validBid); + const bid = Object.assign({}, validBid); bid.userIdAsEids = [{source: 'provider.com', uids: [{id: 'someid', atype: 1, ext: {whatever: true}}]}]; bidRequests.push(bid); @@ -340,10 +340,10 @@ describe('BeOp Bid Adapter tests', () => { }) describe('Ensure first party cookie is well managed', function () { - let bidRequests = []; + const bidRequests = []; it(`should generate a new uuid`, function () { - let bid = Object.assign({}, validBid); + const bid = Object.assign({}, validBid); bidRequests.push(bid); const request = spec.buildRequests(bidRequests, {}); const payload = JSON.parse(request.data); diff --git a/test/spec/modules/betweenBidAdapter_spec.js b/test/spec/modules/betweenBidAdapter_spec.js index a4b89ab1b65..857779ca355 100644 --- a/test/spec/modules/betweenBidAdapter_spec.js +++ b/test/spec/modules/betweenBidAdapter_spec.js @@ -13,19 +13,19 @@ describe('betweenBidAdapterTests', function () { })).to.equal(true); }); it('validate_generated_params', function () { - let bidRequestData = [{ + const bidRequestData = [{ bidId: 'bid1234', bidder: 'between', params: {w: 240, h: 400, s: 1112}, sizes: [[240, 400]] }] - let request = spec.buildRequests(bidRequestData); - let req_data = JSON.parse(request.data)[0].data; + const request = spec.buildRequests(bidRequestData); + const req_data = JSON.parse(request.data)[0].data; expect(req_data.bidid).to.equal('bid1234'); }); it('validate_video_params', function () { - let bidRequestData = [{ + const bidRequestData = [{ bidId: 'bid1234', bidder: 'between', params: {w: 240, h: 400, s: 1112}, @@ -39,8 +39,8 @@ describe('betweenBidAdapterTests', function () { } }, }]; - let request = spec.buildRequests(bidRequestData); - let req_data = JSON.parse(request.data)[0].data; + const request = spec.buildRequests(bidRequestData); + const req_data = JSON.parse(request.data)[0].data; expect(req_data.mediaType).to.equal(2); expect(req_data.maxd).to.equal(123); @@ -50,7 +50,7 @@ describe('betweenBidAdapterTests', function () { }); it('validate itu param', function() { - let bidRequestData = [{ + const bidRequestData = [{ bidId: 'bid1234', bidder: 'between', params: { @@ -62,13 +62,13 @@ describe('betweenBidAdapterTests', function () { sizes: [[240, 400]] }]; - let request = spec.buildRequests(bidRequestData); - let req_data = JSON.parse(request.data)[0].data; + const request = spec.buildRequests(bidRequestData); + const req_data = JSON.parse(request.data)[0].data; expect(req_data.itu).to.equal('https://something.url'); }); it('validate cur param', function() { - let bidRequestData = [{ + const bidRequestData = [{ bidId: 'bid1234', bidder: 'between', params: { @@ -80,13 +80,13 @@ describe('betweenBidAdapterTests', function () { sizes: [[240, 400]] }]; - let request = spec.buildRequests(bidRequestData); - let req_data = JSON.parse(request.data)[0].data; + const request = spec.buildRequests(bidRequestData); + const req_data = JSON.parse(request.data)[0].data; expect(req_data.cur).to.equal('THX'); }); it('validate default cur USD', function() { - let bidRequestData = [{ + const bidRequestData = [{ bidId: 'bid1234', bidder: 'between', params: { @@ -97,13 +97,13 @@ describe('betweenBidAdapterTests', function () { sizes: [[240, 400]] }]; - let request = spec.buildRequests(bidRequestData); - let req_data = JSON.parse(request.data)[0].data; + const request = spec.buildRequests(bidRequestData); + const req_data = JSON.parse(request.data)[0].data; expect(req_data.cur).to.equal('USD'); }); it('validate subid param', function() { - let bidRequestData = [{ + const bidRequestData = [{ bidId: 'bid1234', bidder: 'between', params: { @@ -115,8 +115,8 @@ describe('betweenBidAdapterTests', function () { sizes: [[240, 400]] }]; - let request = spec.buildRequests(bidRequestData); - let req_data = JSON.parse(request.data)[0].data; + const request = spec.buildRequests(bidRequestData); + const req_data = JSON.parse(request.data)[0].data; expect(req_data.subid).to.equal(1138); }); @@ -131,7 +131,7 @@ describe('betweenBidAdapterTests', function () { } ]; - let bidRequestData = [{ + const bidRequestData = [{ bidId: 'bid1234', bidder: 'between', params: { @@ -143,14 +143,14 @@ describe('betweenBidAdapterTests', function () { userIdAsEids: USER_ID_DATA, }]; - let request = spec.buildRequests(bidRequestData); - let req_data = JSON.parse(request.data)[0].data; + const request = spec.buildRequests(bidRequestData); + const req_data = JSON.parse(request.data)[0].data; expect(req_data.eids).to.have.deep.members(USER_ID_DATA); }); it('validate eids parameter, if userIdAsEids = undefined', function() { - let bidRequestData = [{ + const bidRequestData = [{ bidId: 'bid1234', bidder: 'between', params: { @@ -162,14 +162,14 @@ describe('betweenBidAdapterTests', function () { userIdAsEids: undefined }]; - let request = spec.buildRequests(bidRequestData); - let req_data = JSON.parse(request.data)[0].data; + const request = spec.buildRequests(bidRequestData); + const req_data = JSON.parse(request.data)[0].data; expect(req_data.eids).to.have.deep.members([]); }); it('validate click3rd param', function() { - let bidRequestData = [{ + const bidRequestData = [{ bidId: 'bid1234', bidder: 'between', params: { @@ -181,13 +181,13 @@ describe('betweenBidAdapterTests', function () { sizes: [[240, 400]] }]; - let request = spec.buildRequests(bidRequestData); - let req_data = JSON.parse(request.data)[0].data; + const request = spec.buildRequests(bidRequestData); + const req_data = JSON.parse(request.data)[0].data; expect(req_data.click3rd).to.equal('https://something.url'); }); it('validate pubdata param', function() { - let bidRequestData = [{ + const bidRequestData = [{ bidId: 'bid1234', bidder: 'between', params: { @@ -201,13 +201,13 @@ describe('betweenBidAdapterTests', function () { sizes: [[240, 400]] }]; - let request = spec.buildRequests(bidRequestData); - let req_data = JSON.parse(request.data)[0].data; + const request = spec.buildRequests(bidRequestData); + const req_data = JSON.parse(request.data)[0].data; expect(req_data['pubside_macro[param]']).to.equal('%26test%3Dtset'); }); it('validate gdprConsent', function() { - let bidRequestData = [{ + const bidRequestData = [{ bidId: 'bid1234', bidder: 'between', params: { @@ -217,21 +217,21 @@ describe('betweenBidAdapterTests', function () { }, sizes: [[240, 400]] }]; - let bidderRequest = { + const bidderRequest = { gdprConsent: { consentString: 'BOtGbjbOtGbjbBQABBENC3-AAAAtR7_______9______9uz_Ov_v_f__33e8__9v_l_7_-___u_-33d4u_1vf99yfm1-7etr3tp_87ues2_Xur__79__3z3_9pxP78k89r7337Ew_v-_v-b7JCON_IA', gdprApplies: true } } - let request = spec.buildRequests(bidRequestData, bidderRequest); - let req_data = JSON.parse(request.data)[0].data; + const request = spec.buildRequests(bidRequestData, bidderRequest); + const req_data = JSON.parse(request.data)[0].data; expect(req_data.gdprApplies).to.equal(bidderRequest.gdprConsent.gdprApplies); expect(req_data.consentString).to.equal(bidderRequest.gdprConsent.consentString); }); it('validate_response_params', function () { - let serverResponse = { + const serverResponse = { body: [{ bidid: 'bid1234', cpm: 1.12, @@ -241,9 +241,9 @@ describe('betweenBidAdapterTests', function () { ad: 'Ad html' }] }; - let bids = spec.interpretResponse(serverResponse); + const bids = spec.interpretResponse(serverResponse); expect(bids).to.have.lengthOf(1); - let bid = bids[0]; + const bid = bids[0]; expect(bid.cpm).to.equal(1.12); expect(bid.currency).to.equal('USD'); expect(bid.width).to.equal(240); @@ -253,7 +253,7 @@ describe('betweenBidAdapterTests', function () { expect(bid.ad).to.equal('Ad html'); }); it('validate_response_params', function () { - let serverResponse = { + const serverResponse = { body: [{ bidid: 'bid1234', w: 240, @@ -262,9 +262,9 @@ describe('betweenBidAdapterTests', function () { ad: 'Ad html' }] }; - let bids = spec.interpretResponse(serverResponse); + const bids = spec.interpretResponse(serverResponse); expect(bids).to.have.lengthOf(1); - let bid = bids[0]; + const bid = bids[0]; expect(bid.cpm).to.equal(0); expect(bid.currency).to.equal('USD'); expect(bid.width).to.equal(240); @@ -275,21 +275,21 @@ describe('betweenBidAdapterTests', function () { }); it('validate_response_video_params', function () { - let serverResponse = { + const serverResponse = { body: [{ mediaType: 2, vastXml: 'vastXml', }] }; - let bids = spec.interpretResponse(serverResponse); + const bids = spec.interpretResponse(serverResponse); expect(bids).to.have.lengthOf(1); - let bid = bids[0]; + const bid = bids[0]; expect(bid.mediaType).to.equal(2); expect(bid.vastXml).to.equal('vastXml'); }); it('validate response params without currency', function () { - let serverResponse = { + const serverResponse = { body: [{ bidid: 'bid1234', w: 240, @@ -297,9 +297,9 @@ describe('betweenBidAdapterTests', function () { ad: 'Ad html' }] }; - let bids = spec.interpretResponse(serverResponse); + const bids = spec.interpretResponse(serverResponse); expect(bids).to.have.lengthOf(1); - let bid = bids[0]; + const bid = bids[0]; expect(bid.currency).to.equal('USD'); }); it('check getUserSyncs', function() { @@ -310,7 +310,7 @@ describe('betweenBidAdapterTests', function () { }); it('check sizes', function() { - let bidRequestData = [{ + const bidRequestData = [{ bidId: 'bid1234', bidder: 'between', mediaTypes: { @@ -323,8 +323,8 @@ describe('betweenBidAdapterTests', function () { }, }]; - let request = spec.buildRequests(bidRequestData); - let req_data = JSON.parse(request.data)[0].data; + const request = spec.buildRequests(bidRequestData); + const req_data = JSON.parse(request.data)[0].data; expect(req_data.sizes).to.deep.equal(['970x250', '240x400', '728x90']) }); diff --git a/test/spec/modules/beyondmediaBidAdapter_spec.js b/test/spec/modules/beyondmediaBidAdapter_spec.js index b117b2c4972..77d6f55d73f 100644 --- a/test/spec/modules/beyondmediaBidAdapter_spec.js +++ b/test/spec/modules/beyondmediaBidAdapter_spec.js @@ -132,7 +132,7 @@ describe('AndBeyondMediaBidAdapter', function () { }); it('Returns general data valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys('deviceWidth', 'deviceHeight', @@ -197,7 +197,7 @@ describe('AndBeyondMediaBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { delete bidderRequest.uspConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('object'); expect(data.gdpr).to.have.property('consentString'); @@ -211,7 +211,7 @@ describe('AndBeyondMediaBidAdapter', function () { bidderRequest.uspConsent = '1---'; delete bidderRequest.gdprConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -226,8 +226,8 @@ describe('AndBeyondMediaBidAdapter', function () { applicableSections: [8] }; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -241,8 +241,8 @@ describe('AndBeyondMediaBidAdapter', function () { bidderRequest.ortb2.regs.gpp = 'abc123'; bidderRequest.ortb2.regs.gpp_sid = [8]; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -272,9 +272,9 @@ describe('AndBeyondMediaBidAdapter', function () { } }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(banner.body[0].requestId); @@ -306,10 +306,10 @@ describe('AndBeyondMediaBidAdapter', function () { } }] }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -343,10 +343,10 @@ describe('AndBeyondMediaBidAdapter', function () { } }] }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys('requestId', 'cpm', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'native', 'meta'); expect(dataItem.native).to.have.keys('clickUrl', 'impressionTrackers', 'title', 'image') expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -377,7 +377,7 @@ describe('AndBeyondMediaBidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -393,7 +393,7 @@ describe('AndBeyondMediaBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -410,7 +410,7 @@ describe('AndBeyondMediaBidAdapter', function () { currency: 'USD', }] }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -423,7 +423,7 @@ describe('AndBeyondMediaBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/bidViewability_spec.js b/test/spec/modules/bidViewability_spec.js index 276767f4b2c..e33e4a9687b 100644 --- a/test/spec/modules/bidViewability_spec.js +++ b/test/spec/modules/bidViewability_spec.js @@ -91,27 +91,27 @@ describe('#bidViewability', function() { it('should find a match by using customMatchFunction provided in config', function() { // Needs config to be passed with customMatchFunction - let bidViewabilityConfig = { + const bidViewabilityConfig = { customMatchFunction(bid, slot) { return ('AD-' + slot.getAdUnitPath()) === bid.adUnitCode; } }; - let newWinningBid = Object.assign({}, PBJS_WINNING_BID, {adUnitCode: 'AD-' + PBJS_WINNING_BID.adUnitCode}); + const newWinningBid = Object.assign({}, PBJS_WINNING_BID, {adUnitCode: 'AD-' + PBJS_WINNING_BID.adUnitCode}); // Needs pbjs.getWinningBids to be implemented with match winningBidsArray.push(newWinningBid); - let wb = bidViewability.getMatchingWinningBidForGPTSlot(bidViewabilityConfig, gptSlot); + const wb = bidViewability.getMatchingWinningBidForGPTSlot(bidViewabilityConfig, gptSlot); expect(wb).to.deep.equal(newWinningBid); }); it('should NOT find a match by using customMatchFunction provided in config', function() { // Needs config to be passed with customMatchFunction - let bidViewabilityConfig = { + const bidViewabilityConfig = { customMatchFunction(bid, slot) { return ('AD-' + slot.getAdUnitPath()) === bid.adUnitCode; } }; // Needs pbjs.getWinningBids to be implemented without match; winningBidsArray is set to empty in beforeEach - let wb = bidViewability.getMatchingWinningBidForGPTSlot(bidViewabilityConfig, gptSlot); + const wb = bidViewability.getMatchingWinningBidForGPTSlot(bidViewabilityConfig, gptSlot); expect(wb).to.equal(null); }); @@ -119,14 +119,14 @@ describe('#bidViewability', function() { // Needs config to be passed without customMatchFunction // Needs pbjs.getWinningBids to be implemented with match winningBidsArray.push(PBJS_WINNING_BID); - let wb = bidViewability.getMatchingWinningBidForGPTSlot({}, gptSlot); + const wb = bidViewability.getMatchingWinningBidForGPTSlot({}, gptSlot); expect(wb).to.deep.equal(PBJS_WINNING_BID); }); it('should NOT find a match by using default matching function', function() { // Needs config to be passed without customMatchFunction // Needs pbjs.getWinningBids to be implemented without match; winningBidsArray is set to empty in beforeEach - let wb = bidViewability.getMatchingWinningBidForGPTSlot({}, gptSlot); + const wb = bidViewability.getMatchingWinningBidForGPTSlot({}, gptSlot); expect(wb).to.equal(null); }); }); @@ -145,27 +145,27 @@ describe('#bidViewability', function() { }); it('DO NOT fire pixels if NOT mentioned in module config', function() { - let moduleConfig = {}; + const moduleConfig = {}; bidViewability.fireViewabilityPixels(moduleConfig, PBJS_WINNING_BID); expect(triggerPixelSpy.callCount).to.equal(0); }); it('fire pixels if mentioned in module config', function() { - let moduleConfig = {firePixels: true}; + const moduleConfig = {firePixels: true}; bidViewability.fireViewabilityPixels(moduleConfig, PBJS_WINNING_BID); PBJS_WINNING_BID.vurls.forEach((url, i) => { - let call = triggerPixelSpy.getCall(i); + const call = triggerPixelSpy.getCall(i); expect(call.args[0]).to.equal(url); }); }); it('USP: should include the us_privacy key when USP Consent is available', function () { - let uspDataHandlerStub = sinon.stub(uspDataHandler, 'getConsentData'); + const uspDataHandlerStub = sinon.stub(uspDataHandler, 'getConsentData'); uspDataHandlerStub.returns('1YYY'); - let moduleConfig = {firePixels: true}; + const moduleConfig = {firePixels: true}; bidViewability.fireViewabilityPixels(moduleConfig, PBJS_WINNING_BID); PBJS_WINNING_BID.vurls.forEach((url, i) => { - let call = triggerPixelSpy.getCall(i); + const call = triggerPixelSpy.getCall(i); expect(call.args[0].indexOf(url)).to.equal(0); const testurl = parse(call.args[0]); const queryObject = utils.parseQS(testurl.query); @@ -175,10 +175,10 @@ describe('#bidViewability', function() { }); it('USP: should not include the us_privacy key when USP Consent is not available', function () { - let moduleConfig = {firePixels: true}; + const moduleConfig = {firePixels: true}; bidViewability.fireViewabilityPixels(moduleConfig, PBJS_WINNING_BID); PBJS_WINNING_BID.vurls.forEach((url, i) => { - let call = triggerPixelSpy.getCall(i); + const call = triggerPixelSpy.getCall(i); expect(call.args[0].indexOf(url)).to.equal(0); const testurl = parse(call.args[0]); const queryObject = utils.parseQS(testurl.query); @@ -187,16 +187,16 @@ describe('#bidViewability', function() { }); it('GDPR: should include the GDPR keys when GDPR Consent is available', function() { - let gdprDataHandlerStub = sinon.stub(gdprDataHandler, 'getConsentData'); + const gdprDataHandlerStub = sinon.stub(gdprDataHandler, 'getConsentData'); gdprDataHandlerStub.returns({ gdprApplies: true, consentString: 'consent', addtlConsent: 'moreConsent' }); - let moduleConfig = {firePixels: true}; + const moduleConfig = {firePixels: true}; bidViewability.fireViewabilityPixels(moduleConfig, PBJS_WINNING_BID); PBJS_WINNING_BID.vurls.forEach((url, i) => { - let call = triggerPixelSpy.getCall(i); + const call = triggerPixelSpy.getCall(i); expect(call.args[0].indexOf(url)).to.equal(0); const testurl = parse(call.args[0]); const queryObject = utils.parseQS(testurl.query); @@ -208,10 +208,10 @@ describe('#bidViewability', function() { }); it('GDPR: should not include the GDPR keys when GDPR Consent is not available', function () { - let moduleConfig = {firePixels: true}; + const moduleConfig = {firePixels: true}; bidViewability.fireViewabilityPixels(moduleConfig, PBJS_WINNING_BID); PBJS_WINNING_BID.vurls.forEach((url, i) => { - let call = triggerPixelSpy.getCall(i); + const call = triggerPixelSpy.getCall(i); expect(call.args[0].indexOf(url)).to.equal(0); const testurl = parse(call.args[0]); const queryObject = utils.parseQS(testurl.query); @@ -222,15 +222,15 @@ describe('#bidViewability', function() { }); it('GDPR: should only include the GDPR keys for GDPR Consent fields with values', function () { - let gdprDataHandlerStub = sinon.stub(gdprDataHandler, 'getConsentData'); + const gdprDataHandlerStub = sinon.stub(gdprDataHandler, 'getConsentData'); gdprDataHandlerStub.returns({ gdprApplies: true, consentString: 'consent' }); - let moduleConfig = {firePixels: true}; + const moduleConfig = {firePixels: true}; bidViewability.fireViewabilityPixels(moduleConfig, PBJS_WINNING_BID); PBJS_WINNING_BID.vurls.forEach((url, i) => { - let call = triggerPixelSpy.getCall(i); + const call = triggerPixelSpy.getCall(i); expect(call.args[0].indexOf(url)).to.equal(0); const testurl = parse(call.args[0]); const queryObject = utils.parseQS(testurl.query); @@ -250,7 +250,7 @@ describe('#bidViewability', function() { let callBidViewableBidderSpy; let winningBidsArray; let triggerBillingSpy; - let adUnits = [ + const adUnits = [ { 'code': 'abc123', 'bids': [ @@ -282,14 +282,14 @@ describe('#bidViewability', function() { }) it('matching winning bid is found', function() { - let moduleConfig = { + const moduleConfig = { firePixels: true }; winningBidsArray.push(PBJS_WINNING_BID); bidViewability.impressionViewableHandler(moduleConfig, EVENT_OBJ); // fire pixels should be called PBJS_WINNING_BID.vurls.forEach((url, i) => { - let call = triggerPixelSpy.getCall(i); + const call = triggerPixelSpy.getCall(i); expect(call.args[0]).to.equal(url); }); // adapterManager.callBidViewableBidder is called with required args @@ -312,7 +312,7 @@ describe('#bidViewability', function() { }); it('should call the triggerBilling function if the viewable bid has deferBilling set to true', function() { - let moduleConfig = {}; + const moduleConfig = {}; const bid = { ...PBJS_WINNING_BID, deferBilling: true diff --git a/test/spec/modules/bidglassAdapter_spec.js b/test/spec/modules/bidglassAdapter_spec.js index 1470ec0c762..d73991273b9 100644 --- a/test/spec/modules/bidglassAdapter_spec.js +++ b/test/spec/modules/bidglassAdapter_spec.js @@ -6,7 +6,7 @@ describe('Bid Glass Adapter', function () { const adapter = newBidder(spec); describe('isBidRequestValid', function () { - let bid = { + const bid = { 'bidder': 'bidglass', 'params': { 'adUnitId': '3' @@ -23,7 +23,7 @@ describe('Bid Glass Adapter', function () { }); it('should return false when required params are not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = {}; expect(spec.isBidRequestValid(invalidBid)).to.equal(false); @@ -84,7 +84,7 @@ describe('Bid Glass Adapter', function () { }); it('should get the correct bid response', function () { - let expectedResponse = [{ + const expectedResponse = [{ 'requestId': '30b31c1838de1e', 'cpm': 0.01, 'width': 300, @@ -101,17 +101,17 @@ describe('Bid Glass Adapter', function () { } }]; - let result = spec.interpretResponse(serverResponse, serverRequest); + const result = spec.interpretResponse(serverResponse, serverRequest); expect(result[0]).to.deep.equal(expectedResponse[0]); }); it('handles empty bid response', function () { - let response = { + const response = { body: { 'bidResponses': [] } }; - let result = spec.interpretResponse(response, serverRequest); + const result = spec.interpretResponse(response, serverRequest); expect(result.length).to.equal(0); }); }); diff --git a/test/spec/modules/bidtheatreBidAdapter_spec.js b/test/spec/modules/bidtheatreBidAdapter_spec.js index 4842c43d1f0..351f59680b5 100644 --- a/test/spec/modules/bidtheatreBidAdapter_spec.js +++ b/test/spec/modules/bidtheatreBidAdapter_spec.js @@ -130,7 +130,7 @@ const VIDEO_BID_RESPONSE = { describe('BidtheatreAdapter', function () { describe('isBidRequestValid', function () { - let bid = { + const bid = { 'bidder': BIDDER_CODE, 'params': { 'publisherId': VALID_PUBLISHER_ID @@ -143,7 +143,7 @@ describe('BidtheatreAdapter', function () { }); it('should return false when required param is not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = { @@ -152,7 +152,7 @@ describe('BidtheatreAdapter', function () { }); it('should return false when required param of incorrect data type', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = { 'publisherId': 12345 @@ -161,7 +161,7 @@ describe('BidtheatreAdapter', function () { }); it('should return false when required param of incorrect length', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = { 'publisherId': '73b20b3a-12a0-4869-b54e-8d42b55786e' diff --git a/test/spec/modules/blastoBidAdapter_spec.js b/test/spec/modules/blastoBidAdapter_spec.js index 7a2c94f3b14..d0cd8e22b5e 100644 --- a/test/spec/modules/blastoBidAdapter_spec.js +++ b/test/spec/modules/blastoBidAdapter_spec.js @@ -10,7 +10,7 @@ import 'src/prebid.js'; import 'modules/currency.js'; import 'modules/userId/index.js'; import 'modules/multibid/index.js'; -import 'modules/priceFloors.js'; + import 'modules/consentManagementTcf.js'; import 'modules/consentManagementUsp.js'; @@ -196,7 +196,7 @@ describe('blastoAdapter', function () { }); it('should return false when accountID/sourceId is missing', function () { - let localbid = Object.assign({}, BANNER_BID_REQUEST); + const localbid = Object.assign({}, BANNER_BID_REQUEST); delete localbid.params.accountId; delete localbid.params.sourceId; expect(spec.isBidRequestValid(BANNER_BID_REQUEST)).to.equal(false); @@ -271,7 +271,7 @@ describe('blastoAdapter', function () { it('Empty response must return empty array', function () { const emptyResponse = null; - let response = spec.interpretResponse(emptyResponse, BANNER_BID_REQUEST); + const response = spec.interpretResponse(emptyResponse, BANNER_BID_REQUEST); expect(response).to.be.an('array').that.is.empty; }) diff --git a/test/spec/modules/bliinkBidAdapter_spec.js b/test/spec/modules/bliinkBidAdapter_spec.js index 55f76158113..0686c360723 100644 --- a/test/spec/modules/bliinkBidAdapter_spec.js +++ b/test/spec/modules/bliinkBidAdapter_spec.js @@ -171,7 +171,7 @@ const getConfigCreativeVideo = (isNoVast) => { * @return {{bidderRequestId: string, bidderCode: string, bids: {bidderWinsCount: number, adUnitCode: string, bidder: string, src: string, bidRequestsCount: number, params: {tagId: string, placement: string}, bidId: string, transactionId: string, auctionId: string, bidderRequestId: string, bidderRequestsCount: number, mediaTypes: {banner: {sizes: number[][]}}, sizes: number[][], crumbs: {pubcid: string}, ortb2Imp: {ext: {data: {pbadslot: string}}}}[], refererInfo: {referer: string, canonicalUrl: null, isAmp: boolean, reachedTop: boolean, numIframes: number}}} */ const getConfigBuildRequest = (placement) => { - let buildRequest = { + const buildRequest = { bidderRequestId: '164ddfd207e94d', bidderCode: 'bliink', bids: [getConfigBid(placement)], diff --git a/test/spec/modules/blueconicRtdProvider_spec.js b/test/spec/modules/blueconicRtdProvider_spec.js index adda2c894bf..4fe85d8a9c8 100644 --- a/test/spec/modules/blueconicRtdProvider_spec.js +++ b/test/spec/modules/blueconicRtdProvider_spec.js @@ -32,7 +32,7 @@ describe('blueconicRtdProvider', function() { ] }; - let bidConfig = { + const bidConfig = { ortb2Fragments: { global: { user: { @@ -59,7 +59,7 @@ describe('blueconicRtdProvider', function() { addRealTimeData(bidConfig.ortb2Fragments.global, rtd); - let ortb2Config = bidConfig.ortb2Fragments.global; + const ortb2Config = bidConfig.ortb2Fragments.global; expect(ortb2Config.user.data).to.deep.include.members([setConfigUserObj1, setConfigUserObj2, rtdUserObj1]); }); @@ -99,7 +99,7 @@ describe('blueconicRtdProvider', function() { addRealTimeData(bidConfig.ortb2Fragments.global, rtd); - let ortb2Config = bidConfig.ortb2Fragments.global; + const ortb2Config = bidConfig.ortb2Fragments.global; expect(ortb2Config.user.data).to.deep.include.members([userObj1, userObj2]); expect(bidConfig.ortb2Fragments.global.user.data).to.have.lengthOf(2); diff --git a/test/spec/modules/bmtmBidAdapter_spec.js b/test/spec/modules/bmtmBidAdapter_spec.js index 4de78c2fca1..4af4332f3e8 100644 --- a/test/spec/modules/bmtmBidAdapter_spec.js +++ b/test/spec/modules/bmtmBidAdapter_spec.js @@ -5,7 +5,7 @@ const BIDDER_CODE = 'bmtm'; const PLACEMENT_ID = 329; describe('brightMountainMediaBidAdapter_spec', function () { - let bidBanner = { + const bidBanner = { bidId: '2dd581a2b6281d', bidder: BIDDER_CODE, bidderRequestId: '145e1d6a7837c9', @@ -69,7 +69,7 @@ describe('brightMountainMediaBidAdapter_spec', function () { ] }; - let bidVideo = { + const bidVideo = { bidId: '2dd581a2b6281d', bidder: BIDDER_CODE, bidderRequestId: '145e1d6a7837c9', @@ -90,7 +90,7 @@ describe('brightMountainMediaBidAdapter_spec', function () { transactionId: '3bb2f6da-87a6-4029-aeb0-bfe951372e62', }; - let bidderRequest = { + const bidderRequest = { bidderCode: BIDDER_CODE, auctionId: 'fffffff-ffff-ffff-ffff-ffffffffffff', bidderRequestId: 'ffffffffffffff', @@ -120,8 +120,8 @@ describe('brightMountainMediaBidAdapter_spec', function () { }); describe('buildRequests', function () { - let request = spec.buildRequests([bidBanner], bidderRequest)[0]; - let data = JSON.parse(request.data); + const request = spec.buildRequests([bidBanner], bidderRequest)[0]; + const data = JSON.parse(request.data); it('Creates a ServerRequest object with method, URL and data', function () { expect(request).to.exist; @@ -166,12 +166,12 @@ describe('brightMountainMediaBidAdapter_spec', function () { expect(data.user.ext).to.have.property('eids'); expect(data.user.ext.eids).to.not.equal(null).and.to.not.be.undefined; expect(data.user.ext.eids.length).to.greaterThan(0); - for (let index in data.user.ext.eids) { - let eid = data.user.ext.eids[index]; + for (const index in data.user.ext.eids) { + const eid = data.user.ext.eids[index]; expect(eid.source).to.not.equal(null).and.to.not.be.undefined; expect(eid.uids).to.not.equal(null).and.to.not.be.undefined; - for (let uidsIndex in eid.uids) { - let uid = eid.uids[uidsIndex]; + for (const uidsIndex in eid.uids) { + const uid = eid.uids[uidsIndex]; expect(uid.id).to.not.equal(null).and.to.not.be.undefined; } } @@ -189,8 +189,8 @@ describe('brightMountainMediaBidAdapter_spec', function () { it('Returns valid data if array of bids is valid for video', function () { bidderRequest.bids = [bidVideo]; - let serverRequest = spec.buildRequests([bidVideo], bidderRequest)[0]; - let data = JSON.parse(serverRequest.data); + const serverRequest = spec.buildRequests([bidVideo], bidderRequest)[0]; + const data = JSON.parse(serverRequest.data); expect(data).to.be.an('object'); expect(data).to.have.property('imp'); expect(data.imp.length).to.greaterThan(0); @@ -202,7 +202,7 @@ describe('brightMountainMediaBidAdapter_spec', function () { }); describe('interpretResponse', function () { - let resObjectBanner = { + const resObjectBanner = { 'id': '2763-05f22da29b3ffb6-6959', 'bidid': 'e5b41111bec9e4a4e94b85d082f8fb08', 'seatbid': [ @@ -231,7 +231,7 @@ describe('brightMountainMediaBidAdapter_spec', function () { 'cur': 'USD' }; - let resObjectVideo = { + const resObjectVideo = { 'id': '2763-05f22da29b3ffb6-6959', 'bidid': 'e5b41111bec9e4a4e94b85d082f8fb08', 'seatbid': [ @@ -267,7 +267,7 @@ describe('brightMountainMediaBidAdapter_spec', function () { expect(bidResponse).to.be.an('array').that.is.not.empty; for (let i = 0; i < bidResponse.length; i++) { - let dataItem = bidResponse[i]; + const dataItem = bidResponse[i]; expect(dataItem.requestId).to.be.a('string'); expect(dataItem.cpm).to.be.a('number'); expect(dataItem.width).to.be.a('number'); @@ -289,7 +289,7 @@ describe('brightMountainMediaBidAdapter_spec', function () { expect(bidResponse).to.be.an('array').that.is.not.empty; for (let i = 0; i < bidResponse.length; i++) { - let dataItem = bidResponse[i]; + const dataItem = bidResponse[i]; expect(dataItem.requestId).to.be.a('string'); expect(dataItem.cpm).to.be.a('number'); expect(dataItem.width).to.be.a('number'); @@ -313,7 +313,7 @@ describe('brightMountainMediaBidAdapter_spec', function () { }); describe('getUserSyncs', function () { - let syncoptionsIframe = { + const syncoptionsIframe = { 'iframeEnabled': 'true' } it('should return iframe sync option', function () { diff --git a/test/spec/modules/boldwinBidAdapter_spec.js b/test/spec/modules/boldwinBidAdapter_spec.js index 1435ba2c28b..2a3a3f6aeb1 100644 --- a/test/spec/modules/boldwinBidAdapter_spec.js +++ b/test/spec/modules/boldwinBidAdapter_spec.js @@ -132,7 +132,7 @@ describe('BoldwinBidAdapter', function () { }); it('Returns general data valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys('deviceWidth', 'deviceHeight', @@ -200,7 +200,7 @@ describe('BoldwinBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { delete bidderRequest.uspConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('object'); expect(data.gdpr).to.have.property('consentString'); @@ -214,7 +214,7 @@ describe('BoldwinBidAdapter', function () { bidderRequest.uspConsent = '1---'; delete bidderRequest.gdprConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -229,8 +229,8 @@ describe('BoldwinBidAdapter', function () { applicableSections: [8] }; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -244,8 +244,8 @@ describe('BoldwinBidAdapter', function () { bidderRequest.ortb2.regs.gpp = 'abc123'; bidderRequest.ortb2.regs.gpp_sid = [8]; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -275,9 +275,9 @@ describe('BoldwinBidAdapter', function () { } }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(banner.body[0].requestId); @@ -309,10 +309,10 @@ describe('BoldwinBidAdapter', function () { } }] }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -346,10 +346,10 @@ describe('BoldwinBidAdapter', function () { } }] }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys('requestId', 'cpm', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'native', 'meta'); expect(dataItem.native).to.have.keys('clickUrl', 'impressionTrackers', 'title', 'image') expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -380,7 +380,7 @@ describe('BoldwinBidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -396,7 +396,7 @@ describe('BoldwinBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -413,7 +413,7 @@ describe('BoldwinBidAdapter', function () { currency: 'USD', }] }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -426,7 +426,7 @@ describe('BoldwinBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/braveBidAdapter_spec.js b/test/spec/modules/braveBidAdapter_spec.js index 29c15bc0c40..92a235a92ea 100644 --- a/test/spec/modules/braveBidAdapter_spec.js +++ b/test/spec/modules/braveBidAdapter_spec.js @@ -129,7 +129,7 @@ const response_video = { }], }; -let imgData = { +const imgData = { url: `https://example.com/image`, w: 1200, h: 627 @@ -174,7 +174,7 @@ describe('BraveBidAdapter', function() { }); it('should return false when required params are not passed', function () { - let bid = Object.assign({}, request_banner); + const bid = Object.assign({}, request_banner); bid.params = { 'IncorrectParam': 0 }; @@ -201,7 +201,7 @@ describe('BraveBidAdapter', function() { }); it('Returns empty data if no valid requests are passed', function () { - let serverRequest = spec.buildRequests([]); + const serverRequest = spec.buildRequests([]); expect(serverRequest).to.be.an('array').that.is.empty; }); }); @@ -247,7 +247,7 @@ describe('BraveBidAdapter', function() { describe('interpretResponse', function () { it('Empty response must return empty array', function() { const emptyResponse = null; - let response = spec.interpretResponse(emptyResponse); + const response = spec.interpretResponse(emptyResponse); expect(response).to.be.an('array').that.is.empty; }) @@ -271,10 +271,10 @@ describe('BraveBidAdapter', function() { ad: response_banner.seatbid[0].bid[0].adm } - let bannerResponses = spec.interpretResponse(bannerResponse); + const bannerResponses = spec.interpretResponse(bannerResponse); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType'); expect(dataItem.requestId).to.equal(expectedBidResponse.requestId); @@ -307,10 +307,10 @@ describe('BraveBidAdapter', function() { vastXml: response_video.seatbid[0].bid[0].adm } - let videoResponses = spec.interpretResponse(videoResponse); + const videoResponses = spec.interpretResponse(videoResponse); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'vastXml', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType'); expect(dataItem.requestId).to.equal(expectedBidResponse.requestId); @@ -343,10 +343,10 @@ describe('BraveBidAdapter', function() { native: {clickUrl: response_native.seatbid[0].bid[0].adm.native.link.url} } - let nativeResponses = spec.interpretResponse(nativeResponse); + const nativeResponses = spec.interpretResponse(nativeResponse); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'native', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType'); expect(dataItem.requestId).to.equal(expectedBidResponse.requestId); diff --git a/test/spec/modules/bridBidAdapter_spec.js b/test/spec/modules/bridBidAdapter_spec.js index a97e56c5ba0..4819f817427 100644 --- a/test/spec/modules/bridBidAdapter_spec.js +++ b/test/spec/modules/bridBidAdapter_spec.js @@ -49,7 +49,7 @@ describe('Brid Bid Adapter', function() { }] }; - let videoRequestCloned = deepClone(videoRequest); + const videoRequestCloned = deepClone(videoRequest); videoRequestCloned[0].ortb2 = { source: { ext: { schain: globalSchain } } }; const request = spec.buildRequests(videoRequestCloned, videoRequestCloned[0]); @@ -112,9 +112,9 @@ describe('Brid Bid Adapter', function() { }); it('Test GDPR and USP consents are present in the request', function () { - let gdprConsentString = 'BOJ8RZsOJ8RZsABAB8AAAAAZ+A=='; - let uspConsentString = '1YA-'; - let bidderRequest = { + const gdprConsentString = 'BOJ8RZsOJ8RZsABAB8AAAAAZ+A=='; + const uspConsentString = '1YA-'; + const bidderRequest = { 'bidderCode': 'brid', 'bidderRequestId': '22edbae2733bf6', 'timeout': 3000, @@ -136,8 +136,8 @@ describe('Brid Bid Adapter', function() { }); it('Test GDPR is not present', function () { - let uspConsentString = '1YA-'; - let bidderRequest = { + const uspConsentString = '1YA-'; + const bidderRequest = { 'bidderCode': 'brid', 'bidderRequestId': '22edbae2733bf6', 'timeout': 3000, @@ -153,7 +153,7 @@ describe('Brid Bid Adapter', function() { }); it('Test userSync have only one object and it should have a property type=iframe', function () { - let userSync = spec.getUserSyncs({ iframeEnabled: true }); + const userSync = spec.getUserSyncs({ iframeEnabled: true }); expect(userSync).to.be.an('array'); expect(userSync.length).to.be.equal(1); expect(userSync[0]).to.have.property('type'); @@ -161,13 +161,13 @@ describe('Brid Bid Adapter', function() { }); it('Test userSync valid sync url for iframe', function () { - let [userSync] = spec.getUserSyncs({ iframeEnabled: true }, {}, {consentString: 'anyString'}); + const [userSync] = spec.getUserSyncs({ iframeEnabled: true }, {}, {consentString: 'anyString'}); expect(userSync.url).to.contain(SYNC_URL + 'load-cookie.html?endpoint=brid&gdpr=0&gdpr_consent=anyString'); expect(userSync.type).to.be.equal('iframe'); }); it('Test userSyncs iframeEnabled=false', function () { - let userSyncs = spec.getUserSyncs({iframeEnabled: false}); + const userSyncs = spec.getUserSyncs({iframeEnabled: false}); expect(userSyncs).to.have.lengthOf(0); }); }); diff --git a/test/spec/modules/bridgewellBidAdapter_spec.js b/test/spec/modules/bridgewellBidAdapter_spec.js index 7c75300398e..629cf6b62c5 100644 --- a/test/spec/modules/bridgewellBidAdapter_spec.js +++ b/test/spec/modules/bridgewellBidAdapter_spec.js @@ -154,7 +154,7 @@ describe('bridgewellBidAdapter', function () { expect(payload.adUnits).to.be.an('array'); expect(payload.url).to.exist.and.to.equal('https://www.bridgewell.com/'); for (let i = 0, max_i = payload.adUnits.length; i < max_i; i++) { - let u = payload.adUnits[i]; + const u = payload.adUnits[i]; expect(u).to.have.property('ChannelID').that.is.a('string'); expect(u).to.not.have.property('cid'); expect(u).to.have.property('adUnitCode').and.to.equal('adunit-code-2'); @@ -199,7 +199,7 @@ describe('bridgewellBidAdapter', function () { expect(payload.adUnits).to.be.an('array'); expect(payload.url).to.exist.and.to.equal('https://www.bridgewell.com/'); for (let i = 0, max_i = payload.adUnits.length; i < max_i; i++) { - let u = payload.adUnits[i]; + const u = payload.adUnits[i]; expect(u).to.have.property('cid').that.is.a('number'); expect(u).to.not.have.property('ChannelID'); expect(u).to.have.property('adUnitCode').and.to.equal('adunit-code-2'); @@ -1165,8 +1165,8 @@ describe('bridgewellBidAdapter', function () { 'currency': 'NTD' }]; const result = spec.interpretResponse({ 'body': response }, request); - let actualBidId = result.map(obj => obj.requestId); - let expectedBidId = ['3150ccb55da321', '3150ccb55da322']; + const actualBidId = result.map(obj => obj.requestId); + const expectedBidId = ['3150ccb55da321', '3150ccb55da322']; expect(actualBidId).to.include(expectedBidId[0]).and.to.include(expectedBidId[1]); }); @@ -1263,8 +1263,8 @@ describe('bridgewellBidAdapter', function () { 'currency': 'NTD' }]; const result = spec.interpretResponse({ 'body': response }, request); - let actualBidId = result.map(obj => obj.requestId); - let expectedBidId = ['3150ccb55da321', '3150ccb55da322']; + const actualBidId = result.map(obj => obj.requestId); + const expectedBidId = ['3150ccb55da321', '3150ccb55da322']; expect(actualBidId).to.include(expectedBidId[0]).and.to.include(expectedBidId[1]); }); @@ -1318,8 +1318,8 @@ describe('bridgewellBidAdapter', function () { 'currency': 'NTD' }]; const result = spec.interpretResponse({ 'body': response }, request); - let actualBidId = result.map(obj => obj.requestId); - let expectedBidId = ['3150ccb55da321', '3150ccb55da322']; + const actualBidId = result.map(obj => obj.requestId); + const expectedBidId = ['3150ccb55da321', '3150ccb55da322']; expect(actualBidId).to.include(expectedBidId[0]).and.to.include(expectedBidId[1]); }); diff --git a/test/spec/modules/browsiAnalyticsAdapter_spec.js b/test/spec/modules/browsiAnalyticsAdapter_spec.js index 9ff724fe2d3..9d1ca8be6db 100644 --- a/test/spec/modules/browsiAnalyticsAdapter_spec.js +++ b/test/spec/modules/browsiAnalyticsAdapter_spec.js @@ -1,5 +1,5 @@ -import browsiAnalytics from '../../../modules/browsiAnalyticsAdapter.js'; -import { setStaticData, getStaticData } from '../../../modules/browsiAnalyticsAdapter.js'; +import browsiAnalytics, { setStaticData, getStaticData } from '../../../modules/browsiAnalyticsAdapter.js'; + import adapterManager from '../../../src/adapterManager'; import { expect } from 'chai'; import { EVENTS } from '../../../src/constants.js'; @@ -7,7 +7,7 @@ import { server } from '../../../test/mocks/xhr.js'; import { getGlobal } from '../../../src/prebidGlobal.js'; import * as utils from '../../../src/utils.js'; -let events = require('src/events'); +const events = require('src/events'); describe('browsi analytics adapter', function () { const timestamp = 1740559971388; diff --git a/test/spec/modules/browsiBidAdapter_spec.js b/test/spec/modules/browsiBidAdapter_spec.js index 4c585ca71b3..a4f1778af6d 100644 --- a/test/spec/modules/browsiBidAdapter_spec.js +++ b/test/spec/modules/browsiBidAdapter_spec.js @@ -142,13 +142,13 @@ describe('browsi Bid Adapter Test', function () { }); describe('interpretResponse', function () { - let bidRequest = { + const bidRequest = { 'url': ENDPOINT, 'data': { 'bidId': 'bidId1', } }; - let serverResponse = {}; + const serverResponse = {}; serverResponse.body = { bidId: 'bidId1', w: 300, @@ -190,28 +190,28 @@ describe('browsi Bid Adapter Test', function () { {url: 'http://syncUrl2', type: 'iframe'} ] } - let serverResponse = [ + const serverResponse = [ {body: bidResponse} ]; it('should return iframe type userSync', function () { - let userSyncs = spec.getUserSyncs({iframeEnabled: true, pixelEnabled: false}, serverResponse[0]); + const userSyncs = spec.getUserSyncs({iframeEnabled: true, pixelEnabled: false}, serverResponse[0]); expect(userSyncs.length).to.equal(1); - let userSync = userSyncs[0]; + const userSync = userSyncs[0]; expect(userSync.url).to.equal('http://syncUrl2'); expect(userSync.type).to.equal('iframe'); }); it('should return image type userSyncs', function () { - let userSyncs = spec.getUserSyncs({iframeEnabled: false, pixelEnabled: true}, serverResponse[0]); - let userSync = userSyncs[0]; + const userSyncs = spec.getUserSyncs({iframeEnabled: false, pixelEnabled: true}, serverResponse[0]); + const userSync = userSyncs[0]; expect(userSync.url).to.equal('http://syncUrl1'); expect(userSync.type).to.equal('image'); }); it('should handle multiple server responses', function () { - let userSyncs = spec.getUserSyncs({iframeEnabled: false, pixelEnabled: true}, serverResponse); + const userSyncs = spec.getUserSyncs({iframeEnabled: false, pixelEnabled: true}, serverResponse); expect(userSyncs.length).to.equal(1); }); it('should return empty userSyncs', function () { - let userSyncs = spec.getUserSyncs({iframeEnabled: false, pixelEnabled: false}, serverResponse); + const userSyncs = spec.getUserSyncs({iframeEnabled: false, pixelEnabled: false}, serverResponse); expect(userSyncs.length).to.equal(0); }); }); diff --git a/test/spec/modules/buzzoolaBidAdapter_spec.js b/test/spec/modules/buzzoolaBidAdapter_spec.js index 312441c4202..7b32e3c79d2 100644 --- a/test/spec/modules/buzzoolaBidAdapter_spec.js +++ b/test/spec/modules/buzzoolaBidAdapter_spec.js @@ -258,9 +258,9 @@ describe('buzzoolaBidAdapter', () => { }); describe('buildRequests', () => { - let videoBidRequests = [VIDEO_BID]; - let bannerBidRequests = [BANNER_BID]; - let nativeBidRequests = [NATIVE_BID]; + const videoBidRequests = [VIDEO_BID]; + const bannerBidRequests = [BANNER_BID]; + const nativeBidRequests = [NATIVE_BID]; const bannerRequest = spec.buildRequests(bannerBidRequests, BANNER_BID_REQUEST); const nativeRequest = spec.buildRequests(nativeBidRequests, NATIVE_BID_REQUEST); diff --git a/test/spec/modules/byDataAnalyticsAdapter_spec.js b/test/spec/modules/byDataAnalyticsAdapter_spec.js index b98b5cb7039..862a0ee79e5 100644 --- a/test/spec/modules/byDataAnalyticsAdapter_spec.js +++ b/test/spec/modules/byDataAnalyticsAdapter_spec.js @@ -2,14 +2,14 @@ import ascAdapter from 'modules/byDataAnalyticsAdapter'; import { expect } from 'chai'; import {EVENTS} from 'src/constants.js'; -let adapterManager = require('src/adapterManager').default; -let events = require('src/events'); -let auctionId = 'b70ef967-5c5b-4602-831e-f2cf16e59af2'; +const adapterManager = require('src/adapterManager').default; +const events = require('src/events'); +const auctionId = 'b70ef967-5c5b-4602-831e-f2cf16e59af2'; const initOptions = { clientId: 'asc00000', logFrequency: 1, }; -let userData = { +const userData = { 'uid': '271a8-2b86-f4a4-f59bc', 'cid': 'asc00000', 'pid': 'www.letsrun.com', @@ -24,13 +24,13 @@ let userData = { 'de': 'Desktop', 'tz': 'Asia/Calcutta' }; -let bidTimeoutArgs = [{ +const bidTimeoutArgs = [{ auctionId, bidId: '12e90cb5ddc5dea', bidder: 'appnexus', adUnitCode: 'div-gpt-ad-mrec1' }]; -let noBidArgs = { +const noBidArgs = { adUnitCode: 'div-gpt-ad-mrec1', auctionId, bidId: '14480e9832f2d2b', @@ -41,7 +41,7 @@ let noBidArgs = { src: 'client', transactionId: 'c8ee3914-1ee0-4ce6-9126-748d5692188c' } -let bidWonArgs = { +const bidWonArgs = { auctionId, adUnitCode: 'div-gpt-ad-mrec1', size: '300x250', @@ -53,7 +53,7 @@ let bidWonArgs = { cpm: 0.50 } -let auctionEndArgs = { +const auctionEndArgs = { adUnitCodes: ['div-gpt-ad-mrec1'], adUnits: [{ code: 'div-gpt-ad-mrec1', @@ -87,7 +87,7 @@ let auctionEndArgs = { ] }] } -let expectedDataArgs = { +const expectedDataArgs = { visitor_data: 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1aWQiOiIyNzFhOC0yYjg2LWY0YTQtZjU5YmMiLCJjaWQiOiJhc2MwMDAwMCIsInBpZCI6Ind3dy5sZXRzcnVuLmNvbSIsIm9zIjoiTWFjaW50b3NoIiwib3N2IjoxMC4xNTcsImJyIjoiQ2hyb21lIiwiYnJ2IjoxMDMsInNzIjp7IndpZHRoIjoxNzkyLCJoZWlnaHQiOjExMjB9LCJkZSI6IkRlc2t0b3AiLCJ0eiI6IkFzaWEvQ2FsY3V0dGEifQ.Oj3qnh--t06XO-foVmrMJCGqFfOBed09A-f7LZX5rtfBf4w1_RNRZ4F3on4TMPLonSa7GgzbcEfJS9G_amnleQ', aid: auctionId, as: 1627973484504, @@ -115,7 +115,7 @@ let expectedDataArgs = { mt: 'display', }] } -let expectedBidWonArgs = { +const expectedBidWonArgs = { visitor_data: 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1aWQiOiIyNzFhOC0yYjg2LWY0YTQtZjU5YmMiLCJjaWQiOiJhc2MwMDAwMCIsInBpZCI6Ind3dy5sZXRzcnVuLmNvbSIsIm9zIjoiTWFjaW50b3NoIiwib3N2IjoxMC4xNTcsImJyIjoiQ2hyb21lIiwiYnJ2IjoxMDMsInNzIjp7IndpZHRoIjoxNzkyLCJoZWlnaHQiOjExMjB9LCJkZSI6IkRlc2t0b3AiLCJ0eiI6IkFzaWEvQ2FsY3V0dGEifQ.Oj3qnh--t06XO-foVmrMJCGqFfOBed09A-f7LZX5rtfBf4w1_RNRZ4F3on4TMPLonSa7GgzbcEfJS9G_amnleQ', aid: auctionId, as: '', diff --git a/test/spec/modules/c1xBidAdapter_spec.js b/test/spec/modules/c1xBidAdapter_spec.js index c93b43d571b..06a95955e06 100644 --- a/test/spec/modules/c1xBidAdapter_spec.js +++ b/test/spec/modules/c1xBidAdapter_spec.js @@ -13,7 +13,7 @@ describe('C1XAdapter', () => { }); }); describe('isBidRequestValid', () => { - let bid = { + const bid = { 'bidder': BIDDER_CODE, 'adUnitCode': 'adunit-code', 'sizes': [[300, 250], [300, 600]], @@ -31,13 +31,13 @@ describe('C1XAdapter', () => { }); it('should return false when require params are not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); invalidBid.params = {}; expect(c1xAdapter.isBidRequestValid(invalidBid)).to.equal(false); }); }); describe('buildRequests', () => { - let bidRequests = [ + const bidRequests = [ { 'bidder': BIDDER_CODE, 'params': { @@ -85,7 +85,7 @@ describe('C1XAdapter', () => { expect(payloadObj.a1d).to.equal('1233'); }); it('should convert floor price to proper form and attach to request', () => { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { 'params': { @@ -102,7 +102,7 @@ describe('C1XAdapter', () => { expect(payloadObj.a1p).to.equal('4.35'); }); it('should convert pageurl to proper form and attach to request', () => { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { 'params': { @@ -112,7 +112,7 @@ describe('C1XAdapter', () => { } }); - let bidderRequest = { + const bidderRequest = { 'bidderCode': 'c1x' } bidderRequest.bids = bidRequests; @@ -123,8 +123,8 @@ describe('C1XAdapter', () => { }); it('should convert GDPR Consent to proper form and attach to request', () => { - let consentString = 'BOP2gFWOQIFovABABAENBGAAAAAAMw'; - let bidderRequest = { + const consentString = 'BOP2gFWOQIFovABABAENBGAAAAAAMw'; + const bidderRequest = { 'bidderCode': 'c1x', 'gdprConsent': { 'consentString': consentString, @@ -142,7 +142,7 @@ describe('C1XAdapter', () => { }); describe('interpretResponse', () => { - let response = { + const response = { 'bid': true, 'cpm': 1.5, 'ad': '', @@ -153,7 +153,7 @@ describe('C1XAdapter', () => { 'bidType': 'GROSS_BID' }; it('should get correct bid response', () => { - let expectedResponse = [ + const expectedResponse = [ { width: 300, height: 250, @@ -166,23 +166,23 @@ describe('C1XAdapter', () => { requestId: 'yyyy' } ]; - let bidderRequest = {}; + const bidderRequest = {}; bidderRequest.bids = [ { adUnitCode: 'c1x-test', bidId: 'yyyy' } ]; - let result = c1xAdapter.interpretResponse({ body: [response] }, bidderRequest); + const result = c1xAdapter.interpretResponse({ body: [response] }, bidderRequest); expect(Object.keys(result[0])).to.have.members(Object.keys(expectedResponse[0])); }); it('handles nobid responses', () => { - let response = { + const response = { bid: false, adId: 'c1x-test' }; - let bidderRequest = {}; - let result = c1xAdapter.interpretResponse({ body: [response] }, bidderRequest); + const bidderRequest = {}; + const result = c1xAdapter.interpretResponse({ body: [response] }, bidderRequest); expect(result.length).to.equal(0); }); }); diff --git a/test/spec/modules/cadent_aperture_mxBidAdapter_spec.js b/test/spec/modules/cadent_aperture_mxBidAdapter_spec.js index 602fc6dc6b2..de33d5ff6da 100644 --- a/test/spec/modules/cadent_aperture_mxBidAdapter_spec.js +++ b/test/spec/modules/cadent_aperture_mxBidAdapter_spec.js @@ -14,7 +14,7 @@ describe('cadent_aperture_mx Adapter', function () { describe('isBidRequestValid', function () { describe('banner request validity', function () { - let bid = { + const bid = { 'bidder': 'cadent_aperture_mx', 'params': { 'tagid': '25251' @@ -33,7 +33,7 @@ describe('cadent_aperture_mx Adapter', function () { 'bidderRequestId': '22edbae3120bf6', 'auctionId': '1d1a01234a475' }; - let badBid = { + const badBid = { 'bidder': 'cadent_aperture_mx', 'params': { 'tagid': '25251' @@ -47,7 +47,7 @@ describe('cadent_aperture_mx Adapter', function () { 'bidderRequestId': '22edbae3120bf6', 'auctionId': '1d1a01234a475' }; - let noBid = {}; + const noBid = {}; it('should return true when required params found', function () { expect(spec.isBidRequestValid(bid)).to.equal(true); @@ -57,7 +57,7 @@ describe('cadent_aperture_mx Adapter', function () { }); describe('video request validity', function () { - let bid = { + const bid = { 'bidder': 'cadent_aperture_mx', 'params': { 'tagid': '25251', @@ -78,7 +78,7 @@ describe('cadent_aperture_mx Adapter', function () { 'bidderRequestId': '22edbae3120bf6', 'auctionId': '1d1a01234a475' }; - let noInstreamBid = { + const noInstreamBid = { 'bidder': 'cadent_aperture_mx', 'params': { 'tagid': '25251', @@ -101,7 +101,7 @@ describe('cadent_aperture_mx Adapter', function () { 'auctionId': '1d1a01234a475' }; - let outstreamBid = { + const outstreamBid = { 'bidder': 'cadent_aperture_mx', 'params': { 'tagid': '25251', @@ -166,7 +166,7 @@ describe('cadent_aperture_mx Adapter', function () { }); describe('buildRequests', function () { - let bidderRequest = { + const bidderRequest = { 'bidderCode': 'cadent_aperture_mx', 'auctionId': 'e19f1eff-8b27-42a6-888d-9674e5a6130c', 'bidderRequestId': '22edbae3120bf6', @@ -289,8 +289,8 @@ describe('cadent_aperture_mx Adapter', function () { }); it('builds correctly formatted request banner object', function () { - let bidRequestWithBanner = utils.deepClone(bidderRequest.bids); - let request = spec.buildRequests(bidRequestWithBanner, bidderRequest); + const bidRequestWithBanner = utils.deepClone(bidderRequest.bids); + const request = spec.buildRequests(bidRequestWithBanner, bidderRequest); const data = JSON.parse(request.data); expect(data.imp[0].video).to.equal(undefined); expect(data.imp[0].banner).to.exist.and.to.be.a('object'); @@ -303,7 +303,7 @@ describe('cadent_aperture_mx Adapter', function () { }); it('builds correctly formatted request video object for instream', function () { - let bidRequestWithVideo = utils.deepClone(bidderRequest.bids); + const bidRequestWithVideo = utils.deepClone(bidderRequest.bids); bidRequestWithVideo[0].mediaTypes = { video: { context: 'instream', @@ -311,7 +311,7 @@ describe('cadent_aperture_mx Adapter', function () { }, }; bidRequestWithVideo[0].params.video = {}; - let request = spec.buildRequests(bidRequestWithVideo, bidderRequest); + const request = spec.buildRequests(bidRequestWithVideo, bidderRequest); const data = JSON.parse(request.data); expect(data.imp[0].video).to.exist.and.to.be.a('object'); expect(data.imp[0].video.w).to.equal(bidRequestWithVideo[0].mediaTypes.video.playerSize[0][0]); @@ -319,7 +319,7 @@ describe('cadent_aperture_mx Adapter', function () { }); it('builds correctly formatted request video object for outstream', function () { - let bidRequestWithOutstreamVideo = utils.deepClone(bidderRequest.bids); + const bidRequestWithOutstreamVideo = utils.deepClone(bidderRequest.bids); bidRequestWithOutstreamVideo[0].mediaTypes = { video: { context: 'outstream', @@ -327,7 +327,7 @@ describe('cadent_aperture_mx Adapter', function () { }, }; bidRequestWithOutstreamVideo[0].params.video = {}; - let request = spec.buildRequests(bidRequestWithOutstreamVideo, bidderRequest); + const request = spec.buildRequests(bidRequestWithOutstreamVideo, bidderRequest); const data = JSON.parse(request.data); expect(data.imp[0].video).to.exist.and.to.be.a('object'); expect(data.imp[0].video.w).to.equal(bidRequestWithOutstreamVideo[0].mediaTypes.video.playerSize[0][0]); @@ -341,7 +341,7 @@ describe('cadent_aperture_mx Adapter', function () { }); it('should have the right gdpr info when enabled', function () { - let consentString = 'OIJSZsOAFsABAB8EMXZZZZZ+A=='; + const consentString = 'OIJSZsOAFsABAB8EMXZZZZZ+A=='; const gdprBidderRequest = utils.deepClone(bidderRequest); gdprBidderRequest.gdprConsent = { 'consentString': consentString, @@ -367,7 +367,7 @@ describe('cadent_aperture_mx Adapter', function () { it('should add us privacy info to request', function() { const uspBidderRequest = utils.deepClone(bidderRequest); - let consentString = '1YNN'; + const consentString = '1YNN'; uspBidderRequest.uspConsent = consentString; let request = spec.buildRequests(uspBidderRequest.bids, uspBidderRequest); request = JSON.parse(request.data); @@ -421,7 +421,7 @@ describe('cadent_aperture_mx Adapter', function () { it('should add gpid to request if present in ext.gpid', () => { const gpid = '/12345/my-gpt-tag-0'; - let bid = utils.deepClone(bidderRequest.bids[0]); + const bid = utils.deepClone(bidderRequest.bids[0]); bid.ortb2Imp = { ext: { gpid, data: { adserver: { adslot: gpid + '1' }, pbadslot: gpid + '2' } } }; let requestWithGPID = spec.buildRequests([bid], bidderRequest); requestWithGPID = JSON.parse(requestWithGPID.data); @@ -430,7 +430,7 @@ describe('cadent_aperture_mx Adapter', function () { it('should add gpid to request if present in ext.data.adserver.adslot', () => { const gpid = '/12345/my-gpt-tag-0'; - let bid = utils.deepClone(bidderRequest.bids[0]); + const bid = utils.deepClone(bidderRequest.bids[0]); bid.ortb2Imp = { ext: { data: { adserver: { adslot: gpid }, pbadslot: gpid + '1' } } }; let requestWithGPID = spec.buildRequests([bid], bidderRequest); requestWithGPID = JSON.parse(requestWithGPID.data); @@ -439,7 +439,7 @@ describe('cadent_aperture_mx Adapter', function () { it('should add gpid to request if present in ext.data.pbadslot', () => { const gpid = '/12345/my-gpt-tag-0'; - let bid = utils.deepClone(bidderRequest.bids[0]); + const bid = utils.deepClone(bidderRequest.bids[0]); bid.ortb2Imp = { ext: { data: {}, gpid } }; let requestWithGPID = spec.buildRequests([bid], bidderRequest); requestWithGPID = JSON.parse(requestWithGPID.data); @@ -533,7 +533,7 @@ describe('cadent_aperture_mx Adapter', function () { }); describe('interpretResponse', function () { - let bid = { + const bid = { 'bidder': 'cadent_aperture_mx', 'params': { 'tagid': '25251', @@ -660,7 +660,7 @@ describe('cadent_aperture_mx Adapter', function () { }]; it('should properly format bid response', function () { - let result = spec.interpretResponse({ + const result = spec.interpretResponse({ body: serverResponse }); expect(Object.keys(result[0]).length).to.equal(Object.keys(expectedResponse[0]).length); @@ -678,7 +678,7 @@ describe('cadent_aperture_mx Adapter', function () { }); it('should return multiple bids', function () { - let result = spec.interpretResponse({ + const result = spec.interpretResponse({ body: serverResponse }); expect(Array.isArray(result.seatbid)) @@ -703,7 +703,7 @@ describe('cadent_aperture_mx Adapter', function () { }); it('returns a banner bid for non-xml creatives', function () { - let result = spec.interpretResponse({ + const result = spec.interpretResponse({ body: serverResponse }, { bidRequest: bid } ); @@ -727,7 +727,7 @@ describe('cadent_aperture_mx Adapter', function () { vastServerResponse.seatbid[0].bid[0].adm = ''; vastServerResponse.seatbid[1].bid[0].adm = ''; - let result = spec.interpretResponse({ + const result = spec.interpretResponse({ body: vastServerResponse }, { bidRequest: bid } ); @@ -747,7 +747,7 @@ describe('cadent_aperture_mx Adapter', function () { const vastServerResponse = utils.deepClone(serverResponse); vastServerResponse.seatbid[0].bid[0].adm = ''; vastServerResponse.seatbid[1].bid[0].adm = ''; - let result = spec.interpretResponse({body: vastServerResponse}, bid_outstream); + const result = spec.interpretResponse({body: vastServerResponse}, bid_outstream); const ad0 = result[0]; const ad1 = result[1]; expect(ad0.renderer).to.exist.and.to.be.a('object'); @@ -757,11 +757,11 @@ describe('cadent_aperture_mx Adapter', function () { }); it('handles nobid responses', function () { - let serverResponse = { + const serverResponse = { 'bids': [] }; - let result = spec.interpretResponse({ + const result = spec.interpretResponse({ body: serverResponse }); expect(result.length).to.equal(0); @@ -779,7 +779,7 @@ describe('cadent_aperture_mx Adapter', function () { it('returns valid advertiser domains', function () { const bidResponse = utils.deepClone(serverResponse); - let result = spec.interpretResponse({body: bidResponse}); + const result = spec.interpretResponse({body: bidResponse}); expect(result[0].meta.advertiserDomains).to.deep.equal(expectedResponse[0].meta.advertiserDomains); // case where adomains are not in request expect(result[1].meta).to.not.exist; @@ -788,7 +788,7 @@ describe('cadent_aperture_mx Adapter', function () { describe('getUserSyncs', function () { it('should register the iframe sync url', function () { - let syncs = spec.getUserSyncs({ + const syncs = spec.getUserSyncs({ iframeEnabled: true }); expect(syncs).to.not.be.an('undefined'); @@ -798,7 +798,7 @@ describe('cadent_aperture_mx Adapter', function () { }); it('should pass gdpr params', function () { - let syncs = spec.getUserSyncs({ iframeEnabled: true }, {}, { + const syncs = spec.getUserSyncs({ iframeEnabled: true }, {}, { gdprApplies: false, consentString: 'test' }); expect(syncs).to.not.be.an('undefined'); @@ -809,7 +809,7 @@ describe('cadent_aperture_mx Adapter', function () { }); it('should pass us_privacy string', function () { - let syncs = spec.getUserSyncs({ iframeEnabled: true }, {}, {}, { + const syncs = spec.getUserSyncs({ iframeEnabled: true }, {}, {}, { consentString: 'test', }); expect(syncs).to.not.be.an('undefined'); @@ -819,7 +819,7 @@ describe('cadent_aperture_mx Adapter', function () { }); it('should pass us_privacy and gdpr strings', function () { - let syncs = spec.getUserSyncs({ iframeEnabled: true }, {}, + const syncs = spec.getUserSyncs({ iframeEnabled: true }, {}, { gdprApplies: true, consentString: 'test' @@ -836,7 +836,7 @@ describe('cadent_aperture_mx Adapter', function () { }); it('should pass gpp string and section id', function() { - let syncs = spec.getUserSyncs({iframeEnabled: true}, {}, {}, {}, { + const syncs = spec.getUserSyncs({iframeEnabled: true}, {}, {}, {}, { gppString: 'abcdefgs', applicableSections: [1, 2, 4] }); @@ -846,7 +846,7 @@ describe('cadent_aperture_mx Adapter', function () { }); it('should pass us_privacy and gdpr string and gpp string', function () { - let syncs = spec.getUserSyncs({ iframeEnabled: true }, {}, + const syncs = spec.getUserSyncs({ iframeEnabled: true }, {}, { gdprApplies: true, consentString: 'test' diff --git a/test/spec/modules/carodaBidAdapter_spec.js b/test/spec/modules/carodaBidAdapter_spec.js index 7fa0827b3bf..0514e3f21a8 100644 --- a/test/spec/modules/carodaBidAdapter_spec.js +++ b/test/spec/modules/carodaBidAdapter_spec.js @@ -10,7 +10,7 @@ describe('Caroda adapter', function () { let bids = []; describe('isBidRequestValid', function () { - let bid = { + const bid = { 'bidder': 'caroda', 'params': { 'ctok': 'adf232eef344' @@ -123,7 +123,7 @@ describe('Caroda adapter', function () { } }]; - let data = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } })[0].data); + const data = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } })[0].data); assert.deepEqual(data.schain, { validation: 'strict', config: { @@ -137,12 +137,12 @@ describe('Caroda adapter', function () { app: { id: 'appid' }, }); const ortb2 = { app: { name: 'appname' } }; - let validBidRequests = [{ + const validBidRequests = [{ bid_id: 'bidId', params: { mid: '1000' }, ortb2 }]; - let request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' }, ortb2 })[0].data); + const request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' }, ortb2 })[0].data); assert.equal(request.app.id, 'appid'); assert.equal(request.app.name, 'appname'); assert.equal(request.site, undefined); @@ -164,13 +164,13 @@ describe('Caroda adapter', function () { } } }; - let validBidRequests = [{ + const validBidRequests = [{ bid_id: 'bidId', params: { mid: '1000' }, ortb2 }]; - let refererInfo = { page: 'page' }; - let request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo, ortb2 })[0].data); + const refererInfo = { page: 'page' }; + const request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo, ortb2 })[0].data); assert.deepEqual(request.site, { page: refererInfo.page, @@ -183,28 +183,28 @@ describe('Caroda adapter', function () { }); it('should send correct priceType value', function () { - let validBidRequests = [{ + const validBidRequests = [{ bid_id: 'bidId', params: { priceType: 'gross' } }]; - let request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } })[0].data); + const request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } })[0].data); assert.equal(request.price_type, 'gross'); }); it('should send currency if defined', function () { setCurrencyConfig({ adServerCurrency: 'EUR' }); - let validBidRequests = [{ params: {} }]; + const validBidRequests = [{ params: {} }]; const bidderRequest = { refererInfo: { page: 'page' } }; return addFPDToBidderRequest(bidderRequest).then(res => { - let request = JSON.parse(spec.buildRequests(validBidRequests, res)[0].data); + const request = JSON.parse(spec.buildRequests(validBidRequests, res)[0].data); assert.deepEqual(request.currency, 'EUR'); setCurrencyConfig({}); }); }); it('should pass extended ids', function () { - let validBidRequests = [{ + const validBidRequests = [{ bid_id: 'bidId', params: {}, userIdAsEids: [ @@ -213,15 +213,15 @@ describe('Caroda adapter', function () { ] }]; - let request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } })[0].data); + const request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } })[0].data); assert.deepEqual(request.user.eids, validBidRequests[0].userIdAsEids); }); describe('user privacy', function () { it('should send GDPR Consent data to adform if gdprApplies', function () { - let validBidRequests = [{ bid_id: 'bidId', params: { test: 1 } }]; - let bidderRequest = { gdprConsent: { gdprApplies: true, consentString: 'consentDataString' }, refererInfo: { page: 'page' } }; - let request = JSON.parse(spec.buildRequests(validBidRequests, bidderRequest)[0].data); + const validBidRequests = [{ bid_id: 'bidId', params: { test: 1 } }]; + const bidderRequest = { gdprConsent: { gdprApplies: true, consentString: 'consentDataString' }, refererInfo: { page: 'page' } }; + const request = JSON.parse(spec.buildRequests(validBidRequests, bidderRequest)[0].data); assert.equal(request.privacy.gdpr_consent, bidderRequest.gdprConsent.consentString); assert.equal(request.privacy.gdpr, bidderRequest.gdprConsent.gdprApplies); @@ -229,16 +229,16 @@ describe('Caroda adapter', function () { }); it('should send gdpr as number', function () { - let validBidRequests = [{ bid_id: 'bidId', params: { test: 1 } }]; - let bidderRequest = { gdprConsent: { gdprApplies: true, consentString: 'consentDataString' }, refererInfo: { page: 'page' } }; - let request = JSON.parse(spec.buildRequests(validBidRequests, bidderRequest)[0].data); + const validBidRequests = [{ bid_id: 'bidId', params: { test: 1 } }]; + const bidderRequest = { gdprConsent: { gdprApplies: true, consentString: 'consentDataString' }, refererInfo: { page: 'page' } }; + const request = JSON.parse(spec.buildRequests(validBidRequests, bidderRequest)[0].data); assert.equal(typeof request.privacy.gdpr, 'number'); assert.equal(request.privacy.gdpr, 1); }); it('should send CCPA Consent data', function () { - let validBidRequests = [{ bid_id: 'bidId', params: { test: 1 } }]; + const validBidRequests = [{ bid_id: 'bidId', params: { test: 1 } }]; let bidderRequest = { uspConsent: '1YA-', refererInfo: { page: 'page' } }; let request = JSON.parse(spec.buildRequests(validBidRequests, bidderRequest)[0].data); @@ -255,8 +255,8 @@ describe('Caroda adapter', function () { it('should not set coppa when coppa is not provided or is set to false', function () { config.setConfig({ }); - let validBidRequests = [{ bid_id: 'bidId', params: { test: 1 } }]; - let bidderRequest = { gdprConsent: { gdprApplies: true, consentString: 'consentDataString' }, refererInfo: { page: 'page' } }; + const validBidRequests = [{ bid_id: 'bidId', params: { test: 1 } }]; + const bidderRequest = { gdprConsent: { gdprApplies: true, consentString: 'consentDataString' }, refererInfo: { page: 'page' } }; let request = JSON.parse(spec.buildRequests(validBidRequests, bidderRequest)[0].data); assert.equal(request.privacy.coppa, undefined); @@ -272,8 +272,8 @@ describe('Caroda adapter', function () { config.setConfig({ coppa: true }); - let validBidRequests = [{ bid_id: 'bidId', params: { test: 1 } }]; - let request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } })[0].data); + const validBidRequests = [{ bid_id: 'bidId', params: { test: 1 } }]; + const request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } })[0].data); assert.equal(request.privacy.coppa, 1); }); diff --git a/test/spec/modules/categoryTranslation_spec.js b/test/spec/modules/categoryTranslation_spec.js index d4f6aa66c7d..3aeca0fbf75 100644 --- a/test/spec/modules/categoryTranslation_spec.js +++ b/test/spec/modules/categoryTranslation_spec.js @@ -30,7 +30,7 @@ describe('category translation', function () { } } })); - let bid = { + const bid = { meta: { primaryCatId: 'iab-1' } @@ -53,7 +53,7 @@ describe('category translation', function () { } } })); - let bid = { + const bid = { meta: { primaryCatId: 'iab-2' } @@ -63,7 +63,7 @@ describe('category translation', function () { }); it('should not make ajax call to update mapping file if data found in localstorage and is not expired', function () { - let clock = sinon.useFakeTimers(utils.timestamp()); + const clock = sinon.useFakeTimers(utils.timestamp()); getLocalStorageStub.returns(JSON.stringify({ lastUpdated: utils.timestamp(), mapping: { @@ -76,7 +76,7 @@ describe('category translation', function () { }); it('should make ajax call to update mapping file if data found in localstorage is expired', function () { - let clock = sinon.useFakeTimers(utils.timestamp()); + const clock = sinon.useFakeTimers(utils.timestamp()); getLocalStorageStub.returns(JSON.stringify({ lastUpdated: utils.timestamp() - 2 * 24 * 60 * 60 * 1000, mapping: { diff --git a/test/spec/modules/ccxBidAdapter_spec.js b/test/spec/modules/ccxBidAdapter_spec.js index 1dceeef87c9..12dc0cf61f7 100644 --- a/test/spec/modules/ccxBidAdapter_spec.js +++ b/test/spec/modules/ccxBidAdapter_spec.js @@ -4,7 +4,7 @@ import { spec } from 'modules/ccxBidAdapter.js'; import * as utils from 'src/utils.js'; describe('ccxAdapter', function () { - let bids = [ + const bids = [ { adUnitCode: 'banner', auctionId: '0b9de793-8eda-481e-a548-c187d58b28d9', @@ -47,12 +47,12 @@ describe('ccxAdapter', function () { expect(spec.isBidRequestValid(bids[1])).to.be.true; }); it('Invalid bid requests - no placementId', function () { - let bidsClone = utils.deepClone(bids); + const bidsClone = utils.deepClone(bids); bidsClone[0].params = undefined; expect(spec.isBidRequestValid(bidsClone[0])).to.be.false; }); it('Invalid bid requests - invalid banner sizes', function () { - let bidsClone = utils.deepClone(bids); + const bidsClone = utils.deepClone(bids); bidsClone[0].mediaTypes.banner.sizes = [300, 250]; expect(spec.isBidRequestValid(bidsClone[0])).to.be.false; bidsClone[0].mediaTypes.banner.sizes = [[300, 250], [750]]; @@ -61,14 +61,14 @@ describe('ccxAdapter', function () { expect(spec.isBidRequestValid(bidsClone[0])).to.be.false; }); it('Invalid bid requests - invalid video sizes', function () { - let bidsClone = utils.deepClone(bids); + const bidsClone = utils.deepClone(bids); bidsClone[1].mediaTypes.video.playerSize = []; expect(spec.isBidRequestValid(bidsClone[1])).to.be.false; bidsClone[1].mediaTypes.video.sizes = [640, 480]; expect(spec.isBidRequestValid(bidsClone[1])).to.be.false; }); it('Valid bid request - old style sizes', function () { - let bidsClone = utils.deepClone(bids); + const bidsClone = utils.deepClone(bids); delete (bidsClone[0].mediaTypes); delete (bidsClone[1].mediaTypes); expect(spec.isBidRequestValid(bidsClone[0])).to.be.true; @@ -84,16 +84,16 @@ describe('ccxAdapter', function () { }); it('Valid bid request - default', function () { - let response = spec.buildRequests(bids, {bids, bidderRequestId: 'id'}); + const response = spec.buildRequests(bids, {bids, bidderRequestId: 'id'}); expect(response).to.be.not.empty; expect(response.data).to.be.not.empty; - let data = JSON.parse(response.data); + const data = JSON.parse(response.data); expect(data).to.be.an('object'); expect(data).to.have.keys('site', 'imp', 'id', 'ext', 'device'); - let imps = [ + const imps = [ { banner: { format: [ @@ -129,8 +129,8 @@ describe('ccxAdapter', function () { }); it('Valid bid request - custom', function () { - let bidsClone = utils.deepClone(bids); - let imps = [ + const bidsClone = utils.deepClone(bids); + const imps = [ { banner: { format: [ @@ -171,20 +171,20 @@ describe('ccxAdapter', function () { bidsClone[1].params.video.skip = 1; bidsClone[1].params.video.skipafter = 5; - let response = spec.buildRequests(bidsClone, {'bids': bidsClone}); - let data = JSON.parse(response.data); + const response = spec.buildRequests(bidsClone, {'bids': bidsClone}); + const data = JSON.parse(response.data); expect(data.imp).to.deep.have.same.members(imps); }); it('Valid bid request - sizes old style', function () { - let bidsClone = utils.deepClone(bids); + const bidsClone = utils.deepClone(bids); delete (bidsClone[0].mediaTypes); delete (bidsClone[1].mediaTypes); bidsClone[0].mediaType = 'banner'; bidsClone[1].mediaType = 'video'; - let imps = [ + const imps = [ { banner: { format: [ @@ -217,18 +217,18 @@ describe('ccxAdapter', function () { } ]; - let response = spec.buildRequests(bidsClone, {'bids': bidsClone}); - let data = JSON.parse(response.data); + const response = spec.buildRequests(bidsClone, {'bids': bidsClone}); + const data = JSON.parse(response.data); expect(data.imp).to.deep.have.same.members(imps); }); it('Valid bid request - sizes old style - no media type', function () { - let bidsClone = utils.deepClone(bids); + const bidsClone = utils.deepClone(bids); delete (bidsClone[0].mediaTypes); delete (bidsClone[1]); - let imps = [ + const imps = [ { banner: { format: [ @@ -246,8 +246,8 @@ describe('ccxAdapter', function () { } ]; - let response = spec.buildRequests(bidsClone, {'bids': bidsClone}); - let data = JSON.parse(response.data); + const response = spec.buildRequests(bidsClone, {'bids': bidsClone}); + const data = JSON.parse(response.data); expect(data.imp).to.deep.have.same.members(imps); }); @@ -255,13 +255,13 @@ describe('ccxAdapter', function () { describe('GDPR conformity', function () { it('should transmit correct data', function () { - let bidsClone = utils.deepClone(bids); - let gdprConsent = { + const bidsClone = utils.deepClone(bids); + const gdprConsent = { consentString: 'awefasdfwefasdfasd', gdprApplies: true }; - let response = spec.buildRequests(bidsClone, {'bids': bidsClone, 'gdprConsent': gdprConsent}); - let data = JSON.parse(response.data); + const response = spec.buildRequests(bidsClone, {'bids': bidsClone, 'gdprConsent': gdprConsent}); + const data = JSON.parse(response.data); expect(data.regs.ext.gdpr).to.equal(1); expect(data.user.ext.consent).to.equal('awefasdfwefasdfasd'); @@ -270,15 +270,15 @@ describe('ccxAdapter', function () { describe('GDPR absence conformity', function () { it('should transmit correct data', function () { - let response = spec.buildRequests(bids, {bids}); - let data = JSON.parse(response.data); + const response = spec.buildRequests(bids, {bids}); + const data = JSON.parse(response.data); expect(data.regs).to.be.undefined; expect(data.user).to.be.undefined; }); }); - let response = { + const response = { id: '0b9de793-8eda-481e-a548-c187d58b28d9', seatbid: [ { @@ -332,7 +332,7 @@ describe('ccxAdapter', function () { describe('interpretResponse', function () { it('Valid bid response - multi', function () { - let bidResponses = [ + const bidResponses = [ { requestId: '2e56e1af51a5d7', cpm: 8.1, @@ -367,7 +367,7 @@ describe('ccxAdapter', function () { it('Valid bid response - single', function () { delete response.seatbid[0].bid[1]; - let bidResponses = [ + const bidResponses = [ { requestId: '2e56e1af51a5d7', cpm: 8.1, @@ -393,12 +393,12 @@ describe('ccxAdapter', function () { describe('getUserSyncs', function () { it('Valid syncs - all', function () { - let syncOptions = { + const syncOptions = { iframeEnabled: true, pixelEnabled: true }; - let expectedSyncs = [ + const expectedSyncs = [ { type: 'image', url: 'http://foo.sync?param=1' @@ -412,11 +412,11 @@ describe('ccxAdapter', function () { }); it('Valid syncs - only image', function () { - let syncOptions = { + const syncOptions = { iframeEnabled: false, pixelEnabled: true }; - let expectedSyncs = [ + const expectedSyncs = [ { type: 'image', url: 'http://foo.sync?param=1' } @@ -425,8 +425,8 @@ describe('ccxAdapter', function () { }); it('Valid syncs - only iframe', function () { - let syncOptions = {iframeEnabled: true, pixelEnabled: false}; - let expectedSyncs = [ + const syncOptions = {iframeEnabled: true, pixelEnabled: false}; + const expectedSyncs = [ { type: 'iframe', url: 'http://foo.sync?param=2' } @@ -435,7 +435,7 @@ describe('ccxAdapter', function () { }); it('Valid syncs - empty', function () { - let syncOptions = {iframeEnabled: true, pixelEnabled: true}; + const syncOptions = {iframeEnabled: true, pixelEnabled: true}; response.ext.usersync = {}; expect(spec.getUserSyncs(syncOptions, [{body: response}])).to.be.empty; }); @@ -443,7 +443,7 @@ describe('ccxAdapter', function () { describe('mediaTypesVideoParams', function () { it('Valid video mediaTypes', function () { - let bids = [ + const bids = [ { adUnitCode: 'video', auctionId: '0b9de793-8eda-481e-a548-c187d58b28d9', @@ -468,7 +468,7 @@ describe('ccxAdapter', function () { } ]; - let imps = [ + const imps = [ { video: { w: 640, @@ -487,10 +487,10 @@ describe('ccxAdapter', function () { } ]; - let bidsClone = utils.deepClone(bids); + const bidsClone = utils.deepClone(bids); - let response = spec.buildRequests(bidsClone, {'bids': bidsClone}); - let data = JSON.parse(response.data); + const response = spec.buildRequests(bidsClone, {'bids': bidsClone}); + const data = JSON.parse(response.data); expect(data.imp).to.deep.have.same.members(imps); }); @@ -498,12 +498,12 @@ describe('ccxAdapter', function () { describe('FLEDGE', function () { it('should properly build a request when FLEDGE is enabled', async function () { - let bidderRequest = { + const bidderRequest = { paapi: { enabled: true } }; - let bids = [ + const bids = [ { adUnitCode: 'banner', auctionId: '0b9de793-8eda-481e-a548-aaaaaaaaaaa1', @@ -528,18 +528,18 @@ describe('ccxAdapter', function () { } ]; - let ortbRequest = spec.buildRequests(bids, await addFPDToBidderRequest(bidderRequest)); - let data = JSON.parse(ortbRequest.data); + const ortbRequest = spec.buildRequests(bids, await addFPDToBidderRequest(bidderRequest)); + const data = JSON.parse(ortbRequest.data); expect(data.imp[0].ext.ae).to.equal(1); }); it('should properly build a request when FLEDGE is disabled', async function () { - let bidderRequest = { + const bidderRequest = { paapi: { enabled: false } }; - let bids = [ + const bids = [ { adUnitCode: 'banner', auctionId: '0b9de793-8eda-481e-a548-aaaaaaaaaaa2', @@ -564,8 +564,8 @@ describe('ccxAdapter', function () { } ]; - let ortbRequest = spec.buildRequests(bids, await addFPDToBidderRequest(bidderRequest)); - let data = JSON.parse(ortbRequest.data); + const ortbRequest = spec.buildRequests(bids, await addFPDToBidderRequest(bidderRequest)); + const data = JSON.parse(ortbRequest.data); expect(data.imp[0].ext.ae).to.be.undefined; }); }); diff --git a/test/spec/modules/chtnwBidAdapter_spec.js b/test/spec/modules/chtnwBidAdapter_spec.js index 0fdd1a3f19b..70e39c44015 100644 --- a/test/spec/modules/chtnwBidAdapter_spec.js +++ b/test/spec/modules/chtnwBidAdapter_spec.js @@ -28,7 +28,7 @@ describe('ChtnwAdapter', function () { }); describe('buildRequests', function () { - let bidRequests = [{ + const bidRequests = [{ code: 'adunit-code', bidder: 'chtnw', params: { @@ -49,7 +49,7 @@ describe('ChtnwAdapter', function () { }); it('Returns general data valid', function () { - let data = request.data; + const data = request.data; expect(data).to.be.an('object'); expect(data).to.have.property('bids'); expect(data).to.have.property('uuid'); @@ -59,7 +59,7 @@ describe('ChtnwAdapter', function () { }); describe('interpretResponse', function () { - let responseBody = [{ + const responseBody = [{ 'requestId': 'test', 'cpm': 0.5, 'currency': 'USD', @@ -78,19 +78,19 @@ describe('ChtnwAdapter', function () { }]; it('handles empty bid response', function () { - let response = { + const response = { body: responseBody }; - let result = spec.interpretResponse(response); + const result = spec.interpretResponse(response); expect(result.length).to.not.equal(0); expect(result[0].meta.advertiserDomains).to.be.an('array'); }); it('handles empty bid response', function () { - let response = { + const response = { body: [] }; - let result = spec.interpretResponse(response); + const result = spec.interpretResponse(response); expect(result.length).to.equal(0); }); }); @@ -100,7 +100,7 @@ describe('ChtnwAdapter', function () { const syncOptions = { 'pixelEnabled': 'true' } - let userSync = spec.getUserSyncs(syncOptions); + const userSync = spec.getUserSyncs(syncOptions); expect(userSync[0].type).to.equal('image'); expect(userSync[0].url).to.have.string('ssp'); }); diff --git a/test/spec/modules/clickforceBidAdapter_spec.js b/test/spec/modules/clickforceBidAdapter_spec.js index 99aef433890..42b0f6e5017 100644 --- a/test/spec/modules/clickforceBidAdapter_spec.js +++ b/test/spec/modules/clickforceBidAdapter_spec.js @@ -12,7 +12,7 @@ describe('ClickforceAdapter', function () { }); describe('isBidRequestValid', function () { - let bid = { + const bid = { 'bidder': 'clickforce', 'params': { 'zone': '6682' @@ -31,7 +31,7 @@ describe('ClickforceAdapter', function () { }); it('should return false when required params are not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = { 'someIncorrectParam': 0 @@ -41,7 +41,7 @@ describe('ClickforceAdapter', function () { }); describe('buildRequests', function () { - let bidRequests = [{ + const bidRequests = [{ 'bidder': 'clickforce', 'params': { 'zone': '6682' @@ -63,7 +63,7 @@ describe('ClickforceAdapter', function () { }); describe('interpretResponse', function () { - let response = [{ + const response = [{ 'cpm': 0.5, 'width': '300', 'height': '250', @@ -81,7 +81,7 @@ describe('ClickforceAdapter', function () { ] }]; - let response1 = [{ + const response1 = [{ 'cpm': 0.0625, 'width': '3', 'height': '3', @@ -108,7 +108,7 @@ describe('ClickforceAdapter', function () { 'zone': '6878' }]; - let expectedResponse = [{ + const expectedResponse = [{ 'requestId': '220ed41385952a', 'cpm': 0.5, 'width': '300', @@ -126,7 +126,7 @@ describe('ClickforceAdapter', function () { } }]; - let expectedResponse1 = [{ + const expectedResponse1 = [{ 'requestId': '2e27ec595bf1a', 'cpm': 0.0625, 'width': '3', @@ -160,21 +160,21 @@ describe('ClickforceAdapter', function () { it('should get the correct bid response by display ad', function () { let bidderRequest; - let result = spec.interpretResponse({ body: response }, {bidderRequest}); + const result = spec.interpretResponse({ body: response }, {bidderRequest}); expect(Object.keys(result[0])).to.have.members(Object.keys(expectedResponse[0])); }); it('should get the correct bid response by native ad', function () { let bidderRequest; - let result = spec.interpretResponse({ body: response1 }, {bidderRequest}); + const result = spec.interpretResponse({ body: response1 }, {bidderRequest}); expect(Object.keys(result[0])).to.have.members(Object.keys(expectedResponse1[0])); }); it('handles empty bid response', function () { - let response = { + const response = { body: {} }; - let result = spec.interpretResponse(response); + const result = spec.interpretResponse(response); expect(result.length).to.equal(0); }); }); @@ -184,7 +184,7 @@ describe('ClickforceAdapter', function () { const syncOptions = { 'iframeEnabled': 'true' } - let userSync = spec.getUserSyncs(syncOptions); + const userSync = spec.getUserSyncs(syncOptions); expect(userSync[0].type).to.equal('iframe'); expect(userSync[0].url).to.equal('https://cdn.holmesmind.com/js/capmapping.htm'); }); @@ -193,7 +193,7 @@ describe('ClickforceAdapter', function () { const syncOptions = { 'pixelEnabled': 'true' } - let userSync = spec.getUserSyncs(syncOptions); + const userSync = spec.getUserSyncs(syncOptions); expect(userSync[0].type).to.equal('image'); expect(userSync[0].url).to.equal('https://c.holmesmind.com/cm'); }); diff --git a/test/spec/modules/cointrafficBidAdapter_spec.js b/test/spec/modules/cointrafficBidAdapter_spec.js index e027b80c265..e90216d9612 100644 --- a/test/spec/modules/cointrafficBidAdapter_spec.js +++ b/test/spec/modules/cointrafficBidAdapter_spec.js @@ -14,7 +14,7 @@ const ENDPOINT_URL = 'https://apps-pbd.ctraffic.io/pb/tmp'; describe('cointrafficBidAdapter', function () { describe('isBidRequestValid', function () { /** @type {BidRequest} */ - let bidRequest = { + const bidRequest = { bidder: 'cointraffic', params: { placementId: 'testPlacementId' @@ -35,7 +35,7 @@ describe('cointrafficBidAdapter', function () { describe('buildRequests', function () { /** @type {BidRequest[]} */ - let bidRequests = [ + const bidRequests = [ { bidder: 'cointraffic', params: { @@ -65,7 +65,7 @@ describe('cointrafficBidAdapter', function () { ]; /** @type {BidderRequest} */ - let bidderRequest = { + const bidderRequest = { refererInfo: { numIframes: 0, reachedTop: true, @@ -130,7 +130,7 @@ describe('cointrafficBidAdapter', function () { describe('interpretResponse', function () { it('should get the correct bid response', function () { /** @type {BidRequest[]} */ - let bidRequest = [{ + const bidRequest = [{ method: 'POST', url: ENDPOINT_URL, data: { @@ -143,7 +143,7 @@ describe('cointrafficBidAdapter', function () { } }]; - let serverResponse = { + const serverResponse = { body: { requestId: 'bidId12345', cpm: 3.9, @@ -159,7 +159,7 @@ describe('cointrafficBidAdapter', function () { } }; - let expectedResponse = [{ + const expectedResponse = [{ requestId: 'bidId12345', cpm: 3.9, currency: 'EUR', @@ -177,13 +177,13 @@ describe('cointrafficBidAdapter', function () { } }]; - let result = spec.interpretResponse(serverResponse, bidRequest[0]); + const result = spec.interpretResponse(serverResponse, bidRequest[0]); expect(Object.keys(result)).to.deep.equal(Object.keys(expectedResponse)); }); it('should get the correct bid response without advertiser domains specified', function () { /** @type {BidRequest[]} */ - let bidRequest = [{ + const bidRequest = [{ method: 'POST', url: ENDPOINT_URL, data: { @@ -196,7 +196,7 @@ describe('cointrafficBidAdapter', function () { } }]; - let serverResponse = { + const serverResponse = { body: { requestId: 'bidId12345', cpm: 3.9, @@ -211,7 +211,7 @@ describe('cointrafficBidAdapter', function () { } }; - let expectedResponse = [{ + const expectedResponse = [{ requestId: 'bidId12345', cpm: 3.9, currency: 'EUR', @@ -227,13 +227,13 @@ describe('cointrafficBidAdapter', function () { } }]; - let result = spec.interpretResponse(serverResponse, bidRequest[0]); + const result = spec.interpretResponse(serverResponse, bidRequest[0]); expect(Object.keys(result)).to.deep.equal(Object.keys(expectedResponse)); }); it('should get the correct bid response with different currency', function () { /** @type {BidRequest[]} */ - let bidRequest = [{ + const bidRequest = [{ method: 'POST', url: ENDPOINT_URL, data: { @@ -246,7 +246,7 @@ describe('cointrafficBidAdapter', function () { } }]; - let serverResponse = { + const serverResponse = { body: { requestId: 'bidId12345', cpm: 3.9, @@ -262,7 +262,7 @@ describe('cointrafficBidAdapter', function () { } }; - let expectedResponse = [{ + const expectedResponse = [{ requestId: 'bidId12345', cpm: 3.9, currency: 'USD', @@ -282,7 +282,7 @@ describe('cointrafficBidAdapter', function () { const getConfigStub = sinon.stub(config, 'getConfig').returns('USD'); - let result = spec.interpretResponse(serverResponse, bidRequest[0]); + const result = spec.interpretResponse(serverResponse, bidRequest[0]); expect(Object.keys(result)).to.deep.equal(Object.keys(expectedResponse)); getConfigStub.restore(); @@ -290,7 +290,7 @@ describe('cointrafficBidAdapter', function () { it('should get empty bid response requested currency is not available', function () { /** @type {BidRequest[]} */ - let bidRequest = [{ + const bidRequest = [{ method: 'POST', url: ENDPOINT_URL, data: { @@ -303,13 +303,13 @@ describe('cointrafficBidAdapter', function () { } }]; - let serverResponse = {}; + const serverResponse = {}; - let expectedResponse = []; + const expectedResponse = []; const getConfigStub = sinon.stub(config, 'getConfig').returns('BTC'); - let result = spec.interpretResponse(serverResponse, bidRequest[0]); + const result = spec.interpretResponse(serverResponse, bidRequest[0]); expect(Object.keys(result)).to.deep.equal(Object.keys(expectedResponse)); getConfigStub.restore(); @@ -317,7 +317,7 @@ describe('cointrafficBidAdapter', function () { it('should get empty bid response if no server response', function () { /** @type {BidRequest[]} */ - let bidRequest = [{ + const bidRequest = [{ method: 'POST', url: ENDPOINT_URL, data: { @@ -330,11 +330,11 @@ describe('cointrafficBidAdapter', function () { } }]; - let serverResponse = {}; + const serverResponse = {}; - let expectedResponse = []; + const expectedResponse = []; - let result = spec.interpretResponse(serverResponse, bidRequest[0]); + const result = spec.interpretResponse(serverResponse, bidRequest[0]); expect(Object.keys(result)).to.deep.equal(Object.keys(expectedResponse)); }); }); diff --git a/test/spec/modules/coinzillaBidAdapter_spec.js b/test/spec/modules/coinzillaBidAdapter_spec.js index 01f22722abf..08d6c8aede9 100644 --- a/test/spec/modules/coinzillaBidAdapter_spec.js +++ b/test/spec/modules/coinzillaBidAdapter_spec.js @@ -7,7 +7,7 @@ const ENDPOINT_URL = 'https://request.czilladx.com/serve/request.php'; describe('coinzillaBidAdapter', function () { const adapter = newBidder(spec); describe('isBidRequestValid', function () { - let bid = { + const bid = { 'bidder': 'coinzilla', 'params': { placementId: 'testPlacementId' @@ -25,7 +25,7 @@ describe('coinzillaBidAdapter', function () { }); }); describe('buildRequests', function () { - let bidRequests = [ + const bidRequests = [ { 'bidder': 'coinzilla', 'params': { @@ -53,7 +53,7 @@ describe('coinzillaBidAdapter', function () { } ]; - let bidderRequests = { + const bidderRequests = { 'refererInfo': { 'numIframes': 0, 'reachedTop': true, @@ -74,7 +74,7 @@ describe('coinzillaBidAdapter', function () { }); describe('interpretResponse', function () { - let bidRequest = [ + const bidRequest = [ { 'method': 'POST', 'url': ENDPOINT_URL, @@ -87,7 +87,7 @@ describe('coinzillaBidAdapter', function () { } } ]; - let serverResponse = { + const serverResponse = { body: { 'ad': '

I am an ad

', 'cpm': 4.2, @@ -103,7 +103,7 @@ describe('coinzillaBidAdapter', function () { } }; it('should get the correct bid response', function () { - let expectedResponse = [{ + const expectedResponse = [{ 'requestId': 'bidId123', 'cpm': 4.2, 'width': 300, @@ -116,7 +116,7 @@ describe('coinzillaBidAdapter', function () { 'mediaType': 'banner', 'meta': {'advertiserDomains': ['none.com']} }]; - let result = spec.interpretResponse(serverResponse, bidRequest[0]); + const result = spec.interpretResponse(serverResponse, bidRequest[0]); expect(Object.keys(result)).to.deep.equal(Object.keys(expectedResponse)); }); }); diff --git a/test/spec/modules/colombiaBidAdapter_spec.js b/test/spec/modules/colombiaBidAdapter_spec.js index cf8aa2308dc..c4e00351f76 100644 --- a/test/spec/modules/colombiaBidAdapter_spec.js +++ b/test/spec/modules/colombiaBidAdapter_spec.js @@ -10,7 +10,7 @@ describe('colombiaBidAdapter', function () { const adapter = newBidder(spec); describe('isBidRequestValid', function () { - let bid = { + const bid = { 'bidder': 'colombia', 'params': { placementId: '307466' @@ -34,14 +34,14 @@ describe('colombiaBidAdapter', function () { }); it('should return false when require params are not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); invalidBid.params = {}; expect(spec.isBidRequestValid(invalidBid)).to.equal(false); }); }); describe('buildRequests', function () { - let bidRequests = [ + const bidRequests = [ { 'bidder': 'colombia', 'params': { @@ -69,7 +69,7 @@ describe('colombiaBidAdapter', function () { 'auctionId': '61466567-d482-4a16-96f0-fe5f25ffbdf1', } ]; - let bidderRequest = { + const bidderRequest = { refererInfo: { numIframes: 0, reachedTop: true, @@ -89,7 +89,7 @@ describe('colombiaBidAdapter', function () { }); describe('interpretResponse', function () { - let bidRequest = [ + const bidRequest = [ { 'method': 'POST', 'url': 'https://ade.clmbtech.com/cde/prebid.htm', @@ -106,7 +106,7 @@ describe('colombiaBidAdapter', function () { } ]; - let serverResponse = [{ + const serverResponse = [{ 'ad': '
This is test case for colombia adapter
', 'cpm': 3.14, 'creativeId': '6b958110-612c-4b03-b6a9-7436c9f746dc-1sk24', @@ -121,7 +121,7 @@ describe('colombiaBidAdapter', function () { }]; it('should get the correct bid response', function () { - let expectedResponse = [{ + const expectedResponse = [{ 'requestId': '23beaa6af6cdde', 'cpm': 3.14, 'width': 728, @@ -134,12 +134,12 @@ describe('colombiaBidAdapter', function () { 'referrer': 'http%3A%2F%2Flocalhost%3A9876%2F%3Fid%3D74552836', 'ad': '
This is test case for colombia adapter
' }]; - let result = spec.interpretResponse(serverResponse, bidRequest[0]); + const result = spec.interpretResponse(serverResponse, bidRequest[0]); expect(Object.keys(result[0])).to.deep.equal(Object.keys(expectedResponse[0])); }); it('handles empty bid response', function () { - let response = { + const response = { body: { 'uid': '23beaa6af6cdde', 'height': 0, @@ -149,7 +149,7 @@ describe('colombiaBidAdapter', function () { 'cpm': 0 } }; - let result = spec.interpretResponse(response, bidRequest[0]); + const result = spec.interpretResponse(response, bidRequest[0]); expect(result.length).to.equal(0); }); }); diff --git a/test/spec/modules/colossussspBidAdapter_spec.js b/test/spec/modules/colossussspBidAdapter_spec.js index 69b3dc556f0..9c92661fd54 100644 --- a/test/spec/modules/colossussspBidAdapter_spec.js +++ b/test/spec/modules/colossussspBidAdapter_spec.js @@ -2,7 +2,7 @@ import { expect } from 'chai'; import { spec } from '../../../modules/colossussspBidAdapter.js'; describe('ColossussspAdapter', function () { - let bid = { + const bid = { bidId: '2dd581a2b6281d', bidder: 'colossusssp', bidderRequestId: '145e1d6a7837c9', @@ -45,7 +45,7 @@ describe('ColossussspAdapter', function () { } } }; - let bidderRequest = { + const bidderRequest = { bidderCode: 'colossus', auctionId: 'fffffff-ffff-ffff-ffff-ffffffffffff', bidderRequestId: 'ffffffffffffff', @@ -181,7 +181,7 @@ describe('ColossussspAdapter', function () { }) it('Returns valid data if array of bids is valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys('deviceWidth', 'deviceHeight', 'language', 'secure', 'host', 'page', 'placements', 'ccpa', 'gdpr_consent', 'gdpr_require', 'userObj', 'siteObj', 'appObj'); expect(data.deviceWidth).to.be.a('number'); @@ -190,9 +190,9 @@ describe('ColossussspAdapter', function () { expect(data.secure).to.be.within(0, 1); expect(data.host).to.be.a('string'); expect(data.page).to.be.a('string'); - let placements = data['placements']; + const placements = data['placements']; for (let i = 0; i < placements.length; i++) { - let placement = placements[i]; + const placement = placements[i]; expect(placement).to.have.all.keys('placementId', 'groupId', 'eids', 'bidId', 'traffic', 'sizes', 'schain', 'floor', 'gpid', 'tid'); expect(placement.schain).to.be.an('object') expect(placement.placementId).to.be.a('number'); @@ -220,9 +220,9 @@ describe('ColossussspAdapter', function () { } } } - let serverRequest = spec.buildRequests([videoBid], bidderRequest); + const serverRequest = spec.buildRequests([videoBid], bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys('deviceWidth', 'deviceHeight', 'language', 'secure', 'host', 'page', 'placements', 'ccpa', 'gdpr_consent', 'gdpr_require', 'userObj', 'siteObj', 'appObj'); expect(data.deviceWidth).to.be.a('number'); @@ -231,9 +231,9 @@ describe('ColossussspAdapter', function () { expect(data.secure).to.be.within(0, 1); expect(data.host).to.be.a('string'); expect(data.page).to.be.a('string'); - let placements = data['placements']; + const placements = data['placements']; for (let i = 0; i < placements.length; i++) { - let placement = placements[i]; + const placement = placements[i]; expect(placement).to.have.all.keys('placementId', 'groupId', 'eids', 'bidId', 'traffic', 'schain', 'floor', 'gpid', 'sizes', 'playerSize', 'minduration', 'maxduration', 'mimes', 'protocols', 'startdelay', 'placement', 'skip', 'skipafter', 'minbitrate', 'maxbitrate', 'delivery', 'playbackmethod', 'api', 'linearity', 'tid' @@ -254,7 +254,7 @@ describe('ColossussspAdapter', function () { it('Returns empty data if no valid requests are passed', function () { serverRequest = spec.buildRequests([], bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.placements).to.be.an('array').that.is.empty; }); }); @@ -298,18 +298,18 @@ describe('ColossussspAdapter', function () { ] } ]; - let serverRequest = spec.buildRequests([clonedBid], bidderRequest); + const serverRequest = spec.buildRequests([clonedBid], bidderRequest); it('Returns valid data if array of bids is valid', function () { - let data = serverRequest.data; - let placements = data['placements']; + const data = serverRequest.data; + const placements = data['placements']; expect(data).to.be.an('object'); for (let i = 0; i < placements.length; i++) { - let placement = placements[i]; + const placement = placements[i]; expect(placement).to.have.property('eids') expect(placement.eids).to.be.an('array') expect(placement.eids.length).to.be.equal(7) - for (let index in placement.eids) { - let v = placement.eids[index]; + for (const index in placement.eids) { + const v = placement.eids[index]; expect(v).to.have.all.keys('source', 'uids') expect(v.source).to.be.oneOf(['pubcid.org', 'adserver.org', 'neustar.biz', 'identityLink', 'id5-sync.com', 'adserver.org', 'uidapi.com']) expect(v.uids).to.be.an('array'); @@ -327,8 +327,8 @@ describe('ColossussspAdapter', function () { applicableSections: [8] }; - let serverRequest = spec.buildRequests([bid], bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests([bid], bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -341,8 +341,8 @@ describe('ColossussspAdapter', function () { bidderRequest.ortb2.regs.gpp = 'abc123'; bidderRequest.ortb2.regs.gpp_sid = [8]; - let serverRequest = spec.buildRequests([bid], bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests([bid], bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -350,7 +350,7 @@ describe('ColossussspAdapter', function () { }); describe('interpretResponse', function () { - let resObject = { + const resObject = { body: [{ requestId: '123', mediaType: 'banner', @@ -372,7 +372,7 @@ describe('ColossussspAdapter', function () { it('Returns an array of valid server responses if response object is valid', function () { expect(serverResponses).to.be.an('array').that.is.not.empty; for (let i = 0; i < serverResponses.length; i++) { - let dataItem = serverResponses[i]; + const dataItem = serverResponses[i]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'meta'); expect(dataItem.requestId).to.be.a('string'); @@ -393,7 +393,7 @@ describe('ColossussspAdapter', function () { }); }); - let videoResObject = { + const videoResObject = { body: [{ requestId: '123', mediaType: 'video', @@ -415,7 +415,7 @@ describe('ColossussspAdapter', function () { it('Returns an array of valid server video responses if response object is valid', function () { expect(videoServerResponses).to.be.an('array').that.is.not.empty; for (let i = 0; i < videoServerResponses.length; i++) { - let dataItem = videoServerResponses[i]; + const dataItem = videoServerResponses[i]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'meta'); expect(dataItem.requestId).to.be.a('string'); @@ -447,7 +447,7 @@ describe('ColossussspAdapter', function () { }) describe('getUserSyncs', function () { - let userSync = spec.getUserSyncs({}, {}, { consentString: 'xxx', gdprApplies: 1 }, { consentString: '1YN-' }); + const userSync = spec.getUserSyncs({}, {}, { consentString: 'xxx', gdprApplies: 1 }, { consentString: '1YN-' }); it('Returns valid URL and type', function () { expect(userSync).to.be.an('array').with.lengthOf(1); expect(userSync[0].type).to.exist; diff --git a/test/spec/modules/compassBidAdapter_spec.js b/test/spec/modules/compassBidAdapter_spec.js index b8a6ed4789a..9eca69940f7 100644 --- a/test/spec/modules/compassBidAdapter_spec.js +++ b/test/spec/modules/compassBidAdapter_spec.js @@ -133,7 +133,7 @@ describe('CompassBidAdapter', function () { }); it('Returns general data valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys('deviceWidth', 'deviceHeight', @@ -213,7 +213,7 @@ describe('CompassBidAdapter', function () { } ]; - let serverRequest = spec.buildRequests(bids, bidderRequest); + const serverRequest = spec.buildRequests(bids, bidderRequest); const { placements } = serverRequest.data; for (let i = 0, len = placements.length; i < len; i++) { @@ -248,7 +248,7 @@ describe('CompassBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { delete bidderRequest.uspConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('object'); expect(data.gdpr).to.have.property('consentString'); @@ -262,7 +262,7 @@ describe('CompassBidAdapter', function () { bidderRequest.uspConsent = '1---'; delete bidderRequest.gdprConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -277,8 +277,8 @@ describe('CompassBidAdapter', function () { applicableSections: [8] }; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -292,8 +292,8 @@ describe('CompassBidAdapter', function () { bidderRequest.ortb2.regs.gpp = 'abc123'; bidderRequest.ortb2.regs.gpp_sid = [8]; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -323,9 +323,9 @@ describe('CompassBidAdapter', function () { } }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(banner.body[0].requestId); @@ -357,10 +357,10 @@ describe('CompassBidAdapter', function () { } }] }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -394,10 +394,10 @@ describe('CompassBidAdapter', function () { } }] }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys('requestId', 'cpm', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'native', 'meta'); expect(dataItem.native).to.have.keys('clickUrl', 'impressionTrackers', 'title', 'image') expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -428,7 +428,7 @@ describe('CompassBidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -444,7 +444,7 @@ describe('CompassBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -461,7 +461,7 @@ describe('CompassBidAdapter', function () { currency: 'USD', }] }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -474,7 +474,7 @@ describe('CompassBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/conceptxBidAdapter_spec.js b/test/spec/modules/conceptxBidAdapter_spec.js index 349ee765b71..628bbeb7f7d 100644 --- a/test/spec/modules/conceptxBidAdapter_spec.js +++ b/test/spec/modules/conceptxBidAdapter_spec.js @@ -105,13 +105,13 @@ describe('conceptxBidAdapter', function () { describe('user privacy', function () { it('should NOT send GDPR Consent data if gdprApplies equals undefined', function () { - let request = spec.buildRequests(bidderRequests, { gdprConsent: { gdprApplies: undefined, consentString: 'iDoNotConsent' } }); + const request = spec.buildRequests(bidderRequests, { gdprConsent: { gdprApplies: undefined, consentString: 'iDoNotConsent' } }); expect(request.length).to.equal(1); expect(request[0]).to.have.property('url') expect(request[0].url).to.equal(ENDPOINT_URL); }); it('should send GDPR Consent data if gdprApplies', function () { - let request = spec.buildRequests(bidderRequests, { gdprConsent: { gdprApplies: true, consentString: 'ihaveconsented' } }); + const request = spec.buildRequests(bidderRequests, { gdprConsent: { gdprApplies: true, consentString: 'ihaveconsented' } }); expect(request.length).to.equal(1); expect(request[0]).to.have.property('url') expect(request[0].url).to.equal(ENDPOINT_URL_CONSENT); diff --git a/test/spec/modules/concertAnalyticsAdapter_spec.js b/test/spec/modules/concertAnalyticsAdapter_spec.js index e6ab9c6ed94..639011ac481 100644 --- a/test/spec/modules/concertAnalyticsAdapter_spec.js +++ b/test/spec/modules/concertAnalyticsAdapter_spec.js @@ -5,15 +5,15 @@ import { EVENTS } from 'src/constants.js'; import { server } from 'test/mocks/xhr.js'; import sinon from 'sinon'; -let adapterManager = require('src/adapterManager').default; -let events = require('src/events'); +const adapterManager = require('src/adapterManager').default; +const events = require('src/events'); describe('ConcertAnalyticsAdapter', function() { let sandbox; let clock; - let timestamp = 1896134400; - let auctionId = '9f894496-10fe-4652-863d-623462bf82b8'; - let timeout = 1000; + const timestamp = 1896134400; + const auctionId = '9f894496-10fe-4652-863d-623462bf82b8'; + const timeout = 1000; before(function () { sandbox = sinon.createSandbox(); @@ -50,11 +50,11 @@ describe('ConcertAnalyticsAdapter', function() { clock.tick(3000 + 1000); const eventsToReport = ['bidResponse', 'bidWon']; - for (var i = 0; i < concertAnalytics.eventsStorage.length; i++) { + for (let i = 0; i < concertAnalytics.eventsStorage.length; i++) { expect(eventsToReport.indexOf(concertAnalytics.eventsStorage[i].event)).to.be.above(-1); } - for (var i = 0; i < eventsToReport.length; i++) { + for (let i = 0; i < eventsToReport.length; i++) { expect(concertAnalytics.eventsStorage.some(function(event) { return event.event === eventsToReport[i] })).to.equal(true); diff --git a/test/spec/modules/connatixBidAdapter_spec.js b/test/spec/modules/connatixBidAdapter_spec.js index 62c730c7cc4..ce9d2b0d966 100644 --- a/test/spec/modules/connatixBidAdapter_spec.js +++ b/test/spec/modules/connatixBidAdapter_spec.js @@ -576,7 +576,7 @@ describe('connatixBidAdapter', function () { describe('buildRequests', function () { let serverRequest; let setCookieStub, setDataInLocalStorageStub; - let bidderRequest = { + const bidderRequest = { refererInfo: { canonicalUrl: '', numIframes: 0, @@ -885,7 +885,7 @@ describe('connatixBidAdapter', function () { 'atype': 1 }] }]; - let serverRequest = spec.buildRequests(validBidRequests, {}); + const serverRequest = spec.buildRequests(validBidRequests, {}); expect(serverRequest.data.userIdList).to.deep.equal(validBidRequests[0].userIdAsEids); }); }); diff --git a/test/spec/modules/connectIdSystem_spec.js b/test/spec/modules/connectIdSystem_spec.js index 8b846a5fc72..b9650c478a4 100644 --- a/test/spec/modules/connectIdSystem_spec.js +++ b/test/spec/modules/connectIdSystem_spec.js @@ -78,7 +78,7 @@ describe('Yahoo ConnectID Submodule', () => { }); function invokeGetIdAPI(configParams, consentData) { - let result = connectIdSubmodule.getId({ + const result = connectIdSubmodule.getId({ params: configParams }, consentData); if (typeof result === 'object' && result.callback) { @@ -148,7 +148,7 @@ describe('Yahoo ConnectID Submodule', () => { it('returns an object with the stored ID from cookies for valid module configuration and sync is done', () => { const cookieData = {connectId: 'foobar'}; getCookieStub.withArgs(STORAGE_KEY).returns(JSON.stringify(cookieData)); - let result = invokeGetIdAPI({ + const result = invokeGetIdAPI({ he: HASHED_EMAIL, pixelId: PIXEL_ID }, consentData); @@ -162,7 +162,7 @@ describe('Yahoo ConnectID Submodule', () => { const last13Days = Date.now() - (60 * 60 * 24 * 1000 * 13); const cookieData = {connectId: 'foobar', he: HASHED_EMAIL, lastSynced: last13Days}; getCookieStub.withArgs(STORAGE_KEY).returns(JSON.stringify(cookieData)); - let result = invokeGetIdAPI({ + const result = invokeGetIdAPI({ he: HASHED_EMAIL, pixelId: PIXEL_ID }, consentData); @@ -180,7 +180,7 @@ describe('Yahoo ConnectID Submodule', () => { const dateNowStub = sinon.stub(Date, 'now'); dateNowStub.returns(20); const newCookieData = Object.assign({}, cookieData, {lastUsed: 20}) - let result = invokeGetIdAPI({ + const result = invokeGetIdAPI({ he: HASHED_EMAIL, pixelId: PIXEL_ID }, consentData); @@ -203,7 +203,7 @@ describe('Yahoo ConnectID Submodule', () => { getCookieStub.withArgs(STORAGE_KEY).returns(JSON.stringify(cookieData)); const dateNowStub = sinon.stub(Date, 'now'); dateNowStub.returns(20); - let result = invokeGetIdAPI({ + const result = invokeGetIdAPI({ puid: '123', pixelId: PIXEL_ID }, consentData); @@ -219,7 +219,7 @@ describe('Yahoo ConnectID Submodule', () => { const last31Days = Date.now() - (60 * 60 * 24 * 1000 * 31); const cookieData = {connectId: 'foo', he: 'email', lastSynced: last13Days, puid: '9', lastUsed: last31Days}; getCookieStub.withArgs(STORAGE_KEY).returns(JSON.stringify(cookieData)); - let result = invokeGetIdAPI({ + const result = invokeGetIdAPI({ he: HASHED_EMAIL, pixelId: PIXEL_ID }, consentData); @@ -243,7 +243,7 @@ describe('Yahoo ConnectID Submodule', () => { getCookieStub.withArgs(STORAGE_KEY).returns(JSON.stringify(cookieData)); const dateNowStub = sinon.stub(Date, 'now'); dateNowStub.returns(20); - let result = invokeGetIdAPI({ + const result = invokeGetIdAPI({ he: HASHED_EMAIL, pixelId: PIXEL_ID }, consentData); @@ -257,7 +257,7 @@ describe('Yahoo ConnectID Submodule', () => { it('returns an object with the stored ID from localStorage for valid module configuration and sync is done', () => { const localStorageData = {connectId: 'foobarbaz'}; getLocalStorageStub.withArgs(STORAGE_KEY).returns(localStorageData); - let result = invokeGetIdAPI({ + const result = invokeGetIdAPI({ he: HASHED_EMAIL, pixelId: PIXEL_ID }, consentData); @@ -272,7 +272,7 @@ describe('Yahoo ConnectID Submodule', () => { getLocalStorageStub.withArgs(STORAGE_KEY).returns(localStorageData); const dateNowStub = sinon.stub(Date, 'now'); dateNowStub.returns(1); - let result = invokeGetIdAPI({ + const result = invokeGetIdAPI({ he: HASHED_EMAIL, pixelId: PIXEL_ID }, consentData); @@ -293,7 +293,7 @@ describe('Yahoo ConnectID Submodule', () => { const cookieData = {connectId: 'foo', he: 'email', lastSynced: last2Days, puid: '9', lastUsed: last21Days, ttl}; getCookieStub.withArgs(STORAGE_KEY).returns(JSON.stringify(cookieData)); - let result = invokeGetIdAPI({ + const result = invokeGetIdAPI({ he: HASHED_EMAIL, pixelId: PIXEL_ID }, consentData); @@ -310,7 +310,7 @@ describe('Yahoo ConnectID Submodule', () => { const cookieData = {connectId: 'foo', he: HASHED_EMAIL, lastSynced: last2Days, puid: '9', lastUsed: last21Days, ttl}; getCookieStub.withArgs(STORAGE_KEY).returns(JSON.stringify(cookieData)); - let result = invokeGetIdAPI({ + const result = invokeGetIdAPI({ he: HASHED_EMAIL, pixelId: PIXEL_ID }, consentData); @@ -327,7 +327,7 @@ describe('Yahoo ConnectID Submodule', () => { const cookieData = {connectId: 'foo', he: HASHED_EMAIL, lastSynced: last2Days, puid: '9', lastUsed: last21Days, ttl}; getCookieStub.withArgs(STORAGE_KEY).returns(JSON.stringify(cookieData)); - let result = invokeGetIdAPI({ + const result = invokeGetIdAPI({ he: HASHED_EMAIL, pixelId: PIXEL_ID, puid: '9' @@ -348,7 +348,7 @@ describe('Yahoo ConnectID Submodule', () => { getRefererInfoStub.returns({ ref: 'https://dev.fc.yahoo.com?test' }); - let result = invokeGetIdAPI({ + const result = invokeGetIdAPI({ he: HASHED_EMAIL, pixelId: PIXEL_ID }, consentData); @@ -467,7 +467,7 @@ describe('Yahoo ConnectID Submodule', () => { it('deletes local storage data when expiry has passed', () => { const localStorageData = {connectId: 'foobarbaz', __expires: Date.now() - 10000}; getLocalStorageStub.withArgs(STORAGE_KEY).returns(localStorageData); - let result = invokeGetIdAPI({ + const result = invokeGetIdAPI({ he: HASHED_EMAIL, pixelId: PIXEL_ID }, consentData); @@ -480,7 +480,7 @@ describe('Yahoo ConnectID Submodule', () => { it('will not delete local storage data when expiry has not passed', () => { const localStorageData = {connectId: 'foobarbaz', __expires: Date.now() + 10000}; getLocalStorageStub.withArgs(STORAGE_KEY).returns(localStorageData); - let result = invokeGetIdAPI({ + const result = invokeGetIdAPI({ he: HASHED_EMAIL, pixelId: PIXEL_ID }, consentData); @@ -491,7 +491,7 @@ describe('Yahoo ConnectID Submodule', () => { describe('when no data in client storage', () => { it('returns an object with the callback function if the endpoint override param and the he params are passed', () => { - let result = invokeGetIdAPI({ + const result = invokeGetIdAPI({ he: HASHED_EMAIL, endpoint: OVERRIDE_ENDPOINT }, consentData); @@ -500,7 +500,7 @@ describe('Yahoo ConnectID Submodule', () => { }); it('returns an object with the callback function if the endpoint override param and the puid params are passed', () => { - let result = invokeGetIdAPI({ + const result = invokeGetIdAPI({ puid: PUBLISHER_USER_ID, endpoint: OVERRIDE_ENDPOINT }, consentData); @@ -509,7 +509,7 @@ describe('Yahoo ConnectID Submodule', () => { }); it('returns an object with the callback function if the endpoint override param and the puid and he params are passed', () => { - let result = invokeGetIdAPI({ + const result = invokeGetIdAPI({ he: HASHED_EMAIL, puid: PUBLISHER_USER_ID, endpoint: OVERRIDE_ENDPOINT @@ -519,7 +519,7 @@ describe('Yahoo ConnectID Submodule', () => { }); it('returns an object with the callback function if the pixelId and he params are passed', () => { - let result = invokeGetIdAPI({ + const result = invokeGetIdAPI({ he: HASHED_EMAIL, pixelId: PIXEL_ID }, consentData); @@ -528,7 +528,7 @@ describe('Yahoo ConnectID Submodule', () => { }); it('returns an object with the callback function if the pixelId and puid params are passed', () => { - let result = invokeGetIdAPI({ + const result = invokeGetIdAPI({ puid: PUBLISHER_USER_ID, pixelId: PIXEL_ID }, consentData); @@ -537,7 +537,7 @@ describe('Yahoo ConnectID Submodule', () => { }); it('returns an object with the callback function if the pixelId, he and puid params are passed', () => { - let result = invokeGetIdAPI({ + const result = invokeGetIdAPI({ he: HASHED_EMAIL, puid: PUBLISHER_USER_ID, pixelId: PIXEL_ID @@ -562,7 +562,7 @@ describe('Yahoo ConnectID Submodule', () => { it('returns an object with the callback function if the correct params are passed and Yahoo opt-out value is not "1"', () => { mockOptout('true'); - let result = invokeGetIdAPI({ + const result = invokeGetIdAPI({ he: HASHED_EMAIL, pixelId: PIXEL_ID }, consentData); @@ -750,7 +750,7 @@ describe('Yahoo ConnectID Submodule', () => { puid: PUBLISHER_USER_ID, pixelId: PIXEL_ID }, consentData); - let request = server.requests[0]; + const request = server.requests[0]; request.respond( 200, {'Content-Type': 'application/json'}, @@ -791,7 +791,7 @@ describe('Yahoo ConnectID Submodule', () => { puid: PUBLISHER_USER_ID, pixelId: PIXEL_ID }, consentData); - let request = server.requests[0]; + const request = server.requests[0]; request.respond( 200, {'Content-Type': 'application/json'}, diff --git a/test/spec/modules/connectadBidAdapter_spec.js b/test/spec/modules/connectadBidAdapter_spec.js index 66b9eaec0a7..724f4eb93d4 100644 --- a/test/spec/modules/connectadBidAdapter_spec.js +++ b/test/spec/modules/connectadBidAdapter_spec.js @@ -90,7 +90,7 @@ describe('ConnectAd Adapter', function () { describe('implementation', function () { describe('for requests', function () { it('should accept bid', function () { - let validBid = { + const validBid = { bidder: 'connectad', params: { siteId: 123456, @@ -107,7 +107,7 @@ describe('ConnectAd Adapter', function () { }); it('should reject if missing sizes', function () { - let invalidBid = { + const invalidBid = { bidder: 'connectad', params: { siteId: 123456, @@ -118,7 +118,7 @@ describe('ConnectAd Adapter', function () { }); it('should return true when optional bidFloor params found for an ad', function () { - let validBid = { + const validBid = { bidder: 'connectad', params: { siteId: 123456, @@ -136,7 +136,7 @@ describe('ConnectAd Adapter', function () { }); it('should reject if missing siteId/networkId', function () { - let invalidBid = { + const invalidBid = { bidder: 'connectad', params: {}, mediaTypes: { @@ -150,7 +150,7 @@ describe('ConnectAd Adapter', function () { }); it('should reject if missing networkId', function () { - let invalidBid = { + const invalidBid = { bidder: 'connectad', params: { siteId: 123456 @@ -204,7 +204,7 @@ describe('ConnectAd Adapter', function () { }); it('should build a request if Consent but no gdprApplies', function () { - let localbidderRequest = { + const localbidderRequest = { timeout: 3000, gdprConsent: { gdprApplies: false, @@ -219,7 +219,7 @@ describe('ConnectAd Adapter', function () { }); it('should build a request if gdprConsent empty', function () { - let localbidderRequest = { + const localbidderRequest = { timeout: 3000, gdprConsent: {} } @@ -304,8 +304,8 @@ describe('ConnectAd Adapter', function () { } } }; - let request = spec.buildRequests(bidRequests, bidRequest); - let data = JSON.parse(request.data); + const request = spec.buildRequests(bidRequests, bidRequest); + const data = JSON.parse(request.data); assert.deepEqual(data.regs.ext.dsa, dsa); }); @@ -409,7 +409,7 @@ describe('ConnectAd Adapter', function () { describe('GPP Implementation', function() { it('should check with GPP Consent', function () { - let bidRequest = { + const bidRequest = { gppConsent: { 'gppString': 'DBACNYA~CPXxRfAPXxRfAAfKABENB-CgAAAAAAAAAAYgAAAAAAAA~1YNN', 'fullGppData': { @@ -446,21 +446,21 @@ describe('ConnectAd Adapter', function () { 'apiVersion': 1 } }; - let request = spec.buildRequests(bidRequests, bidRequest); - let data = JSON.parse(request.data); + const request = spec.buildRequests(bidRequests, bidRequest); + const data = JSON.parse(request.data); expect(data.regs.gpp).to.equal('DBACNYA~CPXxRfAPXxRfAAfKABENB-CgAAAAAAAAAAYgAAAAAAAA~1YNN'); expect(data.regs.gpp_sid[0]).to.equal(5); }); it('should check without GPP Consent', function () { - let bidRequest = {}; - let request = spec.buildRequests(bidRequests, bidRequest); - let data = JSON.parse(request.data); + const bidRequest = {}; + const request = spec.buildRequests(bidRequests, bidRequest); + const data = JSON.parse(request.data); expect(data.regs.gpp).to.equal(undefined); }); it('should check with GPP Consent read from OpenRTB2', function () { - let bidRequest = { + const bidRequest = { ortb2: { regs: { 'gpp': 'DBACNYA~CPXxRfAPXxRfAAfKABENB-CgAAAAAAAAAAYgAAAAAAAA~1YNN', @@ -470,8 +470,8 @@ describe('ConnectAd Adapter', function () { } } }; - let request = spec.buildRequests(bidRequests, bidRequest); - let data = JSON.parse(request.data); + const request = spec.buildRequests(bidRequests, bidRequest); + const data = JSON.parse(request.data); expect(data.regs.gpp).to.equal('DBACNYA~CPXxRfAPXxRfAAfKABENB-CgAAAAAAAAAAYgAAAAAAAA~1YNN'); expect(data.regs.gpp_sid[0]).to.equal(5); }); @@ -481,7 +481,7 @@ describe('ConnectAd Adapter', function () { it('should return complete bid response with adomain', function () { const ADOMAINS = ['connectad.io']; - let serverResponse = { + const serverResponse = { body: { decisions: { '2f95c00074b931': { @@ -524,7 +524,7 @@ describe('ConnectAd Adapter', function () { adrender: 1 }; - let serverResponse = { + const serverResponse = { body: { decisions: { '2f95c00074b931': { @@ -562,7 +562,7 @@ describe('ConnectAd Adapter', function () { it('should return complete bid response with empty adomain', function () { const ADOMAINS = []; - let serverResponse = { + const serverResponse = { body: { decisions: { '2f95c00074b931': { @@ -593,7 +593,7 @@ describe('ConnectAd Adapter', function () { }); it('should return empty bid response', function () { - let serverResponse = { + const serverResponse = { body: { decisions: [] } @@ -604,7 +604,7 @@ describe('ConnectAd Adapter', function () { }); it('should return empty bid response on incorrect size', function () { - let serverResponse = { + const serverResponse = { body: { decisions: { '2f95c00074b931': { @@ -629,7 +629,7 @@ describe('ConnectAd Adapter', function () { }); it('should return empty bid response on 0 cpm', function () { - let serverResponse = { + const serverResponse = { body: { decisions: { '2f95c00074b931': { @@ -654,7 +654,7 @@ describe('ConnectAd Adapter', function () { }); it('should process a deal id', function () { - let serverResponse = { + const serverResponse = { body: { decisions: { '2f95c00074b931': { @@ -720,7 +720,7 @@ describe('ConnectAd Adapter', function () { }); describe('getUserSyncs', () => { - let testParams = [ + const testParams = [ { name: 'iframe/no gdpr or ccpa', arguments: [{ iframeEnabled: true, pixelEnabled: false }, {}, null], @@ -780,7 +780,7 @@ describe('ConnectAd Adapter', function () { ]; for (let i = 0; i < testParams.length; i++) { - let currParams = testParams[i]; + const currParams = testParams[i]; it(currParams.name, function () { const result = spec.getUserSyncs.apply(this, currParams.arguments); expect(result).to.have.lengthOf(currParams.expect.pixels.length); diff --git a/test/spec/modules/consentManagementGpp_spec.js b/test/spec/modules/consentManagementGpp_spec.js index dc76d95ad92..6adf159ff55 100644 --- a/test/spec/modules/consentManagementGpp_spec.js +++ b/test/spec/modules/consentManagementGpp_spec.js @@ -9,7 +9,7 @@ import * as utils from 'src/utils.js'; import {config} from 'src/config.js'; import 'src/prebid.js'; -let expect = require('chai').expect; +const expect = require('chai').expect; describe('consentManagementGpp', function () { beforeEach(resetConsentData); @@ -64,7 +64,7 @@ describe('consentManagementGpp', function () { it('should not produce any consent metadata', async function () { await setConsentConfig(undefined) - let consentMetadata = gppDataHandler.getConsentMeta(); + const consentMetadata = gppDataHandler.getConsentMeta(); expect(consentMetadata).to.be.undefined; sinon.assert.calledOnce(utils.logWarn); }) @@ -85,7 +85,7 @@ describe('consentManagementGpp', function () { }); it('results in all user settings overriding system defaults', async function () { - let allConfig = { + const allConfig = { gpp: { cmpApi: 'iab', timeout: 7500 @@ -120,7 +120,7 @@ describe('consentManagementGpp', function () { }); it('results in user settings overriding system defaults', async () => { - let staticConfig = { + const staticConfig = { gpp: { cmpApi: 'static', timeout: 7500, @@ -297,7 +297,7 @@ describe('consentManagementGpp', function () { 'irrelevant': {eventName: 'irrelevant'} }).forEach(([t, evt]) => { it(`ignores ${t} events`, () => { - let pm = gppClient.init({signalStatus: 'not ready'}).catch((err) => err.args[0] !== 'done' && Promise.reject(err)); + const pm = gppClient.init({signalStatus: 'not ready'}).catch((err) => err.args[0] !== 'done' && Promise.reject(err)); eventListener(evt); eventListener('done', false); return pm; @@ -346,7 +346,7 @@ describe('consentManagementGpp', function () { }); it('keeps updating consent data on new events', () => { - let pm = gppClient.init({signalStatus: 'not ready'}).then(data => { + const pm = gppClient.init({signalStatus: 'not ready'}).then(data => { sinon.assert.match(data, gppData); sinon.assert.match(gppDataHandler.getConsentData(), gppData); }); @@ -383,7 +383,7 @@ describe('consentManagementGpp', function () { }) describe('moduleConfig.requestBidsHook tests:', function () { - let goodConfig = { + const goodConfig = { gpp: { cmpApi: 'iab', timeout: 7500, @@ -420,7 +420,7 @@ describe('consentManagementGpp', function () { }); it('should throw a warning and return to hooked function when an unknown CMP framework ID is used', async function () { - let badCMPConfig = { + const badCMPConfig = { gpp: { cmpApi: 'bad' } @@ -428,7 +428,7 @@ describe('consentManagementGpp', function () { await setConsentConfig(badCMPConfig); expect(consentConfig.cmpHandler).to.be.equal(badCMPConfig.gpp.cmpApi); expect(await runHook()).to.be.true; - let consent = gppDataHandler.getConsentData(); + const consent = gppDataHandler.getConsentData(); expect(consent).to.be.null; sinon.assert.calledOnce(utils.logWarn); }); @@ -446,7 +446,7 @@ describe('consentManagementGpp', function () { it('should throw proper errors when CMP is not found', async function () { await setConsentConfig(goodConfig); expect(await runHook()).to.be.false; - let consent = gppDataHandler.getConsentData(); + const consent = gppDataHandler.getConsentData(); // throw 2 errors; one for no bidsBackHandler and for CMP not being found (this is an error due to gdpr config) sinon.assert.calledTwice(utils.logError); expect(consent).to.be.null; @@ -550,7 +550,7 @@ describe('consentManagementGpp', function () { await didHookRun(); triggerCMPEvent('sectionChange', {signalStatus: 'ready'}); await consentConfig.loadConsentData(); - for (let run of ['first', 'second']) { + for (const run of ['first', 'second']) { triggerCMPEvent('cmpDisplayStatus', {signalStatus: 'not ready'}); didHookRun = startHook(); expect(await didHookRun()).to.be.false; diff --git a/test/spec/modules/consentManagementUsp_spec.js b/test/spec/modules/consentManagementUsp_spec.js index fb0167a4d11..8b011f20cbb 100644 --- a/test/spec/modules/consentManagementUsp_spec.js +++ b/test/spec/modules/consentManagementUsp_spec.js @@ -12,7 +12,7 @@ import adapterManager, {gdprDataHandler, uspDataHandler} from 'src/adapterManage import {requestBids} from '../../../src/prebid.js'; import {defer} from '../../../src/utils/promise.js'; -let expect = require('chai').expect; +const expect = require('chai').expect; function createIFrameMarker() { var ifr = document.createElement('iframe'); @@ -94,7 +94,7 @@ describe('consentManagement', function () { it('should not produce any USP metadata', function() { setConsentConfig({}); - let consentMeta = uspDataHandler.getConsentMeta(); + const consentMeta = uspDataHandler.getConsentMeta(); expect(consentMeta).to.be.undefined; }); @@ -125,7 +125,7 @@ describe('consentManagement', function () { }); it('results in all user settings overriding system defaults', function () { - let allConfig = { + const allConfig = { usp: { cmpApi: 'daa', timeout: 7500 @@ -159,7 +159,7 @@ describe('consentManagement', function () { requestBids.removeAll(); }); it('results in user settings overriding system defaults', () => { - let staticConfig = { + const staticConfig = { usp: { cmpApi: 'static', timeout: 7500, @@ -181,14 +181,14 @@ describe('consentManagement', function () { }); describe('requestBidsHook tests:', function () { - let goodConfig = { + const goodConfig = { usp: { cmpApi: 'iab', timeout: 7500 } }; - let noConfig = {}; + const noConfig = {}; let didHookReturn; @@ -213,11 +213,11 @@ describe('consentManagement', function () { }); it('should throw a warning and return to hooked function when an unknown USPAPI framework ID is used', function () { - let badCMPConfig = { usp: { cmpApi: 'bad' } }; + const badCMPConfig = { usp: { cmpApi: 'bad' } }; setConsentConfig(badCMPConfig); expect(consentAPI).to.be.equal(badCMPConfig.usp.cmpApi); requestBidsHook(() => { didHookReturn = true; }, {}); - let consent = uspDataHandler.getConsentData(); + const consent = uspDataHandler.getConsentData(); sinon.assert.calledOnce(utils.logWarn); expect(didHookReturn).to.be.true; expect(consent).to.be.null; @@ -226,7 +226,7 @@ describe('consentManagement', function () { it('should throw proper errors when USP config is not found', function () { setConsentConfig(noConfig); requestBidsHook(() => { didHookReturn = true; }, {}); - let consent = uspDataHandler.getConsentData(); + const consent = uspDataHandler.getConsentData(); // throw 2 warnings; one for no bidsBackHandler and for CMP not being found (this is an error due to gdpr config) sinon.assert.calledTwice(utils.logWarn); expect(didHookReturn).to.be.true; @@ -257,7 +257,7 @@ describe('consentManagement', function () { // Because the USP API does not wait for a user response, if it was not successfully obtained before the first auction, we should try again to retrieve privacy data before each subsequent auction. it('should not bypass CMP and simply use previously stored consentData', function () { - let testConsentData = { + const testConsentData = { uspString: '1YY' }; @@ -276,7 +276,7 @@ describe('consentManagement', function () { requestBidsHook(() => { didHookReturn = true; }, {}); - let consent = uspDataHandler.getConsentData(); + const consent = uspDataHandler.getConsentData(); expect(didHookReturn).to.be.true; expect(consent).to.equal(testConsentData.uspString); sinon.assert.called(uspStub); @@ -370,7 +370,7 @@ describe('consentManagement', function () { }) setConsentConfig(goodConfig); requestBidsHook(() => { - let consent = uspDataHandler.getConsentData(); + const consent = uspDataHandler.getConsentData(); sinon.assert.notCalled(utils.logWarn); sinon.assert.notCalled(utils.logError); expect(consent).to.equal('1YY'); @@ -415,7 +415,7 @@ describe('consentManagement', function () { }); it('Workflow for normal page withoout iframe locater', function() { - let testConsentData = { + const testConsentData = { uspString: '1NY' }; @@ -426,7 +426,7 @@ describe('consentManagement', function () { setConsentConfig(goodConfig); requestBidsHook(() => { didHookReturn = true; }, {}); - let consent = uspDataHandler.getConsentData(); + const consent = uspDataHandler.getConsentData(); sinon.assert.notCalled(utils.logWarn); sinon.assert.notCalled(utils.logError); @@ -457,7 +457,7 @@ describe('consentManagement', function () { }); it('performs lookup check and stores consentData for a valid existing user', function () { - let testConsentData = { + const testConsentData = { uspString: '1NY' }; @@ -468,7 +468,7 @@ describe('consentManagement', function () { setConsentConfig(goodConfig); requestBidsHook(() => { didHookReturn = true; }, {}); - let consent = uspDataHandler.getConsentData(); + const consent = uspDataHandler.getConsentData(); sinon.assert.notCalled(utils.logWarn); sinon.assert.notCalled(utils.logError); @@ -478,7 +478,7 @@ describe('consentManagement', function () { }); it('returns USP consent metadata', function () { - let testConsentData = { + const testConsentData = { uspString: '1NY' }; @@ -489,7 +489,7 @@ describe('consentManagement', function () { setConsentConfig(goodConfig); requestBidsHook(() => { didHookReturn = true; }, {}); - let consentMeta = uspDataHandler.getConsentMeta(); + const consentMeta = uspDataHandler.getConsentMeta(); sinon.assert.notCalled(utils.logWarn); sinon.assert.notCalled(utils.logError); diff --git a/test/spec/modules/consentManagement_spec.js b/test/spec/modules/consentManagement_spec.js index c8a96c85069..a033c56ddcd 100644 --- a/test/spec/modules/consentManagement_spec.js +++ b/test/spec/modules/consentManagement_spec.js @@ -4,7 +4,7 @@ import * as utils from 'src/utils.js'; import {config} from 'src/config.js'; import 'src/prebid.js'; -let expect = require('chai').expect; +const expect = require('chai').expect; describe('consentManagement', function () { function mockCMP(cmpResponse) { @@ -54,7 +54,7 @@ describe('consentManagement', function () { it('should not produce any consent metadata', async function () { await setConsentConfig(undefined) - let consentMetadata = gdprDataHandler.getConsentMeta(); + const consentMetadata = gdprDataHandler.getConsentMeta(); expect(consentMetadata).to.be.undefined; sinon.assert.calledOnce(utils.logWarn); }) @@ -71,7 +71,7 @@ describe('consentManagement', function () { }); it('results in all user settings overriding system defaults', async function () { - let allConfig = { + const allConfig = { cmpApi: 'iab', timeout: 7500, defaultGdprScope: true @@ -233,7 +233,7 @@ describe('consentManagement', function () { }); describe('requestBidsHook tests:', function () { - let goodConfig = { + const goodConfig = { cmpApi: 'iab', timeout: 7500, }; @@ -272,13 +272,13 @@ describe('consentManagement', function () { }); it('should throw a warning and return to hooked function when an unknown CMP framework ID is used', async function () { - let badCMPConfig = { + const badCMPConfig = { cmpApi: 'bad' }; await setConsentConfig(badCMPConfig); expect(consentConfig.cmpHandler).to.be.equal(badCMPConfig.cmpApi); expect(await runHook()).to.be.true; - let consent = gdprDataHandler.getConsentData(); + const consent = gdprDataHandler.getConsentData(); sinon.assert.calledOnce(utils.logWarn); expect(consent).to.be.null; }); @@ -292,7 +292,7 @@ describe('consentManagement', function () { it('should throw proper errors when CMP is not found', async function () { await setConsentConfig(goodConfig); expect(await runHook()).to.be.false; - let consent = gdprDataHandler.getConsentData(); + const consent = gdprDataHandler.getConsentData(); // throw 2 errors; one for no bidsBackHandler and for CMP not being found (this is an error due to gdpr config) sinon.assert.calledTwice(utils.logError); expect(consent).to.be.null; @@ -356,7 +356,7 @@ describe('consentManagement', function () { }); it('should bypass CMP and simply use previously stored consentData', async function () { - let testConsentData = { + const testConsentData = { gdprApplies: true, tcString: 'xyz', }; @@ -367,14 +367,14 @@ describe('consentManagement', function () { cmpStub.resetHistory(); expect(await runHook()).to.be.true; - let consent = gdprDataHandler.getConsentData(); + const consent = gdprDataHandler.getConsentData(); expect(consent.consentString).to.equal(testConsentData.tcString); expect(consent.gdprApplies).to.be.true; sinon.assert.notCalled(cmpStub); }); it('should not set consent.gdprApplies to true if defaultGdprScope is true', async function () { - let testConsentData = { + const testConsentData = { gdprApplies: false, tcString: 'xyz', }; @@ -388,7 +388,7 @@ describe('consentManagement', function () { }); expect(await runHook()).to.be.true; - let consent = gdprDataHandler.getConsentData(); + const consent = gdprDataHandler.getConsentData(); expect(consent.gdprApplies).to.be.false; }); }); @@ -398,7 +398,7 @@ describe('consentManagement', function () { let stringifyResponse; function createIFrameMarker(frameName) { - let ifr = document.createElement('iframe'); + const ifr = document.createElement('iframe'); ifr.width = 0; ifr.height = 0; ifr.name = frameName; @@ -409,10 +409,10 @@ describe('consentManagement', function () { function creatCmpMessageHandler(prefix, returnValue) { return function (event) { if (event && event.data) { - let data = event.data; + const data = event.data; if (data[`${prefix}Call`]) { - let callId = data[`${prefix}Call`].callId; - let response = { + const callId = data[`${prefix}Call`].callId; + const response = { [`${prefix}Return`]: { callId, returnValue, @@ -430,7 +430,7 @@ describe('consentManagement', function () { stringifyResponse = messageFormatString; await setConsentConfig(goodConfig); expect(await runHook()).to.be.true; - let consent = gdprDataHandler.getConsentData(); + const consent = gdprDataHandler.getConsentData(); sinon.assert.notCalled(utils.logError); expect(consent.consentString).to.equal(tarConsentString); expect(consent.gdprApplies).to.be.true; @@ -504,7 +504,7 @@ describe('consentManagement', function () { }); it('performs lookup check and stores consentData for a valid existing user', async function () { - let testConsentData = { + const testConsentData = { tcString: 'abc12345234', gdprApplies: true, purposeOneTreatment: false, @@ -516,7 +516,7 @@ describe('consentManagement', function () { await setConsentConfig(goodConfig); expect(await runHook()).to.be.true; - let consent = gdprDataHandler.getConsentData(); + const consent = gdprDataHandler.getConsentData(); sinon.assert.notCalled(utils.logError); expect(consent.consentString).to.equal(testConsentData.tcString); expect(consent.gdprApplies).to.be.true; @@ -524,7 +524,7 @@ describe('consentManagement', function () { }); it('produces gdpr metadata', async function () { - let testConsentData = { + const testConsentData = { tcString: 'abc12345234', gdprApplies: true, purposeOneTreatment: false, @@ -540,7 +540,7 @@ describe('consentManagement', function () { await setConsentConfig(goodConfig); expect(await runHook()).to.be.true; - let consentMeta = gdprDataHandler.getConsentMeta(); + const consentMeta = gdprDataHandler.getConsentMeta(); sinon.assert.notCalled(utils.logError); expect(consentMeta.consentStringSize).to.be.above(0) expect(consentMeta.gdprApplies).to.be.true; @@ -549,7 +549,7 @@ describe('consentManagement', function () { }); it('performs lookup check and stores consentData for a valid existing user with additional consent', async function () { - let testConsentData = { + const testConsentData = { tcString: 'abc12345234', addtlConsent: 'superduperstring', gdprApplies: true, @@ -562,7 +562,7 @@ describe('consentManagement', function () { await setConsentConfig(goodConfig); expect(await runHook()).to.be.true; - let consent = gdprDataHandler.getConsentData(); + const consent = gdprDataHandler.getConsentData(); sinon.assert.notCalled(utils.logError); expect(consent.consentString).to.equal(testConsentData.tcString); expect(consent.addtlConsent).to.equal(testConsentData.addtlConsent); @@ -571,7 +571,7 @@ describe('consentManagement', function () { }); it('throws an error when processCmpData check fails + does not call requestBids callback', async function () { - let testConsentData = {}; + const testConsentData = {}; let bidsBackHandlerReturn = false; cmpStub = sinon.stub(window, '__tcfapi').callsFake((...args) => { @@ -586,7 +586,7 @@ describe('consentManagement', function () { [utils.logWarn, utils.logError].forEach((stub) => stub.resetHistory()); expect(await runHook({bidsBackHandler: () => bidsBackHandlerReturn = true})).to.be.false; - let consent = gdprDataHandler.getConsentData(); + const consent = gdprDataHandler.getConsentData(); sinon.assert.calledOnce(utils.logError); sinon.assert.notCalled(utils.logWarn); @@ -715,7 +715,7 @@ describe('consentManagement', function () { it('It still considers it a valid cmp response if gdprApplies is not a boolean', async function () { // gdprApplies is undefined, should just still store consent response but use whatever defaultGdprScope was - let testConsentData = { + const testConsentData = { tcString: 'abc12345234', purposeOneTreatment: false, eventStatus: 'tcloaded' @@ -730,7 +730,7 @@ describe('consentManagement', function () { defaultGdprScope: true }); expect(await runHook()).to.be.true; - let consent = gdprDataHandler.getConsentData(); + const consent = gdprDataHandler.getConsentData(); sinon.assert.notCalled(utils.logError); expect(consent.consentString).to.equal(testConsentData.tcString); expect(consent.gdprApplies).to.be.true; diff --git a/test/spec/modules/consumableBidAdapter_spec.js b/test/spec/modules/consumableBidAdapter_spec.js index 671fd2d24df..51db64019b5 100644 --- a/test/spec/modules/consumableBidAdapter_spec.js +++ b/test/spec/modules/consumableBidAdapter_spec.js @@ -403,11 +403,11 @@ const BUILD_REQUESTS_VIDEO_OUTPUT = { }; describe('Consumable BidAdapter', function () { - let adapter = spec; + const adapter = spec; describe('bid request validation', function () { it('should accept valid bid requests', function () { - let bid = { + const bid = { bidder: 'consumable', params: { networkId: '9969', @@ -420,7 +420,7 @@ describe('Consumable BidAdapter', function () { }); it('should accept valid bid requests with extra fields', function () { - let bid = { + const bid = { bidder: 'consumable', params: { networkId: '9969', @@ -434,7 +434,7 @@ describe('Consumable BidAdapter', function () { }); it('should reject bid requests without siteId', function () { - let bid = { + const bid = { bidder: 'consumable', params: { networkId: '9969', @@ -446,7 +446,7 @@ describe('Consumable BidAdapter', function () { }); it('should reject bid requests without networkId', function () { - let bid = { + const bid = { bidder: 'consumable', params: { siteId: '9969', @@ -460,74 +460,74 @@ describe('Consumable BidAdapter', function () { describe('buildRequests validation', function () { it('creates request data', function () { - let request = spec.buildRequests(BIDDER_REQUEST_1.bidRequest, BIDDER_REQUEST_1); + const request = spec.buildRequests(BIDDER_REQUEST_1.bidRequest, BIDDER_REQUEST_1); expect(request).to.exist.and.to.be.a('object'); }); it('request to consumable should contain a url', function () { - let request = spec.buildRequests(BIDDER_REQUEST_1.bidRequest, BIDDER_REQUEST_1); + const request = spec.buildRequests(BIDDER_REQUEST_1.bidRequest, BIDDER_REQUEST_1); expect(request.url).to.have.string('serverbid.com'); }); it('requires valid bids to make request', function () { - let request = spec.buildRequests(BIDDER_REQUEST_EMPTY.bidRequest, BIDDER_REQUEST_EMPTY); + const request = spec.buildRequests(BIDDER_REQUEST_EMPTY.bidRequest, BIDDER_REQUEST_EMPTY); expect(request.bidRequest).to.be.empty; }); it('sends bid request to ENDPOINT via POST', function () { - let request = spec.buildRequests(BIDDER_REQUEST_1.bidRequest, BIDDER_REQUEST_1); + const request = spec.buildRequests(BIDDER_REQUEST_1.bidRequest, BIDDER_REQUEST_1); expect(request.method).to.have.string('POST'); }); it('passes through bidderRequest', function () { - let request = spec.buildRequests(BIDDER_REQUEST_1.bidRequest, BIDDER_REQUEST_1); + const request = spec.buildRequests(BIDDER_REQUEST_1.bidRequest, BIDDER_REQUEST_1); expect(request.bidderRequest).to.equal(BIDDER_REQUEST_1); }); it('should contain schain if it exists in the bidRequest', function () { - let request = spec.buildRequests(BIDDER_REQUEST_1.bidRequest, BIDDER_REQUEST_1); - let data = JSON.parse(request.data); + const request = spec.buildRequests(BIDDER_REQUEST_1.bidRequest, BIDDER_REQUEST_1); + const data = JSON.parse(request.data); expect(data.schain).to.deep.equal(BIDDER_REQUEST_1.ortb2.source.ext.schain) }); it('should not contain schain if it does not exist in the bidRequest', function () { - let request = spec.buildRequests(BIDDER_REQUEST_2.bidRequest, BIDDER_REQUEST_2); - let data = JSON.parse(request.data); + const request = spec.buildRequests(BIDDER_REQUEST_2.bidRequest, BIDDER_REQUEST_2); + const data = JSON.parse(request.data); expect(data.schain).to.be.undefined; }); it('should contain coppa if configured', function () { config.setConfig({ coppa: true }); - let request = spec.buildRequests(BIDDER_REQUEST_1.bidRequest, BIDDER_REQUEST_1); - let data = JSON.parse(request.data); + const request = spec.buildRequests(BIDDER_REQUEST_1.bidRequest, BIDDER_REQUEST_1); + const data = JSON.parse(request.data); expect(data.coppa).to.be.true; }); it('should not contain coppa if not configured', function () { config.setConfig({ coppa: false }); - let request = spec.buildRequests(BIDDER_REQUEST_1.bidRequest, BIDDER_REQUEST_1); - let data = JSON.parse(request.data); + const request = spec.buildRequests(BIDDER_REQUEST_1.bidRequest, BIDDER_REQUEST_1); + const data = JSON.parse(request.data); expect(data.coppa).to.be.undefined; }); it('should contain video object for video requests', function () { - let request = spec.buildRequests(BIDDER_REQUEST_VIDEO.bidRequest, BIDDER_REQUEST_VIDEO); - let data = JSON.parse(request.data); + const request = spec.buildRequests(BIDDER_REQUEST_VIDEO.bidRequest, BIDDER_REQUEST_VIDEO); + const data = JSON.parse(request.data); expect(data.placements[0].video).to.deep.equal(BIDDER_REQUEST_VIDEO.bidRequest[0].mediaTypes.video); }); it('sets bidfloor param if present', function () { - let bidderRequest1 = deepClone(BIDDER_REQUEST_1); - let bidderRequest2 = deepClone(BIDDER_REQUEST_2); + const bidderRequest1 = deepClone(BIDDER_REQUEST_1); + const bidderRequest2 = deepClone(BIDDER_REQUEST_2); bidderRequest1.bidRequest[0].params.bidFloor = 0.05; bidderRequest2.bidRequest[0].getFloor = function() { return { @@ -535,36 +535,36 @@ describe('Consumable BidAdapter', function () { floor: 0.15 } }; - let request1 = spec.buildRequests(bidderRequest1.bidRequest, BIDDER_REQUEST_1); - let data1 = JSON.parse(request1.data); - let request2 = spec.buildRequests(bidderRequest2.bidRequest, BIDDER_REQUEST_2); - let data2 = JSON.parse(request2.data); + const request1 = spec.buildRequests(bidderRequest1.bidRequest, BIDDER_REQUEST_1); + const data1 = JSON.parse(request1.data); + const request2 = spec.buildRequests(bidderRequest2.bidRequest, BIDDER_REQUEST_2); + const data2 = JSON.parse(request2.data); expect(data1.placements[0].bidfloor).to.equal(0.05); expect(data2.placements[0].bidfloor).to.equal(0.15); }); it('should contain the language param', function () { - let request = spec.buildRequests(BIDDER_REQUEST_1.bidRequest, BIDDER_REQUEST_1); - let data = JSON.parse(request.data); + const request = spec.buildRequests(BIDDER_REQUEST_1.bidRequest, BIDDER_REQUEST_1); + const data = JSON.parse(request.data); expect(data.lang).to.equal('en'); }); }); describe('interpretResponse validation', function () { it('response should have valid bidderCode', function () { - let bidRequest = spec.buildRequests(BIDDER_REQUEST_2.bidRequest, BIDDER_REQUEST_2); - let bid = createBid(bidRequest.bidRequest[0]); + const bidRequest = spec.buildRequests(BIDDER_REQUEST_2.bidRequest, BIDDER_REQUEST_2); + const bid = createBid(bidRequest.bidRequest[0]); expect(bid.bidderCode).to.equal('consumable'); }); it('response should include objects for all bids', function () { - let bids = spec.interpretResponse(AD_SERVER_RESPONSE, BUILD_REQUESTS_OUTPUT); + const bids = spec.interpretResponse(AD_SERVER_RESPONSE, BUILD_REQUESTS_OUTPUT); expect(bids.length).to.equal(2); }); it('registers bids', function () { - let bids = spec.interpretResponse(AD_SERVER_RESPONSE_2, BUILD_REQUESTS_OUTPUT); + const bids = spec.interpretResponse(AD_SERVER_RESPONSE_2, BUILD_REQUESTS_OUTPUT); bids.forEach(b => { expect(b).to.have.property('cpm'); expect(b.cpm).to.be.above(0); @@ -589,7 +589,7 @@ describe('Consumable BidAdapter', function () { }); it('registers video bids with vastUrl', function () { - let bids = spec.interpretResponse(AD_SERVER_RESPONSE_VIDEO_1, BUILD_REQUESTS_VIDEO_OUTPUT); + const bids = spec.interpretResponse(AD_SERVER_RESPONSE_VIDEO_1, BUILD_REQUESTS_VIDEO_OUTPUT); bids.forEach(b => { expect(b.mediaType).to.equal('video'); @@ -601,7 +601,7 @@ describe('Consumable BidAdapter', function () { }) it('registers video bids with vastXml', function () { - let bids = spec.interpretResponse(AD_SERVER_RESPONSE_VIDEO_2, BUILD_REQUESTS_VIDEO_OUTPUT); + const bids = spec.interpretResponse(AD_SERVER_RESPONSE_VIDEO_2, BUILD_REQUESTS_VIDEO_OUTPUT); bids.forEach(b => { expect(b.mediaType).to.equal('video'); @@ -614,118 +614,118 @@ describe('Consumable BidAdapter', function () { }) it('handles nobid responses', function () { - let EMPTY_RESP = Object.assign({}, AD_SERVER_RESPONSE, {'body': {'decisions': null}}) - let bids = spec.interpretResponse(EMPTY_RESP, BUILD_REQUESTS_OUTPUT); + const EMPTY_RESP = Object.assign({}, AD_SERVER_RESPONSE, {'body': {'decisions': null}}) + const bids = spec.interpretResponse(EMPTY_RESP, BUILD_REQUESTS_OUTPUT); expect(bids).to.be.empty; }); it('handles no server response', function () { - let bids = spec.interpretResponse(null, BUILD_REQUESTS_OUTPUT); + const bids = spec.interpretResponse(null, BUILD_REQUESTS_OUTPUT); expect(bids).to.be.empty; }); }); describe('getUserSyncs', function () { - let syncOptions = {'iframeEnabled': true}; + const syncOptions = {'iframeEnabled': true}; it('handles empty sync options', function () { - let opts = spec.getUserSyncs({}); + const opts = spec.getUserSyncs({}); expect(opts).to.be.undefined; }); it('should return a sync url if iframe syncs are enabled', function () { - let opts = spec.getUserSyncs(syncOptions); + const opts = spec.getUserSyncs(syncOptions); expect(opts.length).to.equal(1); }); it('should return a sync url if iframe syncs are enabled and server response is empty', function () { - let opts = spec.getUserSyncs(syncOptions, []); + const opts = spec.getUserSyncs(syncOptions, []); expect(opts.length).to.equal(1); }); it('should return a sync url if iframe syncs are enabled and server response does not contain a bdr attribute', function () { - let opts = spec.getUserSyncs(syncOptions, [AD_SERVER_RESPONSE]); + const opts = spec.getUserSyncs(syncOptions, [AD_SERVER_RESPONSE]); expect(opts.length).to.equal(1); }); it('should return a sync url if iframe syncs are enabled and server response contains a bdr attribute that is not cx', function () { - let opts = spec.getUserSyncs(syncOptions, [AD_SERVER_RESPONSE_2]); + const opts = spec.getUserSyncs(syncOptions, [AD_SERVER_RESPONSE_2]); expect(opts.length).to.equal(1); }); it('should return a sync url if iframe syncs are enabled and GDPR applies', function () { - let gdprConsent = { + const gdprConsent = { consentString: 'GDPR_CONSENT_STRING', gdprApplies: true, } - let opts = spec.getUserSyncs(syncOptions, [AD_SERVER_RESPONSE], gdprConsent); + const opts = spec.getUserSyncs(syncOptions, [AD_SERVER_RESPONSE], gdprConsent); expect(opts.length).to.equal(1); expect(opts[0].url).to.equal('https://sync.serverbid.com/ss/730181.html?gdpr=1&gdpr_consent=GDPR_CONSENT_STRING'); }) it('should return a sync url if iframe syncs are enabled and GDPR is undefined', function () { - let gdprConsent = { + const gdprConsent = { consentString: 'GDPR_CONSENT_STRING', gdprApplies: undefined, } - let opts = spec.getUserSyncs(syncOptions, [AD_SERVER_RESPONSE], gdprConsent); + const opts = spec.getUserSyncs(syncOptions, [AD_SERVER_RESPONSE], gdprConsent); expect(opts.length).to.equal(1); expect(opts[0].url).to.equal('https://sync.serverbid.com/ss/730181.html?gdpr=0&gdpr_consent=GDPR_CONSENT_STRING'); }) it('should return a sync url if iframe syncs are enabled and has GPP consent with applicable sections', function () { - let gppConsent = { + const gppConsent = { applicableSections: [1, 2], gppString: 'GPP_CONSENT_STRING' } - let opts = spec.getUserSyncs(syncOptions, [AD_SERVER_RESPONSE], {}, '', gppConsent); + const opts = spec.getUserSyncs(syncOptions, [AD_SERVER_RESPONSE], {}, '', gppConsent); expect(opts.length).to.equal(1); expect(opts[0].url).to.equal('https://sync.serverbid.com/ss/730181.html?gpp=GPP_CONSENT_STRING&gpp_sid=1%2C2'); }) it('should return a sync url if iframe syncs are enabled and has GPP consent without applicable sections', function () { - let gppConsent = { + const gppConsent = { applicableSections: [], gppString: 'GPP_CONSENT_STRING' } - let opts = spec.getUserSyncs(syncOptions, [AD_SERVER_RESPONSE], {}, '', gppConsent); + const opts = spec.getUserSyncs(syncOptions, [AD_SERVER_RESPONSE], {}, '', gppConsent); expect(opts.length).to.equal(1); expect(opts[0].url).to.equal('https://sync.serverbid.com/ss/730181.html?gpp=GPP_CONSENT_STRING'); }) it('should return a sync url if iframe syncs are enabled and USP applies', function () { - let uspConsent = 'USP_CONSENT_STRING'; - let opts = spec.getUserSyncs(syncOptions, [AD_SERVER_RESPONSE], {}, uspConsent); + const uspConsent = 'USP_CONSENT_STRING'; + const opts = spec.getUserSyncs(syncOptions, [AD_SERVER_RESPONSE], {}, uspConsent); expect(opts.length).to.equal(1); expect(opts[0].url).to.equal('https://sync.serverbid.com/ss/730181.html?us_privacy=USP_CONSENT_STRING'); }) it('should return a sync url if iframe syncs are enabled, GDPR and USP applies', function () { - let gdprConsent = { + const gdprConsent = { consentString: 'GDPR_CONSENT_STRING', gdprApplies: true, } - let uspConsent = 'USP_CONSENT_STRING'; - let opts = spec.getUserSyncs(syncOptions, [AD_SERVER_RESPONSE], gdprConsent, uspConsent); + const uspConsent = 'USP_CONSENT_STRING'; + const opts = spec.getUserSyncs(syncOptions, [AD_SERVER_RESPONSE], gdprConsent, uspConsent); expect(opts.length).to.equal(1); expect(opts[0].url).to.equal('https://sync.serverbid.com/ss/730181.html?gdpr=1&gdpr_consent=GDPR_CONSENT_STRING&us_privacy=USP_CONSENT_STRING'); }) it('should return a sync url if pixel syncs are enabled and some are returned from the server', function () { - let syncOptions = {'pixelEnabled': true}; - let opts = spec.getUserSyncs(syncOptions, [AD_SERVER_RESPONSE]); + const syncOptions = {'pixelEnabled': true}; + const opts = spec.getUserSyncs(syncOptions, [AD_SERVER_RESPONSE]); expect(opts.length).to.equal(1); }); @@ -754,8 +754,8 @@ describe('Consumable BidAdapter', function () { } }] }]; - let request = spec.buildRequests(bidderRequest.bidRequest, BIDDER_REQUEST_1); - let data = JSON.parse(request.data); + const request = spec.buildRequests(bidderRequest.bidRequest, BIDDER_REQUEST_1); + const data = JSON.parse(request.data); expect(data.user.eids).to.deep.equal(bidderRequest.bidRequest[0].userIdAsEids); }); @@ -777,7 +777,7 @@ describe('Consumable BidAdapter', function () { }, 'RANDOM_IDENTIFIER_STRING' ]; - let scrubbedEids = [ + const scrubbedEids = [ { source: 'adserver.org', uids: [ @@ -791,19 +791,19 @@ describe('Consumable BidAdapter', function () { ], }, ]; - let request = spec.buildRequests( + const request = spec.buildRequests( bidderRequest.bidRequest, BIDDER_REQUEST_1 ); - let data = JSON.parse(request.data); + const data = JSON.parse(request.data); expect(data.user.eids).to.deep.equal( scrubbedEids ); }); it('Request should NOT have adsrvrOrgId params if userId is NOT object', function() { - let request = spec.buildRequests(bidderRequest.bidRequest, BIDDER_REQUEST_1); - let data = JSON.parse(request.data); + const request = spec.buildRequests(bidderRequest.bidRequest, BIDDER_REQUEST_1); + const data = JSON.parse(request.data); expect(data.user.eids).to.deep.equal(undefined); }); @@ -811,8 +811,8 @@ describe('Consumable BidAdapter', function () { bidderRequest.bidRequest[0].userId = { tdid: 1234 }; - let request = spec.buildRequests(bidderRequest.bidRequest, BIDDER_REQUEST_1); - let data = JSON.parse(request.data); + const request = spec.buildRequests(bidderRequest.bidRequest, BIDDER_REQUEST_1); + const data = JSON.parse(request.data); expect(data.user.eids).to.deep.equal(undefined); }); }); diff --git a/test/spec/modules/contentexchangeBidAdapter_spec.js b/test/spec/modules/contentexchangeBidAdapter_spec.js index c006aa520e1..0a747f059d3 100644 --- a/test/spec/modules/contentexchangeBidAdapter_spec.js +++ b/test/spec/modules/contentexchangeBidAdapter_spec.js @@ -132,7 +132,7 @@ describe('ContentexchangeBidAdapter', function () { }); it('Returns general data valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys('deviceWidth', 'deviceHeight', @@ -212,7 +212,7 @@ describe('ContentexchangeBidAdapter', function () { } ]; - let serverRequest = spec.buildRequests(bids, bidderRequest); + const serverRequest = spec.buildRequests(bids, bidderRequest); const { placements } = serverRequest.data; for (let i = 0, len = placements.length; i < len; i++) { @@ -247,7 +247,7 @@ describe('ContentexchangeBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { delete bidderRequest.uspConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('object'); expect(data.gdpr).to.have.property('consentString'); @@ -261,7 +261,7 @@ describe('ContentexchangeBidAdapter', function () { bidderRequest.uspConsent = '1---'; delete bidderRequest.gdprConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -276,8 +276,8 @@ describe('ContentexchangeBidAdapter', function () { applicableSections: [8] }; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -291,8 +291,8 @@ describe('ContentexchangeBidAdapter', function () { bidderRequest.ortb2.regs.gpp = 'abc123'; bidderRequest.ortb2.regs.gpp_sid = [8]; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -322,9 +322,9 @@ describe('ContentexchangeBidAdapter', function () { } }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(banner.body[0].requestId); @@ -356,10 +356,10 @@ describe('ContentexchangeBidAdapter', function () { } }] }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -393,10 +393,10 @@ describe('ContentexchangeBidAdapter', function () { } }] }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys('requestId', 'cpm', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'native', 'meta'); expect(dataItem.native).to.have.keys('clickUrl', 'impressionTrackers', 'title', 'image') expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -427,7 +427,7 @@ describe('ContentexchangeBidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -443,7 +443,7 @@ describe('ContentexchangeBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -460,7 +460,7 @@ describe('ContentexchangeBidAdapter', function () { currency: 'USD', }] }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -473,7 +473,7 @@ describe('ContentexchangeBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/contxtfulBidAdapter_spec.js b/test/spec/modules/contxtfulBidAdapter_spec.js index 4f64d78092b..84a32f7cef8 100644 --- a/test/spec/modules/contxtfulBidAdapter_spec.js +++ b/test/spec/modules/contxtfulBidAdapter_spec.js @@ -539,7 +539,7 @@ describe('contxtful bid adapter', function () { }); }); - let bidRequests = + const bidRequests = [ { bidder: 'contxtful', @@ -579,7 +579,7 @@ describe('contxtful bid adapter', function () { } ]; - let expectedReceptivityData = { + const expectedReceptivityData = { rx: RX_FROM_API, params: { ev: VERSION, @@ -587,7 +587,7 @@ describe('contxtful bid adapter', function () { }, }; - let bidderRequest = { + const bidderRequest = { refererInfo: { ref: 'https://my-referer-custom.com', }, @@ -747,7 +747,7 @@ describe('contxtful bid adapter', function () { }); it('will contains the receptivity value within the ortb2.user.data with contxtful name', () => { - let obtained_receptivity_data = bidRequest.data.ortb2.user.data.filter(function (userData) { + const obtained_receptivity_data = bidRequest.data.ortb2.user.data.filter(function (userData) { return userData.name == 'contxtful'; }); expect(obtained_receptivity_data.length).to.equal(1); @@ -755,7 +755,7 @@ describe('contxtful bid adapter', function () { }); it('will contains ortb2Imp of the bid request within the ortb2.imp.ext', () => { - let first_imp = bidRequest.data.ortb2.imp[0]; + const first_imp = bidRequest.data.ortb2.imp[0]; expect(first_imp.ext).not.to.be.undefined; expect(first_imp.ext.tid).to.equal('t-id-test-1'); expect(first_imp.ext.gpid).to.equal('gpid-id-unitest-1'); @@ -763,7 +763,7 @@ describe('contxtful bid adapter', function () { }); describe('valid bid request with no floor module', () => { - let noFloorsBidRequests = + const noFloorsBidRequests = [ { bidder: 'contxtful', diff --git a/test/spec/modules/contxtfulRtdProvider_spec.js b/test/spec/modules/contxtfulRtdProvider_spec.js index 4d0d9521586..bd1cdaf5533 100644 --- a/test/spec/modules/contxtfulRtdProvider_spec.js +++ b/test/spec/modules/contxtfulRtdProvider_spec.js @@ -62,7 +62,7 @@ function fakeGetElementById(width, height, x, y) { } describe('contxtfulRtdProvider', function () { - let sandbox = sinon.createSandbox(); + const sandbox = sinon.createSandbox(); let loadExternalScriptTag; let eventsEmitSpy; @@ -86,7 +86,7 @@ describe('contxtfulRtdProvider', function () { RX_API_MOCK_WITH_BUNDLE.getOrtb2Fragment.resetHistory(); RX_API_MOCK_WITH_BUNDLE.getOrtb2Fragment.callsFake((bidders, reqBidsConfigObj) => { - let bidderObj = bidders.reduce((accumulator, bidder) => { accumulator[bidder] = { user: { data: [{ name: MODULE_NAME, value: RX_FROM_API }] } }; return accumulator; }, {}); + const bidderObj = bidders.reduce((accumulator, bidder) => { accumulator[bidder] = { user: { data: [{ name: MODULE_NAME, value: RX_FROM_API }] } }; return accumulator; }, {}); return { global: { user: { site: { id: 'globalsiteId' } } }, bidder: bidderObj } } ); @@ -101,7 +101,7 @@ describe('contxtfulRtdProvider', function () { sandbox.stub(utils, 'generateUUID').returns(SM); - let tagId = CUSTOMER; + const tagId = CUSTOMER; sessionStorage.clear(); }); @@ -200,7 +200,7 @@ describe('contxtfulRtdProvider', function () { describe('init', function () { it('uses the RX API to get receptivity', (done) => { - let config = buildInitConfig(VERSION, CUSTOMER); + const config = buildInitConfig(VERSION, CUSTOMER); contxtfulSubmodule.init(config); window.dispatchEvent(RX_CONNECTOR_IS_READY_EVENT); @@ -215,7 +215,7 @@ describe('contxtfulRtdProvider', function () { describe('init', function () { it('gets the RX API returned by an external script', (done) => { - let config = buildInitConfig(VERSION, CUSTOMER); + const config = buildInitConfig(VERSION, CUSTOMER); contxtfulSubmodule.init(config); window.dispatchEvent(RX_CONNECTOR_IS_READY_EVENT); @@ -230,11 +230,11 @@ describe('contxtfulRtdProvider', function () { describe('init', function () { it('detect that initial receptivity is not dispatched and it does not initialize receptivity value', (done) => { - let config = buildInitConfig(VERSION, CUSTOMER); + const config = buildInitConfig(VERSION, CUSTOMER); contxtfulSubmodule.init(config); setTimeout(() => { - let targetingData = contxtfulSubmodule.getTargetingData(['ad-slot'], config); + const targetingData = contxtfulSubmodule.getTargetingData(['ad-slot'], config); expect(targetingData).to.deep.equal({}); done(); }, TIMEOUT); @@ -251,12 +251,12 @@ describe('contxtfulRtdProvider', function () { theories.forEach(([initialReceptivityEvent, _description]) => { it('figures out that initial receptivity is invalid and it does not initialize receptivity value', (done) => { - let config = buildInitConfig(VERSION, CUSTOMER); + const config = buildInitConfig(VERSION, CUSTOMER); contxtfulSubmodule.init(config); loadExternalScriptTag.dispatchEvent(initialReceptivityEvent); setTimeout(() => { - let targetingData = contxtfulSubmodule.getTargetingData(['ad-slot'], config); + const targetingData = contxtfulSubmodule.getTargetingData(['ad-slot'], config); expect(targetingData).to.deep.equal({}); done(); }, TIMEOUT); @@ -285,12 +285,12 @@ describe('contxtfulRtdProvider', function () { theories.forEach(([adUnits, expected, description]) => { it('adds receptivity to the ad units using the RX API', function (done) { - let config = buildInitConfig(VERSION, CUSTOMER); + const config = buildInitConfig(VERSION, CUSTOMER); contxtfulSubmodule.init(config); window.dispatchEvent(RX_CONNECTOR_IS_READY_EVENT); setTimeout(() => { - let targetingData = contxtfulSubmodule.getTargetingData(adUnits, config); + const targetingData = contxtfulSubmodule.getTargetingData(adUnits, config); expect(targetingData, description).to.deep.equal(expected, description); done(); }, TIMEOUT); @@ -317,26 +317,26 @@ describe('contxtfulRtdProvider', function () { theories.forEach(([adUnits, expected, description]) => { it('honours "adServerTargeting" and the RX API is not called', function (done) { - let config = buildInitConfig(VERSION, CUSTOMER); + const config = buildInitConfig(VERSION, CUSTOMER); config.params.adServerTargeting = false; contxtfulSubmodule.init(config); window.dispatchEvent(RX_CONNECTOR_IS_READY_EVENT); setTimeout(() => { - let _ = contxtfulSubmodule.getTargetingData(adUnits, config); + const _ = contxtfulSubmodule.getTargetingData(adUnits, config); expect(RX_API_MOCK.receptivity.callCount).to.be.equal(0); done(); }, TIMEOUT); }); it('honours adServerTargeting and it does not add receptivity to the ad units', function (done) { - let config = buildInitConfig(VERSION, CUSTOMER); + const config = buildInitConfig(VERSION, CUSTOMER); config.params.adServerTargeting = false; contxtfulSubmodule.init(config); window.dispatchEvent(RX_CONNECTOR_IS_READY_EVENT); setTimeout(() => { - let targetingData = contxtfulSubmodule.getTargetingData(adUnits, config); + const targetingData = contxtfulSubmodule.getTargetingData(adUnits, config); expect(targetingData, description).to.deep.equal(expected); done(); }, TIMEOUT); @@ -368,10 +368,10 @@ describe('contxtfulRtdProvider', function () { // Simulate that there was a write to sessionStorage in the past. storage.setDataInSessionStorage(CUSTOMER, JSON.stringify({ exp: new Date().getTime() + 1000, rx: RX_FROM_SESSION_STORAGE })) - let config = buildInitConfig(VERSION, CUSTOMER); + const config = buildInitConfig(VERSION, CUSTOMER); contxtfulSubmodule.init(config); - let targetingData = contxtfulSubmodule.getTargetingData(adUnits, config); + const targetingData = contxtfulSubmodule.getTargetingData(adUnits, config); expect(targetingData).to.deep.equal(expected); done(); @@ -401,10 +401,10 @@ describe('contxtfulRtdProvider', function () { // Simulate that there was a write to sessionStorage in the past. storage.setDataInSessionStorage(CUSTOMER, JSON.stringify({ exp: new Date().getTime() - 100, rx: RX_FROM_SESSION_STORAGE })); - let config = buildInitConfig(VERSION, CUSTOMER); + const config = buildInitConfig(VERSION, CUSTOMER); contxtfulSubmodule.init(config); - let targetingData = contxtfulSubmodule.getTargetingData(adUnits, config); + const targetingData = contxtfulSubmodule.getTargetingData(adUnits, config); expect(targetingData).to.deep.equal(expected); done(); @@ -417,7 +417,7 @@ describe('contxtfulRtdProvider', function () { contxtfulSubmodule.init(buildInitConfig(VERSION, CUSTOMER)); window.dispatchEvent(RX_CONNECTOR_IS_READY_EVENT); - let reqBidsConfigObj = { + const reqBidsConfigObj = { ortb2Fragments: { global: {}, bidder: {}, @@ -435,11 +435,11 @@ describe('contxtfulRtdProvider', function () { describe('getBidRequestData', function () { it('does not write receptivity to the global OpenRTB 2 fragment', function (done) { - let config = buildInitConfig(VERSION, CUSTOMER); + const config = buildInitConfig(VERSION, CUSTOMER); contxtfulSubmodule.init(config); window.dispatchEvent(RX_CONNECTOR_IS_READY_EVENT); - let reqBidsConfigObj = { + const reqBidsConfigObj = { ortb2Fragments: { global: {}, bidder: {}, @@ -457,18 +457,18 @@ describe('contxtfulRtdProvider', function () { describe('getBidRequestData', function () { it('writes receptivity to the configured bidder OpenRTB 2 fragments', function (done) { - let config = buildInitConfig(VERSION, CUSTOMER); + const config = buildInitConfig(VERSION, CUSTOMER); contxtfulSubmodule.init(config); window.dispatchEvent(RX_CONNECTOR_IS_READY_EVENT); - let reqBidsConfigObj = { + const reqBidsConfigObj = { ortb2Fragments: { global: {}, bidder: {}, }, }; - let expectedData = { + const expectedData = { name: 'contxtful', ext: { rx: RX_FROM_API, @@ -483,7 +483,7 @@ describe('contxtfulRtdProvider', function () { const onDoneSpy = sinon.spy(); contxtfulSubmodule.getBidRequestData(reqBidsConfigObj, onDoneSpy, config); - let data = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0]; + const data = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0]; expect(data.name).to.deep.equal(expectedData.name); expect(data.ext.rx).to.deep.equal(expectedData.ext.rx); @@ -495,14 +495,14 @@ describe('contxtfulRtdProvider', function () { describe('getBidRequestData', function () { it('uses non-expired info from session storage and adds receptivity to the reqBidsConfigObj', function (done) { - let config = buildInitConfig(VERSION, CUSTOMER); + const config = buildInitConfig(VERSION, CUSTOMER); // Simulate that there was a write to sessionStorage in the past. - let bidder = config.params.bidders[0]; + const bidder = config.params.bidders[0]; storage.setDataInSessionStorage(`${config.params.customer}_${bidder}`, JSON.stringify({ exp: new Date().getTime() + 1000, rx: RX_FROM_SESSION_STORAGE })); - let reqBidsConfigObj = { + const reqBidsConfigObj = { ortb2Fragments: { global: {}, bidder: {}, @@ -515,9 +515,9 @@ describe('contxtfulRtdProvider', function () { contxtfulSubmodule.getBidRequestData(reqBidsConfigObj, () => { }, config); setTimeout(() => { - let ortb2BidderFragment = reqBidsConfigObj.ortb2Fragments.bidder[bidder]; - let userData = ortb2BidderFragment.user.data; - let contxtfulData = userData[0]; + const ortb2BidderFragment = reqBidsConfigObj.ortb2Fragments.bidder[bidder]; + const userData = ortb2BidderFragment.user.data; + const contxtfulData = userData[0]; expect(contxtfulData.name).to.be.equal('contxtful'); expect(contxtfulData.ext.rx).to.deep.equal(RX_FROM_SESSION_STORAGE); @@ -533,11 +533,11 @@ describe('contxtfulRtdProvider', function () { describe('getBidRequestData', function () { it('uses the RX API', function (done) { - let config = buildInitConfig(VERSION, CUSTOMER); + const config = buildInitConfig(VERSION, CUSTOMER); contxtfulSubmodule.init(config); window.dispatchEvent(RX_CONNECTOR_IS_READY_EVENT); - let reqBidsConfigObj = { + const reqBidsConfigObj = { ortb2Fragments: { global: {}, bidder: {}, @@ -558,18 +558,18 @@ describe('contxtfulRtdProvider', function () { describe('getBidRequestData', function () { it('adds receptivity to the reqBidsConfigObj', function (done) { - let config = buildInitConfig(VERSION, CUSTOMER); + const config = buildInitConfig(VERSION, CUSTOMER); contxtfulSubmodule.init(config); window.dispatchEvent(RX_CONNECTOR_IS_READY_EVENT); - let reqBidsConfigObj = { + const reqBidsConfigObj = { ortb2Fragments: { global: {}, bidder: {}, }, }; - let expectedData = { + const expectedData = { name: 'contxtful', ext: { rx: RX_FROM_API, @@ -585,7 +585,7 @@ describe('contxtfulRtdProvider', function () { const onDoneSpy = sinon.spy(); contxtfulSubmodule.getBidRequestData(reqBidsConfigObj, onDoneSpy, config); - let data = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0]; + const data = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0]; expect(data.name).to.deep.equal(expectedData.name); expect(data.ext.rx).to.deep.equal(expectedData.ext.rx); @@ -596,26 +596,26 @@ describe('contxtfulRtdProvider', function () { }); it('does not change the sm', function (done) { - let config = buildInitConfig(VERSION, CUSTOMER); + const config = buildInitConfig(VERSION, CUSTOMER); contxtfulSubmodule.init(config); window.dispatchEvent(RX_CONNECTOR_IS_READY_EVENT); - let firstReqBidsConfigObj = { + const firstReqBidsConfigObj = { ortb2Fragments: { global: {}, bidder: {}, }, }; - let secondReqBidsConfigObj = deepClone(firstReqBidsConfigObj); + const secondReqBidsConfigObj = deepClone(firstReqBidsConfigObj); setTimeout(() => { const onDoneSpy = sinon.spy(); contxtfulSubmodule.getBidRequestData(firstReqBidsConfigObj, onDoneSpy, config); contxtfulSubmodule.getBidRequestData(secondReqBidsConfigObj, onDoneSpy, config); - let firstData = firstReqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0]; - let secondData = secondReqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0]; + const firstData = firstReqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0]; + const secondData = secondReqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0]; expect(firstData.ext.sm).to.equal(secondData.ext.sm); @@ -634,12 +634,12 @@ describe('contxtfulRtdProvider', function () { moveEventTheories.forEach(([event, expected, _description]) => { it('adds move event', function (done) { - let config = buildInitConfig(VERSION, CUSTOMER); + const config = buildInitConfig(VERSION, CUSTOMER); contxtfulSubmodule.init(config); window.dispatchEvent(event); - let reqBidsConfigObj = { + const reqBidsConfigObj = { ortb2Fragments: { global: {}, bidder: {}, @@ -650,9 +650,9 @@ describe('contxtfulRtdProvider', function () { const onDoneSpy = sinon.spy(); contxtfulSubmodule.getBidRequestData(reqBidsConfigObj, onDoneSpy, config); - let ext = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0].ext; + const ext = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0].ext; - let events = JSON.parse(atob(ext.events)); + const events = JSON.parse(atob(ext.events)); expect(events.ui.position.x).to.be.deep.equal(expected.x); expect(events.ui.position.y).to.be.deep.equal(expected.y); @@ -663,14 +663,14 @@ describe('contxtfulRtdProvider', function () { }); it('adds screen event', function (done) { - let config = buildInitConfig(VERSION, CUSTOMER); + const config = buildInitConfig(VERSION, CUSTOMER); contxtfulSubmodule.init(config); // Cannot change the window size from JS // So we take the current size as expectation const { innerHeight: height, innerWidth: width } = getWinDimensions() - let reqBidsConfigObj = { + const reqBidsConfigObj = { ortb2Fragments: { global: {}, bidder: {}, @@ -681,9 +681,9 @@ describe('contxtfulRtdProvider', function () { const onDoneSpy = sinon.spy(); contxtfulSubmodule.getBidRequestData(reqBidsConfigObj, onDoneSpy, config); - let ext = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0].ext; + const ext = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0].ext; - let events = JSON.parse(atob(ext.events)); + const events = JSON.parse(atob(ext.events)); expect(events.ui.screen.topLeft).to.be.deep.equal({ x: 0, y: 0 }, 'screen top left'); expect(events.ui.screen.width).to.be.deep.equal(width, 'screen width'); @@ -697,9 +697,9 @@ describe('contxtfulRtdProvider', function () { describe('when there is no ad units', function () { it('adds empty ad unit positions', function (done) { - let config = buildInitConfig(VERSION, CUSTOMER); + const config = buildInitConfig(VERSION, CUSTOMER); contxtfulSubmodule.init(config); - let reqBidsConfigObj = { + const reqBidsConfigObj = { ortb2Fragments: { global: {}, bidder: {}, @@ -709,8 +709,8 @@ describe('contxtfulRtdProvider', function () { const onDoneSpy = sinon.spy(); contxtfulSubmodule.getBidRequestData(reqBidsConfigObj, onDoneSpy, config); - let ext = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0].ext; - let pos = JSON.parse(atob(ext.pos)); + const ext = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0].ext; + const pos = JSON.parse(atob(ext.pos)); expect(Object.keys(pos).length).to.be.equal(0); done(); @@ -720,9 +720,9 @@ describe('contxtfulRtdProvider', function () { describe('when there are ad units', function () { it('return empty objects for ad units that we can\'t get position of', function (done) { - let config = buildInitConfig(VERSION, CUSTOMER); + const config = buildInitConfig(VERSION, CUSTOMER); contxtfulSubmodule.init(config); - let reqBidsConfigObj = { + const reqBidsConfigObj = { adUnits: [ { code: 'code1' }, { code: 'code2' } @@ -736,8 +736,8 @@ describe('contxtfulRtdProvider', function () { const onDoneSpy = sinon.spy(); contxtfulSubmodule.getBidRequestData(reqBidsConfigObj, onDoneSpy, config); - let ext = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0].ext; - let pos = JSON.parse(atob(ext.pos)); + const ext = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0].ext; + const pos = JSON.parse(atob(ext.pos)); expect(Object.keys(pos).length).to.be.equal(0); done(); @@ -745,9 +745,9 @@ describe('contxtfulRtdProvider', function () { }); it('returns the IAB position if the ad unit div id cannot be bound but property pos can be found in the ad unit', function (done) { - let config = buildInitConfig(VERSION, CUSTOMER); + const config = buildInitConfig(VERSION, CUSTOMER); contxtfulSubmodule.init(config); - let reqBidsConfigObj = { + const reqBidsConfigObj = { adUnits: [ { code: 'code1', mediaTypes: { banner: { pos: 4 } } }, { code: 'code2', mediaTypes: { banner: { pos: 5 } } }, @@ -762,8 +762,8 @@ describe('contxtfulRtdProvider', function () { const onDoneSpy = sinon.spy(); contxtfulSubmodule.getBidRequestData(reqBidsConfigObj, onDoneSpy, config); - let ext = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0].ext; - let pos = JSON.parse(atob(ext.pos)); + const ext = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0].ext; + const pos = JSON.parse(atob(ext.pos)); expect(Object.keys(pos).length).to.be.equal(3); expect(pos['code1'].p).to.be.equal(4); @@ -787,7 +787,7 @@ describe('contxtfulRtdProvider', function () { } function InitDivStubPositions(config, withIframe, isVisible, forceGetElementById = true) { - let fakeElem = fakeGetElementById(100, 100, 30, 30); + const fakeElem = fakeGetElementById(100, 100, 30, 30); if (isVisible) { fakeElem.checkVisibility = function () { return true }; sandbox.stub(window.top, 'getComputedStyle').returns({ display: 'block' }); @@ -797,7 +797,7 @@ describe('contxtfulRtdProvider', function () { } if (withIframe) { - let ws = { + const ws = { frameElement: { getBoundingClientRect: () => fakeElem.getBoundingClientRect() }, @@ -821,8 +821,8 @@ describe('contxtfulRtdProvider', function () { describe('when the div id cannot be found, we should try with GPT method', function () { it('returns an empty list if gpt not find the div', function (done) { - let config = buildInitConfig(VERSION, CUSTOMER); - let reqBidsConfigObj = { + const config = buildInitConfig(VERSION, CUSTOMER); + const reqBidsConfigObj = { adUnits: [ { code: 'code1' }, { code: 'code2' } @@ -833,7 +833,7 @@ describe('contxtfulRtdProvider', function () { }, }; InitDivStubPositions(config, false, true, false); - let fakeElem = fakeGetElementById(100, 100, 30, 30); + const fakeElem = fakeGetElementById(100, 100, 30, 30); sandbox.stub(window.top.document, 'getElementById').returns(function (id) { if (id == 'code1' || id == 'code2') { return undefined; @@ -845,8 +845,8 @@ describe('contxtfulRtdProvider', function () { const onDoneSpy = sinon.spy(); contxtfulSubmodule.getBidRequestData(reqBidsConfigObj, onDoneSpy, config); - let ext = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0].ext; - let pos = JSON.parse(atob(ext.pos)); + const ext = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0].ext; + const pos = JSON.parse(atob(ext.pos)); expect(Object.keys(pos).length).to.be.equal(0); done(); @@ -854,8 +854,8 @@ describe('contxtfulRtdProvider', function () { }) it('returns object visibility and position if gpt not found but the div id is the ad unit code', function (done) { - let config = buildInitConfig(VERSION, CUSTOMER); - let reqBidsConfigObj = { + const config = buildInitConfig(VERSION, CUSTOMER); + const reqBidsConfigObj = { adUnits: [ { code: 'code1' }, { code: 'code2' } @@ -870,8 +870,8 @@ describe('contxtfulRtdProvider', function () { const onDoneSpy = sinon.spy(); contxtfulSubmodule.getBidRequestData(reqBidsConfigObj, onDoneSpy, config); - let ext = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0].ext; - let pos = JSON.parse(atob(ext.pos)); + const ext = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0].ext; + const pos = JSON.parse(atob(ext.pos)); expect(Object.keys(pos).length).to.be.equal(2); expect(pos['code1'].p.x).to.be.equal(30); @@ -882,8 +882,8 @@ describe('contxtfulRtdProvider', function () { }); it('returns object visibility and position if gpt finds the div', function (done) { - let config = buildInitConfig(VERSION, CUSTOMER); - let reqBidsConfigObj = { + const config = buildInitConfig(VERSION, CUSTOMER); + const reqBidsConfigObj = { adUnits: [ { code: 'code1' }, { code: 'code2' } @@ -900,8 +900,8 @@ describe('contxtfulRtdProvider', function () { const onDoneSpy = sinon.spy(); contxtfulSubmodule.getBidRequestData(reqBidsConfigObj, onDoneSpy, config); - let ext = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0].ext; - let pos = JSON.parse(atob(ext.pos)); + const ext = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0].ext; + const pos = JSON.parse(atob(ext.pos)); expect(Object.keys(pos).length).to.be.equal(2); expect(pos['code1'].p.x).to.be.equal(30); @@ -913,18 +913,18 @@ describe('contxtfulRtdProvider', function () { }); describe('when we get object visibility and position for ad units that we can get div id', function () { - let config = buildInitConfig(VERSION, CUSTOMER); + const config = buildInitConfig(VERSION, CUSTOMER); describe('when we are not in an iframe', function () { it('return object visibility true if element is visible', function (done) { - let reqBidsConfigObj = getFakeRequestBidConfigObj(); + const reqBidsConfigObj = getFakeRequestBidConfigObj(); InitDivStubPositions(config, false, true); setTimeout(() => { const onDoneSpy = sinon.spy(); contxtfulSubmodule.getBidRequestData(reqBidsConfigObj, onDoneSpy, config); - let ext = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0].ext; - let pos = JSON.parse(atob(ext.pos)); + const ext = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0].ext; + const pos = JSON.parse(atob(ext.pos)); expect(Object.keys(pos).length).to.be.equal(2); expect(pos['code1'].p.x).to.be.equal(30); @@ -935,14 +935,14 @@ describe('contxtfulRtdProvider', function () { }); it('return object visibility false if element is not visible', function (done) { - let reqBidsConfigObj = getFakeRequestBidConfigObj(); + const reqBidsConfigObj = getFakeRequestBidConfigObj(); InitDivStubPositions(config, false, false); setTimeout(() => { const onDoneSpy = sinon.spy(); contxtfulSubmodule.getBidRequestData(reqBidsConfigObj, onDoneSpy, config); - let ext = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0].ext; - let pos = JSON.parse(atob(ext.pos)); + const ext = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0].ext; + const pos = JSON.parse(atob(ext.pos)); expect(Object.keys(pos).length).to.be.equal(2); expect(pos['code1'].v).to.be.equal(false); @@ -954,14 +954,14 @@ describe('contxtfulRtdProvider', function () { describe('when we are in an iframe', function () { it('return object visibility true if element is visible', function (done) { - let reqBidsConfigObj = getFakeRequestBidConfigObj(); + const reqBidsConfigObj = getFakeRequestBidConfigObj(); InitDivStubPositions(config, true, true) setTimeout(() => { const onDoneSpy = sinon.spy(); contxtfulSubmodule.getBidRequestData(reqBidsConfigObj, onDoneSpy, config); - let ext = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0].ext; - let pos = JSON.parse(atob(ext.pos)); + const ext = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0].ext; + const pos = JSON.parse(atob(ext.pos)); expect(Object.keys(pos).length).to.be.equal(2); expect(pos['code1'].p.x).to.be.equal(30); @@ -972,14 +972,14 @@ describe('contxtfulRtdProvider', function () { }); it('return object visibility false if element is not visible', function (done) { - let reqBidsConfigObj = getFakeRequestBidConfigObj(); + const reqBidsConfigObj = getFakeRequestBidConfigObj(); InitDivStubPositions(config, true, false); setTimeout(() => { const onDoneSpy = sinon.spy(); contxtfulSubmodule.getBidRequestData(reqBidsConfigObj, onDoneSpy, config); - let ext = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0].ext; - let pos = JSON.parse(atob(ext.pos)); + const ext = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0].ext; + const pos = JSON.parse(atob(ext.pos)); expect(Object.keys(pos).length).to.be.equal(2); expect(pos['code1'].v).to.be.equal(false); @@ -992,11 +992,11 @@ describe('contxtfulRtdProvider', function () { describe('after rxApi is loaded', function () { it('should add event', function (done) { - let config = buildInitConfig(VERSION, CUSTOMER); + const config = buildInitConfig(VERSION, CUSTOMER); contxtfulSubmodule.init(config); window.dispatchEvent(RX_CONNECTOR_IS_READY_EVENT); - let reqBidsConfigObj = { + const reqBidsConfigObj = { ortb2Fragments: { global: {}, bidder: {}, @@ -1007,9 +1007,9 @@ describe('contxtfulRtdProvider', function () { const onDoneSpy = sinon.spy(); contxtfulSubmodule.getBidRequestData(reqBidsConfigObj, onDoneSpy, config); - let ext = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0].ext; + const ext = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]].user.data[0].ext; - let events = ext.events; + const events = ext.events; expect(events).to.be.not.undefined; done(); @@ -1022,11 +1022,11 @@ describe('contxtfulRtdProvider', function () { RX_CONNECTOR_MOCK.rxApiBuilder.resetHistory(); RX_CONNECTOR_MOCK.rxApiBuilder.callsFake((_config) => new Promise((resolve, reject) => resolve(RX_API_MOCK_WITH_BUNDLE))); - let config = buildInitConfig(VERSION, CUSTOMER); + const config = buildInitConfig(VERSION, CUSTOMER); contxtfulSubmodule.init(config); window.dispatchEvent(RX_CONNECTOR_IS_READY_EVENT); - let reqBidsConfigObj = { + const reqBidsConfigObj = { ortb2Fragments: { global: {}, bidder: {}, @@ -1036,11 +1036,11 @@ describe('contxtfulRtdProvider', function () { setTimeout(() => { const onDoneSpy = sinon.spy(); contxtfulSubmodule.getBidRequestData(reqBidsConfigObj, onDoneSpy, config); - let global = reqBidsConfigObj.ortb2Fragments.global; - let bidder = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]]; + const global = reqBidsConfigObj.ortb2Fragments.global; + const bidder = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]]; - let globalExpected = { user: { site: { id: 'globalsiteId' } } }; - let bidderExpected = { user: { data: [{ name: MODULE_NAME, value: RX_FROM_API }] } }; + const globalExpected = { user: { site: { id: 'globalsiteId' } } }; + const bidderExpected = { user: { data: [{ name: MODULE_NAME, value: RX_FROM_API }] } }; expect(RX_API_MOCK_WITH_BUNDLE.getOrtb2Fragment.callCount).to.equal(1); expect(global).to.deep.equal(globalExpected); expect(bidder).to.deep.equal(bidderExpected); diff --git a/test/spec/modules/conversantBidAdapter_spec.js b/test/spec/modules/conversantBidAdapter_spec.js index 820f11b8eaf..acf295074c2 100644 --- a/test/spec/modules/conversantBidAdapter_spec.js +++ b/test/spec/modules/conversantBidAdapter_spec.js @@ -605,7 +605,7 @@ describe('Conversant adapter tests', function() { describe('Extended ID', function() { it('Verify unifiedid and liveramp', function() { // clone bidRequests - let requests = utils.deepClone(bidRequests); + const requests = utils.deepClone(bidRequests); const eidArray = [{'source': 'pubcid.org', 'uids': [{'id': '112233', 'atype': 1}]}, {'source': 'liveramp.com', 'uids': [{'id': '334455', 'atype': 3}]}]; diff --git a/test/spec/modules/copper6sspBidAdapter_spec.js b/test/spec/modules/copper6sspBidAdapter_spec.js index 4e62a416fb8..56acb16bab2 100644 --- a/test/spec/modules/copper6sspBidAdapter_spec.js +++ b/test/spec/modules/copper6sspBidAdapter_spec.js @@ -132,7 +132,7 @@ describe('Copper6SSPBidAdapter', function () { }); it('Returns general data valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys( 'deviceWidth', @@ -213,7 +213,7 @@ describe('Copper6SSPBidAdapter', function () { } ]; - let serverRequest = spec.buildRequests(bids, bidderRequest); + const serverRequest = spec.buildRequests(bids, bidderRequest); const { placements } = serverRequest.data; for (let i = 0, len = placements.length; i < len; i++) { @@ -248,7 +248,7 @@ describe('Copper6SSPBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { delete bidderRequest.uspConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('object'); expect(data.gdpr).to.have.property('consentString'); @@ -262,7 +262,7 @@ describe('Copper6SSPBidAdapter', function () { bidderRequest.uspConsent = '1---'; delete bidderRequest.gdprConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -277,8 +277,8 @@ describe('Copper6SSPBidAdapter', function () { applicableSections: [8] }; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -292,8 +292,8 @@ describe('Copper6SSPBidAdapter', function () { bidderRequest.ortb2.regs.gpp = 'abc123'; bidderRequest.ortb2.regs.gpp_sid = [8]; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -323,9 +323,9 @@ describe('Copper6SSPBidAdapter', function () { } }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(banner.body[0].requestId); @@ -357,10 +357,10 @@ describe('Copper6SSPBidAdapter', function () { } }] }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -394,10 +394,10 @@ describe('Copper6SSPBidAdapter', function () { } }] }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys('requestId', 'cpm', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'native', 'meta'); expect(dataItem.native).to.have.keys('clickUrl', 'impressionTrackers', 'title', 'image') expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -428,7 +428,7 @@ describe('Copper6SSPBidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -444,7 +444,7 @@ describe('Copper6SSPBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -461,7 +461,7 @@ describe('Copper6SSPBidAdapter', function () { currency: 'USD', }] }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -474,7 +474,7 @@ describe('Copper6SSPBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/craftBidAdapter_spec.js b/test/spec/modules/craftBidAdapter_spec.js index d74477c5b8b..eee249b0ab0 100644 --- a/test/spec/modules/craftBidAdapter_spec.js +++ b/test/spec/modules/craftBidAdapter_spec.js @@ -4,7 +4,7 @@ import {newBidder} from 'src/adapters/bidderFactory.js'; import {config} from 'src/config.js'; describe('craftAdapter', function () { - let adapter = newBidder(spec); + const adapter = newBidder(spec); describe('inherited functions', function () { it('exists and is a function', function () { @@ -27,7 +27,7 @@ describe('craftAdapter', function () { $$PREBID_GLOBAL$$.bidderSettings = {}; window.context = this.windowContext; }); - let bid = { + const bid = { bidder: 'craft', params: { sitekey: 'craft-prebid-example', @@ -40,7 +40,7 @@ describe('craftAdapter', function () { }); it('should return false when params.sitekey not found', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = { placementId: '1234abcd' @@ -49,7 +49,7 @@ describe('craftAdapter', function () { }); it('should return false when params.placementId not found', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = { sitekey: 'craft-prebid-example' @@ -76,7 +76,7 @@ describe('craftAdapter', function () { after(function () { $$PREBID_GLOBAL$$.bidderSettings = {}; }); - let bidRequests = [{ + const bidRequests = [{ bidder: 'craft', params: { 'sitekey': 'craft-prebid-example', @@ -89,16 +89,16 @@ describe('craftAdapter', function () { auctionId: '8720f980-4639-4150-923a-e96da2f1de36', transactionId: 'e0c52da2-c008-491c-a910-c6765d948700', }]; - let bidderRequest = { + const bidderRequest = { refererInfo: { topmostLocation: 'https://www.gacraft.jp/publish/craft-prebid-example.html' } }; it('sends bid request to ENDPOINT via POST', function () { - let request = spec.buildRequests(bidRequests, bidderRequest); + const request = spec.buildRequests(bidRequests, bidderRequest); expect(request.method).to.equal('POST'); expect(request.url).to.equal('https://gacraft.jp/prebid-v3/craft-prebid-example'); - let data = JSON.parse(request.data); + const data = JSON.parse(request.data); expect(data.tags).to.deep.equals([{ sitekey: 'craft-prebid-example', placementId: '1234abcd', @@ -114,7 +114,7 @@ describe('craftAdapter', function () { }); describe('interpretResponse', function() { - let serverResponse = { + const serverResponse = { body: { tags: [{ uuid: '0396fae4eb5f47', @@ -137,14 +137,14 @@ describe('craftAdapter', function () { }], } }; - let bidderRequest = { + const bidderRequest = { bids: [{ bidId: '0396fae4eb5f47', adUnitCode: 'craft-prebid-example' }] }; it('should get correct bid response', function() { - let bids = spec.interpretResponse(serverResponse, {bidderRequest: bidderRequest}); + const bids = spec.interpretResponse(serverResponse, {bidderRequest: bidderRequest}); expect(bids).to.have.lengthOf(1); expect(bids[0]).to.deep.equals({ _adUnitCode: 'craft-prebid-example', diff --git a/test/spec/modules/criteoBidAdapter_spec.js b/test/spec/modules/criteoBidAdapter_spec.js index 2f1100b9152..5b7aca89e07 100644 --- a/test/spec/modules/criteoBidAdapter_spec.js +++ b/test/spec/modules/criteoBidAdapter_spec.js @@ -1192,7 +1192,7 @@ describe('The Criteo bidding adapter', function () { }, }, ]; - let dsa = { + const dsa = { required: 3, pubrender: 0, datatopub: 2, @@ -2432,7 +2432,7 @@ describe('The Criteo bidding adapter', function () { } it('should properly parse a bid response with FLEDGE auction configs', async function () { - let auctionConfig1 = { + const auctionConfig1 = { auctionSignals: {}, decisionLogicUrl: 'https://grid-mercury.criteo.com/fledge/decision', interestGroupBuyers: ['https://first-buyer-domain.com', 'https://second-buyer-domain.com'], @@ -2472,7 +2472,7 @@ describe('The Criteo bidding adapter', function () { }, sellerCurrency: 'USD', }; - let auctionConfig2 = { + const auctionConfig2 = { auctionSignals: {}, decisionLogicUrl: 'https://grid-mercury.criteo.com/fledge/decision', interestGroupBuyers: ['https://first-buyer-domain.com', 'https://second-buyer-domain.com'], diff --git a/test/spec/modules/criteoIdSystem_spec.js b/test/spec/modules/criteoIdSystem_spec.js index eb1f54d7cd2..3ea4f3d46c2 100644 --- a/test/spec/modules/criteoIdSystem_spec.js +++ b/test/spec/modules/criteoIdSystem_spec.js @@ -84,13 +84,13 @@ describe('CriteoId module', function () { getCookieStub.withArgs('cto_dna_bundle').returns('info'); window.criteo_pubtag = {} - let callBackSpy = sinon.spy(); - let result = criteoIdSubmodule.getId(); + const callBackSpy = sinon.spy(); + const result = criteoIdSubmodule.getId(); result.callback(callBackSpy); const expectedUrl = `https://gum.criteo.com/sid/json?origin=prebid&topUrl=https%3A%2F%2Ftestdev.com%2F&domain=testdev.com&bundle=bundle&info=info&cw=1&pbt=1&lsw=1`; - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.be.eq(expectedUrl); request.respond( @@ -124,7 +124,7 @@ describe('CriteoId module', function () { expect(id).to.be.deep.equal(response.bidId ? { criteoId: response.bidId } : undefined); }); - let request = server.requests[0]; + const request = server.requests[0]; request.respond( 200, { 'Content-Type': 'application/json' }, @@ -262,14 +262,14 @@ describe('CriteoId module', function () { }); gdprConsentTestCases.forEach(testCase => it('should call user sync url with the gdprConsent', function () { - let callBackSpy = sinon.spy(); + const callBackSpy = sinon.spy(); gdprConsentDataStub.returns(testCase.consentData); - let result = criteoIdSubmodule.getId(undefined); + const result = criteoIdSubmodule.getId(undefined); result.callback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; if (testCase.expectedGdprConsent) { expect(request.url).to.have.string(`gdprString=${testCase.expectedGdprConsent}`); @@ -293,14 +293,14 @@ describe('CriteoId module', function () { })); [undefined, 'abc'].forEach(usPrivacy => it('should call user sync url with the us privacy string', function () { - let callBackSpy = sinon.spy(); + const callBackSpy = sinon.spy(); uspConsentDataStub.returns(usPrivacy); - let result = criteoIdSubmodule.getId(undefined); + const result = criteoIdSubmodule.getId(undefined); result.callback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; if (usPrivacy) { expect(request.url).to.have.string(`us_privacy=${usPrivacy}`); @@ -332,14 +332,14 @@ describe('CriteoId module', function () { expectedGppSid: undefined } ].forEach(testCase => it('should call user sync url with the gpp string', function () { - let callBackSpy = sinon.spy(); + const callBackSpy = sinon.spy(); gppConsentDataStub.returns(testCase.consentData); - let result = criteoIdSubmodule.getId(undefined); + const result = criteoIdSubmodule.getId(undefined); result.callback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; if (testCase.expectedGpp) { expect(request.url).to.have.string(`gpp=${testCase.expectedGpp}`); diff --git a/test/spec/modules/currency_spec.js b/test/spec/modules/currency_spec.js index 6dc50bd284c..774e4617404 100644 --- a/test/spec/modules/currency_spec.js +++ b/test/spec/modules/currency_spec.js @@ -27,7 +27,7 @@ describe('currency', function () { let sandbox; let clock; - let fn = sinon.spy(); + const fn = sinon.spy(); function makeBid(bidProps) { return Object.assign(createBid(), bidProps); diff --git a/test/spec/modules/cwireBidAdapter_spec.js b/test/spec/modules/cwireBidAdapter_spec.js index 60814834d9c..ecba4403851 100644 --- a/test/spec/modules/cwireBidAdapter_spec.js +++ b/test/spec/modules/cwireBidAdapter_spec.js @@ -11,7 +11,7 @@ describe("C-WIRE bid adapter", () => { config.setConfig({ debug: true }); let sandbox; const adapter = newBidder(spec); - let bidRequests = [ + const bidRequests = [ { bidder: "cwire", params: { @@ -87,7 +87,7 @@ describe("C-WIRE bid adapter", () => { it("should add creativeId if url parameter given", function () { // set from bid.params - let bidRequest = deepClone(bidRequests[0]); + const bidRequest = deepClone(bidRequests[0]); const request = spec.buildRequests([bidRequest]); const payload = JSON.parse(request.data); @@ -108,7 +108,7 @@ describe("C-WIRE bid adapter", () => { }); }); it("width and height should be set", function () { - let bidRequest = deepClone(bidRequests[0]); + const bidRequest = deepClone(bidRequests[0]); const request = spec.buildRequests([bidRequest]); const payload = JSON.parse(request.data); @@ -140,7 +140,7 @@ describe("C-WIRE bid adapter", () => { }); }); it("css maxWidth should be set", function () { - let bidRequest = deepClone(bidRequests[0]); + const bidRequest = deepClone(bidRequests[0]); const request = spec.buildRequests([bidRequest]); const payload = JSON.parse(request.data); @@ -165,7 +165,7 @@ describe("C-WIRE bid adapter", () => { }); it("read from url parameter", function () { - let bidRequest = deepClone(bidRequests[0]); + const bidRequest = deepClone(bidRequests[0]); const request = spec.buildRequests([bidRequest]); const payload = JSON.parse(request.data); @@ -188,7 +188,7 @@ describe("C-WIRE bid adapter", () => { }); it("read from url parameter", function () { - let bidRequest = deepClone(bidRequests[0]); + const bidRequest = deepClone(bidRequests[0]); const request = spec.buildRequests([bidRequest]); const payload = JSON.parse(request.data); @@ -211,7 +211,7 @@ describe("C-WIRE bid adapter", () => { }); it("read from url parameter", function () { - let bidRequest = deepClone(bidRequests[0]); + const bidRequest = deepClone(bidRequests[0]); const request = spec.buildRequests([bidRequest]); const payload = JSON.parse(request.data); @@ -236,7 +236,7 @@ describe("C-WIRE bid adapter", () => { }); it("cw_id is set", function () { - let bidRequest = deepClone(bidRequests[0]); + const bidRequest = deepClone(bidRequests[0]); const request = spec.buildRequests([bidRequest]); const payload = JSON.parse(request.data); @@ -261,7 +261,7 @@ describe("C-WIRE bid adapter", () => { }); }); it("pageId flattened", function () { - let bidRequest = deepClone(bidRequests[0]); + const bidRequest = deepClone(bidRequests[0]); const request = spec.buildRequests([bidRequest]); const payload = JSON.parse(request.data); @@ -277,7 +277,7 @@ describe("C-WIRE bid adapter", () => { describe("pageId and placementId are required params", function () { it("invalid request", function () { - let bidRequest = deepClone(bidRequests[0]); + const bidRequest = deepClone(bidRequests[0]); delete bidRequest.params; const valid = spec.isBidRequestValid(bidRequest); @@ -285,7 +285,7 @@ describe("C-WIRE bid adapter", () => { }); it("valid request", function () { - let bidRequest = deepClone(bidRequests[0]); + const bidRequest = deepClone(bidRequests[0]); bidRequest.params.pageId = 42; bidRequest.params.placementId = 42; @@ -294,7 +294,7 @@ describe("C-WIRE bid adapter", () => { }); it("cwcreative must be of type string", function () { - let bidRequest = deepClone(bidRequests[0]); + const bidRequest = deepClone(bidRequests[0]); bidRequest.params.pageId = 42; bidRequest.params.placementId = 42; @@ -303,7 +303,7 @@ describe("C-WIRE bid adapter", () => { }); it("build request adds pageId", function () { - let bidRequest = deepClone(bidRequests[0]); + const bidRequest = deepClone(bidRequests[0]); const request = spec.buildRequests([bidRequest]); const payload = JSON.parse(request.data); @@ -314,7 +314,7 @@ describe("C-WIRE bid adapter", () => { describe("process serverResponse", function () { it("html to ad mapping", function () { - let bidResponse = deepClone(response); + const bidResponse = deepClone(response); const bids = spec.interpretResponse(bidResponse, {}); expect(bids[0].ad).to.exist; @@ -328,7 +328,7 @@ describe("C-WIRE bid adapter", () => { expect(userSyncs).to.be.empty; }); it("empty user-syncs if no syncOption enabled", function () { - let gdprConsent = { + const gdprConsent = { vendorData: { purpose: { consents: 1, @@ -343,7 +343,7 @@ describe("C-WIRE bid adapter", () => { }); it("user-syncs with enabled pixel option", function () { - let gdprConsent = { + const gdprConsent = { vendorData: { purpose: { consents: 1, @@ -352,7 +352,7 @@ describe("C-WIRE bid adapter", () => { gdprApplies: false, consentString: "testConsentString", }; - let synOptions = { pixelEnabled: true, iframeEnabled: true }; + const synOptions = { pixelEnabled: true, iframeEnabled: true }; const userSyncs = spec.getUserSyncs(synOptions, {}, gdprConsent, {}); expect(userSyncs[0].type).to.equal("image"); @@ -362,7 +362,7 @@ describe("C-WIRE bid adapter", () => { }); it("user-syncs with enabled iframe option", function () { - let gdprConsent = { + const gdprConsent = { vendorData: { purpose: { consents: { @@ -373,7 +373,7 @@ describe("C-WIRE bid adapter", () => { gdprApplies: true, consentString: "abc123", }; - let synOptions = { iframeEnabled: true }; + const synOptions = { iframeEnabled: true }; const userSyncs = spec.getUserSyncs(synOptions, {}, gdprConsent, {}); expect(userSyncs[0].type).to.equal("iframe"); @@ -391,7 +391,7 @@ describe("C-WIRE bid adapter", () => { it("should include autoplay: true when autoplay is enabled", function () { sandbox.stub(autoplayLib, "isAutoplayEnabled").returns(true); - let bidRequest = deepClone(bidRequests[0]); + const bidRequest = deepClone(bidRequests[0]); const request = spec.buildRequests([bidRequest]); const payload = JSON.parse(request.data); @@ -401,7 +401,7 @@ describe("C-WIRE bid adapter", () => { it("should include autoplay: false when autoplay is disabled", function () { sandbox.stub(autoplayLib, "isAutoplayEnabled").returns(false); - let bidRequest = deepClone(bidRequests[0]); + const bidRequest = deepClone(bidRequests[0]); const request = spec.buildRequests([bidRequest]); const payload = JSON.parse(request.data); diff --git a/test/spec/modules/dailyhuntBidAdapter_spec.js b/test/spec/modules/dailyhuntBidAdapter_spec.js index ab75264d951..7541ca07d06 100644 --- a/test/spec/modules/dailyhuntBidAdapter_spec.js +++ b/test/spec/modules/dailyhuntBidAdapter_spec.js @@ -13,7 +13,7 @@ const _encodeURIComponent = function (a) { describe('DailyhuntAdapter', function () { describe('isBidRequestValid', function () { - let bid = { + const bid = { 'bidder': 'dailyhunt', 'params': { placement_id: 1, @@ -27,14 +27,14 @@ describe('DailyhuntAdapter', function () { }); it('should return false when required params are not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = {}; expect(spec.isBidRequestValid(invalidBid)).to.equal(false); }); }); describe('buildRequests', function() { - let bidRequests = [ + const bidRequests = [ { bidder: 'dailyhunt', params: { @@ -62,7 +62,7 @@ describe('DailyhuntAdapter', function () { transactionId: '04f2659e-c005-4eb1-a57c-fa93145e3843' } ]; - let nativeBidRequests = [ + const nativeBidRequests = [ { bidder: 'dailyhunt', params: { @@ -95,7 +95,7 @@ describe('DailyhuntAdapter', function () { transactionId: '04f2659e-c005-4eb1-a57c-fa93145e3843' } ]; - let videoBidRequests = [ + const videoBidRequests = [ { bidder: 'dailyhunt', params: { @@ -121,7 +121,7 @@ describe('DailyhuntAdapter', function () { transactionId: '04f2659e-c005-4eb1-a57c-fa93145e3843' } ]; - let bidderRequest = { + const bidderRequest = { 'bidderRequestId': '22edbae2733bf6', 'auctionId': '1d1a030790a475', 'bidderCode': 'dailyhunt', @@ -134,7 +134,7 @@ describe('DailyhuntAdapter', function () { 'referer': 'http://m.dailyhunt.in/' } }; - let nativeBidderRequest = { + const nativeBidderRequest = { 'bidderRequestId': '22edbae2733bf6', 'auctionId': '1d1a030790a475', 'bidderCode': 'dailyhunt', @@ -147,7 +147,7 @@ describe('DailyhuntAdapter', function () { 'referer': 'http://m.dailyhunt.in/' } }; - let videoBidderRequest = { + const videoBidderRequest = { 'bidderRequestId': '22edbae2733bf6', 'auctionId': '1d1a030790a475', 'bidderCode': 'dailyhunt', @@ -180,7 +180,7 @@ describe('DailyhuntAdapter', function () { }); }); describe('interpretResponse', function () { - let bidResponses = { + const bidResponses = { id: 'da32def7-6779-403c-ada7-0b201dbc9744', seatbid: [ { @@ -271,7 +271,7 @@ describe('DailyhuntAdapter', function () { }; it('should get correct bid response', function () { - let expectedResponse = [ + const expectedResponse = [ { requestId: '1', cpm: 1.4, @@ -343,7 +343,7 @@ describe('DailyhuntAdapter', function () { vastXml: 'adm', }, ]; - let bidderRequest = { + const bidderRequest = { bids: [ { bidId: 'banner-impid', @@ -377,7 +377,7 @@ describe('DailyhuntAdapter', function () { }, ] } - let result = spec.interpretResponse({ body: bidResponses }, bidderRequest); + const result = spec.interpretResponse({ body: bidResponses }, bidderRequest); result.forEach((r, i) => { expect(Object.keys(r)).to.have.members(Object.keys(expectedResponse[i])); }); @@ -385,7 +385,7 @@ describe('DailyhuntAdapter', function () { }) describe('onBidWon', function () { it('should hit win url when bid won', function () { - let bid = { + const bid = { requestId: '1', cpm: 1.4, creativeId: 'asd5ddbf014cac993.66466212', diff --git a/test/spec/modules/dataController_spec.js b/test/spec/modules/dataController_spec.js index 25f55047377..07e1c9c19f5 100644 --- a/test/spec/modules/dataController_spec.js +++ b/test/spec/modules/dataController_spec.js @@ -89,7 +89,7 @@ describe('data controller', function () { }); it('filterEIDwhenSDA for All SDA ', function () { - let dataControllerConfiguration = { + const dataControllerConfiguration = { 'dataController': { filterEIDwhenSDA: ['*'] } @@ -103,7 +103,7 @@ describe('data controller', function () { }); it('filterEIDwhenSDA for available SAD permutive.com:4:777777 ', function () { - let dataControllerConfiguration = { + const dataControllerConfiguration = { 'dataController': { filterEIDwhenSDA: ['permutive.com:4:777777'] } @@ -119,7 +119,7 @@ describe('data controller', function () { }); it('filterEIDwhenSDA for unavailable SAD test.com:4:9999 ', function () { - let dataControllerConfiguration = { + const dataControllerConfiguration = { 'dataController': { filterEIDwhenSDA: ['test.com:4:99999'] } @@ -131,14 +131,14 @@ describe('data controller', function () { }); // Test for global it('filterEIDwhenSDA for available global SAD test.com:4:777777 ', function () { - let dataControllerConfiguration = { + const dataControllerConfiguration = { 'dataController': { filterEIDwhenSDA: ['test.com:5:11111'] } }; config.setConfig(dataControllerConfiguration); - let globalObject = { + const globalObject = { 'ortb2Fragments': { 'global': { 'user': { @@ -165,14 +165,14 @@ describe('data controller', function () { } } }; - let globalRequest = Object.assign({}, req, globalObject); + const globalRequest = Object.assign({}, req, globalObject); filterBidData(callbackFn, globalRequest); expect(globalRequest.adUnits[0].bids[0].userIdAsEids).that.is.empty; expect(globalRequest.adUnits[0].bids[0].userId).that.is.empty; }); it('filterSDAwhenEID for id5-sync.com EID ', function () { - let dataControllerConfiguration = { + const dataControllerConfiguration = { 'dataController': { filterSDAwhenEID: ['id5-sync.com'] } @@ -183,7 +183,7 @@ describe('data controller', function () { }); it('filterSDAwhenEID for All EID ', function () { - let dataControllerConfiguration = { + const dataControllerConfiguration = { 'dataController': { filterSDAwhenEID: ['*'] } @@ -196,7 +196,7 @@ describe('data controller', function () { }); it('filterSDAwhenEID for unavailable source test-sync.com EID ', function () { - let dataControllerConfiguration = { + const dataControllerConfiguration = { 'dataController': { filterSDAwhenEID: ['test-sync.com'] } diff --git a/test/spec/modules/datablocksBidAdapter_spec.js b/test/spec/modules/datablocksBidAdapter_spec.js index fc04e1173f0..98c11657cf0 100644 --- a/test/spec/modules/datablocksBidAdapter_spec.js +++ b/test/spec/modules/datablocksBidAdapter_spec.js @@ -1,6 +1,6 @@ import { expect } from 'chai'; -import { spec } from '../../../modules/datablocksBidAdapter.js'; -import { BotClientTests } from '../../../modules/datablocksBidAdapter.js'; +import { spec, BotClientTests } from '../../../modules/datablocksBidAdapter.js'; + import { getStorageManager } from '../../../src/storageManager.js'; import {deepClone} from '../../../src/utils.js'; @@ -177,7 +177,7 @@ const res_object = { } } -let bid_request = { +const bid_request = { method: 'POST', url: 'https://prebid.datablocks.net/openrtb/?sid=2523014', options: { @@ -394,13 +394,13 @@ describe('DatablocksAdapter', function() { describe('get client info', function() { it('Should return object', function() { - let client_info = spec.get_client_info() + const client_info = spec.get_client_info() expect(client_info).to.be.a('object'); expect(client_info).to.have.all.keys('wiw', 'wih', 'saw', 'sah', 'scd', 'sw', 'sh', 'whl', 'wxo', 'wyo', 'wpr', 'is_bot', 'is_hid', 'vs'); }); it('bot test should return boolean', function() { - let bot_test = new BotClientTests(); + const bot_test = new BotClientTests(); expect(bot_test.doTests()).to.be.a('boolean'); }); }) @@ -410,13 +410,13 @@ describe('DatablocksAdapter', function() { expect(spec.isBidRequestValid(bid)).to.be.true; }); it('Should return false when host/source_id is not set', function() { - let moddedBid = deepClone(bid); + const moddedBid = deepClone(bid); delete moddedBid.params.source_id; expect(spec.isBidRequestValid(moddedBid)).to.be.false; }); it('Should return true when viewability reporting is opted out', function() { - let moddedBid = Object.assign({}, bid); + const moddedBid = Object.assign({}, bid); moddedBid.params.vis_optout = true; spec.isBidRequestValid(moddedBid); expect(spec.db_obj.vis_optout).to.be.true; @@ -437,7 +437,7 @@ describe('DatablocksAdapter', function() { describe('onBidWon', function() { it('Should return undefined', function() { - let won_bid = {params: [{source_id: 1}], requestId: 1, adUnitCode: 'unit', auctionId: 1, size: '300x250', cpm: 10, adserverTargeting: {hb_pb: 10}, timeToRespond: 10, ttl: 10}; + const won_bid = {params: [{source_id: 1}], requestId: 1, adUnitCode: 'unit', auctionId: 1, size: '300x250', cpm: 10, adserverTargeting: {hb_pb: 10}, timeToRespond: 10, ttl: 10}; expect(spec.onBidWon(won_bid)).to.equal(undefined); }); }); @@ -464,7 +464,7 @@ describe('DatablocksAdapter', function() { }); it('Should be a valid openRTB request', function() { - let data = request.data; + const data = request.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys('device', 'imp', 'site', 'id'); @@ -472,9 +472,9 @@ describe('DatablocksAdapter', function() { expect(data.imp).to.be.a('array'); expect(data.device.ip).to.equal('peer'); - let imps = data['imp']; + const imps = data['imp']; imps.forEach((imp, index) => { - let curBid = bidderRequest.bids[index]; + const curBid = bidderRequest.bids[index]; if (imp.banner) { expect(imp.banner).to.be.a('object'); expect(imp).to.have.all.keys('banner', 'id', 'secure', 'tagid', 'placement_id', 'ortb2', 'floor'); @@ -495,13 +495,13 @@ describe('DatablocksAdapter', function() { }); it('Returns empty data if no valid requests are passed', function() { - let test_request = spec.buildRequests([]); + const test_request = spec.buildRequests([]); expect(test_request).to.be.an('array').that.is.empty; }); }); describe('interpretResponse', function() { - let response = spec.interpretResponse(res_object, bid_request); + const response = spec.interpretResponse(res_object, bid_request); it('Returns an array of valid server responses if response object is valid', function() { expect(response).to.be.an('array').that.is.not.empty; diff --git a/test/spec/modules/datawrkzBidAdapter_spec.js b/test/spec/modules/datawrkzBidAdapter_spec.js index e78d2f68d91..ad513c20b8b 100644 --- a/test/spec/modules/datawrkzBidAdapter_spec.js +++ b/test/spec/modules/datawrkzBidAdapter_spec.js @@ -18,7 +18,7 @@ describe('datawrkzAdapterTests', function () { }); describe('isBidRequestValid', function () { - let bid = { + const bid = { 'bidder': BIDDER_CODE, 'params': { 'site_id': SITE_ID, @@ -36,19 +36,19 @@ describe('datawrkzAdapterTests', function () { }); it('should return false when params not found', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; expect(spec.isBidRequestValid(invalidBid)).to.equal(false); }); it('should return false when required site_id param not found', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); invalidBid.params = {'bidfloor': '1.0'} expect(spec.isBidRequestValid(invalidBid)).to.equal(false); }); it('should return false when adunit is adpod video', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); invalidBid.params = {'bidfloor': '1.0', 'site_id': SITE_ID}; invalidBid.mediaTypes = { 'video': { diff --git a/test/spec/modules/dchain_spec.js b/test/spec/modules/dchain_spec.js index 45061c539c1..b2f67bfc928 100644 --- a/test/spec/modules/dchain_spec.js +++ b/test/spec/modules/dchain_spec.js @@ -31,7 +31,7 @@ describe('dchain module', function () { }); it('Returns false if complete param is not 0 or 1', function () { - let dchainConfig = bid.meta.dchain; + const dchainConfig = bid.meta.dchain; dchainConfig.complete = 0; // integer expect(checkDchainSyntax(bid, STRICT)).to.true; dchainConfig.complete = 1; // integer @@ -51,7 +51,7 @@ describe('dchain module', function () { }); it('Returns false if ver param is not a String', function () { - let dchainConfig = bid.meta.dchain; + const dchainConfig = bid.meta.dchain; dchainConfig.ver = 1; // integer expect(checkDchainSyntax(bid, STRICT)).to.false; dchainConfig.ver = '1'; // string @@ -69,7 +69,7 @@ describe('dchain module', function () { }); it('Returns false if ext param is not an Object', function () { - let dchainConfig = bid.meta.dchain; + const dchainConfig = bid.meta.dchain; dchainConfig.ext = 1; // integer expect(checkDchainSyntax(bid, STRICT)).to.false; dchainConfig.ext = '1'; // string @@ -87,7 +87,7 @@ describe('dchain module', function () { }); it('Returns false if nodes param is not an Array', function () { - let dchainConfig = bid.meta.dchain; + const dchainConfig = bid.meta.dchain; expect(checkDchainSyntax(bid, STRICT)).to.true; dchainConfig.nodes = 1; // integer expect(checkDchainSyntax(bid, STRICT)).to.false; @@ -104,13 +104,13 @@ describe('dchain module', function () { }); it('Returns false if unknown field is used in main dchain', function () { - let dchainConfig = bid.meta.dchain; + const dchainConfig = bid.meta.dchain; dchainConfig.test = '1'; // String expect(checkDchainSyntax(bid, STRICT)).to.false; }); it('Returns false if nodes[].asi is not a String', function () { - let dchainConfig = bid.meta.dchain; + const dchainConfig = bid.meta.dchain; expect(checkDchainSyntax(bid, STRICT)).to.true; dchainConfig.nodes[0].asi = 1; // Integer expect(checkDchainSyntax(bid, STRICT)).to.false; @@ -127,7 +127,7 @@ describe('dchain module', function () { }); it('Returns false if nodes[].bsid is not a String', function () { - let dchainConfig = bid.meta.dchain; + const dchainConfig = bid.meta.dchain; expect(checkDchainSyntax(bid, STRICT)).to.true; dchainConfig.nodes[0].bsid = 1; // Integer expect(checkDchainSyntax(bid, STRICT)).to.false; @@ -144,7 +144,7 @@ describe('dchain module', function () { }); it('Returns false if nodes[].rid is not a String', function () { - let dchainConfig = bid.meta.dchain; + const dchainConfig = bid.meta.dchain; expect(checkDchainSyntax(bid, STRICT)).to.true; dchainConfig.nodes[0].rid = 1; // Integer expect(checkDchainSyntax(bid, STRICT)).to.false; @@ -161,7 +161,7 @@ describe('dchain module', function () { }); it('Returns false if nodes[].name is not a String', function () { - let dchainConfig = bid.meta.dchain; + const dchainConfig = bid.meta.dchain; expect(checkDchainSyntax(bid, STRICT)).to.true; dchainConfig.nodes[0].name = 1; // Integer expect(checkDchainSyntax(bid, STRICT)).to.false; @@ -178,7 +178,7 @@ describe('dchain module', function () { }); it('Returns false if nodes[].domain is not a String', function () { - let dchainConfig = bid.meta.dchain; + const dchainConfig = bid.meta.dchain; expect(checkDchainSyntax(bid, STRICT)).to.true; dchainConfig.nodes[0].domain = 1; // Integer expect(checkDchainSyntax(bid, STRICT)).to.false; @@ -195,7 +195,7 @@ describe('dchain module', function () { }); it('Returns false if nodes[].ext is not an Object', function () { - let dchainConfig = bid.meta.dchain; + const dchainConfig = bid.meta.dchain; dchainConfig.nodes[0].ext = '1'; // String expect(checkDchainSyntax(bid, STRICT)).to.false; dchainConfig.nodes[0].ext = 1; // Integer @@ -213,7 +213,7 @@ describe('dchain module', function () { }); it('Returns false if unknown field is used in nodes[]', function () { - let dchainConfig = bid.meta.dchain; + const dchainConfig = bid.meta.dchain; dchainConfig.nodes[0].test = '1'; // String expect(checkDchainSyntax(bid, STRICT)).to.false; }); @@ -234,7 +234,7 @@ describe('dchain module', function () { describe('addBidResponseHook', function () { let bid; - let adUnitCode = 'adUnit1'; + const adUnitCode = 'adUnit1'; beforeEach(function () { bid = { diff --git a/test/spec/modules/debugging_mod_spec.js b/test/spec/modules/debugging_mod_spec.js index d09f9cfca39..824043179bd 100644 --- a/test/spec/modules/debugging_mod_spec.js +++ b/test/spec/modules/debugging_mod_spec.js @@ -86,7 +86,7 @@ describe('bid interceptor', () => { }); it('should pass extra arguments to property function matchers', () => { - let matchDef = { + const matchDef = { key: sinon.stub(), outer: {inner: {key: sinon.stub()}} }; @@ -99,7 +99,7 @@ describe('bid interceptor', () => { }); it('should pass extra arguments to single-function matcher', () => { - let matchDef = sinon.stub(); + const matchDef = sinon.stub(); setRules({when: matchDef}); const args = [{}, {}, {}]; interceptor.match(...args); @@ -646,7 +646,7 @@ describe('bid overrides', function () { let bids; beforeEach(function () { - let baseBid = { + const baseBid = { 'bidderCode': 'rubicon', 'width': 970, 'height': 250, @@ -670,7 +670,7 @@ describe('bid overrides', function () { function run(overrides) { mockBids.forEach(bid => { - let next = (adUnitCode, bid) => { + const next = (adUnitCode, bid) => { bids.push(bid); }; addBidResponseHook.bind({overrides, logger})(next, bid.adUnitCode, bid); @@ -754,7 +754,7 @@ describe('bid overrides', function () { let bidderRequests; beforeEach(function () { - let baseBidderRequest = { + const baseBidderRequest = { 'bidderCode': 'rubicon', 'bids': [{ 'width': 970, @@ -779,7 +779,7 @@ describe('bid overrides', function () { }); function run(overrides) { - let next = (b) => { + const next = (b) => { bidderRequests = b; }; addBidderRequestsHook.bind({overrides, logger})(next, mockBidRequests); diff --git a/test/spec/modules/deepintentBidAdapter_spec.js b/test/spec/modules/deepintentBidAdapter_spec.js index b64c29d6800..4ec519bb636 100644 --- a/test/spec/modules/deepintentBidAdapter_spec.js +++ b/test/spec/modules/deepintentBidAdapter_spec.js @@ -130,7 +130,7 @@ describe('Deepintent adapter', function () { describe('validations', function () { it('validBid : tagId is passed', function () { - let bid = { + const bid = { bidder: 'deepintent', params: { tagId: '1232' @@ -140,7 +140,7 @@ describe('Deepintent adapter', function () { expect(isValid).to.equals(true); }); it('invalidBid : tagId is not passed', function () { - let bid = { + const bid = { bidder: 'deepintent', params: { h: 200, @@ -151,7 +151,7 @@ describe('Deepintent adapter', function () { expect(isValid).to.equals(false); }); it('invalidBid : tagId is not a string', function () { - let bid = { + const bid = { bidder: 'deepintent', params: { tagId: 12345 @@ -161,7 +161,7 @@ describe('Deepintent adapter', function () { expect(isValid).to.equals(false); }); it('should check for context if video is present', function() { - let bid = { + const bid = { bidder: 'deepintent', params: { tagId: '12345', @@ -181,7 +181,7 @@ describe('Deepintent adapter', function () { expect(isValid).to.equal(true); }); it('should error out if context is not present and is Video', function() { - let bid = { + const bid = { bidder: 'deepintent', params: { tagId: '12345', @@ -202,19 +202,19 @@ describe('Deepintent adapter', function () { }); describe('request check', function () { it('unmutaable bid request check', function () { - let oRequest = utils.deepClone(request), + const oRequest = utils.deepClone(request), bidRequest = spec.buildRequests(request); expect(request).to.deep.equal(oRequest); }); it('bidder connection check', function () { - let bRequest = spec.buildRequests(request); + const bRequest = spec.buildRequests(request); expect(bRequest.url).to.equal('https://prebid.deepintent.com/prebid'); expect(bRequest.method).to.equal('POST'); expect(bRequest.options.contentType).to.equal('application/json'); }); it('bid request check : Device', function () { - let bRequest = spec.buildRequests(request); - let data = JSON.parse(bRequest.data); + const bRequest = spec.buildRequests(request); + const data = JSON.parse(bRequest.data); expect(data.device.ua).to.be.a('string'); expect(data.device.js).to.equal(1); expect(data.device.dnt).to.be.a('number'); @@ -222,33 +222,33 @@ describe('Deepintent adapter', function () { expect(data.device.w).to.be.a('number'); }); it('bid request check : Impression', function () { - let bRequest = spec.buildRequests(request); - let data = JSON.parse(bRequest.data); + const bRequest = spec.buildRequests(request); + const data = JSON.parse(bRequest.data); expect(data.at).to.equal(1); // auction type expect(data.imp[0].id).to.equal(request[0].bidId); expect(data.imp[0].tagid).to.equal('100013'); }); it('bid request check : ad size', function () { - let bRequest = spec.buildRequests(request); - let data = JSON.parse(bRequest.data); + const bRequest = spec.buildRequests(request); + const data = JSON.parse(bRequest.data); expect(data.imp[0].banner).to.be.a('object'); expect(data.imp[0].banner.w).to.equal(300); expect(data.imp[0].banner.h).to.equal(250); }); it('bid request check : custom params', function () { - let bRequest = spec.buildRequests(request); - let data = JSON.parse(bRequest.data); + const bRequest = spec.buildRequests(request); + const data = JSON.parse(bRequest.data); expect(data.imp[0].ext).to.be.a('object'); expect(data.imp[0].ext.deepintent.position).to.equal('right-box'); }); it('bid request check: position check', function () { - let bRequest = spec.buildRequests(request); - let data = JSON.parse(bRequest.data); + const bRequest = spec.buildRequests(request); + const data = JSON.parse(bRequest.data); expect(data.imp[0].banner.pos).to.equal(1); }); it('bid request check: displaymanager check', function() { - let bRequest = spec.buildRequests(request); - let data = JSON.parse(bRequest.data); + const bRequest = spec.buildRequests(request); + const data = JSON.parse(bRequest.data); expect(data.imp[0].displaymanager).to.equal('di_prebid'); expect(data.imp[0].displaymanagerver).to.equal('1.0.0'); }); @@ -269,8 +269,8 @@ describe('Deepintent adapter', function () { expect(data.imp[0].bidfloor).to.equal(1.2); }); it('bid request check: user object check', function () { - let bRequest = spec.buildRequests(request); - let data = JSON.parse(bRequest.data); + const bRequest = spec.buildRequests(request); + const data = JSON.parse(bRequest.data); expect(data.user).to.be.a('object'); expect(data.user.id).to.equal('di_testuid'); expect(data.user.buyeruid).to.equal('di_testbuyeruid'); @@ -278,37 +278,37 @@ describe('Deepintent adapter', function () { expect(data.user.gender).to.equal('F'); }); it('bid request check: CCPA Check', function () { - let bidRequest = { + const bidRequest = { uspConsent: '1NYN' }; - let bRequest = spec.buildRequests(request, bidRequest); - let data = JSON.parse(bRequest.data); + const bRequest = spec.buildRequests(request, bidRequest); + const data = JSON.parse(bRequest.data); expect(data.regs.ext.us_privacy).to.equal('1NYN'); - let bidRequest2 = {}; - let bRequest2 = spec.buildRequests(request, bidRequest2); - let data2 = JSON.parse(bRequest2.data); + const bidRequest2 = {}; + const bRequest2 = spec.buildRequests(request, bidRequest2); + const data2 = JSON.parse(bRequest2.data); expect(data2.regs).to.equal(undefined); }); it('bid Request check: GDPR Check', function () { - let bidRequest = { + const bidRequest = { gdprConsent: { consentString: 'kjfdnidasd123sadsd', gdprApplies: true } }; - let bRequest = spec.buildRequests(request, bidRequest); - let data = JSON.parse(bRequest.data); + const bRequest = spec.buildRequests(request, bidRequest); + const data = JSON.parse(bRequest.data); expect(data.user.ext.consent).to.equal('kjfdnidasd123sadsd'); expect(data.regs.ext.gdpr).to.equal(1); - let bidRequest2 = {}; - let bRequest2 = spec.buildRequests(request, bidRequest2); - let data2 = JSON.parse(bRequest2.data); + const bidRequest2 = {}; + const bRequest2 = spec.buildRequests(request, bidRequest2); + const data2 = JSON.parse(bRequest2.data); expect(data2.regs).to.equal(undefined); expect(data2.user.ext).to.equal(undefined); }); it('bid request check: Video params check ', function() { - let bRequest = spec.buildRequests(videoBidRequests); - let data = JSON.parse(bRequest.data); + const bRequest = spec.buildRequests(videoBidRequests); + const data = JSON.parse(bRequest.data); expect(data.imp[0].video).to.be.a('object'); expect(data.imp[0].video.minduration).to.be.a('number'); expect(data.imp[0].video.maxduration).to.be.a('number'); @@ -322,8 +322,8 @@ describe('Deepintent adapter', function () { expect(data.imp[0].video.w).to.be.a('number'); }); it('bid request param check : invalid video params', function() { - let bRequest = spec.buildRequests(videoBidRequests); - let data = JSON.parse(bRequest.data); + const bRequest = spec.buildRequests(videoBidRequests); + const data = JSON.parse(bRequest.data); expect(data.imp[0].video).to.be.a('object'); expect(data.imp[0].video.testwrongparam).to.equal(undefined); expect(data.imp[0].video.testwrongparam1).to.equal(undefined); @@ -331,10 +331,10 @@ describe('Deepintent adapter', function () { }); describe('user sync check', function () { it('user sync url check', function () { - let syncOptions = { + const syncOptions = { iframeEnabled: true }; - let userSync = spec.getUserSyncs(syncOptions); + const userSync = spec.getUserSyncs(syncOptions); expect(userSync).to.be.an('array').with.length.above(0); expect(userSync[0].type).to.equal('iframe'); expect(userSync[0].url).to.equal('https://cdn.deepintent.com/syncpixel.html'); @@ -342,9 +342,9 @@ describe('Deepintent adapter', function () { }); describe('response check', function () { it('bid response check: valid bid response', function () { - let bRequest = spec.buildRequests(request); - let data = JSON.parse(bRequest.data); - let bResponse = spec.interpretResponse(bannerResponse, request); + const bRequest = spec.buildRequests(request); + const data = JSON.parse(bRequest.data); + const bResponse = spec.interpretResponse(bannerResponse, request); expect(bResponse).to.be.an('array').with.length.above(0); expect(bResponse[0].requestId).to.equal(bannerResponse.body.seatbid[0].bid[0].impid); expect(bResponse[0].width).to.equal(bannerResponse.body.seatbid[0].bid[0].w); @@ -358,32 +358,32 @@ describe('Deepintent adapter', function () { expect(bResponse[0].dealId).to.equal(bannerResponse.body.seatbid[0].bid[0].dealId); }); it('bid response check: valid video bid response', function() { - let request = spec.buildRequests(videoBidRequests); - let response = spec.interpretResponse(videoBidResponse, request); + const request = spec.buildRequests(videoBidRequests); + const response = spec.interpretResponse(videoBidResponse, request); expect(response[0].mediaType).to.equal('video'); expect(response[0].vastXml).to.not.equal(undefined); }); it('invalid bid response check ', function() { - let bRequest = spec.buildRequests(request); - let response = spec.interpretResponse(invalidResponse, bRequest); + const bRequest = spec.buildRequests(request); + const response = spec.interpretResponse(invalidResponse, bRequest); expect(response[0].mediaType).to.equal(undefined); }); it('invalid bid response check ', function() { - let bRequest = spec.buildRequests(videoBidRequests); - let response = spec.interpretResponse(invalidResponse, bRequest); + const bRequest = spec.buildRequests(videoBidRequests); + const response = spec.interpretResponse(invalidResponse, bRequest); expect(response[0].mediaType).to.equal(undefined); }); }); describe('GPP and coppa', function() { it('Request params check with GPP Consent', function () { - let bidderReq = {gppConsent: {gppString: 'gpp-string-test', applicableSections: [5]}}; - let bRequest = spec.buildRequests(request, bidderReq); - let data = JSON.parse(bRequest.data); + const bidderReq = {gppConsent: {gppString: 'gpp-string-test', applicableSections: [5]}}; + const bRequest = spec.buildRequests(request, bidderReq); + const data = JSON.parse(bRequest.data); expect(data.regs.gpp).to.equal('gpp-string-test'); expect(data.regs.gpp_sid[0]).to.equal(5); }); it('Request params check with GPP Consent read from ortb2', function () { - let bidderReq = { + const bidderReq = { ortb2: { regs: { gpp: 'gpp-test-string', @@ -391,15 +391,15 @@ describe('Deepintent adapter', function () { } } }; - let bRequest = spec.buildRequests(request, bidderReq); - let data = JSON.parse(bRequest.data); + const bRequest = spec.buildRequests(request, bidderReq); + const data = JSON.parse(bRequest.data); expect(data.regs.gpp).to.equal('gpp-test-string'); expect(data.regs.gpp_sid[0]).to.equal(5); }); it('should include coppa flag in bid request if coppa is set to true', () => { - let bidderReq = {ortb2: {regs: {coppa: 1}}}; - let bRequest = spec.buildRequests(request, bidderReq); - let data = JSON.parse(bRequest.data); + const bidderReq = {ortb2: {regs: {coppa: 1}}}; + const bRequest = spec.buildRequests(request, bidderReq); + const data = JSON.parse(bRequest.data); expect(data.regs.coppa).to.equal(1); }); }); diff --git a/test/spec/modules/deepintentDpesIdsystem_spec.js b/test/spec/modules/deepintentDpesIdsystem_spec.js index 252cb2f414c..8f8c100afc8 100644 --- a/test/spec/modules/deepintentDpesIdsystem_spec.js +++ b/test/spec/modules/deepintentDpesIdsystem_spec.js @@ -27,17 +27,17 @@ const html5Config = { describe('Deepintent DPES System', () => { describe('Deepintent Dpes Sytsem: test "getId" method', () => { it('If nothing is found in cache, return undefined', () => { - let diId = deepintentDpesSubmodule.getId({}, undefined, undefined); + const diId = deepintentDpesSubmodule.getId({}, undefined, undefined); expect(diId).to.be.eq(undefined); }); it('Get value stored in cookie for getId', () => { - let diId = deepintentDpesSubmodule.getId(cookieConfig, undefined, DI_COOKIE_OBJECT); + const diId = deepintentDpesSubmodule.getId(cookieConfig, undefined, DI_COOKIE_OBJECT); expect(diId).to.deep.equal(DI_COOKIE_OBJECT); }); it('provides the stored deepintentId if cookie is absent but present in local storage', () => { - let idx = deepintentDpesSubmodule.getId(html5Config, undefined, DI_UPDATED_STORAGE); + const idx = deepintentDpesSubmodule.getId(html5Config, undefined, DI_UPDATED_STORAGE); expect(idx).to.be.eq(DI_UPDATED_STORAGE); }); }); diff --git a/test/spec/modules/deltaprojectsBidAdapter_spec.js b/test/spec/modules/deltaprojectsBidAdapter_spec.js index 619b65fb685..30f709f0a06 100644 --- a/test/spec/modules/deltaprojectsBidAdapter_spec.js +++ b/test/spec/modules/deltaprojectsBidAdapter_spec.js @@ -36,7 +36,7 @@ describe('deltaprojectsBidAdapter', function() { }); it('should return false when publisher id is not set', function () { - let bid = makeBid(); + const bid = makeBid(); delete bid.params.publisherId; expect(spec.isBidRequestValid(bid)).to.equal(false); }); @@ -215,58 +215,58 @@ describe('deltaprojectsBidAdapter', function() { }; it('should get incorrect bid response if response body is missing', function () { - let response = makeResponse(); + const response = makeResponse(); delete response.body; - let result = spec.interpretResponse(response, request); + const result = spec.interpretResponse(response, request); expect(result.length).to.equal(0); }); it('should get incorrect bid response if id or seat id of response body is missing', function () { - let response1 = makeResponse(); + const response1 = makeResponse(); delete response1.body.id; - let result1 = spec.interpretResponse(response1, request); + const result1 = spec.interpretResponse(response1, request); expect(result1.length).to.equal(0); - let response2 = makeResponse(); + const response2 = makeResponse(); delete response2.body.seatbid; - let result2 = spec.interpretResponse(response2, request); + const result2 = spec.interpretResponse(response2, request); expect(result2.length).to.equal(0); }); it('should get the correct bid response', function () { - let result = spec.interpretResponse(makeResponse(), request); + const result = spec.interpretResponse(makeResponse(), request); expect(result.length).to.equal(1); expect(result[0]).to.deep.equal(expectedBid); }); it('should handle a missing crid', function () { - let noCridResponse = makeResponse(); + const noCridResponse = makeResponse(); delete noCridResponse.body.seatbid[0].bid[0].crid; const fallbackCrid = noCridResponse.body.seatbid[0].bid[0].id; - let noCridResult = Object.assign({}, expectedBid, {'creativeId': fallbackCrid}); - let result = spec.interpretResponse(noCridResponse, request); + const noCridResult = Object.assign({}, expectedBid, {'creativeId': fallbackCrid}); + const result = spec.interpretResponse(noCridResponse, request); expect(result.length).to.equal(1); expect(result[0]).to.deep.equal(noCridResult); }); it('should handle a missing nurl', function () { - let noNurlResponse = makeResponse(); + const noNurlResponse = makeResponse(); delete noNurlResponse.body.seatbid[0].bid[0].nurl; - let noNurlResult = Object.assign({}, expectedBid); + const noNurlResult = Object.assign({}, expectedBid); noNurlResult.ad = ''; - let result = spec.interpretResponse(noNurlResponse, request); + const result = spec.interpretResponse(noNurlResponse, request); expect(result.length).to.equal(1); expect(result[0]).to.deep.equal(noNurlResult); }); it('handles empty bid response', function () { - let response = { + const response = { body: { id: '5e5c23a5ba71e78', seatbid: [] } }; - let result = spec.interpretResponse(response, request); + const result = spec.interpretResponse(response, request); expect(result.length).to.equal(0); }); diff --git a/test/spec/modules/dexertoBidAdapter_spec.js b/test/spec/modules/dexertoBidAdapter_spec.js index 419fcbc9dbe..d99b224654f 100644 --- a/test/spec/modules/dexertoBidAdapter_spec.js +++ b/test/spec/modules/dexertoBidAdapter_spec.js @@ -78,7 +78,7 @@ describe('dexerto adapter', function () { describe('validations', function () { it('isBidValid : placement_id is passed', function () { - let bid = { + const bid = { bidder: 'dexerto', params: { placement_id: 110003 @@ -88,7 +88,7 @@ describe('dexerto adapter', function () { expect(isValid).to.equals(true); }); it('isBidValid : placement_id is not passed', function () { - let bid = { + const bid = { bidder: 'dexerto', params: { width: 300, @@ -103,42 +103,42 @@ describe('dexerto adapter', function () { }); describe('Validate Request', function () { it('Immutable bid request validate', function () { - let _Request = utils.deepClone(request), + const _Request = utils.deepClone(request), bidRequest = spec.buildRequests(request); expect(request).to.deep.equal(_Request); }); it('Validate bidder connection', function () { - let _Request = spec.buildRequests(request); + const _Request = spec.buildRequests(request); expect(_Request.url).to.equal('https://rtb.dexerto.media/hb/dexerto'); expect(_Request.method).to.equal('POST'); expect(_Request.options.contentType).to.equal('application/json'); }); it('Validate bid request : Impression', function () { - let _Request = spec.buildRequests(request); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(request); + const data = JSON.parse(_Request.data); // expect(data.at).to.equal(1); // auction type expect(data[0].imp[0].id).to.equal(request[0].bidId); expect(data[0].placementId).to.equal(110003); }); it('Validate bid request : ad size', function () { - let _Request = spec.buildRequests(request); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(request); + const data = JSON.parse(_Request.data); expect(data[0].imp[0].banner).to.be.a('object'); expect(data[0].imp[0].banner.w).to.equal(300); expect(data[0].imp[0].banner.h).to.equal(250); }); it('Validate bid request : user object', function () { - let _Request = spec.buildRequests(request); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(request); + const data = JSON.parse(_Request.data); expect(data[0].user).to.be.a('object'); expect(data[0].user.id).to.be.a('string'); }); it('Validate bid request : CCPA Check', function () { - let bidRequest = { + const bidRequest = { uspConsent: '1NYN' }; - let _Request = spec.buildRequests(request, bidRequest); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(request, bidRequest); + const data = JSON.parse(_Request.data); expect(data[0].regs.ext.us_privacy).to.equal('1NYN'); // let _bidRequest = {}; // let _Request1 = spec.buildRequests(request, _bidRequest); @@ -148,7 +148,7 @@ describe('dexerto adapter', function () { }); describe('Validate response ', function () { it('Validate bid response : valid bid response', function () { - let bResponse = spec.interpretResponse(bannerResponse, request); + const bResponse = spec.interpretResponse(bannerResponse, request); expect(bResponse).to.be.an('array').with.length.above(0); expect(bResponse[0].requestId).to.equal(bannerResponse.body.seatbid[0].bid[0].impid); expect(bResponse[0].width).to.equal(bannerResponse.body.seatbid[0].bid[0].w); @@ -162,21 +162,21 @@ describe('dexerto adapter', function () { expect(bResponse[0].dealId).to.equal(bannerResponse.body.seatbid[0].bid[0].dealId); }); it('Invalid bid response check ', function () { - let bRequest = spec.buildRequests(request); - let response = spec.interpretResponse(invalidResponse, bRequest); + const bRequest = spec.buildRequests(request); + const response = spec.interpretResponse(invalidResponse, bRequest); expect(response[0].ad).to.equal('invalid response'); }); }); describe('GPP and coppa', function () { it('Request params check with GPP Consent', function () { - let bidderReq = { gppConsent: { gppString: 'gpp-string-test', applicableSections: [5] } }; - let _Request = spec.buildRequests(request, bidderReq); - let data = JSON.parse(_Request.data); + const bidderReq = { gppConsent: { gppString: 'gpp-string-test', applicableSections: [5] } }; + const _Request = spec.buildRequests(request, bidderReq); + const data = JSON.parse(_Request.data); expect(data[0].regs.gpp).to.equal('gpp-string-test'); expect(data[0].regs.gpp_sid[0]).to.equal(5); }); it('Request params check with GPP Consent read from ortb2', function () { - let bidderReq = { + const bidderReq = { ortb2: { regs: { gpp: 'gpp-test-string', @@ -184,15 +184,15 @@ describe('dexerto adapter', function () { } } }; - let _Request = spec.buildRequests(request, bidderReq); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(request, bidderReq); + const data = JSON.parse(_Request.data); expect(data[0].regs.gpp).to.equal('gpp-test-string'); expect(data[0].regs.gpp_sid[0]).to.equal(5); }); it(' Bid request should have coppa flag if its true', () => { - let bidderReq = { ortb2: { regs: { coppa: 1 } } }; - let _Request = spec.buildRequests(request, bidderReq); - let data = JSON.parse(_Request.data); + const bidderReq = { ortb2: { regs: { coppa: 1 } } }; + const _Request = spec.buildRequests(request, bidderReq); + const data = JSON.parse(_Request.data); expect(data[0].regs.coppa).to.equal(1); }); }); diff --git a/test/spec/modules/dgkeywordRtdProvider_spec.js b/test/spec/modules/dgkeywordRtdProvider_spec.js index d6460b17b32..225b3de908b 100644 --- a/test/spec/modules/dgkeywordRtdProvider_spec.js +++ b/test/spec/modules/dgkeywordRtdProvider_spec.js @@ -248,9 +248,9 @@ describe('Digital Garage Keyword Module', function () { }, ]; it('should get profiles error(404).', function (done) { - let pbjs = cloneDeep(config); + const pbjs = cloneDeep(config); pbjs.adUnits = cloneDeep(AD_UNITS); - let moduleConfig = cloneDeep(DEF_CONFIG); + const moduleConfig = cloneDeep(DEF_CONFIG); dgRtd.getDgKeywordsAndSet( pbjs, () => { @@ -281,9 +281,9 @@ describe('Digital Garage Keyword Module', function () { }); it('should get profiles timeout.', function (done) { const clock = sinon.useFakeTimers(); - let pbjs = cloneDeep(config); + const pbjs = cloneDeep(config); pbjs.adUnits = cloneDeep(AD_UNITS); - let moduleConfig = cloneDeep(DEF_CONFIG); + const moduleConfig = cloneDeep(DEF_CONFIG); moduleConfig.params.timeout = 10; dgRtd.getDgKeywordsAndSet( pbjs, @@ -324,12 +324,12 @@ describe('Digital Garage Keyword Module', function () { clock.restore(); }); it('should get profiles ok(200).', function (done) { - let pbjs = cloneDeep(config); + const pbjs = cloneDeep(config); pbjs.adUnits = cloneDeep(AD_UNITS); if (IGNORE_SET_ORTB2) { pbjs._ignoreSetOrtb2 = true; } - let moduleConfig = cloneDeep(DEF_CONFIG); + const moduleConfig = cloneDeep(DEF_CONFIG); dgRtd.getDgKeywordsAndSet( pbjs, () => { @@ -368,12 +368,12 @@ describe('Digital Garage Keyword Module', function () { }); it('change url.', function (done) { const dummyUrl = 'https://www.test.com/test' - let pbjs = cloneDeep(config); + const pbjs = cloneDeep(config); pbjs.adUnits = cloneDeep(AD_UNITS); if (IGNORE_SET_ORTB2) { pbjs._ignoreSetOrtb2 = true; } - let moduleConfig = cloneDeep(DEF_CONFIG); + const moduleConfig = cloneDeep(DEF_CONFIG); moduleConfig.params.url = dummyUrl; dgRtd.getDgKeywordsAndSet( pbjs, @@ -395,12 +395,12 @@ describe('Digital Garage Keyword Module', function () { }); it('add fpid stored in local strage.', function (done) { const uuid = 'uuid_abcdefghijklmnopqrstuvwxyz'; - let pbjs = cloneDeep(config); + const pbjs = cloneDeep(config); pbjs.adUnits = cloneDeep(AD_UNITS); if (IGNORE_SET_ORTB2) { pbjs._ignoreSetOrtb2 = true; } - let moduleConfig = cloneDeep(DEF_CONFIG); + const moduleConfig = cloneDeep(DEF_CONFIG); window.localStorage.setItem('ope_fpid', uuid); moduleConfig.params.enableReadFpid = true; dgRtd.getDgKeywordsAndSet( @@ -423,12 +423,12 @@ describe('Digital Garage Keyword Module', function () { }); it('disable fpid stored in local strage.', function (done) { const uuid = 'uuid_abcdefghijklmnopqrstuvwxyz'; - let pbjs = cloneDeep(config); + const pbjs = cloneDeep(config); pbjs.adUnits = cloneDeep(AD_UNITS); if (IGNORE_SET_ORTB2) { pbjs._ignoreSetOrtb2 = true; } - let moduleConfig = cloneDeep(DEF_CONFIG); + const moduleConfig = cloneDeep(DEF_CONFIG); window.localStorage.setItem('ope_fpid', uuid); dgRtd.getDgKeywordsAndSet( pbjs, diff --git a/test/spec/modules/dianomiBidAdapter_spec.js b/test/spec/modules/dianomiBidAdapter_spec.js index a0cb1be68de..f693febd4c3 100644 --- a/test/spec/modules/dianomiBidAdapter_spec.js +++ b/test/spec/modules/dianomiBidAdapter_spec.js @@ -10,7 +10,7 @@ describe('Dianomi adapter', () => { let bids = []; describe('isBidRequestValid', () => { - let bid = { + const bid = { bidder: 'dianomi', params: { smartadId: 1234, @@ -41,13 +41,13 @@ describe('Dianomi adapter', () => { config.resetConfig(); }); it('should send request with correct structure', () => { - let validBidRequests = [ + const validBidRequests = [ { bidId: 'bidId', params: { smartadId: 1234 }, }, ]; - let request = spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }); + const request = spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }); assert.equal(request.method, 'POST'); assert.equal(request.url, 'https://www-prebid.dianomi.com/cgi-bin/smartads_prebid.pl'); @@ -56,12 +56,12 @@ describe('Dianomi adapter', () => { describe('user privacy', () => { it('should send GDPR Consent data to Dianomi if gdprApplies', () => { - let validBidRequests = [{ bidId: 'bidId', params: { smartadId: 1234 } }]; - let bidderRequest = { + const validBidRequests = [{ bidId: 'bidId', params: { smartadId: 1234 } }]; + const bidderRequest = { gdprConsent: { gdprApplies: true, consentString: 'consentDataString' }, refererInfo: { page: 'page' }, }; - let request = JSON.parse(spec.buildRequests(validBidRequests, bidderRequest).data); + const request = JSON.parse(spec.buildRequests(validBidRequests, bidderRequest).data); assert.equal(request.user.ext.consent, bidderRequest.gdprConsent.consentString); assert.equal(request.regs.ext.gdpr, bidderRequest.gdprConsent.gdprApplies); @@ -69,19 +69,19 @@ describe('Dianomi adapter', () => { }); it('should send gdpr as number', () => { - let validBidRequests = [{ bidId: 'bidId', params: { smartadId: 1234 } }]; - let bidderRequest = { + const validBidRequests = [{ bidId: 'bidId', params: { smartadId: 1234 } }]; + const bidderRequest = { gdprConsent: { gdprApplies: true, consentString: 'consentDataString' }, refererInfo: { page: 'page' }, }; - let request = JSON.parse(spec.buildRequests(validBidRequests, bidderRequest).data); + const request = JSON.parse(spec.buildRequests(validBidRequests, bidderRequest).data); assert.equal(typeof request.regs.ext.gdpr, 'number'); assert.equal(request.regs.ext.gdpr, 1); }); it('should send CCPA Consent data to dianomi', () => { - let validBidRequests = [{ bidId: 'bidId', params: { smartadId: 1234 } }]; + const validBidRequests = [{ bidId: 'bidId', params: { smartadId: 1234 } }]; let bidderRequest = { uspConsent: '1YA-', refererInfo: { page: 'page' } }; let request = JSON.parse(spec.buildRequests(validBidRequests, bidderRequest).data); @@ -100,7 +100,7 @@ describe('Dianomi adapter', () => { }); it('should not send GDPR Consent data to dianomi if gdprApplies is undefined', () => { - let validBidRequests = [ + const validBidRequests = [ { bidId: 'bidId', params: { smartadId: 1234 }, @@ -125,13 +125,13 @@ describe('Dianomi adapter', () => { assert.equal(request.regs, undefined); }); it('should send default GDPR Consent data to dianomi', () => { - let validBidRequests = [ + const validBidRequests = [ { bidId: 'bidId', params: { smartadId: 1234 }, }, ]; - let request = JSON.parse( + const request = JSON.parse( spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data ); @@ -141,29 +141,29 @@ describe('Dianomi adapter', () => { }); it('should have default request structure', () => { - let keys = 'site,device,source,ext,imp'.split(','); - let validBidRequests = [ + const keys = 'site,device,source,ext,imp'.split(','); + const validBidRequests = [ { bidId: 'bidId', params: { smartadId: 1234 }, }, ]; - let request = JSON.parse( + const request = JSON.parse( spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data ); - let data = Object.keys(request); + const data = Object.keys(request); assert.deepEqual(keys, data); }); it('should set request keys correct values', () => { - let validBidRequests = [ + const validBidRequests = [ { bidId: 'bidId', params: { smartadId: 1234 }, }, ]; - let request = JSON.parse( + const request = JSON.parse( spec.buildRequests(validBidRequests, {refererInfo: {page: 'page'}, ortb2: {source: {tid: 'tid'}}}).data ); @@ -175,13 +175,13 @@ describe('Dianomi adapter', () => { config.setConfig({ device: { w: 100, h: 100 }, }); - let validBidRequests = [ + const validBidRequests = [ { bidId: 'bidId', params: { smartadId: 1234 }, }, ]; - let request = JSON.parse( + const request = JSON.parse( spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data ); @@ -195,14 +195,14 @@ describe('Dianomi adapter', () => { app: { id: 'appid' }, }); const ortb2 = { app: { name: 'appname' } }; - let validBidRequests = [ + const validBidRequests = [ { bidId: 'bidId', params: { smartadId: 1234 }, ortb2, }, ]; - let request = JSON.parse( + const request = JSON.parse( spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' }, ortb2 }).data ); @@ -227,15 +227,15 @@ describe('Dianomi adapter', () => { }, }, }; - let validBidRequests = [ + const validBidRequests = [ { bidId: 'bidId', params: { smartadId: 1234 }, ortb2, }, ]; - let refererInfo = { page: 'page' }; - let request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo, ortb2 }).data); + const refererInfo = { page: 'page' }; + const request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo, ortb2 }).data); assert.deepEqual(request.site, { page: refererInfo.page, @@ -248,7 +248,7 @@ describe('Dianomi adapter', () => { }); it('should pass extended ids', () => { - let validBidRequests = [ + const validBidRequests = [ { bidId: 'bidId', params: { smartadId: 1234 }, @@ -262,7 +262,7 @@ describe('Dianomi adapter', () => { }, ]; - let request = JSON.parse( + const request = JSON.parse( spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data ); assert.deepEqual(request.user.ext.eids, validBidRequests[0].userIdAsEids); @@ -270,17 +270,17 @@ describe('Dianomi adapter', () => { it('should send currency if defined', () => { setCurrencyConfig({ adServerCurrency: 'EUR' }) - let validBidRequests = [{ params: { smartadId: 1234 } }]; - let refererInfo = { page: 'page' }; + const validBidRequests = [{ params: { smartadId: 1234 } }]; + const refererInfo = { page: 'page' }; return addFPDToBidderRequest({ refererInfo }).then(res => { - let request = JSON.parse(spec.buildRequests(validBidRequests, res).data); + const request = JSON.parse(spec.buildRequests(validBidRequests, res).data); assert.deepEqual(request.cur, ['EUR']); setCurrencyConfig({}); }); }); it('should pass supply chain object', () => { - let validBidRequests = [ + const validBidRequests = [ { bidId: 'bidId', params: { smartadId: 1234 }, @@ -299,7 +299,7 @@ describe('Dianomi adapter', () => { }, ]; - let request = JSON.parse( + const request = JSON.parse( spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data ); assert.deepEqual(request.source.ext.schain, { @@ -312,26 +312,26 @@ describe('Dianomi adapter', () => { describe('priceType', () => { it('should send default priceType', () => { - let validBidRequests = [ + const validBidRequests = [ { bidId: 'bidId', params: { smartadId: 1234 }, }, ]; - let request = JSON.parse( + const request = JSON.parse( spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data ); assert.equal(request.ext.pt, 'net'); }); it('should send correct priceType value', () => { - let validBidRequests = [ + const validBidRequests = [ { bidId: 'bidId', params: { smartadId: 1234 }, }, ]; - let request = JSON.parse( + const request = JSON.parse( spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data ); @@ -341,7 +341,7 @@ describe('Dianomi adapter', () => { describe('bids', () => { it('should add more than one bid to the request', () => { - let validBidRequests = [ + const validBidRequests = [ { bidId: 'bidId', params: { smartadId: 1234 }, @@ -351,14 +351,14 @@ describe('Dianomi adapter', () => { params: { smartadId: 1234 }, }, ]; - let request = JSON.parse( + const request = JSON.parse( spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data ); assert.equal(request.imp.length, 2); }); it('should add incrementing values of id', () => { - let validBidRequests = [ + const validBidRequests = [ { bidId: 'bidId', params: { smartadId: 1234 }, @@ -375,7 +375,7 @@ describe('Dianomi adapter', () => { mediaTypes: { video: {} }, }, ]; - let imps = JSON.parse( + const imps = JSON.parse( spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data ).imp; @@ -389,7 +389,7 @@ describe('Dianomi adapter', () => { const validBidRequests = [ { bidId: 'bidId', params: { smartadId: 1234 }, mediaTypes: { video: {} } }, ]; - let imp = getRequestImps(validBidRequests)[0]; + const imp = getRequestImps(validBidRequests)[0]; assert.equal(imp.bidfloor, undefined); assert.equal(imp.bidfloorcur, undefined); @@ -397,7 +397,7 @@ describe('Dianomi adapter', () => { it('should not add if floor price not defined', () => { const validBidRequests = [getBidWithFloor()]; - let imp = getRequestImps(validBidRequests)[0]; + const imp = getRequestImps(validBidRequests)[0]; assert.equal(imp.bidfloor, undefined); assert.equal(imp.bidfloorcur, 'USD'); @@ -405,10 +405,10 @@ describe('Dianomi adapter', () => { it('should request floor price in adserver currency', () => { setCurrencyConfig({ adServerCurrency: 'GBP' }) - let validBidRequests = [getBidWithFloor()]; - let refererInfo = { page: 'page' }; + const validBidRequests = [getBidWithFloor()]; + const refererInfo = { page: 'page' }; return addFPDToBidderRequest({ refererInfo }).then(res => { - let imp = JSON.parse( + const imp = JSON.parse( spec.buildRequests(validBidRequests, res).data ).imp[0]; @@ -421,7 +421,7 @@ describe('Dianomi adapter', () => { it('should add correct floor values', () => { const expectedFloors = [1, 1.3, 0.5]; const validBidRequests = expectedFloors.map(getBidWithFloor); - let imps = getRequestImps(validBidRequests); + const imps = getRequestImps(validBidRequests); expectedFloors.forEach((floor, index) => { assert.equal(imps[index].bidfloor, floor); @@ -445,7 +445,7 @@ describe('Dianomi adapter', () => { describe('multiple media types', () => { it('should use all configured media types for bidding', () => { - let validBidRequests = [ + const validBidRequests = [ { bidId: 'bidId', params: { smartadId: 1234 }, @@ -485,7 +485,7 @@ describe('Dianomi adapter', () => { }, }, ]; - let [first, second, third] = JSON.parse( + const [first, second, third] = JSON.parse( spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data ).imp; @@ -505,7 +505,7 @@ describe('Dianomi adapter', () => { describe('banner', () => { it('should convert sizes to openrtb format', () => { - let validBidRequests = [ + const validBidRequests = [ { bidId: 'bidId', params: { smartadId: 1234 }, @@ -519,7 +519,7 @@ describe('Dianomi adapter', () => { }, }, ]; - let { banner } = JSON.parse( + const { banner } = JSON.parse( spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data ).imp[0]; assert.deepEqual(banner, { @@ -533,7 +533,7 @@ describe('Dianomi adapter', () => { describe('video', () => { it('should pass video mediatype config', () => { - let validBidRequests = [ + const validBidRequests = [ { bidId: 'bidId', params: { smartadId: 1234 }, @@ -546,7 +546,7 @@ describe('Dianomi adapter', () => { }, }, ]; - let { video } = JSON.parse( + const { video } = JSON.parse( spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data ).imp[0]; assert.deepEqual(video, { @@ -560,7 +560,7 @@ describe('Dianomi adapter', () => { describe('native', () => { describe('assets', () => { it('should set correct asset id', () => { - let validBidRequests = [ + const validBidRequests = [ { bidId: 'bidId', params: { smartadId: 1234 }, @@ -578,7 +578,7 @@ describe('Dianomi adapter', () => { }, }, ]; - let assets = JSON.parse( + const assets = JSON.parse( spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data ).imp[0].native.assets; @@ -587,7 +587,7 @@ describe('Dianomi adapter', () => { assert.equal(assets[2].id, 4); }); it('should add required key if it is necessary', () => { - let validBidRequests = [ + const validBidRequests = [ { bidId: 'bidId', params: { smartadId: 1234 }, @@ -607,7 +607,7 @@ describe('Dianomi adapter', () => { }, ]; - let assets = JSON.parse( + const assets = JSON.parse( spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data ).imp[0].native.assets; @@ -618,7 +618,7 @@ describe('Dianomi adapter', () => { }); it('should map img and data assets', () => { - let validBidRequests = [ + const validBidRequests = [ { bidId: 'bidId', params: { smartadId: 1234 }, @@ -634,7 +634,7 @@ describe('Dianomi adapter', () => { }, ]; - let assets = JSON.parse( + const assets = JSON.parse( spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data ).imp[0].native.assets; assert.ok(assets[0].title); @@ -664,7 +664,7 @@ describe('Dianomi adapter', () => { }, ]; - let assets = JSON.parse( + const assets = JSON.parse( spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data ).imp[0].native.assets; assert.ok(assets[0].img); @@ -701,7 +701,7 @@ describe('Dianomi adapter', () => { }, ]; - let assets = JSON.parse( + const assets = JSON.parse( spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' } }).data ).imp[0].native.assets; assert.ok(assets[0].img); @@ -746,13 +746,13 @@ describe('Dianomi adapter', () => { describe('interpretResponse', () => { it('should return if no body in response', () => { - let serverResponse = {}; - let bidRequest = {}; + const serverResponse = {}; + const bidRequest = {}; assert.ok(!spec.interpretResponse(serverResponse, bidRequest)); }); it('should return more than one bids', () => { - let serverResponse = { + const serverResponse = { body: { seatbid: [ { @@ -782,7 +782,7 @@ describe('Dianomi adapter', () => { ], }, }; - let bidRequest = { + const bidRequest = { data: {}, bids: [ { @@ -825,7 +825,7 @@ describe('Dianomi adapter', () => { }); it('should parse seatbids', () => { - let serverResponse = { + const serverResponse = { body: { seatbid: [ { @@ -863,7 +863,7 @@ describe('Dianomi adapter', () => { ], }, }; - let bidRequest = { + const bidRequest = { data: {}, bids: [ { @@ -950,7 +950,7 @@ describe('Dianomi adapter', () => { }); it('should set correct values to bid', () => { - let serverResponse = { + const serverResponse = { body: { id: null, bidid: null, @@ -980,7 +980,7 @@ describe('Dianomi adapter', () => { cur: 'USD', }, }; - let bidRequest = { + const bidRequest = { data: {}, bids: [ { @@ -1091,7 +1091,7 @@ describe('Dianomi adapter', () => { cur: 'USD', }, }; - let bidRequest = { + const bidRequest = { data: {}, bids: [{ bidId: 'bidId1' }], }; @@ -1124,7 +1124,7 @@ describe('Dianomi adapter', () => { cur: 'USD', }, }; - let bidRequest = { + const bidRequest = { data: {}, bids: [{ bidId: 'bidId1' }], }; @@ -1134,7 +1134,7 @@ describe('Dianomi adapter', () => { describe('banner', () => { it('should set ad content on response', () => { - let serverResponse = { + const serverResponse = { body: { seatbid: [ { @@ -1143,7 +1143,7 @@ describe('Dianomi adapter', () => { ], }, }; - let bidRequest = { + const bidRequest = { data: {}, bids: [ { @@ -1163,7 +1163,7 @@ describe('Dianomi adapter', () => { describe('video', () => { it('should set vastXml on response', () => { - let serverResponse = { + const serverResponse = { body: { seatbid: [ { @@ -1172,7 +1172,7 @@ describe('Dianomi adapter', () => { ], }, }; - let bidRequest = { + const bidRequest = { data: {}, bids: [ { @@ -1190,7 +1190,7 @@ describe('Dianomi adapter', () => { }); it('should add renderer for outstream bids', () => { - let serverResponse = { + const serverResponse = { body: { seatbid: [ { @@ -1202,7 +1202,7 @@ describe('Dianomi adapter', () => { ], }, }; - let bidRequest = { + const bidRequest = { data: {}, bids: [ { @@ -1234,10 +1234,10 @@ describe('Dianomi adapter', () => { }); describe('UserSyncs', () => { - let usersyncIframeUrl = 'https://www-prebid.dianomi.com/prebid/usersync/index.html?'; - let usersyncRedirectUrl = 'https://data.dianomi.com/frontend/usync?'; + const usersyncIframeUrl = 'https://www-prebid.dianomi.com/prebid/usersync/index.html?'; + const usersyncRedirectUrl = 'https://data.dianomi.com/frontend/usync?'; it('should register the usersync iframe', function () { - let syncs = spec.getUserSyncs({ + const syncs = spec.getUserSyncs({ iframeEnabled: true, }); @@ -1245,7 +1245,7 @@ describe('Dianomi adapter', () => { }); it('should register the usersync redirect', function () { - let syncs = spec.getUserSyncs({ + const syncs = spec.getUserSyncs({ pixelEnabled: true, }); diff --git a/test/spec/modules/digitalMatterBidAdapter_spec.js b/test/spec/modules/digitalMatterBidAdapter_spec.js index 12ff5d89c0b..320c27453b6 100644 --- a/test/spec/modules/digitalMatterBidAdapter_spec.js +++ b/test/spec/modules/digitalMatterBidAdapter_spec.js @@ -51,13 +51,13 @@ describe('Digital Matter BidAdapter', function () { }); it('should return false when required params are not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; expect(spec.isBidRequestValid(invalidBid)).to.equal(false); }); it('should return false when media type banner is missing', function () { - let invalidBid = deepClone(bid); + const invalidBid = deepClone(bid); delete invalidBid.mediaTypes.banner; expect(spec.isBidRequestValid(invalidBid)).to.equal(false); }); @@ -68,7 +68,7 @@ describe('Digital Matter BidAdapter', function () { config.resetConfig(); }); it('should send request with correct structure', function () { - let request = spec.buildRequests([bid], bidderRequest); + const request = spec.buildRequests([bid], bidderRequest); assert.equal(request.method, 'POST'); assert.equal(request.url, 'https://adx.digitalmatter.services/openrtb2/auction'); @@ -77,9 +77,9 @@ describe('Digital Matter BidAdapter', function () { }); it('should have default request structure', function () { - let keys = 'tid,site,device,imp,test,ext'.split(','); - let request = JSON.parse(spec.buildRequests([bid], bidderRequest).data); - let data = Object.keys(request); + const keys = 'tid,site,device,imp,test,ext'.split(','); + const request = JSON.parse(spec.buildRequests([bid], bidderRequest).data); + const data = Object.keys(request); assert.deepEqual(keys, data); }); @@ -88,7 +88,7 @@ describe('Digital Matter BidAdapter', function () { config.setConfig({ device: {w: 1920, h: 1080} }); - let request = JSON.parse(spec.buildRequests([bid], bidderRequest).data); + const request = JSON.parse(spec.buildRequests([bid], bidderRequest).data); assert.equal(request.device.ua, navigator.userAgent); assert.equal(request.device.w, 100); @@ -96,7 +96,7 @@ describe('Digital Matter BidAdapter', function () { }); it('should send info about the site', function () { - let request = JSON.parse(spec.buildRequests([bid], bidderRequest).data); + const request = JSON.parse(spec.buildRequests([bid], bidderRequest).data); assert.deepEqual(request.site, { domain: 'publisher.domain.com', @@ -109,13 +109,13 @@ describe('Digital Matter BidAdapter', function () { it('should send currency if defined', function () { config.setConfig({currency: {adServerCurrency: 'EUR'}}); - let request = JSON.parse(spec.buildRequests([bid], bidderRequest).data); + const request = JSON.parse(spec.buildRequests([bid], bidderRequest).data); assert.deepEqual(request.cur, [{adServerCurrency: 'EUR'}]); }); it('should pass supply chain object', function () { - let validBidRequests = { + const validBidRequests = { ...bid, ortb2: { source: { @@ -131,7 +131,7 @@ describe('Digital Matter BidAdapter', function () { } }; - let request = JSON.parse(spec.buildRequests([validBidRequests], bidderRequest).data); + const request = JSON.parse(spec.buildRequests([validBidRequests], bidderRequest).data); assert.deepEqual(request.source.ext.schain, { validation: 'strict', config: { @@ -141,7 +141,7 @@ describe('Digital Matter BidAdapter', function () { }); it('should pass extended ids if exists', function () { - let validBidRequests = { + const validBidRequests = { ...bid, userIdAsEids: [ { @@ -159,13 +159,13 @@ describe('Digital Matter BidAdapter', function () { ] }; - let request = JSON.parse(spec.buildRequests([validBidRequests], bidderRequest).data); + const request = JSON.parse(spec.buildRequests([validBidRequests], bidderRequest).data); assert.deepEqual(request.user.ext.eids, validBidRequests.userIdAsEids); }); it('should pass gdpr consent data if gdprApplies', function () { - let consentedBidderRequest = { + const consentedBidderRequest = { ...bidderRequest, gdprConsent: { gdprApplies: true, @@ -173,7 +173,7 @@ describe('Digital Matter BidAdapter', function () { } }; - let request = JSON.parse(spec.buildRequests([bid], consentedBidderRequest).data); + const request = JSON.parse(spec.buildRequests([bid], consentedBidderRequest).data); assert.equal(request.user.ext.consent, consentedBidderRequest.gdprConsent.consentString); assert.equal(request.regs.ext.gdpr, consentedBidderRequest.gdprConsent.gdprApplies); assert.equal(typeof request.regs.ext.gdpr, 'number'); diff --git a/test/spec/modules/discoveryBidAdapter_spec.js b/test/spec/modules/discoveryBidAdapter_spec.js index ce9335bbb0b..fbeef8a8d7e 100644 --- a/test/spec/modules/discoveryBidAdapter_spec.js +++ b/test/spec/modules/discoveryBidAdapter_spec.js @@ -33,7 +33,7 @@ describe('discovery:BidAdapterTests', function () { sandbox.restore(); }); - let bidRequestData = { + const bidRequestData = { bidderCode: 'discovery', auctionId: 'ff66e39e-4075-4d18-9854-56fde9b879ac', bidderRequestId: '4fec04e87ad785', @@ -126,7 +126,7 @@ describe('discovery:BidAdapterTests', function () { }; let request = []; - let bidRequestDataNoParams = { + const bidRequestDataNoParams = { bidderCode: 'discovery', auctionId: 'ff66e39e-4075-4d18-9854-56fde9b879ac', bidderRequestId: '4fec04e87ad785', @@ -221,13 +221,13 @@ describe('discovery:BidAdapterTests', function () { it('discovery:validate_generated_params', function () { storage.getCookie.withArgs('_ss_pp_utm').callsFake(() => '{"utm_source":"example.com","utm_medium":"123","utm_campaign":"456"}'); request = spec.buildRequests(bidRequestData.bids, bidRequestData); - let req_data = JSON.parse(request.data); + const req_data = JSON.parse(request.data); expect(req_data.imp).to.have.lengthOf(1); }); describe('first party data', function () { it('should pass additional parameter in request for topics', function () { const request = spec.buildRequests(bidRequestData.bids, bidRequestData); - let res = JSON.parse(request.data); + const res = JSON.parse(request.data); expect(res.ext.tpData).to.deep.equal(bidRequestData.ortb2.user.data); }); }); @@ -284,7 +284,7 @@ describe('discovery:BidAdapterTests', function () { tempAdm += '%3Cscr'; tempAdm += 'ipt%3E'; tempAdm += '!function(){\"use strict\";function f(t){return(f=\"function\"==typeof Symbol&&\"symbol\"==typeof Symbol.iterator?function(t){return typeof t}:function(t){return t&&\"function\"==typeof Symbol&&t.constructor===Symbol&&t!==Symbol.prototype?\"symbol\":typeof t})(t)}function l(t){var e=0 { - let bid = { + const bid = { 'bidder': 'djax', 'params': { 'publisherId': 2 @@ -40,7 +40,7 @@ describe('Djax Adapter', function() { }); describe('buildRequestsForBanner', () => { - let bidRequests = [ + const bidRequests = [ { 'bidder': 'djax', 'params': { @@ -69,7 +69,7 @@ describe('Djax Adapter', function() { }); describe('interpretResponseForBanner', () => { - let bidRequests = [ + const bidRequests = [ { 'bidder': 'djax', 'params': { @@ -92,8 +92,8 @@ describe('Djax Adapter', function() { it('handles nobid responses', () => { var request = spec.buildRequests(bidRequests); - let response = ''; - let result = spec.interpretResponse(response, request[0]); + const response = ''; + const result = spec.interpretResponse(response, request[0]); expect(result.length).to.equal(0); }); }); diff --git a/test/spec/modules/dmdIdSystem_spec.js b/test/spec/modules/dmdIdSystem_spec.js index 6b5f4d7d399..d0d8747dee9 100644 --- a/test/spec/modules/dmdIdSystem_spec.js +++ b/test/spec/modules/dmdIdSystem_spec.js @@ -53,12 +53,12 @@ describe('Dmd ID System', function () { }); it('should return dmdId if valid dmd-dgid passed into decode', function () { - let data = { 'dmdId': 'U12345' }; + const data = { 'dmdId': 'U12345' }; expect(dmdIdSubmodule.decode('U12345')).to.deep.equal(data); }); it('should return cacheObj if cacheObj is passed into getId', function () { - let data = { 'dmdId': 'U12345' }; + const data = { 'dmdId': 'U12345' }; expect(dmdIdSubmodule.getId(config, {}, { cookie: 'dmd-dgid' })).to.deep.equal({ cookie: 'dmd-dgid' }); expect(server.requests.length).to.eq(0); }); diff --git a/test/spec/modules/docereeAdManagerBidAdapter_spec.js b/test/spec/modules/docereeAdManagerBidAdapter_spec.js index 6f7da056681..b0a7ac89e1c 100644 --- a/test/spec/modules/docereeAdManagerBidAdapter_spec.js +++ b/test/spec/modules/docereeAdManagerBidAdapter_spec.js @@ -95,9 +95,9 @@ describe('docereeadmanager', function () { }, }, }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys( 'requestId', 'cpm', diff --git a/test/spec/modules/docereeBidAdapter_spec.js b/test/spec/modules/docereeBidAdapter_spec.js index 25da8b256fc..6b79264f2d6 100644 --- a/test/spec/modules/docereeBidAdapter_spec.js +++ b/test/spec/modules/docereeBidAdapter_spec.js @@ -27,7 +27,7 @@ describe('BidlabBidAdapter', function () { } } }); - let bid = { + const bid = { bidId: 'testing', bidder: 'doceree', params: { @@ -85,9 +85,9 @@ describe('BidlabBidAdapter', function () { advertiserDomain: 'doceree.com', } }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'netRevenue', 'currency', 'mediaType', 'creativeId', 'meta'); expect(dataItem.requestId).to.equal('G125fzC5NKl3FHeOT8yvL98ILfQS9TVUgk6Q'); diff --git a/test/spec/modules/dochaseBidAdapter_spec.js b/test/spec/modules/dochaseBidAdapter_spec.js index 2026f3b5811..88466655219 100644 --- a/test/spec/modules/dochaseBidAdapter_spec.js +++ b/test/spec/modules/dochaseBidAdapter_spec.js @@ -141,7 +141,7 @@ describe('dochase adapter', function () { describe('validations', function () { it('isBidValid : placement_id is passed', function () { - let bid = { + const bid = { bidder: 'dochase', params: { placement_id: 5550 @@ -151,7 +151,7 @@ describe('dochase adapter', function () { expect(isValid).to.equals(true); }); it('isBidValid : placement_id is not passed', function () { - let bid = { + const bid = { bidder: 'dochase', params: { width: 300, @@ -166,42 +166,42 @@ describe('dochase adapter', function () { }); describe('Validate Banner Request', function () { it('Immutable bid request validate', function () { - let _Request = utils.deepClone(bannerRequest), + const _Request = utils.deepClone(bannerRequest), bidRequest = spec.buildRequests(bannerRequest); expect(bannerRequest).to.deep.equal(_Request); }); it('Validate bidder connection', function () { - let _Request = spec.buildRequests(bannerRequest); + const _Request = spec.buildRequests(bannerRequest); expect(_Request.url).to.equal('https://rtb.dochaseadx.com/hb'); expect(_Request.method).to.equal('POST'); expect(_Request.options.contentType).to.equal('application/json'); }); it('Validate bid request : Impression', function () { - let _Request = spec.buildRequests(bannerRequest); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(bannerRequest); + const data = JSON.parse(_Request.data); // expect(data.at).to.equal(1); // auction type expect(data[0].imp[0].id).to.equal(bannerRequest[0].bidId); expect(data[0].placementId).to.equal(5550); }); it('Validate bid request : ad size', function () { - let _Request = spec.buildRequests(bannerRequest); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(bannerRequest); + const data = JSON.parse(_Request.data); expect(data[0].imp[0].banner).to.be.a('object'); expect(data[0].imp[0].banner.w).to.equal(300); expect(data[0].imp[0].banner.h).to.equal(250); }); it('Validate bid request : user object', function () { - let _Request = spec.buildRequests(bannerRequest); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(bannerRequest); + const data = JSON.parse(_Request.data); expect(data[0].user).to.be.a('object'); expect(data[0].user.id).to.be.a('string'); }); it('Validate bid request : CCPA Check', function () { - let bidRequest = { + const bidRequest = { uspConsent: '1NYN' }; - let _Request = spec.buildRequests(bannerRequest, bidRequest); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(bannerRequest, bidRequest); + const data = JSON.parse(_Request.data); expect(data[0].regs.ext.us_privacy).to.equal('1NYN'); // let _bidRequest = {}; // let _Request1 = spec.buildRequests(request, _bidRequest); @@ -211,8 +211,8 @@ describe('dochase adapter', function () { }); describe('Validate banner response ', function () { it('Validate bid response : valid bid response', function () { - let _Request = spec.buildRequests(bannerRequest); - let bResponse = spec.interpretResponse(bannerResponse, _Request); + const _Request = spec.buildRequests(bannerRequest); + const bResponse = spec.interpretResponse(bannerResponse, _Request); expect(bResponse).to.be.an('array').with.length.above(0); expect(bResponse[0].requestId).to.equal(bannerResponse.body.seatbid[0].bid[0].impid); expect(bResponse[0].width).to.equal(bannerResponse.body.seatbid[0].bid[0].w); @@ -226,42 +226,42 @@ describe('dochase adapter', function () { expect(bResponse[0].dealId).to.equal(bannerResponse.body.seatbid[0].bid[0].dealId); }); it('Invalid bid response check ', function () { - let bRequest = spec.buildRequests(bannerRequest); - let response = spec.interpretResponse(invalidBannerResponse, bRequest); + const bRequest = spec.buildRequests(bannerRequest); + const response = spec.interpretResponse(invalidBannerResponse, bRequest); expect(response[0].ad).to.equal('invalid response'); }); }); describe('Validate Native Request', function () { it('Immutable bid request validate', function () { - let _Request = utils.deepClone(nativeRequest), + const _Request = utils.deepClone(nativeRequest), bidRequest = spec.buildRequests(nativeRequest); expect(nativeRequest).to.deep.equal(_Request); }); it('Validate bidder connection', function () { - let _Request = spec.buildRequests(nativeRequest); + const _Request = spec.buildRequests(nativeRequest); expect(_Request.url).to.equal('https://rtb.dochaseadx.com/hb'); expect(_Request.method).to.equal('POST'); expect(_Request.options.contentType).to.equal('application/json'); }); it('Validate bid request : Impression', function () { - let _Request = spec.buildRequests(nativeRequest); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(nativeRequest); + const data = JSON.parse(_Request.data); // expect(data.at).to.equal(1); // auction type expect(data[0].imp[0].id).to.equal(nativeRequest[0].bidId); expect(data[0].placementId).to.equal(5551); }); it('Validate bid request : user object', function () { - let _Request = spec.buildRequests(nativeRequest); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(nativeRequest); + const data = JSON.parse(_Request.data); expect(data[0].user).to.be.a('object'); expect(data[0].user.id).to.be.a('string'); }); it('Validate bid request : CCPA Check', function () { - let bidRequest = { + const bidRequest = { uspConsent: '1NYN' }; - let _Request = spec.buildRequests(nativeRequest, bidRequest); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(nativeRequest, bidRequest); + const data = JSON.parse(_Request.data); expect(data[0].regs.ext.us_privacy).to.equal('1NYN'); // let _bidRequest = {}; // let _Request1 = spec.buildRequests(request, _bidRequest); @@ -271,8 +271,8 @@ describe('dochase adapter', function () { }); describe('Validate native response ', function () { it('Validate bid response : valid bid response', function () { - let _Request = spec.buildRequests(nativeRequest); - let bResponse = spec.interpretResponse(nativeResponse, _Request); + const _Request = spec.buildRequests(nativeRequest); + const bResponse = spec.interpretResponse(nativeResponse, _Request); expect(bResponse).to.be.an('array').with.length.above(0); expect(bResponse[0].requestId).to.equal(nativeResponse.body.seatbid[0].bid[0].impid); // expect(bResponse[0].width).to.equal(bannerResponse.body.seatbid[0].bid[0].w); @@ -292,14 +292,14 @@ describe('dochase adapter', function () { }); describe('GPP and coppa', function () { it('Request params check with GPP Consent', function () { - let bidderReq = { gppConsent: { gppString: 'gpp-string-test', applicableSections: [5] } }; - let _Request = spec.buildRequests(bannerRequest, bidderReq); - let data = JSON.parse(_Request.data); + const bidderReq = { gppConsent: { gppString: 'gpp-string-test', applicableSections: [5] } }; + const _Request = spec.buildRequests(bannerRequest, bidderReq); + const data = JSON.parse(_Request.data); expect(data[0].regs.gpp).to.equal('gpp-string-test'); expect(data[0].regs.gpp_sid[0]).to.equal(5); }); it('Request params check with GPP Consent read from ortb2', function () { - let bidderReq = { + const bidderReq = { ortb2: { regs: { gpp: 'gpp-test-string', @@ -307,15 +307,15 @@ describe('dochase adapter', function () { } } }; - let _Request = spec.buildRequests(bannerRequest, bidderReq); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(bannerRequest, bidderReq); + const data = JSON.parse(_Request.data); expect(data[0].regs.gpp).to.equal('gpp-test-string'); expect(data[0].regs.gpp_sid[0]).to.equal(5); }); it(' Bid request should have coppa flag if its true', () => { - let bidderReq = { ortb2: { regs: { coppa: 1 } } }; - let _Request = spec.buildRequests(bannerRequest, bidderReq); - let data = JSON.parse(_Request.data); + const bidderReq = { ortb2: { regs: { coppa: 1 } } }; + const _Request = spec.buildRequests(bannerRequest, bidderReq); + const data = JSON.parse(_Request.data); expect(data[0].regs.coppa).to.equal(1); }); }); diff --git a/test/spec/modules/dspxBidAdapter_spec.js b/test/spec/modules/dspxBidAdapter_spec.js index 95e59f5cec3..e0d7c2a9a3f 100644 --- a/test/spec/modules/dspxBidAdapter_spec.js +++ b/test/spec/modules/dspxBidAdapter_spec.js @@ -12,7 +12,7 @@ describe('dspxAdapter', function () { const adapter = newBidder(spec); describe('isBidRequestValid', function () { - let bid = { + const bid = { 'bidder': 'dspx', 'params': { 'placement': '6682', @@ -52,7 +52,7 @@ describe('dspxAdapter', function () { }); describe('buildRequests', function () { - let bidRequests = [{ + const bidRequests = [{ 'bidder': 'dspx', 'params': { 'placement': '6682', @@ -369,7 +369,7 @@ describe('dspxAdapter', function () { it('sends bid request to our endpoint via GET', function () { expect(request1.method).to.equal('GET'); expect(request1.url).to.equal(ENDPOINT_URL); - let data = request1.data.replace(/rnd=\d+\&/g, '').replace(/ref=.*\&bid/g, 'bid').replace(/pbver=.*?&/g, 'pbver=test&'); + const data = request1.data.replace(/rnd=\d+\&/g, '').replace(/ref=.*\&bid/g, 'bid').replace(/pbver=.*?&/g, 'pbver=test&'); expect(data).to.equal('_f=auto&alternative=prebid_js&inventory_item_id=6682&srw=300&srh=250&idt=100&bid_id=30b31c1838de1e1&pbver=test&pfilter%5Bfloorprice%5D=1000000&pfilter%5Bprivate_auction%5D=0&pfilter%5Bgeo%5D%5Bcountry%5D=DE&pfilter%5Bgdpr_consent%5D=BOJ%2FP2HOJ%2FP2HABABMAAAAAZ%2BA%3D%3D&pfilter%5Bgdpr%5D=true&bcat=IAB2%2CIAB4&dvt=desktop&auctionId=1d1a030790a475&pbcode=testDiv1&media_types%5Bbanner%5D=300x250&schain=1.0%2C1!example.com%2C0%2C1%2Cbidrequestid%2C%2Cexample.com&did_cruid=criteo&did_ppuid=1%3Adomain.com%3A1234&did_pubcid=pubcid&did_netid=netid&did_uid2=uidapi&did_sharedid=sharedid&did_tdid=adserver&did_pbmid=pubmatic&did_yhid=yahoo&did_uqid=utiq&did_euid=euid&did_id5=ID5UID&did_id5_linktype=2&did_cpubcid=crumbs_pubcid'); }); @@ -377,7 +377,7 @@ describe('dspxAdapter', function () { it('sends bid request to our DEV endpoint via GET', function () { expect(request2.method).to.equal('GET'); expect(request2.url).to.equal(ENDPOINT_URL_DEV); - let data = request2.data.replace(/rnd=\d+\&/g, '').replace(/ref=.*\&bid/g, 'bid').replace(/pbver=.*?&/g, 'pbver=test&'); + const data = request2.data.replace(/rnd=\d+\&/g, '').replace(/ref=.*\&bid/g, 'bid').replace(/pbver=.*?&/g, 'pbver=test&'); expect(data).to.equal('_f=auto&alternative=prebid_js&inventory_item_id=101&srw=300&srh=250&idt=100&bid_id=30b31c1838de1e2&pbver=test&pfilter%5Bgdpr_consent%5D=BOJ%2FP2HOJ%2FP2HABABMAAAAAZ%2BA%3D%3D&pfilter%5Bgdpr%5D=true&prebidDevMode=1&auctionId=1d1a030790a476&media_types%5Bbanner%5D=300x250'); }); @@ -391,7 +391,7 @@ describe('dspxAdapter', function () { it('sends bid request without gdprConsent to our endpoint via GET', function () { expect(request3.method).to.equal('GET'); expect(request3.url).to.equal(ENDPOINT_URL); - let data = request3.data.replace(/rnd=\d+\&/g, '').replace(/ref=.*\&bid/g, 'bid').replace(/pbver=.*?&/g, 'pbver=test&'); + const data = request3.data.replace(/rnd=\d+\&/g, '').replace(/ref=.*\&bid/g, 'bid').replace(/pbver=.*?&/g, 'pbver=test&'); expect(data).to.equal('_f=auto&alternative=prebid_js&inventory_item_id=6682&srw=300&srh=250&idt=100&bid_id=30b31c1838de1e3&pbver=test&pfilter%5Bfloorprice%5D=1000000&pfilter%5Bprivate_auction%5D=0&pfilter%5Bgeo%5D%5Bcountry%5D=DE&bcat=IAB2%2CIAB4&dvt=desktop&auctionId=1d1a030790a477&pbcode=testDiv2&media_types%5Bbanner%5D=300x250'); }); @@ -399,14 +399,14 @@ describe('dspxAdapter', function () { it('sends bid request without gdprConsent to our DEV endpoint via GET', function () { expect(request4.method).to.equal('GET'); expect(request4.url).to.equal(ENDPOINT_URL_DEV); - let data = request4.data.replace(/rnd=\d+\&/g, '').replace(/ref=.*\&bid/g, 'bid').replace(/pbver=.*?&/g, 'pbver=test&'); + const data = request4.data.replace(/rnd=\d+\&/g, '').replace(/ref=.*\&bid/g, 'bid').replace(/pbver=.*?&/g, 'pbver=test&'); expect(data).to.equal('_f=auto&alternative=prebid_js&inventory_item_id=101&srw=300&srh=250&idt=100&bid_id=30b31c1838de1e4&pbver=test&prebidDevMode=1&auctionId=1d1a030790a478&pbcode=testDiv3&media_types%5Bvideo%5D=640x480&media_types%5Bbanner%5D=300x250&vctx=instream&vpl%5Bprotocols%5D%5B0%5D=1&vpl%5Bprotocols%5D%5B1%5D=2&vpl%5Bplaybackmethod%5D%5B0%5D=2&vpl%5Bskip%5D=1'); }); var request5 = spec.buildRequests([bidRequests[4]], bidderRequestWithoutGdpr)[0]; it('sends bid video request to our endpoint via GET', function () { expect(request5.method).to.equal('GET'); - let data = request5.data.replace(/rnd=\d+\&/g, '').replace(/ref=.*\&bid/g, 'bid').replace(/pbver=.*?&/g, 'pbver=test&'); + const data = request5.data.replace(/rnd=\d+\&/g, '').replace(/ref=.*\&bid/g, 'bid').replace(/pbver=.*?&/g, 'pbver=test&'); expect(data).to.equal('_f=auto&alternative=prebid_js&inventory_item_id=101&srw=640&srh=480&idt=100&bid_id=30b31c1838de1e41&pbver=test&prebidDevMode=1&auctionId=1d1a030790a478&pbcode=testDiv4&media_types%5Bvideo%5D=640x480&vctx=instream&vf=vast4&vpl%5Bprotocols%5D%5B0%5D=1&vpl%5Bprotocols%5D%5B1%5D=2&vpl%5Bplaybackmethod%5D%5B0%5D=2&vpl%5Bskip%5D=1'); }); @@ -414,7 +414,7 @@ describe('dspxAdapter', function () { it('sends bid request without gdprConsent to our DEV endpoint with overriden DEV params via GET', function () { expect(request6.method).to.equal('GET'); expect(request6.url).to.equal('http://localhost'); - let data = request6.data.replace(/rnd=\d+\&/g, '').replace(/ref=.*\&bid/g, 'bid').replace(/pbver=.*?&/g, 'pbver=test&'); + const data = request6.data.replace(/rnd=\d+\&/g, '').replace(/ref=.*\&bid/g, 'bid').replace(/pbver=.*?&/g, 'pbver=test&'); expect(data).to.equal('_f=auto&alternative=prebid_js&inventory_item_id=107&srw=300&srh=250&idt=100&bid_id=30b31c1838de1e4&pbver=test&pfilter%5Btest%5D=1&prebidDevMode=1&auctionId=1d1a030790a478&pbcode=testDiv3&media_types%5Bvideo%5D=640x480&media_types%5Bbanner%5D=300x250&vctx=instream&vpl%5Bmimes%5D%5B0%5D=video%2Fmp4&vpl%5Bprotocols%5D%5B0%5D=1&vpl%5Bprotocols%5D%5B1%5D=2&vpl%5Bplaybackmethod%5D%5B0%5D=2&vpl%5Bskip%5D=1'); }); @@ -422,7 +422,7 @@ describe('dspxAdapter', function () { it('ortb2 iab_content test', function () { expect(request7.method).to.equal('GET'); expect(request7.url).to.equal('http://localhost'); - let data = request7.data.replace(/rnd=\d+\&/g, '').replace(/ref=.*\&bid/g, 'bid').replace(/pbver=.*?&/g, 'pbver=test&'); + const data = request7.data.replace(/rnd=\d+\&/g, '').replace(/ref=.*\&bid/g, 'bid').replace(/pbver=.*?&/g, 'pbver=test&'); expect(data).to.equal('_f=auto&alternative=prebid_js&inventory_item_id=107&srw=300&srh=250&idt=100&bid_id=30b31c1838de1e4&pbver=test&pfilter%5Btest%5D=1&pfilter%5Bgdpr_consent%5D=BOJ%2FP2HOJ%2FP2HABABMAAAAAZ%2BA%3D%3D&pfilter%5Bgdpr%5D=true&pfilter%5Biab_content%5D=cat%3AIAB1-1%7CIAB1-2%7CIAB2-10%2Cepisode%3A1%2Ccontext%3A1%2Cid%3AcontentID%2Ctitle%3AcontentTitle%2Cseries%3AcontentSeries%2Cseason%3AcontentSeason%25203%2Cartist%3AcontentArtist%2Cgenre%3Arock%2Cisrc%3AcontentIsrc%2Curl%3Ahttps%253A%252F%252Fcontent-url.com%252F%2Ckeywords%3Akw1%252Ckw2%252Ckeqword%25203&bcat=BSW1%2CBSW2&pcat=IAB3&prebidDevMode=1&auctionId=1d1a030790a478&pbcode=testDiv3&media_types%5Bvideo%5D=640x480&media_types%5Bbanner%5D=300x250&vctx=instream&vpl%5Bmimes%5D%5B0%5D=video%2Fmp4&vpl%5Bprotocols%5D%5B0%5D=1&vpl%5Bprotocols%5D%5B1%5D=2&vpl%5Bplaybackmethod%5D%5B0%5D=2&vpl%5Bskip%5D=1'); }); @@ -562,7 +562,7 @@ describe('dspxAdapter', function () { }; config.setConfig(INVALID_TOPICS_DATA); - let request = spec.buildRequests([defaultRequest], { ...REQPARAMS, ...INVALID_TOPICS_DATA })[0]; + const request = spec.buildRequests([defaultRequest], { ...REQPARAMS, ...INVALID_TOPICS_DATA })[0]; expect(request.data).to.not.contain('segtax'); expect(request.data).to.not.contain('segclass'); expect(request.data).to.not.contain('segments'); @@ -570,7 +570,7 @@ describe('dspxAdapter', function () { }); describe('interpretResponse', function () { - let serverResponse = { + const serverResponse = { 'body': { 'cpm': 5000000, 'crid': 100500, @@ -586,7 +586,7 @@ describe('dspxAdapter', function () { 'adomain': ['bdomain'] } }; - let serverVideoResponse = { + const serverVideoResponse = { 'body': { 'cpm': 5000000, 'crid': 100500, @@ -602,7 +602,7 @@ describe('dspxAdapter', function () { 'renderer': {id: 1, url: '//player.example.com', options: {}} } }; - let serverVideoResponseVastUrl = { + const serverVideoResponseVastUrl = { 'body': { 'cpm': 5000000, 'crid': 100500, @@ -620,7 +620,7 @@ describe('dspxAdapter', function () { } }; - let expectedResponse = [{ + const expectedResponse = [{ requestId: '23beaa6af6cdde', cpm: 0.5, width: 0, @@ -667,21 +667,21 @@ describe('dspxAdapter', function () { }]; it('should get the correct bid response by display ad', function () { - let bidRequest = [{ + const bidRequest = [{ 'method': 'GET', 'url': ENDPOINT_URL, 'data': { 'bid_id': '30b31c1838de1e' } }]; - let result = spec.interpretResponse(serverResponse, bidRequest[0]); + const result = spec.interpretResponse(serverResponse, bidRequest[0]); expect(Object.keys(result[0])).to.include.members(Object.keys(expectedResponse[0])); expect(result[0].meta.advertiserDomains.length).to.equal(1); expect(result[0].meta.advertiserDomains[0]).to.equal(expectedResponse[0].meta.advertiserDomains[0]); }); it('should get the correct dspx video bid response by display ad', function () { - let bidRequest = [{ + const bidRequest = [{ 'method': 'GET', 'url': ENDPOINT_URL, 'mediaTypes': { @@ -694,13 +694,13 @@ describe('dspxAdapter', function () { 'bid_id': '30b31c1838de1e' } }]; - let result = spec.interpretResponse(serverVideoResponse, bidRequest[0]); + const result = spec.interpretResponse(serverVideoResponse, bidRequest[0]); expect(Object.keys(result[0])).to.include.members(Object.keys(expectedResponse[1])); expect(result[0].meta.advertiserDomains.length).to.equal(0); }); it('should get the correct dspx video bid response by display ad (vastUrl)', function () { - let bidRequest = [{ + const bidRequest = [{ 'method': 'GET', 'url': ENDPOINT_URL, 'mediaTypes': { @@ -713,16 +713,16 @@ describe('dspxAdapter', function () { 'bid_id': '30b31c1838de1e' } }]; - let result = spec.interpretResponse(serverVideoResponseVastUrl, bidRequest[0]); + const result = spec.interpretResponse(serverVideoResponseVastUrl, bidRequest[0]); expect(Object.keys(result[0])).to.include.members(Object.keys(expectedResponse[2])); expect(result[0].meta.advertiserDomains.length).to.equal(0); }); it('handles empty bid response', function () { - let response = { + const response = { body: {} }; - let result = spec.interpretResponse(response); + const result = spec.interpretResponse(response); expect(result.length).to.equal(0); }); }); @@ -757,22 +757,22 @@ describe('dspxAdapter', function () { }); it(`array should have only one object and it should have a property type = 'iframe'`, function () { expect(spec.getUserSyncs({ iframeEnabled: true }, serverResponses).length).to.be.equal(1); - let [userSync] = spec.getUserSyncs({ iframeEnabled: true }, serverResponses); + const [userSync] = spec.getUserSyncs({ iframeEnabled: true }, serverResponses); expect(userSync).to.have.property('type'); expect(userSync.type).to.be.equal('iframe'); }); it(`we have valid sync url for iframe`, function () { - let [userSync] = spec.getUserSyncs({ iframeEnabled: true }, serverResponses, {consentString: 'anyString'}); + const [userSync] = spec.getUserSyncs({ iframeEnabled: true }, serverResponses, {consentString: 'anyString'}); expect(userSync.url).to.be.equal('anyIframeUrl?a=1&gdpr_consent=anyString') expect(userSync.type).to.be.equal('iframe'); }); it(`we have valid sync url for image`, function () { - let [userSync] = spec.getUserSyncs({ pixelEnabled: true }, serverResponses, {gdprApplies: true, consentString: 'anyString'}); + const [userSync] = spec.getUserSyncs({ pixelEnabled: true }, serverResponses, {gdprApplies: true, consentString: 'anyString'}); expect(userSync.url).to.be.equal('anyImageUrl?gdpr=1&gdpr_consent=anyString') expect(userSync.type).to.be.equal('image'); }); it(`we have valid sync url for image and iframe`, function () { - let userSync = spec.getUserSyncs({ iframeEnabled: true, pixelEnabled: true }, serverResponses, {gdprApplies: true, consentString: 'anyString'}); + const userSync = spec.getUserSyncs({ iframeEnabled: true, pixelEnabled: true }, serverResponses, {gdprApplies: true, consentString: 'anyString'}); expect(userSync.length).to.be.equal(3); expect(userSync[0].url).to.be.equal('anyIframeUrl?a=1&gdpr=1&gdpr_consent=anyString') expect(userSync[0].type).to.be.equal('iframe'); diff --git a/test/spec/modules/dvgroupBidAdapter_spec.js b/test/spec/modules/dvgroupBidAdapter_spec.js index f8ef77ee4df..f31703a9ade 100644 --- a/test/spec/modules/dvgroupBidAdapter_spec.js +++ b/test/spec/modules/dvgroupBidAdapter_spec.js @@ -3,7 +3,7 @@ import { spec } from 'modules/dvgroupBidAdapter.js'; import { deepClone } from 'src/utils.js'; describe('dvgroupBidAdapterTests', function () { - let bidRequestData = { + const bidRequestData = { bids: [ { adUnitCode: 'div-banner-id', @@ -38,13 +38,13 @@ describe('dvgroupBidAdapterTests', function () { it('validate_generated_url', function () { const request = spec.buildRequests(deepClone(bidRequestData.bids), { timeout: 1234 }); - let req_url = request[0].url; + const req_url = request[0].url; expect(req_url).to.equal('https://rtb.dvgroup.com/bid?sspuid=prebidssp'); }); it('validate_response_params', function () { - let serverResponse = { + const serverResponse = { body: { id: 'bid123', seatbid: [ @@ -86,10 +86,10 @@ describe('dvgroupBidAdapterTests', function () { } const request = spec.buildRequests(bidRequest); - let bids = spec.interpretResponse(serverResponse, request[0]); + const bids = spec.interpretResponse(serverResponse, request[0]); expect(bids).to.have.lengthOf(1); - let bid = bids[0]; + const bid = bids[0]; expect(bid.ad).to.equal('

AD

'); expect(bid.cpm).to.equal(0.9899); expect(bid.currency).to.equal('EUR'); @@ -100,7 +100,7 @@ describe('dvgroupBidAdapterTests', function () { }); it('validate_invalid_response', function () { - let serverResponse = { + const serverResponse = { body: {} }; @@ -115,7 +115,7 @@ describe('dvgroupBidAdapterTests', function () { } const request = spec.buildRequests(bidRequest); - let bids = spec.interpretResponse(serverResponse, request[0]); + const bids = spec.interpretResponse(serverResponse, request[0]); expect(bids).to.have.lengthOf(0); }) @@ -130,7 +130,7 @@ describe('dvgroupBidAdapterTests', function () { const request = spec.buildRequests(bidRequest, { timeout: 1234 }); const vastXml = ''; - let serverResponse = { + const serverResponse = { body: { id: 'bid123', seatbid: [ @@ -161,10 +161,10 @@ describe('dvgroupBidAdapterTests', function () { } }; - let bids = spec.interpretResponse(serverResponse, request[0]); + const bids = spec.interpretResponse(serverResponse, request[0]); expect(bids).to.have.lengthOf(1); - let bid = bids[0]; + const bid = bids[0]; expect(bid.mediaType).to.equal('video'); expect(bid.vastXml).to.equal(vastXml); expect(bid.width).to.equal(300); diff --git a/test/spec/modules/dxkultureBidAdapter_spec.js b/test/spec/modules/dxkultureBidAdapter_spec.js index a752c81cb6e..ad1adf18d02 100644 --- a/test/spec/modules/dxkultureBidAdapter_spec.js +++ b/test/spec/modules/dxkultureBidAdapter_spec.js @@ -152,7 +152,7 @@ const getBidderResponse = () => { bidder: { appnexus: { brand_id: 334553, - auction_id: 514667951122925701, + auction_id: '514667951122925701', bidder_id: 2, bid_ad_type: 0 } @@ -465,7 +465,7 @@ describe('dxkultureBidAdapter', function() { context('when mediaType is banner', function () { it('creates request data', function () { - let request = spec.buildRequests(bidderBannerRequest.bids, bidderBannerRequest) + const request = spec.buildRequests(bidderBannerRequest.bids, bidderBannerRequest) expect(request).to.exist.and.to.be.a('object'); const payload = request.data; @@ -479,7 +479,7 @@ describe('dxkultureBidAdapter', function() { gdprApplies: true, } }); - let request = spec.buildRequests(bidderBannerRequest.bids, req); + const request = spec.buildRequests(bidderBannerRequest.bids, req); const payload = request.data; expect(payload.user.ext).to.have.property('consent', req.gdprConsent.consentString); @@ -546,7 +546,7 @@ describe('dxkultureBidAdapter', function() { }); it('have bids', function () { - let bids = spec.interpretResponse(bidderResponse, bidRequest); + const bids = spec.interpretResponse(bidderResponse, bidRequest); expect(bids).to.be.an('array').that.is.not.empty; validateBidOnIndex(0); @@ -615,17 +615,17 @@ describe('dxkultureBidAdapter', function() { }); it('handles no parameters', function () { - let opts = spec.getUserSyncs({}); + const opts = spec.getUserSyncs({}); expect(opts).to.be.an('array').that.is.empty; }); it('returns non if sync is not allowed', function () { - let opts = spec.getUserSyncs({iframeEnabled: false, pixelEnabled: false}); + const opts = spec.getUserSyncs({iframeEnabled: false, pixelEnabled: false}); expect(opts).to.be.an('array').that.is.empty; }); it('iframe sync enabled should return results', function () { - let opts = spec.getUserSyncs({iframeEnabled: true, pixelEnabled: false}, [bidderResponse]); + const opts = spec.getUserSyncs({iframeEnabled: true, pixelEnabled: false}, [bidderResponse]); expect(opts.length).to.equal(1); expect(opts[0].type).to.equal('iframe'); @@ -633,7 +633,7 @@ describe('dxkultureBidAdapter', function() { }); it('pixel sync enabled should return results', function () { - let opts = spec.getUserSyncs({iframeEnabled: false, pixelEnabled: true}, [bidderResponse]); + const opts = spec.getUserSyncs({iframeEnabled: false, pixelEnabled: true}, [bidderResponse]); expect(opts.length).to.equal(1); expect(opts[0].type).to.equal('image'); @@ -641,7 +641,7 @@ describe('dxkultureBidAdapter', function() { }); it('all sync enabled should prioritize iframe', function () { - let opts = spec.getUserSyncs({iframeEnabled: true, pixelEnabled: true}, [bidderResponse]); + const opts = spec.getUserSyncs({iframeEnabled: true, pixelEnabled: true}, [bidderResponse]); expect(opts.length).to.equal(1); }); diff --git a/test/spec/modules/e_volutionBidAdapter_spec.js b/test/spec/modules/e_volutionBidAdapter_spec.js index 4a97988b128..041c7770989 100644 --- a/test/spec/modules/e_volutionBidAdapter_spec.js +++ b/test/spec/modules/e_volutionBidAdapter_spec.js @@ -132,7 +132,7 @@ describe('EvolutionTechBidAdapter', function () { }); it('Returns general data valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys('deviceWidth', 'deviceHeight', @@ -212,7 +212,7 @@ describe('EvolutionTechBidAdapter', function () { } ]; - let serverRequest = spec.buildRequests(bids, bidderRequest); + const serverRequest = spec.buildRequests(bids, bidderRequest); const { placements } = serverRequest.data; for (let i = 0, len = placements.length; i < len; i++) { @@ -247,7 +247,7 @@ describe('EvolutionTechBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { delete bidderRequest.uspConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('object'); expect(data.gdpr).to.have.property('consentString'); @@ -261,7 +261,7 @@ describe('EvolutionTechBidAdapter', function () { bidderRequest.uspConsent = '1---'; delete bidderRequest.gdprConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -276,8 +276,8 @@ describe('EvolutionTechBidAdapter', function () { applicableSections: [8] }; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -291,8 +291,8 @@ describe('EvolutionTechBidAdapter', function () { bidderRequest.ortb2.regs.gpp = 'abc123'; bidderRequest.ortb2.regs.gpp_sid = [8]; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -322,9 +322,9 @@ describe('EvolutionTechBidAdapter', function () { } }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(banner.body[0].requestId); @@ -356,10 +356,10 @@ describe('EvolutionTechBidAdapter', function () { } }] }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -393,10 +393,10 @@ describe('EvolutionTechBidAdapter', function () { } }] }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys('requestId', 'cpm', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'native', 'meta'); expect(dataItem.native).to.have.keys('clickUrl', 'impressionTrackers', 'title', 'image') expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -427,7 +427,7 @@ describe('EvolutionTechBidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -443,7 +443,7 @@ describe('EvolutionTechBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -460,7 +460,7 @@ describe('EvolutionTechBidAdapter', function () { currency: 'USD', }] }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -473,7 +473,7 @@ describe('EvolutionTechBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/edge226BidAdapter_spec.js b/test/spec/modules/edge226BidAdapter_spec.js index b1cf07d5bed..264253e3d03 100644 --- a/test/spec/modules/edge226BidAdapter_spec.js +++ b/test/spec/modules/edge226BidAdapter_spec.js @@ -132,7 +132,7 @@ describe('Edge226BidAdapter', function () { }); it('Returns general data valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys( 'device', @@ -213,7 +213,7 @@ describe('Edge226BidAdapter', function () { } ]; - let serverRequest = spec.buildRequests(bids, bidderRequest); + const serverRequest = spec.buildRequests(bids, bidderRequest); const { placements } = serverRequest.data; for (let i = 0, len = placements.length; i < len; i++) { @@ -248,7 +248,7 @@ describe('Edge226BidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { delete bidderRequest.uspConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('object'); expect(data.gdpr).to.have.property('consentString'); @@ -262,7 +262,7 @@ describe('Edge226BidAdapter', function () { bidderRequest.uspConsent = '1---'; delete bidderRequest.gdprConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -277,8 +277,8 @@ describe('Edge226BidAdapter', function () { applicableSections: [8] }; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -292,8 +292,8 @@ describe('Edge226BidAdapter', function () { bidderRequest.ortb2.regs.gpp = 'abc123'; bidderRequest.ortb2.regs.gpp_sid = [8]; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -323,9 +323,9 @@ describe('Edge226BidAdapter', function () { } }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(banner.body[0].requestId); @@ -357,10 +357,10 @@ describe('Edge226BidAdapter', function () { } }] }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -394,10 +394,10 @@ describe('Edge226BidAdapter', function () { } }] }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys('requestId', 'cpm', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'native', 'meta'); expect(dataItem.native).to.have.keys('clickUrl', 'impressionTrackers', 'title', 'image') expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -428,7 +428,7 @@ describe('Edge226BidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -444,7 +444,7 @@ describe('Edge226BidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -461,7 +461,7 @@ describe('Edge226BidAdapter', function () { currency: 'USD', }] }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -474,7 +474,7 @@ describe('Edge226BidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/ehealthcaresolutionsBidAdapter_spec.js b/test/spec/modules/ehealthcaresolutionsBidAdapter_spec.js index c420c387598..5cce69dac09 100644 --- a/test/spec/modules/ehealthcaresolutionsBidAdapter_spec.js +++ b/test/spec/modules/ehealthcaresolutionsBidAdapter_spec.js @@ -141,7 +141,7 @@ describe('ehealthcaresolutions adapter', function () { describe('validations', function () { it('isBidValid : placement_id is passed', function () { - let bid = { + const bid = { bidder: 'ehealthcaresolutions', params: { placement_id: 111520 @@ -151,7 +151,7 @@ describe('ehealthcaresolutions adapter', function () { expect(isValid).to.equals(true); }); it('isBidValid : placement_id is not passed', function () { - let bid = { + const bid = { bidder: 'ehealthcaresolutions', params: { width: 300, @@ -166,42 +166,42 @@ describe('ehealthcaresolutions adapter', function () { }); describe('Validate Banner Request', function () { it('Immutable bid request validate', function () { - let _Request = utils.deepClone(bannerRequest), + const _Request = utils.deepClone(bannerRequest), bidRequest = spec.buildRequests(bannerRequest); expect(bannerRequest).to.deep.equal(_Request); }); it('Validate bidder connection', function () { - let _Request = spec.buildRequests(bannerRequest); + const _Request = spec.buildRequests(bannerRequest); expect(_Request.url).to.equal('https://rtb.ehealthcaresolutions.com/hb'); expect(_Request.method).to.equal('POST'); expect(_Request.options.contentType).to.equal('application/json'); }); it('Validate bid request : Impression', function () { - let _Request = spec.buildRequests(bannerRequest); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(bannerRequest); + const data = JSON.parse(_Request.data); // expect(data.at).to.equal(1); // auction type expect(data[0].imp[0].id).to.equal(bannerRequest[0].bidId); expect(data[0].placementId).to.equal(111520); }); it('Validate bid request : ad size', function () { - let _Request = spec.buildRequests(bannerRequest); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(bannerRequest); + const data = JSON.parse(_Request.data); expect(data[0].imp[0].banner).to.be.a('object'); expect(data[0].imp[0].banner.w).to.equal(300); expect(data[0].imp[0].banner.h).to.equal(250); }); it('Validate bid request : user object', function () { - let _Request = spec.buildRequests(bannerRequest); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(bannerRequest); + const data = JSON.parse(_Request.data); expect(data[0].user).to.be.a('object'); expect(data[0].user.id).to.be.a('string'); }); it('Validate bid request : CCPA Check', function () { - let bidRequest = { + const bidRequest = { uspConsent: '1NYN' }; - let _Request = spec.buildRequests(bannerRequest, bidRequest); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(bannerRequest, bidRequest); + const data = JSON.parse(_Request.data); expect(data[0].regs.ext.us_privacy).to.equal('1NYN'); // let _bidRequest = {}; // let _Request1 = spec.buildRequests(request, _bidRequest); @@ -211,8 +211,8 @@ describe('ehealthcaresolutions adapter', function () { }); describe('Validate banner response ', function () { it('Validate bid response : valid bid response', function () { - let _Request = spec.buildRequests(bannerRequest); - let bResponse = spec.interpretResponse(bannerResponse, _Request); + const _Request = spec.buildRequests(bannerRequest); + const bResponse = spec.interpretResponse(bannerResponse, _Request); expect(bResponse).to.be.an('array').with.length.above(0); expect(bResponse[0].requestId).to.equal(bannerResponse.body.seatbid[0].bid[0].impid); expect(bResponse[0].width).to.equal(bannerResponse.body.seatbid[0].bid[0].w); @@ -226,42 +226,42 @@ describe('ehealthcaresolutions adapter', function () { expect(bResponse[0].dealId).to.equal(bannerResponse.body.seatbid[0].bid[0].dealId); }); it('Invalid bid response check ', function () { - let bRequest = spec.buildRequests(bannerRequest); - let response = spec.interpretResponse(invalidBannerResponse, bRequest); + const bRequest = spec.buildRequests(bannerRequest); + const response = spec.interpretResponse(invalidBannerResponse, bRequest); expect(response[0].ad).to.equal('invalid response'); }); }); describe('Validate Native Request', function () { it('Immutable bid request validate', function () { - let _Request = utils.deepClone(nativeRequest), + const _Request = utils.deepClone(nativeRequest), bidRequest = spec.buildRequests(nativeRequest); expect(nativeRequest).to.deep.equal(_Request); }); it('Validate bidder connection', function () { - let _Request = spec.buildRequests(nativeRequest); + const _Request = spec.buildRequests(nativeRequest); expect(_Request.url).to.equal('https://rtb.ehealthcaresolutions.com/hb'); expect(_Request.method).to.equal('POST'); expect(_Request.options.contentType).to.equal('application/json'); }); it('Validate bid request : Impression', function () { - let _Request = spec.buildRequests(nativeRequest); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(nativeRequest); + const data = JSON.parse(_Request.data); // expect(data.at).to.equal(1); // auction type expect(data[0].imp[0].id).to.equal(nativeRequest[0].bidId); expect(data[0].placementId).to.equal(111519); }); it('Validate bid request : user object', function () { - let _Request = spec.buildRequests(nativeRequest); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(nativeRequest); + const data = JSON.parse(_Request.data); expect(data[0].user).to.be.a('object'); expect(data[0].user.id).to.be.a('string'); }); it('Validate bid request : CCPA Check', function () { - let bidRequest = { + const bidRequest = { uspConsent: '1NYN' }; - let _Request = spec.buildRequests(nativeRequest, bidRequest); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(nativeRequest, bidRequest); + const data = JSON.parse(_Request.data); expect(data[0].regs.ext.us_privacy).to.equal('1NYN'); // let _bidRequest = {}; // let _Request1 = spec.buildRequests(request, _bidRequest); @@ -271,8 +271,8 @@ describe('ehealthcaresolutions adapter', function () { }); describe('Validate native response ', function () { it('Validate bid response : valid bid response', function () { - let _Request = spec.buildRequests(nativeRequest); - let bResponse = spec.interpretResponse(nativeResponse, _Request); + const _Request = spec.buildRequests(nativeRequest); + const bResponse = spec.interpretResponse(nativeResponse, _Request); expect(bResponse).to.be.an('array').with.length.above(0); expect(bResponse[0].requestId).to.equal(nativeResponse.body.seatbid[0].bid[0].impid); // expect(bResponse[0].width).to.equal(bannerResponse.body.seatbid[0].bid[0].w); @@ -292,14 +292,14 @@ describe('ehealthcaresolutions adapter', function () { }); describe('GPP and coppa', function () { it('Request params check with GPP Consent', function () { - let bidderReq = { gppConsent: { gppString: 'gpp-string-test', applicableSections: [5] } }; - let _Request = spec.buildRequests(bannerRequest, bidderReq); - let data = JSON.parse(_Request.data); + const bidderReq = { gppConsent: { gppString: 'gpp-string-test', applicableSections: [5] } }; + const _Request = spec.buildRequests(bannerRequest, bidderReq); + const data = JSON.parse(_Request.data); expect(data[0].regs.gpp).to.equal('gpp-string-test'); expect(data[0].regs.gpp_sid[0]).to.equal(5); }); it('Request params check with GPP Consent read from ortb2', function () { - let bidderReq = { + const bidderReq = { ortb2: { regs: { gpp: 'gpp-test-string', @@ -307,15 +307,15 @@ describe('ehealthcaresolutions adapter', function () { } } }; - let _Request = spec.buildRequests(bannerRequest, bidderReq); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(bannerRequest, bidderReq); + const data = JSON.parse(_Request.data); expect(data[0].regs.gpp).to.equal('gpp-test-string'); expect(data[0].regs.gpp_sid[0]).to.equal(5); }); it(' Bid request should have coppa flag if its true', () => { - let bidderReq = { ortb2: { regs: { coppa: 1 } } }; - let _Request = spec.buildRequests(bannerRequest, bidderReq); - let data = JSON.parse(_Request.data); + const bidderReq = { ortb2: { regs: { coppa: 1 } } }; + const _Request = spec.buildRequests(bannerRequest, bidderReq); + const data = JSON.parse(_Request.data); expect(data[0].regs.coppa).to.equal(1); }); }); diff --git a/test/spec/modules/eids_spec.js b/test/spec/modules/eids_spec.js index 30bfabb6f50..17d2b5161b0 100644 --- a/test/spec/modules/eids_spec.js +++ b/test/spec/modules/eids_spec.js @@ -50,7 +50,7 @@ describe('Negative case', function () { it('eids array generation for known sub-module with non-string value', function () { // pubCommonId - let userId = { + const userId = { pubcid: undefined }; let newEids = createEidsArray(userId); diff --git a/test/spec/modules/eightPodAnalyticsAdapter_spec.js b/test/spec/modules/eightPodAnalyticsAdapter_spec.js index 878f159cb5c..3f798344d0d 100644 --- a/test/spec/modules/eightPodAnalyticsAdapter_spec.js +++ b/test/spec/modules/eightPodAnalyticsAdapter_spec.js @@ -1,8 +1,8 @@ import analyticsAdapter, { storage, queue, trackEvent } from 'modules/eightPodAnalyticsAdapter.js'; import { expect } from 'chai'; import adapterManager from 'src/adapterManager.js'; -import eightPodAnalytics from 'modules/eightPodAnalyticsAdapter.js'; import { EVENTS } from '../../../src/constants.js'; +const eightPodAnalytics = analyticsAdapter; const { BID_WON diff --git a/test/spec/modules/emtvBidAdapter_spec.js b/test/spec/modules/emtvBidAdapter_spec.js index e68a65a04d6..7a20bf3d670 100644 --- a/test/spec/modules/emtvBidAdapter_spec.js +++ b/test/spec/modules/emtvBidAdapter_spec.js @@ -134,7 +134,7 @@ describe('EMTVBidAdapter', function () { }); it('Returns general data valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys('deviceWidth', 'deviceHeight', @@ -214,7 +214,7 @@ describe('EMTVBidAdapter', function () { } ]; - let serverRequest = spec.buildRequests(bids, bidderRequest); + const serverRequest = spec.buildRequests(bids, bidderRequest); const { placements } = serverRequest.data; for (let i = 0, len = placements.length; i < len; i++) { @@ -249,7 +249,7 @@ describe('EMTVBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { delete bidderRequest.uspConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('object'); expect(data.gdpr).to.have.property('consentString'); @@ -263,7 +263,7 @@ describe('EMTVBidAdapter', function () { bidderRequest.uspConsent = '1---'; delete bidderRequest.gdprConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -278,8 +278,8 @@ describe('EMTVBidAdapter', function () { applicableSections: [8] }; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -293,8 +293,8 @@ describe('EMTVBidAdapter', function () { bidderRequest.ortb2.regs.gpp = 'abc123'; bidderRequest.ortb2.regs.gpp_sid = [8]; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -324,9 +324,9 @@ describe('EMTVBidAdapter', function () { } }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(banner.body[0].requestId); @@ -358,10 +358,10 @@ describe('EMTVBidAdapter', function () { } }] }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -395,10 +395,10 @@ describe('EMTVBidAdapter', function () { } }] }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys('requestId', 'cpm', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'native', 'meta'); expect(dataItem.native).to.have.keys('clickUrl', 'impressionTrackers', 'title', 'image') expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -429,7 +429,7 @@ describe('EMTVBidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -445,7 +445,7 @@ describe('EMTVBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -462,7 +462,7 @@ describe('EMTVBidAdapter', function () { currency: 'USD', }] }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -475,7 +475,7 @@ describe('EMTVBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/engageyaBidAdapter_spec.js b/test/spec/modules/engageyaBidAdapter_spec.js index 283f0148402..79188dcad5c 100644 --- a/test/spec/modules/engageyaBidAdapter_spec.js +++ b/test/spec/modules/engageyaBidAdapter_spec.js @@ -149,7 +149,7 @@ describe('Engageya adapter', function () { describe('isBidRequestValid', function () { it('Valid bid case', function () { - let validBid = { + const validBid = { bidder: 'engageya', params: { widgetId: 85610, @@ -158,21 +158,21 @@ describe('Engageya adapter', function () { }, sizes: [[300, 250]] } - let isValid = spec.isBidRequestValid(validBid); + const isValid = spec.isBidRequestValid(validBid); expect(isValid).to.be.true; }); it('Invalid bid case: widgetId and websiteId is not passed', function () { - let validBid = { + const validBid = { bidder: 'engageya', params: {} } - let isValid = spec.isBidRequestValid(validBid); + const isValid = spec.isBidRequestValid(validBid); expect(isValid).to.be.false; }) it('Invalid bid case: widget id must be number', function () { - let invalidBid = { + const invalidBid = { bidder: 'engageya', params: { widgetId: '157746a', @@ -181,12 +181,12 @@ describe('Engageya adapter', function () { }, sizes: [[300, 250]] } - let isValid = spec.isBidRequestValid(invalidBid); + const isValid = spec.isBidRequestValid(invalidBid); expect(isValid).to.be.false; }) it('Invalid bid case: unsupported sizes', function () { - let invalidBid = { + const invalidBid = { bidder: 'engageya', params: { widgetId: '157746a', @@ -195,7 +195,7 @@ describe('Engageya adapter', function () { }, sizes: [[250, 250]] } - let isValid = spec.isBidRequestValid(invalidBid); + const isValid = spec.isBidRequestValid(invalidBid); expect(isValid).to.be.false; }) }) @@ -208,19 +208,19 @@ describe('Engageya adapter', function () { }); it('buildRequests function should not modify original bidRequests object', function () { - let originalBidRequests = utils.deepClone(bidRequests); - let request = spec.buildRequests(bidRequests); + const originalBidRequests = utils.deepClone(bidRequests); + const request = spec.buildRequests(bidRequests); expect(bidRequests).to.deep.equal(originalBidRequests); }); it('buildRequests function should not modify original nativeBidRequests object', function () { - let originalBidRequests = utils.deepClone(nativeBidRequests); - let request = spec.buildRequests(nativeBidRequests); + const originalBidRequests = utils.deepClone(nativeBidRequests); + const request = spec.buildRequests(nativeBidRequests); expect(nativeBidRequests).to.deep.equal(originalBidRequests); }); it('Request params check', function () { - let request = spec.buildRequests(bidRequests)[0]; + const request = spec.buildRequests(bidRequests)[0]; const urlParams = new URL(request.url).searchParams; expect(parseInt(urlParams.get('wid'))).to.exist.and.to.equal(bidRequests[0].params.widgetId); expect(parseInt(urlParams.get('webid'))).to.exist.and.to.equal(bidRequests[0].params.websiteId); @@ -284,7 +284,7 @@ describe('Engageya adapter', function () { }); it('should return empty array if no valid bids', function () { - let response = { + const response = { recs: [], imageWidth: 300, imageHeight: 250, @@ -292,13 +292,13 @@ describe('Engageya adapter', function () { pbtypeId: 2, viewPxl: '//view.pixel', }; - let request = spec.buildRequests(bidRequests)[0]; + const request = spec.buildRequests(bidRequests)[0]; const result = spec.interpretResponse({ body: response }, request) expect(result).to.be.an('array').that.is.empty }); it('should interpret native response', function () { - let expectedResult = [ + const expectedResult = [ { requestId: '1d236f7890b', cpm: 0.0520, @@ -328,14 +328,14 @@ describe('Engageya adapter', function () { }, } ]; - let request = spec.buildRequests(bidRequests)[0]; - let result = spec.interpretResponse({ body: nativeResponse }, request); + const request = spec.buildRequests(bidRequests)[0]; + const result = spec.interpretResponse({ body: nativeResponse }, request); expect(result).to.deep.equal(expectedResult); }); it('should interpret native response - without pecpm', function () { delete nativeResponse.recs[0].pecpm; - let expectedResult = [ + const expectedResult = [ { requestId: '1d236f7890b', cpm: 0.0920, @@ -365,14 +365,14 @@ describe('Engageya adapter', function () { }, } ]; - let request = spec.buildRequests(bidRequests)[0]; - let result = spec.interpretResponse({ body: nativeResponse }, request); + const request = spec.buildRequests(bidRequests)[0]; + const result = spec.interpretResponse({ body: nativeResponse }, request); expect(result).to.deep.equal(expectedResult); }); it('should interpret native response - without trackers', function () { delete nativeResponse.recs[0].trackers; - let expectedResult = [ + const expectedResult = [ { requestId: '1d236f7890b', cpm: 0.0520, @@ -402,13 +402,13 @@ describe('Engageya adapter', function () { }, } ]; - let request = spec.buildRequests(bidRequests)[0]; - let result = spec.interpretResponse({ body: nativeResponse }, request); + const request = spec.buildRequests(bidRequests)[0]; + const result = spec.interpretResponse({ body: nativeResponse }, request); expect(result).to.deep.equal(expectedResult); }); it('should interpret display response', function () { - let expectedResult = [ + const expectedResult = [ { requestId: '1d236f7890b', cpm: 0.0520, @@ -424,14 +424,14 @@ describe('Engageya adapter', function () { ad: ``, } ]; - let request = spec.buildRequests(bidRequests)[0]; - let result = spec.interpretResponse({ body: bannerResponse }, request); + const request = spec.buildRequests(bidRequests)[0]; + const result = spec.interpretResponse({ body: bannerResponse }, request); expect(result).to.deep.equal(expectedResult); }); it('should interpret display response - without pecpm', function () { delete bannerResponse.recs[0].pecpm; - let expectedResult = [ + const expectedResult = [ { requestId: '1d236f7890b', cpm: 0.0920, @@ -447,14 +447,14 @@ describe('Engageya adapter', function () { ad: ``, } ]; - let request = spec.buildRequests(bidRequests)[0]; - let result = spec.interpretResponse({ body: bannerResponse }, request); + const request = spec.buildRequests(bidRequests)[0]; + const result = spec.interpretResponse({ body: bannerResponse }, request); expect(result).to.deep.equal(expectedResult); }); it('should interpret display response - without title', function () { bannerResponse.recs[0].title = ' '; - let expectedResult = [ + const expectedResult = [ { requestId: '1d236f7890b', cpm: 0.0520, @@ -470,14 +470,14 @@ describe('Engageya adapter', function () { ad: `
`, } ]; - let request = spec.buildRequests(bidRequests)[0]; - let result = spec.interpretResponse({ body: bannerResponse }, request); + const request = spec.buildRequests(bidRequests)[0]; + const result = spec.interpretResponse({ body: bannerResponse }, request); expect(result).to.deep.equal(expectedResult); }); it('should interpret display response - without widget additional data', function () { bannerResponse.widget.additionalData = null; - let expectedResult = [ + const expectedResult = [ { requestId: '1d236f7890b', cpm: 0.0520, @@ -493,14 +493,14 @@ describe('Engageya adapter', function () { ad: ``, } ]; - let request = spec.buildRequests(bidRequests)[0]; - let result = spec.interpretResponse({ body: bannerResponse }, request); + const request = spec.buildRequests(bidRequests)[0]; + const result = spec.interpretResponse({ body: bannerResponse }, request); expect(result).to.deep.equal(expectedResult); }); it('should interpret display response - without trackers', function () { bannerResponse.recs[0].trackers = null; - let expectedResult = [ + const expectedResult = [ { requestId: '1d236f7890b', cpm: 0.0520, @@ -516,8 +516,8 @@ describe('Engageya adapter', function () { ad: ``, } ]; - let request = spec.buildRequests(bidRequests)[0]; - let result = spec.interpretResponse({ body: bannerResponse }, request); + const request = spec.buildRequests(bidRequests)[0]; + const result = spec.interpretResponse({ body: bannerResponse }, request); expect(result).to.deep.equal(expectedResult); }); }) diff --git a/test/spec/modules/enrichmentLiftMeasurement_spec.js b/test/spec/modules/enrichmentLiftMeasurement_spec.js index 18fac401c08..032cd85fd9d 100644 --- a/test/spec/modules/enrichmentLiftMeasurement_spec.js +++ b/test/spec/modules/enrichmentLiftMeasurement_spec.js @@ -1,5 +1,5 @@ import { expect } from "chai"; -import { getCalculatedSubmodules, internals, init, reset, storeSplitsMethod, storeTestConfig, suppressionMethod, getStoredTestConfig } from "../../../modules/enrichmentLiftMeasurement"; +import { getCalculatedSubmodules, internals, init, reset, storeSplitsMethod, storeTestConfig, suppressionMethod, getStoredTestConfig, compareConfigs, STORAGE_KEY } from "../../../modules/enrichmentLiftMeasurement"; import {server} from 'test/mocks/xhr.js'; import { config } from "../../../src/config" import { isInteger } from "../../../src/utils"; @@ -11,8 +11,6 @@ import { disableAjaxForAnalytics, enableAjaxForAnalytics } from "../../mocks/ana import AnalyticsAdapter from "../../../libraries/analyticsAdapter/AnalyticsAdapter"; import { EVENTS } from "../../../src/constants"; import { getCoreStorageManager } from "../../../src/storageManager"; -import { compareConfigs } from "../../../modules/enrichmentLiftMeasurement"; -import { STORAGE_KEY } from "../../../modules/enrichmentLiftMeasurement"; describe('enrichmentLiftMeasurement', () => { beforeEach(() => { diff --git a/test/spec/modules/eplanningBidAdapter_spec.js b/test/spec/modules/eplanningBidAdapter_spec.js index fbd2970462d..31e9d8e5d05 100644 --- a/test/spec/modules/eplanningBidAdapter_spec.js +++ b/test/spec/modules/eplanningBidAdapter_spec.js @@ -636,7 +636,7 @@ describe('E-Planning Adapter', function () { }); describe('buildRequests', function () { - let bidRequests = [validBid]; + const bidRequests = [validBid]; let sandbox; let getWindowTopStub; let innerWidth; @@ -688,13 +688,13 @@ describe('E-Planning Adapter', function () { }); it('should return e parameter with linear mapping attribute with value according to the adunit sizes', function () { - let bidRequestsML = [validBidMappingLinear]; + const bidRequestsML = [validBidMappingLinear]; const e = spec.buildRequests(bidRequestsML, bidderRequest).data.e; expect(e).to.equal(CLEAN_ADUNIT_CODE_ML + ':300x250,300x600'); }); it('should return e parameter with space name attribute with value according to the adunit sizes', function () { - let bidRequestsSN = [validBidSpaceName]; + const bidRequestsSN = [validBidSpaceName]; const e = spec.buildRequests(bidRequestsSN, bidderRequest).data.e; expect(e).to.equal(SN + ':300x250,300x600'); }); @@ -712,7 +712,7 @@ describe('E-Planning Adapter', function () { }); it('should return correct e parameter with support vast with one space with size instream with bidFloor', function () { - let bidRequests = [validBidSpaceInstreamWithBidFloor]; + const bidRequests = [validBidSpaceInstreamWithBidFloor]; const data = spec.buildRequests(bidRequests, bidderRequest).data; expect(data.e).to.equal('video_640x480_0:640x480;1|' + validBidSpaceInstreamWithBidFloor.getFloor().floor); expect(data.vctx).to.equal(1); @@ -737,7 +737,7 @@ describe('E-Planning Adapter', function () { }); it('should return correct e parameter with support vast with one space with size outstream', function () { - let bidRequests = [validBidSpaceOutstream]; + const bidRequests = [validBidSpaceOutstream]; const data = spec.buildRequests(bidRequests, bidderRequest).data; expect(data.e).to.equal('video_300x600_0:300x600;1'); expect(data.vctx).to.equal(2); @@ -745,7 +745,7 @@ describe('E-Planning Adapter', function () { }); it('should correctly return the e parameter with n sizes in playerSize', function () { - let bidRequests = [validBidOutstreamNSizes]; + const bidRequests = [validBidOutstreamNSizes]; const data = spec.buildRequests(bidRequests, bidderRequest).data; expect(data.e).to.equal('video_300x600_0:300x600;1'); expect(data.vctx).to.equal(2); @@ -753,7 +753,7 @@ describe('E-Planning Adapter', function () { }); it('should correctly return the e parameter with invalid sizes in playerSize', function () { - let bidRequests = [bidOutstreamInvalidSizes]; + const bidRequests = [bidOutstreamInvalidSizes]; const data = spec.buildRequests(bidRequests, bidderRequest).data; expect(data.e).to.equal('video_' + DEFAULT_SIZE_VAST + '_0:' + DEFAULT_SIZE_VAST + ';1'); expect(data.vctx).to.equal(2); @@ -761,7 +761,7 @@ describe('E-Planning Adapter', function () { }); it('should return correct e parameter with support vast with one space with size default outstream', function () { - let bidRequests = [validBidOutstreamNoSize]; + const bidRequests = [validBidOutstreamNoSize]; const data = spec.buildRequests(bidRequests, bidderRequest).data; expect(data.e).to.equal('video_640x480_0:640x480;1'); expect(data.vctx).to.equal(2); @@ -769,7 +769,7 @@ describe('E-Planning Adapter', function () { }); it('should return correct e parameter with support vast with one space with size instream', function () { - let bidRequests = [validBidSpaceInstream]; + const bidRequests = [validBidSpaceInstream]; const data = spec.buildRequests(bidRequests, bidderRequest).data; expect(data.e).to.equal('video_640x480_0:640x480;1'); expect(data.vctx).to.equal(1); @@ -777,7 +777,7 @@ describe('E-Planning Adapter', function () { }); it('should return correct e parameter with support vast with one space with size default and vctx default', function () { - let bidRequests = [validBidSpaceVastNoContext]; + const bidRequests = [validBidSpaceVastNoContext]; const data = spec.buildRequests(bidRequests, bidderRequest).data; expect(data.e).to.equal('video_640x480_0:640x480;1'); expect(data.vctx).to.equal(1); @@ -785,14 +785,14 @@ describe('E-Planning Adapter', function () { }); it('if 2 bids arrive, one outstream and the other instream, instream has more priority', function () { - let bidRequests = [validBidSpaceOutstream, validBidSpaceInstream]; + const bidRequests = [validBidSpaceOutstream, validBidSpaceInstream]; const data = spec.buildRequests(bidRequests, bidderRequest).data; expect(data.e).to.equal('video_640x480_0:640x480;1'); expect(data.vctx).to.equal(1); expect(data.vv).to.equal(3); }); it('if 2 bids arrive, one outstream and another banner, outstream has more priority', function () { - let bidRequests = [validBidSpaceOutstream, validBidSpaceName]; + const bidRequests = [validBidSpaceOutstream, validBidSpaceName]; const data = spec.buildRequests(bidRequests, bidderRequest).data; expect(data.e).to.equal('video_300x600_0:300x600;1'); expect(data.vctx).to.equal(2); @@ -800,7 +800,7 @@ describe('E-Planning Adapter', function () { }); it('should return correct e parameter with support vast with one space outstream', function () { - let bidRequests = [validBidSpaceOutstream, validBidOutstreamNoSize]; + const bidRequests = [validBidSpaceOutstream, validBidOutstreamNoSize]; const data = spec.buildRequests(bidRequests, bidderRequest).data; expect(data.e).to.equal('video_300x600_0:300x600;1+video_640x480_1:640x480;1'); expect(data.vctx).to.equal(2); @@ -814,12 +814,12 @@ describe('E-Planning Adapter', function () { expect(data.sch).to.deep.equal(schainExpected); }); it('should not return sch parameter', function () { - let bidRequests = [validBidWithSchainNodes]; + const bidRequests = [validBidWithSchainNodes]; const data = spec.buildRequests(bidRequests, bidderRequest).data; expect(data.sch).to.equal(undefined); }); it('should return correct e parameter with linear mapping attribute with more than one adunit', function () { - let bidRequestsML = [validBidMappingLinear]; + const bidRequestsML = [validBidMappingLinear]; const NEW_CODE = ADUNIT_CODE + '2'; const CLEAN_NEW_CODE = CLEAN_ADUNIT_CODE_ML + '2'; const anotherBid = { @@ -838,7 +838,7 @@ describe('E-Planning Adapter', function () { }); it('should return correct e parameter with space name attribute with more than one adunit', function () { - let bidRequestsSN = [validBidSpaceName]; + const bidRequestsSN = [validBidSpaceName]; const NEW_SN = 'anotherNameSpace'; const anotherBid = { 'bidder': 'eplanning', @@ -887,7 +887,7 @@ describe('E-Planning Adapter', function () { }); it('should return ur parameter without params query string when current window url length is greater than 255', function () { - let bidderRequestParams = bidderRequest; + const bidderRequestParams = bidderRequest; bidderRequestParams.refererInfo.page = refererUrl + '?param=' + 'x'.repeat(255); const ur = spec.buildRequests(bidRequests, bidderRequest).data.ur; @@ -895,9 +895,9 @@ describe('E-Planning Adapter', function () { }); it('should return ur parameter with a length of 255 when url length is greater than 255', function () { - let bidderRequestParams = bidderRequest; - let url_255_characters = 'https://localhost/abc' + '/subse'.repeat(39); - let refererUrl = url_255_characters + '/ext'.repeat(5) + '?param=' + 'x'.repeat(15); + const bidderRequestParams = bidderRequest; + const url_255_characters = 'https://localhost/abc' + '/subse'.repeat(39); + const refererUrl = url_255_characters + '/ext'.repeat(5) + '?param=' + 'x'.repeat(15); bidderRequestParams.refererInfo.page = refererUrl; const ur = spec.buildRequests(bidRequests, bidderRequest).data.ur; @@ -910,7 +910,7 @@ describe('E-Planning Adapter', function () { expect(dataRequest.fr).to.equal(refererUrl); }); it('should return fr parameter without params query string when ref length is greater than 255', function () { - let bidderRequestParams = bidderRequest; + const bidderRequestParams = bidderRequest; bidderRequestParams.refererInfo.ref = refererUrl + '?param=' + 'x'.repeat(255); const fr = spec.buildRequests(bidRequests, bidderRequest).data.fr; @@ -918,9 +918,9 @@ describe('E-Planning Adapter', function () { }); it('should return fr parameter with a length of 255 when url length is greater than 255', function () { - let bidderRequestParams = bidderRequest; - let url_255_characters = 'https://localhost/abc' + '/subse'.repeat(39); - let refererUrl = url_255_characters + '/ext'.repeat(5) + '?param=' + 'x'.repeat(15); + const bidderRequestParams = bidderRequest; + const url_255_characters = 'https://localhost/abc' + '/subse'.repeat(39); + const refererUrl = url_255_characters + '/ext'.repeat(5) + '?param=' + 'x'.repeat(15); bidderRequestParams.refererInfo.ref = refererUrl; const fr = spec.buildRequests(bidRequests, bidderRequest).data.fr; @@ -965,13 +965,13 @@ describe('E-Planning Adapter', function () { }); it('should return the e parameter with a value according to the sizes in order corresponding to the mobile priority list of the ad units', function () { - let bidRequestsPrioritySizes = [validBidExistingSizesInPriorityListForMobile]; + const bidRequestsPrioritySizes = [validBidExistingSizesInPriorityListForMobile]; const e = spec.buildRequests(bidRequestsPrioritySizes, bidderRequest).data.e; expect(e).to.equal('320x50_0:320x50,300x50,970x250'); }); it('should return the e parameter with a value according to the sizes in order corresponding to the desktop priority list of the ad units', function () { - let bidRequestsPrioritySizes = [validBidExistingSizesInPriorityListForDesktop]; + const bidRequestsPrioritySizes = [validBidExistingSizesInPriorityListForDesktop]; // overwrite default innerWdith for tests with a larger one we consider "Desktop" or NOT Mobile getWindowTopStub.returns(createWindow(1025)); resetWinDimensions(); @@ -980,7 +980,7 @@ describe('E-Planning Adapter', function () { }); it('should return the e parameter with a value according to the sizes in order as they are sent from the ad units', function () { - let bidRequestsPrioritySizes2 = [validBidSizesNotExistingInPriorityListForMobile]; + const bidRequestsPrioritySizes2 = [validBidSizesNotExistingInPriorityListForMobile]; const e = spec.buildRequests(bidRequestsPrioritySizes2, bidderRequest).data.e; expect(e).to.equal('970x250_0:970x250,300x70,160x600'); }); @@ -1116,22 +1116,22 @@ describe('E-Planning Adapter', function () { }); }); describe('viewability', function() { - let storageIdRender = 'pbsr_' + validBidView.adUnitCode; - let storageIdView = 'pbvi_' + validBidView.adUnitCode; - let bidRequests = [validBidView]; - let bidRequestMultiple = [validBidView, validBidView2, validBidView3]; + const storageIdRender = 'pbsr_' + validBidView.adUnitCode; + const storageIdView = 'pbvi_' + validBidView.adUnitCode; + const bidRequests = [validBidView]; + const bidRequestMultiple = [validBidView, validBidView2, validBidView3]; let getLocalStorageSpy; let setDataInLocalStorageSpy; let hasLocalStorageStub; let clock; let element; let getBoundingClientRectStub; - let sandbox = sinon.createSandbox(); + const sandbox = sinon.createSandbox(); let intersectionObserverStub; let intersectionCallback; function setIntersectionObserverMock(params) { - let fakeIntersectionObserver = (stateChange, options) => { + const fakeIntersectionObserver = (stateChange, options) => { intersectionCallback = stateChange; return { unobserve: (element) => { @@ -1507,7 +1507,7 @@ describe('E-Planning Adapter', function () { }) it('should add eids to the request', function() { - let bidRequests = [validBidView]; + const bidRequests = [validBidView]; const expected_id5id = encodeURIComponent(JSON.stringify({ uid: 'ID5-ZHMOL_IfFSt7_lVYX8rBZc6GH3XMWyPQOBUfr4bm0g!', ext: { linkType: 1 } })); const request = spec.buildRequests(bidRequests, bidderRequest); const dataRequest = request.data; diff --git a/test/spec/modules/escalaxBidAdapter_spec.js b/test/spec/modules/escalaxBidAdapter_spec.js index 3e539cc1bdc..8a441a04b0b 100644 --- a/test/spec/modules/escalaxBidAdapter_spec.js +++ b/test/spec/modules/escalaxBidAdapter_spec.js @@ -9,7 +9,7 @@ import 'src/prebid.js'; import 'modules/currency.js'; import 'modules/userId/index.js'; import 'modules/multibid/index.js'; -import 'modules/priceFloors.js'; + import 'modules/consentManagementTcf.js'; import 'modules/consentManagementUsp.js'; @@ -191,7 +191,7 @@ describe('escalaxAdapter', function () { }); it('should return false when sourceId/accountId is missing', function () { - let localbid = Object.assign({}, BANNER_BID_REQUEST); + const localbid = Object.assign({}, BANNER_BID_REQUEST); delete localbid.params.sourceId; delete localbid.params.accountId; expect(spec.isBidRequestValid(BANNER_BID_REQUEST)).to.equal(false); @@ -266,7 +266,7 @@ describe('escalaxAdapter', function () { it('Empty response must return empty array', function () { const emptyResponse = null; - let response = spec.interpretResponse(emptyResponse, BANNER_BID_REQUEST); + const response = spec.interpretResponse(emptyResponse, BANNER_BID_REQUEST); expect(response).to.be.an('array').that.is.empty; }) diff --git a/test/spec/modules/eskimiBidAdapter_spec.js b/test/spec/modules/eskimiBidAdapter_spec.js index a452f115767..a6c987aa72e 100644 --- a/test/spec/modules/eskimiBidAdapter_spec.js +++ b/test/spec/modules/eskimiBidAdapter_spec.js @@ -117,7 +117,7 @@ const VIDEO_BID_RESPONSE = { describe('Eskimi bid adapter', function () { describe('isBidRequestValid()', function () { it('should accept request if placementId is passed', function () { - let bid = { + const bid = { bidder: 'eskimi', params: { placementId: 123 @@ -132,7 +132,7 @@ describe('Eskimi bid adapter', function () { }); it('should reject requests without params', function () { - let bid = { + const bid = { bidder: 'eskimi', params: {} }; @@ -155,7 +155,7 @@ describe('Eskimi bid adapter', function () { gdprApplies: true, } }); - let request = spec.buildRequests([bid], req)[0]; + const request = spec.buildRequests([bid], req)[0]; const payload = request.data; expect(payload.user.ext).to.have.property('consent', req.gdprConsent.consentString); @@ -169,7 +169,7 @@ describe('Eskimi bid adapter', function () { mediaTypes: {banner: {battr: [1]}} }); - let [request] = spec.buildRequests([bid], BIDDER_REQUEST); + const [request] = spec.buildRequests([bid], BIDDER_REQUEST); expect(request).to.exist.and.to.be.an('object'); const payload = request.data; @@ -193,7 +193,7 @@ describe('Eskimi bid adapter', function () { it('should create request data', function () { const bid = utils.deepClone(BANNER_BID); - let [request] = spec.buildRequests([bid], BIDDER_REQUEST); + const [request] = spec.buildRequests([bid], BIDDER_REQUEST); expect(request).to.exist.and.to.be.a('object'); const payload = request.data; expect(payload.imp[0]).to.have.property('id', bid.bidId); @@ -273,7 +273,7 @@ describe('Eskimi bid adapter', function () { it('should handle empty bid response', function () { const bid = utils.deepClone(BANNER_BID); - let request = spec.buildRequests([bid], BIDDER_REQUEST)[0]; + const request = spec.buildRequests([bid], BIDDER_REQUEST)[0]; const EMPTY_RESP = Object.assign({}, BANNER_BID_RESPONSE, {'body': {}}); const bids = spec.interpretResponse(EMPTY_RESP, request); expect(bids).to.be.empty; diff --git a/test/spec/modules/etargetBidAdapter_spec.js b/test/spec/modules/etargetBidAdapter_spec.js index a950100d612..c00856d4f57 100644 --- a/test/spec/modules/etargetBidAdapter_spec.js +++ b/test/spec/modules/etargetBidAdapter_spec.js @@ -7,7 +7,7 @@ describe('etarget adapter', function () { let serverResponse, bidRequest, bidResponses; let bids = []; describe('isBidRequestValid', function () { - let bid = { + const bid = { 'bidder': 'etarget', 'params': { 'refid': '55410', @@ -22,30 +22,30 @@ describe('etarget adapter', function () { describe('buildRequests', function () { it('should pass multiple bids via single request', function () { - let request = spec.buildRequests(bids); - let parsedUrl = parseUrl(request.url); + const request = spec.buildRequests(bids); + const parsedUrl = parseUrl(request.url); assert.lengthOf(parsedUrl.items, 7); }); it('should be an object', function () { - let request = spec.buildRequests(bids); + const request = spec.buildRequests(bids); assert.isNotNull(request.metaData); }); it('should handle global request parameters', function () { - let parsedUrl = parseUrl(spec.buildRequests([bids[0]]).url); + const parsedUrl = parseUrl(spec.buildRequests([bids[0]]).url); assert.equal(parsedUrl.path, 'https://sk.search.etargetnet.com/hb'); }); it('should set correct request method', function () { - let request = spec.buildRequests([bids[0]]); + const request = spec.buildRequests([bids[0]]); assert.equal(request.method, 'POST'); }); it('should attach floor param when either bid param or getFloor function exists', function () { // let getFloorResponse = { currency: 'EUR', floor: 5 }; let request = null; - let bidRequest = deepClone(bids[0]); + const bidRequest = deepClone(bids[0]); // floor param has to be NULL request = spec.buildRequests([bidRequest]); @@ -53,9 +53,9 @@ describe('etarget adapter', function () { }); it('should correctly form bid items', function () { - let bidList = bids; - let request = spec.buildRequests(bidList); - let parsedUrl = parseUrl(request.url); + const bidList = bids; + const request = spec.buildRequests(bidList); + const parsedUrl = parseUrl(request.url); assert.deepEqual(parsedUrl.items, [ { refid: '1', @@ -105,24 +105,24 @@ describe('etarget adapter', function () { it('should not change original validBidRequests object', function () { var resultBids = JSON.parse(JSON.stringify(bids[0])); - let request = spec.buildRequests([bids[0]]); + const request = spec.buildRequests([bids[0]]); assert.deepEqual(resultBids, bids[0]); }); describe('gdpr', function () { it('should send GDPR Consent data to etarget if gdprApplies', function () { - let resultBids = JSON.parse(JSON.stringify(bids[0])); - let request = spec.buildRequests([bids[0]], {gdprConsent: {gdprApplies: true, consentString: 'concentDataString'}}); - let parsedUrl = parseUrl(request.url).query; + const resultBids = JSON.parse(JSON.stringify(bids[0])); + const request = spec.buildRequests([bids[0]], {gdprConsent: {gdprApplies: true, consentString: 'concentDataString'}}); + const parsedUrl = parseUrl(request.url).query; assert.equal(parsedUrl.gdpr, 'true'); assert.equal(parsedUrl.gdpr_consent, 'concentDataString'); }); it('should not send GDPR Consent data to etarget if gdprApplies is false or undefined', function () { - let resultBids = JSON.parse(JSON.stringify(bids[0])); + const resultBids = JSON.parse(JSON.stringify(bids[0])); let request = spec.buildRequests([bids[0]], {gdprConsent: {gdprApplies: false, consentString: 'concentDataString'}}); - let parsedUrl = parseUrl(request.url).query; + const parsedUrl = parseUrl(request.url).query; assert.ok(!parsedUrl.gdpr); assert.ok(!parsedUrl.gdpr_consent); @@ -148,21 +148,21 @@ describe('etarget adapter', function () { describe('interpretResponse', function () { it('should respond with empty response when there is empty serverResponse', function () { - let result = spec.interpretResponse({ body: {} }, {}); + const result = spec.interpretResponse({ body: {} }, {}); assert.deepEqual(result, []); }); it('should respond with empty response when response from server is not banner', function () { serverResponse.body[0].response = 'not banner'; serverResponse.body = [serverResponse.body[0]]; bidRequest.bids = [bidRequest.bids[0]]; - let result = spec.interpretResponse(serverResponse, bidRequest); + const result = spec.interpretResponse(serverResponse, bidRequest); assert.deepEqual(result, []); }); it('should interpret server response correctly with one bid', function () { serverResponse.body = [serverResponse.body[0]]; bidRequest.bids = [bidRequest.bids[0]]; - let result = spec.interpretResponse(serverResponse, bidRequest)[0]; + const result = spec.interpretResponse(serverResponse, bidRequest)[0]; assert.equal(result.requestId, '2a0cf4e'); assert.equal(result.cpm, 13.9); @@ -179,13 +179,13 @@ describe('etarget adapter', function () { serverResponse.body = [serverResponse.body[0]]; bidRequest.bids = [bidRequest.bids[1]]; bidRequest.netRevenue = 'net'; - let result = spec.interpretResponse(serverResponse, bidRequest)[0]; + const result = spec.interpretResponse(serverResponse, bidRequest)[0]; assert.equal(result.netRevenue, true); }); it('should create bid response item for every requested item', function () { - let result = spec.interpretResponse(serverResponse, bidRequest); + const result = spec.interpretResponse(serverResponse, bidRequest); assert.lengthOf(result, 5); }); @@ -242,7 +242,7 @@ describe('etarget adapter', function () { serverResponse.body = [serverResponse.body[0]]; bidRequest.bids = [bidRequest.bids[0]]; - let result = spec.interpretResponse(serverResponse, bidRequest); + const result = spec.interpretResponse(serverResponse, bidRequest); assert.equal(serverResponse.body.length, 1); assert.equal(serverResponse.body[0].response, 'banner'); @@ -257,7 +257,7 @@ describe('etarget adapter', function () { bidRequest.bids = [bidRequest.bids[0]]; bidRequest.bids[0].sizes = [['101', '150']]; - let result = spec.interpretResponse(serverResponse, bidRequest); + const result = spec.interpretResponse(serverResponse, bidRequest); assert.equal(serverResponse.body.length, 1); assert.equal(serverResponse.body[0].response, 'banner'); @@ -272,7 +272,7 @@ describe('etarget adapter', function () { bidRequest.bids = [bidRequest.bids[0]]; bidRequest.bids[0].sizes = [['300', '250'], ['250', '300'], ['300', '600'], ['600', '300']] - let result = spec.interpretResponse(serverResponse, bidRequest); + const result = spec.interpretResponse(serverResponse, bidRequest); assert.equal(result[0].width, 300); assert.equal(result[0].height, 600); @@ -281,9 +281,9 @@ describe('etarget adapter', function () { }); beforeEach(function () { - let sizes = [[250, 300], [300, 250], [300, 600]]; - let placementCode = ['div-01', 'div-02', 'div-03', 'div-04', 'div-05']; - let params = [{refid: 1, country: 1, url: 'some// there'}, {refid: 2, country: 1, someVar: 'someValue', pt: 'gross'}, {refid: 3, country: 1, pdom: 'home'}, {refid: 5, country: 1, pt: 'net'}, {refid: 6, country: 1, pt: 'gross'}]; + const sizes = [[250, 300], [300, 250], [300, 600]]; + const placementCode = ['div-01', 'div-02', 'div-03', 'div-04', 'div-05']; + const params = [{refid: 1, country: 1, url: 'some// there'}, {refid: 2, country: 1, someVar: 'someValue', pt: 'gross'}, {refid: 3, country: 1, pdom: 'home'}, {refid: 5, country: 1, pt: 'net'}, {refid: 6, country: 1, pt: 'gross'}]; bids = [ { adUnitCode: placementCode[0], diff --git a/test/spec/modules/euidIdSystem_spec.js b/test/spec/modules/euidIdSystem_spec.js index 9074638a495..0c02fd2aa64 100644 --- a/test/spec/modules/euidIdSystem_spec.js +++ b/test/spec/modules/euidIdSystem_spec.js @@ -9,7 +9,7 @@ import {uninstall as uninstallTcfControl} from 'modules/tcfControl.js'; import {server} from 'test/mocks/xhr'; import {createEidsArray} from '../../../modules/userId/eids.js'; -let expect = require('chai').expect; +const expect = require('chai').expect; // N.B. Most of the EUID code is shared with UID2 - the tests here only cover the happy path. // Most of the functionality is covered by the UID2 tests. diff --git a/test/spec/modules/excoBidAdapter_spec.js b/test/spec/modules/excoBidAdapter_spec.js index bd3b608f157..b9dd2ccea92 100644 --- a/test/spec/modules/excoBidAdapter_spec.js +++ b/test/spec/modules/excoBidAdapter_spec.js @@ -368,4 +368,34 @@ describe('ExcoBidAdapter', function () { expect(stubbedFetch.callCount).to.equal(0); }); }); + + describe('isDebugEnabled', function () { + let originalConfig; + + beforeEach(function () { + originalConfig = config.getConfig('debug'); + }); + + afterEach(function () { + config.setConfig({ debug: originalConfig }); + }); + + it('should return true if debug is enabled in config', function () { + config.setConfig({ debug: true }); + expect(helpers.isDebugEnabled()).to.be.true; + }); + + it('should return false if debug is disabled in config', function () { + config.setConfig({ debug: false }); + expect(helpers.isDebugEnabled()).to.be.false; + }); + + it('should return true if URL contains exco_debug=true', function () { + expect(helpers.isDebugEnabled('https://example.com?exco_debug=true')).to.be.true; + }); + + it('should return false if URL does not contain exco_debug=true', function () { + expect(helpers.isDebugEnabled('https://example.com')).to.be.false; + }); + }); }); diff --git a/test/spec/modules/fabrickIdSystem_spec.js b/test/spec/modules/fabrickIdSystem_spec.js index 4ed1ceba0ff..7f5227a142b 100644 --- a/test/spec/modules/fabrickIdSystem_spec.js +++ b/test/spec/modules/fabrickIdSystem_spec.js @@ -30,13 +30,13 @@ describe('Fabrick ID System', function() { }); it('should error on json parsing', function() { - let submoduleCallback = fabrickIdSubmodule.getId({ + const submoduleCallback = fabrickIdSubmodule.getId({ name: 'fabrickId', params: defaultConfigParams }).callback; - let callBackSpy = sinon.spy(); + const callBackSpy = sinon.spy(); submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; request.respond( 200, responseHeader, @@ -51,20 +51,20 @@ describe('Fabrick ID System', function() { for (let i = 0; i < 1500; i++) { r += 'r'; } - let configParams = Object.assign({}, defaultConfigParams, { + const configParams = Object.assign({}, defaultConfigParams, { refererInfo: { topmostLocation: r, stack: ['s-0'], canonicalUrl: 'cu-0' } }); - let submoduleCallback = fabrickIdSubmodule.getId({ + const submoduleCallback = fabrickIdSubmodule.getId({ name: 'fabrickId', params: configParams }).callback; - let callBackSpy = sinon.spy(); + const callBackSpy = sinon.spy(); submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; r = ''; for (let i = 0; i < 1000 - 3; i++) { r += 'r'; @@ -79,20 +79,20 @@ describe('Fabrick ID System', function() { }); it('should complete successfully', function() { - let configParams = Object.assign({}, defaultConfigParams, { + const configParams = Object.assign({}, defaultConfigParams, { refererInfo: { topmostLocation: 'r-0', stack: ['s-0'], canonicalUrl: 'cu-0' } }); - let submoduleCallback = fabrickIdSubmodule.getId({ + const submoduleCallback = fabrickIdSubmodule.getId({ name: 'fabrickId', params: configParams }).callback; - let callBackSpy = sinon.spy(); + const callBackSpy = sinon.spy(); submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.match(/r=r-0&r=s-0&r=cu-0&r=http/); request.respond( 200, @@ -103,7 +103,7 @@ describe('Fabrick ID System', function() { }); it('should truncate 2', function() { - let configParams = { + const configParams = { maxUrlLen: 10, maxRefLen: 5, maxSpaceAvailable: 2 diff --git a/test/spec/modules/feedadBidAdapter_spec.js b/test/spec/modules/feedadBidAdapter_spec.js index cb81c6f06de..dbabb4dd587 100644 --- a/test/spec/modules/feedadBidAdapter_spec.js +++ b/test/spec/modules/feedadBidAdapter_spec.js @@ -31,14 +31,14 @@ describe('FeedAdAdapter', function () { describe('isBidRequestValid', function () { it('should detect missing params', function () { - let result = spec.isBidRequestValid({ + const result = spec.isBidRequestValid({ bidder: 'feedad', sizes: [] }); expect(result).to.equal(false); }); it('should detect missing client token', function () { - let result = spec.isBidRequestValid({ + const result = spec.isBidRequestValid({ bidder: 'feedad', sizes: [], params: {placementId: 'placement'} @@ -46,7 +46,7 @@ describe('FeedAdAdapter', function () { expect(result).to.equal(false); }); it('should detect zero length client token', function () { - let result = spec.isBidRequestValid({ + const result = spec.isBidRequestValid({ bidder: 'feedad', sizes: [], params: {clientToken: '', placementId: 'placement'} @@ -54,7 +54,7 @@ describe('FeedAdAdapter', function () { expect(result).to.equal(false); }); it('should detect missing placement id', function () { - let result = spec.isBidRequestValid({ + const result = spec.isBidRequestValid({ bidder: 'feedad', sizes: [], params: {clientToken: 'clientToken'} @@ -62,7 +62,7 @@ describe('FeedAdAdapter', function () { expect(result).to.equal(false); }); it('should detect zero length placement id', function () { - let result = spec.isBidRequestValid({ + const result = spec.isBidRequestValid({ bidder: 'feedad', sizes: [], params: {clientToken: 'clientToken', placementId: ''} @@ -74,7 +74,7 @@ describe('FeedAdAdapter', function () { for (var i = 0; i < 300; i++) { placementId += 'a'; } - let result = spec.isBidRequestValid({ + const result = spec.isBidRequestValid({ bidder: 'feedad', sizes: [], params: {clientToken: 'clientToken', placementId} @@ -88,7 +88,7 @@ describe('FeedAdAdapter', function () { 'PLACEMENTID', 'placeme:ntId' ].forEach(id => { - let result = spec.isBidRequestValid({ + const result = spec.isBidRequestValid({ bidder: 'feedad', sizes: [], params: {clientToken: 'clientToken', placementId: id} @@ -97,7 +97,7 @@ describe('FeedAdAdapter', function () { }); }); it('should accept valid parameters', function () { - let result = spec.isBidRequestValid({ + const result = spec.isBidRequestValid({ bidder: 'feedad', sizes: [], params: {clientToken: 'clientToken', placementId: 'placement-id'} @@ -115,11 +115,11 @@ describe('FeedAdAdapter', function () { }; it('should accept empty lists', function () { - let result = spec.buildRequests([], bidderRequest); + const result = spec.buildRequests([], bidderRequest); expect(result).to.be.empty; }); it('should filter native media types', function () { - let bid = { + const bid = { code: 'feedad', mediaTypes: { native: { @@ -128,11 +128,11 @@ describe('FeedAdAdapter', function () { }, params: {clientToken: 'clientToken', placementId: 'placement-id'} }; - let result = spec.buildRequests([bid], bidderRequest); + const result = spec.buildRequests([bid], bidderRequest); expect(result).to.be.empty; }); it('should filter video media types without outstream context', function () { - let bid = { + const bid = { code: 'feedad', mediaTypes: { video: { @@ -141,11 +141,11 @@ describe('FeedAdAdapter', function () { }, params: {clientToken: 'clientToken', placementId: 'placement-id'} }; - let result = spec.buildRequests([bid], bidderRequest); + const result = spec.buildRequests([bid], bidderRequest); expect(result).to.be.empty; }); it('should pass through outstream video media', function () { - let bid = { + const bid = { code: 'feedad', mediaTypes: { video: { @@ -154,12 +154,12 @@ describe('FeedAdAdapter', function () { }, params: {clientToken: 'clientToken', placementId: 'placement-id'} }; - let result = spec.buildRequests([bid], bidderRequest); + const result = spec.buildRequests([bid], bidderRequest); expect(result.data.bids).to.be.lengthOf(1); expect(result.data.bids[0]).to.deep.equal(bid); }); it('should pass through banner media', function () { - let bid = { + const bid = { code: 'feedad', mediaTypes: { banner: { @@ -168,12 +168,12 @@ describe('FeedAdAdapter', function () { }, params: {clientToken: 'clientToken', placementId: 'placement-id'} }; - let result = spec.buildRequests([bid], bidderRequest); + const result = spec.buildRequests([bid], bidderRequest); expect(result.data.bids).to.be.lengthOf(1); expect(result.data.bids[0]).to.deep.equal(bid); }); it('should pass through additional bid parameters', function () { - let bid = { + const bid = { code: 'feedad', mediaTypes: { banner: { @@ -182,13 +182,13 @@ describe('FeedAdAdapter', function () { }, params: {clientToken: 'clientToken', placementId: 'placement-id', another: 'parameter', more: 'parameters'} }; - let result = spec.buildRequests([bid], bidderRequest); + const result = spec.buildRequests([bid], bidderRequest); expect(result.data.bids).to.be.lengthOf(1); expect(result.data.bids[0].params.another).to.equal('parameter'); expect(result.data.bids[0].params.more).to.equal('parameters'); }); it('should detect empty media types', function () { - let bid = { + const bid = { code: 'feedad', mediaTypes: { banner: undefined, @@ -197,11 +197,11 @@ describe('FeedAdAdapter', function () { }, params: {clientToken: 'clientToken', placementId: 'placement-id'} }; - let result = spec.buildRequests([bid], bidderRequest); + const result = spec.buildRequests([bid], bidderRequest); expect(result).to.be.empty; }); it('should use POST', function () { - let bid = { + const bid = { code: 'feedad', mediaTypes: { banner: { @@ -210,11 +210,11 @@ describe('FeedAdAdapter', function () { }, params: {clientToken: 'clientToken', placementId: 'placement-id'} }; - let result = spec.buildRequests([bid], bidderRequest); + const result = spec.buildRequests([bid], bidderRequest); expect(result.method).to.equal('POST'); }); it('should use the correct URL', function () { - let bid = { + const bid = { code: 'feedad', mediaTypes: { banner: { @@ -223,11 +223,11 @@ describe('FeedAdAdapter', function () { }, params: {clientToken: 'clientToken', placementId: 'placement-id'} }; - let result = spec.buildRequests([bid], bidderRequest); + const result = spec.buildRequests([bid], bidderRequest); expect(result.url).to.equal('https://api.feedad.com/1/prebid/web/bids'); }); it('should specify the content type explicitly', function () { - let bid = { + const bid = { code: 'feedad', mediaTypes: { banner: { @@ -236,13 +236,13 @@ describe('FeedAdAdapter', function () { }, params: {clientToken: 'clientToken', placementId: 'placement-id'} }; - let result = spec.buildRequests([bid], bidderRequest); + const result = spec.buildRequests([bid], bidderRequest); expect(result.options).to.deep.equal({ contentType: 'application/json' }) }); it('should include the bidder request', function () { - let bid = { + const bid = { code: 'feedad', mediaTypes: { banner: { @@ -251,11 +251,11 @@ describe('FeedAdAdapter', function () { }, params: {clientToken: 'clientToken', placementId: 'placement-id'} }; - let result = spec.buildRequests([bid, bid, bid], bidderRequest); + const result = spec.buildRequests([bid, bid, bid], bidderRequest); expect(result.data).to.deep.include(bidderRequest); }); it('should detect missing bidder request parameter', function () { - let bid = { + const bid = { code: 'feedad', mediaTypes: { banner: { @@ -264,11 +264,11 @@ describe('FeedAdAdapter', function () { }, params: {clientToken: 'clientToken', placementId: 'placement-id'} }; - let result = spec.buildRequests([bid, bid, bid]); + const result = spec.buildRequests([bid, bid, bid]); expect(result).to.be.empty; }); it('should not include GDPR data if the bidder request has none available', function () { - let bid = { + const bid = { code: 'feedad', mediaTypes: { banner: { @@ -277,12 +277,12 @@ describe('FeedAdAdapter', function () { }, params: {clientToken: 'clientToken', placementId: 'placement-id'} }; - let result = spec.buildRequests([bid], bidderRequest); + const result = spec.buildRequests([bid], bidderRequest); expect(result.data.gdprApplies).to.be.undefined; expect(result.data.consentIabTcf).to.be.undefined; }); it('should include GDPR data if the bidder requests contains it', function () { - let bid = { + const bid = { code: 'feedad', mediaTypes: { banner: { @@ -291,18 +291,18 @@ describe('FeedAdAdapter', function () { }, params: {clientToken: 'clientToken', placementId: 'placement-id'} }; - let request = Object.assign({}, bidderRequest, { + const request = Object.assign({}, bidderRequest, { gdprConsent: { consentString: 'the consent string', gdprApplies: true } }); - let result = spec.buildRequests([bid], request); + const result = spec.buildRequests([bid], request); expect(result.data.gdprApplies).to.equal(request.gdprConsent.gdprApplies); expect(result.data.consentIabTcf).to.equal(request.gdprConsent.consentString); }); it('should include adapter and prebid version', function () { - let bid = { + const bid = { code: 'feedad', mediaTypes: { banner: { @@ -311,7 +311,7 @@ describe('FeedAdAdapter', function () { }, params: {clientToken: 'clientToken', placementId: 'placement-id'} }; - let result = spec.buildRequests([bid], bidderRequest); + const result = spec.buildRequests([bid], bidderRequest); expect(result.data.bids[0].params.prebid_adapter_version).to.equal(EXPECTED_ADAPTER_VERSION); expect(result.data.bids[0].params.prebid_sdk_version).to.equal('$prebid.version$'); }); @@ -322,7 +322,7 @@ describe('FeedAdAdapter', function () { const body = [{ ad: 'bar', }]; - let result = spec.interpretResponse({body: JSON.stringify(body)}); + const result = spec.interpretResponse({body: JSON.stringify(body)}); expect(result).to.deep.equal(body); }); @@ -330,7 +330,7 @@ describe('FeedAdAdapter', function () { const body = [{ ad: 'bar', }]; - let result = spec.interpretResponse({body}); + const result = spec.interpretResponse({body}); expect(result).to.deep.equal(body); }); @@ -347,7 +347,7 @@ describe('FeedAdAdapter', function () { ad: 'ad html', }; const body = [bid1, bid2, bid3]; - let result = spec.interpretResponse({body: JSON.stringify(body)}); + const result = spec.interpretResponse({body: JSON.stringify(body)}); expect(result).to.deep.equal([bid1, bid3]); }); @@ -588,7 +588,7 @@ describe('FeedAdAdapter', function () { ]; cases.forEach(([name, data, eventKlass]) => { - let subject = spec[name]; + const subject = spec[name]; describe(name + ' handler', function () { it('should do nothing on empty data', function () { subject(undefined); @@ -603,7 +603,7 @@ describe('FeedAdAdapter', function () { it('should send tracking params when correct metadata was set', function () { spec.buildRequests([bid], bidderRequest); - let expectedData = { + const expectedData = { app_hybrid: false, client_token: clientToken, placement_id: placementId, @@ -617,7 +617,7 @@ describe('FeedAdAdapter', function () { }; subject(data); expect(server.requests.length).to.equal(1); - let call = server.requests[0]; + const call = server.requests[0]; expect(call.url).to.equal('https://api.feedad.com/1/prebid/web/events'); expect(JSON.parse(call.requestBody)).to.deep.equal(expectedData); expect(call.method).to.equal('POST'); diff --git a/test/spec/modules/finativeBidAdapter_spec.js b/test/spec/modules/finativeBidAdapter_spec.js index b2d2701f6ca..fd45721c438 100644 --- a/test/spec/modules/finativeBidAdapter_spec.js +++ b/test/spec/modules/finativeBidAdapter_spec.js @@ -6,7 +6,7 @@ import { config } from 'src/config.js'; describe('Finative adapter', function () { let serverResponse, bidRequest, bidResponses; - let bid = { + const bid = { 'bidder': 'finative', 'params': { 'adUnitId': '1uyo' @@ -26,41 +26,41 @@ describe('Finative adapter', function () { describe('buildRequests', function () { it('should send request with correct structure', function () { - let validBidRequests = [{ + const validBidRequests = [{ bidId: 'bidId', params: {} }]; - let request = spec.buildRequests(validBidRequests, { refererInfo: { referer: 'page' } }); + const request = spec.buildRequests(validBidRequests, { refererInfo: { referer: 'page' } }); assert.equal(request.method, 'POST'); assert.ok(request.data); }); it('should have default request structure', function () { - let keys = 'site,device,cur,imp,user,regs'.split(','); - let validBidRequests = [{ + const keys = 'site,device,cur,imp,user,regs'.split(','); + const validBidRequests = [{ bidId: 'bidId', params: {} }]; - let request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { referer: 'page' } }).data); - let data = Object.keys(request); + const request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { referer: 'page' } }).data); + const data = Object.keys(request); assert.deepEqual(keys, data); }); it('Verify the device', function () { - let validBidRequests = [{ + const validBidRequests = [{ bidId: 'bidId', params: {} }]; - let request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { referer: 'page' } }).data); + const request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { referer: 'page' } }).data); assert.equal(request.device.ua, navigator.userAgent); }); it('Verify native asset ids', function () { - let validBidRequests = [{ + const validBidRequests = [{ bidId: 'bidId', params: {}, nativeParams: { @@ -86,7 +86,7 @@ describe('Finative adapter', function () { } }]; - let assets = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { referer: 'page' } }).data).imp[0].native.request.assets; + const assets = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { referer: 'page' } }).data).imp[0].native.request.assets; assert.equal(assets[0].id, 1); assert.equal(assets[1].id, 3); diff --git a/test/spec/modules/fintezaAnalyticsAdapter_spec.js b/test/spec/modules/fintezaAnalyticsAdapter_spec.js index dd9fd782b84..eaf5b5f40c2 100644 --- a/test/spec/modules/fintezaAnalyticsAdapter_spec.js +++ b/test/spec/modules/fintezaAnalyticsAdapter_spec.js @@ -4,8 +4,8 @@ import { parseUrl } from 'src/utils.js'; import { server } from 'test/mocks/xhr.js'; import { EVENTS } from 'src/constants.js'; -let adapterManager = require('src/adapterManager').default; -let events = require('src/events'); +const adapterManager = require('src/adapterManager').default; +const events = require('src/events'); function setCookie(name, value, expires) { document.cookie = name + '=' + value + diff --git a/test/spec/modules/flippBidAdapter_spec.js b/test/spec/modules/flippBidAdapter_spec.js index 9602a156bed..e7867c8b479 100644 --- a/test/spec/modules/flippBidAdapter_spec.js +++ b/test/spec/modules/flippBidAdapter_spec.js @@ -25,7 +25,7 @@ describe('flippAdapter', function () { }); it('should return false when required params are not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); invalidBid.params = { siteId: 1234 } expect(spec.isBidRequestValid(invalidBid)).to.equal(false); }); diff --git a/test/spec/modules/fluctBidAdapter_spec.js b/test/spec/modules/fluctBidAdapter_spec.js index 946c9609b58..9db58476e36 100644 --- a/test/spec/modules/fluctBidAdapter_spec.js +++ b/test/spec/modules/fluctBidAdapter_spec.js @@ -26,14 +26,14 @@ describe('fluctAdapter', function () { }); it('should return false when required params are not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = {}; expect(spec.isBidRequestValid(invalidBid)).to.equal(false); }); it('should return true when dfpUnitCode is not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = { tagId: '10000:100000001', @@ -43,7 +43,7 @@ describe('fluctAdapter', function () { }); it('should return false when groupId is not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = { dfpUnitCode: '/1000/dfp_unit_code', diff --git a/test/spec/modules/freeWheelAdserverVideo_spec.js b/test/spec/modules/freeWheelAdserverVideo_spec.js index 0a215092e18..3da5b411e37 100644 --- a/test/spec/modules/freeWheelAdserverVideo_spec.js +++ b/test/spec/modules/freeWheelAdserverVideo_spec.js @@ -9,7 +9,7 @@ describe('freeWheel adserver module', function() { let amGetAdUnitsStub; before(function () { - let adUnits = [{ + const adUnits = [{ code: 'preroll_1', mediaTypes: { video: { @@ -100,7 +100,7 @@ describe('freeWheel adserver module', function() { }); it('should only use adpod bids', function() { - let bannerBid = [{ + const bannerBid = [{ 'ad': 'creative', 'cpm': '1.99', 'width': 300, @@ -200,13 +200,13 @@ describe('freeWheel adserver module', function() { } }); - let tier6Bid = createBid(10, 'preroll_1', 15, 'tier6_395_15s', '123', '395'); + const tier6Bid = createBid(10, 'preroll_1', 15, 'tier6_395_15s', '123', '395'); tier6Bid['video']['dealTier'] = 'tier6' - let tier7Bid = createBid(11, 'preroll_1', 45, 'tier7_395_15s', '123', '395'); + const tier7Bid = createBid(11, 'preroll_1', 45, 'tier7_395_15s', '123', '395'); tier7Bid['video']['dealTier'] = 'tier7' - let bidsReceived = [ + const bidsReceived = [ tier6Bid, tier7Bid, createBid(15, 'preroll_1', 90, '15.00_395_90s', '123', '395'), @@ -245,18 +245,18 @@ describe('freeWheel adserver module', function() { } }); - let tier2Bid = createBid(10, 'preroll_1', 15, 'tier2_395_15s', '123', '395'); + const tier2Bid = createBid(10, 'preroll_1', 15, 'tier2_395_15s', '123', '395'); tier2Bid['video']['dealTier'] = 2 tier2Bid['adserverTargeting']['hb_pb'] = '10.00' - let tier7Bid = createBid(11, 'preroll_1', 45, 'tier7_395_15s', '123', '395'); + const tier7Bid = createBid(11, 'preroll_1', 45, 'tier7_395_15s', '123', '395'); tier7Bid['video']['dealTier'] = 7 tier7Bid['adserverTargeting']['hb_pb'] = '11.00' - let bid = createBid(15, 'preroll_1', 15, '15.00_395_90s', '123', '395'); + const bid = createBid(15, 'preroll_1', 15, '15.00_395_90s', '123', '395'); bid['adserverTargeting']['hb_pb'] = '15.00' - let bidsReceived = [ + const bidsReceived = [ tier2Bid, tier7Bid, bid diff --git a/test/spec/modules/freepassBidAdapter_spec.js b/test/spec/modules/freepassBidAdapter_spec.js index c4acbb1400c..d89c7ca9bdf 100644 --- a/test/spec/modules/freepassBidAdapter_spec.js +++ b/test/spec/modules/freepassBidAdapter_spec.js @@ -34,13 +34,13 @@ describe('FreePass adapter', function () { }); it('should return false when adUnitCode is missing', function () { - let localBid = Object.assign({}, bid); + const localBid = Object.assign({}, bid); delete localBid.adUnitCode; expect(spec.isBidRequestValid(localBid)).to.equal(false); }); it('should return false when params.publisherId is missing', function () { - let localBid = Object.assign({}, bid); + const localBid = Object.assign({}, bid); delete localBid.params.publisherId; expect(spec.isBidRequestValid(localBid)).to.equal(false); }); @@ -76,7 +76,7 @@ describe('FreePass adapter', function () { }); it('should handle missing userIdAsEids gracefully', function () { - let localBidRequests = [JSON.parse(JSON.stringify(bidRequests[0]))]; + const localBidRequests = [JSON.parse(JSON.stringify(bidRequests[0]))]; delete localBidRequests[0].userIdAsEids; expect(() => spec.buildRequests(localBidRequests, bidderRequest)).to.throw(); }); @@ -107,7 +107,7 @@ describe('FreePass adapter', function () { }); it('should skip freepass commonId when not available', function () { - let localBidRequests = [JSON.parse(JSON.stringify(bidRequests[0]))]; + const localBidRequests = [JSON.parse(JSON.stringify(bidRequests[0]))]; localBidRequests[0].userIdAsEids[0].uids[0].id = undefined; const bidRequest = spec.buildRequests(localBidRequests, bidderRequest); const ortbData = bidRequest.data; @@ -126,7 +126,7 @@ describe('FreePass adapter', function () { }); it('should skip IP information when not available', function () { - let localBidRequests = [JSON.parse(JSON.stringify(bidRequests[0]))]; + const localBidRequests = [JSON.parse(JSON.stringify(bidRequests[0]))]; delete localBidRequests[0].userIdAsEids[0].uids[0].ext.ip; const bidRequest = spec.buildRequests(localBidRequests, bidderRequest); const ortbData = bidRequest.data; @@ -147,7 +147,7 @@ describe('FreePass adapter', function () { it('it should add publisher related information w/ publisherUrl', function () { const PUBLISHER_URL = 'publisherUrlValue'; - let localBidRequests = [Object.assign({}, bidRequests[0])]; + const localBidRequests = [Object.assign({}, bidRequests[0])]; localBidRequests[0].params.publisherUrl = PUBLISHER_URL; const bidRequest = spec.buildRequests(localBidRequests, bidderRequest); const ortbData = bidRequest.data; diff --git a/test/spec/modules/freepassIdSystem_spec.js b/test/spec/modules/freepassIdSystem_spec.js index 38806fe3761..56a8eb06778 100644 --- a/test/spec/modules/freepassIdSystem_spec.js +++ b/test/spec/modules/freepassIdSystem_spec.js @@ -2,7 +2,7 @@ import { freepassIdSubmodule } from 'modules/freepassIdSystem'; import sinon from 'sinon'; import * as utils from '../../../src/utils'; -let expect = require('chai').expect; +const expect = require('chai').expect; describe('FreePass ID System', function () { const UUID = '15fde1dc-1861-4894-afdf-b757272f3568'; diff --git a/test/spec/modules/ftrackIdSystem_spec.js b/test/spec/modules/ftrackIdSystem_spec.js index d043f555afb..3ea6e9c177e 100644 --- a/test/spec/modules/ftrackIdSystem_spec.js +++ b/test/spec/modules/ftrackIdSystem_spec.js @@ -9,7 +9,7 @@ import {config} from 'src/config.js'; import {server} from 'test/mocks/xhr.js'; import 'src/prebid.js'; -let configMock = { +const configMock = { name: 'ftrack', params: { url: 'https://d9.flashtalking.com/d9core', @@ -27,7 +27,7 @@ let configMock = { debug: true }; -let consentDataMock = { +const consentDataMock = { gdprApplies: 0, consentString: '' }; @@ -54,7 +54,7 @@ describe('FTRACK ID System', () => { }); it(`should be rejected if 'config.storage' property is missing`, () => { - let configMock1 = JSON.parse(JSON.stringify(configMock)); + const configMock1 = JSON.parse(JSON.stringify(configMock)); delete configMock1.storage; delete configMock1.params; @@ -63,7 +63,7 @@ describe('FTRACK ID System', () => { }); it(`should be rejected if 'config.storage.name' property is missing`, () => { - let configMock1 = JSON.parse(JSON.stringify(configMock)); + const configMock1 = JSON.parse(JSON.stringify(configMock)); delete configMock1.storage.name; ftrackIdSubmodule.isConfigOk(configMock1); @@ -71,7 +71,7 @@ describe('FTRACK ID System', () => { }); it(`should be rejected if 'config.storage.name' is not 'ftrackId'`, () => { - let configMock1 = JSON.parse(JSON.stringify(configMock)); + const configMock1 = JSON.parse(JSON.stringify(configMock)); configMock1.storage.name = 'not-ftrack'; ftrackIdSubmodule.isConfigOk(configMock1); @@ -79,7 +79,7 @@ describe('FTRACK ID System', () => { }); it(`should be rejected if 'congig.storage.type' property is missing`, () => { - let configMock1 = JSON.parse(JSON.stringify(configMock)); + const configMock1 = JSON.parse(JSON.stringify(configMock)); delete configMock1.storage.type; ftrackIdSubmodule.isConfigOk(configMock1); @@ -87,7 +87,7 @@ describe('FTRACK ID System', () => { }); it(`should be rejected if 'config.storage.type' is not 'html5'`, () => { - let configMock1 = JSON.parse(JSON.stringify(configMock)); + const configMock1 = JSON.parse(JSON.stringify(configMock)); configMock1.storage.type = 'not-html5'; ftrackIdSubmodule.isConfigOk(configMock1); @@ -95,7 +95,7 @@ describe('FTRACK ID System', () => { }); it(`should be rejected if 'config.params.url' does not exist`, () => { - let configMock1 = JSON.parse(JSON.stringify(configMock)); + const configMock1 = JSON.parse(JSON.stringify(configMock)); delete configMock1.params.url; ftrackIdSubmodule.isConfigOk(configMock1); @@ -156,7 +156,7 @@ describe('FTRACK ID System', () => { describe(`should use the "ids" setting in the config:`, () => { it(`should use default IDs if config.params.id is not populated`, () => { - let configMock1 = JSON.parse(JSON.stringify(configMock)); + const configMock1 = JSON.parse(JSON.stringify(configMock)); delete configMock1.params.ids; ftrackIdSubmodule.getId(configMock1, null, null).callback(() => {}); @@ -167,7 +167,7 @@ describe('FTRACK ID System', () => { describe(`should use correct ID settings if config.params.id is populated`, () => { it(`- any ID set as strings should not be added to window.D9r`, () => { - let configMock1 = JSON.parse(JSON.stringify(configMock)); + const configMock1 = JSON.parse(JSON.stringify(configMock)); configMock1.params.ids['device id'] = 'test device ID'; configMock1.params.ids['single device id'] = 'test single device ID'; configMock1.params.ids['household id'] = 'test household ID'; @@ -179,7 +179,7 @@ describe('FTRACK ID System', () => { }) it(`- any ID set to false should not be added to window.D9r`, () => { - let configMock1 = JSON.parse(JSON.stringify(configMock)); + const configMock1 = JSON.parse(JSON.stringify(configMock)); configMock1.params.ids['device id'] = false; configMock1.params.ids['single device id'] = false; configMock1.params.ids['household id'] = false; @@ -191,7 +191,7 @@ describe('FTRACK ID System', () => { }); it(`- only device id`, () => { - let configMock1 = JSON.parse(JSON.stringify(configMock)); + const configMock1 = JSON.parse(JSON.stringify(configMock)); delete configMock1.params.ids['single device id']; ftrackIdSubmodule.getId(configMock1, null, null).callback(() => {}); @@ -201,7 +201,7 @@ describe('FTRACK ID System', () => { }); it(`- only single device id`, () => { - let configMock1 = JSON.parse(JSON.stringify(configMock)); + const configMock1 = JSON.parse(JSON.stringify(configMock)); delete configMock1.params.ids['device id']; ftrackIdSubmodule.getId(configMock1, null, null).callback(() => {}); @@ -211,7 +211,7 @@ describe('FTRACK ID System', () => { }); it(`- only household ID`, () => { - let configMock1 = JSON.parse(JSON.stringify(configMock)); + const configMock1 = JSON.parse(JSON.stringify(configMock)); delete configMock1.params.ids['device id']; delete configMock1.params.ids['single device id']; configMock1.params.ids['household id'] = true; diff --git a/test/spec/modules/gamAdpod_spec.js b/test/spec/modules/gamAdpod_spec.js index 2a83fa36734..31e142d11f8 100644 --- a/test/spec/modules/gamAdpod_spec.js +++ b/test/spec/modules/gamAdpod_spec.js @@ -13,7 +13,7 @@ describe('gamAdpod', function () { let amGetAdUnitsStub; before(function () { - let adUnits = [{ + const adUnits = [{ code: 'adUnitCode-1', mediaTypes: { video: { @@ -123,9 +123,9 @@ describe('gamAdpod', function () { it('should return masterTag url', function() { amStub.returns(getBidsReceived()); - let uspDataHandlerStub = sinon.stub(uspDataHandler, 'getConsentData'); + const uspDataHandlerStub = sinon.stub(uspDataHandler, 'getConsentData'); uspDataHandlerStub.returns('1YYY'); - let gdprDataHandlerStub = sinon.stub(gdprDataHandler, 'getConsentData'); + const gdprDataHandlerStub = sinon.stub(gdprDataHandler, 'getConsentData'); gdprDataHandlerStub.returns({ gdprApplies: true, consentString: 'consent', @@ -180,7 +180,7 @@ describe('gamAdpod', function () { } }); function getBids() { - let bids = [ + const bids = [ createBid(10, 'adUnitCode-1', 15, '10.00_15s', '123', '395', '10.00'), createBid(15, 'adUnitCode-1', 15, '15.00_15s', '123', '395', '15.00'), createBid(25, 'adUnitCode-1', 30, '15.00_30s', '123', '406', '25.00'), diff --git a/test/spec/modules/gammaBidAdapter_spec.js b/test/spec/modules/gammaBidAdapter_spec.js index 2c83c3912e3..bff11ded9fa 100644 --- a/test/spec/modules/gammaBidAdapter_spec.js +++ b/test/spec/modules/gammaBidAdapter_spec.js @@ -5,7 +5,7 @@ import { newBidder } from 'src/adapters/bidderFactory.js'; describe('gammaBidAdapter', function() { const adapter = newBidder(spec); - let bid = { + const bid = { 'bidder': 'gamma', 'params': { siteId: '1398219351', @@ -20,7 +20,7 @@ describe('gammaBidAdapter', function() { 'bidderRequestId': '19c0c1efdf37e7', 'auctionId': '61466567-d482-4a16-96f0-fe5f25ffbdf1', }; - let bidArray = [bid]; + const bidArray = [bid]; describe('isBidRequestValid', () => { it('should return true when required params found', () => { @@ -28,7 +28,7 @@ describe('gammaBidAdapter', function() { }); it('should return false when require params are not passed', () => { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); invalidBid.params = {}; expect(spec.isBidRequestValid(invalidBid)).to.equal(false); }); @@ -79,7 +79,7 @@ describe('gammaBidAdapter', function() { }) it('should get the correct bid response', () => { - let expectedResponse = [{ + const expectedResponse = [{ 'requestId': '23beaa6af6cdde', 'cpm': 0.45, 'width': 300, @@ -92,15 +92,15 @@ describe('gammaBidAdapter', function() { 'ad': '', 'meta': {'advertiserDomains': ['testdomain.com']} }]; - let result = spec.interpretResponse(serverResponse); + const result = spec.interpretResponse(serverResponse); expect(Object.keys(result)).to.deep.equal(Object.keys(expectedResponse)); }); it('handles empty bid response', () => { - let response = { + const response = { body: {} }; - let result = spec.interpretResponse(response); + const result = spec.interpretResponse(response); expect(result.length).to.equal(0); }); }); diff --git a/test/spec/modules/gamoshiBidAdapter_spec.js b/test/spec/modules/gamoshiBidAdapter_spec.js index 270c0f7c2aa..65caa53c119 100644 --- a/test/spec/modules/gamoshiBidAdapter_spec.js +++ b/test/spec/modules/gamoshiBidAdapter_spec.js @@ -327,7 +327,7 @@ describe('GamoshiAdapter', () => { }); it('builds request correctly', () => { - let bidRequest2 = utils.deepClone(bidRequest); + const bidRequest2 = utils.deepClone(bidRequest); Object.assign(bidRequest2.refererInfo, { page: 'http://www.test.com/page.html', domain: 'www.test.com', @@ -489,7 +489,7 @@ describe('GamoshiAdapter', () => { }); it('builds request with gdpr consent', () => { - let response = spec.buildRequests([bidRequest], bidRequest)[0]; + const response = spec.buildRequests([bidRequest], bidRequest)[0]; expect(response.data.ext.gdpr_consent).to.not.equal(null).and.not.equal(undefined); expect(response.data.ext).to.have.property('gdpr_consent'); @@ -504,7 +504,7 @@ describe('GamoshiAdapter', () => { const bidRequestClone = utils.deepClone(bidRequest); bidRequestClone.userId = {}; bidRequestClone.userId.id5id = { uid: 'id5-user-id' }; - let request = spec.buildRequests([bidRequestClone], bidRequestClone)[0]; + const request = spec.buildRequests([bidRequestClone], bidRequestClone)[0]; expect(request.data.user.ext.eids).to.deep.equal([{ 'source': 'id5-sync.com', 'uids': [{ @@ -520,7 +520,7 @@ describe('GamoshiAdapter', () => { const bidRequestClone = utils.deepClone(bidRequest); bidRequestClone.userId = {}; bidRequestClone.userId.tdid = 'tdid-user-id'; - let request = spec.buildRequests([bidRequestClone], bidRequestClone)[0]; + const request = spec.buildRequests([bidRequestClone], bidRequestClone)[0]; expect(request.data.user.ext.eids).to.deep.equal([{ 'source': 'adserver.org', 'uids': [{ diff --git a/test/spec/modules/getintentBidAdapter_spec.js b/test/spec/modules/getintentBidAdapter_spec.js index bb0b5ba826c..35788f6f992 100644 --- a/test/spec/modules/getintentBidAdapter_spec.js +++ b/test/spec/modules/getintentBidAdapter_spec.js @@ -84,7 +84,7 @@ describe('GetIntent Adapter Tests:', function () { it('Verify build video request', function () { const serverRequests = spec.buildRequests([videoBidRequest]); - let serverRequest = serverRequests[0]; + const serverRequest = serverRequests[0]; expect(serverRequest.url).to.equal('https://px.adhigh.net/rtb/direct_vast'); expect(serverRequest.method).to.equal('GET'); expect(serverRequest.data.bid_id).to.equal('bid789'); @@ -104,7 +104,7 @@ describe('GetIntent Adapter Tests:', function () { it('Verify build video request with video params', function () { const serverRequests = spec.buildRequests([videoBidRequestWithVideoParams]); - let serverRequest = serverRequests[0]; + const serverRequest = serverRequests[0]; expect(serverRequest.url).to.equal('https://px.adhigh.net/rtb/direct_vast'); expect(serverRequest.method).to.equal('GET'); expect(serverRequest.data.bid_id).to.equal('bid789'); @@ -124,7 +124,7 @@ describe('GetIntent Adapter Tests:', function () { bidRequestWithFloor.params.cur = 'USD' const serverRequests = spec.buildRequests([bidRequestWithFloor]); - let serverRequest = serverRequests[0]; + const serverRequest = serverRequests[0]; expect(serverRequest.data.cur).to.equal('USD'); expect(serverRequest.data.floor).to.equal(10); }); @@ -137,7 +137,7 @@ describe('GetIntent Adapter Tests:', function () { bidRequestWithFloor.getFloor = () => getFloorResponse; const serverRequests = spec.buildRequests([bidRequestWithFloor]); - let serverRequest = serverRequests[0]; + const serverRequest = serverRequests[0]; expect(serverRequest.data.cur).to.equal('EUR'); expect(serverRequest.data.floor).to.equal(5); }); diff --git a/test/spec/modules/gjirafaBidAdapter_spec.js b/test/spec/modules/gjirafaBidAdapter_spec.js index 96bf319dfd2..214468277d2 100644 --- a/test/spec/modules/gjirafaBidAdapter_spec.js +++ b/test/spec/modules/gjirafaBidAdapter_spec.js @@ -145,7 +145,7 @@ describe('gjirafaAdapterTest', () => { it('all keys present', () => { const result = spec.interpretResponse(bidResponse, bidRequest); - let keys = [ + const keys = [ 'requestId', 'cpm', 'width', @@ -161,7 +161,7 @@ describe('gjirafaAdapterTest', () => { 'meta' ]; - let resultKeys = Object.keys(result[0]); + const resultKeys = Object.keys(result[0]); resultKeys.forEach(function (key) { expect(keys.indexOf(key) !== -1).to.equal(true); }); diff --git a/test/spec/modules/gmosspBidAdapter_spec.js b/test/spec/modules/gmosspBidAdapter_spec.js index 77644b136db..b3d0c20f3d4 100644 --- a/test/spec/modules/gmosspBidAdapter_spec.js +++ b/test/spec/modules/gmosspBidAdapter_spec.js @@ -15,7 +15,7 @@ describe('GmosspAdapter', function () { }); describe('isBidRequestValid', function () { - let bid = { + const bid = { bidder: 'gmossp', params: { sid: '123456' @@ -27,7 +27,7 @@ describe('GmosspAdapter', function () { }); it('should return false when required params are not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = {}; expect(spec.isBidRequestValid(invalidBid)).to.equal(false); @@ -35,7 +35,7 @@ describe('GmosspAdapter', function () { }); describe('buildRequests', function () { - let bidRequests = [ + const bidRequests = [ { bidder: 'gmossp', params: { diff --git a/test/spec/modules/gnetBidAdapter_spec.js b/test/spec/modules/gnetBidAdapter_spec.js index 8e2cfadc96b..11cc740a6a9 100644 --- a/test/spec/modules/gnetBidAdapter_spec.js +++ b/test/spec/modules/gnetBidAdapter_spec.js @@ -20,7 +20,7 @@ describe('gnetAdapter', function () { }); describe('isBidRequestValid', function () { - let bid = { + const bid = { bidder: 'gnet', params: { websiteId: '1', adunitId: '1' @@ -32,7 +32,7 @@ describe('gnetAdapter', function () { }); it('should return false when required params are not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = {}; expect(spec.isBidRequestValid(invalidBid)).to.equal(false); diff --git a/test/spec/modules/goldbachBidAdapter_spec.js b/test/spec/modules/goldbachBidAdapter_spec.js index 420bd5cc125..ac1207f6d19 100644 --- a/test/spec/modules/goldbachBidAdapter_spec.js +++ b/test/spec/modules/goldbachBidAdapter_spec.js @@ -13,7 +13,7 @@ const ENDPOINT = 'https://goldlayer-api.prod.gbads.net/openrtb/2.5/auction'; const ENDPOINT_COOKIESYNC = 'https://goldlayer-api.prod.gbads.net/cookiesync'; /* Eids */ -let eids = [ +const eids = [ { source: 'goldbach.com', uids: [ @@ -99,7 +99,7 @@ const validNativeObject = { }; /* Minimal validBidRequests */ -let validBidRequests = [ +const validBidRequests = [ { bidder: BIDDER_NAME, adUnitCode: 'au-1', @@ -191,7 +191,7 @@ let validBidRequests = [ ]; /* Minimal bidderRequest */ -let validBidderRequest = { +const validBidderRequest = { bidderCode: BIDDER_NAME, auctionId: '7570fb24-810d-4c26-9f9c-acd0b6977f60', bidderRequestId: '7570fb24-811d-4c26-9f9c-acd0b6977f61', @@ -204,7 +204,7 @@ let validBidderRequest = { }; /* OpenRTB response from auction endpoint */ -let validOrtbBidResponse = { +const validOrtbBidResponse = { id: '3d52a1909b972a', seatbid: [ { @@ -292,7 +292,7 @@ describe('GoldbachBidAdapter', function () { }); describe('isBidRequestValid', function () { - let bid = { + const bid = { bidder: BIDDER_NAME, params: { publisherId: 'de-publisher.ch-ios', @@ -308,7 +308,7 @@ describe('GoldbachBidAdapter', function () { }); it('should return false when required params are not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = { publisherId: undefined @@ -319,16 +319,16 @@ describe('GoldbachBidAdapter', function () { describe('buildRequests', function () { it('should use defined endpoint', function () { - let bidRequests = deepClone(validBidRequests); - let bidderRequest = deepClone(validBidderRequest); + const bidRequests = deepClone(validBidRequests); + const bidderRequest = deepClone(validBidderRequest); const request = spec.buildRequests(bidRequests, bidderRequest); expect(request.url).to.equal(ENDPOINT); }) it('should parse all bids to a valid openRTB request', function () { - let bidRequests = deepClone(validBidRequests); - let bidderRequest = deepClone(validBidderRequest); + const bidRequests = deepClone(validBidRequests); + const bidderRequest = deepClone(validBidderRequest); const request = spec.buildRequests(bidRequests, bidderRequest); const payload = request.data; @@ -343,8 +343,8 @@ describe('GoldbachBidAdapter', function () { if (FEATURES.VIDEO) { it('should parse all video bids to valid video imps (use video player size)', async function () { - let bidRequests = deepClone(validBidRequests); - let bidderRequest = deepClone(validBidderRequest); + const bidRequests = deepClone(validBidRequests); + const bidderRequest = deepClone(validBidderRequest); const request = spec.buildRequests([bidRequests[1]], await addFPDToBidderRequest(bidderRequest)); const payload = request.data; @@ -356,8 +356,8 @@ describe('GoldbachBidAdapter', function () { } it('should set custom config on request', function () { - let bidRequests = deepClone(validBidRequests); - let bidderRequest = deepClone(validBidderRequest); + const bidRequests = deepClone(validBidRequests); + const bidderRequest = deepClone(validBidderRequest); const request = spec.buildRequests(bidRequests, bidderRequest); const payload = request.data; @@ -365,8 +365,8 @@ describe('GoldbachBidAdapter', function () { }); it('should set gdpr on request', function () { - let bidRequests = deepClone(validBidRequests); - let bidderRequest = deepClone(validBidderRequest); + const bidRequests = deepClone(validBidRequests); + const bidderRequest = deepClone(validBidderRequest); const request = spec.buildRequests(bidRequests, bidderRequest); const payload = request.data; @@ -375,8 +375,8 @@ describe('GoldbachBidAdapter', function () { }); it('should set custom targeting on request', function () { - let bidRequests = deepClone(validBidRequests); - let bidderRequest = deepClone(validBidderRequest); + const bidRequests = deepClone(validBidRequests); + const bidderRequest = deepClone(validBidderRequest); const request = spec.buildRequests(bidRequests, bidderRequest); const payload = request.data; @@ -387,8 +387,8 @@ describe('GoldbachBidAdapter', function () { describe('interpretResponse', function () { it('should map response to valid bids (amount)', function () { - let bidRequest = spec.buildRequests(validBidRequests, validBidderRequest); - let bidResponse = deepClone({body: validOrtbBidResponse}); + const bidRequest = spec.buildRequests(validBidRequests, validBidderRequest); + const bidResponse = deepClone({body: validOrtbBidResponse}); const response = spec.interpretResponse(bidResponse, bidRequest); expect(response).to.exist; @@ -399,8 +399,8 @@ describe('GoldbachBidAdapter', function () { if (FEATURES.VIDEO) { it('should attach a custom video renderer ', function () { - let bidRequest = spec.buildRequests(validBidRequests, validBidderRequest); - let bidResponse = deepClone({body: validOrtbBidResponse}); + const bidRequest = spec.buildRequests(validBidRequests, validBidderRequest); + const bidResponse = deepClone({body: validOrtbBidResponse}); bidResponse.body.seatbid[0].bid[1].adm = ''; bidResponse.body.seatbid[0].bid[1].ext = { prebid: { type: 'video', meta: { type: 'video_outstream' } } }; const response = spec.interpretResponse(bidResponse, bidRequest); @@ -410,8 +410,8 @@ describe('GoldbachBidAdapter', function () { }); it('should set the player accordingly to config', function () { - let bidRequest = spec.buildRequests(validBidRequests, validBidderRequest); - let bidResponse = deepClone({body: validOrtbBidResponse}); + const bidRequest = spec.buildRequests(validBidRequests, validBidderRequest); + const bidResponse = deepClone({body: validOrtbBidResponse}); bidResponse.body.seatbid[0].bid[1].adm = ''; bidResponse.body.seatbid[0].bid[1].ext = { prebid: { type: 'video', meta: { type: 'video_outstream' } } }; validBidRequests[1].mediaTypes.video.playbackmethod = 1; @@ -426,8 +426,8 @@ describe('GoldbachBidAdapter', function () { } it('should not attach a custom video renderer when VAST url/xml is missing', function () { - let bidRequest = spec.buildRequests(validBidRequests, validBidderRequest); - let bidResponse = deepClone({body: validOrtbBidResponse}); + const bidRequest = spec.buildRequests(validBidRequests, validBidderRequest); + const bidResponse = deepClone({body: validOrtbBidResponse}); bidResponse.body.seatbid[0].bid[1].adm = undefined; bidResponse.body.seatbid[0].bid[1].ext = { prebid: { type: 'video', meta: { type: 'video_outstream' } } }; const response = spec.interpretResponse(bidResponse, bidRequest); @@ -439,13 +439,13 @@ describe('GoldbachBidAdapter', function () { describe('getUserSyncs', function () { it('user-syncs with enabled pixel option', function () { - let gdprConsent = { + const gdprConsent = { vendorData: { purpose: { consents: 1 } }}; - let syncOptions = {pixelEnabled: true, iframeEnabled: true}; + const syncOptions = {pixelEnabled: true, iframeEnabled: true}; const userSyncs = spec.getUserSyncs(syncOptions, {}, gdprConsent, {}); expect(userSyncs[0].type).to.equal('image'); @@ -454,13 +454,13 @@ describe('GoldbachBidAdapter', function () { }); it('user-syncs with enabled iframe option', function () { - let gdprConsent = { + const gdprConsent = { vendorData: { purpose: { consents: 1 } }}; - let syncOptions = {iframeEnabled: true}; + const syncOptions = {iframeEnabled: true}; const userSyncs = spec.getUserSyncs(syncOptions, {}, gdprConsent, {}); expect(userSyncs[0].type).to.equal('iframe'); @@ -469,7 +469,7 @@ describe('GoldbachBidAdapter', function () { }); it('user-syncs use gdpr signal', function () { - let gdprConsent = { + const gdprConsent = { gdprApplies: true, consentString: 'CPwk-qEPwk-qEH6AAAENCZCMAP_AAH_AAAAAI7Nd_X__bX9n-_7_6ft0eY1f9_r37uQzDhfNs-8F3L_W_LwX32E7NF36tq4KmR4ku1bBIQNtHMnUDUmxaolVrzHsak2cpyNKJ_JkknsZe2dYGF9Pn9lD-YKZ7_5_9_f52T_9_9_-39z3_9f___dv_-__-vjf_599n_v9fV_78_Kf9______-____________8Edmu_r__tr-z_f9_9P26PMav-_1793IZhwvm2feC7l_rfl4L77Cdmi79W1cFTI8SXatgkIG2jmTqBqTYtUSq15j2NSbOU5GlE_kyST2MvbOsDC-nz-yh_MFM9_8_-_v87J_-_-__b-57_-v___u3__f__Xxv_8--z_3-vq_9-flP-_______f___________-AA.II7Nd_X__bX9n-_7_6ft0eY1f9_r37uQzDhfNs-8F3L_W_LwX32E7NF36tq4KmR4ku1bBIQNtHMnUDUmxaolVrzHsak2cpyNKJ_JkknsZe2dYGF9Pn9lD-YKZ7_5_9_f52T_9_9_-39z3_9f___dv_-__-vjf_599n_v9fV_78_Kf9______-____________8A', vendorData: { @@ -478,7 +478,7 @@ describe('GoldbachBidAdapter', function () { } } }; - let synOptions = {pixelEnabled: true, iframeEnabled: true}; + const synOptions = {pixelEnabled: true, iframeEnabled: true}; const userSyncs = spec.getUserSyncs(synOptions, {}, gdprConsent, {}); expect(userSyncs[0].url).to.contain(`https://ib.adnxs.com/getuid?${ENDPOINT_COOKIESYNC}`); expect(userSyncs[0].url).to.contain('xandrId=$UID'); diff --git a/test/spec/modules/greenbidsBidAdapter_specs.js b/test/spec/modules/greenbidsBidAdapter_specs.js index 7a0e78ae858..7caf686776f 100644 --- a/test/spec/modules/greenbidsBidAdapter_specs.js +++ b/test/spec/modules/greenbidsBidAdapter_specs.js @@ -23,7 +23,7 @@ describe('greenbidsBidAdapter', () => { }); describe('isBidRequestValid', function () { - let bid = { + const bid = { 'bidder': 'greenbids', 'params': { 'placementId': 4242 @@ -41,14 +41,14 @@ describe('greenbidsBidAdapter', () => { }); it('should return false when required params are not found', function () { - let bidNonGbCompatible = { + const bidNonGbCompatible = { 'bidder': 'greenbids', }; expect(spec.isBidRequestValid(bidNonGbCompatible)).to.equal(false); }); it('should return false when the placement is not a number', function () { - let bidNonGbCompatible = { + const bidNonGbCompatible = { 'bidder': 'greenbids', 'params': { 'placementId': 'toto' @@ -73,8 +73,8 @@ describe('greenbidsBidAdapter', () => { }); it('should send US Privacy to endpoint', function () { - let usPrivacy = 'OHHHFCP1' - let bidderRequest = { + const usPrivacy = 'OHHHFCP1' + const bidderRequest = { 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', 'timeout': 3000, @@ -89,9 +89,9 @@ describe('greenbidsBidAdapter', () => { }); it('should send GPP values to endpoint when available and valid', function () { - let consentString = 'DBACNYA~CPXxRfAPXxRfAAfKABENB-CgAAAAAAAAAAYgAAAAAAAA~1YNN'; - let applicableSectionIds = [7, 8]; - let bidderRequest = { + const consentString = 'DBACNYA~CPXxRfAPXxRfAAfKABENB-CgAAAAAAAAAAYgAAAAAAAA~1YNN'; + const applicableSectionIds = [7, 8]; + const bidderRequest = { 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', 'timeout': 3000, @@ -110,7 +110,7 @@ describe('greenbidsBidAdapter', () => { }); it('should send default GPP values to endpoint when available but invalid', function () { - let bidderRequest = { + const bidderRequest = { 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', 'timeout': 3000, @@ -129,7 +129,7 @@ describe('greenbidsBidAdapter', () => { }); it('should not set the GPP object in the request sent to the endpoint when not present', function () { - let bidderRequest = { + const bidderRequest = { 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', 'timeout': 3000 @@ -142,8 +142,8 @@ describe('greenbidsBidAdapter', () => { }); it('should send GDPR to endpoint', function () { - let consentString = 'JRJ8RKfDeBNsERRDCSAAZ+A=='; - let bidderRequest = { + const consentString = 'JRJ8RKfDeBNsERRDCSAAZ+A=='; + const bidderRequest = { 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', 'timeout': 3000, @@ -565,8 +565,8 @@ describe('greenbidsBidAdapter', () => { }); it('should send GDPR to endpoint with 11 status', function () { - let consentString = 'JRJ8RKfDeBNsERRDCSAAZ+A=='; - let bidderRequest = { + const consentString = 'JRJ8RKfDeBNsERRDCSAAZ+A=='; + const bidderRequest = { 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', 'timeout': 3000, @@ -590,8 +590,8 @@ describe('greenbidsBidAdapter', () => { }); it('should send GDPR TCF2 to endpoint with 12 status', function () { - let consentString = 'JRJ8RKfDeBNsERRDCSAAZ+A=='; - let bidderRequest = { + const consentString = 'JRJ8RKfDeBNsERRDCSAAZ+A=='; + const bidderRequest = { 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', 'timeout': 3000, @@ -615,7 +615,7 @@ describe('greenbidsBidAdapter', () => { }); it('should send GDPR to endpoint with 22 status', function () { - let bidderRequest = { + const bidderRequest = { 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', 'timeout': 3000, @@ -637,8 +637,8 @@ describe('greenbidsBidAdapter', () => { }); it('should send GDPR to endpoint with 0 status', function () { - let consentString = 'JRJ8RKfDeBNsERRDCSAAZ+A=='; - let bidderRequest = { + const consentString = 'JRJ8RKfDeBNsERRDCSAAZ+A=='; + const bidderRequest = { 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', 'timeout': 3000, @@ -662,7 +662,7 @@ describe('greenbidsBidAdapter', () => { }); it('should send GDPR to endpoint with 0 status when gdprApplies = false (vendorData = undefined)', function () { - let bidderRequest = { + const bidderRequest = { 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', 'timeout': 3000, @@ -684,8 +684,8 @@ describe('greenbidsBidAdapter', () => { }); it('should send GDPR to endpoint with 12 status when apiVersion = 0', function () { - let consentString = 'JRJ8RKfDeBNsERRDCSAAZ+A=='; - let bidderRequest = { + const consentString = 'JRJ8RKfDeBNsERRDCSAAZ+A=='; + const bidderRequest = { 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', 'timeout': 3000, @@ -794,7 +794,7 @@ describe('greenbidsBidAdapter', () => { }); describe('Global Placement Id', function () { - let bidRequests = [ + const bidRequests = [ { 'bidder': 'greenbids', 'params': { @@ -917,7 +917,7 @@ describe('greenbidsBidAdapter', () => { describe('interpretResponse', function () { it('should get correct bid responses', function () { - let bids = { + const bids = { 'body': { 'responses': [{ 'ad': AD_SCRIPT, @@ -954,7 +954,7 @@ describe('greenbidsBidAdapter', () => { }] } }; - let expectedResponse = [ + const expectedResponse = [ { 'cpm': 0.5, 'width': 300, @@ -997,30 +997,30 @@ describe('greenbidsBidAdapter', () => { ] ; - let result = spec.interpretResponse(bids); + const result = spec.interpretResponse(bids); expect(result).to.eql(expectedResponse); }); it('handles nobid responses', function () { - let bids = { + const bids = { 'body': { 'responses': [] } }; - let result = spec.interpretResponse(bids); + const result = spec.interpretResponse(bids); expect(result.length).to.equal(0); }); }); }); -let bidderRequestDefault = { +const bidderRequestDefault = { 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', 'timeout': 3000 }; -let bidRequests = [ +const bidRequests = [ { 'bidder': 'greenbids', 'params': { diff --git a/test/spec/modules/greenbidsRtdProvider_spec.js b/test/spec/modules/greenbidsRtdProvider_spec.js index ae63a0b00a0..0074600df12 100644 --- a/test/spec/modules/greenbidsRtdProvider_spec.js +++ b/test/spec/modules/greenbidsRtdProvider_spec.js @@ -158,8 +158,8 @@ describe('greenbidsRtdProvider', () => { describe('getBidRequestData', () => { it('Callback is called if the server responds a 200 within the time limit', (done) => { - let requestBids = deepClone(SAMPLE_REQUEST_BIDS_CONFIG_OBJ); - let callback = sinon.stub(); + const requestBids = deepClone(SAMPLE_REQUEST_BIDS_CONFIG_OBJ); + const callback = sinon.stub(); greenbidsSubmodule.getBidRequestData(requestBids, callback, SAMPLE_MODULE_CONFIG); @@ -191,8 +191,8 @@ describe('greenbidsRtdProvider', () => { describe('getBidRequestData', () => { it('Nothing changes if the server times out but still the callback is called', (done) => { - let requestBids = deepClone(SAMPLE_REQUEST_BIDS_CONFIG_OBJ); - let callback = sinon.stub(); + const requestBids = deepClone(SAMPLE_REQUEST_BIDS_CONFIG_OBJ); + const callback = sinon.stub(); greenbidsSubmodule.getBidRequestData(requestBids, callback, SAMPLE_MODULE_CONFIG); @@ -218,8 +218,8 @@ describe('greenbidsRtdProvider', () => { describe('getBidRequestData', () => { it('callback is called if the server responds a 500 error within the time limit and no changes are made', (done) => { - let requestBids = deepClone(SAMPLE_REQUEST_BIDS_CONFIG_OBJ); - let callback = sinon.stub(); + const requestBids = deepClone(SAMPLE_REQUEST_BIDS_CONFIG_OBJ); + const callback = sinon.stub(); greenbidsSubmodule.getBidRequestData(requestBids, callback, SAMPLE_MODULE_CONFIG); diff --git a/test/spec/modules/gridBidAdapter_spec.js b/test/spec/modules/gridBidAdapter_spec.js index d35e8d8dbe8..5138a40ae42 100644 --- a/test/spec/modules/gridBidAdapter_spec.js +++ b/test/spec/modules/gridBidAdapter_spec.js @@ -14,7 +14,7 @@ describe('TheMediaGrid Adapter', function () { }); describe('isBidRequestValid', function () { - let bid = { + const bid = { 'bidder': 'grid', 'params': { 'uid': '1' @@ -30,7 +30,7 @@ describe('TheMediaGrid Adapter', function () { }); it('should return false when required params are not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = { 'uid': 0 @@ -56,7 +56,7 @@ describe('TheMediaGrid Adapter', function () { } }; const referrer = encodeURIComponent(bidderRequest.refererInfo.page); - let bidRequests = [ + const bidRequests = [ { 'bidder': 'grid', 'params': { @@ -449,7 +449,7 @@ describe('TheMediaGrid Adapter', function () { }); it('should add gpp information to the request via bidderRequest.gppConsent', function () { - let consentString = 'abc1234'; + const consentString = 'abc1234'; const gppBidderRequest = Object.assign({gppConsent: {gppString: consentString, applicableSections: [8]}}, bidderRequest); const [request] = spec.buildRequests(bidRequests, gppBidderRequest); @@ -461,7 +461,7 @@ describe('TheMediaGrid Adapter', function () { }); it('should add gpp information to the request via bidderRequest.ortb2.regs.gpp', function () { - let consentString = 'abc1234'; + const consentString = 'abc1234'; const gppBidderRequest = { ...bidderRequest, ortb2: { @@ -890,7 +890,7 @@ describe('TheMediaGrid Adapter', function () { const fpdUserIdNumVal = 2345543345; const getDataFromLocalStorageStub = sinon.stub(storage, 'getDataFromLocalStorage').callsFake( arg => arg === 'tmguid' ? fpdUserIdNumVal : null); - let bidRequestWithNumId = { + const bidRequestWithNumId = { 'bidder': 'grid', 'params': { 'uid': 1, @@ -1609,7 +1609,7 @@ describe('TheMediaGrid Adapter', function () { }); it('should register the Emily iframe', function () { - let syncs = spec.getUserSyncs({ + const syncs = spec.getUserSyncs({ pixelEnabled: true }); diff --git a/test/spec/modules/growadsBidAdapter_spec.js b/test/spec/modules/growadsBidAdapter_spec.js index ef2e9e4e9fa..75c5d241a62 100644 --- a/test/spec/modules/growadsBidAdapter_spec.js +++ b/test/spec/modules/growadsBidAdapter_spec.js @@ -85,43 +85,43 @@ describe('GrowAdvertising Adapter', function() { describe('implementation', function () { describe('for requests', function () { it('should accept valid bid', function () { - let validBid = { + const validBid = { bidder: 'growads', params: { zoneId: ZONE_ID } }; - let isValid = spec.isBidRequestValid(validBid); + const isValid = spec.isBidRequestValid(validBid); expect(isValid).to.equal(true); }); it('should reject null zoneId bid', function () { - let zoneNullBid = { + const zoneNullBid = { bidder: 'growads', params: { zoneId: null } }; - let isValid = spec.isBidRequestValid(zoneNullBid); + const isValid = spec.isBidRequestValid(zoneNullBid); expect(isValid).to.equal(false); }); it('should reject absent zoneId bid', function () { - let absentZoneBid = { + const absentZoneBid = { bidder: 'growads', params: { param: ZONE_ID } }; - let isValid = spec.isBidRequestValid(absentZoneBid); + const isValid = spec.isBidRequestValid(absentZoneBid); expect(isValid).to.equal(false); }); it('should use custom domain', function () { - let validBid = { + const validBid = { bidder: 'growads', params: { zoneId: ZONE_ID, @@ -129,24 +129,24 @@ describe('GrowAdvertising Adapter', function() { }, }; - let requests = spec.buildRequests([validBid]); + const requests = spec.buildRequests([validBid]); expect(requests[0].url).to.have.string('test.subdomain.'); }); it('should use default domain', function () { - let validBid = { + const validBid = { bidder: 'growads', params: { zoneId: ZONE_ID, }, }; - let requests = spec.buildRequests([validBid]); + const requests = spec.buildRequests([validBid]); expect(requests[0].url).to.have.string('portal.growadvertising.com'); }); it('should increment zone index', function () { - let validBids = [ + const validBids = [ { bidder: 'growads', params: { @@ -161,7 +161,7 @@ describe('GrowAdvertising Adapter', function() { } ]; - let requests = spec.buildRequests(validBids); + const requests = spec.buildRequests(validBids); expect(requests[0].data).to.include({i: 0}); expect(requests[1].data).to.include({i: 1}); }); @@ -170,7 +170,7 @@ describe('GrowAdvertising Adapter', function() { describe('bid responses', function () { describe(BANNER, function () { it('should return complete bid response banner', function () { - let bids = spec.interpretResponse(serverResponseBanner, {bidRequest: bidRequests[0]}); + const bids = spec.interpretResponse(serverResponseBanner, {bidRequest: bidRequests[0]}); expect(bids).to.be.lengthOf(1); expect(bids[0].bidderCode).to.equal('growads'); @@ -183,32 +183,32 @@ describe('GrowAdvertising Adapter', function() { }); it('should return empty bid on incorrect size', function () { - let response = utils.mergeDeep(serverResponseBanner, { + const response = utils.mergeDeep(serverResponseBanner, { body: { width: 150, height: 150 } }); - let bids = spec.interpretResponse(response, {bidRequest: bidRequests[0]}); + const bids = spec.interpretResponse(response, {bidRequest: bidRequests[0]}); expect([]).to.be.lengthOf(0); }); it('should return empty bid on incorrect CPM', function () { - let response = utils.mergeDeep(serverResponseBanner, { + const response = utils.mergeDeep(serverResponseBanner, { body: { cpm: 10 } }); - let bids = spec.interpretResponse(response, {bidRequest: bidRequests[0]}); + const bids = spec.interpretResponse(response, {bidRequest: bidRequests[0]}); expect([]).to.be.lengthOf(0); }); }); describe(NATIVE, function () { it('should return complete bid response banner', function () { - let bids = spec.interpretResponse(serverResponseNative, {bidRequest: bidRequests[1]}); + const bids = spec.interpretResponse(serverResponseNative, {bidRequest: bidRequests[1]}); expect(bids).to.be.lengthOf(1); expect(bids[0].bidderCode).to.equal('growads'); diff --git a/test/spec/modules/gumgumBidAdapter_spec.js b/test/spec/modules/gumgumBidAdapter_spec.js index 9c977335689..1ceaf4f2646 100644 --- a/test/spec/modules/gumgumBidAdapter_spec.js +++ b/test/spec/modules/gumgumBidAdapter_spec.js @@ -18,7 +18,7 @@ describe('gumgumAdapter', function () { }); describe('isBidRequestValid', function () { - let bid = { + const bid = { 'bidder': 'gumgum', 'params': { 'inScreen': '10433394', @@ -44,7 +44,7 @@ describe('gumgumAdapter', function () { }); it('should return true when required params found', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = { 'inSlot': '789' @@ -54,7 +54,7 @@ describe('gumgumAdapter', function () { }); it('should return true when inslot sends sizes and trackingid', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = { 'inSlot': '789', @@ -65,7 +65,7 @@ describe('gumgumAdapter', function () { }); it('should return false when no unit type is specified', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = { 'placementId': 0 @@ -74,7 +74,7 @@ describe('gumgumAdapter', function () { }); it('should return false when bidfloor is not a number', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = { 'inSlot': '789', @@ -99,7 +99,7 @@ describe('gumgumAdapter', function () { }); describe('buildRequests', function () { - let sizesArray = [[300, 250], [300, 600]]; + const sizesArray = [[300, 250], [300, 600]]; const bidderRequest = { ortb2: { site: { @@ -123,7 +123,7 @@ describe('gumgumAdapter', function () { } }; - let bidRequests = [ + const bidRequests = [ { gppString: 'DBACNYA~CPXxRfAPXxRfAAfKABENB-CgAAAAAAAAAAYgAAAAAAAA~1YNN', gppSid: [7], @@ -998,7 +998,7 @@ describe('gumgumAdapter', function () { }); it('handles nobid responses', function () { - let response = { + const response = { 'ad': {}, 'pag': { 't': 'ggumtest', @@ -1008,13 +1008,13 @@ describe('gumgumAdapter', function () { }, 'thms': 10000 } - let result = spec.interpretResponse({ body: response }, bidRequest); + const result = spec.interpretResponse({ body: response }, bidRequest); expect(result.length).to.equal(0); }); it('handles empty response', function () { let body; - let result = spec.interpretResponse({ body }, bidRequest); + const result = spec.interpretResponse({ body }, bidRequest); expect(result.length).to.equal(0); }); @@ -1027,7 +1027,7 @@ describe('gumgumAdapter', function () { }); it('returns 1x1 when eligible product and size are available', function () { - let bidRequest = { + const bidRequest = { id: 12346, sizes: [[300, 250], [1, 1]], url: ENDPOINT, @@ -1037,7 +1037,7 @@ describe('gumgumAdapter', function () { t: 'ggumtest' } } - let serverResponse = { + const serverResponse = { 'ad': { 'id': 2065333, 'height': 90, @@ -1056,7 +1056,7 @@ describe('gumgumAdapter', function () { }, 'thms': 10000 } - let result = spec.interpretResponse({ body: serverResponse }, bidRequest); + const result = spec.interpretResponse({ body: serverResponse }, bidRequest); expect(result[0].width).to.equal('1'); expect(result[0].height).to.equal('1'); }); @@ -1146,7 +1146,7 @@ describe('gumgumAdapter', function () { ] } } - let result = spec.getUserSyncs(syncOptions, [{ body: response }]); + const result = spec.getUserSyncs(syncOptions, [{ body: response }]); expect(result[0].type).to.equal('image') expect(result[1].type).to.equal('iframe') }) diff --git a/test/spec/modules/hadronRtdProvider_spec.js b/test/spec/modules/hadronRtdProvider_spec.js index 46877f246b5..f93a1cc4c34 100644 --- a/test/spec/modules/hadronRtdProvider_spec.js +++ b/test/spec/modules/hadronRtdProvider_spec.js @@ -31,7 +31,7 @@ describe('hadronRtdProvider', function () { describe('Add Real-Time Data', function () { it('merges ortb2 data', function () { - let rtdConfig = {}; + const rtdConfig = {}; const setConfigUserObj1 = { name: 'www.dataprovider1.com', @@ -64,7 +64,7 @@ describe('hadronRtdProvider', function () { ] } - let bidConfig = { + const bidConfig = { ortb2Fragments: { global: { user: { @@ -124,14 +124,14 @@ describe('hadronRtdProvider', function () { addRealTimeData(bidConfig, rtd, rtdConfig); - let ortb2Config = bidConfig.ortb2Fragments.global; + const ortb2Config = bidConfig.ortb2Fragments.global; expect(ortb2Config.user.data).to.deep.include.members([setConfigUserObj1, setConfigUserObj2, rtdUserObj1]); expect(ortb2Config.site.content.data).to.deep.include.members([setConfigSiteObj1, rtdSiteObj1]); }); it('merges ortb2 data without duplication', function () { - let rtdConfig = {}; + const rtdConfig = {}; const userObj1 = { name: 'www.dataprovider1.com', @@ -164,7 +164,7 @@ describe('hadronRtdProvider', function () { ] } - let bidConfig = { + const bidConfig = { ortb2Fragments: { global: { user: { @@ -194,7 +194,7 @@ describe('hadronRtdProvider', function () { addRealTimeData(bidConfig, rtd, rtdConfig); - let ortb2Config = bidConfig.ortb2Fragments.global; + const ortb2Config = bidConfig.ortb2Fragments.global; expect(ortb2Config.user.data).to.deep.include.members([userObj1, userObj2]); expect(ortb2Config.site.content.data).to.deep.include.members([siteObj1]); @@ -203,7 +203,7 @@ describe('hadronRtdProvider', function () { }); it('merges bidder-specific ortb2 data', function () { - let rtdConfig = {}; + const rtdConfig = {}; const configUserObj1 = { name: 'www.dataprovider1.com', @@ -256,7 +256,7 @@ describe('hadronRtdProvider', function () { ] }; - let bidConfig = { + const bidConfig = { ortb2Fragments: { bidder: { adbuzz: { @@ -380,7 +380,7 @@ describe('hadronRtdProvider', function () { }); it('merges bidder-specific ortb2 data without duplication', function () { - let rtdConfig = {}; + const rtdConfig = {}; const userObj1 = { name: 'www.dataprovider1.com', @@ -433,7 +433,7 @@ describe('hadronRtdProvider', function () { ] }; - let bidConfig = { + const bidConfig = { ortb2Fragments: { bidder: { adbuzz: { @@ -521,7 +521,7 @@ describe('hadronRtdProvider', function () { } }; - let bidConfig = {}; + const bidConfig = {}; const rtdUserObj1 = { name: 'www.dataprovider.com', @@ -585,8 +585,8 @@ describe('hadronRtdProvider', function () { bid.adBuzzData.segments.adBuzz.push(rtd.adBuzz[k]); } } else if (bid.bidder == 'trueBid') { - for (var k = 0; k < rtd.trueBid.length; k++) { - bid.trueBidSegments.push(rtd.trueBid[k]); + for (var m = 0; m < rtd.trueBid.length; m++) { + bid.trueBidSegments.push(rtd.trueBid[m]); } } } @@ -595,7 +595,7 @@ describe('hadronRtdProvider', function () { } }; - let bidConfig = { + const bidConfig = { adUnits: [ { bids: [ @@ -704,7 +704,7 @@ describe('hadronRtdProvider', function () { } }; - let bidConfig = { + const bidConfig = { ortb2Fragments: { global: { site: { @@ -744,8 +744,8 @@ describe('hadronRtdProvider', function () { getDataFromLocalStorageStub.withArgs(HADRONID_LOCAL_NAME).returns('testHadronId1'); getRealTimeData(bidConfig, () => { - let request = server.requests[0]; - let postData = JSON.parse(request.requestBody); + const request = server.requests[0]; + const postData = JSON.parse(request.requestBody); expect(postData.config).to.have.deep.property('publisherId', 'testPub1'); expect(postData.userIds).to.have.deep.property('hadronId', 'testHadronId1'); request.respond(200, responseHeader, JSON.stringify(data)); diff --git a/test/spec/modules/hypelabBidAdapter_spec.js b/test/spec/modules/hypelabBidAdapter_spec.js index 2339a3d7e08..21f679cbeac 100644 --- a/test/spec/modules/hypelabBidAdapter_spec.js +++ b/test/spec/modules/hypelabBidAdapter_spec.js @@ -281,7 +281,7 @@ describe('hypelabBidAdapter', function () { }); describe('callbacks', () => { - let bid = {}; + const bid = {}; let reportStub; beforeEach(() => (reportStub = sinon.stub(spec, 'report'))); diff --git a/test/spec/modules/id5IdSystem_spec.js b/test/spec/modules/id5IdSystem_spec.js index 4d093e9b831..6d7a39954a0 100644 --- a/test/spec/modules/id5IdSystem_spec.js +++ b/test/spec/modules/id5IdSystem_spec.js @@ -831,17 +831,17 @@ describe('ID5 ID System', function () { }); it('should pass gpp_string and gpp_sid to ID5 server', function () { - let xhrServerMock = new XhrServerMock(server); + const xhrServerMock = new XhrServerMock(server); const gppData = { ready: true, gppString: 'GPP_STRING', applicableSections: [2] }; - let submoduleResponse = callSubmoduleGetId(getId5FetchConfig(), {gpp: gppData}, ID5_STORED_OBJ); + const submoduleResponse = callSubmoduleGetId(getId5FetchConfig(), {gpp: gppData}, ID5_STORED_OBJ); return xhrServerMock.expectFetchRequest() .then(fetchRequest => { - let requestBody = JSON.parse(fetchRequest.requestBody); + const requestBody = JSON.parse(fetchRequest.requestBody); expect(requestBody.gpp_string).is.equal('GPP_STRING'); expect(requestBody.gpp_sid).contains(2); fetchRequest.respond(200, responseHeader, JSON.stringify(ID5_JSON_RESPONSE)); @@ -865,12 +865,12 @@ describe('ID5 ID System', function () { }); it('should pass true link info to ID5 server even when true link is not booted', function () { - let xhrServerMock = new XhrServerMock(server); - let submoduleResponse = callSubmoduleGetId(getId5FetchConfig(), undefined, ID5_STORED_OBJ); + const xhrServerMock = new XhrServerMock(server); + const submoduleResponse = callSubmoduleGetId(getId5FetchConfig(), undefined, ID5_STORED_OBJ); return xhrServerMock.expectFetchRequest() .then(fetchRequest => { - let requestBody = JSON.parse(fetchRequest.requestBody); + const requestBody = JSON.parse(fetchRequest.requestBody); expect(requestBody.true_link).is.eql({booted: false}); fetchRequest.respond(200, responseHeader, JSON.stringify(ID5_JSON_RESPONSE)); return submoduleResponse; @@ -878,18 +878,18 @@ describe('ID5 ID System', function () { }); it('should pass full true link info to ID5 server when true link is booted', function () { - let xhrServerMock = new XhrServerMock(server); - let trueLinkResponse = {booted: true, redirected: true, id: 'TRUE_LINK_ID'}; + const xhrServerMock = new XhrServerMock(server); + const trueLinkResponse = {booted: true, redirected: true, id: 'TRUE_LINK_ID'}; window.id5Bootstrap = { getTrueLinkInfo: function () { return trueLinkResponse; } }; - let submoduleResponse = callSubmoduleGetId(getId5FetchConfig(), undefined, ID5_STORED_OBJ); + const submoduleResponse = callSubmoduleGetId(getId5FetchConfig(), undefined, ID5_STORED_OBJ); return xhrServerMock.expectFetchRequest() .then(fetchRequest => { - let requestBody = JSON.parse(fetchRequest.requestBody); + const requestBody = JSON.parse(fetchRequest.requestBody); expect(requestBody.true_link).is.eql(trueLinkResponse); fetchRequest.respond(200, responseHeader, JSON.stringify(ID5_JSON_RESPONSE)); return submoduleResponse; @@ -929,7 +929,7 @@ describe('ID5 ID System', function () { }); describe('Request Bids Hook', function () { - let adUnits; + let adUnits, ortb2Fragments; let sandbox; beforeEach(function () { @@ -940,6 +940,9 @@ describe('ID5 ID System', function () { coreStorage.removeDataFromLocalStorage(`${id5System.ID5_STORAGE_NAME}_last`); coreStorage.setDataInLocalStorage(id5System.ID5_STORAGE_NAME + '_cst', getConsentHash()); adUnits = [getAdUnitMock()]; + ortb2Fragments = { + global: {} + } }); afterEach(function () { events.getEvents.restore(); @@ -958,22 +961,18 @@ describe('ID5 ID System', function () { config.setConfig(getFetchLocalStorageConfig()); startAuctionHook(wrapAsyncExpects(done, () => { - adUnits.forEach(unit => { - unit.bids.forEach(bid => { - expect(bid.userIdAsEids[0]).is.eql({ - source: ID5_SOURCE, - uids: [{ - id: ID5_STORED_ID, - atype: 1, - ext: { - linkType: ID5_STORED_LINK_TYPE - } - }] - }); - }); + expect(ortb2Fragments.global.user.ext.eids[0]).is.eql({ + source: ID5_SOURCE, + uids: [{ + id: ID5_STORED_ID, + atype: 1, + ext: { + linkType: ID5_STORED_LINK_TYPE + } + }] }); done(); - }), {adUnits}); + }), {ortb2Fragments}); }); it('should add stored EUID from cache to bids', function (done) { @@ -984,23 +983,19 @@ describe('ID5 ID System', function () { config.setConfig(getFetchLocalStorageConfig()); startAuctionHook(function () { - adUnits.forEach(unit => { - unit.bids.forEach(bid => { - expect(bid.userIdAsEids[0].uids[0].id).is.equal(ID5_STORED_ID); - expect(bid.userIdAsEids[1]).is.eql({ - source: EUID_SOURCE, - uids: [{ - id: EUID_STORED_ID, - atype: 3, - ext: { - provider: ID5_SOURCE - } - }] - }); - }); + expect(ortb2Fragments.global.user.ext.eids[0].uids[0].id).is.equal(ID5_STORED_ID); + expect(ortb2Fragments.global.user.ext.eids[1]).is.eql({ + source: EUID_SOURCE, + uids: [{ + id: EUID_STORED_ID, + atype: 3, + ext: { + provider: ID5_SOURCE + } + }] }); done(); - }, {adUnits}); + }, {ortb2Fragments}); }); it('should add stored TRUE_LINK_ID from cache to bids', function (done) { @@ -1011,31 +1006,27 @@ describe('ID5 ID System', function () { config.setConfig(getFetchLocalStorageConfig()); startAuctionHook(wrapAsyncExpects(done, function () { - adUnits.forEach(unit => { - unit.bids.forEach(bid => { - expect(bid.userIdAsEids[1]).is.eql({ - source: TRUE_LINK_SOURCE, - uids: [{ - id: TRUE_LINK_STORED_ID, - atype: 1 - }] - }); - }); + expect(ortb2Fragments.global.user.ext.eids[1]).is.eql({ + source: TRUE_LINK_SOURCE, + uids: [{ + id: TRUE_LINK_STORED_ID, + atype: 1 + }] }); done(); - }), {adUnits}); + }), {ortb2Fragments}); }); }); it('should call ID5 servers with signature and incremented nb post auction if refresh needed', function () { const xhrServerMock = new XhrServerMock(server); - let storedObject = ID5_STORED_OBJ; + const storedObject = ID5_STORED_OBJ; storedObject.nbPage = 1; const initialLocalStorageValue = JSON.stringify(storedObject); storeInStorage(id5System.ID5_STORAGE_NAME, initialLocalStorageValue, 1); storeInStorage(`${id5System.ID5_STORAGE_NAME}_last`, expDaysStr(-1), 1); - let id5Config = getFetchLocalStorageConfig(); + const id5Config = getFetchLocalStorageConfig(); id5Config.userSync.userIds[0].storage.refreshInSeconds = 2; id5Config.userSync.auctionDelay = 0; // do not trigger callback before auction init(config); @@ -1058,6 +1049,8 @@ describe('ID5 ID System', function () { }); describe('when request with "ids" object stored', function () { + // FIXME: all these tests involve base userId logic + // (which already has its own tests, so these make it harder to refactor it) it('should add stored ID from cache to bids - from ids', function (done) { storeInStorage(id5System.ID5_STORAGE_NAME, JSON.stringify(ID5_STORED_OBJ_WITH_IDS_ID5ID_ONLY), 1); @@ -1066,21 +1059,18 @@ describe('ID5 ID System', function () { config.setConfig(getFetchLocalStorageConfig()); const id5IdEidUid = IDS_ID5ID.eid.uids[0]; startAuctionHook(wrapAsyncExpects(done, () => { - adUnits.forEach(unit => { - unit.bids.forEach(bid => { - expect(bid.userIdAsEids[0]).is.eql({ - source: IDS_ID5ID.eid.source, - uids: [{ - id: id5IdEidUid.id, - atype: id5IdEidUid.atype, - ext: id5IdEidUid.ext - }] - }); - }); + expect(ortb2Fragments.global.user.ext.eids[0]).is.eql({ + source: IDS_ID5ID.eid.source, + uids: [{ + id: id5IdEidUid.id, + atype: id5IdEidUid.atype, + ext: id5IdEidUid.ext + }] }); done(); - }), {adUnits}); + }), {ortb2Fragments}); }); + it('should add stored EUID from cache to bids - from ids', function (done) { storeInStorage(id5System.ID5_STORAGE_NAME, JSON.stringify({ ...ID5_STORED_OBJ, @@ -1095,14 +1085,11 @@ describe('ID5 ID System', function () { config.setConfig(getFetchLocalStorageConfig()); startAuctionHook(wrapAsyncExpects(done, () => { - adUnits.forEach(unit => { - unit.bids.forEach(bid => { - expect(bid.userIdAsEids[0]).is.eql(IDS_ID5ID.eid); - expect(bid.userIdAsEids[1]).is.eql(IDS_EUID.eid); - }); - }); + const eids = ortb2Fragments.global.user.ext.eids; + expect(eids[0]).is.eql(IDS_ID5ID.eid); + expect(eids[1]).is.eql(IDS_EUID.eid); done(); - }), {adUnits}); + }), {ortb2Fragments}); }); it('should add stored TRUE_LINK_ID from cache to bids - from ids', function (done) { @@ -1119,13 +1106,9 @@ describe('ID5 ID System', function () { config.setConfig(getFetchLocalStorageConfig()); startAuctionHook(wrapAsyncExpects(done, function () { - adUnits.forEach(unit => { - unit.bids.forEach(bid => { - expect(bid.userIdAsEids[1]).is.eql(IDS_TRUE_LINK_ID.eid); - }); - }); + expect(ortb2Fragments.global.user.ext.eids[1]).is.eql(IDS_TRUE_LINK_ID.eid); done(); - }), {adUnits}); + }), {ortb2Fragments}); }); it('should add other id from cache to bids', function (done) { @@ -1158,23 +1141,19 @@ describe('ID5 ID System', function () { config.setConfig(getFetchLocalStorageConfig()); startAuctionHook(wrapAsyncExpects(done, function () { - adUnits.forEach(unit => { - unit.bids.forEach(bid => { - expect(bid.userIdAsEids[1]).is.eql({ - source: 'other-id.com', - inserter: 'id5-sync.com', - uids: [{ - id: 'other-id-value', - atype: 2, - ext: { - provider: 'id5-sync.com' - } - }] - }); - }); + expect(ortb2Fragments.global.user.ext.eids[1]).is.eql({ + source: 'other-id.com', + inserter: 'id5-sync.com', + uids: [{ + id: 'other-id-value', + atype: 2, + ext: { + provider: 'id5-sync.com' + } + }] }); done(); - }), {adUnits}); + }), {ortb2Fragments}); }); }); }); @@ -1209,7 +1188,7 @@ describe('ID5 ID System', function () { }); it('should decode all ids from a stored object with ids', function () { - let decoded = id5System.id5IdSubmodule.decode(ID5_STORED_OBJ_WITH_IDS_ALL, getId5FetchConfig()); + const decoded = id5System.id5IdSubmodule.decode(ID5_STORED_OBJ_WITH_IDS_ALL, getId5FetchConfig()); expect(decoded.id5id).is.eql({ uid: IDS_ID5ID.eid.uids[0].id, ext: IDS_ID5ID.eid.uids[0].ext diff --git a/test/spec/modules/idImportLibrary_spec.js b/test/spec/modules/idImportLibrary_spec.js index 70485773b12..4604d7ea465 100644 --- a/test/spec/modules/idImportLibrary_spec.js +++ b/test/spec/modules/idImportLibrary_spec.js @@ -20,7 +20,7 @@ const mockMutationObserver = { describe('IdImportLibrary Tests', function () { let sandbox; let clock; - let fn = sinon.spy(); + const fn = sinon.spy(); before(() => { hook.ready(); @@ -64,29 +64,29 @@ describe('IdImportLibrary Tests', function () { sinon.assert.called(utils.logInfo); }); it('results with config debounce ', function () { - let config = { 'url': 'URL', 'debounce': 300 } + const config = { 'url': 'URL', 'debounce': 300 } idImportlibrary.setConfig(config); expect(config.debounce).to.be.equal(300); }); it('results with config default debounce ', function () { - let config = { 'url': 'URL' } + const config = { 'url': 'URL' } idImportlibrary.setConfig(config); expect(config.debounce).to.be.equal(250); }); it('results with config default fullscan ', function () { - let config = { 'url': 'URL', 'debounce': 0 } + const config = { 'url': 'URL', 'debounce': 0 } idImportlibrary.setConfig(config); expect(config.fullscan).to.be.equal(false); }); it('results with config fullscan ', function () { - let config = { 'url': 'URL', 'fullscan': true, 'debounce': 0 } + const config = { 'url': 'URL', 'fullscan': true, 'debounce': 0 } idImportlibrary.setConfig(config); expect(config.fullscan).to.be.equal(true); expect(config.inputscan).to.be.equal(false); }); it('results with config inputscan ', function () { - let config = { 'inputscan': true, 'debounce': 0 } + const config = { 'inputscan': true, 'debounce': 0 } idImportlibrary.setConfig(config); expect(config.inputscan).to.be.equal(true); }); @@ -94,7 +94,7 @@ describe('IdImportLibrary Tests', function () { sandbox.stub(activities, 'isActivityAllowed').callsFake((activity) => { return !(activity === ACTIVITY_ENRICH_UFPD); }); - let config = { 'url': 'URL', 'debounce': 0 }; + const config = { 'url': 'URL', 'debounce': 0 }; idImportlibrary.setConfig(config); sinon.assert.called(utils.logError); expect(config.inputscan).to.be.not.equal(CONF_DEFAULT_INPUT_SCAN); @@ -106,7 +106,7 @@ describe('IdImportLibrary Tests', function () { let userId; let refreshUserIdSpy; beforeEach(function() { - let sandbox = sinon.createSandbox(); + const sandbox = sinon.createSandbox(); refreshUserIdSpy = sinon.stub(getGlobal(), 'refreshUserIds'); clock = sinon.useFakeTimers(1046952000000); // 2003-03-06T12:00:00Z mutationObserverStub = sinon.stub(window, 'MutationObserver').returns(mockMutationObserver); @@ -130,7 +130,7 @@ describe('IdImportLibrary Tests', function () { it('results with config fullscan with email found in html ', function () { document.body.innerHTML = '
test@test.com
'; - let config = { 'url': 'URL', 'fullscan': true, 'debounce': 0 } + const config = { 'url': 'URL', 'fullscan': true, 'debounce': 0 } idImportlibrary.setConfig(config); expect(config.fullscan).to.be.equal(true); expect(config.inputscan).to.be.equal(false); @@ -139,7 +139,7 @@ describe('IdImportLibrary Tests', function () { it('results with config fullscan with no email found in html ', function () { document.body.innerHTML = '
test
'; - let config = { 'url': 'URL', 'fullscan': true, 'debounce': 0 } + const config = { 'url': 'URL', 'fullscan': true, 'debounce': 0 } idImportlibrary.setConfig(config); expect(config.fullscan).to.be.equal(true); expect(config.inputscan).to.be.equal(false); @@ -147,7 +147,7 @@ describe('IdImportLibrary Tests', function () { }); it('results with config formElementId without listner ', function () { - let config = { url: 'testUrl', 'formElementId': 'userid', 'debounce': 0 } + const config = { url: 'testUrl', 'formElementId': 'userid', 'debounce': 0 } document.body.innerHTML = ''; idImportlibrary.setConfig(config); expect(config.formElementId).to.be.equal('userid'); @@ -155,7 +155,7 @@ describe('IdImportLibrary Tests', function () { }); it('results with config formElementId with listner ', function () { - let config = { url: 'testUrl', 'formElementId': 'userid', 'debounce': 0 } + const config = { url: 'testUrl', 'formElementId': 'userid', 'debounce': 0 } document.body.innerHTML = ''; idImportlibrary.setConfig(config); expect(config.formElementId).to.be.equal('userid'); @@ -163,14 +163,14 @@ describe('IdImportLibrary Tests', function () { }); it('results with config target without listner ', function () { - let config = { url: 'testUrl', 'target': 'userid', 'debounce': 0 } + const config = { url: 'testUrl', 'target': 'userid', 'debounce': 0 } document.body.innerHTML = '
test@test.com
'; idImportlibrary.setConfig(config); expect(config.target).to.be.equal('userid'); expect(refreshUserIdSpy.calledOnce).to.equal(true); }); it('results with config target with listner ', function () { - let config = { url: 'testUrl', 'target': 'userid', 'debounce': 0 } + const config = { url: 'testUrl', 'target': 'userid', 'debounce': 0 } document.body.innerHTML = '
'; idImportlibrary.setConfig(config); @@ -179,21 +179,21 @@ describe('IdImportLibrary Tests', function () { }); it('results with config target with listner', function () { - let config = { url: 'testUrl', 'target': 'userid', 'debounce': 0 } + const config = { url: 'testUrl', 'target': 'userid', 'debounce': 0 } idImportlibrary.setConfig(config); document.body.innerHTML = '
test@test.com
'; expect(config.target).to.be.equal('userid'); expect(refreshUserIdSpy.calledOnce).to.equal(false); }); it('results with config fullscan ', function () { - let config = { url: 'testUrl', 'fullscan': true, 'debounce': 0 } + const config = { url: 'testUrl', 'fullscan': true, 'debounce': 0 } idImportlibrary.setConfig(config); document.body.innerHTML = '
'; expect(config.fullscan).to.be.equal(true); expect(refreshUserIdSpy.calledOnce).to.equal(false); }); it('results with config inputscan with listner', function () { - let config = { url: 'testUrl', 'inputscan': true, 'debounce': 0 } + const config = { url: 'testUrl', 'inputscan': true, 'debounce': 0 } var input = document.createElement('input'); input.setAttribute('type', 'text'); document.body.appendChild(input); @@ -206,7 +206,7 @@ describe('IdImportLibrary Tests', function () { }); it('results with config inputscan with listner and no user ids ', function () { - let config = { 'url': 'testUrl', 'inputscan': true, 'debounce': 0 } + const config = { 'url': 'testUrl', 'inputscan': true, 'debounce': 0 } document.body.innerHTML = ''; idImportlibrary.setConfig(config); expect(config.inputscan).to.be.equal(true); @@ -214,7 +214,7 @@ describe('IdImportLibrary Tests', function () { }); it('results with config inputscan with listner ', function () { - let config = { 'url': 'testUrl', 'inputscan': true, 'debounce': 0 } + const config = { 'url': 'testUrl', 'inputscan': true, 'debounce': 0 } document.body.innerHTML = ''; idImportlibrary.setConfig(config); expect(config.inputscan).to.be.equal(true); @@ -222,7 +222,7 @@ describe('IdImportLibrary Tests', function () { }); it('results with config inputscan without listner ', function () { - let config = { 'url': 'testUrl', 'inputscan': true, 'debounce': 0 } + const config = { 'url': 'testUrl', 'inputscan': true, 'debounce': 0 } document.body.innerHTML = ''; idImportlibrary.setConfig(config); expect(config.inputscan).to.be.equal(true); @@ -234,7 +234,7 @@ describe('IdImportLibrary Tests', function () { let userId; let jsonSpy; beforeEach(function() { - let sandbox = sinon.createSandbox(); + const sandbox = sinon.createSandbox(); clock = sinon.useFakeTimers(1046952000000); // 2003-03-06T12:00:00Z mutationObserverStub = sinon.stub(window, 'MutationObserver'); jsonSpy = sinon.spy(JSON, 'stringify'); @@ -253,14 +253,14 @@ describe('IdImportLibrary Tests', function () { mutationObserverStub.restore(); }); it('results with config inputscan without listner with no user ids #1', function () { - let config = { 'url': 'testUrl', 'inputscan': true, 'debounce': 0 } + const config = { 'url': 'testUrl', 'inputscan': true, 'debounce': 0 } document.body.innerHTML = ''; idImportlibrary.setConfig(config); expect(config.inputscan).to.be.equal(true); expect(jsonSpy.calledOnce).to.equal(false); }); it('results with config inputscan without listner with no user ids #2', function () { - let config = { 'url': 'testUrl', 'inputscan': true, 'debounce': 0 } + const config = { 'url': 'testUrl', 'inputscan': true, 'debounce': 0 } document.body.innerHTML = ''; idImportlibrary.setConfig(config); expect(config.inputscan).to.be.equal(true); diff --git a/test/spec/modules/identityLinkIdSystem_spec.js b/test/spec/modules/identityLinkIdSystem_spec.js index 7afec3be1aa..fddca301e36 100644 --- a/test/spec/modules/identityLinkIdSystem_spec.js +++ b/test/spec/modules/identityLinkIdSystem_spec.js @@ -16,7 +16,7 @@ const testEnvelope = 'eyJ0aW1lc3RhbXAiOjE2OTEwNjU5MzQwMTcsInZlcnNpb24iOiIxLjIuMS const testEnvelopeValue = '{"timestamp":1691065934017,"version":"1.2.1","envelope":"AhHzu20SwXvzOHOww6nLZ80-whh7cgwAjZYMvD4R0WOnqEW57msGekj_Pz56oQppgO9PvhREkuGsiLtnzsp6hmwx4mM4M-7-G-v6"}'; function setTestEnvelopeCookie () { - let now = new Date(); + const now = new Date(); now.setTime(now.getTime() + 3000); storage.setCookie('_lr_env', testEnvelope, now.toUTCString()); } @@ -50,10 +50,10 @@ describe('IdentityLinkId tests', function () { }); it('should call the LiveRamp envelope endpoint', function () { - let callBackSpy = sinon.spy(); - let submoduleCallback = identityLinkSubmodule.getId(defaultConfigParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = identityLinkSubmodule.getId(defaultConfigParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.be.eq('https://api.rlcdn.com/api/identity/envelope?pid=14'); request.respond( 200, @@ -64,32 +64,32 @@ describe('IdentityLinkId tests', function () { }); it('should NOT call the LiveRamp envelope endpoint if gdpr applies but consent string is empty string', function () { - let consentData = { + const consentData = { gdprApplies: true, consentString: '' }; - let submoduleCallback = identityLinkSubmodule.getId(defaultConfigParams, {gdpr: consentData}); + const submoduleCallback = identityLinkSubmodule.getId(defaultConfigParams, {gdpr: consentData}); expect(submoduleCallback).to.be.undefined; }); it('should NOT call the LiveRamp envelope endpoint if gdpr applies but consent string is missing', function () { - let consentData = { gdprApplies: true }; - let submoduleCallback = identityLinkSubmodule.getId(defaultConfigParams, {gdpr: consentData}); + const consentData = { gdprApplies: true }; + const submoduleCallback = identityLinkSubmodule.getId(defaultConfigParams, {gdpr: consentData}); expect(submoduleCallback).to.be.undefined; }); it('should call the LiveRamp envelope endpoint with IAB consent string v2', function () { - let callBackSpy = sinon.spy(); - let consentData = { + const callBackSpy = sinon.spy(); + const consentData = { gdprApplies: true, consentString: 'CO4VThZO4VTiuADABBENAzCgAP_AAEOAAAAAAwwAgAEABhAAgAgAAA.YAAAAAAAAAA', vendorData: { tcfPolicyVersion: 2 } }; - let submoduleCallback = identityLinkSubmodule.getId(defaultConfigParams, {gdpr: consentData}).callback; + const submoduleCallback = identityLinkSubmodule.getId(defaultConfigParams, {gdpr: consentData}).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.be.eq('https://api.rlcdn.com/api/identity/envelope?pid=14&ct=4&cv=CO4VThZO4VTiuADABBENAzCgAP_AAEOAAAAAAwwAgAEABhAAgAgAAA.YAAAAAAAAAA'); request.respond( 200, @@ -105,10 +105,10 @@ describe('IdentityLinkId tests', function () { gppString: 'DBABLA~BVVqAAAACqA.QA', applicableSections: [7] }; - let callBackSpy = sinon.spy(); - let submoduleCallback = identityLinkSubmodule.getId(defaultConfigParams, {gpp: gppData}).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = identityLinkSubmodule.getId(defaultConfigParams, {gpp: gppData}).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.be.eq('https://api.rlcdn.com/api/identity/envelope?pid=14&gpp=DBABLA~BVVqAAAACqA.QA&gpp_sid=7'); request.respond( 200, @@ -124,10 +124,10 @@ describe('IdentityLinkId tests', function () { gppString: '', applicableSections: [7] }; - let callBackSpy = sinon.spy(); - let submoduleCallback = identityLinkSubmodule.getId(defaultConfigParams, {gpp: gppData}).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = identityLinkSubmodule.getId(defaultConfigParams, {gpp: gppData}).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.be.eq('https://api.rlcdn.com/api/identity/envelope?pid=14'); request.respond( 200, @@ -138,10 +138,10 @@ describe('IdentityLinkId tests', function () { }); it('should not throw Uncaught TypeError when envelope endpoint returns empty response', function () { - let callBackSpy = sinon.spy(); - let submoduleCallback = identityLinkSubmodule.getId(defaultConfigParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = identityLinkSubmodule.getId(defaultConfigParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.be.eq('https://api.rlcdn.com/api/identity/envelope?pid=14'); request.respond( 204, @@ -152,10 +152,10 @@ describe('IdentityLinkId tests', function () { }); it('should log an error and continue to callback if ajax request errors', function () { - let callBackSpy = sinon.spy(); - let submoduleCallback = identityLinkSubmodule.getId(defaultConfigParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = identityLinkSubmodule.getId(defaultConfigParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.be.eq('https://api.rlcdn.com/api/identity/envelope?pid=14'); request.respond( 503, @@ -166,21 +166,21 @@ describe('IdentityLinkId tests', function () { }); it('should not call the LiveRamp envelope endpoint if cookie _lr_retry_request exist', function () { - let now = new Date(); + const now = new Date(); now.setTime(now.getTime() + 3000); storage.setCookie('_lr_retry_request', 'true', now.toUTCString()); - let callBackSpy = sinon.spy(); - let submoduleCallback = identityLinkSubmodule.getId(defaultConfigParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = identityLinkSubmodule.getId(defaultConfigParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request).to.be.eq(undefined); }); it('should call the LiveRamp envelope endpoint if cookie _lr_retry_request does not exist and notUse3P config property was not set', function () { - let callBackSpy = sinon.spy(); - let submoduleCallback = identityLinkSubmodule.getId(defaultConfigParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = identityLinkSubmodule.getId(defaultConfigParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.be.eq('https://api.rlcdn.com/api/identity/envelope?pid=14'); request.respond( 200, @@ -192,18 +192,18 @@ describe('IdentityLinkId tests', function () { it('should not call the LiveRamp envelope endpoint if config property notUse3P is set to true', function () { defaultConfigParams.params.notUse3P = true; - let callBackSpy = sinon.spy(); - let submoduleCallback = identityLinkSubmodule.getId(defaultConfigParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = identityLinkSubmodule.getId(defaultConfigParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request).to.be.eq(undefined); }); it('should get envelope from storage if ats is not present on a page and pass it to callback', function () { setTestEnvelopeCookie(); - let envelopeValueFromStorage = getEnvelopeFromStorage(); - let callBackSpy = sinon.spy(); - let submoduleCallback = identityLinkSubmodule.getId(defaultConfigParams).callback; + const envelopeValueFromStorage = getEnvelopeFromStorage(); + const callBackSpy = sinon.spy(); + const submoduleCallback = identityLinkSubmodule.getId(defaultConfigParams).callback; submoduleCallback(callBackSpy); expect(envelopeValueFromStorage).to.be.a('string'); expect(callBackSpy.calledOnce).to.be.true; @@ -215,18 +215,18 @@ describe('IdentityLinkId tests', function () { const stubAtob = sinon.stub(window, 'atob'); stubAtob.onFirstCall().throws(new Error('bad')); stubAtob.onSecondCall().callsFake(realAtob); - let envelopeValueFromStorage = getEnvelopeFromStorage(); + const envelopeValueFromStorage = getEnvelopeFromStorage(); stubAtob.restore(); expect(stubAtob.calledTwice).to.be.true; expect(envelopeValueFromStorage).to.equal(testEnvelopeValue); }) it('if there is no envelope in storage and ats is not present on a page try to call 3p url', function () { - let envelopeValueFromStorage = getEnvelopeFromStorage(); - let callBackSpy = sinon.spy(); - let submoduleCallback = identityLinkSubmodule.getId(defaultConfigParams).callback; + const envelopeValueFromStorage = getEnvelopeFromStorage(); + const callBackSpy = sinon.spy(); + const submoduleCallback = identityLinkSubmodule.getId(defaultConfigParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.be.eq('https://api.rlcdn.com/api/identity/envelope?pid=14'); request.respond( 204, @@ -238,13 +238,13 @@ describe('IdentityLinkId tests', function () { it('if ats is present on a page, and envelope is generated and stored in storage, call a callback', function () { setTestEnvelopeCookie(); - let envelopeValueFromStorage = getEnvelopeFromStorage(); + const envelopeValueFromStorage = getEnvelopeFromStorage(); window.ats = {retrieveEnvelope: function() { }} // mock ats.retrieveEnvelope to return envelope stub(window.ats, 'retrieveEnvelope').callsFake(function() { return envelopeValueFromStorage }) - let callBackSpy = sinon.spy(); - let submoduleCallback = identityLinkSubmodule.getId(defaultConfigParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = identityLinkSubmodule.getId(defaultConfigParams).callback; submoduleCallback(callBackSpy); expect(envelopeValueFromStorage).to.be.a('string'); expect(envelopeValueFromStorage).to.be.eq(testEnvelopeValue); diff --git a/test/spec/modules/idxBidAdapter_spec.js b/test/spec/modules/idxBidAdapter_spec.js index 4721b0d4b6e..709fb8c5912 100644 --- a/test/spec/modules/idxBidAdapter_spec.js +++ b/test/spec/modules/idxBidAdapter_spec.js @@ -10,7 +10,7 @@ const DEFAULT_BANNER_HEIGHT = 250 describe('idxBidAdapter', function () { describe('isBidRequestValid', function () { - let validBid = { + const validBid = { bidder: BIDDER_CODE, mediaTypes: { banner: { @@ -24,13 +24,13 @@ describe('idxBidAdapter', function () { }) it('should return false when required params are not passed', function () { - let bid = Object.assign({}, validBid) + const bid = Object.assign({}, validBid) bid.mediaTypes = {} expect(spec.isBidRequestValid(bid)).to.equal(false) }) }) describe('buildRequests', function () { - let bidRequests = [ + const bidRequests = [ { bidder: BIDDER_CODE, bidId: 'asdf12345', @@ -41,7 +41,7 @@ describe('idxBidAdapter', function () { }, } ] - let bidderRequest = { + const bidderRequest = { bidderCode: BIDDER_CODE, bidderRequestId: '12345asdf', bids: [ @@ -59,7 +59,7 @@ describe('idxBidAdapter', function () { }) describe('interpretResponse', function () { it('should get correct bid response', function () { - let response = { + const response = { id: 'f6adb85f-4e19-45a0-b41e-2a5b9a48f23a', seatbid: [ { @@ -81,7 +81,7 @@ describe('idxBidAdapter', function () { ], } - let expectedResponse = [ + const expectedResponse = [ { requestId: 'b4f290d7-d4ab-4778-ab94-2baf06420b22', cpm: DEFAULT_PRICE, @@ -95,7 +95,7 @@ describe('idxBidAdapter', function () { meta: { advertiserDomains: [] }, } ] - let result = spec.interpretResponse({ body: response }) + const result = spec.interpretResponse({ body: response }) expect(Object.keys(result[0])).to.have.members(Object.keys(expectedResponse[0])) }) diff --git a/test/spec/modules/idxIdSystem_spec.js b/test/spec/modules/idxIdSystem_spec.js index e47c606776d..a5bb7d5d762 100644 --- a/test/spec/modules/idxIdSystem_spec.js +++ b/test/spec/modules/idxIdSystem_spec.js @@ -1,8 +1,5 @@ -import { expect } from 'chai'; -import { config } from 'src/config.js'; -import { init, startAuctionHook, setSubmoduleRegistry } from 'modules/userId/index.js'; -import { storage, idxIdSubmodule } from 'modules/idxIdSystem.js'; -import {mockGdprConsent} from '../../helpers/consentData.js'; +import {expect} from 'chai'; +import {idxIdSubmodule, storage} from 'modules/idxIdSystem.js'; import 'src/prebid.js'; const IDX_COOKIE_NAME = '_idx'; @@ -11,32 +8,6 @@ const IDX_COOKIE_STORED = '{ "idx": "' + IDX_DUMMY_VALUE + '" }'; const ID_COOKIE_OBJECT = { id: IDX_DUMMY_VALUE }; const IDX_COOKIE_OBJECT = { idx: IDX_DUMMY_VALUE }; -function getConfigMock() { - return { - userSync: { - syncDelay: 0, - userIds: [{ - name: 'idx' - }] - } - } -} - -function getAdUnitMock(code = 'adUnit-code') { - return { - code, - mediaTypes: {banner: {}, native: {}}, - sizes: [ - [300, 200], - [300, 600] - ], - bids: [{ - bidder: 'sampleBidder', - params: { placementId: 'banner-only-bidder' } - }] - }; -} - describe('IDx ID System', () => { let getDataFromLocalStorageStub, localStorageIsEnabledStub; let getCookieStub, cookiesAreEnabledStub; @@ -58,18 +29,18 @@ describe('IDx ID System', () => { describe('IDx: test "getId" method', () => { it('provides the stored IDx if a cookie exists', () => { getCookieStub.withArgs(IDX_COOKIE_NAME).returns(IDX_COOKIE_STORED); - let idx = idxIdSubmodule.getId(); + const idx = idxIdSubmodule.getId(); expect(idx).to.deep.equal(ID_COOKIE_OBJECT); }); it('provides the stored IDx if cookie is absent but present in local storage', () => { getDataFromLocalStorageStub.withArgs(IDX_COOKIE_NAME).returns(IDX_COOKIE_STORED); - let idx = idxIdSubmodule.getId(); + const idx = idxIdSubmodule.getId(); expect(idx).to.deep.equal(ID_COOKIE_OBJECT); }); it('returns undefined if both cookie and local storage are empty', () => { - let idx = idxIdSubmodule.getId(); + const idx = idxIdSubmodule.getId(); expect(idx).to.be.undefined; }) }); @@ -83,46 +54,4 @@ describe('IDx ID System', () => { expect(idxIdSubmodule.decode(IDX_DUMMY_VALUE)).to.deep.equal(IDX_COOKIE_OBJECT); }); }); - - describe('requestBids hook', () => { - let adUnits; - let sandbox; - - beforeEach(() => { - sandbox = sinon.createSandbox(); - mockGdprConsent(sandbox); - adUnits = [getAdUnitMock()]; - init(config); - setSubmoduleRegistry([idxIdSubmodule]); - getCookieStub.withArgs(IDX_COOKIE_NAME).returns(IDX_COOKIE_STORED); - config.setConfig(getConfigMock()); - }); - - afterEach(() => { - sandbox.restore(); - config.resetConfig(); - }) - - after(() => { - init(config); - }) - - it('when a stored IDx exists it is added to bids', (done) => { - startAuctionHook(() => { - adUnits.forEach(unit => { - unit.bids.forEach(bid => { - const idxIdAsEid = bid.userIdAsEids.find(e => e.source == 'idx.lat'); - expect(idxIdAsEid).to.deep.equal({ - source: 'idx.lat', - uids: [{ - id: IDX_DUMMY_VALUE, - atype: 1, - }] - }); - }); - }); - done(); - }, { adUnits }); - }); - }); }); diff --git a/test/spec/modules/impactifyBidAdapter_spec.js b/test/spec/modules/impactifyBidAdapter_spec.js index b69d0ad7a8d..eb91bb327ba 100644 --- a/test/spec/modules/impactifyBidAdapter_spec.js +++ b/test/spec/modules/impactifyBidAdapter_spec.js @@ -43,7 +43,7 @@ describe('ImpactifyAdapter', function () { }); describe('isBidRequestValid', function () { - let validBids = [ + const validBids = [ { bidder: 'impactify', params: { @@ -62,7 +62,7 @@ describe('ImpactifyAdapter', function () { } ]; - let videoBidRequests = [ + const videoBidRequests = [ { bidder: 'impactify', params: { @@ -97,7 +97,7 @@ describe('ImpactifyAdapter', function () { ] } ]; - let videoBidderRequest = { + const videoBidderRequest = { bidderRequestId: '98845765110', auctionId: '165410516454', bidderCode: 'impactify', @@ -117,12 +117,12 @@ describe('ImpactifyAdapter', function () { }); it('should return false when required params are not passed', function () { - let bid = Object.assign({}, validBids[0]); + const bid = Object.assign({}, validBids[0]); delete bid.params; bid.params = {}; expect(spec.isBidRequestValid(bid)).to.equal(false); - let bid2 = Object.assign({}, validBids[1]); + const bid2 = Object.assign({}, validBids[1]); delete bid2.params; bid2.params = {}; expect(spec.isBidRequestValid(bid2)).to.equal(false); @@ -231,7 +231,7 @@ describe('ImpactifyAdapter', function () { }); }); describe('buildRequests', function () { - let videoBidRequests = [ + const videoBidRequests = [ { bidder: 'impactify', params: { @@ -266,7 +266,7 @@ describe('ImpactifyAdapter', function () { ] } ]; - let videoBidderRequest = { + const videoBidderRequest = { bidderRequestId: '98845765110', auctionId: '165410516454', bidderCode: 'impactify', @@ -323,7 +323,7 @@ describe('ImpactifyAdapter', function () { }); describe('interpretResponse', function () { it('should get correct bid response', function () { - let response = { + const response = { id: '19ab94a9-b0d7-4ed7-9f80-ad0c033cf1b1', seatbid: [ { @@ -357,7 +357,7 @@ describe('ImpactifyAdapter', function () { bidder: { appnexus: { brand_id: 182979, - auction_id: 8657683934873599656, + auction_id: '8657683934873599656', bidder_id: 2, bid_ad_type: 1, creative_info: { @@ -389,7 +389,7 @@ describe('ImpactifyAdapter', function () { } } }; - let bidderRequest = { + const bidderRequest = { bids: [ { bidId: '462c08f20d428', @@ -405,7 +405,7 @@ describe('ImpactifyAdapter', function () { }, ] } - let expectedResponse = [ + const expectedResponse = [ { id: '65820304700829014', requestId: '462c08f20d428', @@ -422,12 +422,12 @@ describe('ImpactifyAdapter', function () { creativeId: '97517771' } ]; - let result = spec.interpretResponse({ body: response }, bidderRequest); + const result = spec.interpretResponse({ body: response }, bidderRequest); expect(Object.keys(result[0])).to.have.members(Object.keys(expectedResponse[0])); }); }); describe('getUserSyncs', function () { - let videoBidRequests = [ + const videoBidRequests = [ { bidder: 'impactify', params: { @@ -448,7 +448,7 @@ describe('ImpactifyAdapter', function () { transactionId: 'f7b2c372-7a7b-11eb-9439-0242ac130002' } ]; - let videoBidderRequest = { + const videoBidderRequest = { bidderRequestId: '98845765110', auctionId: '165410516454', bidderCode: 'impactify', @@ -461,7 +461,7 @@ describe('ImpactifyAdapter', function () { referer: 'https://impactify.io' } }; - let validResponse = { + const validResponse = { id: '19ab94a9-b0d7-4ed7-9f80-ad0c033cf1b1', seatbid: [ { @@ -495,7 +495,7 @@ describe('ImpactifyAdapter', function () { bidder: { appnexus: { brand_id: 182979, - auction_id: 8657683934873599656, + auction_id: '8657683934873599656', bidder_id: 2, bid_ad_type: 1, creative_info: { diff --git a/test/spec/modules/improvedigitalBidAdapter_spec.js b/test/spec/modules/improvedigitalBidAdapter_spec.js index 3d93966a9b9..b17f02fde74 100644 --- a/test/spec/modules/improvedigitalBidAdapter_spec.js +++ b/test/spec/modules/improvedigitalBidAdapter_spec.js @@ -396,7 +396,7 @@ describe('Improve Digital Adapter Tests', function () { expect(payload.imp[0].bidfloorcur).to.equal('USD'); // getFloor defined -> use it over bidFloor - let getFloorResponse = { currency: 'USD', floor: 3 }; + const getFloorResponse = { currency: 'USD', floor: 3 }; bidRequest.getFloor = () => getFloorResponse; payload = JSON.parse(spec.buildRequests([bidRequest], bidderRequest)[0].data); expect(payload.imp[0].bidfloor).to.equal(3); @@ -521,8 +521,8 @@ describe('Improve Digital Adapter Tests', function () { const videoTestInvParam = Object.assign({}, videoTest); videoTestInvParam.blah = 1; bidRequest.params.video = videoTestInvParam; - let request = spec.buildRequests([bidRequest], {})[0]; - let payload = JSON.parse(request.data); + const request = spec.buildRequests([bidRequest], {})[0]; + const payload = JSON.parse(request.data); expect(payload.imp[0].video.blah).not.to.exist; }); @@ -670,8 +670,8 @@ describe('Improve Digital Adapter Tests', function () { it('should not set site when app is defined in FPD', function () { const ortb2 = {app: {content: 'XYZ'}}; - let request = spec.buildRequests([simpleBidRequest], {...bidderRequest, ortb2})[0]; - let payload = JSON.parse(request.data); + const request = spec.buildRequests([simpleBidRequest], {...bidderRequest, ortb2})[0]; + const payload = JSON.parse(request.data); expect(payload.site).does.not.exist; expect(payload.app).does.exist; expect(payload.app.content).does.exist.and.equal('XYZ'); @@ -1348,7 +1348,7 @@ describe('Improve Digital Adapter Tests', function () { it('should attach usp consent to iframe sync url', function () { spec.buildRequests([simpleBidRequest], bidderRequest); - let syncs = spec.getUserSyncs({ iframeEnabled: true, pixelEnabled: false }, serverResponses, null, uspConsent); + const syncs = spec.getUserSyncs({ iframeEnabled: true, pixelEnabled: false }, serverResponses, null, uspConsent); expect(syncs).to.deep.equal([{ type: 'iframe', url: `${basicIframeSyncUrl}&us_privacy=${uspConsent}` }]); }); @@ -1374,8 +1374,8 @@ describe('Improve Digital Adapter Tests', function () { spec.buildRequests([simpleBidRequest], {}); const rawResponse = deepClone(serverResponse) deepSetValue(rawResponse, 'body.ext.responsetimemillis', {a: 1, b: 1, c: 1, d: 1, e: 1}) - let syncs = spec.getUserSyncs({ iframeEnabled: true, pixelEnabled: true }, [rawResponse]); - let url = basicIframeSyncUrl + '&pbs=1' + '&bidders=a,b,c,d,e' + const syncs = spec.getUserSyncs({ iframeEnabled: true, pixelEnabled: true }, [rawResponse]); + const url = basicIframeSyncUrl + '&pbs=1' + '&bidders=a,b,c,d,e' expect(syncs).to.deep.equal([{ type: 'iframe', url }]); }); }); diff --git a/test/spec/modules/innityBidAdapter_spec.js b/test/spec/modules/innityBidAdapter_spec.js index 820f535ba72..5a4689bc971 100644 --- a/test/spec/modules/innityBidAdapter_spec.js +++ b/test/spec/modules/innityBidAdapter_spec.js @@ -37,7 +37,7 @@ describe('innityAdapterTest', () => { 'auctionId': '18fd8b8b0bd757' }]; - let bidderRequest = { + const bidderRequest = { refererInfo: { page: 'https://refererExample.com' } @@ -86,9 +86,9 @@ describe('innityAdapterTest', () => { } }; - let advDomains = ['advertiserExample.com']; + const advDomains = ['advertiserExample.com']; - let bidResponse = { + const bidResponse = { body: { 'cpm': 100, 'width': '300', diff --git a/test/spec/modules/insticatorBidAdapter_spec.js b/test/spec/modules/insticatorBidAdapter_spec.js index c4d09b8f6a5..1de2b7cce22 100644 --- a/test/spec/modules/insticatorBidAdapter_spec.js +++ b/test/spec/modules/insticatorBidAdapter_spec.js @@ -7,13 +7,13 @@ const USER_ID_KEY = 'hb_insticator_uid'; const USER_ID_DUMMY_VALUE = '74f78609-a92d-4cf1-869f-1b244bbfb5d2'; const USER_ID_STUBBED = '12345678-1234-1234-1234-123456789abc'; -let utils = require('src/utils.js'); +const utils = require('src/utils.js'); describe('InsticatorBidAdapter', function () { const adapter = newBidder(spec); const bidderRequestId = '22edbae2733bf6'; - let bidRequest = { + const bidRequest = { bidder: 'insticator', adUnitCode: 'adunit-code', params: { diff --git a/test/spec/modules/instreamTracking_spec.js b/test/spec/modules/instreamTracking_spec.js index 205b19d920a..4d960608c0c 100644 --- a/test/spec/modules/instreamTracking_spec.js +++ b/test/spec/modules/instreamTracking_spec.js @@ -13,7 +13,7 @@ let sandbox; let clock; function enableInstreamTracking(regex) { - let configStub = sandbox.stub(config, 'getConfig'); + const configStub = sandbox.stub(config, 'getConfig'); configStub.withArgs('instreamTracking').returns(Object.assign( { enabled: true, @@ -25,8 +25,8 @@ function enableInstreamTracking(regex) { } function mockPerformanceApi({adServerCallSent, videoPresent}) { - let performanceStub = sandbox.stub(window.performance, 'getEntriesByType'); - let entries = [{ + const performanceStub = sandbox.stub(window.performance, 'getEntriesByType'); + const entries = [{ name: 'https://domain.com/img.png', initiatorType: 'img' }, { diff --git a/test/spec/modules/integr8BidAdapter_spec.js b/test/spec/modules/integr8BidAdapter_spec.js index 01bb706df25..fbabda9c685 100644 --- a/test/spec/modules/integr8BidAdapter_spec.js +++ b/test/spec/modules/integr8BidAdapter_spec.js @@ -145,7 +145,7 @@ describe('integr8AdapterTest', () => { it('all keys present', () => { const result = spec.interpretResponse(bidResponse, bidRequest); - let keys = [ + const keys = [ 'requestId', 'cpm', 'width', @@ -161,7 +161,7 @@ describe('integr8AdapterTest', () => { 'meta' ]; - let resultKeys = Object.keys(result[0]); + const resultKeys = Object.keys(result[0]); resultKeys.forEach(function (key) { expect(keys.indexOf(key) !== -1).to.equal(true); }); diff --git a/test/spec/modules/intentIqAnalyticsAdapter_spec.js b/test/spec/modules/intentIqAnalyticsAdapter_spec.js index 7f83002560d..9903eabb22f 100644 --- a/test/spec/modules/intentIqAnalyticsAdapter_spec.js +++ b/test/spec/modules/intentIqAnalyticsAdapter_spec.js @@ -57,7 +57,7 @@ const getUserConfigWithReportingServerAddress = () => [ } ]; -let wonRequest = { +const wonRequest = { 'bidderCode': 'pubmatic', 'width': 728, 'height': 90, diff --git a/test/spec/modules/intentIqIdSystem_spec.js b/test/spec/modules/intentIqIdSystem_spec.js index 49da8fa3267..47d6b7bb150 100644 --- a/test/spec/modules/intentIqIdSystem_spec.js +++ b/test/spec/modules/intentIqIdSystem_spec.js @@ -78,18 +78,18 @@ const mockGAM = () => { describe('IntentIQ tests', function () { let logErrorStub; - let testLSValue = { + const testLSValue = { 'date': Date.now(), 'cttl': 2000, 'rrtt': 123 } - let testLSValueWithData = { + const testLSValueWithData = { 'date': Date.now(), 'cttl': 9999999999999, 'rrtt': 123, 'data': 'U2FsdGVkX185JJuQ2Zk0JLGjpgEbqxNy0Yl2qMtj9PqA5Q3IkNQYyTyFyTOkJi9Nf7E43PZQvIUgiUY/A9QxKYmy1LHX9LmZMKlLOcY1Je13Kr1EN7HRF8nIIWXo2jRgS5n0Nmty5995x3YMjLw+aRweoEtcrMC6p4wOdJnxfrOhdg0d/R7b8C+IN85rDLfNXANL1ezX8zwh4rj9XpMmWw==' } - let testResponseWithValues = { + const testResponseWithValues = { 'abPercentage': 90, 'adt': 1, 'ct': 2, @@ -115,28 +115,28 @@ describe('IntentIQ tests', function () { }); it('should log an error if no configParams were passed when getId', function () { - let submodule = intentIqIdSubmodule.getId({ params: {} }); + const submodule = intentIqIdSubmodule.getId({ params: {} }); expect(logErrorStub.calledOnce).to.be.true; expect(submodule).to.be.undefined; }); it('should log an error if partner configParam was not passed when getId', function () { - let submodule = intentIqIdSubmodule.getId({ params: {} }); + const submodule = intentIqIdSubmodule.getId({ params: {} }); expect(logErrorStub.calledOnce).to.be.true; expect(submodule).to.be.undefined; }); it('should log an error if partner configParam was not a numeric value', function () { - let submodule = intentIqIdSubmodule.getId({ params: { partner: '10' } }); + const submodule = intentIqIdSubmodule.getId({ params: { partner: '10' } }); expect(logErrorStub.calledOnce).to.be.true; expect(submodule).to.be.undefined; }); it('should not save data in cookie if relevant type not set', function () { - let callBackSpy = sinon.spy(); - let submoduleCallback = intentIqIdSubmodule.getId(defaultConfigParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = intentIqIdSubmodule.getId(defaultConfigParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.contain('https://api.intentiq.com/profiles_engine/ProfilesEngineServlet?at=39&mi=10&dpi=10&pt=17&dpn=1&iiqidtype=2&iiqpcid='); request.respond( 200, @@ -148,10 +148,10 @@ describe('IntentIQ tests', function () { }); it('should save data in cookie if storage type is "cookie"', function () { - let callBackSpy = sinon.spy(); - let submoduleCallback = intentIqIdSubmodule.getId({ ...allConfigParams, enabledStorageTypes: ['cookie'] }).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = intentIqIdSubmodule.getId({ ...allConfigParams, enabledStorageTypes: ['cookie'] }).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.contain('https://api.intentiq.com/profiles_engine/ProfilesEngineServlet?at=39&mi=10&dpi=10&pt=17&dpn=1&pai=11&iiqidtype=2&iiqpcid='); request.respond( 200, @@ -166,10 +166,10 @@ describe('IntentIQ tests', function () { }); it('should call the IntentIQ endpoint with only partner', function () { - let callBackSpy = sinon.spy(); - let submoduleCallback = intentIqIdSubmodule.getId(defaultConfigParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = intentIqIdSubmodule.getId(defaultConfigParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.contain('https://api.intentiq.com/profiles_engine/ProfilesEngineServlet?at=39&mi=10&dpi=10&pt=17&dpn=1&iiqidtype=2&iiqpcid='); request.respond( 200, @@ -212,10 +212,10 @@ describe('IntentIQ tests', function () { }); it('should call the IntentIQ endpoint with only partner, pai', function () { - let callBackSpy = sinon.spy(); - let submoduleCallback = intentIqIdSubmodule.getId(paiConfigParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = intentIqIdSubmodule.getId(paiConfigParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.contain('https://api.intentiq.com/profiles_engine/ProfilesEngineServlet?at=39&mi=10&dpi=10&pt=17&dpn=1&pai=11&iiqidtype=2&iiqpcid='); request.respond( 200, @@ -226,10 +226,10 @@ describe('IntentIQ tests', function () { }); it('should call the IntentIQ endpoint with only partner, pcid', function () { - let callBackSpy = sinon.spy(); - let submoduleCallback = intentIqIdSubmodule.getId(pcidConfigParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = intentIqIdSubmodule.getId(pcidConfigParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.contain('https://api.intentiq.com/profiles_engine/ProfilesEngineServlet?at=39&mi=10&dpi=10&pt=17&dpn=1'); expect(request.url).to.contain('&pcid=12'); request.respond( @@ -241,10 +241,10 @@ describe('IntentIQ tests', function () { }); it('should call the IntentIQ endpoint with partner, pcid, pai', function () { - let callBackSpy = sinon.spy(); - let submoduleCallback = intentIqIdSubmodule.getId(allConfigParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = intentIqIdSubmodule.getId(allConfigParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.contain('https://api.intentiq.com/profiles_engine/ProfilesEngineServlet?at=39&mi=10&dpi=10&pt=17&dpn=1&pai=11&iiqidtype=2&iiqpcid='); expect(request.url).to.contain('&pcid=12'); request.respond( @@ -256,12 +256,12 @@ describe('IntentIQ tests', function () { }); it('should set GAM targeting to U initially and update to A after server response', function () { - let callBackSpy = sinon.spy(); - let mockGamObject = mockGAM(); - let expectedGamParameterName = 'intent_iq_group'; + const callBackSpy = sinon.spy(); + const mockGamObject = mockGAM(); + const expectedGamParameterName = 'intent_iq_group'; const originalPubads = mockGamObject.pubads; - let setTargetingSpy = sinon.spy(); + const setTargetingSpy = sinon.spy(); mockGamObject.pubads = function () { const obj = { ...originalPubads.apply(this, arguments) }; const originalSetTargeting = obj.setTargeting; @@ -274,15 +274,15 @@ describe('IntentIQ tests', function () { defaultConfigParams.params.gamObjectReference = mockGamObject; - let submoduleCallback = intentIqIdSubmodule.getId(defaultConfigParams).callback; + const submoduleCallback = intentIqIdSubmodule.getId(defaultConfigParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; mockGamObject.cmd.forEach(cb => cb()); mockGamObject.cmd = [] - let groupBeforeResponse = mockGamObject.pubads().getTargeting(expectedGamParameterName); + const groupBeforeResponse = mockGamObject.pubads().getTargeting(expectedGamParameterName); request.respond( 200, @@ -292,7 +292,7 @@ describe('IntentIQ tests', function () { mockGamObject.cmd.forEach(item => item()); - let groupAfterResponse = mockGamObject.pubads().getTargeting(expectedGamParameterName); + const groupAfterResponse = mockGamObject.pubads().getTargeting(expectedGamParameterName); expect(request.url).to.contain('https://api.intentiq.com/profiles_engine/ProfilesEngineServlet?at=39'); expect(groupBeforeResponse).to.deep.equal([NOT_YET_DEFINED]); @@ -302,26 +302,26 @@ describe('IntentIQ tests', function () { }); it('should use the provided gamParameterName from configParams', function () { - let callBackSpy = sinon.spy(); - let mockGamObject = mockGAM(); - let customParamName = 'custom_gam_param'; + const callBackSpy = sinon.spy(); + const mockGamObject = mockGAM(); + const customParamName = 'custom_gam_param'; defaultConfigParams.params.gamObjectReference = mockGamObject; defaultConfigParams.params.gamParameterName = customParamName; - let submoduleCallback = intentIqIdSubmodule.getId(defaultConfigParams).callback; + const submoduleCallback = intentIqIdSubmodule.getId(defaultConfigParams).callback; submoduleCallback(callBackSpy); mockGamObject.cmd.forEach(cb => cb()); - let targetingKeys = mockGamObject.pubads().getTargetingKeys(); + const targetingKeys = mockGamObject.pubads().getTargetingKeys(); expect(targetingKeys).to.include(customParamName); }); it('should not throw Uncaught TypeError when IntentIQ endpoint returns empty response', function () { - let callBackSpy = sinon.spy(); - let submoduleCallback = intentIqIdSubmodule.getId(defaultConfigParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = intentIqIdSubmodule.getId(defaultConfigParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.contain('https://api.intentiq.com/profiles_engine/ProfilesEngineServlet?at=39&mi=10&dpi=10&pt=17&dpn=1&iiqidtype=2&iiqpcid='); request.respond( 204, @@ -331,10 +331,10 @@ describe('IntentIQ tests', function () { }); it('should log an error and continue to callback if ajax request errors', function () { - let callBackSpy = sinon.spy(); - let submoduleCallback = intentIqIdSubmodule.getId(defaultConfigParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = intentIqIdSubmodule.getId(defaultConfigParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.contain('https://api.intentiq.com/profiles_engine/ProfilesEngineServlet?at=39&mi=10&dpi=10&pt=17&dpn=1&iiqidtype=2&iiqpcid='); request.respond( 503, @@ -345,10 +345,10 @@ describe('IntentIQ tests', function () { }); it('save result if ls=true', function () { - let callBackSpy = sinon.spy(); - let submoduleCallback = intentIqIdSubmodule.getId(allConfigParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = intentIqIdSubmodule.getId(allConfigParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.contain('https://api.intentiq.com/profiles_engine/ProfilesEngineServlet?at=39&mi=10&dpi=10&pt=17&dpn=1&pai=11&iiqidtype=2&iiqpcid='); request.respond( 200, @@ -360,10 +360,10 @@ describe('IntentIQ tests', function () { }); it('dont save result if ls=false', function () { - let callBackSpy = sinon.spy(); - let submoduleCallback = intentIqIdSubmodule.getId(allConfigParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = intentIqIdSubmodule.getId(allConfigParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.contain('https://api.intentiq.com/profiles_engine/ProfilesEngineServlet?at=39&mi=10&dpi=10&pt=17&dpn=1&pai=11&iiqidtype=2&iiqpcid='); request.respond( 200, @@ -376,10 +376,10 @@ describe('IntentIQ tests', function () { it('send addition parameters if were found in localstorage', function () { localStorage.setItem('_iiq_fdata_' + partner, JSON.stringify(testLSValue)) - let callBackSpy = sinon.spy(); - let submoduleCallback = intentIqIdSubmodule.getId(allConfigParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = intentIqIdSubmodule.getId(allConfigParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.contain('https://api.intentiq.com/profiles_engine/ProfilesEngineServlet?at=39&mi=10&dpi=10&pt=17&dpn=1&pai=11&iiqidtype=2&iiqpcid='); expect(request.url).to.contain('cttl=' + testLSValue.cttl); @@ -395,26 +395,26 @@ describe('IntentIQ tests', function () { it('return data stored in local storage ', function () { localStorage.setItem('_iiq_fdata_' + partner, JSON.stringify(testLSValueWithData)); - let returnedValue = intentIqIdSubmodule.getId(allConfigParams); + const returnedValue = intentIqIdSubmodule.getId(allConfigParams); expect(returnedValue.id).to.deep.equal(JSON.parse(decryptData(testLSValueWithData.data)).eids); }); it('should handle browser blacklisting', function () { - let configParamsWithBlacklist = { + const configParamsWithBlacklist = { params: { partner: partner, browserBlackList: 'chrome' } }; sinon.stub(navigator, 'userAgent').value('Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.124 Safari/537.36'); - let submoduleCallback = intentIqIdSubmodule.getId(configParamsWithBlacklist); + const submoduleCallback = intentIqIdSubmodule.getId(configParamsWithBlacklist); expect(logErrorStub.calledOnce).to.be.true; expect(submoduleCallback).to.be.undefined; }); it('should handle invalid JSON in readData', function () { localStorage.setItem('_iiq_fdata_' + partner, 'invalid_json'); - let callBackSpy = sinon.spy(); - let submoduleCallback = intentIqIdSubmodule.getId(defaultConfigParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = intentIqIdSubmodule.getId(defaultConfigParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.contain('https://api.intentiq.com/profiles_engine/ProfilesEngineServlet?at=39&mi=10&dpi=10&pt=17&dpn=1&iiqidtype=2&iiqpcid='); request.respond( 200, @@ -490,7 +490,7 @@ describe('IntentIQ tests', function () { it('should save spd to firstPartyData in localStorage if present in response', function () { const spdValue = { foo: 'bar', value: 42 }; - let callBackSpy = sinon.spy(); + const callBackSpy = sinon.spy(); const submoduleCallback = intentIqIdSubmodule.getId(defaultConfigParams).callback; submoduleCallback(callBackSpy); @@ -639,20 +639,20 @@ describe('IntentIQ tests', function () { it('should set isOptOut to true for new users if GDPR is detected and update it upon receiving a server response', function () { localStorage.clear(); mockConsentHandlers(uspData, gppData, gdprData); - let callBackSpy = sinon.spy(); - let submoduleCallback = intentIqIdSubmodule.getId(allConfigParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = intentIqIdSubmodule.getId(allConfigParams).callback; submoduleCallback(callBackSpy); - let lsBeforeReq = JSON.parse(localStorage.getItem(FIRST_PARTY_KEY)); + const lsBeforeReq = JSON.parse(localStorage.getItem(FIRST_PARTY_KEY)); - let request = server.requests[0]; + const request = server.requests[0]; request.respond( 200, responseHeader, JSON.stringify({ isOptedOut: false }) ); - let updatedFirstPartyData = JSON.parse(localStorage.getItem(FIRST_PARTY_KEY)); + const updatedFirstPartyData = JSON.parse(localStorage.getItem(FIRST_PARTY_KEY)); expect(lsBeforeReq).to.not.be.null; expect(lsBeforeReq.isOptedOut).to.be.true; @@ -664,12 +664,12 @@ describe('IntentIQ tests', function () { it('should save cmpData parameters in LS data and used it request if uspData, gppData, gdprData exists', function () { mockConsentHandlers(uspData, gppData, gdprData); - let callBackSpy = sinon.spy(); - let submoduleCallback = intentIqIdSubmodule.getId(defaultConfigParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = intentIqIdSubmodule.getId(defaultConfigParams).callback; const data = {eids: {key1: 'value1', key2: 'value2'}} submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; request.respond( 200, responseHeader, @@ -698,12 +698,12 @@ describe('IntentIQ tests', function () { mockConsentHandlers(uspData, gppData, gdprData); - let callBackSpy = sinon.spy(); - let submoduleCallback = intentIqIdSubmodule.getId(defaultConfigParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = intentIqIdSubmodule.getId(defaultConfigParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; request.respond( 200, responseHeader, @@ -731,22 +731,22 @@ describe('IntentIQ tests', function () { it('should make request to correct address api-gdpr.intentiq.com if gdpr is detected', function() { const ENDPOINT_GDPR = 'https://api-gdpr.intentiq.com'; mockConsentHandlers(uspData, gppData, gdprData); - let callBackSpy = sinon.spy(); - let submoduleCallback = intentIqIdSubmodule.getId({...defaultConfigParams}).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = intentIqIdSubmodule.getId({...defaultConfigParams}).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.contain(ENDPOINT_GDPR); }); it('should make request to correct address with iiqServerAddress parameter', function() { defaultConfigParams.params.iiqServerAddress = testAPILink - let callBackSpy = sinon.spy(); - let submoduleCallback = intentIqIdSubmodule.getId({...defaultConfigParams}).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = intentIqIdSubmodule.getId({...defaultConfigParams}).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.contain(testAPILink); }); @@ -765,7 +765,7 @@ describe('IntentIQ tests', function () { intentIqIdSubmodule.getId({...callbackConfigParams}); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.contain(syncTestAPILink); }); @@ -879,47 +879,47 @@ describe('IntentIQ tests', function () { }); it('should send sourceMetaData in AT=39 if it exists in configParams', function () { - let translatedMetaDataValue = translateMetadata(sourceMetaData) - let callBackSpy = sinon.spy(); - let submoduleCallback = intentIqIdSubmodule.getId(allConfigParams).callback; + const translatedMetaDataValue = translateMetadata(sourceMetaData) + const callBackSpy = sinon.spy(); + const submoduleCallback = intentIqIdSubmodule.getId(allConfigParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.include('?at=39') expect(request.url).to.include(`fbp=${translatedMetaDataValue}`) }); it('should NOT send sourceMetaData and sourceMetaDataExternal in AT=39 if it is undefined', function () { - let callBackSpy = sinon.spy(); + const callBackSpy = sinon.spy(); const configParams = { params: {...allConfigParams.params, sourceMetaData: undefined} }; - let submoduleCallback = intentIqIdSubmodule.getId(configParams).callback; + const submoduleCallback = intentIqIdSubmodule.getId(configParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.include('?at=39') expect(request.url).not.to.include('fbp=') }); it('should NOT send sourceMetaData in AT=39 if value is NAN', function () { - let callBackSpy = sinon.spy(); + const callBackSpy = sinon.spy(); const configParams = { params: {...allConfigParams.params, sourceMetaData: NaN} }; - let submoduleCallback = intentIqIdSubmodule.getId(configParams).callback; + const submoduleCallback = intentIqIdSubmodule.getId(configParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.include('?at=39') expect(request.url).not.to.include('fbp=') }); it('should send sourceMetaData in AT=20 if it exists in configParams', function () { - let translatedMetaDataValue = translateMetadata(sourceMetaData) + const translatedMetaDataValue = translateMetadata(sourceMetaData) const configParams = { params: {...allConfigParams.params, browserBlackList: 'chrome'} }; intentIqIdSubmodule.getId(configParams); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.include('?at=20'); expect(request.url).to.include(`fbp=${translatedMetaDataValue}`) @@ -929,19 +929,19 @@ describe('IntentIQ tests', function () { const configParams = { params: {...allConfigParams.params, sourceMetaData: NaN, browserBlackList: 'chrome'} }; intentIqIdSubmodule.getId(configParams); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.include('?at=20'); expect(request.url).to.not.include('&fbp='); }); it('should send pcid and idtype in AT=20 if it provided in config', function () { - let partnerClientId = 'partnerClientId 123'; - let partnerClientIdType = 0; + const partnerClientId = 'partnerClientId 123'; + const partnerClientIdType = 0; const configParams = { params: {...allConfigParams.params, browserBlackList: 'chrome', partnerClientId, partnerClientIdType} }; intentIqIdSubmodule.getId(configParams); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.include('?at=20'); expect(request.url).to.include(`&pcid=${encodeURIComponent(partnerClientId)}`); @@ -949,12 +949,12 @@ describe('IntentIQ tests', function () { }); it('should NOT send pcid and idtype in AT=20 if partnerClientId is NOT a string', function () { - let partnerClientId = 123; - let partnerClientIdType = 0; + const partnerClientId = 123; + const partnerClientIdType = 0; const configParams = { params: {...allConfigParams.params, browserBlackList: 'chrome', partnerClientId, partnerClientIdType} }; intentIqIdSubmodule.getId(configParams); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.include('?at=20'); expect(request.url).not.to.include(`&pcid=`); @@ -962,12 +962,12 @@ describe('IntentIQ tests', function () { }); it('should NOT send pcid and idtype in AT=20 if partnerClientIdType is NOT a number', function () { - let partnerClientId = 'partnerClientId 123'; - let partnerClientIdType = 'wrong'; + const partnerClientId = 'partnerClientId 123'; + const partnerClientIdType = 'wrong'; const configParams = { params: {...allConfigParams.params, browserBlackList: 'chrome', partnerClientId, partnerClientIdType} }; intentIqIdSubmodule.getId(configParams); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.include('?at=20'); expect(request.url).not.to.include(`&pcid=`); @@ -975,14 +975,14 @@ describe('IntentIQ tests', function () { }); it('should send partnerClientId and partnerClientIdType in AT=39 if it provided in config', function () { - let partnerClientId = 'partnerClientId 123'; - let partnerClientIdType = 0; - let callBackSpy = sinon.spy(); + const partnerClientId = 'partnerClientId 123'; + const partnerClientIdType = 0; + const callBackSpy = sinon.spy(); const configParams = { params: {...allConfigParams.params, partnerClientId, partnerClientIdType} }; - let submoduleCallback = intentIqIdSubmodule.getId(configParams).callback; + const submoduleCallback = intentIqIdSubmodule.getId(configParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.include('?at=39') expect(request.url).to.include(`&pcid=${encodeURIComponent(partnerClientId)}`); @@ -990,14 +990,14 @@ describe('IntentIQ tests', function () { }); it('should NOT send partnerClientId and partnerClientIdType in AT=39 if partnerClientId is not a string', function () { - let partnerClientId = 123; - let partnerClientIdType = 0; - let callBackSpy = sinon.spy(); + const partnerClientId = 123; + const partnerClientIdType = 0; + const callBackSpy = sinon.spy(); const configParams = { params: {...allConfigParams.params, partnerClientId, partnerClientIdType} }; - let submoduleCallback = intentIqIdSubmodule.getId(configParams).callback; + const submoduleCallback = intentIqIdSubmodule.getId(configParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.include('?at=39') expect(request.url).not.to.include(`&pcid=${partnerClientId}`); @@ -1005,14 +1005,14 @@ describe('IntentIQ tests', function () { }); it('should NOT send partnerClientId and partnerClientIdType in AT=39 if partnerClientIdType is not a number', function () { - let partnerClientId = 'partnerClientId-123'; - let partnerClientIdType = 'wrong'; - let callBackSpy = sinon.spy(); + const partnerClientId = 'partnerClientId-123'; + const partnerClientIdType = 'wrong'; + const callBackSpy = sinon.spy(); const configParams = { params: {...allConfigParams.params, partnerClientId, partnerClientIdType} }; - let submoduleCallback = intentIqIdSubmodule.getId(configParams).callback; + const submoduleCallback = intentIqIdSubmodule.getId(configParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.include('?at=39') expect(request.url).not.to.include(`&pcid=${partnerClientId}`); @@ -1023,7 +1023,7 @@ describe('IntentIQ tests', function () { const configParams = { params: {...allConfigParams.params, browserBlackList: 'chrome', sourceMetaDataExternal: 123} }; intentIqIdSubmodule.getId(configParams); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.include('?at=20'); expect(request.url).to.include('&fbp=123'); @@ -1043,12 +1043,12 @@ describe('IntentIQ tests', function () { }); it('should send siloEnabled value in the request', function () { - let callBackSpy = sinon.spy(); + const callBackSpy = sinon.spy(); const configParams = { params: {...allConfigParams.params, siloEnabled: true} }; - let submoduleCallback = intentIqIdSubmodule.getId(configParams).callback; + const submoduleCallback = intentIqIdSubmodule.getId(configParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.contain(`&japs=${configParams.params.siloEnabled}`); }); @@ -1138,8 +1138,8 @@ describe('IntentIQ tests', function () { } }; - let callBackSpy = sinon.spy(); - let submoduleCallback = intentIqIdSubmodule.getId(configParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = intentIqIdSubmodule.getId(configParams).callback; submoduleCallback(callBackSpy); const vrRequest = server.requests[0]; @@ -1158,8 +1158,8 @@ describe('IntentIQ tests', function () { } }; - let callBackSpy = sinon.spy(); - let submoduleCallback = intentIqIdSubmodule.getId(configParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = intentIqIdSubmodule.getId(configParams).callback; submoduleCallback(callBackSpy); const vrRequest = server.requests[0]; @@ -1179,8 +1179,8 @@ describe('IntentIQ tests', function () { } }; - let callBackSpy = sinon.spy(); - let submoduleCallback = intentIqIdSubmodule.getId(configParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = intentIqIdSubmodule.getId(configParams).callback; submoduleCallback(callBackSpy); const vrRequest = server.requests[0]; diff --git a/test/spec/modules/intenzeBidAdapter_spec.js b/test/spec/modules/intenzeBidAdapter_spec.js index 95e32c49b26..330c207b8a8 100644 --- a/test/spec/modules/intenzeBidAdapter_spec.js +++ b/test/spec/modules/intenzeBidAdapter_spec.js @@ -142,7 +142,7 @@ const VIDEO_BID_RESPONSE = { }], }; -let imgData = { +const imgData = { url: `https://example.com/image`, w: 1200, h: 627 @@ -201,7 +201,7 @@ describe('IntenzeAdapter', function () { }); it('should send the Coppa "required" flag set to "1" in the request', function () { - let serverRequest = spec.buildRequests([BANNER_BID_REQUEST]); + const serverRequest = spec.buildRequests([BANNER_BID_REQUEST]); expect(serverRequest.data[0].regs.coppa).to.equal(1); }); }); @@ -211,7 +211,7 @@ describe('IntenzeAdapter', function () { }); it('should return false when required params are not passed', function () { - let bid = Object.assign({}, NATIVE_BID_REQUEST); + const bid = Object.assign({}, NATIVE_BID_REQUEST); delete bid.params; bid.params = { 'IncorrectParam': 0 @@ -239,7 +239,7 @@ describe('IntenzeAdapter', function () { }); it('Returns empty data if no valid requests are passed', function () { - let serverRequest = spec.buildRequests([]); + const serverRequest = spec.buildRequests([]); expect(serverRequest).to.be.an('array').that.is.empty; }); }); @@ -291,7 +291,7 @@ describe('IntenzeAdapter', function () { describe('interpretResponse', function () { it('Empty response must return empty array', function () { const emptyResponse = null; - let response = spec.interpretResponse(emptyResponse); + const response = spec.interpretResponse(emptyResponse); expect(response).to.be.an('array').that.is.empty; }) @@ -316,10 +316,10 @@ describe('IntenzeAdapter', function () { ad: BANNER_BID_RESPONSE.seatbid[0].bid[0].adm } - let bannerResponses = spec.interpretResponse(bannerResponse); + const bannerResponses = spec.interpretResponse(bannerResponse); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(expectedBidResponse.requestId); @@ -355,10 +355,10 @@ describe('IntenzeAdapter', function () { vastUrl: VIDEO_BID_RESPONSE.seatbid[0].bid[0].ext.vastUrl } - let videoResponses = spec.interpretResponse(videoResponse); + const videoResponses = spec.interpretResponse(videoResponse); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'vastXml', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(expectedBidResponse.requestId); @@ -395,10 +395,10 @@ describe('IntenzeAdapter', function () { } } - let nativeResponses = spec.interpretResponse(nativeResponse); + const nativeResponses = spec.interpretResponse(nativeResponse); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'native', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(expectedBidResponse.requestId); diff --git a/test/spec/modules/interactiveOffersBidAdapter_spec.js b/test/spec/modules/interactiveOffersBidAdapter_spec.js index ff9ca123def..076f6b44186 100644 --- a/test/spec/modules/interactiveOffersBidAdapter_spec.js +++ b/test/spec/modules/interactiveOffersBidAdapter_spec.js @@ -3,7 +3,7 @@ import {spec} from 'modules/interactiveOffersBidAdapter.js'; describe('Interactive Offers Prebbid.js Adapter', function() { describe('isBidRequestValid function', function() { - let bid = {bidder: 'interactiveOffers', params: {partnerId: '100', tmax: 300}, mediaTypes: {banner: {sizes: [[300, 250]]}}, adUnitCode: 'pageAd01', transactionId: '16526f30-3be2-43f6-ab37-f1ab1f2ac25d', sizes: [[300, 250]], bidId: '227faa83f86546', bidderRequestId: '1eb79bc9dd44a', auctionId: '1aad860c-e04b-482b-acac-0da55ed491c8', src: 'client', bidRequestsCount: 1, bidderRequestsCount: 1, bidderWinsCount: 0}; + const bid = {bidder: 'interactiveOffers', params: {partnerId: '100', tmax: 300}, mediaTypes: {banner: {sizes: [[300, 250]]}}, adUnitCode: 'pageAd01', transactionId: '16526f30-3be2-43f6-ab37-f1ab1f2ac25d', sizes: [[300, 250]], bidId: '227faa83f86546', bidderRequestId: '1eb79bc9dd44a', auctionId: '1aad860c-e04b-482b-acac-0da55ed491c8', src: 'client', bidRequestsCount: 1, bidderRequestsCount: 1, bidderWinsCount: 0}; it('returns true if all the required params are present and properly formatted', function() { expect(spec.isBidRequestValid(bid)).to.be.true; @@ -22,20 +22,20 @@ describe('Interactive Offers Prebbid.js Adapter', function() { }); }); describe('buildRequests function', function() { - let validBidRequests = [{bidder: 'interactiveOffers', params: {partnerId: '100', tmax: 300}, mediaTypes: {banner: {sizes: [[300, 250]]}}, adUnitCode: 'pageAd01', transactionId: '16526f30-3be2-43f6-ab37-f1ab1f2ac25d', sizes: [[300, 250]], bidId: '227faa83f86546', bidderRequestId: '1eb79bc9dd44a', auctionId: '1aad860c-e04b-482b-acac-0da55ed491c8', src: 'client', bidRequestsCount: 1, bidderRequestsCount: 1, bidderWinsCount: 0}]; - let bidderRequest = {bidderCode: 'interactiveOffers', auctionId: '1aad860c-e04b-482b-acac-0da55ed491c8', bidderRequestId: '1eb79bc9dd44a', bids: [{bidder: 'interactiveOffers', params: {partnerId: '100', tmax: 300}, mediaTypes: {banner: {sizes: [[300, 250]]}}, adUnitCode: 'pageAd01', transactionId: '16526f30-3be2-43f6-ab37-f1ab1f2ac25d', sizes: [[300, 250]], bidId: '227faa83f86546', bidderRequestId: '1eb79bc9dd44a', auctionId: '1aad860c-e04b-482b-acac-0da55ed491c8', src: 'client', bidRequestsCount: 1, bidderRequestsCount: 1, bidderWinsCount: 0}], timeout: 5000, refererInfo: {referer: 'http://www.google.com', reachedTop: true, isAmp: false, numIframes: 0, stack: ['http://www.google.com'], canonicalUrl: null}}; + const validBidRequests = [{bidder: 'interactiveOffers', params: {partnerId: '100', tmax: 300}, mediaTypes: {banner: {sizes: [[300, 250]]}}, adUnitCode: 'pageAd01', transactionId: '16526f30-3be2-43f6-ab37-f1ab1f2ac25d', sizes: [[300, 250]], bidId: '227faa83f86546', bidderRequestId: '1eb79bc9dd44a', auctionId: '1aad860c-e04b-482b-acac-0da55ed491c8', src: 'client', bidRequestsCount: 1, bidderRequestsCount: 1, bidderWinsCount: 0}]; + const bidderRequest = {bidderCode: 'interactiveOffers', auctionId: '1aad860c-e04b-482b-acac-0da55ed491c8', bidderRequestId: '1eb79bc9dd44a', bids: [{bidder: 'interactiveOffers', params: {partnerId: '100', tmax: 300}, mediaTypes: {banner: {sizes: [[300, 250]]}}, adUnitCode: 'pageAd01', transactionId: '16526f30-3be2-43f6-ab37-f1ab1f2ac25d', sizes: [[300, 250]], bidId: '227faa83f86546', bidderRequestId: '1eb79bc9dd44a', auctionId: '1aad860c-e04b-482b-acac-0da55ed491c8', src: 'client', bidRequestsCount: 1, bidderRequestsCount: 1, bidderWinsCount: 0}], timeout: 5000, refererInfo: {referer: 'http://www.google.com', reachedTop: true, isAmp: false, numIframes: 0, stack: ['http://www.google.com'], canonicalUrl: null}}; it('returns a Prebid.js request object with a valid json string at the "data" property', function() { - let request = spec.buildRequests(validBidRequests, bidderRequest); + const request = spec.buildRequests(validBidRequests, bidderRequest); expect(request.data).length !== 0; }); }); describe('interpretResponse function', function() { - let openRTBResponse = {body: [{cur: 'USD', id: '2052afa35febb79baa9893cc3ae8b83b89740df65fe98b1bd358dbae6e912801', seatbid: [{seat: 1493, bid: [{ext: {tagid: '227faa83f86546'}, crid: '24477', adm: '', nurl: '', adid: '1138', adomain: ['url.com'], price: '1.53', w: 300, h: 250, iurl: 'http://url.com', cat: ['IAB13-11'], id: '5507ced7a39c06942d3cb260197112ba712e4180', attr: [], impid: 1, cid: '13280'}]}], 'bidid': '0959b9d58ba71b3db3fa29dce3b117c01fc85de0'}], 'headers': {}}; - let prebidRequest = {method: 'POST', url: 'https://url.com', data: '{"id": "1aad860c-e04b-482b-acac-0da55ed491c8", "site": {"id": "url.com", "name": "url.com", "domain": "url.com", "page": "http://url.com", "ref": "http://url.com", "publisher": {"id": 100, "name": "http://url.com", "domain": "url.com"}, "content": {"language": "pt-PT"}}, "source": {"fd": 0, "tid": "1aad860c-e04b-482b-acac-0da55ed491c8", "pchain": ""}, "device": {"ua": "Mozilla/5.0 (Macintosh; Intel Mac OS X 11_2_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.192 Safari/537.36", "language": "pt-PT"}, "user": {}, "imp": [{"id":1, "secure": 0, "tagid": "227faa83f86546", "banner": {"pos": 0, "w": 300, "h": 250, "format": [{"w": 300, "h": 250}]}}], "tmax": 300}', bidderRequest: {bidderCode: 'interactiveOffers', auctionId: '1aad860c-e04b-482b-acac-0da55ed491c8', bidderRequestId: '1eb79bc9dd44a', bids: [{bidder: 'interactiveOffers', params: {partnerId: '100', tmax: 300}, mediaTypes: {banner: {sizes: [[300, 250]]}}, adUnitCode: 'pageAd01', transactionId: '16526f30-3be2-43f6-ab37-f1ab1f2ac25d', sizes: [[300, 250]], bidId: '227faa83f86546', bidderRequestId: '1eb79bc9dd44a', auctionId: '1aad860c-e04b-482b-acac-0da55ed491c8', src: 'client', bidRequestsCount: 1, bidderRequestsCount: 1, bidderWinsCount: 0}], timeout: 5000, refererInfo: {referer: 'http://url.com', reachedTop: true, isAmp: false, numIframes: 0, stack: ['http://url.com'], canonicalUrl: null}}}; + const openRTBResponse = {body: [{cur: 'USD', id: '2052afa35febb79baa9893cc3ae8b83b89740df65fe98b1bd358dbae6e912801', seatbid: [{seat: 1493, bid: [{ext: {tagid: '227faa83f86546'}, crid: '24477', adm: '', nurl: '', adid: '1138', adomain: ['url.com'], price: '1.53', w: 300, h: 250, iurl: 'http://url.com', cat: ['IAB13-11'], id: '5507ced7a39c06942d3cb260197112ba712e4180', attr: [], impid: 1, cid: '13280'}]}], 'bidid': '0959b9d58ba71b3db3fa29dce3b117c01fc85de0'}], 'headers': {}}; + const prebidRequest = {method: 'POST', url: 'https://url.com', data: '{"id": "1aad860c-e04b-482b-acac-0da55ed491c8", "site": {"id": "url.com", "name": "url.com", "domain": "url.com", "page": "http://url.com", "ref": "http://url.com", "publisher": {"id": 100, "name": "http://url.com", "domain": "url.com"}, "content": {"language": "pt-PT"}}, "source": {"fd": 0, "tid": "1aad860c-e04b-482b-acac-0da55ed491c8", "pchain": ""}, "device": {"ua": "Mozilla/5.0 (Macintosh; Intel Mac OS X 11_2_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.192 Safari/537.36", "language": "pt-PT"}, "user": {}, "imp": [{"id":1, "secure": 0, "tagid": "227faa83f86546", "banner": {"pos": 0, "w": 300, "h": 250, "format": [{"w": 300, "h": 250}]}}], "tmax": 300}', bidderRequest: {bidderCode: 'interactiveOffers', auctionId: '1aad860c-e04b-482b-acac-0da55ed491c8', bidderRequestId: '1eb79bc9dd44a', bids: [{bidder: 'interactiveOffers', params: {partnerId: '100', tmax: 300}, mediaTypes: {banner: {sizes: [[300, 250]]}}, adUnitCode: 'pageAd01', transactionId: '16526f30-3be2-43f6-ab37-f1ab1f2ac25d', sizes: [[300, 250]], bidId: '227faa83f86546', bidderRequestId: '1eb79bc9dd44a', auctionId: '1aad860c-e04b-482b-acac-0da55ed491c8', src: 'client', bidRequestsCount: 1, bidderRequestsCount: 1, bidderWinsCount: 0}], timeout: 5000, refererInfo: {referer: 'http://url.com', reachedTop: true, isAmp: false, numIframes: 0, stack: ['http://url.com'], canonicalUrl: null}}}; it('returns an array of Prebid.js response objects', function() { - let prebidResponses = spec.interpretResponse(openRTBResponse, prebidRequest); + const prebidResponses = spec.interpretResponse(openRTBResponse, prebidRequest); expect(prebidResponses).to.not.be.empty; expect(prebidResponses[0].meta.advertiserDomains[0]).to.equal('url.com'); }); diff --git a/test/spec/modules/invibesBidAdapter_spec.js b/test/spec/modules/invibesBidAdapter_spec.js index b4243ba3167..d0c2dbaf50e 100644 --- a/test/spec/modules/invibesBidAdapter_spec.js +++ b/test/spec/modules/invibesBidAdapter_spec.js @@ -8,7 +8,7 @@ describe('invibesBidAdapter:', function () { const ENDPOINT = 'https://bid.videostep.com/Bid/VideoAdContent'; const SYNC_ENDPOINT = 'https://k.r66net.com/GetUserSync'; - let bidRequests = [ + const bidRequests = [ { bidId: 'b1', bidder: BIDDER_CODE, @@ -44,7 +44,7 @@ describe('invibesBidAdapter:', function () { } ]; - let bidRequestsWithDuplicatedplacementId = [ + const bidRequestsWithDuplicatedplacementId = [ { bidId: 'b1', bidder: BIDDER_CODE, @@ -80,7 +80,7 @@ describe('invibesBidAdapter:', function () { } ]; - let bidRequestsWithUniquePlacementId = [ + const bidRequestsWithUniquePlacementId = [ { bidId: 'b1', bidder: BIDDER_CODE, @@ -116,7 +116,7 @@ describe('invibesBidAdapter:', function () { } ]; - let bidRequestsWithUserId = [ + const bidRequestsWithUserId = [ { bidId: 'b1', bidder: BIDDER_CODE, @@ -153,18 +153,18 @@ describe('invibesBidAdapter:', function () { } ]; - let bidderRequestWithPageInfo = { + const bidderRequestWithPageInfo = { refererInfo: { page: 'https://randomWeb.com?someFakePara=fakeValue&secondParam=secondValue' }, auctionStart: Date.now() } - let StubbedPersistence = function (initialValue) { + const StubbedPersistence = function (initialValue) { var value = initialValue; return { load: function () { - let str = value || ''; + const str = value || ''; try { return JSON.parse(str); } catch (e) { @@ -176,7 +176,7 @@ describe('invibesBidAdapter:', function () { } }; - let SetBidderAccess = function() { + const SetBidderAccess = function() { config.setConfig({ deviceAccess: true }); @@ -257,34 +257,34 @@ describe('invibesBidAdapter:', function () { describe('buildRequests', function () { it('sends preventPageViewEvent as false on first call', function () { - let request = spec.buildRequests(bidRequests, bidderRequestWithPageInfo); + const request = spec.buildRequests(bidRequests, bidderRequestWithPageInfo); expect(request.data.preventPageViewEvent).to.be.false; }); it('sends isPlacementRefresh as false when the placement ids are used for the first time', function () { - let request = spec.buildRequests(bidRequestsWithUniquePlacementId, bidderRequestWithPageInfo); + const request = spec.buildRequests(bidRequestsWithUniquePlacementId, bidderRequestWithPageInfo); expect(request.data.isPlacementRefresh).to.be.false; }); it('sends preventPageViewEvent as true on 2nd call', function () { - let request = spec.buildRequests(bidRequests, bidderRequestWithPageInfo); + const request = spec.buildRequests(bidRequests, bidderRequestWithPageInfo); expect(request.data.preventPageViewEvent).to.be.true; }); it('sends isPlacementRefresh as true on multi requests on the same placement id', function () { - let request = spec.buildRequests(bidRequestsWithDuplicatedplacementId, bidderRequestWithPageInfo); + const request = spec.buildRequests(bidRequestsWithDuplicatedplacementId, bidderRequestWithPageInfo); expect(request.data.isPlacementRefresh).to.be.true; }); it('sends isInfiniteScrollPage as false initially', function () { - let request = spec.buildRequests(bidRequests, bidderRequestWithPageInfo); + const request = spec.buildRequests(bidRequests, bidderRequestWithPageInfo); expect(request.data.isInfiniteScrollPage).to.be.false; }); it('sends isPlacementRefresh as true on multi requests multiple calls with the same placement id from second call', function () { - let request = spec.buildRequests(bidRequests, bidderRequestWithPageInfo); + const request = spec.buildRequests(bidRequests, bidderRequestWithPageInfo); expect(request.data.isInfiniteScrollPage).to.be.false; - let duplicatedRequest = spec.buildRequests(bidRequests, bidderRequestWithPageInfo); + const duplicatedRequest = spec.buildRequests(bidRequests, bidderRequestWithPageInfo); expect(duplicatedRequest.data.isPlacementRefresh).to.be.true; }); @@ -452,7 +452,7 @@ describe('invibesBidAdapter:', function () { }); it('does not have capped ids if local storage variable is correctly formatted but no opt in', function () { - let bidderRequest = { + const bidderRequest = { auctionStart: Date.now(), gdprConsent: { vendorData: { @@ -534,13 +534,13 @@ describe('invibesBidAdapter:', function () { it('sends undefined lid when no cookie', function () { sandbox.stub(storage, 'getDataFromLocalStorage').returns(null); sandbox.stub(storage, 'getCookie').returns(null); - let request = spec.buildRequests(bidRequests, bidderRequestWithPageInfo); + const request = spec.buildRequests(bidRequests, bidderRequestWithPageInfo); expect(request.data.lId).to.be.undefined; }); it('sends pushed cids if they exist', function () { top.window.invibes.pushedCids = { 981: [] }; - let request = spec.buildRequests(bidRequests, bidderRequestWithPageInfo); + const request = spec.buildRequests(bidRequests, bidderRequestWithPageInfo); expect(request.data.pcids).to.contain(981); }); @@ -548,7 +548,7 @@ describe('invibesBidAdapter:', function () { top.window.invibes.optIn = 1; top.window.invibes.purposes = [true, false, false, false, false, false, false, false, false, false]; global.document.cookie = 'ivbsdid={"id":"dvdjkams6nkq","cr":' + Date.now() + ',"hc":0}'; - let bidderRequest = { + const bidderRequest = { gdprConsent: { vendorData: { vendorConsents: { @@ -562,7 +562,7 @@ describe('invibesBidAdapter:', function () { }; SetBidderAccess(); - let request = spec.buildRequests(bidRequests, bidderRequest); + const request = spec.buildRequests(bidRequests, bidderRequest); expect(request.data.lId).to.exist; }); @@ -570,7 +570,7 @@ describe('invibesBidAdapter:', function () { top.window.invibes.optIn = 1; top.window.invibes.purposes = [true, false, false, false, false, false, false, false, false, false]; sandbox.stub(storage, 'getCookie').returns(null) - let bidderRequest = { + const bidderRequest = { gdprConsent: { vendorData: { vendorConsents: { @@ -584,7 +584,7 @@ describe('invibesBidAdapter:', function () { }; SetBidderAccess(); - let request = spec.buildRequests(bidRequests, bidderRequest); + const request = spec.buildRequests(bidRequests, bidderRequest); expect(request.data.handIid).to.not.exist; }); @@ -592,7 +592,7 @@ describe('invibesBidAdapter:', function () { top.window.invibes.optIn = 1; top.window.invibes.purposes = [true, false, false, false, false, false, false, false, false, false]; global.document.cookie = 'handIid=abcdefghijkk'; - let bidderRequest = { + const bidderRequest = { gdprConsent: { vendorData: { vendorConsents: { @@ -606,12 +606,12 @@ describe('invibesBidAdapter:', function () { }; SetBidderAccess(); - let request = spec.buildRequests(bidRequests, bidderRequest); + const request = spec.buildRequests(bidRequests, bidderRequest); expect(request.data.handIid).to.equal('abcdefghijkk'); }); it('should send purpose 1', function () { - let bidderRequest = { + const bidderRequest = { gdprConsent: { vendorData: { gdprApplies: true, @@ -637,12 +637,12 @@ describe('invibesBidAdapter:', function () { page: 'https://randomWeb.com?someFakePara=fakeValue&secondParam=secondValue' } }; - let request = spec.buildRequests(bidRequests, bidderRequest); + const request = spec.buildRequests(bidRequests, bidderRequest); expect(request.data.purposes.split(',')[0]).to.equal('true'); }); it('should send purpose 2 & 7', function () { - let bidderRequest = { + const bidderRequest = { gdprConsent: { vendorData: { gdprApplies: true, @@ -668,12 +668,12 @@ describe('invibesBidAdapter:', function () { page: 'https://randomWeb.com?someFakePara=fakeValue&secondParam=secondValue' } }; - let request = spec.buildRequests(bidRequests, bidderRequest); + const request = spec.buildRequests(bidRequests, bidderRequest); expect(request.data.purposes.split(',')[1] && request.data.purposes.split(',')[6]).to.equal('true'); }); it('should send purpose 9', function () { - let bidderRequest = { + const bidderRequest = { gdprConsent: { vendorData: { gdprApplies: true, @@ -699,12 +699,12 @@ describe('invibesBidAdapter:', function () { page: 'https://randomWeb.com?someFakePara=fakeValue&secondParam=secondValue' } }; - let request = spec.buildRequests(bidRequests, bidderRequest); + const request = spec.buildRequests(bidRequests, bidderRequest); expect(request.data.purposes.split(',')[9]).to.equal('true'); }); it('should send legitimateInterests 2 & 7', function () { - let bidderRequest = { + const bidderRequest = { gdprConsent: { vendorData: { gdprApplies: true, @@ -742,11 +742,11 @@ describe('invibesBidAdapter:', function () { page: 'https://randomWeb.com?someFakePara=fakeValue&secondParam=secondValue' } }; - let request = spec.buildRequests(bidRequests, bidderRequest); + const request = spec.buildRequests(bidRequests, bidderRequest); expect(request.data.li.split(',')[1] && request.data.li.split(',')[6]).to.equal('true'); }); it('should send oi = 1 when vendorData is null (calculation will be performed by ADWEB)', function () { - let bidderRequest = { + const bidderRequest = { gdprConsent: { vendorData: null }, @@ -754,12 +754,12 @@ describe('invibesBidAdapter:', function () { page: 'https://randomWeb.com?someFakePara=fakeValue&secondParam=secondValue' } }; - let request = spec.buildRequests(bidRequests, bidderRequest); + const request = spec.buildRequests(bidRequests, bidderRequest); expect(request.data.oi).to.equal(0); }); it('should send oi = 2 when consent was approved on tcf v2', function () { - let bidderRequest = { + const bidderRequest = { gdprConsent: { vendorData: { gdprApplies: true, @@ -785,11 +785,11 @@ describe('invibesBidAdapter:', function () { page: 'https://randomWeb.com?someFakePara=fakeValue&secondParam=secondValue' } }; - let request = spec.buildRequests(bidRequests, bidderRequest); + const request = spec.buildRequests(bidRequests, bidderRequest); expect(request.data.oi).to.equal(2); }); it('should send oi = 0 when vendor consents for invibes are false on tcf v2', function () { - let bidderRequest = { + const bidderRequest = { gdprConsent: { vendorData: { gdprApplies: true, @@ -815,11 +815,11 @@ describe('invibesBidAdapter:', function () { page: 'https://randomWeb.com?someFakePara=fakeValue&secondParam=secondValue' } }; - let request = spec.buildRequests(bidRequests, bidderRequest); + const request = spec.buildRequests(bidRequests, bidderRequest); expect(request.data.oi).to.equal(0); }); it('should send oi = 2 when vendor consent for invibes are false and vendor legitimate interest for invibes are true on tcf v2', function () { - let bidderRequest = { + const bidderRequest = { gdprConsent: { vendorData: { gdprApplies: true, @@ -845,11 +845,11 @@ describe('invibesBidAdapter:', function () { page: 'https://randomWeb.com?someFakePara=fakeValue&secondParam=secondValue' } }; - let request = spec.buildRequests(bidRequests, bidderRequest); + const request = spec.buildRequests(bidRequests, bidderRequest); expect(request.data.oi).to.equal(2); }); it('should send oi = 0 when vendor consents and legitimate interests for invibes are false on tcf v2', function () { - let bidderRequest = { + const bidderRequest = { gdprConsent: { vendorData: { gdprApplies: true, @@ -875,11 +875,11 @@ describe('invibesBidAdapter:', function () { page: 'https://randomWeb.com?someFakePara=fakeValue&secondParam=secondValue' } }; - let request = spec.buildRequests(bidRequests, bidderRequest); + const request = spec.buildRequests(bidRequests, bidderRequest); expect(request.data.oi).to.equal(0); }); it('should send oi = 0 when purpose consents is null', function () { - let bidderRequest = { + const bidderRequest = { gdprConsent: { vendorData: { gdprApplies: true, @@ -892,12 +892,12 @@ describe('invibesBidAdapter:', function () { page: 'https://randomWeb.com?someFakePara=fakeValue&secondParam=secondValue' } }; - let request = spec.buildRequests(bidRequests, bidderRequest); + const request = spec.buildRequests(bidRequests, bidderRequest); expect(request.data.oi).to.equal(0); }); it('should send oi = 2 when purpose consents weren\'t approved on tcf v2', function () { - let bidderRequest = { + const bidderRequest = { gdprConsent: { vendorData: { gdprApplies: true, @@ -923,12 +923,12 @@ describe('invibesBidAdapter:', function () { page: 'https://randomWeb.com?someFakePara=fakeValue&secondParam=secondValue' } }; - let request = spec.buildRequests(bidRequests, bidderRequest); + const request = spec.buildRequests(bidRequests, bidderRequest); expect(request.data.oi).to.equal(2); }); it('should send oi = 2 when purpose consents are less then 10 on tcf v2', function () { - let bidderRequest = { + const bidderRequest = { gdprConsent: { vendorData: { gdprApplies: true, @@ -949,12 +949,12 @@ describe('invibesBidAdapter:', function () { page: 'https://randomWeb.com?someFakePara=fakeValue&secondParam=secondValue' } }; - let request = spec.buildRequests(bidRequests, bidderRequest); + const request = spec.buildRequests(bidRequests, bidderRequest); expect(request.data.oi).to.equal(2); }); it('should send oi = 4 when vendor consents are null on tcf v2', function () { - let bidderRequest = { + const bidderRequest = { gdprConsent: { vendorData: { gdprApplies: true, @@ -980,12 +980,12 @@ describe('invibesBidAdapter:', function () { page: 'https://randomWeb.com?someFakePara=fakeValue&secondParam=secondValue' } }; - let request = spec.buildRequests(bidRequests, bidderRequest); + const request = spec.buildRequests(bidRequests, bidderRequest); expect(request.data.oi).to.equal(4); }); it('should send oi = 4 when vendor consents for invibes is null on tcf v2', function () { - let bidderRequest = { + const bidderRequest = { gdprConsent: { vendorData: { gdprApplies: true, @@ -1011,12 +1011,12 @@ describe('invibesBidAdapter:', function () { page: 'https://randomWeb.com?someFakePara=fakeValue&secondParam=secondValue' } }; - let request = spec.buildRequests(bidRequests, bidderRequest); + const request = spec.buildRequests(bidRequests, bidderRequest); expect(request.data.oi).to.equal(4); }); it('should send oi = 4 when vendor consents for invibes is null on tcf v1', function () { - let bidderRequest = { + const bidderRequest = { gdprConsent: { vendorData: { gdprApplies: true, @@ -1035,12 +1035,12 @@ describe('invibesBidAdapter:', function () { page: 'https://randomWeb.com?someFakePara=fakeValue&secondParam=secondValue' } }; - let request = spec.buildRequests(bidRequests, bidderRequest); + const request = spec.buildRequests(bidRequests, bidderRequest); expect(request.data.oi).to.equal(4); }); it('should send oi = 4 when vendor consents consents are null on tcf v1', function () { - let bidderRequest = { + const bidderRequest = { gdprConsent: { vendorData: { gdprApplies: true, @@ -1059,12 +1059,12 @@ describe('invibesBidAdapter:', function () { page: 'https://randomWeb.com?someFakePara=fakeValue&secondParam=secondValue' } }; - let request = spec.buildRequests(bidRequests, bidderRequest); + const request = spec.buildRequests(bidRequests, bidderRequest); expect(request.data.oi).to.equal(4); }); it('should send oi = 2 when gdpr doesn\'t apply or has global consent', function () { - let bidderRequest = { + const bidderRequest = { gdprConsent: { vendorData: { gdprApplies: false, @@ -1075,12 +1075,12 @@ describe('invibesBidAdapter:', function () { page: 'https://randomWeb.com?someFakePara=fakeValue&secondParam=secondValue' } }; - let request = spec.buildRequests(bidRequests, bidderRequest); + const request = spec.buildRequests(bidRequests, bidderRequest); expect(request.data.oi).to.equal(2); }); it('should send oi = 2 when consent was approved on tcf v1', function () { - let bidderRequest = { + const bidderRequest = { gdprConsent: { vendorData: { gdprApplies: true, @@ -1099,12 +1099,12 @@ describe('invibesBidAdapter:', function () { page: 'https://randomWeb.com?someFakePara=fakeValue&secondParam=secondValue' } }; - let request = spec.buildRequests(bidRequests, bidderRequest); + const request = spec.buildRequests(bidRequests, bidderRequest); expect(request.data.oi).to.equal(2); }); it('should send oi = 2 when purpose consents weren\'t approved on tcf v1', function () { - let bidderRequest = { + const bidderRequest = { gdprConsent: { vendorData: { gdprApplies: true, @@ -1123,12 +1123,12 @@ describe('invibesBidAdapter:', function () { page: 'https://randomWeb.com?someFakePara=fakeValue&secondParam=secondValue' } }; - let request = spec.buildRequests(bidRequests, bidderRequest); + const request = spec.buildRequests(bidRequests, bidderRequest); expect(request.data.oi).to.equal(2); }); it('should send oi = 2 when purpose consents are less then 5 on tcf v1', function () { - let bidderRequest = { + const bidderRequest = { gdprConsent: { vendorData: { gdprApplies: true, @@ -1145,12 +1145,12 @@ describe('invibesBidAdapter:', function () { page: 'https://randomWeb.com?someFakePara=fakeValue&secondParam=secondValue' } }; - let request = spec.buildRequests(bidRequests, bidderRequest); + const request = spec.buildRequests(bidRequests, bidderRequest); expect(request.data.oi).to.equal(2); }); it('should send oi = 0 when vendor consents for invibes are false on tcf v1', function () { - let bidderRequest = { + const bidderRequest = { gdprConsent: { vendorData: { gdprApplies: true, @@ -1169,13 +1169,13 @@ describe('invibesBidAdapter:', function () { page: 'https://randomWeb.com?someFakePara=fakeValue&secondParam=secondValue' } }; - let request = spec.buildRequests(bidRequests, bidderRequest); + const request = spec.buildRequests(bidRequests, bidderRequest); expect(request.data.oi).to.equal(0); }); }); describe('interpretResponse', function () { - let response = { + const response = { Ads: [{ BidPrice: 0.5, VideoExposedId: 123 @@ -1188,7 +1188,7 @@ describe('invibesBidAdapter:', function () { } }; - let expectedResponse = [{ + const expectedResponse = [{ requestId: bidRequests[0].bidId, cpm: 0.5, width: 400, @@ -1206,7 +1206,7 @@ describe('invibesBidAdapter:', function () { meta: {} }]; - let multiResponse = { + const multiResponse = { MultipositionEnabled: true, AdPlacements: [{ Ads: [{ @@ -1222,7 +1222,7 @@ describe('invibesBidAdapter:', function () { }] }; - let invalidResponse = { + const invalidResponse = { AdPlacements: [{ Ads: [{ BidPrice: 0.5, @@ -1231,7 +1231,7 @@ describe('invibesBidAdapter:', function () { }] }; - let responseWithMeta = { + const responseWithMeta = { Ads: [{ BidPrice: 0.5, VideoExposedId: 123 @@ -1248,7 +1248,7 @@ describe('invibesBidAdapter:', function () { } }; - let responseWithAdUnit = { + const responseWithAdUnit = { Ads: [{ BidPrice: 0.5, VideoExposedId: 123 @@ -1306,22 +1306,22 @@ describe('invibesBidAdapter:', function () { context('when the response is not valid', function () { it('handles response with no bids requested', function () { - let emptyResult = spec.interpretResponse({body: response}); + const emptyResult = spec.interpretResponse({body: response}); expect(emptyResult).to.be.empty; }); it('handles empty response', function () { - let emptyResult = spec.interpretResponse(null, {bidRequests}); + const emptyResult = spec.interpretResponse(null, {bidRequests}); expect(emptyResult).to.be.empty; }); it('handles response with bidding is not configured', function () { - let emptyResult = spec.interpretResponse({body: {Ads: [{BidPrice: 1}]}}, {bidRequests}); + const emptyResult = spec.interpretResponse({body: {Ads: [{BidPrice: 1}]}}, {bidRequests}); expect(emptyResult).to.be.empty; }); it('handles response with no ads are received', function () { - let emptyResult = spec.interpretResponse({ + const emptyResult = spec.interpretResponse({ body: { BidModel: {PlacementId: '12345'}, AdReason: 'No ads' @@ -1331,12 +1331,12 @@ describe('invibesBidAdapter:', function () { }); it('handles response with no ads are received - no ad reason', function () { - let emptyResult = spec.interpretResponse({body: {BidModel: {PlacementId: '12345'}}}, {bidRequests}); + const emptyResult = spec.interpretResponse({body: {BidModel: {PlacementId: '12345'}}}, {bidRequests}); expect(emptyResult).to.be.empty; }); it('handles response when no placement Id matches', function () { - let emptyResult = spec.interpretResponse({ + const emptyResult = spec.interpretResponse({ body: { BidModel: {PlacementId: '123456'}, Ads: [{BidPrice: 1}] @@ -1346,42 +1346,42 @@ describe('invibesBidAdapter:', function () { }); it('handles response when placement Id is not present', function () { - let emptyResult = spec.interpretResponse({BidModel: {}, Ads: [{BidPrice: 1}]}, {bidRequests}); + const emptyResult = spec.interpretResponse({BidModel: {}, Ads: [{BidPrice: 1}]}, {bidRequests}); expect(emptyResult).to.be.empty; }); it('handles response when bid model is missing', function () { - let emptyResult = spec.interpretResponse(invalidResponse); + const emptyResult = spec.interpretResponse(invalidResponse); expect(emptyResult).to.be.empty; }); }); context('when the multiresponse is valid', function () { it('responds with a valid multiresponse bid', function () { - let result = spec.interpretResponse({body: multiResponse}, {bidRequests}); + const result = spec.interpretResponse({body: multiResponse}, {bidRequests}); expect(Object.keys(result[0])).to.have.members(Object.keys(expectedResponse[0])); }); it('responds with a valid singleresponse bid', function () { - let result = spec.interpretResponse({body: response}, {bidRequests}); + const result = spec.interpretResponse({body: response}, {bidRequests}); expect(Object.keys(result[0])).to.have.members(Object.keys(expectedResponse[0])); }); it('does not make multiple bids', function () { - let result = spec.interpretResponse({body: response}, {bidRequests}); - let secondResult = spec.interpretResponse({body: response}, {bidRequests}); + const result = spec.interpretResponse({body: response}, {bidRequests}); + const secondResult = spec.interpretResponse({body: response}, {bidRequests}); expect(secondResult).to.be.empty; }); it('bids using the adUnitCode', function () { - let result = spec.interpretResponse({body: responseWithAdUnit}, {bidRequests}); + const result = spec.interpretResponse({body: responseWithAdUnit}, {bidRequests}); expect(Object.keys(result[0])).to.have.members(Object.keys(expectedResponse[0])); }); }); context('when the response has meta', function () { it('responds with a valid bid, with the meta info', function () { - let result = spec.interpretResponse({body: responseWithMeta}, {bidRequests}); + const result = spec.interpretResponse({body: responseWithMeta}, {bidRequests}); expect(result[0].meta.advertiserName).to.equal('theadvertiser'); expect(result[0].meta.advertiserDomains).to.contain('theadvertiser.com'); expect(result[0].meta.advertiserDomains).to.contain('theadvertiser_2.com'); @@ -1455,14 +1455,14 @@ describe('invibesBidAdapter:', function () { describe('getUserSyncs', function () { it('returns undefined if disableUserSyncs not passed as bid request param ', function () { spec.buildRequests(bidRequestsWithUserId, bidderRequestWithPageInfo); - let response = spec.getUserSyncs({iframeEnabled: true}); + const response = spec.getUserSyncs({iframeEnabled: true}); expect(response).to.equal(undefined); }); it('returns an iframe if enabled', function () { spec.buildRequests(bidRequests, bidderRequestWithPageInfo); - let response = spec.getUserSyncs({iframeEnabled: true}); + const response = spec.getUserSyncs({iframeEnabled: true}); expect(response.type).to.equal('iframe'); expect(response.url).to.include(SYNC_ENDPOINT); }); @@ -1471,7 +1471,7 @@ describe('invibesBidAdapter:', function () { top.window.invibes.optIn = 1; spec.buildRequests(bidRequests, bidderRequestWithPageInfo); - let response = spec.getUserSyncs({iframeEnabled: true}); + const response = spec.getUserSyncs({iframeEnabled: true}); expect(response.type).to.equal('iframe'); expect(response.url).to.include(SYNC_ENDPOINT); expect(response.url).to.include('optIn'); @@ -1484,7 +1484,7 @@ describe('invibesBidAdapter:', function () { global.document.cookie = 'ivbsdid={"id":"dvdjkams6nkq","cr":' + Date.now() + ',"hc":0}'; SetBidderAccess(); - let response = spec.getUserSyncs({iframeEnabled: true}); + const response = spec.getUserSyncs({iframeEnabled: true}); expect(response.type).to.equal('iframe'); expect(response.url).to.include(SYNC_ENDPOINT); expect(response.url).to.include('optIn'); @@ -1498,7 +1498,7 @@ describe('invibesBidAdapter:', function () { localStorage.ivbsdid = 'dvdjkams6nkq'; SetBidderAccess(); - let response = spec.getUserSyncs({iframeEnabled: true}); + const response = spec.getUserSyncs({iframeEnabled: true}); expect(response.type).to.equal('iframe'); expect(response.url).to.include(SYNC_ENDPOINT); expect(response.url).to.include('optIn'); @@ -1508,19 +1508,19 @@ describe('invibesBidAdapter:', function () { it('returns undefined if iframe not enabled ', function () { spec.buildRequests(bidRequests, bidderRequestWithPageInfo); - let response = spec.getUserSyncs({iframeEnabled: false}); + const response = spec.getUserSyncs({iframeEnabled: false}); expect(response).to.equal(undefined); }); it('uses uspConsent when no gdprConsent', function () { - let bidderRequest = { + const bidderRequest = { uspConsent: '1YNY', refererInfo: { page: 'https://randomWeb.com?someFakePara=fakeValue&secondParam=secondValue' } }; - let request = spec.buildRequests(bidRequests, bidderRequest); + const request = spec.buildRequests(bidRequests, bidderRequest); expect(top.window.invibes.optIn).to.equal(2); expect(top.window.invibes.GdprModuleInstalled).to.be.false; expect(top.window.invibes.UspModuleInstalled).to.be.true; diff --git a/test/spec/modules/invisiblyAnalyticsAdapter_spec.js b/test/spec/modules/invisiblyAnalyticsAdapter_spec.js index e866d2404f3..71182d146a0 100644 --- a/test/spec/modules/invisiblyAnalyticsAdapter_spec.js +++ b/test/spec/modules/invisiblyAnalyticsAdapter_spec.js @@ -3,7 +3,7 @@ import { expect } from 'chai'; import {expectEvents} from '../../helpers/analytics.js'; import {server} from '../../mocks/xhr.js'; import { EVENTS, STATUS } from 'src/constants.js'; -let events = require('src/events'); +const events = require('src/events'); describe('Invisibly Analytics Adapter test suite', function () { let xhr; @@ -214,7 +214,7 @@ describe('Invisibly Analytics Adapter test suite', function () { }); // spec to test custom api endpoint it('support custom endpoint', function () { - let custom_url = 'custom url'; + const custom_url = 'custom url'; invisiblyAdapter.enableAnalytics({ provider: 'invisiblyAnalytics', options: { diff --git a/test/spec/modules/ipromBidAdapter_spec.js b/test/spec/modules/ipromBidAdapter_spec.js index bb2f364bece..3a1a6c972e1 100644 --- a/test/spec/modules/ipromBidAdapter_spec.js +++ b/test/spec/modules/ipromBidAdapter_spec.js @@ -44,7 +44,7 @@ describe('iPROM Adapter', function () { describe('validating bids', function () { it('should accept valid bid', function () { - let validBid = { + const validBid = { bidder: 'iprom', params: { id: '1234', @@ -58,7 +58,7 @@ describe('iPROM Adapter', function () { }); it('should reject bid if missing dimension and id', function () { - let invalidBid = { + const invalidBid = { bidder: 'iprom', params: {} }; @@ -69,7 +69,7 @@ describe('iPROM Adapter', function () { }); it('should reject bid if missing dimension', function () { - let invalidBid = { + const invalidBid = { bidder: 'iprom', params: { id: '1234', @@ -82,7 +82,7 @@ describe('iPROM Adapter', function () { }); it('should reject bid if dimension is not a string', function () { - let invalidBid = { + const invalidBid = { bidder: 'iprom', params: { id: '1234', @@ -96,7 +96,7 @@ describe('iPROM Adapter', function () { }); it('should reject bid if missing id', function () { - let invalidBid = { + const invalidBid = { bidder: 'iprom', params: { dimension: '300x250', @@ -109,7 +109,7 @@ describe('iPROM Adapter', function () { }); it('should reject bid if id is not a string', function () { - let invalidBid = { + const invalidBid = { bidder: 'iprom', params: { id: 1234, diff --git a/test/spec/modules/iqzoneBidAdapter_spec.js b/test/spec/modules/iqzoneBidAdapter_spec.js index 210d3a2d60b..2ae00aeeb5d 100644 --- a/test/spec/modules/iqzoneBidAdapter_spec.js +++ b/test/spec/modules/iqzoneBidAdapter_spec.js @@ -132,7 +132,7 @@ describe('IQZoneBidAdapter', function () { }); it('Returns general data valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys('deviceWidth', 'deviceHeight', @@ -212,7 +212,7 @@ describe('IQZoneBidAdapter', function () { } ]; - let serverRequest = spec.buildRequests(bids, bidderRequest); + const serverRequest = spec.buildRequests(bids, bidderRequest); const { placements } = serverRequest.data; for (let i = 0, len = placements.length; i < len; i++) { @@ -247,7 +247,7 @@ describe('IQZoneBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { delete bidderRequest.uspConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('object'); expect(data.gdpr).to.have.property('consentString'); @@ -261,7 +261,7 @@ describe('IQZoneBidAdapter', function () { bidderRequest.uspConsent = '1---'; delete bidderRequest.gdprConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -276,8 +276,8 @@ describe('IQZoneBidAdapter', function () { applicableSections: [8] }; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -291,8 +291,8 @@ describe('IQZoneBidAdapter', function () { bidderRequest.ortb2.regs.gpp = 'abc123'; bidderRequest.ortb2.regs.gpp_sid = [8]; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -322,9 +322,9 @@ describe('IQZoneBidAdapter', function () { } }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(banner.body[0].requestId); @@ -356,10 +356,10 @@ describe('IQZoneBidAdapter', function () { } }] }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -393,10 +393,10 @@ describe('IQZoneBidAdapter', function () { } }] }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys('requestId', 'cpm', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'native', 'meta'); expect(dataItem.native).to.have.keys('clickUrl', 'impressionTrackers', 'title', 'image') expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -427,7 +427,7 @@ describe('IQZoneBidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -443,7 +443,7 @@ describe('IQZoneBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -460,7 +460,7 @@ describe('IQZoneBidAdapter', function () { currency: 'USD', }] }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -473,7 +473,7 @@ describe('IQZoneBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/ivsBidAdapter_spec.js b/test/spec/modules/ivsBidAdapter_spec.js index 819c7480595..3b46f34bb2e 100644 --- a/test/spec/modules/ivsBidAdapter_spec.js +++ b/test/spec/modules/ivsBidAdapter_spec.js @@ -4,7 +4,7 @@ import { deepClone } from '../../../src/utils'; describe('ivsBidAdapter', function () { describe('isBidRequestValid()', function () { - let validBid = { + const validBid = { bidder: 'ivs', mediaTypes: { video: { @@ -24,19 +24,19 @@ describe('ivsBidAdapter', function () { }); it('should return false if publisherId info is missing', function () { - let bid = deepClone(validBid); + const bid = deepClone(validBid); delete bid.params.publisherId; assert.isFalse(spec.isBidRequestValid(bid)); }); it('should return false for empty video parameters', function () { - let bid = deepClone(validBid); + const bid = deepClone(validBid); delete bid.mediaTypes.video; assert.isFalse(spec.isBidRequestValid(bid)); }); it('should return false for non instream context', function () { - let bid = deepClone(validBid); + const bid = deepClone(validBid); bid.mediaTypes.video.context = 'outstream'; assert.isFalse(spec.isBidRequestValid(bid)); }); diff --git a/test/spec/modules/ixBidAdapter_spec.js b/test/spec/modules/ixBidAdapter_spec.js index adb0535bbbc..744ec32f8dd 100644 --- a/test/spec/modules/ixBidAdapter_spec.js +++ b/test/spec/modules/ixBidAdapter_spec.js @@ -1084,7 +1084,7 @@ describe('IndexexchangeAdapter', function () { const syncOptions = { 'iframeEnabled': true } - let userSync = spec.getUserSyncs(syncOptions, []); + const userSync = spec.getUserSyncs(syncOptions, []); expect(userSync[0].type).to.equal('iframe'); const USER_SYNC_URL = 'https://js-sec.indexww.com/um/ixmatch.html'; expect(userSync[0].url).to.equal(USER_SYNC_URL); @@ -1094,7 +1094,7 @@ describe('IndexexchangeAdapter', function () { const syncOptions = { 'iframeEnabled': false, } - let userSync = spec.getUserSyncs(syncOptions, []); + const userSync = spec.getUserSyncs(syncOptions, []); expect(userSync[0].type).to.equal('image'); const USER_SYNC_URL = 'https://dsum.casalemedia.com/pbusermatch?origin=prebid&site_id=123&p=1&i=0&gdpr=1&gdpr_consent=3huaa11=qu3198ae&us_privacy='; expect(userSync[0].url).to.equal(USER_SYNC_URL); @@ -1110,7 +1110,7 @@ describe('IndexexchangeAdapter', function () { syncsPerBidder: 3 } }) - let userSync = spec.getUserSyncs(syncOptions, []); + const userSync = spec.getUserSyncs(syncOptions, []); expect(userSync[0].type).to.equal('image'); const USER_SYNC_URL = 'https://dsum.casalemedia.com/pbusermatch?origin=prebid&site_id=123&p=1&i=0&gdpr=1&gdpr_consent=3huaa11=qu3198ae&us_privacy='; expect(userSync[0].url).to.equal(USER_SYNC_URL); @@ -1126,7 +1126,7 @@ describe('IndexexchangeAdapter', function () { syncsPerBidder: 3 } }); - let userSync = spec.getUserSyncs(syncOptions, [{ 'body': { 'ext': { 'publishersyncsperbidderoverride': 0 } } }]); + const userSync = spec.getUserSyncs(syncOptions, [{ 'body': { 'ext': { 'publishersyncsperbidderoverride': 0 } } }]); expect(userSync.length).to.equal(0); }); @@ -1140,7 +1140,7 @@ describe('IndexexchangeAdapter', function () { syncsPerBidder: 3 } }); - let userSync = spec.getUserSyncs(syncOptions, [{ 'body': { 'ext': { 'publishersyncsperbidderoverride': 2 } } }]); + const userSync = spec.getUserSyncs(syncOptions, [{ 'body': { 'ext': { 'publishersyncsperbidderoverride': 2 } } }]); expect(userSync[0].type).to.equal('image'); const USER_SYNC_URL_0 = 'https://dsum.casalemedia.com/pbusermatch?origin=prebid&site_id=123&p=2&i=0&gdpr=1&gdpr_consent=3huaa11=qu3198ae&us_privacy='; const USER_SYNC_URL_1 = 'https://dsum.casalemedia.com/pbusermatch?origin=prebid&site_id=123&p=2&i=1&gdpr=1&gdpr_consent=3huaa11=qu3198ae&us_privacy='; @@ -1159,7 +1159,7 @@ describe('IndexexchangeAdapter', function () { syncsPerBidder: 3 } }); - let userSync = spec.getUserSyncs(syncOptions, [{ 'body': { 'ext': { 'publishersyncsperbidderoverride': 4 } } }]); + const userSync = spec.getUserSyncs(syncOptions, [{ 'body': { 'ext': { 'publishersyncsperbidderoverride': 4 } } }]); expect(userSync[0].type).to.equal('image'); const USER_SYNC_URL_0 = 'https://dsum.casalemedia.com/pbusermatch?origin=prebid&site_id=123&p=3&i=0&gdpr=1&gdpr_consent=3huaa11=qu3198ae&us_privacy='; const USER_SYNC_URL_1 = 'https://dsum.casalemedia.com/pbusermatch?origin=prebid&site_id=123&p=3&i=1&gdpr=1&gdpr_consent=3huaa11=qu3198ae&us_privacy='; @@ -1180,7 +1180,7 @@ describe('IndexexchangeAdapter', function () { syncsPerBidder: 0 } }); - let userSync = spec.getUserSyncs(syncOptions, [{ 'body': { 'ext': { 'publishersyncsperbidderoverride': 2 } } }]); + const userSync = spec.getUserSyncs(syncOptions, [{ 'body': { 'ext': { 'publishersyncsperbidderoverride': 2 } } }]); expect(userSync[0].type).to.equal('image'); const USER_SYNC_URL_0 = 'https://dsum.casalemedia.com/pbusermatch?origin=prebid&site_id=123&p=2&i=0&gdpr=1&gdpr_consent=3huaa11=qu3198ae&us_privacy='; const USER_SYNC_URL_1 = 'https://dsum.casalemedia.com/pbusermatch?origin=prebid&site_id=123&p=2&i=1&gdpr=1&gdpr_consent=3huaa11=qu3198ae&us_privacy='; @@ -1424,7 +1424,7 @@ describe('IndexexchangeAdapter', function () { }); it('should fail if native openRTB object contains no valid assets', function () { - let bid = utils.deepClone(DEFAULT_NATIVE_VALID_BID[0]); + const bid = utils.deepClone(DEFAULT_NATIVE_VALID_BID[0]); bid.nativeOrtbRequest = {} expect(spec.isBidRequestValid(bid)).to.be.false; @@ -1637,12 +1637,12 @@ describe('IndexexchangeAdapter', function () { it('IX adapter filters eids from prebid past the maximum eid limit', function () { const cloneValidBid = utils.deepClone(DEFAULT_VIDEO_VALID_BID); - let eid_sent_from_prebid = generateEid(55); + const eid_sent_from_prebid = generateEid(55); cloneValidBid[0].userIdAsEids = utils.deepClone(eid_sent_from_prebid); const request = spec.buildRequests(cloneValidBid, DEFAULT_OPTION)[0]; const payload = extractPayload(request); expect(payload.user.eids).to.have.lengthOf(50); - let eid_accepted = eid_sent_from_prebid.slice(0, 50); + const eid_accepted = eid_sent_from_prebid.slice(0, 50); expect(payload.user.eids).to.have.deep.members(eid_accepted); expect(payload.ext.ixdiag.eidLength).to.equal(55); }); @@ -1678,7 +1678,7 @@ describe('IndexexchangeAdapter', function () { } }; const cloneValidBid = utils.deepClone(DEFAULT_VIDEO_VALID_BID); - let eid_sent_from_prebid = generateEid(49); + const eid_sent_from_prebid = generateEid(49); cloneValidBid[0].userIdAsEids = utils.deepClone(eid_sent_from_prebid); const request = spec.buildRequests(cloneValidBid, DEFAULT_OPTION)[0]; const payload = extractPayload(request); @@ -1699,7 +1699,7 @@ describe('IndexexchangeAdapter', function () { it('Has incoming eids with no uid', function () { const cloneValidBid = utils.deepClone(DEFAULT_VIDEO_VALID_BID); - let eid_sent_from_prebid = [ + const eid_sent_from_prebid = [ { source: 'catijah.org' }, @@ -2912,7 +2912,7 @@ describe('IndexexchangeAdapter', function () { for (var i = 0; i < requests.length; i++) { const reqSize = `${requests[i].url}?${utils.parseQueryStringParameters(requests[i].data)}`.length; expect(reqSize).to.be.lessThan(8000); - let payload = extractPayload(requests[i]); + const payload = extractPayload(requests[i]); expect(payload.source.ext.schain).to.deep.equal(SAMPLE_SCHAIN); } }); @@ -3254,7 +3254,7 @@ describe('IndexexchangeAdapter', function () { }); it('should build request with given asset properties', function () { - let bid = utils.deepClone(DEFAULT_NATIVE_VALID_BID) + const bid = utils.deepClone(DEFAULT_NATIVE_VALID_BID) bid[0].nativeOrtbRequest = { assets: [{ id: 0, required: 0, title: { len: 140 } }, { id: 1, required: 0, video: { mimes: ['javascript'], minduration: 10, maxduration: 60, protocols: [1] } }] } @@ -3264,7 +3264,7 @@ describe('IndexexchangeAdapter', function () { }); it('should build request with all possible Prebid asset properties', function () { - let bid = utils.deepClone(DEFAULT_NATIVE_VALID_BID) + const bid = utils.deepClone(DEFAULT_NATIVE_VALID_BID) bid[0].nativeOrtbRequest = { 'ver': '1.2', 'assets': [ @@ -3556,7 +3556,7 @@ describe('IndexexchangeAdapter', function () { it('impression should have paapi extension when passed', function () { const bidderRequest = deepClone(DEFAULT_OPTION_FLEDGE_ENABLED); - let bid = utils.deepClone(DEFAULT_BANNER_VALID_BID_WITH_FLEDGE_ENABLED[0]); + const bid = utils.deepClone(DEFAULT_BANNER_VALID_BID_WITH_FLEDGE_ENABLED[0]); bid.ortb2Imp.ext.ae = 1 bid.ortb2Imp.ext.paapi = { requestedSize: { @@ -3944,7 +3944,7 @@ describe('IndexexchangeAdapter', function () { }); it('should not set bid[].renderer if renderer defined at mediaType.video level', function () { - let outstreamAdUnit = utils.deepClone(DEFAULT_MULTIFORMAT_BANNER_VALID_BID); + const outstreamAdUnit = utils.deepClone(DEFAULT_MULTIFORMAT_BANNER_VALID_BID); outstreamAdUnit[0].mediaTypes.video.renderer = { url: 'test', render: function () { } @@ -3956,7 +3956,7 @@ describe('IndexexchangeAdapter', function () { }); it('should not set bid[].renderer if renderer defined at the ad unit level', function () { - let outstreamAdUnit = utils.deepClone(DEFAULT_MULTIFORMAT_BANNER_VALID_BID); + const outstreamAdUnit = utils.deepClone(DEFAULT_MULTIFORMAT_BANNER_VALID_BID); outstreamAdUnit[0].renderer = { url: 'test', render: function () { } @@ -3968,7 +3968,7 @@ describe('IndexexchangeAdapter', function () { }); it('should set bid[].renderer if ad unit renderer is invalid', function () { - let outstreamAdUnit = utils.deepClone(DEFAULT_MULTIFORMAT_BANNER_VALID_BID); + const outstreamAdUnit = utils.deepClone(DEFAULT_MULTIFORMAT_BANNER_VALID_BID); outstreamAdUnit[0].mediaTypes.video.renderer = { url: 'test' }; @@ -3979,7 +3979,7 @@ describe('IndexexchangeAdapter', function () { }); it('should set bid[].renderer if ad unit renderer is a backup', function () { - let outstreamAdUnit = utils.deepClone(DEFAULT_MULTIFORMAT_BANNER_VALID_BID); + const outstreamAdUnit = utils.deepClone(DEFAULT_MULTIFORMAT_BANNER_VALID_BID); outstreamAdUnit[0].mediaTypes.video.renderer = { url: 'test', render: function () { }, @@ -4062,7 +4062,7 @@ describe('IndexexchangeAdapter', function () { } } ]; - let bid_response = DEFAULT_VIDEO_BID_RESPONSE_WITH_XML_ADM; + const bid_response = DEFAULT_VIDEO_BID_RESPONSE_WITH_XML_ADM; bid_response.seatbid[0].bid[0].ext['vasturl'] = 'www.abcd.com/vast'; const result = spec.interpretResponse({ body: bid_response }, { data: videoBidderRequest.data, validBidRequests: ONE_VIDEO @@ -4609,7 +4609,7 @@ describe('IndexexchangeAdapter', function () { expect(requests).to.be.an('array'); // buildRequestv2 enabled causes only 1 requests to get generated. expect(requests).to.have.lengthOf(1); - for (let request of requests) { + for (const request of requests) { expect(request.method).to.equal('POST'); } }); @@ -4803,7 +4803,7 @@ describe('IndexexchangeAdapter', function () { const bids = [DEFAULT_MULTIFORMAT_BANNER_VALID_BID[0], DEFAULT_MULTIFORMAT_VIDEO_VALID_BID[0]]; bids[0].params.bidFloor = 2.35; bids[0].params.bidFloorCur = 'USD'; - let adunitcode = bids[1].adUnitCode; + const adunitcode = bids[1].adUnitCode; bids[1].adUnitCode = bids[0].adUnitCode; bids[1].params.bidFloor = 2.05; bids[1].params.bidFloorCur = 'USD'; @@ -4821,7 +4821,7 @@ describe('IndexexchangeAdapter', function () { const bids = [DEFAULT_MULTIFORMAT_BANNER_VALID_BID[0], DEFAULT_MULTIFORMAT_NATIVE_VALID_BID[0]]; bids[0].params.bidFloor = 2.35; bids[0].params.bidFloorCur = 'USD'; - let adunitcode = bids[1].adUnitCode; + const adunitcode = bids[1].adUnitCode; bids[1].adUnitCode = bids[0].adUnitCode; bids[1].params.bidFloor = 2.05; bids[1].params.bidFloorCur = 'USD'; @@ -4838,7 +4838,7 @@ describe('IndexexchangeAdapter', function () { const bids = [DEFAULT_MULTIFORMAT_BANNER_VALID_BID[0], DEFAULT_MULTIFORMAT_NATIVE_VALID_BID[0]]; bids[0].params.bidFloor = 2.05; bids[0].params.bidFloorCur = 'USD'; - let adunitcode = bids[1].adUnitCode; + const adunitcode = bids[1].adUnitCode; bids[1].adUnitCode = bids[0].adUnitCode; bids[1].params.bidFloor = 2.35; bids[1].params.bidFloorCur = 'USD'; @@ -4852,7 +4852,7 @@ describe('IndexexchangeAdapter', function () { }); it('should return valid banner and video requests, different adunit, creates multiimp request', function () { - let bid = DEFAULT_MULTIFORMAT_VALID_BID[0] + const bid = DEFAULT_MULTIFORMAT_VALID_BID[0] bid.bidId = '1abcdef' const bids = [DEFAULT_MULTIFORMAT_VIDEO_VALID_BID[0], bid]; const request = spec.buildRequests(bids, {}); @@ -4861,7 +4861,7 @@ describe('IndexexchangeAdapter', function () { }); it('should return valid video requests, different adunit, creates multiimp request', function () { - let bid = DEFAULT_BANNER_VALID_BID[0] + const bid = DEFAULT_BANNER_VALID_BID[0] bid.bidId = '1abcdef' const bids = [DEFAULT_VIDEO_VALID_BID[0], bid]; const request = spec.buildRequests(bids, {}); diff --git a/test/spec/modules/jixieBidAdapter_spec.js b/test/spec/modules/jixieBidAdapter_spec.js index d40d32f7446..710e7c7bb5c 100644 --- a/test/spec/modules/jixieBidAdapter_spec.js +++ b/test/spec/modules/jixieBidAdapter_spec.js @@ -26,7 +26,7 @@ describe('jixie Adapter', function () { * isBidRequestValid */ describe('isBidRequestValid', function () { - let bid = { + const bid = { 'bidder': 'jixie', 'params': { 'unit': 'prebidsampleunit' @@ -43,13 +43,13 @@ describe('jixie Adapter', function () { }); it('should return false when required params obj does not exist', function () { - let bid0 = Object.assign({}, bid); + const bid0 = Object.assign({}, bid); delete bid0.params; expect(spec.isBidRequestValid(bid0)).to.equal(false); }); it('should return false when params obj does not contain unit property', function () { - let bid1 = Object.assign({}, bid); + const bid1 = Object.assign({}, bid); bid1.params = { rubbish: '' }; expect(spec.isBidRequestValid(bid1)).to.equal(false); }); @@ -94,7 +94,7 @@ describe('jixie Adapter', function () { timeout: timeout_ }; // to serve as the object that prebid will call jixie buildRequest with: (param1) - let bidRequests_ = [ + const bidRequests_ = [ { 'bidder': 'jixie', 'params': { @@ -239,7 +239,7 @@ describe('jixie Adapter', function () { // similar to above test case but here we force some clientid sessionid values // and domain, pageurl // get the interceptors ready: - let getConfigStub = sinon.stub(config, 'getConfig'); + const getConfigStub = sinon.stub(config, 'getConfig'); getConfigStub.callsFake(function fakeFn(prop) { if (prop == 'jixie') { return testJixieCfg_; @@ -247,8 +247,8 @@ describe('jixie Adapter', function () { return null; }); - let getCookieStub = sinon.stub(storage, 'getCookie'); - let getLocalStorageStub = sinon.stub(storage, 'getDataFromLocalStorage'); + const getCookieStub = sinon.stub(storage, 'getCookie'); + const getLocalStorageStub = sinon.stub(storage, 'getDataFromLocalStorage'); getCookieStub .withArgs('ckname1') .returns(ckname1Val_); @@ -283,7 +283,7 @@ describe('jixie Adapter', function () { .withArgs('_jxxs') .returns(sessionIdTest1_ ); - let miscDimsStub = sinon.stub(jixieaux, 'getMiscDims'); + const miscDimsStub = sinon.stub(jixieaux, 'getMiscDims'); miscDimsStub .returns({ device: device_, pageurl: pageurl_, domain: domain_, mkeywords: keywords_ }); @@ -316,7 +316,7 @@ describe('jixie Adapter', function () { });// it it('it should popular the pricegranularity when info is available', function () { - let content = { + const content = { 'ranges': [{ 'max': 12, 'increment': 0.5 @@ -327,7 +327,7 @@ describe('jixie Adapter', function () { }], precision: 1 }; - let getConfigStub = sinon.stub(config, 'getConfig'); + const getConfigStub = sinon.stub(config, 'getConfig'); getConfigStub.callsFake(function fakeFn(prop) { if (prop == 'priceGranularity') { return content; @@ -343,8 +343,8 @@ describe('jixie Adapter', function () { }); it('it should popular the device info when it is available', function () { - let getConfigStub = sinon.stub(config, 'getConfig'); - let content = {w: 500, h: 400}; + const getConfigStub = sinon.stub(config, 'getConfig'); + const content = {w: 500, h: 400}; getConfigStub.callsFake(function fakeFn(prop) { if (prop == 'device') { return content; @@ -385,7 +385,7 @@ describe('jixie Adapter', function () { }); it('it should populate the floor info when available', function () { - let oneSpecialBidReq = deepClone(bidRequests_[0]); + const oneSpecialBidReq = deepClone(bidRequests_[0]); let request, payload = null; // 1 floor is not set request = spec.buildRequests([oneSpecialBidReq], bidderRequest_); @@ -393,7 +393,7 @@ describe('jixie Adapter', function () { expect(payload.bids[0].bidFloor).to.not.exist; // 2 floor is set - let getFloorResponse = { currency: 'USD', floor: 2.1 }; + const getFloorResponse = { currency: 'USD', floor: 2.1 }; oneSpecialBidReq.getFloor = () => getFloorResponse; request = spec.buildRequests([oneSpecialBidReq], bidderRequest_); payload = JSON.parse(request.data); @@ -401,14 +401,14 @@ describe('jixie Adapter', function () { }); it('it should populate the aid field when available', function () { - let oneSpecialBidReq = deepClone(bidRequests_[0]); + const oneSpecialBidReq = deepClone(bidRequests_[0]); // 1 aid is not set in the jixie config let request = spec.buildRequests([oneSpecialBidReq], bidderRequest_); let payload = JSON.parse(request.data); expect(payload.aid).to.eql(''); // 2 aid is set in the jixie config - let getConfigStub = sinon.stub(config, 'getConfig'); + const getConfigStub = sinon.stub(config, 'getConfig'); getConfigStub.callsFake(function fakeFn(prop) { if (prop == 'jixie') { return { aid: '11223344556677889900' }; @@ -622,8 +622,8 @@ describe('jixie Adapter', function () { }); it('should get correct bid response', function () { - let setCookieSpy = sinon.spy(storage, 'setCookie'); - let setLocalStorageSpy = sinon.spy(storage, 'setDataInLocalStorage'); + const setCookieSpy = sinon.spy(storage, 'setCookie'); + const setLocalStorageSpy = sinon.spy(storage, 'setDataInLocalStorage'); const result = spec.interpretResponse({body: responseBody_}, requestObj_) expect(setLocalStorageSpy.calledWith('_jxx', '43aacc10-f643-11ea-8a10-c5fe2d394e7e')).to.equal(true); expect(setLocalStorageSpy.calledWith('_jxxs', '1600057934-43aacc10-f643-11ea-8a10-c5fe2d394e7e')).to.equal(true); @@ -708,7 +708,7 @@ describe('jixie Adapter', function () { ajaxStub.restore(); }) - let TRACKINGURL_ = 'https://abc.com/sync?action=bidwon'; + const TRACKINGURL_ = 'https://abc.com/sync?action=bidwon'; it('Should fire if the adserver trackingUrl flag says so', function() { spec.onBidWon({ trackingUrl: TRACKINGURL_ }) @@ -733,7 +733,7 @@ describe('jixie Adapter', function () { } ] } - let result = spec.getUserSyncs(syncOptions, [{ body: response }]); + const result = spec.getUserSyncs(syncOptions, [{ body: response }]); expect(result[0].type).to.equal('iframe') expect(result[1].type).to.equal('image') }) @@ -754,7 +754,7 @@ describe('jixie Adapter', function () { } ] } - let result = spec.getUserSyncs(syncOptions, [{ body: response }]); + const result = spec.getUserSyncs(syncOptions, [{ body: response }]); expect(result[0].type).to.equal('image') expect(result[1].type).to.equal('image') }) @@ -774,7 +774,7 @@ describe('jixie Adapter', function () { } ] } - let result = spec.getUserSyncs(syncOptions, [{ body: response }]); + const result = spec.getUserSyncs(syncOptions, [{ body: response }]); expect(result.length).to.equal(0) }) }) diff --git a/test/spec/modules/justpremiumBidAdapter_spec.js b/test/spec/modules/justpremiumBidAdapter_spec.js index 3b78be7e9c0..21cd488e745 100644 --- a/test/spec/modules/justpremiumBidAdapter_spec.js +++ b/test/spec/modules/justpremiumBidAdapter_spec.js @@ -12,7 +12,7 @@ describe('justpremium adapter', function () { sandbox.restore(); }); - let schainConfig = { + const schainConfig = { 'ver': '1.0', 'complete': 1, 'nodes': [ @@ -24,7 +24,7 @@ describe('justpremium adapter', function () { ] } - let adUnits = [ + const adUnits = [ { adUnitCode: 'div-gpt-ad-1471513102552-1', bidder: 'justpremium', @@ -64,7 +64,7 @@ describe('justpremium adapter', function () { }, ] - let bidderRequest = { + const bidderRequest = { uspConsent: '1YYN', refererInfo: { referer: 'https://justpremium.com' @@ -134,7 +134,7 @@ describe('justpremium adapter', function () { describe('interpretResponse', function () { const request = spec.buildRequests(adUnits, bidderRequest) it('Verify server response', function () { - let response = { + const response = { 'bid': { '28313': [{ 'id': 3213123, @@ -155,7 +155,7 @@ describe('justpremium adapter', function () { 'deals': {} } - let expectedResponse = [ + const expectedResponse = [ { requestId: '319a5029c362f4', creativeId: 3213123, @@ -176,7 +176,7 @@ describe('justpremium adapter', function () { } ] - let result = spec.interpretResponse({body: response}, request) + const result = spec.interpretResponse({body: response}, request) expect(Object.keys(result[0])).to.deep.equal(Object.keys(expectedResponse[0])) expect(result[0]).to.not.equal(null) @@ -194,7 +194,7 @@ describe('justpremium adapter', function () { }) it('Verify wrong server response', function () { - let response = { + const response = { 'bid': { '28313': [] }, @@ -203,7 +203,7 @@ describe('justpremium adapter', function () { } } - let result = spec.interpretResponse({body: response}, request) + const result = spec.interpretResponse({body: response}, request) expect(result.length).to.equal(0) }) }) diff --git a/test/spec/modules/jwplayerRtdProvider_spec.js b/test/spec/modules/jwplayerRtdProvider_spec.js index 58cfc751a4f..e60d346de0f 100644 --- a/test/spec/modules/jwplayerRtdProvider_spec.js +++ b/test/spec/modules/jwplayerRtdProvider_spec.js @@ -768,6 +768,9 @@ describe('jwplayerRtdProvider', function() { const contentData = getContentData(testMediaId, testSegments); expect(contentData).to.have.property('name', 'jwplayer.com'); expect(contentData.ext).to.have.property('segtax', 502); + expect(contentData).to.have.property('cids'); + expect(contentData.cids).to.have.length(1); + expect(contentData.cids[0]).to.equal(testMediaId); expect(contentData.ext).to.have.property('cids'); expect(contentData.ext.cids).to.have.length(1); expect(contentData.ext.cids[0]).to.equal(testMediaId); @@ -779,6 +782,9 @@ describe('jwplayerRtdProvider', function() { const contentData = getContentData(testMediaId); expect(contentData).to.have.property('name', 'jwplayer.com'); expect(contentData.ext.segtax).to.be.undefined; + expect(contentData).to.have.property('cids'); + expect(contentData.cids).to.have.length(1); + expect(contentData.cids[0]).to.equal(testMediaId); expect(contentData.ext).to.have.property('cids'); expect(contentData.ext.cids).to.have.length(1); expect(contentData.ext.cids[0]).to.equal(testMediaId); @@ -790,6 +796,7 @@ describe('jwplayerRtdProvider', function() { const contentData = getContentData(null, testSegments); expect(contentData).to.have.property('name', 'jwplayer.com'); expect(contentData.ext).to.have.property('segtax', 502); + expect(contentData).to.not.have.property('cids'); expect(contentData.ext).to.not.have.property('cids'); expect(contentData.segment).to.deep.equal(testSegments); }); diff --git a/test/spec/modules/kargoAnalyticsAdapter_spec.js b/test/spec/modules/kargoAnalyticsAdapter_spec.js index c2acd86defa..35b6210778d 100644 --- a/test/spec/modules/kargoAnalyticsAdapter_spec.js +++ b/test/spec/modules/kargoAnalyticsAdapter_spec.js @@ -2,7 +2,7 @@ import kargoAnalyticsAdapter from 'modules/kargoAnalyticsAdapter.js'; import { expect } from 'chai'; import { server } from 'test/mocks/xhr.js'; import { EVENTS } from 'src/constants.js'; -let events = require('src/events'); +const events = require('src/events'); describe('Kargo Analytics Adapter', function () { const adapterConfig = { diff --git a/test/spec/modules/kargoBidAdapter_spec.js b/test/spec/modules/kargoBidAdapter_spec.js index 031f8af9139..44162dc70ee 100644 --- a/test/spec/modules/kargoBidAdapter_spec.js +++ b/test/spec/modules/kargoBidAdapter_spec.js @@ -117,7 +117,7 @@ describe('kargo adapter tests', function() { '2_93': '5ee24138-5e03-4b9d-a953-38e833f2849f' }; function buildCrbValue(isCookie, withIds, withTdid, withLexId, withClientId, optOut) { - let value = { + const value = { expireTime: Date.now() + 60000, lastSyncedAt: Date.now() - 60000, optOut, @@ -629,24 +629,24 @@ describe('kargo adapter tests', function() { it('does not send currency if it is not defined', function() { undefinedCurrency = true; - let payload = getPayloadFromTestBids(testBids); + const payload = getPayloadFromTestBids(testBids); expect(payload.cur).to.be.undefined; }); it('does not send currency if it is missing', function() { noAdServerCurrency = true; - let payload = getPayloadFromTestBids(testBids); + const payload = getPayloadFromTestBids(testBids); expect(payload.cur).to.be.undefined; }); it('does not send currency if it is USD', function() { - let payload = getPayloadFromTestBids(testBids); + const payload = getPayloadFromTestBids(testBids); expect(payload.cur).to.be.undefined; }); it('provides the currency if it is not USD', function() { nonUSDAdServerCurrency = true; - let payload = getPayloadFromTestBids(testBids); + const payload = getPayloadFromTestBids(testBids); expect(payload.cur).to.equal('EUR'); }); @@ -1336,7 +1336,7 @@ describe('kargo adapter tests', function() { sandbox.stub(STORAGE, 'getDataFromLocalStorage').throws(); localStorage.removeItem('krg_crb'); document.cookie = 'krg_crb=; expires=Thu, 01 Jan 1970 00:00:00 GMT; path=/'; - let payload = getPayloadFromTestBids(testBids); + const payload = getPayloadFromTestBids(testBids); expect(payload.user).to.deep.equal({ crbIDs: {}, data: [] @@ -1346,7 +1346,7 @@ describe('kargo adapter tests', function() { describe('sua', function() { it('is not provided if not present in the first valid bid', function() { - let payload = getPayloadFromTestBids([ + const payload = getPayloadFromTestBids([ ...testBids, { ...minimumBidParams, @@ -1379,7 +1379,7 @@ describe('kargo adapter tests', function() { }); it('is provided if present in the first valid bid', function() { - let payload = getPayloadFromTestBids([ + const payload = getPayloadFromTestBids([ { ...minimumBidParams, ortb2: { device: { sua: { @@ -1459,7 +1459,7 @@ describe('kargo adapter tests', function() { }); it('does not send non-mapped attributes', function() { - let payload = getPayloadFromTestBids([{...minimumBidParams, + const payload = getPayloadFromTestBids([{...minimumBidParams, ortb2: { device: { sua: { other: 'value', objectMissing: { @@ -1522,7 +1522,7 @@ describe('kargo adapter tests', function() { ' ', ' ', ].forEach(value => { - let payload = getPayloadFromTestBids([{...minimumBidParams, + const payload = getPayloadFromTestBids([{...minimumBidParams, ortb2: { device: { sua: { platform: value, browsers: [ @@ -1567,7 +1567,7 @@ describe('kargo adapter tests', function() { }); it('does not send 0 for mobile or source', function() { - let payload = getPayloadFromTestBids([{ + const payload = getPayloadFromTestBids([{ ...minimumBidParams, ortb2: { device: { sua: { platform: { @@ -1620,7 +1620,7 @@ describe('kargo adapter tests', function() { describe('page', function() { it('pulls the page ID from localStorage', function() { setLocalStorageValue('pageViewId', 'test-page-id'); - let payload = getPayloadFromTestBids(testBids); + const payload = getPayloadFromTestBids(testBids); expect(payload.page).to.deep.equal({ id: 'test-page-id' }); @@ -1628,7 +1628,7 @@ describe('kargo adapter tests', function() { it('pulls the page timestamp from localStorage', function() { setLocalStorageValue('pageViewTimestamp', '123456789'); - let payload = getPayloadFromTestBids(testBids); + const payload = getPayloadFromTestBids(testBids); expect(payload.page).to.deep.equal({ timestamp: 123456789 }); @@ -1636,7 +1636,7 @@ describe('kargo adapter tests', function() { it('pulls the page ID from localStorage', function() { setLocalStorageValue('pageViewUrl', 'https://test-url.com'); - let payload = getPayloadFromTestBids(testBids); + const payload = getPayloadFromTestBids(testBids); expect(payload.page).to.deep.equal({ url: 'https://test-url.com' }); @@ -1646,7 +1646,7 @@ describe('kargo adapter tests', function() { setLocalStorageValue('pageViewId', 'test-page-id'); setLocalStorageValue('pageViewTimestamp', '123456789'); setLocalStorageValue('pageViewUrl', 'https://test-url.com'); - let payload = getPayloadFromTestBids(testBids); + const payload = getPayloadFromTestBids(testBids); expect(payload.page).to.deep.equal({ id: 'test-page-id', timestamp: 123456789, @@ -1658,7 +1658,7 @@ describe('kargo adapter tests', function() { sandbox.stub(STORAGE, 'getDataFromLocalStorage').throws(); localStorage.removeItem('krg_crb'); document.cookie = 'krg_crb=; expires=Thu, 01 Jan 1970 00:00:00 GMT; path=/'; - let payload = getPayloadFromTestBids(testBids); + const payload = getPayloadFromTestBids(testBids); expect(payload.page).to.be.undefined; }); }); @@ -1776,13 +1776,13 @@ describe('kargo adapter tests', function() { {}, 1234, ].forEach(value => { - let bids = spec.interpretResponse({ body: value }, bidderRequest); + const bids = spec.interpretResponse({ body: value }, bidderRequest); expect(bids, `Value - ${JSON.stringify(value)}`).to.deep.equal([]); }); }); it('returns bid response for various objects', function() { - let bids = spec.interpretResponse(response, bidderRequest); + const bids = spec.interpretResponse(response, bidderRequest); expect(bids).to.have.length(Object.keys(response.body).length); expect(bids[0]).to.deep.equal({ ad: '
', @@ -1885,7 +1885,7 @@ describe('kargo adapter tests', function() { }); it('adds landingPageDomain data', function() { - let response = spec.interpretResponse({ body: { 0: { + const response = spec.interpretResponse({ body: { 0: { metadata: { landingPageDomain: [ 'https://foo.com', @@ -1919,7 +1919,7 @@ describe('kargo adapter tests', function() { } } - let result = spec.interpretResponse(response, bidderRequest); + const result = spec.interpretResponse(response, bidderRequest); // Test properties of bidResponses result.bids.forEach(bid => { @@ -1956,7 +1956,7 @@ describe('kargo adapter tests', function() { const baseUrl = 'https://crb.kargo.com/api/v1/initsyncrnd/random-client-id-string?seed=3205e885-8d37-4139-b47e-f82cff268000&gdpr=0&gdpr_consent=&us_privacy=&gpp=&gpp_sid='; function buildSyncUrls(baseUrl = 'https://crb.kargo.com/api/v1/initsyncrnd/random-client-id-string?seed=3205e885-8d37-4139-b47e-f82cff268000&gdpr=0&gdpr_consent=&us_privacy=&gpp=&gpp_sid=') { - let syncs = []; + const syncs = []; syncs.push({ type: 'iframe', diff --git a/test/spec/modules/kiviadsBidAdapter_spec.js b/test/spec/modules/kiviadsBidAdapter_spec.js index bd59a50e3ae..c0fd8c1aa97 100644 --- a/test/spec/modules/kiviadsBidAdapter_spec.js +++ b/test/spec/modules/kiviadsBidAdapter_spec.js @@ -134,7 +134,7 @@ describe('KiviAdsBidAdapter', function () { }); it('Returns general data valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys('deviceWidth', 'deviceHeight', @@ -214,7 +214,7 @@ describe('KiviAdsBidAdapter', function () { } ]; - let serverRequest = spec.buildRequests(bids, bidderRequest); + const serverRequest = spec.buildRequests(bids, bidderRequest); const { placements } = serverRequest.data; for (let i = 0, len = placements.length; i < len; i++) { @@ -249,7 +249,7 @@ describe('KiviAdsBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { delete bidderRequest.uspConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('object'); expect(data.gdpr).to.have.property('consentString'); @@ -263,7 +263,7 @@ describe('KiviAdsBidAdapter', function () { bidderRequest.uspConsent = '1---'; delete bidderRequest.gdprConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -278,8 +278,8 @@ describe('KiviAdsBidAdapter', function () { applicableSections: [8] }; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -293,8 +293,8 @@ describe('KiviAdsBidAdapter', function () { bidderRequest.ortb2.regs.gpp = 'abc123'; bidderRequest.ortb2.regs.gpp_sid = [8]; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -324,9 +324,9 @@ describe('KiviAdsBidAdapter', function () { } }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(banner.body[0].requestId); @@ -358,10 +358,10 @@ describe('KiviAdsBidAdapter', function () { } }] }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -395,10 +395,10 @@ describe('KiviAdsBidAdapter', function () { } }] }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys('requestId', 'cpm', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'native', 'meta'); expect(dataItem.native).to.have.keys('clickUrl', 'impressionTrackers', 'title', 'image') expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -429,7 +429,7 @@ describe('KiviAdsBidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -445,7 +445,7 @@ describe('KiviAdsBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -462,7 +462,7 @@ describe('KiviAdsBidAdapter', function () { currency: 'USD', }] }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -475,7 +475,7 @@ describe('KiviAdsBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/koblerBidAdapter_spec.js b/test/spec/modules/koblerBidAdapter_spec.js index 94904b3cc4b..17bfe73023b 100644 --- a/test/spec/modules/koblerBidAdapter_spec.js +++ b/test/spec/modules/koblerBidAdapter_spec.js @@ -689,8 +689,8 @@ describe('KoblerAdapter', function () { it('Should trigger pixel with replaced nurl if nurl is not empty', function () { setCurrencyConfig({ adServerCurrency: 'NOK' }); - let validBidRequests = [{ params: {} }]; - let refererInfo = { page: 'page' }; + const validBidRequests = [{ params: {} }]; + const refererInfo = { page: 'page' }; const bidderRequest = { refererInfo }; return addFPDToBidderRequest(bidderRequest).then(res => { JSON.parse(spec.buildRequests(validBidRequests, res).data); diff --git a/test/spec/modules/krushmediaBidAdapter_spec.js b/test/spec/modules/krushmediaBidAdapter_spec.js index f6fe1b5661b..743d0f66a58 100644 --- a/test/spec/modules/krushmediaBidAdapter_spec.js +++ b/test/spec/modules/krushmediaBidAdapter_spec.js @@ -132,7 +132,7 @@ describe('KrushmediabBidAdapter', function () { }); it('Returns general data valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys('deviceWidth', 'deviceHeight', @@ -213,7 +213,7 @@ describe('KrushmediabBidAdapter', function () { } ]; - let serverRequest = spec.buildRequests(bids, bidderRequest); + const serverRequest = spec.buildRequests(bids, bidderRequest); const { placements } = serverRequest.data; for (let i = 0, len = placements.length; i < len; i++) { @@ -249,7 +249,7 @@ describe('KrushmediabBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { delete bidderRequest.uspConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('object'); expect(data.gdpr).to.have.property('consentString'); @@ -263,7 +263,7 @@ describe('KrushmediabBidAdapter', function () { bidderRequest.uspConsent = '1---'; delete bidderRequest.gdprConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -278,8 +278,8 @@ describe('KrushmediabBidAdapter', function () { applicableSections: [8] }; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -293,8 +293,8 @@ describe('KrushmediabBidAdapter', function () { bidderRequest.ortb2.regs.gpp = 'abc123'; bidderRequest.ortb2.regs.gpp_sid = [8]; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -324,9 +324,9 @@ describe('KrushmediabBidAdapter', function () { } }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(banner.body[0].requestId); @@ -358,10 +358,10 @@ describe('KrushmediabBidAdapter', function () { } }] }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -395,10 +395,10 @@ describe('KrushmediabBidAdapter', function () { } }] }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys('requestId', 'cpm', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'native', 'meta'); expect(dataItem.native).to.have.keys('clickUrl', 'impressionTrackers', 'title', 'image') expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -429,7 +429,7 @@ describe('KrushmediabBidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -445,7 +445,7 @@ describe('KrushmediabBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -462,7 +462,7 @@ describe('KrushmediabBidAdapter', function () { currency: 'USD', }] }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -475,7 +475,7 @@ describe('KrushmediabBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/kubientBidAdapter_spec.js b/test/spec/modules/kubientBidAdapter_spec.js index 71136c2c8cd..7ddfd7ef314 100644 --- a/test/spec/modules/kubientBidAdapter_spec.js +++ b/test/spec/modules/kubientBidAdapter_spec.js @@ -10,7 +10,7 @@ function encodeQueryData(data) { } describe('KubientAdapter', function () { - let bidBanner = { + const bidBanner = { bidId: '2dd581a2b6281d', bidder: 'kubient', bidderRequestId: '145e1d6a7837c9', @@ -50,7 +50,7 @@ describe('KubientAdapter', function () { } } }; - let bidVideo = { + const bidVideo = { bidId: '1dd581a2b6281d', bidder: 'kubient', bidderRequestId: '245e1d6a7837c9', @@ -93,9 +93,9 @@ describe('KubientAdapter', function () { } } }; - let consentString = 'BOJ8RZsOJ8RZsABAB8AAAAAZ+A=='; - let uspConsentData = '1YCC'; - let bidderRequest = { + const consentString = 'BOJ8RZsOJ8RZsABAB8AAAAAZ+A=='; + const uspConsentData = '1YCC'; + const bidderRequest = { bidderCode: 'kubient', auctionId: 'fffffff-ffff-ffff-ffff-ffffffffffff', bidderRequestId: 'ffffffffffffff', @@ -118,16 +118,16 @@ describe('KubientAdapter', function () { }); it('Creates Banner 1 ServerRequest object with method, URL and data', function () { config.setConfig({'coppa': false}); - let serverRequests = spec.buildRequests([bidBanner], Object.assign({}, bidderRequest, {bids: [bidBanner]})); + const serverRequests = spec.buildRequests([bidBanner], Object.assign({}, bidderRequest, {bids: [bidBanner]})); expect(serverRequests).to.be.an('array'); for (let i = 0; i < serverRequests.length; i++) { - let serverRequest = serverRequests[i]; + const serverRequest = serverRequests[i]; expect(serverRequest.method).to.be.a('string'); expect(serverRequest.url).to.be.a('string'); expect(serverRequest.data).to.be.a('string'); expect(serverRequest.method).to.equal('POST'); expect(serverRequest.url).to.equal('https://kssp.kbntx.ch/kubprebidjs'); - let data = JSON.parse(serverRequest.data); + const data = JSON.parse(serverRequest.data); expect(data).to.be.an('object'); expect(data).to.have.all.keys('v', 'requestId', 'adSlots', 'gdpr', 'referer', 'tmax', 'consent', 'consentGiven', 'uspConsent'); expect(data.v).to.exist.and.to.be.a('string'); @@ -138,7 +138,7 @@ describe('KubientAdapter', function () { expect(data.consent).to.equal(consentString); expect(data.uspConsent).to.exist.and.to.equal(uspConsentData); for (let j = 0; j < data['adSlots'].length; j++) { - let adSlot = data['adSlots'][i]; + const adSlot = data['adSlots'][i]; expect(adSlot).to.have.all.keys('bidId', 'zoneId', 'banner', 'schain'); expect(adSlot.bidId).to.be.a('string').and.to.equal(bidBanner.bidId); expect(adSlot.zoneId).to.be.a('string').and.to.equal(bidBanner.params.zoneid); @@ -154,16 +154,16 @@ describe('KubientAdapter', function () { }); it('Creates Video 1 ServerRequest object with method, URL and data', function () { config.setConfig({'coppa': false}); - let serverRequests = spec.buildRequests([bidVideo], Object.assign({}, bidderRequest, {bids: [bidVideo]})); + const serverRequests = spec.buildRequests([bidVideo], Object.assign({}, bidderRequest, {bids: [bidVideo]})); expect(serverRequests).to.be.an('array'); for (let i = 0; i < serverRequests.length; i++) { - let serverRequest = serverRequests[i]; + const serverRequest = serverRequests[i]; expect(serverRequest.method).to.be.a('string'); expect(serverRequest.url).to.be.a('string'); expect(serverRequest.data).to.be.a('string'); expect(serverRequest.method).to.equal('POST'); expect(serverRequest.url).to.equal('https://kssp.kbntx.ch/kubprebidjs'); - let data = JSON.parse(serverRequest.data); + const data = JSON.parse(serverRequest.data); expect(data).to.be.an('object'); expect(data).to.have.all.keys('v', 'requestId', 'adSlots', 'gdpr', 'referer', 'tmax', 'consent', 'consentGiven', 'uspConsent'); expect(data.v).to.exist.and.to.be.a('string'); @@ -174,7 +174,7 @@ describe('KubientAdapter', function () { expect(data.consent).to.equal(consentString); expect(data.uspConsent).to.exist.and.to.equal(uspConsentData); for (let j = 0; j < data['adSlots'].length; j++) { - let adSlot = data['adSlots'][i]; + const adSlot = data['adSlots'][i]; expect(adSlot).to.have.all.keys('bidId', 'zoneId', 'floor', 'video', 'schain'); expect(adSlot.bidId).to.be.a('string').and.to.equal(bidVideo.bidId); expect(adSlot.zoneId).to.be.a('string').and.to.equal(bidVideo.params.zoneid); @@ -191,16 +191,16 @@ describe('KubientAdapter', function () { }); it('Creates Banner 2 ServerRequest object with method, URL and data with bidBanner', function () { config.setConfig({'coppa': true}); - let serverRequests = spec.buildRequests([bidBanner], Object.assign({}, bidderRequest, {bids: [bidBanner]})); + const serverRequests = spec.buildRequests([bidBanner], Object.assign({}, bidderRequest, {bids: [bidBanner]})); expect(serverRequests).to.be.an('array'); for (let i = 0; i < serverRequests.length; i++) { - let serverRequest = serverRequests[i]; + const serverRequest = serverRequests[i]; expect(serverRequest.method).to.be.a('string'); expect(serverRequest.url).to.be.a('string'); expect(serverRequest.data).to.be.a('string'); expect(serverRequest.method).to.equal('POST'); expect(serverRequest.url).to.equal('https://kssp.kbntx.ch/kubprebidjs'); - let data = JSON.parse(serverRequest.data); + const data = JSON.parse(serverRequest.data); expect(data).to.be.an('object'); expect(data).to.have.all.keys('v', 'requestId', 'adSlots', 'gdpr', 'coppa', 'referer', 'tmax', 'consent', 'consentGiven', 'uspConsent'); expect(data.v).to.exist.and.to.be.a('string'); @@ -212,7 +212,7 @@ describe('KubientAdapter', function () { expect(data.consent).to.equal(consentString); expect(data.uspConsent).to.exist.and.to.equal(uspConsentData); for (let j = 0; j < data['adSlots'].length; j++) { - let adSlot = data['adSlots'][i]; + const adSlot = data['adSlots'][i]; expect(adSlot).to.have.all.keys('bidId', 'zoneId', 'banner', 'schain'); expect(adSlot.bidId).to.be.a('string').and.to.equal(bidBanner.bidId); expect(adSlot.zoneId).to.be.a('string').and.to.equal(bidBanner.params.zoneid); @@ -228,16 +228,16 @@ describe('KubientAdapter', function () { }); it('Creates Video 2 ServerRequest object with method, URL and data', function () { config.setConfig({'coppa': true}); - let serverRequests = spec.buildRequests([bidVideo], Object.assign({}, bidderRequest, {bids: [bidVideo]})); + const serverRequests = spec.buildRequests([bidVideo], Object.assign({}, bidderRequest, {bids: [bidVideo]})); expect(serverRequests).to.be.an('array'); for (let i = 0; i < serverRequests.length; i++) { - let serverRequest = serverRequests[i]; + const serverRequest = serverRequests[i]; expect(serverRequest.method).to.be.a('string'); expect(serverRequest.url).to.be.a('string'); expect(serverRequest.data).to.be.a('string'); expect(serverRequest.method).to.equal('POST'); expect(serverRequest.url).to.equal('https://kssp.kbntx.ch/kubprebidjs'); - let data = JSON.parse(serverRequest.data); + const data = JSON.parse(serverRequest.data); expect(data).to.be.an('object'); expect(data).to.have.all.keys('v', 'requestId', 'adSlots', 'gdpr', 'coppa', 'referer', 'tmax', 'consent', 'consentGiven', 'uspConsent'); expect(data.v).to.exist.and.to.be.a('string'); @@ -249,7 +249,7 @@ describe('KubientAdapter', function () { expect(data.consent).to.equal(consentString); expect(data.uspConsent).to.exist.and.to.equal(uspConsentData); for (let j = 0; j < data['adSlots'].length; j++) { - let adSlot = data['adSlots'][i]; + const adSlot = data['adSlots'][i]; expect(adSlot).to.have.all.keys('bidId', 'zoneId', 'floor', 'video', 'schain'); expect(adSlot.bidId).to.be.a('string').and.to.equal(bidVideo.bidId); expect(adSlot.zoneId).to.be.a('string').and.to.equal(bidVideo.params.zoneid); @@ -307,9 +307,9 @@ describe('KubientAdapter', function () { ] } }; - let bannerResponses = spec.interpretResponse(serverResponse); + const bannerResponses = spec.interpretResponse(serverResponse); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'ad', 'creativeId', 'width', 'height', 'currency', 'netRevenue', 'ttl', 'meta'); expect(dataItem.requestId).to.exist.and.to.be.a('string').and.to.equal(serverResponse.body.seatbid[0].bid[0].bidId); expect(dataItem.cpm).to.exist.and.to.be.a('number').and.to.equal(serverResponse.body.seatbid[0].bid[0].price); @@ -358,9 +358,9 @@ describe('KubientAdapter', function () { ] } }; - let bannerResponses = spec.interpretResponse(serverResponse); + const bannerResponses = spec.interpretResponse(serverResponse); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'ad', 'creativeId', 'width', 'height', 'currency', 'netRevenue', 'ttl', 'meta', 'mediaType', 'vastXml'); expect(dataItem.requestId).to.exist.and.to.be.a('string').and.to.equal(serverResponse.body.seatbid[0].bid[0].bidId); expect(dataItem.cpm).to.exist.and.to.be.a('number').and.to.equal(serverResponse.body.seatbid[0].bid[0].price); @@ -387,15 +387,15 @@ describe('KubientAdapter', function () { config.resetConfig(); }); it('should register the sync image without gdpr', function () { - let syncOptions = { + const syncOptions = { pixelEnabled: true }; - let values = {}; - let serverResponses = null; - let gdprConsent = { + const values = {}; + const serverResponses = null; + const gdprConsent = { consentString: consentString }; - let uspConsent = null; + const uspConsent = null; config.setConfig({ userSync: { filterSettings: { @@ -406,23 +406,23 @@ describe('KubientAdapter', function () { } } }); - let syncs = spec.getUserSyncs(syncOptions, serverResponses, gdprConsent, uspConsent); + const syncs = spec.getUserSyncs(syncOptions, serverResponses, gdprConsent, uspConsent); values['consent'] = consentString; expect(syncs).to.be.an('array').and.to.have.length(1); expect(syncs[0].type).to.equal('image'); expect(syncs[0].url).to.equal('https://matching.kubient.net/match/sp?' + encodeQueryData(values)); }); it('should register the sync image with gdpr', function () { - let syncOptions = { + const syncOptions = { pixelEnabled: true }; - let values = {}; - let serverResponses = null; - let gdprConsent = { + const values = {}; + const serverResponses = null; + const gdprConsent = { gdprApplies: true, consentString: consentString }; - let uspConsent = null; + const uspConsent = null; config.setConfig({ userSync: { filterSettings: { @@ -433,7 +433,7 @@ describe('KubientAdapter', function () { } } }); - let syncs = spec.getUserSyncs(syncOptions, serverResponses, gdprConsent, uspConsent); + const syncs = spec.getUserSyncs(syncOptions, serverResponses, gdprConsent, uspConsent); values['gdpr'] = 1; values['consent'] = consentString; expect(syncs).to.be.an('array').and.to.have.length(1); @@ -441,12 +441,12 @@ describe('KubientAdapter', function () { expect(syncs[0].url).to.equal('https://matching.kubient.net/match/sp?' + encodeQueryData(values)); }); it('should register the sync image with gdpr vendor', function () { - let syncOptions = { + const syncOptions = { pixelEnabled: true }; - let values = {}; - let serverResponses = null; - let gdprConsent = { + const values = {}; + const serverResponses = null; + const gdprConsent = { gdprApplies: true, consentString: consentString, apiVersion: 2, @@ -458,7 +458,7 @@ describe('KubientAdapter', function () { } } }; - let uspConsent = null; + const uspConsent = null; config.setConfig({ userSync: { filterSettings: { @@ -469,7 +469,7 @@ describe('KubientAdapter', function () { } } }); - let syncs = spec.getUserSyncs(syncOptions, serverResponses, gdprConsent, uspConsent); + const syncs = spec.getUserSyncs(syncOptions, serverResponses, gdprConsent, uspConsent); values['gdpr'] = 1; values['consent'] = consentString; expect(syncs).to.be.an('array').and.to.have.length(1); @@ -477,15 +477,15 @@ describe('KubientAdapter', function () { expect(syncs[0].url).to.equal('https://matching.kubient.net/match/sp?' + encodeQueryData(values)); }); it('should register the sync image without gdpr and with uspConsent', function () { - let syncOptions = { + const syncOptions = { pixelEnabled: true }; - let values = {}; - let serverResponses = null; - let gdprConsent = { + const values = {}; + const serverResponses = null; + const gdprConsent = { consentString: consentString }; - let uspConsent = '1YNN'; + const uspConsent = '1YNN'; config.setConfig({ userSync: { filterSettings: { @@ -496,7 +496,7 @@ describe('KubientAdapter', function () { } } }); - let syncs = spec.getUserSyncs(syncOptions, serverResponses, gdprConsent, uspConsent); + const syncs = spec.getUserSyncs(syncOptions, serverResponses, gdprConsent, uspConsent); values['consent'] = consentString; values['usp'] = uspConsent; expect(syncs).to.be.an('array').and.to.have.length(1); diff --git a/test/spec/modules/lane4BidAdapter_spec.js b/test/spec/modules/lane4BidAdapter_spec.js index 49dc3aad6a4..5fec38145b8 100644 --- a/test/spec/modules/lane4BidAdapter_spec.js +++ b/test/spec/modules/lane4BidAdapter_spec.js @@ -141,7 +141,7 @@ describe('lane4 adapter', function () { describe('validations', function () { it('isBidValid : placement_id is passed', function () { - let bid = { + const bid = { bidder: 'lane4', params: { placement_id: 110044 @@ -151,7 +151,7 @@ describe('lane4 adapter', function () { expect(isValid).to.equals(true); }); it('isBidValid : placement_id is not passed', function () { - let bid = { + const bid = { bidder: 'lane4', params: { width: 300, @@ -166,42 +166,42 @@ describe('lane4 adapter', function () { }); describe('Validate Banner Request', function () { it('Immutable bid request validate', function () { - let _Request = utils.deepClone(bannerRequest), + const _Request = utils.deepClone(bannerRequest), bidRequest = spec.buildRequests(bannerRequest); expect(bannerRequest).to.deep.equal(_Request); }); it('Validate bidder connection', function () { - let _Request = spec.buildRequests(bannerRequest); + const _Request = spec.buildRequests(bannerRequest); expect(_Request.url).to.equal('https://rtb.lane4.io/hb'); expect(_Request.method).to.equal('POST'); expect(_Request.options.contentType).to.equal('application/json'); }); it('Validate bid request : Impression', function () { - let _Request = spec.buildRequests(bannerRequest); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(bannerRequest); + const data = JSON.parse(_Request.data); // expect(data.at).to.equal(1); // auction type expect(data[0].imp[0].id).to.equal(bannerRequest[0].bidId); expect(data[0].placementId).to.equal(110044); }); it('Validate bid request : ad size', function () { - let _Request = spec.buildRequests(bannerRequest); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(bannerRequest); + const data = JSON.parse(_Request.data); expect(data[0].imp[0].banner).to.be.a('object'); expect(data[0].imp[0].banner.w).to.equal(300); expect(data[0].imp[0].banner.h).to.equal(250); }); it('Validate bid request : user object', function () { - let _Request = spec.buildRequests(bannerRequest); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(bannerRequest); + const data = JSON.parse(_Request.data); expect(data[0].user).to.be.a('object'); expect(data[0].user.id).to.be.a('string'); }); it('Validate bid request : CCPA Check', function () { - let bidRequest = { + const bidRequest = { uspConsent: '1NYN' }; - let _Request = spec.buildRequests(bannerRequest, bidRequest); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(bannerRequest, bidRequest); + const data = JSON.parse(_Request.data); expect(data[0].regs.ext.us_privacy).to.equal('1NYN'); // let _bidRequest = {}; // let _Request1 = spec.buildRequests(request, _bidRequest); @@ -211,8 +211,8 @@ describe('lane4 adapter', function () { }); describe('Validate banner response ', function () { it('Validate bid response : valid bid response', function () { - let _Request = spec.buildRequests(bannerRequest); - let bResponse = spec.interpretResponse(bannerResponse, _Request); + const _Request = spec.buildRequests(bannerRequest); + const bResponse = spec.interpretResponse(bannerResponse, _Request); expect(bResponse).to.be.an('array').with.length.above(0); expect(bResponse[0].requestId).to.equal(bannerResponse.body.seatbid[0].bid[0].impid); expect(bResponse[0].width).to.equal(bannerResponse.body.seatbid[0].bid[0].w); @@ -226,42 +226,42 @@ describe('lane4 adapter', function () { expect(bResponse[0].dealId).to.equal(bannerResponse.body.seatbid[0].bid[0].dealId); }); it('Invalid bid response check ', function () { - let bRequest = spec.buildRequests(bannerRequest); - let response = spec.interpretResponse(invalidBannerResponse, bRequest); + const bRequest = spec.buildRequests(bannerRequest); + const response = spec.interpretResponse(invalidBannerResponse, bRequest); expect(response[0].ad).to.equal('invalid response'); }); }); describe('Validate Native Request', function () { it('Immutable bid request validate', function () { - let _Request = utils.deepClone(nativeRequest), + const _Request = utils.deepClone(nativeRequest), bidRequest = spec.buildRequests(nativeRequest); expect(nativeRequest).to.deep.equal(_Request); }); it('Validate bidder connection', function () { - let _Request = spec.buildRequests(nativeRequest); + const _Request = spec.buildRequests(nativeRequest); expect(_Request.url).to.equal('https://rtb.lane4.io/hb'); expect(_Request.method).to.equal('POST'); expect(_Request.options.contentType).to.equal('application/json'); }); it('Validate bid request : Impression', function () { - let _Request = spec.buildRequests(nativeRequest); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(nativeRequest); + const data = JSON.parse(_Request.data); // expect(data.at).to.equal(1); // auction type expect(data[0].imp[0].id).to.equal(nativeRequest[0].bidId); expect(data[0].placementId).to.equal(5551); }); it('Validate bid request : user object', function () { - let _Request = spec.buildRequests(nativeRequest); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(nativeRequest); + const data = JSON.parse(_Request.data); expect(data[0].user).to.be.a('object'); expect(data[0].user.id).to.be.a('string'); }); it('Validate bid request : CCPA Check', function () { - let bidRequest = { + const bidRequest = { uspConsent: '1NYN' }; - let _Request = spec.buildRequests(nativeRequest, bidRequest); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(nativeRequest, bidRequest); + const data = JSON.parse(_Request.data); expect(data[0].regs.ext.us_privacy).to.equal('1NYN'); // let _bidRequest = {}; // let _Request1 = spec.buildRequests(request, _bidRequest); @@ -271,8 +271,8 @@ describe('lane4 adapter', function () { }); describe('Validate native response ', function () { it('Validate bid response : valid bid response', function () { - let _Request = spec.buildRequests(nativeRequest); - let bResponse = spec.interpretResponse(nativeResponse, _Request); + const _Request = spec.buildRequests(nativeRequest); + const bResponse = spec.interpretResponse(nativeResponse, _Request); expect(bResponse).to.be.an('array').with.length.above(0); expect(bResponse[0].requestId).to.equal(nativeResponse.body.seatbid[0].bid[0].impid); // expect(bResponse[0].width).to.equal(bannerResponse.body.seatbid[0].bid[0].w); @@ -292,14 +292,14 @@ describe('lane4 adapter', function () { }); describe('GPP and coppa', function () { it('Request params check with GPP Consent', function () { - let bidderReq = { gppConsent: { gppString: 'gpp-string-test', applicableSections: [5] } }; - let _Request = spec.buildRequests(bannerRequest, bidderReq); - let data = JSON.parse(_Request.data); + const bidderReq = { gppConsent: { gppString: 'gpp-string-test', applicableSections: [5] } }; + const _Request = spec.buildRequests(bannerRequest, bidderReq); + const data = JSON.parse(_Request.data); expect(data[0].regs.gpp).to.equal('gpp-string-test'); expect(data[0].regs.gpp_sid[0]).to.equal(5); }); it('Request params check with GPP Consent read from ortb2', function () { - let bidderReq = { + const bidderReq = { ortb2: { regs: { gpp: 'gpp-test-string', @@ -307,15 +307,15 @@ describe('lane4 adapter', function () { } } }; - let _Request = spec.buildRequests(bannerRequest, bidderReq); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(bannerRequest, bidderReq); + const data = JSON.parse(_Request.data); expect(data[0].regs.gpp).to.equal('gpp-test-string'); expect(data[0].regs.gpp_sid[0]).to.equal(5); }); it(' Bid request should have coppa flag if its true', () => { - let bidderReq = { ortb2: { regs: { coppa: 1 } } }; - let _Request = spec.buildRequests(bannerRequest, bidderReq); - let data = JSON.parse(_Request.data); + const bidderReq = { ortb2: { regs: { coppa: 1 } } }; + const _Request = spec.buildRequests(bannerRequest, bidderReq); + const data = JSON.parse(_Request.data); expect(data[0].regs.coppa).to.equal(1); }); }); diff --git a/test/spec/modules/lassoBidAdapter_spec.js b/test/spec/modules/lassoBidAdapter_spec.js index 94ec86aba69..cc229029d46 100644 --- a/test/spec/modules/lassoBidAdapter_spec.js +++ b/test/spec/modules/lassoBidAdapter_spec.js @@ -272,7 +272,7 @@ describe('lassoBidAdapter', function () { }); describe('interpretResponse', function () { - let serverResponse = { + const serverResponse = { body: { bidid: '123456789', id: '33302780340222111', @@ -296,7 +296,7 @@ describe('lassoBidAdapter', function () { }; it('should get the correct bid response', function () { - let expectedResponse = { + const expectedResponse = { requestId: '123456789', bidId: '123456789', cpm: 1, @@ -315,7 +315,7 @@ describe('lassoBidAdapter', function () { mediaType: 'banner' } }; - let result = spec.interpretResponse(serverResponse); + const result = spec.interpretResponse(serverResponse); expect(Object.keys(result[0])).to.deep.equal(Object.keys(expectedResponse)); }); }); diff --git a/test/spec/modules/lemmaDigitalBidAdapter_spec.js b/test/spec/modules/lemmaDigitalBidAdapter_spec.js index 91cf0a17482..99dd243eef8 100644 --- a/test/spec/modules/lemmaDigitalBidAdapter_spec.js +++ b/test/spec/modules/lemmaDigitalBidAdapter_spec.js @@ -132,7 +132,7 @@ describe('lemmaDigitalBidAdapter', function () { describe('implementation', function () { describe('Bid validations', function () { it('valid bid case', function () { - let validBid = { + const validBid = { bidder: 'lemmadigital', params: { pubId: 1001, @@ -143,11 +143,11 @@ describe('lemmaDigitalBidAdapter', function () { expect(isValid).to.equal(true); }); it('invalid bid case', function () { - let isValid = spec.isBidRequestValid(); + const isValid = spec.isBidRequestValid(); expect(isValid).to.equal(false); }); it('invalid bid case: pubId not passed', function () { - let validBid = { + const validBid = { bidder: 'lemmadigital', params: { adunitId: 1 @@ -157,7 +157,7 @@ describe('lemmaDigitalBidAdapter', function () { expect(isValid).to.equal(false); }); it('invalid bid case: pubId is not number', function () { - let validBid = { + const validBid = { bidder: 'lemmadigital', params: { pubId: '301', @@ -168,7 +168,7 @@ describe('lemmaDigitalBidAdapter', function () { expect(isValid).to.equal(false); }); it('invalid bid case: adunitId is not passed', function () { - let validBid = { + const validBid = { bidder: 'lemmadigital', params: { pubId: 1001 @@ -199,29 +199,29 @@ describe('lemmaDigitalBidAdapter', function () { }); describe('Request formation', function () { it('bidRequest check empty', function () { - let bidRequests = []; - let request = spec.buildRequests(bidRequests); + const bidRequests = []; + const request = spec.buildRequests(bidRequests); expect(request).to.equal(undefined); }); it('buildRequests function should not modify original bidRequests object', function () { - let originalBidRequests = utils.deepClone(bidRequests); - let request = spec.buildRequests(bidRequests); + const originalBidRequests = utils.deepClone(bidRequests); + const request = spec.buildRequests(bidRequests); expect(bidRequests).to.deep.equal(originalBidRequests); }); it('bidRequest imp array check empty', function () { - let request = spec.buildRequests(bidRequests); - let data = JSON.parse(request.data); + const request = spec.buildRequests(bidRequests); + const data = JSON.parse(request.data); data.imp = []; expect(data.imp.length).to.equal(0); }); it('Endpoint checking', function () { - let request = spec.buildRequests(bidRequests); + const request = spec.buildRequests(bidRequests); expect(request.url).to.equal('https://pbidj.lemmamedia.com/lemma/servad?pid=1001&aid=1'); expect(request.method).to.equal('POST'); }); it('Request params check', function () { - let request = spec.buildRequests(bidRequests); - let data = JSON.parse(request.data); + const request = spec.buildRequests(bidRequests); + const data = JSON.parse(request.data); expect(data.site.domain).to.be.a('string'); // domain should be set expect(data.site.publisher.id).to.equal(bidRequests[0].params.pubId.toString()); // publisher Id expect(data.imp[0].tagid).to.equal('1'); // tagid @@ -231,30 +231,30 @@ describe('lemmaDigitalBidAdapter', function () { }); it('Set sizes from mediaTypes object', function () { - let newBannerRequest = utils.deepClone(bidRequests); + const newBannerRequest = utils.deepClone(bidRequests); delete newBannerRequest[0].sizes; - let request = spec.buildRequests(newBannerRequest); - let data = JSON.parse(request.data); + const request = spec.buildRequests(newBannerRequest); + const data = JSON.parse(request.data); expect(data.sizes).to.equal(undefined); }); it('Check request banner object present', function () { - let newBannerRequest = utils.deepClone(bidRequests); - let request = spec.buildRequests(newBannerRequest); - let data = JSON.parse(request.data); + const newBannerRequest = utils.deepClone(bidRequests); + const request = spec.buildRequests(newBannerRequest); + const data = JSON.parse(request.data); expect(data.banner).to.deep.equal(undefined); }); it('Check device, source object not present', function () { - let newBannerRequest = utils.deepClone(bidRequests); + const newBannerRequest = utils.deepClone(bidRequests); delete newBannerRequest[0].ortb2; - let request = spec.buildRequests(newBannerRequest); - let data = JSON.parse(request.data); + const request = spec.buildRequests(newBannerRequest); + const data = JSON.parse(request.data); delete data.device; delete data.source; expect(data.source).to.equal(undefined); expect(data.device).to.equal(undefined); }); it('Set content from config, set site.content', function () { - let sandbox = sinon.createSandbox(); + const sandbox = sinon.createSandbox(); const content = { 'id': 'alpha-numeric-id' }; @@ -264,13 +264,13 @@ describe('lemmaDigitalBidAdapter', function () { }; return config[key]; }); - let request = spec.buildRequests(bidRequests); - let data = JSON.parse(request.data); + const request = spec.buildRequests(bidRequests); + const data = JSON.parse(request.data); expect(data.site.content).to.deep.equal(content); sandbox.restore(); }); it('Set content from config, set app.content', function () { - let bidRequest = [{ + const bidRequest = [{ bidder: 'lemmadigital', params: { pubId: 1001, @@ -294,7 +294,7 @@ describe('lemmaDigitalBidAdapter', function () { }, } }]; - let sandbox = sinon.createSandbox(); + const sandbox = sinon.createSandbox(); const content = { 'id': 'alpha-numeric-id' }; @@ -304,18 +304,18 @@ describe('lemmaDigitalBidAdapter', function () { }; return config[key]; }); - let request = spec.buildRequests(bidRequest); - let data = JSON.parse(request.data); + const request = spec.buildRequests(bidRequest); + const data = JSON.parse(request.data); expect(data.app.content).to.deep.equal(content); sandbox.restore(); }); it('Set tmax from requestBids method', function () { - let request = spec.buildRequests(bidRequests); - let data = JSON.parse(request.data); + const request = spec.buildRequests(bidRequests); + const data = JSON.parse(request.data); expect(data.tmax).to.deep.equal(300); }); it('Request params check without mediaTypes object', function () { - let bidRequests = [{ + const bidRequests = [{ bidder: 'lemmadigital', params: { pubId: 1001, @@ -327,8 +327,8 @@ describe('lemmaDigitalBidAdapter', function () { [300, 600] ] }]; - let request = spec.buildRequests(bidRequests); - let data = JSON.parse(request.data); + const request = spec.buildRequests(bidRequests); + const data = JSON.parse(request.data); expect(data.imp[0].banner.w).to.equal(300); // width expect(data.imp[0].banner.h).to.equal(250); // height expect(data.imp[0].banner.format).exist.and.to.be.an('array'); @@ -338,8 +338,8 @@ describe('lemmaDigitalBidAdapter', function () { }); it('Request params check: without tagId', function () { delete bidRequests[0].params.adunitId; - let request = spec.buildRequests(bidRequests); - let data = JSON.parse(request.data); + const request = spec.buildRequests(bidRequests); + const data = JSON.parse(request.data); expect(data.site.domain).to.be.a('string'); // domain should be set expect(data.site.publisher.id).to.equal(bidRequests[0].params.pubId.toString()); // publisher Id expect(data.imp[0].tagid).to.equal(undefined); // tagid @@ -347,7 +347,7 @@ describe('lemmaDigitalBidAdapter', function () { expect(data.imp[0].bidfloor).to.equal(bidRequests[0].params.bidFloor); }); it('Request params multi size format object check', function () { - let bidRequests = [{ + const bidRequests = [{ bidder: 'lemmadigital', mediaTypes: { banner: { @@ -413,7 +413,7 @@ describe('lemmaDigitalBidAdapter', function () { expect(data.imp[0].banner.format[0].h).to.equal(250); // height }); it('Request params currency check', function () { - let bidRequest = [{ + const bidRequest = [{ bidder: 'lemmadigital', mediaTypes: { banner: { @@ -450,8 +450,8 @@ describe('lemmaDigitalBidAdapter', function () { expect(data.imp[0].bidfloorcur).to.equal('USD'); }); it('Request params check for video ad', function () { - let request = spec.buildRequests(videoBidRequests); - let data = JSON.parse(request.data); + const request = spec.buildRequests(videoBidRequests); + const data = JSON.parse(request.data); expect(data.imp[0].video).to.exist; expect(data.imp[0].tagid).to.equal('1'); expect(data.imp[0]['video']['mimes']).to.exist.and.to.be.an('array'); @@ -472,7 +472,7 @@ describe('lemmaDigitalBidAdapter', function () { let newRequest; let floorModuleTestData; - let getFloor = function (req) { + const getFloor = function (req) { return floorModuleTestData[req.mediaType]; }; @@ -494,7 +494,7 @@ describe('lemmaDigitalBidAdapter', function () { it('bidfloor should be undefined if calculation is <= 0', function () { floorModuleTestData.banner.floor = 0; // lowest of them all newRequest[0].params.bidFloor = undefined; - let request = spec.buildRequests(newRequest); + const request = spec.buildRequests(newRequest); let data = JSON.parse(request.data); data = data.imp[0]; expect(data.bidfloor).to.equal(undefined); @@ -503,7 +503,7 @@ describe('lemmaDigitalBidAdapter', function () { it('ignore floormodule o/p if floor is not number', function () { floorModuleTestData.banner.floor = 'INR'; newRequest[0].params.bidFloor = undefined; - let request = spec.buildRequests(newRequest); + const request = spec.buildRequests(newRequest); let data = JSON.parse(request.data); data = data.imp[0]; expect(data.bidfloor).to.equal(undefined); // video will be lowest now @@ -512,7 +512,7 @@ describe('lemmaDigitalBidAdapter', function () { it('ignore floormodule o/p if currency is not matched', function () { floorModuleTestData.banner.currency = 'INR'; newRequest[0].params.bidFloor = undefined; - let request = spec.buildRequests(newRequest); + const request = spec.buildRequests(newRequest); let data = JSON.parse(request.data); data = data.imp[0]; expect(data.bidfloor).to.equal(undefined); // video will be lowest now @@ -520,7 +520,7 @@ describe('lemmaDigitalBidAdapter', function () { it('bidFloor is not passed, use minimum from floorModule', function () { newRequest[0].params.bidFloor = undefined; - let request = spec.buildRequests(newRequest); + const request = spec.buildRequests(newRequest); let data = JSON.parse(request.data); data = data.imp[0]; expect(data.bidfloor).to.equal(1.5); @@ -528,7 +528,7 @@ describe('lemmaDigitalBidAdapter', function () { it('bidFloor is passed as 1, use min of floorModule as it is highest', function () { newRequest[0].params.bidFloor = '1.0';// yes, we want it as a string - let request = spec.buildRequests(newRequest); + const request = spec.buildRequests(newRequest); let data = JSON.parse(request.data); data = data.imp[0]; expect(data.bidfloor).to.equal(1.5); @@ -536,8 +536,8 @@ describe('lemmaDigitalBidAdapter', function () { }); describe('Response checking', function () { it('should check for valid response values', function () { - let request = spec.buildRequests(bidRequests); - let response = spec.interpretResponse(bidResponses, request); + const request = spec.buildRequests(bidRequests); + const response = spec.interpretResponse(bidResponses, request); expect(response).to.be.an('array').with.length.above(0); expect(response[0].requestId).to.equal(bidResponses.body.seatbid[0].bid[0].impid); expect(response[0].cpm).to.equal((bidResponses.body.seatbid[0].bid[0].price).toFixed(2)); @@ -554,14 +554,14 @@ describe('lemmaDigitalBidAdapter', function () { expect(response[0].ttl).to.equal(300); }); it('should check for valid banner mediaType in request', function () { - let request = spec.buildRequests(bidRequests); - let response = spec.interpretResponse(bidResponses, request); + const request = spec.buildRequests(bidRequests); + const response = spec.interpretResponse(bidResponses, request); expect(response[0].mediaType).to.equal('banner'); }); it('should check for valid video mediaType in request', function () { - let request = spec.buildRequests(videoBidRequests); - let response = spec.interpretResponse(videoBidResponse, request); + const request = spec.buildRequests(videoBidRequests); + const response = spec.interpretResponse(videoBidResponse, request); expect(response[0].mediaType).to.equal('video'); }); @@ -584,15 +584,15 @@ describe('lemmaDigitalBidAdapter', function () { it('Video params from mediaTypes and params obj of bid are not present', function () { delete newVideoRequest[0].mediaTypes.video; delete newVideoRequest[0].params.video; - let request = spec.buildRequests(newVideoRequest); + const request = spec.buildRequests(newVideoRequest); expect(request).to.equal(undefined); }); it('Should consider video params from mediaType object of bid', function () { delete newVideoRequest[0].params.video; - let request = spec.buildRequests(newVideoRequest); - let data = JSON.parse(request.data); + const request = spec.buildRequests(newVideoRequest); + const data = JSON.parse(request.data); expect(data.imp[0].video).to.exist; expect(data.imp[0]['video']['w']).to.equal(videoBidRequests[0].mediaTypes.video.playerSize[0][0]); expect(data.imp[0]['video']['h']).to.equal(videoBidRequests[0].mediaTypes.video.playerSize[0][1]); diff --git a/test/spec/modules/lifestreetBidAdapter_spec.js b/test/spec/modules/lifestreetBidAdapter_spec.js index d66727da644..2c121b30474 100644 --- a/test/spec/modules/lifestreetBidAdapter_spec.js +++ b/test/spec/modules/lifestreetBidAdapter_spec.js @@ -154,8 +154,8 @@ describe('lifestreetBidAdapter', function() { }); it('should add GDPR consent information to the request', function () { - let consentString = 'BOJ8RZsOJ8RZsABAB8AAAAAZ+A=='; - let bidderRequest = { + const consentString = 'BOJ8RZsOJ8RZsABAB8AAAAAZ+A=='; + const bidderRequest = { bidderCode: 'lifestreet', auctionId: '1d1a030790a875', bidderRequestId: '22edbae2744bf6', @@ -173,8 +173,8 @@ describe('lifestreetBidAdapter', function() { }); it('should add US privacy string to request', function() { - let consentString = '1YA-'; - let bidderRequest = { + const consentString = '1YA-'; + const bidderRequest = { bidderCode: 'lifestreet', auctionId: '1d1a030790a875', bidderRequestId: '22edbae2744bf6', diff --git a/test/spec/modules/limelightDigitalBidAdapter_spec.js b/test/spec/modules/limelightDigitalBidAdapter_spec.js index ef94070bb9b..a4b161b7026 100644 --- a/test/spec/modules/limelightDigitalBidAdapter_spec.js +++ b/test/spec/modules/limelightDigitalBidAdapter_spec.js @@ -267,7 +267,7 @@ describe('limelightDigitalAdapter', function () { expect(serverRequest.method).to.equal('POST') }) it('Returns valid data if array of bids is valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys( 'deviceWidth', @@ -348,7 +348,7 @@ describe('limelightDigitalAdapter', function () { }) }) describe('interpretBannerResponse', function () { - let resObject = { + const resObject = { body: [ { requestId: '123', cpm: 0.3, @@ -369,7 +369,7 @@ describe('limelightDigitalAdapter', function () { it('Returns an array of valid server responses if response object is valid', function () { expect(serverResponses).to.be.an('array').that.is.not.empty; for (let i = 0; i < serverResponses.length; i++) { - let dataItem = serverResponses[i]; + const dataItem = serverResponses[i]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'meta'); expect(dataItem.requestId).to.be.a('string'); @@ -391,7 +391,7 @@ describe('limelightDigitalAdapter', function () { }); }); describe('interpretVideoResponse', function () { - let resObject = { + const resObject = { body: [ { requestId: '123', cpm: 0.3, @@ -412,7 +412,7 @@ describe('limelightDigitalAdapter', function () { it('Returns an array of valid server responses if response object is valid', function () { expect(serverResponses).to.be.an('array').that.is.not.empty; for (let i = 0; i < serverResponses.length; i++) { - let dataItem = serverResponses[i]; + const dataItem = serverResponses[i]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'vastXml', 'ttl', 'creativeId', 'netRevenue', 'currency', 'meta'); expect(dataItem.requestId).to.be.a('string'); @@ -434,7 +434,7 @@ describe('limelightDigitalAdapter', function () { }); }); describe('isBidRequestValid', function() { - let bid = { + const bid = { bidId: '2dd581a2b6281d', bidder: 'limelightDigital', bidderRequestId: '145e1d6a7837c9', @@ -461,7 +461,7 @@ describe('limelightDigitalAdapter', function () { }); it('should return false when required params are not passed', function() { - let bidFailed = { + const bidFailed = { bidder: 'limelightDigital', bidderRequestId: '145e1d6a7837c9', params: { @@ -477,7 +477,7 @@ describe('limelightDigitalAdapter', function () { }); }); describe('interpretResponse', function() { - let resObject = { + const resObject = { requestId: '123', cpm: 0.3, width: 320, @@ -493,7 +493,7 @@ describe('limelightDigitalAdapter', function () { } }; it('should skip responses which do not contain required params', function() { - let bidResponses = { + const bidResponses = { body: [ { cpm: 0.3, ttl: 1000, @@ -507,28 +507,28 @@ describe('limelightDigitalAdapter', function () { expect(spec.interpretResponse(bidResponses)).to.deep.equal([ resObject ]); }); it('should skip responses which do not contain advertiser domains', function() { - let resObjectWithoutAdvertiserDomains = Object.assign({}, resObject); + const resObjectWithoutAdvertiserDomains = Object.assign({}, resObject); resObjectWithoutAdvertiserDomains.meta = Object.assign({}, resObject.meta); delete resObjectWithoutAdvertiserDomains.meta.advertiserDomains; - let bidResponses = { + const bidResponses = { body: [ resObjectWithoutAdvertiserDomains, resObject ] } expect(spec.interpretResponse(bidResponses)).to.deep.equal([ resObject ]); }); it('should return responses which contain empty advertiser domains', function() { - let resObjectWithEmptyAdvertiserDomains = Object.assign({}, resObject); + const resObjectWithEmptyAdvertiserDomains = Object.assign({}, resObject); resObjectWithEmptyAdvertiserDomains.meta = Object.assign({}, resObject.meta); resObjectWithEmptyAdvertiserDomains.meta.advertiserDomains = []; - let bidResponses = { + const bidResponses = { body: [ resObjectWithEmptyAdvertiserDomains, resObject ] } expect(spec.interpretResponse(bidResponses)).to.deep.equal([resObjectWithEmptyAdvertiserDomains, resObject]); }); it('should skip responses which do not contain meta media type', function() { - let resObjectWithoutMetaMediaType = Object.assign({}, resObject); + const resObjectWithoutMetaMediaType = Object.assign({}, resObject); resObjectWithoutMetaMediaType.meta = Object.assign({}, resObject.meta); delete resObjectWithoutMetaMediaType.meta.mediaType; - let bidResponses = { + const bidResponses = { body: [ resObjectWithoutMetaMediaType, resObject ] } expect(spec.interpretResponse(bidResponses)).to.deep.equal([ resObject ]); diff --git a/test/spec/modules/liveIntentAnalyticsAdapter_spec.js b/test/spec/modules/liveIntentAnalyticsAdapter_spec.js index c30ff582a9e..bfd71c5d1e0 100644 --- a/test/spec/modules/liveIntentAnalyticsAdapter_spec.js +++ b/test/spec/modules/liveIntentAnalyticsAdapter_spec.js @@ -6,15 +6,15 @@ import { EVENTS } from 'src/constants.js'; import { config } from 'src/config.js'; import { BID_WON_EVENT, AUCTION_INIT_EVENT, BID_WON_EVENT_UNDEFINED, AUCTION_INIT_EVENT_NOT_LI } from '../../fixtures/liveIntentAuctionEvents'; -let utils = require('src/utils'); -let refererDetection = require('src/refererDetection'); -let instanceId = '77abbc81-c1f1-41cd-8f25-f7149244c800'; -let url = 'https://www.test.com' +const utils = require('src/utils'); +const refererDetection = require('src/refererDetection'); +const instanceId = '77abbc81-c1f1-41cd-8f25-f7149244c800'; +const url = 'https://www.test.com' let sandbox; let clock; -let now = new Date(); +const now = new Date(); -let events = require('src/events'); +const events = require('src/events'); const USERID_CONFIG = [ { diff --git a/test/spec/modules/liveIntentIdMinimalSystem_spec.js b/test/spec/modules/liveIntentIdMinimalSystem_spec.js index 2167953f591..e0e81bdf62e 100644 --- a/test/spec/modules/liveIntentIdMinimalSystem_spec.js +++ b/test/spec/modules/liveIntentIdMinimalSystem_spec.js @@ -59,10 +59,10 @@ describe('LiveIntentMinimalId', function() { it('should call the Custom URL of the LiveIntent Identity Exchange endpoint', function() { getCookieStub.returns(null); - let callBackSpy = sinon.spy(); - let submoduleCallback = liveIntentIdSubmodule.getId({ params: {...defaultConfigParams.params, ...{'url': 'https://dummy.liveintent.com/idex'}} }).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = liveIntentIdSubmodule.getId({ params: {...defaultConfigParams.params, ...{'url': 'https://dummy.liveintent.com/idex'}} }).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.be.eq('https://dummy.liveintent.com/idex/prebid/89899?resolve=nonId'); request.respond( 200, @@ -74,10 +74,10 @@ describe('LiveIntentMinimalId', function() { it('should call the Identity Exchange endpoint with the provided distributorId', function() { getCookieStub.returns(null); - let callBackSpy = sinon.spy(); - let submoduleCallback = liveIntentIdSubmodule.getId({ params: { fireEventDelay: 1, distributorId: 'did-1111' } }).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = liveIntentIdSubmodule.getId({ params: { fireEventDelay: 1, distributorId: 'did-1111' } }).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.be.eq('https://idx.liadm.com/idex/did-1111/any?did=did-1111&resolve=nonId'); request.respond( 204, @@ -88,10 +88,10 @@ describe('LiveIntentMinimalId', function() { it('should call the Identity Exchange endpoint without the provided distributorId when appId is provided', function() { getCookieStub.returns(null); - let callBackSpy = sinon.spy(); - let submoduleCallback = liveIntentIdSubmodule.getId({ params: { fireEventDelay: 1, distributorId: 'did-1111', liCollectConfig: { appId: 'a-0001' } } }).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = liveIntentIdSubmodule.getId({ params: { fireEventDelay: 1, distributorId: 'did-1111', liCollectConfig: { appId: 'a-0001' } } }).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.be.eq('https://idx.liadm.com/idex/prebid/any?resolve=nonId'); request.respond( 204, @@ -102,8 +102,8 @@ describe('LiveIntentMinimalId', function() { it('should call the default url of the LiveIntent Identity Exchange endpoint, with a partner', function() { getCookieStub.returns(null); - let callBackSpy = sinon.spy(); - let submoduleCallback = liveIntentIdSubmodule.getId({ params: { + const callBackSpy = sinon.spy(); + const submoduleCallback = liveIntentIdSubmodule.getId({ params: { ...defaultConfigParams.params, ...{ 'url': 'https://dummy.liveintent.com/idex', @@ -111,7 +111,7 @@ describe('LiveIntentMinimalId', function() { } } }).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.be.eq('https://dummy.liveintent.com/idex/rubicon/89899?resolve=nonId'); request.respond( 200, @@ -123,10 +123,10 @@ describe('LiveIntentMinimalId', function() { it('should call the LiveIntent Identity Exchange endpoint, with no additional query params', function() { getCookieStub.returns(null); - let callBackSpy = sinon.spy(); - let submoduleCallback = liveIntentIdSubmodule.getId(defaultConfigParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = liveIntentIdSubmodule.getId(defaultConfigParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.be.eq('https://idx.liadm.com/idex/prebid/89899?resolve=nonId'); request.respond( 200, @@ -138,10 +138,10 @@ describe('LiveIntentMinimalId', function() { it('should log an error and continue to callback if ajax request errors', function() { getCookieStub.returns(null); - let callBackSpy = sinon.spy(); - let submoduleCallback = liveIntentIdSubmodule.getId(defaultConfigParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = liveIntentIdSubmodule.getId(defaultConfigParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.be.eq('https://idx.liadm.com/idex/prebid/89899?resolve=nonId'); request.respond( 503, @@ -155,10 +155,10 @@ describe('LiveIntentMinimalId', function() { it('should include the LiveConnect identifier when calling the LiveIntent Identity Exchange endpoint', function() { const oldCookie = 'a-xxxx--123e4567-e89b-12d3-a456-426655440000' getDataFromLocalStorageStub.withArgs('_li_duid').returns(oldCookie); - let callBackSpy = sinon.spy(); - let submoduleCallback = liveIntentIdSubmodule.getId(defaultConfigParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = liveIntentIdSubmodule.getId(defaultConfigParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.be.eq(`https://idx.liadm.com/idex/prebid/89899?duid=${oldCookie}&resolve=nonId`); request.respond( 200, @@ -178,10 +178,10 @@ describe('LiveIntentMinimalId', function() { 'identifiersToResolve': ['_thirdPC'] } }}; - let callBackSpy = sinon.spy(); - let submoduleCallback = liveIntentIdSubmodule.getId(configParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = liveIntentIdSubmodule.getId(configParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.be.eq(`https://idx.liadm.com/idex/prebid/89899?duid=${oldCookie}&_thirdPC=third-pc&resolve=nonId`); request.respond( 200, @@ -200,10 +200,10 @@ describe('LiveIntentMinimalId', function() { 'identifiersToResolve': ['_thirdPC'] } }}; - let callBackSpy = sinon.spy(); - let submoduleCallback = liveIntentIdSubmodule.getId(configParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = liveIntentIdSubmodule.getId(configParams).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.be.eq('https://idx.liadm.com/idex/prebid/89899?_thirdPC=%7B%22key%22%3A%22value%22%7D&resolve=nonId'); request.respond( 200, @@ -224,13 +224,13 @@ describe('LiveIntentMinimalId', function() { }); it('should resolve extra attributes', function() { - let callBackSpy = sinon.spy(); - let submoduleCallback = liveIntentIdSubmodule.getId({ params: { + const callBackSpy = sinon.spy(); + const submoduleCallback = liveIntentIdSubmodule.getId({ params: { ...defaultConfigParams.params, ...{ requestedAttributesOverrides: { 'foo': true, 'bar': false } } } }).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.be.eq(`https://idx.liadm.com/idex/prebid/89899?resolve=nonId&resolve=foo`); request.respond( 200, @@ -298,13 +298,13 @@ describe('LiveIntentMinimalId', function() { }); it('should allow disabling nonId resolution', function() { - let callBackSpy = sinon.spy(); - let submoduleCallback = liveIntentIdSubmodule.getId({ params: { + const callBackSpy = sinon.spy(); + const submoduleCallback = liveIntentIdSubmodule.getId({ params: { ...defaultConfigParams.params, ...{ requestedAttributesOverrides: { 'nonId': false, 'uid2': true } } } }).callback; submoduleCallback(callBackSpy); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.be.eq(`https://idx.liadm.com/idex/prebid/89899?resolve=uid2`); request.respond( 200, diff --git a/test/spec/modules/liveIntentIdSystem_spec.js b/test/spec/modules/liveIntentIdSystem_spec.js index e2c7fac20e7..84951ba1cc0 100644 --- a/test/spec/modules/liveIntentIdSystem_spec.js +++ b/test/spec/modules/liveIntentIdSystem_spec.js @@ -77,11 +77,11 @@ describe('LiveIntentId', function() { gppString: 'gppConsentDataString', applicableSections: [1, 2] }) - let callBackSpy = sinon.spy(); - let submoduleCallback = liveIntentIdSubmodule.getId(defaultConfigParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = liveIntentIdSubmodule.getId(defaultConfigParams).callback; submoduleCallback(callBackSpy); setTimeout(() => { - let requests = idxRequests().concat(rpRequests()); + const requests = idxRequests().concat(rpRequests()); expect(requests).to.be.empty; expect(callBackSpy.notCalled).to.be.true; done(); @@ -100,7 +100,7 @@ describe('LiveIntentId', function() { }) liveIntentIdSubmodule.getId(defaultConfigParams); setTimeout(() => { - let request = rpRequests()[0]; + const request = rpRequests()[0]; expect(request.url).to.match(/https:\/\/rp.liadm.com\/j\?.*&us_privacy=1YNY.*&wpn=prebid.*&gdpr=0.*&gdpr_consent=consentDataString.*&gpp_s=gppConsentDataString.*&gpp_as=1.*/); done(); }, 300); @@ -112,7 +112,7 @@ describe('LiveIntentId', function() { emailHash: '58131bc547fb87af94cebdaf3102321f' }}); setTimeout(() => { - let request = rpRequests()[0]; + const request = rpRequests()[0]; expect(request.url).to.match(/https:\/\/rp.liadm.com\/j\?.*e=58131bc547fb87af94cebdaf3102321f.+/) done(); }, 300); @@ -121,7 +121,7 @@ describe('LiveIntentId', function() { it('should initialize LiveConnect and forward the prebid version when decode and emit an event', function(done) { liveIntentIdSubmodule.decode({}, defaultConfigParams); setTimeout(() => { - let request = rpRequests()[0]; + const request = rpRequests()[0]; expect(request.url).to.contain('tv=$prebid.version$') done(); }, 300); @@ -139,7 +139,7 @@ describe('LiveIntentId', function() { } }}); setTimeout(() => { - let request = requests(/https:\/\/collector.liveintent.com\/j\?.*aid=a-0001.*&wpn=prebid.*/); + const request = requests(/https:\/\/collector.liveintent.com\/j\?.*aid=a-0001.*&wpn=prebid.*/); expect(request.length).to.be.greaterThan(0); done(); }, 300); @@ -148,7 +148,7 @@ describe('LiveIntentId', function() { it('should fire an event with the provided distributorId', function (done) { liveIntentIdSubmodule.decode({}, { params: { fireEventDelay: 1, distributorId: 'did-1111' } }); setTimeout(() => { - let request = rpRequests()[0]; + const request = rpRequests()[0]; expect(request.url).to.match(/https:\/\/rp.liadm.com\/j\?.*did=did-1111.*&wpn=prebid.*/); done(); }, 300); @@ -157,7 +157,7 @@ describe('LiveIntentId', function() { it('should fire an event without the provided distributorId when appId is provided', function (done) { liveIntentIdSubmodule.decode({}, { params: { fireEventDelay: 1, distributorId: 'did-1111', liCollectConfig: { appId: 'a-0001' } } }); setTimeout(() => { - let request = rpRequests()[0]; + const request = rpRequests()[0]; expect(request.url).to.match(/https:\/\/rp.liadm.com\/j\?.*aid=a-0001.*&wpn=prebid.*/); expect(request.url).to.not.match(/.*did=*/); done(); @@ -176,7 +176,7 @@ describe('LiveIntentId', function() { }) liveIntentIdSubmodule.decode({}, defaultConfigParams); setTimeout(() => { - let request = rpRequests()[0]; + const request = rpRequests()[0]; expect(request.url).to.match(/.*us_privacy=1YNY.*&gdpr=0&gdpr_consent=consentDataString.*&gpp_s=gppConsentDataString&gpp_as=1.*/); done(); }, 300); @@ -188,7 +188,7 @@ describe('LiveIntentId', function() { emailHash: '58131bc547fb87af94cebdaf3102321f' }}); setTimeout(() => { - let request = rpRequests()[0]; + const request = rpRequests()[0]; expect(request.url).to.match(/https:\/\/rp.liadm.com\/j\?.*e=58131bc547fb87af94cebdaf3102321f.+/); done(); }, 300); @@ -215,10 +215,10 @@ describe('LiveIntentId', function() { it('should call the custom URL of the LiveIntent Identity Exchange endpoint', function() { getCookieStub.returns(null); - let callBackSpy = sinon.spy(); - let submoduleCallback = liveIntentIdSubmodule.getId({ params: {...defaultConfigParams.params, ...{'url': 'https://dummy.liveintent.com/idex'}} }).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = liveIntentIdSubmodule.getId({ params: {...defaultConfigParams.params, ...{'url': 'https://dummy.liveintent.com/idex'}} }).callback; submoduleCallback(callBackSpy); - let request = requests(/https:\/\/dummy.liveintent.com\/idex\/.*/)[0]; + const request = requests(/https:\/\/dummy.liveintent.com\/idex\/.*/)[0]; expect(request.url).to.match(/https:\/\/dummy.liveintent.com\/idex\/prebid\/89899\?.*cd=.localhost.*&resolve=nonId.*/); request.respond( 204, @@ -229,10 +229,10 @@ describe('LiveIntentId', function() { it('should call the Identity Exchange endpoint with the provided distributorId', function() { getCookieStub.returns(null); - let callBackSpy = sinon.spy(); - let submoduleCallback = liveIntentIdSubmodule.getId({ params: { fireEventDelay: 1, distributorId: 'did-1111' } }).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = liveIntentIdSubmodule.getId({ params: { fireEventDelay: 1, distributorId: 'did-1111' } }).callback; submoduleCallback(callBackSpy); - let request = idxRequests()[0]; + const request = idxRequests()[0]; expect(request.url).to.match(/https:\/\/idx.liadm.com\/idex\/did-1111\/any\?.*did=did-1111.*&cd=.localhost.*&resolve=nonId.*/); request.respond( 204, @@ -243,10 +243,10 @@ describe('LiveIntentId', function() { it('should call the Identity Exchange endpoint without the provided distributorId when appId is provided', function() { getCookieStub.returns(null); - let callBackSpy = sinon.spy(); - let submoduleCallback = liveIntentIdSubmodule.getId({ params: { fireEventDelay: 1, distributorId: 'did-1111', liCollectConfig: { appId: 'a-0001' } } }).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = liveIntentIdSubmodule.getId({ params: { fireEventDelay: 1, distributorId: 'did-1111', liCollectConfig: { appId: 'a-0001' } } }).callback; submoduleCallback(callBackSpy); - let request = idxRequests()[0]; + const request = idxRequests()[0]; expect(request.url).to.match(/https:\/\/idx.liadm.com\/idex\/prebid\/any\?.*cd=.localhost.*&resolve=nonId.*/); request.respond( 204, @@ -257,8 +257,8 @@ describe('LiveIntentId', function() { it('should call the default url of the LiveIntent Identity Exchange endpoint, with a partner', function() { getCookieStub.returns(null); - let callBackSpy = sinon.spy(); - let submoduleCallback = liveIntentIdSubmodule.getId({ params: { + const callBackSpy = sinon.spy(); + const submoduleCallback = liveIntentIdSubmodule.getId({ params: { ...defaultConfigParams.params, ...{ 'url': 'https://dummy.liveintent.com/idex', @@ -266,7 +266,7 @@ describe('LiveIntentId', function() { } } }).callback; submoduleCallback(callBackSpy); - let request = requests(/https:\/\/dummy.liveintent.com\/idex\/.*/)[0]; + const request = requests(/https:\/\/dummy.liveintent.com\/idex\/.*/)[0]; expect(request.url).to.match(/https:\/\/dummy.liveintent.com\/idex\/rubicon\/89899\?.*cd=.localhost.*&resolve=nonId.*/); request.respond( 200, @@ -278,10 +278,10 @@ describe('LiveIntentId', function() { it('should call the LiveIntent Identity Exchange endpoint, with no additional query params', function() { getCookieStub.returns(null); - let callBackSpy = sinon.spy(); - let submoduleCallback = liveIntentIdSubmodule.getId(defaultConfigParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = liveIntentIdSubmodule.getId(defaultConfigParams).callback; submoduleCallback(callBackSpy); - let request = idxRequests()[0]; + const request = idxRequests()[0]; expect(request.url).to.match(/https:\/\/idx.liadm.com\/idex\/prebid\/89899\?.*cd=.localhost.*&resolve=nonId.*/); request.respond( 200, @@ -293,10 +293,10 @@ describe('LiveIntentId', function() { it('should log an error and continue to callback if ajax request errors', function() { getCookieStub.returns(null); - let callBackSpy = sinon.spy(); - let submoduleCallback = liveIntentIdSubmodule.getId(defaultConfigParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = liveIntentIdSubmodule.getId(defaultConfigParams).callback; submoduleCallback(callBackSpy); - let request = idxRequests()[0]; + const request = idxRequests()[0]; expect(request.url).to.match(/https:\/\/idx.liadm.com\/idex\/prebid\/89899\?.*cd=.localhost.*&resolve=nonId.*/); request.respond( 503, @@ -310,10 +310,10 @@ describe('LiveIntentId', function() { it('should include the LiveConnect identifier when calling the LiveIntent Identity Exchange endpoint', function() { const oldCookie = 'a-xxxx--123e4567-e89b-12d3-a456-426655440000' getCookieStub.withArgs('_lc2_fpi').returns(oldCookie) - let callBackSpy = sinon.spy(); - let submoduleCallback = liveIntentIdSubmodule.getId(defaultConfigParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = liveIntentIdSubmodule.getId(defaultConfigParams).callback; submoduleCallback(callBackSpy); - let request = idxRequests()[0]; + const request = idxRequests()[0]; const expected = new RegExp('https:\/\/idx.liadm.com\/idex\/prebid\/89899\?.*duid=' + oldCookie + '.*&cd=.localhost.*&resolve=nonId.*'); expect(request.url).to.match(expected); request.respond( @@ -334,10 +334,10 @@ describe('LiveIntentId', function() { 'identifiersToResolve': ['_thirdPC'] } }}; - let callBackSpy = sinon.spy(); - let submoduleCallback = liveIntentIdSubmodule.getId(configParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = liveIntentIdSubmodule.getId(configParams).callback; submoduleCallback(callBackSpy); - let request = idxRequests()[0]; + const request = idxRequests()[0]; const expected = new RegExp('https:\/\/idx.liadm.com\/idex\/prebid\/89899\?.*duid=' + oldCookie + '.*&cd=.localhost.*&_thirdPC=third-pc.*&resolve=nonId.*'); expect(request.url).to.match(expected); request.respond( @@ -357,10 +357,10 @@ describe('LiveIntentId', function() { 'identifiersToResolve': ['_thirdPC'] } }}; - let callBackSpy = sinon.spy(); - let submoduleCallback = liveIntentIdSubmodule.getId(configParams).callback; + const callBackSpy = sinon.spy(); + const submoduleCallback = liveIntentIdSubmodule.getId(configParams).callback; submoduleCallback(callBackSpy); - let request = idxRequests()[0]; + const request = idxRequests()[0]; expect(request.url).to.match(/https:\/\/idx.liadm.com\/idex\/prebid\/89899\?.*cd=.localhost.*&_thirdPC=%7B%22key%22%3A%22value%22%7D.*&resolve=nonId.*/); request.respond( 200, @@ -378,7 +378,7 @@ describe('LiveIntentId', function() { userAgent: 'boo' }}); setTimeout(() => { - let request = rpRequests()[0]; + const request = rpRequests()[0]; expect(request.url).to.match(/^https:\/\/rp\.liadm\.com\/j?.*pip=.*&pip6=.*$/) expect(request.requestHeaders['X-LI-Provided-User-Agent']).to.be.eq('boo') done(); @@ -402,13 +402,13 @@ describe('LiveIntentId', function() { }); it('should resolve extra attributes', function() { - let callBackSpy = sinon.spy(); - let submoduleCallback = liveIntentIdSubmodule.getId({ params: { + const callBackSpy = sinon.spy(); + const submoduleCallback = liveIntentIdSubmodule.getId({ params: { ...defaultConfigParams.params, ...{ requestedAttributesOverrides: { 'foo': true, 'bar': false } } } }).callback; submoduleCallback(callBackSpy); - let request = idxRequests()[0]; + const request = idxRequests()[0]; expect(request.url).to.match(/https:\/\/idx.liadm.com\/idex\/prebid\/89899\?.*cd=.localhost.*&resolve=nonId.*&resolve=foo.*/); request.respond( 200, @@ -481,13 +481,13 @@ describe('LiveIntentId', function() { }); it('should allow disabling nonId resolution', function() { - let callBackSpy = sinon.spy(); - let submoduleCallback = liveIntentIdSubmodule.getId({ params: { + const callBackSpy = sinon.spy(); + const submoduleCallback = liveIntentIdSubmodule.getId({ params: { ...defaultConfigParams.params, ...{ requestedAttributesOverrides: { 'nonId': false, 'uid2': true } } } }).callback; submoduleCallback(callBackSpy); - let request = idxRequests()[0]; + const request = idxRequests()[0]; expect(request.url).to.match(/https:\/\/idx.liadm.com\/idex\/prebid\/89899\?.*cd=.localhost.*&resolve=uid2.*/); request.respond( 200, diff --git a/test/spec/modules/livewrappedAnalyticsAdapter_spec.js b/test/spec/modules/livewrappedAnalyticsAdapter_spec.js index 4607b249bc2..42ab636776b 100644 --- a/test/spec/modules/livewrappedAnalyticsAdapter_spec.js +++ b/test/spec/modules/livewrappedAnalyticsAdapter_spec.js @@ -4,9 +4,9 @@ import { config } from 'src/config.js'; import { server } from 'test/mocks/xhr.js'; import { setConfig } from 'modules/currency.js'; -let events = require('src/events'); -let utils = require('src/utils'); -let adapterManager = require('src/adapterManager').default; +const events = require('src/events'); +const utils = require('src/utils'); +const adapterManager = require('src/adapterManager').default; const { AUCTION_INIT, @@ -316,7 +316,7 @@ describe('Livewrapped analytics adapter', function () { beforeEach(function () { sandbox = sinon.createSandbox(); - let element = { + const element = { getAttribute: function() { return 'adunitid'; } @@ -366,11 +366,11 @@ describe('Livewrapped analytics adapter', function () { clock.tick(BID_WON_TIMEOUT + 1000); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.equal('https://lwadm.com/analytics/10'); - let message = JSON.parse(request.requestBody); + const message = JSON.parse(request.requestBody); expect(message).to.deep.equal(ANALYTICS_MESSAGE); }); @@ -416,7 +416,7 @@ describe('Livewrapped analytics adapter', function () { expect(server.requests.length).to.equal(1); - let message = JSON.parse(server.requests[0].requestBody); + const message = JSON.parse(server.requests[0].requestBody); expect(message.timeouts.length).to.equal(1); expect(message.timeouts[0].bidder).to.equal('livewrapped'); expect(message.timeouts[0].adUnit).to.equal('panorama_d_1'); @@ -455,8 +455,8 @@ describe('Livewrapped analytics adapter', function () { clock.tick(BID_WON_TIMEOUT + 1000); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; - let message = JSON.parse(request.requestBody); + const request = server.requests[0]; + const message = JSON.parse(request.requestBody); expect(message.gdpr.length).to.equal(1); expect(message.gdpr[0].gdprApplies).to.equal(true); @@ -509,8 +509,8 @@ describe('Livewrapped analytics adapter', function () { clock.tick(BID_WON_TIMEOUT + 1000); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; - let message = JSON.parse(request.requestBody); + const request = server.requests[0]; + const message = JSON.parse(request.requestBody); expect(message.gdpr.length).to.equal(1); @@ -560,8 +560,8 @@ describe('Livewrapped analytics adapter', function () { clock.tick(BID_WON_TIMEOUT + 1000); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; - let message = JSON.parse(request.requestBody); + const request = server.requests[0]; + const message = JSON.parse(request.requestBody); expect(message.gdpr.length).to.equal(1); @@ -589,8 +589,8 @@ describe('Livewrapped analytics adapter', function () { clock.tick(BID_WON_TIMEOUT + 1000); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; - let message = JSON.parse(request.requestBody); + const request = server.requests[0]; + const message = JSON.parse(request.requestBody); expect(message.wins.length).to.equal(1); expect(message.wins[0].rUp).to.equal('rUpObject'); @@ -623,7 +623,7 @@ describe('Livewrapped analytics adapter', function () { clock.tick(BID_WON_TIMEOUT + 1000); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.equal('https://whitelabeled.com/analytics/10'); }); @@ -657,8 +657,8 @@ describe('Livewrapped analytics adapter', function () { clock.tick(BID_WON_TIMEOUT + 1000); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; - let message = JSON.parse(request.requestBody); + const request = server.requests[0]; + const message = JSON.parse(request.requestBody); expect(message.ext).to.not.equal(null); expect(message.ext.testparam).to.equal(123); @@ -680,8 +680,8 @@ describe('Livewrapped analytics adapter', function () { clock.tick(BID_WON_TIMEOUT + 1000); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; - let message = JSON.parse(request.requestBody); + const request = server.requests[0]; + const message = JSON.parse(request.requestBody); expect(message.wins.length).to.equal(1); expect(message.wins[0]).to.deep.equal({ diff --git a/test/spec/modules/livewrappedBidAdapter_spec.js b/test/spec/modules/livewrappedBidAdapter_spec.js index 78de4301b6e..11df1b13a2c 100644 --- a/test/spec/modules/livewrappedBidAdapter_spec.js +++ b/test/spec/modules/livewrappedBidAdapter_spec.js @@ -59,41 +59,41 @@ describe('Livewrapped adapter tests', function () { describe('isBidRequestValid', function() { it('should accept a request with id only as valid', function() { - let bid = {params: {adUnitId: '9E153CED-61BC-479E-98DF-24DC0D01BA37'}}; + const bid = {params: {adUnitId: '9E153CED-61BC-479E-98DF-24DC0D01BA37'}}; - let result = spec.isBidRequestValid(bid); + const result = spec.isBidRequestValid(bid); expect(result).to.be.true; }); it('should accept a request with adUnitName and PublisherId as valid', function() { - let bid = {params: {adUnitName: 'panorama_d_1', publisherId: '26947112-2289-405D-88C1-A7340C57E63E'}}; + const bid = {params: {adUnitName: 'panorama_d_1', publisherId: '26947112-2289-405D-88C1-A7340C57E63E'}}; - let result = spec.isBidRequestValid(bid); + const result = spec.isBidRequestValid(bid); expect(result).to.be.true; }); it('should accept a request with adUnitCode and PublisherId as valid', function() { - let bid = {adUnitCode: 'panorama_d_1', params: {publisherId: '26947112-2289-405D-88C1-A7340C57E63E'}}; + const bid = {adUnitCode: 'panorama_d_1', params: {publisherId: '26947112-2289-405D-88C1-A7340C57E63E'}}; - let result = spec.isBidRequestValid(bid); + const result = spec.isBidRequestValid(bid); expect(result).to.be.true; }); it('should accept a request with placementCode and PublisherId as valid', function() { - let bid = {placementCode: 'panorama_d_1', params: {publisherId: '26947112-2289-405D-88C1-A7340C57E63E'}}; + const bid = {placementCode: 'panorama_d_1', params: {publisherId: '26947112-2289-405D-88C1-A7340C57E63E'}}; - let result = spec.isBidRequestValid(bid); + const result = spec.isBidRequestValid(bid); expect(result).to.be.true; }); it('should not accept a request with adUnitName, adUnitCode, placementCode but no PublisherId as valid', function() { - let bid = {placementCode: 'panorama_d_1', adUnitCode: 'panorama_d_1', params: {adUnitName: 'panorama_d_1'}}; + const bid = {placementCode: 'panorama_d_1', adUnitCode: 'panorama_d_1', params: {adUnitName: 'panorama_d_1'}}; - let result = spec.isBidRequestValid(bid); + const result = spec.isBidRequestValid(bid); expect(result).to.be.false; }); @@ -103,12 +103,12 @@ describe('Livewrapped adapter tests', function () { it('should make a well-formed single request object', function() { sandbox.stub(utils, 'isSafariBrowser').callsFake(() => false); sandbox.stub(storage, 'cookiesAreEnabled').callsFake(() => true); - let result = spec.buildRequests(bidderRequest.bids, bidderRequest); - let data = JSON.parse(result.data); + const result = spec.buildRequests(bidderRequest.bids, bidderRequest); + const data = JSON.parse(result.data); expect(result.url).to.equal('https://lwadm.com/ad'); - let expectedQuery = { + const expectedQuery = { auctionId: 'F7557995-65F5-4682-8782-7D5D34D82A8C', publisherId: '26947112-2289-405D-88C1-A7340C57E63E', userId: 'user id', @@ -137,14 +137,14 @@ describe('Livewrapped adapter tests', function () { it('should send ortb2Imp', function() { sandbox.stub(utils, 'isSafariBrowser').callsFake(() => false); sandbox.stub(storage, 'cookiesAreEnabled').callsFake(() => true); - let ortb2ImpRequest = clone(bidderRequest); + const ortb2ImpRequest = clone(bidderRequest); ortb2ImpRequest.bids[0].ortb2Imp.ext.data = {key: 'value'}; - let result = spec.buildRequests(ortb2ImpRequest.bids, ortb2ImpRequest); - let data = JSON.parse(result.data); + const result = spec.buildRequests(ortb2ImpRequest.bids, ortb2ImpRequest); + const data = JSON.parse(result.data); expect(result.url).to.equal('https://lwadm.com/ad'); - let expectedQuery = { + const expectedQuery = { auctionId: 'F7557995-65F5-4682-8782-7D5D34D82A8C', publisherId: '26947112-2289-405D-88C1-A7340C57E63E', userId: 'user id', @@ -174,19 +174,19 @@ describe('Livewrapped adapter tests', function () { it('should make a well-formed multiple request object', function() { sandbox.stub(utils, 'isSafariBrowser').callsFake(() => false); sandbox.stub(storage, 'cookiesAreEnabled').callsFake(() => true); - let multiplebidRequest = clone(bidderRequest); + const multiplebidRequest = clone(bidderRequest); multiplebidRequest.bids.push(clone(bidderRequest.bids[0])); multiplebidRequest.bids[1].adUnitCode = 'box_d_1'; multiplebidRequest.bids[1].sizes = [[300, 250]]; multiplebidRequest.bids[1].bidId = '3ffb201a808da7'; delete multiplebidRequest.bids[1].params.adUnitId; - let result = spec.buildRequests(multiplebidRequest.bids, multiplebidRequest); - let data = JSON.parse(result.data); + const result = spec.buildRequests(multiplebidRequest.bids, multiplebidRequest); + const data = JSON.parse(result.data); expect(result.url).to.equal('https://lwadm.com/ad'); - let expectedQuery = { + const expectedQuery = { auctionId: 'F7557995-65F5-4682-8782-7D5D34D82A8C', publisherId: '26947112-2289-405D-88C1-A7340C57E63E', userId: 'user id', @@ -224,15 +224,15 @@ describe('Livewrapped adapter tests', function () { it('should make a well-formed single request object with AdUnitName', function() { sandbox.stub(utils, 'isSafariBrowser').callsFake(() => false); sandbox.stub(storage, 'cookiesAreEnabled').callsFake(() => true); - let testbidRequest = clone(bidderRequest); + const testbidRequest = clone(bidderRequest); testbidRequest.bids[0].params.adUnitName = 'caller id 1'; delete testbidRequest.bids[0].params.adUnitId; - let result = spec.buildRequests(testbidRequest.bids, testbidRequest); - let data = JSON.parse(result.data); + const result = spec.buildRequests(testbidRequest.bids, testbidRequest); + const data = JSON.parse(result.data); expect(result.url).to.equal('https://lwadm.com/ad'); - let expectedQuery = { + const expectedQuery = { auctionId: 'F7557995-65F5-4682-8782-7D5D34D82A8C', publisherId: '26947112-2289-405D-88C1-A7340C57E63E', userId: 'user id', @@ -260,16 +260,16 @@ describe('Livewrapped adapter tests', function () { it('should make a well-formed single request object with less parameters', function() { sandbox.stub(utils, 'isSafariBrowser').callsFake(() => false); sandbox.stub(storage, 'cookiesAreEnabled').callsFake(() => true); - let testbidRequest = clone(bidderRequest); + const testbidRequest = clone(bidderRequest); delete testbidRequest.bids[0].params.userId; delete testbidRequest.bids[0].params.seats; delete testbidRequest.bids[0].params.adUnitId; - let result = spec.buildRequests(testbidRequest.bids, testbidRequest); - let data = JSON.parse(result.data); + const result = spec.buildRequests(testbidRequest.bids, testbidRequest); + const data = JSON.parse(result.data); expect(result.url).to.equal('https://lwadm.com/ad'); - let expectedQuery = { + const expectedQuery = { auctionId: 'F7557995-65F5-4682-8782-7D5D34D82A8C', publisherId: '26947112-2289-405D-88C1-A7340C57E63E', url: 'https://www.domain.com', @@ -295,16 +295,16 @@ describe('Livewrapped adapter tests', function () { it('should make a well-formed single request object with less parameters, no publisherId', function() { sandbox.stub(utils, 'isSafariBrowser').callsFake(() => false); sandbox.stub(storage, 'cookiesAreEnabled').callsFake(() => true); - let testbidRequest = clone(bidderRequest); + const testbidRequest = clone(bidderRequest); delete testbidRequest.bids[0].params.userId; delete testbidRequest.bids[0].params.seats; delete testbidRequest.bids[0].params.publisherId; - let result = spec.buildRequests(testbidRequest.bids, testbidRequest); - let data = JSON.parse(result.data); + const result = spec.buildRequests(testbidRequest.bids, testbidRequest); + const data = JSON.parse(result.data); expect(result.url).to.equal('https://lwadm.com/ad'); - let expectedQuery = { + const expectedQuery = { auctionId: 'F7557995-65F5-4682-8782-7D5D34D82A8C', url: 'https://www.domain.com', version: '1.4', @@ -330,16 +330,16 @@ describe('Livewrapped adapter tests', function () { it('should make a well-formed single request object with app parameters', function() { sandbox.stub(utils, 'isSafariBrowser').callsFake(() => false); sandbox.stub(storage, 'cookiesAreEnabled').callsFake(() => true); - let testbidRequest = clone(bidderRequest); + const testbidRequest = clone(bidderRequest); delete testbidRequest.bids[0].params.userId; delete testbidRequest.bids[0].params.seats; delete testbidRequest.bids[0].params.adUnitId; testbidRequest.bids[0].params.deviceId = 'deviceid'; testbidRequest.bids[0].params.ifa = 'ifa'; - let result = spec.buildRequests(testbidRequest.bids, testbidRequest); - let data = JSON.parse(result.data); + const result = spec.buildRequests(testbidRequest.bids, testbidRequest); + const data = JSON.parse(result.data); - let expectedQuery = { + const expectedQuery = { auctionId: 'F7557995-65F5-4682-8782-7D5D34D82A8C', publisherId: '26947112-2289-405D-88C1-A7340C57E63E', url: 'https://www.domain.com', @@ -367,16 +367,16 @@ describe('Livewrapped adapter tests', function () { it('should make a well-formed single request object with debug parameters', function() { sandbox.stub(utils, 'isSafariBrowser').callsFake(() => false); sandbox.stub(storage, 'cookiesAreEnabled').callsFake(() => true); - let testbidRequest = clone(bidderRequest); + const testbidRequest = clone(bidderRequest); delete testbidRequest.bids[0].params.userId; delete testbidRequest.bids[0].params.seats; delete testbidRequest.bids[0].params.adUnitId; testbidRequest.bids[0].params.tid = 'tracking id'; testbidRequest.bids[0].params.test = true; - let result = spec.buildRequests(testbidRequest.bids, testbidRequest); - let data = JSON.parse(result.data); + const result = spec.buildRequests(testbidRequest.bids, testbidRequest); + const data = JSON.parse(result.data); - let expectedQuery = { + const expectedQuery = { auctionId: 'F7557995-65F5-4682-8782-7D5D34D82A8C', publisherId: '26947112-2289-405D-88C1-A7340C57E63E', url: 'https://www.domain.com', @@ -404,15 +404,15 @@ describe('Livewrapped adapter tests', function () { it('should make a well-formed single request object with optional parameters', function() { sandbox.stub(utils, 'isSafariBrowser').callsFake(() => false); sandbox.stub(storage, 'cookiesAreEnabled').callsFake(() => true); - let testbidRequest = clone(bidderRequest); + const testbidRequest = clone(bidderRequest); delete testbidRequest.bids[0].params.userId; delete testbidRequest.bids[0].params.seats; delete testbidRequest.bids[0].params.adUnitId; testbidRequest.bids[0].params.options = {keyvalues: [{key: 'key', value: 'value'}]}; - let result = spec.buildRequests(testbidRequest.bids, testbidRequest); - let data = JSON.parse(result.data); + const result = spec.buildRequests(testbidRequest.bids, testbidRequest); + const data = JSON.parse(result.data); - let expectedQuery = { + const expectedQuery = { auctionId: 'F7557995-65F5-4682-8782-7D5D34D82A8C', publisherId: '26947112-2289-405D-88C1-A7340C57E63E', url: 'https://www.domain.com', @@ -440,14 +440,14 @@ describe('Livewrapped adapter tests', function () { sandbox.stub(utils, 'getWindowTop').returns({ I12C: { Morph: 1 } }); sandbox.stub(utils, 'isSafariBrowser').callsFake(() => false); sandbox.stub(storage, 'cookiesAreEnabled').callsFake(() => true); - let testbidRequest = clone(bidderRequest); + const testbidRequest = clone(bidderRequest); delete testbidRequest.bids[0].params.userId; delete testbidRequest.bids[0].params.seats; delete testbidRequest.bids[0].params.adUnitId; - let result = spec.buildRequests(testbidRequest.bids, testbidRequest); - let data = JSON.parse(result.data); + const result = spec.buildRequests(testbidRequest.bids, testbidRequest); + const data = JSON.parse(result.data); - let expectedQuery = { + const expectedQuery = { auctionId: 'F7557995-65F5-4682-8782-7D5D34D82A8C', publisherId: '26947112-2289-405D-88C1-A7340C57E63E', url: 'https://www.domain.com', @@ -474,15 +474,15 @@ describe('Livewrapped adapter tests', function () { it('should make a well-formed single request object with native only parameters', function() { sandbox.stub(utils, 'isSafariBrowser').callsFake(() => false); sandbox.stub(storage, 'cookiesAreEnabled').callsFake(() => true); - let testbidRequest = clone(bidderRequest); + const testbidRequest = clone(bidderRequest); delete testbidRequest.bids[0].params.userId; delete testbidRequest.bids[0].params.seats; delete testbidRequest.bids[0].params.adUnitId; testbidRequest.bids[0].mediaTypes = {'native': {'nativedata': 'content parsed serverside only'}}; - let result = spec.buildRequests(testbidRequest.bids, testbidRequest); - let data = JSON.parse(result.data); + const result = spec.buildRequests(testbidRequest.bids, testbidRequest); + const data = JSON.parse(result.data); - let expectedQuery = { + const expectedQuery = { auctionId: 'F7557995-65F5-4682-8782-7D5D34D82A8C', publisherId: '26947112-2289-405D-88C1-A7340C57E63E', url: 'https://www.domain.com', @@ -509,15 +509,15 @@ describe('Livewrapped adapter tests', function () { it('should make a well-formed single request object with native and banner parameters', function() { sandbox.stub(utils, 'isSafariBrowser').callsFake(() => false); sandbox.stub(storage, 'cookiesAreEnabled').callsFake(() => true); - let testbidRequest = clone(bidderRequest); + const testbidRequest = clone(bidderRequest); delete testbidRequest.bids[0].params.userId; delete testbidRequest.bids[0].params.seats; delete testbidRequest.bids[0].params.adUnitId; testbidRequest.bids[0].mediaTypes = {'native': {'nativedata': 'content parsed serverside only'}, 'banner': {'sizes': [[980, 240], [980, 120]]}}; - let result = spec.buildRequests(testbidRequest.bids, testbidRequest); - let data = JSON.parse(result.data); + const result = spec.buildRequests(testbidRequest.bids, testbidRequest); + const data = JSON.parse(result.data); - let expectedQuery = { + const expectedQuery = { auctionId: 'F7557995-65F5-4682-8782-7D5D34D82A8C', publisherId: '26947112-2289-405D-88C1-A7340C57E63E', url: 'https://www.domain.com', @@ -545,15 +545,15 @@ describe('Livewrapped adapter tests', function () { it('should make a well-formed single request object with video only parameters', function() { sandbox.stub(utils, 'isSafariBrowser').callsFake(() => false); sandbox.stub(storage, 'cookiesAreEnabled').callsFake(() => true); - let testbidRequest = clone(bidderRequest); + const testbidRequest = clone(bidderRequest); delete testbidRequest.bids[0].params.userId; delete testbidRequest.bids[0].params.seats; delete testbidRequest.bids[0].params.adUnitId; testbidRequest.bids[0].mediaTypes = {'video': {'videodata': 'content parsed serverside only'}}; - let result = spec.buildRequests(testbidRequest.bids, testbidRequest); - let data = JSON.parse(result.data); + const result = spec.buildRequests(testbidRequest.bids, testbidRequest); + const data = JSON.parse(result.data); - let expectedQuery = { + const expectedQuery = { auctionId: 'F7557995-65F5-4682-8782-7D5D34D82A8C', publisherId: '26947112-2289-405D-88C1-A7340C57E63E', url: 'https://www.domain.com', @@ -581,10 +581,10 @@ describe('Livewrapped adapter tests', function () { sandbox.stub(utils, 'isSafariBrowser').callsFake(() => false); sandbox.stub(storage, 'cookiesAreEnabled').callsFake(() => true); - let testbidRequest = clone(bidderRequest); + const testbidRequest = clone(bidderRequest); delete testbidRequest.bids[0].params.url; - let origGetConfig = config.getConfig; + const origGetConfig = config.getConfig; sandbox.stub(config, 'getConfig').callsFake(function (key) { if (key === 'app') { return {bundle: 'bundle', domain: 'https://appdomain.com'}; @@ -595,12 +595,12 @@ describe('Livewrapped adapter tests', function () { return origGetConfig.apply(config, arguments); }); - let result = spec.buildRequests(testbidRequest.bids, testbidRequest); - let data = JSON.parse(result.data); + const result = spec.buildRequests(testbidRequest.bids, testbidRequest); + const data = JSON.parse(result.data); expect(result.url).to.equal('https://lwadm.com/ad'); - let expectedQuery = { + const expectedQuery = { auctionId: 'F7557995-65F5-4682-8782-7D5D34D82A8C', publisherId: '26947112-2289-405D-88C1-A7340C57E63E', userId: 'user id', @@ -631,15 +631,15 @@ describe('Livewrapped adapter tests', function () { it('should use mediaTypes.banner.sizes before legacy sizes', function() { sandbox.stub(utils, 'isSafariBrowser').callsFake(() => false); sandbox.stub(storage, 'cookiesAreEnabled').callsFake(() => true); - let testbidRequest = clone(bidderRequest); + const testbidRequest = clone(bidderRequest); delete testbidRequest.bids[0].params.userId; delete testbidRequest.bids[0].params.seats; delete testbidRequest.bids[0].params.adUnitId; testbidRequest.bids[0].mediaTypes = {'banner': {'sizes': [[728, 90]]}}; - let result = spec.buildRequests(testbidRequest.bids, testbidRequest); - let data = JSON.parse(result.data); + const result = spec.buildRequests(testbidRequest.bids, testbidRequest); + const data = JSON.parse(result.data); - let expectedQuery = { + const expectedQuery = { auctionId: 'F7557995-65F5-4682-8782-7D5D34D82A8C', publisherId: '26947112-2289-405D-88C1-A7340C57E63E', url: 'https://www.domain.com', @@ -665,17 +665,17 @@ describe('Livewrapped adapter tests', function () { it('should pass gdpr true parameters', function() { sandbox.stub(utils, 'isSafariBrowser').callsFake(() => false); sandbox.stub(storage, 'cookiesAreEnabled').callsFake(() => true); - let testRequest = clone(bidderRequest); + const testRequest = clone(bidderRequest); testRequest.gdprConsent = { gdprApplies: true, consentString: 'test' }; - let result = spec.buildRequests(testRequest.bids, testRequest); - let data = JSON.parse(result.data); + const result = spec.buildRequests(testRequest.bids, testRequest); + const data = JSON.parse(result.data); expect(result.url).to.equal('https://lwadm.com/ad'); - let expectedQuery = { + const expectedQuery = { auctionId: 'F7557995-65F5-4682-8782-7D5D34D82A8C', publisherId: '26947112-2289-405D-88C1-A7340C57E63E', userId: 'user id', @@ -706,16 +706,16 @@ describe('Livewrapped adapter tests', function () { it('should pass gdpr false parameters', function() { sandbox.stub(utils, 'isSafariBrowser').callsFake(() => false); sandbox.stub(storage, 'cookiesAreEnabled').callsFake(() => true); - let testRequest = clone(bidderRequest); + const testRequest = clone(bidderRequest); testRequest.gdprConsent = { gdprApplies: false }; - let result = spec.buildRequests(testRequest.bids, testRequest); - let data = JSON.parse(result.data); + const result = spec.buildRequests(testRequest.bids, testRequest); + const data = JSON.parse(result.data); expect(result.url).to.equal('https://lwadm.com/ad'); - let expectedQuery = { + const expectedQuery = { auctionId: 'F7557995-65F5-4682-8782-7D5D34D82A8C', publisherId: '26947112-2289-405D-88C1-A7340C57E63E', userId: 'user id', @@ -745,14 +745,14 @@ describe('Livewrapped adapter tests', function () { it('should pass us privacy parameter', function() { sandbox.stub(utils, 'isSafariBrowser').callsFake(() => false); sandbox.stub(storage, 'cookiesAreEnabled').callsFake(() => true); - let testRequest = clone(bidderRequest); + const testRequest = clone(bidderRequest); testRequest.uspConsent = '1---'; - let result = spec.buildRequests(testRequest.bids, testRequest); - let data = JSON.parse(result.data); + const result = spec.buildRequests(testRequest.bids, testRequest); + const data = JSON.parse(result.data); expect(result.url).to.equal('https://lwadm.com/ad'); - let expectedQuery = { + const expectedQuery = { auctionId: 'F7557995-65F5-4682-8782-7D5D34D82A8C', publisherId: '26947112-2289-405D-88C1-A7340C57E63E', userId: 'user id', @@ -783,7 +783,7 @@ describe('Livewrapped adapter tests', function () { sandbox.stub(utils, 'isSafariBrowser').callsFake(() => false); sandbox.stub(storage, 'cookiesAreEnabled').callsFake(() => true); - let origGetConfig = config.getConfig; + const origGetConfig = config.getConfig; sandbox.stub(config, 'getConfig').callsFake(function (key) { if (key === 'coppa') { return true; @@ -791,12 +791,12 @@ describe('Livewrapped adapter tests', function () { return origGetConfig.apply(config, arguments); }); - let result = spec.buildRequests(bidderRequest.bids, bidderRequest); - let data = JSON.parse(result.data); + const result = spec.buildRequests(bidderRequest.bids, bidderRequest); + const data = JSON.parse(result.data); expect(result.url).to.equal('https://lwadm.com/ad'); - let expectedQuery = { + const expectedQuery = { auctionId: 'F7557995-65F5-4682-8782-7D5D34D82A8C', publisherId: '26947112-2289-405D-88C1-A7340C57E63E', userId: 'user id', @@ -826,12 +826,12 @@ describe('Livewrapped adapter tests', function () { it('should pass no cookie support', function() { sandbox.stub(storage, 'cookiesAreEnabled').callsFake(() => false); sandbox.stub(utils, 'isSafariBrowser').callsFake(() => false); - let result = spec.buildRequests(bidderRequest.bids, bidderRequest); - let data = JSON.parse(result.data); + const result = spec.buildRequests(bidderRequest.bids, bidderRequest); + const data = JSON.parse(result.data); expect(result.url).to.equal('https://lwadm.com/ad'); - let expectedQuery = { + const expectedQuery = { auctionId: 'F7557995-65F5-4682-8782-7D5D34D82A8C', publisherId: '26947112-2289-405D-88C1-A7340C57E63E', userId: 'user id', @@ -860,12 +860,12 @@ describe('Livewrapped adapter tests', function () { it('should pass no cookie support Safari', function() { sandbox.stub(storage, 'cookiesAreEnabled').callsFake(() => true); sandbox.stub(utils, 'isSafariBrowser').callsFake(() => true); - let result = spec.buildRequests(bidderRequest.bids, bidderRequest); - let data = JSON.parse(result.data); + const result = spec.buildRequests(bidderRequest.bids, bidderRequest); + const data = JSON.parse(result.data); expect(result.url).to.equal('https://lwadm.com/ad'); - let expectedQuery = { + const expectedQuery = { auctionId: 'F7557995-65F5-4682-8782-7D5D34D82A8C', publisherId: '26947112-2289-405D-88C1-A7340C57E63E', userId: 'user id', @@ -892,7 +892,7 @@ describe('Livewrapped adapter tests', function () { }); it('should use params.url, then bidderRequest.refererInfo.page', function() { - let testRequest = clone(bidderRequest); + const testRequest = clone(bidderRequest); testRequest.refererInfo = {page: 'https://www.topurl.com'}; let result = spec.buildRequests(testRequest.bids, testRequest); @@ -911,15 +911,15 @@ describe('Livewrapped adapter tests', function () { it('should make use of pubcid if available', function() { sandbox.stub(utils, 'isSafariBrowser').callsFake(() => false); sandbox.stub(storage, 'cookiesAreEnabled').callsFake(() => true); - let testbidRequest = clone(bidderRequest); + const testbidRequest = clone(bidderRequest); delete testbidRequest.bids[0].params.userId; testbidRequest.bids[0].crumbs = {pubcid: 'pubcid 123'}; - let result = spec.buildRequests(testbidRequest.bids, testbidRequest); - let data = JSON.parse(result.data); + const result = spec.buildRequests(testbidRequest.bids, testbidRequest); + const data = JSON.parse(result.data); expect(result.url).to.equal('https://lwadm.com/ad'); - let expectedQuery = { + const expectedQuery = { auctionId: 'F7557995-65F5-4682-8782-7D5D34D82A8C', publisherId: '26947112-2289-405D-88C1-A7340C57E63E', userId: 'pubcid 123', @@ -948,14 +948,14 @@ describe('Livewrapped adapter tests', function () { it('should make userId take precedence over pubcid', function() { sandbox.stub(utils, 'isSafariBrowser').callsFake(() => false); sandbox.stub(storage, 'cookiesAreEnabled').callsFake(() => true); - let testbidRequest = clone(bidderRequest); + const testbidRequest = clone(bidderRequest); testbidRequest.bids[0].crumbs = {pubcid: 'pubcid 123'}; - let result = spec.buildRequests(testbidRequest.bids, testbidRequest); - let data = JSON.parse(result.data); + const result = spec.buildRequests(testbidRequest.bids, testbidRequest); + const data = JSON.parse(result.data); expect(result.url).to.equal('https://lwadm.com/ad'); - let expectedQuery = { + const expectedQuery = { auctionId: 'F7557995-65F5-4682-8782-7D5D34D82A8C', publisherId: '26947112-2289-405D-88C1-A7340C57E63E', userId: 'user id', @@ -987,13 +987,13 @@ describe('Livewrapped adapter tests', function () { config.resetConfig(); - let testbidRequest = clone(bidderRequest); - let result = spec.buildRequests(testbidRequest.bids, testbidRequest); - let data = JSON.parse(result.data); + const testbidRequest = clone(bidderRequest); + const result = spec.buildRequests(testbidRequest.bids, testbidRequest); + const data = JSON.parse(result.data); expect(result.url).to.equal('https://lwadm.com/ad'); - let expectedQuery = { + const expectedQuery = { auctionId: 'F7557995-65F5-4682-8782-7D5D34D82A8C', publisherId: '26947112-2289-405D-88C1-A7340C57E63E', userId: 'user id', @@ -1025,13 +1025,13 @@ describe('Livewrapped adapter tests', function () { sandbox.stub(utils, 'isSafariBrowser').callsFake(() => false); sandbox.stub(storage, 'cookiesAreEnabled').callsFake(() => true); - let testbidRequest = clone(bidderRequest); - let result = spec.buildRequests(testbidRequest.bids, testbidRequest); - let data = JSON.parse(result.data); + const testbidRequest = clone(bidderRequest); + const result = spec.buildRequests(testbidRequest.bids, testbidRequest); + const data = JSON.parse(result.data); expect(result.url).to.equal('https://lwadm.com/ad'); - let expectedQuery = { + const expectedQuery = { auctionId: 'F7557995-65F5-4682-8782-7D5D34D82A8C', publisherId: '26947112-2289-405D-88C1-A7340C57E63E', userId: 'user id', @@ -1061,17 +1061,17 @@ describe('Livewrapped adapter tests', function () { sandbox.stub(utils, 'isSafariBrowser').callsFake(() => false); sandbox.stub(storage, 'cookiesAreEnabled').callsFake(() => true); - let testbidRequest = clone(bidderRequest); - let bids = testbidRequest.bids.map(b => { + const testbidRequest = clone(bidderRequest); + const bids = testbidRequest.bids.map(b => { b.getFloor = function () { return undefined; } return b; }); - let result = spec.buildRequests(bids, testbidRequest); - let data = JSON.parse(result.data); + const result = spec.buildRequests(bids, testbidRequest); + const data = JSON.parse(result.data); expect(result.url).to.equal('https://lwadm.com/ad'); - let expectedQuery = { + const expectedQuery = { auctionId: 'F7557995-65F5-4682-8782-7D5D34D82A8C', publisherId: '26947112-2289-405D-88C1-A7340C57E63E', userId: 'user id', @@ -1101,17 +1101,17 @@ describe('Livewrapped adapter tests', function () { sandbox.stub(utils, 'isSafariBrowser').callsFake(() => false); sandbox.stub(storage, 'cookiesAreEnabled').callsFake(() => true); - let testbidRequest = clone(bidderRequest); - let bids = testbidRequest.bids.map(b => { + const testbidRequest = clone(bidderRequest); + const bids = testbidRequest.bids.map(b => { b.getFloor = function () { return { floor: undefined }; } return b; }); - let result = spec.buildRequests(bids, testbidRequest); - let data = JSON.parse(result.data); + const result = spec.buildRequests(bids, testbidRequest); + const data = JSON.parse(result.data); expect(result.url).to.equal('https://lwadm.com/ad'); - let expectedQuery = { + const expectedQuery = { auctionId: 'F7557995-65F5-4682-8782-7D5D34D82A8C', publisherId: '26947112-2289-405D-88C1-A7340C57E63E', userId: 'user id', @@ -1141,17 +1141,17 @@ describe('Livewrapped adapter tests', function () { sandbox.stub(utils, 'isSafariBrowser').callsFake(() => false); sandbox.stub(storage, 'cookiesAreEnabled').callsFake(() => true); - let testbidRequest = clone(bidderRequest); - let bids = testbidRequest.bids.map(b => { + const testbidRequest = clone(bidderRequest); + const bids = testbidRequest.bids.map(b => { b.getFloor = function () { return { floor: 10, currency: 'EUR' }; } return b; }); - let result = spec.buildRequests(bids, testbidRequest); - let data = JSON.parse(result.data); + const result = spec.buildRequests(bids, testbidRequest); + const data = JSON.parse(result.data); expect(result.url).to.equal('https://lwadm.com/ad'); - let expectedQuery = { + const expectedQuery = { auctionId: 'F7557995-65F5-4682-8782-7D5D34D82A8C', publisherId: '26947112-2289-405D-88C1-A7340C57E63E', userId: 'user id', @@ -1182,15 +1182,15 @@ describe('Livewrapped adapter tests', function () { sandbox.stub(storage, 'cookiesAreEnabled').callsFake(() => true); setCurrencyConfig({ adServerCurrency: 'EUR' }); - let testbidRequest = clone(bidderRequest); - let bids = testbidRequest.bids.map(b => { + const testbidRequest = clone(bidderRequest); + const bids = testbidRequest.bids.map(b => { b.getFloor = function () { return { floor: 10, currency: 'EUR' }; } return b; }); return addFPDToBidderRequest(testbidRequest).then(res => { - let result = spec.buildRequests(bids, res); - let data = JSON.parse(result.data); + const result = spec.buildRequests(bids, res); + const data = JSON.parse(result.data); expect(result.url).to.equal('https://lwadm.com/ad'); expect(data.adRequests[0].flr).to.eql(10) expect(data.flrCur).to.eql('EUR') @@ -1202,17 +1202,17 @@ describe('Livewrapped adapter tests', function () { sandbox.stub(utils, 'isSafariBrowser').callsFake(() => false); sandbox.stub(storage, 'cookiesAreEnabled').callsFake(() => true); - let testbidRequest = clone(bidderRequest); - let bids = testbidRequest.bids.map(b => { + const testbidRequest = clone(bidderRequest); + const bids = testbidRequest.bids.map(b => { b.getFloor = function () { return { floor: 10, currency: 'USD' }; } return b; }); - let result = spec.buildRequests(bids, testbidRequest); - let data = JSON.parse(result.data); + const result = spec.buildRequests(bids, testbidRequest); + const data = JSON.parse(result.data); expect(result.url).to.equal('https://lwadm.com/ad'); - let expectedQuery = { + const expectedQuery = { auctionId: 'F7557995-65F5-4682-8782-7D5D34D82A8C', publisherId: '26947112-2289-405D-88C1-A7340C57E63E', userId: 'user id', @@ -1244,7 +1244,7 @@ describe('Livewrapped adapter tests', function () { it('should make use of user ids if available', function() { sandbox.stub(utils, 'isSafariBrowser').callsFake(() => false); sandbox.stub(storage, 'cookiesAreEnabled').callsFake(() => true); - let testbidRequest = clone(bidderRequest); + const testbidRequest = clone(bidderRequest); delete testbidRequest.bids[0].params.userId; testbidRequest.bids[0].userIdAsEids = [ { @@ -1266,8 +1266,8 @@ describe('Livewrapped adapter tests', function () { } ]; - let result = spec.buildRequests(testbidRequest.bids, testbidRequest); - let data = JSON.parse(result.data); + const result = spec.buildRequests(testbidRequest.bids, testbidRequest); + const data = JSON.parse(result.data); expect(data.rtbData.user.ext.eids).to.deep.equal(testbidRequest.bids[0].userIdAsEids); }); @@ -1278,7 +1278,7 @@ describe('Livewrapped adapter tests', function () { const ortb2 = {user: {ext: {prop: 'value'}}}; - let testbidRequest = {...clone(bidderRequest), ortb2}; + const testbidRequest = {...clone(bidderRequest), ortb2}; delete testbidRequest.bids[0].params.userId; testbidRequest.bids[0].userIdAsEids = [ { @@ -1290,8 +1290,8 @@ describe('Livewrapped adapter tests', function () { } ]; - let result = spec.buildRequests(testbidRequest.bids, testbidRequest); - let data = JSON.parse(result.data); + const result = spec.buildRequests(testbidRequest.bids, testbidRequest); + const data = JSON.parse(result.data); var expected = {user: {ext: {prop: 'value', eids: testbidRequest.bids[0].userIdAsEids}}} expect(data.rtbData).to.deep.equal(expected); @@ -1301,8 +1301,8 @@ describe('Livewrapped adapter tests', function () { it('should send schain object if available', function() { sandbox.stub(utils, 'isSafariBrowser').callsFake(() => false); sandbox.stub(storage, 'cookiesAreEnabled').callsFake(() => true); - let testbidRequest = clone(bidderRequest); - let schain = { + const testbidRequest = clone(bidderRequest); + const schain = { 'ver': '1.0', 'complete': 1, 'nodes': [ @@ -1320,15 +1320,15 @@ describe('Livewrapped adapter tests', function () { testbidRequest.bids[0].ortb2.source.ext = testbidRequest.bids[0].ortb2.source.ext || {}; testbidRequest.bids[0].ortb2.source.ext.schain = schain; - let result = spec.buildRequests(testbidRequest.bids, testbidRequest); - let data = JSON.parse(result.data); + const result = spec.buildRequests(testbidRequest.bids, testbidRequest); + const data = JSON.parse(result.data); expect(data.schain).to.deep.equal(schain); }); describe('interpretResponse', function () { it('should handle single success response', function() { - let lwResponse = { + const lwResponse = { ads: [ { id: '28e5ddf4-3c01-11e8-86a7-0a44794250d4', @@ -1347,7 +1347,7 @@ describe('Livewrapped adapter tests', function () { currency: 'USD' }; - let expectedResponse = [{ + const expectedResponse = [{ requestId: '32e50fad901ae89', cpm: 2.565917, width: 300, @@ -1360,13 +1360,13 @@ describe('Livewrapped adapter tests', function () { meta: undefined }]; - let bids = spec.interpretResponse({body: lwResponse}); + const bids = spec.interpretResponse({body: lwResponse}); expect(bids).to.deep.equal(expectedResponse); }) it('should forward dealId', function() { - let lwResponse = { + const lwResponse = { ads: [ { id: '28e5ddf4-3c01-11e8-86a7-0a44794250d4', @@ -1385,7 +1385,7 @@ describe('Livewrapped adapter tests', function () { currency: 'USD' }; - let expectedResponse = [{ + const expectedResponse = [{ requestId: '32e50fad901ae89', cpm: 2.565917, width: 300, @@ -1399,13 +1399,13 @@ describe('Livewrapped adapter tests', function () { meta: { dealId: "deal id", bidder: "bidder" } }]; - let bids = spec.interpretResponse({body: lwResponse}); + const bids = spec.interpretResponse({body: lwResponse}); expect(bids).to.deep.equal(expectedResponse); }) it('should forward bidderCode', function() { - let lwResponse = { + const lwResponse = { ads: [ { id: '28e5ddf4-3c01-11e8-86a7-0a44794250d4', @@ -1425,7 +1425,7 @@ describe('Livewrapped adapter tests', function () { currency: 'USD' }; - let expectedResponse = [{ + const expectedResponse = [{ requestId: '32e50fad901ae89', cpm: 2.565917, width: 300, @@ -1439,13 +1439,13 @@ describe('Livewrapped adapter tests', function () { bidderCode: "bidder" }]; - let bids = spec.interpretResponse({body: lwResponse}); + const bids = spec.interpretResponse({body: lwResponse}); expect(bids).to.deep.equal(expectedResponse); }) it('should handle single native success response', function() { - let lwResponse = { + const lwResponse = { ads: [ { id: '28e5ddf4-3c01-11e8-86a7-0a44794250d4', @@ -1465,7 +1465,7 @@ describe('Livewrapped adapter tests', function () { currency: 'USD' }; - let expectedResponse = [{ + const expectedResponse = [{ requestId: '32e50fad901ae89', cpm: 2.565917, width: 300, @@ -1480,13 +1480,13 @@ describe('Livewrapped adapter tests', function () { mediaType: NATIVE }]; - let bids = spec.interpretResponse({body: lwResponse}); + const bids = spec.interpretResponse({body: lwResponse}); expect(bids).to.deep.equal(expectedResponse); }) it('should handle single video success response', function() { - let lwResponse = { + const lwResponse = { ads: [ { id: '28e5ddf4-3c01-11e8-86a7-0a44794250d4', @@ -1506,7 +1506,7 @@ describe('Livewrapped adapter tests', function () { currency: 'USD' }; - let expectedResponse = [{ + const expectedResponse = [{ requestId: '32e50fad901ae89', cpm: 2.565917, width: 300, @@ -1521,13 +1521,13 @@ describe('Livewrapped adapter tests', function () { mediaType: VIDEO }]; - let bids = spec.interpretResponse({body: lwResponse}); + const bids = spec.interpretResponse({body: lwResponse}); expect(bids).to.deep.equal(expectedResponse); }) it('should handle multiple success response', function() { - let lwResponse = { + const lwResponse = { ads: [ { id: '28e5ddf4-3c01-11e8-86a7-0a44794250d4', @@ -1559,7 +1559,7 @@ describe('Livewrapped adapter tests', function () { currency: 'USD' }; - let expectedResponse = [{ + const expectedResponse = [{ requestId: '32e50fad901ae89', cpm: 2.565917, width: 300, @@ -1583,13 +1583,13 @@ describe('Livewrapped adapter tests', function () { meta: undefined }]; - let bids = spec.interpretResponse({body: lwResponse}); + const bids = spec.interpretResponse({body: lwResponse}); expect(bids).to.deep.equal(expectedResponse); }) it('should return meta-data', function() { - let lwResponse = { + const lwResponse = { ads: [ { id: '28e5ddf4-3c01-11e8-86a7-0a44794250d4', @@ -1608,7 +1608,7 @@ describe('Livewrapped adapter tests', function () { currency: 'USD' }; - let expectedResponse = [{ + const expectedResponse = [{ requestId: '32e50fad901ae89', cpm: 2.565917, width: 300, @@ -1621,13 +1621,13 @@ describe('Livewrapped adapter tests', function () { meta: {metadata: 'metadata'} }]; - let bids = spec.interpretResponse({body: lwResponse}); + const bids = spec.interpretResponse({body: lwResponse}); expect(bids).to.deep.equal(expectedResponse); }) it('should send debug-data to external debugger', function() { - let lwResponse = { + const lwResponse = { ads: [ { id: '28e5ddf4-3c01-11e8-86a7-0a44794250d4', @@ -1675,56 +1675,56 @@ describe('Livewrapped adapter tests', function () { }); it('should return empty if no server responses', function() { - let syncs = spec.getUserSyncs({ + const syncs = spec.getUserSyncs({ pixelEnabled: true, iframeEnabled: true }, []); - let expectedResponse = []; + const expectedResponse = []; expect(syncs).to.deep.equal(expectedResponse) }); it('should return empty if no user sync', function() { - let syncs = spec.getUserSyncs({ + const syncs = spec.getUserSyncs({ pixelEnabled: true, iframeEnabled: true }, [{body: {}}]); - let expectedResponse = []; + const expectedResponse = []; expect(syncs).to.deep.equal(expectedResponse) }); it('should returns pixel and iframe user sync', function() { - let syncs = spec.getUserSyncs({ + const syncs = spec.getUserSyncs({ pixelEnabled: true, iframeEnabled: true }, serverResponses); - let expectedResponse = [{type: 'image', url: 'https://pixelsync'}, {type: 'iframe', url: 'https://iframesync'}]; + const expectedResponse = [{type: 'image', url: 'https://pixelsync'}, {type: 'iframe', url: 'https://iframesync'}]; expect(syncs).to.deep.equal(expectedResponse) }); it('should returns pixel only if iframe not supported user sync', function() { - let syncs = spec.getUserSyncs({ + const syncs = spec.getUserSyncs({ pixelEnabled: true, iframeEnabled: false }, serverResponses); - let expectedResponse = [{type: 'image', url: 'https://pixelsync'}]; + const expectedResponse = [{type: 'image', url: 'https://pixelsync'}]; expect(syncs).to.deep.equal(expectedResponse) }); it('should returns iframe only if pixel not supported user sync', function() { - let syncs = spec.getUserSyncs({ + const syncs = spec.getUserSyncs({ pixelEnabled: false, iframeEnabled: true }, serverResponses); - let expectedResponse = [{type: 'iframe', url: 'https://iframesync'}]; + const expectedResponse = [{type: 'iframe', url: 'https://iframesync'}]; expect(syncs).to.deep.equal(expectedResponse) }); diff --git a/test/spec/modules/lkqdBidAdapter_spec.js b/test/spec/modules/lkqdBidAdapter_spec.js index 1e05b9deeb3..2dd58c7193f 100644 --- a/test/spec/modules/lkqdBidAdapter_spec.js +++ b/test/spec/modules/lkqdBidAdapter_spec.js @@ -46,7 +46,7 @@ describe('lkqdBidAdapter', () => { }); it('should return false when required params are not passed', () => { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = { wrong: 'missing zone id' @@ -298,15 +298,15 @@ describe('lkqdBidAdapter', () => { }); it('safely handles invalid bid response', () => { - let invalidServerResponse = {}; + const invalidServerResponse = {}; invalidServerResponse.body = ''; - let result = spec.interpretResponse(invalidServerResponse, bidRequest); + const result = spec.interpretResponse(invalidServerResponse, bidRequest); expect(result.length).to.equal(0); }); it('handles nobid responses', () => { - let nobidResponse = {}; + const nobidResponse = {}; nobidResponse.body = { seatbid: [ { @@ -315,7 +315,7 @@ describe('lkqdBidAdapter', () => { ] }; - let result = spec.interpretResponse(nobidResponse, bidRequest); + const result = spec.interpretResponse(nobidResponse, bidRequest); expect(result.length).to.equal(0); }); }); diff --git a/test/spec/modules/lmpIdSystem_spec.js b/test/spec/modules/lmpIdSystem_spec.js index 4758d943f6c..cf525121fad 100644 --- a/test/spec/modules/lmpIdSystem_spec.js +++ b/test/spec/modules/lmpIdSystem_spec.js @@ -1,35 +1,5 @@ -import { expect } from 'chai'; -import { config } from 'src/config.js'; -import {init, startAuctionHook, setSubmoduleRegistry, resetUserIds} from 'modules/userId/index.js'; -import { storage, lmpIdSubmodule } from 'modules/lmpIdSystem.js'; -import { mockGdprConsent } from '../../helpers/consentData.js'; -import 'src/prebid.js'; - -function getConfigMock() { - return { - userSync: { - syncDelay: 0, - userIds: [{ - name: 'lmpid' - }] - } - } -} - -function getAdUnitMock(code = 'adUnit-code') { - return { - code, - mediaTypes: { banner: {}, native: {} }, - sizes: [ - [300, 200], - [300, 600] - ], - bids: [{ - bidder: 'sampleBidder', - params: { placementId: 'banner-only-bidder' } - }] - }; -} +import {expect} from 'chai'; +import {lmpIdSubmodule, storage} from 'modules/lmpIdSystem.js'; describe('LMPID System', () => { let getDataFromLocalStorageStub, localStorageIsEnabledStub; @@ -81,51 +51,4 @@ describe('LMPID System', () => { expect(lmpIdSubmodule.decode('lmpid')).to.deep.equal({ lmpid: 'lmpid' }); }); }); - - describe('LMPID: requestBids hook', () => { - let adUnits; - let sandbox; - - beforeEach(() => { - sandbox = sinon.createSandbox(); - mockGdprConsent(sandbox); - adUnits = [getAdUnitMock()]; - init(config); - setSubmoduleRegistry([lmpIdSubmodule]); - getDataFromLocalStorageStub.withArgs('__lmpid').returns('stored-lmpid'); - localStorageIsEnabledStub.returns(true); - config.setConfig(getConfigMock()); - }); - - afterEach(() => { - sandbox.restore(); - config.resetConfig(); - }); - - after(() => { - init(config); - }) - - after(() => { - resetUserIds(); - }) - - it('when a stored LMPID exists it is added to bids', (done) => { - startAuctionHook(() => { - adUnits.forEach(unit => { - unit.bids.forEach(bid => { - const lmpidAsEid = bid.userIdAsEids.find(e => e.source == 'loblawmedia.ca'); - expect(lmpidAsEid).to.deep.equal({ - source: 'loblawmedia.ca', - uids: [{ - id: 'stored-lmpid', - atype: 3, - }] - }); - }); - }); - done(); - }, { adUnits }); - }); - }); }); diff --git a/test/spec/modules/lockerdomeBidAdapter_spec.js b/test/spec/modules/lockerdomeBidAdapter_spec.js index ffbeb1c9340..988d16ecac1 100644 --- a/test/spec/modules/lockerdomeBidAdapter_spec.js +++ b/test/spec/modules/lockerdomeBidAdapter_spec.js @@ -75,7 +75,7 @@ describe('LockerDomeAdapter', function () { expect(spec.isBidRequestValid(bidRequests[1])).to.be.true; }); it('should return false if the adUnitId parameter is not present', function () { - let bidRequest = utils.deepClone(bidRequests[0]); + const bidRequest = utils.deepClone(bidRequests[0]); delete bidRequest.params.adUnitId; expect(spec.isBidRequestValid(bidRequest)).to.be.false; }); diff --git a/test/spec/modules/loganBidAdapter_spec.js b/test/spec/modules/loganBidAdapter_spec.js index f51f22580e2..8b343761a46 100644 --- a/test/spec/modules/loganBidAdapter_spec.js +++ b/test/spec/modules/loganBidAdapter_spec.js @@ -47,7 +47,7 @@ describe('LoganBidAdapter', function () { expect(serverRequest.url).to.equal('https://USeast2.logan.ai/pbjs'); }); it('Returns valid data if array of bids is valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys('deviceWidth', 'deviceHeight', 'language', 'secure', 'host', 'page', 'placements'); expect(data.deviceWidth).to.be.a('number'); @@ -58,7 +58,7 @@ describe('LoganBidAdapter', function () { expect(data.page).to.be.a('string'); expect(data.gdpr).to.not.exist; expect(data.ccpa).to.not.exist; - let placement = data['placements'][0]; + const placement = data['placements'][0]; expect(placement).to.have.keys('placementId', 'bidId', 'adFormat', 'sizes', 'schain', 'bidfloor'); expect(placement.placementId).to.equal(783); expect(placement.bidId).to.equal('23fhj33i987f'); @@ -75,9 +75,9 @@ describe('LoganBidAdapter', function () { playerSize }; serverRequest = spec.buildRequests([bid], bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); - let placement = data['placements'][0]; + const placement = data['placements'][0]; expect(placement).to.be.an('object'); expect(placement).to.have.keys('placementId', 'bidId', 'adFormat', 'wPlayer', 'hPlayer', 'schain', 'minduration', 'maxduration', 'mimes', 'protocols', 'startdelay', 'placement', 'plcmt', 'skip', 'skipafter', 'minbitrate', 'maxbitrate', 'delivery', 'playbackmethod', 'api', 'linearity', 'bidfloor'); expect(placement.adFormat).to.equal(VIDEO); @@ -103,9 +103,9 @@ describe('LoganBidAdapter', function () { bid.mediaTypes = {}; bid.mediaTypes[NATIVE] = native; serverRequest = spec.buildRequests([bid], bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); - let placement = data['placements'][0]; + const placement = data['placements'][0]; expect(placement).to.be.an('object'); expect(placement).to.have.keys('placementId', 'bidId', 'adFormat', 'native', 'schain', 'bidfloor'); expect(placement.adFormat).to.equal(NATIVE); @@ -116,7 +116,7 @@ describe('LoganBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { bidderRequest.gdprConsent = 'test'; serverRequest = spec.buildRequests([bid], bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('string'); expect(data.gdpr).to.equal(bidderRequest.gdprConsent); @@ -127,7 +127,7 @@ describe('LoganBidAdapter', function () { it('Returns data with uspConsent and without gdprConsent', function () { bidderRequest.uspConsent = 'test'; serverRequest = spec.buildRequests([bid], bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -136,7 +136,7 @@ describe('LoganBidAdapter', function () { it('Returns empty data if no valid requests are passed', function () { serverRequest = spec.buildRequests([]); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.placements).to.be.an('array').that.is.empty; }); }); @@ -158,9 +158,9 @@ describe('LoganBidAdapter', function () { meta: {} }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -190,10 +190,10 @@ describe('LoganBidAdapter', function () { meta: {} }] }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'vastUrl', 'vastXml', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -225,10 +225,10 @@ describe('LoganBidAdapter', function () { meta: {} }] }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys('requestId', 'cpm', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'native', 'meta'); expect(dataItem.native).to.have.keys('clickUrl', 'impressionTrackers', 'title', 'image') expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -259,7 +259,7 @@ describe('LoganBidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -275,7 +275,7 @@ describe('LoganBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -292,7 +292,7 @@ describe('LoganBidAdapter', function () { currency: 'USD', }] }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -305,7 +305,7 @@ describe('LoganBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/logicadBidAdapter_spec.js b/test/spec/modules/logicadBidAdapter_spec.js index 6aeb97af9e3..24cc1faae62 100644 --- a/test/spec/modules/logicadBidAdapter_spec.js +++ b/test/spec/modules/logicadBidAdapter_spec.js @@ -313,13 +313,13 @@ describe('LogicadAdapter', function () { }); it('should return false if the tid parameter is not present', function () { - let bidRequest = utils.deepClone(bidRequests[0]); + const bidRequest = utils.deepClone(bidRequests[0]); delete bidRequest.params.tid; expect(spec.isBidRequestValid(bidRequest)).to.be.false; }); it('should return false if the params object is not present', function () { - let bidRequest = utils.deepClone(bidRequests); + const bidRequest = utils.deepClone(bidRequests); delete bidRequest[0].params; expect(spec.isBidRequestValid(bidRequest)).to.be.false; }); diff --git a/test/spec/modules/lotamePanoramaIdSystem_spec.js b/test/spec/modules/lotamePanoramaIdSystem_spec.js index 0fa90cc6278..12dd02ee223 100644 --- a/test/spec/modules/lotamePanoramaIdSystem_spec.js +++ b/test/spec/modules/lotamePanoramaIdSystem_spec.js @@ -51,10 +51,10 @@ describe('LotameId', function() { describe('caching initial data received from the remote server', function () { let request; - let callBackSpy = sinon.spy(); + const callBackSpy = sinon.spy(); beforeEach(function() { - let submoduleCallback = lotamePanoramaIdSubmodule.getId({}).callback; + const submoduleCallback = lotamePanoramaIdSubmodule.getId({}).callback; submoduleCallback(callBackSpy); request = server.requests[0]; @@ -118,10 +118,10 @@ describe('LotameId', function() { describe('No stored values', function() { describe('and receives the profile id but no panorama id', function() { let request; - let callBackSpy = sinon.spy(); + const callBackSpy = sinon.spy(); beforeEach(function() { - let submoduleCallback = lotamePanoramaIdSubmodule.getId({}).callback; + const submoduleCallback = lotamePanoramaIdSubmodule.getId({}).callback; submoduleCallback(callBackSpy); request = server.requests[0]; @@ -182,10 +182,10 @@ describe('LotameId', function() { describe('and receives both the profile id and the panorama id', function () { let request; - let callBackSpy = sinon.spy(); + const callBackSpy = sinon.spy(); beforeEach(function () { - let submoduleCallback = lotamePanoramaIdSubmodule.getId({}).callback; + const submoduleCallback = lotamePanoramaIdSubmodule.getId({}).callback; submoduleCallback(callBackSpy); request = server.requests[0]; @@ -265,7 +265,7 @@ describe('LotameId', function() { describe('and can try again', function () { let request; - let callBackSpy = sinon.spy(); + const callBackSpy = sinon.spy(); beforeEach(function () { getCookieStub.withArgs('panoramaId_expiry').returns('1000'); @@ -275,7 +275,7 @@ describe('LotameId', function() { 'ca22992567e3cd4d116a5899b88a55d0d857a23610db939ae6ac13ba2335d87d' ); - let submoduleCallback = lotamePanoramaIdSubmodule.getId({}).callback; + const submoduleCallback = lotamePanoramaIdSubmodule.getId({}).callback; submoduleCallback(callBackSpy); request = server.requests[0]; @@ -299,7 +299,7 @@ describe('LotameId', function() { describe('receives an optout request', function () { let request; - let callBackSpy = sinon.spy(); + const callBackSpy = sinon.spy(); beforeEach(function () { getCookieStub.withArgs('panoramaId_expiry').returns('1000'); @@ -309,7 +309,7 @@ describe('LotameId', function() { 'ca22992567e3cd4d116a5899b88a55d0d857a23610db939ae6ac13ba2335d87d' ); - let submoduleCallback = lotamePanoramaIdSubmodule.getId({}).callback; + const submoduleCallback = lotamePanoramaIdSubmodule.getId({}).callback; submoduleCallback(callBackSpy); request = server.requests[0]; @@ -381,14 +381,14 @@ describe('LotameId', function() { describe('and can try again', function () { let request; - let callBackSpy = sinon.spy(); + const callBackSpy = sinon.spy(); beforeEach(function () { getLocalStorageStub .withArgs('panoramaId_expiry') .returns('1000'); - let submoduleCallback = lotamePanoramaIdSubmodule.getId({}).callback; + const submoduleCallback = lotamePanoramaIdSubmodule.getId({}).callback; submoduleCallback(callBackSpy); request = server.requests[0]; @@ -413,10 +413,10 @@ describe('LotameId', function() { describe('when gdpr applies', function () { let request; - let callBackSpy = sinon.spy(); + const callBackSpy = sinon.spy(); beforeEach(function () { - let submoduleCallback = lotamePanoramaIdSubmodule.getId({}, { + const submoduleCallback = lotamePanoramaIdSubmodule.getId({}, { gdpr: { gdprApplies: true, consentString: 'consentGiven' @@ -451,8 +451,8 @@ describe('LotameId', function() { describe('when gdpr applies but no consent string is available', function () { let request; - let callBackSpy = sinon.spy(); - let consentData = { + const callBackSpy = sinon.spy(); + const consentData = { gdpr: { gdprApplies: true, consentString: undefined @@ -460,7 +460,7 @@ describe('LotameId', function() { }; beforeEach(function () { - let submoduleCallback = lotamePanoramaIdSubmodule.getId({}, consentData).callback; + const submoduleCallback = lotamePanoramaIdSubmodule.getId({}, consentData).callback; submoduleCallback(callBackSpy); // the contents of the response don't matter for this @@ -481,11 +481,11 @@ describe('LotameId', function() { describe('when no consentData and no cookies', function () { let request; - let callBackSpy = sinon.spy(); + const callBackSpy = sinon.spy(); let consentData; beforeEach(function () { - let submoduleCallback = lotamePanoramaIdSubmodule.getId({}, consentData).callback; + const submoduleCallback = lotamePanoramaIdSubmodule.getId({}, consentData).callback; submoduleCallback(callBackSpy); // the contents of the response don't matter for this @@ -504,10 +504,10 @@ describe('LotameId', function() { describe('with an empty cache, ignore profile id for error 111', function () { let request; - let callBackSpy = sinon.spy(); + const callBackSpy = sinon.spy(); beforeEach(function () { - let submoduleCallback = lotamePanoramaIdSubmodule.getId({}).callback; + const submoduleCallback = lotamePanoramaIdSubmodule.getId({}).callback; submoduleCallback(callBackSpy); request = server.requests[0]; @@ -561,7 +561,7 @@ describe('LotameId', function() { describe('receives an optout request with an error 111', function () { let request; - let callBackSpy = sinon.spy(); + const callBackSpy = sinon.spy(); beforeEach(function () { getCookieStub.withArgs('panoramaId_expiry').returns('1000'); @@ -571,7 +571,7 @@ describe('LotameId', function() { 'ca22992567e3cd4d116a5899b88a55d0d857a23610db939ae6ac13ba2335d87d' ); - let submoduleCallback = lotamePanoramaIdSubmodule.getId({}).callback; + const submoduleCallback = lotamePanoramaIdSubmodule.getId({}).callback; submoduleCallback(callBackSpy); request = server.requests[0]; @@ -684,10 +684,10 @@ describe('LotameId', function() { describe('with no client expiry set', function () { describe('and no existing pano id', function () { let request; - let callBackSpy = sinon.spy(); + const callBackSpy = sinon.spy(); beforeEach(function () { - let submoduleCallback = lotamePanoramaIdSubmodule.getId( + const submoduleCallback = lotamePanoramaIdSubmodule.getId( { params: { clientId: '1234', @@ -767,10 +767,10 @@ describe('LotameId', function() { }); describe('when client consent has errors', function () { let request; - let callBackSpy = sinon.spy(); + const callBackSpy = sinon.spy(); beforeEach(function () { - let submoduleCallback = lotamePanoramaIdSubmodule.getId( + const submoduleCallback = lotamePanoramaIdSubmodule.getId( { params: { clientId: '1234', diff --git a/test/spec/modules/loyalBidAdapter_spec.js b/test/spec/modules/loyalBidAdapter_spec.js index 1c9106e3be8..2ba06c69835 100644 --- a/test/spec/modules/loyalBidAdapter_spec.js +++ b/test/spec/modules/loyalBidAdapter_spec.js @@ -132,7 +132,7 @@ describe('LoyalBidAdapter', function () { }); it('Returns general data valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys('deviceWidth', 'deviceHeight', @@ -212,7 +212,7 @@ describe('LoyalBidAdapter', function () { } ]; - let serverRequest = spec.buildRequests(bids, bidderRequest); + const serverRequest = spec.buildRequests(bids, bidderRequest); const { placements } = serverRequest.data; for (let i = 0, len = placements.length; i < len; i++) { @@ -247,7 +247,7 @@ describe('LoyalBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { delete bidderRequest.uspConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('object'); expect(data.gdpr).to.have.property('consentString'); @@ -261,7 +261,7 @@ describe('LoyalBidAdapter', function () { bidderRequest.uspConsent = '1---'; delete bidderRequest.gdprConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -276,8 +276,8 @@ describe('LoyalBidAdapter', function () { applicableSections: [8] }; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -291,8 +291,8 @@ describe('LoyalBidAdapter', function () { bidderRequest.ortb2.regs.gpp = 'abc123'; bidderRequest.ortb2.regs.gpp_sid = [8]; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -322,9 +322,9 @@ describe('LoyalBidAdapter', function () { } }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(banner.body[0].requestId); @@ -356,10 +356,10 @@ describe('LoyalBidAdapter', function () { } }] }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -393,10 +393,10 @@ describe('LoyalBidAdapter', function () { } }] }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys('requestId', 'cpm', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'native', 'meta'); expect(dataItem.native).to.have.keys('clickUrl', 'impressionTrackers', 'title', 'image') expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -427,7 +427,7 @@ describe('LoyalBidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -443,7 +443,7 @@ describe('LoyalBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -460,7 +460,7 @@ describe('LoyalBidAdapter', function () { currency: 'USD', }] }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -473,7 +473,7 @@ describe('LoyalBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/lunamediahbBidAdapter_spec.js b/test/spec/modules/lunamediahbBidAdapter_spec.js index b715fb0d0c3..8ef3b813803 100644 --- a/test/spec/modules/lunamediahbBidAdapter_spec.js +++ b/test/spec/modules/lunamediahbBidAdapter_spec.js @@ -132,7 +132,7 @@ describe('LunamediaHBBidAdapter', function () { }); it('Returns general data valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys('deviceWidth', 'deviceHeight', @@ -198,7 +198,7 @@ describe('LunamediaHBBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { delete bidderRequest.uspConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('object'); expect(data.gdpr).to.have.property('consentString'); @@ -212,7 +212,7 @@ describe('LunamediaHBBidAdapter', function () { bidderRequest.uspConsent = '1---'; delete bidderRequest.gdprConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -227,8 +227,8 @@ describe('LunamediaHBBidAdapter', function () { applicableSections: [8] }; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -242,8 +242,8 @@ describe('LunamediaHBBidAdapter', function () { bidderRequest.ortb2.regs.gpp = 'abc123'; bidderRequest.ortb2.regs.gpp_sid = [8]; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -273,9 +273,9 @@ describe('LunamediaHBBidAdapter', function () { } }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(banner.body[0].requestId); @@ -307,10 +307,10 @@ describe('LunamediaHBBidAdapter', function () { } }] }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -344,10 +344,10 @@ describe('LunamediaHBBidAdapter', function () { } }] }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys('requestId', 'cpm', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'native', 'meta'); expect(dataItem.native).to.have.keys('clickUrl', 'impressionTrackers', 'title', 'image') expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -378,7 +378,7 @@ describe('LunamediaHBBidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -394,7 +394,7 @@ describe('LunamediaHBBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -411,7 +411,7 @@ describe('LunamediaHBBidAdapter', function () { currency: 'USD', }] }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -424,7 +424,7 @@ describe('LunamediaHBBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/madvertiseBidAdapter_spec.js b/test/spec/modules/madvertiseBidAdapter_spec.js index 8128bcc2d42..966d5113105 100644 --- a/test/spec/modules/madvertiseBidAdapter_spec.js +++ b/test/spec/modules/madvertiseBidAdapter_spec.js @@ -6,7 +6,7 @@ import {spec} from 'modules/madvertiseBidAdapter'; describe('madvertise adapater', () => { describe('Test validate req', () => { it('should accept minimum valid bid', () => { - let bid = { + const bid = { bidder: 'madvertise', sizes: [[728, 90]], params: { @@ -18,7 +18,7 @@ describe('madvertise adapater', () => { expect(isValid).to.equal(false); }); it('should reject no sizes', () => { - let bid = { + const bid = { bidder: 'madvertise', params: { zoneId: 'test' @@ -29,7 +29,7 @@ describe('madvertise adapater', () => { expect(isValid).to.equal(false); }); it('should reject empty sizes', () => { - let bid = { + const bid = { bidder: 'madvertise', sizes: [], params: { @@ -41,7 +41,7 @@ describe('madvertise adapater', () => { expect(isValid).to.equal(false); }); it('should reject wrong format sizes', () => { - let bid = { + const bid = { bidder: 'madvertise', sizes: [['728x90']], params: { @@ -52,7 +52,7 @@ describe('madvertise adapater', () => { expect(isValid).to.equal(false); }); it('should reject no params', () => { - let bid = { + const bid = { bidder: 'madvertise', sizes: [[728, 90]] }; @@ -61,7 +61,7 @@ describe('madvertise adapater', () => { expect(isValid).to.equal(false); }); it('should reject missing s', () => { - let bid = { + const bid = { bidder: 'madvertise', params: {} }; @@ -73,7 +73,7 @@ describe('madvertise adapater', () => { describe('Test build request', () => { beforeEach(function () { - let mockConfig = { + const mockConfig = { consentManagement: { cmpApi: 'IAB', timeout: 1111, @@ -88,7 +88,7 @@ describe('madvertise adapater', () => { afterEach(function () { config.getConfig.restore(); }); - let bid = [{ + const bid = [{ bidder: 'madvertise', sizes: [[728, 90], [300, 100]], bidId: '51ef8751f9aead', @@ -101,7 +101,7 @@ describe('madvertise adapater', () => { } }]; it('minimum request with gdpr consent', () => { - let bidderRequest = { + const bidderRequest = { gdprConsent: { consentString: 'CO_5mtSPHOmEIAsAkBFRBOCsAP_AAH_AAAqIHQgB7SrERyNAYWB5gusAKYlfQAQCA2AABAYdASgJQQBAMJYEkGAIuAnAACAKAAAEIHQAAAAlCCmABAEAAIABBSGMAQgABZAAIiAEEAATAABACAABGYCSCAIQjIAAAAEAgEKEAAoAQGBAAAEgBABAAAogACADAgXmACIKkQBAkBAYAkAYQAogAhAAAAAIAAAAAAAKAABAAAghAAQQAAAAAAAAAgAAAAABAAAAAAAAQAAAAAAAAABAAgAAAAAAAAAIAAAAAAAAAAAAAAAABAAAAAAAAAAAQCAKCgBgEQALgAqkJADAIgAXABVIaACAAERABAACKgAgABA', vendorData: {}, @@ -123,7 +123,7 @@ describe('madvertise adapater', () => { }); it('minimum request without gdpr consent', () => { - let bidderRequest = {}; + const bidderRequest = {}; const req = spec.buildRequests(bid, bidderRequest); expect(req).to.exist.and.to.be.a('array'); @@ -141,7 +141,7 @@ describe('madvertise adapater', () => { describe('Test interpret response', () => { it('General banner response', () => { - let bid = { + const bid = { bidder: 'madvertise', sizes: [[728, 90]], bidId: '51ef8751f9aead', @@ -155,7 +155,7 @@ describe('madvertise adapater', () => { age: 25, } }; - let resp = spec.interpretResponse({body: { + const resp = spec.interpretResponse({body: { requestId: 'REQUEST_ID', cpm: 1, ad: '

I am an ad

', @@ -183,7 +183,7 @@ describe('madvertise adapater', () => { // expect(resp[0].adomain).to.deep.equal(['madvertise.com']); }); it('No response', () => { - let bid = { + const bid = { bidder: 'madvertise', sizes: [[728, 90]], bidId: '51ef8751f9aead', @@ -197,7 +197,7 @@ describe('madvertise adapater', () => { age: 25, } }; - let resp = spec.interpretResponse({body: null}, {bidId: bid.bidId}); + const resp = spec.interpretResponse({body: null}, {bidId: bid.bidId}); expect(resp).to.exist.and.to.be.a('array').that.is.empty; }); diff --git a/test/spec/modules/magniteAnalyticsAdapter_spec.js b/test/spec/modules/magniteAnalyticsAdapter_spec.js index b58b73cb8c9..90b9859fc84 100644 --- a/test/spec/modules/magniteAnalyticsAdapter_spec.js +++ b/test/spec/modules/magniteAnalyticsAdapter_spec.js @@ -13,8 +13,8 @@ import * as mockGpt from '../integration/faker/googletag.js'; import { getGlobal } from '../../../src/prebidGlobal.js'; import { deepAccess } from '../../../src/utils.js'; -let events = require('src/events.js'); -let utils = require('src/utils.js'); +const events = require('src/events.js'); +const utils = require('src/utils.js'); const { AUCTION_INIT, @@ -549,11 +549,11 @@ describe('magnite analytics adapter', function () { performStandardAuction(); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.match(/\/\/localhost:9999\/event/); - let message = JSON.parse(request.requestBody); + const message = JSON.parse(request.requestBody); expect(message).to.deep.equal(ANALYTICS_MESSAGE); }); @@ -573,7 +573,7 @@ describe('magnite analytics adapter', function () { events.emit(AUCTION_END, MOCK.AUCTION_END); clock.tick(rubiConf.analyticsBatchTimeout + 1000); - let message = JSON.parse(server.requests[0].requestBody); + const message = JSON.parse(server.requests[0].requestBody); expect(message.auctions[0].bidderOrder).to.deep.equal([ 'rubicon', 'pubmatic', @@ -613,7 +613,7 @@ describe('magnite analytics adapter', function () { expect(server.requests.length).to.equal(3); server.requests.forEach((request, index) => { - let message = JSON.parse(request.requestBody); + const message = JSON.parse(request.requestBody); // should be index of array + 1 expect(message?.auctions?.[0].auctionIndex).to.equal(index + 1); @@ -631,7 +631,7 @@ describe('magnite analytics adapter', function () { events.emit(AUCTION_END, MOCK.AUCTION_END); clock.tick(rubiConf.analyticsBatchTimeout + 1000); - let message = JSON.parse(server.requests[0].requestBody); + const message = JSON.parse(server.requests[0].requestBody); expect(message.auctions[0].adUnits[0].dimensions).to.deep.equal([ { width: 1, @@ -671,7 +671,7 @@ describe('magnite analytics adapter', function () { events.emit(AUCTION_END, MOCK.AUCTION_END); clock.tick(rubiConf.analyticsBatchTimeout + 1000); - let message = JSON.parse(server.requests[0].requestBody); + const message = JSON.parse(server.requests[0].requestBody); expect(message.auctions[0].experiments[0]).to.deep.equal({ name: 'a', rule: 'b', @@ -680,7 +680,7 @@ describe('magnite analytics adapter', function () { }); it('should pass along user ids', function () { - let auctionInit = utils.deepClone(MOCK.AUCTION_INIT); + const auctionInit = utils.deepClone(MOCK.AUCTION_INIT); auctionInit.bidderRequests[0].bids[0].userId = { criteoId: 'sadfe4334', lotamePanoramaId: 'asdf3gf4eg', @@ -695,7 +695,7 @@ describe('magnite analytics adapter', function () { events.emit(AUCTION_END, MOCK.AUCTION_END); clock.tick(rubiConf.analyticsBatchTimeout + 1000); - let message = JSON.parse(server.requests[0].requestBody); + const message = JSON.parse(server.requests[0].requestBody); expect(message.auctions[0].user).to.deep.equal({ ids: [ @@ -719,7 +719,7 @@ describe('magnite analytics adapter', function () { events.emit(AUCTION_INIT, MOCK.AUCTION_INIT); events.emit(BID_REQUESTED, MOCK.BID_REQUESTED); - let bidResponse = utils.deepClone(MOCK.BID_RESPONSE); + const bidResponse = utils.deepClone(MOCK.BID_RESPONSE); bidResponse.meta = { advertiserDomains: test.input } @@ -730,7 +730,7 @@ describe('magnite analytics adapter', function () { events.emit(BID_WON, MOCK.BID_WON); clock.tick(rubiConf.analyticsBatchTimeout + 1000); - let message = JSON.parse(server.requests[0].requestBody); + const message = JSON.parse(server.requests[0].requestBody); expect(message.auctions[0].adUnits[0].bids[0].bidResponse.adomains).to.deep.equal(test.expected); }); @@ -744,7 +744,7 @@ describe('magnite analytics adapter', function () { events.emit(AUCTION_INIT, MOCK.AUCTION_INIT); events.emit(BID_REQUESTED, MOCK.BID_REQUESTED); - let bidResponse = utils.deepClone(MOCK.BID_RESPONSE); + const bidResponse = utils.deepClone(MOCK.BID_RESPONSE); bidResponse.meta = { networkId: test.input }; @@ -755,7 +755,7 @@ describe('magnite analytics adapter', function () { events.emit(BID_WON, MOCK.BID_WON); clock.tick(rubiConf.analyticsBatchTimeout + 1000); - let message = JSON.parse(server.requests[0].requestBody); + const message = JSON.parse(server.requests[0].requestBody); expect(message.auctions[0].adUnits[0].bids[0].bidResponse.networkId).to.equal(test.expected); }); }); @@ -770,7 +770,7 @@ describe('magnite analytics adapter', function () { events.emit(AUCTION_INIT, MOCK.AUCTION_INIT); events.emit(BID_REQUESTED, MOCK.BID_REQUESTED); - let bidResponse = utils.deepClone(MOCK.BID_RESPONSE); + const bidResponse = utils.deepClone(MOCK.BID_RESPONSE); bidResponse.meta = { mediaType: test.input }; @@ -781,7 +781,7 @@ describe('magnite analytics adapter', function () { events.emit(BID_WON, MOCK.BID_WON); clock.tick(rubiConf.analyticsBatchTimeout + 1000); - let message = JSON.parse(server.requests[0].requestBody); + const message = JSON.parse(server.requests[0].requestBody); expect(message.auctions[0].adUnits[0].bids[0].bidResponse.mediaType).to.equal(test.expected); if (test.hasOg) expect(message.auctions[0].adUnits[0].bids[0].bidResponse.ogMediaType).to.equal('banner'); else expect(message.auctions[0].adUnits[0].bids[0].bidResponse).to.not.haveOwnProperty('ogMediaType'); @@ -798,18 +798,18 @@ describe('magnite analytics adapter', function () { it('should not log any session data if local storage is not enabled', function () { localStorageIsEnabledStub.returns(false); - let expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); + const expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); delete expectedMessage.session; delete expectedMessage.fpkvs; performStandardAuction(); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.match(/\/\/localhost:9999\/event/); - let message = JSON.parse(request.requestBody); + const message = JSON.parse(request.requestBody); expect(message).to.deep.equal(expectedMessage); }); @@ -825,10 +825,10 @@ describe('magnite analytics adapter', function () { }); performStandardAuction(); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; - let message = JSON.parse(request.requestBody); + const request = server.requests[0]; + const message = JSON.parse(request.requestBody); - let expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); + const expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); expectedMessage.session.pvid = STUBBED_UUID.slice(0, 8); expectedMessage.fpkvs = [ { key: 'source', value: 'fb' }, @@ -851,10 +851,10 @@ describe('magnite analytics adapter', function () { }); performStandardAuction(); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; - let message = JSON.parse(request.requestBody); + const request = server.requests[0]; + const message = JSON.parse(request.requestBody); - let expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); + const expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); expectedMessage.session.pvid = STUBBED_UUID.slice(0, 8); expectedMessage.fpkvs = [ { key: 'number', value: '24' }, @@ -879,10 +879,10 @@ describe('magnite analytics adapter', function () { }); performStandardAuction(); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; - let message = JSON.parse(request.requestBody); + const request = server.requests[0]; + const message = JSON.parse(request.requestBody); - let expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); + const expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); expectedMessage.session.pvid = STUBBED_UUID.slice(0, 8); expectedMessage.fpkvs = [ { key: 'source', value: 'other' }, @@ -897,7 +897,7 @@ describe('magnite analytics adapter', function () { it('should pick up existing localStorage and use its values', function () { // set some localStorage - let inputlocalStorage = { + const inputlocalStorage = { id: '987654', start: 1519767017881, // 15 mins before "now" expires: 1519767039481, // six hours later @@ -915,10 +915,10 @@ describe('magnite analytics adapter', function () { }); performStandardAuction(); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; - let message = JSON.parse(request.requestBody); + const request = server.requests[0]; + const message = JSON.parse(request.requestBody); - let expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); + const expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); expectedMessage.session = { id: '987654', start: 1519767017881, @@ -952,7 +952,7 @@ describe('magnite analytics adapter', function () { sandbox.stub(utils, 'getWindowLocation').returns({ 'search': '?utm_source=fb&utm_click=dog' }); // set some localStorage - let inputlocalStorage = { + const inputlocalStorage = { id: '987654', start: 1519766113781, // 15 mins before "now" expires: 1519787713781, // six hours later @@ -970,10 +970,10 @@ describe('magnite analytics adapter', function () { }); performStandardAuction(); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; - let message = JSON.parse(request.requestBody); + const request = server.requests[0]; + const message = JSON.parse(request.requestBody); - let expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); + const expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); expectedMessage.session = { id: '987654', start: 1519766113781, @@ -1010,7 +1010,7 @@ describe('magnite analytics adapter', function () { it('should throw out session if lastSeen > 30 mins ago and create new one', function () { // set some localStorage - let inputlocalStorage = { + const inputlocalStorage = { id: '987654', start: 1519764313781, // 45 mins before "now" expires: 1519785913781, // six hours later @@ -1029,10 +1029,10 @@ describe('magnite analytics adapter', function () { performStandardAuction(); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; - let message = JSON.parse(request.requestBody); + const request = server.requests[0]; + const message = JSON.parse(request.requestBody); - let expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); + const expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); // session should match what is already in ANALYTICS_MESSAGE, just need to add pvid expectedMessage.session.pvid = expectedPvid; @@ -1061,7 +1061,7 @@ describe('magnite analytics adapter', function () { it('should throw out session if past expires time and create new one', function () { // set some localStorage - let inputlocalStorage = { + const inputlocalStorage = { id: '987654', start: 1519745353781, // 6 hours before "expires" expires: 1519766953781, // little more than six hours ago @@ -1080,10 +1080,10 @@ describe('magnite analytics adapter', function () { performStandardAuction(); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; - let message = JSON.parse(request.requestBody); + const request = server.requests[0]; + const message = JSON.parse(request.requestBody); - let expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); + const expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); // session should match what is already in ANALYTICS_MESSAGE, just need to add pvid expectedMessage.session.pvid = expectedPvid; @@ -1114,24 +1114,24 @@ describe('magnite analytics adapter', function () { it('should send gam data if adunit has elementid ortb2 fields', function () { // update auction init mock to have the elementids in the adunit // and change adUnitCode to be hashes - let auctionInit = utils.deepClone(MOCK.AUCTION_INIT); + const auctionInit = utils.deepClone(MOCK.AUCTION_INIT); auctionInit.adUnits[0].ortb2Imp.ext.data.elementid = [gptSlot0.getSlotElementId()]; auctionInit.adUnits[0].code = '1a2b3c4d'; // bid request - let bidRequested = utils.deepClone(MOCK.BID_REQUESTED); + const bidRequested = utils.deepClone(MOCK.BID_REQUESTED); bidRequested.bids[0].adUnitCode = '1a2b3c4d'; // bid response - let bidResponse = utils.deepClone(MOCK.BID_RESPONSE); + const bidResponse = utils.deepClone(MOCK.BID_RESPONSE); bidResponse.adUnitCode = '1a2b3c4d'; // bidder done - let bidderDone = utils.deepClone(MOCK.BIDDER_DONE); + const bidderDone = utils.deepClone(MOCK.BIDDER_DONE); bidderDone.bids[0].adUnitCode = '1a2b3c4d'; // bidder done - let bidWon = utils.deepClone(MOCK.BID_WON); + const bidWon = utils.deepClone(MOCK.BID_WON); bidWon.adUnitCode = '1a2b3c4d'; // Run auction @@ -1150,9 +1150,9 @@ describe('magnite analytics adapter', function () { clock.tick(rubiConf.analyticsEventDelay + rubiConf.analyticsProcessDelay); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; - let message = JSON.parse(request.requestBody); - let expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); + const request = server.requests[0]; + const message = JSON.parse(request.requestBody); + const expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); // new adUnitCodes in payload expectedMessage.auctions[0].adUnits[0].adUnitCode = '1a2b3c4d'; @@ -1175,11 +1175,11 @@ describe('magnite analytics adapter', function () { clock.tick(2000); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; - let message = JSON.parse(request.requestBody); + const request = server.requests[0]; + const message = JSON.parse(request.requestBody); // The timestamps should be changed from the default by (set eventDelay (2000) - eventDelay default (500)) - let expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); + const expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); expectedMessage.timestamps.eventTime = expectedMessage.timestamps.eventTime + 1500; expectedMessage.timestamps.timeSincePageLoad = expectedMessage.timestamps.timeSincePageLoad + 1500; @@ -1189,7 +1189,7 @@ describe('magnite analytics adapter', function () { ['seatBidId', 'pbsBidId'].forEach(pbsParam => { it(`should overwrite prebid bidId with incoming PBS ${pbsParam}`, function () { // bid response - let seatBidResponse = utils.deepClone(MOCK.BID_RESPONSE); + const seatBidResponse = utils.deepClone(MOCK.BID_RESPONSE); seatBidResponse[pbsParam] = 'abc-123-do-re-me'; // Run auction @@ -1208,9 +1208,9 @@ describe('magnite analytics adapter', function () { clock.tick(rubiConf.analyticsEventDelay + rubiConf.analyticsProcessDelay); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; - let message = JSON.parse(request.requestBody); - let expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); + const request = server.requests[0]; + const message = JSON.parse(request.requestBody); + const expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); // new adUnitCodes in payload expectedMessage.auctions[0].adUnits[0].bids[0].bidId = 'abc-123-do-re-me'; @@ -1222,7 +1222,7 @@ describe('magnite analytics adapter', function () { it('should not use pbsBidId if the bid was client side cached', function () { // bid response - let seatBidResponse = utils.deepClone(MOCK.BID_RESPONSE); + const seatBidResponse = utils.deepClone(MOCK.BID_RESPONSE); seatBidResponse.pbsBidId = 'do-not-use-me'; // Run auction @@ -1245,8 +1245,8 @@ describe('magnite analytics adapter', function () { clock.tick(rubiConf.analyticsEventDelay + rubiConf.analyticsProcessDelay); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; - let message = JSON.parse(request.requestBody); + const request = server.requests[0]; + const message = JSON.parse(request.requestBody); // Expect the ids sent to server to use the original bidId not the pbsBidId thing expect(message.auctions[0].adUnits[0].bids[0].bidId).to.equal(MOCK.BID_RESPONSE.requestId); @@ -1256,7 +1256,7 @@ describe('magnite analytics adapter', function () { [0, '0'].forEach(pbsParam => { it(`should generate new bidId if incoming pbsBidId is ${pbsParam}`, function () { // bid response - let seatBidResponse = utils.deepClone(MOCK.BID_RESPONSE); + const seatBidResponse = utils.deepClone(MOCK.BID_RESPONSE); seatBidResponse.pbsBidId = pbsParam; // Run auction @@ -1275,9 +1275,9 @@ describe('magnite analytics adapter', function () { clock.tick(rubiConf.analyticsEventDelay + rubiConf.analyticsProcessDelay); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; - let message = JSON.parse(request.requestBody); - let expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); + const request = server.requests[0]; + const message = JSON.parse(request.requestBody); + const expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); // new adUnitCodes in payload expectedMessage.auctions[0].adUnits[0].bids[0].bidId = STUBBED_UUID; @@ -1311,9 +1311,9 @@ describe('magnite analytics adapter', function () { clock.tick(rubiConf.analyticsEventDelay + rubiConf.analyticsProcessDelay); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; - let message = JSON.parse(request.requestBody); - let expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); + const request = server.requests[0]; + const message = JSON.parse(request.requestBody); + const expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); // highest cpm in payload expectedMessage.auctions[0].adUnits[0].bids[0].bidResponse.bidPriceUSD = 5.5; @@ -1334,7 +1334,7 @@ describe('magnite analytics adapter', function () { expect(server.requests.length).to.equal(2); // first is normal analytics event without bidWon - let expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); + const expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); delete expectedMessage.bidsWon; let message = JSON.parse(server.requests[0].requestBody); @@ -1343,7 +1343,7 @@ describe('magnite analytics adapter', function () { // second is just a bidWon (remove gam and auction event) message = JSON.parse(server.requests[1].requestBody); - let expectedMessage2 = utils.deepClone(ANALYTICS_MESSAGE); + const expectedMessage2 = utils.deepClone(ANALYTICS_MESSAGE); delete expectedMessage2.auctions; delete expectedMessage2.gamRenders; @@ -1372,7 +1372,7 @@ describe('magnite analytics adapter', function () { expect(server.requests.length).to.equal(2); // first is normal analytics event without bidWon or gam - let expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); + const expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); delete expectedMessage.bidsWon; delete expectedMessage.gamRenders; @@ -1390,7 +1390,7 @@ describe('magnite analytics adapter', function () { // second is gam and bid won message = JSON.parse(server.requests[1].requestBody); - let expectedMessage2 = utils.deepClone(ANALYTICS_MESSAGE); + const expectedMessage2 = utils.deepClone(ANALYTICS_MESSAGE); // second event should be event delay time after first one expectedMessage2.timestamps.eventTime = expectedMessage.timestamps.eventTime + rubiConf.analyticsEventDelay; expectedMessage2.timestamps.timeSincePageLoad = expectedMessage.timestamps.timeSincePageLoad + rubiConf.analyticsEventDelay; @@ -1418,7 +1418,7 @@ describe('magnite analytics adapter', function () { expect(server.requests.length).to.equal(3); // grab expected 3 requests from default message - let { auctions, gamRenders, bidsWon, ...rest } = utils.deepClone(ANALYTICS_MESSAGE); + const { auctions, gamRenders, bidsWon, ...rest } = utils.deepClone(ANALYTICS_MESSAGE); // rest of payload should have timestamps changed to be - default eventDelay since we changed it to 0 rest.timestamps.eventTime = rest.timestamps.eventTime - defaultDelay; @@ -1430,7 +1430,7 @@ describe('magnite analytics adapter', function () { { expectedMessage: { gamRenders, ...rest }, trigger: 'solo-gam' }, { expectedMessage: { bidsWon, ...rest }, trigger: 'solo-bidWon' }, ].forEach((stuff, requestNum) => { - let message = JSON.parse(server.requests[requestNum].requestBody); + const message = JSON.parse(server.requests[requestNum].requestBody); stuff.expectedMessage.trigger = stuff.trigger; expect(message).to.deep.equal(stuff.expectedMessage); }); @@ -1462,9 +1462,9 @@ describe('magnite analytics adapter', function () { clock.tick(rubiConf.analyticsEventDelay + rubiConf.analyticsProcessDelay); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; - let message = JSON.parse(request.requestBody); - let expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); + const request = server.requests[0]; + const message = JSON.parse(request.requestBody); + const expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); // should see error time out bid expectedMessage.auctions[0].adUnits[0].bids[0].status = 'error'; @@ -1492,7 +1492,7 @@ describe('magnite analytics adapter', function () { ].forEach(test => { it(`should correctly pass ${test.name}`, function () { // bid response - let auctionInit = utils.deepClone(MOCK.AUCTION_INIT); + const auctionInit = utils.deepClone(MOCK.AUCTION_INIT); utils.deepSetValue(auctionInit, test.adUnitPath, test.input); // Run auction @@ -1511,8 +1511,8 @@ describe('magnite analytics adapter', function () { clock.tick(rubiConf.analyticsEventDelay + rubiConf.analyticsProcessDelay); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; - let message = JSON.parse(request.requestBody); + const request = server.requests[0]; + const message = JSON.parse(request.requestBody); // pattern in payload expect(deepAccess(message, test.eventPath)).to.equal(test.input); @@ -1520,7 +1520,7 @@ describe('magnite analytics adapter', function () { }); it('should pass bidderDetail for multibid auctions', function () { - let bidResponse = utils.deepClone(MOCK.BID_RESPONSE); + const bidResponse = utils.deepClone(MOCK.BID_RESPONSE); bidResponse.targetingBidder = 'rubi2'; bidResponse.originalRequestId = bidResponse.requestId; bidResponse.requestId = '1a2b3c4d5e6f7g8h9'; @@ -1535,7 +1535,7 @@ describe('magnite analytics adapter', function () { // emmit gpt events and bidWon mockGpt.emitEvent(gptSlotRenderEnded0.eventName, gptSlotRenderEnded0.params); - let bidWon = utils.deepClone(MOCK.BID_WON); + const bidWon = utils.deepClone(MOCK.BID_WON); bidWon.bidId = bidWon.requestId = '1a2b3c4d5e6f7g8h9'; bidWon.bidderDetail = 'rubi2'; events.emit(BID_WON, bidWon); @@ -1545,9 +1545,9 @@ describe('magnite analytics adapter', function () { expect(server.requests.length).to.equal(1); - let message = JSON.parse(server.requests[0].requestBody); + const message = JSON.parse(server.requests[0].requestBody); - let expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); + const expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); // expect an extra bid added expectedMessage.auctions[0].adUnits[0].bids.push({ @@ -1598,9 +1598,9 @@ describe('magnite analytics adapter', function () { clock.tick(rubiConf.analyticsEventDelay + rubiConf.analyticsProcessDelay); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; - let message = JSON.parse(request.requestBody); - let expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); + const request = server.requests[0]; + const message = JSON.parse(request.requestBody); + const expectedMessage = utils.deepClone(ANALYTICS_MESSAGE); // bid source should be 'server' expectedMessage.auctions[0].adUnits[0].bids[0].source = 'server'; @@ -1630,11 +1630,11 @@ describe('magnite analytics adapter', function () { performStandardAuction(); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.equal('http://localhost:9999/event'); - let message = JSON.parse(request.requestBody); + const message = JSON.parse(request.requestBody); const AnalyticsMessageWithCustomData = { ...ANALYTICS_MESSAGE, @@ -1841,11 +1841,11 @@ describe('magnite analytics adapter', function () { performStandardAuction(); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.match(/\/\/localhost:9999\/event/); - let message = JSON.parse(request.requestBody); + const message = JSON.parse(request.requestBody); expect(message.wrapper).to.deep.equal({ name: '1001_general', family: 'general', @@ -1863,7 +1863,7 @@ describe('magnite analytics adapter', function () { }); const auctionId = MOCK.AUCTION_INIT.auctionId; - let auctionInit = utils.deepClone(MOCK.AUCTION_INIT); + const auctionInit = utils.deepClone(MOCK.AUCTION_INIT); auctionInit.bidderRequests[0].ortb2.device.ext = { cdep: 'treatment' }; // Run auction events.emit(AUCTION_INIT, auctionInit); @@ -1875,8 +1875,8 @@ describe('magnite analytics adapter', function () { events.emit(BID_WON, { ...MOCK.BID_WON, auctionId }); clock.tick(rubiConf.analyticsEventDelay); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; - let message = JSON.parse(request.requestBody); + const request = server.requests[0]; + const message = JSON.parse(request.requestBody); expect(message.wrapper).to.deep.equal({ name: '1001_general', family: 'general', @@ -1893,7 +1893,7 @@ describe('magnite analytics adapter', function () { }); const auctionId = MOCK.AUCTION_INIT.auctionId; - let auctionInit = utils.deepClone(MOCK.AUCTION_INIT); + const auctionInit = utils.deepClone(MOCK.AUCTION_INIT); auctionInit.bidderRequests[0].ortb2.device.ext = { cdep: 'control_2' }; // Run auction events.emit(AUCTION_INIT, auctionInit); @@ -1905,8 +1905,8 @@ describe('magnite analytics adapter', function () { events.emit(BID_WON, { ...MOCK.BID_WON, auctionId }); clock.tick(rubiConf.analyticsEventDelay); expect(server.requests.length).to.equal(1); - let request = server.requests[0]; - let message = JSON.parse(request.requestBody); + const request = server.requests[0]; + const message = JSON.parse(request.requestBody); expect(message.wrapper).to.deep.equal({ family: 'general', name: '1001_general', @@ -2298,7 +2298,7 @@ describe('magnite analytics adapter', function () { events.emit(AUCTION_END, MOCK.AUCTION_END); clock.tick(rubiConf.analyticsBatchTimeout + 1000); - let message = JSON.parse(server.requests[0].requestBody); + const message = JSON.parse(server.requests[0].requestBody); expect(utils.generateUUID.called).to.equal(true); expect(message.auctions[0].adUnits[0].bids[1]).to.deep.equal( @@ -2338,8 +2338,8 @@ describe('magnite analytics adapter', function () { const checkStatusAgainstCode = (status, code, error, index) => { seatnonbid.seatnonbid[0].nonbid[0].status = code; runNonBidAuction(); - let message = JSON.parse(server.requests[index].requestBody); - let bid = message.auctions[0].adUnits[0].bids[1]; + const message = JSON.parse(server.requests[index].requestBody); + const bid = message.auctions[0].adUnits[0].bids[1]; if (error) { expect(bid.error).to.deep.equal(error); @@ -2362,7 +2362,7 @@ describe('magnite analytics adapter', function () { it('adds seatnonbid info to bids array', () => { runNonBidAuction(); - let message = JSON.parse(server.requests[0].requestBody); + const message = JSON.parse(server.requests[0].requestBody); expect(message.auctions[0].adUnits[0].bids[1]).to.deep.equal( { @@ -2431,7 +2431,7 @@ describe('magnite analytics adapter', function () { bidRejectedArgs.rejectionReason = 'Bid does not meet price floor'; runBidRejectedAuction(); - let message = JSON.parse(server.requests[0].requestBody); + const message = JSON.parse(server.requests[0].requestBody); expect(message.auctions[0].adUnits[0].bids[0]).to.deep.equal({ bidder: 'rubicon', @@ -2459,7 +2459,7 @@ describe('magnite analytics adapter', function () { bidRejectedArgs.rejectionReason = 'this bid is rejected'; runBidRejectedAuction(); - let message = JSON.parse(server.requests[0].requestBody); + const message = JSON.parse(server.requests[0].requestBody); expect(message.auctions[0].adUnits[0].bids[0]).to.deep.equal({ bidder: 'rubicon', diff --git a/test/spec/modules/malltvBidAdapter_spec.js b/test/spec/modules/malltvBidAdapter_spec.js index c31e91992f7..2633f3716c3 100644 --- a/test/spec/modules/malltvBidAdapter_spec.js +++ b/test/spec/modules/malltvBidAdapter_spec.js @@ -145,7 +145,7 @@ describe('malltvAdapterTest', () => { it('all keys present', () => { const result = spec.interpretResponse(bidResponse, bidRequest); - let keys = [ + const keys = [ 'requestId', 'cpm', 'width', @@ -161,7 +161,7 @@ describe('malltvAdapterTest', () => { 'meta' ]; - let resultKeys = Object.keys(result[0]); + const resultKeys = Object.keys(result[0]); resultKeys.forEach(function (key) { expect(keys.indexOf(key) !== -1).to.equal(true); }); diff --git a/test/spec/modules/mantisBidAdapter_spec.js b/test/spec/modules/mantisBidAdapter_spec.js index 0f9abe4e734..586a6a49181 100644 --- a/test/spec/modules/mantisBidAdapter_spec.js +++ b/test/spec/modules/mantisBidAdapter_spec.js @@ -17,7 +17,7 @@ describe('MantisAdapter', function () { }); describe('isBidRequestValid', function () { - let bid = { + const bid = { 'bidder': 'mantis', 'params': { 'property': '10433394', @@ -35,7 +35,7 @@ describe('MantisAdapter', function () { }); it('should return false when required params are not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = {}; expect(spec.isBidRequestValid(invalidBid)).to.equal(false); @@ -105,7 +105,7 @@ describe('MantisAdapter', function () { }); describe('buildRequests', function () { - let bidRequests = [ + const bidRequests = [ { 'bidder': 'mantis', 'params': { @@ -199,7 +199,7 @@ describe('MantisAdapter', function () { describe('getUserSyncs', function () { it('iframe', function () { - let result = spec.getUserSyncs({ + const result = spec.getUserSyncs({ iframeEnabled: true }); @@ -208,7 +208,7 @@ describe('MantisAdapter', function () { }); it('pixel', function () { - let result = spec.getUserSyncs({ + const result = spec.getUserSyncs({ pixelEnabled: true }); @@ -219,7 +219,7 @@ describe('MantisAdapter', function () { describe('interpretResponse', function () { it('use ad ttl if provided', function () { - let response = { + const response = { body: { ttl: 360, uuid: 'uuid', @@ -237,7 +237,7 @@ describe('MantisAdapter', function () { } }; - let expectedResponse = [ + const expectedResponse = [ { requestId: 'bid', cpm: 1, @@ -255,12 +255,12 @@ describe('MantisAdapter', function () { ]; let bidderRequest; - let result = spec.interpretResponse(response, {bidderRequest}); + const result = spec.interpretResponse(response, {bidderRequest}); expect(result[0]).to.deep.equal(expectedResponse[0]); }); it('use global ttl if provded', function () { - let response = { + const response = { body: { ttl: 360, uuid: 'uuid', @@ -278,7 +278,7 @@ describe('MantisAdapter', function () { } }; - let expectedResponse = [ + const expectedResponse = [ { requestId: 'bid', cpm: 1, @@ -296,12 +296,12 @@ describe('MantisAdapter', function () { ]; let bidderRequest; - let result = spec.interpretResponse(response, {bidderRequest}); + const result = spec.interpretResponse(response, {bidderRequest}); expect(result[0]).to.deep.equal(expectedResponse[0]); }); it('display ads returned', function () { - let response = { + const response = { body: { uuid: 'uuid', ads: [ @@ -318,7 +318,7 @@ describe('MantisAdapter', function () { } }; - let expectedResponse = [ + const expectedResponse = [ { requestId: 'bid', cpm: 1, @@ -339,7 +339,7 @@ describe('MantisAdapter', function () { sandbox.stub(storage, 'hasLocalStorage').returns(true); const spy = sandbox.spy(storage, 'setDataInLocalStorage'); - let result = spec.interpretResponse(response, {bidderRequest}); + const result = spec.interpretResponse(response, {bidderRequest}); expect(spy.calledWith('mantis:uuid', 'uuid')); expect(result[0]).to.deep.equal(expectedResponse[0]); @@ -347,14 +347,14 @@ describe('MantisAdapter', function () { }); it('no ads returned', function () { - let response = { + const response = { body: { ads: [] } }; let bidderRequest; - let result = spec.interpretResponse(response, {bidderRequest}); + const result = spec.interpretResponse(response, {bidderRequest}); expect(result.length).to.equal(0); }); }); diff --git a/test/spec/modules/mathildeadsBidAdapter_spec.js b/test/spec/modules/mathildeadsBidAdapter_spec.js index eb4318199af..0300860b5ca 100644 --- a/test/spec/modules/mathildeadsBidAdapter_spec.js +++ b/test/spec/modules/mathildeadsBidAdapter_spec.js @@ -132,7 +132,7 @@ describe('MathildeAdsBidAdapter', function () { }); it('Returns general data valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys('deviceWidth', 'deviceHeight', @@ -198,7 +198,7 @@ describe('MathildeAdsBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { delete bidderRequest.uspConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('object'); expect(data.gdpr).to.have.property('consentString'); @@ -212,7 +212,7 @@ describe('MathildeAdsBidAdapter', function () { bidderRequest.uspConsent = '1---'; delete bidderRequest.gdprConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -227,8 +227,8 @@ describe('MathildeAdsBidAdapter', function () { applicableSections: [8] }; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -242,8 +242,8 @@ describe('MathildeAdsBidAdapter', function () { bidderRequest.ortb2.regs.gpp = 'abc123'; bidderRequest.ortb2.regs.gpp_sid = [8]; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -273,9 +273,9 @@ describe('MathildeAdsBidAdapter', function () { } }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(banner.body[0].requestId); @@ -307,10 +307,10 @@ describe('MathildeAdsBidAdapter', function () { } }] }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -344,10 +344,10 @@ describe('MathildeAdsBidAdapter', function () { } }] }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys('requestId', 'cpm', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'native', 'meta'); expect(dataItem.native).to.have.keys('clickUrl', 'impressionTrackers', 'title', 'image') expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -378,7 +378,7 @@ describe('MathildeAdsBidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -394,7 +394,7 @@ describe('MathildeAdsBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -411,7 +411,7 @@ describe('MathildeAdsBidAdapter', function () { currency: 'USD', }] }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -424,7 +424,7 @@ describe('MathildeAdsBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/mediabramaBidAdapter_spec.js b/test/spec/modules/mediabramaBidAdapter_spec.js index d7341e02f17..74c2ac48e5a 100644 --- a/test/spec/modules/mediabramaBidAdapter_spec.js +++ b/test/spec/modules/mediabramaBidAdapter_spec.js @@ -48,7 +48,7 @@ describe('MediaBramaBidAdapter', function () { expect(serverRequest.url).to.equal('https://prebid.mediabrama.com/pbjs'); }); it('Returns valid data if array of bids is valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys('deviceWidth', 'deviceHeight', 'language', 'host', 'page', 'placements'); expect(data.deviceWidth).to.be.a('number'); @@ -58,7 +58,7 @@ describe('MediaBramaBidAdapter', function () { expect(data.page).to.be.a('string'); expect(data.gdpr).to.not.exist; expect(data.ccpa).to.not.exist; - let placement = data['placements'][0]; + const placement = data['placements'][0]; expect(placement).to.have.keys('placementId', 'bidId', 'adFormat', 'sizes', 'schain', 'bidfloor'); expect(placement.placementId).to.equal(24428); expect(placement.bidId).to.equal('23dc19818e5293'); @@ -71,7 +71,7 @@ describe('MediaBramaBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { bidderRequest.gdprConsent = 'test'; serverRequest = spec.buildRequests([bid], bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('string'); expect(data.gdpr).to.equal(bidderRequest.gdprConsent); @@ -82,7 +82,7 @@ describe('MediaBramaBidAdapter', function () { it('Returns data with uspConsent and without gdprConsent', function () { bidderRequest.uspConsent = 'test'; serverRequest = spec.buildRequests([bid], bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -91,7 +91,7 @@ describe('MediaBramaBidAdapter', function () { it('Returns empty data if no valid requests are passed', function () { serverRequest = spec.buildRequests([]); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.placements).to.be.an('array').that.is.empty; }); }); @@ -113,9 +113,9 @@ describe('MediaBramaBidAdapter', function () { meta: {} }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23dc19818e5293'); @@ -144,7 +144,7 @@ describe('MediaBramaBidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -157,7 +157,7 @@ describe('MediaBramaBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/mediaeyesBidAdapter_spec.js b/test/spec/modules/mediaeyesBidAdapter_spec.js index 1872a7c7f04..3df07a66969 100644 --- a/test/spec/modules/mediaeyesBidAdapter_spec.js +++ b/test/spec/modules/mediaeyesBidAdapter_spec.js @@ -57,7 +57,7 @@ describe('mediaeyes adapter', function () { describe('validations', function () { it('isBidValid : itemId is passed', function () { - let bid = { + const bid = { bidder: 'mediaeyes', params: { itemId: 'ec1d7389a4a5afa28a23c4', @@ -67,7 +67,7 @@ describe('mediaeyes adapter', function () { expect(isValid).to.equals(true); }); it('isBidValid : itemId is not passed', function () { - let bid = { + const bid = { bidder: 'mediaeyes', params: { @@ -79,7 +79,7 @@ describe('mediaeyes adapter', function () { }); describe('Validate Request', function () { it('Immutable bid request validate', function () { - let _Request = utils.deepClone(request), + const _Request = utils.deepClone(request), bidRequest = spec.buildRequests(request); expect(request).to.deep.equal(_Request); }); @@ -87,9 +87,9 @@ describe('mediaeyes adapter', function () { describe('responses processing', function () { it('should return fully-initialized banner bid-response', function () { - let bidRequest = spec.buildRequests(request); + const bidRequest = spec.buildRequests(request); - let resp = spec.interpretResponse(bannerResponse, bidRequest[0])[0]; + const resp = spec.interpretResponse(bannerResponse, bidRequest[0])[0]; expect(resp).to.have.property('requestId'); expect(resp).to.have.property('cpm'); expect(resp).to.have.property('width'); @@ -102,7 +102,7 @@ describe('mediaeyes adapter', function () { }); it('no ads returned', function () { - let response = { + const response = { "body": { "id": "0309d787-75cd-4e9d-a430-666fc76c1fbe", "seatbid": [ @@ -114,7 +114,7 @@ describe('mediaeyes adapter', function () { } let bidderRequest; - let result = spec.interpretResponse(response, {bidderRequest}); + const result = spec.interpretResponse(response, {bidderRequest}); expect(result.length).to.equal(0); }); }) @@ -122,7 +122,7 @@ describe('mediaeyes adapter', function () { describe('setting imp.floor using floorModule', function () { let newRequest; let floorModuleTestData; - let getFloor = function (req) { + const getFloor = function (req) { return floorModuleTestData['banner']; }; @@ -140,7 +140,7 @@ describe('mediaeyes adapter', function () { it('params bidfloor undefined', function () { floorModuleTestData.banner.floor = 0; newRequest[0].params.bidFloor = undefined; - let request = spec.buildRequests(newRequest); + const request = spec.buildRequests(newRequest); let data = JSON.parse(request[0].data); data = data.imp[0]; expect(data.bidfloor).to.equal(0); @@ -149,7 +149,7 @@ describe('mediaeyes adapter', function () { it('floormodule if floor is not number', function () { floorModuleTestData.banner.floor = 'INR'; newRequest[0].params.bidFloor = undefined; - let request = spec.buildRequests(newRequest); + const request = spec.buildRequests(newRequest); let data = JSON.parse(request[0].data); data = data.imp[0]; expect(data.bidfloor).to.equal(0); @@ -158,7 +158,7 @@ describe('mediaeyes adapter', function () { it('floormodule if currency is not matched', function () { floorModuleTestData.banner.currency = 'INR'; newRequest[0].params.bidFloor = undefined; - let request = spec.buildRequests(newRequest); + const request = spec.buildRequests(newRequest); let data = JSON.parse(request[0].data); data = data.imp[0]; expect(data.bidfloor).to.equal(1); @@ -166,7 +166,7 @@ describe('mediaeyes adapter', function () { it('bidFloor is not passed, use minimum from floorModule', function () { newRequest[0].params.bidFloor = undefined; - let request = spec.buildRequests(newRequest); + const request = spec.buildRequests(newRequest); let data = JSON.parse(request[0].data); data = data.imp[0]; expect(data.bidfloor).to.equal(1); @@ -174,7 +174,7 @@ describe('mediaeyes adapter', function () { it('if params bidFloor is passed, priority use it', function () { newRequest[0].params.bidFloor = 1; - let request = spec.buildRequests(newRequest); + const request = spec.buildRequests(newRequest); let data = JSON.parse(request[0].data); data = data.imp[0]; expect(data.bidfloor).to.equal(1); diff --git a/test/spec/modules/mediaforceBidAdapter_spec.js b/test/spec/modules/mediaforceBidAdapter_spec.js index 00d43b09ac9..cbacf54087f 100644 --- a/test/spec/modules/mediaforceBidAdapter_spec.js +++ b/test/spec/modules/mediaforceBidAdapter_spec.js @@ -15,7 +15,7 @@ describe('mediaforce bid adapter', function () { }); function getLanguage() { - let language = navigator.language ? 'language' : 'userLanguage'; + const language = navigator.language ? 'language' : 'userLanguage'; return navigator[language].split('-')[0]; } @@ -36,19 +36,19 @@ describe('mediaforce bid adapter', function () { }); it('should return false when params are not passed', function () { - let bid = utils.deepClone(defaultBid); + const bid = utils.deepClone(defaultBid); delete bid.params; assert.equal(spec.isBidRequestValid(bid), false); }); it('should return false when valid params are not passed', function () { - let bid = utils.deepClone(defaultBid); + const bid = utils.deepClone(defaultBid); bid.params = {placement_id: '', publisher_id: ''}; assert.equal(spec.isBidRequestValid(bid), false); }); it('should return true when valid params are passed', function () { - let bid = utils.deepClone(defaultBid); + const bid = utils.deepClone(defaultBid); bid.mediaTypes = { banner: { sizes: [[300, 250]] @@ -239,18 +239,18 @@ describe('mediaforce bid adapter', function () { const bid = utils.deepClone(defaultBid); bid.mediaTypes.audio = { size: [300, 250] }; - let bidRequests = [bid]; - let bidderRequest = { + const bidRequests = [bid]; + const bidderRequest = { bids: bidRequests, refererInfo: refererInfo, timeout: timeout, auctionId: auctionId, }; - let [request] = spec.buildRequests(bidRequests, bidderRequest); - let data = JSON.parse(request.data); + const [request] = spec.buildRequests(bidRequests, bidderRequest); + const data = JSON.parse(request.data); - let expectedDataCopy = utils.deepClone(createExpectedData()); + const expectedDataCopy = utils.deepClone(createExpectedData()); assert.exists(data.id); expectedDataCopy.id = data.id @@ -258,7 +258,7 @@ describe('mediaforce bid adapter', function () { }); it('should return proper request url: no refererInfo', function () { - let [request] = spec.buildRequests([defaultBid]); + const [request] = spec.buildRequests([defaultBid]); assert.equal(request.url, requestUrl); }); @@ -296,22 +296,22 @@ describe('mediaforce bid adapter', function () { }); it('should return proper banner imp', function () { - let bid = utils.deepClone(defaultBid); + const bid = utils.deepClone(defaultBid); bid.params.bidfloor = 0; - let bidRequests = [bid]; - let bidderRequest = { + const bidRequests = [bid]; + const bidderRequest = { bids: bidRequests, refererInfo: refererInfo, timeout: timeout, auctionId: auctionId, }; - let [request] = spec.buildRequests(bidRequests, bidderRequest); + const [request] = spec.buildRequests(bidRequests, bidderRequest); - let data = JSON.parse(request.data); + const data = JSON.parse(request.data); - let expectedDataCopy = utils.deepClone(createExpectedData()); + const expectedDataCopy = utils.deepClone(createExpectedData()); assert.exists(data.id); expectedDataCopy.id = data.id @@ -320,15 +320,15 @@ describe('mediaforce bid adapter', function () { }); it('multiple sizes', function () { - let bid = utils.deepClone(defaultBid); + const bid = utils.deepClone(defaultBid); bid.mediaTypes = { banner: { sizes: [[300, 600], [300, 250]], } }; - let [request] = spec.buildRequests([bid]); - let data = JSON.parse(request.data); + const [request] = spec.buildRequests([bid]); + const data = JSON.parse(request.data); assert.deepEqual(data.imp[0].banner, {w: 300, h: 600, format: [{w: 300, h: 250}]}); }); @@ -342,14 +342,14 @@ describe('mediaforce bid adapter', function () { }); it('should return proper requests for multiple imps', function () { - let bidderRequest = { + const bidderRequest = { bids: multiBid, refererInfo: refererInfo, timeout: timeout, auctionId: auctionId, }; - let requests = spec.buildRequests(multiBid, bidderRequest); + const requests = spec.buildRequests(multiBid, bidderRequest); assert.equal(requests.length, 2); requests.forEach((req) => { req.data = JSON.parse(req.data); @@ -458,7 +458,7 @@ describe('mediaforce bid adapter', function () { }); it('successfull response', function () { - let bid = { + const bid = { price: 3, w: 100, id: '65599d0a-42d2-446a-9d39-6086c1433ffe', @@ -473,7 +473,7 @@ describe('mediaforce bid adapter', function () { adm: `` }; - let response = { + const response = { body: { seatbid: [{ bid: [bid] @@ -483,7 +483,7 @@ describe('mediaforce bid adapter', function () { } }; - let bids = spec.interpretResponse(response); + const bids = spec.interpretResponse(response); assert.deepEqual(bids, ([{ ad: bid.adm, cpm: bid.price, @@ -504,17 +504,17 @@ describe('mediaforce bid adapter', function () { describe('interpretResponse() native as object', function () { it('successfull response', function () { - let titleText = 'Colorado Drivers With No DUI\'s Getting A Pay Day on Friday'; - let imgData = { + const titleText = 'Colorado Drivers With No DUI\'s Getting A Pay Day on Friday'; + const imgData = { url: `${baseUrl}/image`, w: 1200, h: 627 }; - let nativeLink = `${baseUrl}/click/`; - let nativeTracker = `${baseUrl}/imp-image`; - let sponsoredByValue = 'Comparisons.org'; - let bodyValue = 'Drivers With No Tickets In 3 Years Should Do This On June'; - let bid = { + const nativeLink = `${baseUrl}/click/`; + const nativeTracker = `${baseUrl}/imp-image`; + const sponsoredByValue = 'Comparisons.org'; + const bodyValue = 'Drivers With No Tickets In 3 Years Should Do This On June'; + const bid = { price: 3, id: '65599d0a-42d2-446a-9d39-6086c1433ffe', burl: `${baseUrl}/burl/\${AUCTION_PRICE}`, @@ -549,7 +549,7 @@ describe('mediaforce bid adapter', function () { } }; - let response = { + const response = { body: { seatbid: [{ bid: [bid] @@ -559,7 +559,7 @@ describe('mediaforce bid adapter', function () { } }; - let bids = spec.interpretResponse(response); + const bids = spec.interpretResponse(response); assert.deepEqual(bids, ([{ native: { clickUrl: nativeLink, @@ -590,17 +590,17 @@ describe('mediaforce bid adapter', function () { describe('interpretResponse() native as string', function () { it('successfull response', function () { - let titleText = 'Colorado Drivers With No DUI\'s Getting A Pay Day on Friday'; - let imgData = { + const titleText = 'Colorado Drivers With No DUI\'s Getting A Pay Day on Friday'; + const imgData = { url: `${baseUrl}/image`, w: 1200, h: 627 }; - let nativeLink = `${baseUrl}/click/`; - let nativeTracker = `${baseUrl}/imp-image`; - let sponsoredByValue = 'Comparisons.org'; - let bodyValue = 'Drivers With No Tickets In 3 Years Should Do This On June'; - let adm = JSON.stringify({ + const nativeLink = `${baseUrl}/click/`; + const nativeTracker = `${baseUrl}/imp-image`; + const sponsoredByValue = 'Comparisons.org'; + const bodyValue = 'Drivers With No Tickets In 3 Years Should Do This On June'; + const adm = JSON.stringify({ native: { link: {url: nativeLink}, assets: [{ @@ -621,7 +621,7 @@ describe('mediaforce bid adapter', function () { ver: '1' } }); - let bid = { + const bid = { price: 3, id: '65599d0a-42d2-446a-9d39-6086c1433ffe', burl: `${baseUrl}/burl/\${AUCTION_PRICE}`, @@ -633,7 +633,7 @@ describe('mediaforce bid adapter', function () { adm: adm }; - let response = { + const response = { body: { seatbid: [{ bid: [bid] @@ -643,7 +643,7 @@ describe('mediaforce bid adapter', function () { } }; - let bids = spec.interpretResponse(response); + const bids = spec.interpretResponse(response); assert.deepEqual(bids, ([{ native: { clickUrl: nativeLink, @@ -724,8 +724,8 @@ describe('mediaforce bid adapter', function () { utils.triggerPixel.restore(); }); it('should expand price macros in burl', function () { - let burl = 'burl&s=${AUCTION_PRICE}'; - let bid = { + const burl = 'burl&s=${AUCTION_PRICE}'; + const bid = { bidder: 'mediaforce', width: 300, height: 250, diff --git a/test/spec/modules/mediafuseBidAdapter_spec.js b/test/spec/modules/mediafuseBidAdapter_spec.js index e00b495c3c7..06a0be58b8e 100644 --- a/test/spec/modules/mediafuseBidAdapter_spec.js +++ b/test/spec/modules/mediafuseBidAdapter_spec.js @@ -18,7 +18,7 @@ describe('MediaFuseAdapter', function () { }); describe('isBidRequestValid', function () { - let bid = { + const bid = { 'bidder': 'mediafuse', 'params': { 'placementId': '10433394' @@ -35,7 +35,7 @@ describe('MediaFuseAdapter', function () { }); it('should return true when required params found', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = { 'member': '1234', @@ -46,7 +46,7 @@ describe('MediaFuseAdapter', function () { }); it('should return false when required params are not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = { 'placementId': 0 @@ -57,7 +57,7 @@ describe('MediaFuseAdapter', function () { describe('buildRequests', function () { let getAdUnitsStub; - let bidRequests = [ + const bidRequests = [ { 'bidder': 'mediafuse', 'params': { @@ -83,7 +83,7 @@ describe('MediaFuseAdapter', function () { }); it('should parse out private sizes', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { @@ -101,7 +101,7 @@ describe('MediaFuseAdapter', function () { }); it('should add publisher_id in request', function() { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { @@ -129,7 +129,7 @@ describe('MediaFuseAdapter', function () { }); it('should populate the ad_types array on all requests', function () { - let adUnits = [{ + const adUnits = [{ code: 'adunit-code', mediaTypes: { banner: { @@ -192,7 +192,7 @@ describe('MediaFuseAdapter', function () { }); it('should attach valid video params to the tag', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { @@ -216,7 +216,7 @@ describe('MediaFuseAdapter', function () { }); it('should include ORTB video values when video params were not set', function() { - let bidRequest = deepClone(bidRequests[0]); + const bidRequest = deepClone(bidRequests[0]); bidRequest.params = { placementId: '1234235', video: { @@ -292,7 +292,7 @@ describe('MediaFuseAdapter', function () { }); it('should attach valid user params to the tag', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { @@ -317,9 +317,9 @@ describe('MediaFuseAdapter', function () { }); it('should attach reserve param when either bid param or getFloor function exists', function () { - let getFloorResponse = { currency: 'USD', floor: 3 }; + const getFloorResponse = { currency: 'USD', floor: 3 }; let request, payload = null; - let bidRequest = deepClone(bidRequests[0]); + const bidRequest = deepClone(bidRequests[0]); // 1 -> reserve not defined, getFloor not defined > empty request = spec.buildRequests([bidRequest]); @@ -347,7 +347,7 @@ describe('MediaFuseAdapter', function () { }); it('should duplicate adpod placements into batches and set correct maxduration', function() { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { placementId: '14542875' } @@ -380,7 +380,7 @@ describe('MediaFuseAdapter', function () { }); it('should round down adpod placements when numbers are uneven', function() { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { placementId: '14542875' } @@ -403,7 +403,7 @@ describe('MediaFuseAdapter', function () { }); it('should duplicate adpod placements when requireExactDuration is set', function() { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { placementId: '14542875' } @@ -445,7 +445,7 @@ describe('MediaFuseAdapter', function () { }); it('should set durations for placements when requireExactDuration is set and numbers are uneven', function() { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { placementId: '14542875' } @@ -476,7 +476,7 @@ describe('MediaFuseAdapter', function () { }); it('should break adpod request into batches', function() { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { placementId: '14542875' } @@ -504,7 +504,7 @@ describe('MediaFuseAdapter', function () { }); it('should contain hb_source value for adpod', function() { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { placementId: '14542875' } @@ -526,7 +526,7 @@ describe('MediaFuseAdapter', function () { }); it('should contain hb_source value for other media', function() { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { mediaType: 'banner', @@ -542,7 +542,7 @@ describe('MediaFuseAdapter', function () { }); it('adds brand_category_exclusion to request when set', function() { - let bidRequest = Object.assign({}, bidRequests[0]); + const bidRequest = Object.assign({}, bidRequests[0]); sinon .stub(config, 'getConfig') .withArgs('adpod.brandCategoryExclusion') @@ -557,7 +557,7 @@ describe('MediaFuseAdapter', function () { }); it('adds auction level keywords to request when set', function() { - let bidRequest = Object.assign({}, bidRequests[0]); + const bidRequest = Object.assign({}, bidRequests[0]); sinon .stub(config, 'getConfig') .withArgs('mediafuseAuctionKeywords') @@ -584,7 +584,7 @@ describe('MediaFuseAdapter', function () { }); it('should attach native params to the request', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { mediaType: 'native', @@ -635,7 +635,7 @@ describe('MediaFuseAdapter', function () { }); it('should always populated tags[].sizes with 1,1 for native if otherwise not defined', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { mediaType: 'native', @@ -659,7 +659,7 @@ describe('MediaFuseAdapter', function () { }); it('should convert keyword params to proper form and attaches to request', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { @@ -704,7 +704,7 @@ describe('MediaFuseAdapter', function () { }); it('should add payment rules to the request', function () { - let bidRequest = Object.assign({}, + const bidRequest = Object.assign({}, bidRequests[0], { params: { @@ -721,8 +721,8 @@ describe('MediaFuseAdapter', function () { }); it('should add gpid to the request', function () { - let testGpid = '/12345/my-gpt-tag-0'; - let bidRequest = deepClone(bidRequests[0]); + const testGpid = '/12345/my-gpt-tag-0'; + const bidRequest = deepClone(bidRequests[0]); bidRequest.ortb2Imp = { ext: { data: {}, gpid: testGpid } }; const request = spec.buildRequests([bidRequest]); @@ -732,8 +732,8 @@ describe('MediaFuseAdapter', function () { }); it('should add gdpr consent information to the request', function () { - let consentString = 'BOJ8RZsOJ8RZsABAB8AAAAAZ+A=='; - let bidderRequest = { + const consentString = 'BOJ8RZsOJ8RZsABAB8AAAAAZ+A=='; + const bidderRequest = { 'bidderCode': 'mediafuse', 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', @@ -757,8 +757,8 @@ describe('MediaFuseAdapter', function () { }); it('should add us privacy string to payload', function() { - let consentString = '1YA-'; - let bidderRequest = { + const consentString = '1YA-'; + const bidderRequest = { 'bidderCode': 'mediafuse', 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', @@ -775,7 +775,7 @@ describe('MediaFuseAdapter', function () { }); it('supports sending hybrid mobile app parameters', function () { - let appRequest = Object.assign({}, + const appRequest = Object.assign({}, bidRequests[0], { params: { @@ -881,7 +881,7 @@ describe('MediaFuseAdapter', function () { }); it('should populate coppa if set in config', function () { - let bidRequest = Object.assign({}, bidRequests[0]); + const bidRequest = Object.assign({}, bidRequests[0]); sinon.stub(config, 'getConfig') .withArgs('coppa') .returns(true); @@ -895,7 +895,7 @@ describe('MediaFuseAdapter', function () { }); it('should set the X-Is-Test customHeader if test flag is enabled', function () { - let bidRequest = Object.assign({}, bidRequests[0]); + const bidRequest = Object.assign({}, bidRequests[0]); sinon.stub(config, 'getConfig') .withArgs('apn_test') .returns(true); @@ -907,14 +907,14 @@ describe('MediaFuseAdapter', function () { }); it('should always set withCredentials: true on the request.options', function () { - let bidRequest = Object.assign({}, bidRequests[0]); + const bidRequest = Object.assign({}, bidRequests[0]); const request = spec.buildRequests([bidRequest]); expect(request.options.withCredentials).to.equal(true); }); it('should set simple domain variant if purpose 1 consent is not given', function () { - let consentString = 'BOJ8RZsOJ8RZsABAB8AAAAAZ+A=='; - let bidderRequest = { + const consentString = 'BOJ8RZsOJ8RZsABAB8AAAAAZ+A=='; + const bidderRequest = { 'bidderCode': 'mediafuse', 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', @@ -996,7 +996,7 @@ describe('MediaFuseAdapter', function () { it('should populate iab_support object at the root level if omid support is detected', function () { // with bid.params.frameworks - let bidRequest_A = Object.assign({}, bidRequests[0], { + const bidRequest_A = Object.assign({}, bidRequests[0], { params: { frameworks: [1, 2, 5, 6], video: { @@ -1052,7 +1052,7 @@ describe('MediaFuseAdapter', function () { $$PREBID_GLOBAL$$.bidderSettings = bidderSettingsStorage; }); - let response = { + const response = { 'version': '3.0.0', 'tags': [ { @@ -1101,7 +1101,7 @@ describe('MediaFuseAdapter', function () { }; it('should get correct bid response', function () { - let expectedResponse = [ + const expectedResponse = [ { 'requestId': '3db3773286ee59', 'cpm': 0.5, @@ -1129,25 +1129,25 @@ describe('MediaFuseAdapter', function () { } } ]; - let bidderRequest = { + const bidderRequest = { bids: [{ bidId: '3db3773286ee59', adUnitCode: 'code' }] }; - let result = spec.interpretResponse({ body: response }, {bidderRequest}); + const result = spec.interpretResponse({ body: response }, {bidderRequest}); expect(Object.keys(result[0])).to.have.members(Object.keys(expectedResponse[0])); }); it('should reject 0 cpm bids', function () { - let zeroCpmResponse = deepClone(response); + const zeroCpmResponse = deepClone(response); zeroCpmResponse.tags[0].ads[0].cpm = 0; - let bidderRequest = { + const bidderRequest = { bidderCode: 'mediafuse' }; - let result = spec.interpretResponse({ body: zeroCpmResponse }, { bidderRequest }); + const result = spec.interpretResponse({ body: zeroCpmResponse }, { bidderRequest }); expect(result.length).to.equal(0); }); @@ -1158,10 +1158,10 @@ describe('MediaFuseAdapter', function () { } }; - let zeroCpmResponse = deepClone(response); + const zeroCpmResponse = deepClone(response); zeroCpmResponse.tags[0].ads[0].cpm = 0; - let bidderRequest = { + const bidderRequest = { bidderCode: 'mediafuse', bids: [{ bidId: '3db3773286ee59', @@ -1169,13 +1169,13 @@ describe('MediaFuseAdapter', function () { }] }; - let result = spec.interpretResponse({ body: zeroCpmResponse }, { bidderRequest }); + const result = spec.interpretResponse({ body: zeroCpmResponse }, { bidderRequest }); expect(result.length).to.equal(1); expect(result[0].cpm).to.equal(0); }); it('handles nobid responses', function () { - let response = { + const response = { 'version': '0.0.1', 'tags': [{ 'uuid': '84ab500420319d', @@ -1186,12 +1186,12 @@ describe('MediaFuseAdapter', function () { }; let bidderRequest; - let result = spec.interpretResponse({ body: response }, {bidderRequest}); + const result = spec.interpretResponse({ body: response }, {bidderRequest}); expect(result.length).to.equal(0); }); it('handles outstream video responses', function () { - let response = { + const response = { 'tags': [{ 'uuid': '84ab500420319d', 'ads': [{ @@ -1207,7 +1207,7 @@ describe('MediaFuseAdapter', function () { }] }] }; - let bidderRequest = { + const bidderRequest = { bids: [{ bidId: '84ab500420319d', adUnitCode: 'code', @@ -1219,14 +1219,14 @@ describe('MediaFuseAdapter', function () { }] } - let result = spec.interpretResponse({ body: response }, {bidderRequest}); + const result = spec.interpretResponse({ body: response }, {bidderRequest}); expect(result[0]).to.have.property('vastXml'); expect(result[0]).to.have.property('vastImpUrl'); expect(result[0]).to.have.property('mediaType', 'video'); }); it('handles instream video responses', function () { - let response = { + const response = { 'tags': [{ 'uuid': '84ab500420319d', 'ads': [{ @@ -1242,7 +1242,7 @@ describe('MediaFuseAdapter', function () { }] }] }; - let bidderRequest = { + const bidderRequest = { bids: [{ bidId: '84ab500420319d', adUnitCode: 'code', @@ -1254,14 +1254,14 @@ describe('MediaFuseAdapter', function () { }] } - let result = spec.interpretResponse({ body: response }, {bidderRequest}); + const result = spec.interpretResponse({ body: response }, {bidderRequest}); expect(result[0]).to.have.property('vastUrl'); expect(result[0]).to.have.property('vastImpUrl'); expect(result[0]).to.have.property('mediaType', 'video'); }); it('handles adpod responses', function () { - let response = { + const response = { 'tags': [{ 'uuid': '84ab500420319d', 'ads': [{ @@ -1282,7 +1282,7 @@ describe('MediaFuseAdapter', function () { }] }; - let bidderRequest = { + const bidderRequest = { bids: [{ bidId: '84ab500420319d', adUnitCode: 'code', @@ -1294,14 +1294,14 @@ describe('MediaFuseAdapter', function () { }] }; - let result = spec.interpretResponse({ body: response }, {bidderRequest}); + const result = spec.interpretResponse({ body: response }, {bidderRequest}); expect(result[0]).to.have.property('vastUrl'); expect(result[0].video.context).to.equal('adpod'); expect(result[0].video.durationSeconds).to.equal(30); }); it('handles native responses', function () { - let response1 = deepClone(response); + const response1 = deepClone(response); response1.tags[0].ads[0].ad_type = 'native'; response1.tags[0].ads[0].rtb.native = { 'title': 'Native Creative', @@ -1336,14 +1336,14 @@ describe('MediaFuseAdapter', function () { 'privacy_link': 'https://www.mediafuse.com/privacy-policy-agreement/', 'javascriptTrackers': '' }; - let bidderRequest = { + const bidderRequest = { bids: [{ bidId: '3db3773286ee59', adUnitCode: 'code' }] } - let result = spec.interpretResponse({ body: response1 }, {bidderRequest}); + const result = spec.interpretResponse({ body: response1 }, {bidderRequest}); expect(result[0].native.title).to.equal('Native Creative'); expect(result[0].native.body).to.equal('Cool description great stuff'); expect(result[0].native.cta).to.equal('Do it'); @@ -1378,7 +1378,7 @@ describe('MediaFuseAdapter', function () { }); it('should add deal_priority and deal_code', function() { - let responseWithDeal = deepClone(response); + const responseWithDeal = deepClone(response); responseWithDeal.tags[0].ads[0].ad_type = 'video'; responseWithDeal.tags[0].ads[0].deal_priority = 5; responseWithDeal.tags[0].ads[0].deal_code = '123'; @@ -1388,7 +1388,7 @@ describe('MediaFuseAdapter', function () { player_height: 340, }; - let bidderRequest = { + const bidderRequest = { bids: [{ bidId: '3db3773286ee59', adUnitCode: 'code', @@ -1399,50 +1399,50 @@ describe('MediaFuseAdapter', function () { } }] } - let result = spec.interpretResponse({ body: responseWithDeal }, {bidderRequest}); + const result = spec.interpretResponse({ body: responseWithDeal }, {bidderRequest}); expect(Object.keys(result[0].mediafuse)).to.include.members(['buyerMemberId', 'dealPriority', 'dealCode']); expect(result[0].video.dealTier).to.equal(5); }); it('should add advertiser id', function() { - let responseAdvertiserId = deepClone(response); + const responseAdvertiserId = deepClone(response); responseAdvertiserId.tags[0].ads[0].advertiser_id = '123'; - let bidderRequest = { + const bidderRequest = { bids: [{ bidId: '3db3773286ee59', adUnitCode: 'code' }] } - let result = spec.interpretResponse({ body: responseAdvertiserId }, {bidderRequest}); + const result = spec.interpretResponse({ body: responseAdvertiserId }, {bidderRequest}); expect(Object.keys(result[0].meta)).to.include.members(['advertiserId']); }); it('should add brand id', function() { - let responseBrandId = deepClone(response); + const responseBrandId = deepClone(response); responseBrandId.tags[0].ads[0].brand_id = 123; - let bidderRequest = { + const bidderRequest = { bids: [{ bidId: '3db3773286ee59', adUnitCode: 'code' }] } - let result = spec.interpretResponse({ body: responseBrandId }, {bidderRequest}); + const result = spec.interpretResponse({ body: responseBrandId }, {bidderRequest}); expect(Object.keys(result[0].meta)).to.include.members(['brandId']); }); it('should add advertiserDomains', function() { - let responseAdvertiserId = deepClone(response); + const responseAdvertiserId = deepClone(response); responseAdvertiserId.tags[0].ads[0].adomain = ['123']; - let bidderRequest = { + const bidderRequest = { bids: [{ bidId: '3db3773286ee59', adUnitCode: 'code' }] } - let result = spec.interpretResponse({ body: responseAdvertiserId }, {bidderRequest}); + const result = spec.interpretResponse({ body: responseAdvertiserId }, {bidderRequest}); expect(Object.keys(result[0].meta)).to.include.members(['advertiserDomains']); expect(Object.keys(result[0].meta.advertiserDomains)).to.deep.equal([]); }); diff --git a/test/spec/modules/mediagoBidAdapter_spec.js b/test/spec/modules/mediagoBidAdapter_spec.js index 260fac12044..5f12de78b34 100644 --- a/test/spec/modules/mediagoBidAdapter_spec.js +++ b/test/spec/modules/mediagoBidAdapter_spec.js @@ -11,7 +11,7 @@ import { getPageTitle, getPageDescription, getPageKeywords, getConnectionDownLin import * as utils from 'src/utils.js'; describe('mediago:BidAdapterTests', function () { - let bidRequestData = { + const bidRequestData = { bidderCode: 'mediago', auctionId: '7fae02a9-0195-472f-ba94-708d3bc2c0d9', bidderRequestId: '4fec04e87ad785', @@ -137,7 +137,7 @@ describe('mediago:BidAdapterTests', function () { it('mediago:validate_generated_params', function () { request = spec.buildRequests(bidRequestData.bids, bidRequestData); - let req_data = JSON.parse(request.data); + const req_data = JSON.parse(request.data); expect(req_data.imp).to.have.lengthOf(1); }); @@ -192,7 +192,7 @@ describe('mediago:BidAdapterTests', function () { temp += '%3B%3C%2Fscri'; temp += 'pt%3E'; adm += decodeURIComponent(temp); - let serverResponse = { + const serverResponse = { body: { id: 'mgprebidjs_0b6572fc-ceba-418f-b6fd-33b41ad0ac8a', seatbid: [ @@ -215,13 +215,13 @@ describe('mediago:BidAdapterTests', function () { } }; - let bids = spec.interpretResponse(serverResponse); + const bids = spec.interpretResponse(serverResponse); // console.log({ // bids // }); expect(bids).to.have.lengthOf(1); - let bid = bids[0]; + const bid = bids[0]; expect(bid.creativeId).to.equal('ff32b6f9b3bbc45c00b78b6674a2952e'); expect(bid.width).to.equal(300); diff --git a/test/spec/modules/mediaimpactBidAdapter_spec.js b/test/spec/modules/mediaimpactBidAdapter_spec.js index 5bf088c0334..518397b11f8 100644 --- a/test/spec/modules/mediaimpactBidAdapter_spec.js +++ b/test/spec/modules/mediaimpactBidAdapter_spec.js @@ -16,7 +16,7 @@ describe('MediaimpactAdapter', function () { describe('isBidRequestValid', function () { it('should return true when required params found', function () { - let validRequest = { + const validRequest = { 'params': { 'unitId': 123 } @@ -25,7 +25,7 @@ describe('MediaimpactAdapter', function () { }); it('should return true when required params is srting', function () { - let validRequest = { + const validRequest = { 'params': { 'unitId': '456' } @@ -34,7 +34,7 @@ describe('MediaimpactAdapter', function () { }); it('should return false when required params are not passed', function () { - let validRequest = { + const validRequest = { 'params': { 'unknownId': 123 } @@ -43,7 +43,7 @@ describe('MediaimpactAdapter', function () { }); it('should return false when required params is 0', function () { - let validRequest = { + const validRequest = { 'params': { 'unitId': 0 } @@ -53,9 +53,9 @@ describe('MediaimpactAdapter', function () { }); describe('buildRequests', function () { - let validEndpoint = ENDPOINT_PROTOCOL + '://' + ENDPOINT_DOMAIN + ENDPOINT_PATH + '?tag=123,456&partner=777&sizes=300x250|300x600,728x90,300x250&referer=https%3A%2F%2Ftest.domain'; + const validEndpoint = ENDPOINT_PROTOCOL + '://' + ENDPOINT_DOMAIN + ENDPOINT_PATH + '?tag=123,456&partner=777&sizes=300x250|300x600,728x90,300x250&referer=https%3A%2F%2Ftest.domain'; - let validRequest = [ + const validRequest = [ { 'bidder': BIDDER_CODE, 'params': { @@ -85,7 +85,7 @@ describe('MediaimpactAdapter', function () { } ]; - let bidderRequest = { + const bidderRequest = { refererInfo: { page: 'https://test.domain' } @@ -299,7 +299,7 @@ describe('MediaimpactAdapter', function () { 'pixelEnabled': false }; - let syncs = spec.getUserSyncs(syncOptions); + const syncs = spec.getUserSyncs(syncOptions); expect(syncs).to.deep.equal([]); }); @@ -310,7 +310,7 @@ describe('MediaimpactAdapter', function () { }; const gdprConsent = undefined; - let syncs = spec.getUserSyncs(syncOptions, bidResponse, gdprConsent); + const syncs = spec.getUserSyncs(syncOptions, bidResponse, gdprConsent); expect(syncs.length).to.equal(3); expect(syncs[0].type).to.equal('image'); expect(syncs[0].url).to.equal('https://test.domain/tracker_1.gif'); @@ -328,7 +328,7 @@ describe('MediaimpactAdapter', function () { apiVersion: 2 }; - let syncs = spec.getUserSyncs(syncOptions, bidResponse, gdprConsent); + const syncs = spec.getUserSyncs(syncOptions, bidResponse, gdprConsent); expect(syncs.length).to.equal(3); expect(syncs[0].type).to.equal('image'); expect(syncs[0].url).to.equal('https://test.domain/tracker_1.gif?gdpr=1&gdpr_consent=someString'); diff --git a/test/spec/modules/medianetAnalyticsAdapter_spec.js b/test/spec/modules/medianetAnalyticsAdapter_spec.js index b7fbfcc0eb3..d293dca12fc 100644 --- a/test/spec/modules/medianetAnalyticsAdapter_spec.js +++ b/test/spec/modules/medianetAnalyticsAdapter_spec.js @@ -1,13 +1,13 @@ import {expect} from 'chai'; import medianetAnalytics from 'modules/medianetAnalyticsAdapter.js'; import * as utils from 'src/utils.js'; -import {EVENTS} from 'src/constants.js'; +import {EVENTS, REJECTION_REASON} from 'src/constants.js'; import * as events from 'src/events.js'; import {clearEvents} from 'src/events.js'; import {deepAccess} from 'src/utils.js'; import 'src/prebid.js'; import {config} from 'src/config.js'; -import {REJECTION_REASON} from 'src/constants.js'; + import {getGlobal} from 'src/prebidGlobal.js'; import sinon from "sinon"; import * as mnUtils from '../../../libraries/medianetUtils/utils.js'; @@ -363,7 +363,7 @@ function performAuctionNoWin() { } function performMultiBidAuction() { - let bidRequest = createBidRequest('medianet', '8e0d5245-deb3-406c-96ca-9b609e077ff7', '28248b0e6aece2', [BANNER_AD_UNIT]); + const bidRequest = createBidRequest('medianet', '8e0d5245-deb3-406c-96ca-9b609e077ff7', '28248b0e6aece2', [BANNER_AD_UNIT]); events.emit(AUCTION_INIT, Object.assign({}, MOCK.AUCTION_INIT, {adUnits: MOCK.AD_UNITS})); events.emit(BID_REQUESTED, bidRequest); MOCK.MULTI_BID_RESPONSES.forEach(bidResp => events.emit(BID_RESPONSE, bidResp)); @@ -400,8 +400,8 @@ function performCurrencyConversionAuction() { describe('Media.net Analytics Adapter', function () { let sandbox; let clock; - let CUSTOMER_ID = 'test123'; - let VALID_CONFIGURATION = { + const CUSTOMER_ID = 'test123'; + const VALID_CONFIGURATION = { options: { cid: CUSTOMER_ID } @@ -663,7 +663,7 @@ describe('Media.net Analytics Adapter', function () { clock.tick(2000); waitForPromiseResolve(Promise.resolve()).then(() => { - let winningBid = medianetAnalytics.getlogsQueue().map((log) => getQueryData(log)).filter(log => log.winner === '1')[0]; + const winningBid = medianetAnalytics.getlogsQueue().map((log) => getQueryData(log)).filter(log => log.winner === '1')[0]; expect(winningBid.adid).equals('3e6e4bce5c8fb3'); medianetAnalytics.clearlogsQueue(); @@ -672,7 +672,7 @@ describe('Media.net Analytics Adapter', function () { return waitForPromiseResolve(Promise.resolve()); }).then(() => { - let winningBid = medianetAnalytics.getlogsQueue().map((log) => getQueryData(log)).filter(log => log.winner === '1')[0]; + const winningBid = medianetAnalytics.getlogsQueue().map((log) => getQueryData(log)).filter(log => log.winner === '1')[0]; expect(winningBid.adid).equals('3e6e4bce5c8fb3'); done(); }).catch(done); @@ -683,7 +683,7 @@ describe('Media.net Analytics Adapter', function () { clock.tick(2000); waitForPromiseResolve(Promise.resolve()).then(() => { - let winningBid = medianetAnalytics.getlogsQueue().map((log) => getQueryData(log)).filter(log => log.winner === '1')[0]; + const winningBid = medianetAnalytics.getlogsQueue().map((log) => getQueryData(log)).filter(log => log.winner === '1')[0]; expect(winningBid.adid).equals('3e6e4bce5c8fb3'); medianetAnalytics.clearlogsQueue(); done(); @@ -696,8 +696,8 @@ describe('Media.net Analytics Adapter', function () { clock.tick(2000); waitForPromiseResolve(Promise.resolve()).then(() => { - let winningBids = medianetAnalytics.getlogsQueue().map((log) => getQueryData(log)).filter(log => log.winner); - let errors = medianetAnalytics.getErrorQueue().map((log) => getQueryData(log)); + const winningBids = medianetAnalytics.getlogsQueue().map((log) => getQueryData(log)).filter(log => log.winner); + const errors = medianetAnalytics.getErrorQueue().map((log) => getQueryData(log)); expect(winningBids.length).equals(0); expect(errors.length).equals(1); expect(errors[0].event).equals('winning_bid_absent'); @@ -710,7 +710,7 @@ describe('Media.net Analytics Adapter', function () { clock.tick(2000); waitForPromiseResolve(Promise.resolve()).then(() => { - let bidRejectedLog = medianetAnalytics.getlogsQueue().map((log) => getQueryData(log))[0]; + const bidRejectedLog = medianetAnalytics.getlogsQueue().map((log) => getQueryData(log))[0]; expect(bidRejectedLog.pvnm).to.have.ordered.members(['-2', 'medianet', 'medianet', 'medianet']); expect(bidRejectedLog.status).to.have.ordered.members(['1', '1', '12', '12']); done(); @@ -764,7 +764,7 @@ describe('Media.net Analytics Adapter', function () { it('should have winner log in standard auction', function () { performBidWonAuction(); - let winnerLog = medianetAnalytics.getlogsQueue().map((log) => getQueryData(log)).filter((log) => log.winner); + const winnerLog = medianetAnalytics.getlogsQueue().map((log) => getQueryData(log)).filter((log) => log.winner); expect(winnerLog.length).to.equal(1); expect(winnerLog[0].lgtp).to.equal('RA'); }); @@ -772,7 +772,7 @@ describe('Media.net Analytics Adapter', function () { it('should have correct values in winner log', function () { performBidWonAuction(); - let winnerLog = medianetAnalytics.getlogsQueue().map((log) => getQueryData(log)).filter((log) => log.winner); + const winnerLog = medianetAnalytics.getlogsQueue().map((log) => getQueryData(log)).filter((log) => log.winner); expect(winnerLog[0]).to.include({ winner: '1', pvnm: 'medianet', @@ -793,7 +793,7 @@ describe('Media.net Analytics Adapter', function () { it('should have correct bid floor data in winner log', function (done) { performBidWonAuction(); - let winnerLog = medianetAnalytics.getlogsQueue().map((log) => getQueryData(log)).filter((log) => log.winner); + const winnerLog = medianetAnalytics.getlogsQueue().map((log) => getQueryData(log)).filter((log) => log.winner); expect(winnerLog[0]).to.include({ winner: '1', curr: 'USD', diff --git a/test/spec/modules/medianetBidAdapter_spec.js b/test/spec/modules/medianetBidAdapter_spec.js index a4328075f98..5339860c77c 100644 --- a/test/spec/modules/medianetBidAdapter_spec.js +++ b/test/spec/modules/medianetBidAdapter_spec.js @@ -7,7 +7,7 @@ import {server} from '../../mocks/xhr.js'; import {resetWinDimensions} from '../../../src/utils.js'; $$PREBID_GLOBAL$$.version = $$PREBID_GLOBAL$$.version || 'version'; -let VALID_BID_REQUEST = [{ +const VALID_BID_REQUEST = [{ 'bidder': 'medianet', 'params': { 'cid': 'customer_id', @@ -1932,27 +1932,27 @@ describe('Media.net bid adapter', function () { describe('isBidRequestValid', function () { it('should accept valid bid params', function () { - let isValid = spec.isBidRequestValid(VALID_PARAMS); + const isValid = spec.isBidRequestValid(VALID_PARAMS); expect(isValid).to.equal(true); }); it('should reject bid if cid is not present', function () { - let isValid = spec.isBidRequestValid(PARAMS_WITHOUT_CID); + const isValid = spec.isBidRequestValid(PARAMS_WITHOUT_CID); expect(isValid).to.equal(false); }); it('should reject bid if cid is not a string', function () { - let isValid = spec.isBidRequestValid(PARAMS_WITH_INTEGER_CID); + const isValid = spec.isBidRequestValid(PARAMS_WITH_INTEGER_CID); expect(isValid).to.equal(false); }); it('should reject bid if cid is a empty string', function () { - let isValid = spec.isBidRequestValid(PARAMS_WITH_EMPTY_CID); + const isValid = spec.isBidRequestValid(PARAMS_WITH_EMPTY_CID); expect(isValid).to.equal(false); }); it('should have missing params', function () { - let isValid = spec.isBidRequestValid(PARAMS_MISSING); + const isValid = spec.isBidRequestValid(PARAMS_MISSING); expect(isValid).to.equal(false); }); }); @@ -1961,8 +1961,8 @@ describe('Media.net bid adapter', function () { beforeEach(function () { $$PREBID_GLOBAL$$.medianetGlobals = {}; - let documentStub = sandbox.stub(document, 'getElementById'); - let boundingRect = { + const documentStub = sandbox.stub(document, 'getElementById'); + const boundingRect = { top: 50, left: 50, bottom: 100, @@ -1974,7 +1974,7 @@ describe('Media.net bid adapter', function () { documentStub.withArgs('div-gpt-ad-1460505748561-0').returns({ getBoundingClientRect: () => boundingRect }); - let windowSizeStub = sandbox.stub(spec, 'getWindowSize'); + const windowSizeStub = sandbox.stub(spec, 'getWindowSize'); windowSizeStub.returns({ w: 1000, h: 1000 @@ -1982,37 +1982,37 @@ describe('Media.net bid adapter', function () { }); it('should build valid payload on bid', function () { - let requestObj = spec.buildRequests(VALID_BID_REQUEST, VALID_AUCTIONDATA); + const requestObj = spec.buildRequests(VALID_BID_REQUEST, VALID_AUCTIONDATA); expect(JSON.parse(requestObj.data)).to.deep.include(VALID_PAYLOAD); }); it('should accept size as a one dimensional array', function () { - let bidReq = spec.buildRequests(BID_REQUEST_SIZE_AS_1DARRAY, VALID_AUCTIONDATA); + const bidReq = spec.buildRequests(BID_REQUEST_SIZE_AS_1DARRAY, VALID_AUCTIONDATA); expect(JSON.parse(bidReq.data)).to.deep.equal(VALID_PAYLOAD); }); it('should ignore bidfloor if not a valid number', function () { - let bidReq = spec.buildRequests(VALID_BID_REQUEST_INVALID_BIDFLOOR, VALID_AUCTIONDATA); + const bidReq = spec.buildRequests(VALID_BID_REQUEST_INVALID_BIDFLOOR, VALID_AUCTIONDATA); expect(JSON.parse(bidReq.data)).to.deep.equal(VALID_PAYLOAD_INVALID_BIDFLOOR); }); it('should add gdpr to response ext', function () { - let bidReq = spec.buildRequests(VALID_BID_REQUEST, VALID_BIDDER_REQUEST_WITH_GDPR); + const bidReq = spec.buildRequests(VALID_BID_REQUEST, VALID_BIDDER_REQUEST_WITH_GDPR); expect(JSON.parse(bidReq.data)).to.deep.equal(VALID_PAYLOAD_FOR_GDPR); }); it('should have gpp params in ortb2', function () { - let bidReq = spec.buildRequests(VALID_BID_REQUEST, VALID_BIDDER_REQUEST_WITH_GPP_IN_ORTB2); + const bidReq = spec.buildRequests(VALID_BID_REQUEST, VALID_BIDDER_REQUEST_WITH_GPP_IN_ORTB2); expect(JSON.parse(bidReq.data)).to.deep.equal(VALID_PAYLOAD_FOR_GPP_ORTB2); }); it('should parse params for native request', function () { - let bidReq = spec.buildRequests(VALID_NATIVE_BID_REQUEST, VALID_AUCTIONDATA); + const bidReq = spec.buildRequests(VALID_NATIVE_BID_REQUEST, VALID_AUCTIONDATA); expect(JSON.parse(bidReq.data)).to.deep.equal(VALID_PAYLOAD_NATIVE); }); it('should parse params for video request', function () { - let bidReq = spec.buildRequests(VALID_VIDEO_BID_REQUEST, VALID_AUCTIONDATA); + const bidReq = spec.buildRequests(VALID_VIDEO_BID_REQUEST, VALID_AUCTIONDATA); expect(JSON.stringify(bidReq.data)).to.include('instream'); }); @@ -2023,7 +2023,7 @@ describe('Media.net bid adapter', function () { }; return config[key]; }); - let bidreq = spec.buildRequests(VALID_BID_REQUEST_WITH_CRID, VALID_AUCTIONDATA); + const bidreq = spec.buildRequests(VALID_BID_REQUEST_WITH_CRID, VALID_AUCTIONDATA); expect(JSON.parse(bidreq.data)).to.deep.equal(VALID_PAYLOAD_WITH_CRID); }); @@ -2039,23 +2039,23 @@ describe('Media.net bid adapter', function () { }); it('should have userid in bid request', function () { - let bidReq = spec.buildRequests(VALID_BID_REQUEST_WITH_USERID, VALID_AUCTIONDATA); + const bidReq = spec.buildRequests(VALID_BID_REQUEST_WITH_USERID, VALID_AUCTIONDATA); expect(JSON.parse(bidReq.data)).to.deep.equal(VALID_PAYLOAD_WITH_USERID); }); it('should have userIdAsEids in bid request', function () { - let bidReq = spec.buildRequests(VALID_BID_REQUEST_WITH_USERIDASEIDS, VALID_AUCTIONDATA); + const bidReq = spec.buildRequests(VALID_BID_REQUEST_WITH_USERIDASEIDS, VALID_AUCTIONDATA); expect(JSON.parse(bidReq.data)).to.deep.equal(VALID_PAYLOAD_WITH_USERIDASEIDS); }); it('should have valid payload when PAAPI is enabled', function () { - let bidReq = spec.buildRequests(VALID_BID_REQUEST_WITH_AE_IN_ORTB2IMP, {...VALID_AUCTIONDATA, paapi: {enabled: true}}); + const bidReq = spec.buildRequests(VALID_BID_REQUEST_WITH_AE_IN_ORTB2IMP, {...VALID_AUCTIONDATA, paapi: {enabled: true}}); expect(JSON.parse(bidReq.data)).to.deep.equal(VALID_PAYLOAD_PAAPI); }); it('should send whatever is set in ortb2imp.ext.ae in all bid requests when PAAPI is enabled', function () { - let bidReq = spec.buildRequests(VALID_BID_REQUEST_WITH_AE_IN_ORTB2IMP, {...VALID_AUCTIONDATA, paapi: {enabled: true}}); - let data = JSON.parse(bidReq.data); + const bidReq = spec.buildRequests(VALID_BID_REQUEST_WITH_AE_IN_ORTB2IMP, {...VALID_AUCTIONDATA, paapi: {enabled: true}}); + const data = JSON.parse(bidReq.data); expect(data).to.deep.equal(VALID_PAYLOAD_PAAPI); expect(data.imp[0].ext).to.have.property('ae'); expect(data.imp[0].ext.ae).to.equal(1); @@ -2065,8 +2065,9 @@ describe('Media.net bid adapter', function () { beforeEach(() => { spec.clearPageMeta(); }); + it('should pass canonical, twitter and fb parameters if available', () => { - let documentStub = sandbox.stub(window.top.document, 'querySelector'); + const documentStub = sandbox.stub(window.top.document, 'querySelector'); documentStub.withArgs('link[rel="canonical"]').returns({ href: 'http://localhost:9999/canonical-test' }); @@ -2076,7 +2077,7 @@ describe('Media.net bid adapter', function () { documentStub.withArgs('meta[name="twitter:url"]').returns({ content: 'http://localhost:9999/twitter-test' }); - let bidReq = spec.buildRequests(VALID_BID_REQUEST, VALID_AUCTIONDATA); + const bidReq = spec.buildRequests(VALID_BID_REQUEST, VALID_AUCTIONDATA); expect(JSON.parse(bidReq.data)).to.deep.equal(VALID_PAYLOAD_PAGE_META); }); }); @@ -2085,7 +2086,7 @@ describe('Media.net bid adapter', function () { describe('slot visibility', function () { let documentStub; beforeEach(function () { - let windowSizeStub = sandbox.stub(spec, 'getWindowSize'); + const windowSizeStub = sandbox.stub(spec, 'getWindowSize'); windowSizeStub.returns({ w: 1000, h: 1000 @@ -2093,7 +2094,7 @@ describe('Media.net bid adapter', function () { documentStub = sandbox.stub(document, 'getElementById'); }); it('slot visibility should be 2 and ratio 0 when ad unit is BTF', function () { - let boundingRect = { + const boundingRect = { top: 1010, left: 1010, bottom: 1050, @@ -2106,13 +2107,13 @@ describe('Media.net bid adapter', function () { getBoundingClientRect: () => boundingRect }); - let bidReq = spec.buildRequests(VALID_BID_REQUEST, VALID_AUCTIONDATA); - let data = JSON.parse(bidReq.data); + const bidReq = spec.buildRequests(VALID_BID_REQUEST, VALID_AUCTIONDATA); + const data = JSON.parse(bidReq.data); expect(data.imp[0].ext.visibility).to.equal(2); expect(data.imp[0].ext.viewability).to.equal(0); }); it('slot visibility should be 2 and ratio < 0.5 when ad unit is partially inside viewport', function () { - let boundingRect = { + const boundingRect = { top: 990, left: 990, bottom: 1050, @@ -2124,13 +2125,13 @@ describe('Media.net bid adapter', function () { documentStub.withArgs('div-gpt-ad-1460505748561-0').returns({ getBoundingClientRect: () => boundingRect }); - let bidReq = spec.buildRequests(VALID_BID_REQUEST, VALID_AUCTIONDATA); - let data = JSON.parse(bidReq.data); + const bidReq = spec.buildRequests(VALID_BID_REQUEST, VALID_AUCTIONDATA); + const data = JSON.parse(bidReq.data); expect(data.imp[0].ext.visibility).to.equal(2); expect(data.imp[0].ext.viewability).to.equal(100 / 75000); }); it('slot visibility should be 1 and ratio > 0.5 when ad unit mostly in viewport', function () { - let boundingRect = { + const boundingRect = { top: 800, left: 800, bottom: 1050, @@ -2142,14 +2143,14 @@ describe('Media.net bid adapter', function () { documentStub.withArgs('div-gpt-ad-1460505748561-0').returns({ getBoundingClientRect: () => boundingRect }); - let bidReq = spec.buildRequests(VALID_BID_REQUEST, VALID_AUCTIONDATA); - let data = JSON.parse(bidReq.data); + const bidReq = spec.buildRequests(VALID_BID_REQUEST, VALID_AUCTIONDATA); + const data = JSON.parse(bidReq.data); expect(data.imp[0].ext.visibility).to.equal(1); expect(data.imp[0].ext.viewability).to.equal(40000 / 75000); }); it('co-ordinates should not be sent and slot visibility should be 0 when ad unit is not present', function () { - let bidReq = spec.buildRequests(VALID_BID_REQUEST, VALID_AUCTIONDATA); - let data = JSON.parse(bidReq.data); + const bidReq = spec.buildRequests(VALID_BID_REQUEST, VALID_AUCTIONDATA); + const data = JSON.parse(bidReq.data); expect(data.imp[1].ext).to.not.have.ownPropertyDescriptor('viewability'); expect(data.imp[1].ext.visibility).to.equal(0); }); @@ -2158,7 +2159,7 @@ describe('Media.net bid adapter', function () { const divId = 'div-gpt-ad-1460505748561-0'; window.googletag.pubads().setSlots([makeSlot({ code, divId })]); - let boundingRect = { + const boundingRect = { top: 1010, left: 1010, bottom: 1050, @@ -2181,84 +2182,84 @@ describe('Media.net bid adapter', function () { describe('getUserSyncs', function () { it('should exclude iframe syncs if iframe is disabled', function () { - let userSyncs = spec.getUserSyncs(SYNC_OPTIONS_PIXEL_ENABLED, SERVER_CSYNC_RESPONSE); + const userSyncs = spec.getUserSyncs(SYNC_OPTIONS_PIXEL_ENABLED, SERVER_CSYNC_RESPONSE); expect(userSyncs).to.deep.equal(ENABLED_SYNC_PIXEL); }); it('should exclude pixel syncs if pixel is disabled', function () { - let userSyncs = spec.getUserSyncs(SYNC_OPTIONS_IFRAME_ENABLED, SERVER_CSYNC_RESPONSE); + const userSyncs = spec.getUserSyncs(SYNC_OPTIONS_IFRAME_ENABLED, SERVER_CSYNC_RESPONSE); expect(userSyncs).to.deep.equal(ENABLED_SYNC_IFRAME); }); it('should choose iframe sync urls if both sync options are enabled', function () { - let userSyncs = spec.getUserSyncs(SYNC_OPTIONS_BOTH_ENABLED, SERVER_CSYNC_RESPONSE); + const userSyncs = spec.getUserSyncs(SYNC_OPTIONS_BOTH_ENABLED, SERVER_CSYNC_RESPONSE); expect(userSyncs).to.deep.equal(ENABLED_SYNC_IFRAME); }); it('should have empty user sync array', function() { - let userSyncs = spec.getUserSyncs(SYNC_OPTIONS_IFRAME_ENABLED, {}); + const userSyncs = spec.getUserSyncs(SYNC_OPTIONS_IFRAME_ENABLED, {}); expect(userSyncs).to.deep.equal([]); }); }); describe('interpretResponse', function () { it('should not push bid response if cpm missing', function () { - let validBids = []; - let bids = spec.interpretResponse(SERVER_RESPONSE_CPM_MISSING, []); + const validBids = []; + const bids = spec.interpretResponse(SERVER_RESPONSE_CPM_MISSING, []); expect(bids).to.deep.equal(validBids); }); it('should not push bid response if cpm 0', function () { - let validBids = []; - let bids = spec.interpretResponse(SERVER_RESPONSE_CPM_ZERO, []); + const validBids = []; + const bids = spec.interpretResponse(SERVER_RESPONSE_CPM_ZERO, []); expect(bids).to.deep.equal(validBids); }); it('should not push response if no-bid', function () { - let validBids = []; - let bids = spec.interpretResponse(SERVER_RESPONSE_NOBID, []); + const validBids = []; + const bids = spec.interpretResponse(SERVER_RESPONSE_NOBID, []); expect(bids).to.deep.equal(validBids); }); it('should have empty bid response', function() { - let bids = spec.interpretResponse(SERVER_RESPONSE_NOBODY, []); + const bids = spec.interpretResponse(SERVER_RESPONSE_NOBODY, []); expect(bids).to.deep.equal([]); }); it('should have valid bids', function () { - let bids = spec.interpretResponse(SERVER_RESPONSE_VALID_BID, []); + const bids = spec.interpretResponse(SERVER_RESPONSE_VALID_BID, []); expect(bids).to.deep.equal(SERVER_VALID_BIDS); }); it('should have empty bid list', function() { - let validBids = []; - let bids = spec.interpretResponse(SERVER_RESPONSE_EMPTY_BIDLIST, []); + const validBids = []; + const bids = spec.interpretResponse(SERVER_RESPONSE_EMPTY_BIDLIST, []); expect(bids).to.deep.equal(validBids); }); it('should return paapi if PAAPI response is received', function() { - let response = spec.interpretResponse(SERVER_RESPONSE_PAAPI, []); + const response = spec.interpretResponse(SERVER_RESPONSE_PAAPI, []); expect(response).to.have.property('bids'); expect(response).to.have.property('paapi'); expect(response.paapi[0]).to.deep.equal(SERVER_RESPONSE_PAAPI.body.ext.paApiAuctionConfigs[0]); }); it('should return paapi if openRTB PAAPI response received', function () { - let response = spec.interpretResponse(SERVER_RESPONSE_PAAPI_ORTB, []); + const response = spec.interpretResponse(SERVER_RESPONSE_PAAPI_ORTB, []); expect(response).to.have.property('bids'); expect(response).to.have.property('paapi'); expect(response.paapi[0]).to.deep.equal(SERVER_RESPONSE_PAAPI_ORTB.body.ext.igi[0].igs[0]) }); it('should have the correlation between paapi[0].bidId and bidreq.imp[0].id', function() { - let bidReq = spec.buildRequests(VALID_BID_REQUEST_WITH_AE_IN_ORTB2IMP, {...VALID_AUCTIONDATA, paapi: {enabled: true}}); - let bidRes = spec.interpretResponse(SERVER_RESPONSE_PAAPI, []); + const bidReq = spec.buildRequests(VALID_BID_REQUEST_WITH_AE_IN_ORTB2IMP, {...VALID_AUCTIONDATA, paapi: {enabled: true}}); + const bidRes = spec.interpretResponse(SERVER_RESPONSE_PAAPI, []); expect(bidRes.paapi[0].bidId).to.equal(JSON.parse(bidReq.data).imp[0].id) }); it('should have the correlation between paapi[0].bidId and bidreq.imp[0].id for openRTB response', function() { - let bidReq = spec.buildRequests(VALID_BID_REQUEST_WITH_AE_IN_ORTB2IMP, {...VALID_AUCTIONDATA, paapi: {enabled: true}}); - let bidRes = spec.interpretResponse(SERVER_RESPONSE_PAAPI_ORTB, []); + const bidReq = spec.buildRequests(VALID_BID_REQUEST_WITH_AE_IN_ORTB2IMP, {...VALID_AUCTIONDATA, paapi: {enabled: true}}); + const bidRes = spec.interpretResponse(SERVER_RESPONSE_PAAPI_ORTB, []); expect(bidRes.paapi[0].bidId).to.equal(JSON.parse(bidReq.data).imp[0].id) }); }); @@ -2373,12 +2374,12 @@ describe('Media.net bid adapter', function () { }); it('context should be outstream', function () { - let bids = spec.interpretResponse(SERVER_VIDEO_OUTSTREAM_RESPONSE_VALID_BID, []); + const bids = spec.interpretResponse(SERVER_VIDEO_OUTSTREAM_RESPONSE_VALID_BID, []); expect(bids[0].context).to.equal('outstream'); }); describe('buildRequests floor tests', function () { let floor; - let getFloor = function(req) { + const getFloor = function(req) { return floor[req.mediaType]; }; beforeEach(function () { @@ -2390,8 +2391,8 @@ describe('Media.net bid adapter', function () { }; $$PREBID_GLOBAL$$.medianetGlobals = {}; - let documentStub = sandbox.stub(document, 'getElementById'); - let boundingRect = { + const documentStub = sandbox.stub(document, 'getElementById'); + const boundingRect = { top: 50, left: 50, bottom: 100, @@ -2403,7 +2404,7 @@ describe('Media.net bid adapter', function () { documentStub.withArgs('div-gpt-ad-1460505748561-0').returns({ getBoundingClientRect: () => boundingRect }); - let windowSizeStub = sandbox.stub(spec, 'getWindowSize'); + const windowSizeStub = sandbox.stub(spec, 'getWindowSize'); windowSizeStub.returns({ w: 1000, h: 1000 @@ -2420,51 +2421,51 @@ describe('Media.net bid adapter', function () { describe('isBidRequestValid trustedstack', function () { it('should accept valid bid params', function () { - let isValid = spec.isBidRequestValid(VALID_PARAMS_TS); + const isValid = spec.isBidRequestValid(VALID_PARAMS_TS); expect(isValid).to.equal(true); }); it('should reject bid if cid is not present', function () { - let isValid = spec.isBidRequestValid(PARAMS_WITHOUT_CID_TS); + const isValid = spec.isBidRequestValid(PARAMS_WITHOUT_CID_TS); expect(isValid).to.equal(false); }); it('should reject bid if cid is not a string', function () { - let isValid = spec.isBidRequestValid(PARAMS_WITH_INTEGER_CID_TS); + const isValid = spec.isBidRequestValid(PARAMS_WITH_INTEGER_CID_TS); expect(isValid).to.equal(false); }); it('should reject bid if cid is a empty string', function () { - let isValid = spec.isBidRequestValid(PARAMS_WITH_EMPTY_CID_TS); + const isValid = spec.isBidRequestValid(PARAMS_WITH_EMPTY_CID_TS); expect(isValid).to.equal(false); }); it('should have missing params', function () { - let isValid = spec.isBidRequestValid(PARAMS_MISSING_TS); + const isValid = spec.isBidRequestValid(PARAMS_MISSING_TS); expect(isValid).to.equal(false); }); }); describe('interpretResponse trustedstack', function () { it('should not push response if no-bid', function () { - let validBids = []; - let bids = spec.interpretResponse(SERVER_RESPONSE_NOBID, []); + const validBids = []; + const bids = spec.interpretResponse(SERVER_RESPONSE_NOBID, []); expect(bids).to.deep.equal(validBids); }); it('should have empty bid response', function() { - let bids = spec.interpretResponse(SERVER_RESPONSE_NOBODY, []); + const bids = spec.interpretResponse(SERVER_RESPONSE_NOBODY, []); expect(bids).to.deep.equal([]); }); it('should have valid bids', function () { - let bids = spec.interpretResponse(SERVER_RESPONSE_VALID_BID, []); + const bids = spec.interpretResponse(SERVER_RESPONSE_VALID_BID, []); expect(bids).to.deep.equal(SERVER_VALID_BIDS); }); it('should have empty bid list', function() { - let validBids = []; - let bids = spec.interpretResponse(SERVER_RESPONSE_EMPTY_BIDLIST, []); + const validBids = []; + const bids = spec.interpretResponse(SERVER_RESPONSE_EMPTY_BIDLIST, []); expect(bids).to.deep.equal(validBids); }); }); diff --git a/test/spec/modules/mediasquareBidAdapter_spec.js b/test/spec/modules/mediasquareBidAdapter_spec.js index 065e5de9648..2c4c995e078 100644 --- a/test/spec/modules/mediasquareBidAdapter_spec.js +++ b/test/spec/modules/mediasquareBidAdapter_spec.js @@ -250,7 +250,7 @@ describe('MediaSquare bid adapter tests', function () { const won = spec.onBidWon(response[0]); expect(won).to.equal(true); expect(server.requests.length).to.equal(1); - let message = JSON.parse(server.requests[0].requestBody); + const message = JSON.parse(server.requests[0].requestBody); expect(message).to.have.property('increment').exist; expect(message).to.have.property('increment').and.to.equal('1'); expect(message).to.have.property('ova').and.to.equal('cleared'); @@ -270,12 +270,12 @@ describe('MediaSquare bid adapter tests', function () { var syncs = spec.getUserSyncs({}, null, DEFAULT_OPTIONS.gdprConsent, DEFAULT_OPTIONS.uspConsent); expect(syncs).to.have.lengthOf(0); }); - it('Verifies user sync with no bid body response', function() { - var syncs = spec.getUserSyncs({}, [], DEFAULT_OPTIONS.gdprConsent, DEFAULT_OPTIONS.uspConsent); - expect(syncs).to.have.lengthOf(0); - var syncs = spec.getUserSyncs({}, [{}], DEFAULT_OPTIONS.gdprConsent, DEFAULT_OPTIONS.uspConsent); - expect(syncs).to.have.lengthOf(0); - }); + it('Verifies user sync with no bid body response', function() { + let syncs = spec.getUserSyncs({}, [], DEFAULT_OPTIONS.gdprConsent, DEFAULT_OPTIONS.uspConsent); + expect(syncs).to.have.lengthOf(0); + syncs = spec.getUserSyncs({}, [{}], DEFAULT_OPTIONS.gdprConsent, DEFAULT_OPTIONS.uspConsent); + expect(syncs).to.have.lengthOf(0); + }); it('Verifies native in bid response', function () { const request = spec.buildRequests(NATIVE_PARAMS, DEFAULT_OPTIONS); BID_RESPONSE.body.responses[0].native = {'title': 'native title'}; diff --git a/test/spec/modules/merkleIdSystem_spec.js b/test/spec/modules/merkleIdSystem_spec.js index 3c4b909c012..0999cacc8e4 100644 --- a/test/spec/modules/merkleIdSystem_spec.js +++ b/test/spec/modules/merkleIdSystem_spec.js @@ -6,7 +6,7 @@ import sinon from 'sinon'; import {createEidsArray} from '../../../modules/userId/eids.js'; import {attachIdSystem} from '../../../modules/userId/index.js'; -let expect = require('chai').expect; +const expect = require('chai').expect; const CONFIG_PARAMS = { endpoint: undefined, @@ -41,7 +41,7 @@ function mockResponse( describe('Merkle System', function () { describe('merkleIdSystem.decode()', function() { it('provides multiple Merkle IDs (EID) from a stored object', function() { - let storage = { + const storage = { merkleId: [{ id: 'some-random-id-value', ext: { enc: 1, keyID: 16, idName: 'pamId', ssp: 'ssp1' } }, { @@ -62,7 +62,7 @@ describe('Merkle System', function () { }); it('can decode legacy stored object', function() { - let merkleId = {'pam_id': {'id': 'testmerkleId', 'keyID': 1}}; + const merkleId = {'pam_id': {'id': 'testmerkleId', 'keyID': 1}}; expect(merkleIdSubmodule.decode(merkleId)).to.deep.equal({ merkleId: {'id': 'testmerkleId', 'keyID': 1} @@ -70,7 +70,7 @@ describe('Merkle System', function () { }) it('returns undefined', function() { - let merkleId = {}; + const merkleId = {}; expect(merkleIdSubmodule.decode(merkleId)).to.be.undefined; }) }); @@ -97,7 +97,7 @@ describe('Merkle System', function () { }); it('getId() should fail on missing sv_pubid', function () { - let config = { + const config = { params: { ...CONFIG_PARAMS, sv_pubid: undefined @@ -105,13 +105,13 @@ describe('Merkle System', function () { storage: STORAGE_PARAMS }; - let submoduleCallback = merkleIdSubmodule.getId(config, undefined); + const submoduleCallback = merkleIdSubmodule.getId(config, undefined); expect(submoduleCallback).to.be.undefined; expect(utils.logError.args[0][0]).to.exist.and.to.equal('User ID - merkleId submodule requires a valid sv_pubid string to be defined'); }); it('getId() should fail on missing ssp_ids', function () { - let config = { + const config = { params: { ...CONFIG_PARAMS, ssp_ids: undefined @@ -119,13 +119,13 @@ describe('Merkle System', function () { storage: STORAGE_PARAMS }; - let submoduleCallback = merkleIdSubmodule.getId(config, undefined); + const submoduleCallback = merkleIdSubmodule.getId(config, undefined); expect(submoduleCallback).to.be.undefined; expect(utils.logError.args[0][0]).to.exist.and.to.equal('User ID - merkleId submodule requires a valid ssp_ids array to be defined'); }); it('getId() should warn on missing endpoint', function () { - let config = { + const config = { params: { ...CONFIG_PARAMS, endpoint: undefined @@ -133,25 +133,25 @@ describe('Merkle System', function () { storage: STORAGE_PARAMS }; - let submoduleCallback = merkleIdSubmodule.getId(config, undefined).callback; + const submoduleCallback = merkleIdSubmodule.getId(config, undefined).callback; submoduleCallback(callbackSpy); expect(callbackSpy.calledOnce).to.be.true; expect(utils.logWarn.args[0][0]).to.exist.and.to.equal('User ID - merkleId submodule endpoint string is not defined'); }); it('getId() should handle callback with valid configuration', function () { - let config = { + const config = { params: CONFIG_PARAMS, storage: STORAGE_PARAMS }; - let submoduleCallback = merkleIdSubmodule.getId(config, undefined).callback; + const submoduleCallback = merkleIdSubmodule.getId(config, undefined).callback; submoduleCallback(callbackSpy); expect(callbackSpy.calledOnce).to.be.true; }); it('getId() does not handle consent strings', function () { - let config = { + const config = { params: { ...CONFIG_PARAMS, ssp_ids: [] @@ -159,7 +159,7 @@ describe('Merkle System', function () { storage: STORAGE_PARAMS }; - let submoduleCallback = merkleIdSubmodule.getId(config, {gdpr: {gdprApplies: true}}); + const submoduleCallback = merkleIdSubmodule.getId(config, {gdpr: {gdprApplies: true}}); expect(submoduleCallback).to.be.undefined; expect(utils.logError.args[0][0]).to.exist.and.to.equal('User ID - merkleId submodule does not currently handle consent strings'); }); @@ -187,19 +187,19 @@ describe('Merkle System', function () { }); it('extendId() get storedid', function () { - let config = { + const config = { params: { ...CONFIG_PARAMS, }, storage: STORAGE_PARAMS }; - let id = merkleIdSubmodule.extendId(config, undefined, 'Merkle_Stored_ID'); + const id = merkleIdSubmodule.extendId(config, undefined, 'Merkle_Stored_ID'); expect(id.id).to.exist.and.to.equal('Merkle_Stored_ID'); }); it('extendId() get storedId on configured storageParam.refreshInSeconds', function () { - let config = { + const config = { params: { ...CONFIG_PARAMS, refreshInSeconds: 1000 @@ -207,16 +207,16 @@ describe('Merkle System', function () { storage: STORAGE_PARAMS }; - let yesterday = new Date(Date.now() - 86400000).toUTCString(); - let storedId = {value: 'Merkle_Stored_ID', date: yesterday}; + const yesterday = new Date(Date.now() - 86400000).toUTCString(); + const storedId = {value: 'Merkle_Stored_ID', date: yesterday}; - let id = merkleIdSubmodule.extendId(config, undefined, + const id = merkleIdSubmodule.extendId(config, undefined, storedId); expect(id.id).to.exist.and.to.equal(storedId); }); it('extendId() should warn on missing endpoint', function () { - let config = { + const config = { params: { ...CONFIG_PARAMS, endpoint: undefined @@ -224,10 +224,10 @@ describe('Merkle System', function () { storage: STORAGE_PARAMS }; - let yesterday = new Date(Date.now() - 86400000).toUTCString(); - let storedId = {value: 'Merkle_Stored_ID', date: yesterday}; + const yesterday = new Date(Date.now() - 86400000).toUTCString(); + const storedId = {value: 'Merkle_Stored_ID', date: yesterday}; - let submoduleCallback = merkleIdSubmodule.extendId(config, undefined, + const submoduleCallback = merkleIdSubmodule.extendId(config, undefined, storedId).callback; submoduleCallback(callbackSpy); expect(callbackSpy.calledOnce).to.be.true; @@ -235,17 +235,17 @@ describe('Merkle System', function () { }); it('extendId() callback on configured storageParam.refreshInSeconds', function () { - let config = { + const config = { params: { ...CONFIG_PARAMS, refreshInSeconds: 1 } }; - let yesterday = new Date(Date.now() - 86400000).toUTCString(); - let storedId = {value: 'Merkle_Stored_ID', date: yesterday}; + const yesterday = new Date(Date.now() - 86400000).toUTCString(); + const storedId = {value: 'Merkle_Stored_ID', date: yesterday}; - let submoduleCallback = merkleIdSubmodule.extendId(config, undefined, storedId).callback; + const submoduleCallback = merkleIdSubmodule.extendId(config, undefined, storedId).callback; submoduleCallback(callbackSpy); expect(callbackSpy.calledOnce).to.be.true; }); diff --git a/test/spec/modules/mgidBidAdapter_spec.js b/test/spec/modules/mgidBidAdapter_spec.js index 7e5738a8990..89c97c21781 100644 --- a/test/spec/modules/mgidBidAdapter_spec.js +++ b/test/spec/modules/mgidBidAdapter_spec.js @@ -37,7 +37,7 @@ describe('Mgid bid adapter', function () { }); describe('isBidRequestValid', function () { - let sbid = { + const sbid = { 'adUnitCode': 'div', 'bidder': 'mgid', 'params': { @@ -47,26 +47,26 @@ describe('Mgid bid adapter', function () { }; it('should not accept bid without required params', function () { - let isValid = spec.isBidRequestValid(sbid); + const isValid = spec.isBidRequestValid(sbid); expect(isValid).to.equal(false); }); it('should return false when params are not passed', function () { - let bid = Object.assign({}, sbid); + const bid = Object.assign({}, sbid); delete bid.params; bid.params = {}; expect(spec.isBidRequestValid(bid)).to.equal(false); }); it('should return false when valid params are not passed', function () { - let bid = Object.assign({}, sbid); + const bid = Object.assign({}, sbid); delete bid.params; bid.params = {accountId: '', placementId: ''}; expect(spec.isBidRequestValid(bid)).to.equal(false); }); it('should return false when valid params are not passed', function () { - let bid = Object.assign({}, sbid); + const bid = Object.assign({}, sbid); delete bid.params; bid.adUnitCode = ''; bid.mediaTypes = { @@ -79,7 +79,7 @@ describe('Mgid bid adapter', function () { }); it('should return false when adUnitCode not passed', function () { - let bid = Object.assign({}, sbid); + const bid = Object.assign({}, sbid); delete bid.params; bid.adUnitCode = ''; bid.mediaTypes = { @@ -92,7 +92,7 @@ describe('Mgid bid adapter', function () { }); it('should return true when valid params are passed as nums', function () { - let bid = Object.assign({}, sbid); + const bid = Object.assign({}, sbid); delete bid.params; bid.adUnitCode = 'div'; bid.mediaTypes = { @@ -105,7 +105,7 @@ describe('Mgid bid adapter', function () { }); it('should return false when valid params are not passed', function () { - let bid = Object.assign({}, sbid); + const bid = Object.assign({}, sbid); delete bid.params; bid.mediaTypes = { native: { @@ -117,14 +117,14 @@ describe('Mgid bid adapter', function () { }); it('should return false when valid mediaTypes are not passed', function () { - let bid = Object.assign({}, sbid); + const bid = Object.assign({}, sbid); delete bid.params; bid.params = {accountId: '1', placementId: '1'}; expect(spec.isBidRequestValid(bid)).to.equal(false); }); it('should return false when valid mediaTypes.banner are not passed', function () { - let bid = Object.assign({}, sbid); + const bid = Object.assign({}, sbid); delete bid.params; bid.params = {accountId: '1', placementId: '1'}; bid.mediaTypes = { @@ -133,7 +133,7 @@ describe('Mgid bid adapter', function () { }); it('should return false when valid mediaTypes.banner.sizes are not passed', function () { - let bid = Object.assign({}, sbid); + const bid = Object.assign({}, sbid); delete bid.params; bid.params = {accountId: '1', placementId: '1'}; bid.mediaTypes = { @@ -143,7 +143,7 @@ describe('Mgid bid adapter', function () { }); it('should return false when valid mediaTypes.banner.sizes are not valid', function () { - let bid = Object.assign({}, sbid); + const bid = Object.assign({}, sbid); delete bid.params; bid.params = {accountId: '1', placementId: '1'}; bid.mediaTypes = { @@ -153,7 +153,7 @@ describe('Mgid bid adapter', function () { }); it('should return true when valid params are passed as strings', function () { - let bid = Object.assign({}, sbid); + const bid = Object.assign({}, sbid); delete bid.params; bid.adUnitCode = 'div'; bid.params = {accountId: '1', placementId: '1'}; @@ -166,7 +166,7 @@ describe('Mgid bid adapter', function () { }); it('should return false when valid mediaTypes.native is not object', function () { - let bid = Object.assign({}, sbid); + const bid = Object.assign({}, sbid); bid.params = {accountId: '1', placementId: '1'}; bid.mediaTypes = { native: [] @@ -175,7 +175,7 @@ describe('Mgid bid adapter', function () { }); it('should return false when mediaTypes.native is empty object', function () { - let bid = Object.assign({}, sbid); + const bid = Object.assign({}, sbid); delete bid.params; bid.params = {accountId: '1', placementId: '1'}; bid.mediaTypes = { @@ -185,7 +185,7 @@ describe('Mgid bid adapter', function () { }); it('should return false when mediaTypes.native is invalid object', function () { - let bid = Object.assign({}, sbid); + const bid = Object.assign({}, sbid); delete bid.params; bid.params = {accountId: '1', placementId: '1'}; bid.mediaTypes = { @@ -199,7 +199,7 @@ describe('Mgid bid adapter', function () { }); it('should return false when mediaTypes.native has unsupported required asset', function () { - let bid = Object.assign({}, sbid); + const bid = Object.assign({}, sbid); bid.params = {accountId: '2', placementId: '1'}; bid.mediaTypes = { native: { @@ -218,7 +218,7 @@ describe('Mgid bid adapter', function () { }); it('should return true when mediaTypes.native all assets needed', function () { - let bid = Object.assign({}, sbid); + const bid = Object.assign({}, sbid); bid.adUnitCode = 'div'; bid.params = {accountId: '2', placementId: '1'}; bid.mediaTypes = { @@ -238,7 +238,7 @@ describe('Mgid bid adapter', function () { }); describe('override defaults', function () { - let sbid = { + const sbid = { bidder: 'mgid', params: { accountId: '1', @@ -246,19 +246,19 @@ describe('Mgid bid adapter', function () { }, }; it('should return object', function () { - let bid = Object.assign({}, sbid); + const bid = Object.assign({}, sbid); bid.mediaTypes = { banner: { sizes: [[300, 250]] } }; - let bidRequests = [bid]; + const bidRequests = [bid]; const request = spec.buildRequests(bidRequests); expect(request).to.exist.and.to.be.a('object'); }); it('should return overwrite default bidurl', function () { - let bid = Object.assign({}, sbid); + const bid = Object.assign({}, sbid); bid.params = { bidUrl: 'https://newbidurl.com/', accountId: '1', @@ -269,12 +269,12 @@ describe('Mgid bid adapter', function () { sizes: [[300, 250]] } }; - let bidRequests = [bid]; + const bidRequests = [bid]; const request = spec.buildRequests(bidRequests); expect(request.url).to.include('https://newbidurl.com/1'); }); it('should return overwrite default bidFloor', function () { - let bid = Object.assign({}, sbid); + const bid = Object.assign({}, sbid); bid.params = { bidFloor: 1.1, accountId: '1', @@ -285,7 +285,7 @@ describe('Mgid bid adapter', function () { sizes: [[300, 250]] } }; - let bidRequests = [bid]; + const bidRequests = [bid]; const request = spec.buildRequests(bidRequests); expect(request.data).to.be.a('string'); const data = JSON.parse(request.data); @@ -295,7 +295,7 @@ describe('Mgid bid adapter', function () { expect(data.imp[0].bidfloor).to.deep.equal(1.1); }); it('should return overwrite default currency', function () { - let bid = Object.assign({}, sbid); + const bid = Object.assign({}, sbid); bid.params = { cur: 'GBP', accountId: '1', @@ -306,7 +306,7 @@ describe('Mgid bid adapter', function () { sizes: [[300, 250]] } }; - let bidRequests = [bid]; + const bidRequests = [bid]; const request = spec.buildRequests(bidRequests); expect(request.data).to.be.a('string'); const data = JSON.parse(request.data); @@ -316,7 +316,7 @@ describe('Mgid bid adapter', function () { }); describe('buildRequests', function () { - let abid = { + const abid = { adUnitCode: 'div', bidder: 'mgid', ortb2Imp: { @@ -340,16 +340,16 @@ describe('Mgid bid adapter', function () { expect(spec.buildRequests([])).to.be.undefined; }); it('should return request url with muid', function () { - let getDataFromLocalStorageStub = sinon.stub(storage, 'getDataFromLocalStorage'); + const getDataFromLocalStorageStub = sinon.stub(storage, 'getDataFromLocalStorage'); getDataFromLocalStorageStub.withArgs('mgMuidn').returns('xxx'); - let bid = Object.assign({}, abid); + const bid = Object.assign({}, abid); bid.mediaTypes = { banner: { sizes: [[300, 250]] } }; - let bidRequests = [bid]; + const bidRequests = [bid]; const request = spec.buildRequests(bidRequests); expect(request.url).deep.equal('https://prebid.mgid.com/prebid/1?muid=xxx'); @@ -357,13 +357,13 @@ describe('Mgid bid adapter', function () { }); it('should proper handle gdpr', function () { config.setConfig({coppa: 1}) - let bid = Object.assign({}, abid); + const bid = Object.assign({}, abid); bid.mediaTypes = { banner: { sizes: [[300, 250]] } }; - let bidRequests = [bid]; + const bidRequests = [bid]; const request = spec.buildRequests(bidRequests, {gdprConsent: {consentString: 'gdpr', gdprApplies: true}, uspConsent: 'usp', gppConsent: {gppString: 'gpp'}}); expect(request.url).deep.equal('https://prebid.mgid.com/prebid/1'); expect(request.method).deep.equal('POST'); @@ -372,13 +372,13 @@ describe('Mgid bid adapter', function () { expect(data.regs).deep.equal({ext: {gdpr: 1, us_privacy: 'usp'}, gpp: 'gpp', coppa: 1}); }); it('should handle refererInfo', function () { - let bid = Object.assign({}, abid); + const bid = Object.assign({}, abid); bid.mediaTypes = { banner: { sizes: [[300, 250]] } }; - let bidRequests = [bid]; + const bidRequests = [bid]; const domain = 'site.com' const page = `http://${domain}/site.html` const ref = 'http://ref.com/ref.html' @@ -391,7 +391,7 @@ describe('Mgid bid adapter', function () { expect(data.site.ref).to.deep.equal(ref); }); it('should handle schain', function () { - let bid = Object.assign({}, abid); + const bid = Object.assign({}, abid); bid.mediaTypes = { banner: { sizes: [[300, 250]] @@ -401,19 +401,19 @@ describe('Mgid bid adapter', function () { bid.ortb2.source = bid.ortb2.source || {}; bid.ortb2.source.ext = bid.ortb2.source.ext || {}; bid.ortb2.source.ext.schain = ['schain1', 'schain2']; - let bidRequests = [bid]; + const bidRequests = [bid]; const request = spec.buildRequests(bidRequests); const data = JSON.parse(request.data); expect(data.source).to.deep.equal({ext: {schain: bid.ortb2.source.ext.schain}}); }); it('should handle userId', function () { - let bid = Object.assign({}, abid); + const bid = Object.assign({}, abid); bid.mediaTypes = { banner: { sizes: [[300, 250]] } }; - let bidRequests = [bid]; + const bidRequests = [bid]; const bidderRequest = {userId: 'userid'}; const request = spec.buildRequests(bidRequests, bidderRequest); expect(request.url).deep.equal('https://prebid.mgid.com/prebid/1'); @@ -422,26 +422,26 @@ describe('Mgid bid adapter', function () { expect(data.user.id).to.deep.equal(bidderRequest.userId); }); it('should handle eids', function () { - let bid = Object.assign({}, abid); + const bid = Object.assign({}, abid); bid.mediaTypes = { banner: { sizes: [[300, 250]] } }; bid.userIdAsEids = ['eid1', 'eid2'] - let bidRequests = [bid]; + const bidRequests = [bid]; const request = spec.buildRequests(bidRequests); const data = JSON.parse(request.data); expect(data.user.ext.eids).to.deep.equal(bid.userIdAsEids); }); it('should return proper banner imp', function () { - let bid = Object.assign({}, abid); + const bid = Object.assign({}, abid); bid.mediaTypes = { banner: { sizes: [[300, 250]] } }; - let bidRequests = [bid]; + const bidRequests = [bid]; const page = top.location.href; const domain = utils.parseUrl(page).hostname; const request = spec.buildRequests(bidRequests); @@ -467,7 +467,7 @@ describe('Mgid bid adapter', function () { }); }); it('should not return native imp if minimum asset list not requested', function () { - let bid = Object.assign({}, abid); + const bid = Object.assign({}, abid); bid.mediaTypes = { native: '', }; @@ -475,12 +475,12 @@ describe('Mgid bid adapter', function () { title: {required: true}, image: {sizes: [80, 80]}, }; - let bidRequests = [bid]; + const bidRequests = [bid]; const request = spec.buildRequests(bidRequests); expect(request).to.be.undefined; }); it('should return proper native imp', function () { - let bid = Object.assign({}, abid); + const bid = Object.assign({}, abid); bid.mediaTypes = { native: '', }; @@ -490,7 +490,7 @@ describe('Mgid bid adapter', function () { sponsored: { }, }; - let bidRequests = [bid]; + const bidRequests = [bid]; const page = top.location.href; const domain = utils.parseUrl(page).hostname; const request = spec.buildRequests(bidRequests); @@ -517,7 +517,7 @@ describe('Mgid bid adapter', function () { }); }); it('should return proper native imp with image altered', function () { - let bid = Object.assign({}, abid); + const bid = Object.assign({}, abid); bid.mediaTypes = { native: '', }; @@ -528,7 +528,7 @@ describe('Mgid bid adapter', function () { sponsored: { }, }; - let bidRequests = [bid]; + const bidRequests = [bid]; const page = top.location.href; const domain = utils.parseUrl(page).hostname; const request = spec.buildRequests(bidRequests); @@ -554,7 +554,7 @@ describe('Mgid bid adapter', function () { }); }); it('should return proper native imp with sponsoredBy', function () { - let bid = Object.assign({}, abid); + const bid = Object.assign({}, abid); bid.mediaTypes = { native: '', }; @@ -564,7 +564,7 @@ describe('Mgid bid adapter', function () { sponsoredBy: { }, }; - let bidRequests = [bid]; + const bidRequests = [bid]; const page = top.location.href; const domain = utils.parseUrl(page).hostname; const request = spec.buildRequests(bidRequests); @@ -590,14 +590,14 @@ describe('Mgid bid adapter', function () { }); }); it('should return proper banner request', function () { - let bid = Object.assign({}, abid); + const bid = Object.assign({}, abid); bid.mediaTypes = { banner: { sizes: [[300, 600], [300, 250]], pos: 1, }, }; - let bidRequests = [bid]; + const bidRequests = [bid]; const request = spec.buildRequests(bidRequests); const page = top.location.href; @@ -624,15 +624,15 @@ describe('Mgid bid adapter', function () { }); }); it('should proper handle ortb2 data', function () { - let bid = Object.assign({}, abid); + const bid = Object.assign({}, abid); bid.mediaTypes = { banner: { sizes: [[300, 250]] } }; - let bidRequests = [bid]; + const bidRequests = [bid]; - let bidderRequest = { + const bidderRequest = { gdprConsent: { consentString: 'consent1', gdprApplies: false, @@ -694,24 +694,24 @@ describe('Mgid bid adapter', function () { describe('interpretResponse', function () { it('should not push proper native bid response if adm is missing', function () { - let resp = { + const resp = { body: {'id': '57c0c2b1b732ca', 'bidid': '57c0c2b1b732ca', 'cur': 'GBP', 'seatbid': [{'bid': [{'price': 1.5, 'h': 600, 'w': 300, 'id': '1', 'impid': '61e40632c53fc2', 'adid': '2898532/2419121/2592854/2499195', 'nurl': 'https nurl', 'burl': 'https burl', 'cid': '44082', 'crid': '2898532/2419121/2592854/2499195', 'cat': ['IAB7', 'IAB14', 'IAB18-3', 'IAB1-2'], 'ext': {'place': 0, 'crtype': 'native'}, 'adomain': ['test.com']}], 'seat': '44082'}]} }; - let bids = spec.interpretResponse(resp); + const bids = spec.interpretResponse(resp); expect(bids).to.deep.equal([]) }); it('should not push proper native bid response if assets is empty', function () { - let resp = { + const resp = { body: {'id': '57c0c2b1b732ca', 'bidid': '57c0c2b1b732ca', 'cur': 'GBP', 'seatbid': [{'bid': [{'price': 1.5, 'h': 600, 'w': 300, 'id': '1', 'impid': '61e40632c53fc2', 'adid': '2898532/2419121/2592854/2499195', 'nurl': 'https nurl', 'burl': 'https burl', 'adm': '{"native":{"ver":"1.1","link":{"url":"link_url"},"assets":[],"imptrackers":["imptrackers1"]}}', 'cid': '44082', 'crid': '2898532/2419121/2592854/2499195', 'cat': ['IAB7', 'IAB14', 'IAB18-3', 'IAB1-2'], 'ext': {'place': 0, 'crtype': 'native'}, 'adomain': ['test.com']}], 'seat': '44082'}]} }; - let bids = spec.interpretResponse(resp); + const bids = spec.interpretResponse(resp); expect(bids).to.deep.equal([]) }); it('should push proper native bid response, assets1', function () { - let resp = { + const resp = { body: {'id': '57c0c2b1b732ca', 'bidid': '57c0c2b1b732ca', 'cur': 'GBP', 'seatbid': [{'bid': [{'price': 1.5, 'h': 600, 'w': 300, 'id': '1', 'impid': '61e40632c53fc2', 'adid': '2898532/2419121/2592854/2499195', 'nurl': 'https nurl', 'burl': 'https burl', 'adm': '{"native":{"ver":"1.1","link":{"url":"link_url"},"assets":[{"id":1,"required":0,"title":{"text":"title1"}},{"id":2,"required":0,"img":{"w":80,"h":80,"type":3,"url":"image_src"}},{"id":3,"required":0,"img":{"w":50,"h":50,"type":1,"url":"icon_src"}},{"id":4,"required":0,"data":{"type":4,"value":"sponsored"}},{"id":5,"required":0,"data":{"type":6,"value":"price1"}},{"id":6,"required":0,"data":{"type":7,"value":"price2"}}],"imptrackers":["imptrackers1"]}}', 'cid': '44082', 'crid': '2898532/2419121/2592854/2499195', 'cat': ['IAB7', 'IAB14', 'IAB18-3', 'IAB1-2'], 'ext': {'place': 0, 'crtype': 'native'}, 'adomain': ['test.com']}], 'seat': '44082'}], ext: {'muidn': 'userid'}} }; - let bids = spec.interpretResponse(resp); + const bids = spec.interpretResponse(resp); expect(bids).to.deep.equal([{ 'ad': '{"native":{"ver":"1.1","link":{"url":"link_url"},"assets":[{"id":1,"required":0,"title":{"text":"title1"}},{"id":2,"required":0,"img":{"w":80,"h":80,"type":3,"url":"image_src"}},{"id":3,"required":0,"img":{"w":50,"h":50,"type":1,"url":"icon_src"}},{"id":4,"required":0,"data":{"type":4,"value":"sponsored"}},{"id":5,"required":0,"data":{"type":6,"value":"price1"}},{"id":6,"required":0,"data":{"type":7,"value":"price2"}}],"imptrackers":["imptrackers1"]}}', 'burl': 'https burl', @@ -752,10 +752,10 @@ describe('Mgid bid adapter', function () { }]) }); it('should push proper native bid response, assets2', function () { - let resp = { + const resp = { body: {'id': '57c0c2b1b732ca', 'bidid': '57c0c2b1b732ca', 'cur': 'GBP', 'seatbid': [{'bid': [{'price': 1.5, 'h': 600, 'w': 300, 'id': '1', 'impid': '61e40632c53fc2', 'adid': '2898532/2419121/2592854/2499195', 'nurl': 'https nurl', 'burl': 'https burl', 'adm': '{"native":{"ver":"1.1","link":{"url":"link_url"},"assets":[{"id":1,"required":0,"title":{"text":"title1"}},{"id":2,"required":0,"img":{"w":80,"h":80,"type":3,"url":"image_src"}},{"id":3,"required":0,"img":{"w":50,"h":50,"type":1,"url":"icon_src"}}],"imptrackers":["imptrackers1"]}}', 'cid': '44082', 'crid': '2898532/2419121/2592854/2499195', 'cat': ['IAB7', 'IAB14', 'IAB18-3', 'IAB1-2'], 'ext': {'place': 0, 'crtype': 'native'}, 'adomain': ['test.com']}], 'seat': '44082'}]} }; - let bids = spec.interpretResponse(resp); + const bids = spec.interpretResponse(resp); expect(bids).to.deep.equal([ { 'ad': '{"native":{"ver":"1.1","link":{"url":"link_url"},"assets":[{"id":1,"required":0,"title":{"text":"title1"}},{"id":2,"required":0,"img":{"w":80,"h":80,"type":3,"url":"image_src"}},{"id":3,"required":0,"img":{"w":50,"h":50,"type":1,"url":"icon_src"}}],"imptrackers":["imptrackers1"]}}', @@ -795,14 +795,14 @@ describe('Mgid bid adapter', function () { }); it('should not push bid response', function () { - let bids = spec.interpretResponse(); + const bids = spec.interpretResponse(); expect(bids).to.be.undefined; }); it('should push proper banner bid response', function () { - let resp = { + const resp = { body: {'id': '57c0c2b1b732ca', 'bidid': '57c0c2b1b732ca', 'cur': '', 'seatbid': [{'bid': [{'price': 1.5, 'h': 600, 'w': 300, 'id': '1', 'impid': '61e40632c53fc2', 'adid': '2898532/2419121/2592854/2499195', 'nurl': 'https nurl', 'burl': 'https burl', 'adm': 'html: adm', 'cid': '44082', 'crid': '2898532/2419121/2592854/2499195', 'cat': ['IAB7', 'IAB14', 'IAB18-3', 'IAB1-2'], 'adomain': ['test.com']}], 'seat': '44082'}]} }; - let bids = spec.interpretResponse(resp); + const bids = spec.interpretResponse(resp); expect(bids).to.deep.equal([ { 'ad': 'html: adm', @@ -920,7 +920,7 @@ describe('Mgid bid adapter', function () { describe('price floor module', function() { let bidRequest; - let bidRequests0 = { + const bidRequests0 = { adUnitCode: 'div', bidder: 'mgid', params: { diff --git a/test/spec/modules/mgidRtdProvider_spec.js b/test/spec/modules/mgidRtdProvider_spec.js index 996875649b6..54dd99baf3e 100644 --- a/test/spec/modules/mgidRtdProvider_spec.js +++ b/test/spec/modules/mgidRtdProvider_spec.js @@ -42,7 +42,7 @@ describe('Mgid RTD submodule', () => { muid: 'qwerty654321', }; - let reqBidsConfigObj = { + const reqBidsConfigObj = { ortb2Fragments: { global: { site: { @@ -54,7 +54,7 @@ describe('Mgid RTD submodule', () => { } }; - let onDone = sinon.stub(); + const onDone = sinon.stub(); mgidSubmodule.getBidRequestData( reqBidsConfigObj, @@ -123,13 +123,13 @@ describe('Mgid RTD submodule', () => { }); it('getBidRequestData doesn\'t send params (consent and cxlang), if we haven\'t received them', () => { - let reqBidsConfigObj = { + const reqBidsConfigObj = { ortb2Fragments: { global: {}, } }; - let onDone = sinon.stub(); + const onDone = sinon.stub(); mgidSubmodule.getBidRequestData( reqBidsConfigObj, @@ -157,13 +157,13 @@ describe('Mgid RTD submodule', () => { }); it('getBidRequestData send gdprApplies event if it is false', () => { - let reqBidsConfigObj = { + const reqBidsConfigObj = { ortb2Fragments: { global: {}, } }; - let onDone = sinon.stub(); + const onDone = sinon.stub(); mgidSubmodule.getBidRequestData( reqBidsConfigObj, @@ -197,15 +197,15 @@ describe('Mgid RTD submodule', () => { }); it('getBidRequestData use og:url for cxurl, if it is available', () => { - let reqBidsConfigObj = { + const reqBidsConfigObj = { ortb2Fragments: { global: {}, } }; - let onDone = sinon.stub(); + const onDone = sinon.stub(); - let metaStub = sinon.stub(document, 'getElementsByTagName').returns([ + const metaStub = sinon.stub(document, 'getElementsByTagName').returns([ { getAttribute: () => 'og:test', content: 'fake' }, { getAttribute: () => 'og:url', content: 'https://realOgUrl.com/' } ]); @@ -231,13 +231,13 @@ describe('Mgid RTD submodule', () => { }); it('getBidRequestData use topMostLocation for cxurl, if nothing else left', () => { - let reqBidsConfigObj = { + const reqBidsConfigObj = { ortb2Fragments: { global: {}, } }; - let onDone = sinon.stub(); + const onDone = sinon.stub(); getRefererInfoStub.returns({ topmostLocation: 'https://www.test.com/topMost' @@ -262,13 +262,13 @@ describe('Mgid RTD submodule', () => { }); it('getBidRequestData won\'t modify ortb2 if response is broken', () => { - let reqBidsConfigObj = { + const reqBidsConfigObj = { ortb2Fragments: { global: {}, } }; - let onDone = sinon.stub(); + const onDone = sinon.stub(); mgidSubmodule.getBidRequestData( reqBidsConfigObj, @@ -288,13 +288,13 @@ describe('Mgid RTD submodule', () => { }); it('getBidRequestData won\'t modify ortb2 if response status is not 200', () => { - let reqBidsConfigObj = { + const reqBidsConfigObj = { ortb2Fragments: { global: {}, } }; - let onDone = sinon.stub(); + const onDone = sinon.stub(); mgidSubmodule.getBidRequestData( reqBidsConfigObj, @@ -313,13 +313,13 @@ describe('Mgid RTD submodule', () => { }); it('getBidRequestData won\'t modify ortb2 if response results in error', () => { - let reqBidsConfigObj = { + const reqBidsConfigObj = { ortb2Fragments: { global: {}, } }; - let onDone = sinon.stub(); + const onDone = sinon.stub(); mgidSubmodule.getBidRequestData( reqBidsConfigObj, @@ -339,13 +339,13 @@ describe('Mgid RTD submodule', () => { }); it('getBidRequestData won\'t modify ortb2 if response time hits timeout', () => { - let reqBidsConfigObj = { + const reqBidsConfigObj = { ortb2Fragments: { global: {}, } }; - let onDone = sinon.stub(); + const onDone = sinon.stub(); mgidSubmodule.getBidRequestData( reqBidsConfigObj, diff --git a/test/spec/modules/mgidXBidAdapter_spec.js b/test/spec/modules/mgidXBidAdapter_spec.js index f933a61ee55..c36c33f9c1f 100644 --- a/test/spec/modules/mgidXBidAdapter_spec.js +++ b/test/spec/modules/mgidXBidAdapter_spec.js @@ -144,7 +144,7 @@ describe('MGIDXBidAdapter', function () { }); it('Returns general data valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys('deviceWidth', 'deviceHeight', @@ -224,7 +224,7 @@ describe('MGIDXBidAdapter', function () { } ]; - let serverRequest = spec.buildRequests(bids, bidderRequest); + const serverRequest = spec.buildRequests(bids, bidderRequest); const { placements } = serverRequest.data; for (let i = 0, len = placements.length; i < len; i++) { @@ -259,7 +259,7 @@ describe('MGIDXBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { delete bidderRequest.uspConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('object'); expect(data.gdpr).to.have.property('consentString'); @@ -273,7 +273,7 @@ describe('MGIDXBidAdapter', function () { bidderRequest.uspConsent = '1---'; delete bidderRequest.gdprConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -288,8 +288,8 @@ describe('MGIDXBidAdapter', function () { applicableSections: [8] }; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -303,8 +303,8 @@ describe('MGIDXBidAdapter', function () { bidderRequest.ortb2.regs.gpp = 'abc123'; bidderRequest.ortb2.regs.gpp_sid = [8]; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -334,9 +334,9 @@ describe('MGIDXBidAdapter', function () { } }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(banner.body[0].requestId); @@ -368,10 +368,10 @@ describe('MGIDXBidAdapter', function () { } }] }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -405,10 +405,10 @@ describe('MGIDXBidAdapter', function () { } }] }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys('requestId', 'cpm', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'native', 'meta'); expect(dataItem.native).to.have.keys('clickUrl', 'impressionTrackers', 'title', 'image') expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -439,7 +439,7 @@ describe('MGIDXBidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -455,7 +455,7 @@ describe('MGIDXBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -472,7 +472,7 @@ describe('MGIDXBidAdapter', function () { currency: 'USD', }] }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -485,7 +485,7 @@ describe('MGIDXBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/minutemediaBidAdapter_spec.js b/test/spec/modules/minutemediaBidAdapter_spec.js index ce3ab6dd9d7..7281e1ae307 100644 --- a/test/spec/modules/minutemediaBidAdapter_spec.js +++ b/test/spec/modules/minutemediaBidAdapter_spec.js @@ -439,57 +439,33 @@ describe('minutemediaAdapter', function () { 'architecture': 'x86' } const bid = utils.deepClone(bidRequests[0]); - bid.ortb2 = { + const bidderRequestWithSua = utils.deepClone(bidderRequest); + bidderRequestWithSua.ortb2 = { 'device': { - 'sua': { - 'platform': { - 'brand': 'macOS', - 'version': [ '12', '4', '0' ] - }, - 'browsers': [ - { - 'brand': 'Chromium', - 'version': [ '106', '0', '5249', '119' ] - }, - { - 'brand': 'Google Chrome', - 'version': [ '106', '0', '5249', '119' ] - }, - { - 'brand': 'Not;A=Brand', - 'version': [ '99', '0', '0', '0' ] - } - ], - 'mobile': 0, - 'model': '', - 'bitness': '64', - 'architecture': 'x86' - } + 'sua': sua } - } - const requestWithSua = spec.buildRequests([bid], bidderRequest); + }; + const requestWithSua = spec.buildRequests([bid], bidderRequestWithSua); const data = requestWithSua.data; - expect(data.bids[0].sua).to.exist; - expect(data.bids[0].sua).to.deep.equal(sua); - const request = spec.buildRequests(bidRequests, bidderRequest); - expect(request.data.bids[0].sua).to.not.exist; + expect(data.params.sua).to.exist; + expect(data.params.sua).to.deep.equal(JSON.stringify(sua)); }); describe('COPPA Param', function() { - it('should set coppa equal 0 in bid request if coppa is set to false', function() { + it('should set coppa equal 0 in bid request if coppa is set to 0', function() { const request = spec.buildRequests(bidRequests, bidderRequest); - expect(request.data.bids[0].coppa).to.be.equal(0); + expect(request.data.params.coppa).to.be.equal(0); }); - it('should set coppa equal 1 in bid request if coppa is set to true', function() { - const bid = utils.deepClone(bidRequests[0]); - bid.ortb2 = { + it('should set coppa equal 1 in bid request if coppa is set to 1', function() { + const bidderRequestWithCoppa = utils.deepClone(bidderRequest); + bidderRequestWithCoppa.ortb2 = { 'regs': { - 'coppa': true, + 'coppa': 1, } }; - const request = spec.buildRequests([bid], bidderRequest); - expect(request.data.bids[0].coppa).to.be.equal(1); + const request = spec.buildRequests(bidRequests, bidderRequestWithCoppa); + expect(request.data.params.coppa).to.be.equal(1); }); }); }); diff --git a/test/spec/modules/missenaBidAdapter_spec.js b/test/spec/modules/missenaBidAdapter_spec.js index cab2647d6d3..8689eb0174e 100644 --- a/test/spec/modules/missenaBidAdapter_spec.js +++ b/test/spec/modules/missenaBidAdapter_spec.js @@ -18,7 +18,7 @@ describe('Missena Adapter', function () { storageAllowed: true, }, }; - let sandbox = sinon.createSandbox(); + const sandbox = sinon.createSandbox(); sandbox.stub(config, 'getConfig').withArgs('coppa').returns(true); sandbox.stub(autoplay, 'isAutoplayEnabled').returns(false); const viewport = { width: getWinDimensions().innerWidth, height: getWinDimensions().innerHeight }; diff --git a/test/spec/modules/mobfoxpbBidAdapter_spec.js b/test/spec/modules/mobfoxpbBidAdapter_spec.js index c926c2c9bfc..8377eea24a3 100644 --- a/test/spec/modules/mobfoxpbBidAdapter_spec.js +++ b/test/spec/modules/mobfoxpbBidAdapter_spec.js @@ -132,7 +132,7 @@ describe('MobfoxHBBidAdapter', function () { }); it('Returns general data valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys('deviceWidth', 'deviceHeight', @@ -213,7 +213,7 @@ describe('MobfoxHBBidAdapter', function () { } ]; - let serverRequest = spec.buildRequests(bids, bidderRequest); + const serverRequest = spec.buildRequests(bids, bidderRequest); const { placements } = serverRequest.data; for (let i = 0, len = placements.length; i < len; i++) { @@ -248,7 +248,7 @@ describe('MobfoxHBBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { delete bidderRequest.uspConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('object'); expect(data.gdpr).to.have.property('consentString'); @@ -262,7 +262,7 @@ describe('MobfoxHBBidAdapter', function () { bidderRequest.uspConsent = '1---'; delete bidderRequest.gdprConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -277,8 +277,8 @@ describe('MobfoxHBBidAdapter', function () { applicableSections: [8] }; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -292,8 +292,8 @@ describe('MobfoxHBBidAdapter', function () { bidderRequest.ortb2.regs.gpp = 'abc123'; bidderRequest.ortb2.regs.gpp_sid = [8]; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -323,9 +323,9 @@ describe('MobfoxHBBidAdapter', function () { } }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(banner.body[0].requestId); @@ -357,10 +357,10 @@ describe('MobfoxHBBidAdapter', function () { } }] }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -394,10 +394,10 @@ describe('MobfoxHBBidAdapter', function () { } }] }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys('requestId', 'cpm', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'native', 'meta'); expect(dataItem.native).to.have.keys('clickUrl', 'impressionTrackers', 'title', 'image') expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -428,7 +428,7 @@ describe('MobfoxHBBidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -444,7 +444,7 @@ describe('MobfoxHBBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -461,7 +461,7 @@ describe('MobfoxHBBidAdapter', function () { currency: 'USD', }] }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -474,7 +474,7 @@ describe('MobfoxHBBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/multibid_spec.js b/test/spec/modules/multibid_spec.js index b7d9f3f47c5..c48e1d65263 100644 --- a/test/spec/modules/multibid_spec.js +++ b/test/spec/modules/multibid_spec.js @@ -12,7 +12,7 @@ import {config} from 'src/config.js'; import {getHighestCpm} from '../../../src/utils/reducers.js'; describe('multibid adapter', function () { - let bidArray = [{ + const bidArray = [{ 'bidderCode': 'bidderA', 'requestId': '1c5f0a05d3629a', 'cpm': 75, @@ -25,7 +25,7 @@ describe('multibid adapter', function () { 'originalCpm': 52, 'bidder': 'bidderA', }]; - let bidCacheArray = [{ + const bidCacheArray = [{ 'bidderCode': 'bidderA', 'requestId': '1c5f0a05d3629a', 'cpm': 66, @@ -42,7 +42,7 @@ describe('multibid adapter', function () { 'originalBidder': 'bidderA', 'multibidPrefix': 'bidA' }]; - let bidArrayAlt = [{ + const bidArrayAlt = [{ 'bidderCode': 'bidderA', 'requestId': '1c5f0a05d3629a', 'cpm': 29, @@ -67,7 +67,7 @@ describe('multibid adapter', function () { 'originalCpm': 12, 'bidder': 'bidderC' }]; - let bidderRequests = [{ + const bidderRequests = [{ 'bidderCode': 'bidderA', 'auctionId': 'e6bd4400-28fc-459b-9905-ad64d044daaa', 'bidderRequestId': '10e78266423c0e', @@ -125,7 +125,7 @@ describe('multibid adapter', function () { describe('adjustBidderRequestsHook', function () { let result; - let callbackFn = function (bidderRequests) { + const callbackFn = function (bidderRequests) { result = bidderRequests; }; @@ -134,7 +134,7 @@ describe('multibid adapter', function () { }); it('does not modify bidderRequest when no multibid config exists', function () { - let bidRequests = [{...bidderRequests[0]}]; + const bidRequests = [{...bidderRequests[0]}]; adjustBidderRequestsHook(callbackFn, bidRequests); @@ -143,7 +143,7 @@ describe('multibid adapter', function () { }); it('does modify bidderRequest when multibid config exists', function () { - let bidRequests = [{...bidderRequests[0]}]; + const bidRequests = [{...bidderRequests[0]}]; config.setConfig({multibid: [{bidder: 'bidderA', maxBids: 2}]}); @@ -155,7 +155,7 @@ describe('multibid adapter', function () { }); it('does modify bidderRequest when multibid config exists using bidders array', function () { - let bidRequests = [{...bidderRequests[0]}]; + const bidRequests = [{...bidderRequests[0]}]; config.setConfig({multibid: [{bidders: ['bidderA'], maxBids: 2}]}); @@ -167,7 +167,7 @@ describe('multibid adapter', function () { }); it('does only modifies bidderRequest when multibid config exists for bidder', function () { - let bidRequests = [{...bidderRequests[0]}, {...bidderRequests[1]}]; + const bidRequests = [{...bidderRequests[0]}, {...bidderRequests[1]}]; config.setConfig({multibid: [{bidder: 'bidderA', maxBids: 2}]}); @@ -183,7 +183,7 @@ describe('multibid adapter', function () { describe('addBidResponseHook', function () { let result; - let callbackFn = function (adUnitCode, bid) { + const callbackFn = function (adUnitCode, bid) { result = { 'adUnitCode': adUnitCode, 'bid': bid @@ -195,8 +195,8 @@ describe('multibid adapter', function () { }); it('adds original bids and does not modify', function () { - let adUnitCode = 'test.div'; - let bids = [{...bidArray[0]}, {...bidArray[1]}]; + const adUnitCode = 'test.div'; + const bids = [{...bidArray[0]}, {...bidArray[1]}]; addBidResponseHook(callbackFn, adUnitCode, {...bids[0]}); @@ -218,8 +218,8 @@ describe('multibid adapter', function () { }); it('modifies and adds both bids based on multibid configuration', function () { - let adUnitCode = 'test.div'; - let bids = [{...bidArray[0]}, {...bidArray[1]}]; + const adUnitCode = 'test.div'; + const bids = [{...bidArray[0]}, {...bidArray[1]}]; config.setConfig({multibid: [{bidder: 'bidderA', maxBids: 2, targetBiddercodePrefix: 'bidA'}]}); @@ -254,8 +254,8 @@ describe('multibid adapter', function () { }); it('only modifies bids defined in the multibid configuration', function () { - let adUnitCode = 'test.div'; - let bids = [{...bidArray[0]}, {...bidArray[1]}]; + const adUnitCode = 'test.div'; + const bids = [{...bidArray[0]}, {...bidArray[1]}]; bids.push({ 'bidderCode': 'bidderB', @@ -306,7 +306,7 @@ describe('multibid adapter', function () { }); it('only modifies and returns bids under limit for a specific bidder in the multibid configuration', function () { - let adUnitCode = 'test.div'; + const adUnitCode = 'test.div'; let bids = [{...bidArray[0]}, {...bidArray[1]}]; bids.push({ @@ -354,8 +354,8 @@ describe('multibid adapter', function () { }); it('if no prefix in multibid configuration, modifies and returns bids under limit without preifx property', function () { - let adUnitCode = 'test.div'; - let bids = [{...bidArray[0]}, {...bidArray[1]}]; + const adUnitCode = 'test.div'; + const bids = [{...bidArray[0]}, {...bidArray[1]}]; bids.push({ 'bidderCode': 'bidderA', @@ -399,8 +399,8 @@ describe('multibid adapter', function () { }); it('does not include extra bids if cpm is less than floor value', function () { - let adUnitCode = 'test.div'; - let bids = [{...bidArrayAlt[1]}, {...bidArrayAlt[0]}, {...bidArrayAlt[2]}, {...bidArrayAlt[3]}]; + const adUnitCode = 'test.div'; + const bids = [{...bidArrayAlt[1]}, {...bidArrayAlt[0]}, {...bidArrayAlt[2]}, {...bidArrayAlt[3]}]; bids.map(bid => { bid.floorData = { @@ -468,8 +468,8 @@ describe('multibid adapter', function () { }); it('does include extra bids if cpm is not less than floor value', function () { - let adUnitCode = 'test.div'; - let bids = [{...bidArrayAlt[1]}, {...bidArrayAlt[0]}]; + const adUnitCode = 'test.div'; + const bids = [{...bidArrayAlt[1]}, {...bidArrayAlt[0]}]; bids.map(bid => { bid.floorData = { @@ -526,14 +526,14 @@ describe('multibid adapter', function () { describe('targetBidPoolHook', function () { let result; let bidResult; - let callbackFn = function (bidsReceived, highestCpmCallback, adUnitBidLimit = 0, hasModified = false) { + const callbackFn = function (bidsReceived, highestCpmCallback, adUnitBidLimit = 0, hasModified = false) { result = { 'bidsReceived': bidsReceived, 'adUnitBidLimit': adUnitBidLimit, 'hasModified': hasModified }; }; - let bidResponseCallback = function (adUnitCode, bid) { + const bidResponseCallback = function (adUnitCode, bid) { bidResult = bid; }; @@ -543,7 +543,7 @@ describe('multibid adapter', function () { }); it('it does not run filter on bidsReceived if no multibid configuration found', function () { - let bids = [{...bidArray[0]}, {...bidArray[1]}]; + const bids = [{...bidArray[0]}, {...bidArray[1]}]; targetBidPoolHook(callbackFn, bids, getHighestCpm); expect(result).to.not.equal(null); @@ -557,7 +557,7 @@ describe('multibid adapter', function () { }); it('it does filter on bidsReceived if multibid configuration found with no prefix', function () { - let bids = [{...bidArray[0]}, {...bidArray[1]}]; + const bids = [{...bidArray[0]}, {...bidArray[1]}]; config.setConfig({multibid: [{bidder: 'bidderA', maxBids: 2}]}); @@ -575,7 +575,7 @@ describe('multibid adapter', function () { }); it('it sorts and creates dynamic alias on bidsReceived if multibid configuration found with prefix', function () { - let modifiedBids = [{...bidArray[1]}, {...bidArray[0]}].map(bid => { + const modifiedBids = [{...bidArray[1]}, {...bidArray[0]}].map(bid => { addBidResponseHook(bidResponseCallback, 'test.div', {...bid}); return bidResult; @@ -600,7 +600,7 @@ describe('multibid adapter', function () { }); it('it sorts by cpm treating dynamic alias as unique bid when no bid limit defined', function () { - let modifiedBids = [{...bidArrayAlt[0]}, {...bidArrayAlt[2]}, {...bidArrayAlt[3]}, {...bidArrayAlt[1]}].map(bid => { + const modifiedBids = [{...bidArrayAlt[0]}, {...bidArrayAlt[2]}, {...bidArrayAlt[3]}, {...bidArrayAlt[1]}].map(bid => { addBidResponseHook(bidResponseCallback, 'test.div', {...bid}); return bidResult; @@ -633,7 +633,7 @@ describe('multibid adapter', function () { }); it('it should filter out dynamic bid when bid limit is less than unique bid pool', function () { - let modifiedBids = [{...bidArrayAlt[0]}, {...bidArrayAlt[2]}, {...bidArrayAlt[3]}, {...bidArrayAlt[1]}].map(bid => { + const modifiedBids = [{...bidArrayAlt[0]}, {...bidArrayAlt[2]}, {...bidArrayAlt[3]}, {...bidArrayAlt[1]}].map(bid => { addBidResponseHook(bidResponseCallback, 'test.div', {...bid}); return bidResult; @@ -659,13 +659,13 @@ describe('multibid adapter', function () { it('it should collect all bids from auction and bid cache then sort and filter', function () { config.setConfig({ multibid: [{bidder: 'bidderA', maxBids: 2, targetBiddercodePrefix: 'bidA'}] }); - let modifiedBids = [{...bidArrayAlt[0]}, {...bidArrayAlt[2]}, {...bidArrayAlt[3]}, {...bidArrayAlt[1]}].map(bid => { + const modifiedBids = [{...bidArrayAlt[0]}, {...bidArrayAlt[2]}, {...bidArrayAlt[3]}, {...bidArrayAlt[1]}].map(bid => { addBidResponseHook(bidResponseCallback, 'test.div', {...bid}); return bidResult; }); - let bidPool = [].concat.apply(modifiedBids, [{...bidCacheArray[0]}, {...bidCacheArray[1]}]); + const bidPool = [].concat.apply(modifiedBids, [{...bidCacheArray[0]}, {...bidCacheArray[1]}]); expect(bidPool.length).to.equal(6); @@ -688,50 +688,50 @@ describe('multibid adapter', function () { describe('validate multibid', function () { it('should fail validation for missing bidder name in entry', function () { - let conf = [{maxBids: 1}]; - let result = validateMultibid(conf); + const conf = [{maxBids: 1}]; + const result = validateMultibid(conf); expect(result).to.equal(false); }); it('should pass validation on all multibid entries', function () { - let conf = [{bidder: 'bidderA', maxBids: 1}, {bidder: 'bidderB', maxBids: 2}]; - let result = validateMultibid(conf); + const conf = [{bidder: 'bidderA', maxBids: 1}, {bidder: 'bidderB', maxBids: 2}]; + const result = validateMultibid(conf); expect(result).to.equal(true); }); it('should fail validation for maxbids less than 1 in entry', function () { - let conf = [{bidder: 'bidderA', maxBids: 0}, {bidder: 'bidderB', maxBids: 2}]; - let result = validateMultibid(conf); + const conf = [{bidder: 'bidderA', maxBids: 0}, {bidder: 'bidderB', maxBids: 2}]; + const result = validateMultibid(conf); expect(result).to.equal(false); }); it('should fail validation for maxbids greater than 9 in entry', function () { - let conf = [{bidder: 'bidderA', maxBids: 10}, {bidder: 'bidderB', maxBids: 2}]; - let result = validateMultibid(conf); + const conf = [{bidder: 'bidderA', maxBids: 10}, {bidder: 'bidderB', maxBids: 2}]; + const result = validateMultibid(conf); expect(result).to.equal(false); }); it('should add multbid entries to global config', function () { config.setConfig({multibid: [{bidder: 'bidderA', maxBids: 1}]}); - let conf = config.getConfig('multibid'); + const conf = config.getConfig('multibid'); expect(conf).to.deep.equal([{bidder: 'bidderA', maxBids: 1}]); }); it('should modify multbid entries and add to global config', function () { config.setConfig({multibid: [{bidder: 'bidderA', maxBids: 0}, {bidder: 'bidderB', maxBids: 15}]}); - let conf = config.getConfig('multibid'); + const conf = config.getConfig('multibid'); expect(conf).to.deep.equal([{bidder: 'bidderA', maxBids: 1}, {bidder: 'bidderB', maxBids: 9}]); }); it('should filter multbid entry and add modified to global config', function () { config.setConfig({multibid: [{bidder: 'bidderA', maxBids: 0}, {maxBids: 15}]}); - let conf = config.getConfig('multibid'); + const conf = config.getConfig('multibid'); expect(conf.length).to.equal(1); expect(conf).to.deep.equal([{bidder: 'bidderA', maxBids: 1}]); @@ -740,7 +740,7 @@ describe('multibid adapter', function () { describe('sort multibid', function () { it('should not alter order', function () { - let bids = [{ + const bids = [{ 'bidderCode': 'bidderA', 'cpm': 75, 'originalCpm': 75, @@ -756,7 +756,7 @@ describe('multibid adapter', function () { 'bidder': 'bidderA', }]; - let expected = [{ + const expected = [{ 'bidderCode': 'bidderA', 'cpm': 75, 'originalCpm': 75, @@ -771,13 +771,13 @@ describe('multibid adapter', function () { 'originalBidder': 'bidderA', 'bidder': 'bidderA', }]; - let result = bids.sort(sortByMultibid); + const result = bids.sort(sortByMultibid); expect(result).to.deep.equal(expected); }); it('should sort dynamic alias bidders to end', function () { - let bids = [{ + const bids = [{ 'bidderCode': 'bidA2', 'cpm': 75, 'originalCpm': 75, @@ -806,7 +806,7 @@ describe('multibid adapter', function () { 'originalBidder': 'bidderB', 'bidder': 'bidderB', }]; - let expected = [{ + const expected = [{ 'bidderCode': 'bidderA', 'cpm': 22, 'originalCpm': 22, @@ -835,7 +835,7 @@ describe('multibid adapter', function () { 'originalBidder': 'bidderB', 'bidder': 'bidderB', }]; - let result = bids.sort(sortByMultibid); + const result = bids.sort(sortByMultibid); expect(result).to.deep.equal(expected); }); diff --git a/test/spec/modules/nativoBidAdapter_spec.js b/test/spec/modules/nativoBidAdapter_spec.js index 349051cb48e..b9e392ef5de 100644 --- a/test/spec/modules/nativoBidAdapter_spec.js +++ b/test/spec/modules/nativoBidAdapter_spec.js @@ -44,7 +44,7 @@ describe('bidDataMap', function () { describe('nativoBidAdapterTests', function () { describe('isBidRequestValid', function () { - let bid = { + const bid = { bidder: 'nativo', } @@ -182,7 +182,7 @@ describe('nativoBidAdapterTests', function () { }) describe('interpretResponse', function () { - let response = { + const response = { id: '126456', seatbid: [ { @@ -206,7 +206,7 @@ describe('interpretResponse', function () { } it('should get correct bid response', function () { - let expectedResponse = [ + const expectedResponse = [ { requestId: '1F254428-AB11-4D5E-9887-567B3F952CA5', cpm: 3.569, @@ -225,7 +225,7 @@ describe('interpretResponse', function () { }, ] - let bidderRequest = { + const bidderRequest = { id: 123456, bids: [ { @@ -244,17 +244,17 @@ describe('interpretResponse', function () { } } - let result = spec.interpretResponse({ body: response }, { bidderRequest }) + const result = spec.interpretResponse({ body: response }, { bidderRequest }) expect(Object.keys(result[0])).to.have.deep.members( Object.keys(expectedResponse[0]) ) }) it('handles nobid responses', function () { - let response = {} + const response = {} let bidderRequest - let result = spec.interpretResponse({ body: response }, { bidderRequest }) + const result = spec.interpretResponse({ body: response }, { bidderRequest }) expect(result.length).to.equal(0) }) }) @@ -295,7 +295,7 @@ describe('getUserSyncs', function () { } it('Returns empty array if no supported user syncs', function () { - let userSync = spec.getUserSyncs( + const userSync = spec.getUserSyncs( { iframeEnabled: false, pixelEnabled: false, @@ -308,7 +308,7 @@ describe('getUserSyncs', function () { }) it('Returns valid iframe user sync', function () { - let userSync = spec.getUserSyncs( + const userSync = spec.getUserSyncs( { iframeEnabled: true, pixelEnabled: false, @@ -327,7 +327,7 @@ describe('getUserSyncs', function () { }) it('Returns valid URL and type', function () { - let userSync = spec.getUserSyncs( + const userSync = spec.getUserSyncs( { iframeEnabled: false, pixelEnabled: true, @@ -388,7 +388,7 @@ describe('getAdUnitData', () => { }) describe('Response to Request Filter Flow', () => { - let bidRequests = [ + const bidRequests = [ { bidder: 'nativo', params: { @@ -433,7 +433,7 @@ describe('Response to Request Filter Flow', () => { } }) - let bidderRequest = { + const bidderRequest = { id: 123456, bids: [ { @@ -454,7 +454,7 @@ describe('Response to Request Filter Flow', () => { it('Appends NO filter based on previous response', () => { // Getting the mock response - let result = spec.interpretResponse({ body: response }, { bidderRequest }) + const result = spec.interpretResponse({ body: response }, { bidderRequest }) // Winning the bid spec.onBidWon(result[0]) @@ -475,7 +475,7 @@ describe('Response to Request Filter Flow', () => { response.seatbid[0].bid[0].ext = { adsToFilter: ['12345'] } // Getting the mock response - let result = spec.interpretResponse({ body: response }, { bidderRequest }) + const result = spec.interpretResponse({ body: response }, { bidderRequest }) // Winning the bid spec.onBidWon(result[0]) @@ -496,7 +496,7 @@ describe('Response to Request Filter Flow', () => { response.seatbid[0].bid[0].ext = { advertisersToFilter: ['1'] } // Getting the mock response - let result = spec.interpretResponse({ body: response }, { bidderRequest }) + const result = spec.interpretResponse({ body: response }, { bidderRequest }) // Winning the bid spec.onBidWon(result[0]) @@ -517,7 +517,7 @@ describe('Response to Request Filter Flow', () => { response.seatbid[0].bid[0].ext = { campaignsToFilter: ['234'] } // Getting the mock response - let result = spec.interpretResponse({ body: response }, { bidderRequest }) + const result = spec.interpretResponse({ body: response }, { bidderRequest }) // Winning the bid spec.onBidWon(result[0]) @@ -556,15 +556,15 @@ describe('sizeToString', () => { describe('getSizeWildcardPrice', () => { it('Generates the correct floor price data', () => { - let floorPrice = { + const floorPrice = { currency: 'USD', floor: 1.0, } - let getFloorMock = () => { + const getFloorMock = () => { return floorPrice } - let floorMockSpy = sinon.spy(getFloorMock) - let bidRequest = { + const floorMockSpy = sinon.spy(getFloorMock) + const bidRequest = { getFloor: floorMockSpy, mediaTypes: { banner: { @@ -573,7 +573,7 @@ describe('getSizeWildcardPrice', () => { }, } - let result = getSizeWildcardPrice(bidRequest, 'banner') + const result = getSizeWildcardPrice(bidRequest, 'banner') expect( floorMockSpy.calledWith({ currency: 'USD', @@ -587,21 +587,21 @@ describe('getSizeWildcardPrice', () => { describe('getMediaWildcardPrices', () => { it('Generates the correct floor price data', () => { - let defaultFloorPrice = { + const defaultFloorPrice = { currency: 'USD', floor: 1.1, } - let sizefloorPrice = { + const sizefloorPrice = { currency: 'USD', floor: 2.2, } - let getFloorMock = ({ currency, mediaType, size }) => { + const getFloorMock = ({ currency, mediaType, size }) => { if (Array.isArray(size)) return sizefloorPrice return defaultFloorPrice } - let floorMockSpy = sinon.spy(getFloorMock) - let bidRequest = { + const floorMockSpy = sinon.spy(getFloorMock) + const bidRequest = { getFloor: floorMockSpy, mediaTypes: { banner: { @@ -610,7 +610,7 @@ describe('getMediaWildcardPrices', () => { }, } - let result = getMediaWildcardPrices(bidRequest, ['*', [300, 250]]) + const result = getMediaWildcardPrices(bidRequest, ['*', [300, 250]]) expect( floorMockSpy.calledWith({ currency: 'USD', @@ -631,21 +631,21 @@ describe('getMediaWildcardPrices', () => { describe('parseFloorPriceData', () => { it('Generates the correct floor price data', () => { - let defaultFloorPrice = { + const defaultFloorPrice = { currency: 'USD', floor: 1.1, } - let sizefloorPrice = { + const sizefloorPrice = { currency: 'USD', floor: 2.2, } - let getFloorMock = ({ currency, mediaType, size }) => { + const getFloorMock = ({ currency, mediaType, size }) => { if (Array.isArray(size)) return sizefloorPrice return defaultFloorPrice } - let floorMockSpy = sinon.spy(getFloorMock) - let bidRequest = { + const floorMockSpy = sinon.spy(getFloorMock) + const bidRequest = { getFloor: floorMockSpy, mediaTypes: { banner: { @@ -654,7 +654,7 @@ describe('parseFloorPriceData', () => { }, } - let result = parseFloorPriceData(bidRequest) + const result = parseFloorPriceData(bidRequest) expect(result).to.deep.equal({ '*': { '*': 1.1, '300x250': 2.2 }, banner: { '*': 1.1, '300x250': 2.2 }, diff --git a/test/spec/modules/neuwoRtdProvider_spec.js b/test/spec/modules/neuwoRtdProvider_spec.js index 0ad3d7c1f74..c400eea0429 100644 --- a/test/spec/modules/neuwoRtdProvider_spec.js +++ b/test/spec/modules/neuwoRtdProvider_spec.js @@ -46,7 +46,7 @@ describe('neuwoRtdProvider', function () { expect(neuwo.pickSegments({ bad_object: 'bad' })).to.be.an('array').that.is.empty; }) it('handles malformations', function () { - let result = neuwo.pickSegments([{something_wrong: true}, null, { ID: 'IAB19-20' }, { id: 'IAB3-1', ID: 'IAB9-20' }]) + const result = neuwo.pickSegments([{something_wrong: true}, null, { ID: 'IAB19-20' }, { id: 'IAB3-1', ID: 'IAB9-20' }]) expect(result[0].id).to.equal('631') expect(result[1].id).to.equal('58') expect(result.length).to.equal(2) @@ -55,8 +55,8 @@ describe('neuwoRtdProvider', function () { describe('topic injection', function () { it('mutates bidsConfig', function () { - let topics = apiReturns() - let bidsConfig = bidsConfiglike() + const topics = apiReturns() + const bidsConfig = bidsConfiglike() neuwo.injectTopics(topics, bidsConfig, () => { }) expect(bidsConfig.ortb2Fragments.global.site.content.data[0].name, 'name of first content data object').to.equal(neuwo.DATA_PROVIDER) expect(bidsConfig.ortb2Fragments.global.site.content.data[0].segment[0].id, 'id of first segment in content.data').to.equal(TAX_ID) @@ -65,19 +65,19 @@ describe('neuwoRtdProvider', function () { it('handles malformed responses', function () { let topics = { message: 'Forbidden' } - let bidsConfig = bidsConfiglike() + const bidsConfig = bidsConfiglike() neuwo.injectTopics(topics, bidsConfig, () => { }) expect(bidsConfig.ortb2Fragments.global.site.content.data[0].name, 'name of first content data object').to.equal(neuwo.DATA_PROVIDER) expect(bidsConfig.ortb2Fragments.global.site.content.data[0].segment, 'length of segment(s) in content.data').to.be.an('array').that.is.empty; topics = '404 wouldn\'t really even show up for injection' - let bdsConfig = bidsConfiglike() + const bdsConfig = bidsConfiglike() neuwo.injectTopics(topics, bdsConfig, () => { }) expect(bdsConfig.ortb2Fragments.global.site.content.data[0].name, 'name of first content data object').to.equal(neuwo.DATA_PROVIDER) expect(bdsConfig.ortb2Fragments.global.site.content.data[0].segment, 'length of segment(s) in content.data').to.be.an('array').that.is.empty; topics = undefined - let bdsConfigE = bidsConfiglike() + const bdsConfigE = bidsConfiglike() neuwo.injectTopics(topics, bdsConfigE, () => { }) expect(bdsConfigE.ortb2Fragments.global.site.content.data[0].name, 'name of first content data object').to.equal(neuwo.DATA_PROVIDER) expect(bdsConfigE.ortb2Fragments.global.site.content.data[0].segment, 'length of segment(s) in content.data').to.be.an('array').that.is.empty; @@ -86,7 +86,7 @@ describe('neuwoRtdProvider', function () { describe('fragment addition', function () { it('mutates input objects', function () { - let alphabet = { a: { b: { c: {} } } } + const alphabet = { a: { b: { c: {} } } } neuwo.addFragment(alphabet.a.b.c, 'd.e.f', { g: 'h' }) expect(alphabet.a.b.c.d.e.f.g).to.equal('h') }) @@ -94,14 +94,14 @@ describe('neuwoRtdProvider', function () { describe('getBidRequestData', function () { it('forms requests properly and mutates input bidsConfig', function () { - let bids = bidsConfiglike() - let conf = config() + const bids = bidsConfiglike() + const conf = config() // control xhr api request target for testing conf.params.argUrl = 'https://publisher.works/article.php?get=horrible_url_for_testing&id=5' neuwo.getBidRequestData(bids, () => { }, conf, 'any consent data works, clearly') - let request = server.requests[0]; + const request = server.requests[0]; expect(request.url).to.be.a('string').that.includes(conf.params.publicToken) expect(request.url).to.include(encodeURIComponent(conf.params.argUrl)) request.respond(200, { 'Content-Type': 'application/json; encoding=UTF-8' }, JSON.stringify(apiReturns())); @@ -111,10 +111,10 @@ describe('neuwoRtdProvider', function () { }) it('accepts detail not available result', function () { - let bidsConfig = bidsConfiglike() - let comparison = bidsConfiglike() + const bidsConfig = bidsConfiglike() + const comparison = bidsConfiglike() neuwo.getBidRequestData(bidsConfig, () => { }, config(), 'consensually') - let request = server.requests[0]; + const request = server.requests[0]; request.respond(404, { 'Content-Type': 'application/json; encoding=UTF-8' }, JSON.stringify({ detail: 'Basically first time seeing this' })); expect(bidsConfig).to.deep.equal(comparison) }) diff --git a/test/spec/modules/nextMillenniumBidAdapter_spec.js b/test/spec/modules/nextMillenniumBidAdapter_spec.js index 53e541efded..76fa1aeb049 100644 --- a/test/spec/modules/nextMillenniumBidAdapter_spec.js +++ b/test/spec/modules/nextMillenniumBidAdapter_spec.js @@ -174,7 +174,7 @@ describe('nextMillenniumBidAdapterTests', () => { }, ]; - for (let {title, data, expected} of dataTests) { + for (const {title, data, expected} of dataTests) { it(title, () => { const {bid, id, mediaTypes, postBody} = data; const imp = getImp(bid, id, mediaTypes, postBody); @@ -316,7 +316,7 @@ describe('nextMillenniumBidAdapterTests', () => { }, ]; - for (let {title, validBidRequests, bidderRequest, expected} of dataTests) { + for (const {title, validBidRequests, bidderRequest, expected} of dataTests) { it(title, () => { const source = getSourceObj(validBidRequests, bidderRequest); expect(source).to.deep.equal(expected); @@ -394,7 +394,7 @@ describe('nextMillenniumBidAdapterTests', () => { }, ]; - for (let {title, data, expected} of dataTests) { + for (const {title, data, expected} of dataTests) { it(title, () => { const {postBody, bidderRequest} = data; setConsentStrings(postBody, bidderRequest); @@ -454,7 +454,7 @@ describe('nextMillenniumBidAdapterTests', () => { }, ]; - for (let {title, data, expected} of dataTests) { + for (const {title, data, expected} of dataTests) { it(title, () => { const {url, gdprConsent, uspConsent, gppConsent, type} = data; const newUrl = replaceUsersyncMacros(url, gdprConsent, uspConsent, gppConsent, type); @@ -618,7 +618,7 @@ describe('nextMillenniumBidAdapterTests', () => { }, ]; - for (let {title, data, expected} of dataTests) { + for (const {title, data, expected} of dataTests) { it(title, () => { const {syncOptions, responses, gdprConsent, uspConsent, gppConsent} = data; const pixels = spec.getUserSyncs(syncOptions, responses, gdprConsent, uspConsent, gppConsent); @@ -705,7 +705,7 @@ describe('nextMillenniumBidAdapterTests', () => { }, ]; - for (let {title, data, expected} of dataTests) { + for (const {title, data, expected} of dataTests) { it(title, () => { const {postBody, ortb2} = data; setOrtb2Parameters(postBody, ortb2); @@ -792,7 +792,7 @@ describe('nextMillenniumBidAdapterTests', () => { }, ]; - for (let { title, data, expected } of dataTests) { + for (const { title, data, expected } of dataTests) { it(title, () => { const { postBody, bids } = data; setEids(postBody, bids); @@ -867,7 +867,7 @@ describe('nextMillenniumBidAdapterTests', () => { describe('check parameters group_id or placement_id', function() { let numberTest = 0 - for (let test of bidRequestDataGI) { + for (const test of bidRequestDataGI) { it(`test - ${++numberTest}`, () => { const request = spec.buildRequests([test]); const requestData = JSON.parse(request[0].data); @@ -880,7 +880,7 @@ describe('nextMillenniumBidAdapterTests', () => { expect(srId.length).to.be.equal(3); expect((/^g[1-9]\d*/).test(srId[0])).to.be.true; const sizes = srId[1].split('|'); - for (let size of sizes) { + for (const size of sizes) { if (!(/^[1-9]\d*[xX,][1-9]\d*$/).test(size)) { expect(storeRequestId).to.be.equal(''); } @@ -1093,7 +1093,7 @@ describe('nextMillenniumBidAdapterTests', () => { }, ]; - for (let {title, eventName, bids, expected} of dataForTests) { + for (const {title, eventName, bids, expected} of dataForTests) { it(title, () => { const url = spec._getUrlPixelMetric(eventName, bids); expect(url).to.equal(expected); @@ -1172,7 +1172,7 @@ describe('nextMillenniumBidAdapterTests', () => { }, ]; - for (let {title, bidRequests, bidderRequest, expected} of tests) { + for (const {title, bidRequests, bidderRequest, expected} of tests) { it(title, () => { const request = spec.buildRequests(bidRequests, bidderRequest); expect(request.length).to.equal(expected.requestSize); @@ -1279,7 +1279,7 @@ describe('nextMillenniumBidAdapterTests', () => { }, ]; - for (let {title, serverResponse, bidRequest, expected} of tests) { + for (const {title, serverResponse, bidRequest, expected} of tests) { describe(title, () => { const bids = spec.interpretResponse(serverResponse, bidRequest); for (let i = 0; i < bids.length; i++) { diff --git a/test/spec/modules/nextrollBidAdapter_spec.js b/test/spec/modules/nextrollBidAdapter_spec.js index d4779120248..93debb192fa 100644 --- a/test/spec/modules/nextrollBidAdapter_spec.js +++ b/test/spec/modules/nextrollBidAdapter_spec.js @@ -14,7 +14,7 @@ describe('nextrollBidAdapter', function() { utilsMock.restore(); }); - let validBid = { + const validBid = { bidder: 'nextroll', adUnitCode: 'adunit-code', bidId: 'bid_id', @@ -25,12 +25,12 @@ describe('nextrollBidAdapter', function() { publisherId: 'publisher_id' } }; - let bidWithoutValidId = { id: '' }; - let bidWithoutId = { params: { zoneId: 'zone1' } }; + const bidWithoutValidId = { id: '' }; + const bidWithoutId = { params: { zoneId: 'zone1' } }; describe('nativeBidRequest', () => { it('validates native spec', () => { - let nativeAdUnit = [{ + const nativeAdUnit = [{ bidder: 'nextroll', adUnitCode: 'adunit-code', bidId: 'bid_id', @@ -52,10 +52,10 @@ describe('nextrollBidAdapter', function() { } }]; - let request = spec.buildRequests(nativeAdUnit) - let assets = request[0].data.imp.native.request.native.assets + const request = spec.buildRequests(nativeAdUnit) + const assets = request[0].data.imp.native.request.native.assets - let excptedAssets = [ + const excptedAssets = [ {id: 1, required: 1, title: {len: 80}}, {id: 2, required: 1, img: {w: 728, h: 90, wmin: 1, hmin: 1, type: 3}}, {id: 3, required: 1, img: {w: 50, h: 50, wmin: 4, hmin: 3, type: 1}}, @@ -130,7 +130,7 @@ describe('nextrollBidAdapter', function() { expect(request.data.imp.bidfloor).to.not.exist; // bidfloor defined, getFloor defined, use getFloor - let getFloorResponse = { currency: 'USD', floor: 3 }; + const getFloorResponse = { currency: 'USD', floor: 3 }; bid = deepClone(validBid); bid.getFloor = () => getFloorResponse; request = spec.buildRequests([bid], {})[0]; @@ -156,7 +156,7 @@ describe('nextrollBidAdapter', function() { }); describe('interpretResponse', function () { - let responseBody = { + const responseBody = { id: 'bidresponse_id', dealId: 'deal_id', seatbid: [ @@ -210,15 +210,15 @@ describe('nextrollBidAdapter', function() { }); describe('interpret native response', () => { - let clickUrl = 'https://clickurl.com/with/some/path' - let titleText = 'Some title' - let imgW = 300 - let imgH = 250 - let imgUrl = 'https://clickurl.com/img.png' - let brandText = 'Some Brand' - let impUrl = 'https://clickurl.com/imptracker' - - let responseBody = { + const clickUrl = 'https://clickurl.com/with/some/path' + const titleText = 'Some title' + const imgW = 300 + const imgH = 250 + const imgUrl = 'https://clickurl.com/img.png' + const brandText = 'Some Brand' + const impUrl = 'https://clickurl.com/imptracker' + + const responseBody = { body: { id: 'bidresponse_id', seatbid: [{ @@ -240,8 +240,8 @@ describe('nextrollBidAdapter', function() { }; it('Should interpret response', () => { - let response = spec.interpretResponse(utils.deepClone(responseBody)) - let expectedResponse = { + const response = spec.interpretResponse(utils.deepClone(responseBody)) + const expectedResponse = { clickUrl: clickUrl, impressionTrackers: [impUrl], privacyLink: 'https://app.adroll.com/optout/personalized', @@ -257,10 +257,10 @@ describe('nextrollBidAdapter', function() { }) it('Should interpret all assets', () => { - let allAssetsResponse = utils.deepClone(responseBody) - let iconUrl = imgUrl + '?icon=true', iconW = 10, iconH = 15 - let logoUrl = imgUrl + '?logo=true', logoW = 20, logoH = 25 - let bodyText = 'Some body text' + const allAssetsResponse = utils.deepClone(responseBody) + const iconUrl = imgUrl + '?icon=true', iconW = 10, iconH = 15 + const logoUrl = imgUrl + '?logo=true', logoW = 20, logoH = 25 + const bodyText = 'Some body text' allAssetsResponse.body.seatbid[0].bid[0].adm.assets.push(...[ {id: 3, img: {w: iconW, h: iconH, url: iconUrl}}, @@ -268,8 +268,8 @@ describe('nextrollBidAdapter', function() { {id: 6, data: {value: bodyText}} ]) - let response = spec.interpretResponse(allAssetsResponse) - let expectedResponse = { + const response = spec.interpretResponse(allAssetsResponse) + const expectedResponse = { clickUrl: clickUrl, impressionTrackers: [impUrl], jstracker: [], diff --git a/test/spec/modules/nexverseBidAdapter_spec.js b/test/spec/modules/nexverseBidAdapter_spec.js index fd20a37cc0d..2cc4b196c26 100644 --- a/test/spec/modules/nexverseBidAdapter_spec.js +++ b/test/spec/modules/nexverseBidAdapter_spec.js @@ -7,7 +7,7 @@ const BIDDER_ENDPOINT = 'https://rtb.nexverse.ai'; describe('nexverseBidAdapterTests', () => { describe('isBidRequestValid', function () { - let sbid = { + const sbid = { 'adUnitCode': 'div', 'bidder': 'nexverse', 'params': { @@ -17,26 +17,26 @@ describe('nexverseBidAdapterTests', () => { }; it('should not accept bid without required params', function () { - let isValid = spec.isBidRequestValid(sbid); + const isValid = spec.isBidRequestValid(sbid); expect(isValid).to.equal(false); }); it('should return false when params are not passed', function () { - let bid = Object.assign({}, sbid); + const bid = Object.assign({}, sbid); delete bid.params; bid.params = {}; expect(spec.isBidRequestValid(bid)).to.equal(false); }); it('should return false when valid params are not passed', function () { - let bid = Object.assign({}, sbid); + const bid = Object.assign({}, sbid); delete bid.params; bid.params = {uid: '', pubId: '', pubEpid: ''}; expect(spec.isBidRequestValid(bid)).to.equal(false); }); it('should return false when valid params are not passed', function () { - let bid = Object.assign({}, sbid); + const bid = Object.assign({}, sbid); delete bid.params; bid.adUnitCode = ''; bid.mediaTypes = { @@ -48,7 +48,7 @@ describe('nexverseBidAdapterTests', () => { expect(spec.isBidRequestValid(bid)).to.equal(false); }); it('should return true when valid params are passed as nums', function () { - let bid = Object.assign({}, sbid); + const bid = Object.assign({}, sbid); delete bid.params; bid.mediaTypes = { banner: { diff --git a/test/spec/modules/nexx360BidAdapter_spec.js b/test/spec/modules/nexx360BidAdapter_spec.js index a097fe8037f..48b8e60725e 100644 --- a/test/spec/modules/nexx360BidAdapter_spec.js +++ b/test/spec/modules/nexx360BidAdapter_spec.js @@ -714,11 +714,11 @@ describe('Nexx360 bid adapter tests', () => { var syncs = spec.getUserSyncs({}, null, DEFAULT_OPTIONS.gdprConsent, DEFAULT_OPTIONS.uspConsent); expect(syncs).to.eql([]); }); - it('Verifies user sync with no bid body response', () => { - var syncs = spec.getUserSyncs({}, [], DEFAULT_OPTIONS.gdprConsent, DEFAULT_OPTIONS.uspConsent); - expect(syncs).to.eql([]); - var syncs = spec.getUserSyncs({}, [{}], DEFAULT_OPTIONS.gdprConsent, DEFAULT_OPTIONS.uspConsent); - expect(syncs).to.eql([]); - }); + it('Verifies user sync with no bid body response', () => { + let syncs = spec.getUserSyncs({}, [], DEFAULT_OPTIONS.gdprConsent, DEFAULT_OPTIONS.uspConsent); + expect(syncs).to.eql([]); + syncs = spec.getUserSyncs({}, [{}], DEFAULT_OPTIONS.gdprConsent, DEFAULT_OPTIONS.uspConsent); + expect(syncs).to.eql([]); + }); }); }); diff --git a/test/spec/modules/nobidAnalyticsAdapter_spec.js b/test/spec/modules/nobidAnalyticsAdapter_spec.js index 81b78dc14d6..e20348f51cc 100644 --- a/test/spec/modules/nobidAnalyticsAdapter_spec.js +++ b/test/spec/modules/nobidAnalyticsAdapter_spec.js @@ -2,8 +2,8 @@ import nobidAnalytics from 'modules/nobidAnalyticsAdapter.js'; import {expect} from 'chai'; import {server} from 'test/mocks/xhr.js'; import { EVENTS } from 'src/constants.js'; -let events = require('src/events'); -let adapterManager = require('src/adapterManager').default; +const events = require('src/events'); +const adapterManager = require('src/adapterManager').default; const TOP_LOCATION = 'https://www.somesite.com'; const SITE_ID = 1234; @@ -596,7 +596,7 @@ describe('NoBid Prebid Analytic', function () { active = nobidCarbonizer.isActive(); expect(active).to.equal(true); - let adunits = [ + const adunits = [ { bids: [ { bidder: 'bidder1' }, diff --git a/test/spec/modules/nobidBidAdapter_spec.js b/test/spec/modules/nobidBidAdapter_spec.js index 9e616c26d32..e56555e1b85 100644 --- a/test/spec/modules/nobidBidAdapter_spec.js +++ b/test/spec/modules/nobidBidAdapter_spec.js @@ -17,7 +17,7 @@ describe('Nobid Adapter', function () { describe('buildRequestsWithFloor', function () { const SITE_ID = 2; const REFERER = 'https://www.examplereferer.com'; - let bidRequests = [ + const bidRequests = [ { 'bidder': 'nobid', 'params': { @@ -32,7 +32,7 @@ describe('Nobid Adapter', function () { } ]; - let bidderRequest = { + const bidderRequest = { refererInfo: {page: REFERER} } @@ -45,7 +45,7 @@ describe('Nobid Adapter', function () { }); describe('isBidRequestValid', function () { - let bid = { + const bid = { 'bidder': 'nobid', 'params': { 'siteId': 2 @@ -83,7 +83,7 @@ describe('Nobid Adapter', function () { const SITE_ID = 2; const REFERER = 'https://www.examplereferer.com'; const BIDDER_CODE = 'duration'; - let bidRequests = [ + const bidRequests = [ { 'bidder': BIDDER_CODE, 'params': { @@ -97,7 +97,7 @@ describe('Nobid Adapter', function () { } ]; - let bidderRequest = { + const bidderRequest = { refererInfo: {page: REFERER}, bidderCode: BIDDER_CODE } @@ -145,7 +145,7 @@ describe('Nobid Adapter', function () { const SITE_ID = 2; const REFERER = 'https://www.examplereferer.com'; const BIDDER_CODE = 'duration'; - let bidRequests = [ + const bidRequests = [ { 'bidder': BIDDER_CODE, 'params': { @@ -200,7 +200,7 @@ describe('Nobid Adapter', function () { const SITE_ID = 2; const REFERER = 'https://www.examplereferer.com'; const BIDDER_CODE = 'duration'; - let bidRequests = [ + const bidRequests = [ { 'bidder': BIDDER_CODE, 'params': { @@ -214,7 +214,7 @@ describe('Nobid Adapter', function () { } ]; - let bidderRequest = { + const bidderRequest = { refererInfo: {page: REFERER}, bidderCode: BIDDER_CODE } @@ -273,8 +273,8 @@ describe('Nobid Adapter', function () { }); it('should add gdpr consent information to the request', function () { - let consentString = 'BOJ8RZsOJ8RZsABAB8AAAAAZ+A=='; - let bidderRequest = { + const consentString = 'BOJ8RZsOJ8RZsABAB8AAAAAZ+A=='; + const bidderRequest = { 'bidderCode': 'nobid', 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', @@ -295,7 +295,7 @@ describe('Nobid Adapter', function () { }); it('should add gdpr consent information to the request', function () { - let bidderRequest = { + const bidderRequest = { 'bidderCode': 'nobid', 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', @@ -315,7 +315,7 @@ describe('Nobid Adapter', function () { }); it('should add usp consent information to the request', function () { - let bidderRequest = { + const bidderRequest = { 'bidderCode': 'nobid', 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', @@ -333,7 +333,7 @@ describe('Nobid Adapter', function () { }); describe('isVideoBidRequestValid', function () { - let bid = { + const bid = { bidder: 'nobid', params: { siteId: 2, @@ -360,7 +360,7 @@ describe('Nobid Adapter', function () { }; const SITE_ID = 2; const REFERER = 'https://www.examplereferer.com'; - let bidRequests = [ + const bidRequests = [ { bidder: 'nobid', params: { @@ -388,7 +388,7 @@ describe('Nobid Adapter', function () { } ]; - let bidderRequest = { + const bidderRequest = { refererInfo: {page: REFERER} } @@ -423,7 +423,7 @@ describe('Nobid Adapter', function () { }); describe('isVideoBidRequestValid', function () { - let bid = { + const bid = { bidder: 'nobid', params: { siteId: 2, @@ -450,7 +450,7 @@ describe('Nobid Adapter', function () { }; const SITE_ID = 2; const REFERER = 'https://www.examplereferer.com'; - let bidRequests = [ + const bidRequests = [ { bidder: 'nobid', params: { @@ -478,7 +478,7 @@ describe('Nobid Adapter', function () { } ]; - let bidderRequest = { + const bidderRequest = { refererInfo: {page: REFERER} } @@ -515,7 +515,7 @@ describe('Nobid Adapter', function () { describe('buildRequestsEIDs', function () { const SITE_ID = 2; const REFERER = 'https://www.examplereferer.com'; - let bidRequests = [ + const bidRequests = [ { 'bidder': 'nobid', 'params': { @@ -564,7 +564,7 @@ describe('Nobid Adapter', function () { } ]; - let bidderRequest = { + const bidderRequest = { refererInfo: {page: REFERER} } @@ -584,7 +584,7 @@ describe('Nobid Adapter', function () { describe('buildRequests', function () { const SITE_ID = 2; const REFERER = 'https://www.examplereferer.com'; - let bidRequests = [ + const bidRequests = [ { 'bidder': 'nobid', 'params': { @@ -598,7 +598,7 @@ describe('Nobid Adapter', function () { } ]; - let bidderRequest = { + const bidderRequest = { refererInfo: {page: REFERER} } @@ -656,8 +656,8 @@ describe('Nobid Adapter', function () { }); it('should add gdpr consent information to the request', function () { - let consentString = 'BOJ8RZsOJ8RZsABAB8AAAAAZ+A=='; - let bidderRequest = { + const consentString = 'BOJ8RZsOJ8RZsABAB8AAAAAZ+A=='; + const bidderRequest = { 'bidderCode': 'nobid', 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', @@ -678,7 +678,7 @@ describe('Nobid Adapter', function () { }); it('should add gdpr consent information to the request', function () { - let bidderRequest = { + const bidderRequest = { 'bidderCode': 'nobid', 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', @@ -698,7 +698,7 @@ describe('Nobid Adapter', function () { }); it('should add usp consent information to the request', function () { - let bidderRequest = { + const bidderRequest = { 'bidderCode': 'nobid', 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', @@ -718,7 +718,7 @@ describe('Nobid Adapter', function () { describe('buildRequestsRefreshCount', function () { const SITE_ID = 2; const REFERER = 'https://www.examplereferer.com'; - let bidRequests = [ + const bidRequests = [ { 'bidder': 'nobid', 'params': { @@ -732,7 +732,7 @@ describe('Nobid Adapter', function () { } ]; - let bidderRequest = { + const bidderRequest = { refererInfo: {page: REFERER} } @@ -755,7 +755,7 @@ describe('Nobid Adapter', function () { const PRICE_300x250 = 0.51; const REQUEST_ID = '3db3773286ee59'; const DEAL_ID = 'deal123'; - let response = { + const response = { country: 'US', ip: '68.83.15.75', device: 'COMPUTER', @@ -774,7 +774,7 @@ describe('Nobid Adapter', function () { }; it('should get correct bid response', function () { - let expectedResponse = [ + const expectedResponse = [ { requestId: REQUEST_ID, cpm: PRICE_300x250, @@ -790,13 +790,13 @@ describe('Nobid Adapter', function () { } ]; - let bidderRequest = { + const bidderRequest = { bids: [{ bidId: REQUEST_ID, adUnitCode: ADUNIT_300x250 }] } - let result = spec.interpretResponse({ body: response }, {bidderRequest: bidderRequest}); + const result = spec.interpretResponse({ body: response }, {bidderRequest: bidderRequest}); expect(result.length).to.equal(expectedResponse.length); expect(Object.keys(result[0])).to.have.members(Object.keys(expectedResponse[0])); expect(result[0].requestId).to.equal(expectedResponse[0].requestId); @@ -804,18 +804,18 @@ describe('Nobid Adapter', function () { }); it('should get correct empty response', function () { - let bidderRequest = { + const bidderRequest = { bids: [{ bidId: REQUEST_ID, adUnitCode: ADUNIT_300x250 + '1' }] } - let result = spec.interpretResponse({ body: response }, {bidderRequest: bidderRequest}); + const result = spec.interpretResponse({ body: response }, {bidderRequest: bidderRequest}); expect(result.length).to.equal(0); }); it('should get correct deal id', function () { - let expectedResponse = [ + const expectedResponse = [ { requestId: REQUEST_ID, cpm: PRICE_300x250, @@ -831,13 +831,13 @@ describe('Nobid Adapter', function () { } ]; - let bidderRequest = { + const bidderRequest = { bids: [{ bidId: REQUEST_ID, adUnitCode: ADUNIT_300x250 }] } - let result = spec.interpretResponse({ body: response }, {bidderRequest: bidderRequest}); + const result = spec.interpretResponse({ body: response }, {bidderRequest: bidderRequest}); expect(result.length).to.equal(expectedResponse.length); expect(result[0].dealId).to.equal(expectedResponse[0].dealId); }); @@ -851,7 +851,7 @@ describe('Nobid Adapter', function () { const REQUEST_ID = '3db3773286ee59'; const DEAL_ID = 'deal123'; const REFRESH_LIMIT = 3; - let response = { + const response = { country: 'US', ip: '68.83.15.75', device: 'COMPUTER', @@ -871,13 +871,13 @@ describe('Nobid Adapter', function () { }; it('should refreshLimit be respected', function () { - let bidderRequest = { + const bidderRequest = { bids: [{ bidId: REQUEST_ID, adUnitCode: ADUNIT_300x250 }] } - let result = spec.interpretResponse({ body: response }, {bidderRequest: bidderRequest}); + const result = spec.interpretResponse({ body: response }, {bidderRequest: bidderRequest}); expect(nobid.refreshLimit).to.equal(REFRESH_LIMIT); }); }); @@ -890,7 +890,7 @@ describe('Nobid Adapter', function () { const REQUEST_ID = '3db3773286ee59'; const DEAL_ID = 'deal123'; const ADOMAINS = ['adomain1', 'adomain2']; - let response = { + const response = { country: 'US', ip: '68.83.15.75', device: 'COMPUTER', @@ -912,20 +912,20 @@ describe('Nobid Adapter', function () { }; it('should meta.advertiserDomains be respected', function () { - let bidderRequest = { + const bidderRequest = { bids: [{ bidId: REQUEST_ID, adUnitCode: ADUNIT_300x250 }] } - let result = spec.interpretResponse({ body: response }, {bidderRequest: bidderRequest}); + const result = spec.interpretResponse({ body: response }, {bidderRequest: bidderRequest}); expect(result[0].meta.advertiserDomains).to.equal(ADOMAINS); }); }); describe('buildRequestsWithSupplyChain', function () { const SITE_ID = 2; - let bidRequests = [ + const bidRequests = [ { bidder: 'nobid', params: { @@ -987,7 +987,7 @@ describe('Nobid Adapter', function () { const REQUEST_ID = '3db3773286ee59'; const DEAL_ID = 'deal123'; const ULIMIT = 1; - let response = { + const response = { country: 'US', ip: '68.83.15.75', device: 'COMPUTER', @@ -1027,7 +1027,7 @@ describe('Nobid Adapter', function () { } ]; spec.interpretResponse({ body: response }, {bidderRequest: bidderRequest}); - let request = spec.buildRequests(bidRequests, bidderRequest); + const request = spec.buildRequests(bidRequests, bidderRequest); expect(request).to.equal(undefined); }); }); @@ -1035,30 +1035,30 @@ describe('Nobid Adapter', function () { describe('getUserSyncs', function () { const GDPR_CONSENT_STRING = 'GDPR_CONSENT_STRING'; it('should get correct user sync when iframeEnabled', function () { - let pixel = spec.getUserSyncs({iframeEnabled: true}) + const pixel = spec.getUserSyncs({iframeEnabled: true}) expect(pixel[0].type).to.equal('iframe'); expect(pixel[0].url).to.equal('https://public.servenobid.com/sync.html'); }); it('should get correct user sync when iframeEnabled and pixelEnabled', function () { - let pixel = spec.getUserSyncs({iframeEnabled: true, pixelEnabled: true}) + const pixel = spec.getUserSyncs({iframeEnabled: true, pixelEnabled: true}) expect(pixel[0].type).to.equal('iframe'); expect(pixel[0].url).to.equal('https://public.servenobid.com/sync.html'); }); it('should get correct user sync when iframeEnabled', function () { - let pixel = spec.getUserSyncs({iframeEnabled: true}, {}, {gdprApplies: true, consentString: GDPR_CONSENT_STRING}) + const pixel = spec.getUserSyncs({iframeEnabled: true}, {}, {gdprApplies: true, consentString: GDPR_CONSENT_STRING}) expect(pixel[0].type).to.equal('iframe'); expect(pixel[0].url).to.equal('https://public.servenobid.com/sync.html?gdpr=1&gdpr_consent=' + GDPR_CONSENT_STRING); }); it('should get correct user sync when !iframeEnabled', function () { - let pixel = spec.getUserSyncs({iframeEnabled: false}) + const pixel = spec.getUserSyncs({iframeEnabled: false}) expect(pixel.length).to.equal(0); }); it('should get correct user sync when !iframeEnabled and pixelEnabled', function () { - let pixel = spec.getUserSyncs({iframeEnabled: false, pixelEnabled: true}, [{body: {syncs: ['sync_url']}}]) + const pixel = spec.getUserSyncs({iframeEnabled: false, pixelEnabled: true}, [{body: {syncs: ['sync_url']}}]) expect(pixel.length).to.equal(1); expect(pixel[0].type).to.equal('image'); expect(pixel[0].url).to.equal('sync_url'); @@ -1072,14 +1072,14 @@ describe('Nobid Adapter', function () { describe('onTimeout', function (syncOptions) { it('should increment timeoutTotal', function () { - let timeoutTotal = spec.onTimeout() + const timeoutTotal = spec.onTimeout() expect(timeoutTotal).to.equal(1); }); }); describe('onBidWon', function (syncOptions) { it('should increment bidWonTotal', function () { - let bidWonTotal = spec.onBidWon() + const bidWonTotal = spec.onBidWon() expect(bidWonTotal).to.equal(1); }); }); diff --git a/test/spec/modules/nodalsAiRtdProvider_spec.js b/test/spec/modules/nodalsAiRtdProvider_spec.js index bfa38ef5424..f07d13fd11b 100644 --- a/test/spec/modules/nodalsAiRtdProvider_spec.js +++ b/test/spec/modules/nodalsAiRtdProvider_spec.js @@ -366,7 +366,7 @@ describe('NodalsAI RTD Provider', () => { describe('when performing requests to the publisher endpoint', () => { it('should construct the correct URL to the default origin', () => { nodalsAiRtdSubmodule.init(validConfig, permissiveUserConsent); - let request = server.requests[0]; + const request = server.requests[0]; server.respond(); expect(request.method).to.equal('GET'); @@ -379,7 +379,7 @@ describe('NodalsAI RTD Provider', () => { const config = Object.assign({}, validConfig); config.params.endpoint = { origin: 'http://localhost:8000' }; nodalsAiRtdSubmodule.init(config, permissiveUserConsent); - let request = server.requests[0]; + const request = server.requests[0]; server.respond(); expect(request.method).to.equal('GET'); @@ -390,7 +390,7 @@ describe('NodalsAI RTD Provider', () => { it('should construct the correct URL with the correct path', () => { nodalsAiRtdSubmodule.init(validConfig, permissiveUserConsent); - let request = server.requests[0]; + const request = server.requests[0]; server.respond(); const requestUrl = new URL(request.url); @@ -402,7 +402,7 @@ describe('NodalsAI RTD Provider', () => { consentString: 'foobarbaz', }; nodalsAiRtdSubmodule.init(validConfig, generateGdprConsent(consentData)); - let request = server.requests[0]; + const request = server.requests[0]; server.respond(); const requestUrl = new URL(request.url); @@ -419,7 +419,7 @@ describe('NodalsAI RTD Provider', () => { describe('when handling responses from the publisher endpoint', () => { it('should store successful response data in local storage', () => { nodalsAiRtdSubmodule.init(validConfig, permissiveUserConsent); - let request = server.requests[0]; + const request = server.requests[0]; server.respond(); const storedData = JSON.parse( @@ -438,7 +438,7 @@ describe('NodalsAI RTD Provider', () => { config.params.storage = { key: overrideLocalStorageKey }; nodalsAiRtdSubmodule.init(config, permissiveUserConsent); server.respond(); - let request = server.requests[0]; + const request = server.requests[0]; const storedData = JSON.parse( nodalsAiRtdSubmodule.storage.getDataFromLocalStorage(overrideLocalStorageKey) ); diff --git a/test/spec/modules/novatiqIdSystem_spec.js b/test/spec/modules/novatiqIdSystem_spec.js index 6d25601d958..b8906a9a1cc 100644 --- a/test/spec/modules/novatiqIdSystem_spec.js +++ b/test/spec/modules/novatiqIdSystem_spec.js @@ -3,7 +3,7 @@ import * as utils from 'src/utils.js'; import { server } from 'test/mocks/xhr.js'; describe('novatiqIdSystem', function () { - let urlParams = { + const urlParams = { novatiqId: 'snowflake', useStandardUuid: false, useSspId: true, @@ -62,7 +62,7 @@ describe('novatiqIdSystem', function () { it('should set sharedStatus if sharedID is configured and is valid', function() { const config = { params: { sourceid: '123', useSharedId: true } }; - let stub = sinon.stub(novatiqIdSubmodule, 'getSharedId').returns('fakeId'); + const stub = sinon.stub(novatiqIdSubmodule, 'getSharedId').returns('fakeId'); const response = novatiqIdSubmodule.getId(config); @@ -74,7 +74,7 @@ describe('novatiqIdSystem', function () { it('should set sharedStatus if sharedID is configured and is valid when making an async call', function() { const config = { params: { sourceid: '123', useSharedId: true, useCallbacks: true } }; - let stub = sinon.stub(novatiqIdSubmodule, 'getSharedId').returns('fakeId'); + const stub = sinon.stub(novatiqIdSubmodule, 'getSharedId').returns('fakeId'); const response = novatiqIdSubmodule.getId(config); @@ -100,7 +100,7 @@ describe('novatiqIdSystem', function () { }); it('should return custom url parameters when set', function() { - let customUrlParams = { + const customUrlParams = { novatiqId: 'hyperid', useStandardUuid: true, useSspId: false, @@ -145,7 +145,7 @@ describe('novatiqIdSystem', function () { }); it('should change the result format if async', function() { - let novatiqId = {}; + const novatiqId = {}; novatiqId.id = '81b001ec-8914-488c-a96e-8c220d4ee08895ef'; novatiqId.syncResponse = 2; const response = novatiqIdSubmodule.decode(novatiqId); @@ -155,7 +155,7 @@ describe('novatiqIdSystem', function () { }); it('should remove syncResponse if removeAdditionalInfo true', function() { - let novatiqId = {}; + const novatiqId = {}; novatiqId.id = '81b001ec-8914-488c-a96e-8c220d4ee08895ef'; novatiqId.syncResponse = 2; var config = {params: {removeAdditionalInfo: true}}; diff --git a/test/spec/modules/oguryBidAdapter_spec.js b/test/spec/modules/oguryBidAdapter_spec.js index cc65450300a..f6922f70942 100644 --- a/test/spec/modules/oguryBidAdapter_spec.js +++ b/test/spec/modules/oguryBidAdapter_spec.js @@ -121,34 +121,34 @@ describe('OguryBidAdapter', () => { describe('isBidRequestValid', () => { it('should validate correct bid', () => { - let validBid = utils.deepClone(bidRequests[0]); + const validBid = utils.deepClone(bidRequests[0]); - let isValid = spec.isBidRequestValid(validBid); + const isValid = spec.isBidRequestValid(validBid); expect(isValid).to.true; }); it('should not validate when sizes is not defined', () => { - let invalidBid = utils.deepClone(bidRequests[0]); + const invalidBid = utils.deepClone(bidRequests[0]); delete invalidBid.sizes; delete invalidBid.mediaTypes; - let isValid = spec.isBidRequestValid(invalidBid); + const isValid = spec.isBidRequestValid(invalidBid); expect(isValid).to.be.false; }); it('should not validate bid when adunit is not defined', () => { - let invalidBid = utils.deepClone(bidRequests[0]); + const invalidBid = utils.deepClone(bidRequests[0]); delete invalidBid.params.adUnitId; - let isValid = spec.isBidRequestValid(invalidBid); + const isValid = spec.isBidRequestValid(invalidBid); expect(isValid).to.to.be.false; }); it('should not validate bid when assetKey is not defined', () => { - let invalidBid = utils.deepClone(bidRequests[0]); + const invalidBid = utils.deepClone(bidRequests[0]); delete invalidBid.params.assetKey; - let isValid = spec.isBidRequestValid(invalidBid); + const isValid = spec.isBidRequestValid(invalidBid); expect(isValid).to.be.false; }); @@ -851,7 +851,7 @@ describe('OguryBidAdapter', () => { }); describe('interpretResponse', function () { - let openRtbBidResponse = { + const openRtbBidResponse = { body: { id: 'id_of_bid_response', seatbid: [{ diff --git a/test/spec/modules/omsBidAdapter_spec.js b/test/spec/modules/omsBidAdapter_spec.js index ead1d387811..6727c16092f 100644 --- a/test/spec/modules/omsBidAdapter_spec.js +++ b/test/spec/modules/omsBidAdapter_spec.js @@ -90,7 +90,7 @@ describe('omsBidAdapter', function () { }); describe('isBidRequestValid', function () { - let bid = { + const bid = { 'bidder': 'oms', 'params': { 'publisherId': 1234567 @@ -116,7 +116,7 @@ describe('omsBidAdapter', function () { }); it('should return false when require params are not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); invalidBid.params = {}; expect(spec.isBidRequestValid(invalidBid)).to.equal(false); }); @@ -401,7 +401,7 @@ describe('omsBidAdapter', function () { }); it('should get the correct bid response', function () { - let expectedResponse = [{ + const expectedResponse = [{ 'requestId': '283a9f4cd2415d', 'cpm': 0.35743275, 'width': 300, @@ -417,12 +417,12 @@ describe('omsBidAdapter', function () { } }]; - let result = spec.interpretResponse(response); + const result = spec.interpretResponse(response); expect(result[0]).to.deep.equal(expectedResponse[0]); }); it('should get the correct bid response for video bids', function () { - let expectedResponse = [{ + const expectedResponse = [{ 'requestId': '283a9f4cd2415d', 'cpm': 0.35743275, 'width': 300, @@ -456,12 +456,12 @@ describe('omsBidAdapter', function () { } }; - let result = spec.interpretResponse(response); + const result = spec.interpretResponse(response); expect(result[0]).to.deep.equal(expectedResponse[0]); }); it('crid should default to the bid id if not on the response', function () { - let expectedResponse = [{ + const expectedResponse = [{ 'requestId': '283a9f4cd2415d', 'cpm': 0.35743275, 'width': 300, @@ -477,15 +477,15 @@ describe('omsBidAdapter', function () { } }]; - let result = spec.interpretResponse(response); + const result = spec.interpretResponse(response); expect(result[0]).to.deep.equal(expectedResponse[0]); }); it('handles empty bid response', function () { - let response = { + const response = { body: '' }; - let result = spec.interpretResponse(response); + const result = spec.interpretResponse(response); expect(result.length).to.equal(0); }); }); diff --git a/test/spec/modules/onetagBidAdapter_spec.js b/test/spec/modules/onetagBidAdapter_spec.js index e0e93137a27..c4266e69650 100644 --- a/test/spec/modules/onetagBidAdapter_spec.js +++ b/test/spec/modules/onetagBidAdapter_spec.js @@ -121,7 +121,7 @@ describe('onetag', function () { } function addNativeParams(bidRequest) { - let bidParams = bidRequest.nativeParams || {}; + const bidParams = bidRequest.nativeParams || {}; for (const property in bidRequest.mediaTypes.native) { bidParams[property] = bidRequest.mediaTypes.native[property]; } @@ -594,9 +594,9 @@ describe('onetag', function () { }); it('Returns empty data if no valid requests are passed', function () { serverRequest = spec.buildRequests([]); - let dataString = serverRequest.data; + const dataString = serverRequest.data; try { - let dataObj = JSON.parse(dataString); + const dataObj = JSON.parse(dataString); expect(dataObj.bids).to.be.an('array').that.is.empty; } catch (e) { } }); @@ -611,9 +611,9 @@ describe('onetag', function () { expect(payload.bids[0].ortb2Imp).to.deep.equal(bannerBid.ortb2Imp); }); it('should send GDPR consent data', function () { - let consentString = 'consentString'; - let addtlConsent = '2~1.35.41.101~dv.9.21.81'; - let bidderRequest = { + const consentString = 'consentString'; + const addtlConsent = '2~1.35.41.101~dv.9.21.81'; + const bidderRequest = { 'bidderCode': 'onetag', 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', @@ -624,7 +624,7 @@ describe('onetag', function () { addtlConsent: addtlConsent } }; - let serverRequest = spec.buildRequests([bannerBid], bidderRequest); + const serverRequest = spec.buildRequests([bannerBid], bidderRequest); const payload = JSON.parse(serverRequest.data); expect(payload).to.exist; @@ -634,9 +634,9 @@ describe('onetag', function () { expect(payload.gdprConsent.consentRequired).to.exist.and.to.be.true; }); it('Should send GPP consent data', function () { - let consentString = 'consentString'; - let applicableSections = [1, 2, 3]; - let bidderRequest = { + const consentString = 'consentString'; + const applicableSections = [1, 2, 3]; + const bidderRequest = { 'bidderCode': 'onetag', 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', @@ -646,7 +646,7 @@ describe('onetag', function () { applicableSections: applicableSections } }; - let serverRequest = spec.buildRequests([bannerBid], bidderRequest); + const serverRequest = spec.buildRequests([bannerBid], bidderRequest); const payload = JSON.parse(serverRequest.data); expect(payload).to.exist; @@ -655,15 +655,15 @@ describe('onetag', function () { expect(payload.gppConsent.applicableSections).to.have.same.members(applicableSections); }); it('Should send us privacy string', function () { - let consentString = 'us_foo'; - let bidderRequest = { + const consentString = 'us_foo'; + const bidderRequest = { 'bidderCode': 'onetag', 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', 'timeout': 3000, 'uspConsent': consentString }; - let serverRequest = spec.buildRequests([bannerBid], bidderRequest); + const serverRequest = spec.buildRequests([bannerBid], bidderRequest); const payload = JSON.parse(serverRequest.data); expect(payload.usPrivacy).to.exist; @@ -726,14 +726,14 @@ describe('onetag', function () { gpp_sid: [7] } }; - let bidderRequest = { + const bidderRequest = { 'bidderCode': 'onetag', 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', 'timeout': 3000, 'ortb2': firtPartyData } - let serverRequest = spec.buildRequests([bannerBid], bidderRequest); + const serverRequest = spec.buildRequests([bannerBid], bidderRequest); const payload = JSON.parse(serverRequest.data); expect(payload.ortb2).to.exist; expect(payload.ortb2).to.exist.and.to.deep.equal(firtPartyData); @@ -754,20 +754,20 @@ describe('onetag', function () { } } }; - let bidderRequest = { + const bidderRequest = { 'bidderCode': 'onetag', 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', 'timeout': 3000, 'ortb2': dsa } - let serverRequest = spec.buildRequests([bannerBid], bidderRequest); + const serverRequest = spec.buildRequests([bannerBid], bidderRequest); const payload = JSON.parse(serverRequest.data); expect(payload.ortb2).to.exist; expect(payload.ortb2).to.exist.and.to.deep.equal(dsa); }); it('Should send FLEDGE eligibility flag when FLEDGE is enabled', function () { - let bidderRequest = { + const bidderRequest = { 'bidderCode': 'onetag', 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', @@ -776,14 +776,14 @@ describe('onetag', function () { 'enabled': true } }; - let serverRequest = spec.buildRequests([bannerBid], bidderRequest); + const serverRequest = spec.buildRequests([bannerBid], bidderRequest); const payload = JSON.parse(serverRequest.data); expect(payload.fledgeEnabled).to.exist; expect(payload.fledgeEnabled).to.exist.and.to.equal(bidderRequest.paapi.enabled); }); it('Should send FLEDGE eligibility flag when FLEDGE is not enabled', function () { - let bidderRequest = { + const bidderRequest = { 'bidderCode': 'onetag', 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', @@ -792,20 +792,20 @@ describe('onetag', function () { enabled: false } }; - let serverRequest = spec.buildRequests([bannerBid], bidderRequest); + const serverRequest = spec.buildRequests([bannerBid], bidderRequest); const payload = JSON.parse(serverRequest.data); expect(payload.fledgeEnabled).to.exist; expect(payload.fledgeEnabled).to.exist.and.to.equal(bidderRequest.paapi.enabled); }); it('Should send FLEDGE eligibility flag set to false when fledgeEnabled is not defined', function () { - let bidderRequest = { + const bidderRequest = { 'bidderCode': 'onetag', 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', 'timeout': 3000, }; - let serverRequest = spec.buildRequests([bannerBid], bidderRequest); + const serverRequest = spec.buildRequests([bannerBid], bidderRequest); const payload = JSON.parse(serverRequest.data); expect(payload.fledgeEnabled).to.exist; @@ -827,7 +827,7 @@ describe('onetag', function () { }); expect(fledgeInterpretedResponse.paapi).to.be.an('array').that.is.not.empty; for (let i = 0; i < interpretedResponse.length; i++) { - let dataItem = interpretedResponse[i]; + const dataItem = interpretedResponse[i]; expect(dataItem).to.include.all.keys('requestId', 'cpm', 'width', 'height', 'ttl', 'creativeId', 'netRevenue', 'currency', 'meta', 'dealId'); if (dataItem.meta.mediaType === VIDEO) { const { context } = requestData.bids.find((item) => item.bidId === dataItem.requestId); @@ -953,7 +953,7 @@ describe('onetag', function () { expect(syncs[0].url).to.not.match(/(?:[?&](?:gpp_consent=([^&]*)))+$/); }); it('Should send us privacy string', function () { - let usConsentString = 'us_foo'; + const usConsentString = 'us_foo'; const syncs = spec.getUserSyncs({ iframeEnabled: true }, {}, {}, usConsentString); expect(syncs[0].type).to.equal('iframe'); expect(syncs[0].url).to.include(sync_endpoint); diff --git a/test/spec/modules/onomagicBidAdapter_spec.js b/test/spec/modules/onomagicBidAdapter_spec.js index dd05fa9870c..93819272f15 100644 --- a/test/spec/modules/onomagicBidAdapter_spec.js +++ b/test/spec/modules/onomagicBidAdapter_spec.js @@ -66,7 +66,7 @@ describe('onomagicBidAdapter', function() { }); describe('isBidRequestValid', function () { - let bid = { + const bid = { 'bidder': 'onomagic', 'params': { 'publisherId': 1234567 @@ -92,7 +92,7 @@ describe('onomagicBidAdapter', function() { }); it('should return false when require params are not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); invalidBid.params = {}; expect(spec.isBidRequestValid(invalidBid)).to.equal(false); }); @@ -235,7 +235,7 @@ describe('onomagicBidAdapter', function() { }); it('should get the correct bid response', function () { - let expectedResponse = [{ + const expectedResponse = [{ 'requestId': '283a9f4cd2415d', 'cpm': 0.35743275, 'width': 300, @@ -251,12 +251,12 @@ describe('onomagicBidAdapter', function() { } }]; - let result = spec.interpretResponse(response); + const result = spec.interpretResponse(response); expect(result[0]).to.deep.equal(expectedResponse[0]); }); it('crid should default to the bid id if not on the response', function () { - let expectedResponse = [{ + const expectedResponse = [{ 'requestId': '283a9f4cd2415d', 'cpm': 0.35743275, 'width': 300, @@ -272,24 +272,24 @@ describe('onomagicBidAdapter', function() { } }]; - let result = spec.interpretResponse(response); + const result = spec.interpretResponse(response); expect(result[0]).to.deep.equal(expectedResponse[0]); }); it('handles empty bid response', function () { - let response = { + const response = { body: '' }; - let result = spec.interpretResponse(response); + const result = spec.interpretResponse(response); expect(result.length).to.equal(0); }); }); describe('getUserSyncs ', () => { - let syncOptions = {iframeEnabled: true, pixelEnabled: true}; + const syncOptions = {iframeEnabled: true, pixelEnabled: true}; it('should not return', () => { - let returnStatement = spec.getUserSyncs(syncOptions, []); + const returnStatement = spec.getUserSyncs(syncOptions, []); expect(returnStatement).to.be.empty; }); }); diff --git a/test/spec/modules/ooloAnalyticsAdapter_spec.js b/test/spec/modules/ooloAnalyticsAdapter_spec.js index f5b3cebf307..3a86f567f05 100644 --- a/test/spec/modules/ooloAnalyticsAdapter_spec.js +++ b/test/spec/modules/ooloAnalyticsAdapter_spec.js @@ -731,7 +731,7 @@ describe('oolo Prebid Analytic', () => { }); describe('buildAuctionData', () => { - let auction = { + const auction = { auctionId, auctionStart, auctionEnd, diff --git a/test/spec/modules/open8BidAdapter_spec.js b/test/spec/modules/open8BidAdapter_spec.js index 27e460bad9d..049aead514d 100644 --- a/test/spec/modules/open8BidAdapter_spec.js +++ b/test/spec/modules/open8BidAdapter_spec.js @@ -7,7 +7,7 @@ describe('Open8Adapter', function() { const adapter = newBidder(spec); describe('isBidRequestValid', function() { - let bid = { + const bid = { 'bidder': 'open8', 'params': { 'slotKey': 'slotkey1234' @@ -32,7 +32,7 @@ describe('Open8Adapter', function() { }); describe('buildRequests', function() { - let bidRequests = [ + const bidRequests = [ { 'bidder': 'open8', 'params': { @@ -117,7 +117,7 @@ describe('Open8Adapter', function() { }; it('should get correct banner bid response', function() { - let expectedResponse = [{ + const expectedResponse = [{ 'slotKey': 'slotkey1234', 'userId': 'userid1234', 'impId': 'impid1234', @@ -143,13 +143,13 @@ describe('Open8Adapter', function() { }]; let bidderRequest; - let result = spec.interpretResponse({ body: bannerResponse }, { bidderRequest }); + const result = spec.interpretResponse({ body: bannerResponse }, { bidderRequest }); expect(Object.keys(result[0])).to.have.members(Object.keys(expectedResponse[0])); expect(result[0]).to.nested.contain.property('meta.advertiserDomains', adomin); }); it('handles video responses', function() { - let expectedResponse = [{ + const expectedResponse = [{ 'slotKey': 'slotkey1234', 'userId': 'userid1234', 'impId': 'impid1234', @@ -177,19 +177,19 @@ describe('Open8Adapter', function() { }]; let bidderRequest; - let result = spec.interpretResponse({ body: videoResponse }, { bidderRequest }); + const result = spec.interpretResponse({ body: videoResponse }, { bidderRequest }); expect(Object.keys(result[0])).to.have.members(Object.keys(expectedResponse[0])); expect(result[0]).to.nested.contain.property('meta.advertiserDomains', adomin); }); it('handles nobid responses', function() { - let response = { + const response = { isAdReturn: false, 'ad': {} }; let bidderRequest; - let result = spec.interpretResponse({ body: response }, { bidderRequest }); + const result = spec.interpretResponse({ body: response }, { bidderRequest }); expect(result.length).to.equal(0); }); }); diff --git a/test/spec/modules/openPairIdSystem_spec.js b/test/spec/modules/openPairIdSystem_spec.js index 9a1c77526f9..e6fbd653749 100644 --- a/test/spec/modules/openPairIdSystem_spec.js +++ b/test/spec/modules/openPairIdSystem_spec.js @@ -25,10 +25,10 @@ describe('openPairId', function () { }); it('should read publisher id from specified clean room if configured with storageKey', function() { - let publisherIds = ['dGVzdC1wYWlyLWlkMQ==', 'test-pair-id2', 'test-pair-id3']; + const publisherIds = ['dGVzdC1wYWlyLWlkMQ==', 'test-pair-id2', 'test-pair-id3']; sandbox.stub(storage, 'getDataFromLocalStorage').withArgs('habu_pairId_custom').returns(btoa(JSON.stringify({'envelope': publisherIds}))); - let id = openPairIdSubmodule.getId({ + const id = openPairIdSubmodule.getId({ params: { habu: { storageKey: 'habu_pairId_custom' @@ -39,14 +39,14 @@ describe('openPairId', function () { }); it('should read publisher id from liveramp with default storageKey and additional clean room with configured storageKey', function() { - let getDataStub = sandbox.stub(storage, 'getDataFromLocalStorage'); - let liveRampPublisherIds = ['lr-test-pair-id1', 'lr-test-pair-id2', 'lr-test-pair-id3']; + const getDataStub = sandbox.stub(storage, 'getDataFromLocalStorage'); + const liveRampPublisherIds = ['lr-test-pair-id1', 'lr-test-pair-id2', 'lr-test-pair-id3']; getDataStub.withArgs('_lr_pairId').returns(btoa(JSON.stringify({'envelope': liveRampPublisherIds}))); - let habuPublisherIds = ['habu-test-pair-id1', 'habu-test-pair-id2', 'habu-test-pair-id3']; + const habuPublisherIds = ['habu-test-pair-id1', 'habu-test-pair-id2', 'habu-test-pair-id3']; getDataStub.withArgs('habu_pairId_custom').returns(btoa(JSON.stringify({'envelope': habuPublisherIds}))); - let id = openPairIdSubmodule.getId({ + const id = openPairIdSubmodule.getId({ params: { habu: { storageKey: 'habu_pairId_custom' @@ -63,25 +63,25 @@ describe('openPairId', function () { }); it('should read publisher id from local storage if exists', function() { - let publisherIds = ['test-pair-id1', 'test-pair-id2', 'test-pair-id3']; + const publisherIds = ['test-pair-id1', 'test-pair-id2', 'test-pair-id3']; sandbox.stub(storage, 'getDataFromLocalStorage').withArgs('pairId').returns(btoa(JSON.stringify(publisherIds))); - let id = openPairIdSubmodule.getId({ params: {} }); + const id = openPairIdSubmodule.getId({ params: {} }); expect(id).to.be.deep.equal({id: publisherIds}); }); it('should read publisher id from cookie if exists', function() { - let publisherIds = ['test-pair-id4', 'test-pair-id5', 'test-pair-id6']; + const publisherIds = ['test-pair-id4', 'test-pair-id5', 'test-pair-id6']; sandbox.stub(storage, 'getCookie').withArgs('pairId').returns(btoa(JSON.stringify(publisherIds))); - let id = openPairIdSubmodule.getId({ params: {} }); + const id = openPairIdSubmodule.getId({ params: {} }); expect(id).to.be.deep.equal({id: publisherIds}); }); it('should read publisher id from default liveramp envelope local storage key if configured', function() { - let publisherIds = ['test-pair-id1', 'test-pair-id2', 'test-pair-id3']; + const publisherIds = ['test-pair-id1', 'test-pair-id2', 'test-pair-id3']; sandbox.stub(storage, 'getDataFromLocalStorage').withArgs('_lr_pairId').returns(btoa(JSON.stringify({'envelope': publisherIds}))); - let id = openPairIdSubmodule.getId({ + const id = openPairIdSubmodule.getId({ params: { liveramp: {} }}) @@ -89,9 +89,9 @@ describe('openPairId', function () { }); it('should read publisher id from default liveramp envelope cookie entry if configured', function() { - let publisherIds = ['test-pair-id4', 'test-pair-id5', 'test-pair-id6']; + const publisherIds = ['test-pair-id4', 'test-pair-id5', 'test-pair-id6']; sandbox.stub(storage, 'getDataFromLocalStorage').withArgs('_lr_pairId').returns(btoa(JSON.stringify({'envelope': publisherIds}))); - let id = openPairIdSubmodule.getId({ + const id = openPairIdSubmodule.getId({ params: { liveramp: {} }}) @@ -99,9 +99,9 @@ describe('openPairId', function () { }); it('should read publisher id from specified liveramp envelope cookie entry if configured with storageKey', function() { - let publisherIds = ['test-pair-id7', 'test-pair-id8', 'test-pair-id9']; + const publisherIds = ['test-pair-id7', 'test-pair-id8', 'test-pair-id9']; sandbox.stub(storage, 'getDataFromLocalStorage').withArgs('lr_pairId_custom').returns(btoa(JSON.stringify({'envelope': publisherIds}))); - let id = openPairIdSubmodule.getId({ + const id = openPairIdSubmodule.getId({ params: { liveramp: { storageKey: 'lr_pairId_custom' @@ -113,7 +113,7 @@ describe('openPairId', function () { it('should not get data from storage if local storage and cookies are disabled', function () { sandbox.stub(storage, 'localStorageIsEnabled').returns(false); sandbox.stub(storage, 'cookiesAreEnabled').returns(false); - let id = openPairIdSubmodule.getId({ + const id = openPairIdSubmodule.getId({ params: { liveramp: { storageKey: 'lr_pairId_custom' @@ -153,7 +153,7 @@ describe('openPairId', function () { it('encodes and decodes the original value with atob/btoa', function () { const value = 'dGVzdC1wYWlyLWlkMQ=='; - let publisherIds = [value]; + const publisherIds = [value]; const stored = btoa(JSON.stringify({'envelope': publisherIds})); diff --git a/test/spec/modules/openwebBidAdapter_spec.js b/test/spec/modules/openwebBidAdapter_spec.js index 02945125ca2..8947029b2cc 100644 --- a/test/spec/modules/openwebBidAdapter_spec.js +++ b/test/spec/modules/openwebBidAdapter_spec.js @@ -448,57 +448,33 @@ describe('openwebAdapter', function () { 'architecture': 'x86' } const bid = utils.deepClone(bidRequests[0]); - bid.ortb2 = { + const bidderRequestWithSua = utils.deepClone(bidderRequest); + bidderRequestWithSua.ortb2 = { 'device': { - 'sua': { - 'platform': { - 'brand': 'macOS', - 'version': [ '12', '4', '0' ] - }, - 'browsers': [ - { - 'brand': 'Chromium', - 'version': [ '106', '0', '5249', '119' ] - }, - { - 'brand': 'Google Chrome', - 'version': [ '106', '0', '5249', '119' ] - }, - { - 'brand': 'Not;A=Brand', - 'version': [ '99', '0', '0', '0' ] - } - ], - 'mobile': 0, - 'model': '', - 'bitness': '64', - 'architecture': 'x86' - } + 'sua': sua } - } - const requestWithSua = spec.buildRequests([bid], bidderRequest); + }; + const requestWithSua = spec.buildRequests([bid], bidderRequestWithSua); const data = requestWithSua.data; - expect(data.bids[0].sua).to.exist; - expect(data.bids[0].sua).to.deep.equal(sua); - const request = spec.buildRequests(bidRequests, bidderRequest); - expect(request.data.bids[0].sua).to.not.exist; + expect(data.params.sua).to.exist; + expect(data.params.sua).to.deep.equal(JSON.stringify(sua)); }); describe('COPPA Param', function() { - it('should set coppa equal 0 in bid request if coppa is set to false', function() { + it('should set coppa equal 0 in bid request if coppa is set to 0', function() { const request = spec.buildRequests(bidRequests, bidderRequest); - expect(request.data.bids[0].coppa).to.be.equal(0); + expect(request.data.params.coppa).to.be.equal(0); }); - it('should set coppa equal 1 in bid request if coppa is set to true', function() { - const bid = utils.deepClone(bidRequests[0]); - bid.ortb2 = { + it('should set coppa equal 1 in bid request if coppa is set to 1', function() { + const bidderRequestWithCoppa = utils.deepClone(bidderRequest); + bidderRequestWithCoppa.ortb2 = { 'regs': { - 'coppa': true, + 'coppa': 1, } }; - const request = spec.buildRequests([bid], bidderRequest); - expect(request.data.bids[0].coppa).to.be.equal(1); + const request = spec.buildRequests(bidRequests, bidderRequestWithCoppa); + expect(request.data.params.coppa).to.be.equal(1); }); }); }); diff --git a/test/spec/modules/openxBidAdapter_spec.js b/test/spec/modules/openxBidAdapter_spec.js index 3812083bf59..1fb85682e0e 100644 --- a/test/spec/modules/openxBidAdapter_spec.js +++ b/test/spec/modules/openxBidAdapter_spec.js @@ -187,7 +187,7 @@ describe('OpenxRtbAdapter', function () { }); it('should return false when required params are not passed', function () { - let invalidVideoBidWithMediaTypes = Object.assign({}, videoBidWithMediaTypes); + const invalidVideoBidWithMediaTypes = Object.assign({}, videoBidWithMediaTypes); invalidVideoBidWithMediaTypes.params = {}; expect(spec.isBidRequestValid(invalidVideoBidWithMediaTypes)).to.equal(false); }); @@ -216,7 +216,7 @@ describe('OpenxRtbAdapter', function () { }); it('should return false when required params are not passed', function () { - let invalidVideoBidWithMediaTypes = Object.assign({}, videoBidWithDelDomainAndPlatform); + const invalidVideoBidWithMediaTypes = Object.assign({}, videoBidWithDelDomainAndPlatform); invalidVideoBidWithMediaTypes.params = {}; expect(spec.isBidRequestValid(invalidVideoBidWithMediaTypes)).to.equal(false); }); @@ -241,7 +241,7 @@ describe('OpenxRtbAdapter', function () { }); it('should return false when required params are not passed', function () { - let invalidVideoBidWithMediaType = Object.assign({}, videoBidWithMediaType); + const invalidVideoBidWithMediaType = Object.assign({}, videoBidWithMediaType); delete invalidVideoBidWithMediaType.params; invalidVideoBidWithMediaType.params = {}; expect(spec.isBidRequestValid(invalidVideoBidWithMediaType)).to.equal(false); @@ -286,7 +286,7 @@ describe('OpenxRtbAdapter', function () { }); it('should return false when required params are not passed', function () { - let invalidNativeBidWithMediaTypes = Object.assign({}, nativeBidWithMediaTypes); + const invalidNativeBidWithMediaTypes = Object.assign({}, nativeBidWithMediaTypes); invalidNativeBidWithMediaTypes.params = {}; expect(spec.isBidRequestValid(invalidNativeBidWithMediaTypes)).to.equal(false); }); @@ -320,7 +320,7 @@ describe('OpenxRtbAdapter', function () { }); it('should return false when required params are not passed', function () { - let invalidNativeBidWithMediaTypes = Object.assign({}, nativeBidWithDelDomainAndPlatform); + const invalidNativeBidWithMediaTypes = Object.assign({}, nativeBidWithDelDomainAndPlatform); invalidNativeBidWithMediaTypes.params = {}; expect(spec.isBidRequestValid(invalidNativeBidWithMediaTypes)).to.equal(false); }); @@ -635,7 +635,7 @@ describe('OpenxRtbAdapter', function () { } } }); - let data = request[0].data; + const data = request[0].data; expect(data.site.domain).to.equal('page.example.com'); expect(data.site.cat).to.deep.equal(['IAB2']); expect(data.site.sectioncat).to.deep.equal(['IAB2-2']); @@ -650,7 +650,7 @@ describe('OpenxRtbAdapter', function () { } } }); - let data = request[0].data; + const data = request[0].data; expect(data.user.yob).to.equal(1985); }); @@ -667,7 +667,7 @@ describe('OpenxRtbAdapter', function () { ext: {} }; const request = spec.buildRequests(bidRequests, mockBidderRequest); - let data = request[0].data; + const data = request[0].data; expect(data.imp[0].ext).to.not.have.property('data'); }); @@ -679,7 +679,7 @@ describe('OpenxRtbAdapter', function () { } }; const request = spec.buildRequests(bidRequests, mockBidderRequest); - let data = request[0].data; + const data = request[0].data; if (data.imp[0].ext.data) { expect(data.imp[0].ext.data).to.not.have.property('pbadslot'); } else { @@ -696,7 +696,7 @@ describe('OpenxRtbAdapter', function () { } }; const request = spec.buildRequests(bidRequests, mockBidderRequest); - let data = request[0].data; + const data = request[0].data; expect(data.imp[0].ext.data).to.have.property('pbadslot'); expect(data.imp[0].ext.data.pbadslot).to.equal('abcd'); }); @@ -714,7 +714,7 @@ describe('OpenxRtbAdapter', function () { ext: {} }; const request = spec.buildRequests(bidRequests, mockBidderRequest); - let data = request[0].data; + const data = request[0].data; expect(data.imp[0].ext).to.not.have.property('data'); }); @@ -726,7 +726,7 @@ describe('OpenxRtbAdapter', function () { } }; const request = spec.buildRequests(bidRequests, mockBidderRequest); - let data = request[0].data; + const data = request[0].data; if (data.imp[0].ext.data) { expect(data.imp[0].ext.data).to.not.have.property('adserver'); } else { @@ -735,7 +735,7 @@ describe('OpenxRtbAdapter', function () { }); it('should send', function() { - let adSlotValue = 'abc'; + const adSlotValue = 'abc'; bidRequests[0].ortb2Imp = { ext: { data: { @@ -747,7 +747,7 @@ describe('OpenxRtbAdapter', function () { } }; const request = spec.buildRequests(bidRequests, mockBidderRequest); - let data = request[0].data; + const data = request[0].data; expect(data.imp[0].ext.data.adserver.name).to.equal('GAM'); expect(data.imp[0].ext.data.adserver.adslot).to.equal(adSlotValue); }); @@ -765,7 +765,7 @@ describe('OpenxRtbAdapter', function () { ext: {} }; const request = spec.buildRequests(bidRequests, mockBidderRequest); - let data = request[0].data; + const data = request[0].data; expect(data.imp[0].ext).to.not.have.property('data'); }); @@ -777,7 +777,7 @@ describe('OpenxRtbAdapter', function () { } }; const request = spec.buildRequests(bidRequests, mockBidderRequest); - let data = request[0].data; + const data = request[0].data; if (data.imp[0].ext.data) { expect(data.imp[0].ext.data).to.not.have.property('other'); } else { @@ -794,7 +794,7 @@ describe('OpenxRtbAdapter', function () { } }; const request = spec.buildRequests(bidRequests, mockBidderRequest); - let data = request[0].data; + const data = request[0].data; expect(data.imp[0].ext.data.other).to.equal(1234); }); }); @@ -997,7 +997,7 @@ describe('OpenxRtbAdapter', function () { }); it('should send a coppa flag there is when there is coppa param settings in the bid requests', async function () { - let mockConfig = { + const mockConfig = { coppa: true }; @@ -1957,7 +1957,7 @@ describe('OpenxRtbAdapter', function () { describe('user sync', function () { it('should register the default image pixel if no pixels available', function () { - let syncs = spec.getUserSyncs( + const syncs = spec.getUserSyncs( {pixelEnabled: true}, [] ); @@ -1965,7 +1965,7 @@ describe('OpenxRtbAdapter', function () { }); it('should register custom syncUrl when exists', function () { - let syncs = spec.getUserSyncs( + const syncs = spec.getUserSyncs( {pixelEnabled: true}, [{body: {ext: {delDomain: 'www.url.com'}}}] ); @@ -1973,7 +1973,7 @@ describe('OpenxRtbAdapter', function () { }); it('should register custom syncUrl when exists', function () { - let syncs = spec.getUserSyncs( + const syncs = spec.getUserSyncs( {pixelEnabled: true}, [{body: {ext: {platform: 'abc'}}}] ); @@ -1981,7 +1981,7 @@ describe('OpenxRtbAdapter', function () { }); it('when iframe sync is allowed, it should register an iframe sync', function () { - let syncs = spec.getUserSyncs( + const syncs = spec.getUserSyncs( {iframeEnabled: true}, [] ); @@ -1989,7 +1989,7 @@ describe('OpenxRtbAdapter', function () { }); it('should prioritize iframe over image for user sync', function () { - let syncs = spec.getUserSyncs( + const syncs = spec.getUserSyncs( {iframeEnabled: true, pixelEnabled: true}, [] ); @@ -2011,7 +2011,7 @@ describe('OpenxRtbAdapter', function () { }); it('when there is a response, it should have the gdpr query params', () => { - let [{url}] = spec.getUserSyncs( + const [{url}] = spec.getUserSyncs( {iframeEnabled: true, pixelEnabled: true}, [], gdprConsent @@ -2022,7 +2022,7 @@ describe('OpenxRtbAdapter', function () { }); it('should not send signals if no consent object is available', function () { - let [{url}] = spec.getUserSyncs( + const [{url}] = spec.getUserSyncs( {iframeEnabled: true, pixelEnabled: true}, [], ); @@ -2040,7 +2040,7 @@ describe('OpenxRtbAdapter', function () { uspPixelUrl = `${DEFAULT_SYNC}&us_privacy=${privacyString}` }); it('should send the us privacy string, ', () => { - let [{url}] = spec.getUserSyncs( + const [{url}] = spec.getUserSyncs( {iframeEnabled: true, pixelEnabled: true}, [], undefined, @@ -2050,7 +2050,7 @@ describe('OpenxRtbAdapter', function () { }); it('should not send signals if no consent string is available', function () { - let [{url}] = spec.getUserSyncs( + const [{url}] = spec.getUserSyncs( {iframeEnabled: true, pixelEnabled: true}, [], ); diff --git a/test/spec/modules/operaadsBidAdapter_spec.js b/test/spec/modules/operaadsBidAdapter_spec.js index 9a8981235d5..15708c1bb42 100644 --- a/test/spec/modules/operaadsBidAdapter_spec.js +++ b/test/spec/modules/operaadsBidAdapter_spec.js @@ -248,7 +248,7 @@ describe('Opera Ads Bid Adapter', function () { expect(requestData.cur).to.be.an('array').that.not.be.empty; expect(requestData.user).to.be.an('object'); - let impItem = requestData.imp[0]; + const impItem = requestData.imp[0]; expect(impItem).to.be.an('object'); expect(impItem.id).to.equal(bidRequest.bidId); expect(impItem.tagid).to.equal(bidRequest.params.placementId); @@ -292,7 +292,7 @@ describe('Opera Ads Bid Adapter', function () { } it('test default case', function () { - let requestData = getRequest(); + const requestData = getRequest(); expect(requestData.site).to.be.an('object'); expect(requestData.site.id).to.equal(bidRequest.params.publisherId); expect(requestData.site.domain).to.not.be.empty; @@ -309,7 +309,7 @@ describe('Opera Ads Bid Adapter', function () { domain: 'www.test.com' } } - let requestData = getRequest(); + const requestData = getRequest(); expect(requestData.site).to.be.an('object'); expect(requestData.site.id).to.equal(bidRequest.params.publisherId); expect(requestData.site.name).to.equal('test-site-1'); @@ -326,7 +326,7 @@ describe('Opera Ads Bid Adapter', function () { name: 'test-app-1' } } - let requestData = getRequest(); + const requestData = getRequest(); expect(requestData.app).to.be.an('object'); expect(requestData.app.id).to.equal(bidRequest.params.publisherId); expect(requestData.app.name).to.equal('test-app-1'); @@ -346,7 +346,7 @@ describe('Opera Ads Bid Adapter', function () { name: 'test-app-1' } } - let requestData = getRequest(); + const requestData = getRequest(); expect(requestData.site).to.be.an('object'); expect(requestData.site.id).to.equal(bidRequest.params.publisherId); expect(requestData.site.name).to.equal('test-site-2'); diff --git a/test/spec/modules/oprxBidAdapter_spec.js b/test/spec/modules/oprxBidAdapter_spec.js new file mode 100644 index 00000000000..d0ef431e731 --- /dev/null +++ b/test/spec/modules/oprxBidAdapter_spec.js @@ -0,0 +1,100 @@ +import { expect } from 'chai'; +import { spec, __setTestConverter } from 'modules/oprxBidAdapter.js'; + +describe('oprxBidAdapter', function () { + const bid = { + bidder: 'oprx', + bidId: 'bid123', + auctionId: 'auction123', + adUnitCode: 'div-id', + transactionId: 'txn123', + mediaTypes: { + banner: { + sizes: [[300, 250]] + } + }, + params: { + key: 'abc', + placement_id: '123456', + npi: '9999999999', + bid_floor: 1.25 + } + }; + + const bidderRequest = { + auctionId: 'auction123', + bidderCode: 'oprx', + refererInfo: { referer: 'https://example.com' } + }; + + // SETUP: Replace real converter with mock + before(() => { + __setTestConverter({ + toORTB: ({ bRequests }) => ({ + id: 'test-request', + imp: bRequests.map(bid => ({ + id: bid.bidId, + banner: { format: [{ w: 300, h: 250 }] }, + bidfloor: bid.params.bid_floor || 0 + })), + cur: ['USD'], + site: { page: 'https://example.com' } + }), + fromORTB: ({ response }) => ({ + bids: response.seatbid?.[0]?.bid?.map(b => ({ + requestId: b.impid, + cpm: b.price, + ad: b.adm, + width: b.w, + height: b.h, + currency: 'USD', + creativeId: b.crid, + netRevenue: true, + ttl: 50 + })) || [] + }) + }); + }); + + describe('buildRequests', () => { + it('should build a valid request object', () => { + const request = spec.buildRequests([bid], bidderRequest)[0]; + expect(request.method).to.equal('POST'); + expect(request.url).to.include('placement_id=123456'); + expect(request.data).to.be.an('object'); + }); + }); + + describe('interpretResponse', () => { + let request; + + beforeEach(() => { + request = spec.buildRequests([bid], bidderRequest)[0]; + }); + + it('should return a valid bid response', () => { + const serverResponse = { + body: { + id: 'resp123', + cur: 'USD', + seatbid: [{ + bid: [{ + impid: 'bid123', + price: 2.5, + adm: '
Ad
', + crid: 'creative-789', + w: 300, + h: 250 + }] + }] + } + }; + + const bids = spec.interpretResponse(serverResponse, request); + expect(bids).to.be.an('array').with.lengthOf(1); + const b = bids[0]; + expect(b.cpm).to.equal(2.5); + expect(b.ad).to.include('Ad'); + }); + }); +}); diff --git a/test/spec/modules/optidigitalBidAdapter_spec.js b/test/spec/modules/optidigitalBidAdapter_spec.js index 2decdda7b2f..3b4ef61e961 100755 --- a/test/spec/modules/optidigitalBidAdapter_spec.js +++ b/test/spec/modules/optidigitalBidAdapter_spec.js @@ -179,7 +179,7 @@ describe('optidigitalAdapterTests', function () { } }; - let validBidRequests = [ + const validBidRequests = [ { 'bidder': 'optidigital', 'bidId': '51ef8751f9aead', @@ -253,7 +253,7 @@ describe('optidigitalAdapterTests', function () { }); it('should add adContainerWidth and adContainerHeight to payload if divId exsists in parameter', function () { - let validBidRequestsWithDivId = [ + const validBidRequestsWithDivId = [ { 'bidder': 'optidigital', 'bidId': '51ef8751f9aead', @@ -283,7 +283,7 @@ describe('optidigitalAdapterTests', function () { }); it('should add pageTemplate to payload if pageTemplate exsists in parameter', function () { - let validBidRequestsWithDivId = [ + const validBidRequestsWithDivId = [ { 'bidder': 'optidigital', 'bidId': '51ef8751f9aead', @@ -394,7 +394,7 @@ describe('optidigitalAdapterTests', function () { }); it('should send GDPR to given endpoint', function() { - let consentString = 'DFR8KRePoQNsRREZCADBG+A=='; + const consentString = 'DFR8KRePoQNsRREZCADBG+A=='; bidderRequest.gdprConsent = { 'consentString': consentString, 'gdprApplies': true, @@ -411,7 +411,7 @@ describe('optidigitalAdapterTests', function () { }); it('should send empty GDPR consent to endpoint', function() { - let consentString = false; + const consentString = false; bidderRequest.gdprConsent = { 'consentString': consentString, 'gdprApplies': true, @@ -433,7 +433,7 @@ describe('optidigitalAdapterTests', function () { }); it('should send gppConsent to given endpoint where there is gppConsent', function() { - let consentString = 'BOJ/P2HOJ/P2HABABMAAAAAZ+A=='; + const consentString = 'BOJ/P2HOJ/P2HABABMAAAAAZ+A=='; bidderRequest.gppConsent = { 'gppString': consentString, 'applicableSections': [7] @@ -444,7 +444,7 @@ describe('optidigitalAdapterTests', function () { }); it('should send gppConsent to given endpoint when there is gpp in ortb2', function() { - let consentString = 'BOJ/P2HOJ/P2HABABMAAAAAZ+A=='; + const consentString = 'BOJ/P2HOJ/P2HABABMAAAAAZ+A=='; bidderRequest.gppConsent = undefined; bidderRequest.ortb2 = { regs: { @@ -480,7 +480,7 @@ describe('optidigitalAdapterTests', function () { }); it('should fetch floor from floor module if it is available', function() { - let validBidRequestsWithCurrency = [ + const validBidRequestsWithCurrency = [ { 'bidder': 'optidigital', 'bidId': '51ef8751f9aead', @@ -505,7 +505,7 @@ describe('optidigitalAdapterTests', function () { let floorInfo; validBidRequestsWithCurrency[0].getFloor = () => floorInfo; floorInfo = { currency: 'USD', floor: 1.99 }; - let request = spec.buildRequests(validBidRequestsWithCurrency, bidderRequest); + const request = spec.buildRequests(validBidRequestsWithCurrency, bidderRequest); const payload = JSON.parse(request.data); expect(payload.imp[0].bidFloor).to.exist; }); @@ -590,7 +590,7 @@ describe('optidigitalAdapterTests', function () { }); describe('interpretResponse', function () { it('should get bids', function() { - let bids = { + const bids = { 'body': { 'bids': [{ 'transactionId': 'cf5faec3-fcee-4f26-80ae-fc8b6cf23b7d', @@ -619,7 +619,7 @@ describe('optidigitalAdapterTests', function () { }] } }; - let expectedResponse = [ + const expectedResponse = [ { 'placementId': 'Billboard_Top', 'requestId': '83fb53a5e67f49', @@ -650,17 +650,17 @@ describe('optidigitalAdapterTests', function () { } } ]; - let result = spec.interpretResponse(bids); + const result = spec.interpretResponse(bids); expect(result).to.eql(expectedResponse); }); it('should handle empty array bid response', function() { - let bids = { + const bids = { 'body': { 'bids': [] } }; - let result = spec.interpretResponse(bids); + const result = spec.interpretResponse(bids); expect(result.length).to.equal(0); }); }); diff --git a/test/spec/modules/orakiBidAdapter_spec.js b/test/spec/modules/orakiBidAdapter_spec.js index 1a00100cf61..74b32d4b9f3 100644 --- a/test/spec/modules/orakiBidAdapter_spec.js +++ b/test/spec/modules/orakiBidAdapter_spec.js @@ -128,7 +128,7 @@ describe('OrakiBidAdapter', function () { }); it('Returns general data valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys( 'deviceWidth', @@ -209,7 +209,7 @@ describe('OrakiBidAdapter', function () { } ]; - let serverRequest = spec.buildRequests(bids, bidderRequest); + const serverRequest = spec.buildRequests(bids, bidderRequest); const { placements } = serverRequest.data; for (let i = 0, len = placements.length; i < len; i++) { @@ -244,7 +244,7 @@ describe('OrakiBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { delete bidderRequest.uspConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('object'); expect(data.gdpr).to.have.property('consentString'); @@ -258,7 +258,7 @@ describe('OrakiBidAdapter', function () { bidderRequest.uspConsent = '1---'; delete bidderRequest.gdprConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -273,8 +273,8 @@ describe('OrakiBidAdapter', function () { applicableSections: [8] }; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -288,8 +288,8 @@ describe('OrakiBidAdapter', function () { bidderRequest.ortb2.regs.gpp = 'abc123'; bidderRequest.ortb2.regs.gpp_sid = [8]; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -319,9 +319,9 @@ describe('OrakiBidAdapter', function () { } }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(banner.body[0].requestId); @@ -353,10 +353,10 @@ describe('OrakiBidAdapter', function () { } }] }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -390,10 +390,10 @@ describe('OrakiBidAdapter', function () { } }] }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys('requestId', 'cpm', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'native', 'meta'); expect(dataItem.native).to.have.keys('clickUrl', 'impressionTrackers', 'title', 'image') expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -424,7 +424,7 @@ describe('OrakiBidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -440,7 +440,7 @@ describe('OrakiBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -457,7 +457,7 @@ describe('OrakiBidAdapter', function () { currency: 'USD', }] }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -470,7 +470,7 @@ describe('OrakiBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/orbitsoftBidAdapter_spec.js b/test/spec/modules/orbitsoftBidAdapter_spec.js index 8c3187e9324..43ac5f232dd 100644 --- a/test/spec/modules/orbitsoftBidAdapter_spec.js +++ b/test/spec/modules/orbitsoftBidAdapter_spec.js @@ -8,7 +8,7 @@ describe('Orbitsoft adapter', function () { describe('implementation', function () { describe('for requests', function () { it('should accept valid bid', function () { - let validBid = { + const validBid = { bidder: 'orbitsoft', params: { placementId: '123', @@ -21,7 +21,7 @@ describe('Orbitsoft adapter', function () { }); it('should reject invalid bid', function () { - let invalidBid = { + const invalidBid = { bidder: 'orbitsoft' }, isValid = spec.isBidRequestValid(invalidBid); @@ -31,7 +31,7 @@ describe('Orbitsoft adapter', function () { }); describe('for requests', function () { it('should accept valid bid with styles', function () { - let validBid = { + const validBid = { bidder: 'orbitsoft', params: { placementId: '123', @@ -70,9 +70,9 @@ describe('Orbitsoft adapter', function () { isValid = spec.isBidRequestValid(validBid); expect(isValid).to.equal(true); - let buildRequest = spec.buildRequests([validBid])[0]; - let requestUrl = buildRequest.url; - let requestUrlParams = buildRequest.data; + const buildRequest = spec.buildRequests([validBid])[0]; + const requestUrl = buildRequest.url; + const requestUrlParams = buildRequest.data; expect(requestUrl).to.equal(ENDPOINT_URL); expect(requestUrlParams).have.property('f1', 'Tahoma'); expect(requestUrlParams).have.property('fs1', 'medium'); @@ -95,7 +95,7 @@ describe('Orbitsoft adapter', function () { }); it('should accept valid bid with custom params', function () { - let validBid = { + const validBid = { bidder: 'orbitsoft', params: { placementId: '123', @@ -110,14 +110,14 @@ describe('Orbitsoft adapter', function () { isValid = spec.isBidRequestValid(validBid); expect(isValid).to.equal(true); - let buildRequest = spec.buildRequests([validBid])[0]; - let requestUrlCustomParams = buildRequest.data; + const buildRequest = spec.buildRequests([validBid])[0]; + const requestUrlCustomParams = buildRequest.data; expect(requestUrlCustomParams).have.property('c.cacheBuster', 'bf4d7c1'); expect(requestUrlCustomParams).have.property('c.clickUrl', 'http://testclickurl.com'); }); it('should reject invalid bid without requestUrl', function () { - let invalidBid = { + const invalidBid = { bidder: 'orbitsoft', params: { placementId: '123' @@ -129,7 +129,7 @@ describe('Orbitsoft adapter', function () { }); it('should reject invalid bid without placementId', function () { - let invalidBid = { + const invalidBid = { bidder: 'orbitsoft', params: { requestUrl: ENDPOINT_URL @@ -142,7 +142,7 @@ describe('Orbitsoft adapter', function () { }); describe('bid responses', function () { it('should return complete bid response', function () { - let serverResponse = { + const serverResponse = { body: { callback_uid: '265b29b70cc106', cpm: 0.5, @@ -153,7 +153,7 @@ describe('Orbitsoft adapter', function () { } }; - let bidRequests = [ + const bidRequests = [ { bidder: 'orbitsoft', params: { @@ -162,7 +162,7 @@ describe('Orbitsoft adapter', function () { } } ]; - let bids = spec.interpretResponse(serverResponse, {'bidRequest': bidRequests[0]}); + const bids = spec.interpretResponse(serverResponse, {'bidRequest': bidRequests[0]}); expect(bids).to.be.lengthOf(1); expect(bids[0].cpm).to.equal(serverResponse.body.cpm); expect(bids[0].width).to.equal(serverResponse.body.width); @@ -176,7 +176,7 @@ describe('Orbitsoft adapter', function () { }); it('should return empty bid response', function () { - let bidRequests = [ + const bidRequests = [ { bidder: 'orbitsoft', params: { @@ -185,7 +185,7 @@ describe('Orbitsoft adapter', function () { } } ]; - let serverResponse = { + const serverResponse = { body: { callback_uid: '265b29b70cc106', cpm: 0 @@ -197,7 +197,7 @@ describe('Orbitsoft adapter', function () { }); it('should return empty bid response on incorrect size', function () { - let bidRequests = [ + const bidRequests = [ { bidder: 'orbitsoft', params: { @@ -206,7 +206,7 @@ describe('Orbitsoft adapter', function () { } } ]; - let serverResponse = { + const serverResponse = { body: { callback_uid: '265b29b70cc106', cpm: 1.5, @@ -220,7 +220,7 @@ describe('Orbitsoft adapter', function () { }); it('should return empty bid response with error', function () { - let bidRequests = [ + const bidRequests = [ { bidder: 'orbitsoft', params: { @@ -229,14 +229,14 @@ describe('Orbitsoft adapter', function () { } } ]; - let serverResponse = {error: 'error'}, + const serverResponse = {error: 'error'}, bids = spec.interpretResponse(serverResponse, {'bidRequest': bidRequests[0]}); expect(bids).to.be.lengthOf(0); }); it('should return empty bid response on empty body', function () { - let bidRequests = [ + const bidRequests = [ { bidder: 'orbitsoft', params: { @@ -245,7 +245,7 @@ describe('Orbitsoft adapter', function () { } } ]; - let serverResponse = {}, + const serverResponse = {}, bids = spec.interpretResponse(serverResponse, {'bidRequest': bidRequests[0]}); expect(bids).to.be.lengthOf(0); diff --git a/test/spec/modules/outbrainBidAdapter_spec.js b/test/spec/modules/outbrainBidAdapter_spec.js index c38f8e44ab5..06b94d985f2 100644 --- a/test/spec/modules/outbrainBidAdapter_spec.js +++ b/test/spec/modules/outbrainBidAdapter_spec.js @@ -550,7 +550,7 @@ describe('Outbrain Adapter', function () { }); it('should pass extended ids', function () { - let bidRequest = { + const bidRequest = { bidId: 'bidId', params: {}, userIdAsEids: [ @@ -559,7 +559,7 @@ describe('Outbrain Adapter', function () { ...commonBidRequest, }; - let res = spec.buildRequests([bidRequest], commonBidderRequest); + const res = spec.buildRequests([bidRequest], commonBidderRequest); const resData = JSON.parse(res.data) expect(resData.user.ext.eids).to.deep.equal([ { source: 'liveramp.com', uids: [{ id: 'id-value', atype: 3 }] } @@ -569,13 +569,13 @@ describe('Outbrain Adapter', function () { it('should pass OB user token', function () { getDataFromLocalStorageStub.returns('12345'); - let bidRequest = { + const bidRequest = { bidId: 'bidId', params: {}, ...commonBidRequest, }; - let res = spec.buildRequests([bidRequest], commonBidderRequest); + const res = spec.buildRequests([bidRequest], commonBidderRequest); const resData = JSON.parse(res.data) expect(resData.user.ext.obusertoken).to.equal('12345') expect(getDataFromLocalStorageStub.called).to.be.true; @@ -600,7 +600,7 @@ describe('Outbrain Adapter', function () { }); it('should transform string sizes to numbers', function () { - let bidRequest = { + const bidRequest = { bidId: 'bidId', params: {}, ...commonBidRequest, @@ -634,7 +634,7 @@ describe('Outbrain Adapter', function () { ] } - let res = spec.buildRequests([bidRequest], commonBidderRequest); + const res = spec.buildRequests([bidRequest], commonBidderRequest); const resData = JSON.parse(res.data) expect(resData.imp[0].native.request).to.equal(JSON.stringify(expectedNativeAssets)); }); diff --git a/test/spec/modules/ownadxBidAdapter_spec.js b/test/spec/modules/ownadxBidAdapter_spec.js index 13d69b3a261..0bb19af3aa3 100644 --- a/test/spec/modules/ownadxBidAdapter_spec.js +++ b/test/spec/modules/ownadxBidAdapter_spec.js @@ -35,7 +35,7 @@ describe('ownadx', function () { }); describe('buildRequests', function () { - let bidderRequest = { + const bidderRequest = { refererInfo: { page: 'https://www.test.com', reachedTop: true, @@ -63,7 +63,7 @@ describe('ownadx', function () { }); describe('interpretResponse', function () { - let serverResponse = { + const serverResponse = { body: { tokenId: '3f2941af4f7e446f9a19ca6045f8cff4', bid: 'BID-XXXX-XXXX', @@ -77,7 +77,7 @@ describe('ownadx', function () { } }; - let expectedResponse = [{ + const expectedResponse = [{ token: '3f2941af4f7e446f9a19ca6045f8cff4', requestId: 'bid-id-123456', cpm: '0.7', @@ -96,7 +96,7 @@ describe('ownadx', function () { }]; it('should correctly interpret valid banner response', function () { - let result = spec.interpretResponse(serverResponse); + const result = spec.interpretResponse(serverResponse); expect(result).to.deep.equal(expectedResponse); }); }); diff --git a/test/spec/modules/oxxionAnalyticsAdapter_spec.js b/test/spec/modules/oxxionAnalyticsAdapter_spec.js index cbd6bbb810b..9759b39c056 100644 --- a/test/spec/modules/oxxionAnalyticsAdapter_spec.js +++ b/test/spec/modules/oxxionAnalyticsAdapter_spec.js @@ -1,17 +1,17 @@ -import oxxionAnalytics from 'modules/oxxionAnalyticsAdapter.js'; -import {dereferenceWithoutRenderer} from 'modules/oxxionAnalyticsAdapter.js'; +import oxxionAnalytics, {dereferenceWithoutRenderer} from 'modules/oxxionAnalyticsAdapter.js'; + import { expect } from 'chai'; import { server } from 'test/mocks/xhr.js'; import { EVENTS } from 'src/constants.js'; -let adapterManager = require('src/adapterManager').default; -let events = require('src/events'); +const adapterManager = require('src/adapterManager').default; +const events = require('src/events'); describe('Oxxion Analytics', function () { - let timestamp = new Date() - 256; - let auctionId = '5018eb39-f900-4370-b71e-3bb5b48d324f'; - let timeout = 1500; + const timestamp = new Date() - 256; + const auctionId = '5018eb39-f900-4370-b71e-3bb5b48d324f'; + const timeout = 1500; - let bidTimeout = [ + const bidTimeout = [ { 'bidId': '5fe418f2d70364', 'bidder': 'appnexusAst', @@ -203,7 +203,7 @@ describe('Oxxion Analytics', function () { 'timeout': 1000 }; - let bidWon = { + const bidWon = { 'bidderCode': 'appnexus', 'width': 970, 'height': 250, @@ -284,9 +284,9 @@ describe('Oxxion Analytics', function () { domain: 'test' } }); - let resultBidWon = JSON.parse(dereferenceWithoutRenderer(bidWon)); + const resultBidWon = JSON.parse(dereferenceWithoutRenderer(bidWon)); expect(resultBidWon).not.to.have.property('renderer'); - let resultBid = JSON.parse(dereferenceWithoutRenderer(auctionEnd)); + const resultBid = JSON.parse(dereferenceWithoutRenderer(auctionEnd)); expect(resultBid).to.have.property('bidsReceived').and.to.have.lengthOf(1); expect(resultBid.bidsReceived[0]).not.to.have.property('renderer'); }); @@ -308,7 +308,7 @@ describe('Oxxion Analytics', function () { events.emit(EVENTS.BID_TIMEOUT, bidTimeout); events.emit(EVENTS.AUCTION_END, auctionEnd); expect(server.requests.length).to.equal(1); - let message = JSON.parse(server.requests[0].requestBody); + const message = JSON.parse(server.requests[0].requestBody); expect(message).to.have.property('auctionEnd').exist; expect(message.auctionEnd).to.have.lengthOf(1); expect(message.auctionEnd[0]).to.have.property('bidsReceived').and.to.have.lengthOf(1); @@ -338,7 +338,7 @@ describe('Oxxion Analytics', function () { }); events.emit(EVENTS.BID_WON, bidWon); expect(server.requests.length).to.equal(1); - let message = JSON.parse(server.requests[0].requestBody); + const message = JSON.parse(server.requests[0].requestBody); expect(message).not.to.have.property('ad'); expect(message).to.have.property('adId') expect(message).to.have.property('cpmIncrement').and.to.equal(27.4276); diff --git a/test/spec/modules/oxxionRtdProvider_spec.js b/test/spec/modules/oxxionRtdProvider_spec.js index 2a8024f3565..f5d2606e8ee 100644 --- a/test/spec/modules/oxxionRtdProvider_spec.js +++ b/test/spec/modules/oxxionRtdProvider_spec.js @@ -13,7 +13,7 @@ const moduleConfig = { } }; -let request = { +const request = { 'auctionId': '1e8b993d-8f0a-4232-83eb-3639ddf3a44b', 'timestamp': 1647424261187, 'auctionEnd': 1647424261714, @@ -45,7 +45,7 @@ let request = { ] }; -let bids = [{ +const bids = [{ 'bidderCode': 'mediasquare', 'width': 640, 'height': 480, @@ -113,7 +113,7 @@ let bids = [{ }, ]; -let bidInterests = [ +const bidInterests = [ {'id': 0, 'rate': 50.0, 'suggestion': true}, {'id': 1, 'rate': 12.0, 'suggestion': false}, {'id': 2, 'rate': 0.0, 'suggestion': true}, @@ -137,13 +137,13 @@ describe('oxxionRtdProvider', () => { }); describe('Oxxion RTD sub module', () => { - let auctionEnd = request; + const auctionEnd = request; auctionEnd.bidsReceived = bids; it('call everything', function() { oxxionSubmodule.getBidRequestData(request, null, moduleConfig); }); it('check bid filtering', function() { - let requestsList = oxxionSubmodule.getRequestsList(request); + const requestsList = oxxionSubmodule.getRequestsList(request); expect(requestsList.length).to.equal(4); expect(requestsList[0]).to.have.property('id'); expect(request.adUnits[0].bids[0]).to.have.property('_id'); diff --git a/test/spec/modules/ozoneBidAdapter_spec.js b/test/spec/modules/ozoneBidAdapter_spec.js index 89da1a90721..94102ad628a 100644 --- a/test/spec/modules/ozoneBidAdapter_spec.js +++ b/test/spec/modules/ozoneBidAdapter_spec.js @@ -2209,7 +2209,7 @@ var multiResponse1 = { }; describe('ozone Adapter', function () { describe('isBidRequestValid', function () { - let validBidReq = { + const validBidReq = { bidder: BIDDER_CODE, params: { placementId: '1310000099', @@ -2477,7 +2477,7 @@ describe('ozone Adapter', function () { it('should not validate video without context attribute', function () { expect(spec.isBidRequestValid(xBadVideoContext2)).to.equal(false); }); - let validVideoBidReq = { + const validVideoBidReq = { bidder: BIDDER_CODE, params: { placementId: '1310000099', @@ -2494,7 +2494,7 @@ describe('ozone Adapter', function () { expect(spec.isBidRequestValid(validVideoBidReq)).to.equal(true); }); it('should validate video instream being sent even though its not properly supported yet', function () { - let instreamVid = JSON.parse(JSON.stringify(validVideoBidReq)); + const instreamVid = JSON.parse(JSON.stringify(validVideoBidReq)); instreamVid.mediaTypes.video.context = 'instream'; expect(spec.isBidRequestValid(instreamVid)).to.equal(true); }); @@ -2525,7 +2525,7 @@ describe('ozone Adapter', function () { expect(request).not.to.have.key('customData'); }); it('adds all parameters inside the ext object only - lightning', function () { - let localBidReq = JSON.parse(JSON.stringify(validBidRequests)); + const localBidReq = JSON.parse(JSON.stringify(validBidRequests)); const request = spec.buildRequests(localBidReq, validBidderRequest); expect(request.data).to.be.a('string'); var data = JSON.parse(request.data); @@ -2534,7 +2534,7 @@ describe('ozone Adapter', function () { expect(request).not.to.have.key('customData'); }); it('ignores ozoneData in & after version 2.1.1', function () { - let validBidRequestsWithOzoneData = JSON.parse(JSON.stringify(validBidRequests)); + const validBidRequestsWithOzoneData = JSON.parse(JSON.stringify(validBidRequests)); validBidRequestsWithOzoneData[0].params.ozoneData = {'networkID': '3048', 'dfpSiteID': 'd.thesun', 'sectionID': 'homepage', 'path': '/', 'sec_id': 'null', 'sec': 'sec', 'topics': 'null', 'kw': 'null', 'aid': 'null', 'search': 'null', 'article_type': 'null', 'hide_ads': '', 'article_slug': 'null'}; const request = spec.buildRequests(validBidRequestsWithOzoneData, validBidderRequest); expect(request.data).to.be.a('string'); @@ -2572,8 +2572,8 @@ describe('ozone Adapter', function () { config.setConfig({'ozone': {'singleRequest': true}}); }); it('should add gdpr consent information to the request when ozone is true', function () { - let consentString = 'BOcocyaOcocyaAfEYDENCD-AAAAjx7_______9______9uz_Ov_v_f__33e8__9v_l_7_-___u_-33d4-_1vf99yfm1-7ftr3tp_87ues2_Xur__59__3z3_NphLgA=='; - let bidderRequest = JSON.parse(JSON.stringify(validBidderRequest)); + const consentString = 'BOcocyaOcocyaAfEYDENCD-AAAAjx7_______9______9uz_Ov_v_f__33e8__9v_l_7_-___u_-33d4-_1vf99yfm1-7ftr3tp_87ues2_Xur__59__3z3_NphLgA=='; + const bidderRequest = JSON.parse(JSON.stringify(validBidderRequest)); bidderRequest.gdprConsent = { consentString: consentString, gdprApplies: true, @@ -2590,8 +2590,8 @@ describe('ozone Adapter', function () { expect(payload.user.ext.consent).to.equal(consentString); }); it('should add gdpr consent information to the request when vendorData is missing vendorConsents (Mirror)', function () { - let consentString = 'BOcocyaOcocyaAfEYDENCD-AAAAjx7_______9______9uz_Ov_v_f__33e8__9v_l_7_-___u_-33d4-_1vf99yfm1-7ftr3tp_87ues2_Xur__59__3z3_NphLgA=='; - let bidderRequest = JSON.parse(JSON.stringify(validBidderRequest)); + const consentString = 'BOcocyaOcocyaAfEYDENCD-AAAAjx7_______9______9uz_Ov_v_f__33e8__9v_l_7_-___u_-33d4-_1vf99yfm1-7ftr3tp_87ues2_Xur__59__3z3_NphLgA=='; + const bidderRequest = JSON.parse(JSON.stringify(validBidderRequest)); bidderRequest.gdprConsent = { consentString: consentString, gdprApplies: true, @@ -2606,8 +2606,8 @@ describe('ozone Adapter', function () { expect(payload.user.ext.consent).to.equal(consentString); }); it('should set regs.ext.gdpr flag to 0 when gdprApplies is false', function () { - let consentString = 'BOcocyaOcocyaAfEYDENCD-AAAAjx7_______9______9uz_Ov_v_f__33e8__9v_l_7_-___u_-33d4-_1vf99yfm1-7ftr3tp_87ues2_Xur__59__3z3_NphLgA=='; - let bidderRequest = JSON.parse(JSON.stringify(validBidderRequest)); + const consentString = 'BOcocyaOcocyaAfEYDENCD-AAAAjx7_______9______9uz_Ov_v_f__33e8__9v_l_7_-___u_-33d4-_1vf99yfm1-7ftr3tp_87ues2_Xur__59__3z3_NphLgA=='; + const bidderRequest = JSON.parse(JSON.stringify(validBidderRequest)); bidderRequest.gdprConsent = { consentString: consentString, gdprApplies: false, @@ -2623,9 +2623,9 @@ describe('ozone Adapter', function () { expect(payload.regs.ext.gdpr).to.equal(0); }); it('should set gpp and gpp_sid when available', function() { - let gppString = 'gppConsentString'; - let gppSections = [7, 8, 9]; - let bidderRequest = JSON.parse(JSON.stringify(validBidderRequest)); + const gppString = 'gppConsentString'; + const gppSections = [7, 8, 9]; + const bidderRequest = JSON.parse(JSON.stringify(validBidderRequest)); bidderRequest.ortb2 = {regs: {gpp: gppString, gpp_sid: gppSections}}; const request = spec.buildRequests(validBidRequestsNoSizes, bidderRequest); const payload = JSON.parse(request.data); @@ -2638,8 +2638,8 @@ describe('ozone Adapter', function () { expect(payload).to.not.contain.keys(['gpp', 'gpp_sid', 'ext', 'regs']); }); it('should not have imp[N].ext.ozone.userId', function () { - let consentString = 'BOcocyaOcocyaAfEYDENCD-AAAAjx7_______9______9uz_Ov_v_f__33e8__9v_l_7_-___u_-33d4-_1vf99yfm1-7ftr3tp_87ues2_Xur__59__3z3_NphLgA=='; - let bidderRequest = JSON.parse(JSON.stringify(validBidderRequest)); + const consentString = 'BOcocyaOcocyaAfEYDENCD-AAAAjx7_______9______9uz_Ov_v_f__33e8__9v_l_7_-___u_-33d4-_1vf99yfm1-7ftr3tp_87ues2_Xur__59__3z3_NphLgA=='; + const bidderRequest = JSON.parse(JSON.stringify(validBidderRequest)); bidderRequest.gdprConsent = { consentString: consentString, gdprApplies: false, @@ -2650,7 +2650,7 @@ describe('ozone Adapter', function () { purposeConsents: {1: true, 2: true, 3: true, 4: true, 5: true} } }; - let bidRequests = JSON.parse(JSON.stringify(validBidRequests)); + const bidRequests = JSON.parse(JSON.stringify(validBidRequests)); bidRequests[0]['userId'] = { 'digitrustid': {data: {id: 'DTID', keyv: 4, privacy: {optout: false}, producer: 'ABC', version: 2}}, 'id5id': { uid: '1111', ext: { linkType: 2, abTestingControlGroup: false } }, @@ -2663,11 +2663,11 @@ describe('ozone Adapter', function () { bidRequests[0]['userIdAsEids'] = validBidRequestsWithUserIdData[0]['userIdAsEids']; const request = spec.buildRequests(bidRequests, bidderRequest); const payload = JSON.parse(request.data); - let firstBid = payload.imp[0].ext.ozone; + const firstBid = payload.imp[0].ext.ozone; expect(firstBid).to.not.have.property('userId'); }); it('should pick up the value of pubcid when built using the pubCommonId module (not userId)', function () { - let bidRequests = validBidRequests; + const bidRequests = validBidRequests; const request = spec.buildRequests(bidRequests, validBidderRequest); const payload = JSON.parse(request.data); expect(payload.ext.ozone.pubcid).to.equal(bidRequests[0]['crumbs']['pubcid']); @@ -2694,7 +2694,7 @@ describe('ozone Adapter', function () { expect(payload.user.ext.eids[6]['uids'][0]['id']['eid']).to.equal('01.5678.parrableid'); }); it('replaces the auction url for a config override', function () { - let fakeOrigin = 'http://sometestendpoint'; + const fakeOrigin = 'http://sometestendpoint'; config.setConfig({'ozone': {'endpointOverride': {'origin': fakeOrigin}}}); const request = spec.buildRequests(validBidRequests, validBidderRequest); expect(request.url).to.equal(fakeOrigin + '/openrtb2/auction'); @@ -2704,7 +2704,7 @@ describe('ozone Adapter', function () { config.setConfig({'ozone': {'kvpPrefix': null, 'endpointOverride': null}}); }); it('replaces the FULL auction url for a config override', function () { - let fakeurl = 'http://sometestendpoint/myfullurl'; + const fakeurl = 'http://sometestendpoint/myfullurl'; config.setConfig({'ozone': {'endpointOverride': {'auctionUrl': fakeurl}}}); const request = spec.buildRequests(validBidRequests, validBidderRequest); expect(request.url).to.equal(fakeurl); @@ -2714,7 +2714,7 @@ describe('ozone Adapter', function () { config.setConfig({'ozone': {'kvpPrefix': null, 'endpointOverride': null}}); }); it('replaces the renderer url for a config override', function () { - let fakeUrl = 'http://renderer.com'; + const fakeUrl = 'http://renderer.com'; config.setConfig({'ozone': {'endpointOverride': {'rendererUrl': fakeUrl}}}); const result = spec.interpretResponse(getCleanValidVideoResponse(), validBidderRequest1OutstreamVideo2020); const bid = result[0]; @@ -2759,7 +2759,7 @@ describe('ozone Adapter', function () { }); it('should pass gpid to auction if it is present (gptPreAuction adapter sets this)', function () { var specMock = utils.deepClone(spec); - let br = JSON.parse(JSON.stringify(validBidRequests)); + const br = JSON.parse(JSON.stringify(validBidRequests)); utils.deepSetValue(br[0], 'ortb2Imp.ext.gpid', '/22037345/projectozone'); const request = specMock.buildRequests(br, validBidderRequest); const data = JSON.parse(request.data); @@ -2768,9 +2768,9 @@ describe('ozone Adapter', function () { it('should batch into 10s if config is set to true', function () { config.setConfig({ozone: {'batchRequests': true}}); var specMock = utils.deepClone(spec); - let arrReq = []; + const arrReq = []; for (let i = 0; i < 25; i++) { - let b = validBidRequests[0]; + const b = validBidRequests[0]; b.adUnitCode += i; arrReq.push(b); } @@ -2781,9 +2781,9 @@ describe('ozone Adapter', function () { it('should batch into 7 if config is set to 7', function () { config.setConfig({ozone: {'batchRequests': 7}}); var specMock = utils.deepClone(spec); - let arrReq = []; + const arrReq = []; for (let i = 0; i < 25; i++) { - let b = validBidRequests[0]; + const b = validBidRequests[0]; b.adUnitCode += i; arrReq.push(b); } @@ -2794,9 +2794,9 @@ describe('ozone Adapter', function () { it('should not batch if config is set to false and singleRequest is true', function () { config.setConfig({ozone: {'batchRequests': false, 'singleRequest': true}}); var specMock = utils.deepClone(spec); - let arrReq = []; + const arrReq = []; for (let i = 0; i < 15; i++) { - let b = validBidRequests[0]; + const b = validBidRequests[0]; b.adUnitCode += i; arrReq.push(b); } @@ -2807,9 +2807,9 @@ describe('ozone Adapter', function () { it('should not batch if config is set to invalid value -10 and singleRequest is true', function () { config.setConfig({ozone: {'batchRequests': -10, 'singleRequest': true}}); var specMock = utils.deepClone(spec); - let arrReq = []; + const arrReq = []; for (let i = 0; i < 15; i++) { - let b = validBidRequests[0]; + const b = validBidRequests[0]; b.adUnitCode += i; arrReq.push(b); } @@ -2822,9 +2822,9 @@ describe('ozone Adapter', function () { specMock.getGetParametersAsObject = function() { return {'batchRequests': '5'}; }; - let arrReq = []; + const arrReq = []; for (let i = 0; i < 25; i++) { - let b = validBidRequests[0]; + const b = validBidRequests[0]; b.adUnitCode += i; arrReq.push(b); } @@ -2905,21 +2905,21 @@ describe('ozone Adapter', function () { config.resetConfig(); }); it('should handle a valid ozFloor string value in the adunit correctly', function () { - let cloneBidRequests = JSON.parse(JSON.stringify(validBidRequests)); + const cloneBidRequests = JSON.parse(JSON.stringify(validBidRequests)); cloneBidRequests[0].params.ozFloor = '0.1234'; const request = spec.buildRequests(cloneBidRequests, validBidderRequest); const payload = JSON.parse(request.data); expect(utils.deepAccess(payload, 'imp.0.ext.ozone.ozFloor')).to.equal(0.1234); }); it('should handle a valid ozFloor float value in the adunit correctly', function () { - let cloneBidRequests = JSON.parse(JSON.stringify(validBidRequests)); + const cloneBidRequests = JSON.parse(JSON.stringify(validBidRequests)); cloneBidRequests[0].params.ozFloor = 0.1234; const request = spec.buildRequests(cloneBidRequests, validBidderRequest); const payload = JSON.parse(request.data); expect(utils.deepAccess(payload, 'imp.0.ext.ozone.ozFloor')).to.equal(0.1234); }); it('should ignore an invalid ozFloor string value in the adunit correctly', function () { - let cloneBidRequests = JSON.parse(JSON.stringify(validBidRequests)); + const cloneBidRequests = JSON.parse(JSON.stringify(validBidRequests)); cloneBidRequests[0].params.ozFloor = 'this is no good!'; const request = spec.buildRequests(cloneBidRequests, validBidderRequest); const payload = JSON.parse(request.data); @@ -2927,10 +2927,10 @@ describe('ozone Adapter', function () { }); it('should should contain a unique page view id in the auction request which persists across calls', function () { let request = spec.buildRequests(validBidRequests, validBidderRequest); - let payload = JSON.parse(request.data); + const payload = JSON.parse(request.data); expect(utils.deepAccess(payload, 'ext.ozone.pv')).to.be.a('string'); request = spec.buildRequests(validBidRequests1OutstreamVideo2020, validBidderRequest); - let payload2 = JSON.parse(request.data); + const payload2 = JSON.parse(request.data); expect(utils.deepAccess(payload2, 'ext.ozone.pv')).to.be.a('string'); expect(utils.deepAccess(payload2, 'ext.ozone.pv')).to.equal(utils.deepAccess(payload, 'ext.ozone.pv')); }); @@ -2952,7 +2952,7 @@ describe('ozone Adapter', function () { expect(payload.ext.ozone.oz_kvp_rw).to.equal(0); }); it('should handle ortb2 site data', function () { - let bidderRequest = JSON.parse(JSON.stringify(validBidderRequest)); + const bidderRequest = JSON.parse(JSON.stringify(validBidderRequest)); bidderRequest.ortb2 = { 'site': { 'name': 'example_ortb2_name', @@ -2972,7 +2972,7 @@ describe('ozone Adapter', function () { expect(payload.user.ext).to.not.have.property('gender'); }); it('should add ortb2 site data when there is no customData already created', function () { - let bidderRequest = JSON.parse(JSON.stringify(validBidderRequest)); + const bidderRequest = JSON.parse(JSON.stringify(validBidderRequest)); bidderRequest.ortb2 = { 'site': { 'name': 'example_ortb2_name', @@ -2992,7 +2992,7 @@ describe('ozone Adapter', function () { expect(payload.imp[0].ext.ozone.customData[0].targeting).to.not.have.property('gender') }); it('should add ortb2 user data to the user object', function () { - let bidderRequest = JSON.parse(JSON.stringify(validBidderRequest)); + const bidderRequest = JSON.parse(JSON.stringify(validBidderRequest)); bidderRequest.ortb2 = { 'user': { 'gender': 'I identify as a box of rocks' @@ -3003,7 +3003,7 @@ describe('ozone Adapter', function () { expect(payload.user.gender).to.equal('I identify as a box of rocks'); }); it('should not override the user.ext.consent string even if this is set in config ortb2', function () { - let bidderRequest = JSON.parse(JSON.stringify(bidderRequestWithFullGdpr)); + const bidderRequest = JSON.parse(JSON.stringify(bidderRequestWithFullGdpr)); bidderRequest.ortb2 = { 'user': { 'ext': { @@ -3018,7 +3018,7 @@ describe('ozone Adapter', function () { expect(payload.user.ext.consent).to.equal('BOh7mtYOh7mtYAcABBENCU-AAAAncgPIXJiiAoao0PxBFkgCAC8ACIAAQAQQAAIAAAIAAAhBGAAAQAQAEQgAAAAAAABAAAAAAAAAAAAAAACAAAAAAAACgAAAAABAAAAQAAAAAAA'); }); it('should have openrtb video params', function() { - let allowed = ['mimes', 'minduration', 'maxduration', 'protocols', 'w', 'h', 'startdelay', 'placement', 'linearity', 'skip', 'skipmin', 'skipafter', 'sequence', 'battr', 'maxextended', 'minbitrate', 'maxbitrate', 'boxingallowed', 'playbackmethod', 'playbackend', 'delivery', 'pos', 'companionad', 'api', 'companiontype', 'ext']; + const allowed = ['mimes', 'minduration', 'maxduration', 'protocols', 'w', 'h', 'startdelay', 'placement', 'linearity', 'skip', 'skipmin', 'skipafter', 'sequence', 'battr', 'maxextended', 'minbitrate', 'maxbitrate', 'boxingallowed', 'playbackmethod', 'playbackend', 'delivery', 'pos', 'companionad', 'api', 'companiontype', 'ext']; const request = spec.buildRequests(validBidRequests1OutstreamVideo2020, validBidderRequest); const payload = JSON.parse(request.data); const vid = (payload.imp[0].video); @@ -3047,7 +3047,7 @@ describe('ozone Adapter', function () { } } }); - let localBidRequest = JSON.parse(JSON.stringify(validBidRequestsWithBannerMediaType)); + const localBidRequest = JSON.parse(JSON.stringify(validBidRequestsWithBannerMediaType)); localBidRequest[0].getFloor = function(x) { return {'currency': 'USD', 'floor': 0.8} }; const request = spec.buildRequests(localBidRequest, validBidderRequest); const payload = JSON.parse(request.data); @@ -3055,7 +3055,7 @@ describe('ozone Adapter', function () { expect(utils.deepAccess(payload, 'imp.0.floor.banner.floor')).to.equal(0.8); }); it(' (getFloorObjectForAuction) should handle advanced/custom floor config function correctly (note you cant fully test floor functionality because it relies on the floor module - only our code that interacts with it; we must extract the first w/h pair)', function () { - let testBidObject = { + const testBidObject = { mediaTypes: { banner: { sizes: [[300, 250], [300, 600]] @@ -3073,14 +3073,14 @@ describe('ozone Adapter', function () { return obj.size; } }; - let floorObject = spec.getFloorObjectForAuction(testBidObject); + const floorObject = spec.getFloorObjectForAuction(testBidObject); expect(floorObject.banner).to.deep.equal([300, 250]); expect(floorObject.video).to.deep.equal([640, 360]); expect(floorObject.native).to.deep.equal([300, 250]); }); it('handles schain object in each bidrequest (will be the same in each br)', function () { - let br = JSON.parse(JSON.stringify(validBidRequests)); - let schainConfigObject = { + const br = JSON.parse(JSON.stringify(validBidRequests)); + const schainConfigObject = { 'ver': '1.0', 'complete': 1, 'nodes': [ @@ -3101,20 +3101,20 @@ describe('ozone Adapter', function () { expect(data.source.ext.schain).to.deep.equal(schainConfigObject); }); it('should find ortb2 cookieDeprecation values', function () { - let bidderRequest = JSON.parse(JSON.stringify(validBidderRequestWithCookieDeprecation)); + const bidderRequest = JSON.parse(JSON.stringify(validBidderRequestWithCookieDeprecation)); const request = spec.buildRequests(validBidRequests, bidderRequest); const payload = JSON.parse(request.data); expect(payload.ext.ozone.cookieDeprecationLabel).to.equal('fake_control_2'); }); it('should set ortb2 cookieDeprecation to "none" if there is none', function () { - let bidderRequest = JSON.parse(JSON.stringify(validBidderRequest)); + const bidderRequest = JSON.parse(JSON.stringify(validBidderRequest)); const request = spec.buildRequests(validBidRequests, bidderRequest); const payload = JSON.parse(request.data); expect(payload.ext.ozone.cookieDeprecationLabel).to.equal('none'); }); it('should handle fledge requests', function () { - let bidderRequest = JSON.parse(JSON.stringify(validBidderRequest)); - let bidRequests = JSON.parse(JSON.stringify(validBidRequests)); + const bidderRequest = JSON.parse(JSON.stringify(validBidderRequest)); + const bidRequests = JSON.parse(JSON.stringify(validBidRequests)); deepSetValue(bidRequests[0], 'ortb2Imp.ext.ae', 1); bidderRequest.fledgeEnabled = true; const request = spec.buildRequests(bidRequests, bidderRequest); @@ -3195,14 +3195,14 @@ describe('ozone Adapter', function () { expect(bid.height).to.equal(validResponse.body.seatbid[0].bid[0].height); }); it('should build bid array with gdpr', function () { - let validBR = JSON.parse(JSON.stringify(bidderRequestWithFullGdpr)); + const validBR = JSON.parse(JSON.stringify(bidderRequestWithFullGdpr)); validBR.gdprConsent = {'gdprApplies': 1, 'consentString': 'This is the gdpr consent string'}; const request = spec.buildRequests(validBidRequests, validBR); const result = spec.interpretResponse(validResponse, request); expect(result.length).to.equal(1); }); it('should build bid array with usp/CCPA', function () { - let validBR = JSON.parse(JSON.stringify(bidderRequestWithFullGdpr)); + const validBR = JSON.parse(JSON.stringify(bidderRequestWithFullGdpr)); validBR.uspConsent = '1YNY'; const request = spec.buildRequests(validBidRequests, validBR); const payload = JSON.parse(request.data); @@ -3232,9 +3232,9 @@ describe('ozone Adapter', function () { expect(bid.renderer).to.be.an.instanceOf(Renderer); }); it('should have NO video renderer for instream video', function () { - let instreamRequestsObj = JSON.parse(JSON.stringify(validBidRequests1OutstreamVideo2020)); + const instreamRequestsObj = JSON.parse(JSON.stringify(validBidRequests1OutstreamVideo2020)); instreamRequestsObj[0].mediaTypes.video.context = 'instream'; - let instreamBidderReq = JSON.parse(JSON.stringify(validBidderRequest1OutstreamVideo2020)); + const instreamBidderReq = JSON.parse(JSON.stringify(validBidderRequest1OutstreamVideo2020)); instreamBidderReq.bidderRequest.bids[0].mediaTypes.video.context = 'instream'; const result = spec.interpretResponse(getCleanValidVideoResponse(), instreamBidderReq); const bid = result[0]; @@ -3269,7 +3269,7 @@ describe('ozone Adapter', function () { }); it('should handle ext.bidder.ozone.floor correctly, setting flr & rid as necessary', function () { const request = spec.buildRequests(validBidRequests, validBidderRequest); - let vres = JSON.parse(JSON.stringify(validResponse)); + const vres = JSON.parse(JSON.stringify(validResponse)); vres.body.seatbid[0].bid[0].ext.bidder.ozone = {floor: 1, ruleId: 'ZjbsYE1q'}; const result = spec.interpretResponse(vres, request); expect(utils.deepAccess(result[0].adserverTargeting, 'oz_appnexus_flr')).to.equal(1); @@ -3277,7 +3277,7 @@ describe('ozone Adapter', function () { }); it('should handle ext.bidder.ozone.floor correctly, inserting 0 as necessary', function () { const request = spec.buildRequests(validBidRequests, validBidderRequest); - let vres = JSON.parse(JSON.stringify(validResponse)); + const vres = JSON.parse(JSON.stringify(validResponse)); vres.body.seatbid[0].bid[0].ext.bidder.ozone = {floor: 0, ruleId: 'ZjbXXE1q'}; const result = spec.interpretResponse(vres, request); expect(utils.deepAccess(result[0].adserverTargeting, 'oz_appnexus_flr')).to.equal(0); @@ -3285,7 +3285,7 @@ describe('ozone Adapter', function () { }); it('should handle ext.bidder.ozone.floor correctly, inserting nothing as necessary', function () { const request = spec.buildRequests(validBidRequests, validBidderRequest); - let vres = JSON.parse(JSON.stringify(validResponse)); + const vres = JSON.parse(JSON.stringify(validResponse)); vres.body.seatbid[0].bid[0].ext.bidder.ozone = {}; const result = spec.interpretResponse(vres, request); expect(utils.deepAccess(result[0].adserverTargeting, 'oz_appnexus_flr', null)).to.equal(null); @@ -3293,7 +3293,7 @@ describe('ozone Adapter', function () { }); it('should handle ext.bidder.ozone.floor correctly, when bidder.ozone is not there', function () { const request = spec.buildRequests(validBidRequests, validBidderRequest); - let vres = JSON.parse(JSON.stringify(validResponse)); + const vres = JSON.parse(JSON.stringify(validResponse)); const result = spec.interpretResponse(vres, request); expect(utils.deepAccess(result[0].adserverTargeting, 'oz_appnexus_flr', null)).to.equal(null); expect(utils.deepAccess(result[0].adserverTargeting, 'oz_appnexus_rid', null)).to.equal(null); @@ -3321,7 +3321,7 @@ describe('ozone Adapter', function () { }); it('should add flr into ads request if floor exists in the auction response', function () { const request = spec.buildRequests(validBidRequestsMulti, validBidderRequest); - let validres = JSON.parse(JSON.stringify(validResponse2Bids)); + const validres = JSON.parse(JSON.stringify(validResponse2Bids)); validres.body.seatbid[0].bid[0].ext.bidder.ozone = {'floor': 1}; const result = spec.interpretResponse(validres, request); expect(utils.deepAccess(result[0].adserverTargeting, 'oz_appnexus_flr')).to.equal(1); @@ -3329,7 +3329,7 @@ describe('ozone Adapter', function () { }); it('should add rid into ads request if ruleId exists in the auction response', function () { const request = spec.buildRequests(validBidRequestsMulti, validBidderRequest); - let validres = JSON.parse(JSON.stringify(validResponse2Bids)); + const validres = JSON.parse(JSON.stringify(validResponse2Bids)); validres.body.seatbid[0].bid[0].ext.bidder.ozone = {'ruleId': 123}; const result = spec.interpretResponse(validres, request); expect(utils.deepAccess(result[0].adserverTargeting, 'oz_appnexus_rid')).to.equal(123); @@ -3337,13 +3337,13 @@ describe('ozone Adapter', function () { }); it('should add oz_auc_id (response id value)', function () { const request = spec.buildRequests(validBidRequestsMulti, validBidderRequest); - let validres = JSON.parse(JSON.stringify(validBidResponse1adWith2Bidders)); + const validres = JSON.parse(JSON.stringify(validBidResponse1adWith2Bidders)); const result = spec.interpretResponse(validres, request); expect(utils.deepAccess(result[0].adserverTargeting, 'oz_auc_id')).to.equal(validBidResponse1adWith2Bidders.body.id); }); it('should add unique adId values to each bid', function() { const request = spec.buildRequests(validBidRequests, validBidderRequest); - let validres = JSON.parse(JSON.stringify(validResponse2BidsSameAdunit)); + const validres = JSON.parse(JSON.stringify(validResponse2BidsSameAdunit)); const result = spec.interpretResponse(validres, request); expect(result.length).to.equal(1); expect(result[0]['price']).to.equal(0.9); @@ -3374,9 +3374,9 @@ describe('ozone Adapter', function () { expect(result[0].mediaType).to.equal('banner'); }); it('should add mediaType: video for a video ad', function () { - let instreamRequestsObj = JSON.parse(JSON.stringify(validBidRequests1OutstreamVideo2020)); + const instreamRequestsObj = JSON.parse(JSON.stringify(validBidRequests1OutstreamVideo2020)); instreamRequestsObj[0].mediaTypes.video.context = 'instream'; - let instreamBidderReq = JSON.parse(JSON.stringify(validBidderRequest1OutstreamVideo2020)); + const instreamBidderReq = JSON.parse(JSON.stringify(validBidderRequest1OutstreamVideo2020)); instreamBidderReq.bidderRequest.bids[0].mediaTypes.video.context = 'instream'; const result = spec.interpretResponse(getCleanValidVideoResponse(), instreamBidderReq); const bid = result[0]; @@ -3384,7 +3384,7 @@ describe('ozone Adapter', function () { }); it('should handle fledge response', function () { const req = spec.buildRequests(validBidRequests, validBidderRequest); - let objResp = JSON.parse(JSON.stringify(validResponse)); + const objResp = JSON.parse(JSON.stringify(validResponse)); objResp.body.ext = {igi: [{ 'impid': '1', 'igb': [{ @@ -3398,7 +3398,7 @@ describe('ozone Adapter', function () { }); it('should add labels in the adserver request if they are present in the auction response', function () { const request = spec.buildRequests(validBidRequestsMulti, validBidderRequest); - let validres = JSON.parse(JSON.stringify(validResponse2Bids)); + const validres = JSON.parse(JSON.stringify(validResponse2Bids)); validres.body.seatbid.push(JSON.parse(JSON.stringify(validres.body.seatbid[0]))); validres.body.seatbid[1].seat = 'marktest'; validres.body.seatbid[1].bid[0].ext.prebid.labels = ['b1', 'b2', 'b3']; @@ -3420,7 +3420,7 @@ describe('ozone Adapter', function () { it('should not add labels in the adserver request if they are present in the auction response when config contains ozone.enhancedAdserverTargeting', function () { config.setConfig({'ozone': {'enhancedAdserverTargeting': false}}); const request = spec.buildRequests(validBidRequestsMulti, validBidderRequest); - let validres = JSON.parse(JSON.stringify(validResponse2Bids)); + const validres = JSON.parse(JSON.stringify(validResponse2Bids)); validres.body.seatbid.push(JSON.parse(JSON.stringify(validres.body.seatbid[0]))); validres.body.seatbid[1].seat = 'marktest'; validres.body.seatbid[1].bid[0].ext.prebid.labels = ['b1', 'b2', 'b3']; @@ -3478,40 +3478,40 @@ describe('ozone Adapter', function () { }); describe('video object utils', function () { it('should find width & height from video object', function () { - let obj = {'playerSize': [640, 480], 'mimes': ['video/mp4'], 'context': 'outstream'}; + const obj = {'playerSize': [640, 480], 'mimes': ['video/mp4'], 'context': 'outstream'}; const result = getWidthAndHeightFromVideoObject(obj); expect(result.w).to.equal(640); expect(result.h).to.equal(480); }); it('should find null from bad video object', function () { - let obj = {'playerSize': [], 'mimes': ['video/mp4'], 'context': 'outstream'}; + const obj = {'playerSize': [], 'mimes': ['video/mp4'], 'context': 'outstream'}; const result = getWidthAndHeightFromVideoObject(obj); expect(result).to.be.null; }); it('should find null from bad video object2', function () { - let obj = {'mimes': ['video/mp4'], 'context': 'outstream'}; + const obj = {'mimes': ['video/mp4'], 'context': 'outstream'}; const result = getWidthAndHeightFromVideoObject(obj); expect(result).to.be.null; }); it('should find null from bad video object3', function () { - let obj = {'playerSize': 'should be an array', 'mimes': ['video/mp4'], 'context': 'outstream'}; + const obj = {'playerSize': 'should be an array', 'mimes': ['video/mp4'], 'context': 'outstream'}; const result = getWidthAndHeightFromVideoObject(obj); expect(result).to.be.null; }); it('should find that player size is nested', function () { - let obj = {'playerSize': [[640, 480]], 'mimes': ['video/mp4'], 'context': 'outstream'}; + const obj = {'playerSize': [[640, 480]], 'mimes': ['video/mp4'], 'context': 'outstream'}; const result = getWidthAndHeightFromVideoObject(obj); expect(result.w).to.equal(640); expect(result.h).to.equal(480); }); it('should fail if player size is 2 x nested', function () { - let obj = {'playerSize': [[[640, 480]]], 'mimes': ['video/mp4'], 'context': 'outstream'}; + const obj = {'playerSize': [[[640, 480]]], 'mimes': ['video/mp4'], 'context': 'outstream'}; const result = getWidthAndHeightFromVideoObject(obj); expect(result).to.be.null; }); it('should add oz_appnexus_dealid into ads request if dealid exists in the auction response', function () { const request = spec.buildRequests(validBidRequestsMulti, validBidderRequest); - let validres = JSON.parse(JSON.stringify(validResponse2Bids)); + const validres = JSON.parse(JSON.stringify(validResponse2Bids)); validres.body.seatbid[0].bid[0].dealid = '1234'; const result = spec.interpretResponse(validres, request); expect(utils.deepAccess(result[0].adserverTargeting, 'oz_appnexus_dealid')).to.equal('1234'); @@ -3520,7 +3520,7 @@ describe('ozone Adapter', function () { }); describe('default size', function () { it('should should return default sizes if no obj is sent', function () { - let obj = ''; + const obj = ''; const result = defaultSize(obj); expect(result.defaultHeight).to.equal(250); expect(result.defaultWidth).to.equal(300); @@ -3532,20 +3532,20 @@ describe('ozone Adapter', function () { }) it('should return true if oz_request is false', function() { config.setConfig({'ozone': {'oz_request': false}}); - let result = spec.blockTheRequest(); + const result = spec.blockTheRequest(); expect(result).to.be.true; }); it('should return false if oz_request is true', function() { config.setConfig({'ozone': {'oz_request': true}}); - let result = spec.blockTheRequest(); + const result = spec.blockTheRequest(); expect(result).to.be.false; }); }); describe('getPageId', function() { it('should return the same Page ID for multiple calls', function () { - let result = spec.getPageId(); + const result = spec.getPageId(); expect(result).to.be.a('string'); - let result2 = spec.getPageId(); + const result2 = spec.getPageId(); expect(result2).to.equal(result); }); }); @@ -3559,19 +3559,19 @@ describe('ozone Adapter', function () { }); describe('getVideoContextForBidId', function() { it('should locate the video context inside a bid', function () { - let result = spec.getVideoContextForBidId('2899ec066a91ff8', validBidRequestsWithNonBannerMediaTypesAndValidOutstreamVideo); + const result = spec.getVideoContextForBidId('2899ec066a91ff8', validBidRequestsWithNonBannerMediaTypesAndValidOutstreamVideo); expect(result).to.equal('outstream'); }); }); describe('unpackVideoConfigIntoIABformat', function() { it('should correctly unpack a usual video config', function () { - let mediaTypes = { + const mediaTypes = { playerSize: [640, 480], mimes: ['video/mp4'], context: 'outstream', testKey: 'parent value' }; - let bid_params_video = { + const bid_params_video = { skippable: true, playback_method: ['auto_play_sound_off'], playbackmethod: 2, @@ -3581,7 +3581,7 @@ describe('ozone Adapter', function () { skipafter: 5, testKey: 'child value' }; - let result = spec.unpackVideoConfigIntoIABformat(mediaTypes, bid_params_video); + const result = spec.unpackVideoConfigIntoIABformat(mediaTypes, bid_params_video); expect(result.mimes).to.be.an('array').that.includes('video/mp4'); expect(result.ext.context).to.equal('outstream'); expect(result.ext.skippable).to.be.true; @@ -3590,12 +3590,12 @@ describe('ozone Adapter', function () { }); describe('addVideoDefaults', function() { it('should not add video defaults if there is no videoParams config', function () { - let mediaTypes = { + const mediaTypes = { playerSize: [640, 480], mimes: ['video/mp4'], context: 'outstream', }; - let bid_params_video = { + const bid_params_video = { skippable: true, playback_method: ['auto_play_sound_off'], playbackmethod: 2, @@ -3614,13 +3614,13 @@ describe('ozone Adapter', function () { it('should correctly add video defaults if page config videoParams is defined, also check skip in the parent', function () { var specMock = utils.deepClone(spec); config.setConfig({'ozone': {videoParams: {outstream: 3, instream: 1}}}); - let mediaTypes = { + const mediaTypes = { playerSize: [640, 480], mimes: ['video/mp4'], context: 'outstream', skippable: true }; - let bid_params_video = { + const bid_params_video = { playback_method: ['auto_play_sound_off'], playbackmethod: 2, minduration: 5, @@ -3629,7 +3629,7 @@ describe('ozone Adapter', function () { skipafter: 5, testKey: 'child value' }; - let result = specMock.addVideoDefaults({}, mediaTypes, bid_params_video); + const result = specMock.addVideoDefaults({}, mediaTypes, bid_params_video); expect(result.placement).to.equal(3); expect(result.skip).to.equal(1); config.resetConfig(); @@ -3637,10 +3637,10 @@ describe('ozone Adapter', function () { }); describe('removeSingleBidderMultipleBids', function() { it('should remove the multi bid by ozappnexus for adslot 2d30e86db743a8', function() { - let validres = JSON.parse(JSON.stringify(multiResponse1)); + const validres = JSON.parse(JSON.stringify(multiResponse1)); expect(validres.body.seatbid[0].bid.length).to.equal(3); expect(validres.body.seatbid[0].seat).to.equal('ozappnexus'); - let response = spec.removeSingleBidderMultipleBids(validres.body.seatbid); + const response = spec.removeSingleBidderMultipleBids(validres.body.seatbid); expect(response.length).to.equal(2); expect(response[0].bid.length).to.equal(2); expect(response[0].seat).to.equal('ozappnexus'); @@ -3649,20 +3649,20 @@ describe('ozone Adapter', function () { }); describe('setBidMediaTypeIfNotExist', function() { it('should leave the bid object alone if it already contains mediaType', function() { - let thisBid = {mediaType: 'marktest'}; + const thisBid = {mediaType: 'marktest'}; spec.setBidMediaTypeIfNotExist(thisBid, 'replacement'); expect(thisBid.mediaType).to.equal('marktest'); }); it('should change the bid object if it doesnt already contain mediaType', function() { - let thisBid = {someKey: 'someValue'}; + const thisBid = {someKey: 'someValue'}; spec.setBidMediaTypeIfNotExist(thisBid, 'replacement'); expect(thisBid.mediaType).to.equal('replacement'); }); }); describe('getLoggableBidObject', function() { it('should return an object without a "renderer" element', function () { - let obj = {'renderer': {}, 'somevalue': '', 'h': 100}; - let ret = spec.getLoggableBidObject(obj); + const obj = {'renderer': {}, 'somevalue': '', 'h': 100}; + const ret = spec.getLoggableBidObject(obj); expect(ret).to.not.have.own.property('renderer'); expect(ret.h).to.equal(100); }); diff --git a/test/spec/modules/paapi_spec.js b/test/spec/modules/paapi_spec.js index c3aad7613c9..6de300684af 100644 --- a/test/spec/modules/paapi_spec.js +++ b/test/spec/modules/paapi_spec.js @@ -73,7 +73,7 @@ describe('paapi module', () => { }) function getWrappedAjax() { let wrappedAjax; - let next = sinon.stub().callsFake((spec, bids, br, ajax) => { + const next = sinon.stub().callsFake((spec, bids, br, ajax) => { wrappedAjax = ajax; }); adAuctionHeadersHook(next, {}, [], bidderRequest, ajax); diff --git a/test/spec/modules/padsquadBidAdapter_spec.js b/test/spec/modules/padsquadBidAdapter_spec.js index 7d0858ed25e..1229ce778ff 100644 --- a/test/spec/modules/padsquadBidAdapter_spec.js +++ b/test/spec/modules/padsquadBidAdapter_spec.js @@ -65,7 +65,7 @@ const RESPONSE = { 'bidder': { 'appnexus': { 'brand_id': 334553, - 'auction_id': 514667951122925701, + 'auction_id': '514667951122925701', 'bidder_id': 2, 'bid_ad_type': 0 } @@ -94,7 +94,7 @@ const RESPONSE = { 'bidder': { 'appnexus': { 'brand_id': 386046, - 'auction_id': 517067951122925501, + 'auction_id': '517067951122925501', 'bidder_id': 2, 'bid_ad_type': 0 } @@ -136,7 +136,7 @@ const RESPONSE = { describe('Padsquad bid adapter', function () { describe('isBidRequestValid', function () { it('should accept request if only unitId is passed', function () { - let bid = { + const bid = { bidder: 'padsquad', params: { unitId: 'unitId', @@ -145,7 +145,7 @@ describe('Padsquad bid adapter', function () { expect(spec.isBidRequestValid(bid)).to.equal(true); }); it('should accept request if only networkId is passed', function () { - let bid = { + const bid = { bidder: 'padsquad', params: { networkId: 'networkId', @@ -154,7 +154,7 @@ describe('Padsquad bid adapter', function () { expect(spec.isBidRequestValid(bid)).to.equal(true); }); it('should accept request if only publisherId is passed', function () { - let bid = { + const bid = { bidder: 'padsquad', params: { publisherId: 'publisherId', @@ -164,7 +164,7 @@ describe('Padsquad bid adapter', function () { }); it('reject requests without params', function () { - let bid = { + const bid = { bidder: 'padsquad', params: {} }; @@ -174,7 +174,7 @@ describe('Padsquad bid adapter', function () { describe('buildRequests', function () { it('creates request data', function () { - let request = spec.buildRequests(REQUEST.bidRequest, REQUEST); + const request = spec.buildRequests(REQUEST.bidRequest, REQUEST); expect(request).to.exist.and.to.be.a('object'); const payload = JSON.parse(request.data); @@ -189,7 +189,7 @@ describe('Padsquad bid adapter', function () { gdprApplies: true, } }); - let request = spec.buildRequests(REQUEST.bidRequest, req); + const request = spec.buildRequests(REQUEST.bidRequest, req); const payload = JSON.parse(request.data); expect(payload.user.ext).to.have.property('consent', req.gdprConsent.consentString); @@ -199,7 +199,7 @@ describe('Padsquad bid adapter', function () { describe('interpretResponse', function () { it('have bids', function () { - let bids = spec.interpretResponse(RESPONSE, REQUEST); + const bids = spec.interpretResponse(RESPONSE, REQUEST); expect(bids).to.be.an('array').that.is.not.empty; validateBidOnIndex(0); validateBidOnIndex(1); @@ -228,17 +228,17 @@ describe('Padsquad bid adapter', function () { describe('getUserSyncs', function () { it('handles no parameters', function () { - let opts = spec.getUserSyncs({}); + const opts = spec.getUserSyncs({}); expect(opts).to.be.an('array').that.is.empty; }); it('returns non if sync is not allowed', function () { - let opts = spec.getUserSyncs({iframeEnabled: false, pixelEnabled: false}); + const opts = spec.getUserSyncs({iframeEnabled: false, pixelEnabled: false}); expect(opts).to.be.an('array').that.is.empty; }); it('iframe sync enabled should return results', function () { - let opts = spec.getUserSyncs({iframeEnabled: true, pixelEnabled: false}, [RESPONSE]); + const opts = spec.getUserSyncs({iframeEnabled: true, pixelEnabled: false}, [RESPONSE]); expect(opts.length).to.equal(1); expect(opts[0].type).to.equal('iframe'); @@ -246,7 +246,7 @@ describe('Padsquad bid adapter', function () { }); it('pixel sync enabled should return results', function () { - let opts = spec.getUserSyncs({iframeEnabled: false, pixelEnabled: true}, [RESPONSE]); + const opts = spec.getUserSyncs({iframeEnabled: false, pixelEnabled: true}, [RESPONSE]); expect(opts.length).to.equal(1); expect(opts[0].type).to.equal('image'); @@ -254,7 +254,7 @@ describe('Padsquad bid adapter', function () { }); it('all sync enabled should return all results', function () { - let opts = spec.getUserSyncs({iframeEnabled: true, pixelEnabled: true}, [RESPONSE]); + const opts = spec.getUserSyncs({iframeEnabled: true, pixelEnabled: true}, [RESPONSE]); expect(opts.length).to.equal(2); }); diff --git a/test/spec/modules/pairIdSystem_spec.js b/test/spec/modules/pairIdSystem_spec.js index d391b4deeb0..1228100f3f8 100644 --- a/test/spec/modules/pairIdSystem_spec.js +++ b/test/spec/modules/pairIdSystem_spec.js @@ -19,25 +19,25 @@ describe('pairId', function () { }); it('should read pairId from local storage if exists', function() { - let pairIds = ['test-pair-id1', 'test-pair-id2', 'test-pair-id3']; + const pairIds = ['test-pair-id1', 'test-pair-id2', 'test-pair-id3']; sandbox.stub(storage, 'getDataFromLocalStorage').withArgs('pairId').returns(btoa(JSON.stringify(pairIds))); - let id = pairIdSubmodule.getId({ params: {} }); + const id = pairIdSubmodule.getId({ params: {} }); expect(id).to.be.deep.equal({id: pairIds}); }); it('should read pairId from cookie if exists', function() { - let pairIds = ['test-pair-id4', 'test-pair-id5', 'test-pair-id6']; + const pairIds = ['test-pair-id4', 'test-pair-id5', 'test-pair-id6']; sandbox.stub(storage, 'getCookie').withArgs('pairId').returns(btoa(JSON.stringify(pairIds))); - let id = pairIdSubmodule.getId({ params: {} }); + const id = pairIdSubmodule.getId({ params: {} }); expect(id).to.be.deep.equal({id: pairIds}); }); it('should read pairId from default liveramp envelope local storage key if configured', function() { - let pairIds = ['test-pair-id1', 'test-pair-id2', 'test-pair-id3']; + const pairIds = ['test-pair-id1', 'test-pair-id2', 'test-pair-id3']; sandbox.stub(storage, 'getDataFromLocalStorage').withArgs('_lr_pairId').returns(btoa(JSON.stringify({'envelope': pairIds}))); - let id = pairIdSubmodule.getId({ + const id = pairIdSubmodule.getId({ params: { liveramp: {} }}) @@ -45,9 +45,9 @@ describe('pairId', function () { }) it('should read pairId from default liveramp envelope cookie entry if configured', function() { - let pairIds = ['test-pair-id4', 'test-pair-id5', 'test-pair-id6']; + const pairIds = ['test-pair-id4', 'test-pair-id5', 'test-pair-id6']; sandbox.stub(storage, 'getDataFromLocalStorage').withArgs('_lr_pairId').returns(btoa(JSON.stringify({'envelope': pairIds}))); - let id = pairIdSubmodule.getId({ + const id = pairIdSubmodule.getId({ params: { liveramp: {} }}) @@ -55,9 +55,9 @@ describe('pairId', function () { }) it('should read pairId from specified liveramp envelope cookie entry if configured with storageKey', function() { - let pairIds = ['test-pair-id7', 'test-pair-id8', 'test-pair-id9']; + const pairIds = ['test-pair-id7', 'test-pair-id8', 'test-pair-id9']; sandbox.stub(storage, 'getDataFromLocalStorage').withArgs('lr_pairId_custom').returns(btoa(JSON.stringify({'envelope': pairIds}))); - let id = pairIdSubmodule.getId({ + const id = pairIdSubmodule.getId({ params: { liveramp: { storageKey: 'lr_pairId_custom' @@ -69,7 +69,7 @@ describe('pairId', function () { it('should not get data from storage if local storage and cookies are disabled', function () { sandbox.stub(storage, 'localStorageIsEnabled').returns(false); sandbox.stub(storage, 'cookiesAreEnabled').returns(false); - let id = pairIdSubmodule.getId({ + const id = pairIdSubmodule.getId({ params: { liveramp: { storageKey: 'lr_pairId_custom' diff --git a/test/spec/modules/pangleBidAdapter_spec.js b/test/spec/modules/pangleBidAdapter_spec.js index f2504a810c4..3fbdbaca418 100644 --- a/test/spec/modules/pangleBidAdapter_spec.js +++ b/test/spec/modules/pangleBidAdapter_spec.js @@ -91,7 +91,7 @@ const RESPONSE = { 'bidder': { 'pangle': { 'brand_id': 334553, - 'auction_id': 514667951122925701, + 'auction_id': '514667951122925701', 'bidder_id': 2, 'bid_ad_type': 0 } @@ -108,7 +108,7 @@ const RESPONSE = { describe('pangle bid adapter', function () { describe('isBidRequestValid', function () { it('should accept request if placementid and appid is passed', function () { - let bid = { + const bid = { bidder: 'pangle', params: { token: 'xxx', @@ -117,7 +117,7 @@ describe('pangle bid adapter', function () { expect(spec.isBidRequestValid(bid)).to.equal(true); }); it('reject requests without params', function () { - let bid = { + const bid = { bidder: 'pangle', params: {} }; @@ -127,12 +127,12 @@ describe('pangle bid adapter', function () { describe('buildRequests', function () { it('creates request data', function () { - let request1 = spec.buildRequests(REQUEST, DEFAULT_OPTIONS)[0]; + const request1 = spec.buildRequests(REQUEST, DEFAULT_OPTIONS)[0]; expect(request1).to.exist.and.to.be.a('object'); const payload1 = request1.data; expect(payload1.imp[0]).to.have.property('id', REQUEST[0].bidId); - let request2 = spec.buildRequests(REQUEST, DEFAULT_OPTIONS)[1]; + const request2 = spec.buildRequests(REQUEST, DEFAULT_OPTIONS)[1]; expect(request2).to.exist.and.to.be.a('object'); const payload2 = request2.data; expect(payload2.imp[0]).to.have.property('id', REQUEST[1].bidId); @@ -141,8 +141,8 @@ describe('pangle bid adapter', function () { describe('interpretResponse', function () { it('has bids', function () { - let request = spec.buildRequests(REQUEST, DEFAULT_OPTIONS)[0]; - let bids = spec.interpretResponse(RESPONSE, request); + const request = spec.buildRequests(REQUEST, DEFAULT_OPTIONS)[0]; + const bids = spec.interpretResponse(RESPONSE, request); expect(bids).to.be.an('array').that.is.not.empty; validateBidOnIndex(0); @@ -160,7 +160,7 @@ describe('pangle bid adapter', function () { }); it('handles empty response', function () { - let request = spec.buildRequests(REQUEST, DEFAULT_OPTIONS)[0]; + const request = spec.buildRequests(REQUEST, DEFAULT_OPTIONS)[0]; const EMPTY_RESP = Object.assign({}, RESPONSE, { 'body': {} }); const bids = spec.interpretResponse(EMPTY_RESP, request); expect(bids).to.be.empty; @@ -176,17 +176,17 @@ describe('pangle bid adapter', function () { }); it('should return correct device type: tablet', function () { - let deviceType = spec.getDeviceType(tablet); + const deviceType = spec.getDeviceType(tablet); expect(deviceType).to.equal(5); }); it('should return correct device type: mobile', function () { - let deviceType = spec.getDeviceType(mobile); + const deviceType = spec.getDeviceType(mobile); expect(deviceType).to.equal(4); }); it('should return correct device type: desktop', function () { - let deviceType = spec.getDeviceType(desktop); + const deviceType = spec.getDeviceType(desktop); expect(deviceType).to.equal(2); }); }); diff --git a/test/spec/modules/performaxBidAdapter_spec.js b/test/spec/modules/performaxBidAdapter_spec.js index 49a6a83e29d..218f9402e75 100644 --- a/test/spec/modules/performaxBidAdapter_spec.js +++ b/test/spec/modules/performaxBidAdapter_spec.js @@ -2,7 +2,7 @@ import { expect } from 'chai'; import { spec, converter } from 'modules/performaxBidAdapter.js'; describe('Performax adapter', function () { - let bids = [{ + const bids = [{ bidder: 'performax', params: { tagid: 'sample' @@ -67,7 +67,7 @@ describe('Performax adapter', function () { device: {} }}]; - let bidderRequest = { + const bidderRequest = { bidderCode: 'performax2', auctionId: 'acd97e55-01e1-45ad-813c-67fa27fc5c1b', id: 'acd97e55-01e1-45ad-813c-67fa27fc5c1b', @@ -87,7 +87,7 @@ describe('Performax adapter', function () { device: {} }}; - let serverResponse = { + const serverResponse = { body: { cur: 'CZK', seatbid: [ @@ -105,7 +105,7 @@ describe('Performax adapter', function () { } describe('isBidRequestValid', function () { - let bid = {}; + const bid = {}; it('should return false when missing "tagid" param', function() { bid.params = {slotId: 'param'}; expect(spec.isBidRequestValid(bid)).to.equal(false); @@ -121,47 +121,47 @@ describe('Performax adapter', function () { describe('buildRequests', function () { it('should set correct request method and url', function () { - let requests = spec.buildRequests([bids[0]], bidderRequest); + const requests = spec.buildRequests([bids[0]], bidderRequest); expect(requests).to.be.an('array').that.has.lengthOf(1); - let request = requests[0]; + const request = requests[0]; expect(request.method).to.equal('POST'); expect(request.url).to.equal('https://dale.performax.cz/ortb'); expect(request.data).to.be.an('object'); }); it('should pass correct imp', function () { - let requests = spec.buildRequests([bids[0]], bidderRequest); - let {data} = requests[0]; - let {imp} = data; + const requests = spec.buildRequests([bids[0]], bidderRequest); + const {data} = requests[0]; + const {imp} = data; expect(imp).to.be.an('array').that.has.lengthOf(1); expect(imp[0]).to.be.an('object'); - let bid = imp[0]; + const bid = imp[0]; expect(bid.id).to.equal('2bc545c347dbbe'); expect(bid.banner).to.deep.equal({topframe: 0, format: [{w: 300, h: 300}]}); }); it('should process multiple bids', function () { - let requests = spec.buildRequests(bids, bidderRequest); + const requests = spec.buildRequests(bids, bidderRequest); expect(requests).to.be.an('array').that.has.lengthOf(1); - let {data} = requests[0]; - let {imp} = data; + const {data} = requests[0]; + const {imp} = data; expect(imp).to.be.an('array').that.has.lengthOf(bids.length); - let bid1 = imp[0]; + const bid1 = imp[0]; expect(bid1.banner).to.deep.equal({topframe: 0, format: [{w: 300, h: 300}]}); - let bid2 = imp[1]; + const bid2 = imp[1]; expect(bid2.banner).to.deep.equal({topframe: 0, format: [{w: 300, h: 600}]}); }); }); describe('interpretResponse', function () { it('should map params correctly', function () { - let ortbRequest = {data: converter.toORTB({bidderRequest, bids})}; + const ortbRequest = {data: converter.toORTB({bidderRequest, bids})}; serverResponse.body.id = ortbRequest.data.id; serverResponse.body.seatbid[0].bid[0].imp_id = ortbRequest.data.imp[0].id; - let result = spec.interpretResponse(serverResponse, ortbRequest); + const result = spec.interpretResponse(serverResponse, ortbRequest); expect(result).to.be.an('array').that.has.lengthOf(1); - let bid = result[0]; + const bid = result[0]; expect(bid.cpm).to.equal(20); expect(bid.ad).to.equal('My ad'); diff --git a/test/spec/modules/pgamsspBidAdapter_spec.js b/test/spec/modules/pgamsspBidAdapter_spec.js index ace20539459..d8b3edb82c2 100644 --- a/test/spec/modules/pgamsspBidAdapter_spec.js +++ b/test/spec/modules/pgamsspBidAdapter_spec.js @@ -132,7 +132,7 @@ describe('PGAMBidAdapter', function () { }); it('Returns general data valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys('deviceWidth', 'deviceHeight', @@ -212,7 +212,7 @@ describe('PGAMBidAdapter', function () { } ]; - let serverRequest = spec.buildRequests(bids, bidderRequest); + const serverRequest = spec.buildRequests(bids, bidderRequest); const { placements } = serverRequest.data; for (let i = 0, len = placements.length; i < len; i++) { @@ -247,7 +247,7 @@ describe('PGAMBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { delete bidderRequest.uspConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('object'); expect(data.gdpr).to.have.property('consentString'); @@ -261,7 +261,7 @@ describe('PGAMBidAdapter', function () { bidderRequest.uspConsent = '1---'; delete bidderRequest.gdprConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -276,8 +276,8 @@ describe('PGAMBidAdapter', function () { applicableSections: [8] }; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -291,8 +291,8 @@ describe('PGAMBidAdapter', function () { bidderRequest.ortb2.regs.gpp = 'abc123'; bidderRequest.ortb2.regs.gpp_sid = [8]; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -322,9 +322,9 @@ describe('PGAMBidAdapter', function () { } }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(banner.body[0].requestId); @@ -356,10 +356,10 @@ describe('PGAMBidAdapter', function () { } }] }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -393,10 +393,10 @@ describe('PGAMBidAdapter', function () { } }] }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys('requestId', 'cpm', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'native', 'meta'); expect(dataItem.native).to.have.keys('clickUrl', 'impressionTrackers', 'title', 'image') expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -427,7 +427,7 @@ describe('PGAMBidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -443,7 +443,7 @@ describe('PGAMBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -460,7 +460,7 @@ describe('PGAMBidAdapter', function () { currency: 'USD', }] }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -473,7 +473,7 @@ describe('PGAMBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/pilotxBidAdapter_spec.js b/test/spec/modules/pilotxBidAdapter_spec.js index 4dfa695be41..86b6e1ece08 100644 --- a/test/spec/modules/pilotxBidAdapter_spec.js +++ b/test/spec/modules/pilotxBidAdapter_spec.js @@ -149,21 +149,21 @@ describe('pilotxAdapter', function () { }]; it('should return correct response', function () { const builtRequest = spec.buildRequests(mockVideo1, mockRequest) - let builtRequestData = builtRequest.data - let data = JSON.parse(builtRequestData) + const builtRequestData = builtRequest.data + const data = JSON.parse(builtRequestData) expect(data['379'].bidId).to.equal(mockVideo1[0].bidId) }); it('should return correct response for only array of size', function () { const builtRequest = spec.buildRequests(mockVideo2, mockRequest) - let builtRequestData = builtRequest.data - let data = JSON.parse(builtRequestData) + const builtRequestData = builtRequest.data + const data = JSON.parse(builtRequestData) expect(data['379'].sizes[0][0]).to.equal(mockVideo2[0].sizes[0]) expect(data['379'].sizes[0][1]).to.equal(mockVideo2[0].sizes[1]) }); it('should be valid and pass gdpr items correctly', function () { const builtRequest = spec.buildRequests(mockVideo2, mockRequestGDPR) - let builtRequestData = builtRequest.data - let data = JSON.parse(builtRequestData) + const builtRequestData = builtRequest.data + const data = JSON.parse(builtRequestData) expect(data['379'].gdprConsentString).to.equal(mockRequestGDPR.gdprConsent.consentString) expect(data['379'].gdprConsentRequired).to.equal(mockRequestGDPR.gdprConsent.gdprApplies) }); diff --git a/test/spec/modules/pinkLionBidAdapter_spec.js b/test/spec/modules/pinkLionBidAdapter_spec.js index ca7d5e4ed14..3118491446f 100644 --- a/test/spec/modules/pinkLionBidAdapter_spec.js +++ b/test/spec/modules/pinkLionBidAdapter_spec.js @@ -132,7 +132,7 @@ describe('PinkLionBidAdapter', function () { }); it('Returns general data valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys('deviceWidth', 'deviceHeight', @@ -212,7 +212,7 @@ describe('PinkLionBidAdapter', function () { } ]; - let serverRequest = spec.buildRequests(bids, bidderRequest); + const serverRequest = spec.buildRequests(bids, bidderRequest); const { placements } = serverRequest.data; for (let i = 0, len = placements.length; i < len; i++) { @@ -247,7 +247,7 @@ describe('PinkLionBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { delete bidderRequest.uspConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('object'); expect(data.gdpr).to.have.property('consentString'); @@ -261,7 +261,7 @@ describe('PinkLionBidAdapter', function () { bidderRequest.uspConsent = '1---'; delete bidderRequest.gdprConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -276,8 +276,8 @@ describe('PinkLionBidAdapter', function () { applicableSections: [8] }; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -291,8 +291,8 @@ describe('PinkLionBidAdapter', function () { bidderRequest.ortb2.regs.gpp = 'abc123'; bidderRequest.ortb2.regs.gpp_sid = [8]; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -322,9 +322,9 @@ describe('PinkLionBidAdapter', function () { } }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(banner.body[0].requestId); @@ -356,10 +356,10 @@ describe('PinkLionBidAdapter', function () { } }] }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -393,10 +393,10 @@ describe('PinkLionBidAdapter', function () { } }] }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys('requestId', 'cpm', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'native', 'meta'); expect(dataItem.native).to.have.keys('clickUrl', 'impressionTrackers', 'title', 'image') expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -427,7 +427,7 @@ describe('PinkLionBidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -443,7 +443,7 @@ describe('PinkLionBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -460,7 +460,7 @@ describe('PinkLionBidAdapter', function () { currency: 'USD', }] }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -473,7 +473,7 @@ describe('PinkLionBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/pixfutureBidAdapter_spec.js b/test/spec/modules/pixfutureBidAdapter_spec.js index bdf40fbb06b..78069c62441 100644 --- a/test/spec/modules/pixfutureBidAdapter_spec.js +++ b/test/spec/modules/pixfutureBidAdapter_spec.js @@ -18,7 +18,7 @@ describe('PixFutureAdapter', function () { // Test of isBidRequestValid method describe('isBidRequestValid', function () { - let bid = { + const bid = { 'bidder': 'pixfuture', 'pageUrl': 'https://adinify.com/prebidjs/?pbjs_debug=true', 'bidId': '236e806f760f0c', @@ -43,7 +43,7 @@ describe('PixFutureAdapter', function () { }); it('should return false when required params are not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = { 'pix_id': 0 @@ -55,7 +55,7 @@ describe('PixFutureAdapter', function () { // Test of buildRequest method describe('Test of buildRequest method', function () { - let validBidRequests = [{ + const validBidRequests = [{ 'labelAny': ['display'], 'bidder': 'pixfuture', 'params': { @@ -139,7 +139,7 @@ describe('PixFutureAdapter', function () { } }]; - let bidderRequests = + const bidderRequests = { 'bidderCode': 'pixfuture', 'auctionId': '4cd5684b-ae2a-4d1f-84be-5f1ee66d9ff3', @@ -243,7 +243,7 @@ describe('PixFutureAdapter', function () { // let bidderRequest = Object.assign({}, bidderRequests); const request = spec.buildRequests(validBidRequests, bidderRequests); // console.log(JSON.stringify(request)); - let bidRequest = Object.assign({}, request[0]); + const bidRequest = Object.assign({}, request[0]); expect(bidRequest.data).to.exist; expect(bidRequest.data.sizes).to.deep.equal([[300, 250]]); diff --git a/test/spec/modules/playdigoBidAdapter_spec.js b/test/spec/modules/playdigoBidAdapter_spec.js index 107e0ebc7aa..ec0fdafd64d 100644 --- a/test/spec/modules/playdigoBidAdapter_spec.js +++ b/test/spec/modules/playdigoBidAdapter_spec.js @@ -132,7 +132,7 @@ describe('PlaydigoBidAdapter', function () { }); it('Returns general data valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys('deviceWidth', 'deviceHeight', @@ -212,7 +212,7 @@ describe('PlaydigoBidAdapter', function () { } ]; - let serverRequest = spec.buildRequests(bids, bidderRequest); + const serverRequest = spec.buildRequests(bids, bidderRequest); const { placements } = serverRequest.data; for (let i = 0, len = placements.length; i < len; i++) { @@ -247,7 +247,7 @@ describe('PlaydigoBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { delete bidderRequest.uspConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('object'); expect(data.gdpr).to.have.property('consentString'); @@ -261,7 +261,7 @@ describe('PlaydigoBidAdapter', function () { bidderRequest.uspConsent = '1---'; delete bidderRequest.gdprConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -276,8 +276,8 @@ describe('PlaydigoBidAdapter', function () { applicableSections: [8] }; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -291,8 +291,8 @@ describe('PlaydigoBidAdapter', function () { bidderRequest.ortb2.regs.gpp = 'abc123'; bidderRequest.ortb2.regs.gpp_sid = [8]; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -322,9 +322,9 @@ describe('PlaydigoBidAdapter', function () { } }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(banner.body[0].requestId); @@ -356,10 +356,10 @@ describe('PlaydigoBidAdapter', function () { } }] }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -393,10 +393,10 @@ describe('PlaydigoBidAdapter', function () { } }] }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys('requestId', 'cpm', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'native', 'meta'); expect(dataItem.native).to.have.keys('clickUrl', 'impressionTrackers', 'title', 'image') expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -427,7 +427,7 @@ describe('PlaydigoBidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -443,7 +443,7 @@ describe('PlaydigoBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -460,7 +460,7 @@ describe('PlaydigoBidAdapter', function () { currency: 'USD', }] }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -473,7 +473,7 @@ describe('PlaydigoBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/prebidServerBidAdapter_spec.js b/test/spec/modules/prebidServerBidAdapter_spec.js index aa8a01ccbe6..468c5a0e685 100644 --- a/test/spec/modules/prebidServerBidAdapter_spec.js +++ b/test/spec/modules/prebidServerBidAdapter_spec.js @@ -437,7 +437,7 @@ const RESPONSE_OPENRTB_VIDEO = { bidder: { appnexus: { brand_id: 1, - auction_id: 6673622101799484743, + auction_id: '6673622101799484743', bidder_id: 2, bid_ad_type: 1, }, @@ -542,7 +542,7 @@ const RESPONSE_OPENRTB_NATIVE = { 'bidder': { 'appnexus': { 'brand_id': 555545, - 'auction_id': 4676806524825984103, + 'auction_id': '4676806524825984103', 'bidder_id': 2, 'bid_ad_type': 3 } @@ -865,11 +865,11 @@ describe('S2S Adapter', function () { }) it('should set customHeaders correctly when publisher has provided it', () => { - let configWithCustomHeaders = utils.deepClone(CONFIG); + const configWithCustomHeaders = utils.deepClone(CONFIG); configWithCustomHeaders.customHeaders = { customHeader1: 'customHeader1Value' }; config.setConfig({ s2sConfig: configWithCustomHeaders }); - let reqWithNewConfig = utils.deepClone(REQUEST); + const reqWithNewConfig = utils.deepClone(REQUEST); reqWithNewConfig.s2sConfig = configWithCustomHeaders; adapter.callBids(reqWithNewConfig, BID_REQUESTS, addBidResponse, done, ajax); @@ -879,11 +879,11 @@ describe('S2S Adapter', function () { }); it('should block request if config did not define p1Consent URL in endpoint object config', function () { - let badConfig = utils.deepClone(CONFIG); + const badConfig = utils.deepClone(CONFIG); badConfig.endpoint = { noP1Consent: 'https://prebid.adnxs.com/pbs/v1/openrtb2/auction' }; config.setConfig({ s2sConfig: badConfig }); - let badCfgRequest = utils.deepClone(REQUEST); + const badCfgRequest = utils.deepClone(REQUEST); badCfgRequest.s2sConfig = badConfig; adapter.callBids(badCfgRequest, BID_REQUESTS, addBidResponse, done, ajax); @@ -892,14 +892,14 @@ describe('S2S Adapter', function () { }); it('should block request if config did not define noP1Consent URL in endpoint object config', function () { - let badConfig = utils.deepClone(CONFIG); + const badConfig = utils.deepClone(CONFIG); badConfig.endpoint = { p1Consent: 'https://prebid.adnxs.com/pbs/v1/openrtb2/auction' }; config.setConfig({ s2sConfig: badConfig }); - let badCfgRequest = utils.deepClone(REQUEST); + const badCfgRequest = utils.deepClone(REQUEST); badCfgRequest.s2sConfig = badConfig; - let badBidderRequest = utils.deepClone(BID_REQUESTS); + const badBidderRequest = utils.deepClone(BID_REQUESTS); badBidderRequest[0].gdprConsent = { consentString: 'abc123', addtlConsent: 'superduperconsent', @@ -920,11 +920,11 @@ describe('S2S Adapter', function () { }); it('should block request if config did not define any URLs in endpoint object config', function () { - let badConfig = utils.deepClone(CONFIG); + const badConfig = utils.deepClone(CONFIG); badConfig.endpoint = {}; config.setConfig({ s2sConfig: badConfig }); - let badCfgRequest = utils.deepClone(REQUEST); + const badCfgRequest = utils.deepClone(REQUEST); badCfgRequest.s2sConfig = badConfig; adapter.callBids(badCfgRequest, BID_REQUESTS, addBidResponse, done, ajax); @@ -961,12 +961,12 @@ describe('S2S Adapter', function () { }); it('converts video mediaType properties into openRTB format', function () { - let ortb2Config = utils.deepClone(CONFIG); + const ortb2Config = utils.deepClone(CONFIG); ortb2Config.endpoint.p1Consent = 'https://prebid.adnxs.com/pbs/v1/openrtb2/auction'; config.setConfig({ s2sConfig: ortb2Config }); - let videoBid = utils.deepClone(VIDEO_REQUEST); + const videoBid = utils.deepClone(VIDEO_REQUEST); videoBid.ad_units[0].mediaTypes.video.context = 'instream'; adapter.callBids(videoBid, BID_REQUESTS, addBidResponse, done, ajax); @@ -1050,10 +1050,10 @@ describe('S2S Adapter', function () { }); it('adds gdpr consent information to ortb2 request depending on presence of module', async function () { - let consentConfig = {consentManagement: {cmpApi: 'iab'}, s2sConfig: CONFIG}; + const consentConfig = {consentManagement: {cmpApi: 'iab'}, s2sConfig: CONFIG}; config.setConfig(consentConfig); - let gdprBidRequest = utils.deepClone(BID_REQUESTS); + const gdprBidRequest = utils.deepClone(BID_REQUESTS); gdprBidRequest[0].gdprConsent = mockTCF(); adapter.callBids(await addFpdEnrichmentsToS2SRequest(REQUEST, gdprBidRequest), gdprBidRequest, addBidResponse, done, ajax); @@ -1073,10 +1073,10 @@ describe('S2S Adapter', function () { }); it('adds additional consent information to ortb2 request depending on presence of module', async function () { - let consentConfig = {consentManagement: {cmpApi: 'iab'}, s2sConfig: CONFIG}; + const consentConfig = {consentManagement: {cmpApi: 'iab'}, s2sConfig: CONFIG}; config.setConfig(consentConfig); - let gdprBidRequest = utils.deepClone(BID_REQUESTS); + const gdprBidRequest = utils.deepClone(BID_REQUESTS); gdprBidRequest[0].gdprConsent = Object.assign(mockTCF(), { addtlConsent: 'superduperconsent', }); @@ -1107,7 +1107,7 @@ describe('S2S Adapter', function () { it('is added to ortb2 request when in FPD', async function () { config.setConfig({s2sConfig: CONFIG}); - let uspBidRequest = utils.deepClone(BID_REQUESTS); + const uspBidRequest = utils.deepClone(BID_REQUESTS); uspBidRequest[0].uspConsent = '1NYN'; adapter.callBids(await addFpdEnrichmentsToS2SRequest(REQUEST, uspBidRequest), uspBidRequest, addBidResponse, done, ajax); @@ -1133,7 +1133,7 @@ describe('S2S Adapter', function () { it('is added to ortb2 request when in bidRequest', async function () { config.setConfig({s2sConfig: CONFIG}); - let consentBidRequest = utils.deepClone(BID_REQUESTS); + const consentBidRequest = utils.deepClone(BID_REQUESTS); consentBidRequest[0].uspConsent = '1NYN'; consentBidRequest[0].gdprConsent = mockTCF(); @@ -1155,11 +1155,11 @@ describe('S2S Adapter', function () { }); it('is added to cookie_sync request when in bidRequest', function () { - let cookieSyncConfig = utils.deepClone(CONFIG); + const cookieSyncConfig = utils.deepClone(CONFIG); cookieSyncConfig.syncEndpoint = { p1Consent: 'https://prebid.adnxs.com/pbs/v1/cookie_sync' }; config.setConfig({ s2sConfig: cookieSyncConfig }); - let consentBidRequest = utils.deepClone(BID_REQUESTS); + const consentBidRequest = utils.deepClone(BID_REQUESTS); consentBidRequest[0].uspConsent = '1YNN'; consentBidRequest[0].gdprConsent = mockTCF(); @@ -1167,7 +1167,7 @@ describe('S2S Adapter', function () { s2sBidRequest.s2sConfig = cookieSyncConfig adapter.callBids(s2sBidRequest, consentBidRequest, addBidResponse, done, ajax); - let requestBid = JSON.parse(server.requests[0].requestBody); + const requestBid = JSON.parse(server.requests[0].requestBody); expect(requestBid.us_privacy).is.equal('1YNN'); expect(requestBid.gdpr).is.equal(1); @@ -2488,7 +2488,7 @@ describe('S2S Adapter', function () { }); it('should have extPrebid.schains present on req object if bidder specific schains were configured with pbjs', function () { - let bidRequest = utils.deepClone(BID_REQUESTS); + const bidRequest = utils.deepClone(BID_REQUESTS); bidRequest[0].bids[0].ortb2 = { source: { schain: { @@ -2504,7 +2504,7 @@ describe('S2S Adapter', function () { }; adapter.callBids(REQUEST, bidRequest, addBidResponse, done, ajax); - let requestBid = JSON.parse(server.requests[0].requestBody); + const requestBid = JSON.parse(server.requests[0].requestBody); expect(requestBid.ext.prebid.schains).to.deep.equal([ { @@ -2525,7 +2525,7 @@ describe('S2S Adapter', function () { }); it('should skip over adding any bid specific schain entries that already exist on extPrebid.schains', function () { - let bidRequest = utils.deepClone(BID_REQUESTS); + const bidRequest = utils.deepClone(BID_REQUESTS); bidRequest[0].bids[0].schain = { complete: 1, nodes: [{ @@ -2562,7 +2562,7 @@ describe('S2S Adapter', function () { adapter.callBids(s2sBidRequest, bidRequest, addBidResponse, done, ajax); - let requestBid = JSON.parse(server.requests[0].requestBody); + const requestBid = JSON.parse(server.requests[0].requestBody); expect(requestBid.ext.prebid.schains).to.deep.equal([ { bidders: ['appnexus'], @@ -2582,7 +2582,7 @@ describe('S2S Adapter', function () { }); it('should add a bidder name to pbs schain if the schain is equal to a pbjs one but the pbjs bidder name is not in the bidder array on the pbs side', function () { - let bidRequest = utils.deepClone(BID_REQUESTS); + const bidRequest = utils.deepClone(BID_REQUESTS); bidRequest[0].bids[0].ortb2 = { source: { schain: { @@ -2633,7 +2633,7 @@ describe('S2S Adapter', function () { adapter.callBids(s2sBidRequest, bidRequest, addBidResponse, done, ajax); - let requestBid = JSON.parse(server.requests[0].requestBody); + const requestBid = JSON.parse(server.requests[0].requestBody); expect(requestBid.ext.prebid.schains).to.deep.equal([ { bidders: ['rubicon', 'appnexus'], @@ -3208,7 +3208,7 @@ describe('S2S Adapter', function () { }); it('should set the default bidResponse currency when not specified in OpenRTB', function () { - let modifiedResponse = utils.deepClone(RESPONSE_OPENRTB); + const modifiedResponse = utils.deepClone(RESPONSE_OPENRTB); modifiedResponse.cur = ''; adapter.callBids(REQUEST, BID_REQUESTS, addBidResponse, done, ajax); server.requests[0].respond(200, {}, JSON.stringify(modifiedResponse)); @@ -3237,7 +3237,7 @@ describe('S2S Adapter', function () { }); it('registers client user syncs when client bid adapter is present', function () { - let rubiconAdapter = { + const rubiconAdapter = { registerSyncs: sinon.spy() }; sinon.stub(adapterManager, 'getBidAdapter').callsFake(() => rubiconAdapter); @@ -3252,7 +3252,7 @@ describe('S2S Adapter', function () { }); it('registers client user syncs when using OpenRTB endpoint', function () { - let rubiconAdapter = { + const rubiconAdapter = { registerSyncs: sinon.spy() }; sinon.stub(adapterManager, 'getBidAdapter').returns(rubiconAdapter); @@ -3665,7 +3665,7 @@ describe('S2S Adapter', function () { it('setting adapterCode for alternate bidder', function () { config.setConfig({ CONFIG }); - let RESPONSE_OPENRTB2 = deepClone(RESPONSE_OPENRTB); + const RESPONSE_OPENRTB2 = deepClone(RESPONSE_OPENRTB); RESPONSE_OPENRTB2.seatbid[0].bid[0].ext.prebid.meta.adaptercode = 'appnexus2' adapter.callBids(REQUEST, BID_REQUESTS, addBidResponse, done, ajax); server.requests[0].respond(200, {}, JSON.stringify(RESPONSE_OPENRTB2)); @@ -4090,32 +4090,32 @@ describe('S2S Adapter', function () { }); it('should add cooperative sync flag to cookie_sync request if property is present', function () { - let s2sConfig = utils.deepClone(CONFIG); + const s2sConfig = utils.deepClone(CONFIG); s2sConfig.coopSync = false; s2sConfig.syncEndpoint = { p1Consent: 'https://prebid.adnxs.com/pbs/v1/cookie_sync' }; const s2sBidRequest = utils.deepClone(REQUEST); s2sBidRequest.s2sConfig = s2sConfig; - let bidRequest = utils.deepClone(BID_REQUESTS); + const bidRequest = utils.deepClone(BID_REQUESTS); adapter.callBids(s2sBidRequest, bidRequest, addBidResponse, done, ajax); - let requestBid = JSON.parse(server.requests[0].requestBody); + const requestBid = JSON.parse(server.requests[0].requestBody); expect(requestBid.coopSync).to.equal(false); }); it('should not add cooperative sync flag to cookie_sync request if property is not present', function () { - let s2sConfig = utils.deepClone(CONFIG); + const s2sConfig = utils.deepClone(CONFIG); s2sConfig.syncEndpoint = { p1Consent: 'https://prebid.adnxs.com/pbs/v1/cookie_sync' }; const s2sBidRequest = utils.deepClone(REQUEST); s2sBidRequest.s2sConfig = s2sConfig; - let bidRequest = utils.deepClone(BID_REQUESTS); + const bidRequest = utils.deepClone(BID_REQUESTS); adapter.callBids(s2sBidRequest, bidRequest, addBidResponse, done, ajax); - let requestBid = JSON.parse(server.requests[0].requestBody); + const requestBid = JSON.parse(server.requests[0].requestBody); expect(requestBid.coopSync).to.be.undefined; }); @@ -4141,16 +4141,16 @@ describe('S2S Adapter', function () { it('adds debug flag', function () { config.setConfig({ debug: true }); - let bidRequest = utils.deepClone(BID_REQUESTS); + const bidRequest = utils.deepClone(BID_REQUESTS); adapter.callBids(REQUEST, bidRequest, addBidResponse, done, ajax); - let requestBid = JSON.parse(server.requests[0].requestBody); + const requestBid = JSON.parse(server.requests[0].requestBody); expect(requestBid.ext.prebid.debug).is.equal(true); }); it('should correctly add floors flag', function () { - let bidRequest = utils.deepClone(BID_REQUESTS); + const bidRequest = utils.deepClone(BID_REQUESTS); // should not pass if floorData is undefined adapter.callBids(REQUEST, bidRequest, addBidResponse, done, ajax); diff --git a/test/spec/modules/precisoBidAdapter_spec.js b/test/spec/modules/precisoBidAdapter_spec.js index 83dea6951e5..ae963fa6800 100644 --- a/test/spec/modules/precisoBidAdapter_spec.js +++ b/test/spec/modules/precisoBidAdapter_spec.js @@ -12,7 +12,7 @@ const DEFAULT_BANNER_HEIGHT = 250 const BIDDER_CODE = 'preciso'; describe('PrecisoAdapter', function () { - let bid = { + const bid = { precisoBid: true, bidId: '23fhj33i987f', bidder: 'preciso', @@ -56,7 +56,7 @@ describe('PrecisoAdapter', function () { }; - let nativeBid = { + const nativeBid = { precisoBid: true, bidId: '23fhj33i987f', @@ -157,7 +157,7 @@ describe('PrecisoAdapter', function () { expect(serverRequest.url).to.equal('https://ssp-bidder.2trk.info/bid_request/openrtb'); }); it('Returns valid data if array of bids is valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data.device).to.be.a('object'); expect(data.user).to.be.a('object'); @@ -167,11 +167,11 @@ describe('PrecisoAdapter', function () { it('Returns empty data if no valid requests are passed', function () { delete bid.ortb2.device; serverRequest = spec.buildRequests([bid]); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.device).to.be.undefined; }); - let ServeNativeRequest = spec.buildRequests([nativeBid]); + const ServeNativeRequest = spec.buildRequests([nativeBid]); it('Creates a valid nativeServerRequest object ', function () { expect(ServeNativeRequest).to.exist; expect(ServeNativeRequest.method).to.exist; @@ -182,7 +182,7 @@ describe('PrecisoAdapter', function () { }); it('should extract the native params', function () { - let nativeData = ServeNativeRequest.data; + const nativeData = ServeNativeRequest.data; const asset = JSON.parse(nativeData.imp[0].native.request).assets[0] expect(asset).to.deep.equal({ id: OPENRTB.NATIVE.ASSET_ID.IMAGE, @@ -199,7 +199,7 @@ describe('PrecisoAdapter', function () { describe('interpretResponse', function () { it('should get correct bid response', function () { - let response = { + const response = { bidderRequestId: 'f6adb85f-4e19-45a0-b41e-2a5b9a48f23a', @@ -223,7 +223,7 @@ describe('PrecisoAdapter', function () { ], } - let expectedResponse = [ + const expectedResponse = [ { requestId: 'b4f290d7-d4ab-4778-ab94-2baf06420b22', cpm: DEFAULT_PRICE, @@ -237,7 +237,7 @@ describe('PrecisoAdapter', function () { meta: { advertiserDomains: [] }, } ] - let result = spec.interpretResponse({ body: response }) + const result = spec.interpretResponse({ body: response }) expect(Object.keys(result[0])).to.have.members(Object.keys(expectedResponse[0])) }) @@ -269,7 +269,7 @@ describe('PrecisoAdapter', function () { }], } } - let nativeResponse = { + const nativeResponse = { bidderRequestId: 'f6adb85f-4e19-45a0-b41e-2a5b9a48f23a', seatbid: [ { @@ -291,7 +291,7 @@ describe('PrecisoAdapter', function () { ], } - let expectedNativeResponse = [ + const expectedNativeResponse = [ { requestId: 'b4f290d7-d4ab-4778-ab94-2baf06420b22', mediaType: NATIVE, @@ -317,7 +317,7 @@ describe('PrecisoAdapter', function () { } } ] - let result = spec.interpretResponse({ body: nativeResponse }); + const result = spec.interpretResponse({ body: nativeResponse }); expect(Object.keys(result[0])).to.have.members(Object.keys(expectedNativeResponse[0])); }) }) @@ -328,7 +328,7 @@ describe('PrecisoAdapter', function () { iframeEnabled: true, spec: true }; - let userSync = spec.getUserSyncs(syncOptions); + const userSync = spec.getUserSyncs(syncOptions); it('Returns valid URL and type', function () { expect(userSync).to.be.an('array').with.lengthOf(1); expect(userSync[0].type).to.exist; diff --git a/test/spec/modules/priceFloors_spec.js b/test/spec/modules/priceFloors_spec.js index d045e980d54..8cf8cfeb49f 100644 --- a/test/spec/modules/priceFloors_spec.js +++ b/test/spec/modules/priceFloors_spec.js @@ -221,7 +221,7 @@ describe('the price floors module', function () { expect(getFloorsDataForAuction(basicFloorData)).to.deep.equal(basicFloorData); // if cur and delim not defined then default to correct ones (usd and |) - let inputFloorData = utils.deepClone(basicFloorData); + const inputFloorData = utils.deepClone(basicFloorData); delete inputFloorData.currency; delete inputFloorData.schema.delimiter; expect(getFloorsDataForAuction(inputFloorData)).to.deep.equal(basicFloorData); @@ -229,13 +229,13 @@ describe('the price floors module', function () { // should not use defaults if differing values inputFloorData.currency = 'EUR' inputFloorData.schema.delimiter = '^' - let resultingData = getFloorsDataForAuction(inputFloorData); + const resultingData = getFloorsDataForAuction(inputFloorData); expect(resultingData.currency).to.equal('EUR'); expect(resultingData.schema.delimiter).to.equal('^'); }); it('converts more complex floor data correctly', function () { - let inputFloorData = { + const inputFloorData = { schema: { fields: ['mediaType', 'size', 'domain'] }, @@ -247,7 +247,7 @@ describe('the price floors module', function () { '*|*|prebid.org': 3.5, } }; - let resultingData = getFloorsDataForAuction(inputFloorData); + const resultingData = getFloorsDataForAuction(inputFloorData); expect(resultingData).to.deep.equal({ currency: 'USD', schema: { @@ -265,7 +265,7 @@ describe('the price floors module', function () { }); it('adds adUnitCode to the schema if the floorData comes from adUnit level to maintain scope', function () { - let inputFloorData = utils.deepClone(basicFloorData); + const inputFloorData = utils.deepClone(basicFloorData); let resultingData = getFloorsDataForAuction(inputFloorData, 'test_div_1'); expect(resultingData).to.deep.equal({ modelVersion: 'basic model', @@ -306,7 +306,7 @@ describe('the price floors module', function () { describe('getFirstMatchingFloor', function () { it('uses a 0 floor as override', function () { - let inputFloorData = normalizeDefault({ + const inputFloorData = normalizeDefault({ currency: 'USD', schema: { delimiter: '|', @@ -344,7 +344,7 @@ describe('the price floors module', function () { }); }); it('correctly applies floorMin if on adunit', function () { - let inputFloorData = { + const inputFloorData = { floorMin: 2.6, currency: 'USD', schema: { @@ -358,7 +358,7 @@ describe('the price floors module', function () { default: 0.5 }; - let myBidRequest = { ...basicBidRequest }; + const myBidRequest = { ...basicBidRequest }; // should take adunit floormin first even if lower utils.deepSetValue(myBidRequest, 'ortb2Imp.ext.prebid.floors.floorMin', 2.2); @@ -442,9 +442,9 @@ describe('the price floors module', function () { }); }); it('does not alter cached matched input if conversion occurs', function () { - let inputData = {...basicFloorData}; + const inputData = {...basicFloorData}; [0.2, 0.4, 0.6, 0.8].forEach(modifier => { - let result = getFirstMatchingFloor(inputData, basicBidRequest, {mediaType: 'banner', size: '*'}); + const result = getFirstMatchingFloor(inputData, basicBidRequest, {mediaType: 'banner', size: '*'}); // result should always be the same expect(result).to.deep.equal({ floorMin: 0, @@ -458,7 +458,7 @@ describe('the price floors module', function () { }); }); it('selects the right floor for different sizes', function () { - let inputFloorData = { + const inputFloorData = { currency: 'USD', schema: { delimiter: '|', @@ -506,7 +506,7 @@ describe('the price floors module', function () { }); }); it('selects the right floor for more complex rules', function () { - let inputFloorData = normalizeDefault({ + const inputFloorData = normalizeDefault({ currency: 'USD', schema: { delimiter: '^', @@ -547,7 +547,7 @@ describe('the price floors module', function () { matchingRule: undefined }); // update adUnitCode to test_div_2 with weird other params - let newBidRequest = { ...basicBidRequest, adUnitCode: 'test_div_2' } + const newBidRequest = { ...basicBidRequest, adUnitCode: 'test_div_2' } expect(getFirstMatchingFloor(inputFloorData, newBidRequest, {mediaType: 'badmediatype', size: [900, 900]})).to.deep.equal({ floorMin: 0, floorRuleValue: 3.3, @@ -610,7 +610,7 @@ describe('the price floors module', function () { matchingRule: '/12345/sports/soccer' }); - let newBidRequest = { ...basicBidRequest, adUnitCode: 'test_div_2' } + const newBidRequest = { ...basicBidRequest, adUnitCode: 'test_div_2' } expect(getFirstMatchingFloor(gptFloorData, newBidRequest)).to.deep.equal({ floorMin: 0, floorRuleValue: 2.2, @@ -916,14 +916,14 @@ describe('the price floors module', function () { data: undefined }); // attach floor data onto an adUnit and run an auction - let adUnitWithFloors1 = { + const adUnitWithFloors1 = { ...getAdUnitMock('adUnit-Div-1'), floors: { ...basicFloorData, modelVersion: 'adUnit Model Version', // change the model name } }; - let adUnitWithFloors2 = { + const adUnitWithFloors2 = { ...getAdUnitMock('adUnit-Div-2'), floors: { ...basicFloorData, @@ -952,14 +952,14 @@ describe('the price floors module', function () { data: undefined }); // attach floor data onto an adUnit and run an auction - let adUnitWithFloors1 = { + const adUnitWithFloors1 = { ...getAdUnitMock('adUnit-Div-1'), floors: { ...basicFloorData, modelVersion: 'adUnit Model Version', // change the model name } }; - let adUnitWithFloors2 = { + const adUnitWithFloors2 = { ...getAdUnitMock('adUnit-Div-2'), floors: { ...basicFloorData, @@ -1087,7 +1087,7 @@ describe('the price floors module', function () { }); }); it('should pick the right floorProvider', function () { - let inputFloors = { + const inputFloors = { ...basicFloorConfig, floorProvider: 'providerA', data: { @@ -1144,7 +1144,7 @@ describe('the price floors module', function () { it('should take the right skipRate depending on input', function () { // first priority is data object sandbox.stub(Math, 'random').callsFake(() => 0.99); - let inputFloors = { + const inputFloors = { ...basicFloorConfig, skipRate: 10, data: { @@ -1199,7 +1199,7 @@ describe('the price floors module', function () { }); }); it('should randomly pick a model if floorsSchemaVersion is 2', function () { - let inputFloors = { + const inputFloors = { ...basicFloorConfig, floorProvider: 'floorprovider', data: { @@ -1391,7 +1391,7 @@ describe('the price floors module', function () { }); it('It should fetch if config has url and bidRequests have fetch level flooring meta data', function () { // init the fake server with response stuff - let fetchFloorData = { + const fetchFloorData = { ...basicFloorData, modelVersion: 'fetch model name', // change the model name }; @@ -1430,7 +1430,7 @@ describe('the price floors module', function () { }); it('it should correctly overwrite floorProvider with fetch provider', function () { // init the fake server with response stuff - let fetchFloorData = { + const fetchFloorData = { ...basicFloorData, floorProvider: 'floorProviderD', // change the floor provider modelVersion: 'fetch model name', // change the model name @@ -1471,7 +1471,7 @@ describe('the price floors module', function () { // so floors does not skip sandbox.stub(Math, 'random').callsFake(() => 0.99); // init the fake server with response stuff - let fetchFloorData = { + const fetchFloorData = { ...basicFloorData, modelVersion: 'fetch model name', // change the model name }; @@ -1586,12 +1586,12 @@ describe('the price floors module', function () { }); describe('isFloorsDataValid', function () { it('should return false if unknown floorsSchemaVersion', function () { - let inputFloorData = utils.deepClone(basicFloorData); + const inputFloorData = utils.deepClone(basicFloorData); inputFloorData.floorsSchemaVersion = 3; expect(isFloorsDataValid(inputFloorData)).to.to.equal(false); }); it('should work correctly for fields array', function () { - let inputFloorData = utils.deepClone(basicFloorData); + const inputFloorData = utils.deepClone(basicFloorData); expect(isFloorsDataValid(inputFloorData)).to.to.equal(true); // no fields array @@ -1611,7 +1611,7 @@ describe('the price floors module', function () { expect(isFloorsDataValid(inputFloorData)).to.to.equal(false); }); it('should work correctly for values object', function () { - let inputFloorData = utils.deepClone(basicFloorData); + const inputFloorData = utils.deepClone(basicFloorData); expect(isFloorsDataValid(inputFloorData)).to.to.equal(true); // no values object @@ -1646,7 +1646,7 @@ describe('the price floors module', function () { expect(inputFloorData.values).to.deep.equal({ 'test-div-1|native': 1.0 }); }); it('should work correctly for floorsSchemaVersion 2', function () { - let inputFloorData = { + const inputFloorData = { floorsSchemaVersion: 2, currency: 'USD', modelGroups: [ @@ -1707,7 +1707,7 @@ describe('the price floors module', function () { }); }); describe('getFloor', function () { - let bidRequest = { + const bidRequest = { ...basicBidRequest, getFloor }; @@ -1846,7 +1846,7 @@ describe('the price floors module', function () { }; _floorDataForAuction[bidRequest.auctionId] = utils.deepClone(basicFloorConfig); _floorDataForAuction[bidRequest.auctionId].data.values = { '*': 1.0 }; - let appnexusBid = { + const appnexusBid = { ...bidRequest, bidder: 'appnexus' }; @@ -1906,7 +1906,7 @@ describe('the price floors module', function () { // start with banner as only mediaType bidRequest.mediaTypes = { banner: { sizes: [[300, 250]] } }; - let appnexusBid = { + const appnexusBid = { ...bidRequest, bidder: 'appnexus', }; @@ -2070,7 +2070,7 @@ describe('the price floors module', function () { }; _floorDataForAuction[bidRequest.auctionId] = utils.deepClone(basicFloorConfig); _floorDataForAuction[bidRequest.auctionId].data.values = { '*': 1.0 }; - let appnexusBid = { + const appnexusBid = { ...bidRequest, bidder: 'appnexus' }; @@ -2104,7 +2104,7 @@ describe('the price floors module', function () { }; _floorDataForAuction[bidRequest.auctionId] = utils.deepClone(basicFloorConfig); _floorDataForAuction[bidRequest.auctionId].data.values = { '*': 1.0 }; - let appnexusBid = { + const appnexusBid = { ...bidRequest, bidder: 'appnexus' }; @@ -2123,7 +2123,7 @@ describe('the price floors module', function () { }); }); it('should correctly pick the right attributes if * is passed in and context can be assumed', function () { - let inputBidReq = { + const inputBidReq = { bidder: 'rubicon', adUnitCode: 'test_div_2', auctionId: '987654321', @@ -2226,11 +2226,11 @@ describe('the price floors module', function () { describe('bidResponseHook tests', function () { const AUCTION_ID = '123456'; let returnedBidResponse, indexStub, reject; - let adUnit = { + const adUnit = { transactionId: 'au', code: 'test_div_1' } - let basicBidResponse = { + const basicBidResponse = { bidderCode: 'appnexus', width: 300, height: 250, @@ -2251,7 +2251,7 @@ describe('the price floors module', function () { }); function runBidResponse(bidResp = basicBidResponse) { - let next = (adUnitCode, bid) => { + const next = (adUnitCode, bid) => { returnedBidResponse = bid; }; addBidResponseHook(next, bidResp.adUnitCode, Object.assign(createBid({ auctionId: AUCTION_ID }), bidResp), reject); @@ -2461,7 +2461,7 @@ describe('setting null as rule value', () => { }; it('should validate for null values', function () { - let data = utils.deepClone(nullFloorData); + const data = utils.deepClone(nullFloorData); data.floorsSchemaVersion = 1; expect(isFloorsDataValid(data)).to.to.equal(true); }); @@ -2482,7 +2482,7 @@ describe('setting null as rule value', () => { } _floorDataForAuction[bidRequest.auctionId] = basicFloorConfig; - let inputParams = {mediaType: 'banner', size: [600, 300]}; + const inputParams = {mediaType: 'banner', size: [600, 300]}; expect(bidRequest.getFloor(inputParams)).to.deep.equal(null); }) @@ -2515,7 +2515,7 @@ describe('setting null as rule value', () => { adUnits }); - let inputParams = {mediaType: 'banner', size: [600, 300]}; + const inputParams = {mediaType: 'banner', size: [600, 300]}; expect(exposedAdUnits[0].bids[0].getFloor(inputParams)).to.deep.equal(null); }); diff --git a/test/spec/modules/prismaBidAdapter_spec.js b/test/spec/modules/prismaBidAdapter_spec.js index b0d068e5614..8530a561c24 100644 --- a/test/spec/modules/prismaBidAdapter_spec.js +++ b/test/spec/modules/prismaBidAdapter_spec.js @@ -252,10 +252,10 @@ describe('Prisma bid adapter tests', function () { var syncs = spec.getUserSyncs({}, null, DEFAULT_OPTIONS.gdprConsent, DEFAULT_OPTIONS.uspConsent); expect(syncs).to.have.lengthOf(0); }); - it('Verifies user sync with no bid body response', function() { - var syncs = spec.getUserSyncs({}, [], DEFAULT_OPTIONS.gdprConsent, DEFAULT_OPTIONS.uspConsent); - expect(syncs).to.have.lengthOf(0); - var syncs = spec.getUserSyncs({}, [{}], DEFAULT_OPTIONS.gdprConsent, DEFAULT_OPTIONS.uspConsent); - expect(syncs).to.have.lengthOf(0); - }); + it('Verifies user sync with no bid body response', function() { + let syncs = spec.getUserSyncs({}, [], DEFAULT_OPTIONS.gdprConsent, DEFAULT_OPTIONS.uspConsent); + expect(syncs).to.have.lengthOf(0); + syncs = spec.getUserSyncs({}, [{}], DEFAULT_OPTIONS.gdprConsent, DEFAULT_OPTIONS.uspConsent); + expect(syncs).to.have.lengthOf(0); + }); }); diff --git a/test/spec/modules/programmaticXBidAdapter_spec.js b/test/spec/modules/programmaticXBidAdapter_spec.js index 4f6b817e17b..2cff5d9055b 100644 --- a/test/spec/modules/programmaticXBidAdapter_spec.js +++ b/test/spec/modules/programmaticXBidAdapter_spec.js @@ -132,7 +132,7 @@ describe('ProgrammaticXBidAdapter', function () { }); it('Returns general data valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys('deviceWidth', 'deviceHeight', @@ -212,7 +212,7 @@ describe('ProgrammaticXBidAdapter', function () { } ]; - let serverRequest = spec.buildRequests(bids, bidderRequest); + const serverRequest = spec.buildRequests(bids, bidderRequest); const { placements } = serverRequest.data; for (let i = 0, len = placements.length; i < len; i++) { @@ -247,7 +247,7 @@ describe('ProgrammaticXBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { delete bidderRequest.uspConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('object'); expect(data.gdpr).to.have.property('consentString'); @@ -261,7 +261,7 @@ describe('ProgrammaticXBidAdapter', function () { bidderRequest.uspConsent = '1---'; delete bidderRequest.gdprConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -276,8 +276,8 @@ describe('ProgrammaticXBidAdapter', function () { applicableSections: [8] }; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -291,8 +291,8 @@ describe('ProgrammaticXBidAdapter', function () { bidderRequest.ortb2.regs.gpp = 'abc123'; bidderRequest.ortb2.regs.gpp_sid = [8]; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -322,9 +322,9 @@ describe('ProgrammaticXBidAdapter', function () { } }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(banner.body[0].requestId); @@ -356,10 +356,10 @@ describe('ProgrammaticXBidAdapter', function () { } }] }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -393,10 +393,10 @@ describe('ProgrammaticXBidAdapter', function () { } }] }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys('requestId', 'cpm', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'native', 'meta'); expect(dataItem.native).to.have.keys('clickUrl', 'impressionTrackers', 'title', 'image') expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -427,7 +427,7 @@ describe('ProgrammaticXBidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -443,7 +443,7 @@ describe('ProgrammaticXBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -460,7 +460,7 @@ describe('ProgrammaticXBidAdapter', function () { currency: 'USD', }] }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -473,7 +473,7 @@ describe('ProgrammaticXBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/programmaticaBidAdapter_spec.js b/test/spec/modules/programmaticaBidAdapter_spec.js index 247d20752c3..819ad58cd49 100644 --- a/test/spec/modules/programmaticaBidAdapter_spec.js +++ b/test/spec/modules/programmaticaBidAdapter_spec.js @@ -3,7 +3,7 @@ import { spec } from 'modules/programmaticaBidAdapter.js'; import { deepClone } from 'src/utils.js'; describe('programmaticaBidAdapterTests', function () { - let bidRequestData = { + const bidRequestData = { bids: [ { bidId: 'testbid', @@ -16,7 +16,7 @@ describe('programmaticaBidAdapterTests', function () { } ] }; - let request = []; + const request = []; it('validate_pub_params', function () { expect( @@ -32,13 +32,13 @@ describe('programmaticaBidAdapterTests', function () { it('validate_generated_url', function () { const request = spec.buildRequests(deepClone(bidRequestData.bids), { timeout: 1234 }); - let req_url = request[0].url; + const req_url = request[0].url; expect(req_url).to.equal('https://asr.programmatica.com/get'); }); it('validate_response_params', function () { - let serverResponse = { + const serverResponse = { body: { 'id': 'crid', 'type': { @@ -68,10 +68,10 @@ describe('programmaticaBidAdapterTests', function () { } const request = spec.buildRequests(bidRequest); - let bids = spec.interpretResponse(serverResponse, request[0]); + const bids = spec.interpretResponse(serverResponse, request[0]); expect(bids).to.have.lengthOf(1); - let bid = bids[0]; + const bid = bids[0]; expect(bid.ad).to.equal('test ad'); expect(bid.cpm).to.equal(10); expect(bid.currency).to.equal('USD'); @@ -82,7 +82,7 @@ describe('programmaticaBidAdapterTests', function () { }); it('validate_response_params_imps', function () { - let serverResponse = { + const serverResponse = { body: { 'id': 'crid', 'type': { @@ -114,10 +114,10 @@ describe('programmaticaBidAdapterTests', function () { } const request = spec.buildRequests(bidRequest); - let bids = spec.interpretResponse(serverResponse, request[0]); + const bids = spec.interpretResponse(serverResponse, request[0]); expect(bids).to.have.lengthOf(1); - let bid = bids[0]; + const bid = bids[0]; expect(bid.ad).to.equal('test ad'); expect(bid.cpm).to.equal(10); expect(bid.currency).to.equal('USD'); @@ -128,7 +128,7 @@ describe('programmaticaBidAdapterTests', function () { }) it('validate_invalid_response', function () { - let serverResponse = { + const serverResponse = { body: {} }; @@ -138,7 +138,7 @@ describe('programmaticaBidAdapterTests', function () { } const request = spec.buildRequests(bidRequest); - let bids = spec.interpretResponse(serverResponse, request[0]); + const bids = spec.interpretResponse(serverResponse, request[0]); expect(bids).to.have.lengthOf(0); }) @@ -152,7 +152,7 @@ describe('programmaticaBidAdapterTests', function () { const request = spec.buildRequests(bidRequest, { timeout: 1234 }); const vastXml = ''; - let serverResponse = { + const serverResponse = { body: { 'id': 'cki2n3n6snkuulqutpf0', 'type': { @@ -177,10 +177,10 @@ describe('programmaticaBidAdapterTests', function () { } }; - let bids = spec.interpretResponse(serverResponse, request[0]); + const bids = spec.interpretResponse(serverResponse, request[0]); expect(bids).to.have.lengthOf(1); - let bid = bids[0]; + const bid = bids[0]; expect(bid.mediaType).to.equal('video'); expect(bid.vastXml).to.equal(vastXml); expect(bid.width).to.equal(234); diff --git a/test/spec/modules/proxistoreBidAdapter_spec.js b/test/spec/modules/proxistoreBidAdapter_spec.js index c6cf69f9253..767ef93cf81 100644 --- a/test/spec/modules/proxistoreBidAdapter_spec.js +++ b/test/spec/modules/proxistoreBidAdapter_spec.js @@ -23,7 +23,7 @@ describe('ProxistoreBidAdapter', function () { }, }, }; - let bid = { + const bid = { sizes: [[300, 600]], params: { website: 'example.fr', diff --git a/test/spec/modules/pubCircleBidAdapter_spec.js b/test/spec/modules/pubCircleBidAdapter_spec.js index f02aab9d4d6..5f6d028a7a8 100644 --- a/test/spec/modules/pubCircleBidAdapter_spec.js +++ b/test/spec/modules/pubCircleBidAdapter_spec.js @@ -132,7 +132,7 @@ describe('PubCircleBidAdapter', function () { }); it('Returns general data valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys('deviceWidth', 'deviceHeight', @@ -198,7 +198,7 @@ describe('PubCircleBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { delete bidderRequest.uspConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('object'); expect(data.gdpr).to.have.property('consentString'); @@ -212,7 +212,7 @@ describe('PubCircleBidAdapter', function () { bidderRequest.uspConsent = '1---'; delete bidderRequest.gdprConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -227,8 +227,8 @@ describe('PubCircleBidAdapter', function () { applicableSections: [8] }; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -242,8 +242,8 @@ describe('PubCircleBidAdapter', function () { bidderRequest.ortb2.regs.gpp = 'abc123'; bidderRequest.ortb2.regs.gpp_sid = [8]; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -273,9 +273,9 @@ describe('PubCircleBidAdapter', function () { } }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(banner.body[0].requestId); @@ -307,10 +307,10 @@ describe('PubCircleBidAdapter', function () { } }] }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -344,10 +344,10 @@ describe('PubCircleBidAdapter', function () { } }] }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys('requestId', 'cpm', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'native', 'meta'); expect(dataItem.native).to.have.keys('clickUrl', 'impressionTrackers', 'title', 'image') expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -378,7 +378,7 @@ describe('PubCircleBidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -394,7 +394,7 @@ describe('PubCircleBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -411,7 +411,7 @@ describe('PubCircleBidAdapter', function () { currency: 'USD', }] }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -424,7 +424,7 @@ describe('PubCircleBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/publinkIdSystem_spec.js b/test/spec/modules/publinkIdSystem_spec.js index 65f4f312676..7929a674f68 100644 --- a/test/spec/modules/publinkIdSystem_spec.js +++ b/test/spec/modules/publinkIdSystem_spec.js @@ -72,7 +72,7 @@ describe('PublinkIdSystem', () => { }); describe('callout for id', () => { - let callbackSpy = sinon.spy(); + const callbackSpy = sinon.spy(); beforeEach(() => { callbackSpy.resetHistory(); @@ -80,7 +80,7 @@ describe('PublinkIdSystem', () => { it('Has cached id', () => { const config = {storage: {type: 'cookie'}}; - let submoduleCallback = publinkIdSubmodule.getId(config, undefined, TEST_COOKIE_VALUE).callback; + const submoduleCallback = publinkIdSubmodule.getId(config, undefined, TEST_COOKIE_VALUE).callback; submoduleCallback(callbackSpy); const request = server.requests[0]; @@ -99,7 +99,7 @@ describe('PublinkIdSystem', () => { it('Request path has priority', () => { const config = {storage: {type: 'cookie'}, params: {e: 'ca11c0ca7', site_id: '102030'}}; - let submoduleCallback = publinkIdSubmodule.getId(config, undefined, TEST_COOKIE_VALUE).callback; + const submoduleCallback = publinkIdSubmodule.getId(config, undefined, TEST_COOKIE_VALUE).callback; submoduleCallback(callbackSpy); const request = server.requests[0]; @@ -119,7 +119,7 @@ describe('PublinkIdSystem', () => { it('Fetch with GDPR consent data', () => { const config = {storage: {type: 'cookie'}, params: {e: 'ca11c0ca7', site_id: '102030'}}; const consentData = {gdpr: {gdprApplies: 1, consentString: 'myconsentstring'}}; - let submoduleCallback = publinkIdSubmodule.getId(config, consentData).callback; + const submoduleCallback = publinkIdSubmodule.getId(config, consentData).callback; submoduleCallback(callbackSpy); const request = server.requests[0]; @@ -141,10 +141,10 @@ describe('PublinkIdSystem', () => { it('server doesnt respond', () => { const config = {storage: {type: 'cookie'}, params: {e: 'ca11c0ca7'}}; - let submoduleCallback = publinkIdSubmodule.getId(config).callback; + const submoduleCallback = publinkIdSubmodule.getId(config).callback; submoduleCallback(callbackSpy); - let request = server.requests[0]; + const request = server.requests[0]; const parsed = parseUrl(request.url); expect(parsed.hostname).to.equal('proc.ad.cpe.dotomi.com'); @@ -159,7 +159,7 @@ describe('PublinkIdSystem', () => { it('reject plain email address', () => { const config = {storage: {type: 'cookie'}, params: {e: 'tester@test.com'}}; const consentData = {gdprApplies: 1, consentString: 'myconsentstring'}; - let submoduleCallback = publinkIdSubmodule.getId(config, consentData).callback; + const submoduleCallback = publinkIdSubmodule.getId(config, consentData).callback; submoduleCallback(callbackSpy); expect(server.requests).to.have.lengthOf(0); @@ -168,14 +168,14 @@ describe('PublinkIdSystem', () => { }); describe('usPrivacy', () => { - let callbackSpy = sinon.spy(); + const callbackSpy = sinon.spy(); it('Fetch with usprivacy data', () => { const config = {storage: {type: 'cookie'}, params: {e: 'ca11c0ca7', api_key: 'abcdefg'}}; - let submoduleCallback = publinkIdSubmodule.getId(config, {usp: '1YNN'}).callback; + const submoduleCallback = publinkIdSubmodule.getId(config, {usp: '1YNN'}).callback; submoduleCallback(callbackSpy); - let request = server.requests[0]; + const request = server.requests[0]; const parsed = parseUrl(request.url); expect(parsed.hostname).to.equal('proc.ad.cpe.dotomi.com'); diff --git a/test/spec/modules/pubmaticAnalyticsAdapter_spec.js b/test/spec/modules/pubmaticAnalyticsAdapter_spec.js index 2c007084699..cc27c621fa2 100755 --- a/test/spec/modules/pubmaticAnalyticsAdapter_spec.js +++ b/test/spec/modules/pubmaticAnalyticsAdapter_spec.js @@ -7,9 +7,9 @@ import { server } from '../../mocks/xhr.js'; import 'src/prebid.js'; import { getGlobal } from 'src/prebidGlobal'; -let events = require('src/events'); -let ajax = require('src/ajax'); -let utils = require('src/utils'); +const events = require('src/events'); +const ajax = require('src/ajax'); +const utils = require('src/utils'); const DEFAULT_USER_AGENT = window.navigator.userAgent; const MOBILE_USER_AGENT = 'Mozilla/5.0 (iPhone; CPU iPhone OS 13_3_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.0.5 Mobile/15E148 Safari/604.1'; @@ -364,9 +364,9 @@ describe('pubmatic analytics adapter', function () { clock.tick(2000 + 1000); expect(requests.length).to.equal(1); // only logger is fired - let request = requests[0]; + const request = requests[0]; expect(request.url).to.equal('https://t.pubmatic.com/wl?pubid=9999'); - let data = getLoggerJsonFromRequest(request.requestBody); + const data = getLoggerJsonFromRequest(request.requestBody); expect(data.pubid).to.equal('9999'); expect(data.pid).to.equal('1111'); expect(data.pdvid).to.equal('20'); @@ -502,14 +502,14 @@ describe('pubmatic analytics adapter', function () { clock.tick(2000 + 1000); expect(requests.length).to.equal(2); // logger as well as tracker is fired - let request = requests[1]; // logger is executed late, trackers execute first + const request = requests[1]; // logger is executed late, trackers execute first expect(request.url).to.equal('https://t.pubmatic.com/wl?pubid=9999'); - let data = getLoggerJsonFromRequest(request.requestBody); + const data = getLoggerJsonFromRequest(request.requestBody); expect(data.pubid).to.equal('9999'); expect(data.pid).to.equal('1111'); expect(data.pdvid).to.equal('20'); - let firstTracker = requests[0].url; + const firstTracker = requests[0].url; expect(firstTracker.split('?')[0]).to.equal('https://t.pubmatic.com/wt'); firstTracker.split('?')[1].split('&').map(e => e.split('=')).forEach(e => data[e[0]] = e[1]); expect(data.pubid).to.equal('9999'); @@ -584,7 +584,7 @@ describe('pubmatic analytics adapter', function () { clock.tick(2000 + 1000); expect(requests.length).to.equal(3); // 1 logger and 2 win-tracker - let request = requests[2]; // logger is executed late, trackers execute first + const request = requests[2]; // logger is executed late, trackers execute first expect(request.url).to.equal('https://t.pubmatic.com/wl?pubid=9999'); let data = getLoggerJsonFromRequest(request.requestBody); expect(data.pubid).to.equal('9999'); @@ -672,7 +672,7 @@ describe('pubmatic analytics adapter', function () { expect(data.s[1].ps[0].pb).to.equal(1.50); // tracker slot1 - let firstTracker = requests[0].url; + const firstTracker = requests[0].url; expect(firstTracker.split('?')[0]).to.equal('https://t.pubmatic.com/wt'); data = {}; firstTracker.split('?')[1].split('&').map(e => e.split('=')).forEach(e => data[e[0]] = e[1]); @@ -729,10 +729,10 @@ describe('pubmatic analytics adapter', function () { clock.tick(2000 + 1000); expect(requests.length).to.equal(3); // 1 logger and 2 win-tracker - let request = requests[2]; // logger is executed late, trackers execute first + const request = requests[2]; // logger is executed late, trackers execute first expect(request.url).to.equal('https://t.pubmatic.com/wl?pubid=9999'); - let data = getLoggerJsonFromRequest(request.requestBody); + const data = getLoggerJsonFromRequest(request.requestBody); expect(data.pubid).to.equal('9999'); expect(data.fmv).to.equal(undefined); @@ -773,10 +773,10 @@ describe('pubmatic analytics adapter', function () { clock.tick(2000 + 1000); expect(requests.length).to.equal(3); // 1 logger and 2 win-tracker - let request = requests[2]; // logger is executed late, trackers execute first + const request = requests[2]; // logger is executed late, trackers execute first expect(request.url).to.equal('https://t.pubmatic.com/wl?pubid=9999'); - let data = getLoggerJsonFromRequest(request.requestBody); + const data = getLoggerJsonFromRequest(request.requestBody); expect(data.pubid).to.equal('9999'); expect(data.fmv).to.equal('floorModelTest'); @@ -813,7 +813,7 @@ describe('pubmatic analytics adapter', function () { clock.tick(2000 + 1000); expect(requests.length).to.equal(3); // 1 logger and 2 win-tracker - let request = requests[2]; // logger is executed late, trackers execute first + const request = requests[2]; // logger is executed late, trackers execute first expect(request.url).to.equal('https://t.pubmatic.com/wl?pubid=9999'); let data = getLoggerJsonFromRequest(request.requestBody); expect(data.pubid).to.equal('9999'); @@ -850,7 +850,7 @@ describe('pubmatic analytics adapter', function () { expect(data.s[1].ps[0].frv).to.equal(1.1); expect(data.s[1].ps[0].pb).to.equal(1.50); // tracker slot1 - let firstTracker = requests[0].url; + const firstTracker = requests[0].url; expect(firstTracker.split('?')[0]).to.equal('https://t.pubmatic.com/wt'); data = {}; firstTracker.split('?')[1].split('&').map(e => e.split('=')).forEach(e => data[e[0]] = e[1]); @@ -894,7 +894,7 @@ describe('pubmatic analytics adapter', function () { clock.tick(2000 + 1000); expect(requests.length).to.equal(3); // 1 logger and 2 win-tracker - let request = requests[2]; // logger is executed late, trackers execute first + const request = requests[2]; // logger is executed late, trackers execute first expect(request.url).to.equal('https://t.pubmatic.com/wl?pubid=9999'); let data = getLoggerJsonFromRequest(request.requestBody); expect(data.pubid).to.equal('9999'); @@ -924,7 +924,7 @@ describe('pubmatic analytics adapter', function () { expect(data.s[0].ps[0].ocpm).to.equal(100); expect(data.s[0].ps[0].ocry).to.equal('JPY'); // tracker slot1 - let firstTracker = requests[0].url; + const firstTracker = requests[0].url; expect(firstTracker.split('?')[0]).to.equal('https://t.pubmatic.com/wt'); data = {}; firstTracker.split('?')[1].split('&').map(e => e.split('=')).forEach(e => data[e[0]] = e[1]); @@ -950,8 +950,8 @@ describe('pubmatic analytics adapter', function () { clock.tick(2000 + 1000); expect(requests.length).to.equal(2); // 1 logger and 1 win-tracker - let request = requests[1]; // logger is executed late, trackers execute first - let data = getLoggerJsonFromRequest(request.requestBody); + const request = requests[1]; // logger is executed late, trackers execute first + const data = getLoggerJsonFromRequest(request.requestBody); expect(data.ctr).not.to.be.null; expect(data.tgid).to.equal(0);// test group id should be an INT between 0-15 else set to 0 expect(data.ffs).to.equal(1); @@ -996,8 +996,8 @@ describe('pubmatic analytics adapter', function () { clock.tick(2000 + 1000); expect(requests.length).to.equal(1); // 1 logger and 0 win-tracker - let request = requests[0]; - let data = getLoggerJsonFromRequest(request.requestBody); + const request = requests[0]; + const data = getLoggerJsonFromRequest(request.requestBody); expect(data.s[1].sn).to.equal('/19968336/header-bid-tag-1'); expect(data.s[1].sz).to.deep.equal(['1000x300', '970x250', '728x90']); expect(data.s[1].ps).to.be.an('array'); @@ -1039,8 +1039,8 @@ describe('pubmatic analytics adapter', function () { clock.tick(2000 + 1000); expect(requests.length).to.equal(1); // 1 logger and 0 win-tracker - let request = requests[0]; - let data = getLoggerJsonFromRequest(request.requestBody); + const request = requests[0]; + const data = getLoggerJsonFromRequest(request.requestBody); expect(data.ffs).to.equal(1); expect(data.fsrc).to.equal(2); expect(data.fp).to.equal('pubmatic'); @@ -1105,9 +1105,9 @@ describe('pubmatic analytics adapter', function () { clock.tick(2000 + 1000); expect(requests.length).to.equal(3); // 1 logger and 2 win-tracker - let request = requests[2]; // logger is executed late, trackers execute first + const request = requests[2]; // logger is executed late, trackers execute first expect(request.url).to.equal('https://t.pubmatic.com/wl?pubid=9999'); - let data = getLoggerJsonFromRequest(request.requestBody); + const data = getLoggerJsonFromRequest(request.requestBody); expect(data.s[1].sn).to.equal('/19968336/header-bid-tag-1'); expect(data.s[1].sz).to.deep.equal(['1000x300', '970x250', '728x90']); expect(data.s[1].ps).to.be.an('array'); @@ -1154,7 +1154,7 @@ describe('pubmatic analytics adapter', function () { clock.tick(2000 + 1000); expect(requests.length).to.equal(3); // 1 logger and 2 win-tracker - let request = requests[2]; // logger is executed late, trackers execute first + const request = requests[2]; // logger is executed late, trackers execute first expect(request.url).to.equal('https://t.pubmatic.com/wl?pubid=9999'); let data = getLoggerJsonFromRequest(request.requestBody); expect(data.ffs).to.equal(1); @@ -1192,7 +1192,7 @@ describe('pubmatic analytics adapter', function () { expect(data.s[1].ps[0].pb).to.equal(1.50); expect(data.dvc).to.deep.equal({'plt': 2}); // respective tracker slot - let firstTracker = requests[1].url; + const firstTracker = requests[1].url; expect(firstTracker.split('?')[0]).to.equal('https://t.pubmatic.com/wt'); data = {}; firstTracker.split('?')[1].split('&').map(e => e.split('=')).forEach(e => data[e[0]] = e[1]); @@ -1218,7 +1218,7 @@ describe('pubmatic analytics adapter', function () { clock.tick(2000 + 1000); expect(requests.length).to.equal(3); // 1 logger and 2 win-tracker - let request = requests[2]; // logger is executed late, trackers execute first + const request = requests[2]; // logger is executed late, trackers execute first expect(request.url).to.equal('https://t.pubmatic.com/wl?pubid=9999'); let data = getLoggerJsonFromRequest(request.requestBody); expect(data.s[1].sn).to.equal('/19968336/header-bid-tag-1'); @@ -1252,7 +1252,7 @@ describe('pubmatic analytics adapter', function () { expect(data.s[1].ps[0].frv).to.equal(1.1); expect(data.s[1].ps[0].pb).to.equal(1.50); // respective tracker slot - let firstTracker = requests[1].url; + const firstTracker = requests[1].url; expect(firstTracker.split('?')[0]).to.equal('https://t.pubmatic.com/wt'); data = {}; firstTracker.split('?')[1].split('&').map(e => e.split('=')).forEach(e => data[e[0]] = e[1]); @@ -1274,7 +1274,7 @@ describe('pubmatic analytics adapter', function () { clock.tick(2000 + 1000); expect(requests.length).to.equal(3); // 1 logger and 2 win-tracker - let request = requests[2]; // logger is executed late, trackers execute first + const request = requests[2]; // logger is executed late, trackers execute first expect(request.url).to.equal('https://t.pubmatic.com/wl?pubid=9999'); let data = getLoggerJsonFromRequest(request.requestBody); expect(data.ffs).to.equal(1); @@ -1311,7 +1311,7 @@ describe('pubmatic analytics adapter', function () { expect(data.s[1].ps[0].frv).to.equal(1.1); expect(data.s[1].ps[0].pb).to.equal(1.50); // respective tracker slot - let firstTracker = requests[1].url; + const firstTracker = requests[1].url; expect(firstTracker.split('?')[0]).to.equal('https://t.pubmatic.com/wt'); data = {}; firstTracker.split('?')[1].split('&').map(e => e.split('=')).forEach(e => data[e[0]] = e[1]); @@ -1336,7 +1336,7 @@ describe('pubmatic analytics adapter', function () { clock.tick(2000 + 1000); expect(requests.length).to.equal(3); // 1 logger and 2 win-tracker - let request = requests[2]; // logger is executed late, trackers execute first + const request = requests[2]; // logger is executed late, trackers execute first expect(request.url).to.equal('https://t.pubmatic.com/wl?pubid=9999'); let data = getLoggerJsonFromRequest(request.requestBody); expect(data.s[1].sn).to.equal('/19968336/header-bid-tag-1'); @@ -1367,7 +1367,7 @@ describe('pubmatic analytics adapter', function () { expect(data.s[1].ps[0].ocpm).to.equal(1.52); expect(data.s[1].ps[0].ocry).to.equal('USD'); // respective tracker slot - let firstTracker = requests[1].url; + const firstTracker = requests[1].url; expect(firstTracker.split('?')[0]).to.equal('https://t.pubmatic.com/wt'); data = {}; firstTracker.split('?')[1].split('&').map(e => e.split('=')).forEach(e => data[e[0]] = e[1]); @@ -1392,9 +1392,9 @@ describe('pubmatic analytics adapter', function () { clock.tick(2000 + 1000); expect(requests.length).to.equal(2); // 1 logger and 1 win-tracker - let request = requests[1]; // logger is executed late, trackers execute first + const request = requests[1]; // logger is executed late, trackers execute first expect(request.url).to.equal('https://t.pubmatic.com/wl?pubid=9999'); - let data = getLoggerJsonFromRequest(request.requestBody); + const data = getLoggerJsonFromRequest(request.requestBody); expect(data.ffs).to.equal(1); expect(data.fsrc).to.equal(2); expect(data.fp).to.equal('pubmatic'); @@ -1459,7 +1459,7 @@ describe('pubmatic analytics adapter', function () { clock.tick(2000 + 1000); expect(requests.length).to.equal(3); // 1 logger and 2 win-tracker - let request = requests[2]; // logger is executed late, trackers execute first + const request = requests[2]; // logger is executed late, trackers execute first expect(request.url).to.equal('https://t.pubmatic.com/wl?pubid=9999'); let data = getLoggerJsonFromRequest(request.requestBody); expect(data.pubid).to.equal('9999'); @@ -1548,7 +1548,7 @@ describe('pubmatic analytics adapter', function () { expect(data.s[1].ps[0].pb).to.equal(1.50); // tracker slot1 - let firstTracker = requests[0].url; + const firstTracker = requests[0].url; expect(firstTracker.split('?')[0]).to.equal('https://t.pubmatic.com/wt'); data = {}; firstTracker.split('?')[1].split('&').map(e => e.split('=')).forEach(e => data[e[0]] = e[1]); @@ -1590,7 +1590,7 @@ describe('pubmatic analytics adapter', function () { clock.tick(2000 + 1000); expect(requests.length).to.equal(3); // 1 logger and 2 win-tracker - let request = requests[2]; // logger is executed late, trackers execute first + const request = requests[2]; // logger is executed late, trackers execute first expect(request.url).to.equal('https://t.pubmatic.com/wl?pubid=9999'); let data = getLoggerJsonFromRequest(request.requestBody); expect(data.pubid).to.equal('9999'); @@ -1676,7 +1676,7 @@ describe('pubmatic analytics adapter', function () { expect(data.s[1].ps[0].ocry).to.equal('USD'); // tracker slot1 - let firstTracker = requests[0].url; + const firstTracker = requests[0].url; expect(firstTracker.split('?')[0]).to.equal('https://t.pubmatic.com/wt'); data = {}; firstTracker.split('?')[1].split('&').map(e => e.split('=')).forEach(e => data[e[0]] = e[1]); @@ -1719,7 +1719,7 @@ describe('pubmatic analytics adapter', function () { clock.tick(2000 + 1000); expect(requests.length).to.equal(3); // 1 logger and 2 win-tracker - let request = requests[2]; // logger is executed late, trackers execute first + const request = requests[2]; // logger is executed late, trackers execute first expect(request.url).to.equal('https://t.pubmatic.com/wl?pubid=9999'); let data = getLoggerJsonFromRequest(request.requestBody); expect(data.s).to.be.an('array'); @@ -1734,7 +1734,7 @@ describe('pubmatic analytics adapter', function () { expect(data.s[1].ps[0].origbidid).to.equal('partnerImpressionID-2'); // tracker slot1 - let firstTracker = requests[0].url; + const firstTracker = requests[0].url; expect(firstTracker.split('?')[0]).to.equal('https://t.pubmatic.com/wt'); data = {}; firstTracker.split('?')[1].split('&').map(e => e.split('=')).forEach(e => data[e[0]] = e[1]); @@ -1766,7 +1766,7 @@ describe('pubmatic analytics adapter', function () { clock.tick(2000 + 1000); expect(requests.length).to.equal(3); // 1 logger and 2 win-tracker - let request = requests[2]; // logger is executed late, trackers execute first + const request = requests[2]; // logger is executed late, trackers execute first expect(request.url).to.equal('https://t.pubmatic.com/wl?pubid=9999'); let data = getLoggerJsonFromRequest(request.requestBody); expect(data.s).to.be.an('array'); @@ -1781,7 +1781,7 @@ describe('pubmatic analytics adapter', function () { expect(data.s[1].ps[0].origbidid).to.equal('3bd4ebb1c900e2'); // tracker slot1 - let firstTracker = requests[0].url; + const firstTracker = requests[0].url; expect(firstTracker.split('?')[0]).to.equal('https://t.pubmatic.com/wt'); data = {}; firstTracker.split('?')[1].split('&').map(e => e.split('=')).forEach(e => data[e[0]] = e[1]); diff --git a/test/spec/modules/pubmaticBidAdapter_spec.js b/test/spec/modules/pubmaticBidAdapter_spec.js index b752691f6d3..65912106cfa 100644 --- a/test/spec/modules/pubmaticBidAdapter_spec.js +++ b/test/spec/modules/pubmaticBidAdapter_spec.js @@ -6,7 +6,7 @@ import { config } from 'src/config.js'; describe('PubMatic adapter', () => { let firstBid, videoBid, firstResponse, response, videoResponse; - let request = {}; + const request = {}; firstBid = { adUnitCode: 'Div1', bidder: 'pubmatic', @@ -129,8 +129,8 @@ describe('PubMatic adapter', () => { seatbid: [videoBid] } } - let validBidRequests = [firstBid]; - let bidderRequest = { + const validBidRequests = [firstBid]; + const bidderRequest = { bids: [firstBid], auctionId: 'ee3074fe-97ce-4681-9235-d7622aede74c', auctionStart: 1725514077194, @@ -821,7 +821,7 @@ describe('PubMatic adapter', () => { describe('GPP', () => { it('should have gpp & gpp_sid in request if set using ortb2 and not present in request', () => { - let copiedBidderRequest = utils.deepClone(bidderRequest); + const copiedBidderRequest = utils.deepClone(bidderRequest); copiedBidderRequest.ortb2.regs = { gpp: 'DBACNYA~CPXxRfAPXxRfAAfKABENB-CgAAAAAAAAAAYgAAAAAAAA~1YNN', gpp_sid: [5] @@ -1056,7 +1056,7 @@ describe('PubMatic adapter', () => { if (FEATURES.VIDEO) { describe('VIDEO', () => { beforeEach(() => { - let videoBidderRequest = utils.deepClone(bidderRequest); + const videoBidderRequest = utils.deepClone(bidderRequest); delete videoBidderRequest.bids[0].mediaTypes.banner; videoBidderRequest.bids[0].mediaTypes.video = { skip: 1, diff --git a/test/spec/modules/pubmaticRtdProvider_spec.js b/test/spec/modules/pubmaticRtdProvider_spec.js index de77b5cd860..518113a6b27 100644 --- a/test/spec/modules/pubmaticRtdProvider_spec.js +++ b/test/spec/modules/pubmaticRtdProvider_spec.js @@ -39,7 +39,7 @@ describe('Pubmatic RTD Provider', () => { describe('registerSubModule', () => { it('should register RTD submodule provider', () => { - let submoduleStub = sinon.stub(hook, 'submodule'); + const submoduleStub = sinon.stub(hook, 'submodule'); registerSubModule(); assert(submoduleStub.calledOnceWith('realTimeData', pubmaticSubmodule)); submoduleStub.restore(); diff --git a/test/spec/modules/pubperfAnalyticsAdapter_spec.js b/test/spec/modules/pubperfAnalyticsAdapter_spec.js index 9949d87a2bc..0d75c64f97f 100644 --- a/test/spec/modules/pubperfAnalyticsAdapter_spec.js +++ b/test/spec/modules/pubperfAnalyticsAdapter_spec.js @@ -3,8 +3,8 @@ import {expect} from 'chai'; import {server} from 'test/mocks/xhr.js'; import {expectEvents, fireEvents} from '../../helpers/analytics.js'; -let events = require('src/events'); -let utils = require('src/utils.js'); +const events = require('src/events'); +const utils = require('src/utils.js'); describe('Pubperf Analytics Adapter', function() { describe('Prebid Manager Analytic tests', function() { diff --git a/test/spec/modules/pubriseBidAdapter_spec.js b/test/spec/modules/pubriseBidAdapter_spec.js index 37f1c742c65..200acfec961 100644 --- a/test/spec/modules/pubriseBidAdapter_spec.js +++ b/test/spec/modules/pubriseBidAdapter_spec.js @@ -132,7 +132,7 @@ describe('PubriseBidAdapter', function () { }); it('Returns general data valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys( 'device', @@ -213,7 +213,7 @@ describe('PubriseBidAdapter', function () { } ]; - let serverRequest = spec.buildRequests(bids, bidderRequest); + const serverRequest = spec.buildRequests(bids, bidderRequest); const { placements } = serverRequest.data; for (let i = 0, len = placements.length; i < len; i++) { @@ -248,7 +248,7 @@ describe('PubriseBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { delete bidderRequest.uspConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('object'); expect(data.gdpr).to.have.property('consentString'); @@ -262,7 +262,7 @@ describe('PubriseBidAdapter', function () { bidderRequest.uspConsent = '1---'; delete bidderRequest.gdprConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -277,8 +277,8 @@ describe('PubriseBidAdapter', function () { applicableSections: [8] }; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -292,8 +292,8 @@ describe('PubriseBidAdapter', function () { bidderRequest.ortb2.regs.gpp = 'abc123'; bidderRequest.ortb2.regs.gpp_sid = [8]; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -323,9 +323,9 @@ describe('PubriseBidAdapter', function () { } }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(banner.body[0].requestId); @@ -357,10 +357,10 @@ describe('PubriseBidAdapter', function () { } }] }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -394,10 +394,10 @@ describe('PubriseBidAdapter', function () { } }] }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys('requestId', 'cpm', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'native', 'meta'); expect(dataItem.native).to.have.keys('clickUrl', 'impressionTrackers', 'title', 'image') expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -428,7 +428,7 @@ describe('PubriseBidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -444,7 +444,7 @@ describe('PubriseBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -461,7 +461,7 @@ describe('PubriseBidAdapter', function () { currency: 'USD', }] }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -474,7 +474,7 @@ describe('PubriseBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/pubwiseAnalyticsAdapter_spec.js b/test/spec/modules/pubwiseAnalyticsAdapter_spec.js index 404e3425d80..44c87301fb3 100644 --- a/test/spec/modules/pubwiseAnalyticsAdapter_spec.js +++ b/test/spec/modules/pubwiseAnalyticsAdapter_spec.js @@ -4,14 +4,14 @@ import {expectEvents} from '../../helpers/analytics.js'; import {server} from '../../mocks/xhr.js'; import { EVENTS } from 'src/constants.js'; -let events = require('src/events'); -let adapterManager = require('src/adapterManager').default; +const events = require('src/events'); +const adapterManager = require('src/adapterManager').default; describe('PubWise Prebid Analytics', function () { let requests; let sandbox; let clock; - let mock = {}; + const mock = {}; mock.DEFAULT_PW_CONFIG = { provider: 'pubwiseanalytics', @@ -77,8 +77,8 @@ describe('PubWise Prebid Analytics', function () { clock.tick(500); /* check for critical values */ - let request = requests[0]; - let data = JSON.parse(request.requestBody); + const request = requests[0]; + const data = JSON.parse(request.requestBody); // console.log(data.metaData); expect(data.metaData, 'metaData property').to.exist; @@ -125,8 +125,8 @@ describe('PubWise Prebid Analytics', function () { clock.tick(500); /* check for critical values */ - let request = requests[0]; - let data = JSON.parse(request.requestBody); + const request = requests[0]; + const data = JSON.parse(request.requestBody); // check the basics expect(data.eventList, 'eventList property').to.exist; @@ -135,7 +135,7 @@ describe('PubWise Prebid Analytics', function () { // console.log(data.eventList[0].args); - let eventArgs = data.eventList[0].args; + const eventArgs = data.eventList[0].args; // the props we want removed should go away expect(eventArgs.adUnitCodes, 'adUnitCodes property').not.to.exist; expect(eventArgs.bidderRequests, 'adUnitCodes property').not.to.exist; diff --git a/test/spec/modules/pubxBidAdapter_spec.js b/test/spec/modules/pubxBidAdapter_spec.js index 370669713e9..f0148bb1d06 100644 --- a/test/spec/modules/pubxBidAdapter_spec.js +++ b/test/spec/modules/pubxBidAdapter_spec.js @@ -26,7 +26,7 @@ describe('pubxAdapter', function () { }); it('should return false when required params are not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = {}; expect(spec.isBidRequestValid(invalidBid)).to.equal(false); diff --git a/test/spec/modules/pubxaiAnalyticsAdapter_spec.js b/test/spec/modules/pubxaiAnalyticsAdapter_spec.js index f9f4005db41..e9bde2d7750 100644 --- a/test/spec/modules/pubxaiAnalyticsAdapter_spec.js +++ b/test/spec/modules/pubxaiAnalyticsAdapter_spec.js @@ -33,14 +33,14 @@ describe('pubxai analytics adapter', () => { describe('track', () => { const pubxId = '6c415fc0-8b0e-4cf5-be73-01526a4db625'; - let initOptions = { + const initOptions = { samplingRate: '1', pubxId: pubxId, }; let originalVS; - let location = getWindowLocation(); + const location = getWindowLocation(); const replaceProperty = (obj, params) => { let strObj = JSON.stringify(obj); @@ -53,7 +53,7 @@ describe('pubxai analytics adapter', () => { return JSON.parse(strObj); }; - let prebidEvent = { + const prebidEvent = { auctionInit: { auctionId: 'bc3806e4-873e-453c-8ae5-204f35e923b4', timestamp: 1603865707180, @@ -520,7 +520,7 @@ describe('pubxai analytics adapter', () => { }, }; - let expectedAfterBid = { + const expectedAfterBid = { bids: [ { bidderCode: 'appnexus', @@ -607,7 +607,7 @@ describe('pubxai analytics adapter', () => { }, }; - let expectedAfterBidWon = { + const expectedAfterBidWon = { winningBid: { adUnitCode: '/19968336/header-bid-tag-1', gptSlotCode: diff --git a/test/spec/modules/pubxaiRtdProvider_spec.js b/test/spec/modules/pubxaiRtdProvider_spec.js index 6ffa4952992..85bb0e5c474 100644 --- a/test/spec/modules/pubxaiRtdProvider_spec.js +++ b/test/spec/modules/pubxaiRtdProvider_spec.js @@ -75,7 +75,7 @@ const stubConfig = () => { describe('pubxaiRtdProvider', () => { describe('beforeInit', () => { it('should register RTD submodule provider', function () { - let submoduleStub = sinon.stub(hook, 'submodule'); + const submoduleStub = sinon.stub(hook, 'submodule'); beforeInit(); assert(submoduleStub.calledOnceWith('realTimeData', pubxaiSubmodule)); submoduleStub.restore(); diff --git a/test/spec/modules/pulsepointBidAdapter_spec.js b/test/spec/modules/pulsepointBidAdapter_spec.js index 818acea7791..30663066d93 100644 --- a/test/spec/modules/pulsepointBidAdapter_spec.js +++ b/test/spec/modules/pulsepointBidAdapter_spec.js @@ -569,8 +569,8 @@ describe('PulsePoint Adapter Tests', function () { } } }; - let request = spec.buildRequests(slotConfigs, await addFPDToBidderRequest(bidderRequest)); - let ortbRequest = request.data; + const request = spec.buildRequests(slotConfigs, await addFPDToBidderRequest(bidderRequest)); + const ortbRequest = request.data; expect(ortbRequest).to.not.equal(null); expect(ortbRequest.user).to.not.equal(null); expect(ortbRequest.user).to.deep.equal({ @@ -607,8 +607,8 @@ describe('PulsePoint Adapter Tests', function () { } } }; - let request = spec.buildRequests(slotConfigs, await addFPDToBidderRequest(bidderRequest)); - let ortbRequest = request.data; + const request = spec.buildRequests(slotConfigs, await addFPDToBidderRequest(bidderRequest)); + const ortbRequest = request.data; expect(ortbRequest).to.not.equal(null); expect(ortbRequest.site).to.not.equal(null); expect(ortbRequest.site).to.deep.equal({ @@ -654,8 +654,8 @@ describe('PulsePoint Adapter Tests', function () { } } }]; - let request = spec.buildRequests(bidderRequests, bidderRequest); - let ortbRequest = request.data; + const request = spec.buildRequests(bidderRequests, bidderRequest); + const ortbRequest = request.data; expect(ortbRequest).to.not.equal(null); expect(ortbRequest.imp).to.not.equal(null); expect(ortbRequest.imp).to.have.lengthOf(1); diff --git a/test/spec/modules/pwbidBidAdapter_spec.js b/test/spec/modules/pwbidBidAdapter_spec.js index fdd95553687..221eadac31a 100644 --- a/test/spec/modules/pwbidBidAdapter_spec.js +++ b/test/spec/modules/pwbidBidAdapter_spec.js @@ -1,9 +1,7 @@ // import or require modules necessary for the test, e.g.: import {expect} from 'chai'; -import {spec} from 'modules/pwbidBidAdapter.js'; -import {_checkVideoPlacement, _checkMediaType} from 'modules/pwbidBidAdapter.js'; // this is exported only for testing so maintaining the JS convention of _ to indicate the intent -import {_parseAdSlot} from 'modules/pwbidBidAdapter.js'; // this is exported only for testing so maintaining the JS convention of _ to indicate the intent +import {spec, _checkVideoPlacement, _checkMediaType, _parseAdSlot} from 'modules/pwbidBidAdapter.js'; // _ functions exported only for testing so maintaining the JS convention of _ to indicate the intent import * as utils from 'src/utils.js'; const sampleRequestBanner = { @@ -493,28 +491,28 @@ describe('PubWiseAdapter', function () { describe('Handles Params Properly', function () { it('properly sets the default endpoint', function () { const referenceEndpoint = 'https://bid.pubwise.io/prebid'; - let endpointBidRequest = utils.deepClone(sampleValidBidRequests); + const endpointBidRequest = utils.deepClone(sampleValidBidRequests); // endpointBidRequest.forEach((bidRequest) => { // bidRequest.params.endpoint_url = newEndpoint; // }); - let result = spec.buildRequests(endpointBidRequest, {auctionId: 'placeholder'}); + const result = spec.buildRequests(endpointBidRequest, {auctionId: 'placeholder'}); expect(result.url).to.equal(referenceEndpoint); }); it('allows endpoint to be reset', function () { const newEndpoint = 'http://www.pubwise.io/endpointtest'; - let endpointBidRequest = utils.deepClone(sampleValidBidRequests); + const endpointBidRequest = utils.deepClone(sampleValidBidRequests); endpointBidRequest.forEach((bidRequest) => { bidRequest.params.endpoint_url = newEndpoint; }); - let result = spec.buildRequests(endpointBidRequest, {auctionId: 'placeholder'}); + const result = spec.buildRequests(endpointBidRequest, {auctionId: 'placeholder'}); expect(result.url).to.equal(newEndpoint); }); }); describe('Properly Validates Bids', function () { it('valid bid', function () { - let validBid = { + const validBid = { bidder: 'pubwise', params: { siteId: 'xxxxxx' @@ -525,7 +523,7 @@ describe('PubWiseAdapter', function () { }); it('valid bid: extra fields are ok', function () { - let validBid = { + const validBid = { bidder: 'pubwise', params: { siteId: 'xxxxxx', @@ -537,7 +535,7 @@ describe('PubWiseAdapter', function () { }); it('invalid bid: no siteId', function () { - let inValidBid = { + const inValidBid = { bidder: 'pubwise', params: { gender: 'M', @@ -548,7 +546,7 @@ describe('PubWiseAdapter', function () { }); it('invalid bid: siteId should be a string', function () { - let validBid = { + const validBid = { bidder: 'pubwise', params: { siteId: 123456 @@ -561,26 +559,26 @@ describe('PubWiseAdapter', function () { describe('Handling Request Construction', function () { it('bid requests are not mutable', function() { - let sourceBidRequest = utils.deepClone(sampleValidBidRequests); + const sourceBidRequest = utils.deepClone(sampleValidBidRequests); spec.buildRequests(sampleValidBidRequests, {auctionId: 'placeholder'}); expect(sampleValidBidRequests).to.deep.equal(sourceBidRequest, 'Should be unedited as they are used elsewhere'); }); it('should handle complex bidRequest', function() { - let request = spec.buildRequests(sampleValidBidRequests, sampleBidderRequest); + const request = spec.buildRequests(sampleValidBidRequests, sampleBidderRequest); expect(request.bidderRequest).to.equal(sampleBidderRequest, "Bid Request Doesn't Match Sample"); expect(request.data.source.tid).to.equal(sampleBidderRequest.ortb2.source.tid, 'source.tid -> source.tid Mismatch'); expect(request.data.imp[0].ext.tid).to.equal(sampleBidderRequest.bids[0].ortb2Imp.ext.tid, 'ext.tid -> ext.tid Mismatch'); }); it('must conform to API for buildRequests', function() { - let request = spec.buildRequests(sampleValidBidRequests); + const request = spec.buildRequests(sampleValidBidRequests); expect(request.bidderRequest).to.be.undefined; }); }); describe('Identifies Media Types', function () { it('identifies native adm type', function() { - let adm = '{"ver":"1.2","assets":[{"title":{"text":"PubWise Test"}},{"img":{"type":3,"url":"http://www.pubwise.io"}},{"img":{"type":1,"url":"http://www.pubwise.io"}},{"data":{"type":2,"value":"PubWise Test Desc"}},{"data":{"type":1,"value":"PubWise.io"}}],"link":{"url":""}}'; - let newBid = {mediaType: 'unknown'}; + const adm = '{"ver":"1.2","assets":[{"title":{"text":"PubWise Test"}},{"img":{"type":3,"url":"http://www.pubwise.io"}},{"img":{"type":1,"url":"http://www.pubwise.io"}},{"data":{"type":2,"value":"PubWise Test Desc"}},{"data":{"type":1,"value":"PubWise.io"}}],"link":{"url":""}}'; + const newBid = {mediaType: 'unknown'}; _checkMediaType({adm}, newBid); expect(newBid.mediaType).to.equal('native', adm + ' Is a Native adm'); }); @@ -595,7 +593,7 @@ describe('PubWiseAdapter', function () { describe('Properly Parses AdSlot Data', function () { it('parses banner', function() { - let testBid = utils.deepClone(sampleValidBannerBidRequest) + const testBid = utils.deepClone(sampleValidBannerBidRequest) _parseAdSlot(testBid) expect(testBid).to.deep.equal(sampleBidderBannerRequest); }); @@ -604,7 +602,7 @@ describe('PubWiseAdapter', function () { describe('Properly Handles Response', function () { it('handles response with muiltiple responses', function() { // the request when it comes back is on the data object - let pbResponse = spec.interpretResponse(sampleRTBResponse, {'data': sampleRequest}) + const pbResponse = spec.interpretResponse(sampleRTBResponse, {'data': sampleRequest}) expect(pbResponse).to.deep.equal(samplePBBidObjects); }); }); @@ -648,7 +646,7 @@ describe('PubWiseAdapter', function () { } ]; - let newvideoRequests = [{ + const newvideoRequests = [{ 'bidder': 'pwbid', 'params': { 'siteId': 'xxxxx', @@ -686,7 +684,7 @@ describe('PubWiseAdapter', function () { 'bidderWinsCount': 0 }]; - let newvideoBidResponses = { + const newvideoBidResponses = { 'body': { 'id': '1621441141473', 'cur': 'USD', @@ -713,7 +711,7 @@ describe('PubWiseAdapter', function () { 'headers': {} }; - let videoBidResponse = { + const videoBidResponse = { 'body': { 'id': '93D3BAD6-E2E2-49FB-9D89-920B1761C865', 'seatbid': [{ @@ -733,10 +731,10 @@ describe('PubWiseAdapter', function () { }; it('Request params check for video ad', function () { - let request = spec.buildRequests(videoBidRequests, { + const request = spec.buildRequests(videoBidRequests, { auctionId: 'new-auction-id' }); - let data = request.data; + const data = request.data; expect(data.imp[0].video).to.exist; expect(data.imp[0].tagid).to.equal('Div1'); expect(data.imp[0]['video']['mimes']).to.exist.and.to.be.an('array'); @@ -772,23 +770,23 @@ describe('PubWiseAdapter', function () { }); it('should assign mediaType even if bid.ext.mediaType does not exists', function() { - let newrequest = spec.buildRequests(newvideoRequests, { + const newrequest = spec.buildRequests(newvideoRequests, { auctionId: 'new-auction-id' }); - let newresponse = spec.interpretResponse(newvideoBidResponses, newrequest); + const newresponse = spec.interpretResponse(newvideoBidResponses, newrequest); expect(newresponse[0].mediaType).to.equal('video'); }); it('should not assign renderer if bid is video and request is for instream', function() { - let request = spec.buildRequests(videoBidRequests, { + const request = spec.buildRequests(videoBidRequests, { auctionId: 'new-auction-id' }); - let response = spec.interpretResponse(videoBidResponse, request); + const response = spec.interpretResponse(videoBidResponse, request); expect(response[0].renderer).to.not.exist; }); it('should process instream and outstream', function() { - let validOutstreamRequest = + const validOutstreamRequest = { code: 'video1', mediaTypes: { @@ -814,12 +812,12 @@ describe('PubWiseAdapter', function () { } }; - let outstreamBidRequest = + const outstreamBidRequest = [ validOutstreamRequest ]; - let validInstreamRequest = { + const validInstreamRequest = { code: 'video1', mediaTypes: { video: { @@ -844,15 +842,15 @@ describe('PubWiseAdapter', function () { } }; - let instreamBidRequest = + const instreamBidRequest = [ validInstreamRequest ]; - let outstreamRequest = spec.isBidRequestValid(validOutstreamRequest); + const outstreamRequest = spec.isBidRequestValid(validOutstreamRequest); expect(outstreamRequest).to.equal(false); - let instreamRequest = spec.isBidRequestValid(validInstreamRequest); + const instreamRequest = spec.isBidRequestValid(validInstreamRequest); expect(instreamRequest).to.equal(true); }); @@ -860,7 +858,7 @@ describe('PubWiseAdapter', function () { let sandbox, utilsMock; const adUnit = 'DivCheckPlacement'; const msg_placement_missing = 'PubWise: Video.Placement param missing for DivCheckPlacement'; - let videoData = { + const videoData = { battr: [6, 7], skipafter: 15, maxduration: 50, diff --git a/test/spec/modules/pxyzBidAdapter_spec.js b/test/spec/modules/pxyzBidAdapter_spec.js index 87dc5ff0783..2ce6ed0140b 100644 --- a/test/spec/modules/pxyzBidAdapter_spec.js +++ b/test/spec/modules/pxyzBidAdapter_spec.js @@ -22,7 +22,7 @@ describe('pxyzBidAdapter', function () { }); describe('isBidRequestValid', function () { - let bid = { + const bid = { 'bidder': 'pxyz', 'params': { 'placementId': '10433394' @@ -39,7 +39,7 @@ describe('pxyzBidAdapter', function () { }); it('should return false when required params are not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = { 'placementId': 0 @@ -49,7 +49,7 @@ describe('pxyzBidAdapter', function () { }); describe('buildRequests', function () { - let bidRequests = [ + const bidRequests = [ { 'bidder': 'pxyz', 'params': { @@ -143,7 +143,7 @@ describe('pxyzBidAdapter', function () { }) describe('interpretResponse', function () { - let response = { + const response = { 'id': 'bidd_id', 'seatbid': [ { 'bid': [ @@ -175,12 +175,12 @@ describe('pxyzBidAdapter', function () { 'cur': 'AUD' }; - let bidderRequest = { + const bidderRequest = { 'bidderCode': 'pxyz' }; it('should get correct bid response', function () { - let expectedResponse = [ + const expectedResponse = [ { 'requestId': '221f2bdc1fbc31', 'cpm': 1, @@ -197,14 +197,14 @@ describe('pxyzBidAdapter', function () { } } ]; - let result = spec.interpretResponse({ body: response }, {bidderRequest}); + const result = spec.interpretResponse({ body: response }, {bidderRequest}); expect(Object.keys(result[0])).to.have.members(Object.keys(expectedResponse[0])); expect(result[0].meta.advertiserDomains).to.deep.equal(expectedResponse[0].meta.advertiserDomains); }); it('handles nobid response', function () { const response = undefined; - let result = spec.interpretResponse({ body: response }, {bidderRequest}); + const result = spec.interpretResponse({ body: response }, {bidderRequest}); expect(result.length).to.equal(0); }); }); @@ -213,7 +213,7 @@ describe('pxyzBidAdapter', function () { const syncImageUrl = '//ib.adnxs.com/getuidnb?https://ads.playground.xyz/usersync?partner=appnexus&uid=$UID'; const syncIframeUrl = '//rtb.gumgum.com/getuid/15801?r=https%3A%2F%2Fads.playground.xyz%2Fusersync%3Fpartner%3Dgumgum%26uid%3D'; it('should return one image type user sync pixel', function () { - let result = spec.getUserSyncs(); + const result = spec.getUserSyncs(); expect(result.length).to.equal(2); expect(result[0].type).to.equal('image') expect(result[0].url).to.equal(syncImageUrl); diff --git a/test/spec/modules/qortexRtdProvider_spec.js b/test/spec/modules/qortexRtdProvider_spec.js index 1eee5ea293d..393841c0d28 100644 --- a/test/spec/modules/qortexRtdProvider_spec.js +++ b/test/spec/modules/qortexRtdProvider_spec.js @@ -172,7 +172,7 @@ describe('qortexRtdProvider', () => { let addEventListenerSpy; let billableEvents = []; - let config = cloneDeep(validModuleConfig); + const config = cloneDeep(validModuleConfig); config.params.tagConfig = validTagConfig; events.on(EVENTS.BILLABLE_EVENT, (e) => { diff --git a/test/spec/modules/qtBidAdapter_spec.js b/test/spec/modules/qtBidAdapter_spec.js index 9319df0f660..ad710f1ea9a 100644 --- a/test/spec/modules/qtBidAdapter_spec.js +++ b/test/spec/modules/qtBidAdapter_spec.js @@ -132,7 +132,7 @@ describe('QTBidAdapter', function () { }); it('Returns general data valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys('deviceWidth', 'deviceHeight', @@ -212,7 +212,7 @@ describe('QTBidAdapter', function () { } ]; - let serverRequest = spec.buildRequests(bids, bidderRequest); + const serverRequest = spec.buildRequests(bids, bidderRequest); const { placements } = serverRequest.data; for (let i = 0, len = placements.length; i < len; i++) { @@ -247,7 +247,7 @@ describe('QTBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { delete bidderRequest.uspConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('object'); expect(data.gdpr).to.have.property('consentString'); @@ -261,7 +261,7 @@ describe('QTBidAdapter', function () { bidderRequest.uspConsent = '1---'; delete bidderRequest.gdprConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -276,8 +276,8 @@ describe('QTBidAdapter', function () { applicableSections: [8] }; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -291,8 +291,8 @@ describe('QTBidAdapter', function () { bidderRequest.ortb2.regs.gpp = 'abc123'; bidderRequest.ortb2.regs.gpp_sid = [8]; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -322,9 +322,9 @@ describe('QTBidAdapter', function () { } }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(banner.body[0].requestId); @@ -356,10 +356,10 @@ describe('QTBidAdapter', function () { } }] }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -393,10 +393,10 @@ describe('QTBidAdapter', function () { } }] }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys('requestId', 'cpm', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'native', 'meta'); expect(dataItem.native).to.have.keys('clickUrl', 'impressionTrackers', 'title', 'image') expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -427,7 +427,7 @@ describe('QTBidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -443,7 +443,7 @@ describe('QTBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -460,7 +460,7 @@ describe('QTBidAdapter', function () { currency: 'USD', }] }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -473,7 +473,7 @@ describe('QTBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/qwarryBidAdapter_spec.js b/test/spec/modules/qwarryBidAdapter_spec.js index fef013f8ce6..ae930277476 100644 --- a/test/spec/modules/qwarryBidAdapter_spec.js +++ b/test/spec/modules/qwarryBidAdapter_spec.js @@ -78,7 +78,7 @@ describe('qwarryBidAdapter', function () { }) it('should return false when required params are not passed', function () { - let bid = Object.assign({}, REQUEST) + const bid = Object.assign({}, REQUEST) delete bid.params.zoneToken expect(spec.isBidRequestValid(bid)).to.equal(false) delete bid.params @@ -87,7 +87,7 @@ describe('qwarryBidAdapter', function () { }) describe('buildRequests', function () { - let bidRequests = [REQUEST] + const bidRequests = [REQUEST] const bidderRequest = spec.buildRequests(bidRequests, { bidderRequestId: '123', gdprConsent: { diff --git a/test/spec/modules/r2b2AnalytiscAdapter_spec.js b/test/spec/modules/r2b2AnalytiscAdapter_spec.js index 0bc0b02c457..70a543e61e2 100644 --- a/test/spec/modules/r2b2AnalytiscAdapter_spec.js +++ b/test/spec/modules/r2b2AnalytiscAdapter_spec.js @@ -1,5 +1,5 @@ -import r2b2Analytics from '../../../modules/r2b2AnalyticsAdapter'; -import {resetAnalyticAdapter} from '../../../modules/r2b2AnalyticsAdapter'; +import r2b2Analytics, {resetAnalyticAdapter} from '../../../modules/r2b2AnalyticsAdapter'; + import { expect } from 'chai'; import {EVENTS, AD_RENDER_FAILED_REASON, REJECTION_REASON} from 'src/constants.js'; import * as pbEvents from 'src/events.js'; @@ -7,7 +7,7 @@ import * as ajax from 'src/ajax.js'; import * as utils from 'src/utils'; import {getGlobal} from 'src/prebidGlobal'; import * as prebidGlobal from 'src/prebidGlobal'; -let adapterManager = require('src/adapterManager').default; +const adapterManager = require('src/adapterManager').default; const { NO_BID, AUCTION_INIT, BID_REQUESTED, BID_TIMEOUT, BID_RESPONSE, BID_REJECTED, BIDDER_DONE, AUCTION_END, BID_WON, SET_TARGETING, STALE_RENDER, AD_RENDER_SUCCEEDED, AD_RENDER_FAILED, BID_VIEWABLE @@ -300,11 +300,11 @@ function expectEvents(events, sandbox) { function validateAndExtractEvents(ajaxStub) { expect(ajaxStub.calledOnce).to.equal(true); - let eventArgs = ajaxStub.firstCall.args[2]; + const eventArgs = ajaxStub.firstCall.args[2]; expect(typeof eventArgs).to.be.equal('string'); expect(eventArgs.indexOf('events=')).to.be.equal(0); - let eventsString = eventArgs.substring(7); - let events = tryParseJSON(eventsString); + const eventsString = eventArgs.substring(7); + const events = tryParseJSON(eventsString); expect(events).to.not.be.undefined; return events; @@ -333,12 +333,12 @@ function getPrebidEvents(events) { return events && events.prebid && events.prebid.e; } function getPrebidEventsByName(events, name) { - let prebidEvents = getPrebidEvents(events); + const prebidEvents = getPrebidEvents(events); if (!prebidEvents) return []; - let result = []; + const result = []; for (let i = 0; i < prebidEvents.length; i++) { - let event = prebidEvents[i]; + const event = prebidEvents[i]; if (event.e === name) { result.push(event); } @@ -391,7 +391,7 @@ describe('r2b2 Analytics', function () { describe('config', () => { it('missing domain', () => { - let logWarnStub = sandbox.stub(utils, 'logWarn'); + const logWarnStub = sandbox.stub(utils, 'logWarn'); adapterManager.enableAnalytics({ provider: 'r2b2', @@ -420,7 +420,7 @@ describe('r2b2 Analytics', function () { expect(ajaxStub.calledOnce).to.be.true; expect(typeof ajaxStub.firstCall.args[0]).to.be.equal('string'); - let query = getQueryData(ajaxStub.firstCall.args[0], true); + const query = getQueryData(ajaxStub.firstCall.args[0], true); expect(query['d']).to.be.equal('test.cz'); expect(query['conf']).to.be.equal('11'); expect(query['conf_ver']).to.be.equal('7'); @@ -445,7 +445,7 @@ describe('r2b2 Analytics', function () { setTimeout(() => { expect(ajaxStub.calledOnce).to.be.true; expect(typeof ajaxStub.firstCall.args[0]).to.be.equal('string'); - let query = getQueryData(ajaxStub.firstCall.args[0], true); + const query = getQueryData(ajaxStub.firstCall.args[0], true); expect(query['hbDomain']).to.be.equal('test.cz'); expect(query['conf']).to.be.equal('11'); expect(query['conf_ver']).to.be.equal('7'); @@ -492,10 +492,10 @@ describe('r2b2 Analytics', function () { it('auction init content', (done) => { fireEvents([[AUCTION_INIT, MOCK.AUCTION_INIT]]); setTimeout(() => { - let events = validateAndExtractEvents(ajaxStub); - let initEvents = getPrebidEventsByName(events, 'init'); + const events = validateAndExtractEvents(ajaxStub); + const initEvents = getPrebidEventsByName(events, 'init'); expect(initEvents.length).to.be.equal(1); - let initEvent = initEvents[0]; + const initEvent = initEvents[0]; expect(initEvent.d).to.be.deep.equal({ ai: AUCTION_ID, u: { @@ -512,14 +512,14 @@ describe('r2b2 Analytics', function () { }) it('auction multiple init', (done) => { - let auction_init = MOCK.AUCTION_INIT; - let auction_init_2 = utils.deepClone(MOCK.AUCTION_INIT); + const auction_init = MOCK.AUCTION_INIT; + const auction_init_2 = utils.deepClone(MOCK.AUCTION_INIT); auction_init_2.auctionId = 'different_auction_id'; fireEvents([[AUCTION_INIT, auction_init], [AUCTION_INIT, auction_init_2]]); setTimeout(() => { - let events = validateAndExtractEvents(ajaxStub); - let initEvents = getPrebidEventsByName(events, 'init'); + const events = validateAndExtractEvents(ajaxStub); + const initEvents = getPrebidEventsByName(events, 'init'); expect(initEvents.length).to.be.equal(2); done(); }, 500); @@ -535,11 +535,11 @@ describe('r2b2 Analytics', function () { ]); setTimeout(() => { - let events = validateAndExtractEvents(ajaxStub); - let bidRequestedEvents = getPrebidEventsByName(events, 'request'); + const events = validateAndExtractEvents(ajaxStub); + const bidRequestedEvents = getPrebidEventsByName(events, 'request'); expect(bidRequestedEvents.length).to.be.equal(2); - let r2b2BidRequest = bidRequestedEvents[0]; - let adformBidRequest = bidRequestedEvents[1]; + const r2b2BidRequest = bidRequestedEvents[0]; + const adformBidRequest = bidRequestedEvents[1]; expect(r2b2BidRequest.d).to.be.deep.equal({ ai: AUCTION_ID, b: 'r2b2', @@ -567,10 +567,10 @@ describe('r2b2 Analytics', function () { ]); setTimeout(() => { - let events = validateAndExtractEvents(ajaxStub); - let noBidEvents = getPrebidEventsByName(events, 'noBid'); + const events = validateAndExtractEvents(ajaxStub); + const noBidEvents = getPrebidEventsByName(events, 'noBid'); expect(noBidEvents.length).to.be.equal(1); - let noBidEvent = noBidEvents[0]; + const noBidEvent = noBidEvents[0]; expect(noBidEvent.d).to.be.deep.equal({ ai: AUCTION_ID, b: 'r2b2', @@ -590,10 +590,10 @@ describe('r2b2 Analytics', function () { ]); setTimeout(() => { - let events = validateAndExtractEvents(ajaxStub); - let timeoutEvents = getPrebidEventsByName(events, 'timeout'); + const events = validateAndExtractEvents(ajaxStub); + const timeoutEvents = getPrebidEventsByName(events, 'timeout'); expect(timeoutEvents.length).to.be.equal(1); - let timeoutEvent = timeoutEvents[0]; + const timeoutEvent = timeoutEvents[0]; expect(timeoutEvent.d).to.be.deep.equal({ ai: AUCTION_ID, b: { @@ -614,10 +614,10 @@ describe('r2b2 Analytics', function () { ]); setTimeout(() => { - let events = validateAndExtractEvents(ajaxStub); - let bidderDoneEvents = getPrebidEventsByName(events, 'bidderDone'); + const events = validateAndExtractEvents(ajaxStub); + const bidderDoneEvents = getPrebidEventsByName(events, 'bidderDone'); expect(bidderDoneEvents.length).to.be.equal(1); - let bidderDoneEvent = bidderDoneEvents[0]; + const bidderDoneEvent = bidderDoneEvents[0]; expect(bidderDoneEvent.d).to.be.deep.equal({ ai: AUCTION_ID, b: 'r2b2' }); done(); @@ -633,10 +633,10 @@ describe('r2b2 Analytics', function () { ]); setTimeout(() => { - let events = validateAndExtractEvents(ajaxStub); - let auctionEndEvents = getPrebidEventsByName(events, 'auction'); + const events = validateAndExtractEvents(ajaxStub); + const auctionEndEvents = getPrebidEventsByName(events, 'auction'); expect(auctionEndEvents.length).to.be.equal(1); - let auctionEnd = auctionEndEvents[0]; + const auctionEnd = auctionEndEvents[0]; expect(auctionEnd.d).to.be.deep.equal({ ai: AUCTION_ID, wins: [{ @@ -662,7 +662,7 @@ describe('r2b2 Analytics', function () { }); it('auction end empty auction', (done) => { - let noBidderRequestsEnd = utils.deepClone(MOCK.AUCTION_END); + const noBidderRequestsEnd = utils.deepClone(MOCK.AUCTION_END); noBidderRequestsEnd.bidderRequests = []; fireEvents([ @@ -685,10 +685,10 @@ describe('r2b2 Analytics', function () { ]); setTimeout(() => { - let events = validateAndExtractEvents(ajaxStub); - let bidResponseEvents = getPrebidEventsByName(events, 'response'); + const events = validateAndExtractEvents(ajaxStub); + const bidResponseEvents = getPrebidEventsByName(events, 'response'); expect(bidResponseEvents.length).to.be.equal(1); - let bidResponseEvent = bidResponseEvents[0]; + const bidResponseEvent = bidResponseEvents[0]; expect(bidResponseEvent.d).to.be.deep.equal({ ai: AUCTION_ID, b: 'r2b2', @@ -710,7 +710,7 @@ describe('r2b2 Analytics', function () { }); it('bid rejected content', (done) => { - let rejectedBid = utils.deepClone(R2B2_AD_UNIT_2_BID); + const rejectedBid = utils.deepClone(R2B2_AD_UNIT_2_BID); rejectedBid.rejectionReason = REJECTION_REASON.FLOOR_NOT_MET; fireEvents([ @@ -719,10 +719,10 @@ describe('r2b2 Analytics', function () { ]); setTimeout(() => { - let events = validateAndExtractEvents(ajaxStub); - let rejectedBidsEvents = getPrebidEventsByName(events, 'reject'); + const events = validateAndExtractEvents(ajaxStub); + const rejectedBidsEvents = getPrebidEventsByName(events, 'reject'); expect(rejectedBidsEvents.length).to.be.equal(1); - let rejectedBidEvent = rejectedBidsEvents[0]; + const rejectedBidEvent = rejectedBidsEvents[0]; expect(rejectedBidEvent.d).to.be.deep.equal({ ai: AUCTION_ID, b: 'r2b2', @@ -746,10 +746,10 @@ describe('r2b2 Analytics', function () { ]); setTimeout(() => { - let events = validateAndExtractEvents(ajaxStub); - let bidWonEvents = getPrebidEventsByName(events, 'bidWon'); + const events = validateAndExtractEvents(ajaxStub); + const bidWonEvents = getPrebidEventsByName(events, 'bidWon'); expect(bidWonEvents.length).to.be.equal(1); - let bidWonEvent = bidWonEvents[0]; + const bidWonEvent = bidWonEvents[0]; expect(bidWonEvent.d).to.be.deep.equal({ ai: AUCTION_ID, b: 'r2b2', @@ -777,7 +777,7 @@ describe('r2b2 Analytics', function () { }); it('bid won content no targeting', (done) => { - let bidWonWithoutTargeting = utils.deepClone(MOCK.BID_WON); + const bidWonWithoutTargeting = utils.deepClone(MOCK.BID_WON); bidWonWithoutTargeting.adserverTargeting = {}; fireEvents([ @@ -786,10 +786,10 @@ describe('r2b2 Analytics', function () { ]); setTimeout(() => { - let events = validateAndExtractEvents(ajaxStub); - let bidWonEvents = getPrebidEventsByName(events, 'bidWon'); + const events = validateAndExtractEvents(ajaxStub); + const bidWonEvents = getPrebidEventsByName(events, 'bidWon'); expect(bidWonEvents.length).to.be.equal(1); - let bidWonEvent = bidWonEvents[0]; + const bidWonEvent = bidWonEvents[0]; expect(bidWonEvent.d).to.be.deep.equal({ ai: AUCTION_ID, b: 'r2b2', @@ -824,8 +824,8 @@ describe('r2b2 Analytics', function () { ]); setTimeout(() => { - let events = validateAndExtractEvents(ajaxStub); - let setTargetingEvents = getPrebidEventsByName(events, 'targeting'); + const events = validateAndExtractEvents(ajaxStub); + const setTargetingEvents = getPrebidEventsByName(events, 'targeting'); expect(setTargetingEvents.length).to.be.equal(1); expect(setTargetingEvents[0].d).to.be.deep.equal({ ai: AUCTION_ID, @@ -853,10 +853,10 @@ describe('r2b2 Analytics', function () { ]); setTimeout(() => { - let events = validateAndExtractEvents(ajaxStub); - let setTargetingEvents = getPrebidEventsByName(events, 'render'); + const events = validateAndExtractEvents(ajaxStub); + const setTargetingEvents = getPrebidEventsByName(events, 'render'); expect(setTargetingEvents.length).to.be.equal(1); - let setTargeting = setTargetingEvents[0]; + const setTargeting = setTargetingEvents[0]; expect(setTargeting.d).to.be.deep.equal({ ai: AUCTION_ID, b: 'r2b2', @@ -882,10 +882,10 @@ describe('r2b2 Analytics', function () { ]); setTimeout(() => { - let events = validateAndExtractEvents(ajaxStub); - let renderFailedEvents = getPrebidEventsByName(events, 'renderFail'); + const events = validateAndExtractEvents(ajaxStub); + const renderFailedEvents = getPrebidEventsByName(events, 'renderFail'); expect(renderFailedEvents.length).to.be.equal(1); - let renderFailed = renderFailedEvents[0]; + const renderFailed = renderFailedEvents[0]; expect(renderFailed.d).to.be.deep.equal({ ai: AUCTION_ID, b: 'r2b2', @@ -909,10 +909,10 @@ describe('r2b2 Analytics', function () { ]); setTimeout(() => { - let events = validateAndExtractEvents(ajaxStub); - let staleRenderEvents = getPrebidEventsByName(events, 'staleRender'); + const events = validateAndExtractEvents(ajaxStub); + const staleRenderEvents = getPrebidEventsByName(events, 'staleRender'); expect(staleRenderEvents.length).to.be.equal(1); - let staleRenderEvent = staleRenderEvents[0]; + const staleRenderEvent = staleRenderEvents[0]; expect(staleRenderEvent.d).to.be.deep.equal({ ai: AUCTION_ID, b: 'r2b2', @@ -929,7 +929,7 @@ describe('r2b2 Analytics', function () { }); it('bid viewable content', (done) => { - let dateStub = sandbox.stub(Date, 'now'); + const dateStub = sandbox.stub(Date, 'now'); dateStub.returns(100); fireEvents([ @@ -943,10 +943,10 @@ describe('r2b2 Analytics', function () { fireEvents([[BID_VIEWABLE, MOCK.BID_VIEWABLE]]); setTimeout(() => { - let events = validateAndExtractEvents(ajaxStub); - let bidViewableEvents = getPrebidEventsByName(events, 'view'); + const events = validateAndExtractEvents(ajaxStub); + const bidViewableEvents = getPrebidEventsByName(events, 'view'); expect(bidViewableEvents.length).to.be.equal(1); - let bidViewableEvent = bidViewableEvents[0]; + const bidViewableEvent = bidViewableEvents[0]; expect(bidViewableEvent.d).to.be.deep.equal({ ai: AUCTION_ID, b: 'r2b2', @@ -970,7 +970,7 @@ describe('r2b2 Analytics', function () { setTimeout(() => { expect(ajaxStub.calledOnce).to.be.true; expect(typeof ajaxStub.firstCall.args[0]).to.be.equal('string'); - let query = getQueryData(ajaxStub.firstCall.args[0], true); + const query = getQueryData(ajaxStub.firstCall.args[0], true); expect(typeof query.m).to.be.equal('string'); expect(query.m.indexOf('No auction data when creating event')).to.not.be.equal(-1); @@ -981,9 +981,9 @@ describe('r2b2 Analytics', function () { }); it('empty auction', (done) => { - let emptyAuctionInit = utils.deepClone(MOCK.AUCTION_INIT); + const emptyAuctionInit = utils.deepClone(MOCK.AUCTION_INIT); emptyAuctionInit.bidderRequests = undefined; - let emptyAuctionEnd = utils.deepClone(MOCK.AUCTION_END); + const emptyAuctionEnd = utils.deepClone(MOCK.AUCTION_END); emptyAuctionEnd.bidderRequests = []; fireEvents([ @@ -993,9 +993,9 @@ describe('r2b2 Analytics', function () { setTimeout(() => { expect(ajaxStub.calledOnce).to.be.true; - let events = validateAndExtractEvents(ajaxStub); - let initEvents = getPrebidEventsByName(events, 'init'); - let auctionEndEvents = getPrebidEventsByName(events, 'auction'); + const events = validateAndExtractEvents(ajaxStub); + const initEvents = getPrebidEventsByName(events, 'init'); + const auctionEndEvents = getPrebidEventsByName(events, 'auction'); expect(initEvents.length).to.be.equal(1); expect(auctionEndEvents.length).to.be.equal(0); diff --git a/test/spec/modules/r2b2BidAdapter_spec.js b/test/spec/modules/r2b2BidAdapter_spec.js index f9040798abc..29134e7c3a3 100644 --- a/test/spec/modules/r2b2BidAdapter_spec.js +++ b/test/spec/modules/r2b2BidAdapter_spec.js @@ -11,11 +11,11 @@ describe('R2B2 adapter', function () { let serverResponse, requestForInterpretResponse; let bidderRequest; let bids = []; - let gdprConsent = { + const gdprConsent = { gdprApplies: true, consentString: 'consent-string', }; - let schain = { + const schain = { ver: '1.0', complete: 1, nodes: [{ @@ -199,7 +199,7 @@ describe('R2B2 adapter', function () { }); describe('isBidRequestValid', function () { - let bid = {}; + const bid = {}; it('should return false when missing required "pid" param', function () { bid.params = {random: 'param'}; @@ -258,9 +258,9 @@ describe('R2B2 adapter', function () { }); it('should set correct request method and url and pass bids', function () { - let requests = spec.buildRequests([bids[0]], bidderRequest); + const requests = spec.buildRequests([bids[0]], bidderRequest); expect(requests).to.be.an('array').that.has.lengthOf(1); - let request = requests[0] + const request = requests[0] expect(request.method).to.equal('POST'); expect(request.url).to.equal('https://hb.r2b2.cz/openrtb2/bid'); expect(request.data).to.be.an('object'); @@ -268,9 +268,9 @@ describe('R2B2 adapter', function () { }); it('should pass correct parameters', function () { - let requests = spec.buildRequests([bids[0]], bidderRequest); - let {data} = requests[0]; - let {imp, device, site, source, ext, cur, test} = data; + const requests = spec.buildRequests([bids[0]], bidderRequest); + const {data} = requests[0]; + const {imp, device, site, source, ext, cur, test} = data; expect(imp).to.be.an('array').that.has.lengthOf(1); expect(device).to.be.an('object'); expect(site).to.be.an('object'); @@ -281,12 +281,12 @@ describe('R2B2 adapter', function () { }); it('should pass correct imp', function () { - let requests = spec.buildRequests([bids[0]], bidderRequest); - let {data} = requests[0]; - let {imp} = data; + const requests = spec.buildRequests([bids[0]], bidderRequest); + const {data} = requests[0]; + const {imp} = data; expect(imp).to.be.an('array').that.has.lengthOf(1); expect(imp[0]).to.be.an('object'); - let bid = imp[0]; + const bid = imp[0]; expect(bid.id).to.equal('20917a54ee9858'); expect(bid.banner).to.deep.equal({topframe: 0, format: [{w: 300, h: 250}]}); expect(bid.ext).to.be.an('object'); @@ -295,10 +295,10 @@ describe('R2B2 adapter', function () { it('should map type correctly', function () { let result, bid; - let requestWithId = function(id) { - let b = bids[0]; + const requestWithId = function(id) { + const b = bids[0]; b.params.pid = id; - let passedBids = [b]; + const passedBids = [b]; bidderRequest.bids = passedBids; return spec.buildRequests(passedBids, bidderRequest); }; @@ -329,34 +329,34 @@ describe('R2B2 adapter', function () { }); it('should pass correct parameters for test ad', function () { - let testAdBid = bids[0]; + const testAdBid = bids[0]; testAdBid.params = {pid: 'selfpromo'}; - let requests = spec.buildRequests([testAdBid], bidderRequest); - let {data} = requests[0]; - let {imp} = data; + const requests = spec.buildRequests([testAdBid], bidderRequest); + const {data} = requests[0]; + const {imp} = data; expect(imp).to.be.an('array').that.has.lengthOf(1); expect(imp[0]).to.be.an('object'); - let bid = imp[0]; + const bid = imp[0]; expect(bid.ext).to.be.an('object'); expect(bid.ext.r2b2).to.deep.equal({d: 'test', g: 'test', p: 'selfpromo', m: 0, 'selfpromo': 1}); }); it('should pass multiple bids', function () { - let requests = spec.buildRequests(bids, bidderRequest); + const requests = spec.buildRequests(bids, bidderRequest); expect(requests).to.be.an('array').that.has.lengthOf(1); - let {data} = requests[0]; - let {imp} = data; + const {data} = requests[0]; + const {imp} = data; expect(imp).to.be.an('array').that.has.lengthOf(bids.length); - let bid1 = imp[0]; + const bid1 = imp[0]; expect(bid1.ext.r2b2).to.deep.equal({d: 'example.com', g: 'generic', p: '300x250', m: 1}); - let bid2 = imp[1]; + const bid2 = imp[1]; expect(bid2.ext.r2b2).to.deep.equal({d: 'example.com', g: 'generic', p: '300x600', m: 0}); }); it('should set up internal variables', function () { - let requests = spec.buildRequests(bids, bidderRequest); - let bid1Id = bids[0].bidId; - let bid2Id = bids[1].bidId; + const requests = spec.buildRequests(bids, bidderRequest); + const bid1Id = bids[0].bidId; + const bid2Id = bids[1].bidId; expect(r2b2.placementsToSync).to.be.an('array').that.has.lengthOf(2); expect(r2b2.mappedParams).to.have.property(bid1Id); expect(r2b2.mappedParams[bid1Id]).to.deep.equal({d: 'example.com', g: 'generic', p: '300x250', m: 1, pid: 'example.com/generic/300x250/1'}); @@ -365,9 +365,9 @@ describe('R2B2 adapter', function () { }); it('should pass gdpr properties', function () { - let requests = spec.buildRequests(bids, bidderRequest); - let {data} = requests[0]; - let {user, regs} = data; + const requests = spec.buildRequests(bids, bidderRequest); + const {data} = requests[0]; + const {user, regs} = data; expect(user).to.be.an('object').that.has.property('ext'); expect(regs).to.be.an('object').that.has.property('ext'); expect(user.ext.consent).to.equal('consent-string'); @@ -375,17 +375,17 @@ describe('R2B2 adapter', function () { }); it('should pass us privacy properties', function () { - let requests = spec.buildRequests(bids, bidderRequest); - let {data} = requests[0]; - let {regs} = data; + const requests = spec.buildRequests(bids, bidderRequest); + const {data} = requests[0]; + const {regs} = data; expect(regs).to.be.an('object').that.has.property('ext'); expect(regs.ext.us_privacy).to.equal('1YYY'); }); it('should pass supply chain', function () { - let requests = spec.buildRequests(bids, bidderRequest); - let {data} = requests[0]; - let {source} = data; + const requests = spec.buildRequests(bids, bidderRequest); + const {data} = requests[0]; + const {source} = data; expect(source).to.be.an('object').that.has.property('ext'); expect(source.ext.schain).to.deep.equal({ complete: 1, @@ -397,7 +397,7 @@ describe('R2B2 adapter', function () { }); it('should pass extended ids', function () { - let eidsArray = [ + const eidsArray = [ { source: 'adserver.org', uids: [ @@ -421,9 +421,9 @@ describe('R2B2 adapter', function () { }, ]; bidderRequest.ortb2 = {user: {ext: {eids: eidsArray}}} - let requests = spec.buildRequests(bids, bidderRequest); - let request = requests[0]; - let eids = request.data.user.ext.eids; + const requests = spec.buildRequests(bids, bidderRequest); + const request = requests[0]; + const eids = request.data.user.ext.eids; expect(eids).to.deep.equal(eidsArray); }); @@ -442,9 +442,9 @@ describe('R2B2 adapter', function () { }); it('should map params correctly', function () { - let result = spec.interpretResponse({ body: serverResponse }, requestForInterpretResponse); + const result = spec.interpretResponse({ body: serverResponse }, requestForInterpretResponse); expect(result).to.be.an('array').that.has.lengthOf(1); - let bid = result[0]; + const bid = result[0]; expect(bid.requestId).to.equal(impId); expect(bid.cpm).to.equal(price); expect(bid.ad).to.equal(ad); @@ -458,23 +458,23 @@ describe('R2B2 adapter', function () { }); it('should set up renderer on bid', function () { - let result = spec.interpretResponse({ body: serverResponse }, requestForInterpretResponse); + const result = spec.interpretResponse({ body: serverResponse }, requestForInterpretResponse); expect(result).to.be.an('array').that.has.lengthOf(1); - let bid = result[0]; + const bid = result[0]; expect(bid.renderer).to.be.an('object'); expect(bid.renderer).to.have.property('render').that.is.a('function'); expect(bid.renderer).to.have.property('url').that.is.a('string'); }); it('should map ext params correctly', function() { - let dgpm = {something: 'something'}; + const dgpm = {something: 'something'}; r2b2.mappedParams = {}; r2b2.mappedParams[impId] = dgpm; - let result = spec.interpretResponse({ body: serverResponse }, requestForInterpretResponse); + const result = spec.interpretResponse({ body: serverResponse }, requestForInterpretResponse); expect(result).to.be.an('array').that.has.lengthOf(1); - let bid = result[0]; + const bid = result[0]; expect(bid.ext).to.be.an('object'); - let { ext } = bid; + const { ext } = bid; expect(ext.dgpm).to.deep.equal(dgpm); expect(ext.cid).to.equal(cid); expect(ext.cdid).to.equal(cdid); @@ -499,8 +499,8 @@ describe('R2B2 adapter', function () { const ad2 = 'gaeouho'; const w2 = 300; const h2 = 600; - let b = serverResponse.seatbid[0].bid[0]; - let b2 = Object.assign({}, b); + const b = serverResponse.seatbid[0].bid[0]; + const b2 = Object.assign({}, b); b2.impid = impId2; b2.price = price2; b2.adm = ad2; @@ -508,10 +508,10 @@ describe('R2B2 adapter', function () { b2.h = h2; serverResponse.seatbid[0].bid.push(b2); requestForInterpretResponse.data.imp.push({id: impId2}); - let result = spec.interpretResponse({ body: serverResponse }, requestForInterpretResponse); + const result = spec.interpretResponse({ body: serverResponse }, requestForInterpretResponse); expect(result).to.be.an('array').that.has.lengthOf(2); - let firstBid = result[0]; - let secondBid = result[1]; + const firstBid = result[0]; + const secondBid = result[1]; expect(firstBid.requestId).to.equal(impId); expect(firstBid.ad).to.equal(ad); expect(firstBid.cpm).to.equal(price); diff --git a/test/spec/modules/rakutenBidAdapter_spec.js b/test/spec/modules/rakutenBidAdapter_spec.js index 2a9fcb9f83b..e6cdb12e31d 100644 --- a/test/spec/modules/rakutenBidAdapter_spec.js +++ b/test/spec/modules/rakutenBidAdapter_spec.js @@ -23,7 +23,7 @@ describe('rakutenBidAdapter', function() { }); describe('isBidRequestValid', () => { - let bid = { + const bid = { bidder: 'rakuten', params: { adSpotId: '56789' @@ -40,7 +40,7 @@ describe('rakutenBidAdapter', function() { }); it('should return false when required params are not passed', () => { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = {}; expect(spec.isBidRequestValid(invalidBid)).to.equal(false) diff --git a/test/spec/modules/realTimeDataModule_spec.js b/test/spec/modules/realTimeDataModule_spec.js index 4e21f88ac08..4a7f13112c5 100644 --- a/test/spec/modules/realTimeDataModule_spec.js +++ b/test/spec/modules/realTimeDataModule_spec.js @@ -182,7 +182,7 @@ describe('Real time module', function () { ] }; validSM.getTargetingData = (adUnits) => { - let targeting = {'module1': 'targeting'} + const targeting = {'module1': 'targeting'} return { ad1: targeting, ad2: targeting diff --git a/test/spec/modules/redtramBidAdapter_spec.js b/test/spec/modules/redtramBidAdapter_spec.js index e136c37962b..45d2b08a51f 100644 --- a/test/spec/modules/redtramBidAdapter_spec.js +++ b/test/spec/modules/redtramBidAdapter_spec.js @@ -48,7 +48,7 @@ describe('RedtramBidAdapter', function () { expect(serverRequest.url).to.equal('https://prebid.redtram.com/pbjs'); }); it('Returns valid data if array of bids is valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys('deviceWidth', 'deviceHeight', 'language', 'host', 'page', 'placements'); expect(data.deviceWidth).to.be.a('number'); @@ -58,7 +58,7 @@ describe('RedtramBidAdapter', function () { expect(data.page).to.be.a('string'); expect(data.gdpr).to.not.exist; expect(data.ccpa).to.not.exist; - let placement = data['placements'][0]; + const placement = data['placements'][0]; expect(placement).to.have.keys('placementId', 'bidId', 'adFormat', 'sizes', 'schain', 'bidfloor'); expect(placement.placementId).to.equal(23611); expect(placement.bidId).to.equal('23dc19818e5293'); @@ -71,7 +71,7 @@ describe('RedtramBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { bidderRequest.gdprConsent = 'test'; serverRequest = spec.buildRequests([bid], bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('string'); expect(data.gdpr).to.equal(bidderRequest.gdprConsent); @@ -82,7 +82,7 @@ describe('RedtramBidAdapter', function () { it('Returns data with uspConsent and without gdprConsent', function () { bidderRequest.uspConsent = 'test'; serverRequest = spec.buildRequests([bid], bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -91,7 +91,7 @@ describe('RedtramBidAdapter', function () { it('Returns empty data if no valid requests are passed', function () { serverRequest = spec.buildRequests([]); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.placements).to.be.an('array').that.is.empty; }); }); @@ -113,9 +113,9 @@ describe('RedtramBidAdapter', function () { meta: {} }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23dc19818e5293'); @@ -144,7 +144,7 @@ describe('RedtramBidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -157,7 +157,7 @@ describe('RedtramBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/relaidoBidAdapter_spec.js b/test/spec/modules/relaidoBidAdapter_spec.js index a61b4fd19bf..da3584a2de0 100644 --- a/test/spec/modules/relaidoBidAdapter_spec.js +++ b/test/spec/modules/relaidoBidAdapter_spec.js @@ -356,7 +356,7 @@ describe('RelaidoAdapter', function () { it('should get canonicalUrl (ogUrl:true)', function () { bidRequest.params.ogUrl = true; bidderRequest.refererInfo.canonicalUrl = null; - let documentStub = sandbox.stub(window.top.document, 'querySelector'); + const documentStub = sandbox.stub(window.top.document, 'querySelector'); documentStub.withArgs('meta[property="og:url"]').returns({ content: 'http://localhost:9999/fb-test' }); @@ -370,7 +370,7 @@ describe('RelaidoAdapter', function () { it('should not get canonicalUrl (ogUrl:false)', function () { bidRequest.params.ogUrl = false; bidderRequest.refererInfo.canonicalUrl = null; - let documentStub = sandbox.stub(window.top.document, 'querySelector'); + const documentStub = sandbox.stub(window.top.document, 'querySelector'); documentStub.withArgs('meta[property="og:url"]').returns({ content: 'http://localhost:9999/fb-test' }); @@ -383,7 +383,7 @@ describe('RelaidoAdapter', function () { it('should not get canonicalUrl (ogUrl:nothing)', function () { bidderRequest.refererInfo.canonicalUrl = null; - let documentStub = sandbox.stub(window.top.document, 'querySelector'); + const documentStub = sandbox.stub(window.top.document, 'querySelector'); documentStub.withArgs('meta[property="og:url"]').returns({ content: 'http://localhost:9999/fb-test' }); @@ -483,7 +483,7 @@ describe('RelaidoAdapter', function () { describe('spec.getUserSyncs', function () { it('should choose iframe sync urls', function () { - let userSyncs = spec.getUserSyncs({iframeEnabled: true}, [serverResponse]); + const userSyncs = spec.getUserSyncs({iframeEnabled: true}, [serverResponse]); expect(userSyncs).to.deep.equal([{ type: 'iframe', url: serverResponse.body.syncUrl + '?uu=hogehoge' @@ -491,7 +491,7 @@ describe('RelaidoAdapter', function () { }); it('should choose iframe sync urls if serverResponse are empty', function () { - let userSyncs = spec.getUserSyncs({iframeEnabled: true}, []); + const userSyncs = spec.getUserSyncs({iframeEnabled: true}, []); expect(userSyncs).to.deep.equal([{ type: 'iframe', url: 'https://api.relaido.jp/tr/v1/prebid/sync.html?uu=hogehoge' @@ -500,7 +500,7 @@ describe('RelaidoAdapter', function () { it('should choose iframe sync urls if syncUrl are undefined', function () { serverResponse.body.syncUrl = undefined; - let userSyncs = spec.getUserSyncs({iframeEnabled: true}, [serverResponse]); + const userSyncs = spec.getUserSyncs({iframeEnabled: true}, [serverResponse]); expect(userSyncs).to.deep.equal([{ type: 'iframe', url: 'https://api.relaido.jp/tr/v1/prebid/sync.html?uu=hogehoge' @@ -508,14 +508,14 @@ describe('RelaidoAdapter', function () { }); it('should return empty if iframeEnabled are false', function () { - let userSyncs = spec.getUserSyncs({iframeEnabled: false}, [serverResponse]); + const userSyncs = spec.getUserSyncs({iframeEnabled: false}, [serverResponse]); expect(userSyncs).to.have.lengthOf(0); }); }); describe('spec.onBidWon', function () { it('Should create nurl pixel if bid nurl', function () { - let bid = { + const bid = { bidder: bidRequest.bidder, creativeId: serverResponse.body.ads[0].creativeId, cpm: serverResponse.body.ads[0].price, diff --git a/test/spec/modules/relevadRtdProvider_spec.js b/test/spec/modules/relevadRtdProvider_spec.js index 31c3700bd24..c535bf6ad98 100644 --- a/test/spec/modules/relevadRtdProvider_spec.js +++ b/test/spec/modules/relevadRtdProvider_spec.js @@ -73,13 +73,13 @@ describe('relevadRtdProvider', function() { describe('Add segments and categories test 1', function() { it('adds contextual categories and segments', function() { - let moduleConfig = { ...deepClone(moduleConfigCommon) }; - let reqBids = { + const moduleConfig = { ...deepClone(moduleConfigCommon) }; + const reqBids = { ...deepClone(reqBidsCommon), 'adUnits': deepClone(adUnitsCommon), }; - let data = { + const data = { segments: ['segment1', 'segment2'], cats: { 'category3': 100 }, }; @@ -99,13 +99,13 @@ describe('relevadRtdProvider', function() { describe('Add segments and categories test 2 to one bidder out of many', function() { it('adds contextual categories and segments', function() { - let moduleConfig = { ...deepClone(moduleConfigCommon) }; - let reqBids = { + const moduleConfig = { ...deepClone(moduleConfigCommon) }; + const reqBids = { ...deepClone(reqBidsCommon), 'adUnits': deepClone(adUnitsCommon), }; - let data = { + const data = { segments: ['segment1', 'segment2'], cats: { 'category3': 100 }, wl: { 'appnexus': { 'placementId': '13144370' } }, @@ -127,7 +127,7 @@ describe('relevadRtdProvider', function() { describe('Add segments and categories test 4', function() { it('adds contextual categories and segments', function() { - let moduleConfig = { + const moduleConfig = { 'dryrun': true, params: { setgpt: true, @@ -136,7 +136,7 @@ describe('relevadRtdProvider', function() { } }; - let reqBids = { + const reqBids = { 'timeout': 10000, 'adUnits': deepClone(adUnitsCommon), 'adUnitCodes': [ '/19968336/header-bid-tag-0' ], @@ -163,7 +163,7 @@ describe('relevadRtdProvider', function() { 'defer': { 'promise': {} } } - let data = { + const data = { segments: ['segment1', 'segment2'], cats: {'category3': 100} }; @@ -185,7 +185,7 @@ describe('relevadRtdProvider', function() { } }; - let reqBidsConfigObj = { + const reqBidsConfigObj = { adUnits: [{ bids: [{ bidder: 'appnexus', @@ -198,14 +198,14 @@ describe('relevadRtdProvider', function() { }] }; - let data = { + const data = { segments: ['segment1', 'segment2'], cats: {'category3': 100} }; getBidRequestData(reqBidsConfigObj, () => {}, moduleConfig, {}); - let request = server.requests[0]; + const request = server.requests[0]; request.respond(200, responseHeader, JSON.stringify(data)); expect(reqBidsConfigObj.adUnits[0].bids[0].params.keywords).to.have.deep.property('relevad_rtd', ['segment1', 'segment2', 'category3']); @@ -376,9 +376,9 @@ describe('Process auction end data', function() { 'userConsent': { 'gdpr': null, 'usp': null, 'gpp': null, 'coppa': false } }; - let auctionDetails = auctionEndData['auctionDetails']; - let userConsent = auctionEndData['userConsent']; - let moduleConfig = auctionEndData['config']; + const auctionDetails = auctionEndData['auctionDetails']; + const userConsent = auctionEndData['userConsent']; + const moduleConfig = auctionEndData['config']; relevadSubmodule.onAuctionEndEvent(auctionDetails, moduleConfig, userConsent); expect(serverData.clientdata).to.deep.equal( diff --git a/test/spec/modules/relevatehealthBidAdapter_spec.js b/test/spec/modules/relevatehealthBidAdapter_spec.js index be830827921..8d7d7cafb41 100644 --- a/test/spec/modules/relevatehealthBidAdapter_spec.js +++ b/test/spec/modules/relevatehealthBidAdapter_spec.js @@ -82,7 +82,7 @@ describe('relevatehealth adapter', function() { describe('validations', function() { it('isBidValid : placement_id is passed', function() { - let bid = { + const bid = { bidder: 'relevatehealth', params: { placement_id: 110011 @@ -92,7 +92,7 @@ describe('relevatehealth adapter', function() { expect(isValid).to.equals(true); }); it('isBidValid : placement_id is not passed', function() { - let bid = { + const bid = { bidder: 'relevatehealth', params: { width: 160, @@ -107,47 +107,47 @@ describe('relevatehealth adapter', function() { }); describe('Validate Request', function() { it('Immutable bid request validate', function() { - let _Request = utils.deepClone(request), + const _Request = utils.deepClone(request), bidRequest = spec.buildRequests(request); expect(request).to.deep.equal(_Request); }); it('Validate bidder connection', function() { - let _Request = spec.buildRequests(request); + const _Request = spec.buildRequests(request); expect(_Request.url).to.equal('https://rtb.relevate.health/prebid/relevate'); expect(_Request.method).to.equal('POST'); expect(_Request.options.contentType).to.equal('application/json'); }); it('Validate bid request : Impression', function() { - let _Request = spec.buildRequests(request); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(request); + const data = JSON.parse(_Request.data); expect(data[0].imp[0].id).to.equal(request[0].bidId); expect(data[0].placementId).to.equal(110011); }); it('Validate bid request : ad size', function() { - let _Request = spec.buildRequests(request); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(request); + const data = JSON.parse(_Request.data); expect(data[0].imp[0].banner).to.be.a('object'); expect(data[0].imp[0].banner.w).to.equal(160); expect(data[0].imp[0].banner.h).to.equal(600); }); it('Validate bid request : user object', function() { - let _Request = spec.buildRequests(request); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(request); + const data = JSON.parse(_Request.data); expect(data[0].user).to.be.a('object'); expect(data[0].user.id).to.be.a('string'); }); it('Validate bid request : CCPA Check', function() { - let bidRequest = { + const bidRequest = { uspConsent: '1NYN' }; - let _Request = spec.buildRequests(request, bidRequest); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(request, bidRequest); + const data = JSON.parse(_Request.data); expect(data[0].regs.ext.us_privacy).to.equal('1NYN'); }); }); describe('Validate response ', function() { it('Validate bid response : valid bid response', function() { - let bResponse = spec.interpretResponse(bannerResponse, request); + const bResponse = spec.interpretResponse(bannerResponse, request); expect(bResponse).to.be.an('array').with.length.above(0); expect(bResponse[0].requestId).to.equal(bannerResponse.body.seatbid[0].bid[0].impid); expect(bResponse[0].width).to.equal(bannerResponse.body.seatbid[0].bid[0].w); @@ -161,26 +161,26 @@ describe('relevatehealth adapter', function() { expect(bResponse[0].dealId).to.equal(bannerResponse.body.seatbid[0].bid[0].dealId); }); it('Invalid bid response check ', function() { - let bRequest = spec.buildRequests(request); - let response = spec.interpretResponse(invalidResponse, bRequest); + const bRequest = spec.buildRequests(request); + const response = spec.interpretResponse(invalidResponse, bRequest); expect(response[0].ad).to.equal('invalid response'); }); }); describe('GPP and coppa', function() { it('Request params check with GPP Consent', function() { - let bidderReq = { + const bidderReq = { gppConsent: { gppString: 'gpp-string-test', applicableSections: [5] } }; - let _Request = spec.buildRequests(request, bidderReq); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(request, bidderReq); + const data = JSON.parse(_Request.data); expect(data[0].regs.gpp).to.equal('gpp-string-test'); expect(data[0].regs.gpp_sid[0]).to.equal(5); }); it('Request params check with GPP Consent read from ortb2', function() { - let bidderReq = { + const bidderReq = { ortb2: { regs: { gpp: 'gpp-test-string', @@ -188,21 +188,21 @@ describe('relevatehealth adapter', function() { } } }; - let _Request = spec.buildRequests(request, bidderReq); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(request, bidderReq); + const data = JSON.parse(_Request.data); expect(data[0].regs.gpp).to.equal('gpp-test-string'); expect(data[0].regs.gpp_sid[0]).to.equal(5); }); it(' Bid request should have coppa flag if its true', () => { - let bidderReq = { + const bidderReq = { ortb2: { regs: { coppa: 1 } } }; - let _Request = spec.buildRequests(request, bidderReq); - let data = JSON.parse(_Request.data); + const _Request = spec.buildRequests(request, bidderReq); + const data = JSON.parse(_Request.data); expect(data[0].regs.coppa).to.equal(1); }); }); diff --git a/test/spec/modules/resetdigitalBidAdapter_spec.js b/test/spec/modules/resetdigitalBidAdapter_spec.js index 34354ceeea8..9c05c5af1d8 100644 --- a/test/spec/modules/resetdigitalBidAdapter_spec.js +++ b/test/spec/modules/resetdigitalBidAdapter_spec.js @@ -39,7 +39,7 @@ const vr = { describe('resetdigitalBidAdapter', function () { const adapter = newBidder(spec) - let bannerRequest = { + const bannerRequest = { bidId: '123', transactionId: '456', mediaTypes: { @@ -52,7 +52,7 @@ describe('resetdigitalBidAdapter', function () { } } - let videoRequest = { + const videoRequest = { bidId: 'abc', transactionId: 'def', mediaTypes: { @@ -82,7 +82,7 @@ describe('resetdigitalBidAdapter', function () { }) describe('buildRequests', function () { - let req = spec.buildRequests([ bannerRequest ], { refererInfo: { } }) + const req = spec.buildRequests([ bannerRequest ], { refererInfo: { } }) let rdata it('should return request object', function () { @@ -109,11 +109,11 @@ describe('resetdigitalBidAdapter', function () { describe('interpretResponse', function () { it('should form compliant banner bid object response', function () { - let ir = spec.interpretResponse(br, bannerRequest) + const ir = spec.interpretResponse(br, bannerRequest) expect(ir.length).to.equal(1) - let en = ir[0] + const en = ir[0] expect(en.requestId != null && en.cpm != null && typeof en.cpm === 'number' && @@ -124,11 +124,11 @@ describe('resetdigitalBidAdapter', function () { ).to.be.true }) it('should form compliant video object response', function () { - let ir = spec.interpretResponse(vr, videoRequest) + const ir = spec.interpretResponse(vr, videoRequest) expect(ir.length).to.equal(1) - let en = ir[0] + const en = ir[0] expect(en.requestId != null && en.cpm != null && typeof en.cpm === 'number' && @@ -142,14 +142,14 @@ describe('resetdigitalBidAdapter', function () { describe('getUserSyncs', function () { it('should return iframe sync', function () { - let sync = spec.getUserSyncs({ iframeEnabled: true }, [br]) + const sync = spec.getUserSyncs({ iframeEnabled: true }, [br]) expect(sync.length).to.equal(1) expect(sync[0].type === 'iframe') expect(typeof sync[0].url === 'string') }) it('should return pixel sync', function () { - let sync = spec.getUserSyncs({ pixelEnabled: true }, [br]) + const sync = spec.getUserSyncs({ pixelEnabled: true }, [br]) expect(sync.length).to.equal(1) expect(sync[0].type === 'image') expect(typeof sync[0].url === 'string') diff --git a/test/spec/modules/retailspotBidAdapter_spec.js b/test/spec/modules/retailspotBidAdapter_spec.js index c5cb001c1ba..7e693c7973d 100644 --- a/test/spec/modules/retailspotBidAdapter_spec.js +++ b/test/spec/modules/retailspotBidAdapter_spec.js @@ -255,7 +255,7 @@ describe('RetailSpot Adapter', function () { }); describe('isBidRequestValid', function () { - let bid = { + const bid = { 'bidId': 'bid_id_1', 'bidder': 'retailspot', 'placementCode': 'adunit/hb-1', @@ -266,7 +266,7 @@ describe('RetailSpot Adapter', function () { 'transactionId': 'bid_id_1_transaction_id' }; - let bidWSize = { + const bidWSize = { 'bidId': 'bid_id_1', 'bidder': 'retailspot', 'placementCode': 'adunit/hb-1', @@ -286,14 +286,14 @@ describe('RetailSpot Adapter', function () { }); it('should return false when required params are not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.sizes; expect(!!spec.isBidRequestValid(invalidBid)).to.equal(false); }); it('should return false when required params are not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = { 'placement': 0 @@ -304,9 +304,9 @@ describe('RetailSpot Adapter', function () { describe('buildRequests', function () { it('should add gdpr/usp consent information to the request', function () { - let consentString = 'BOJ8RZsOJ8RZsABAB8AAAAAZ+A=='; - let uspConsentData = '1YCC'; - let bidderRequest = { + const consentString = 'BOJ8RZsOJ8RZsABAB8AAAAAZ+A=='; + const uspConsentData = '1YCC'; + const bidderRequest = { 'auctionId': '1d1a030790a475', 'bidderRequestId': '22edbae2733bf6', 'timeout': 3000, @@ -377,18 +377,18 @@ describe('RetailSpot Adapter', function () { }); it('handles nobid responses', function () { - let response = [{ + const response = [{ requestId: '123dfsdf', placement: '12df1' }]; serverResponse.body = response; - let result = spec.interpretResponse(serverResponse, []); + const result = spec.interpretResponse(serverResponse, []); expect(result).deep.equal([]); }); it('receive reponse with single placement', function () { serverResponse.body = responseWithSinglePlacement; - let result = spec.interpretResponse(serverResponse, {data: '{"bids":' + JSON.stringify(requestDataOnePlacement) + '}'}); + const result = spec.interpretResponse(serverResponse, {data: '{"bids":' + JSON.stringify(requestDataOnePlacement) + '}'}); expect(result.length).to.equal(1); expect(result[0].cpm).to.equal(0.5); @@ -400,7 +400,7 @@ describe('RetailSpot Adapter', function () { it('receive reponse with multiple placement', function () { serverResponse.body = responseWithMultiplePlacements; - let result = spec.interpretResponse(serverResponse, {data: '{"bids":' + JSON.stringify(requestDataMultiPlacement) + '}'}); + const result = spec.interpretResponse(serverResponse, {data: '{"bids":' + JSON.stringify(requestDataMultiPlacement) + '}'}); expect(result.length).to.equal(2); @@ -417,7 +417,7 @@ describe('RetailSpot Adapter', function () { it('receive Vast reponse with Video ad', function () { serverResponse.body = responseWithSingleVideo; - let result = spec.interpretResponse(serverResponse, {data: '{"bids":' + JSON.stringify(sentBidVideo) + '}'}); + const result = spec.interpretResponse(serverResponse, {data: '{"bids":' + JSON.stringify(sentBidVideo) + '}'}); expect(result.length).to.equal(1); expect(result).to.deep.equal(videoResult); diff --git a/test/spec/modules/revcontentBidAdapter_spec.js b/test/spec/modules/revcontentBidAdapter_spec.js index ca4e7bc4e4b..6d660d1b3b5 100644 --- a/test/spec/modules/revcontentBidAdapter_spec.js +++ b/test/spec/modules/revcontentBidAdapter_spec.js @@ -7,10 +7,10 @@ import * as utils from 'src/utils.js'; describe('revcontent adapter', function () { let serverResponse, bidRequest, bidResponses; - let bids = []; + const bids = []; describe('isBidRequestValid', function () { - let bid = { + const bid = { bidder: 'revcontent', nativeParams: {}, params: { @@ -34,7 +34,7 @@ describe('revcontent adapter', function () { describe('buildRequests', function () { it('should send request with correct structure', function () { - let validBidRequests = [{ + const validBidRequests = [{ bidder: 'revcontent', nativeParams: {}, params: { @@ -54,8 +54,8 @@ describe('revcontent adapter', function () { }); it('should have default request structure', function () { - let keys = 'method,options,url,data,bid'.split(','); - let validBidRequests = [{ + const keys = 'method,options,url,data,bid'.split(','); + const validBidRequests = [{ bidder: 'revcontent', nativeParams: {}, params: { @@ -69,13 +69,13 @@ describe('revcontent adapter', function () { let request = spec.buildRequests(validBidRequests, {refererInfo: {page: 'page'}}); request = request[0]; - let data = Object.keys(request); + const data = Object.keys(request); assert.deepEqual(keys, data); }); it('should send info about device and unique bidfloor', function () { - let validBidRequests = [{ + const validBidRequests = [{ bidder: 'revcontent', nativeParams: {}, params: { @@ -94,7 +94,7 @@ describe('revcontent adapter', function () { }); it('should send info about device and use getFloor', function () { - let validBidRequests = [{ + const validBidRequests = [{ bidder: 'revcontent', nativeParams: {}, params: { @@ -119,7 +119,7 @@ describe('revcontent adapter', function () { }); it('should send info about the site and default bidfloor', function () { - let validBidRequests = [{ + const validBidRequests = [{ bidder: 'revcontent', nativeParams: { image: { @@ -146,7 +146,7 @@ describe('revcontent adapter', function () { endpoint: 'trends-s0.revcontent.com' } }]; - let refererInfo = {page: 'page'}; + const refererInfo = {page: 'page'}; let request = spec.buildRequests(validBidRequests, {refererInfo}); request = JSON.parse(request[0].data); @@ -161,10 +161,10 @@ describe('revcontent adapter', function () { describe('interpretResponse', function () { it('should return if no body in response', function () { - let serverResponse = {}; - let bidRequest = {}; + const serverResponse = {}; + const bidRequest = {}; - let result = spec.interpretResponse(serverResponse, bidRequest); + const result = spec.interpretResponse(serverResponse, bidRequest); assert.equal(result.length, 0); }); @@ -324,7 +324,7 @@ describe('revcontent adapter', function () { cur: 'USD' } }; - let bidRequest = { + const bidRequest = { data: '{}', bids: [{bidId: 'bidId1'}] }; diff --git a/test/spec/modules/richaudienceBidAdapter_spec.js b/test/spec/modules/richaudienceBidAdapter_spec.js index 1f84d852b8e..aca6f6a49a3 100644 --- a/test/spec/modules/richaudienceBidAdapter_spec.js +++ b/test/spec/modules/richaudienceBidAdapter_spec.js @@ -803,7 +803,7 @@ describe('Richaudience adapter tests', function () { }); it('should pass schain', function () { - let schain = { + const schain = { 'ver': '1.0', 'complete': 1, 'nodes': [{ @@ -1270,11 +1270,11 @@ describe('Richaudience adapter tests', function () { 'userSync': {filterSettings: {iframe: {bidders: '*', filter: 'include'}}} }) - var syncs = spec.getUserSyncs({iframeEnabled: true}, [BID_RESPONSE], { - gppString: 'DBABL~BVVqAAEABgA.QA', - applicableSections: [7] - }, - ); + let syncs = spec.getUserSyncs({iframeEnabled: true}, [BID_RESPONSE], { + gppString: 'DBABL~BVVqAAEABgA.QA', + applicableSections: [7] + }, + ); expect(syncs).to.have.lengthOf(1); expect(syncs[0].type).to.equal('iframe'); @@ -1282,11 +1282,11 @@ describe('Richaudience adapter tests', function () { 'userSync': {filterSettings: {image: {bidders: '*', filter: 'include'}}} }) - var syncs = spec.getUserSyncs({pixelEnabled: true}, [BID_RESPONSE], { - gppString: 'DBABL~BVVqAAEABgA.QA', - applicableSections: [7, 5] - }, - ); + syncs = spec.getUserSyncs({pixelEnabled: true}, [BID_RESPONSE], { + gppString: 'DBABL~BVVqAAEABgA.QA', + applicableSections: [7, 5] + }, + ); expect(syncs).to.have.lengthOf(1); expect(syncs[0].type).to.equal('image'); }); diff --git a/test/spec/modules/ringieraxelspringerBidAdapter_spec.js b/test/spec/modules/ringieraxelspringerBidAdapter_spec.js index a68d51a9456..08587e5174f 100644 --- a/test/spec/modules/ringieraxelspringerBidAdapter_spec.js +++ b/test/spec/modules/ringieraxelspringerBidAdapter_spec.js @@ -189,7 +189,7 @@ describe('ringieraxelspringerBidAdapter', function () { } } }; - let bidderRequest = { + const bidderRequest = { ortb2: { regs: { ext: { @@ -236,7 +236,7 @@ describe('ringieraxelspringerBidAdapter', function () { }); it('should handle empty ad', function () { - let res = { + const res = { 'ads': [{ type: 'empty' }] @@ -246,7 +246,7 @@ describe('ringieraxelspringerBidAdapter', function () { }); it('should handle empty server response', function () { - let res = { + const res = { 'ads': [] }; const resp = spec.interpretResponse({ body: res }, {}); @@ -254,7 +254,7 @@ describe('ringieraxelspringerBidAdapter', function () { }); it('should generate auctionConfig when fledge is enabled', function () { - let bidRequest = { + const bidRequest = { method: 'GET', url: 'https://example.com', bidIds: [{ @@ -283,7 +283,7 @@ describe('ringieraxelspringerBidAdapter', function () { }] }; - let auctionConfigs = [{ + const auctionConfigs = [{ 'bidId': '123', 'config': { 'seller': 'https://csr.onet.pl', diff --git a/test/spec/modules/riseBidAdapter_spec.js b/test/spec/modules/riseBidAdapter_spec.js index bb7e07bd69e..f7ae2f8a88a 100644 --- a/test/spec/modules/riseBidAdapter_spec.js +++ b/test/spec/modules/riseBidAdapter_spec.js @@ -465,40 +465,16 @@ describe('riseAdapter', function () { 'architecture': 'x86' } const bid = utils.deepClone(bidRequests[0]); - bid.ortb2 = { + const bidderRequestWithSua = utils.deepClone(bidderRequest); + bidderRequestWithSua.ortb2 = { 'device': { - 'sua': { - 'platform': { - 'brand': 'macOS', - 'version': [ '12', '4', '0' ] - }, - 'browsers': [ - { - 'brand': 'Chromium', - 'version': [ '106', '0', '5249', '119' ] - }, - { - 'brand': 'Google Chrome', - 'version': [ '106', '0', '5249', '119' ] - }, - { - 'brand': 'Not;A=Brand', - 'version': [ '99', '0', '0', '0' ] - } - ], - 'mobile': 0, - 'model': '', - 'bitness': '64', - 'architecture': 'x86' - } + 'sua': sua } - } - const requestWithSua = spec.buildRequests([bid], bidderRequest); + }; + const requestWithSua = spec.buildRequests([bid], bidderRequestWithSua); const data = requestWithSua.data; - expect(data.bids[0].sua).to.exist; - expect(data.bids[0].sua).to.deep.equal(sua); - const request = spec.buildRequests(bidRequests, bidderRequest); - expect(request.data.bids[0].sua).to.not.exist; + expect(data.params.sua).to.exist; + expect(data.params.sua).to.deep.equal(JSON.stringify(sua)); }); it('should send ORTB2 device data in bid request', function() { @@ -527,20 +503,20 @@ describe('riseAdapter', function () { }); describe('COPPA Param', function() { - it('should set coppa equal 0 in bid request if coppa is set to false', function() { + it('should set coppa equal 0 in bid request if coppa is set to 0', function() { const request = spec.buildRequests(bidRequests, bidderRequest); - expect(request.data.bids[0].coppa).to.be.equal(0); + expect(request.data.params.coppa).to.be.equal(0); }); - it('should set coppa equal 1 in bid request if coppa is set to true', function() { - const bid = utils.deepClone(bidRequests[0]); - bid.ortb2 = { + it('should set coppa equal 1 in bid request if coppa is set to 1', function() { + const bidderRequestWithCoppa = utils.deepClone(bidderRequest); + bidderRequestWithCoppa.ortb2 = { 'regs': { - 'coppa': true, + 'coppa': 1, } }; - const request = spec.buildRequests([bid], bidderRequest); - expect(request.data.bids[0].coppa).to.be.equal(1); + const request = spec.buildRequests(bidRequests, bidderRequestWithCoppa); + expect(request.data.params.coppa).to.be.equal(1); }); }); }); diff --git a/test/spec/modules/rivrAnalyticsAdapter_spec.js b/test/spec/modules/rivrAnalyticsAdapter_spec.js index 8208ba7d40d..444c91f89be 100644 --- a/test/spec/modules/rivrAnalyticsAdapter_spec.js +++ b/test/spec/modules/rivrAnalyticsAdapter_spec.js @@ -1,6 +1,5 @@ import * as utils from 'src/utils.js'; -import analyticsAdapter from 'modules/rivrAnalyticsAdapter.js'; -import { +import analyticsAdapter, { sendImpressions, handleClickEventWithClosureScope, createUnOptimisedParamsField, @@ -14,8 +13,8 @@ import { getCookie, storeAndReturnRivrUsrIdCookie, arrayDifference, - activelyWaitForBannersToRender, -} from 'modules/rivrAnalyticsAdapter.js'; + activelyWaitForBannersToRender} from 'modules/rivrAnalyticsAdapter.js'; + import {expect} from 'chai'; import adapterManager from 'src/adapterManager.js'; import * as ajax from 'src/ajax.js'; @@ -93,7 +92,7 @@ describe('RIVR Analytics adapter', () => { }); it('Firing an event when rivraddon context is not defined it should do nothing', () => { - let rivraddonsGetContextStub = sandbox.stub(window.rivraddon.analytics, 'getContext'); + const rivraddonsGetContextStub = sandbox.stub(window.rivraddon.analytics, 'getContext'); rivraddonsTrackPbjsEventStub = sandbox.stub(window.rivraddon.analytics, 'trackPbjsEvent'); expect(rivraddonsTrackPbjsEventStub.callCount).to.be.equal(0); diff --git a/test/spec/modules/rixengineBidAdapter_spec.js b/test/spec/modules/rixengineBidAdapter_spec.js index a400b5c755b..c20423879d8 100644 --- a/test/spec/modules/rixengineBidAdapter_spec.js +++ b/test/spec/modules/rixengineBidAdapter_spec.js @@ -51,7 +51,7 @@ const RESPONSE = { describe('rixengine bid adapter', function () { describe('isBidRequestValid', function () { - let bid = { + const bid = { bidder: 'rixengine', params: { endpoint: 'http://demo.svr.rixengine.com/rtb', @@ -93,8 +93,8 @@ describe('rixengine bid adapter', function () { describe('interpretResponse', function () { it('has bids', function () { - let request = spec.buildRequests(REQUEST, {})[0]; - let bids = spec.interpretResponse(RESPONSE, request); + const request = spec.buildRequests(REQUEST, {})[0]; + const bids = spec.interpretResponse(RESPONSE, request); expect(bids).to.be.an('array').that.is.not.empty; validateBidOnIndex(0); diff --git a/test/spec/modules/rocketlabBidAdapter_spec.js b/test/spec/modules/rocketlabBidAdapter_spec.js index 9993ee094ae..78f39761656 100644 --- a/test/spec/modules/rocketlabBidAdapter_spec.js +++ b/test/spec/modules/rocketlabBidAdapter_spec.js @@ -123,7 +123,7 @@ describe("RocketLabBidAdapter", function () { }); it("Returns general data valid", function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an("object"); expect(data).to.have.all.keys( "deviceWidth", @@ -207,7 +207,7 @@ describe("RocketLabBidAdapter", function () { }, ]; - let serverRequest = spec.buildRequests(bids, bidderRequest); + const serverRequest = spec.buildRequests(bids, bidderRequest); const { placements } = serverRequest.data; for (let i = 0, len = placements.length; i < len; i++) { @@ -246,7 +246,7 @@ describe("RocketLabBidAdapter", function () { it("Returns data with gdprConsent and without uspConsent", function () { delete bidderRequest.uspConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a("object"); expect(data.gdpr).to.have.property("consentString"); @@ -262,7 +262,7 @@ describe("RocketLabBidAdapter", function () { bidderRequest.uspConsent = "1---"; delete bidderRequest.gdprConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a("string"); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -277,8 +277,8 @@ describe("RocketLabBidAdapter", function () { applicableSections: [8], }; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an("object"); expect(data).to.have.property("gpp"); expect(data).to.have.property("gpp_sid"); @@ -292,8 +292,8 @@ describe("RocketLabBidAdapter", function () { bidderRequest.ortb2.regs.gpp = "abc123"; bidderRequest.ortb2.regs.gpp_sid = [8]; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an("object"); expect(data).to.have.property("gpp"); expect(data).to.have.property("gpp_sid"); @@ -325,9 +325,9 @@ describe("RocketLabBidAdapter", function () { }, ], }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an("array").that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys( "requestId", "cpm", @@ -375,10 +375,10 @@ describe("RocketLabBidAdapter", function () { }, ], }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an("array").that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys( "requestId", "cpm", @@ -426,10 +426,10 @@ describe("RocketLabBidAdapter", function () { }, ], }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an("array").that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys( "requestId", "cpm", @@ -480,7 +480,7 @@ describe("RocketLabBidAdapter", function () { ], }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an("array").that.is.empty; }); it("Should return an empty array if invalid video response is passed", function () { @@ -498,7 +498,7 @@ describe("RocketLabBidAdapter", function () { }, ], }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an("array").that.is.empty; }); it("Should return an empty array if invalid native response is passed", function () { @@ -517,7 +517,7 @@ describe("RocketLabBidAdapter", function () { }, ], }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an("array").that.is.empty; }); it("Should return an empty array if invalid response is passed", function () { @@ -532,7 +532,7 @@ describe("RocketLabBidAdapter", function () { }, ], }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an("array").that.is.empty; }); }); diff --git a/test/spec/modules/roxotAnalyticsAdapter_spec.js b/test/spec/modules/roxotAnalyticsAdapter_spec.js index 6fc7f356333..4882d6e7c63 100644 --- a/test/spec/modules/roxotAnalyticsAdapter_spec.js +++ b/test/spec/modules/roxotAnalyticsAdapter_spec.js @@ -3,29 +3,29 @@ import {expect} from 'chai'; import {server} from 'test/mocks/xhr.js'; import { EVENTS } from 'src/constants.js'; -let events = require('src/events'); +const events = require('src/events'); describe('Roxot Prebid Analytic', function () { - let roxotConfigServerUrl = 'config-server'; - let roxotEventServerUrl = 'event-server'; - let publisherId = 'test_roxot_prebid_analytics_publisher_id'; + const roxotConfigServerUrl = 'config-server'; + const roxotEventServerUrl = 'event-server'; + const publisherId = 'test_roxot_prebid_analytics_publisher_id'; - let auctionId = '0ea14159-2058-4b87-a966-9d7652176a56'; - let timeout = 3000; - let auctionStartTimestamp = Date.now(); - let bidder = 'rubicon'; + const auctionId = '0ea14159-2058-4b87-a966-9d7652176a56'; + const timeout = 3000; + const auctionStartTimestamp = Date.now(); + const bidder = 'rubicon'; - let bidAdUnit = 'div_with_bid'; - let noBidAdUnit = 'div_no_bid'; - let bidAfterTimeoutAdUnit = 'div_after_timeout'; + const bidAdUnit = 'div_with_bid'; + const noBidAdUnit = 'div_no_bid'; + const bidAfterTimeoutAdUnit = 'div_after_timeout'; - let auctionInit = { + const auctionInit = { timestamp: auctionStartTimestamp, auctionId: auctionId, timeout: timeout }; - let bidRequested = { + const bidRequested = { auctionId: auctionId, auctionStart: auctionStartTimestamp, bidderCode: bidder, @@ -67,7 +67,7 @@ describe('Roxot Prebid Analytic', function () { timeout: timeout }; - let bidAdjustmentWithBid = { + const bidAdjustmentWithBid = { ad: 'html', adId: '298bf14ecbafb', adUnitCode: bidAdUnit, @@ -91,7 +91,7 @@ describe('Roxot Prebid Analytic', function () { width: 300 }; - let bidAdjustmentAfterTimeout = { + const bidAdjustmentAfterTimeout = { ad: 'html', adId: '36c6375e2dceba', adUnitCode: bidAfterTimeoutAdUnit, @@ -115,7 +115,7 @@ describe('Roxot Prebid Analytic', function () { width: 300 }; - let bidAdjustmentNoBid = { + const bidAdjustmentNoBid = { ad: 'html', adId: '36c6375e2dce21', adUnitCode: noBidAdUnit, @@ -139,11 +139,11 @@ describe('Roxot Prebid Analytic', function () { width: 0 }; - let auctionEnd = { + const auctionEnd = { auctionId: auctionId }; - let bidTimeout = [ + const bidTimeout = [ { adUnitCode: bidAfterTimeoutAdUnit, auctionId: auctionId, @@ -153,11 +153,11 @@ describe('Roxot Prebid Analytic', function () { } ]; - let bidResponseWithBid = bidAdjustmentWithBid; - let bidResponseAfterTimeout = bidAdjustmentAfterTimeout; - let bidResponseNoBid = bidAdjustmentNoBid; - let bidderDone = bidRequested; - let bidWon = bidAdjustmentWithBid; + const bidResponseWithBid = bidAdjustmentWithBid; + const bidResponseAfterTimeout = bidAdjustmentAfterTimeout; + const bidResponseNoBid = bidAdjustmentNoBid; + const bidderDone = bidRequested; + const bidWon = bidAdjustmentWithBid; describe('correct build and send events', function () { beforeEach(function () { @@ -200,7 +200,7 @@ describe('Roxot Prebid Analytic', function () { expect(server.requests[2].url).to.equal('https://' + roxotEventServerUrl + '/bat?publisherId=' + publisherId + '&host=localhost'); expect(server.requests[3].url).to.equal('https://' + roxotEventServerUrl + '/i?publisherId=' + publisherId + '&host=localhost'); - let auction = JSON.parse(server.requests[1].requestBody); + const auction = JSON.parse(server.requests[1].requestBody); expect(auction).to.include.all.keys('event', 'eventName', 'options', 'data'); expect(auction.event).to.equal('a'); @@ -217,7 +217,7 @@ describe('Roxot Prebid Analytic', function () { expect(auction.data.adUnits[bidAfterTimeoutAdUnit].bidders[bidder].status).to.equal('timeout'); expect(auction.data.adUnits[noBidAdUnit].bidders[bidder].status).to.equal('noBid'); - let bidAfterTimeout = JSON.parse(server.requests[2].requestBody); + const bidAfterTimeout = JSON.parse(server.requests[2].requestBody); expect(bidAfterTimeout).to.include.all.keys('event', 'eventName', 'options', 'data'); expect(bidAfterTimeout.event).to.equal('bat'); @@ -226,7 +226,7 @@ describe('Roxot Prebid Analytic', function () { expect(bidAfterTimeout.data.bidder).to.equal(bidder); expect(bidAfterTimeout.data.cpm).to.equal(bidAdjustmentAfterTimeout.cpm); - let impression = JSON.parse(server.requests[3].requestBody); + const impression = JSON.parse(server.requests[3].requestBody); expect(impression).to.include.all.keys('event', 'eventName', 'options', 'data'); expect(impression.event).to.equal('i'); @@ -278,7 +278,7 @@ describe('Roxot Prebid Analytic', function () { expect(server.requests[1].url).to.equal('https://' + roxotEventServerUrl + '/a?publisherId=' + publisherId + '&host=localhost'); expect(server.requests[2].url).to.equal('https://' + roxotEventServerUrl + '/bat?publisherId=' + publisherId + '&host=localhost'); - let auction = JSON.parse(server.requests[1].requestBody); + const auction = JSON.parse(server.requests[1].requestBody); expect(auction.data.adUnits).to.include.all.keys(noBidAdUnit, bidAfterTimeoutAdUnit); expect(auction.data.adUnits).to.not.include.all.keys(bidAdUnit); }); @@ -295,7 +295,7 @@ describe('Roxot Prebid Analytic', function () { }); it('correct parse publisher config', function () { - let publisherOptions = { + const publisherOptions = { publisherId: publisherId, configServer: roxotConfigServerUrl, server: roxotEventServerUrl, @@ -311,7 +311,7 @@ describe('Roxot Prebid Analytic', function () { }); it('support deprecated options', function () { - let publisherOptions = { + const publisherOptions = { publisherIds: [publisherId], }; @@ -325,7 +325,7 @@ describe('Roxot Prebid Analytic', function () { }); it('support default end-points', function () { - let publisherOptions = { + const publisherOptions = { publisherId: publisherId, }; @@ -339,7 +339,7 @@ describe('Roxot Prebid Analytic', function () { }); it('support custom config end-point', function () { - let publisherOptions = { + const publisherOptions = { publisherId: publisherId, configServer: roxotConfigServerUrl }; @@ -354,7 +354,7 @@ describe('Roxot Prebid Analytic', function () { }); it('support custom config and event end-point', function () { - let publisherOptions = { + const publisherOptions = { publisherId: publisherId, server: roxotEventServerUrl }; @@ -369,7 +369,7 @@ describe('Roxot Prebid Analytic', function () { }); it('support different config and event end-points', function () { - let publisherOptions = { + const publisherOptions = { publisherId: publisherId, configServer: roxotConfigServerUrl, server: roxotEventServerUrl @@ -385,7 +385,7 @@ describe('Roxot Prebid Analytic', function () { }); it('support adUnit filter', function () { - let publisherOptions = { + const publisherOptions = { publisherId: publisherId, adUnits: ['div1', 'div2'] }; @@ -399,7 +399,7 @@ describe('Roxot Prebid Analytic', function () { }); it('support fail loading server config', function () { - let publisherOptions = { + const publisherOptions = { publisherId: publisherId }; @@ -432,7 +432,7 @@ describe('Roxot Prebid Analytic', function () { localStorage.removeItem('roxot_analytics_utm_ttl'); }); it('should build utm data from local storage', function () { - let utmTagData = roxotAnalytic.buildUtmTagData(); + const utmTagData = roxotAnalytic.buildUtmTagData(); expect(utmTagData.utm_source).to.equal('utm_source'); expect(utmTagData.utm_medium).to.equal('utm_medium'); expect(utmTagData.utm_campaign).to.equal(''); diff --git a/test/spec/modules/rtbhouseBidAdapter_spec.js b/test/spec/modules/rtbhouseBidAdapter_spec.js index 2b596f2cf6b..fe4cd31d516 100644 --- a/test/spec/modules/rtbhouseBidAdapter_spec.js +++ b/test/spec/modules/rtbhouseBidAdapter_spec.js @@ -15,7 +15,7 @@ describe('RTBHouseAdapter', () => { }); describe('isBidRequestValid', function () { - let bid = { + const bid = { 'bidder': 'rtbhouse', 'params': { 'publisherId': 'PREBID_TEST', @@ -37,14 +37,14 @@ describe('RTBHouseAdapter', () => { }); it('Checking backward compatibility. should return true', function () { - let bid2 = Object.assign({}, bid); + const bid2 = Object.assign({}, bid); delete bid2.mediaTypes; bid2.sizes = [[300, 250], [300, 600]]; expect(spec.isBidRequestValid(bid2)).to.equal(true); }); it('should return false when required params are not passed', function () { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = { 'someIncorrectParam': 0 @@ -119,26 +119,26 @@ describe('RTBHouseAdapter', () => { }); it('should build test param into the request', () => { - let builtTestRequest = spec.buildRequests(bidRequests, bidderRequest).data; + const builtTestRequest = spec.buildRequests(bidRequests, bidderRequest).data; expect(JSON.parse(builtTestRequest).test).to.equal(1); }); it('should build channel param into request.site', () => { - let builtTestRequest = spec.buildRequests(bidRequests, bidderRequest).data; + const builtTestRequest = spec.buildRequests(bidRequests, bidderRequest).data; expect(JSON.parse(builtTestRequest).site.channel).to.equal('Partner_Site - news'); }) it('should not build channel param into request.site if no value is passed', () => { - let bidRequest = Object.assign([], bidRequests); + const bidRequest = Object.assign([], bidRequests); bidRequest[0].params.channel = undefined; - let builtTestRequest = spec.buildRequests(bidRequest, bidderRequest).data; + const builtTestRequest = spec.buildRequests(bidRequest, bidderRequest).data; expect(JSON.parse(builtTestRequest).site.channel).to.be.undefined }) it('should cap the request.site.channel length to 50', () => { - let bidRequest = Object.assign([], bidRequests); + const bidRequest = Object.assign([], bidRequests); bidRequest[0].params.channel = 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Praesent scelerisque ipsum eu purus lobortis iaculis.'; - let builtTestRequest = spec.buildRequests(bidRequest, bidderRequest).data; + const builtTestRequest = spec.buildRequests(bidRequest, bidderRequest).data; expect(JSON.parse(builtTestRequest).site.channel.length).to.equal(50) }) @@ -159,7 +159,7 @@ describe('RTBHouseAdapter', () => { }); it('sends bid request to ENDPOINT via POST', function () { - let bidRequest = Object.assign([], bidRequests); + const bidRequest = Object.assign([], bidRequests); delete bidRequest[0].params.test; const request = spec.buildRequests(bidRequest, bidderRequest); expect(request.url).to.equal('https://prebid-eu.creativecdn.com/bidder/prebid/bids'); @@ -167,16 +167,16 @@ describe('RTBHouseAdapter', () => { }); it('should not populate GDPR if for non-EEA users', function () { - let bidRequest = Object.assign([], bidRequests); + const bidRequest = Object.assign([], bidRequests); delete bidRequest[0].params.test; const request = spec.buildRequests(bidRequest, bidderRequest); - let data = JSON.parse(request.data); + const data = JSON.parse(request.data); expect(data).to.not.have.property('regs'); expect(data).to.not.have.property('user'); }); it('should populate GDPR and consent string if available for EEA users', function () { - let bidRequest = Object.assign([], bidRequests); + const bidRequest = Object.assign([], bidRequests); delete bidRequest[0].params.test; const request = spec.buildRequests( bidRequest, @@ -187,13 +187,13 @@ describe('RTBHouseAdapter', () => { } }) ); - let data = JSON.parse(request.data); + const data = JSON.parse(request.data); expect(data.regs.ext.gdpr).to.equal(1); expect(data.user.ext.consent).to.equal('BOJ8RZsOJ8RZsABAB8AAAAAZ-A'); }); it('should populate GDPR and empty consent string if available for EEA users without consent string but with consent', function () { - let bidRequest = Object.assign([], bidRequests); + const bidRequest = Object.assign([], bidRequests); delete bidRequest[0].params.test; const request = spec.buildRequests( bidRequest, @@ -203,7 +203,7 @@ describe('RTBHouseAdapter', () => { } }) ); - let data = JSON.parse(request.data); + const data = JSON.parse(request.data); expect(data.regs.ext.gdpr).to.equal(1); expect(data.user.ext.consent).to.equal(''); }); @@ -678,7 +678,7 @@ describe('RTBHouseAdapter', () => { }); it('should get correct bid response', function () { - let expectedResponse = [ + const expectedResponse = [ { 'requestId': '552b8922e28f27', 'cpm': 0.5, @@ -694,14 +694,14 @@ describe('RTBHouseAdapter', () => { } ]; let bidderRequest; - let result = spec.interpretResponse({body: response}, {bidderRequest}); + const result = spec.interpretResponse({body: response}, {bidderRequest}); expect(Object.keys(result[0])).to.have.members(Object.keys(expectedResponse[0])); }); it('handles nobid responses', function () { - let response = ''; + const response = ''; let bidderRequest; - let result = spec.interpretResponse({body: response}, {bidderRequest}); + const result = spec.interpretResponse({body: response}, {bidderRequest}); expect(result.length).to.equal(0); }); @@ -740,7 +740,7 @@ describe('RTBHouseAdapter', () => { } ]; let bidderRequest; - let result = spec.interpretResponse({body: response}, {bidderRequest}); + const result = spec.interpretResponse({body: response}, {bidderRequest}); expect(Object.keys(result[0])).to.have.members(Object.keys(expectedResponse[0])); expect(result[0]).to.have.nested.property('meta.dsa'); diff --git a/test/spec/modules/rtbsapeBidAdapter_spec.js b/test/spec/modules/rtbsapeBidAdapter_spec.js index eea9e51b1a9..538a728d03a 100644 --- a/test/spec/modules/rtbsapeBidAdapter_spec.js +++ b/test/spec/modules/rtbsapeBidAdapter_spec.js @@ -18,18 +18,18 @@ describe('rtbsapeBidAdapterTests', function () { }); it('buildRequests', function () { - let bidRequestData = [{ + const bidRequestData = [{ bidId: 'bid1234', bidder: 'rtbsape', params: {placeId: 4321}, sizes: [[240, 400]] }]; - let bidderRequest = { + const bidderRequest = { auctionId: '2e208334-cafe-4c2c-b06b-f055ff876852', bidderRequestId: '1392d0aa613366', refererInfo: {} }; - let request = spec.buildRequests(bidRequestData, bidderRequest); + const request = spec.buildRequests(bidRequestData, bidderRequest); expect(request.data.auctionId).to.equal('2e208334-cafe-4c2c-b06b-f055ff876852'); expect(request.data.requestId).to.equal('1392d0aa613366'); expect(request.data.bids[0].bidId).to.equal('bid1234'); @@ -38,7 +38,7 @@ describe('rtbsapeBidAdapterTests', function () { describe('interpretResponse', function () { it('banner', function () { - let serverResponse = { + const serverResponse = { body: { bids: [{ requestId: 'bid1234', @@ -54,9 +54,9 @@ describe('rtbsapeBidAdapterTests', function () { }] } }; - let bids = spec.interpretResponse(serverResponse, {data: {bids: [{mediaTypes: {banner: true}}]}}); + const bids = spec.interpretResponse(serverResponse, {data: {bids: [{mediaTypes: {banner: true}}]}}); expect(bids).to.have.lengthOf(1); - let bid = bids[0]; + const bid = bids[0]; expect(bid.cpm).to.equal(2.21); expect(bid.currency).to.equal('RUB'); expect(bid.width).to.equal(240); @@ -70,7 +70,7 @@ describe('rtbsapeBidAdapterTests', function () { let bid; before(() => { - let serverResponse = { + const serverResponse = { body: { bids: [{ requestId: 'bid1234', @@ -88,7 +88,7 @@ describe('rtbsapeBidAdapterTests', function () { }] } }; - let serverRequest = { + const serverRequest = { data: { bids: [{ bidId: 'bid1234', @@ -107,7 +107,7 @@ describe('rtbsapeBidAdapterTests', function () { }] } }; - let bids = spec.interpretResponse(serverResponse, serverRequest); + const bids = spec.interpretResponse(serverResponse, serverRequest); expect(bids).to.have.lengthOf(1); bid = bids[0]; }); @@ -144,7 +144,7 @@ describe('rtbsapeBidAdapterTests', function () { }); it('skip adomain', function () { - let serverResponse = { + const serverResponse = { body: { bids: [{ requestId: 'bid1234', @@ -168,9 +168,9 @@ describe('rtbsapeBidAdapterTests', function () { }] } }; - let bids = spec.interpretResponse(serverResponse, {data: {bids: [{mediaTypes: {banner: true}}]}}); + const bids = spec.interpretResponse(serverResponse, {data: {bids: [{mediaTypes: {banner: true}}]}}); expect(bids).to.have.lengthOf(1); - let bid = bids[0]; + const bid = bids[0]; expect(bid.cpm).to.equal(2.23); expect(bid.currency).to.equal('RUB'); expect(bid.width).to.equal(300); diff --git a/test/spec/modules/rubiconBidAdapter_spec.js b/test/spec/modules/rubiconBidAdapter_spec.js index ec8ebb53f91..e8c54059193 100644 --- a/test/spec/modules/rubiconBidAdapter_spec.js +++ b/test/spec/modules/rubiconBidAdapter_spec.js @@ -225,7 +225,7 @@ describe('the rubicon adapter', function () { const bidderRequest = createGdprBidderRequest(true); addUspToBidderRequest(bidderRequest); - let bid = bidderRequest.bids[0]; + const bid = bidderRequest.bids[0]; bid.mediaTypes = { video: { context: 'instream', @@ -352,7 +352,7 @@ describe('the rubicon adapter', function () { } function removeVideoParamFromBidderRequest(bidderRequest) { - let bid = bidderRequest.bids[0]; + const bid = bidderRequest.bids[0]; bid.mediaTypes = { video: { context: 'instream' @@ -363,7 +363,7 @@ describe('the rubicon adapter', function () { function createVideoBidderRequestOutstream() { const bidderRequest = createGdprBidderRequest(false); - let bid = bidderRequest.bids[0]; + const bid = bidderRequest.bids[0]; delete bid.sizes; bid.mediaTypes = { video: { @@ -492,7 +492,7 @@ describe('the rubicon adapter', function () { describe('MAS mapping / ordering', function () { it('should sort values without any MAS priority sizes in regular ascending order', function () { - let ordering = masSizeOrdering([126, 43, 65, 16]); + const ordering = masSizeOrdering([126, 43, 65, 16]); expect(ordering).to.deep.equal([16, 43, 65, 126]); }); @@ -513,15 +513,15 @@ describe('the rubicon adapter', function () { describe('to fastlane', function () { it('should make a well-formed request object', function () { sandbox.stub(Math, 'random').callsFake(() => 0.1); - let duplicate = Object.assign(bidderRequest); + const duplicate = Object.assign(bidderRequest); duplicate.bids[0].params.floor = 0.01; - let [request] = spec.buildRequests(duplicate.bids, duplicate); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests(duplicate.bids, duplicate); + const data = new URLSearchParams(request.data); expect(request.url).to.equal('https://fastlane.rubiconproject.com/a/api/fastlane.json'); - let expectedQuery = { + const expectedQuery = { 'account_id': '14062', 'site_id': '70608', 'zone_id': '335918', @@ -547,7 +547,7 @@ describe('the rubicon adapter', function () { // test that all values above are both present and correct Object.keys(expectedQuery).forEach(key => { - let value = expectedQuery[key]; + const value = expectedQuery[key]; if (value instanceof RegExp) { expect(data.get(key)).to.match(value); } else { @@ -609,8 +609,8 @@ describe('the rubicon adapter', function () { var multibidRequest = utils.deepClone(bidderRequest); multibidRequest.bidLimit = 5; - let [request] = spec.buildRequests(multibidRequest.bids, multibidRequest); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests(multibidRequest.bids, multibidRequest); + const data = new URLSearchParams(request.data); expect(data.get('rp_maxbids')).to.equal('5'); }); @@ -619,8 +619,8 @@ describe('the rubicon adapter', function () { var noposRequest = utils.deepClone(bidderRequest); delete noposRequest.bids[0].params.position; - let [request] = spec.buildRequests(noposRequest.bids, noposRequest); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests(noposRequest.bids, noposRequest); + const data = new URLSearchParams(request.data); expect(data.get('site_id')).to.equal('70608'); expect(data.get('p_pos')).to.equal(null); @@ -635,8 +635,8 @@ describe('the rubicon adapter', function () { }; delete bidRequest.bids[0].params.position; - let [request] = spec.buildRequests(bidRequest.bids, bidRequest); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests(bidRequest.bids, bidRequest); + const data = new URLSearchParams(request.data); expect(data.get('site_id')).to.equal('70608'); expect(data.get('p_pos')).to.equal(null); @@ -651,8 +651,8 @@ describe('the rubicon adapter', function () { }; delete bidRequest.bids[0].params.position; - let [request] = spec.buildRequests(bidRequest.bids, bidRequest); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests(bidRequest.bids, bidRequest); + const data = new URLSearchParams(request.data); expect(data.get('site_id')).to.equal('70608'); expect(data.get('p_pos')).to.equal('atf'); @@ -662,8 +662,8 @@ describe('the rubicon adapter', function () { var badposRequest = utils.deepClone(bidderRequest); badposRequest.bids[0].params.position = 'bad'; - let [request] = spec.buildRequests(badposRequest.bids, badposRequest); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests(badposRequest.bids, badposRequest); + const data = new URLSearchParams(request.data); expect(data.get('site_id')).to.equal('70608'); expect(data.get('p_pos')).to.equal(null); @@ -694,8 +694,8 @@ describe('the rubicon adapter', function () { delete bidCopy3.params.position; sraPosRequest.bids.push(bidCopy3); - let [request] = spec.buildRequests(sraPosRequest.bids, sraPosRequest); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests(sraPosRequest.bids, sraPosRequest); + const data = new URLSearchParams(request.data); expect(data.get('p_pos')).to.equal('atf;;btf;;'); }); @@ -704,8 +704,8 @@ describe('the rubicon adapter', function () { var badposRequest = utils.deepClone(bidderRequest); badposRequest.bids[0].ortb2 = {device: {ext: {cdep: 3}}}; - let [request] = spec.buildRequests(badposRequest.bids, badposRequest); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests(badposRequest.bids, badposRequest); + const data = new URLSearchParams(request.data); expect(data.get('o_cdep')).to.equal('3'); }); @@ -714,8 +714,8 @@ describe('the rubicon adapter', function () { const ipRequest = utils.deepClone(bidderRequest); ipRequest.bids[0].ortb2 = { device: { ip: '123.45.67.89' } }; - let [request] = spec.buildRequests(ipRequest.bids, ipRequest); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests(ipRequest.bids, ipRequest); + const data = new URLSearchParams(request.data); // Verify if 'ip' is correctly added to the request data expect(data.get('ip')).to.equal('123.45.67.89'); @@ -725,8 +725,8 @@ describe('the rubicon adapter', function () { const ipv6Request = utils.deepClone(bidderRequest); ipv6Request.bids[0].ortb2 = { device: { ipv6: '2001:db8::ff00:42:8329' } }; - let [request] = spec.buildRequests(ipv6Request.bids, ipv6Request); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests(ipv6Request.bids, ipv6Request); + const data = new URLSearchParams(request.data); // Verify if 'ipv6' is correctly added to the request data expect(data.get('ipv6')).to.equal('2001:db8::ff00:42:8329'); @@ -734,7 +734,7 @@ describe('the rubicon adapter', function () { it('ad engine query params should be ordered correctly', function () { sandbox.stub(Math, 'random').callsFake(() => 0.1); - let [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); + const [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); const referenceOrdering = ['account_id', 'site_id', 'zone_id', 'size_id', 'alt_size_ids', 'p_pos', 'rf', 'p_geo.latitude', 'p_geo.longitude', 'kw', 'tg_v.ucat', 'tg_v.lastsearch', 'tg_v.likes', 'tg_i.rating', 'tg_i.prodtype', 'tk_flint', 'x_source.tid', 'l_pb_bid_id', 'p_screen_res', 'rp_secure', 'tk_user_key', 'x_imp.ext.tid', 'tg_fl.eid', 'slots', 'rand']; @@ -744,7 +744,7 @@ describe('the rubicon adapter', function () { }); it('should make a well-formed request object without latLong', function () { - let expectedQuery = { + const expectedQuery = { 'account_id': '14062', 'site_id': '70608', 'zone_id': '335918', @@ -779,7 +779,7 @@ describe('the rubicon adapter', function () { // test that all values above are both present and correct Object.keys(expectedQuery).forEach(key => { - let value = expectedQuery[key]; + const value = expectedQuery[key]; if (value instanceof RegExp) { expect(data.get(key)).to.match(value); } else { @@ -795,7 +795,7 @@ describe('the rubicon adapter', function () { // test that all values above are both present and correct Object.keys(expectedQuery).forEach(key => { - let value = expectedQuery[key]; + const value = expectedQuery[key]; if (value instanceof RegExp) { expect(data.get(key)).to.match(value); } else { @@ -805,7 +805,7 @@ describe('the rubicon adapter', function () { }); it('should add referer info to request data', function () { - let refererInfo = { + const refererInfo = { page: 'https://www.prebid.org', reachedTop: true, numIframes: 1, @@ -817,7 +817,7 @@ describe('the rubicon adapter', function () { bidderRequest = Object.assign({refererInfo}, bidderRequest); delete bidderRequest.bids[0].params.referrer; - let [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); + const [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); expect(new URLSearchParams(request.data).get('rf')).to.exist; expect(new URLSearchParams(request.data).get('rf')).to.equal('https://www.prebid.org'); @@ -828,7 +828,7 @@ describe('the rubicon adapter', function () { expect(new URLSearchParams(request.data).get('rf')).to.equal('localhost'); delete bidderRequest.bids[0].params.referrer; - let refererInfo = {page: 'https://www.prebid.org'}; + const refererInfo = {page: 'https://www.prebid.org'}; bidderRequest = Object.assign({refererInfo}, bidderRequest); [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); expect(new URLSearchParams(request.data).get('rf')).to.equal('https://www.prebid.org'); @@ -843,8 +843,8 @@ describe('the rubicon adapter', function () { var sizesBidderRequest = utils.deepClone(bidderRequest); sizesBidderRequest.bids[0].params.sizes = [55, 57, 59, 801]; - let [request] = spec.buildRequests(sizesBidderRequest.bids, sizesBidderRequest); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests(sizesBidderRequest.bids, sizesBidderRequest); + const data = new URLSearchParams(request.data); expect(data.get('size_id')).to.equal('55'); expect(data.get('alt_size_ids')).to.equal('57,59,801'); @@ -854,7 +854,7 @@ describe('the rubicon adapter', function () { var sizesBidderRequest = utils.deepClone(bidderRequest); sizesBidderRequest.bids[0].sizes = [[621, 250], [300, 251]]; - let result = spec.isBidRequestValid(sizesBidderRequest.bids[0]); + const result = spec.isBidRequestValid(sizesBidderRequest.bids[0]); expect(result).to.equal(false); }); @@ -863,7 +863,7 @@ describe('the rubicon adapter', function () { var noAccountBidderRequest = utils.deepClone(bidderRequest); delete noAccountBidderRequest.bids[0].params.accountId; - let result = spec.isBidRequestValid(noAccountBidderRequest.bids[0]); + const result = spec.isBidRequestValid(noAccountBidderRequest.bids[0]); expect(result).to.equal(false); }); @@ -872,8 +872,8 @@ describe('the rubicon adapter', function () { var floorBidderRequest = utils.deepClone(bidderRequest); floorBidderRequest.bids[0].params.floor = 2; - let [request] = spec.buildRequests(floorBidderRequest.bids, floorBidderRequest); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests(floorBidderRequest.bids, floorBidderRequest); + const data = new URLSearchParams(request.data); expect(data.get('rp_floor')).to.equal('2'); }); @@ -881,8 +881,8 @@ describe('the rubicon adapter', function () { describe('GDPR consent config', function () { it('should send "gdpr" and "gdpr_consent", when gdprConsent defines consentString and gdprApplies', function () { const bidderRequest = createGdprBidderRequest(true); - let [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); + const data = new URLSearchParams(request.data); expect(data.get('gdpr')).to.equal('1'); expect(data.get('gdpr_consent')).to.equal('BOJ/P2HOJ/P2HABABMAAAAAZ+A=='); @@ -890,16 +890,16 @@ describe('the rubicon adapter', function () { it('should send only "gdpr_consent", when gdprConsent defines only consentString', function () { const bidderRequest = createGdprBidderRequest(); - let [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); + const data = new URLSearchParams(request.data); expect(data.get('gdpr_consent')).to.equal('BOJ/P2HOJ/P2HABABMAAAAAZ+A=='); expect(data.get('gdpr')).to.equal(null); }); it('should not send GDPR params if gdprConsent is not defined', function () { - let [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); + const data = new URLSearchParams(request.data); expect(data.get('gdpr')).to.equal(null); expect(data.get('gdpr_consent')).to.equal(null); @@ -921,15 +921,15 @@ describe('the rubicon adapter', function () { describe('USP Consent', function () { it('should send us_privacy if bidderRequest has a value for uspConsent', function () { addUspToBidderRequest(bidderRequest); - let [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); + const data = new URLSearchParams(request.data); expect(data.get('us_privacy')).to.equal('1NYN'); }); it('should not send us_privacy if bidderRequest has no uspConsent value', function () { - let [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); + const data = new URLSearchParams(request.data); expect(data.get('us_privacy')).to.equal(null); }); @@ -941,8 +941,8 @@ describe('the rubicon adapter', function () { gppString: 'consent', applicableSections: 2 }; - let [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); + const data = new URLSearchParams(request.data); delete bidderRequest.gppConsent; expect(data.get('gpp')).to.equal('consent'); @@ -950,8 +950,8 @@ describe('the rubicon adapter', function () { }); it('should not send gpp information if bidderRequest does not have a value for gppConsent', function () { - let [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); + const data = new URLSearchParams(request.data); expect(data.get('gpp')).to.equal(null); expect(data.get('gpp_sid')).to.equal(null); @@ -960,7 +960,7 @@ describe('the rubicon adapter', function () { describe('first party data', function () { it('should not have any tg_v or tg_i params if all are undefined', function () { - let params = { + const params = { inventory: { rating: null, prodtype: undefined @@ -976,11 +976,11 @@ describe('the rubicon adapter', function () { Object.assign(bidderRequest.bids[0].params, params); // get the built request - let [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); + const data = new URLSearchParams(request.data); // make sure that no tg_v or tg_i keys are present in the request - let matchingExp = RegExp('^tg_(i|v)\..*$'); + const matchingExp = RegExp('^tg_(i|v)\..*$'); // Display the keys for (const key of data.keys()) { expect(key).to.not.match(matchingExp); @@ -988,7 +988,7 @@ describe('the rubicon adapter', function () { }); it('should contain valid params when some are undefined', function () { - let params = { + const params = { inventory: { rating: undefined, prodtype: ['tech', 'mobile'] @@ -999,8 +999,8 @@ describe('the rubicon adapter', function () { likes: undefined }, }; - let undefinedKeys = ['tg_i.rating', 'tg_v.ucat', 'tg_v.likes'] - let expectedQuery = { + const undefinedKeys = ['tg_i.rating', 'tg_v.ucat', 'tg_v.likes'] + const expectedQuery = { 'tg_v.lastsearch': 'iphone', 'tg_i.prodtype': 'tech,mobile', } @@ -1009,8 +1009,8 @@ describe('the rubicon adapter', function () { Object.assign(bidderRequest.bids[0].params, params); // get the built request - let [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); + const data = new URLSearchParams(request.data); // make sure none of the undefined keys are in query undefinedKeys.forEach(key => { @@ -1019,7 +1019,7 @@ describe('the rubicon adapter', function () { // make sure the expected and defined ones do show up still Object.keys(expectedQuery).forEach(key => { - let value = expectedQuery[key]; + const value = expectedQuery[key]; expect(data.get(key)).to.equal(value); }); }); @@ -1103,12 +1103,12 @@ describe('the rubicon adapter', function () { }; // get the built request - let [request] = spec.buildRequests(bidderRequest.bids.map((b) => ({...b, ortb2})), bidderRequest); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests(bidderRequest.bids.map((b) => ({...b, ortb2})), bidderRequest); + const data = new URLSearchParams(request.data); // make sure that tg_v, tg_i, and kw values are correct Object.keys(expectedQuery).forEach(key => { - let value = expectedQuery[key]; + const value = expectedQuery[key]; expect(data.get(key)).to.deep.equal(value); }); }); @@ -1231,7 +1231,7 @@ describe('the rubicon adapter', function () { // TEST '10' BIDS, add 9 to 1 existing bid for (let i = 0; i < 9; i++) { - let bidCopy = utils.deepClone(bidderRequest.bids[0]); + const bidCopy = utils.deepClone(bidderRequest.bids[0]); bidCopy.params.zoneId = `${i}0000`; bidderRequest.bids.push(bidCopy); } @@ -1250,7 +1250,7 @@ describe('the rubicon adapter', function () { // TEST '100' BIDS, add 90 to the previously added 10 for (let i = 0; i < 90; i++) { - let bidCopy = utils.deepClone(bidderRequest.bids[0]); + const bidCopy = utils.deepClone(bidderRequest.bids[0]); bidCopy.params.zoneId = `${(i + 10)}0000`; bidderRequest.bids.push(bidCopy); } @@ -1278,13 +1278,13 @@ describe('the rubicon adapter', function () { bidderRequest.bids.push(bidCopy); bidderRequest.bids.push(bidCopy); - let serverRequests = spec.buildRequests(bidderRequest.bids, bidderRequest); + const serverRequests = spec.buildRequests(bidderRequest.bids, bidderRequest); // should have 1 request only expect(serverRequests).that.is.an('array').of.length(1); // get the built query - let data = new URLSearchParams(serverRequests[0].data); + const data = new URLSearchParams(serverRequests[0].data); // num slots should be 4 expect(data.get('slots')).to.equal('4'); @@ -1304,7 +1304,7 @@ describe('the rubicon adapter', function () { bidCopy3.params.siteId = '32001'; bidderRequest.bids.push(bidCopy3); - let serverRequests = spec.buildRequests(bidderRequest.bids, bidderRequest); + const serverRequests = spec.buildRequests(bidderRequest.bids, bidderRequest); expect(serverRequests).that.is.an('array').of.length(4); }); @@ -1348,7 +1348,7 @@ describe('the rubicon adapter', function () { }; bidderRequest.bids.push(bidCopy4); - let serverRequests = spec.buildRequests(bidderRequest.bids, bidderRequest); + const serverRequests = spec.buildRequests(bidderRequest.bids, bidderRequest); expect(serverRequests).that.is.an('array').of.length(3); }); }); @@ -1373,8 +1373,8 @@ describe('the rubicon adapter', function () { } } }; - let [request] = spec.buildRequests([clonedBid], bidderRequest); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests([clonedBid], bidderRequest); + const data = new URLSearchParams(request.data); expect(data.get('eid_pubcid.org')).to.equal('1111^1^^^^^'); }); @@ -1399,8 +1399,8 @@ describe('the rubicon adapter', function () { } } }; - let [request] = spec.buildRequests([clonedBid], bidderRequest); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests([clonedBid], bidderRequest); + const data = new URLSearchParams(request.data); expect(data.get('eid_criteo.com')).to.equal('1111^1^^^^^'); }); @@ -1446,8 +1446,8 @@ describe('the rubicon adapter', function () { } } }; - let [request] = spec.buildRequests([clonedBid], bidderRequest); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests([clonedBid], bidderRequest); + const data = new URLSearchParams(request.data); expect(data.get('ppuid')).to.equal('11111'); }); @@ -1480,8 +1480,8 @@ describe('the rubicon adapter', function () { } } }; - let [request] = spec.buildRequests([clonedBid], bidderRequest); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests([clonedBid], bidderRequest); + const data = new URLSearchParams(request.data); expect(data.get('eid_id5-sync.com')).to.equal('11111^1^^^^^'); }); @@ -1504,8 +1504,8 @@ describe('the rubicon adapter', function () { } } }; - let [request] = spec.buildRequests([clonedBid], bidderRequest); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests([clonedBid], bidderRequest); + const data = new URLSearchParams(request.data); expect(data.get('eid_catchall')).to.equal('11111^2^^^^^'); }); @@ -1526,8 +1526,8 @@ describe('the rubicon adapter', function () { } } }; - let [request] = spec.buildRequests([clonedBid], bidderRequest); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests([clonedBid], bidderRequest); + const data = new URLSearchParams(request.data); expect(data.get('eid_rubiconproject.com')).to.equal('some-cool-id^3^^^^^'); }); @@ -1556,8 +1556,8 @@ describe('the rubicon adapter', function () { } }; - let [request] = spec.buildRequests([clonedBid], bidderRequest); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests([clonedBid], bidderRequest); + const data = new URLSearchParams(request.data); // Expected format: uid^atype^third^inserter^matcher^mm^rtipartner const expectedEidValue = '11111^2^^inserter123^matcher123^mm123^rtipartner123'; @@ -1589,8 +1589,8 @@ describe('the rubicon adapter', function () { } }; - let [request] = spec.buildRequests([clonedBid], bidderRequest); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests([clonedBid], bidderRequest); + const data = new URLSearchParams(request.data); // Expected format: uid^atype^third^inserter^matcher^mm^rtipartner const expectedEidValue = '11111^2^^inserter123^matcher123^mm123^rtipartner123'; @@ -1607,8 +1607,8 @@ describe('the rubicon adapter', function () { clonedBid.userId = { pubcid: '1111' }; - let [request] = spec.buildRequests([clonedBid], bidderRequest); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests([clonedBid], bidderRequest); + const data = new URLSearchParams(request.data); expect(data.get('ppuid')).to.equal('123'); }); @@ -1972,11 +1972,11 @@ describe('the rubicon adapter', function () { } }); it('should send m_ch_* params if ortb2.device.sua object is there with igh entropy', function () { - let bidRequestSua = utils.deepClone(bidderRequest); + const bidRequestSua = utils.deepClone(bidderRequest); bidRequestSua.bids[0].ortb2 = { device: { sua: standardSuaObject } }; // How should fastlane query be constructed with default SUA - let expectedValues = { + const expectedValues = { m_ch_arch: 'x86', m_ch_bitness: '64', m_ch_ua: `"Not.A/Brand"|v="8","Chromium"|v="114","Google Chrome"|v="114"`, @@ -1987,8 +1987,8 @@ describe('the rubicon adapter', function () { } // Build Fastlane call - let [request] = spec.buildRequests(bidRequestSua.bids, bidRequestSua); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests(bidRequestSua.bids, bidRequestSua); + const data = new URLSearchParams(request.data); // Loop through expected values and if they do not match push an error const errors = Object.entries(expectedValues).reduce((accum, [key, val]) => { @@ -2000,7 +2000,7 @@ describe('the rubicon adapter', function () { expect(errors).to.deep.equal([]); }); it('should not send invalid values for m_ch_*', function () { - let bidRequestSua = utils.deepClone(bidderRequest); + const bidRequestSua = utils.deepClone(bidderRequest); // Alter input SUA object // send model @@ -2021,8 +2021,8 @@ describe('the rubicon adapter', function () { bidRequestSua.bids[0].ortb2 = { device: { sua: standardSuaObject } }; // Build Fastlane request - let [request] = spec.buildRequests(bidRequestSua.bids, bidRequestSua); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests(bidRequestSua.bids, bidRequestSua); + const data = new URLSearchParams(request.data); // should show new names expect(data.get('m_ch_model')).to.equal('Suface Duo'); @@ -2042,7 +2042,7 @@ describe('the rubicon adapter', function () { expect(data.get('m_ch_arch')).to.be.null; }); it('should not send high entropy if not present when it is low entropy client hints', function () { - let bidRequestSua = utils.deepClone(bidderRequest); + const bidRequestSua = utils.deepClone(bidderRequest); bidRequestSua.bids[0].ortb2 = { device: { sua: { 'source': 1, 'platform': { @@ -2072,15 +2072,15 @@ describe('the rubicon adapter', function () { } } }; // How should fastlane query be constructed with default SUA - let expectedValues = { + const expectedValues = { m_ch_ua: `"Not A(Brand"|v="8","Chromium"|v="132","Google Chrome"|v="132"`, m_ch_mobile: '?0', m_ch_platform: 'macOS', } // Build Fastlane call - let [request] = spec.buildRequests(bidRequestSua.bids, bidRequestSua); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests(bidRequestSua.bids, bidRequestSua); + const data = new URLSearchParams(request.data); // Loop through expected values and if they do not match push an error const errors = Object.entries(expectedValues).reduce((accum, [key, val]) => { @@ -2092,11 +2092,11 @@ describe('the rubicon adapter', function () { expect(errors).to.deep.equal([]); // make sure high entropy keys are not present - let highEntropyHints = ['m_ch_full_ver', 'm_ch_arch', 'm_ch_bitness', 'm_ch_platform_ver']; + const highEntropyHints = ['m_ch_full_ver', 'm_ch_arch', 'm_ch_bitness', 'm_ch_platform_ver']; highEntropyHints.forEach((hint) => { expect(data.get(hint)).to.be.null; }); }); it('should ignore invalid browser hints (missing version)', function () { - let bidRequestSua = utils.deepClone(bidderRequest); + const bidRequestSua = utils.deepClone(bidderRequest); bidRequestSua.bids[0].ortb2 = { device: { sua: { 'browsers': [ { @@ -2107,13 +2107,13 @@ describe('the rubicon adapter', function () { } } }; // How should fastlane query be constructed with default SUA - let expectedValues = { + const expectedValues = { m_ch_ua: `"Not A(Brand"|v="undefined"`, } // Build Fastlane call - let [request] = spec.buildRequests(bidRequestSua.bids, bidRequestSua); - let data = new URLSearchParams(request.data); + const [request] = spec.buildRequests(bidRequestSua.bids, bidRequestSua); + const data = new URLSearchParams(request.data); // Loop through expected values and if they do not match push an error const errors = Object.entries(expectedValues).reduce((accum, [key, val]) => { @@ -2125,7 +2125,7 @@ describe('the rubicon adapter', function () { expect(errors).to.deep.equal([]); // make sure high entropy keys are not present - let highEntropyHints = ['m_ch_full_ver']; + const highEntropyHints = ['m_ch_full_ver']; highEntropyHints.forEach((hint) => { expect(data.get(hint)).to.be.null; }); }); }); @@ -2140,12 +2140,12 @@ describe('the rubicon adapter', function () { bidderRequest.auctionStart + 100 ); - let [request] = spec.buildRequests(bidderRequest.bids, await addFPDToBidderRequest(bidderRequest)); - let post = request.data; + const [request] = spec.buildRequests(bidderRequest.bids, await addFPDToBidderRequest(bidderRequest)); + const post = request.data; expect(post).to.have.property('imp'); // .with.length.of(1); - let imp = post.imp[0]; + const imp = post.imp[0]; expect(imp.id).to.equal(bidderRequest.bids[0].adUnitCode); expect(imp.exp).to.equal(undefined); // now undefined expect(imp.video.w).to.equal(640); @@ -2240,12 +2240,12 @@ describe('the rubicon adapter', function () { } } - let [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); - let post = request.data; + const [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); + const post = request.data; expect(post).to.have.property('imp'); // .with.length.of(1); - let imp = post.imp[0]; + const imp = post.imp[0]; expect(imp.ext.gpid).to.equal('/test/gpid'); expect(imp.ext.data.pbadslot).to.equal('/test/pbadslot'); expect(imp.ext.prebid.storedauctionresponse.id).to.equal('sample_video_response'); @@ -2307,7 +2307,7 @@ describe('the rubicon adapter', function () { bidderRequest.auctionStart + 100 ); - let [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); + const [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); // should have an imp expect(request.data.imp).to.exist.and.to.be.a('array'); @@ -2323,7 +2323,7 @@ describe('the rubicon adapter', function () { adapterManager.aliasRegistry['superRubicon'] = 'rubicon'; bidderRequest.bidderCode = 'superRubicon'; bidderRequest.bids[0].bidder = 'superRubicon'; - let [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); + const [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); // should have the aliases object sent to PBS expect(request.data.ext.prebid).to.haveOwnProperty('aliases'); @@ -2336,7 +2336,7 @@ describe('the rubicon adapter', function () { it('should add floors flag correctly to PBS Request', function () { const bidderRequest = createVideoBidderRequest(); - let [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); + const [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); // should not pass if undefined expect(request.data.ext.prebid.floors).to.be.undefined; @@ -2346,7 +2346,7 @@ describe('the rubicon adapter', function () { skipped: false, location: 'fetch', } - let [newRequest] = spec.buildRequests(bidderRequest.bids, bidderRequest); + const [newRequest] = spec.buildRequests(bidderRequest.bids, bidderRequest); expect(newRequest.data.ext.prebid.floors).to.deep.equal({ enabled: false }); }); @@ -2370,7 +2370,7 @@ describe('the rubicon adapter', function () { config.setConfig({multibid: multibid}); - let [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); + const [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); // should have the aliases object sent to PBS expect(request.data.ext.prebid).to.haveOwnProperty('multibid'); @@ -2380,8 +2380,8 @@ describe('the rubicon adapter', function () { it('should pass client analytics to PBS endpoint if all modules included', function () { const bidderRequest = createVideoBidderRequest(); $$PREBID_GLOBAL$$.installedModules = []; - let [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); - let payload = request.data; + const [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); + const payload = request.data; expect(payload.ext.prebid.analytics).to.not.be.undefined; expect(payload.ext.prebid.analytics).to.deep.equal({'rubicon': {'client-analytics': true}}); @@ -2390,8 +2390,8 @@ describe('the rubicon adapter', function () { it('should pass client analytics to PBS endpoint if rubicon analytics adapter is included', function () { const bidderRequest = createVideoBidderRequest(); $$PREBID_GLOBAL$$.installedModules = ['rubiconBidAdapter', 'rubiconAnalyticsAdapter']; - let [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); - let payload = request.data; + const [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); + const payload = request.data; expect(payload.ext.prebid.analytics).to.not.be.undefined; expect(payload.ext.prebid.analytics).to.deep.equal({'rubicon': {'client-analytics': true}}); @@ -2400,19 +2400,19 @@ describe('the rubicon adapter', function () { it('should not pass client analytics to PBS endpoint if rubicon analytics adapter is not included', function () { const bidderRequest = createVideoBidderRequest(); $$PREBID_GLOBAL$$.installedModules = ['rubiconBidAdapter']; - let [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); - let payload = request.data; + const [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); + const payload = request.data; expect(payload.ext.prebid.analytics).to.be.undefined; }); it('should not send video exp at all if not set in s2sConfig config', function () { const bidderRequest = createVideoBidderRequest(); - let [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); - let post = request.data; + const [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); + const post = request.data; // should exp set to the right value according to config - let imp = post.imp[0]; + const imp = post.imp[0]; // bidderFactory stringifies request body before sending so removes undefined attributes: expect(imp.exp).to.equal(undefined); }); @@ -2420,8 +2420,8 @@ describe('the rubicon adapter', function () { it('should send tmax as the bidderRequest timeout value', function () { const bidderRequest = createVideoBidderRequest(); bidderRequest.timeout = 3333; - let [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); - let post = request.data; + const [request] = spec.buildRequests(bidderRequest.bids, bidderRequest); + const post = request.data; expect(post.tmax).to.equal(3333); }); @@ -2486,7 +2486,7 @@ describe('the rubicon adapter', function () { }); it('should properly enforce video.context to be either instream or outstream', function () { - let bid = bidderRequest.bids[0]; + const bid = bidderRequest.bids[0]; bid.mediaTypes = { video: { context: 'instream', @@ -2571,7 +2571,7 @@ describe('the rubicon adapter', function () { const bidRequestCopy = utils.deepClone(bidderRequest); - let [request] = spec.buildRequests(bidRequestCopy.bids, bidRequestCopy); + const [request] = spec.buildRequests(bidRequestCopy.bids, bidRequestCopy); expect(spec.isBidRequestValid(bidderRequest.bids[0])).to.equal(true); expect(request.data.imp[0].ext.prebid.bidder.rubicon.video.size_id).to.equal(203); }); @@ -2608,7 +2608,7 @@ describe('the rubicon adapter', function () { it('should send request as banner when invalid video bid in multiple mediaType bidRequest', function () { removeVideoParamFromBidderRequest(bidderRequest); - let bid = bidderRequest.bids[0]; + const bid = bidderRequest.bids[0]; bid.mediaTypes.banner = { sizes: [[300, 250]] }; @@ -2619,7 +2619,7 @@ describe('the rubicon adapter', function () { const bidRequestCopy = utils.deepClone(bidderRequest); - let requests = spec.buildRequests(bidRequestCopy.bids, bidRequestCopy); + const requests = spec.buildRequests(bidRequestCopy.bids, bidRequestCopy); expect(requests.length).to.equal(1); expect(requests[0].url).to.equal('https://fastlane.rubiconproject.com/a/api/fastlane.json'); }); @@ -2775,12 +2775,12 @@ describe('the rubicon adapter', function () { bidderRequest.auctionStart + 100 ); - let [request] = spec.buildRequests(bidderRequest.bids, await addFPDToBidderRequest(bidderRequest)); - let post = request.data; + const [request] = spec.buildRequests(bidderRequest.bids, await addFPDToBidderRequest(bidderRequest)); + const post = request.data; expect(post).to.have.property('imp') // .with.length.of(1); - let imp = post.imp[0]; + const imp = post.imp[0]; expect(imp.id).to.equal(bidderRequest.bids[0].adUnitCode); expect(imp.exp).to.equal(undefined); expect(imp.video.w).to.equal(640); @@ -2849,7 +2849,7 @@ describe('the rubicon adapter', function () { describe('createSlotParams', function () { it('should return a valid slot params object', function () { const localBidderRequest = Object.assign({}, bidderRequest); - let expectedQuery = { + const expectedQuery = { 'account_id': '14062', 'site_id': '70608', 'zone_id': '335918', @@ -3030,13 +3030,13 @@ describe('the rubicon adapter', function () { it('Should return false if both banner and video mediaTypes are set and params.video is not an object', function () { removeVideoParamFromBidderRequest(bidderRequest); - let bid = bidderRequest.bids[0]; + const bid = bidderRequest.bids[0]; bid.mediaTypes.banner = {flag: true}; expect(classifiedAsVideo(bid)).to.equal(false); }); it('Should return true if both banner and video mediaTypes are set and params.video is an object', function () { removeVideoParamFromBidderRequest(bidderRequest); - let bid = bidderRequest.bids[0]; + const bid = bidderRequest.bids[0]; bid.mediaTypes.banner = {flag: true}; bid.params.video = {}; expect(classifiedAsVideo(bid)).to.equal(true); @@ -3044,7 +3044,7 @@ describe('the rubicon adapter', function () { it('Should return true and create a params.video object if one is not already present', function () { removeVideoParamFromBidderRequest(bidderRequest); - let bid = bidderRequest.bids[0] + const bid = bidderRequest.bids[0] expect(classifiedAsVideo(bid)).to.equal(true); expect(bid.params.video).to.not.be.undefined; }); @@ -3058,7 +3058,7 @@ describe('the rubicon adapter', function () { bidReq.bids[0].params = { video: {} } - let [request] = spec.buildRequests(bidReq.bids, bidReq); + const [request] = spec.buildRequests(bidReq.bids, bidReq); expect(request.method).to.equal('POST'); expect(request.url).to.equal('https://prebid-server.rubiconproject.com/openrtb2/auction'); expect(request.data.imp).to.have.nested.property('[0].native'); @@ -3070,7 +3070,7 @@ describe('the rubicon adapter', function () { bidReq.bids[0].params = { position: 'atf' } - let [request] = spec.buildRequests(bidReq.bids, bidReq); + const [request] = spec.buildRequests(bidReq.bids, bidReq); expect(request.method).to.equal('POST'); expect(request.url).to.equal('https://prebid-server.rubiconproject.com/openrtb2/auction'); expect(request.data.imp).to.have.nested.property('[0].native'); @@ -3082,7 +3082,7 @@ describe('the rubicon adapter', function () { bidReq.bids[0].mediaTypes.banner = { sizes: [[300, 250]] } - let [request] = spec.buildRequests(bidReq.bids, bidReq); + const [request] = spec.buildRequests(bidReq.bids, bidReq); expect(request.method).to.equal('GET'); expect(request.url).to.include('https://fastlane.rubiconproject.com/a/api/fastlane.json'); }); @@ -3100,7 +3100,7 @@ describe('the rubicon adapter', function () { }, params: bidReq.bids[0].params }) - let [request1, request2] = spec.buildRequests(bidReq.bids, bidReq); + const [request1, request2] = spec.buildRequests(bidReq.bids, bidReq); expect(request1.method).to.equal('POST'); expect(request1.url).to.equal('https://prebid-server.rubiconproject.com/openrtb2/auction'); expect(request1.data.imp).to.have.nested.property('[0].native'); @@ -3121,7 +3121,7 @@ describe('the rubicon adapter', function () { } }; bidReq.bids[0].params.bidonmultiformat = true; - let [pbsRequest, fastlanteRequest] = spec.buildRequests(bidReq.bids, bidReq); + const [pbsRequest, fastlanteRequest] = spec.buildRequests(bidReq.bids, bidReq); expect(pbsRequest.method).to.equal('POST'); expect(pbsRequest.url).to.equal('https://prebid-server.rubiconproject.com/openrtb2/auction'); expect(pbsRequest.data.imp).to.have.nested.property('[0].native'); @@ -3138,7 +3138,7 @@ describe('the rubicon adapter', function () { } }; bidReq.bids[0].params.bidonmultiformat = true; - let [pbsRequest, fastlanteRequest] = spec.buildRequests(bidReq.bids, bidReq); + const [pbsRequest, fastlanteRequest] = spec.buildRequests(bidReq.bids, bidReq); expect(pbsRequest.data.imp[0].ext.prebid.bidder.rubicon.formats).to.deep.equal(['native', 'banner']); }); @@ -3152,8 +3152,8 @@ describe('the rubicon adapter', function () { } }; bidReq.bids[0].params.bidonmultiformat = true; - let [pbsRequest, fastlanteRequest] = spec.buildRequests(bidReq.bids, bidReq); - let formatsIncluded = fastlanteRequest.data.indexOf('formats=native%2Cbanner') !== -1; + const [pbsRequest, fastlanteRequest] = spec.buildRequests(bidReq.bids, bidReq); + const formatsIncluded = fastlanteRequest.data.indexOf('formats=native%2Cbanner') !== -1; expect(formatsIncluded).to.equal(true); }); }); @@ -3168,7 +3168,7 @@ describe('the rubicon adapter', function () { } }; - let [fastlanteRequest, ...others] = spec.buildRequests(bidReq.bids, bidReq); + const [fastlanteRequest, ...others] = spec.buildRequests(bidReq.bids, bidReq); expect(fastlanteRequest.url).to.equal('https://fastlane.rubiconproject.com/a/api/fastlane.json'); expect(others).to.be.empty; }); @@ -3186,7 +3186,7 @@ describe('the rubicon adapter', function () { bidReq.bids[0].params = { video: {} } - let [fastlaneRequest, ...other] = spec.buildRequests(bidReq.bids, bidReq); + const [fastlaneRequest, ...other] = spec.buildRequests(bidReq.bids, bidReq); expect(fastlaneRequest.method).to.equal('GET'); expect(fastlaneRequest.url).to.equal('https://fastlane.rubiconproject.com/a/api/fastlane.json'); expect(other).to.be.empty; @@ -3214,7 +3214,7 @@ describe('the rubicon adapter', function () { describe('interpretResponse', function () { describe('for fastlane', function () { it('should handle a success response and sort by cpm', function () { - let response = { + const response = { 'status': 'ok', 'account_id': 14062, 'site_id': 70608, @@ -3273,7 +3273,7 @@ describe('the rubicon adapter', function () { ] }; - let bids = spec.interpretResponse({body: response}, { + const bids = spec.interpretResponse({body: response}, { bidRequest: bidderRequest.bids[0] }); @@ -3313,7 +3313,7 @@ describe('the rubicon adapter', function () { }); it('should pass netRevenue correctly if set in setConfig', function () { - let response = { + const response = { 'status': 'ok', 'account_id': 14062, 'site_id': 70608, @@ -3425,7 +3425,7 @@ describe('the rubicon adapter', function () { config.resetConfig(); }); it('should use "network-advertiser" if no creative_id', function () { - let response = { + const response = { 'status': 'ok', 'account_id': 14062, 'site_id': 70608, @@ -3548,7 +3548,7 @@ describe('the rubicon adapter', function () { }); it('should be fine with a CPM of 0', function () { - let response = { + const response = { 'status': 'ok', 'account_id': 14062, 'site_id': 70608, @@ -3566,7 +3566,7 @@ describe('the rubicon adapter', function () { }] }; - let bids = spec.interpretResponse({body: response}, { + const bids = spec.interpretResponse({body: response}, { bidRequest: bidderRequest.bids[0] }); @@ -3575,7 +3575,7 @@ describe('the rubicon adapter', function () { }); it('should handle DSA object from response', function() { - let response = { + const response = { 'status': 'ok', 'account_id': 14062, 'site_id': 70608, @@ -3643,7 +3643,7 @@ describe('the rubicon adapter', function () { } ] }; - let bids = spec.interpretResponse({body: response}, { + const bids = spec.interpretResponse({body: response}, { bidRequest: bidderRequest.bids[0] }); expect(bids).to.be.lengthOf(2); @@ -3655,7 +3655,7 @@ describe('the rubicon adapter', function () { }) it('should create bids with matching requestIds if imp id matches', function () { - let bidRequests = [{ + const bidRequests = [{ 'bidder': 'rubicon', 'params': { 'accountId': 1001, @@ -3705,7 +3705,7 @@ describe('the rubicon adapter', function () { 'startTime': 1615412098213 }]; - let response = { + const response = { 'status': 'ok', 'account_id': 14062, 'site_id': 70608, @@ -3785,7 +3785,7 @@ describe('the rubicon adapter', function () { config.setConfig({ multibid: [{bidder: 'rubicon', maxbids: 2, targetbiddercodeprefix: 'rubi'}] }); - let bids = spec.interpretResponse({body: response}, { + const bids = spec.interpretResponse({body: response}, { bidRequest: bidRequests }); @@ -3795,7 +3795,7 @@ describe('the rubicon adapter', function () { }); it('should handle an error with no ads returned', function () { - let response = { + const response = { 'status': 'ok', 'account_id': 14062, 'site_id': 70608, @@ -3809,7 +3809,7 @@ describe('the rubicon adapter', function () { 'ads': [] }; - let bids = spec.interpretResponse({body: response}, { + const bids = spec.interpretResponse({body: response}, { bidRequest: bidderRequest.bids[0] }); @@ -3817,7 +3817,7 @@ describe('the rubicon adapter', function () { }); it('Should support recieving an auctionConfig and pass it along to Prebid', function () { - let response = { + const response = { 'status': 'ok', 'account_id': 14062, 'site_id': 70608, @@ -3843,7 +3843,7 @@ describe('the rubicon adapter', function () { }] }; - let {bids, paapi} = spec.interpretResponse({body: response}, { + const {bids, paapi} = spec.interpretResponse({body: response}, { bidRequest: bidderRequest.bids[0] }); @@ -3854,7 +3854,7 @@ describe('the rubicon adapter', function () { }); it('should handle an error', function () { - let response = { + const response = { 'status': 'ok', 'account_id': 14062, 'site_id': 70608, @@ -3870,7 +3870,7 @@ describe('the rubicon adapter', function () { }] }; - let bids = spec.interpretResponse({body: response}, { + const bids = spec.interpretResponse({body: response}, { bidRequest: bidderRequest.bids[0] }); @@ -3878,9 +3878,9 @@ describe('the rubicon adapter', function () { }); it('should handle an error because of malformed json response', function () { - let response = '{test{'; + const response = '{test{'; - let bids = spec.interpretResponse({body: response}, { + const bids = spec.interpretResponse({body: response}, { bidRequest: bidderRequest.bids[0] }); @@ -3888,7 +3888,7 @@ describe('the rubicon adapter', function () { }); it('should handle a bidRequest argument of type Array', function () { - let response = { + const response = { 'status': 'ok', 'account_id': 14062, 'site_id': 70608, @@ -3906,7 +3906,7 @@ describe('the rubicon adapter', function () { }] }; - let bids = spec.interpretResponse({body: response}, { + const bids = spec.interpretResponse({body: response}, { bidRequest: [utils.deepClone(bidderRequest.bids[0])] }); @@ -3915,7 +3915,7 @@ describe('the rubicon adapter', function () { }); it('should use ads.emulated_format if defined for bid.meta.mediaType', function () { - let response = { + const response = { 'status': 'ok', 'account_id': 14062, 'site_id': 70608, @@ -3972,7 +3972,7 @@ describe('the rubicon adapter', function () { } ] }; - let bids = spec.interpretResponse({body: response}, { + const bids = spec.interpretResponse({body: response}, { bidRequest: bidderRequest.bids[0] }); expect(bids[0].meta.mediaType).to.equal('banner'); @@ -4137,7 +4137,7 @@ describe('the rubicon adapter', function () { describe('for video', function () { it('should register a successful bid', function () { const bidderRequest = createVideoBidderRequest(); - let response = { + const response = { cur: 'USD', seatbid: [{ bid: [{ @@ -4169,7 +4169,7 @@ describe('the rubicon adapter', function () { const request = converter.toORTB({bidderRequest, bidRequests: bidderRequest.bids}); - let bids = spec.interpretResponse({body: response}, {data: request}); + const bids = spec.interpretResponse({body: response}, {data: request}); expect(bids).to.be.lengthOf(1); @@ -4196,17 +4196,17 @@ describe('the rubicon adapter', function () { it('should get a native bid', () => { const nativeBidderRequest = addNativeToBidRequest(bidderRequest); const request = converter.toORTB({bidderRequest: nativeBidderRequest, bidRequests: nativeBidderRequest.bids}); - let response = getNativeResponse({impid: request.imp[0].id}); - let bids = spec.interpretResponse({body: response}, {data: request}); + const response = getNativeResponse({impid: request.imp[0].id}); + const bids = spec.interpretResponse({body: response}, {data: request}); expect(bids).to.have.nested.property('[0].native'); }); it('should set 0 to bids width and height if `w` and `h` in response object not defined', () => { const nativeBidderRequest = addNativeToBidRequest(bidderRequest); const request = converter.toORTB({bidderRequest: nativeBidderRequest, bidRequests: nativeBidderRequest.bids}); - let response = getNativeResponse({impid: request.imp[0].id}); + const response = getNativeResponse({impid: request.imp[0].id}); delete response.seatbid[0].bid[0].w; delete response.seatbid[0].bid[0].h - let bids = spec.interpretResponse({body: response}, {data: request}); + const bids = spec.interpretResponse({body: response}, {data: request}); expect(bids[0].width).to.equal(0); expect(bids[0].height).to.equal(0); }); @@ -4239,7 +4239,7 @@ describe('the rubicon adapter', function () { it('should register a successful bid', function () { const bidderRequest = createVideoBidderRequestOutstream(); - let response = { + const response = { cur: 'USD', seatbid: [{ bid: [{ @@ -4271,7 +4271,7 @@ describe('the rubicon adapter', function () { const request = converter.toORTB({bidderRequest, bidRequests: bidderRequest.bids}); - let bids = spec.interpretResponse({body: response}, { data: request }); + const bids = spec.interpretResponse({body: response}, { data: request }); expect(bids).to.be.lengthOf(1); @@ -4301,7 +4301,7 @@ describe('the rubicon adapter', function () { it('should render ad with Magnite renderer', function () { const bidderRequest = createVideoBidderRequestOutstream(); - let response = { + const response = { cur: 'USD', seatbid: [{ bid: [{ @@ -4336,7 +4336,7 @@ describe('the rubicon adapter', function () { sinon.spy(window.MagniteApex, 'renderAd'); - let bids = spec.interpretResponse({body: response}, {data: request}); + const bids = spec.interpretResponse({body: response}, {data: request}); const bid = bids[0]; bid.adUnitCode = 'outstream_video1_placement'; const adUnit = document.createElement('div'); @@ -4371,7 +4371,7 @@ describe('the rubicon adapter', function () { bidderRequest.bids[0].mediaTypes.video.placement = 3; bidderRequest.bids[0].mediaTypes.video.playerSize = [640, 480]; - let response = { + const response = { cur: 'USD', seatbid: [{ bid: [{ @@ -4406,7 +4406,7 @@ describe('the rubicon adapter', function () { sinon.spy(window.MagniteApex, 'renderAd'); - let bids = spec.interpretResponse({body: response}, {data: request}); + const bids = spec.interpretResponse({body: response}, {data: request}); const bid = bids[0]; bid.adUnitCode = 'outstream_video1_placement'; const adUnit = document.createElement('div'); @@ -4454,7 +4454,7 @@ describe('the rubicon adapter', function () { }); it('should register the Emily iframe', function () { - let syncs = spec.getUserSyncs({ + const syncs = spec.getUserSyncs({ iframeEnabled: true }); @@ -4740,19 +4740,19 @@ describe('the rubicon adapter', function () { // banner const bannerBidderRequest = createGdprBidderRequest(false); - let [bannerRequest] = spec.buildRequests(bannerBidderRequest.bids, bannerBidderRequest); + const [bannerRequest] = spec.buildRequests(bannerBidderRequest.bids, bannerBidderRequest); expect(bannerRequest.url).to.equal('https://fastlane-qa.rubiconproject.com/a/api/fastlane.json'); // video and returnVast const videoBidderRequest = createVideoBidderRequest(); - let [videoRequest] = spec.buildRequests(videoBidderRequest.bids, videoBidderRequest); - let post = videoRequest.data; + const [videoRequest] = spec.buildRequests(videoBidderRequest.bids, videoBidderRequest); + const post = videoRequest.data; expect(videoRequest.url).to.equal('https://prebid-server-qa.rubiconproject.com/openrtb2/auction'); expect(post.ext.prebid.cache.vastxml).to.have.property('returnCreative').that.is.an('boolean'); expect(post.ext.prebid.cache.vastxml.returnCreative).to.equal(true); // user sync - let syncs = spec.getUserSyncs({ + const syncs = spec.getUserSyncs({ iframeEnabled: true }); expect(syncs).to.deep.equal({type: 'iframe', url: 'https://eus-qa.rubiconproject.com/usync.html'}); diff --git a/test/spec/modules/scatteredBidAdapter_spec.js b/test/spec/modules/scatteredBidAdapter_spec.js index aadebbdfecd..8e6312fe140 100644 --- a/test/spec/modules/scatteredBidAdapter_spec.js +++ b/test/spec/modules/scatteredBidAdapter_spec.js @@ -5,7 +5,7 @@ import { deepClone, mergeDeep } from '../../../src/utils'; describe('Scattered adapter', function () { describe('isBidRequestValid', function () { // A valid bid - let validBid = { + const validBid = { bidder: 'scattered', mediaTypes: { banner: { @@ -25,14 +25,14 @@ describe('Scattered adapter', function () { }); it('should skip if bidderDomain info is missing', function () { - let bid = deepClone(validBid); + const bid = deepClone(validBid); delete bid.params.bidderDomain; assert.isFalse(spec.isBidRequestValid(bid)); }); it('should expect at least one banner size', function () { - let bid = deepClone(validBid); + const bid = deepClone(validBid); delete bid.mediaTypes.banner; assert.isFalse(spec.isBidRequestValid(bid)); @@ -88,21 +88,21 @@ describe('Scattered adapter', function () { }); it('should validate request format', function () { - let request = spec.buildRequests(arrayOfValidBidRequests, validBidderRequest); + const request = spec.buildRequests(arrayOfValidBidRequests, validBidderRequest); assert.equal(request.method, 'POST'); assert.deepEqual(request.options, { contentType: 'application/json' }); assert.ok(request.data); }); it('has the right fields filled', function () { - let request = spec.buildRequests(arrayOfValidBidRequests, validBidderRequest); + const request = spec.buildRequests(arrayOfValidBidRequests, validBidderRequest); const bidderRequest = request.data; assert.ok(bidderRequest.site); assert.lengthOf(bidderRequest.imp, 1); }); it('should configure the site object', function () { - let request = spec.buildRequests(arrayOfValidBidRequests, validBidderRequest); + const request = spec.buildRequests(arrayOfValidBidRequests, validBidderRequest); const site = request.data.site; assert.equal(site.publisher.name, validBidderRequest.ortb2.site.publisher.name) }); @@ -119,7 +119,7 @@ describe('Scattered adapter', function () { } }); - let request = spec.buildRequests(arrayOfValidBidRequests, req); + const request = spec.buildRequests(arrayOfValidBidRequests, req); const site = request.data.site; assert.deepEqual(site, { id: '876', @@ -136,7 +136,7 @@ describe('Scattered adapter', function () { device: { w: 375, h: 273 } }); - let request = spec.buildRequests(arrayOfValidBidRequests, validBidderRequest); + const request = spec.buildRequests(arrayOfValidBidRequests, validBidderRequest); assert.equal(request.device.ua, navigator.userAgent); assert.equal(request.device.w, 375); @@ -170,7 +170,7 @@ describe('interpretResponse', function () { } }; - let bidderRequest = { + const bidderRequest = { bids: [ { bidId: '123', diff --git a/test/spec/modules/seedingAllianceAdapter_spec.js b/test/spec/modules/seedingAllianceAdapter_spec.js index ab5163f90a2..550ee2df073 100755 --- a/test/spec/modules/seedingAllianceAdapter_spec.js +++ b/test/spec/modules/seedingAllianceAdapter_spec.js @@ -5,14 +5,14 @@ import {spec} from 'modules/seedingAllianceBidAdapter.js'; describe('SeedingAlliance adapter', function () { let serverResponse, bidRequest, bidResponses; - let bid = { + const bid = { 'bidder': 'seedingAlliance', 'params': { 'adUnitId': '1hq8' } }; - let validBidRequests = [{ + const validBidRequests = [{ bidId: 'bidId', params: {}, mediaType: { @@ -33,33 +33,33 @@ describe('SeedingAlliance adapter', function () { describe('buildRequests', function () { it('should send request with correct structure', function () { - let request = spec.buildRequests(validBidRequests, { refererInfo: { referer: 'page' } }); + const request = spec.buildRequests(validBidRequests, { refererInfo: { referer: 'page' } }); assert.equal(request.method, 'POST'); assert.ok(request.data); }); it('should have default request structure', function () { - let keys = 'site,cur,imp,regs'.split(','); - let request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { referer: 'page' } }).data); - let data = Object.keys(request); + const keys = 'site,cur,imp,regs'.split(','); + const request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { referer: 'page' } }).data); + const data = Object.keys(request); assert.includeDeepMembers(data, keys); }); it('Verify the site url', function () { - let siteUrl = 'https://www.yourdomain.tld/your-directory/'; + const siteUrl = 'https://www.yourdomain.tld/your-directory/'; validBidRequests[0].params.url = siteUrl; - let request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { referer: 'page' } }).data); + const request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { referer: 'page' } }).data); assert.equal(request.site.page, siteUrl); }); }); describe('check user ID functionality', function () { - let storage = getStorageManager({ bidderCode: 'seedingAlliance' }); - let localStorageIsEnabledStub = sinon.stub(storage, 'localStorageIsEnabled'); - let getDataFromLocalStorageStub = sinon.stub(storage, 'getDataFromLocalStorage'); + const storage = getStorageManager({ bidderCode: 'seedingAlliance' }); + const localStorageIsEnabledStub = sinon.stub(storage, 'localStorageIsEnabled'); + const getDataFromLocalStorageStub = sinon.stub(storage, 'getDataFromLocalStorage'); const bidRequests = [{ bidId: 'bidId', params: {} @@ -130,7 +130,7 @@ describe('SeedingAlliance adapter', function () { }; localStorageIsEnabledStub.returns(true); - let nativendoUserEid = { source: 'nativendo.de', uids: [{ id: '123', atype: 1 }] }; + const nativendoUserEid = { source: 'nativendo.de', uids: [{ id: '123', atype: 1 }] }; storage.setDataInLocalStorage('nativendo_id', '123'); request = JSON.parse(spec.buildRequests(bidRequests, bidderRequest).data); diff --git a/test/spec/modules/setupadBidAdapter_spec.js b/test/spec/modules/setupadBidAdapter_spec.js index 3a184c50922..0448ee8d231 100644 --- a/test/spec/modules/setupadBidAdapter_spec.js +++ b/test/spec/modules/setupadBidAdapter_spec.js @@ -287,8 +287,8 @@ describe('SetupadAdapter', function () { describe('interpretResponse', function () { it('should return empty array if error during parsing', () => { const wrongServerResponse = 'wrong data'; - let request = spec.buildRequests(bidRequests, bidderRequest); - let result = spec.interpretResponse(wrongServerResponse, request); + const request = spec.buildRequests(bidRequests, bidderRequest); + const result = spec.interpretResponse(wrongServerResponse, request); expect(result).to.be.instanceof(Array); expect(result.length).to.equal(0); diff --git a/test/spec/modules/sharedIdSystem_spec.js b/test/spec/modules/sharedIdSystem_spec.js index 4310956e509..c258e2ad4f7 100644 --- a/test/spec/modules/sharedIdSystem_spec.js +++ b/test/spec/modules/sharedIdSystem_spec.js @@ -1,13 +1,13 @@ -import {sharedIdSystemSubmodule, storage} from 'modules/sharedIdSystem.js'; +import {sharedIdSystemSubmodule} from 'modules/sharedIdSystem.js'; import {config} from 'src/config.js'; import sinon from 'sinon'; import * as utils from 'src/utils.js'; import {createEidsArray} from '../../../modules/userId/eids.js'; -import {attachIdSystem, init} from '../../../modules/userId/index.js'; +import {attachIdSystem} from '../../../modules/userId/index.js'; import {getGlobal} from '../../../src/prebidGlobal.js'; -let expect = require('chai').expect; +const expect = require('chai').expect; describe('SharedId System', function () { const UUID = '15fde1dc-1861-4894-afdf-b757272f3568'; @@ -37,7 +37,7 @@ describe('SharedId System', function () { }); it('should call UUID', function () { - let config = { + const config = { storage: { type: 'cookie', name: '_pubcid', @@ -45,7 +45,7 @@ describe('SharedId System', function () { } }; - let submoduleCallback = sharedIdSystemSubmodule.getId(config, undefined).callback; + const submoduleCallback = sharedIdSystemSubmodule.getId(config, undefined).callback; submoduleCallback(callbackSpy); expect(callbackSpy.calledOnce).to.be.true; expect(callbackSpy.lastCall.lastArg).to.equal(UUID); @@ -68,7 +68,7 @@ describe('SharedId System', function () { sandbox.restore(); }); it('should call UUID', function () { - let config = { + const config = { params: { extend: true }, @@ -78,7 +78,7 @@ describe('SharedId System', function () { expires: 10 } }; - let pubcommId = sharedIdSystemSubmodule.extendId(config, undefined, 'TestId').id; + const pubcommId = sharedIdSystemSubmodule.extendId(config, undefined, 'TestId').id; expect(pubcommId).to.equal('TestId'); }); it('should abort if coppa is set', function () { @@ -117,7 +117,7 @@ describe('SharedId System', function () { }] } }); - await getGlobal().getUserIdsAsync(); + await getGlobal().refreshUserIds(); const eids = getGlobal().getUserIdsAsEids(); sinon.assert.match(eids[0], { source: 'pubcid.org', diff --git a/test/spec/modules/showheroes-bsBidAdapter_spec.js b/test/spec/modules/showheroes-bsBidAdapter_spec.js index 0a1462d9b66..564df497628 100644 --- a/test/spec/modules/showheroes-bsBidAdapter_spec.js +++ b/test/spec/modules/showheroes-bsBidAdapter_spec.js @@ -264,13 +264,13 @@ describe('shBidAdapter', () => { }] it('empty', function () { - let result = spec.getUserSyncs({}, []); + const result = spec.getUserSyncs({}, []); expect(result).to.deep.equal([]); }); it('iframe', function () { - let result = spec.getUserSyncs({ + const result = spec.getUserSyncs({ iframeEnabled: true }, response); @@ -279,7 +279,7 @@ describe('shBidAdapter', () => { }); it('pixel', function () { - let result = spec.getUserSyncs({ + const result = spec.getUserSyncs({ pixelEnabled: true }, response); diff --git a/test/spec/modules/silvermobBidAdapter_spec.js b/test/spec/modules/silvermobBidAdapter_spec.js index b967efdd9b5..21cdea24d18 100644 --- a/test/spec/modules/silvermobBidAdapter_spec.js +++ b/test/spec/modules/silvermobBidAdapter_spec.js @@ -10,7 +10,7 @@ import 'src/prebid.js'; import 'modules/currency.js'; import 'modules/userId/index.js'; import 'modules/multibid/index.js'; -import 'modules/priceFloors.js'; + import 'modules/consentManagementTcf.js'; import 'modules/consentManagementUsp.js'; @@ -192,7 +192,7 @@ describe('silvermobAdapter', function () { }); it('should return false when zoneid is missing', function () { - let localbid = Object.assign({}, BANNER_BID_REQUEST); + const localbid = Object.assign({}, BANNER_BID_REQUEST); delete localbid.params.zoneid; expect(spec.isBidRequestValid(BANNER_BID_REQUEST)).to.equal(false); }); @@ -264,7 +264,7 @@ describe('silvermobAdapter', function () { it('Empty response must return empty array', function () { const emptyResponse = null; - let response = spec.interpretResponse(emptyResponse, BANNER_BID_REQUEST); + const response = spec.interpretResponse(emptyResponse, BANNER_BID_REQUEST); expect(response).to.be.an('array').that.is.empty; }) diff --git a/test/spec/modules/silverpushBidAdapter_spec.js b/test/spec/modules/silverpushBidAdapter_spec.js index de31135eabe..204c59e3f20 100644 --- a/test/spec/modules/silverpushBidAdapter_spec.js +++ b/test/spec/modules/silverpushBidAdapter_spec.js @@ -253,36 +253,36 @@ describe('Silverpush Adapter', function () { describe('getOS()', () => { it('shold return correct os name for Windows', () => { - let userAgent = 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2311.135 Safari/537.36 Edge/12.246'; - let osName = spec.getOS(userAgent); + const userAgent = 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2311.135 Safari/537.36 Edge/12.246'; + const osName = spec.getOS(userAgent); expect(osName).to.equal('Windows'); }); it('shold return correct os name for Mac OS', () => { - let userAgent = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_2) AppleWebKit/601.3.9 (KHTML, like Gecko) Version/9.0.2 Safari/601.3.9'; - let osName = spec.getOS(userAgent); + const userAgent = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_2) AppleWebKit/601.3.9 (KHTML, like Gecko) Version/9.0.2 Safari/601.3.9'; + const osName = spec.getOS(userAgent); expect(osName).to.equal('macOS'); }); it('shold return correct os name for Android', () => { - let userAgent = 'Mozilla/5.0 (Linux; Android 10; SM-G996U Build/QP1A.190711.020; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Mobile Safari/537.36'; - let osName = spec.getOS(userAgent); + const userAgent = 'Mozilla/5.0 (Linux; Android 10; SM-G996U Build/QP1A.190711.020; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Mobile Safari/537.36'; + const osName = spec.getOS(userAgent); expect(osName).to.equal('Android'); }); it('shold return correct os name for ios', () => { - let userAgent = 'Mozilla/5.0 (iPhone14,3; U; CPU iPhone OS 15_0 like Mac OS X) AppleWebKit/602.1.50 (KHTML, like Gecko) Version/10.0 Mobile/19A346 Safari/602.1'; - let osName = spec.getOS(userAgent); + const userAgent = 'Mozilla/5.0 (iPhone14,3; U; CPU iPhone OS 15_0 like Mac OS X) AppleWebKit/602.1.50 (KHTML, like Gecko) Version/10.0 Mobile/19A346 Safari/602.1'; + const osName = spec.getOS(userAgent); expect(osName).to.equal('iOS'); }); it('shold return correct os name for Linux', () => { - let userAgent = 'Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:15.0) Gecko/20100101 Firefox/15.0.1'; - let osName = spec.getOS(userAgent); + const userAgent = 'Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:15.0) Gecko/20100101 Firefox/15.0.1'; + const osName = spec.getOS(userAgent); expect(osName).to.equal('Linux'); }); diff --git a/test/spec/modules/sirdataRtdProvider_spec.js b/test/spec/modules/sirdataRtdProvider_spec.js index 9f6bb30e0b0..da7c8756cc8 100644 --- a/test/spec/modules/sirdataRtdProvider_spec.js +++ b/test/spec/modules/sirdataRtdProvider_spec.js @@ -40,13 +40,13 @@ describe('sirdataRtdProvider', function () { describe('Sanitize content', function () { it('removes PII from content', function () { - let doc = document.implementation.createHTMLDocument(''); - let div = doc.createElement('div'); + const doc = document.implementation.createHTMLDocument(''); + const div = doc.createElement('div'); div.className = 'test'; div.setAttribute('test', 'test'); div.textContent = 'My email is test@test.com, My bank account number is 123456789012, my SSN is 123-45-6789, and my credit card number is 1234 5678 9101 1121.Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum. Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.'; - let div2 = doc.createElement('div'); - let div3 = doc.createElement('div'); + const div2 = doc.createElement('div'); + const div3 = doc.createElement('div'); div3.innerText = 'hello'; div2.appendChild(div3); div.appendChild(div2); @@ -61,7 +61,7 @@ describe('sirdataRtdProvider', function () { describe('setUidInStorage', function () { it('sets Id in Storage', function () { setUidInStorage('123456789'); - let val = getUidFromStorage(); + const val = getUidFromStorage(); expect(val).to.deep.equal([{source: 'sddan.com', uids: [{id: '123456789', atype: 1}]}]); }); }); @@ -84,15 +84,15 @@ describe('sirdataRtdProvider', function () { resString = onDocumentReady(testString); } catch (e) {} expect(resString).to.be.false; - let resFunction = onDocumentReady(testFunction); + const resFunction = onDocumentReady(testFunction); expect(resFunction).to.be.true; }); }); describe('postContentForSemanticAnalysis', function () { it('gets content for analysis', function () { - let res = postContentForSemanticAnalysis('1223456', 'https://www.sirdata.com/'); - let resEmpty = postContentForSemanticAnalysis('1223456', ''); + const res = postContentForSemanticAnalysis('1223456', 'https://www.sirdata.com/'); + const resEmpty = postContentForSemanticAnalysis('1223456', ''); expect(res).to.be.true; expect(resEmpty).to.be.false; }); @@ -134,7 +134,7 @@ describe('sirdataRtdProvider', function () { }; sirdataSubmodule.init(firstConfig); - let adUnits = [ + const adUnits = [ { bids: [{ bidder: 'appnexus', @@ -147,14 +147,14 @@ describe('sirdataRtdProvider', function () { } ]; - let firstReqBidsConfigObj = { + const firstReqBidsConfigObj = { adUnits: adUnits, ortb2Fragments: { global: {} } }; - let firstData = { + const firstData = { segments: [111111, 222222], contextual_categories: {'333333': 100}, 'segtaxid': null, @@ -215,7 +215,7 @@ describe('sirdataRtdProvider', function () { }; sirdataSubmodule.init(config); - let reqBidsConfigObj = { + const reqBidsConfigObj = { adUnits: [{ bids: [{ bidder: 'appnexus', @@ -276,7 +276,7 @@ describe('sirdataRtdProvider', function () { } }; - let data = { + const data = { 'segments': [111111, 222222], 'segtaxid': null, 'cattaxid': null, @@ -310,7 +310,7 @@ describe('sirdataRtdProvider', function () { getSegmentsAndCategories(reqBidsConfigObj, () => { }, {}, {}); - let request = server.requests[0]; + const request = server.requests[0]; request.respond(200, responseHeader, JSON.stringify(data)); expect(reqBidsConfigObj.ortb2Fragments.global.site.content.data[0].name).to.equal( @@ -335,7 +335,7 @@ describe('sirdataRtdProvider', function () { describe('Set ortb2 for bidder', function () { it('set ortb2 for a givent bidder', function () { - let reqBidsConfigObj = { + const reqBidsConfigObj = { adUnits: [{ bids: [{ bidder: 'appnexus', diff --git a/test/spec/modules/sizeMappingV2_spec.js b/test/spec/modules/sizeMappingV2_spec.js index 4a523c784d9..b384e21debe 100644 --- a/test/spec/modules/sizeMappingV2_spec.js +++ b/test/spec/modules/sizeMappingV2_spec.js @@ -1,6 +1,6 @@ import { expect } from 'chai'; import * as utils from '../../../src/utils.js'; -import { internal as utilInternal } from '../../../src/utils.js'; +import { internal as utilInternal, deepClone } from '../../../src/utils.js'; import { isUsingNewSizeMapping, checkAdUnitSetupHook, @@ -17,7 +17,6 @@ import { } from '../../../modules/sizeMappingV2.js'; import { adUnitSetupChecks } from '../../../src/prebid.js'; -import {deepClone} from '../../../src/utils.js'; const AD_UNITS = [{ code: 'div-gpt-ad-1460505748561-0', @@ -175,7 +174,7 @@ describe('sizeMappingV2', function () { }); it('should return "true" if sizeConfig is declared both at the adUnits level and at the bids level', function () { - let adUnits = utils.deepClone(AD_UNITS); + const adUnits = utils.deepClone(AD_UNITS); const usingNewSizeMappingBool = isUsingNewSizeMapping(adUnits); @@ -236,7 +235,7 @@ describe('sizeMappingV2', function () { }); it('should log an error message if mediaTypes.banner does not contain "sizes" or "sizeConfig" property', function () { - let adUnits = utils.deepClone(AD_UNITS); + const adUnits = utils.deepClone(AD_UNITS); // deleteing the sizeConfig property from the first ad unit. delete adUnits[0].mediaTypes.banner.sizeConfig; diff --git a/test/spec/modules/sizeMapping_spec.js b/test/spec/modules/sizeMapping_spec.js index 40e0831f0a5..795e87e72f5 100644 --- a/test/spec/modules/sizeMapping_spec.js +++ b/test/spec/modules/sizeMapping_spec.js @@ -1,8 +1,8 @@ import {expect} from 'chai'; import {resolveStatus, setSizeConfig, sizeSupported} from 'modules/sizeMapping.js'; -let utils = require('src/utils.js'); -let deepClone = utils.deepClone; +const utils = require('src/utils.js'); +const deepClone = utils.deepClone; describe('sizeMapping', function () { var sizeConfig = [{ @@ -76,7 +76,7 @@ describe('sizeMapping', function () { }); it('should log a warning when mediaQuery property missing from sizeConfig', function () { - let errorConfig = deepClone(sizeConfig); + const errorConfig = deepClone(sizeConfig); delete errorConfig[0].mediaQuery; @@ -128,7 +128,7 @@ describe('sizeMapping', function () { it('when one mediaQuery block matches, it should filter the adUnit.sizes passed in', function () { matchMediaOverride = (str) => str === '(min-width: 1200px)' ? {matches: true} : {matches: false}; - let status = resolveStatus(undefined, mediaTypes, sizeConfig); + const status = resolveStatus(undefined, mediaTypes, sizeConfig); expect(status.active).to.equal(true); expect(getSizes(status.mediaTypes)).to.deep.equal( @@ -142,7 +142,7 @@ describe('sizeMapping', function () { '(min-width: 768px) and (max-width: 1199px)' ].includes(str) ? {matches: true} : {matches: false}; - let status = resolveStatus(undefined, mediaTypes, sizeConfig); + const status = resolveStatus(undefined, mediaTypes, sizeConfig); expect(status.active).to.equal(true); expect(getSizes(status.mediaTypes)).to.deep.equal( [[970, 90], [728, 90], [300, 250], [300, 100]] @@ -152,7 +152,7 @@ describe('sizeMapping', function () { it('if no mediaQueries match, it should allow all sizes specified', function () { matchMediaOverride = () => ({matches: false}); - let status = resolveStatus(undefined, mediaTypes, sizeConfig); + const status = resolveStatus(undefined, mediaTypes, sizeConfig); expect(status.active).to.equal(true); expect(status.mediaTypes).to.deep.equal(mediaTypes); }); @@ -160,14 +160,14 @@ describe('sizeMapping', function () { it('if a mediaQuery matches and has sizesSupported: [], it should filter all sizes', function () { matchMediaOverride = (str) => str === '(min-width: 0px) and (max-width: 767px)' ? {matches: true} : {matches: false}; - let status = resolveStatus(undefined, mediaTypes, sizeConfig); + const status = resolveStatus(undefined, mediaTypes, sizeConfig); expect(status.active).to.equal(false); expect(getSizes(status.mediaTypes)).to.deep.equal([]); }); it('should filter all banner sizes and should disable the adUnit even if other mediaTypes are present', function () { matchMediaOverride = (str) => str === '(min-width: 0px) and (max-width: 767px)' ? {matches: true} : {matches: false}; - let status = resolveStatus(undefined, Object.assign({}, mediaTypes, { + const status = resolveStatus(undefined, Object.assign({}, mediaTypes, { native: { type: 'image' } @@ -182,7 +182,7 @@ describe('sizeMapping', function () { it('if a mediaQuery matches and no sizesSupported specified, it should not affect adUnit.sizes', function () { matchMediaOverride = (str) => str === '(min-width: 1200px)' ? {matches: true} : {matches: false}; - let status = resolveStatus(undefined, mediaTypes, sizeConfigWithLabels); + const status = resolveStatus(undefined, mediaTypes, sizeConfigWithLabels); expect(status.active).to.equal(true); expect(status.mediaTypes).to.deep.equal(mediaTypes); }); @@ -210,7 +210,7 @@ describe('sizeMapping', function () { }); it('should active/deactivate adUnits/bidders based on requestBids labels', function () { - let activeLabels = ['us-visitor', 'desktop', 'smart']; + const activeLabels = ['us-visitor', 'desktop', 'smart']; let status = resolveStatus({ labels: ['uk-visitor'], // from adunit @@ -254,7 +254,7 @@ describe('sizeMapping', function () { it('should activate/decactivate adUnits/bidders based on labels with multiformat ads', function () { matchMediaOverride = (str) => str === '(min-width: 768px) and (max-width: 1199px)' ? {matches: true} : {matches: false}; - let multiFormatSizes = { + const multiFormatSizes = { banner: { sizes: [[728, 90], [300, 300]] }, diff --git a/test/spec/modules/slimcutBidAdapter_spec.js b/test/spec/modules/slimcutBidAdapter_spec.js index 64ddac71899..40c66b9b33b 100644 --- a/test/spec/modules/slimcutBidAdapter_spec.js +++ b/test/spec/modules/slimcutBidAdapter_spec.js @@ -17,7 +17,7 @@ describe('slimcutBidAdapter', function() { }); }); describe('isBidRequestValid', function() { - let bid = { + const bid = { 'bidder': 'slimcut', 'params': { 'placementId': 83 @@ -35,7 +35,7 @@ describe('slimcutBidAdapter', function() { expect(spec.isBidRequestValid(bid)).to.equal(true); }); it('should return false when placementId is not valid (letters)', function() { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = { 'placementId': 'ABCD' @@ -43,7 +43,7 @@ describe('slimcutBidAdapter', function() { expect(spec.isBidRequestValid(invalidBid)).to.equal(false); }); it('should return false when placementId < 0', function() { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = { 'placementId': -1 @@ -51,14 +51,14 @@ describe('slimcutBidAdapter', function() { expect(spec.isBidRequestValid(invalidBid)).to.equal(false); }); it('should return false when required params are not passed', function() { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = {}; expect(spec.isBidRequestValid(invalidBid)).to.equal(false); }); }); describe('buildRequests', function() { - let bidRequests = [{ + const bidRequests = [{ 'bidder': 'teads', 'params': { 'placementId': 10433394 @@ -73,7 +73,7 @@ describe('slimcutBidAdapter', function() { 'auctionId': '4e156668c977d7', 'deviceWidth': 1680 }]; - let bidderResquestDefault = { + const bidderResquestDefault = { 'auctionId': '4e156668c977d7', 'bidderRequestId': 'b41642f1aee381', 'timeout': 3000 @@ -84,8 +84,8 @@ describe('slimcutBidAdapter', function() { expect(request.method).to.equal('POST'); }); it('should send GDPR to endpoint', function() { - let consentString = 'JRJ8RKfDeBNsERRDCSAAZ+A=='; - let bidderRequest = { + const consentString = 'JRJ8RKfDeBNsERRDCSAAZ+A=='; + const bidderRequest = { 'auctionId': '4e156668c977d7', 'bidderRequestId': 'b41642f1aee381', 'timeout': 3000, @@ -118,7 +118,7 @@ describe('slimcutBidAdapter', function() { }); }); describe('getUserSyncs', () => { - let bids = { + const bids = { 'body': { 'responses': [{ 'ad': AD_SCRIPT, @@ -136,21 +136,21 @@ describe('slimcutBidAdapter', function() { } }; it('should get the correct number of sync urls', () => { - let urls = spec.getUserSyncs({ + const urls = spec.getUserSyncs({ iframeEnabled: true }, bids); expect(urls.length).to.equal(1); expect(urls[0].url).to.equal('https://sb.freeskreen.com/async_usersync.html'); }); it('should return no url if not iframe enabled', () => { - let urls = spec.getUserSyncs({ + const urls = spec.getUserSyncs({ iframeEnabled: false }, bids); expect(urls.length).to.equal(0); }); }); describe('interpretResponse', function() { - let bids = { + const bids = { 'body': { 'responses': [{ 'ad': AD_SCRIPT, @@ -168,7 +168,7 @@ describe('slimcutBidAdapter', function() { } }; it('should get correct bid response', function() { - let expectedResponse = [{ + const expectedResponse = [{ 'cpm': 0.5, 'width': 300, 'height': 250, @@ -183,16 +183,16 @@ describe('slimcutBidAdapter', function() { 'advertiserDomains': [] } }]; - let result = spec.interpretResponse(bids); + const result = spec.interpretResponse(bids); expect(Object.keys(result[0])).to.deep.equal(Object.keys(expectedResponse[0])); }); it('handles nobid responses', function() { - let bids = { + const bids = { 'body': { 'responses': [] } }; - let result = spec.interpretResponse(bids); + const result = spec.interpretResponse(bids); expect(result.length).to.equal(0); }); }); diff --git a/test/spec/modules/smartadserverBidAdapter_spec.js b/test/spec/modules/smartadserverBidAdapter_spec.js index c07a494a94a..2d278eccafb 100644 --- a/test/spec/modules/smartadserverBidAdapter_spec.js +++ b/test/spec/modules/smartadserverBidAdapter_spec.js @@ -1244,12 +1244,12 @@ describe('Smart bid adapter tests', function () { expect(requestContent).to.have.property('eids'); expect(requestContent.eids).to.not.equal(null).and.to.not.be.undefined; expect(requestContent.eids.length).to.greaterThan(0); - for (let index in requestContent.eids) { - let eid = requestContent.eids[index]; + for (const index in requestContent.eids) { + const eid = requestContent.eids[index]; expect(eid.source).to.not.equal(null).and.to.not.be.undefined; expect(eid.uids).to.not.equal(null).and.to.not.be.undefined; - for (let uidsIndex in eid.uids) { - let uid = eid.uids[uidsIndex]; + for (const uidsIndex in eid.uids) { + const uid = eid.uids[uidsIndex]; expect(uid.id).to.not.equal(null).and.to.not.be.undefined; } } @@ -1258,7 +1258,7 @@ describe('Smart bid adapter tests', function () { describe('Supply Chain Serializer tests', function () { it('Verify a multi node supply chain serialization matches iab example', function() { - let schain = { + const schain = { 'ver': '1.0', 'complete': 1, 'nodes': [ @@ -1281,22 +1281,22 @@ describe('Smart bid adapter tests', function () { ] }; - let serializedSchain = spec.serializeSupplyChain(schain); + const serializedSchain = spec.serializeSupplyChain(schain); expect(serializedSchain).to.equal('1.0,1!exchange1.com,1234,1,bid-request-1,publisher,publisher.com!exchange2.com,abcd,1,bid-request-2,intermediary,intermediary.com'); }); it('Verifiy that null schain produce null result', function () { - let actual = spec.serializeSupplyChain(null); + const actual = spec.serializeSupplyChain(null); expect(null, actual); }); it('Verifiy that schain with null nodes produce null result', function () { - let schain = { + const schain = { 'ver': '1.0', 'complete': 1 }; - let actual = spec.serializeSupplyChain(null); + const actual = spec.serializeSupplyChain(null); expect(null, actual); }); }); diff --git a/test/spec/modules/smarthubBidAdapter_spec.js b/test/spec/modules/smarthubBidAdapter_spec.js index 058978f2f53..12e3d40d928 100644 --- a/test/spec/modules/smarthubBidAdapter_spec.js +++ b/test/spec/modules/smarthubBidAdapter_spec.js @@ -147,7 +147,7 @@ describe('SmartHubBidAdapter', function () { }); it('Returns general data valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys('deviceWidth', 'deviceHeight', @@ -216,7 +216,7 @@ describe('SmartHubBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { delete bidderRequest.uspConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest[0].data; + const data = serverRequest[0].data; expect(data.gdpr).to.exist; expect(data.gdpr.consentString).to.be.a('string'); expect(data.gdpr.consentString).to.equal(bidderRequest.gdprConsent.consentString); @@ -228,7 +228,7 @@ describe('SmartHubBidAdapter', function () { bidderRequest.uspConsent = '1---'; delete bidderRequest.gdprConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest[0].data; + const data = serverRequest[0].data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -262,9 +262,9 @@ describe('SmartHubBidAdapter', function () { } }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal(banner.body[0].requestId); @@ -298,10 +298,10 @@ describe('SmartHubBidAdapter', function () { } }] }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta', 'width', 'height'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -335,10 +335,10 @@ describe('SmartHubBidAdapter', function () { } }] }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys('requestId', 'cpm', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'native', 'meta'); expect(dataItem.native).to.have.keys('clickUrl', 'impressionTrackers', 'title', 'image') expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -369,7 +369,7 @@ describe('SmartHubBidAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -385,7 +385,7 @@ describe('SmartHubBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -402,7 +402,7 @@ describe('SmartHubBidAdapter', function () { currency: 'USD', }] }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -415,7 +415,7 @@ describe('SmartHubBidAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/smarticoBidAdapter_spec.js b/test/spec/modules/smarticoBidAdapter_spec.js index 49d00b4579b..9de6f85f913 100644 --- a/test/spec/modules/smarticoBidAdapter_spec.js +++ b/test/spec/modules/smarticoBidAdapter_spec.js @@ -4,7 +4,7 @@ import {newBidder} from 'src/adapters/bidderFactory.js'; describe('smarticoBidAdapter', function () { const adapter = newBidder(spec); - let bid = { + const bid = { adUnitCode: 'adunit-code', auctionId: '5kaj89l8-3456-2s56-c455-4g6h78jsdfgf', bidRequestsCount: 1, @@ -23,7 +23,7 @@ describe('smarticoBidAdapter', function () { ], transactionId: '34562345-4dg7-46g7-4sg6-45gdsdj8fd56' } - let bidderRequests = { + const bidderRequests = { auctionId: 'b06c5141-fe8f-4cdf-9d7d-54415490a917', auctionStart: 1579746300522, bidderCode: 'myBidderCode', @@ -41,8 +41,8 @@ describe('smarticoBidAdapter', function () { }); }); describe('buildRequests', function () { - let bidRequests = [ bid ]; - let request = spec.buildRequests(bidRequests, bidderRequests); + const bidRequests = [ bid ]; + const request = spec.buildRequests(bidRequests, bidderRequests); it('sends bid request via POST', function () { expect(request.method).to.equal('POST'); }); @@ -59,7 +59,7 @@ describe('smarticoBidAdapter', function () { }); describe('interpretResponse', function () { - let bidRequest = { + const bidRequest = { method: 'POST', url: 'https://trmads.eu/preBidRequest', bids: [bid], @@ -71,7 +71,7 @@ describe('smarticoBidAdapter', function () { placementId: 'testPlacementId', }] }; - let serverResponse = { + const serverResponse = { body: [{ bidId: '22499d052045', id: 987654, @@ -86,7 +86,7 @@ describe('smarticoBidAdapter', function () { title: 'Advertiser' }] }; - let expectedResponse = [{ + const expectedResponse = [{ requestId: bid.bidId, cpm: 10, width: 300, @@ -100,7 +100,7 @@ describe('smarticoBidAdapter', function () { advertiserDomains: ['www.advertiser.com'], advertiserName: 'Advertiser' }}]; - let result = spec.interpretResponse(serverResponse, bidRequest); + const result = spec.interpretResponse(serverResponse, bidRequest); it('should contain correct creativeId', function () { expect(result[0].creativeId).to.equal(expectedResponse[0].creativeId) }); diff --git a/test/spec/modules/smartyadsAnalyticsAdapter_spec.js b/test/spec/modules/smartyadsAnalyticsAdapter_spec.js index de7e08a8a77..7c035e2ffd0 100644 --- a/test/spec/modules/smartyadsAnalyticsAdapter_spec.js +++ b/test/spec/modules/smartyadsAnalyticsAdapter_spec.js @@ -3,8 +3,8 @@ import { expect } from 'chai'; import { server } from 'test/mocks/xhr.js'; import { EVENTS } from '../../../src/constants'; -let adapterManager = require('src/adapterManager').default; -let events = require('src/events'); +const adapterManager = require('src/adapterManager').default; +const events = require('src/events'); describe('SmartyAds Analytics', function () { const auctionEnd = { @@ -190,7 +190,7 @@ describe('SmartyAds Analytics', function () { 'timeout': 1000 }; - let bidWon = { + const bidWon = { 'bidderCode': 'smartyads', 'width': 970, 'height': 250, @@ -245,7 +245,7 @@ describe('SmartyAds Analytics', function () { ] }; - let renderData = { + const renderData = { 'doc': { 'location': { 'ancestorOrigins': { @@ -391,7 +391,7 @@ describe('SmartyAds Analytics', function () { events.emit(EVENTS.AUCTION_END, auctionEnd); expect(server.requests.length).to.equal(1); - let message = JSON.parse(server.requests[0].requestBody); + const message = JSON.parse(server.requests[0].requestBody); expect(message).to.have.property('auctionData'); expect(message).to.have.property('eventType').and.to.equal(EVENTS.AUCTION_END); expect(message.auctionData).to.have.property('auctionId'); @@ -410,7 +410,7 @@ describe('SmartyAds Analytics', function () { events.emit(EVENTS.BID_WON, bidWon); expect(server.requests.length).to.equal(1); - let message = JSON.parse(server.requests[0].requestBody); + const message = JSON.parse(server.requests[0].requestBody); expect(message).to.have.property('eventType').and.to.equal(EVENTS.BID_WON); expect(message).to.have.property('bid'); expect(message.bid).to.have.property('bidder').and.to.equal('smartyads'); @@ -429,7 +429,7 @@ describe('SmartyAds Analytics', function () { events.emit(EVENTS.AD_RENDER_SUCCEEDED, renderData); expect(server.requests.length).to.equal(1); - let message = JSON.parse(server.requests[0].requestBody); + const message = JSON.parse(server.requests[0].requestBody); expect(message).to.have.property('eventType').and.to.equal(EVENTS.AD_RENDER_SUCCEEDED); expect(message).to.have.property('renderData'); expect(message.renderData).to.have.property('doc'); diff --git a/test/spec/modules/smartyadsBidAdapter_spec.js b/test/spec/modules/smartyadsBidAdapter_spec.js index 65480ee11e6..5bd4b871b7d 100644 --- a/test/spec/modules/smartyadsBidAdapter_spec.js +++ b/test/spec/modules/smartyadsBidAdapter_spec.js @@ -4,7 +4,7 @@ import { config } from '../../../src/config.js'; import {server} from '../../mocks/xhr'; describe('SmartyadsAdapter', function () { - let bid = { + const bid = { bidId: '23fhj33i987f', bidder: 'smartyads', params: { @@ -15,7 +15,7 @@ describe('SmartyadsAdapter', function () { } }; - let bidResponse = { + const bidResponse = { width: 300, height: 250, mediaType: 'banner', @@ -59,7 +59,7 @@ describe('SmartyadsAdapter', function () { ]); }); it('Returns valid data if array of bids is valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys('deviceWidth', 'deviceHeight', 'host', 'page', 'placements', 'coppa', 'eeid', 'ifa'); expect(data.deviceWidth).to.be.a('number'); @@ -67,7 +67,7 @@ describe('SmartyadsAdapter', function () { expect(data.coppa).to.be.a('number'); expect(data.host).to.be.a('string'); expect(data.page).to.be.a('string'); - let placement = data['placements'][0]; + const placement = data['placements'][0]; expect(placement).to.have.keys('placementId', 'bidId', 'traffic', 'sizes', 'publisherId'); expect(placement.placementId).to.equal('0'); expect(placement.bidId).to.equal('23fhj33i987f'); @@ -75,7 +75,7 @@ describe('SmartyadsAdapter', function () { }); it('Returns empty data if no valid requests are passed', function () { serverRequest = spec.buildRequests([]); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.placements).to.be.an('array').that.is.empty; }); }); @@ -91,7 +91,7 @@ describe('SmartyadsAdapter', function () { }); it('should send the Coppa "required" flag set to "1" in the request', function () { - let serverRequest = spec.buildRequests([bid]); + const serverRequest = spec.buildRequests([bid]); expect(serverRequest.data.coppa).to.equal(1); }); }); @@ -114,9 +114,9 @@ describe('SmartyadsAdapter', function () { meta: {advertiserDomains: ['example.com']} }] }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -145,10 +145,10 @@ describe('SmartyadsAdapter', function () { dealId: '1' }] }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys('requestId', 'cpm', 'vastUrl', 'ttl', 'creativeId', 'netRevenue', 'currency', 'dealId', 'mediaType', 'meta'); expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -177,10 +177,10 @@ describe('SmartyadsAdapter', function () { currency: 'USD', }] }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys('requestId', 'cpm', 'ttl', 'creativeId', 'netRevenue', 'currency', 'mediaType', 'native', 'meta'); expect(dataItem.native).to.have.keys('clickUrl', 'impressionTrackers', 'title', 'image') expect(dataItem.requestId).to.equal('23fhj33i987f'); @@ -210,7 +210,7 @@ describe('SmartyadsAdapter', function () { }] }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -226,7 +226,7 @@ describe('SmartyadsAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -243,7 +243,7 @@ describe('SmartyadsAdapter', function () { currency: 'USD', }] }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -256,7 +256,7 @@ describe('SmartyadsAdapter', function () { dealId: '1' }] }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); @@ -265,7 +265,7 @@ describe('SmartyadsAdapter', function () { const syncOptions = { iframeEnabled: true }; - let userSync = spec.getUserSyncs(syncOptions); + const userSync = spec.getUserSyncs(syncOptions); it('Returns valid URL and type', function () { expect(userSync).to.be.an('array').with.lengthOf(1); expect(userSync[0].type).to.exist; diff --git a/test/spec/modules/smartytechBidAdapter_spec.js b/test/spec/modules/smartytechBidAdapter_spec.js index 3b6d5d0c5fc..28e45284a23 100644 --- a/test/spec/modules/smartytechBidAdapter_spec.js +++ b/test/spec/modules/smartytechBidAdapter_spec.js @@ -142,7 +142,7 @@ function mockBidRequestListData(mediaType, size, customSizes) { return Array.apply(null, {length: size}).map((i, index) => { const id = Math.floor(Math.random() * 800) * (index + 1); let mediaTypes; - let params = { + const params = { endpointId: id } @@ -183,7 +183,7 @@ function mockRefererData() { } function mockResponseData(requestData) { - let data = {} + const data = {} requestData.data.forEach((request, index) => { const rndIndex = Math.floor(Math.random() * 800); let width, height, mediaType; diff --git a/test/spec/modules/smilewantedBidAdapter_spec.js b/test/spec/modules/smilewantedBidAdapter_spec.js index 7c1e007c6a7..e1d740ea19e 100644 --- a/test/spec/modules/smilewantedBidAdapter_spec.js +++ b/test/spec/modules/smilewantedBidAdapter_spec.js @@ -438,12 +438,12 @@ describe('smilewantedBidAdapterTests', function () { expect(requestContent).to.have.property('eids'); expect(requestContent.eids).to.not.equal(null).and.to.not.be.undefined; expect(requestContent.eids.length).to.greaterThan(0); - for (let index in requestContent.eids) { - let eid = requestContent.eids[index]; + for (const index in requestContent.eids) { + const eid = requestContent.eids[index]; expect(eid.source).to.not.equal(null).and.to.not.be.undefined; expect(eid.uids).to.not.equal(null).and.to.not.be.undefined; - for (let uidsIndex in eid.uids) { - let uid = eid.uids[uidsIndex]; + for (const uidsIndex in eid.uids) { + const uid = eid.uids[uidsIndex]; expect(uid.id).to.not.equal(null).and.to.not.be.undefined; } } @@ -635,7 +635,7 @@ describe('smilewantedBidAdapterTests', function () { }); it('SmileWanted - Verify user sync - empty data', function () { - let syncs = spec.getUserSyncs({iframeEnabled: true}, {}, {}, null); + const syncs = spec.getUserSyncs({iframeEnabled: true}, {}, {}, null); expect(syncs).to.have.lengthOf(1); expect(syncs[0].type).to.equal('iframe'); expect(syncs[0].url).to.equal('https://csync.smilewanted.com'); diff --git a/test/spec/modules/smootBidAdapter_spec.js b/test/spec/modules/smootBidAdapter_spec.js index f51c054f883..81cd02b314a 100644 --- a/test/spec/modules/smootBidAdapter_spec.js +++ b/test/spec/modules/smootBidAdapter_spec.js @@ -123,7 +123,7 @@ describe('SmootBidAdapter', function () { }); it('Returns general data valid', function () { - let data = serverRequest.data; + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.all.keys( 'deviceWidth', @@ -207,7 +207,7 @@ describe('SmootBidAdapter', function () { }, ]; - let serverRequest = spec.buildRequests(bids, bidderRequest); + const serverRequest = spec.buildRequests(bids, bidderRequest); const { placements } = serverRequest.data; for (let i = 0, len = placements.length; i < len; i++) { @@ -246,7 +246,7 @@ describe('SmootBidAdapter', function () { it('Returns data with gdprConsent and without uspConsent', function () { delete bidderRequest.uspConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.gdpr).to.exist; expect(data.gdpr).to.be.a('object'); expect(data.gdpr).to.have.property('consentString'); @@ -262,7 +262,7 @@ describe('SmootBidAdapter', function () { bidderRequest.uspConsent = '1---'; delete bidderRequest.gdprConsent; serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const data = serverRequest.data; expect(data.ccpa).to.exist; expect(data.ccpa).to.be.a('string'); expect(data.ccpa).to.equal(bidderRequest.uspConsent); @@ -277,8 +277,8 @@ describe('SmootBidAdapter', function () { applicableSections: [8], }; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -292,8 +292,8 @@ describe('SmootBidAdapter', function () { bidderRequest.ortb2.regs.gpp = 'abc123'; bidderRequest.ortb2.regs.gpp_sid = [8]; - let serverRequest = spec.buildRequests(bids, bidderRequest); - let data = serverRequest.data; + const serverRequest = spec.buildRequests(bids, bidderRequest); + const data = serverRequest.data; expect(data).to.be.an('object'); expect(data).to.have.property('gpp'); expect(data).to.have.property('gpp_sid'); @@ -325,9 +325,9 @@ describe('SmootBidAdapter', function () { }, ], }; - let bannerResponses = spec.interpretResponse(banner); + const bannerResponses = spec.interpretResponse(banner); expect(bannerResponses).to.be.an('array').that.is.not.empty; - let dataItem = bannerResponses[0]; + const dataItem = bannerResponses[0]; expect(dataItem).to.have.all.keys( 'requestId', 'cpm', @@ -375,10 +375,10 @@ describe('SmootBidAdapter', function () { }, ], }; - let videoResponses = spec.interpretResponse(video); + const videoResponses = spec.interpretResponse(video); expect(videoResponses).to.be.an('array').that.is.not.empty; - let dataItem = videoResponses[0]; + const dataItem = videoResponses[0]; expect(dataItem).to.have.all.keys( 'requestId', 'cpm', @@ -426,10 +426,10 @@ describe('SmootBidAdapter', function () { }, ], }; - let nativeResponses = spec.interpretResponse(native); + const nativeResponses = spec.interpretResponse(native); expect(nativeResponses).to.be.an('array').that.is.not.empty; - let dataItem = nativeResponses[0]; + const dataItem = nativeResponses[0]; expect(dataItem).to.have.keys( 'requestId', 'cpm', @@ -480,7 +480,7 @@ describe('SmootBidAdapter', function () { ], }; - let serverResponses = spec.interpretResponse(invBanner); + const serverResponses = spec.interpretResponse(invBanner); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid video response is passed', function () { @@ -498,7 +498,7 @@ describe('SmootBidAdapter', function () { }, ], }; - let serverResponses = spec.interpretResponse(invVideo); + const serverResponses = spec.interpretResponse(invVideo); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid native response is passed', function () { @@ -517,7 +517,7 @@ describe('SmootBidAdapter', function () { }, ], }; - let serverResponses = spec.interpretResponse(invNative); + const serverResponses = spec.interpretResponse(invNative); expect(serverResponses).to.be.an('array').that.is.empty; }); it('Should return an empty array if invalid response is passed', function () { @@ -532,7 +532,7 @@ describe('SmootBidAdapter', function () { }, ], }; - let serverResponses = spec.interpretResponse(invalid); + const serverResponses = spec.interpretResponse(invalid); expect(serverResponses).to.be.an('array').that.is.empty; }); }); diff --git a/test/spec/modules/sonaradsBidAdapter_spec.js b/test/spec/modules/sonaradsBidAdapter_spec.js index bc0de144363..4c77bca83da 100644 --- a/test/spec/modules/sonaradsBidAdapter_spec.js +++ b/test/spec/modules/sonaradsBidAdapter_spec.js @@ -575,7 +575,7 @@ describe('bridgeuppBidAdapter_spec', function () { const bidRequests = []; const bidderRequest = {}; config.setConfig({coppa: false}); - let buildRequests = spec.buildRequests(bidRequests, await addFPDToBidderRequest(bidderRequest)); + const buildRequests = spec.buildRequests(bidRequests, await addFPDToBidderRequest(bidderRequest)); const ortbRequest = buildRequests.data; expect(ortbRequest.regs.coppa).to.equal(0); }); diff --git a/test/spec/modules/sonobiBidAdapter_spec.js b/test/spec/modules/sonobiBidAdapter_spec.js index 78d538c77d2..f84a2f78fcc 100644 --- a/test/spec/modules/sonobiBidAdapter_spec.js +++ b/test/spec/modules/sonobiBidAdapter_spec.js @@ -266,7 +266,7 @@ describe('SonobiBidAdapter', function () { gptUtils.getGptSlotInfoForAdUnitCode.restore(); sandbox.restore(); }); - let bidRequest = [{ + const bidRequest = [{ 'ortb2': { 'source': { 'ext': { @@ -390,14 +390,14 @@ describe('SonobiBidAdapter', function () { } }]; - let keyMakerData = { + const keyMakerData = { '30b31c1838de1f': '1a2b3c4d5e6f1a2b3c4d|640x480|f=1.25,gpid=/123123/gpt_publisher/adunit-code-1,c=v,pm=1:2:3,p=2,pl=3,protocols=1:2:3:4:5,mimes=video/mp4:video/mpeg:video/x-flv,battr=16:17,api=1:2:3,minduration=5,maxduration=60,skip=1,skipafter=10,startdelay=5,linearity=1,minbitrate=1,maxbitrate=2,', '30b31c1838de1g': '1a2b3c4d5e6f1a2b3c4d|300x250,300x600|f=1.25,gpid=/123123/gpt_publisher/adunit-code-42,c=d,', '30b31c1838de1d': '1a2b3c4d5e6f1a2b3c4e|300x250,300x600|f=0.42,gpid=/123123/gpt_publisher/adunit-code-3,c=d,', '/7780971/sparks_prebid_LB|30b31c1838de1e': '300x250,300x600|gpid=/7780971/sparks_prebid_LB,c=d,', }; - let bidderRequests = { + const bidderRequests = { 'gdprConsent': { 'consentString': 'BOJ/P2HOJ/P2HABABMAAAAAZ+A==', 'vendorData': {}, @@ -495,7 +495,7 @@ describe('SonobiBidAdapter', function () { expect(bidRequests.data.consent_string).to.equal(encodeURIComponent('BOJ/P2HOJ/P2HABABMAAAAAZ+A==')) }) it('should return a properly formatted request with GDPR applies set to false with no consent_string param', function () { - let bidderRequests = { + const bidderRequests = { 'gdprConsent': { 'consentString': undefined, 'vendorData': {}, @@ -515,7 +515,7 @@ describe('SonobiBidAdapter', function () { expect(bidRequests.data).to.not.include.keys('consent_string') }) it('should return a properly formatted request with GDPR applies set to true with no consent_string param', function () { - let bidderRequests = { + const bidderRequests = { 'gdprConsent': { 'consentString': undefined, 'vendorData': {}, @@ -707,7 +707,7 @@ describe('SonobiBidAdapter', function () { ] }; - let bidResponse = { + const bidResponse = { 'body': { 'slots': { '/7780971/sparks_prebid_LB|30b31c1838de1f': { @@ -762,7 +762,7 @@ describe('SonobiBidAdapter', function () { } }; - let prebidResponse = [ + const prebidResponse = [ { 'requestId': '30b31c1838de1f', 'cpm': 1.07, @@ -862,7 +862,7 @@ describe('SonobiBidAdapter', function () { }); describe('.getUserSyncs', function () { - let bidResponse = [{ + const bidResponse = [{ 'body': { 'sbi_px': [{ 'code': 'so', diff --git a/test/spec/modules/sovrnBidAdapter_spec.js b/test/spec/modules/sovrnBidAdapter_spec.js index 15cd6cbd256..58608705073 100644 --- a/test/spec/modules/sovrnBidAdapter_spec.js +++ b/test/spec/modules/sovrnBidAdapter_spec.js @@ -962,7 +962,7 @@ describe('sovrnBidAdapter', function() { }) describe('fledge response', function () { - let fledgeResponse = { + const fledgeResponse = { body: { id: '37386aade21a71', seatbid: [{ @@ -1027,7 +1027,7 @@ describe('sovrnBidAdapter', function() { } } } - let emptyFledgeResponse = { + const emptyFledgeResponse = { body: { id: '37386aade21a71', seatbid: [{ @@ -1048,7 +1048,7 @@ describe('sovrnBidAdapter', function() { } } } - let expectedResponse = { + const expectedResponse = { requestId: '263c448586f5a1', cpm: 0.45882675, width: 728, @@ -1062,7 +1062,7 @@ describe('sovrnBidAdapter', function() { meta: { advertiserDomains: [] }, ad: decodeURIComponent(`>`) } - let expectedFledgeResponse = [ + const expectedFledgeResponse = [ { bidId: 'test_imp_id', config: { diff --git a/test/spec/modules/sparteoBidAdapter_spec.js b/test/spec/modules/sparteoBidAdapter_spec.js index 51a195bd482..6b7615bcd1e 100644 --- a/test/spec/modules/sparteoBidAdapter_spec.js +++ b/test/spec/modules/sparteoBidAdapter_spec.js @@ -220,14 +220,14 @@ describe('SparteoAdapter', function () { }); it('should return false because the networkId is missing', function () { - let wrongBid = deepClone(VALID_BID_BANNER); + const wrongBid = deepClone(VALID_BID_BANNER); delete wrongBid.params.networkId; expect(adapter.isBidRequestValid(wrongBid)).to.equal(false); }); it('should return false because the banner size is missing', function () { - let wrongBid = deepClone(VALID_BID_BANNER); + const wrongBid = deepClone(VALID_BID_BANNER); wrongBid.mediaTypes.banner.sizes = '123456'; expect(adapter.isBidRequestValid(wrongBid)).to.equal(false); @@ -237,7 +237,7 @@ describe('SparteoAdapter', function () { }); it('should return false because the video player size paramater is missing', function () { - let wrongBid = deepClone(VALID_BID_VIDEO); + const wrongBid = deepClone(VALID_BID_VIDEO); wrongBid.mediaTypes.video.playerSize = '123456'; expect(adapter.isBidRequestValid(wrongBid)).to.equal(false); @@ -276,15 +276,15 @@ describe('SparteoAdapter', function () { } it('should return the right formatted request with endpoint test', function() { - let endpoint = 'https://bid-test.sparteo.com/auction'; + const endpoint = 'https://bid-test.sparteo.com/auction'; - let bids = mergeDeep(deepClone([VALID_BID_BANNER, VALID_BID_VIDEO]), { + const bids = mergeDeep(deepClone([VALID_BID_BANNER, VALID_BID_VIDEO]), { params: { endpoint: endpoint } }); - let requests = mergeDeep(deepClone(VALID_REQUEST)); + const requests = mergeDeep(deepClone(VALID_REQUEST)); const request = adapter.buildRequests(bids, BIDDER_REQUEST); requests.url = endpoint; @@ -298,7 +298,7 @@ describe('SparteoAdapter', function () { describe('interpretResponse', function() { describe('Check method return', function () { it('should return the right formatted response', function() { - let response = { + const response = { body: { 'id': '63f4d300-6896-4bdc-8561-0932f73148b1', 'cur': 'EUR', @@ -351,7 +351,7 @@ describe('SparteoAdapter', function () { }); } - let formattedReponse = [ + const formattedReponse = [ { requestId: '1a2b3c4d', seatBidId: 'cdbb6982-a269-40c7-84e5-04797f11d87a', @@ -405,7 +405,7 @@ describe('SparteoAdapter', function () { describe('onBidWon', function() { describe('Check methods succeed', function () { it('should not throw error', function() { - let bids = [ + const bids = [ { requestId: '1a2b3c4d', seatBidId: 'cdbb6982-a269-40c7-84e5-04797f11d87a', diff --git a/test/spec/modules/ssmasBidAdapter_spec.js b/test/spec/modules/ssmasBidAdapter_spec.js index 26c6f60da4b..a97a40caeac 100644 --- a/test/spec/modules/ssmasBidAdapter_spec.js +++ b/test/spec/modules/ssmasBidAdapter_spec.js @@ -89,7 +89,7 @@ describe('ssmasBidAdapter', function () { }); describe('interpretResponse', function () { - let bidOrtbResponse = { + const bidOrtbResponse = { 'id': 'aa02e2fe-56d9-4713-88f9-d8672ceae8ab', 'seatbid': [ { @@ -138,7 +138,7 @@ describe('ssmasBidAdapter', function () { 'cur': 'EUR', 'nbr': -1 }; - let bidResponse = { + const bidResponse = { 'mediaType': 'banner', 'ad': '', 'requestId': '37c658fe8ba57b', @@ -158,7 +158,7 @@ describe('ssmasBidAdapter', function () { ] } }; - let bidRequest = { + const bidRequest = { 'imp': [ { 'ext': { diff --git a/test/spec/modules/sspBCBidAdapter_spec.js b/test/spec/modules/sspBCBidAdapter_spec.js index 32f99096156..53261a3a734 100644 --- a/test/spec/modules/sspBCBidAdapter_spec.js +++ b/test/spec/modules/sspBCBidAdapter_spec.js @@ -534,7 +534,7 @@ describe('SSPBC adapter', function () { describe('isBidRequestValid', function () { const { bids } = prepareTestData(); - let bid = bids[0]; + const bid = bids[0]; it('should always return true whether bid has params (standard) or not (OneCode)', function () { assert(spec.isBidRequestValid(bid)); @@ -680,13 +680,13 @@ describe('SSPBC adapter', function () { const requestNative = spec.buildRequests([bid_native], bidRequestNative); it('should handle nobid responses', function () { - let result = spec.interpretResponse(emptyResponse, request); + const result = spec.interpretResponse(emptyResponse, request); expect(result.length).to.equal(0); }); it('should create bids from non-empty responses', function () { - let result = spec.interpretResponse(serverResponse, request); - let resultSingle = spec.interpretResponse(serverResponseSingle, requestSingle); + const result = spec.interpretResponse(serverResponse, request); + const resultSingle = spec.interpretResponse(serverResponseSingle, requestSingle); expect(result.length).to.equal(bids.length); expect(resultSingle.length).to.equal(1); @@ -694,36 +694,36 @@ describe('SSPBC adapter', function () { }); it('should create bid from OneCode (parameter-less) request, if response contains siteId', function () { - let resultOneCode = spec.interpretResponse(serverResponseOneCode, requestOneCode); + const resultOneCode = spec.interpretResponse(serverResponseOneCode, requestOneCode); expect(resultOneCode.length).to.equal(1); expect(resultOneCode[0]).to.have.keys('ad', 'cpm', 'width', 'height', 'mediaType', 'meta', 'requestId', 'creativeId', 'currency', 'netRevenue', 'ttl', 'vurls'); }); it('should not create bid from OneCode (parameter-less) request, if response does not contain siteId', function () { - let resultOneCodeNoMatch = spec.interpretResponse(serverResponse, requestOneCode); + const resultOneCodeNoMatch = spec.interpretResponse(serverResponse, requestOneCode); expect(resultOneCodeNoMatch.length).to.equal(0); }); it('should handle a partial response', function () { - let resultPartial = spec.interpretResponse(serverResponseSingle, request); + const resultPartial = spec.interpretResponse(serverResponseSingle, request); expect(resultPartial.length).to.equal(1); }); it('should not alter HTML from response', function () { - let resultSingle = spec.interpretResponse(serverResponseSingle, requestSingle); - let adcode = resultSingle[0].ad; + const resultSingle = spec.interpretResponse(serverResponseSingle, requestSingle); + const adcode = resultSingle[0].ad; expect(adcode).to.be.equal(serverResponseSingle.body.seatbid[0].bid[0].adm); }); it('should create a correct video bid', function () { - let resultVideo = spec.interpretResponse(serverResponseVideo, requestVideo); + const resultVideo = spec.interpretResponse(serverResponseVideo, requestVideo); expect(resultVideo.length).to.equal(1); - let videoBid = resultVideo[0]; + const videoBid = resultVideo[0]; expect(videoBid).to.have.keys('adType', 'cpm', 'creativeId', 'currency', 'width', 'height', 'meta', 'mediaType', 'netRevenue', 'requestId', 'ttl', 'vastContent', 'vastXml', 'vastUrl', 'vurls'); expect(videoBid.adType).to.equal('instream'); expect(videoBid.mediaType).to.equal('video'); @@ -733,17 +733,17 @@ describe('SSPBC adapter', function () { }); it('should create a correct native bid', function () { - let resultNative = spec.interpretResponse(serverResponseNative, requestNative); + const resultNative = spec.interpretResponse(serverResponseNative, requestNative); expect(resultNative.length).to.equal(1); - let nativeBid = resultNative[0]; + const nativeBid = resultNative[0]; expect(nativeBid).to.have.keys('cpm', 'creativeId', 'currency', 'width', 'height', 'meta', 'mediaType', 'netRevenue', 'requestId', 'ttl', 'native', 'vurls'); expect(nativeBid.native).to.have.keys('image', 'icon', 'title', 'sponsoredBy', 'body', 'clickUrl', 'impressionTrackers', 'javascriptTrackers', 'clickTrackers'); }); it('should reject responses that are not HTML, VATS/VPAID or native', function () { - let resultIncorrect = spec.interpretResponse(serverResponseIncorrect, requestSingle); + const resultIncorrect = spec.interpretResponse(serverResponseIncorrect, requestSingle); expect(resultIncorrect.length).to.equal(0); }); @@ -757,9 +757,9 @@ describe('SSPBC adapter', function () { }); describe('getUserSyncs', function () { - let syncResultAll = spec.getUserSyncs({ iframeEnabled: true, pixelEnabled: true }); - let syncResultImage = spec.getUserSyncs({ iframeEnabled: false, pixelEnabled: true }); - let syncResultNone = spec.getUserSyncs({ iframeEnabled: false, pixelEnabled: false }); + const syncResultAll = spec.getUserSyncs({ iframeEnabled: true, pixelEnabled: true }); + const syncResultImage = spec.getUserSyncs({ iframeEnabled: false, pixelEnabled: true }); + const syncResultNone = spec.getUserSyncs({ iframeEnabled: false, pixelEnabled: false }); it('should provide correct iframe url, if frame sync is allowed', function () { expect(syncResultAll).to.have.length(1); @@ -779,15 +779,15 @@ describe('SSPBC adapter', function () { describe('onBidWon', function () { it('should generate no notification if bid is undefined', function () { - let notificationPayload = spec.onBidWon(); + const notificationPayload = spec.onBidWon(); expect(notificationPayload).to.be.undefined; }); it('should generate notification with event name and request/adUnit data, if correct bid is provided. Should also contain site/slot data as arrays.', function () { const { bids } = prepareTestData(); - let bid = bids[0]; + const bid = bids[0]; - let notificationPayload = spec.onBidWon(bid); + const notificationPayload = spec.onBidWon(bid); expect(notificationPayload).to.have.property('event').that.equals('bidWon'); expect(notificationPayload).to.have.property('requestId').that.equals(bid.bidderRequestId); expect(notificationPayload).to.have.property('tagid').that.deep.equals([bid.adUnitCode]); @@ -798,15 +798,15 @@ describe('SSPBC adapter', function () { describe('onBidBillable', function () { it('should generate no notification if bid is undefined', function () { - let notificationPayload = spec.onBidBillable(); + const notificationPayload = spec.onBidBillable(); expect(notificationPayload).to.be.undefined; }); it('should generate notification with event name and request/adUnit data, if correct bid is provided. Should also contain site/slot data as arrays.', function () { const { bids } = prepareTestData(); - let bid = bids[0]; + const bid = bids[0]; - let notificationPayload = spec.onBidBillable(bid); + const notificationPayload = spec.onBidBillable(bid); expect(notificationPayload).to.have.property('event').that.equals('bidBillable'); expect(notificationPayload).to.have.property('requestId').that.equals(bid.bidderRequestId); expect(notificationPayload).to.have.property('tagid').that.deep.equals([bid.adUnitCode]); @@ -817,8 +817,8 @@ describe('SSPBC adapter', function () { describe('onTimeout', function () { it('should generate no notification if timeout data is undefined / has no bids', function () { - let notificationPayloadUndefined = spec.onTimeout(); - let notificationPayloadNoBids = spec.onTimeout([]); + const notificationPayloadUndefined = spec.onTimeout(); + const notificationPayloadNoBids = spec.onTimeout([]); expect(notificationPayloadUndefined).to.be.undefined; expect(notificationPayloadNoBids).to.be.undefined; @@ -826,7 +826,7 @@ describe('SSPBC adapter', function () { it('should generate single notification for any number of timeouted bids', function () { const { bids_timeouted } = prepareTestData(); - let notificationPayload = spec.onTimeout(bids_timeouted); + const notificationPayload = spec.onTimeout(bids_timeouted); expect(notificationPayload).to.have.property('event').that.equals('timeout'); expect(notificationPayload).to.have.property('tagid').that.deep.equals([bids_timeouted[0].adUnitCode, bids_timeouted[1].adUnitCode]); diff --git a/test/spec/modules/stackadaptBidAdapter_spec.js b/test/spec/modules/stackadaptBidAdapter_spec.js index 4a1943babdf..00c799b52cc 100644 --- a/test/spec/modules/stackadaptBidAdapter_spec.js +++ b/test/spec/modules/stackadaptBidAdapter_spec.js @@ -134,18 +134,18 @@ describe('stackadaptBidAdapter', function () { describe('interpretResponse() empty', function () { it('should handle empty response', function () { - let result = spec.interpretResponse({}); + const result = spec.interpretResponse({}); expect(result.length).to.equal(0); }); it('should handle empty seatbid response', function () { - let response = { + const response = { body: { 'id': '9p1a65c0oc85a62', 'seatbid': [] } }; - let result = spec.interpretResponse(response); + const result = spec.interpretResponse(response); expect(result.length).to.equal(0); }); }); @@ -242,7 +242,7 @@ describe('stackadaptBidAdapter', function () { bids: [bidderRequest] }) - let result = spec.interpretResponse(ortbResponse, {data: ortbRequest.data}); + const result = spec.interpretResponse(ortbResponse, {data: ortbRequest.data}); expect(result.length).to.equal(1); expect(result[0]).to.deep.equal(expectedBid); }); @@ -398,7 +398,7 @@ describe('stackadaptBidAdapter', function () { const ortbRequest = spec.buildRequests([bidderRequest1, bidderRequest2], { bids: [bidderRequest1, bidderRequest2] }) - let result = spec.interpretResponse(ortbResponse, {data: ortbRequest.data}); + const result = spec.interpretResponse(ortbResponse, {data: ortbRequest.data}); expect(result.length).to.equal(2); expect(result).to.deep.equal(expectedBids); }); @@ -472,7 +472,7 @@ describe('stackadaptBidAdapter', function () { bids: [bidderRequest] }) - let result = spec.interpretResponse(ortbResponse, {data: ortbRequest.data}); + const result = spec.interpretResponse(ortbResponse, {data: ortbRequest.data}); expect(result.length).to.equal(1); expect(result[0]).to.deep.equal(expectedBid); }); @@ -853,7 +853,7 @@ describe('stackadaptBidAdapter', function () { } } }; - let clonedBidderRequest = {...deepClone(bidderRequest), ortb2}; + const clonedBidderRequest = {...deepClone(bidderRequest), ortb2}; const ortbRequest = spec.buildRequests(bidRequests, clonedBidderRequest).data; expect(ortbRequest.user.ext.consent).to.equal(consentString); expect(ortbRequest.regs.ext.gdpr).to.equal(1); @@ -868,7 +868,7 @@ describe('stackadaptBidAdapter', function () { } } }; - let clonedBidderRequest = {...deepClone(bidderRequest), ortb2}; + const clonedBidderRequest = {...deepClone(bidderRequest), ortb2}; const ortbRequest = spec.buildRequests(bidRequests, clonedBidderRequest).data; expect(ortbRequest.regs.ext.us_privacy).to.equal(consentString); }); @@ -879,7 +879,7 @@ describe('stackadaptBidAdapter', function () { coppa: 1 } }; - let clonedBidderRequest = {...deepClone(bidderRequest), ortb2}; + const clonedBidderRequest = {...deepClone(bidderRequest), ortb2}; const ortbRequest = spec.buildRequests(bidRequests, clonedBidderRequest).data; expect(ortbRequest.regs.coppa).to.equal(1); }); @@ -891,7 +891,7 @@ describe('stackadaptBidAdapter', function () { gpp_sid: [9] } }; - let clonedBidderRequest = {...deepClone(bidderRequest), ortb2}; + const clonedBidderRequest = {...deepClone(bidderRequest), ortb2}; const ortbRequest = spec.buildRequests(bidRequests, clonedBidderRequest).data; expect(ortbRequest.regs.gpp).to.equal('DCACTA~1YAA'); expect(ortbRequest.regs.gpp_sid).to.eql([9]); @@ -1096,7 +1096,7 @@ describe('stackadaptBidAdapter', function () { } }; - let bidderRequestMerged = {...bidderRequest, ortb2}; + const bidderRequestMerged = {...bidderRequest, ortb2}; const ortbRequest = spec.buildRequests(bidRequests, bidderRequestMerged).data; validateExtFirstPartyData(ortbRequest.pmp.ext) @@ -1375,12 +1375,12 @@ describe('stackadaptBidAdapter', function () { applicableSections: [7, 8] }; - let syncs = spec.getUserSyncs(syncOptions, [], gdprConsent, uspConsent, gppConsent); + const syncs = spec.getUserSyncs(syncOptions, [], gdprConsent, uspConsent, gppConsent); expect(syncs).to.have.lengthOf(1); expect(syncs[0].type).to.equal('image'); expect(syncs[0].url).to.equal('https://sync.srv.stackadapt.com/sync?nid=pjs&gdpr=1&gdpr_consent=CQGRvoAQGRvoAAHABAENBKFsAP_gAEPgAAAAKhNV&us_privacy=1YNY&gpp=DCACTA~1YAB&gpp_sid=7,8'); - let params = new URLSearchParams(new URL(syncs[0].url).search); + const params = new URLSearchParams(new URL(syncs[0].url).search); expect(params.get('us_privacy')).to.equal(uspConsent); expect(params.get('gdpr')).to.equal('1'); expect(params.get('gdpr_consent')).to.equal(gdprConsentString); diff --git a/test/spec/modules/stnBidAdapter_spec.js b/test/spec/modules/stnBidAdapter_spec.js index 18089f64f44..22b306ecfca 100644 --- a/test/spec/modules/stnBidAdapter_spec.js +++ b/test/spec/modules/stnBidAdapter_spec.js @@ -440,57 +440,33 @@ describe('stnAdapter', function () { 'architecture': 'x86' } const bid = utils.deepClone(bidRequests[0]); - bid.ortb2 = { + const bidderRequestWithSua = utils.deepClone(bidderRequest); + bidderRequestWithSua.ortb2 = { 'device': { - 'sua': { - 'platform': { - 'brand': 'macOS', - 'version': [ '12', '4', '0' ] - }, - 'browsers': [ - { - 'brand': 'Chromium', - 'version': [ '106', '0', '5249', '119' ] - }, - { - 'brand': 'Google Chrome', - 'version': [ '106', '0', '5249', '119' ] - }, - { - 'brand': 'Not;A=Brand', - 'version': [ '99', '0', '0', '0' ] - } - ], - 'mobile': 0, - 'model': '', - 'bitness': '64', - 'architecture': 'x86' - } + 'sua': sua } - } - const requestWithSua = spec.buildRequests([bid], bidderRequest); + }; + const requestWithSua = spec.buildRequests([bid], bidderRequestWithSua); const data = requestWithSua.data; - expect(data.bids[0].sua).to.exist; - expect(data.bids[0].sua).to.deep.equal(sua); - const request = spec.buildRequests(bidRequests, bidderRequest); - expect(request.data.bids[0].sua).to.not.exist; + expect(data.params.sua).to.exist; + expect(data.params.sua).to.deep.equal(JSON.stringify(sua)); }); describe('COPPA Param', function() { - it('should set coppa equal 0 in bid request if coppa is set to false', function() { + it('should set coppa equal 0 in bid request if coppa is set to 0', function() { const request = spec.buildRequests(bidRequests, bidderRequest); - expect(request.data.bids[0].coppa).to.be.equal(0); + expect(request.data.params.coppa).to.be.equal(0); }); - it('should set coppa equal 1 in bid request if coppa is set to true', function() { - const bid = utils.deepClone(bidRequests[0]); - bid.ortb2 = { + it('should set coppa equal 1 in bid request if coppa is set to 1', function() { + const bidderRequestWithCoppa = utils.deepClone(bidderRequest); + bidderRequestWithCoppa.ortb2 = { 'regs': { - 'coppa': true, + 'coppa': 1, } }; - const request = spec.buildRequests([bid], bidderRequest); - expect(request.data.bids[0].coppa).to.be.equal(1); + const request = spec.buildRequests(bidRequests, bidderRequestWithCoppa); + expect(request.data.params.coppa).to.be.equal(1); }); }); }); diff --git a/test/spec/modules/storageControl_spec.js b/test/spec/modules/storageControl_spec.js index a7941de7ef1..a3fb571256b 100644 --- a/test/spec/modules/storageControl_spec.js +++ b/test/spec/modules/storageControl_spec.js @@ -38,24 +38,26 @@ describe('storageControl', () => { beforeEach(() => { metadata.register('mockModule', { disclosures: { - 'mock.url': [ - { - identifier: 'mockCookie', - type: 'cookie' - }, - { - identifier: 'mockKey', - type: 'web' - }, - { - identifier: 'wildcard*', - type: 'cookie' - }, - { - identifier: 'wrongType', - type: 'wrong' - } - ] + 'mock.url': { + disclosures: [ + { + identifier: 'mockCookie', + type: 'cookie' + }, + { + identifier: 'mockKey', + type: 'web' + }, + { + identifier: 'wildcard*', + type: 'cookie' + }, + { + identifier: 'wrongType', + type: 'wrong' + } + ] + } }, components: [ { diff --git a/test/spec/modules/stroeerCoreBidAdapter_spec.js b/test/spec/modules/stroeerCoreBidAdapter_spec.js index f5b566db25a..5458a33ec79 100644 --- a/test/spec/modules/stroeerCoreBidAdapter_spec.js +++ b/test/spec/modules/stroeerCoreBidAdapter_spec.js @@ -133,7 +133,7 @@ describe('stroeerCore bid adapter', function () { }); const createWindow = (href, params = {}) => { - let {parent, top, frameElement, placementElements = []} = params; + const {parent, top, frameElement, placementElements = []} = params; const protocol = href.startsWith('https') ? 'https:' : 'http:'; const win = { @@ -342,7 +342,7 @@ describe('stroeerCore bid adapter', function () { it('should use hardcoded url as default endpoint', () => { const bidReq = buildBidderRequest(); - let serverRequestInfo = spec.buildRequests(bidReq.bids, bidReq); + const serverRequestInfo = spec.buildRequests(bidReq.bids, bidReq); assert.equal(serverRequestInfo.method, 'POST'); assert.isObject(serverRequestInfo.data); @@ -375,7 +375,7 @@ describe('stroeerCore bid adapter', function () { bidReq.bids[0].params = sample.params; bidReq.bids.length = 1; - let serverRequestInfo = spec.buildRequests(bidReq.bids, bidReq); + const serverRequestInfo = spec.buildRequests(bidReq.bids, bidReq); assert.equal(serverRequestInfo.method, 'POST'); assert.isObject(serverRequestInfo.data); @@ -645,7 +645,7 @@ describe('stroeerCore bid adapter', function () { const serverRequestInfo = spec.buildRequests(bidReq.bids, bidReq); assert.lengthOf(serverRequestInfo.data.bids, 2); - for (let bid of serverRequestInfo.data.bids) { + for (const bid of serverRequestInfo.data.bids) { assert.isUndefined(bid.viz); } }); @@ -657,7 +657,7 @@ describe('stroeerCore bid adapter', function () { const serverRequestInfo = spec.buildRequests(bidderRequest.bids, bidderRequest); assert.lengthOf(serverRequestInfo.data.bids, 2); - for (let bid of serverRequestInfo.data.bids) { + for (const bid of serverRequestInfo.data.bids) { assert.isUndefined(bid.ref); } }); @@ -1010,7 +1010,7 @@ describe('stroeerCore bid adapter', function () { it('should interpret a video response', () => { const bidderResponse = buildBidderResponseWithVideo(); const bidResponses = spec.interpretResponse({body: bidderResponse}); - let videoBidResponse = bidResponses[0]; + const videoBidResponse = bidResponses[0]; assertStandardFieldsOnVideoBid(videoBidResponse, 'bid1', 'video', 800, 250, 4); }) diff --git a/test/spec/modules/stvBidAdapter_spec.js b/test/spec/modules/stvBidAdapter_spec.js index bd53053f06d..5e08a4f77f9 100644 --- a/test/spec/modules/stvBidAdapter_spec.js +++ b/test/spec/modules/stvBidAdapter_spec.js @@ -9,7 +9,7 @@ describe('stvAdapter', function() { const adapter = newBidder(spec); describe('isBidRequestValid', function() { - let bid = { + const bid = { 'bidder': 'stv', 'params': { 'placement': '6682', @@ -30,7 +30,7 @@ describe('stvAdapter', function() { }); it('should return false when required params are not passed', function() { - let invalidBid = Object.assign({}, bid); + const invalidBid = Object.assign({}, bid); delete invalidBid.params; invalidBid.params = { 'someIncorrectParam': 0 @@ -40,7 +40,7 @@ describe('stvAdapter', function() { }); describe('buildRequests', function() { - let bidRequests = [ + const bidRequests = [ // banner { 'bidder': 'stv', @@ -292,7 +292,7 @@ describe('stvAdapter', function() { it('sends bid request 1 to our endpoint via GET', function() { expect(request1.method).to.equal('GET'); expect(request1.url).to.equal(ENDPOINT_URL); - let data = request1.data.replace(/rnd=\d+\&/g, '').replace(/ref=.*\&bid/g, 'bid').replace(/pbver=.*?&/g, 'pbver=test&'); + const data = request1.data.replace(/rnd=\d+\&/g, '').replace(/ref=.*\&bid/g, 'bid').replace(/pbver=.*?&/g, 'pbver=test&'); expect(data).to.equal('_f=html&alternative=prebid_js&_ps=6682&srw=300&srh=250&idt=100&bid_id=30b31c1838de1e1&pbver=test&schain=1.0,0!reseller.com,aaaaa,1,BidRequest4,,&uids=id5%3A1234,id5_linktype%3Aabc,netid%3A2345,uid2%3A3456,sharedid%3A4567,liverampid%3A5678,criteoid%3A6789,utiq%3A7890,euid%3A8901&pfilter%5Bfloorprice%5D=1000000&pfilter%5Bgeo%5D%5Bcountry%5D=DE&gdpr_consent=BOJ%2FP2HOJ%2FP2HABABMAAAAAZ%2BA%3D%3D&gdpr=true&bcat=IAB2%2CIAB4&dvt=desktop&pbcode=testDiv1&media_types%5Bbanner%5D=300x250'); }); @@ -300,7 +300,7 @@ describe('stvAdapter', function() { it('sends bid request 2 endpoint via GET', function() { expect(request2.method).to.equal('GET'); expect(request2.url).to.equal(ENDPOINT_URL); - let data = request2.data.replace(/rnd=\d+\&/g, '').replace(/ref=.*\&bid/g, 'bid').replace(/pbver=.*?&/g, 'pbver=test&'); + const data = request2.data.replace(/rnd=\d+\&/g, '').replace(/ref=.*\&bid/g, 'bid').replace(/pbver=.*?&/g, 'pbver=test&'); expect(data).to.equal('_f=html&alternative=prebid_js&_ps=101&srw=300&srh=250&idt=100&bid_id=30b31c1838de1e2&pbver=test&uids=id5%3A1234,id5_linktype%3Aabc,netid%3A2345,uid2%3A3456,sharedid%3A4567,liverampid%3A5678,criteoid%3A6789,utiq%3A7890,euid%3A8901&gdpr_consent=BOJ%2FP2HOJ%2FP2HABABMAAAAAZ%2BA%3D%3D&gdpr=true&prebidDevMode=1&media_types%5Bbanner%5D=300x250'); }); @@ -314,7 +314,7 @@ describe('stvAdapter', function() { it('sends bid request 3 without gdprConsent to our endpoint via GET', function() { expect(request3.method).to.equal('GET'); expect(request3.url).to.equal(ENDPOINT_URL); - let data = request3.data.replace(/rnd=\d+\&/g, '').replace(/ref=.*\&bid/g, 'bid').replace(/pbver=.*?&/g, 'pbver=test&'); + const data = request3.data.replace(/rnd=\d+\&/g, '').replace(/ref=.*\&bid/g, 'bid').replace(/pbver=.*?&/g, 'pbver=test&'); expect(data).to.equal('_f=html&alternative=prebid_js&_ps=6682&srw=300&srh=250&idt=100&bid_id=30b31c1838de1e3&pbver=test&pfilter%5Bfloorprice%5D=1000000&pfilter%5Bgeo%5D%5Bcountry%5D=DE&bcat=IAB2%2CIAB4&dvt=desktop&pbcode=testDiv2&media_types%5Bbanner%5D=300x250'); }); @@ -322,7 +322,7 @@ describe('stvAdapter', function() { it('sends bid request 4 (video) without gdprConsent endpoint via GET', function() { expect(request4.method).to.equal('GET'); expect(request4.url).to.equal(ENDPOINT_URL); - let data = request4.data.replace(/rnd=\d+\&/g, '').replace(/ref=.*\&bid/g, 'bid').replace(/pbver=.*?&/g, 'pbver=test&'); + const data = request4.data.replace(/rnd=\d+\&/g, '').replace(/ref=.*\&bid/g, 'bid').replace(/pbver=.*?&/g, 'pbver=test&'); expect(data).to.equal('_f=vast2&alternative=prebid_js&_ps=101&srw=640&srh=480&idt=100&bid_id=30b31c1838de1e4&pbver=test&pfilter%5Bmax_duration%5D=20&prebidDevMode=1&pbcode=testDiv3&media_types%5Bvideo%5D=640x480'); }); @@ -330,7 +330,7 @@ describe('stvAdapter', function() { it('sends bid request 5 (video) to our endpoint via GET', function() { expect(request5.method).to.equal('GET'); expect(request5.url).to.equal(ENDPOINT_URL); - let data = request5.data.replace(/rnd=\d+\&/g, '').replace(/ref=.*\&bid/g, 'bid').replace(/pbver=.*?&/g, 'pbver=test&'); + const data = request5.data.replace(/rnd=\d+\&/g, '').replace(/ref=.*\&bid/g, 'bid').replace(/pbver=.*?&/g, 'pbver=test&'); expect(data).to.equal('_f=vast2&alternative=prebid_js&_ps=101&srw=640&srh=480&idt=100&bid_id=30b31c1838de1e41&pbver=test&pfilter%5Bmax_duration%5D=40&prebidDevMode=1&pbcode=testDiv4&media_types%5Bvideo%5D=640x480'); }); @@ -338,13 +338,13 @@ describe('stvAdapter', function() { it('sends bid request 6 (video) to our endpoint via GET', function() { expect(request6.method).to.equal('GET'); expect(request6.url).to.equal(ENDPOINT_URL); - let data = request6.data.replace(/rnd=\d+\&/g, '').replace(/ref=.*\&bid/g, 'bid').replace(/pbver=.*?&/g, 'pbver=test&'); + const data = request6.data.replace(/rnd=\d+\&/g, '').replace(/ref=.*\&bid/g, 'bid').replace(/pbver=.*?&/g, 'pbver=test&'); expect(data).to.equal('_f=vast2&alternative=prebid_js&_ps=101&srw=640&srh=480&idt=100&bid_id=30b31c1838de1e41&pbver=test&pfilter%5Bmax_duration%5D=20&prebidDevMode=1&pbcode=testDiv4&media_types%5Bvideo%5D=640x480'); }); }); describe('interpretResponse', function() { - let serverResponse = { + const serverResponse = { 'body': { 'cpm': 5000000, 'crid': 100500, @@ -360,7 +360,7 @@ describe('stvAdapter', function() { 'adomain': ['bdomain'] } }; - let serverVideoResponse = { + const serverVideoResponse = { 'body': { 'cpm': 5000000, 'crid': 100500, @@ -376,7 +376,7 @@ describe('stvAdapter', function() { } }; - let expectedResponse = [{ + const expectedResponse = [{ requestId: '23beaa6af6cdde', cpm: 0.5, width: 0, @@ -404,21 +404,21 @@ describe('stvAdapter', function() { }]; it('should get the correct bid response by display ad', function() { - let bidRequest = [{ + const bidRequest = [{ 'method': 'GET', 'url': ENDPOINT_URL, 'data': { 'bid_id': '30b31c1838de1e' } }]; - let result = spec.interpretResponse(serverResponse, bidRequest[0]); + const result = spec.interpretResponse(serverResponse, bidRequest[0]); expect(Object.keys(result[0])).to.include.members(Object.keys(expectedResponse[0])); expect(result[0].meta.advertiserDomains.length).to.equal(1); expect(result[0].meta.advertiserDomains[0]).to.equal(expectedResponse[0].meta.advertiserDomains[0]); }); it('should get the correct smartstream video bid response by display ad', function() { - let bidRequest = [{ + const bidRequest = [{ 'method': 'GET', 'url': ENDPOINT_URL, 'mediaTypes': { @@ -431,16 +431,16 @@ describe('stvAdapter', function() { 'bid_id': '30b31c1838de1e' } }]; - let result = spec.interpretResponse(serverVideoResponse, bidRequest[0]); + const result = spec.interpretResponse(serverVideoResponse, bidRequest[0]); expect(Object.keys(result[0])).to.include.members(Object.keys(expectedResponse[1])); expect(result[0].meta.advertiserDomains.length).to.equal(0); }); it('handles empty bid response', function() { - let response = { + const response = { body: {} }; - let result = spec.interpretResponse(response); + const result = spec.interpretResponse(response); expect(result.length).to.equal(0); }); }); @@ -475,22 +475,22 @@ describe('stvAdapter', function() { }); it(`array should have only one object and it should have a property type = 'iframe'`, function() { expect(spec.getUserSyncs({ iframeEnabled: true }, serverResponses).length).to.be.equal(1); - let [userSync] = spec.getUserSyncs({ iframeEnabled: true }, serverResponses); + const [userSync] = spec.getUserSyncs({ iframeEnabled: true }, serverResponses); expect(userSync).to.have.property('type'); expect(userSync.type).to.be.equal('iframe'); }); it(`we have valid sync url for iframe`, function() { - let [userSync] = spec.getUserSyncs({ iframeEnabled: true }, serverResponses, { consentString: 'anyString' }); + const [userSync] = spec.getUserSyncs({ iframeEnabled: true }, serverResponses, { consentString: 'anyString' }); expect(userSync.url).to.be.equal('anyIframeUrl?a=1&gdpr_consent=anyString') expect(userSync.type).to.be.equal('iframe'); }); it(`we have valid sync url for image`, function() { - let [userSync] = spec.getUserSyncs({ pixelEnabled: true }, serverResponses, { gdprApplies: true, consentString: 'anyString' }); + const [userSync] = spec.getUserSyncs({ pixelEnabled: true }, serverResponses, { gdprApplies: true, consentString: 'anyString' }); expect(userSync.url).to.be.equal('anyImageUrl?gdpr=1&gdpr_consent=anyString') expect(userSync.type).to.be.equal('image'); }); it(`we have valid sync url for image and iframe`, function() { - let userSync = spec.getUserSyncs({ iframeEnabled: true, pixelEnabled: true }, serverResponses, { gdprApplies: true, consentString: 'anyString' }); + const userSync = spec.getUserSyncs({ iframeEnabled: true, pixelEnabled: true }, serverResponses, { gdprApplies: true, consentString: 'anyString' }); expect(userSync.length).to.be.equal(3); expect(userSync[0].url).to.be.equal('anyIframeUrl?a=1&gdpr=1&gdpr_consent=anyString') expect(userSync[0].type).to.be.equal('iframe'); diff --git a/test/spec/modules/symitriAnalyticsAdapter_spec.js b/test/spec/modules/symitriAnalyticsAdapter_spec.js index c02d5b55696..d52ae2e88c0 100644 --- a/test/spec/modules/symitriAnalyticsAdapter_spec.js +++ b/test/spec/modules/symitriAnalyticsAdapter_spec.js @@ -4,7 +4,7 @@ import adapterManager from 'src/adapterManager.js'; import { server } from 'test/mocks/xhr.js'; import { EVENTS } from 'src/constants.js'; -let events = require('src/events'); +const events = require('src/events'); describe('symitri analytics adapter', function () { beforeEach(function () { @@ -16,13 +16,13 @@ describe('symitri analytics adapter', function () { }); describe('track', function () { - let initOptionsValid = { + const initOptionsValid = { apiAuthToken: 'TOKEN1234' }; - let initOptionsInValid = { + const initOptionsInValid = { }; - let bidWon = { + const bidWon = { 'bidderCode': 'appnexus', 'width': 300, 'height': 250, @@ -81,9 +81,9 @@ describe('symitri analytics adapter', function () { }); events.emit(EVENTS.BID_WON, bidWon); expect(server.requests.length).to.equal(1); - let winEventData = JSON.parse(server.requests[0].requestBody); + const winEventData = JSON.parse(server.requests[0].requestBody); expect(winEventData).to.deep.equal(bidWon); - let authToken = server.requests[0].requestHeaders['Authorization']; + const authToken = server.requests[0].requestHeaders['Authorization']; expect(authToken).to.equal(initOptionsValid.apiAuthToken); }); }); diff --git a/test/spec/modules/symitriDapRtdProvider_spec.js b/test/spec/modules/symitriDapRtdProvider_spec.js index 7912e76a994..f3deb840658 100644 --- a/test/spec/modules/symitriDapRtdProvider_spec.js +++ b/test/spec/modules/symitriDapRtdProvider_spec.js @@ -11,7 +11,7 @@ import {hook} from '../../../src/hook.js'; import { EVENTS } from 'src/constants.js'; const responseHeader = {'Content-Type': 'application/json'}; -let events = require('src/events'); +const events = require('src/events'); describe('symitriDapRtdProvider', function() { const testReqBidsConfigObj = { @@ -89,7 +89,7 @@ describe('symitriDapRtdProvider', function() { 'segtax': 710, 'identity': sampleIdentity } - let cacheExpiry = Math.round(Date.now() / 1000.0) + 300; // in seconds + const cacheExpiry = Math.round(Date.now() / 1000.0) + 300; // in seconds const sampleCachedToken = {'expires_at': cacheExpiry, 'token': 'eyJhbGciOiJkaXIiLCJlbmMiOiJBMTI4Q0JDLUhTMjU2Iiwia2lkIjoicGFzc3dvcmQxIn0..6buzBd2BjtgoyaNbHN8YnQ.l38avCfm3sYNy798-ETYOugz0cOx1cCkjACkAhYszxzrZ0sUJ0AiF-NdDXVTiTyp2Ih3vCWKzS0rKJ8lbS1zhyEVWVu91QwtwseM2fBbwA5ggAgBEo5wV-IXqDLPxVnxsPF0D3hP6cNCiH9Q2c-vULfsLhMhG5zvvZDPBbn4hUY5fKB8LoCBTF9rbuuWGYK1nramnb4AlS5UK82wBsHQea1Ou_Kp5wWCMNZ6TZk5qKIuRBfPIAhQblWvHECaHXkg1wyoM9VASs_yNhne7RR-qkwzbFiPFiMJibNOt9hF3_vPDJO5-06ZBjRTP1BllYGWxI-uQX6InzN18Wtun2WHqg.63sH0SNlIRcsK57v0pMujfB_nhU8Y5CuQbsHqH5MGoM'}; const cachedEncryptedMembership = {'expires_at': cacheExpiry, 'encryptedSegments': 'eyJhbGciOiJkaXIiLCJlbmMiOiJBMTI4Q0JDLUhTMjU2Iiwia2lkIjoic29tZXNlY3JldGludmF1bHQifQ..IvnIUQDqWBVYIS0gbcE9bw.Z4NZGvtogWaWlGH4e-GdYKe_PUc15M2x3Bj85rMWsN1A17mIxQIMOfg2hsQ2tgieLu5LggWPmsFu1Wbph6P0k3kOu1dVReoIhOHzxw50rP0DLHKaEZ5mLMJ7Lcosvwh4miIfFuCHlsX7J0sFgOTAp0zGo1S_UsHLtev1JflhjoSB0AoX95ALbAnyctirPuLJM8gZ1vXTiZ01jpvucGyR1lM4cWjPOeD8jPtgwaPGgSRZXE-3X2Cqy7z4Giam5Uqu74LPWTBuKtUQTGyAXA5QJoP7xwTbsU4O1f69lu3fWNqC92GijeTH1A4Zd_C-WXxWuQlDEURjlkWQoaqTHka2OqlnwukEQIf_v0r5KQQX64CTLhEUH91jeD0-E9ClcIP7pwOLxxqiKoaBmx8Mrnm_6Agj5DtTA1rusy3AL63sI_rsUxrmLrVt0Wft4aCfRkW8QpQxu8clFdOmce0NNCGeBCyCPVw9d9izrILlXJ6rItU2cpFrcbz8uw2otamF5eOFCOY3IzHedWVNNuKHFIUVC_xYSlsYvQ8f2QIP1eiMbmukcuPzmTzjw1h1_7IKaj-jJkXrnrY-TdDgX_4-_Z3rmbpXK2yTR7dBrsg-ubqFbgbKic1b4zlQEO_LbBlgPl3DYdWEuJ8CY2NUt1GfpATQGsufS2FTY1YGw_gkPe3q04l_cgLafDoxHvHh_t_0ZgPjciW82gThB_kN4RP7Mc3krVcXl_P6N1VbV07xyx0hCyVsrrxbLslI8q9wYDiLGci7mNmByM5j7SXV9jPwwPkHtn0HfMJlw2PFbIDPjgG3h7sOyLcBIJTTvuUIgpHPIkRWLIl_4FlIucXbJ7orW2nt5BWleBVHgumzGcnl9ZNcZb3W-dsdYPSOmuj0CY28MRTP2oJ1rzLInbDDpIRffJBtR7SS4nYyy7Vi09PtBigod5YNz1Q0WDSJxr8zeH_aKFaXInw7Bfo_U0IAcLiRgcT0ogsMLeQRjRFy27mr4XNJv3NtHhbdjDAwF2aClCktXyXbQaVdsPH2W71v6m2Q9rB5GQWOktw2s5f-4N1-_EBPGq6TgjF-aJZP22MJVwp1pimT50DfOzoeEqDwi862NNwNNoHmcObH0ZfwAXlhRxsgupNBe20-MNNABj2Phlfv4DUrtQbMdfCnNiypzNCmoTb7G7c_o5_JUwoV_GVkwUtvmi_IUm05P4GeMASSUw8zDKVRAj9h31C2cabM8RjMHGhkbCWpUP2pcz9zlJ7Y76Dh3RLnctfTw7DG9U4w4UlaxNZOgLUiSrGwfyapuSiuGUpuOJkBBLiHmEqAGI5C8oJpcVRccNlHxJAYowgXyFopD5Fr-FkXmv8KMkS0h5C9F6KihmDt5sqDD0qnjM0hHJgq01l7wjVnhEmPpyD-6auFQ-xDnbh1uBOJ_0gCVbRad--FSa5p-dXenggegRxOvZXJ0iAtM6Fal5Og-RCjexIHa9WhVbXhQBJpkSTWwAajZJ64eQ.yih49XB51wE-Xob7COT9OYqBrzBmIMVCQbLFx2UdzkI'}; const cachedMembership = {'expires_at': cacheExpiry, 'said': 'eyJhbGciOiJkaXIiLCJlbmMiOiJBMTI4Q0JDLUhTMjU2Iiwia2lkIjoicGFzc3dvcmQxIn0..QwvU5h0NVJYaJbs5EqWCKA.XNaJHSlnsH8P-yBIr3gIEqavLONWDIFyj7QCHFwJVkwXH_EYkxrk0_26b0uMPzfJp5URnqxKZusMH9DzEJsmj8EMrKQv1y3IYYMsW5_0BdP5bcAWfG6fzOqtMOwLiYRkYiQOqn1ZVGzhovheHWEmNr2_oCY0LvAr3iN1eG_K-l-bBKvBWnwvuuGKquUfCqO8NMMq6wtkecEXM9blqFRZ7oNYmW2aIG7qcHUsrUW7HMr9Ev2Ik0sIeEUsOYrgf_X_VA64RgKSTRugS9FupMv1p54JkHokwduF9pOFmW8QLQi8itFogKGbbgvOTNnmahxQUX5FcrjjYLqHwKqC8htLdlHnO5LWU9l4A7vLXrRurvoSnh0cAJy0GsdoyEwTqR9bwVFHoPquxlJjQ4buEd7PIxpBj9Qg9oOPH3b2upbMTu5CQ9oj526eXPhP5G54nwGklm2AZ3Vggd7jCQJn45Jjiq0iIfsXAtpqS2BssCLBN8WhmUTnStK8m5sux6WUBdrpDESQjPj-EEHVS-DB5rA7icRUh6EzRxzen2rndvHvnwVhSG_l6cwPYuJ0HE0KBmYHOoqNpKwzoGiKFHrf4ReA06iWB3V2TEGJucGujhtQ9_18WwHCeJ1XtQiiO1eqa3tp5MwAbFXawVFl3FFOBgadrPyvGmkmUJ6FCLU2MSwHiYZmANMnJsokFX_6DwoAgO3U_QnvEHIVSvefc7ReeJ8fBDdmrH3LtuLrUpXsvLvEIMQdWQ_SXhjKIi7tOODR8CfrhUcdIjsp3PZs1DpuOcDB6YJKbGnKZTluLUJi3TyHgyi-DHXdTm-jSE5i_DYJGW-t2Gf23FoQhexv4q7gdrfsKfcRJNrZLp6Gd6jl4zHhUtY.nprKBsy9taQBk6dCPbA7BFF0CiGhQOEF_MazZ2bedqk', 'cohorts': ['9', '11', '13']}; @@ -128,12 +128,12 @@ describe('symitriDapRtdProvider', function() { } }; - let membership = { + const membership = { said: cachedMembership.said, cohorts: cachedMembership.cohorts, attributes: null }; - let encMembership = { + const encMembership = { encryptedSegments: cachedEncryptedMembership.encryptedSegments }; encRtdUserObj.segment.push({ id: encMembership.encryptedSegments }); @@ -174,11 +174,11 @@ describe('symitriDapRtdProvider', function() { describe('Get Real-Time Data', function() { it('gets rtd from local storage cache', function() { - let dapGetMembershipFromLocalStorageStub = sinon.stub(dapUtils, 'dapGetMembershipFromLocalStorage').returns(membership) - let dapGetRtdObjStub = sinon.stub(dapUtils, 'dapGetRtdObj').returns(cachedRtd) - let dapGetEncryptedMembershipFromLocalStorageStub = sinon.stub(dapUtils, 'dapGetEncryptedMembershipFromLocalStorage').returns(encMembership) - let dapGetEncryptedRtdObjStub = sinon.stub(dapUtils, 'dapGetEncryptedRtdObj').returns(cachedEncRtd) - let callDapApisStub = sinon.stub(dapUtils, 'callDapAPIs') + const dapGetMembershipFromLocalStorageStub = sinon.stub(dapUtils, 'dapGetMembershipFromLocalStorage').returns(membership) + const dapGetRtdObjStub = sinon.stub(dapUtils, 'dapGetRtdObj').returns(cachedRtd) + const dapGetEncryptedMembershipFromLocalStorageStub = sinon.stub(dapUtils, 'dapGetEncryptedMembershipFromLocalStorage').returns(encMembership) + const dapGetEncryptedRtdObjStub = sinon.stub(dapUtils, 'dapGetEncryptedRtdObj').returns(cachedEncRtd) + const callDapApisStub = sinon.stub(dapUtils, 'callDapAPIs') try { storage.setDataInLocalStorage(DAP_TOKEN, JSON.stringify(sampleCachedToken)); expect(ortb2).to.eql({}); @@ -200,19 +200,19 @@ describe('symitriDapRtdProvider', function() { describe('calling DAP APIs', function() { it('Calls callDapAPIs for unencrypted segments flow', function() { storage.setDataInLocalStorage(DAP_TOKEN, JSON.stringify(sampleCachedToken)); - let dapExtractExpiryFromTokenStub = sinon.stub(dapUtils, 'dapExtractExpiryFromToken').returns(cacheExpiry) + const dapExtractExpiryFromTokenStub = sinon.stub(dapUtils, 'dapExtractExpiryFromToken').returns(cacheExpiry) try { expect(ortb2).to.eql({}); dapUtils.callDapAPIs(bidConfig, () => {}, cmoduleConfig, {}); - let membership = {'cohorts': ['9', '11', '13'], 'said': 'sample-said'} - let membershipRequest = server.requests[0]; + const membership = {'cohorts': ['9', '11', '13'], 'said': 'sample-said'} + const membershipRequest = server.requests[0]; membershipRequest.respond(200, responseHeader, JSON.stringify(membership)); - let tokenWithExpiry = 'Sample-token-with-exp' - let tokenizeRequest = server.requests[1]; + const tokenWithExpiry = 'Sample-token-with-exp' + const tokenizeRequest = server.requests[1]; tokenizeRequest.requestHeaders['Content-Type'].should.equal('application/json'); responseHeader['Symitri-DAP-Token'] = tokenWithExpiry; tokenizeRequest.respond(200, responseHeader, JSON.stringify(tokenWithExpiry)); - let data = dapUtils.dapGetRtdObj(membership, cmoduleConfig.params.segtax); + const data = dapUtils.dapGetRtdObj(membership, cmoduleConfig.params.segtax); expect(ortb2.user.data).to.deep.include.members(data.rtd.ortb2.user.data); } finally { dapExtractExpiryFromTokenStub.restore(); @@ -221,20 +221,20 @@ describe('symitriDapRtdProvider', function() { it('Calls callDapAPIs for encrypted segments flow', function() { storage.setDataInLocalStorage(DAP_TOKEN, JSON.stringify(sampleCachedToken)); - let dapExtractExpiryFromTokenStub = sinon.stub(dapUtils, 'dapExtractExpiryFromToken').returns(cacheExpiry) + const dapExtractExpiryFromTokenStub = sinon.stub(dapUtils, 'dapExtractExpiryFromToken').returns(cacheExpiry) try { expect(ortb2).to.eql({}); dapUtils.callDapAPIs(bidConfig, () => {}, emoduleConfig, {}); - let encMembership = 'Sample-enc-token'; - let membershipRequest = server.requests[0]; + const encMembership = 'Sample-enc-token'; + const membershipRequest = server.requests[0]; responseHeader['Symitri-DAP-Token'] = encMembership; membershipRequest.respond(200, responseHeader, JSON.stringify(encMembership)); - let tokenWithExpiry = 'Sample-token-with-exp' - let tokenizeRequest = server.requests[1]; + const tokenWithExpiry = 'Sample-token-with-exp' + const tokenizeRequest = server.requests[1]; tokenizeRequest.requestHeaders['Content-Type'].should.equal('application/json'); responseHeader['Symitri-DAP-Token'] = tokenWithExpiry; tokenizeRequest.respond(200, responseHeader, JSON.stringify(tokenWithExpiry)); - let data = dapUtils.dapGetEncryptedRtdObj({'encryptedSegments': encMembership}, emoduleConfig.params.segtax); + const data = dapUtils.dapGetEncryptedRtdObj({'encryptedSegments': encMembership}, emoduleConfig.params.segtax); expect(ortb2.user.data).to.deep.include.members(data.rtd.ortb2.user.data); } finally { dapExtractExpiryFromTokenStub.restore(); @@ -244,27 +244,27 @@ describe('symitriDapRtdProvider', function() { describe('dapTokenize', function () { it('dapTokenize error callback', function () { - let configAsync = JSON.parse(JSON.stringify(sampleConfig)); - let submoduleCallback = dapUtils.dapTokenize(configAsync, sampleIdentity, onDone, + const configAsync = JSON.parse(JSON.stringify(sampleConfig)); + const submoduleCallback = dapUtils.dapTokenize(configAsync, sampleIdentity, onDone, function(token, status, xhr, onDone) { }, function(xhr, status, error, onDone) { } ); - let request = server.requests[0]; + const request = server.requests[0]; request.respond(400, responseHeader, JSON.stringify('error')); expect(submoduleCallback).to.equal(undefined); }); it('dapTokenize success callback', function () { - let configAsync = JSON.parse(JSON.stringify(sampleConfig)); - let submoduleCallback = dapUtils.dapTokenize(configAsync, sampleIdentity, onDone, + const configAsync = JSON.parse(JSON.stringify(sampleConfig)); + const submoduleCallback = dapUtils.dapTokenize(configAsync, sampleIdentity, onDone, function(token, status, xhr, onDone) { }, function(xhr, status, error, onDone) { } ); - let request = server.requests[0]; + const request = server.requests[0]; request.requestHeaders['Content-Type'].should.equal('application/json'); request.respond(200, responseHeader, JSON.stringify('success')); expect(submoduleCallback).to.equal(undefined); @@ -273,28 +273,28 @@ describe('symitriDapRtdProvider', function() { describe('dapX2Tokenize', function () { it('dapX2Tokenize error callback', function () { - let configAsync = JSON.parse(JSON.stringify(sampleX2Config)); - let submoduleCallback = dapUtils.dapTokenize(configAsync, sampleIdentity, onDone, + const configAsync = JSON.parse(JSON.stringify(sampleX2Config)); + const submoduleCallback = dapUtils.dapTokenize(configAsync, sampleIdentity, onDone, function(token, status, xhr, onDone) { }, function(xhr, status, error, onDone) { } ); - let request = server.requests[0]; + const request = server.requests[0]; request.requestHeaders['Content-Type'].should.equal('application/json'); request.respond(400, responseHeader, JSON.stringify('error')); expect(submoduleCallback).to.equal(undefined); }); it('dapX2Tokenize success callback', function () { - let configAsync = JSON.parse(JSON.stringify(sampleX2Config)); - let submoduleCallback = dapUtils.dapTokenize(configAsync, sampleIdentity, onDone, + const configAsync = JSON.parse(JSON.stringify(sampleX2Config)); + const submoduleCallback = dapUtils.dapTokenize(configAsync, sampleIdentity, onDone, function(token, status, xhr, onDone) { }, function(xhr, status, error, onDone) { } ); - let request = server.requests[0]; + const request = server.requests[0]; request.requestHeaders['Content-Type'].should.equal('application/json'); request.respond(200, responseHeader, JSON.stringify('success')); expect(submoduleCallback).to.equal(undefined); @@ -318,7 +318,7 @@ describe('symitriDapRtdProvider', function() { 'domain': '', 'segtax': 710 }; - let identity = { + const identity = { type: 'dap-signature:1.0.0' }; expect(dapUtils.dapTokenize(config, identity, onDone, null, null)).to.be.equal(undefined); @@ -346,27 +346,27 @@ describe('symitriDapRtdProvider', function() { describe('dapMembership', function () { it('dapMembership success callback', function () { - let configAsync = JSON.parse(JSON.stringify(sampleConfig)); - let submoduleCallback = dapUtils.dapMembership(configAsync, 'token', onDone, + const configAsync = JSON.parse(JSON.stringify(sampleConfig)); + const submoduleCallback = dapUtils.dapMembership(configAsync, 'token', onDone, function(token, status, xhr, onDone) { }, function(xhr, status, error, onDone) { } ); - let request = server.requests[0]; + const request = server.requests[0]; request.respond(200, responseHeader, JSON.stringify('success')); expect(submoduleCallback).to.equal(undefined); }); it('dapMembership error callback', function () { - let configAsync = JSON.parse(JSON.stringify(sampleConfig)); - let submoduleCallback = dapUtils.dapMembership(configAsync, 'token', onDone, + const configAsync = JSON.parse(JSON.stringify(sampleConfig)); + const submoduleCallback = dapUtils.dapMembership(configAsync, 'token', onDone, function(token, status, xhr, onDone) { }, function(xhr, status, error, onDone) { } ); - let request = server.requests[0]; + const request = server.requests[0]; request.respond(400, responseHeader, JSON.stringify('error')); expect(submoduleCallback).to.equal(undefined); }); @@ -374,27 +374,27 @@ describe('symitriDapRtdProvider', function() { describe('dapEncMembership', function () { it('dapEncMembership success callback', function () { - let configAsync = JSON.parse(JSON.stringify(esampleConfig)); - let submoduleCallback = dapUtils.dapEncryptedMembership(configAsync, 'token', onDone, + const configAsync = JSON.parse(JSON.stringify(esampleConfig)); + const submoduleCallback = dapUtils.dapEncryptedMembership(configAsync, 'token', onDone, function(token, status, xhr, onDone) { }, function(xhr, status, error, onDone) { } ); - let request = server.requests[0]; + const request = server.requests[0]; request.respond(200, responseHeader, JSON.stringify('success')); expect(submoduleCallback).to.equal(undefined); }); it('dapEncMembership error callback', function () { - let configAsync = JSON.parse(JSON.stringify(esampleConfig)); - let submoduleCallback = dapUtils.dapEncryptedMembership(configAsync, 'token', onDone, + const configAsync = JSON.parse(JSON.stringify(esampleConfig)); + const submoduleCallback = dapUtils.dapEncryptedMembership(configAsync, 'token', onDone, function(token, status, xhr, onDone) { }, function(xhr, status, error, onDone) { } ); - let request = server.requests[0]; + const request = server.requests[0]; request.respond(400, responseHeader, JSON.stringify('error')); expect(submoduleCallback).to.equal(undefined); }); @@ -402,14 +402,14 @@ describe('symitriDapRtdProvider', function() { describe('dapMembership', function () { it('should invoke the getDapToken and getDapMembership', function () { - let membership = { + const membership = { said: 'item.said1', cohorts: 'item.cohorts', attributes: null }; - let getDapMembershipStub = sinon.stub(dapUtils, 'dapGetMembershipFromLocalStorage').returns(membership); - let callDapApisStub = sinon.stub(dapUtils, 'callDapAPIs'); + const getDapMembershipStub = sinon.stub(dapUtils, 'dapGetMembershipFromLocalStorage').returns(membership); + const callDapApisStub = sinon.stub(dapUtils, 'callDapAPIs'); try { generateRealTimeData(testReqBidsConfigObj, onDone, cmoduleConfig); expect(getDapMembershipStub.calledOnce).to.be.equal(true); @@ -422,12 +422,12 @@ describe('symitriDapRtdProvider', function() { describe('dapEncMembership test', function () { it('should invoke the getDapToken and getEncDapMembership', function () { - let encMembership = { + const encMembership = { encryptedSegments: 'enc.seg', }; - let getDapEncMembershipStub = sinon.stub(dapUtils, 'dapGetEncryptedMembershipFromLocalStorage').returns(encMembership); - let callDapApisStub = sinon.stub(dapUtils, 'callDapAPIs'); + const getDapEncMembershipStub = sinon.stub(dapUtils, 'dapGetEncryptedMembershipFromLocalStorage').returns(encMembership); + const callDapApisStub = sinon.stub(dapUtils, 'callDapAPIs'); try { generateRealTimeData(testReqBidsConfigObj, onDone, emoduleConfig); expect(getDapEncMembershipStub.calledOnce).to.be.equal(true); @@ -464,9 +464,9 @@ describe('symitriDapRtdProvider', function() { describe('dapExtractExpiryFromToken test', function () { it('test dapExtractExpiryFromToken function', function () { - let tokenWithoutExpiry = 'eyJhbGciOiJkaXIiLCJlbmMiOiJBMTI4Q0JDLUhTMjU2Iiwia2lkIjoicGFzc3dvcmQxIn0..6buzBd2BjtgoyaNbHN8YnQ.l38avCfm3sYNy798-ETYOugz0cOx1cCkjACkAhYszxzrZ0sUJ0AiF-NdDXVTiTyp2Ih3vCWKzS0rKJ8lbS1zhyEVWVu91QwtwseM2fBbwA5ggAgBEo5wV-IXqDLPxVnxsPF0D3hP6cNCiH9Q2c-vULfsLhMhG5zvvZDPBbn4hUY5fKB8LoCBTF9rbuuWGYK1nramnb4AlS5UK82wBsHQea1Ou_Kp5wWCMNZ6TZk5qKIuRBfPIAhQblWvHECaHXkg1wyoM9VASs_yNhne7RR-qkwzbFiPFiMJibNOt9hF3_vPDJO5-06ZBjRTP1BllYGWxI-uQX6InzN18Wtun2WHqg.63sH0SNlIRcsK57v0pMujfB_nhU8Y5CuQbsHqH5MGoM' + const tokenWithoutExpiry = 'eyJhbGciOiJkaXIiLCJlbmMiOiJBMTI4Q0JDLUhTMjU2Iiwia2lkIjoicGFzc3dvcmQxIn0..6buzBd2BjtgoyaNbHN8YnQ.l38avCfm3sYNy798-ETYOugz0cOx1cCkjACkAhYszxzrZ0sUJ0AiF-NdDXVTiTyp2Ih3vCWKzS0rKJ8lbS1zhyEVWVu91QwtwseM2fBbwA5ggAgBEo5wV-IXqDLPxVnxsPF0D3hP6cNCiH9Q2c-vULfsLhMhG5zvvZDPBbn4hUY5fKB8LoCBTF9rbuuWGYK1nramnb4AlS5UK82wBsHQea1Ou_Kp5wWCMNZ6TZk5qKIuRBfPIAhQblWvHECaHXkg1wyoM9VASs_yNhne7RR-qkwzbFiPFiMJibNOt9hF3_vPDJO5-06ZBjRTP1BllYGWxI-uQX6InzN18Wtun2WHqg.63sH0SNlIRcsK57v0pMujfB_nhU8Y5CuQbsHqH5MGoM' expect(dapUtils.dapExtractExpiryFromToken(tokenWithoutExpiry)).to.equal(undefined); - let tokenWithExpiry = 'eyJhbGciOiJkaXIiLCJlbmMiOiJBMTI4Q0JDLUhTMjU2Iiwia2lkIjoicGFzc3dvcmQxIiwiZXhwIjoxNjQzODMwMzY5fQ..hTbcSQgmmO0HUJJrQ5fRHw.7zjrQXNNVkb-GD0ZhIVhEPcWbyaDBilHTWv-bp1lFZ9mdkSC0QbcAvUbYteiTD7ya23GUwcL2WOW8WgRSHaWHOJe0B5NDqfdUGTzElWfu7fFodRxRgGmwG8Rq5xxteFKLLGHLf1mFYRJKDtjtgajGNUKIDfn9AEt-c5Qz4KU8VolG_KzrLROx-f6Z7MnoPTcwRCj0WjXD6j2D6RAZ80-mKTNIsMIELdj6xiabHcjDJ1WzwtwCZSE2y2nMs451pSYp8W-bFPfZmDDwrkjN4s9ASLlIXcXgxK-H0GsiEbckQOZ49zsIKyFtasBvZW8339rrXi1js-aBh99M7aS5w9DmXPpUDmppSPpwkeTfKiqF0cQiAUq8tpeEQrGDJuw3Qt2.XI8h9Xw-VZj_NOmKtV19wLM63S4snos7rzkoHf9FXCw' + const tokenWithExpiry = 'eyJhbGciOiJkaXIiLCJlbmMiOiJBMTI4Q0JDLUhTMjU2Iiwia2lkIjoicGFzc3dvcmQxIiwiZXhwIjoxNjQzODMwMzY5fQ..hTbcSQgmmO0HUJJrQ5fRHw.7zjrQXNNVkb-GD0ZhIVhEPcWbyaDBilHTWv-bp1lFZ9mdkSC0QbcAvUbYteiTD7ya23GUwcL2WOW8WgRSHaWHOJe0B5NDqfdUGTzElWfu7fFodRxRgGmwG8Rq5xxteFKLLGHLf1mFYRJKDtjtgajGNUKIDfn9AEt-c5Qz4KU8VolG_KzrLROx-f6Z7MnoPTcwRCj0WjXD6j2D6RAZ80-mKTNIsMIELdj6xiabHcjDJ1WzwtwCZSE2y2nMs451pSYp8W-bFPfZmDDwrkjN4s9ASLlIXcXgxK-H0GsiEbckQOZ49zsIKyFtasBvZW8339rrXi1js-aBh99M7aS5w9DmXPpUDmppSPpwkeTfKiqF0cQiAUq8tpeEQrGDJuw3Qt2.XI8h9Xw-VZj_NOmKtV19wLM63S4snos7rzkoHf9FXCw' expect(dapUtils.dapExtractExpiryFromToken(tokenWithExpiry)).to.equal(1643830369); }); }); @@ -474,7 +474,7 @@ describe('symitriDapRtdProvider', function() { describe('dapRefreshToken test', function () { it('test dapRefreshToken success response', function () { dapUtils.dapRefreshToken(ortb2, sampleConfig, true, onDone) - let request = server.requests[0]; + const request = server.requests[0]; request.requestHeaders['Content-Type'].should.equal('application/json'); responseHeader['Symitri-DAP-Token'] = sampleCachedToken.token; request.respond(200, responseHeader, JSON.stringify(sampleCachedToken.token)); @@ -483,7 +483,7 @@ describe('symitriDapRtdProvider', function() { it('test dapRefreshToken success response with deviceid 100', function () { dapUtils.dapRefreshToken(ortb2, esampleConfig, true, onDone) - let request = server.requests[0]; + const request = server.requests[0]; request.requestHeaders['Content-Type'].should.equal('application/json'); responseHeader['Symitri-DAP-100'] = sampleCachedToken.token; request.respond(200, responseHeader, ''); @@ -492,8 +492,8 @@ describe('symitriDapRtdProvider', function() { it('test dapRefreshToken success response with exp claim', function () { dapUtils.dapRefreshToken(ortb2, sampleConfig, true, onDone) - let request = server.requests[0]; - let tokenWithExpiry = 'eyJhbGciOiJkaXIiLCJlbmMiOiJBMTI4Q0JDLUhTMjU2Iiwia2lkIjoicGFzc3dvcmQxIiwiZXhwIjoxNjQzODMwMzY5fQ..hTbcSQgmmO0HUJJrQ5fRHw.7zjrQXNNVkb-GD0ZhIVhEPcWbyaDBilHTWv-bp1lFZ9mdkSC0QbcAvUbYteiTD7ya23GUwcL2WOW8WgRSHaWHOJe0B5NDqfdUGTzElWfu7fFodRxRgGmwG8Rq5xxteFKLLGHLf1mFYRJKDtjtgajGNUKIDfn9AEt-c5Qz4KU8VolG_KzrLROx-f6Z7MnoPTcwRCj0WjXD6j2D6RAZ80-mKTNIsMIELdj6xiabHcjDJ1WzwtwCZSE2y2nMs451pSYp8W-bFPfZmDDwrkjN4s9ASLlIXcXgxK-H0GsiEbckQOZ49zsIKyFtasBvZW8339rrXi1js-aBh99M7aS5w9DmXPpUDmppSPpwkeTfKiqF0cQiAUq8tpeEQrGDJuw3Qt2.XI8h9Xw-VZj_NOmKtV19wLM63S4snos7rzkoHf9FXCw' + const request = server.requests[0]; + const tokenWithExpiry = 'eyJhbGciOiJkaXIiLCJlbmMiOiJBMTI4Q0JDLUhTMjU2Iiwia2lkIjoicGFzc3dvcmQxIiwiZXhwIjoxNjQzODMwMzY5fQ..hTbcSQgmmO0HUJJrQ5fRHw.7zjrQXNNVkb-GD0ZhIVhEPcWbyaDBilHTWv-bp1lFZ9mdkSC0QbcAvUbYteiTD7ya23GUwcL2WOW8WgRSHaWHOJe0B5NDqfdUGTzElWfu7fFodRxRgGmwG8Rq5xxteFKLLGHLf1mFYRJKDtjtgajGNUKIDfn9AEt-c5Qz4KU8VolG_KzrLROx-f6Z7MnoPTcwRCj0WjXD6j2D6RAZ80-mKTNIsMIELdj6xiabHcjDJ1WzwtwCZSE2y2nMs451pSYp8W-bFPfZmDDwrkjN4s9ASLlIXcXgxK-H0GsiEbckQOZ49zsIKyFtasBvZW8339rrXi1js-aBh99M7aS5w9DmXPpUDmppSPpwkeTfKiqF0cQiAUq8tpeEQrGDJuw3Qt2.XI8h9Xw-VZj_NOmKtV19wLM63S4snos7rzkoHf9FXCw' responseHeader['Symitri-DAP-Token'] = tokenWithExpiry; request.requestHeaders['Content-Type'].should.equal('application/json'); request.respond(200, responseHeader, JSON.stringify(tokenWithExpiry)); @@ -503,7 +503,7 @@ describe('symitriDapRtdProvider', function() { it('test dapRefreshToken error response', function () { storage.setDataInLocalStorage(DAP_TOKEN, JSON.stringify(sampleCachedToken)); dapUtils.dapRefreshToken(ortb2, sampleConfig, false, onDone) - let request = server.requests[0]; + const request = server.requests[0]; request.requestHeaders['Content-Type'].should.equal('application/json'); request.respond(400, responseHeader, 'error'); expect(JSON.parse(storage.getDataFromLocalStorage(DAP_TOKEN)).expires_at).to.be.equal(cacheExpiry);// Since the expiry is same, the token is not updated in the cache @@ -512,43 +512,43 @@ describe('symitriDapRtdProvider', function() { describe('dapRefreshEncryptedMembership test', function () { it('test dapRefreshEncryptedMembership success response', function () { - let expiry = Math.round(Date.now() / 1000.0) + 3600; // in seconds - let encMembership = 'eyJhbGciOiJkaXIiLCJlbmMiOiJBMTI4Q0JDLUhTMjU2Iiwia2lkIjoic29tZXNlY3JldGludmF1bHQifQ..f8_At4OqeQXyQcSwThOJ_w.69ImVQ3bEZ6QP7ROCRpAJjNcKY49SEPYR6qTp_8l7L8kQdPbpi4wmuOzt78j7iBrX64k2wltzmQFjDmVKSxDhrEguxpgx6t-L1tT8ZA0UosMWpVsgmKEZxOn2e9ES3jw8RNCS4WSWocSPQX33xSb51evXjm9E1s0tGoLnwXl0GsUvzRsSU86wQG6RZnAQTi7s-r-M2TKibdDjUqgIt62vJ-aBZ7RWw91MINgOdmDNs1bFfbBX5Cy1kd4-kjvRDz_aJ6zHX4sK_7EmQhGEY3tW-A3_l2I88mw-RSJaPkb_IWg0QpVwXDaE2F2g8NpY1PzCRvG_NIE8r28eK5q44OMVitykHmKmBXGDj7z2JVgoXkfo5u0I-dypZARn4GP_7niK932avB-9JD7Mz3TrlU4GZ7IpYfJ91PMsRhrs5xNPQwLZbpuhF76A7Dp7iss71UjkGCiPTU6udfRb4foyf_7xEF66m1eQVcVaMdxEbMuu9GBfdr-d04TbtJhPfUV8JfxTenvRYoi13n0j5kH0M5OgaSQD9kQ3Mrd9u-Cms-BGtT0vf-N8AaFZY_wn0Y4rkpv5HEaH7z3iT4RCHINWrXb_D0WtjLTKQi2YmF8zMlzUOewNJGwZRwbRwxc7JoDIKEc5RZkJYevfJXOEEOPGXZ7AGZxOEsJawPqFqd_nOUosCZS4akHhcDPcVowoecVAV0hhhoS6JEY66PhPp1snbt6yqA-fQhch7z8Y-DZT3Scibvffww3Scg_KFANWp0KeEvHG0vyv9R2F4o66viSS8y21MDnM7Yjk8C-j7aNMldUQbjN_7Yq1nkfe0jiBX_hsINBRPgJHUY4zCaXuyXs-JZZfU92nwG0RT3A_3RP2rpY8-fXp9d3C2QJjEpnmHvTMsuAZCQSBe5DVrJwN_UKedxcJEoOt0wLz6MaCMyYZPd8tnQeqYK1cd3RgQDXtzKC0HDw1En489DqJXEst4eSSkaaW1lImLeaF8XCOaIqPqoyGk4_6KVLw5Q7OnpczuXqYKMd9UTMovGeuTuo1k0ddfEqTq9QwxkwZL51AiDRnwTCAeYBU1krV8FCJQx-mH_WPB5ftZj-o_3pbvANeRk27QBVmjcS-tgDllJkWBxX-4axRXzLw8pUUUZUT_NOL0OiqUCWVm0qMBEpgRQ57Se42-hkLMTzLhhGJOnVcaXU1j4ep-N7faNvbgREBjf_LgzvaWS90a2NJ9bB_J9FyXelhCN_AMLfdOS3fHkeWlZ0u0PMbn5DxXRMe0l9jB-2VJZhcPQRlWoYyoCO3l4F5ZmuQP5Xh9CU4tvSWih6jlwMDgdVWuTpdfPD5bx8ccog3JDq87enx-QtPzLU3gMgouNARJGgNwKS_GJSE1uPrt2oiqgZ3Z0u_I5MKvPdQPV3o-4rsaE730eB4OwAOF-mkGWpzy8Pbl-Qe5PR9mHBhuyJgZ-WDSCHl5yvet2kfO9mPXZlqBQ26fzTcUYH94MULAZn36og6w.3iKGv-Le-AvRmi26W1v6ibRLGbwKbCR92vs-a9t55hw'; + const expiry = Math.round(Date.now() / 1000.0) + 3600; // in seconds + const encMembership = 'eyJhbGciOiJkaXIiLCJlbmMiOiJBMTI4Q0JDLUhTMjU2Iiwia2lkIjoic29tZXNlY3JldGludmF1bHQifQ..f8_At4OqeQXyQcSwThOJ_w.69ImVQ3bEZ6QP7ROCRpAJjNcKY49SEPYR6qTp_8l7L8kQdPbpi4wmuOzt78j7iBrX64k2wltzmQFjDmVKSxDhrEguxpgx6t-L1tT8ZA0UosMWpVsgmKEZxOn2e9ES3jw8RNCS4WSWocSPQX33xSb51evXjm9E1s0tGoLnwXl0GsUvzRsSU86wQG6RZnAQTi7s-r-M2TKibdDjUqgIt62vJ-aBZ7RWw91MINgOdmDNs1bFfbBX5Cy1kd4-kjvRDz_aJ6zHX4sK_7EmQhGEY3tW-A3_l2I88mw-RSJaPkb_IWg0QpVwXDaE2F2g8NpY1PzCRvG_NIE8r28eK5q44OMVitykHmKmBXGDj7z2JVgoXkfo5u0I-dypZARn4GP_7niK932avB-9JD7Mz3TrlU4GZ7IpYfJ91PMsRhrs5xNPQwLZbpuhF76A7Dp7iss71UjkGCiPTU6udfRb4foyf_7xEF66m1eQVcVaMdxEbMuu9GBfdr-d04TbtJhPfUV8JfxTenvRYoi13n0j5kH0M5OgaSQD9kQ3Mrd9u-Cms-BGtT0vf-N8AaFZY_wn0Y4rkpv5HEaH7z3iT4RCHINWrXb_D0WtjLTKQi2YmF8zMlzUOewNJGwZRwbRwxc7JoDIKEc5RZkJYevfJXOEEOPGXZ7AGZxOEsJawPqFqd_nOUosCZS4akHhcDPcVowoecVAV0hhhoS6JEY66PhPp1snbt6yqA-fQhch7z8Y-DZT3Scibvffww3Scg_KFANWp0KeEvHG0vyv9R2F4o66viSS8y21MDnM7Yjk8C-j7aNMldUQbjN_7Yq1nkfe0jiBX_hsINBRPgJHUY4zCaXuyXs-JZZfU92nwG0RT3A_3RP2rpY8-fXp9d3C2QJjEpnmHvTMsuAZCQSBe5DVrJwN_UKedxcJEoOt0wLz6MaCMyYZPd8tnQeqYK1cd3RgQDXtzKC0HDw1En489DqJXEst4eSSkaaW1lImLeaF8XCOaIqPqoyGk4_6KVLw5Q7OnpczuXqYKMd9UTMovGeuTuo1k0ddfEqTq9QwxkwZL51AiDRnwTCAeYBU1krV8FCJQx-mH_WPB5ftZj-o_3pbvANeRk27QBVmjcS-tgDllJkWBxX-4axRXzLw8pUUUZUT_NOL0OiqUCWVm0qMBEpgRQ57Se42-hkLMTzLhhGJOnVcaXU1j4ep-N7faNvbgREBjf_LgzvaWS90a2NJ9bB_J9FyXelhCN_AMLfdOS3fHkeWlZ0u0PMbn5DxXRMe0l9jB-2VJZhcPQRlWoYyoCO3l4F5ZmuQP5Xh9CU4tvSWih6jlwMDgdVWuTpdfPD5bx8ccog3JDq87enx-QtPzLU3gMgouNARJGgNwKS_GJSE1uPrt2oiqgZ3Z0u_I5MKvPdQPV3o-4rsaE730eB4OwAOF-mkGWpzy8Pbl-Qe5PR9mHBhuyJgZ-WDSCHl5yvet2kfO9mPXZlqBQ26fzTcUYH94MULAZn36og6w.3iKGv-Le-AvRmi26W1v6ibRLGbwKbCR92vs-a9t55hw'; dapUtils.dapRefreshEncryptedMembership(ortb2, esampleConfig, sampleCachedToken.token, onDone) - let request = server.requests[0]; + const request = server.requests[0]; responseHeader['Symitri-DAP-Token'] = encMembership; request.respond(200, responseHeader, encMembership); - let rtdObj = dapUtils.dapGetEncryptedRtdObj({'encryptedSegments': encMembership}, 710) + const rtdObj = dapUtils.dapGetEncryptedRtdObj({'encryptedSegments': encMembership}, 710) expect(ortb2.user.data).to.deep.include.members(rtdObj.rtd.ortb2.user.data); expect(JSON.parse(storage.getDataFromLocalStorage(DAP_ENCRYPTED_MEMBERSHIP)).expires_at).to.equal(expiry); }); it('test dapRefreshEncryptedMembership success response with exp claim', function () { - let encMembership = 'eyJhbGciOiJkaXIiLCJlbmMiOiJBMTI4Q0JDLUhTMjU2Iiwia2lkIjoic29tZXNlY3JldGludmF1bHQiLCJleHAiOjE2NDM4MzA2NDB9..inYoxwht_aqTIWqGhEm_Gw.wDcCUOCwtqgnNUouaD723gKfm7X7bgkHgtiX4mr07P3tWk25PUQunmwTLhWBB5CYzzGIfIvveG_u4glNRLi_eRSQV4ihKKk1AN-BSSJ3d0CLAdY9I1WG5vX1VmopXyKnV90bl9SLNqnhg4Vxe6YU4ogTYxsKHuIN1EeIH4hpl-HbCQWQ1DQt4mB-MQF8V9AWTfU0D7sFMSK8f9qj6NGmf1__oHdHUlws0t5V2UAn_dhJexsuREK_gh65pczCuly5eEcziZ82LeP-nOhKWSRHB_tS_mKXrRU6_At_EVDgtfA3PSBJ6eQylCii6bTL42vZzz4jZhJv_3eLfRdKqpVT5CWNBzcDoQ2VcQgKgIBtPJ45KFfAYTQ6kdl21QMSjqtu8GTsv1lEZtrqHY6zRiG8_Mu28-PmjEw4LDdZmBDOeroue_MJD6wuE_jlE7J2iVdo8CkVnoRgzFwNbKBo7CK4z0WahV9rhuOm0LKAN5H0jF_gj696U-3fVTDTIb8ndNKNI2_xAhvWs00BFGtUtWgr8QGDGRTDCNGsDgnb_Vva9xCqVOyAE9O3Fq1QYl-tMA-KkBt3zzvmFFpOxpOyH-lUubKLKlsrxKc3GSyVEQ9DDLhrXXJgR5H5BSE4tjlK7p3ODF5qz0FHtIj7oDcgLazFO7z2MuFy2LjJmd3hKl6ujcfYEDiQ4D3pMIo7oiU33aFBD1YpzI4-WzNfJlUt1FoK0-DAXpbbV95s8p08GOD4q81rPw5hRADKJEr0QzrbDwplTWCzT2fKXMg_dIIc5AGqGKnVRUS6UyF1DnHpudNIJWxyWZjWIEw_QNjU0cDFmyPSyKxNrnfq9w8WE2bfbS5KTicxei5QHnC-cnL7Nh7IXp7WOW6R1YHbNPT7Ad4OhnlV-jjrXwkSv4wMAbfwAWoSCchGh7uvENNAeJymuponlJbOgw_GcYM73hMs8Z8W9qxRfbyF4WX5fDKXg61mMlaieHkc0EnoC5q7uKyXuZUehHZ76JLDFmewslLkQq5SkVCttzJePBnY1ouPEHw5ZTzUnG5f01QQOVcjIN-AqXNDbG5IOwq0heyS6vVfq7lZKJdLDVQ21qRjazGPaqYwLzugkWkzCOzPTgyFdbXzgjfmJwylHSOM5Jpnul84GzxEQF-1mHP2A8wtIT-M7_iX24It2wwWvc8qLA6GEqruWCtNyoug8CXo44mKdSSCGeEZHtfMbzXdLIBHCy2jSHz5i8S7DU_R7rE_5Ssrb81CqIYbgsAQBHtOYoyvzduTOruWcci4De0QcULloqImIEHUuIe2lnYO889_LIx5p7nE3UlSvLBo0sPexavFUtHqI6jdG6ye9tdseUEoNBDXW0aWD4D-KXX1JLtAgToPVUtEaXCJI7QavwO9ZG6UZM6jbfuJ5co0fvUXp6qYrFxPQo2dYHkar0nT6s1Zg5l2g8yWlLUJrHdHAzAw_NScUp71OpM4TmNsLnYaPVPcOxMvtJXTanbNWr0VKc8gy9q3k_1XxAnQwiduNs7f5bA-6qCVpayHv5dE7mUhFEwyh1_w95jEaURsQF_hnnd2OqRkADfiok4ZiPU2b38kFW1LXjpI39XXES3JU0e08Rq2uuelyLbCLWuJWq_axuKSZbZvpYeqWtIAde8FjCiO7RPlEc0nyzWBst8RBxQ-Bekg9UXPhxBRcm0HwA.Q2cBSFOQAC-QKDwmjrQXnVQd3jNOppMl9oZfd2yuKeY'; + const encMembership = 'eyJhbGciOiJkaXIiLCJlbmMiOiJBMTI4Q0JDLUhTMjU2Iiwia2lkIjoic29tZXNlY3JldGludmF1bHQiLCJleHAiOjE2NDM4MzA2NDB9..inYoxwht_aqTIWqGhEm_Gw.wDcCUOCwtqgnNUouaD723gKfm7X7bgkHgtiX4mr07P3tWk25PUQunmwTLhWBB5CYzzGIfIvveG_u4glNRLi_eRSQV4ihKKk1AN-BSSJ3d0CLAdY9I1WG5vX1VmopXyKnV90bl9SLNqnhg4Vxe6YU4ogTYxsKHuIN1EeIH4hpl-HbCQWQ1DQt4mB-MQF8V9AWTfU0D7sFMSK8f9qj6NGmf1__oHdHUlws0t5V2UAn_dhJexsuREK_gh65pczCuly5eEcziZ82LeP-nOhKWSRHB_tS_mKXrRU6_At_EVDgtfA3PSBJ6eQylCii6bTL42vZzz4jZhJv_3eLfRdKqpVT5CWNBzcDoQ2VcQgKgIBtPJ45KFfAYTQ6kdl21QMSjqtu8GTsv1lEZtrqHY6zRiG8_Mu28-PmjEw4LDdZmBDOeroue_MJD6wuE_jlE7J2iVdo8CkVnoRgzFwNbKBo7CK4z0WahV9rhuOm0LKAN5H0jF_gj696U-3fVTDTIb8ndNKNI2_xAhvWs00BFGtUtWgr8QGDGRTDCNGsDgnb_Vva9xCqVOyAE9O3Fq1QYl-tMA-KkBt3zzvmFFpOxpOyH-lUubKLKlsrxKc3GSyVEQ9DDLhrXXJgR5H5BSE4tjlK7p3ODF5qz0FHtIj7oDcgLazFO7z2MuFy2LjJmd3hKl6ujcfYEDiQ4D3pMIo7oiU33aFBD1YpzI4-WzNfJlUt1FoK0-DAXpbbV95s8p08GOD4q81rPw5hRADKJEr0QzrbDwplTWCzT2fKXMg_dIIc5AGqGKnVRUS6UyF1DnHpudNIJWxyWZjWIEw_QNjU0cDFmyPSyKxNrnfq9w8WE2bfbS5KTicxei5QHnC-cnL7Nh7IXp7WOW6R1YHbNPT7Ad4OhnlV-jjrXwkSv4wMAbfwAWoSCchGh7uvENNAeJymuponlJbOgw_GcYM73hMs8Z8W9qxRfbyF4WX5fDKXg61mMlaieHkc0EnoC5q7uKyXuZUehHZ76JLDFmewslLkQq5SkVCttzJePBnY1ouPEHw5ZTzUnG5f01QQOVcjIN-AqXNDbG5IOwq0heyS6vVfq7lZKJdLDVQ21qRjazGPaqYwLzugkWkzCOzPTgyFdbXzgjfmJwylHSOM5Jpnul84GzxEQF-1mHP2A8wtIT-M7_iX24It2wwWvc8qLA6GEqruWCtNyoug8CXo44mKdSSCGeEZHtfMbzXdLIBHCy2jSHz5i8S7DU_R7rE_5Ssrb81CqIYbgsAQBHtOYoyvzduTOruWcci4De0QcULloqImIEHUuIe2lnYO889_LIx5p7nE3UlSvLBo0sPexavFUtHqI6jdG6ye9tdseUEoNBDXW0aWD4D-KXX1JLtAgToPVUtEaXCJI7QavwO9ZG6UZM6jbfuJ5co0fvUXp6qYrFxPQo2dYHkar0nT6s1Zg5l2g8yWlLUJrHdHAzAw_NScUp71OpM4TmNsLnYaPVPcOxMvtJXTanbNWr0VKc8gy9q3k_1XxAnQwiduNs7f5bA-6qCVpayHv5dE7mUhFEwyh1_w95jEaURsQF_hnnd2OqRkADfiok4ZiPU2b38kFW1LXjpI39XXES3JU0e08Rq2uuelyLbCLWuJWq_axuKSZbZvpYeqWtIAde8FjCiO7RPlEc0nyzWBst8RBxQ-Bekg9UXPhxBRcm0HwA.Q2cBSFOQAC-QKDwmjrQXnVQd3jNOppMl9oZfd2yuKeY'; dapUtils.dapRefreshEncryptedMembership(ortb2, esampleConfig, sampleCachedToken.token, onDone) - let request = server.requests[0]; + const request = server.requests[0]; responseHeader['Symitri-DAP-Token'] = encMembership; request.respond(200, responseHeader, encMembership); - let rtdObj = dapUtils.dapGetEncryptedRtdObj({'encryptedSegments': encMembership}, 710) + const rtdObj = dapUtils.dapGetEncryptedRtdObj({'encryptedSegments': encMembership}, 710) expect(ortb2.user.data).to.deep.include.members(rtdObj.rtd.ortb2.user.data); expect(JSON.parse(storage.getDataFromLocalStorage(DAP_ENCRYPTED_MEMBERSHIP)).expires_at).to.equal(1643830630); }); it('test dapRefreshEncryptedMembership error response', function () { dapUtils.dapRefreshEncryptedMembership(ortb2, esampleConfig, sampleCachedToken.token, onDone) - let request = server.requests[0]; + const request = server.requests[0]; request.respond(400, responseHeader, 'error'); expect(ortb2).to.eql({}); }); it('test dapRefreshEncryptedMembership 403 error response', function () { dapUtils.dapRefreshEncryptedMembership(ortb2, esampleConfig, sampleCachedToken.token, onDone) - let request = server.requests[0]; + const request = server.requests[0]; request.respond(403, responseHeader, 'error'); - let requestTokenize = server.requests[1]; + const requestTokenize = server.requests[1]; responseHeader['Symitri-DAP-Token'] = sampleCachedToken.token; requestTokenize.respond(200, responseHeader, ''); - let requestMembership = server.requests[2]; + const requestMembership = server.requests[2]; requestMembership.respond(403, responseHeader, 'error'); expect(server.requests.length).to.be.equal(DAP_MAX_RETRY_TOKENIZE + 2); }); @@ -556,34 +556,34 @@ describe('symitriDapRtdProvider', function() { describe('dapRefreshMembership test', function () { it('test dapRefreshMembership success response', function () { - let membership = {'cohorts': ['9', '11', '13'], 'said': 'eyJhbGciOiJkaXIiLCJlbmMiOiJBMTI4Q0JDLUhTMjU2Iiwia2lkIjoicGFzc3dvcmQxIn0..17wnrhz6FbWx0Cf6LXpm1A.m9PKVCradk3CZokNKzVHzE06TOqiXYeijgxTQUiQy5Syx-yicnO8DyYX6zQ6rgPcNgUNRt4R4XE5MXuK0laUVQJr9yc9g3vUfQfw69OMYGW_vRlLMPzoNOhF2c4gSyfkRrLr7C0qgALmZO1D11sPflaCTNmO7pmZtRaCOB5buHoWcQhp1bUSJ09DNDb31dX3llimPwjNGSrUhyq_EZl4HopnnjxbM4qVNMY2G_43C_idlVOvbFoTxcDRATd-6MplJoIOIHQLDZEetpIOVcbEYN9gQ_ndBISITwuu5YEgs5C_WPHA25nm6e4BT5R-tawSA8yPyQAupqE8gk4ZWq_2-T0cqyTstIHrMQnZ_vysYN7h6bkzE-KeZRk7GMtySN87_fiu904hLD9QentGegamX6UAbVqQh7Htj7SnMHXkEenjxXAM5mRqQvNCTlw8k-9-VPXs-vTcKLYP8VFf8gMOmuYykgWac1gX-svyAg-24mo8cUbqcsj9relx4Qj5HiXUVyDMBZxK-mHZi-Xz6uv9GlggcsjE13DSszar-j2OetigpdibnJIxRZ-4ew3-vlvZ0Dul3j0LjeWURVBWYWfMjuZ193G7lwR3ohh_NzlNfwOPBK_SYurdAnLh7jJgTW-lVLjH2Dipmi9JwX9s03IQq9opexAn7hlM9oBI6x5asByH8JF8WwZ5GhzDjpDwpSmHPQNGFRSyrx_Sh2CPWNK6C1NJmLkyqAtJ5iw0_al7vPDQyZrKXaLTjBCUnbpJhUZ8dUKtWLzGPjzFXp10muoDIutd1NfyKxk1aWGhx5aerYuLdywv6cT_M8RZTi8924NGj5VA30V5OvEwLLyX93eDhntXZSCbkPHpAfiRZNGXrPY.GhCbWGQz11mIRD4uPKmoAuFXDH7hGnils54zg7N7-TU'} + const membership = {'cohorts': ['9', '11', '13'], 'said': 'eyJhbGciOiJkaXIiLCJlbmMiOiJBMTI4Q0JDLUhTMjU2Iiwia2lkIjoicGFzc3dvcmQxIn0..17wnrhz6FbWx0Cf6LXpm1A.m9PKVCradk3CZokNKzVHzE06TOqiXYeijgxTQUiQy5Syx-yicnO8DyYX6zQ6rgPcNgUNRt4R4XE5MXuK0laUVQJr9yc9g3vUfQfw69OMYGW_vRlLMPzoNOhF2c4gSyfkRrLr7C0qgALmZO1D11sPflaCTNmO7pmZtRaCOB5buHoWcQhp1bUSJ09DNDb31dX3llimPwjNGSrUhyq_EZl4HopnnjxbM4qVNMY2G_43C_idlVOvbFoTxcDRATd-6MplJoIOIHQLDZEetpIOVcbEYN9gQ_ndBISITwuu5YEgs5C_WPHA25nm6e4BT5R-tawSA8yPyQAupqE8gk4ZWq_2-T0cqyTstIHrMQnZ_vysYN7h6bkzE-KeZRk7GMtySN87_fiu904hLD9QentGegamX6UAbVqQh7Htj7SnMHXkEenjxXAM5mRqQvNCTlw8k-9-VPXs-vTcKLYP8VFf8gMOmuYykgWac1gX-svyAg-24mo8cUbqcsj9relx4Qj5HiXUVyDMBZxK-mHZi-Xz6uv9GlggcsjE13DSszar-j2OetigpdibnJIxRZ-4ew3-vlvZ0Dul3j0LjeWURVBWYWfMjuZ193G7lwR3ohh_NzlNfwOPBK_SYurdAnLh7jJgTW-lVLjH2Dipmi9JwX9s03IQq9opexAn7hlM9oBI6x5asByH8JF8WwZ5GhzDjpDwpSmHPQNGFRSyrx_Sh2CPWNK6C1NJmLkyqAtJ5iw0_al7vPDQyZrKXaLTjBCUnbpJhUZ8dUKtWLzGPjzFXp10muoDIutd1NfyKxk1aWGhx5aerYuLdywv6cT_M8RZTi8924NGj5VA30V5OvEwLLyX93eDhntXZSCbkPHpAfiRZNGXrPY.GhCbWGQz11mIRD4uPKmoAuFXDH7hGnils54zg7N7-TU'} dapUtils.dapRefreshMembership(ortb2, sampleConfig, sampleCachedToken.token, onDone); - let request = server.requests[0]; + const request = server.requests[0]; request.respond(200, responseHeader, JSON.stringify(membership)); - let rtdObj = dapUtils.dapGetRtdObj(membership, 708); + const rtdObj = dapUtils.dapGetRtdObj(membership, 708); expect(ortb2.user.data).to.deep.include.members(rtdObj.rtd.ortb2.user.data); }); it('test dapRefreshMembership success response with exp claim', function () { - let membership = {'cohorts': ['9', '11', '13'], 'said': 'eyJhbGciOiJkaXIiLCJlbmMiOiJBMTI4Q0JDLUhTMjU2Iiwia2lkIjoicGFzc3dvcmQxIiwiZXhwIjoxNjQ3OTcxNTU4fQ..ptdM5WO-62ypXlKxFXD4FQ.waEo9MHS2NYQCi-zh_p6HgT9BdqGyQbBq4GfGLfsay4nRBgICsTS-VkV6e7xx5U1T8BgpKkRJIZBwTOY5Pkxk9FpK5nnffDSEljRrp1LXLCkNP4qwrlqHInFbZsonNWW4_mW-7aUPlTwIsTbfjTuyHdXHeQa1ALrwFFFWE7QUmPNd2RsHjDwUsxlJPEb5TnHn5W0Mgo_PQZaxvhJInMbxPgtJLoqnJvOqCBEoQY7au7ALZL_nWK8XIwPMF19J7Z3cBg9vQInhr_E3rMdQcAFHEzYfgoNcIYCCR0t1UOqUE3HNtX-E64kZAYKWdlsBb9eW5Gj9hHYyPNL_4Hntjg5eLXGpsocMg0An-qQKGC6hkrxKzeM-GrjpvSaQLNs4iqDpHUtzA02LW_vkLkMNRUiyXVJ3FUZwfyq6uHSRKWZ6UFdAfL0rfJ8q8x8Ll-qJO2Jfyvidlsi9FIs7x1WJrvDCKepfAQM1UXRTonrQljFBAk83PcL2bmWuJDgJZ0lWS4VnZbIf6A7fDourmkDxdVRptvQq5nSjtzCA6whRw0-wGz8ehNJsaJw9H_nG9k4lRKs7A5Lqsyy7TVFrAPjnA_Q1a2H6xF2ULxrtIqoNqdX7k9RjowEZSQlZgZUOAmI4wzjckdcSyC_pUlYBMcBwmlld34mmOJe9EBHAxjdci7Q_9lvj1HTcwGDcQITXnkW9Ux5Jkt9Naw-IGGrnEIADaT2guUAto8W_Gb05TmwHSd6DCmh4zepQCbqeVe6AvPILtVkTgsTTo27Q-NvS7h-XtthJy8425j5kqwxxpZFJ0l0ytc6DUyNCLJXuxi0JFU6-LoSXcROEMVrHa_Achufr9vHIELwacSAIHuwseEvg_OOu1c1WYEwZH8ynBLSjqzy8AnDj24hYgA0YanPAvDqacrYrTUFqURbHmvcQqLBTcYa_gs7uDx4a1EjtP_NvHRlvCgGAaASrjGMhTX8oJxlTqahhQ.pXm-7KqnNK8sbyyczwkVYhcjgiwkpO8LjBBVw4lcyZE'}; + const membership = {'cohorts': ['9', '11', '13'], 'said': 'eyJhbGciOiJkaXIiLCJlbmMiOiJBMTI4Q0JDLUhTMjU2Iiwia2lkIjoicGFzc3dvcmQxIiwiZXhwIjoxNjQ3OTcxNTU4fQ..ptdM5WO-62ypXlKxFXD4FQ.waEo9MHS2NYQCi-zh_p6HgT9BdqGyQbBq4GfGLfsay4nRBgICsTS-VkV6e7xx5U1T8BgpKkRJIZBwTOY5Pkxk9FpK5nnffDSEljRrp1LXLCkNP4qwrlqHInFbZsonNWW4_mW-7aUPlTwIsTbfjTuyHdXHeQa1ALrwFFFWE7QUmPNd2RsHjDwUsxlJPEb5TnHn5W0Mgo_PQZaxvhJInMbxPgtJLoqnJvOqCBEoQY7au7ALZL_nWK8XIwPMF19J7Z3cBg9vQInhr_E3rMdQcAFHEzYfgoNcIYCCR0t1UOqUE3HNtX-E64kZAYKWdlsBb9eW5Gj9hHYyPNL_4Hntjg5eLXGpsocMg0An-qQKGC6hkrxKzeM-GrjpvSaQLNs4iqDpHUtzA02LW_vkLkMNRUiyXVJ3FUZwfyq6uHSRKWZ6UFdAfL0rfJ8q8x8Ll-qJO2Jfyvidlsi9FIs7x1WJrvDCKepfAQM1UXRTonrQljFBAk83PcL2bmWuJDgJZ0lWS4VnZbIf6A7fDourmkDxdVRptvQq5nSjtzCA6whRw0-wGz8ehNJsaJw9H_nG9k4lRKs7A5Lqsyy7TVFrAPjnA_Q1a2H6xF2ULxrtIqoNqdX7k9RjowEZSQlZgZUOAmI4wzjckdcSyC_pUlYBMcBwmlld34mmOJe9EBHAxjdci7Q_9lvj1HTcwGDcQITXnkW9Ux5Jkt9Naw-IGGrnEIADaT2guUAto8W_Gb05TmwHSd6DCmh4zepQCbqeVe6AvPILtVkTgsTTo27Q-NvS7h-XtthJy8425j5kqwxxpZFJ0l0ytc6DUyNCLJXuxi0JFU6-LoSXcROEMVrHa_Achufr9vHIELwacSAIHuwseEvg_OOu1c1WYEwZH8ynBLSjqzy8AnDj24hYgA0YanPAvDqacrYrTUFqURbHmvcQqLBTcYa_gs7uDx4a1EjtP_NvHRlvCgGAaASrjGMhTX8oJxlTqahhQ.pXm-7KqnNK8sbyyczwkVYhcjgiwkpO8LjBBVw4lcyZE'}; dapUtils.dapRefreshMembership(ortb2, sampleConfig, sampleCachedToken.token, onDone); - let request = server.requests[0]; + const request = server.requests[0]; request.respond(200, responseHeader, JSON.stringify(membership)); - let rtdObj = dapUtils.dapGetRtdObj(membership, 708) + const rtdObj = dapUtils.dapGetRtdObj(membership, 708) expect(ortb2.user.data).to.deep.include.members(rtdObj.rtd.ortb2.user.data); expect(JSON.parse(storage.getDataFromLocalStorage(DAP_MEMBERSHIP)).expires_at).to.be.equal(1647971548); }); it('test dapRefreshMembership 400 error response', function () { dapUtils.dapRefreshMembership(ortb2, sampleConfig, sampleCachedToken.token, onDone) - let request = server.requests[0]; + const request = server.requests[0]; request.respond(400, responseHeader, 'error'); expect(ortb2).to.eql({}); }); it('test dapRefreshMembership 403 error response', function () { dapUtils.dapRefreshMembership(ortb2, sampleConfig, sampleCachedToken.token, onDone) - let request = server.requests[0]; + const request = server.requests[0]; request.respond(403, responseHeader, 'error'); expect(server.requests.length).to.be.equal(DAP_MAX_RETRY_TOKENIZE); }); @@ -596,8 +596,8 @@ describe('symitriDapRtdProvider', function() { }); it('test dapGetEncryptedMembershipFromLocalStorage function with invalid cache', function () { - let expiry = Math.round(Date.now() / 1000.0) - 100; // in seconds - let encMembership = {'expiry': expiry, 'encryptedSegments': cachedEncryptedMembership.encryptedSegments} + const expiry = Math.round(Date.now() / 1000.0) - 100; // in seconds + const encMembership = {'expiry': expiry, 'encryptedSegments': cachedEncryptedMembership.encryptedSegments} storage.setDataInLocalStorage(DAP_ENCRYPTED_MEMBERSHIP, JSON.stringify(encMembership)) expect(dapUtils.dapGetEncryptedMembershipFromLocalStorage()).to.equal(null); }); @@ -605,11 +605,11 @@ describe('symitriDapRtdProvider', function() { describe('Symitri-DAP-SS-ID test', function () { it('Symitri-DAP-SS-ID present in response header', function () { - let expiry = Math.round(Date.now() / 1000.0) + 300; // in seconds + const expiry = Math.round(Date.now() / 1000.0) + 300; // in seconds dapUtils.dapRefreshToken(ortb2, sampleConfig, false, onDone) - let request = server.requests[0]; + const request = server.requests[0]; request.requestHeaders['Content-Type'].should.equal('application/json'); - let sampleSSID = 'Test_SSID_Spec'; + const sampleSSID = 'Test_SSID_Spec'; responseHeader['Symitri-DAP-Token'] = sampleCachedToken.token; responseHeader['Symitri-DAP-SS-ID'] = sampleSSID; request.respond(200, responseHeader, ''); @@ -617,12 +617,12 @@ describe('symitriDapRtdProvider', function() { }); it('Test if Symitri-DAP-SS-ID is present in request header', function () { - let expiry = Math.round(Date.now() / 1000.0) + 100; // in seconds + const expiry = Math.round(Date.now() / 1000.0) + 100; // in seconds storage.setDataInLocalStorage(DAP_SS_ID, JSON.stringify('Test_SSID_Spec')) dapUtils.dapRefreshToken(ortb2, sampleConfig, false, onDone) - let request = server.requests[0]; + const request = server.requests[0]; request.requestHeaders['Content-Type'].should.equal('application/json'); - let ssidHeader = request.requestHeaders['Symitri-DAP-SS-ID']; + const ssidHeader = request.requestHeaders['Symitri-DAP-SS-ID']; responseHeader['Symitri-DAP-Token'] = sampleCachedToken.token; request.respond(200, responseHeader, ''); expect(ssidHeader).to.be.equal('Test_SSID_Spec'); @@ -665,15 +665,15 @@ describe('symitriDapRtdProvider', function() { it('passed identifier is handled', async function () { const test_identity = 'test_identity_1234'; - let identity = { + const identity = { value: test_identity }; - let apiParams = { + const apiParams = { 'type': identity.type, }; if (window.crypto && window.crypto.subtle) { - let hid = await dapUtils.addIdentifier(identity, apiParams).then(); + const hid = await dapUtils.addIdentifier(identity, apiParams).then(); expect(hid['identity']).is.equal('843BE0FB20AAE699F27E5BC88C554B716F3DD366F58C1BDE0ACFB7EA0DD90CE7'); } else { expect(window.crypto.subtle).is.undefined @@ -682,22 +682,22 @@ describe('symitriDapRtdProvider', function() { it('passed undefined identifier is handled', async function () { const test_identity = undefined; - let identity = { + const identity = { identity: test_identity } - let apiParams = { + const apiParams = { 'type': identity.type, }; - let hid = await dapUtils.addIdentifier(identity, apiParams); + const hid = await dapUtils.addIdentifier(identity, apiParams); expect(hid.identity).is.undefined; }); }); describe('onBidResponseEvent', function () { const bidResponse = {adId: 'ad_123', bidder: 'test_bidder', bidderCode: 'test_bidder_code', cpm: '1.5', creativeId: 'creative_123', dealId: 'DEMODEAL555', mediaType: 'banner', responseTimestamp: '1725892736147', ad: ''}; - let url = emoduleConfig.params.pixelUrl + '?token=' + sampleCachedToken.token + '&ad_id=' + bidResponse.adId + '&bidder=' + bidResponse.bidder + '&bidder_code=' + bidResponse.bidderCode + '&cpm=' + bidResponse.cpm + '&creative_id=' + bidResponse.creativeId + '&deal_id=' + bidResponse.dealId + '&media_type=' + bidResponse.mediaType + '&response_timestamp=' + bidResponse.responseTimestamp; - let adPixel = `${bidResponse.ad}