Skip to content

08-defensive.md: use correct dash character#478

Merged
annefou merged 2 commits into
swcarpentry:gh-pagesfrom
cleary3:patch-4
Apr 8, 2018
Merged

08-defensive.md: use correct dash character#478
annefou merged 2 commits into
swcarpentry:gh-pagesfrom
cleary3:patch-4

Conversation

@cleary3

@cleary3 cleary3 commented Feb 21, 2018

Copy link
Copy Markdown
Contributor

Use an en dash (–) instead of a figure dash (-) when specifying a numeric range.

Please delete the text below before submitting your contribution.

Use an en dash (–) instead of a figure dash (-) when specifying a numeric range.
@rgaiacs

rgaiacs commented Feb 22, 2018

Copy link
Copy Markdown
Contributor

Hi @cleary3, can you send a pull request to https://github.com/swcarpentry/lesson-example with a change to http://swcarpentry.github.io/lesson-example/06-style-guide/index.html, you need to edit https://github.com/swcarpentry/lesson-example/blob/gh-pages/_episodes/06-style-guide.md, that add the use of figure dash, en dash and em dash? Many people aren't familiar with the different use cases and neither on how they can insert those characters. Thanks in advance.

@cleary3

cleary3 commented Feb 26, 2018

Copy link
Copy Markdown
Contributor Author

OK, I think I've done it:
carpentries/lesson-example#181

@maxim-belkin

Copy link
Copy Markdown
Contributor

How about 10-20% on the line above?

@cleary3

cleary3 commented Mar 28, 2018

Copy link
Copy Markdown
Contributor Author

Yep, that's in pull request #480

@maxim-belkin

Copy link
Copy Markdown
Contributor

I have mixed feelings about this and the other PR... Shouldn't we use — or — for '—' and – or – for '–'?

@cleary3

cleary3 commented Apr 4, 2018

Copy link
Copy Markdown
Contributor Author

That's fine with me. However, my pull request sparked a larger conversation about whether it's even worthwhile to use em- and en-dashes in the Software Carpentry lessons. (The fear being that they'd be applied inconsistently and be distracting to the learners going through the lessons.)

@maxim-belkin

Copy link
Copy Markdown
Contributor

I'm all for using them em- and en-dashes. I just question what is the right way of doing that in Markdown.

@maxim-belkin maxim-belkin changed the title Update 08-defensive.md — use correct dash character 08-defensive.md: use correct dash character Apr 4, 2018
@cleary3

cleary3 commented Apr 4, 2018

Copy link
Copy Markdown
Contributor Author

Well, I'd vote for readability and go with — and –.

@annefou annefou merged commit 904307b into swcarpentry:gh-pages Apr 8, 2018
@annefou

annefou commented Apr 8, 2018

Copy link
Copy Markdown

I close this PR. We may change it again once a conclusion about the usage of dash (beyond this PR) is reached.

@maxim-belkin maxim-belkin assigned annefou and unassigned maxim-belkin Apr 8, 2018
@maxim-belkin

Copy link
Copy Markdown
Contributor

@annefou you merged it, you didn't close it :) that's fine though

fmichonneau pushed a commit to fmichonneau/python-novice-inflammation that referenced this pull request Oct 13, 2020
zkamvar pushed a commit that referenced this pull request Apr 21, 2023
Use an en dash (–) instead of a figure dash (-) when specifying a numeric range.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants