-
Notifications
You must be signed in to change notification settings - Fork 25
phpDocumentor Guides integration #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
wouterj
wants to merge
35
commits into
symfony-tools:main
Choose a base branch
from
wouterj:phpdocumentor-guides
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
8e290fe
Convert docs builder into an extension
wouterj 21ef959
Cleanup
wouterj 78614b5
Update to latest Guides
wouterj b4d3554
Upgrade to latest guides and use guides-code's highlighter
wouterj f1974c7
Fix SymfonyExtension build
wouterj cbc1362
Set-up Psalm CI
wouterj 2f8a2c7
Set-up PHP CS Fixer CI
wouterj 908a935
Use guides-code from Packagist
wouterj a051171
Upgrade to Sphinx RTD Theme 2.0.0
wouterj fb8c2e8
Unskip fixed test cases
wouterj d0251f1
Upgrade Guides and split RTD theme
wouterj 2c41ce3
Do not use anchors for document links in toctree
wouterj 74ff68b
Enable toctree project test
wouterj 91c3ded
Fix CI
wouterj 262f58f
Fix CS
wouterj 016b7fc
Upgrade to Guides 1.0
wouterj d4b9c30
Made last skipped test green
wouterj d8b8547
Upgrade to latest Guides
wouterj e2a9ed5
Upgrade other dependencies
wouterj 388cc64
Apply recent changes to DocsBuilder in new code
wouterj 5cfd812
Move GuidesExtension code into a subdirectory
wouterj 516d502
Merge integration tests
wouterj aebc39f
Replace version placeholder with Symfony version in URLs
wouterj 1682f32
Use newer PHPUnit version in GitHub Workflow
wouterj b6730bd
Fix php class role with namespaced FQCN
wouterj 5096197
Skip non-html integration tests
wouterj fedc9d7
Update caution icon
wouterj 1bf4f75
Fix highlightphp tests
wouterj 060aa2a
Add fjson renderer
wouterj a89dc29
Upgrade to Symfony 8
wouterj b10f781
Add support for tabs directive
wouterj ccb5737
Require PHPUnit directly
wouterj cfbc874
Upgrade Guides to fix the `testBlocks@nodes/title.rst` test
wouterj dcc64af
Update JsonRenderer tests based on real integration
wouterj 3f57237
Use relative references
wouterj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,11 @@ | ||
| !tools/*/composer.lock | ||
| /vendor/ | ||
| /tests/_output | ||
| /tests/_cache | ||
| /var/ | ||
| /docs.phar | ||
| /.env | ||
| /.php-cs-fixer.cache | ||
| /.phpunit.result.cache | ||
| /.phpunit.cache | ||
| /composer.lock |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| <?php | ||
|
|
||
| $fileHeaderComment = <<<EOT | ||
| This file is part of the Guides SymfonyExtension package. | ||
|
|
||
| (c) Wouter de Jong | ||
|
|
||
| For the full copyright and license information, please view the LICENSE | ||
| file that was distributed with this source code. | ||
| EOT; | ||
|
|
||
| return (new PhpCsFixer\Config()) | ||
| ->setRules([ | ||
| '@PHP71Migration' => true, | ||
| '@PHPUnit75Migration:risky' => true, | ||
| '@Symfony' => true, | ||
| '@Symfony:risky' => true, | ||
| 'protected_to_private' => false, | ||
| 'native_constant_invocation' => ['strict' => false], | ||
| 'no_superfluous_phpdoc_tags' => [ | ||
| 'remove_inheritdoc' => true, | ||
| 'allow_unused_params' => true, // for future-ready params, to be replaced with https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/7377 | ||
| ], | ||
| 'header_comment' => ['header' => $fileHeaderComment], | ||
| 'modernize_strpos' => true, | ||
| 'get_class_to_class_keyword' => true, | ||
| 'nullable_type_declaration' => true, | ||
| ]) | ||
| ->setRiskyAllowed(true) | ||
| ->setFinder( | ||
| (new PhpCsFixer\Finder()) | ||
| ->in(__DIR__.'/src') | ||
| ) | ||
| ; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/12.4/phpunit.xsd" | ||
| bootstrap="vendor/autoload.php" | ||
| beStrictAboutOutputDuringTests="true" | ||
| failOnDeprecation="true" | ||
| failOnRisky="true" | ||
| failOnWarning="true" | ||
| cacheDirectory=".phpunit.cache" | ||
| beStrictAboutCoverageMetadata="true"> | ||
| <testsuites> | ||
| <testsuite name="default"> | ||
| <directory>tests</directory> | ||
| </testsuite> | ||
| </testsuites> | ||
|
|
||
| <source ignoreSuppressionOfDeprecations="true" | ||
| ignoreIndirectDeprecations="true" | ||
| restrictNotices="true" | ||
| restrictWarnings="true"> | ||
| <include> | ||
| <directory>src</directory> | ||
| </include> | ||
|
|
||
| <deprecationTrigger> | ||
| <function>trigger_deprecation</function> | ||
| <method>Doctrine\Deprecations\Deprecation::trigger</method> | ||
| <method>Doctrine\Deprecations\Deprecation::delegateTriggerToBackend</method> | ||
| </deprecationTrigger> | ||
| </source> | ||
| </phpunit> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| <?xml version="1.0"?> | ||
| <psalm | ||
| errorLevel="2" | ||
| resolveFromConfigFile="true" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xmlns="https://getpsalm.org/schema/config" | ||
| xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd" | ||
| findUnusedCode="false" | ||
| findUnusedBaselineEntry="true" | ||
| > | ||
| <projectFiles> | ||
| <directory name="src" /> | ||
| <directory name="config" /> | ||
| <ignoreFiles> | ||
| <directory name="vendor" /> | ||
| </ignoreFiles> | ||
| </projectFiles> | ||
|
|
||
| <issueHandlers> | ||
| <ImplicitToStringCast errorLevel="suppress" /> | ||
| </issueHandlers> | ||
| </psalm> |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this
SymfonyDocsBuildernamespace still used ?