[Store][SurrealDB] Introduce StoreFactory#2094
Open
Guikingone wants to merge 1 commit into
Open
Conversation
Guikingone
force-pushed
the
feature/store-factory-surrealdb
branch
3 times, most recently
from
07c0616 to
43bbf33
Compare
carsonbot
added
Bug
Guikingone
force-pushed
the
feature/store-factory-surrealdb
branch
2 times, most recently
from
c0bd6a5 to
57183a8
Compare
Contributor
|
0.9 -> 0.10 |
The `Store` constructor now expects a pre-scoped `HttpClientInterface`; the endpoint scoping is performed by `StoreFactory::create()` via `ScopingHttpClient::forBaseUri()`. Username/password remain in `Store` for the lazy signin flow. The `AiBundle` wiring switches to the factory and exposes the `http_client` configuration node.
Guikingone
force-pushed
the
feature/store-factory-surrealdb
branch
from
57183a8 to
0a673d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StoreFactoryfor SurrealDB10