From dfedb172db02b0ad4f768b828880a228c5a516a2 Mon Sep 17 00:00:00 2001 From: darshan-uber <57134799+darshan-uber@users.noreply.github.com> Date: Mon, 24 Feb 2025 12:01:59 -0800 Subject: [PATCH 1/3] fix: check for target presence in event handlers * Noticed intermittent (<1%) uncaught errors from the usage of component in a application. * I wasn't able to root cause the flow when this was happening. So adding a check in the utility to prevent component crashes in such instances Test Plan * Unit tests * Sanity tested locally in ladle --- src/utils.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/utils.ts b/src/utils.ts index 89046f7..5a0d118 100644 --- a/src/utils.ts +++ b/src/utils.ts @@ -120,6 +120,8 @@ export function checkIfInteractive(target: Element, rootElement: Element) { "switch", "tab", ]; + if (!target || !rootElement) return false; + while (target !== rootElement) { if (target.getAttribute("data-movable-handle")) { return false; From 7f1aeb366228bb762fe68bf7a00faac3f0ef8a65 Mon Sep 17 00:00:00 2001 From: darshan-uber <57134799+darshan-uber@users.noreply.github.com> Date: Mon, 24 Feb 2025 12:06:36 -0800 Subject: [PATCH 2/3] update patch version --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 05c6574..fb2cca1 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "react-movable", - "version": "3.4.0", + "version": "3.4.1", "type": "module", "description": "Drag and drop lists.", "main": "lib/index.js", From e6c3702575e981b1a98287075854464a46e9cf63 Mon Sep 17 00:00:00 2001 From: "darshan.a" Date: Tue, 25 Feb 2025 22:10:18 -0800 Subject: [PATCH 3/3] add changeset --- .changeset/spotty-pears-agree.md | 5 +++++ package.json | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/spotty-pears-agree.md diff --git a/.changeset/spotty-pears-agree.md b/.changeset/spotty-pears-agree.md new file mode 100644 index 0000000..b754485 --- /dev/null +++ b/.changeset/spotty-pears-agree.md @@ -0,0 +1,5 @@ +--- +"react-movable": patch +--- + +add check for element presence in "checkIfInteractive" utility diff --git a/package.json b/package.json index fb2cca1..05c6574 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "react-movable", - "version": "3.4.1", + "version": "3.4.0", "type": "module", "description": "Drag and drop lists.", "main": "lib/index.js",