Improve stability and error handling across auth, main, and accounts logic#1
Open
krlaskidata wants to merge 2 commits into
Open
Improve stability and error handling across auth, main, and accounts logic#1krlaskidata wants to merge 2 commits into
krlaskidata wants to merge 2 commits into
Conversation
Author
|
Let me know what you think 🙂 I focused mainly on stability, removing duplication, and improving error visibility. I'm open to feedback or changes if something doesn't fit your expectations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves stability, error handling, and overall robustness across multiple parts of the application, mainly focusing on authentication, window communication, and account handling.
Key Changes
🔐 Authentication (auth-service.js)
rejectUnauthorized: true) to improve security and prevent potential MITM risksconsole.warnfallback for unencrypted credential handling to improve visibility during debugging🧠 Core Logic (main.js)
sendToWindow(channel, ...args)helper to reduce duplicated logicmainWindow && !mainWindow.isDestroyed()) before sending events→ prevents crashes when windows close during async operations
.catch()blocks with proper logging (console.warn)→ improves debugging and avoids silent failures
resolveAccountCookies(accountId)logic to eliminate duplication across:resolveLiveAuthTokensscanAllAccountRegionscopy-cloud-settings⚡ UI / Accounts (App.jsx)
refreshAccountRanks:status === 'running'