From c00603dda272d3fd3e2e66767c5ad25b5b572f13 Mon Sep 17 00:00:00 2001 From: Esun Kim Date: Sat, 24 Jan 2026 17:10:01 -0800 Subject: [PATCH] fixes --- .bazelrc | 2 ++ tensorflow/lite/micro/kernels/add_n.cc | 2 +- .../lite/micro/kernels/concatenation_test.cc | 16 ++++++++-------- tensorflow/lite/micro/kernels/l2norm_test.cc | 4 +--- tensorflow/lite/micro/kernels/mul_test.cc | 4 +--- tensorflow/lite/micro/kernels/pack_test.cc | 12 ++++++------ tensorflow/lite/micro/kernels/unpack_test.cc | 12 ++++++------ .../lite/micro/micro_resource_variable_test.cc | 13 ++++++------- 8 files changed, 31 insertions(+), 34 deletions(-) diff --git a/.bazelrc b/.bazelrc index 1d353ade595..ce4cd09ddee 100644 --- a/.bazelrc +++ b/.bazelrc @@ -48,6 +48,7 @@ build:ci --show_timestamps build:ci --terminal_columns=0 build:ci --verbose_failures build:ci --test_output=errors +build:ci --keep_going # Windows CI options build:windows_ci --config=windows @@ -59,6 +60,7 @@ build:windows_ci --show_timestamps build:windows_ci --terminal_columns=0 build:windows_ci --verbose_failures build:windows_ci --test_output=errors +build:windows_ci --keep_going # When building with the address sanitizer # E.g., bazel build --config asan diff --git a/tensorflow/lite/micro/kernels/add_n.cc b/tensorflow/lite/micro/kernels/add_n.cc index 765d5d630f6..05a8edd052b 100644 --- a/tensorflow/lite/micro/kernels/add_n.cc +++ b/tensorflow/lite/micro/kernels/add_n.cc @@ -86,7 +86,7 @@ TfLiteStatus CalculateOpData(TfLiteContext* context, TfLiteNode* node) { TF_LITE_ENSURE_OK(context, context->RequestScratchBufferInArena( context, scratch_size, &scratch_index)); node->user_data = - reinterpret_castuser_data)>(scratch_index); + reinterpret_cast(static_cast(scratch_index)); } else if (output->type == kTfLiteInt8) { node->user_data = context->AllocatePersistentBuffer(context, sizeof(OpData)); diff --git a/tensorflow/lite/micro/kernels/concatenation_test.cc b/tensorflow/lite/micro/kernels/concatenation_test.cc index c7e698007ea..01b17cfc2e4 100644 --- a/tensorflow/lite/micro/kernels/concatenation_test.cc +++ b/tensorflow/lite/micro/kernels/concatenation_test.cc @@ -43,8 +43,8 @@ void TestConcatenateOneInput(int* input1_dims_data, const T* input1_data, TfLiteIntArray* outputs_array = IntArrayFromInts(outputs_array_data); TfLiteConcatenationParams builtin_data = { - .axis = axis, - .activation = kTfLiteActNone // Only activation supported in this impl + axis, + kTfLiteActNone // Only activation supported in this impl }; const TFLMRegistration registration = Register_CONCATENATION(); @@ -97,8 +97,8 @@ void TestConcatenateTwoInputs( TfLiteIntArray* outputs_array = IntArrayFromInts(outputs_array_data); TfLiteConcatenationParams builtin_data = { - .axis = axis, - .activation = kTfLiteActNone // Only activation supported in this impl + axis, + kTfLiteActNone // Only activation supported in this impl }; const TFLMRegistration registration = Register_CONCATENATION(); @@ -166,8 +166,8 @@ void TestConcatenateQuantizedTwoInputs( TfLiteIntArray* outputs_array = IntArrayFromInts(outputs_array_data); TfLiteConcatenationParams builtin_data = { - .axis = axis, - .activation = kTfLiteActNone // Only activation supported in this impl + axis, + kTfLiteActNone // Only activation supported in this impl }; const TFLMRegistration registration = Register_CONCATENATION(); @@ -226,8 +226,8 @@ void TestConcatenateQuantizedTwoInputsCompressed( TfLiteIntArray* outputs_array = IntArrayFromInts(outputs_array_data); TfLiteConcatenationParams builtin_data = { - .axis = axis, - .activation = kTfLiteActNone // Only activation supported in this impl + axis, + kTfLiteActNone // Only activation supported in this impl }; const TFLMRegistration registration = Register_CONCATENATION(); diff --git a/tensorflow/lite/micro/kernels/l2norm_test.cc b/tensorflow/lite/micro/kernels/l2norm_test.cc index 435f2f00479..3d459f1cf60 100644 --- a/tensorflow/lite/micro/kernels/l2norm_test.cc +++ b/tensorflow/lite/micro/kernels/l2norm_test.cc @@ -70,9 +70,7 @@ void TestL2Normalization(int* input_dims_data, const T* input_data, int outputs_array_data[] = {1, 1}; TfLiteIntArray* outputs_array = IntArrayFromInts(outputs_array_data); - TfLiteL2NormParams builtin_data = { - .activation = kTfLiteActNone, - }; + TfLiteL2NormParams builtin_data = {kTfLiteActNone}; const TFLMRegistration registration = tflite::Register_L2_NORMALIZATION(); micro::KernelRunner runner(registration, tensors, tensors_size, inputs_array, diff --git a/tensorflow/lite/micro/kernels/mul_test.cc b/tensorflow/lite/micro/kernels/mul_test.cc index 2234a1f7650..62b440c18e2 100644 --- a/tensorflow/lite/micro/kernels/mul_test.cc +++ b/tensorflow/lite/micro/kernels/mul_test.cc @@ -45,9 +45,7 @@ template void ValidateMulGoldens(TfLiteTensor* tensors, int tensors_size, TfLiteFusedActivation activation, const T* golden, int output_len, float tolerance, T* output) { - TfLiteMulParams builtin_data = { - .activation = activation, - }; + TfLiteMulParams builtin_data = {activation}; int inputs_array_data[] = {2, 0, 1}; TfLiteIntArray* inputs_array = IntArrayFromInts(inputs_array_data); diff --git a/tensorflow/lite/micro/kernels/pack_test.cc b/tensorflow/lite/micro/kernels/pack_test.cc index 90fbb98e83e..60fbc2a916f 100644 --- a/tensorflow/lite/micro/kernels/pack_test.cc +++ b/tensorflow/lite/micro/kernels/pack_test.cc @@ -63,8 +63,8 @@ void TestPackTwoInputsFloat(int* input1_dims_data, const float* input1_data, CreateTensor(output_data, output_dims)}; TfLitePackParams builtin_data = { - .values_count = 2, - .axis = axis, + 2, + axis, }; int inputs_array_data[] = {2, 0, 1}; TfLiteIntArray* inputs_array = IntArrayFromInts(inputs_array_data); @@ -97,8 +97,8 @@ void TestPackThreeInputsFloat(int* input1_dims_data, const float* input1_data, CreateTensor(output_data, output_dims)}; TfLitePackParams builtin_data = { - .values_count = 3, - .axis = axis, + 3, + axis, }; int inputs_array_data[] = {3, 0, 1, 2}; TfLiteIntArray* inputs_array = IntArrayFromInts(inputs_array_data); @@ -128,8 +128,8 @@ void TestPackTwoInputs(int* input1_dims_data, const T* input1_data, CreateTensor(output_data, output_dims)}; TfLitePackParams builtin_data = { - .values_count = 2, - .axis = axis, + 2, + axis, }; int inputs_array_data[] = {2, 0, 1}; TfLiteIntArray* inputs_array = IntArrayFromInts(inputs_array_data); diff --git a/tensorflow/lite/micro/kernels/unpack_test.cc b/tensorflow/lite/micro/kernels/unpack_test.cc index 59c8946424a..d93bb54c787 100644 --- a/tensorflow/lite/micro/kernels/unpack_test.cc +++ b/tensorflow/lite/micro/kernels/unpack_test.cc @@ -60,8 +60,8 @@ void TestUnpackThreeOutputsFloat( } TfLiteUnpackParams builtin_data = { - .num = 3, - .axis = axis, + 3, + axis, }; int inputs_array_data[] = {1, 0}; @@ -110,8 +110,8 @@ void TestUnpackOneOutputFloat(int* input_dims_data, const float* input_data, } TfLiteUnpackParams builtin_data = { - .num = 1, - .axis = axis, + 1, + axis, }; int inputs_array_data[] = {1, 0}; @@ -172,8 +172,8 @@ void TestUnpackThreeOutputs(int* input_dims_data, const T* input_data, int axis, } TfLiteUnpackParams builtin_data = { - .num = 3, - .axis = axis, + 3, + axis, }; int inputs_array_data[] = {1, 0}; diff --git a/tensorflow/lite/micro/micro_resource_variable_test.cc b/tensorflow/lite/micro/micro_resource_variable_test.cc index a30718cb994..fd8384873ea 100644 --- a/tensorflow/lite/micro/micro_resource_variable_test.cc +++ b/tensorflow/lite/micro/micro_resource_variable_test.cc @@ -116,10 +116,9 @@ TF_LITE_MICRO_TEST(VerifyAssignAndReadResourceBuffer) { 23, 24, 25, 26, 27, 28, 29, 30, 31, 32}; int dims[] = {1, 32}; TfLiteEvalTensor assign_tensor = { - .data = {golden}, - .dims = tflite::testing::IntArrayFromInts(dims), - - .type = kTfLiteFloat32, + {reinterpret_cast(golden)}, + tflite::testing::IntArrayFromInts(dims), + kTfLiteFloat32, }; resource_variables->Assign( id, tflite::EvalTensorBytes(&assign_tensor), @@ -127,9 +126,9 @@ TF_LITE_MICRO_TEST(VerifyAssignAndReadResourceBuffer) { int32_t buffer[32]; TfLiteEvalTensor read_tensor = { - .data = {buffer}, - .dims = tflite::testing::IntArrayFromInts(dims), - .type = kTfLiteInt32, + {reinterpret_cast(buffer)}, + tflite::testing::IntArrayFromInts(dims), + kTfLiteInt32, }; resource_variables->Read(id, &read_tensor); for (int i = 0; i < 32; i++) {