From 879a20ea416c70576fc884b49ed197345da3b3eb Mon Sep 17 00:00:00 2001 From: campersau Date: Wed, 4 Mar 2026 12:25:35 +0100 Subject: [PATCH] Use GetBytesFromBase64 / WriteBase64StringValue to avoid string allocations --- src/Docker.DotNet/Base64Converter.cs | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/Docker.DotNet/Base64Converter.cs b/src/Docker.DotNet/Base64Converter.cs index 66e3e302..1b2a37ea 100644 --- a/src/Docker.DotNet/Base64Converter.cs +++ b/src/Docker.DotNet/Base64Converter.cs @@ -4,13 +4,11 @@ internal class Base64Converter : JsonConverter> { public override IList Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options) { - var base64String = reader.GetString(); - return base64String == null ? null : Convert.FromBase64String(base64String); + return reader.GetBytesFromBase64(); } public override void Write(Utf8JsonWriter writer, IList value, JsonSerializerOptions options) { - var base64String = Convert.ToBase64String(value.ToArray()); - writer.WriteStringValue(base64String); + writer.WriteBase64StringValue(value.ToArray()); } } \ No newline at end of file