Skip to content

Get crisp_e2e test and templates/default integration tests working with trbfv and switch trbfv on by default #990

Description

@ryardley

The CRISP trbfv test does not work because the old parameter set returns incorrect output with trbfv.

Problems:

  1. Whilst this integration test works with new params:

    https://github.com/gnosisguild/enclave/blob/418e42feceb5596a50f4f039f45d0f102fb7d50b/tests/integration/base.sh#L56-L62

    When substituting these with the old params the test fails because the output is garbled and the decryption fails.

  2. To implement the latest full params for crisp as found here:

    https://github.com/gnosisguild/enclave/blob/418e42feceb5596a50f4f039f45d0f102fb7d50b/crates/bfv-helpers/src/lib.rs#L52-L62

    Will make our tests take an extremely long time in terms of proving so we need to test with less secure parameters but because of problem 1 above we cannot use smaller params so CRISP test is currently running in BFV mode and not TrBFV mode

    This is configured here for crisp (we should change this to be configured in a more centralized way in a different PR)

    https://github.com/gnosisguild/enclave/blob/418e42feceb5596a50f4f039f45d0f102fb7d50b/packages/enclave-contracts/scripts/deployEnclave.ts#L33-L40

Metadata

Metadata

Assignees

Labels

ciphernodeRelated to the ciphernode packagecrispRelated to the crisp example app

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions