Crashes horribly when function names are invalid identifiers

[LinusU]

See mciparelli/co-redis#16

Small test case to reproduce:

const thenify = require('thenify')

function testMe () {}

Object.defineProperty(testMe, 'name', { value: 'test-me' })

thenify(testMe)

[LinusU]

Also reported here mciparelli/co-redis#16 and here redis/node-redis#1075

[jonathanong]

it's like they are intentionally trying to break it... :P

what's your solution here?

[LinusU]

Hehe, it seems that way 😆

I would actually prefer this being fixed on both ends, we could probably implement a quick check for valid names here, and if the name is invalid we could drop the name...

Another solution would be to utilize the same check that they are using, and in newer engines (e.g. Node.js >4) set the name by using Object.defineProperty instead of using eval. That way this wouldn't have blown up...

[juliangruber]

a function's .name containing - and other chars is totally valid from a language point of view, so -1 on having to change that in the redis libs.

[magicdawn]

I'm using eval to build cowrap for keeping the function.length, but what's purpose of this using eval here? keeping the function name?