Commit 1921336
committed
ASoC: SOF: Add support for hint from topology for pause support
A new token is added to topology:
1202: SOF_TKN_STREAM_PLAYBACK_PAUSE_SUPPORTED
The snd_sof_pcm_stream.pause_supported is updated based on the new token
as hint for platform code that the PAUSE support should or should not be
advertised to user space.
If the token does not exist then the PAUSE is advised to be disabled.
Reasoning: End-users are using media servers to use audio (Pulseaudio,
Pipewire, CRAS, etc) and they never use pause operation. Media players
using ALSA directly have support for PCMs without pause support.
The pause/resume has never been tested in a same depth as other use cases
and we have corner cases that receives virtually no testing at all, like
suspending while the stream is paused.
We do not test the pause/resume in a more complex environment either and
it might have hidden issues.
Note: it is up to the platform code to use this flag to disable (or enable)
the pause support, this patch is just stores it as a hint.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>1 parent ca0a005 commit 1921336
3 files changed
Lines changed: 14 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
153 | 153 | | |
154 | 154 | | |
155 | 155 | | |
| 156 | + | |
| 157 | + | |
156 | 158 | | |
157 | 159 | | |
158 | 160 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
332 | 332 | | |
333 | 333 | | |
334 | 334 | | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
335 | 343 | | |
336 | 344 | | |
337 | 345 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
407 | 407 | | |
408 | 408 | | |
409 | 409 | | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
410 | 414 | | |
411 | 415 | | |
412 | 416 | | |
| |||
0 commit comments