Skip to content

Commit aeffc83

Browse files
committed
Trace: remove atomic trace context dependency
Remove context dependency from four atomic trace definition. Signed-off-by: Baofeng Tian <baofeng.tian@intel.com>
1 parent 740072f commit aeffc83

6 files changed

Lines changed: 21 additions & 21 deletions

File tree

posix/include/rtos/spinlock.h

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,9 @@ extern struct tr_ctx sl_tr;
8888
break; /* lock acquired */ \
8989
} \
9090
if (__tries == 0) { \
91-
tr_err_atomic(&sl_tr, "DED"); \
92-
tr_err_atomic(&sl_tr, "line: %d", line); \
93-
tr_err_atomic(&sl_tr, "user: %d", (lock)->user); \
91+
tr_err_atomic("DED"); \
92+
tr_err_atomic("line: %d", line); \
93+
tr_err_atomic("user: %d", (lock)->user); \
9494
panic(SOF_IPC_PANIC_DEADLOCK); /* lock not acquired */ \
9595
} \
9696
} while (0)
@@ -102,11 +102,11 @@ extern struct tr_ctx sl_tr;
102102
int __i = 0; \
103103
int __count = lock_dbg_atomic >= DBG_LOCK_USERS \
104104
? DBG_LOCK_USERS : lock_dbg_atomic; \
105-
tr_err_atomic(&sl_tr, "eal"); \
106-
tr_err_atomic(&sl_tr, "line: %d", line); \
107-
tr_err_atomic(&sl_tr, "dbg_atomic: %d", lock_dbg_atomic); \
105+
tr_err_atomic("eal"); \
106+
tr_err_atomic("line: %d", line); \
107+
tr_err_atomic("dbg_atomic: %d", lock_dbg_atomic); \
108108
for (__i = 0; __i < __count; __i++) { \
109-
tr_err_atomic(&sl_tr, "value: %d", \
109+
tr_err_atomic("value: %d", \
110110
(lock_dbg_atomic << 24) | \
111111
lock_dbg_user[__i]); \
112112
} \

posix/include/rtos/wait.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ static inline void wait_for_interrupt(int level)
3232
tr_dbg(&wait_tr, "WFE");
3333
#if CONFIG_DEBUG_LOCKS
3434
if (lock_dbg_atomic)
35-
tr_err_atomic(&wait_tr, "atm");
35+
tr_err_atomic("atm");
3636
#endif
3737
platform_wait_for_interrupt(level);
3838
tr_dbg(&wait_tr, "WFX");

src/include/sof/trace/trace.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -220,22 +220,22 @@ struct tr_ctx {
220220

221221
/* tracing from infrastructure part */
222222

223-
#define tr_err_atomic(ctx, fmt, ...) \
223+
#define tr_err_atomic(fmt, ...) \
224224
trace_error_atomic_with_ids_nonzephyr(_TRACE_INV_CLASS, \
225225
_TRACE_INV_ID, _TRACE_INV_ID, \
226226
fmt, ##__VA_ARGS__)
227227

228-
#define tr_warn_atomic(ctx, fmt, ...) \
228+
#define tr_warn_atomic(fmt, ...) \
229229
trace_warn_atomic_with_ids_nonzephyr(_TRACE_INV_CLASS, \
230230
_TRACE_INV_ID, _TRACE_INV_ID, \
231231
fmt, ##__VA_ARGS__)
232232

233-
#define tr_info_atomic(ctx, fmt, ...) \
233+
#define tr_info_atomic(fmt, ...) \
234234
trace_event_atomic_with_ids_nonzephyr(_TRACE_INV_CLASS, \
235235
_TRACE_INV_ID, _TRACE_INV_ID, \
236236
fmt, ##__VA_ARGS__)
237237

238-
#define tr_dbg_atomic(ctx, fmt, ...) \
238+
#define tr_dbg_atomic(fmt, ...) \
239239
tracev_event_atomic_with_ids_nonzephyr(_TRACE_INV_CLASS, \
240240
_TRACE_INV_ID, _TRACE_INV_ID, \
241241
fmt, ##__VA_ARGS__)

src/trace/dma-trace.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -491,7 +491,7 @@ int dma_trace_enable(struct dma_trace_data *d)
491491

492492
/* validate DMA context */
493493
if (!d->dc.dmac || !d->dc.chan) {
494-
tr_err_atomic(&dt_tr, "dma_trace_enable(): not valid");
494+
tr_err_atomic("dma_trace_enable(): not valid");
495495
err = -ENODEV;
496496
goto out;
497497
}

xtos/include/rtos/spinlock.h

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,9 @@ extern struct tr_ctx sl_tr;
8888
break; /* lock acquired */ \
8989
} \
9090
if (__tries == 0) { \
91-
tr_err_atomic(&sl_tr, "DED"); \
92-
tr_err_atomic(&sl_tr, "line: %d", line); \
93-
tr_err_atomic(&sl_tr, "user: %d", (lock)->user); \
91+
tr_err_atomic("DED"); \
92+
tr_err_atomic("line: %d", line); \
93+
tr_err_atomic("user: %d", (lock)->user); \
9494
panic(SOF_IPC_PANIC_DEADLOCK); /* lock not acquired */ \
9595
} \
9696
} while (0)
@@ -102,11 +102,11 @@ extern struct tr_ctx sl_tr;
102102
int __i = 0; \
103103
int __count = lock_dbg_atomic >= DBG_LOCK_USERS \
104104
? DBG_LOCK_USERS : lock_dbg_atomic; \
105-
tr_err_atomic(&sl_tr, "eal"); \
106-
tr_err_atomic(&sl_tr, "line: %d", line); \
107-
tr_err_atomic(&sl_tr, "dbg_atomic: %d", lock_dbg_atomic); \
105+
tr_err_atomic("eal"); \
106+
tr_err_atomic("line: %d", line); \
107+
tr_err_atomic("dbg_atomic: %d", lock_dbg_atomic); \
108108
for (__i = 0; __i < __count; __i++) { \
109-
tr_err_atomic(&sl_tr, "value: %d", \
109+
tr_err_atomic("value: %d", \
110110
(lock_dbg_atomic << 24) | \
111111
lock_dbg_user[__i]); \
112112
} \

xtos/include/rtos/wait.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ static inline void wait_for_interrupt(int level)
3232
tr_dbg(&wait_tr, "WFE");
3333
#if CONFIG_DEBUG_LOCKS
3434
if (lock_dbg_atomic)
35-
tr_err_atomic(&wait_tr, "atm");
35+
tr_err_atomic("atm");
3636
#endif
3737
platform_wait_for_interrupt(level);
3838
tr_dbg(&wait_tr, "WFX");

0 commit comments

Comments
 (0)