Add a handful of pikaday options#7
Open
imjared wants to merge 1 commit into
Open
Conversation
- defaultDate - firstDay - format - maxDate - minDate - position - setDefaultDate - showWeekNumber
|
👍, the format option would be nice to have. |
|
This means every option is a prop, how about just passing one prop called |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a few pikaday options that I needed for my project. Might extend this further if I have need for it.
I've gotta admit, I'm not too great with testing and while your tests were helpful as a reference, I'm not entirely sure how I'd write one for something like
maxDateorfirstDay. If you have any suggestions on how I could account for these options, I'm happy to try writing them! I could definitely use the practice.