From 921c0b5e04b18b0188673811bd1fb27448fa6a61 Mon Sep 17 00:00:00 2001 From: Felipe Barroso Date: Tue, 9 Aug 2022 10:12:47 -0300 Subject: [PATCH 1/2] small improvement to always return ActionParam os User model user_params method and make use of permit for default params --- app/controllers/clearance/users_controller.rb | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/app/controllers/clearance/users_controller.rb b/app/controllers/clearance/users_controller.rb index 59cab213..9250c450 100644 --- a/app/controllers/clearance/users_controller.rb +++ b/app/controllers/clearance/users_controller.rb @@ -31,16 +31,10 @@ def url_after_create end def user_from_params - email = user_params.delete(:email) - password = user_params.delete(:password) - - Clearance.configuration.user_model.new(user_params).tap do |user| - user.email = email - user.password = password - end + Clearance.configuration.user_model.new(user_params) end def user_params - params[Clearance.configuration.user_parameter] || Hash.new + params.fetch(Clearance.configuration.user_parameter, {}).permit(:email, :password) end end From 27d79c0ea4f4c89b60dc483f7e173d548afc41b3 Mon Sep 17 00:00:00 2001 From: Felipe Barroso Date: Tue, 9 Aug 2022 10:40:45 -0300 Subject: [PATCH 2/2] fix to pass Metrics/LineLegth check --- app/controllers/clearance/users_controller.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/controllers/clearance/users_controller.rb b/app/controllers/clearance/users_controller.rb index 9250c450..ccece588 100644 --- a/app/controllers/clearance/users_controller.rb +++ b/app/controllers/clearance/users_controller.rb @@ -35,6 +35,7 @@ def user_from_params end def user_params - params.fetch(Clearance.configuration.user_parameter, {}).permit(:email, :password) + params.fetch(Clearance.configuration.user_parameter, {}). + permit(:email, :password) end end