Skip to content

Commit 2654bf4

Browse files
banner link open in new tab
1 parent 0670c0c commit 2654bf4

2 files changed

Lines changed: 9 additions & 9 deletions

File tree

src/components/DevDocTemplate/index.tsx

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -522,6 +522,11 @@ const DevDocTemplate: FC<DevDocTemplateProps> = (props) => {
522522
};
523523

524524
const isExternalLink = (href?: string) => /^https?:\/\//i.test(href || '');
525+
const shouldOpenBannerLinkNewTab = (href?: string) =>
526+
Boolean(HOME_ANNOUNCEMENT_BANNER?.openInNewTab) || isExternalLink(href);
527+
const bannerLinkOpensInNewTab = shouldOpenBannerLinkNewTab(
528+
HOME_ANNOUNCEMENT_BANNER?.linkHref,
529+
);
525530

526531
return (
527532
<>
@@ -558,17 +563,11 @@ const DevDocTemplate: FC<DevDocTemplateProps> = (props) => {
558563
className="announcementBanner__link"
559564
href={HOME_ANNOUNCEMENT_BANNER.linkHref}
560565
target={
561-
isExternalLink(
562-
HOME_ANNOUNCEMENT_BANNER.linkHref,
563-
)
564-
? '_blank'
565-
: undefined
566+
bannerLinkOpensInNewTab ? '_blank' : undefined
566567
}
567568
rel={
568-
isExternalLink(
569-
HOME_ANNOUNCEMENT_BANNER.linkHref,
570-
)
571-
? 'noreferrer'
569+
bannerLinkOpensInNewTab
570+
? 'noopener noreferrer'
572571
: undefined
573572
}
574573
>

src/configs/doc-configs.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ module.exports = {
2424
//linkHref: '/docs/whats-new',
2525
linkHref: '/docs/26.2.0.cl?pageid=whats-new',
2626
linkText: 'Version 26.2.0.cl',
27+
openInNewTab: true,
2728
},
2829
TYPE_DOC_PREFIX: 'typedoc',
2930
DEFAULT_HOST: 'https://try-everywhere.thoughtspot.cloud',

0 commit comments

Comments
 (0)