Skip to content

Dropdown selection not working #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityamittal3107 merged 1 commit into from
Apr 25, 2025
Merged

Dropdown selection not working #307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 26 additions & 13 deletions src/components/Dropdown/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,28 @@ const Dropdown = (props: { location: Location; isMobile: boolean }) => {

useEffect(() => {
const currentPath = location.pathname;

// First check if we're on a versioned path
const versionFromPath = options.find(
(option) =>
option.link !== ' ' &&
option.link !== '' &&
(currentPath.includes(`/${option.link}`) ||
currentPath.includes(
`/${option.link.replace(/\./g, '-')}`,
)),
);

if (versionFromPath) {
setCurrentVersion(versionFromPath);
return;
}

// Check for latest version paths
if (
currentPath === '/' ||
currentPath === '/docs' ||
currentPath === '/docs/' ||
currentPath.startsWith('/introduction') ||
!currentPath.includes('-')
) {
Expand All @@ -32,18 +52,7 @@ const Dropdown = (props: { location: Location; isMobile: boolean }) => {
}
}

const versionFromPath = options.find(
(option) =>
option.link !== ' ' &&
option.link !== '' &&
currentPath.includes(option.link),
);

if (versionFromPath) {
setCurrentVersion(versionFromPath);
return;
}

// Check in /docs/ path
if (currentPath.startsWith('/docs/')) {
const pathParts = currentPath.split('/');
if (pathParts.length >= 3) {
Expand All @@ -55,7 +64,10 @@ const Dropdown = (props: { location: Location; isMobile: boolean }) => {
const optionPath = option.link.startsWith('/')
? option.link.substring(1)
: option.link;
return optionPath === versionPathInDocs;
return (
optionPath === versionPathInDocs ||
optionPath.replace(/\./g, '-') === versionPathInDocs
);
});
if (matchingVersion) {
setCurrentVersion(matchingVersion);
Expand All @@ -64,6 +76,7 @@ const Dropdown = (props: { location: Location; isMobile: boolean }) => {
}
}

// Fallback to query params or localStorage
const params = new URLSearchParams(location.search);
const version =
params.get('version') || localStorage.getItem('version');
Expand Down
Loading