UninstallHook raised exception

[hafedh-trimeche]

Hello,

Please note this exception raised by FastMM:

FastMM_GetMem_GetSmallBlock($0000000001d4f7d0)
@GetMem(??)
@NewUnicodeString(16)
@UStrSetLength('',16)
_UInt64ToHexString(140718007382672,16,12,'0','')
IntToHex(??,??,'')
WideFormatBuf($00000080000043c0,4095,$0000000000fd8c34,34,([0]=(((_Reserved1=140718007382672,VType=5)))),(CurrencyString='',CurrencyFormat=0,CurrencyDecimals=0,DateSeparator='-',TimeSeparator=':',ListSeparator=#$0,ShortDateFormat='',LongDateFormat='yyyy-mm-dd',TimeAMString='',TimePMString='',ShortTimeFormat='',LongTimeFormat='hh:nn:ss.zzz',ShortMonthNames=([1]='',[2]='',[3]='',[4]='',[5]='',[6]='',[7]='',[8]='',[9]='',[10]='',[11]='',[12]='')))
FormatBuf(??,??,(??),??,([0]=(((_Reserved1=140718007382672,VType=5)))),(CurrencyString='',CurrencyFormat=0,CurrencyDecimals=0,DateSeparator='-',TimeSeparator=':',ListSeparator=#$0,ShortDateFormat='',LongDateFormat='yyyy-mm-dd',TimeAMString='',TimePMString='',ShortTimeFormat='',LongTimeFormat='hh:nn:ss.zzz',ShortMonthNames=([1]='',[2]='',[3]='',[4]='',[5]='',[6]='',[7]='',[8]='',[9]='',[10]='',[11]='',[12]='')))
FmtStr('','Attempting to uninstall hook at %p',([0]=(((_Reserved1=140718007382672,VType=5))),[1]=(((_Reserved1=0,VType=0))),[2]=(((_Reserved1=16616176,VType=0))),[3]=(((_Reserved1=140718007382016,VType=0))),[4]=(((_Reserved1=549755839664,VType=0))),[5]=(((_Reserved1=140717961651723,VType=14))),[6]=(((_Reserved1=2731615780864,VType=112)))),(CurrencyString='',CurrencyFormat=0,CurrencyDecimals=0,DateSeparator='-',TimeSeparator=':',ListSeparator=#$0,ShortDateFormat='',LongDateFormat='yyyy-mm-dd',TimeAMString='',TimePMString='',ShortTimeFormat='',LongTimeFormat='hh:nn:ss.zzz',ShortMonthNames=([1]='',[2]='',[3]='',[4]='',[5]='',[6]='',[7]='',[8]='',[9]='',[10]='',[11]='',[12]='')))
Format(??,([0]=(((_Reserved1=??,VType=??)))),(CurrencyString='',CurrencyFormat=0,CurrencyDecimals=0,DateSeparator='-',TimeSeparator=':',ListSeparator=#$0,ShortDateFormat='',LongDateFormat='yyyy-mm-dd',TimeAMString='',TimePMString='',ShortTimeFormat='',LongTimeFormat='hh:nn:ss.zzz',ShortMonthNames=([1]='',[2]='',[3]='',[4]='',[5]='',[6]='',[7]='',[8]='',[9]='',[10]='',[11]='',[12]='')),'')
Format(??,([0]=(((_Reserved1=??,VType=??)))),'')
OutputDebugStringFmt('Attempting to uninstall hook at %p',([0]=(((_Reserved1=140718007382672,VType=5)))))
UninstallHook($00007ffb76d7f290,??)
HookedNtQueryVirtualMemory(18446744073709551615,$0000027c25fd0000,MemoryRegionInformation,$00000080000fde18,48,nil)
HookedNtQueryVirtualMemory(18446744073709551615,$0000027c25fd0000,MemoryRegionInformation,$00000080000fde18,48,nil)

Raised inside:

function UninstallHook(
  const ATargetFunc: Pointer;   // Address of the hooked function.
  const AOrigBytes: TBytes      // The original bytes saved during InstallHook.
): Boolean;
var
  LOldProtect: DWORD;           // Stores original memory protection flags.
begin
  Result := False; // Assume failure.

  // Validate input pointer and original bytes length.
  if (ATargetFunc = nil) or (Length(AOrigBytes) <> HOOK_SIZE) then
  begin
    OutputDebugStringFmt('UninstallHook Error: TargetFunc (%p) is nil or OrigBytes length mismatch (%d vs %d).', [ATargetFunc, Length(AOrigBytes), HOOK_SIZE]);
    Exit;
  end;

  OutputDebugStringFmt('Attempting to uninstall hook at %p', [ATargetFunc]);

  // 1. Make the target function's memory writable and executable.
  if VirtualProtect(ATargetFunc, HOOK_SIZE, PAGE_EXECUTE_READWRITE, LOldProtect) then
  try
    // 2. Write the saved original bytes back to the target function's entry point.
    Move(AOrigBytes[0], ATargetFunc^, HOOK_SIZE);

    // 3. Flush the CPU's instruction cache for the modified memory range.
    FlushInstructionCache(GetCurrentProcess, ATargetFunc, HOOK_SIZE);

    Result := True; // Hook removal successful.
    OutputDebugStringFmt('Hook uninstalled successfully at %p', [ATargetFunc]);
  finally
    // 4. Restore the original memory protection flags.
    VirtualProtect(ATargetFunc, HOOK_SIZE, LOldProtect, LOldProtect);
  end
  else
  begin
    // VirtualProtect failed. Log error.
    OutputDebugStringFmt('UninstallHook Error: VirtualProtect PAGE_EXECUTE_READWRITE failed for %p. Error: %d', [ATargetFunc, GetLastError]);
  end;
end;

Best regards.

[jarroddavis68]

Well I need more in formation. What are trying to do here? which version of Delphi, Windows, etc.

[jarroddavis68]

You may want to consider StdApp.DllLoader.pas, it has the latest features and has been improved.
https://github.com/tinyBigGAMES/StdApp

[hafedh-trimeche]

Hello,

Same problem using StdApp:
Delphi 12.3 Windows 11

FastMM_GetMem_GetSmallBlock($00000000013df7d0)
@GetMem(??)
@NewUnicodeString(16)
@UStrSetLength('',16)
_UInt64ToHexString(140718007382672,16,12,'0','')
IntToHex(??,??,'')
WideFormatBuf($000000f1ab6243c0,4095,$0000000000668c44,34,([0]=(((_Reserved1=140718007382672,VType=5)))),(CurrencyString='',CurrencyFormat=0,CurrencyDecimals=0,DateSeparator='-',TimeSeparator=':',ListSeparator=#$0,ShortDateFormat='',LongDateFormat='yyyy-mm-dd',TimeAMString='',TimePMString='',ShortTimeFormat='',LongTimeFormat='hh:nn:ss.zzz',ShortMonthNames=([1]='',[2]='',[3]='',[4]='',[5]='',[6]='',[7]='',[8]='',[9]='',[10]='',[11]='',[12]='')))
FormatBuf(??,??,(??),??,([0]=(((_Reserved1=140718007382672,VType=5)))),(CurrencyString='',CurrencyFormat=0,CurrencyDecimals=0,DateSeparator='-',TimeSeparator=':',ListSeparator=#$0,ShortDateFormat='',LongDateFormat='yyyy-mm-dd',TimeAMString='',TimePMString='',ShortTimeFormat='',LongTimeFormat='hh:nn:ss.zzz',ShortMonthNames=([1]='',[2]='',[3]='',[4]='',[5]='',[6]='',[7]='',[8]='',[9]='',[10]='',[11]='',[12]='')))
FmtStr('','Attempting to uninstall hook at %p',([0]=(((_Reserved1=140718007382672,VType=5))),[1]=(((_Reserved1=0,VType=0))),[2]=(((_Reserved1=6720256,VType=0))),[3]=(((_Reserved1=140718007382016,VType=0))),[4]=(((_Reserved1=1037962470576,VType=0))),[5]=(((_Reserved1=140717961651723,VType=14))),[6]=(((_Reserved1=2735904980992,VType=112)))),(CurrencyString='',CurrencyFormat=0,CurrencyDecimals=0,DateSeparator='-',TimeSeparator=':',ListSeparator=#$0,ShortDateFormat='',LongDateFormat='yyyy-mm-dd',TimeAMString='',TimePMString='',ShortTimeFormat='',LongTimeFormat='hh:nn:ss.zzz',ShortMonthNames=([1]='',[2]='',[3]='',[4]='',[5]='',[6]='',[7]='',[8]='',[9]='',[10]='',[11]='',[12]='')))
Format(??,([0]=(((_Reserved1=??,VType=??)))),(CurrencyString='',CurrencyFormat=0,CurrencyDecimals=0,DateSeparator='-',TimeSeparator=':',ListSeparator=#$0,ShortDateFormat='',LongDateFormat='yyyy-mm-dd',TimeAMString='',TimePMString='',ShortTimeFormat='',LongTimeFormat='hh:nn:ss.zzz',ShortMonthNames=([1]='',[2]='',[3]='',[4]='',[5]='',[6]='',[7]='',[8]='',[9]='',[10]='',[11]='',[12]='')),'')
Format(??,([0]=(((_Reserved1=??,VType=??)))),'')
OutputDebugStringFmt('Attempting to uninstall hook at %p',([0]=(((_Reserved1=140718007382672,VType=5)))))
UninstallHook($00007ffb76d7f290,??)
HookedNtQueryVirtualMemory(18446744073709551615,$0000027deba50000,MemoryRegionInformation,$000000f1ab71dfd8,48,nil)
HookedNtQueryVirtualMemory(18446744073709551615,$0000027deba50000,MemoryRegionInformation,$000000f1ab71dfd8,48,nil)

function UninstallHook(
  const ATargetFunc: Pointer;   // Address of the hooked function.
  const AOrigBytes: TBytes      // The original bytes saved during InstallHook.
): Boolean;
var
  LOldProtect: DWORD;           // Stores original memory protection flags.
begin
  Result := False; // Assume failure.

  // Validate input pointer and original bytes length.
  if (ATargetFunc = nil) or (Length(AOrigBytes) <> HOOK_SIZE) then
  begin
    OutputDebugStringFmt('UninstallHook Error: TargetFunc (%p) is nil or OrigBytes length mismatch (%d vs %d).', [ATargetFunc, Length(AOrigBytes), HOOK_SIZE]);
    Exit;
  end;

  OutputDebugStringFmt('Attempting to uninstall hook at %p', [ATargetFunc]);

  // 1. Make the target function's memory writable and executable.
  if VirtualProtect(ATargetFunc, HOOK_SIZE, PAGE_EXECUTE_READWRITE, LOldProtect) then
  try
    // 2. Write the saved original bytes back to the target function's entry point.
    Move(AOrigBytes[0], ATargetFunc^, HOOK_SIZE);

    // 3. Flush the CPU's instruction cache for the modified memory range.
    FlushInstructionCache(GetCurrentProcess, ATargetFunc, HOOK_SIZE);

    Result := True; // Hook removal successful.
    OutputDebugStringFmt('Hook uninstalled successfully at %p', [ATargetFunc]);
  finally
    // 4. Restore the original memory protection flags.
    VirtualProtect(ATargetFunc, HOOK_SIZE, LOldProtect, LOldProtect);
  end
  else
  begin
    // VirtualProtect failed. Log error.
    OutputDebugStringFmt('UninstallHook Error: VirtualProtect PAGE_EXECUTE_READWRITE failed for %p. Error: %d', [ATargetFunc, GetLastError]);
  end;
end;

Best Regards.

[jarroddavis68]

Hmm. I'm not sure. Have use it with FastMM before? If you have, then what did you change in your main code from when it did work?

[hafedh-trimeche]

unit uMemory;
{$I ReleaseDebug.inc}
{$IF Defined(DEBUG)}
{$DEFINE FastMM}
{$IFEND}
{$IF Defined(FastMM)}
{$R FastMM}
{$ELSE}
{$R MemoryManager}
{$IFEND}
{
  https://github.com/microsoft/mimalloc
  CMake: Disable  MI_WIN_REDIRECT
  mimalloc.dll
  ------------------------------------------------------------------
  pacman -S mingw-w64-clang-x86_64-mimalloc
  libmimalloc.dll

  cd /d/DevStudio/mimalloc/src
  mkdir -p $(gcc -dumpmachine) ; gcc -w -I./include -I../include -shared -O3 -s -DNDEBUG -static -o $(gcc -dumpmachine)/libmimalloc.dll static.c
}
interface
uses
  {$IF Defined(FastMM)}
  FastMM5,
  {$ELSE}
  uMemLibrary,
  {$IFEND}
  uBootstrap,uEnvironment,uResource,uWinLog,
  Classes,Windows,SysUtils;
var
  MemoryManagerIndex : Integer = {$IF Defined(FastMM)}1{$ELSE}2{$IFEND};

implementation
uses
  {$IF Defined(FastMM)}
  IOUtils,
  uHash,
  {$IFEND}
  Math;
var
{$IF Defined(FastMM)}
  FullDebugModeLibrary : string;
{$IFEND}
  EventLogFilename     : string;
type
  MemoryException = Exception;

  THeader=
  record
    Prefix : Word;
    Size   : NativeInt;
    Suffix : Word;
  end;
const
  HeaderSize   : Integer = SizeOf(THeader);
  MemoryPrefix : Word = $E721;
  MemorySuffix : Word = $127E;
type
  TManager=
  record
    LibName    : string;
    GetMem     ,
    FreeMem    ,
    ReallocMem : string;
  end;
const
  (*
    pacman -S mingw-w64-clang-x86_64-mimalloc
  *)
  Managers : array[1..4] of TManager =
  (
  (LibName:'FastMM'               ; GetMem:'GetMem'          ; FreeMem:'FreeMem'       ; ReallocMem:'ReallocMem'),
  (LibName:'tcmalloc_minimal.dll' ; GetMem:'tc_malloc'       ; FreeMem:'tc_free'       ; ReallocMem:'tc_realloc'),
  (LibName:'libmimalloc.dll'      ; GetMem:'mi_malloc'       ; FreeMem:'mi_free'       ; ReallocMem:'mi_realloc'),
  (LibName:'tbbmalloc.dll'        ; GetMem:'scalable_malloc' ; FreeMem:'scalable_free' ; ReallocMem:'scalable_realloc')
  );
var
  OldMemoryManager : TMemoryManagerEx;
var
  xmalloc  : function(Size:size_t):Pointer;cdecl=nil;
  xfree    : function(P:Pointer):size_t;cdecl=nil;
  xrealloc : function(P:Pointer;Size:size_t):Pointer;cdecl=nil;

function IsPrefixed(P:Pointer;out Header:THeader):Boolean;
begin
  if MemoryManagerIndex=1 then Exit(False);
  if P<>nil then
  begin
    Header := THeader(Pointer(PByte(P)-HeaderSize)^);
    Result := (Header.Prefix=MemoryPrefix) and (Header.Suffix=MemorySuffix);
  end
  else Result := False;
end;

function NewAllocMem(Size:NativeInt):Pointer;
begin
  if Size<=0 then Exit(nil);
  if MemoryManagerIndex=1 then
  begin
    Result := OldMemoryManager.AllocMem(Size);
    FillChar(Result^,Size,0);
  end
  else
  begin
    Result := xmalloc(HeaderSize+Size);
    FillChar(Result^,HeaderSize+Size,0);
    THeader(Result^).Prefix := MemoryPrefix;
    THeader(Result^).Size   := Size;
    THeader(Result^).Suffix := MemorySuffix;
    Inc(PByte(Result),HeaderSize);
  end;
end;

function NewFreeMem(P:Pointer):Integer;
var
  Header : THeader;
begin
  Result := 0;
  if P=nil then Exit;
  if IsPrefixed(P,Header) then
  begin
    Dec(PByte(P),HeaderSize);
    FillChar(P^,HeaderSize+Header.Size,0);
    if MemoryManagerIndex=1 then Result := OldMemoryManager.FreeMem(P)
                            else xfree(P);
  end
  else Result := OldMemoryManager.FreeMem(P);
end;

function NewReallocMem(P:Pointer;Size:NativeInt):Pointer;
var
  Header : THeader;
  Delta  : Integer;
begin
  if P=nil then
  begin
    Result := NewAllocMem(Size);
    Exit;
  end;
  if Size=0 then
  begin
    Result := nil;
    NewFreeMem(P);
    Exit;
  end;
  if IsPrefixed(P,Header) then
  begin
    if Header.Size=Size then
    begin
      Result := P;
      Exit;
    end;
    Delta := Header.Size-Size;
    Dec(PByte(P),HeaderSize);
    if Delta>0 then FillChar(Pointer(PByte(P)+HeaderSize+Size)^,Delta,0);
    if MemoryManagerIndex=1 then Result := OldMemoryManager.ReallocMem(P,Size+HeaderSize)
                            else Result := xrealloc(P,Size+HeaderSize);
    if Delta<0 then FillChar(Pointer(PByte(Result)+HeaderSize+Header.Size)^,-Delta,0);
    THeader(Result^).Prefix := MemoryPrefix;
    THeader(Result^).Size   := Size;
    THeader(Result^).Suffix := MemorySuffix;
    Inc(PByte(Result),HeaderSize);
  end
  else Result := OldMemoryManager.ReallocMem(P,Size);
end;

function NewRegisterMemoryLeak(P:Pointer):Boolean;
begin
  Result := OldMemoryManager.RegisterExpectedMemoryLeak(P);
end;

function NewUnregisterMemoryLeak(P:Pointer):Boolean;
begin
  Result := OldMemoryManager.UnregisterExpectedMemoryLeak(P);
end;

const
  NewMemoryManager : TMemoryManagerEx =
  (
    GetMem                       : NewAllocMem;
    FreeMem                      : NewFreeMem;
    ReallocMem                   : NewReallocMem;
    AllocMem                     : NewAllocMem;
    RegisterExpectedMemoryLeak   : NewRegisterMemoryLeak;
    UnregisterExpectedMemoryLeak : NewUnregisterMemoryLeak;
  );

procedure InitMemoryManager;
{$IF not Defined(FastMM)}
var
  Handle : THandle;
  Bytes  : TBytes;
{$IFEND}
begin
  MemoryManagerLib := Managers[MemoryManagerIndex].LibName;
  EventLogFilename := ChangeFileExt(ParamStr(0),'.leak');
  {$IF Defined(FastMM)}
  FastMM_LogToFileEvents         := FastMM_LogToFileEvents+[mmetUnexpectedMemoryLeakDetail,mmetUnexpectedMemoryLeakSummary];
  FastMM_MessageBoxEvents        := [];
  FullDebugModeLibrary           := ApplicationMainPath+CFastMM_DefaultDebugSupportLibraryName;
  FastMM_DebugSupportLibraryName := PChar(FullDebugModeLibrary);
  FastMM_SetEventLogFilename(PChar(EventLogFilename));
  FastMM_DeleteEventLogFile;
  if FastMM_LoadDebugSupportLibrary then FastMM_EnterDebugMode;
  {$ELSE}
  DeleteFile(EventLogFilename);
  if MemoryManagerIndex>1 then
  begin
    Bytes  := ExtractMemoryResource(MemoryManagerLib);
    Handle := mmLoad(Bytes);
    if Handle=INVALID_HANDLE_VALUE then raise MemoryException.Create('Module Load ['+MemoryManagerLib+']');
    try
      @xmalloc  := mmProc(Handle,Managers[MemoryManagerIndex].GetMem);
      @xfree    := mmProc(Handle,Managers[MemoryManagerIndex].FreeMem);
      @xrealloc := mmProc(Handle,Managers[MemoryManagerIndex].ReallocMem);
    except
      on E:Exception do raise MemoryException.Create('GetProcAddress ['+MemoryManagerLib+'] '+E.Message+#13#10+E.StackTrace);
    end;
  end;
  {$IFEND}
  if MemoryManagerIndex>1 then SetMemoryManager(NewMemoryManager);
end;

procedure InitUnit;
begin
  IsMultiThread := True;
  {$IF Defined(madExcept)}
  Exit;
  {$IFEND}
  ReportMemoryLeaksOnShutdown := False;
  GetMemoryManager(OldMemoryManager);
  if IsRuntime then InitMemoryManager;
end;

procedure FreeUnit;
begin
  {$IF Defined(FastMM)}
  if IsRuntime then FastMM_ExitDebugMode;
  {$IFEND}
end;

type
  DummyClass = class
  end;
var
  Bootstrap : TBootstrap;
initialization
  Bootstrap.Init(InitUnit,DummyClass);
finalization
  Bootstrap.Free(FreeUnit);
end.

[hafedh-trimeche]

function mmLoad(Buffer:TBytes):THandle;
begin
  ModuleList.LockList;

  {$IF Declared(PeLoader)}
  Result := PeLoader.mmLoad(Buffer);
  {$IFEND}

  {$IF Declared(StdApp.DllLoader)}
  Result := StdApp.DllLoader.LoadLibrary(Buffer,Length(Buffer));
  {$IFEND}

  ModuleList.UnlockList;
end;

function mmProc(Handle:THandle;Name:string):Pointer;
begin
  ModuleList.LockList;

  {$IF Declared(PeLoader)}
  Result := PeLoader.mmProc(Handle,Name);
  {$IFEND}

  {$IF Declared(StdApp.DllLoader)}
  Result := GetProcAddress(Handle,PChar(Name));
  {$IFEND}

  ModuleList.UnlockList;

  if Result=nil then RegisterEventLog('mmProc: '+Name,LogError,LogSystem);
end;

function mmFree(Handle:THandle):Boolean;
begin
  ModuleList.LockList;

  {$IF Declared(PeLoader)}
  Result := PeLoader.mmFree(Handle);
  {$IFEND}

  {$IF Declared(StdApp.DllLoader)}
  Result := FreeLibrary(Handle);
  {$IFEND}

  ModuleList.UnlockList;
end;

[jarroddavis68]

ok, once again, you have given me any information of what you are trying to do. I see this code but its out of context. How do you expect me to help you at all when I have ZERO idea what you are trying to do, the context of how the dll loader is working for your project.

If you are trying to mix things up like last time, it's not going to work. First does the dll loader work properly in the examples that come with the project? It maybe a case where the external FastMM not work. I've only tested it with the FastMM implementation that come stock with Delphi.

The first thing you must establish is if the dll loader will work with your version of Delphi without doing what you are doing with this code. It looks like you are once again, mixing the way it is designed to work.