Skip to content

internal/itoa package unconditionally used in tlssock.go #57

@darealprism

Description

@darealprism

tlssock.go incorrectly uses the internal/itoa package, regardless of go version.

net/tlssock.go

Lines 11 to 17 in 1026408

import (
"internal/itoa"
"io"
"net/netip"
"strconv"
"time"
)

The package is then used here:

net/tlssock.go

Line 31 in 1026408

return JoinHostPort(a.Host, itoa.Itoa(a.Port))

There is already an implementation based on go version in itoa_go126.go and itoa_pre126.go, so this may just be a silly mistake.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions