From e0220b20313dc1c08b3be36f184f009c5fa360f5 Mon Sep 17 00:00:00 2001 From: "Panek, Tomasz" Date: Tue, 21 Oct 2025 22:11:14 +0200 Subject: [PATCH 1/4] returning non empty session state --- core/pom.xml | 2 ++ .../adk/sessions/VertexAiSessionService.java | 2 +- pom.xml | 33 +++++-------------- 3 files changed, 12 insertions(+), 25 deletions(-) diff --git a/core/pom.xml b/core/pom.xml index 809ee0039..d10b0a3cb 100644 --- a/core/pom.xml +++ b/core/pom.xml @@ -23,6 +23,7 @@ 0.3.1-SNAPSHOT + com.sabre.adk google-adk Agent Development Kit Agent Development Kit: an open-source, code-first toolkit designed to simplify building, evaluating, and deploying advanced AI agents anywhere. @@ -196,6 +197,7 @@ maven-compiler-plugin + diff --git a/core/src/main/java/com/google/adk/sessions/VertexAiSessionService.java b/core/src/main/java/com/google/adk/sessions/VertexAiSessionService.java index 0321ef281..47c74abc7 100644 --- a/core/src/main/java/com/google/adk/sessions/VertexAiSessionService.java +++ b/core/src/main/java/com/google/adk/sessions/VertexAiSessionService.java @@ -138,7 +138,7 @@ private ListSessionsResponse parseListSessionsResponse( Session.builder(sessionId) .appName(appName) .userId(userId) - .state(new ConcurrentHashMap<>()) + .state(new ConcurrentHashMap<>((Map) apiSession.get("sessionState"))) .lastUpdateTime(updateTimestamp) .build(); sessions.add(session); diff --git a/pom.xml b/pom.xml index d174f6ad8..d9c384066 100644 --- a/pom.xml +++ b/pom.xml @@ -383,27 +383,11 @@ - - org.sonatype.central - central-publishing-maven-plugin - 0.8.0 - true - - central - - + - - org.sonatype.central - central-publishing-maven-plugin - 0.8.0 - true - - central - - + com.spotify.fmt fmt-maven-plugin @@ -537,14 +521,15 @@ - central - Maven Central Repository - https://central.sonatype.com/api/v1/publisher + sabre-repo-stages + https://repository.sabre-gcp.com/repository/maven-staging/ + default - central - Maven Central Repository Snapshots - https://central.sonatype.com/repository/maven-snapshots/ + gcp.repository.sabre.com-snapshots + https://repository.sabre-gcp.com/repository/maven-snapshots/ + default + true From acd7d5cd4ac6fdeb696adc1ad2c55755befb1e3d Mon Sep 17 00:00:00 2001 From: "Panek, Tomasz" Date: Tue, 21 Oct 2025 22:49:14 +0200 Subject: [PATCH 2/4] handling null sessionState in map --- .../com/google/adk/sessions/VertexAiSessionService.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/core/src/main/java/com/google/adk/sessions/VertexAiSessionService.java b/core/src/main/java/com/google/adk/sessions/VertexAiSessionService.java index 47c74abc7..b4b00d66d 100644 --- a/core/src/main/java/com/google/adk/sessions/VertexAiSessionService.java +++ b/core/src/main/java/com/google/adk/sessions/VertexAiSessionService.java @@ -122,6 +122,7 @@ public Single listSessions(String appName, String userId) .defaultIfEmpty(ListSessionsResponse.builder().build()); } + @SuppressWarnings("unchecked") private ListSessionsResponse parseListSessionsResponse( JsonNode listSessionsResponseMap, String appName, String userId) { List> apiSessions = @@ -138,7 +139,11 @@ private ListSessionsResponse parseListSessionsResponse( Session.builder(sessionId) .appName(appName) .userId(userId) - .state(new ConcurrentHashMap<>((Map) apiSession.get("sessionState"))) + .state( + apiSession.get("sessionState") == null + ? new ConcurrentHashMap<>() + : new ConcurrentHashMap<>( + (Map) apiSession.get("sessionState"))) .lastUpdateTime(updateTimestamp) .build(); sessions.add(session); From 354f92f261ecc2248a70a068efbc0024336bb648 Mon Sep 17 00:00:00 2001 From: "Panek, Tomasz" Date: Tue, 21 Oct 2025 23:48:43 +0200 Subject: [PATCH 3/4] refactoring --- .../com/google/adk/sessions/VertexAiSessionService.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/core/src/main/java/com/google/adk/sessions/VertexAiSessionService.java b/core/src/main/java/com/google/adk/sessions/VertexAiSessionService.java index b4b00d66d..7878daf22 100644 --- a/core/src/main/java/com/google/adk/sessions/VertexAiSessionService.java +++ b/core/src/main/java/com/google/adk/sessions/VertexAiSessionService.java @@ -122,7 +122,6 @@ public Single listSessions(String appName, String userId) .defaultIfEmpty(ListSessionsResponse.builder().build()); } - @SuppressWarnings("unchecked") private ListSessionsResponse parseListSessionsResponse( JsonNode listSessionsResponseMap, String appName, String userId) { List> apiSessions = @@ -142,8 +141,9 @@ private ListSessionsResponse parseListSessionsResponse( .state( apiSession.get("sessionState") == null ? new ConcurrentHashMap<>() - : new ConcurrentHashMap<>( - (Map) apiSession.get("sessionState"))) + : objectMapper.convertValue( + apiSession.get("sessionState"), + new TypeReference>() {})) .lastUpdateTime(updateTimestamp) .build(); sessions.add(session); From 1aa3d817d5b955eb0ec2aee5378245d107e582f3 Mon Sep 17 00:00:00 2001 From: "Panek, Tomasz" Date: Wed, 22 Oct 2025 19:56:13 +0200 Subject: [PATCH 4/4] changing group id for parent --- core/pom.xml | 2 +- pom.xml | 9 +-------- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/core/pom.xml b/core/pom.xml index d10b0a3cb..8865695f8 100644 --- a/core/pom.xml +++ b/core/pom.xml @@ -18,7 +18,7 @@ 4.0.0 - com.google.adk + com.sabre.adk google-adk-parent 0.3.1-SNAPSHOT diff --git a/pom.xml b/pom.xml index d9c384066..91c595b81 100644 --- a/pom.xml +++ b/pom.xml @@ -15,7 +15,7 @@ 4.0.0 - com.google.adk + com.sabre.adk google-adk-parent 0.3.1-SNAPSHOT pom @@ -26,13 +26,6 @@ core - dev - maven_plugin - contrib/langchain4j - contrib/samples - tutorials/city-time-weather - a2a - a2a/webservice