From 24290d2a40ae54270a129bf57f3691eff323edf2 Mon Sep 17 00:00:00 2001 From: Goutham Annem Date: Sat, 18 Jul 2026 19:09:53 -0700 Subject: [PATCH] fix(qdrant): remove upload_records method removed in qdrant-client v1.16.1 The upload_records method was removed from QdrantClient and AsyncQdrantClient in qdrant-client v1.16.1. The hasattr guard in _instrument/_uninstrument already prevents the AttributeError at patching time, but the dead code in wrapper.py and the stale entries in the JSON methods files should also be cleaned up. Fixes #3492 Signed-off-by: Goutham Annem --- .../instrumentation/qdrant/async_qdrant_client_methods.json | 5 ----- .../instrumentation/qdrant/qdrant_client_methods.json | 5 ----- .../opentelemetry/instrumentation/qdrant/wrapper.py | 2 -- 3 files changed, 12 deletions(-) diff --git a/packages/opentelemetry-instrumentation-qdrant/opentelemetry/instrumentation/qdrant/async_qdrant_client_methods.json b/packages/opentelemetry-instrumentation-qdrant/opentelemetry/instrumentation/qdrant/async_qdrant_client_methods.json index ec161a5ee6..f85e8c8728 100644 --- a/packages/opentelemetry-instrumentation-qdrant/opentelemetry/instrumentation/qdrant/async_qdrant_client_methods.json +++ b/packages/opentelemetry-instrumentation-qdrant/opentelemetry/instrumentation/qdrant/async_qdrant_client_methods.json @@ -14,11 +14,6 @@ "method": "upload_points", "span_name": "qdrant.upload_points" }, - { - "object": "AsyncQdrantClient", - "method": "upload_records", - "span_name": "qdrant.upload_records" - }, { "object": "AsyncQdrantClient", "method": "upload_collection", diff --git a/packages/opentelemetry-instrumentation-qdrant/opentelemetry/instrumentation/qdrant/qdrant_client_methods.json b/packages/opentelemetry-instrumentation-qdrant/opentelemetry/instrumentation/qdrant/qdrant_client_methods.json index 9f8f94a692..aa555b6b35 100644 --- a/packages/opentelemetry-instrumentation-qdrant/opentelemetry/instrumentation/qdrant/qdrant_client_methods.json +++ b/packages/opentelemetry-instrumentation-qdrant/opentelemetry/instrumentation/qdrant/qdrant_client_methods.json @@ -14,11 +14,6 @@ "method": "upload_points", "span_name": "qdrant.upload_points" }, - { - "object": "QdrantClient", - "method": "upload_records", - "span_name": "qdrant.upload_records" - }, { "object": "QdrantClient", "method": "upload_collection", diff --git a/packages/opentelemetry-instrumentation-qdrant/opentelemetry/instrumentation/qdrant/wrapper.py b/packages/opentelemetry-instrumentation-qdrant/opentelemetry/instrumentation/qdrant/wrapper.py index bf35d9529f..4819dde48d 100644 --- a/packages/opentelemetry-instrumentation-qdrant/opentelemetry/instrumentation/qdrant/wrapper.py +++ b/packages/opentelemetry-instrumentation-qdrant/opentelemetry/instrumentation/qdrant/wrapper.py @@ -53,8 +53,6 @@ def _wrap(tracer, to_wrap, wrapped, instance, args, kwargs): _set_upload_attributes(span, args, kwargs, method, "documents") elif method == "upload_points": _set_upload_attributes(span, args, kwargs, method, "points") - elif method == "upload_records": - _set_upload_attributes(span, args, kwargs, method, "records") elif method == "upload_collection": _set_upload_attributes(span, args, kwargs, method, "vectors") elif method in [