lint

Author: carderne

.oxlintrc.json

@@ -9,19 +9,37 @@
     "**/seedCloud.ts",
     "**/populate.js"
   ],
+  // All rules below are disabled because they currently fire on the existing
+  // codebase (1748 warnings across these 20 rules as of this commit). Disabled
+  // to keep the lint baseline green; re-enable and fix incrementally.
   "rules": {
-    "consistent-type-imports": [
-      "warn",
-      {
-        "prefer": "type-imports",
-        "disallowTypeAnnotations": true,
-        "fixStyle": "inline-type-imports"
-      }
-    ],
-    "import/no-duplicates": ["warn", { "prefer-inline": true }],
-    // Disabled for now: oxlint treats any use*()/use() call as a React hook,
-    // producing false positives in async/test code (testcontainers, cli-v3 e2e).
-    // Re-enable (ideally scoped to React packages) once those are addressed.
+    // eslint
+    "no-unused-vars": "off",
+    "no-unused-expressions": "off",
+    "no-control-regex": "off",
+    "no-empty-pattern": "off",
+    "no-unused-private-class-members": "off",
+    "no-useless-catch": "off",
+    "no-unsafe-optional-chaining": "off",
+    "no-unreachable": "off",
+    "require-yield": "off",
+    "no-async-promise-executor": "off",
+    "no-unsafe-finally": "off",
+    // typescript
+    "typescript/consistent-type-imports": "off",
+    "typescript/no-this-alias": "off",
+    "typescript/no-non-null-asserted-optional-chain": "off",
+    "typescript/no-unnecessary-parameter-property-assignment": "off",
+    // import
+    "import/no-duplicates": "off",
+    "import/namespace": "off",
+    // react
+    "react/jsx-key": "off",
+    "react/no-children-prop": "off",
+    // react-hooks
+    "react-hooks/exhaustive-deps": "off",
+    // oxlint treats any use*()/use() call as a React hook, producing false
+    // positives in async/test code (testcontainers, cli-v3 e2e).
     "react-hooks/rules-of-hooks": "off"
   }
 }

apps/coordinator/src/index.ts

@@ -7,7 +7,7 @@ import {
   PlatformToCoordinatorMessages,
   ProdWorkerSocketData,
   ProdWorkerToCoordinatorMessages,
-  WaitReason,
+  type WaitReason,
 } from "@trigger.dev/core/v3";
 import { ZodNamespace } from "@trigger.dev/core/v3/zodNamespace";
 import { ZodSocketConnection } from "@trigger.dev/core/v3/zodSocket";

apps/docker-provider/src/index.ts

@@ -1,16 +1,16 @@
 import { $, type ExecaChildProcess, execa } from "execa";
 import {
   ProviderShell,
-  TaskOperations,
-  TaskOperationsCreateOptions,
-  TaskOperationsIndexOptions,
-  TaskOperationsRestoreOptions,
+  type TaskOperations,
+  type TaskOperationsCreateOptions,
+  type TaskOperationsIndexOptions,
+  type TaskOperationsRestoreOptions,
 } from "@trigger.dev/core/v3/apps";
 import { SimpleLogger } from "@trigger.dev/core/v3/apps";
 import { isExecaChildProcess } from "@trigger.dev/core/v3/apps";
 import { testDockerCheckpoint } from "@trigger.dev/core/v3/serverOnly";
 import { setTimeout } from "node:timers/promises";
-import { PostStartCauses, PreStopCauses } from "@trigger.dev/core/v3";
+import { type PostStartCauses, type PreStopCauses } from "@trigger.dev/core/v3";
 
 const MACHINE_NAME = process.env.MACHINE_NAME || "local";
 const COORDINATOR_PORT = process.env.COORDINATOR_PORT || 8020;

apps/kubernetes-provider/src/index.ts

@@ -1,18 +1,18 @@
 import * as k8s from "@kubernetes/client-node";
 import {
-  EnvironmentType,
-  MachinePreset,
-  PostStartCauses,
-  PreStopCauses,
+  type EnvironmentType,
+  type MachinePreset,
+  type PostStartCauses,
+  type PreStopCauses,
 } from "@trigger.dev/core/v3";
 import {
   ProviderShell,
   SimpleLogger,
-  TaskOperations,
-  TaskOperationsCreateOptions,
-  TaskOperationsIndexOptions,
-  TaskOperationsPrePullDeploymentOptions,
-  TaskOperationsRestoreOptions,
+  type TaskOperations,
+  type TaskOperationsCreateOptions,
+  type TaskOperationsIndexOptions,
+  type TaskOperationsPrePullDeploymentOptions,
+  type TaskOperationsRestoreOptions,
 } from "@trigger.dev/core/v3/apps";
 import { PodCleaner } from "./podCleaner";
 import { TaskMonitor } from "./taskMonitor";

apps/supervisor/src/clients/kubernetes.ts

@@ -1,7 +1,7 @@
 import * as k8s from "@kubernetes/client-node";
-import { Informer } from "@kubernetes/client-node";
-import { ListPromise } from "@kubernetes/client-node";
-import { KubernetesObject } from "@kubernetes/client-node";
+import { type Informer } from "@kubernetes/client-node";
+import { type ListPromise } from "@kubernetes/client-node";
+import { type KubernetesObject } from "@kubernetes/client-node";
 import { assertExhaustive } from "@trigger.dev/core/utils";
 import { SimpleStructuredLogger } from "@trigger.dev/core/v3/utils/structuredLogger";
 

apps/supervisor/src/services/failedPodHandler.ts

@@ -1,8 +1,8 @@
 import { LogLevel, SimpleStructuredLogger } from "@trigger.dev/core/v3/utils/structuredLogger";
-import { K8sApi } from "../clients/kubernetes.js";
+import { type K8sApi } from "../clients/kubernetes.js";
 import { createK8sApi } from "../clients/kubernetes.js";
-import { Informer, V1Pod } from "@kubernetes/client-node";
-import { Counter, Registry, Histogram } from "prom-client";
+import { type Informer, type V1Pod } from "@kubernetes/client-node";
+import { Counter, type Registry, Histogram } from "prom-client";
 import { register } from "../metrics.js";
 import { setTimeout } from "timers/promises";
 

apps/supervisor/src/services/podCleaner.ts

@@ -1,8 +1,8 @@
 import { SimpleStructuredLogger } from "@trigger.dev/core/v3/utils/structuredLogger";
-import { K8sApi } from "../clients/kubernetes.js";
+import { type K8sApi } from "../clients/kubernetes.js";
 import { createK8sApi } from "../clients/kubernetes.js";
 import { IntervalService } from "@trigger.dev/core/v3";
-import { Counter, Gauge, Registry } from "prom-client";
+import { Counter, Gauge, type Registry } from "prom-client";
 import { register } from "../metrics.js";
 
 export type PodCleanerOptions = {

apps/supervisor/src/workloadManager/ecrAuth.ts

@@ -1,7 +1,7 @@
 import { ECRClient, GetAuthorizationTokenCommand } from "@aws-sdk/client-ecr";
 import { SimpleStructuredLogger } from "@trigger.dev/core/v3/utils/structuredLogger";
 import { tryCatch } from "@trigger.dev/core";
-import Docker from "dockerode";
+import type Docker from "dockerode";
 
 interface ECRTokenCache {
   token: string;

apps/supervisor/src/workloadServer/index.ts

@@ -16,7 +16,7 @@ import {
   type WorkloadRunAttemptCompleteResponseBody,
   WorkloadRunAttemptStartRequestBody,
   type WorkloadRunAttemptStartResponseBody,
-  WorkloadRunSnapshotsSinceResponseBody,
+  type WorkloadRunSnapshotsSinceResponseBody,
   type WorkloadServerToClientEvents,
   type WorkloadSuspendRunResponseBody,
 } from "@trigger.dev/core/v3/workers";

apps/webapp/app/components/admin/debugRun.tsx

@@ -4,7 +4,7 @@ import { Button } from "../primitives/Buttons";
 import { Dialog, DialogContent, DialogHeader, DialogTrigger } from "../primitives/Dialog";
 import { Cog6ToothIcon } from "@heroicons/react/20/solid";
 import { type loader } from "~/routes/resources.taskruns.$runParam.debug";
-import { UseDataFunctionReturn, useTypedFetcher } from "remix-typedjson";
+import { type UseDataFunctionReturn, useTypedFetcher } from "remix-typedjson";
 import { useEffect } from "react";
 import { Spinner } from "../primitives/Spinner";
 import * as Property from "~/components/primitives/PropertyTable";