fix(webapp): inject runStore into UpdateMetadataService

The service statically imported the db.server-backed runStore singleton,
which dragged the Prisma client into otherwise-light test module graphs and
opened an eager connection to DATABASE_URL on import. The metadata service
test then threw an unhandled connection error whenever no database was
reachable at the configured address.

Make runStore a required constructor option, pass the singleton at the
production construction site, and inject a testcontainer-backed store in the
tests.

Author: d-cs

apps/webapp/app/services/metadata/updateMetadata.server.ts

@@ -14,7 +14,6 @@ import { type RuntimeFiber } from "effect/Fiber";
 import { setTimeout } from "timers/promises";
 import { Logger, LogLevel } from "@trigger.dev/core/logger";
 import type { RunStore } from "@internal/run-store";
-import { runStore as defaultRunStore } from "~/v3/runStore.server";
 
 const RUN_UPDATABLE_WINDOW_MS = 60 * 60 * 1000; // 1 hour
 
@@ -26,7 +25,7 @@ type BufferedRunMetadataChangeOperation = {
 
 export type UpdateMetadataServiceOptions = {
   prisma: PrismaClientOrTransaction;
-  runStore?: RunStore;
+  runStore: RunStore;
   flushIntervalMs?: number;
   flushEnabled?: boolean;
   flushLoggingEnabled?: boolean;
@@ -61,7 +60,7 @@ export class UpdateMetadataService {
 
   constructor(private readonly options: UpdateMetadataServiceOptions) {
     this._prisma = options.prisma;
-    this._runStore = options.runStore ?? defaultRunStore;
+    this._runStore = options.runStore;
     this.flushIntervalMs = options.flushIntervalMs ?? 5000;
     this.flushEnabled = options.flushEnabled ?? true;
     this.flushLoggingEnabled = options.flushLoggingEnabled ?? true;

apps/webapp/app/services/metadata/updateMetadataInstance.server.ts

@@ -2,13 +2,15 @@ import { singleton } from "~/utils/singleton";
 import { env } from "~/env.server";
 import { UpdateMetadataService } from "./updateMetadata.server";
 import { prisma } from "~/db.server";
+import { runStore } from "~/v3/runStore.server";
 import { publishChangeRecord } from "~/services/realtime/runChangeNotifierInstance.server";
 
 export const updateMetadataService = singleton(
   "update-metadata-service",
   () =>
     new UpdateMetadataService({
       prisma,
+      runStore,
       flushIntervalMs: env.BATCH_METADATA_OPERATIONS_FLUSH_INTERVAL_MS,
       flushEnabled: env.BATCH_METADATA_OPERATIONS_FLUSH_ENABLED === "1",
       flushLoggingEnabled: env.BATCH_METADATA_OPERATIONS_FLUSH_LOGGING_ENABLED === "1",

apps/webapp/test/updateMetadata.test.ts

@@ -2,6 +2,7 @@ import { containerTest } from "@internal/testcontainers";
 import { parsePacket } from "@trigger.dev/core/v3";
 import { setTimeout } from "timers/promises";
 import { describe } from "vitest";
+import { PostgresRunStore } from "@internal/run-store";
 import { UpdateMetadataService } from "~/services/metadata/updateMetadata.server";
 import { MetadataTooLargeError } from "~/utils/packets";
 
@@ -13,6 +14,7 @@ describe("UpdateMetadataService.call", () => {
     async ({ prisma, redisOptions }) => {
       const service = new UpdateMetadataService({
         prisma,
+        runStore: new PostgresRunStore({ prisma, readOnlyPrisma: prisma }),
         flushIntervalMs: 100,
         flushEnabled: true,
         flushLoggingEnabled: true,
@@ -112,6 +114,7 @@ describe("UpdateMetadataService.call", () => {
     async ({ prisma, redisOptions }) => {
       const service = new UpdateMetadataService({
         prisma,
+        runStore: new PostgresRunStore({ prisma, readOnlyPrisma: prisma }),
         flushIntervalMs: 100,
         flushEnabled: true,
         flushLoggingEnabled: true,
@@ -280,6 +283,7 @@ describe("UpdateMetadataService.call", () => {
     async ({ prisma, redisOptions }) => {
       const service = new UpdateMetadataService({
         prisma,
+        runStore: new PostgresRunStore({ prisma, readOnlyPrisma: prisma }),
         flushIntervalMs: 100,
         flushEnabled: true,
         flushLoggingEnabled: true,
@@ -395,6 +399,7 @@ describe("UpdateMetadataService.call", () => {
     async ({ prisma, redisOptions }) => {
       const service = new UpdateMetadataService({
         prisma,
+        runStore: new PostgresRunStore({ prisma, readOnlyPrisma: prisma }),
         flushIntervalMs: 100,
         flushEnabled: true,
         flushLoggingEnabled: true,
@@ -587,6 +592,7 @@ describe("UpdateMetadataService.call", () => {
     async ({ prisma, redisOptions }) => {
       const service = new UpdateMetadataService({
         prisma,
+        runStore: new PostgresRunStore({ prisma, readOnlyPrisma: prisma }),
         flushIntervalMs: 100,
         flushEnabled: true,
         flushLoggingEnabled: true,
@@ -785,6 +791,7 @@ describe("UpdateMetadataService.call", () => {
 
       const service = new UpdateMetadataService({
         prisma,
+        runStore: new PostgresRunStore({ prisma, readOnlyPrisma: prisma }),
         flushIntervalMs: 100000, // Very long interval so we can control flushing
         flushEnabled: true,
         flushLoggingEnabled: true,
@@ -893,6 +900,7 @@ describe("UpdateMetadataService.call", () => {
 
       const service = new UpdateMetadataService({
         prisma,
+        runStore: new PostgresRunStore({ prisma, readOnlyPrisma: prisma }),
         flushIntervalMs: 100,
         flushEnabled: true,
         flushLoggingEnabled: true,
@@ -1004,6 +1012,7 @@ describe("UpdateMetadataService.call", () => {
     async ({ prisma, redisOptions }) => {
       const service = new UpdateMetadataService({
         prisma,
+        runStore: new PostgresRunStore({ prisma, readOnlyPrisma: prisma }),
         flushIntervalMs: 100000, // Very long interval so we can control flushing
         flushEnabled: true,
         flushLoggingEnabled: true,
@@ -1134,6 +1143,7 @@ describe("UpdateMetadataService.call", () => {
     async ({ prisma, redisOptions }) => {
       const service = new UpdateMetadataService({
         prisma,
+        runStore: new PostgresRunStore({ prisma, readOnlyPrisma: prisma }),
         flushIntervalMs: 100,
         flushEnabled: true,
         flushLoggingEnabled: true,
@@ -1209,6 +1219,7 @@ describe("UpdateMetadataService.call", () => {
     async ({ prisma, redisOptions }) => {
       const service = new UpdateMetadataService({
         prisma,
+        runStore: new PostgresRunStore({ prisma, readOnlyPrisma: prisma }),
         flushIntervalMs: 100,
         flushEnabled: true,
         flushLoggingEnabled: true,