fix(webapp): bound realtime publisher retries instead of disabling its offline queue

Author: ericallam

apps/webapp/app/redis.server.ts

@@ -11,9 +11,7 @@ export type RedisWithClusterOptions = {
   clusterMode?: boolean;
   clusterOptions?: Omit<ClusterOptions, "redisOptions">;
   keyPrefix?: string;
-  /** Reject commands immediately when the connection isn't ready instead of buffering them in memory (default: ioredis's `true`). */
-  enableOfflineQueue?: boolean;
-  /** Cap retries for an in-flight command before it rejects; `null` means unlimited (default: ioredis's default of 20). */
+  /** Cap retries for a command before it rejects; `null` means unlimited (default: ioredis's default of 20). */
   maxRetriesPerRequest?: number | null;
 };
 
@@ -41,9 +39,6 @@ export function createRedisClient(
 
     redis = new Redis.Cluster(nodes, {
       ...options.clusterOptions,
-      ...(options.enableOfflineQueue !== undefined
-        ? { enableOfflineQueue: options.enableOfflineQueue }
-        : {}),
       redisOptions: {
         connectionName,
         keyPrefix: options.keyPrefix,
@@ -82,9 +77,6 @@ export function createRedisClient(
       enableAutoPipelining: true,
       keyPrefix: options.keyPrefix,
       reconnectOnError: defaultReconnectOnError,
-      ...(options.enableOfflineQueue !== undefined
-        ? { enableOfflineQueue: options.enableOfflineQueue }
-        : {}),
       ...(options.maxRetriesPerRequest !== undefined
         ? { maxRetriesPerRequest: options.maxRetriesPerRequest }
         : {}),

apps/webapp/app/services/realtime/runChangeNotifier.server.ts

@@ -226,10 +226,10 @@ export class RunChangeNotifier {
   #ensurePublisher(): RedisClient {
     if (!this.#publisher) {
       // Publishes are fire-and-forget with a consumer-side backstop, so a dropped publish is
-      // latency-only. Fail fast rather than buffer commands in memory during a pub/sub outage.
+      // latency-only. Cap retries (vs ioredis's default 20) so a pub/sub outage rejects publishes
+      // after ~1 reconnect cycle instead of buffering them in memory across the fleet.
       this.#publisher = createRedisClient(`${this.#connectionName}:pub`, {
         ...this.options.redis,
-        enableOfflineQueue: false,
         maxRetriesPerRequest: 1,
       });
     }