chore: switch to oxfmt, oxlint - add ci checks

Author: carderne

.eslintignore

@@ -0,0 +1,73 @@
+name: "🎨 Format & Lint"
+
+on:
+  workflow_call:
+
+permissions:
+  contents: read
+
+jobs:
+  code-quality:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: ⬇️ Checkout repo
+        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        with:
+          fetch-depth: 0
+          persist-credentials: false
+
+      - name: ⎔ Setup pnpm
+        uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v5.0.0
+        with:
+          version: 10.33.2
+
+      - name: ⎔ Setup node
+        uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
+        with:
+          node-version: 20.20.2
+          cache: "pnpm"
+
+      - name: 📥 Download deps
+        run: pnpm install --frozen-lockfile
+
+      # Gate only on files this PR adds/modifies (ratchet) — the repo is not
+      # fully formatted/linted yet, so a whole-repo check would fail every PR.
+      - name: 🔍 Determine changed files
+        id: changes
+        env:
+          BASE_SHA: ${{ github.event.pull_request.base.sha }}
+        run: |
+          FILES=$(git diff --name-only --diff-filter=ACMR "$BASE_SHA"...HEAD -- \
+            '*.ts' '*.tsx' '*.js' '*.jsx' '*.mjs' '*.cjs')
+          echo "Changed code files:"
+          echo "${FILES:-<none>}"
+          {
+            echo "files<<EOF"
+            echo "$FILES"
+            echo "EOF"
+          } >> "$GITHUB_OUTPUT"
+          if [ -z "$FILES" ]; then
+            echo "has_files=false" >> "$GITHUB_OUTPUT"
+          else
+            echo "has_files=true" >> "$GITHUB_OUTPUT"
+          fi
+
+      # TODO enable format check for ALL code
+      - name: 💅 Check formatting
+        if: steps.changes.outputs.has_files == 'true'
+        env:
+          FILES: ${{ steps.changes.outputs.files }}
+        # Unquoted $FILES intentionally word-splits the newline-separated list
+        # into separate path args. Safe given the has_files guard above.
+        run: pnpm exec oxfmt --check $FILES
+
+      # TODO update this so lint failures fail CI
+      # Informational only — lint findings are surfaced in the logs but never
+      # fail the job. Only the formatting check above blocks the PR.
+      - name: 🔎 Lint (informational, non-blocking)
+        if: steps.changes.outputs.has_files == 'true'
+        continue-on-error: true
+        env:
+          FILES: ${{ steps.changes.outputs.files }}
+        run: pnpm exec oxlint $FILES

.github/workflows/code-quality.yml

@@ -102,6 +102,11 @@ jobs:
               - 'pnpm-workspace.yaml'
               - 'turbo.json'
 
+  code-quality:
+    needs: changes
+    if: needs.changes.outputs.code == 'true'
+    uses: ./.github/workflows/code-quality.yml
+
   typecheck:
     needs: changes
     if: needs.changes.outputs.code == 'true' || needs.changes.outputs.typecheck_self == 'true'
@@ -155,6 +160,7 @@ jobs:
     name: All PR Checks
     needs:
       - changes
+      - code-quality
       - typecheck
       - webapp
       - e2e-webapp

.github/workflows/pr_checks.yml

@@ -0,0 +1,25 @@
+{
+  "$schema": "./node_modules/oxfmt/configuration_schema.json",
+  "semi": true,
+  "singleQuote": false,
+  "jsxSingleQuote": false,
+  "trailingComma": "es5",
+  "bracketSpacing": true,
+  "bracketSameLine": false,
+  "printWidth": 100,
+  "tabWidth": 2,
+  "useTabs": false,
+  "sortPackageJson": false,
+  "ignorePatterns": [
+    "node_modules",
+    ".env",
+    ".env.local",
+    "pnpm-lock.yaml",
+    "tailwind.css",
+    ".babelrc.json",
+    "**/.react-email/",
+    "**/storybook-static/",
+    "**/.changeset/",
+    "**/dist/",
+  ]
+}

.oxfmtrc.json

@@ -0,0 +1,24 @@
+{
+  "$schema": "./node_modules/oxlint/configuration_schema.json",
+  "plugins": ["typescript", "import", "react"],
+  "ignorePatterns": [
+    "**/dist/**",
+    "**/build/**",
+    "**/*.d.ts",
+    "**/seed.js",
+    "**/seedCloud.ts",
+    "**/populate.js"
+  ],
+  "rules": {
+    "consistent-type-imports": [
+      "warn",
+      {
+        "prefer": "type-imports",
+        "disallowTypeAnnotations": true,
+        "fixStyle": "inline-type-imports"
+      }
+    ],
+    "import/no-duplicates": ["warn", { "prefer-inline": true }],
+    "react-hooks/rules-of-hooks": "error"
+  }
+}

.oxlintrc.json

@@ -10,8 +10,8 @@
     "build:sentry": "esbuild --platform=node --format=cjs --outbase=. ./sentry.server.ts ./app/utils/sentryTraceContext.server.ts --outdir=build --sourcemap",
     "dev": "cross-env PORT=3030 remix dev -c \"node ./build/server.js\"",
     "dev:worker": "cross-env NODE_PATH=../../node_modules/.pnpm/node_modules node ./build/server.js",
-    "format": "prettier --write .",
-    "lint": "eslint --cache --cache-location ./node_modules/.cache/eslint .",
+    "format": "oxfmt .",
+    "lint": "oxlint -c ../../.oxlintrc.json",
     "start": "cross-env NODE_ENV=production node --max-old-space-size=8192 ./build/server.js",
     "start:local": "cross-env node --max-old-space-size=8192 ./build/server.js",
     "typecheck": "cross-env NODE_OPTIONS=\"--max-old-space-size=8192\" tsc --noEmit -p ./tsconfig.check.json",
@@ -21,11 +21,6 @@
     "test": "vitest --no-file-parallelism",
     "eval:dev": "evalite watch"
   },
-  "eslintIgnore": [
-    "/node_modules",
-    "/build",
-    "/public/build"
-  ],
   "dependencies": {
     "@ai-sdk/openai": "^3.0.0",
     "@ai-sdk/react": "^3.0.0",
@@ -242,7 +237,6 @@
     "@internal/replication": "workspace:*",
     "@internal/testcontainers": "workspace:*",
     "@remix-run/dev": "2.17.4",
-    "@remix-run/eslint-config": "2.17.4",
     "@remix-run/testing": "^2.17.4",
     "@sentry/cli": "2.50.2",
     "@swc/core": "^1.3.4",
@@ -253,7 +247,6 @@
     "@types/bcryptjs": "^2.4.2",
     "@types/compression": "^1.7.2",
     "@types/cookie": "^0.6.0",
-    "@types/eslint": "^8.4.6",
     "@types/express": "^4.17.13",
     "@types/humanize-duration": "^3.27.1",
     "@types/json-query": "^2.2.3",
@@ -274,19 +267,12 @@
     "@types/supertest": "^6.0.2",
     "@types/tar": "^6.1.4",
     "@types/ws": "^8.5.3",
-    "@typescript-eslint/eslint-plugin": "^5.59.6",
-    "@typescript-eslint/parser": "^5.59.6",
     "autoevals": "^0.0.130",
     "autoprefixer": "^10.4.13",
     "css-loader": "^6.10.0",
     "datepicker": "link:@types/@react-aria/datepicker",
     "engine.io": "^6.5.4",
     "esbuild": "^0.15.10",
-    "eslint": "^8.24.0",
-    "eslint-config-prettier": "^8.5.0",
-    "eslint-plugin-import": "^2.29.1",
-    "eslint-plugin-react-hooks": "^4.6.2",
-    "eslint-plugin-turbo": "^2.0.4",
     "evalite": "1.0.0-beta.16",
     "npm-run-all": "^4.1.5",
     "postcss-import": "^16.0.1",