Merge branch 'preetam/rethink-extension-entity-contracts' into preetam/ext/changeset-resolver

Author: behinddwalls

MODULE.bazel

@@ -53,7 +53,7 @@ use_repo(
     "com_github_go_sql_driver_mysql",
     "com_github_spf13_cobra",
     "com_github_stretchr_testify",
-    "com_github_uber_go_tally_v4",
+    "com_github_uber_go_tally",
     "in_gopkg_yaml_v3",
     "org_golang_google_grpc",
     "org_golang_google_grpc_cmd_protoc_gen_go_grpc",

core/metrics/BUILD.bazel

@@ -7,7 +7,7 @@ go_library(
     visibility = ["//visibility:public"],
     deps = [
         "//core/errs",
-        "@com_github_uber_go_tally_v4//:tally",
+        "@com_github_uber_go_tally//:tally",
     ],
 )
 
@@ -18,6 +18,6 @@ go_test(
     deps = [
         "//core/errs",
         "@com_github_stretchr_testify//assert",
-        "@com_github_uber_go_tally_v4//:tally",
+        "@com_github_uber_go_tally//:tally",
     ],
 )

core/metrics/metrics.go

@@ -17,7 +17,7 @@ package metrics
 import (
 	"time"
 
-	"github.com/uber-go/tally/v4"
+	"github.com/uber-go/tally"
 	"github.com/uber/submitqueue/core/errs"
 )
 

core/metrics/metrics_test.go

@@ -20,7 +20,7 @@ import (
 	"time"
 
 	"github.com/stretchr/testify/assert"
-	"github.com/uber-go/tally/v4"
+	"github.com/uber-go/tally"
 	"github.com/uber/submitqueue/core/errs"
 )
 

doc/rfc/index.md

@@ -11,3 +11,8 @@ Design documents and technical proposals, grouped by scope. Shared/cross-cutting
 - [Orchestrator Workflow](submitqueue/workflow.md) - Queue-driven controller pipeline from gateway entry through batching, scoring, build, merge, and conclude
 - [Build Runner](submitqueue/build-runner.md) - Vendor-agnostic BuildRunner interface, provider-neutral BuildStatus lifecycle, and how the orchestrator wires it into the build stage
 - [Extension Contract](submitqueue/extension-contract.md) - When extensions take orchestrator identity (request/batch) and resolve granular content themselves vs. take controller-resolved data; revises the BuildRunner base/head contract
+
+
+## Stovepipe
+
+- [Stovepipe Workflow](stovepipe/workflow.md) - Post-merge trunk-validation pipeline: ingest trunk push events (webhook + fallback poll), batch since last green, build to validate, record per-commit health, bisect to the offending commit, hand off to a remediation extension

doc/rfc/stovepipe/workflow.md

@@ -13,7 +13,7 @@ go_library(
     deps = [
         "//stovepipe/gateway/controller",
         "//stovepipe/gateway/protopb",
-        "@com_github_uber_go_tally_v4//:tally",
+        "@com_github_uber_go_tally//:tally",
         "@org_golang_google_grpc//:grpc",
         "@org_golang_google_grpc//reflection",
         "@org_uber_go_zap//:zap",

example/stovepipe/gateway/server/BUILD.bazel

@@ -25,7 +25,7 @@ import (
 	"syscall"
 	"time"
 
-	"github.com/uber-go/tally/v4"
+	"github.com/uber-go/tally"
 	"github.com/uber/submitqueue/stovepipe/gateway/controller"
 	pb "github.com/uber/submitqueue/stovepipe/gateway/protopb"
 	"go.uber.org/zap"

example/stovepipe/gateway/server/main.go

@@ -13,7 +13,7 @@ go_library(
     deps = [
         "//stovepipe/orchestrator/controller",
         "//stovepipe/orchestrator/protopb",
-        "@com_github_uber_go_tally_v4//:tally",
+        "@com_github_uber_go_tally//:tally",
         "@org_golang_google_grpc//:grpc",
         "@org_golang_google_grpc//reflection",
         "@org_uber_go_zap//:zap",

example/stovepipe/orchestrator/server/BUILD.bazel

@@ -25,7 +25,7 @@ import (
 	"syscall"
 	"time"
 
-	"github.com/uber-go/tally/v4"
+	"github.com/uber-go/tally"
 	"github.com/uber/submitqueue/stovepipe/orchestrator/controller"
 	pb "github.com/uber/submitqueue/stovepipe/orchestrator/protopb"
 	"go.uber.org/zap"