fix(proto): generate yarpc stubs with v2 codec to match V2 messages

The committed *.pb.yarpc.go stubs were produced by the legacy
protoc-gen-yarpc-go, which wires yarpc's gogo-based protobuf codec
(github.com/gogo/protobuf). The sibling *.pb.go messages, however, are
generated by protoc-gen-go (google.golang.org/protobuf V2 runtime, with
the protoimpl `state`/`sizeCache`/`unknownFields` fields). The two halves
disagree: the gogo codec assumes gogo-style structs, but is handed V2
ones.

This is dormant in this repo because the example servers run the
V2-native grpc-go stub; the yarpc stubs are unused here. But when the
yarpc procedures are consumed elsewhere (e.g. a yarpc monorepo), the gogo
codec's reflection unmarshaler panics on the first untagged V2 field:

    protobuf tag not enough fields in LandRequest.state:

(gogo's encode side tolerates V2 structs by skipping untagged fields, but
the decode side parses every field's protobuf tag and panics — so the
server inbound / client response path breaks.)

Switch the Makefile proto target to protoc-gen-yarpc-go-v2 and regenerate.
The v2 generator emits an API-compatible stub (same NewFx*YARPCProcedures
symbols) whose codec uses the google.golang.org/protobuf V2 runtime,
agreeing with the V2 messages. The codec is per-procedure, so these
procedures interoperate with gogo-based services in the same process; the
wire bytes are identical. gazelle drops the gogo dep and adds
encoding/protobuf/v2; no go.mod/MODULE.bazel change is required.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: albertywu

Makefile

@@ -341,19 +341,19 @@ proto: ## Generate protobuf files from .proto definitions
 	@echo "Generating protobuf files with protoc..."
 	@protoc --go_out=submitqueue/gateway/protopb --go_opt=paths=source_relative \
 	  --go-grpc_out=submitqueue/gateway/protopb --go-grpc_opt=paths=source_relative \
-	  --yarpc-go_out=submitqueue/gateway/protopb --yarpc-go_opt=paths=source_relative \
+	  --yarpc-go-v2_out=submitqueue/gateway/protopb --yarpc-go-v2_opt=paths=source_relative \
 	  --proto_path=submitqueue/gateway/proto submitqueue/gateway/proto/gateway.proto
 	@protoc --go_out=submitqueue/orchestrator/protopb --go_opt=paths=source_relative \
 	  --go-grpc_out=submitqueue/orchestrator/protopb --go-grpc_opt=paths=source_relative \
-	  --yarpc-go_out=submitqueue/orchestrator/protopb --yarpc-go_opt=paths=source_relative \
+	  --yarpc-go-v2_out=submitqueue/orchestrator/protopb --yarpc-go-v2_opt=paths=source_relative \
 	  --proto_path=submitqueue/orchestrator/proto submitqueue/orchestrator/proto/orchestrator.proto
 	@protoc --go_out=stovepipe/gateway/protopb --go_opt=paths=source_relative \
 	  --go-grpc_out=stovepipe/gateway/protopb --go-grpc_opt=paths=source_relative \
-	  --yarpc-go_out=stovepipe/gateway/protopb --yarpc-go_opt=paths=source_relative \
+	  --yarpc-go-v2_out=stovepipe/gateway/protopb --yarpc-go-v2_opt=paths=source_relative \
 	  --proto_path=stovepipe/gateway/proto stovepipe/gateway/proto/gateway.proto
 	@protoc --go_out=stovepipe/orchestrator/protopb --go_opt=paths=source_relative \
 	  --go-grpc_out=stovepipe/orchestrator/protopb --go-grpc_opt=paths=source_relative \
-	  --yarpc-go_out=stovepipe/orchestrator/protopb --yarpc-go_opt=paths=source_relative \
+	  --yarpc-go-v2_out=stovepipe/orchestrator/protopb --yarpc-go-v2_opt=paths=source_relative \
 	  --proto_path=stovepipe/orchestrator/proto stovepipe/orchestrator/proto/orchestrator.proto
 	@echo "Protobuf files generated successfully!"
 

stovepipe/gateway/protopb/BUILD.bazel

@@ -10,18 +10,17 @@ go_library(
     importpath = "github.com/uber/submitqueue/stovepipe/gateway/protopb",
     visibility = ["//visibility:public"],
     deps = [
-        "@com_github_gogo_protobuf//jsonpb",
-        "@com_github_gogo_protobuf//proto",
         "@org_golang_google_grpc//:grpc",
         "@org_golang_google_grpc//codes",
         "@org_golang_google_grpc//status",
+        "@org_golang_google_protobuf//proto",
         "@org_golang_google_protobuf//reflect/protoreflect",
         "@org_golang_google_protobuf//runtime/protoimpl",
         "@org_uber_go_fx//:fx",
         "@org_uber_go_yarpc//:yarpc",
         "@org_uber_go_yarpc//api/transport",
         "@org_uber_go_yarpc//api/x/restriction",
-        "@org_uber_go_yarpc//encoding/protobuf",
         "@org_uber_go_yarpc//encoding/protobuf/reflection",
+        "@org_uber_go_yarpc//encoding/protobuf/v2:protobuf",
     ],
 )

stovepipe/gateway/protopb/gateway.pb.yarpc.go

@@ -10,18 +10,17 @@ go_library(
     importpath = "github.com/uber/submitqueue/stovepipe/orchestrator/protopb",
     visibility = ["//visibility:public"],
     deps = [
-        "@com_github_gogo_protobuf//jsonpb",
-        "@com_github_gogo_protobuf//proto",
         "@org_golang_google_grpc//:grpc",
         "@org_golang_google_grpc//codes",
         "@org_golang_google_grpc//status",
+        "@org_golang_google_protobuf//proto",
         "@org_golang_google_protobuf//reflect/protoreflect",
         "@org_golang_google_protobuf//runtime/protoimpl",
         "@org_uber_go_fx//:fx",
         "@org_uber_go_yarpc//:yarpc",
         "@org_uber_go_yarpc//api/transport",
         "@org_uber_go_yarpc//api/x/restriction",
-        "@org_uber_go_yarpc//encoding/protobuf",
         "@org_uber_go_yarpc//encoding/protobuf/reflection",
+        "@org_uber_go_yarpc//encoding/protobuf/v2:protobuf",
     ],
 )