feat(queue/sql): add publisher with gomock testing

- Implement Publisher interface with SQL MessageStore backend
- Add gomock-based mocks for MessageStore interface
- Use fixed timestamps in tests for repeatability
- Optimize mutex usage: only lock for closed flag check
- Move logging outside mutex to avoid I/O under lock
- Extract validateTopicName to validation.go for sharing
- Add comprehensive test coverage for publish, close, validation, and concurrency

Author: behinddwalls

MODULE.bazel

@@ -39,6 +39,7 @@ use_repo(
     "org_golang_google_grpc",
     "org_golang_google_protobuf",
     "org_uber_go_fx",
+    "org_uber_go_mock",
     "org_uber_go_yarpc",
     "org_uber_go_zap",
 )

extensions/queue/sql/BUILD.bazel

@@ -2,17 +2,37 @@ load("@rules_go//go:def.bzl", "go_library", "go_test")
 
 go_library(
     name = "sql",
-    srcs = ["config.go"],
+    srcs = [
+        "config.go",
+        "publisher.go",
+        "stores.go",
+        "validation.go",
+    ],
     importpath = "github.com/uber/submitqueue/extensions/queue/sql",
     visibility = ["//visibility:public"],
+    deps = [
+        "//entities/queue",
+        "@com_github_uber_go_tally_v4//:tally",
+        "@org_uber_go_zap//:zap",
+    ],
 )
 
 go_test(
     name = "sql_test",
-    srcs = ["config_test.go"],
+    srcs = [
+        "config_test.go",
+        "publisher_test.go",
+    ],
+    data = ["//extensions/queue/sql/schema"],
     embed = [":sql"],
     deps = [
+        "//entities/queue",
+        "//extensions/queue",
+        "//extensions/queue/sql/mocks",
         "@com_github_stretchr_testify//assert",
         "@com_github_stretchr_testify//require",
+        "@com_github_uber_go_tally_v4//:tally",
+        "@org_uber_go_mock//gomock",
+        "@org_uber_go_zap//zaptest",
     ],
 )

extensions/queue/sql/mocks/BUILD.bazel

@@ -0,0 +1,12 @@
+load("@rules_go//go:def.bzl", "go_library")
+
+go_library(
+    name = "mocks",
+    srcs = ["mock_stores.go"],
+    importpath = "github.com/uber/submitqueue/extensions/queue/sql/mocks",
+    visibility = ["//visibility:public"],
+    deps = [
+        "//entities/queue",
+        "@org_uber_go_mock//gomock",
+    ],
+)

extensions/queue/sql/mocks/mock_stores.go

@@ -0,0 +1,72 @@
+package sql
+
+import (
+	"context"
+	"fmt"
+	"sync"
+
+	"github.com/uber-go/tally/v4"
+	"go.uber.org/zap"
+
+	"github.com/uber/submitqueue/entities/queue"
+)
+
+type publisher struct {
+	config       Config
+	logger       *zap.SugaredLogger
+	metrics      tally.Scope
+	messageStore MessageStore
+	mu           sync.RWMutex
+	closed       bool
+}
+
+// NewPublisher creates a publisher with the given configuration and dependencies
+func NewPublisher(config Config, logger *zap.SugaredLogger, metrics tally.Scope, messageStore MessageStore) *publisher {
+	return &publisher{
+		config:       config,
+		logger:       logger,
+		metrics:      metrics,
+		messageStore: messageStore,
+	}
+}
+
+// Publish sends a message to the specified topic
+func (p *publisher) Publish(ctx context.Context, topic string, message queue.Message) error {
+	// Check if closed (under lock)
+	p.mu.RLock()
+	closed := p.closed
+	p.mu.RUnlock()
+
+	if closed {
+		p.logger.Errorw("publish failure: publisher is closed", "topic", topic)
+		return fmt.Errorf("publisher is closed")
+	}
+
+	// Validate topic name (SQL-safe)
+	if err := validateTopicName(topic); err != nil {
+		p.logger.Errorw("publish failure: invalid topic name", "topic", topic, "error", err)
+		p.metrics.Tagged(map[string]string{"topic": topic}).Counter("publish_errors").Inc(1)
+		return fmt.Errorf("publish failure: invalid topic name. err: %w", err)
+	}
+
+	if err := p.messageStore.Insert(ctx, topic, []queue.Message{message}); err != nil {
+		p.metrics.Tagged(map[string]string{"topic": topic}).Counter("publish_errors").Inc(1)
+		p.logger.Errorw("publish failure: message store insert error", "topic", topic, "error", err)
+		return fmt.Errorf("publish failure: message store insert error. err: %w", err)
+	}
+
+	p.metrics.Tagged(map[string]string{"topic": topic}).Counter("messages_published").Inc(1)
+	p.logger.Debugw("published message", "topic", topic, "message_id", message.ID)
+
+	return nil
+}
+
+// Close gracefully shuts down the publisher
+func (p *publisher) Close() error {
+	p.mu.Lock()
+	p.closed = true
+	p.mu.Unlock()
+
+	p.logger.Info("publisher closed")
+	return nil
+}