refactor(storage): revert per-queue Factory; storage is global

## Summary

### Why?

PR #188 added `storage.Factory` (`For(queue) (Storage, error)`) and threaded it into every controller, leaving a `TODO(queue-aware)` in all 11 orchestrator controllers: each fell back to `stores.For("")` because storage is needed *before* the by-ID entity load, so the queue isn't known yet. That chicken-and-egg was the sole reason for the TODO.

Behavioral extensions (mergechecker, buildrunner, scorer, conflict, changeprovider, pusher) are already correctly per-queue — resolved *after* the load from the loaded entity's queue. Storage, by contrast, does not vary by queue: every queue shares the same entity schema and tables. Per-queue storage, if ever needed, is better achieved by splitting the environment and wiring different stores per deployment, not an in-process Factory.

### What?

- Remove the `storage.Factory` interface and delete the `staticFactory` / `NewStaticFactory` implementation (+ its test). Regenerate the storage mock (drops `MockFactory`).
- Switch the 11 orchestrator controllers and the gateway `land` controller from `storage.Factory` to a single injected `storage.Storage`; drop the `stores.For("")` hack and the `TODO(queue-aware)` comments. Queue for logging and behavioral-extension resolution continues to come from the loaded entity.
- Update example wiring (gateway + orchestrator `main.go`) to pass the store directly instead of `NewStaticFactory(store)`.
- Behavioral-extension Factories are unchanged.

No behavior change under today's single-store deployment — `For("")` already returned this exact store.

## Test Plan

✅ `make build`, `make test` (39 pass)
✅ `make gazelle` / `make mocks` / `make tidy` / `make fmt` (all in sync)

Author: behinddwalls

example/submitqueue/gateway/server/BUILD.bazel

@@ -15,7 +15,6 @@ go_library(
         "//extension/messagequeue/mysql",
         "//submitqueue/core/consumer",
         "//submitqueue/extension/queueconfig/yaml",
-        "//submitqueue/extension/storage",
         "//submitqueue/extension/storage/mysql",
         "//submitqueue/gateway/controller",
         "//submitqueue/gateway/protopb",

example/submitqueue/gateway/server/main.go

@@ -32,7 +32,6 @@ import (
 	queueMySQL "github.com/uber/submitqueue/extension/messagequeue/mysql"
 	"github.com/uber/submitqueue/submitqueue/core/consumer"
 	yamlqueueconfig "github.com/uber/submitqueue/submitqueue/extension/queueconfig/yaml"
-	"github.com/uber/submitqueue/submitqueue/extension/storage"
 	mysqlstorage "github.com/uber/submitqueue/submitqueue/extension/storage/mysql"
 	"github.com/uber/submitqueue/submitqueue/gateway/controller"
 	pb "github.com/uber/submitqueue/submitqueue/gateway/protopb"
@@ -201,13 +200,12 @@ func run() error {
 	))
 
 	// Initialize storage from the shared app database connection. The land
-	// controller takes a storage.Factory (static: every queue → this store);
-	// cancel/status use the request log store directly.
+	// controller writes to this store directly; cancel/status use the request
+	// log store directly.
 	store, err := mysqlstorage.NewStorage(appDB, scope.SubScope("storage"))
 	if err != nil {
 		return fmt.Errorf("failed to create storage: %w", err)
 	}
-	stores := storage.NewStaticFactory(store)
 	requestLogStore := store.GetRequestLogStore()
 
 	// Load queue configurations from YAML. Path is required so the gateway
@@ -223,7 +221,7 @@ func run() error {
 
 	// Create controllers and wrap them for gRPC
 	pingController := controller.NewPingController(logger, scope)
-	landController := controller.NewLandController(logger.Sugar(), scope, cnt, stores, queueConfigs, registry)
+	landController := controller.NewLandController(logger.Sugar(), scope, cnt, store, queueConfigs, registry)
 	cancelController := controller.NewCancelController(logger.Sugar(), scope, requestLogStore, registry)
 	statusController := controller.NewStatusController(logger.Sugar(), scope, requestLogStore)
 	gatewayServer := &GatewayServer{

example/submitqueue/orchestrator/server/main.go

@@ -461,14 +461,10 @@ type conflictFactory struct{ impl conflict.Analyzer }
 func (f conflictFactory) For(conflict.Config) (conflict.Analyzer, error) { return f.impl, nil }
 
 func registerControllers(c consumer.Consumer, logger *zap.SugaredLogger, scope tally.Scope, registry consumer.TopicRegistry, mc mergechecker.MergeChecker, cp changeprovider.ChangeProvider, psh pusher.Pusher, br buildrunner.BuildRunner, cnt counter.Counter, store storage.Storage, changeStore changestore.ChangeStore) error {
-	// Static storage factory: every queue resolves to the one configured store.
-	// The factory is the injection point for future per-queue backends.
-	stores := storage.NewStaticFactory(store)
-
 	requestController := start.NewController(
 		logger,
 		scope,
-		stores,
+		store,
 		changeStore,
 		registry,
 		consumer.TopicKeyStart,
@@ -481,7 +477,7 @@ func registerControllers(c consumer.Consumer, logger *zap.SugaredLogger, scope t
 	cancelController := cancel.NewController(
 		logger,
 		scope,
-		stores,
+		store,
 		registry,
 		consumer.TopicKeyCancel,
 		"orchestrator-cancel",
@@ -493,7 +489,7 @@ func registerControllers(c consumer.Consumer, logger *zap.SugaredLogger, scope t
 	validateController := validate.NewController(
 		logger,
 		scope,
-		stores,
+		store,
 		changeStore,
 		registry,
 		mergeCheckerFactory{impl: mc},
@@ -510,7 +506,7 @@ func registerControllers(c consumer.Consumer, logger *zap.SugaredLogger, scope t
 		scope,
 		registry,
 		cnt,
-		stores,
+		store,
 		// TODO: replace with a real conflict analyzer (e.g. one backed by
 		// Tango target analysis). The "all" stub serializes the queue.
 		conflictFactory{impl: all.New()},
@@ -524,7 +520,7 @@ func registerControllers(c consumer.Consumer, logger *zap.SugaredLogger, scope t
 	scoreController := score.NewController(
 		logger,
 		scope,
-		stores,
+		store,
 		// TODO: replace with a real scorer
 		scorerFactory{impl: heuristic.New(
 			[]heuristic.Bucket{
@@ -549,7 +545,7 @@ func registerControllers(c consumer.Consumer, logger *zap.SugaredLogger, scope t
 	speculateController := speculate.NewController(
 		logger,
 		scope,
-		stores,
+		store,
 		registry,
 		consumer.TopicKeySpeculate,
 		"orchestrator-speculate",
@@ -561,7 +557,7 @@ func registerControllers(c consumer.Consumer, logger *zap.SugaredLogger, scope t
 	buildController := build.NewController(
 		logger,
 		scope,
-		stores,
+		store,
 		buildRunnerFactory{impl: br},
 		registry,
 		consumer.TopicKeyBuild,
@@ -574,7 +570,7 @@ func registerControllers(c consumer.Consumer, logger *zap.SugaredLogger, scope t
 	buildsignalController := buildsignal.NewController(
 		logger,
 		scope,
-		stores,
+		store,
 		buildRunnerFactory{impl: br},
 		registry,
 		consumer.TopicKeyBuildSignal,
@@ -587,7 +583,7 @@ func registerControllers(c consumer.Consumer, logger *zap.SugaredLogger, scope t
 	mergeController := merge.NewController(
 		logger,
 		scope,
-		stores,
+		store,
 		registry,
 		pusherFactory{impl: psh},
 		consumer.TopicKeyMerge,
@@ -600,7 +596,7 @@ func registerControllers(c consumer.Consumer, logger *zap.SugaredLogger, scope t
 	concludeController := conclude.NewController(
 		logger,
 		scope,
-		stores,
+		store,
 		registry,
 		consumer.TopicKeyConclude,
 		"orchestrator-conclude",
@@ -612,7 +608,7 @@ func registerControllers(c consumer.Consumer, logger *zap.SugaredLogger, scope t
 	logController := logctrl.NewController(
 		logger,
 		scope,
-		stores,
+		store,
 		consumer.TopicKeyLog,
 		"orchestrator-log",
 	)

submitqueue/extension/storage/BUILD.bazel

@@ -1,4 +1,4 @@
-load("@rules_go//go:def.bzl", "go_library", "go_test")
+load("@rules_go//go:def.bzl", "go_library")
 
 go_library(
     name = "storage",
@@ -7,7 +7,6 @@ go_library(
         "batch_store.go",
         "build_store.go",
         "change_provider_store.go",
-        "factory.go",
         "request_log_store.go",
         "request_store.go",
         "speculation_tree_store.go",
@@ -17,13 +16,3 @@ go_library(
     visibility = ["//visibility:public"],
     deps = ["//submitqueue/entity"],
 )
-
-go_test(
-    name = "storage_test",
-    srcs = ["factory_test.go"],
-    embed = [":storage"],
-    deps = [
-        "@com_github_stretchr_testify//assert",
-        "@com_github_stretchr_testify//require",
-    ],
-)

submitqueue/extension/storage/factory.go

@@ -68,15 +68,3 @@ type Storage interface {
 	// Close closes the storage and all underlying connections. Should only be called once at the end of the program.
 	Close() error
 }
-
-// Factory returns the Storage backing a named queue. It exists so a single
-// queue can be migrated to a different backend without affecting others; the
-// default implementation (NewStaticFactory) returns the same Storage for
-// every queue. Callers resolve the Storage per message from the queue name
-// carried in the message envelope, before any entity lookup.
-type Factory interface {
-	// For returns the Storage for the named queue. An empty name selects the
-	// default backend. It returns an error if no backend is configured for the
-	// queue.
-	For(name string) (Storage, error)
-}

submitqueue/extension/storage/factory_test.go

@@ -64,20 +64,20 @@ type LandController struct {
 	logger       *zap.SugaredLogger
 	metricsScope tally.Scope
 	counter      counter.Counter
-	stores       storage.Factory
+	store        storage.Storage
 	queueConfigs queueconfig.Store
 	registry     consumer.TopicRegistry
 }
 
 // NewLandController creates a new instance of the gateway land controller.
 // The controller publishes land requests to the topic registered under
 // consumer.TopicKeyStart in the registry.
-func NewLandController(logger *zap.SugaredLogger, scope tally.Scope, counter counter.Counter, stores storage.Factory, queueConfigs queueconfig.Store, registry consumer.TopicRegistry) *LandController {
+func NewLandController(logger *zap.SugaredLogger, scope tally.Scope, counter counter.Counter, store storage.Storage, queueConfigs queueconfig.Store, registry consumer.TopicRegistry) *LandController {
 	return &LandController{
 		logger:       logger,
 		metricsScope: scope.SubScope("land_controller"),
 		counter:      counter,
-		stores:       stores,
+		store:        store,
 		queueConfigs: queueConfigs,
 		registry:     registry,
 	}
@@ -110,14 +110,6 @@ func (c *LandController) Land(ctx context.Context, req *pb.LandRequest) (resp *p
 		return nil, fmt.Errorf("LandController failed to look up queue %q: %w", queue, err)
 	}
 
-	// Resolve the storage backend for this entityqueue. The queue is known up front
-	// here (from the request), so this is the one place per-queue storage
-	// routing is actionable.
-	store, err := c.stores.For(queue)
-	if err != nil {
-		return nil, fmt.Errorf("LandController failed to resolve storage for queue=%s: %w", queue, err)
-	}
-
 	// TODO: pass default queue land strategy to resolver function to process a default.
 	strategy, err := resolveRequestLandStrategy(req.Strategy)
 	if err != nil {
@@ -141,7 +133,7 @@ func (c *LandController) Land(ctx context.Context, req *pb.LandRequest) (resp *p
 	// It is important to record the status before publishing to the queue for processing. It is important to publish straight to the database and not via a entityqueue.
 	// Gateway has to stay consistent with the request log.
 	logEntry := entity.NewRequestLog(landRequest.ID, entity.RequestStatusAccepted, 0, "", nil)
-	if err := store.GetRequestLogStore().Insert(ctx, logEntry); err != nil {
+	if err := c.store.GetRequestLogStore().Insert(ctx, logEntry); err != nil {
 		return nil, fmt.Errorf("LandController failed to insert request log for sqid=%s: %w", landRequest.ID, err)
 	}