Commit 43f3258
committed
feat(example): per-queue extension wiring; retire buildrunner/noop
## Summary
### Why?
Demonstrate SubmitQueue's core premise — per-queue pluggable extensions —
in the example orchestrator, rather than wiring one implementation for
every queue, and make the fakes drivable end-to-end. Also document where
factory implementations and queue routing belong.
Stacked on the fakes PR, which adds the extension/*/fake packages this PR
wires in.
### What?
- Queue-major registry in example main.go: queueExtensions (one queue's
full impl set) + queueRegistry (queue -> profile, with a default). Six
thin Factory adapters resolve impls by Config.QueueName — all routing
lives here in the wiring layer.
- Per-queue profiles: test-queue (heuristic over lines changed),
e2e-test-queue (composite scorer, no-conflict), plus a new
e2e-conflict-error-queue that always fails conflict analysis. Edge
integrations + build runner share a baseline; scorer/analyzer are wrapped
by the decorator fakes (score-error marker / failing predicate).
- Retire buildrunner/noop (subsumed by buildrunner/fake); switch the build
controller unit test to buildfake.
- queues.yaml: register e2e-conflict-error-queue.
- CLAUDE.md: extensions hold contracts + impls only — factory
implementations and routing live in the wiring layer; plus a TODO to
evaluate promoting the registry into submitqueue/core later.
## Test Plan
- ✅ `make test` — 44/44 unit tests
- ✅ `make e2e-test` — 1/1
- ✅ `make integration-test` — 7/7
- ✅ `make check-gazelle` / `make check-tidy` — clean
- ✅ Live stack (`make local-submitqueue-start`): Ping OK; gateway rejects
unknown queues; validated end-to-end — scorer passthrough (test-queue),
scorer error (`?sq-fake=score-error` -> "fake: marked score error"), and
conflict error (e2e-conflict-error-queue -> "fake: injected analyze
error").1 parent 3471964 commit 43f3258
9 files changed
Lines changed: 238 additions & 243 deletions
File tree
- example/submitqueue
- gateway/server
- orchestrator/server
- submitqueue
- extension/buildrunner/noop
- orchestrator/controller/build
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
116 | 116 | | |
117 | 117 | | |
118 | 118 | | |
| 119 | + | |
| 120 | + | |
119 | 121 | | |
120 | 122 | | |
121 | 123 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
| 26 | + | |
26 | 27 | | |
27 | 28 | | |
28 | 29 | | |
| 30 | + | |
| 31 | + | |
29 | 32 | | |
| 33 | + | |
30 | 34 | | |
31 | 35 | | |
| 36 | + | |
32 | 37 | | |
33 | 38 | | |
| 39 | + | |
| 40 | + | |
34 | 41 | | |
35 | 42 | | |
36 | 43 | | |
| |||
Large diffs are not rendered by default.
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| 31 | + | |
31 | 32 | | |
32 | | - | |
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| 31 | + | |
31 | 32 | | |
32 | | - | |
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| |||
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
77 | | - | |
| 77 | + | |
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
| |||
111 | 111 | | |
112 | 112 | | |
113 | 113 | | |
114 | | - | |
| 114 | + | |
115 | 115 | | |
116 | 116 | | |
117 | 117 | | |
| |||
124 | 124 | | |
125 | 125 | | |
126 | 126 | | |
127 | | - | |
| 127 | + | |
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
| |||
315 | 315 | | |
316 | 316 | | |
317 | 317 | | |
318 | | - | |
| 318 | + | |
319 | 319 | | |
320 | 320 | | |
321 | 321 | | |
| |||
332 | 332 | | |
333 | 333 | | |
334 | 334 | | |
335 | | - | |
| 335 | + | |
336 | 336 | | |
337 | 337 | | |
338 | 338 | | |
| |||
347 | 347 | | |
348 | 348 | | |
349 | 349 | | |
350 | | - | |
| 350 | + | |
351 | 351 | | |
352 | 352 | | |
353 | 353 | | |
| |||
0 commit comments