Commit e007125
refactor(test): use gomock for Delivery with mocks folder structure
## Summary
Replace manual mockDelivery with gomock-generated mock in a dedicated mocks package.
## What Changed
**Delivery Mock:**
- Generate gomock in extension/queue/mocks/ package
- Add go:generate directive to delivery.go
- Create extension/queue/mocks/BUILD.bazel
**Request Controller Tests:**
- Update request_test.go to use mocks.NewMockDelivery
- Add Message() and Attempt() expectations (controller calls these for logging)
- Remove 45 lines of manual mockDelivery struct
- Add mocks package dependency to BUILD.bazel
## Why Gomock in Mocks Folder?
1. Already used in codebase (extension/queue/sql)
2. Organized structure - mocks in dedicated package
3. Eliminates duplicate manual mocks
4. Better type safety and compile-time verification
5. Easier to maintain with go:generate directive
## Files Changed
- extension/queue/delivery.go (go:generate directive)
- extension/queue/mocks/delivery.go (new - generated mock)
- extension/queue/mocks/BUILD.bazel (new - bazel build)
- orchestrator/controller/request/request_test.go (use gomock)
- orchestrator/controller/request/BUILD.bazel (add mocks dep)
- orchestrator/controller/BUILD.bazel (gazelle formatting)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>1 parent 39e6a79 commit e007125
6 files changed
Lines changed: 201 additions & 75 deletions
File tree
- extension/queue
- mocks
- orchestrator/controller
- request
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
3 | 5 | | |
4 | 6 | | |
5 | 7 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | | - | |
7 | | - | |
| 5 | + | |
8 | 6 | | |
9 | 7 | | |
10 | 8 | | |
| |||
16 | 14 | | |
17 | 15 | | |
18 | 16 | | |
19 | | - | |
20 | | - | |
21 | | - | |
| 17 | + | |
22 | 18 | | |
23 | 19 | | |
24 | 20 | | |
25 | 21 | | |
26 | 22 | | |
27 | 23 | | |
28 | 24 | | |
29 | | - | |
30 | 25 | | |
31 | 26 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | | - | |
7 | | - | |
| 5 | + | |
8 | 6 | | |
9 | 7 | | |
10 | 8 | | |
| |||
18 | 16 | | |
19 | 17 | | |
20 | 18 | | |
21 | | - | |
22 | | - | |
23 | | - | |
| 19 | + | |
24 | 20 | | |
25 | 21 | | |
26 | 22 | | |
27 | 23 | | |
28 | 24 | | |
| 25 | + | |
29 | 26 | | |
30 | 27 | | |
31 | 28 | | |
| 29 | + | |
32 | 30 | | |
33 | 31 | | |
34 | 32 | | |
0 commit comments