Skip to content

Commit e8c261d

Browse files
committed
refactor(queue/mysql): clean up logging, metrics naming, and error handling
- Add queue_mysql_ prefix to all logger Named() and metrics SubScope() calls for consistent scoping across stores - Rename metrics field to scope, use metrics to refer to core/metrics package - Remove redundant pre-operation debug logs (e.g. "inserting messages") - Elevate "message not found for DLQ move" from Debug to Warn - Remove redundant "subscription created" debug log - Replace manual error tagging with core/metrics framework (Begin/Complete) - Remove unused constants (tagErrorType, errorBeginTx, errorCommit)
1 parent 7f44e8d commit e8c261d

10 files changed

Lines changed: 260 additions & 543 deletions

extension/queue/mysql/constants.go

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,16 +17,9 @@ package mysql
1717
// Common constants for frequently repeated strings across stores
1818

1919
const (
20-
// Tag key (used in every Tagged() call)
21-
tagErrorType = "error_type"
22-
2320
// Common log field names (used extensively across all stores)
2421
logTopic = "topic"
2522
logPartitionKey = "partition_key"
2623
logMessageID = "message_id"
2724
logError = "error"
28-
29-
// Error types used across multiple methods/stores
30-
errorBeginTx = "begin_transaction"
31-
errorCommit = "commit"
3225
)

0 commit comments

Comments
 (0)