From def4f5a47167b36ffb63fffc077a385a06f52148 Mon Sep 17 00:00:00 2001 From: Kevin New Date: Mon, 23 Feb 2026 10:08:49 -0800 Subject: [PATCH 1/2] feat(ping api): adding fun exclamation to the response --- orchestrator/controller/ping.go | 2 +- orchestrator/controller/ping_test.go | 2 +- speculator/controller/ping.go | 2 +- speculator/controller/ping_test.go | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/orchestrator/controller/ping.go b/orchestrator/controller/ping.go index f931a563..b3e9c658 100644 --- a/orchestrator/controller/ping.go +++ b/orchestrator/controller/ping.go @@ -33,7 +33,7 @@ func (c *PingController) Ping(ctx context.Context, req *pb.PingRequest) (*pb.Pin c.metricsScope.Counter("ping_requests_total").Inc(1) - message := "pong" + message := "pong!" isEcho := false if req.Message != "" { message = "echo: " + req.Message diff --git a/orchestrator/controller/ping_test.go b/orchestrator/controller/ping_test.go index 6a138a7b..2b4e88c0 100644 --- a/orchestrator/controller/ping_test.go +++ b/orchestrator/controller/ping_test.go @@ -25,7 +25,7 @@ func TestPing_DefaultMessage(t *testing.T) { resp, err := controller.Ping(ctx, req) require.NoError(t, err) - assert.Equal(t, "pong", resp.Message) + assert.Equal(t, "pong!", resp.Message) } func TestPing_CustomMessage(t *testing.T) { diff --git a/speculator/controller/ping.go b/speculator/controller/ping.go index 6f91b58b..08daa4d3 100644 --- a/speculator/controller/ping.go +++ b/speculator/controller/ping.go @@ -33,7 +33,7 @@ func (c *PingController) Ping(ctx context.Context, req *pb.PingRequest) (*pb.Pin c.metricsScope.Counter("ping_requests_total").Inc(1) - message := "pong" + message := "pong!" isEcho := false if req.Message != "" { message = "echo: " + req.Message diff --git a/speculator/controller/ping_test.go b/speculator/controller/ping_test.go index 80e60f01..b952c5b9 100644 --- a/speculator/controller/ping_test.go +++ b/speculator/controller/ping_test.go @@ -25,7 +25,7 @@ func TestPing_DefaultMessage(t *testing.T) { resp, err := controller.Ping(ctx, req) require.NoError(t, err) - assert.Equal(t, "pong", resp.Message) + assert.Equal(t, "pong!", resp.Message) } func TestPing_CustomMessage(t *testing.T) { From 589a3a67b8cdb65a2ae68550ab9447f49a8c5769 Mon Sep 17 00:00:00 2001 From: Kevin New Date: Mon, 23 Feb 2026 13:10:47 -0800 Subject: [PATCH 2/2] add for gateway --- gateway/controller/ping.go | 2 +- gateway/controller/ping_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gateway/controller/ping.go b/gateway/controller/ping.go index 6704fc1d..eef653f6 100644 --- a/gateway/controller/ping.go +++ b/gateway/controller/ping.go @@ -33,7 +33,7 @@ func (c *PingController) Ping(ctx context.Context, req *pb.PingRequest) (*pb.Pin c.metricsScope.Counter("ping_requests_total").Inc(1) - message := "pong" + message := "pong!" isEcho := false if req.Message != "" { message = "echo: " + req.Message diff --git a/gateway/controller/ping_test.go b/gateway/controller/ping_test.go index f8168953..070e2284 100644 --- a/gateway/controller/ping_test.go +++ b/gateway/controller/ping_test.go @@ -25,7 +25,7 @@ func TestPing_DefaultMessage(t *testing.T) { resp, err := controller.Ping(ctx, req) require.NoError(t, err) - assert.Equal(t, "pong", resp.Message) + assert.Equal(t, "pong!", resp.Message) } func TestPing_CustomMessage(t *testing.T) {