From 91d98b3c8ab24f05b62dfc51e34188f50b2b5e9d Mon Sep 17 00:00:00 2001 From: sergeyb Date: Wed, 25 Feb 2026 17:25:32 +0000 Subject: [PATCH] test(all): Remove change detector tests --- core/consumer/registry_test.go | 25 -------- entity/BUILD.bazel | 1 - entity/queue/message_test.go | 14 ----- entity/queue_config_test.go | 23 -------- extension/queue/subscription_config_test.go | 64 --------------------- 5 files changed, 127 deletions(-) delete mode 100644 entity/queue_config_test.go diff --git a/core/consumer/registry_test.go b/core/consumer/registry_test.go index 1c0197da..250e7430 100644 --- a/core/consumer/registry_test.go +++ b/core/consumer/registry_test.go @@ -167,28 +167,3 @@ func TestTopicRegistry_Queue_PerTopic(t *testing.T) { _, ok = registry.Queue(consumer.Topic("nonexistent")) assert.False(t, ok) } - -func TestTopic_String(t *testing.T) { - tests := []struct { - name string - topic consumer.Topic - expected string - }{ - { - name: "predefined topic", - topic: consumer.TopicRequest, - expected: "request", - }, - { - name: "custom topic", - topic: consumer.Topic("custom"), - expected: "custom", - }, - } - - for _, tt := range tests { - t.Run(tt.name, func(t *testing.T) { - assert.Equal(t, tt.expected, tt.topic.String()) - }) - } -} diff --git a/entity/BUILD.bazel b/entity/BUILD.bazel index 98ed2138..a2e750e6 100644 --- a/entity/BUILD.bazel +++ b/entity/BUILD.bazel @@ -19,7 +19,6 @@ go_test( name = "entity_test", srcs = [ "build_test.go", - "queue_config_test.go", "request_test.go", ], embed = [":entity"], diff --git a/entity/queue/message_test.go b/entity/queue/message_test.go index bc08cd7b..64ba867d 100644 --- a/entity/queue/message_test.go +++ b/entity/queue/message_test.go @@ -7,20 +7,6 @@ import ( "github.com/stretchr/testify/assert" ) -func TestNewMessage(t *testing.T) { - id := "test-id" - payload := []byte("test payload") - - msg := NewMessage(id, payload, "", nil) - - assert.Equal(t, id, msg.ID) - assert.Equal(t, payload, msg.Payload) - assert.Empty(t, msg.PartitionKey) - assert.NotNil(t, msg.Metadata) - assert.Empty(t, msg.Metadata) - assert.NotZero(t, msg.PublishedAt) -} - func TestMessage_Copy(t *testing.T) { original := NewMessage("id-123", []byte("payload"), "partition-1", map[string]string{"key": "value"}) diff --git a/entity/queue_config_test.go b/entity/queue_config_test.go deleted file mode 100644 index 98a71f37..00000000 --- a/entity/queue_config_test.go +++ /dev/null @@ -1,23 +0,0 @@ -package entity - -import ( - "testing" - - "github.com/stretchr/testify/assert" -) - -func TestQueueConfig(t *testing.T) { - cfg := QueueConfig{ - Name: "uber/submitqueue/main", - VCSType: "git", - VCSAddress: "git@github.com:uber/submitqueue.git", - Target: "main", - BuildRunner: "buildkite.com/uber/submitqueue-ci", - } - - assert.Equal(t, "uber/submitqueue/main", cfg.Name) - assert.Equal(t, "git", cfg.VCSType) - assert.Equal(t, "git@github.com:uber/submitqueue.git", cfg.VCSAddress) - assert.Equal(t, "main", cfg.Target) - assert.Equal(t, "buildkite.com/uber/submitqueue-ci", cfg.BuildRunner) -} diff --git a/extension/queue/subscription_config_test.go b/extension/queue/subscription_config_test.go index 48b93ff0..259ceca0 100644 --- a/extension/queue/subscription_config_test.go +++ b/extension/queue/subscription_config_test.go @@ -7,36 +7,6 @@ import ( "github.com/stretchr/testify/require" ) -func TestDefaultSubscriptionConfig(t *testing.T) { - topic := "test-topic" - subscriberName := "test-worker" - consumerGroup := "test-consumer" - - config := DefaultSubscriptionConfig(topic, subscriberName, consumerGroup) - - // Verify required fields are set - assert.Equal(t, topic, config.Topic) - assert.Equal(t, subscriberName, config.SubscriberName) - assert.Equal(t, consumerGroup, config.ConsumerGroup) - - // Verify default timing values (in milliseconds) - assert.Equal(t, int64(100), config.PollIntervalMs) - assert.Equal(t, 10, config.BatchSize) - assert.Equal(t, int64(60000), config.VisibilityTimeoutMs) - assert.Equal(t, int64(10000), config.LeaseRenewalIntervalMs) - assert.Equal(t, int64(30000), config.LeaseDurationMs) - - // Verify retry config defaults - assert.Equal(t, 3, config.Retry.MaxAttempts) - assert.Equal(t, int64(1000), config.Retry.InitialBackoffMs) - assert.Equal(t, int64(30000), config.Retry.MaxBackoffMs) - assert.Equal(t, 2.0, config.Retry.BackoffMultiplier) - - // Verify DLQ config defaults - assert.True(t, config.DLQ.Enabled) - assert.Equal(t, "_dlq", config.DLQ.TopicSuffix) -} - func TestSubscriptionConfig_FieldsAreIndependent(t *testing.T) { // Create two configs and modify one to ensure they're independent config1 := DefaultSubscriptionConfig("topic-1", "worker-1", "consumer-1") @@ -89,40 +59,6 @@ func TestSubscriptionConfig_CustomValues(t *testing.T) { assert.Equal(t, "_dead", config.DLQ.TopicSuffix) } -func TestRetryConfig_ZeroValues(t *testing.T) { - // Test that zero-value RetryConfig can be created - var config RetryConfig - - assert.Equal(t, 0, config.MaxAttempts) - assert.Equal(t, int64(0), config.InitialBackoffMs) - assert.Equal(t, int64(0), config.MaxBackoffMs) - assert.Equal(t, 0.0, config.BackoffMultiplier) -} - -func TestDLQConfig_ZeroValues(t *testing.T) { - // Test that zero-value DLQConfig can be created - var config DLQConfig - - assert.False(t, config.Enabled) - assert.Equal(t, "", config.TopicSuffix) -} - -func TestSubscriptionConfig_ZeroValues(t *testing.T) { - // Test that zero-value SubscriptionConfig can be created - var config SubscriptionConfig - - assert.Equal(t, "", config.Topic) - assert.Equal(t, "", config.SubscriberName) - assert.Equal(t, "", config.ConsumerGroup) - assert.Equal(t, int64(0), config.PollIntervalMs) - assert.Equal(t, 0, config.BatchSize) - assert.Equal(t, int64(0), config.VisibilityTimeoutMs) - assert.Equal(t, int64(0), config.LeaseRenewalIntervalMs) - assert.Equal(t, int64(0), config.LeaseDurationMs) - assert.Equal(t, 0, config.Retry.MaxAttempts) - assert.False(t, config.DLQ.Enabled) -} - func TestSubscriptionConfig_DifferentConsumerGroups(t *testing.T) { // Test that different consumer groups get independent configs tests := []struct {