From dfd9884eaa6c59b5c1b9b895b35e2755a7ca58dd Mon Sep 17 00:00:00 2001
From: Ulli Hafner <ullrich.hafner@gmail.com>
Date: Tue, 14 Apr 2026 11:04:58 +0200
Subject: [PATCH] Restore serialization to use interfaces again

Changing the fields to serializable classes breaks the existing
serializations.
---
 etc/pmd-java-configuration.xml                    | 1 -
 pom.xml                                           | 7 +++++++
 src/main/java/edu/hm/hafner/util/FilteredLog.java | 8 ++++----
 3 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/etc/pmd-java-configuration.xml b/etc/pmd-java-configuration.xml
index 3c8cabff..aac62fb8 100644
--- a/etc/pmd-java-configuration.xml
+++ b/etc/pmd-java-configuration.xml
@@ -21,7 +21,6 @@
   <rule ref="category/java/bestpractices.xml/LooseCoupling">
     <properties>
       <property name="allowedTypes" value="java.util.Properties, java.util.Stack, java.util.jar.Attributes, net.minidev.json.JSONArray, hudson.util.ListBoxModel, hudson.util.ComboBoxModel, hudson.DescriptorExtensionList, hudson.EnvVars,  org.jsoup.select.Elements, edu.hm.hafner.util.LineRangeList" />
-      <property name="violationSuppressXPath" value="./ancestor::ClassDeclaration[1][pmd-java:typeIs('java.io.Serializable')]"/>
     </properties>
   </rule>
   <rule ref="category/java/codestyle.xml">
diff --git a/pom.xml b/pom.xml
index 55ec6d25..1d2243ee 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1012,6 +1012,13 @@
                   <classQualifiedName>edu.hm.hafner.util.SuppressMutation.*</classQualifiedName>
                   <justification>PitMute Annotations are not relevant in API</justification>
                 </item>
+                <item>
+                  <ignore>true</ignore>
+                  <regex>true</regex>
+                  <code>java.field.serialVersionUIDUnchanged</code>
+                  <classSimpleName>FilteredLog</classSimpleName>
+                  <justification>We are using the interface which still serializes correctly.</justification>
+                </item>
               </differences>
             </revapi.differences>
             <revapi.versions>
diff --git a/src/main/java/edu/hm/hafner/util/FilteredLog.java b/src/main/java/edu/hm/hafner/util/FilteredLog.java
index e446025d..86ba3e70 100644
--- a/src/main/java/edu/hm/hafner/util/FilteredLog.java
+++ b/src/main/java/edu/hm/hafner/util/FilteredLog.java
@@ -31,10 +31,10 @@ public class FilteredLog implements Serializable {
     private final int maxLines;
     private int lines;
 
-    @SuppressWarnings("PMD.LooseCoupling")
-    private final ArrayList<String> infoMessages = new ArrayList<>();
-    @SuppressWarnings("PMD.LooseCoupling")
-    private final ArrayList<String> errorMessages = new ArrayList<>();
+    @SuppressWarnings("serial")
+    private final List<String> infoMessages = new ArrayList<>();
+    @SuppressWarnings("serial")
+    private final List<String> errorMessages = new ArrayList<>();
 
     private transient ReentrantLock lock = new ReentrantLock();