From 450656a4b0aa5c8745994997cb3f2264518f4d31 Mon Sep 17 00:00:00 2001
From: kw-pr <9133572+kw-pr@users.noreply.github.com>
Date: Wed, 29 Aug 2018 09:50:42 +0200
Subject: [PATCH] fixed undefined and unused some variables

$postparams and $target overwritten.
$comment is not defined.
$transactionId not defined, replaced with `$parameters->IDENTIFICATION_TRANSACTIONID` <= please check this!
---
 Frontend/HeidelGateway/Controllers/Frontend/PaymentHgw.php | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/Frontend/HeidelGateway/Controllers/Frontend/PaymentHgw.php b/Frontend/HeidelGateway/Controllers/Frontend/PaymentHgw.php
index 0407ee7..0afebce 100644
--- a/Frontend/HeidelGateway/Controllers/Frontend/PaymentHgw.php
+++ b/Frontend/HeidelGateway/Controllers/Frontend/PaymentHgw.php
@@ -1486,7 +1486,6 @@ public function savePaymentAction(){
 		    $swVersion = Shopware::VERSION;
 		    $tplVersion = Shopware()->Shop()->getTemplate()->getVersion();
 
-			$postparams = array();
             $postparams = array('payment' => $this->Request()->getParam('sRegister'));
 
 			$_SERVER['REQUEST_METHOD'] = 'GET';
@@ -1507,7 +1506,6 @@ public function savePaymentAction(){
 
 			$this->Request()->setPost('sRegister', $postparams);
 
-			$target = false;
 			$target = $this->Request()->getParam('sTarget');
 			if(!empty($target)){
 				$this->Request()->setParam('sTarget', $target);
@@ -1765,6 +1763,7 @@ public function successAction(){
 								'{IDENTIFICATION_SHORTID}'		=> "\n".$parameters->IDENTIFICATION_SHORTID,
 						);
 
+			$comment = '';
                         if(
                             (strtolower($payType) == 'iv') ||
                             (strtolower($payType) == 'papg') ||
@@ -1962,7 +1961,7 @@ public function successAction(){
                                         );
                                     }
 
-									$orderNum = $this->getOrder($transactionId);
+									$orderNum = $this->getOrder($parameters->IDENTIFICATION_TRANSACTIONID);
 									$prepayment = array();
 									$user = $this->getUser();
 									foreach($repl AS $k => $v){
@@ -3925,4 +3924,4 @@ public function getWhitelistedCSRFActions()
             'succsess'
 		);
 	}
-}
\ No newline at end of file
+}