Set up shared Prettier configuration from @upfluence/w-conf#22
Merged
Conversation
Co-authored-by: phndiaye <4022350+phndiaye@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Set up shared Prettier configuration from @upfluence/w-conf
Set up shared Prettier configuration from @upfluence/w-conf
Mar 5, 2026
phndiaye
approved these changes
Mar 5, 2026
7 tasks
Co-authored-by: phndiaye <4022350+phndiaye@users.noreply.github.com>
chore: run pnpm prettier **/*.{js,ts,hbs} --write
olxmpe
approved these changes
Mar 27, 2026
JulienVannier66
approved these changes
Mar 27, 2026
aprentout
approved these changes
Mar 31, 2026
| import { run } from '@ember/runloop'; | ||
| import { inject as service } from '@ember/service'; | ||
|
|
||
| import ActivityTracking from '../services/activity-tracking'; |
There was a problem hiding this comment.
Question here, isn't it better to do the following ?
Suggested change
| import ActivityTracking from '../services/activity-tracking'; | |
| import ActivityTracking from '@upfluence/hyperevents/services/activity-tracking'; |
Member
There was a problem hiding this comment.
doesn't change anything.
and it's actually better like this and it will also end up being relative imports when we land v2 addon format as the "package name as prefix" is part of Ember's weird magic ^^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces the shared Upfluence Prettier setup (
@upfluence/w-conf) with import sorting, replacing the bespoke.prettierrc.Changes
prettier.config.mjs— New ESM config usingbuildConfigurationfrom@upfluence/w-conf/prettier, withsortImportscoped to@upfluence/hypereventspackage.json— Added@upfluence/w-conf@^0.2.0,@trivago/prettier-plugin-sort-imports@^4.3.0; bumpedprettierto^3.0.0.prettierrc— Deleted (superseded byprettier.config.mjs).prettierignore— Addedpnpm-lock.yamltsconfig.json, and HTML files updated to match new config outputWhat are the observable changes?
Running
pnpm prettier --check .will pass. Import order in.js/.tsfiles is now enforced: Ember/Glimmer internals → third-party →@upfluence/hyperevents→ relative.🧑💻 Developer Heads Up
⚡ Since we are using Ember Octane now:
Useful Resource : Ember Octane vs Classic Cheat Sheet
Good PR checklist
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/orgs/upfluence/packages/npm/w-conf/versions/usr/bin/curl curl -H Authorization: ****** REDACTED(http block)/usr/bin/curl curl -s -H Authorization: ****** REDACTED(http block)/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
This pull request was created from Copilot chat.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.