From 6454d45e72738bb484e4321db56b5f3afaee7e5b Mon Sep 17 00:00:00 2001 From: "Maximilien B." Date: Mon, 4 May 2026 11:32:23 +0200 Subject: [PATCH 1/5] Updated: FeatureCard - getters as privates --- addon/components/o-s-s/feature-card.ts | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/addon/components/o-s-s/feature-card.ts b/addon/components/o-s-s/feature-card.ts index d380764bd..3a296eeb7 100644 --- a/addon/components/o-s-s/feature-card.ts +++ b/addon/components/o-s-s/feature-card.ts @@ -55,14 +55,6 @@ export default class OSSFeatureCard extends Component { } } - get colorVariant(): OSSFeatureCardColorVariant { - return this.args.colorVariant ?? DEFAULT_COLOR_VARIANT; - } - - get shadowVariant(): OSSFeatureCardShadowVariant { - return this.args.shadowVariant ?? DEFAULT_SHADOW_VARIANT; - } - get computedClasses(): string { return [ 'oss-feature-card', @@ -71,6 +63,14 @@ export default class OSSFeatureCard extends Component { ].join(' '); } + private get colorVariant(): OSSFeatureCardColorVariant { + return this.args.colorVariant ?? DEFAULT_COLOR_VARIANT; + } + + private get shadowVariant(): OSSFeatureCardShadowVariant { + return this.args.shadowVariant ?? DEFAULT_SHADOW_VARIANT; + } + get imageAlt(): string { return this.args.image.alt ?? ''; } From 1d511ffb50b6101597d364c07abea4ceb3f96a9e Mon Sep 17 00:00:00 2001 From: "Maximilien B." Date: Mon, 4 May 2026 11:33:04 +0200 Subject: [PATCH 2/5] Updated: FeatureCardsContainer - use oop methods - remove dead assertions --- .../o-s-s/feature-cards-container.ts | 40 +++++++++---------- 1 file changed, 18 insertions(+), 22 deletions(-) diff --git a/addon/components/o-s-s/feature-cards-container.ts b/addon/components/o-s-s/feature-cards-container.ts index ea9e9353b..6b0e26a6d 100644 --- a/addon/components/o-s-s/feature-cards-container.ts +++ b/addon/components/o-s-s/feature-cards-container.ts @@ -7,26 +7,6 @@ type OSSFeatureCardsContainerArgs = { cards: OSSFeatureCardArgs[]; }; -function isCenterCard(cardsCount: number, index: number): boolean { - return cardsCount === 1 || (cardsCount === 3 && index === 1); -} - -function getDefaultCardColorVariant(cardsCount: number, index: number): OSSFeatureCardColorVariant { - if (isCenterCard(cardsCount, index)) return 'violet'; - - if (cardsCount === 2 || cardsCount === 3) return index === 0 ? 'blue' : 'yellow'; - - assert('[OSS::FeatureCardsContainer] Internal layout configuration mismatch', false); -} - -function getDefaultCardShadowVariant(cardsCount: number, index: number): OSSFeatureCardShadowVariant { - if (isCenterCard(cardsCount, index)) return 'lg'; - - if (cardsCount === 2 || cardsCount === 3) return 'sm'; - - assert('[OSS::FeatureCardsContainer] Internal layout configuration mismatch', false); -} - export default class OSSFeatureCardsContainer extends Component { constructor(owner: unknown, args: OSSFeatureCardsContainerArgs) { super(owner, args); @@ -43,8 +23,8 @@ export default class OSSFeatureCardsContainer extends Component { const cardCount = cards.length; - const colorVariant = card.colorVariant ?? getDefaultCardColorVariant(cardCount, index); - const shadowVariant = card.shadowVariant ?? getDefaultCardShadowVariant(cardCount, index); + const colorVariant = card.colorVariant ?? this.getDefaultCardColorVariant(cardCount, index); + const shadowVariant = card.shadowVariant ?? this.getDefaultCardShadowVariant(cardCount, index); return { ...card, @@ -53,4 +33,20 @@ export default class OSSFeatureCardsContainer extends Component Date: Mon, 4 May 2026 11:34:12 +0200 Subject: [PATCH 3/5] Removed: FeatureCardsContainer less - unwanted comments + use prettier alignment --- app/styles/molecules/feature-cards-container.less | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/styles/molecules/feature-cards-container.less b/app/styles/molecules/feature-cards-container.less index 78002fdb7..873388ced 100644 --- a/app/styles/molecules/feature-cards-container.less +++ b/app/styles/molecules/feature-cards-container.less @@ -15,31 +15,31 @@ &__item { position: absolute; - // To target child i in a list of n, we can use: :nth-child(i):nth-last-child(n - i + 1) - // Specific 2 cards layout &:first-child:nth-last-child(2) { translate: calc(-1 * var(--two-cards-offset-x)); rotate: calc(-1 * var(--rotation-angle)); } + &:last-child:nth-child(2) { translate: var(--two-cards-offset-x); rotate: var(--rotation-angle); } - // Specific 3 cards layout &:first-child:nth-last-child(3) { top: var(--side-cards-top); translate: calc(-1 * var(--three-cards-offset-x)); rotate: calc(-1 * var(--rotation-angle)); } + &:nth-child(2):nth-last-child(2) { top: var(--center-card-top); z-index: 1; } + &:last-child:nth-child(3) { top: var(--side-cards-top); translate: var(--three-cards-offset-x); rotate: var(--rotation-angle); } } -} +} \ No newline at end of file From d33ccd9f08ed06af1589f371aff514ec52e7a463 Mon Sep 17 00:00:00 2001 From: "Maximilien B." Date: Mon, 4 May 2026 11:40:12 +0200 Subject: [PATCH 4/5] Updated: FeatureCardsContainer less - fix positioning to prevent misalignment --- app/styles/molecules/feature-cards-container.less | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/styles/molecules/feature-cards-container.less b/app/styles/molecules/feature-cards-container.less index 873388ced..e360451d8 100644 --- a/app/styles/molecules/feature-cards-container.less +++ b/app/styles/molecules/feature-cards-container.less @@ -16,11 +16,13 @@ position: absolute; &:first-child:nth-last-child(2) { + top: var(--side-cards-top); translate: calc(-1 * var(--two-cards-offset-x)); rotate: calc(-1 * var(--rotation-angle)); } &:last-child:nth-child(2) { + top: var(--side-cards-top); translate: var(--two-cards-offset-x); rotate: var(--rotation-angle); } From b9f7b92e9bd5e6294ca764fc4a41f12ff2b39c72 Mon Sep 17 00:00:00 2001 From: Maximilien B Date: Tue, 5 May 2026 12:02:34 +0200 Subject: [PATCH 5/5] Updated: Reddit sans with semibold weight --- app/styles/deprecated/_fonts.less | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/styles/deprecated/_fonts.less b/app/styles/deprecated/_fonts.less index 2442e984e..b0cdaa71b 100644 --- a/app/styles/deprecated/_fonts.less +++ b/app/styles/deprecated/_fonts.less @@ -1 +1 @@ -@import url('https://fonts.googleapis.com/css?family=Reddit+Sans:wght@400&family=Open+Sans:400,400i,600,600i,700,700i&display=swap&subset=cyrillic,cyrillic-ext,greek,greek-ext,latin-ext,vietnamese'); +@import url('https://fonts.googleapis.com/css?family=Reddit+Sans:wght@400,600&family=Open+Sans:400,400i,600,600i,700,700i&display=swap&subset=cyrillic,cyrillic-ext,greek,greek-ext,latin-ext,vietnamese'); \ No newline at end of file