From ccd655737674e87afbe5ec500e984d7706bd7b0e Mon Sep 17 00:00:00 2001 From: jublankeviadee Date: Mon, 23 Feb 2026 11:03:29 +0100 Subject: [PATCH 1/3] fix: added suite setup/teardown to model visitor for called keyword parsing --- .../robot_parsing/called_keyword_parsing.py | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/packages/roboview/roboview/models/robot_parsing/called_keyword_parsing.py b/packages/roboview/roboview/models/robot_parsing/called_keyword_parsing.py index 7a51a4e..98f6238 100644 --- a/packages/roboview/roboview/models/robot_parsing/called_keyword_parsing.py +++ b/packages/roboview/roboview/models/robot_parsing/called_keyword_parsing.py @@ -11,6 +11,8 @@ Teardown, TestSetup, TestTeardown, + SuiteSetup, + SuiteTeardown ) logger = logging.getLogger(__name__) @@ -69,6 +71,22 @@ def visit_Teardown(self, node: Teardown) -> None: # noqa: N802 """ self._add_keyword(node.name) + def visit_SuiteSetup(self, node: SuiteSetup) -> None: # noqa: N802 + """Visit a SuiteSetup node and extract the keyword. + + Arguments: + node (SuiteSetup): SuiteSetup node in the AST. + """ + self._add_keyword(node.name) + + def visit_SuiteTeardown(self, node: SuiteTeardown) -> None: # noqa: N802 + """Visit a SuiteTeardown node and extract the keyword. + + Arguments: + node (SuiteTeardown): SuiteTeardown node in the AST. + """ + self._add_keyword(node.name) + def visit_TestSetup(self, node: TestSetup) -> None: # noqa: N802 """Visit a TestSetup node and extract the keyword. From 8a8e9d59789fdf78762ab17eee2528a03e0b865b Mon Sep 17 00:00:00 2001 From: jublankeviadee Date: Mon, 23 Feb 2026 12:52:22 +0100 Subject: [PATCH 2/3] misc: ruff corrections --- .../robot_parsing/called_keyword_parsing.py | 28 ++++++++++--------- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/packages/roboview/roboview/models/robot_parsing/called_keyword_parsing.py b/packages/roboview/roboview/models/robot_parsing/called_keyword_parsing.py index 98f6238..f569718 100644 --- a/packages/roboview/roboview/models/robot_parsing/called_keyword_parsing.py +++ b/packages/roboview/roboview/models/robot_parsing/called_keyword_parsing.py @@ -53,37 +53,39 @@ def visit_KeywordCall(self, node: KeywordCall) -> None: # noqa: N802 """ self._add_keyword(node.keyword) - def visit_Setup(self, node: Setup) -> None: # noqa: N802 - """Visit a Setup node and extract the keyword. + def visit_SuiteSetup(self, node: SuiteSetup) -> None: # noqa: N802 + """Visit a SuiteSetup node and extract the keyword. Arguments: - node (Setup): Setup node in the AST. - + node (SuiteSetup): SuiteSetup node in the AST. + """ self._add_keyword(node.name) - def visit_Teardown(self, node: Teardown) -> None: # noqa: N802 - """Visit a Teardown node and extract the keyword. + def visit_SuiteTeardown(self, node: SuiteTeardown) -> None: # noqa: N802 + """Visit a SuiteTeardown node and extract the keyword. Arguments: - node (Teardown): Teardown node in the AST. + node (SuiteTeardown): SuiteTeardown node in the AST. """ self._add_keyword(node.name) - def visit_SuiteSetup(self, node: SuiteSetup) -> None: # noqa: N802 - """Visit a SuiteSetup node and extract the keyword. + def visit_Setup(self, node: Setup) -> None: # noqa: N802 + """Visit a Setup node and extract the keyword. Arguments: - node (SuiteSetup): SuiteSetup node in the AST. + node (Setup): Setup node in the AST. + """ self._add_keyword(node.name) - def visit_SuiteTeardown(self, node: SuiteTeardown) -> None: # noqa: N802 - """Visit a SuiteTeardown node and extract the keyword. + def visit_Teardown(self, node: Teardown) -> None: # noqa: N802 + """Visit a Teardown node and extract the keyword. Arguments: - node (SuiteTeardown): SuiteTeardown node in the AST. + node (Teardown): Teardown node in the AST. + """ self._add_keyword(node.name) From 4c2240b9a6a19f1aa890fb9f607c19dfe14b1a27 Mon Sep 17 00:00:00 2001 From: jublankeviadee Date: Mon, 23 Feb 2026 13:02:02 +0100 Subject: [PATCH 3/3] misc: ruff corrections --- .../roboview/models/robot_parsing/called_keyword_parsing.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/roboview/roboview/models/robot_parsing/called_keyword_parsing.py b/packages/roboview/roboview/models/robot_parsing/called_keyword_parsing.py index f569718..5d04c25 100644 --- a/packages/roboview/roboview/models/robot_parsing/called_keyword_parsing.py +++ b/packages/roboview/roboview/models/robot_parsing/called_keyword_parsing.py @@ -8,11 +8,11 @@ from robot.parsing.model.statements import ( KeywordCall, Setup, + SuiteSetup, + SuiteTeardown, Teardown, TestSetup, TestTeardown, - SuiteSetup, - SuiteTeardown ) logger = logging.getLogger(__name__) @@ -58,7 +58,7 @@ def visit_SuiteSetup(self, node: SuiteSetup) -> None: # noqa: N802 Arguments: node (SuiteSetup): SuiteSetup node in the AST. - + """ self._add_keyword(node.name)