Skip to content

body.upload.upload_link is null sometimes #325

Description

@jongotlin

For an unknown reason I've got null as upload_link from Vimeo a few times.

$url = $attempt['body']['upload']['upload_link'];

This breaks the code here:

$client = $this->_tus_client_factory->getTusClient($base_url, $url);

Vimeo\Upload\TusClientFactory::getTusClient(): Argument #2 ($url) must be of type string, null given, called in /var/task/vendor/vimeo/vimeo-api/src/Vimeo/Vimeo.php on line 599

We should solve it by either throw an exception, allow null or cast to string. I have too little knowledge in this process to know what's best but I can sure open a PR if someone decides which way to go.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions