vp fmt errors when all input files are excluded by ignorePatterns

[nickytonline]

Describe the bug

When vp staged passes files to vp fmt that are all excluded by fmt ignorePatterns in vite.config.ts, vp fmt exits non-zero with "Expected at least one target file" instead of exiting 0.

This happens when a CI bot commits only package-lock.json. The staged config matches it via *.json, passes it to vp fmt, which filters it out via ignorePatterns, then errors because zero files remain.

Config:

staged: {
  "*.{json,md,mdx,css,html,yml,yaml}": ["vp fmt"],
},
fmt: {
  ignorePatterns: ["package-lock.json", ...],
},

Expected: vp fmt exits 0 when all inputs are excluded by its own ignore patterns.
Actual: exits non-zero with "Expected at least one target file".

Reproduction

https://github.com/nickytonline/vp-fmt-repro

Steps to reproduce

1. Install Vite+: curl -fsSL https://viteplus.dev/install.sh | bash
2. Clone the https://github.com/nickytonline/vp-fmt-repro repo and run vp install
3. Make any change to package-lock.json (e.g. add a trailing newline)
4. Stage and commit:

   git add package-lock.json
   git commit -m "test"
   

System Info

vp v0.1.14
vite-plus v0.1.14
oxfmt v0.42.0
Node.js v22.22.2
npm v11.12.1

Used Package Manager

npm

Logs

See https://github.com/nickytonline/nickytdotco/actions/runs/23727201068/job/69113096665#logs


Run ./bin/pr-blog-posts.sh
  ./bin/pr-blog-posts.sh
  shell: /usr/bin/bash -e {0}
  env:
    GITHUB_TOKEN: ***
Switched to branch 'chore_automated_update_blog_posts_1774842949'
M	package-lock.json
Creating PR "chore (automated): update blog posts" for branch chore_automated_update_blog_posts_1774842949
[STARTED] Backing up original state...
[COMPLETED] Backed up original state in git stash (77fcc62)
[STARTED] Running tasks for staged files...
[STARTED] Config object — 1 file
[STARTED] *.{js,ts,jsx,tsx,astro,mjs,cjs} — 0 files
[STARTED] *.{json,md,mdx,css,html,yml,yaml} — 1 file
[SKIPPED] *.{js,ts,jsx,tsx,astro,mjs,cjs} — no files
[STARTED] vp fmt
[FAILED] vp fmt [FAILED]
[FAILED] vp fmt [FAILED]
[COMPLETED] Running tasks for staged files...
[STARTED] Applying modifications from tasks...
[SKIPPED] Skipped because of errors from tasks.
[STARTED] Reverting to original state because of errors...
[COMPLETED] Reverting to original state because of errors...
[STARTED] Cleaning up temporary files...
[COMPLETED] Cleaning up temporary files...
✖ vp fmt:
Expected at least one target file
VITE+ - pre-commit script failed (code 1)
remote: 
remote: Create a pull request for 'chore_automated_update_blog_posts_1774842949' on GitHub by visiting:        
remote:      https://github.com/nickytonline/nickytdotco/pull/new/chore_automated_update_blog_posts_1774842949        
remote: 
To https://github.com/nickytonline/nickytdotco
 * [new branch]      chore_automated_update_blog_posts_1774842949 -> chore_automated_update_blog_posts_1774842949
pull request create failed: GraphQL: No commits between main and chore_automated_update_blog_posts_1774842949 (createPullRequest)
no pull requests found for branch "chore_automated_update_blog_posts_1774842949"
Error: Process completed with exit code 1.

Validations

• Read the Contributing Guidelines.
• Check that there isn't already an issue for the same bug.
• Confirm this is a Vite+ issue and not an upstream issue (Vite, Vitest, tsdown, Rolldown, or Oxc).
• The provided reproduction is a minimal reproducible example.

[nickytonline]

Happy to dig into this and provide a PR.

[kazupon]

Thank you for your reporting!
I could reproduce this issue on my env.

Happy to dig into this and provide a PR.

Sure! we’d love to contribute from you.

[leaysgur]

NOTE:

• This comes from usage of oxfmt --no-error-on-unmatched-pattern
• vp check automatically add it when positional PATH provided
• But vp fmt itself does not

In that sense, perhaps it’s something the user should specify...?

https://oxc.rs/docs/guide/usage/formatter/ci.html#pre-commit-hook

[leaysgur]

Also found oxlint does not have --no-error-on-unmatched-pattern.
(eslint does have it, however)

In short, the question here is: How we want vp check|lint|fmt to behave when a user specifies a path that doesn't exist.

• If we want to be helpful and throw an error,
  • we would need to introduce a breaking change to oxlint to report them
• If we want to allow it,
  • we should just ensure that vp fmt always includes the --no-error-on-unmatched-pattern flag

---

BTW, I suspect the output we're getting for now is NOT the intended behavior?

❯ vp check noop
VITE+ - The Unified Toolchain for the Web

error: Formatting could not start
Checking formatting...

Finished in 90ms on 0 files using 8 threads.
No files found matching the given patterns.

Formatting failed before analysis started
pass: Found no warnings, lint errors, or type errors in 0 files (82ms, 8 threads)

vp check [PATH] automatically set vp fmt --no-error-on-unmatched-pattern to surpress error, but it reports error.

[cpojer]

I suggest this:

• No change to vp fmt or vp check. They both work as expected.
• vp fmt --no-error-on-unmatched-pattern is the correct way to call vp fmt with possibly ignored/missing files.
• Oxlint should support --no-error-on-unmatched-pattern since it takes a list of files, and so vp lint should also support it. vp check should pass it automatically also.
• We should fix the output of vp check with missing files, it does look incorrectly handled.

We could consider removing it as a default from vp check as well and adding this flag to the staged config. It is a breaking change, but might be worth it for consistency.