From 14c517e0640c05f50ae89430e905278bf2681533 Mon Sep 17 00:00:00 2001 From: Breno Novelli Date: Fri, 12 Jun 2026 23:35:45 -0300 Subject: [PATCH 1/2] fix: add files field to prevent dist from being excluded in pack, and fix ads-react build order MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Without a `files` field and no `.npmignore`, pnpm pack honors `.gitignore` which excludes `dist/` — the tarball sent to CodeArtifact was missing the built output. For ads-react: DK runs nodeCommands from contextPath (packages/react), so ads-core dist doesn't exist yet when tsup tries to generate .d.ts. A `prebuild` lifecycle script builds ads-core first. - Add `files: ["dist", "src", ...]` to both packages so pnpm pack includes dist - Add `prebuild` to ads-react that builds ads-core before tsup runs - Move @swc/core from dependencies to devDependencies (it's a build tool, not runtime) Co-Authored-By: Claude Sonnet 4.6 --- packages/core/package.json | 8 +++++++- packages/react/package.json | 7 +++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/packages/core/package.json b/packages/core/package.json index 39806f6..3f5145e 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -2,6 +2,12 @@ "name": "@vtex/ads-core", "type": "module", "version": "0.5.2", + "files": [ + "dist", + "src", + "README.md", + "CHANGELOG.md" + ], "scripts": { "build": "tsup", "clean": "rimraf dist", @@ -10,7 +16,6 @@ "test": "vitest" }, "dependencies": { - "@swc/core": "^1.13.3", "cross-fetch": "^4.1.0" }, "main": "dist/cjs/index.cjs.js", @@ -53,6 +58,7 @@ }, "homepage": "https://github.com/vtex/ads-js/tree/main/packages/ads-core#readme", "devDependencies": { + "@swc/core": "^1.13.3", "tsup": "^8.5.0" } } diff --git a/packages/react/package.json b/packages/react/package.json index dc88142..fc16f0f 100644 --- a/packages/react/package.json +++ b/packages/react/package.json @@ -12,7 +12,14 @@ "import": "./dist/esm/index.js" } }, + "files": [ + "dist", + "src", + "README.md", + "CHANGELOG.md" + ], "scripts": { + "prebuild": "pnpm --filter @vtex/ads-core run build", "build": "tsup", "clean": "rimraf dist", "dev": "tsc --watch", From eed3c4226514472fdf388bb2223da5988209c105 Mon Sep 17 00:00:00 2001 From: Breno Novelli Date: Fri, 12 Jun 2026 23:37:55 -0300 Subject: [PATCH 2/2] chore: update lockfile after moving @swc/core to devDependencies Co-Authored-By: Claude Sonnet 4.6 --- pnpm-lock.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 7186a0c..777a973 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -117,13 +117,13 @@ importers: packages/core: dependencies: - '@swc/core': - specifier: ^1.13.3 - version: 1.13.3 cross-fetch: specifier: ^4.1.0 version: 4.1.0 devDependencies: + '@swc/core': + specifier: ^1.13.3 + version: 1.13.3 tsup: specifier: ^8.5.0 version: 8.5.0(@swc/core@1.13.3)(jiti@1.21.7)(postcss@8.5.6)(typescript@5.8.3)(yaml@2.8.0)