🐛🧑‍💻 - Setup crash

[efraespada]

Is there an existing issue for this?

• I have searched the existing issues.

Which actions are affected?

No response

Which platforms are affected?

No response

Description

There is a crash when running the setup command out of this project.

Reproducing the issue

Run copilot setup of this repository.

copilot Version

v2

Relevant Log Output

🔍 Checking we are inside a git repository...
✅ Git repository detected.
🔗 Resolving repository (owner/repo)...
📦 Repository: landamessenger/zstandard
⚙️  Running initial setup (labels, issue types, access)...
node:fs:448
    return binding.readFileUtf8(path, stringToFlags(options.flag));
                   ^

Error: ENOENT: no such file or directory, open '/Users/efraespada/Development/zstandard/action.yml'
    at Object.readFileSync (node:fs:448:20)
    at loadActionYaml (/Users/efraespada/Development/copilot/build/cli/index.js:60655:28)
    at getActionInputs (/Users/efraespada/Development/copilot/build/cli/index.js:60659:24)
    at getActionInputsWithDefaults (/Users/efraespada/Development/copilot/build/cli/index.js:60663:20)
    at runLocalAction (/Users/efraespada/Development/copilot/build/cli/index.js:46813:70)
    at Command.<anonymous> (/Users/efraespada/Development/copilot/build/cli/index.js:47672:45)
    at Command.listener [as _actionHandler] (/Users/efraespada/Development/copilot/build/cli/index.js:63310:17)
    at /Users/efraespada/Development/copilot/build/cli/index.js:64270:14
    at Command._chainOrCall (/Users/efraespada/Development/copilot/build/cli/index.js:64154:12)
    at Command._parseCommand (/Users/efraespada/Development/copilot/build/cli/index.js:64269:27) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: '/Users/efraespada/Development/zstandard/action.yml'
}

Additional context and comments

Not sure if there was an error while creating the initial .env file. I think it wasn't created.

[vypbot]

🐛 Bugfix Actions

1. The issue was assigned to @efraespada (creator).
2. The issue's title was updated from Setup crash to 🐛🧑‍💻 - Setup crash.
3. The issue was linked to vypdev and moved to the column Todo.
4. Priority set to P0 in vypdev.
5. The branch develop was used to create bugfix/309-setup-crash.
6. Moved issue to In Progress in vypdev.
7. Recommended steps (OpenCode Plan agent):
8. Based on my analysis of the codebase, I can see the issue clearly:

Root Cause: When running copilot setup in a repository (like landamessenger/zstandard), the runLocalAction() function calls getActionInputsWithDefaults() which tries to read action.yml from the current working directory (the target repo). However, the target repository being set up doesn't have an action.yml file, causing an ENOENT crash.

Recommended Steps to Fix Issue #309

1. Modify loadActionYaml to Handle Missing File

File: src/utils/yml_utils.ts:17-21

Make the function gracefully handle the case when action.yml doesn't exist by checking if the file exists before reading:

export function loadActionYaml(): ActionYaml {
  const actionYamlPath = path.join(process.cwd(), 'action.yml');
  
  if (!fs.existsSync(actionYamlPath)) {
    return {
      name: '',
      description: '',
      author: '',
      inputs: {}
    };
  }
  
  const yamlContent = fs.readFileSync(actionYamlPath, 'utf8');
  return yaml.load(yamlContent) as ActionYaml;
}

2. Add Tests for Missing action.yml

File: src/utils/__tests__/yml_utils.test.ts

Add test case to ensure the function handles missing files:

it('returns empty inputs when action.yml does not exist', () => {
  mockReadFileSync.mockImplementation(() => {
    const error = new Error('ENOENT: no such file or directory');
    (error as NodeJS.ErrnoException).code = 'ENOENT';
    throw error;
  });
  // or use existsSync mock
  
  const { loadActionYaml } = require('../yml_utils');
  const result = loadActionYaml();
  
  expect(result.inputs).toEqual({});
  expect(result.name).toBe('');
});

3. Verify the Fix

Run the test suite to ensure existing tests still pass:

npm test -- src/utils/__tests__/yml_utils.test.ts

4. Build and Test

Build the CLI and test the setup command in a repo without action.yml:

npm run build
cd /path/to/test-repo
copilot setup

5. Update Documentation (if needed)

If there's user-facing documentation about the setup command behavior when run in repos without action.yml, update it in the docs/ folder to clarify that copilot setup can now be run in any repository.

Reminder

1. Take a coffee break while you work ☕.
2. Check out the branch:

git fetch -v && git checkout bugfix/309-setup-crash

3. Commit the needed changes with this prefix:

bugfix-309-setup-crash

4. Open a Pull Request from bugfix/309-setup-crash to develop. New PR

🚀 Happy coding!

[vypbot]

🐛 Bugfix News

Changes on branch bugfix/309-setup-crash:

---

• 8eca2b5 by Efra Espada (@efraespada)

Refactor loadActionYaml to resolve action.yml from the copilot package root instead of the current working directory. Update type definitions and add documentation for clarity on path resolution in different contexts.

---

• 16ff6a5 by Efra Espada (@efraespada)

Enhance setup process by validating PERSONAL_ACCESS_TOKEN availability. Introduce functions to check token presence in environment and .env file, ensuring setup continuity. Update copySetupFiles to handle token checks and improve logging for user guidance on token setup.

---

• fd735be by Efra Espada (@efraespada)

Enhance CLI setup test by verifying token presence in parameters and adding comments for clarity on token validation coverage in related tests.

---

• e11b036 by Efra Espada (@efraespada)

Add tests for various exit conditions in CLI commands, including handling non-GitHub URLs, errors in `getGitInfo`, and missing issue numbers. Introduce emoji-based title formatting in `IssueRepository` based on labels, ensuring proper representation for different issue types. Improve test coverage for issue state transitions and context fallbacks.

---

• 45a4b87 by Efra Espada (@efraespada)

Add publicUrl method to ProjectDetail class and update related use cases to utilize it. Enhance tests for publicUrl functionality to ensure correct URL generation based on project details.

---

• 37dff87 by Efra Espada (@efraespada)

Add publicUrl method to ProjectDetail class and update related use cases to utilize it. Enhance tests to verify correct URL generation when project URL is absent.

---