From b71753c1a24fb08671fc7e05ac4d209e7e2de90b Mon Sep 17 00:00:00 2001 From: Matej Novotny Date: Fri, 5 Jun 2026 15:09:08 +0200 Subject: [PATCH] Add CDI API signature test module Separate module activated via -Dsigtest, with a CI job on JDK 17. --- .github/workflows/ci-actions.yml | 25 ++++++++++ pom.xml | 13 ++++- sigtest/pom.xml | 81 ++++++++++++++++++++++++++++++++ 3 files changed, 118 insertions(+), 1 deletion(-) create mode 100644 sigtest/pom.xml diff --git a/.github/workflows/ci-actions.yml b/.github/workflows/ci-actions.yml index bab1f96bf3..dbc963dd30 100644 --- a/.github/workflows/ci-actions.yml +++ b/.github/workflows/ci-actions.yml @@ -210,6 +210,31 @@ jobs: name: server-log-cdi-tck-jdk${{matrix.java.name}} path: 'server-log.tgz' + # CDI API signature test + # The JDK version used for signature verification is pinned in sigtest/pom.xml via maven.compiler.release + sigtest: + name: "CDI Signature Test" + runs-on: ubuntu-latest + needs: initial-build + timeout-minutes: 10 + steps: + - uses: actions/checkout@v6 + - name: Set up JDK 21 + uses: actions/setup-java@v5 + with: + java-version: 21 + distribution: 'temurin' + - name: Download Maven Repo + uses: actions/download-artifact@v8 + with: + name: maven-repo + path: . + - name: Extract Maven Repo + shell: bash + run: tar -xzf maven-repo.tgz -C ~ + - name: Run Signature Test + run: mvn verify -Dsigtest -Dno-format -pl sigtest + # relaxed mode, w/ and w/o Wildfly, single JDK version relaxed-mode-test: name: "Relaxed mode testing - JDK ${{matrix.java.name}}" diff --git a/pom.xml b/pom.xml index dccd84c782..a1e2aa5e40 100644 --- a/pom.xml +++ b/pom.xml @@ -61,7 +61,7 @@ 1.2.4.Final 2.0.1 - 5.0.0.Beta1 + 5.0.0.Beta2-SNAPSHOT 11.0.3 @@ -523,6 +523,17 @@ jboss-tck-runner + + sigtest + + + sigtest + + + + sigtest + + examples diff --git a/sigtest/pom.xml b/sigtest/pom.xml new file mode 100644 index 0000000000..283e437df3 --- /dev/null +++ b/sigtest/pom.xml @@ -0,0 +1,81 @@ + + + + weld-core-parent + org.jboss.weld + 7.0.0-SNAPSHOT + ../pom.xml + + 4.0.0 + weld-sigtest + jar + CDI API Signature Test + Verifies CDI API signatures against the TCK signature file + + + + 17 + true + true + + + + + org.jboss.weld + weld-core-impl + + + + + + + org.apache.maven.plugins + maven-dependency-plugin + + + copy-sigfile + generate-test-resources + + copy + + + + + jakarta.cdi + jakarta.cdi-tck-core-impl + ${cdi.tck.version} + sigfile + jdk${maven.compiler.release} + true + cdi-api.sigfile + + + ${project.build.directory} + + + + + + jakarta.tck + sigtest-maven-plugin + 2.6 + + + sigtest + test + + check + + + + + strictcheck + ${project.build.directory}/cdi-api.sigfile + jakarta.decorator,jakarta.enterprise.**,jakarta.interceptor + ${project.build.directory}/cdi-sig-report.txt + + + + +