process pr comments

Author: Piotr Stachaczynski

Examples/Examples/Mcp/AgentWithKnowledgeMcpExample.cs

@@ -33,7 +33,7 @@ public async Task Start()
                     Arguments = ["-y",
                         "@modelcontextprotocol/server-filesystem",
                         "C:\\Users\\stach\\Desktop",  //Align paths to fit your system
-                        "C:\\WiseDev", //Align paths to fit your system
+                        "C:\\WiseDev" //Align paths to fit your system
                         ], //Align paths to fit your system
                     Backend = BackendType.GroqCloud,
                     Model = "openai/gpt-oss-20b"

Examples/Examples/Utils/Tools.cs

@@ -22,7 +22,6 @@ public static class NoteTools
 {
     private const string NotesFolder = "notes";
 
-
     public static async Task<object> ListNotes(ListNotesArgs args)
     {
         if (!Directory.Exists(args.Folder))

src/MaIN.Core/Hub/Utils/ToolConfigurationBuilder.cs

@@ -2,15 +2,15 @@
 using MaIN.Domain.Entities.Tools;
 
 namespace MaIN.Core.Hub.Utils;
-
+//TODO try to share logic of adding tool to the list across methods https://github.com/wisedev-code/MaIN.NET/pull/98#discussion_r2454997846
 public class ToolsConfigurationBuilder
 {
-    private readonly ToolsConfiguration _config = new() { Tools = new List<ToolDefinition>() };
+    private readonly ToolsConfiguration _config = new() { Tools = [] };
 
     public ToolsConfigurationBuilder AddDefaultTool(
         string type)
     {
-        _config.Tools!.Add(new ToolDefinition
+        _config.Tools.Add(new ToolDefinition
         {
             Type = type
         });
@@ -23,7 +23,7 @@ public ToolsConfigurationBuilder AddTool(
         object parameters,
         Func<string, Task<string>> execute)
     {
-        _config.Tools!.Add(new ToolDefinition
+        _config.Tools.Add(new ToolDefinition
         {
             Function = new FunctionDefinition
             {
@@ -61,7 +61,7 @@ public ToolsConfigurationBuilder AddTool<TArgs>(
         object parameters,
         Func<TArgs, Task<object>> execute) where TArgs : class
     {
-        _config.Tools!.Add(new ToolDefinition
+        _config.Tools.Add(new ToolDefinition
         {
             Function = new FunctionDefinition
             {
@@ -110,7 +110,7 @@ public ToolsConfigurationBuilder AddTool(
         string description,
         Func<Task<object>> execute)
     {
-        _config.Tools!.Add(new ToolDefinition
+        _config.Tools.Add(new ToolDefinition
         {
             Function = new FunctionDefinition
             {
@@ -132,7 +132,7 @@ public ToolsConfigurationBuilder AddTool(
         string description,
         Func<object> execute)
     {
-        _config.Tools!.Add(new ToolDefinition
+        _config.Tools.Add(new ToolDefinition
         {
             Function = new FunctionDefinition
             {

src/MaIN.Domain/Entities/Tools/ToolsConfiguration.cs

@@ -2,11 +2,11 @@ namespace MaIN.Domain.Entities.Tools;
 
 public class ToolsConfiguration
 {
-    public List<ToolDefinition>? Tools { get; set; }
+    public required List<ToolDefinition> Tools { get; set; }
     public string? ToolChoice { get; set; }
 
     public Func<string, Task<string>>? GetExecutor(string functionName)
     {
-        return Tools?.FirstOrDefault(t => t.Function.Name == functionName)?.Execute;
+        return Tools.FirstOrDefault(t => t.Function!.Name == functionName)?.Execute;
     }
 }