Fix release config editing and static-site CLI dependencies#29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR tightens the post-build lifecycle CLI in two places:
fission.tomlcomments and formatting when release commands update project metadata.fission-clidependency graph so static-site publishing does not needlibdbus-1-devjust to runfission site checkor package the documentation site.Details
Release metadata editing
Release setup, signing import, and store metadata import commands now use
toml_editfor in-place TOML updates instead of parsing throughtoml::Valueand rewriting the whole manifest. This keeps hand-written project metadata readable and avoids destroying comments or existing layout infission.toml.Touched paths include:
crates/tools/fission-cli/src/release.rscrates/tools/fission-cli/src/release/signing_ops.rscrates/tools/fission-cli/src/release/store_ops.rscrates/tools/fission-cli/src/release/microsoft_store_ops.rsStatic-site CI dependency cleanup
The GitHub Pages workflow failed because the CLI pulled
libdbus-systhrough this chain:fission-cli -> keyring -> dbus-secret-service -> dbus -> libdbus-sysThat was caused by enabling the persistent Linux Secret Service backend on
keyring. Static-site generation does not need DBus, and the CLI should not force DBus development headers into unrelated workflows.The CLI now disables default keyring features and enables the Linux
keyutilsbackend instead:keyring = { default-features = false, features = ["apple-native", "windows-native", "linux-native", "crypto-rust"] }Verification
cargo tree -p fission-cli --target x86_64-unknown-linux-gnu -i libdbus-sys --lockedprints no dependency path.cargo tree -p fission-cli --target x86_64-unknown-linux-gnu --locked | rg -i "dbus|secret-service|keyutils|keyring"only showskeyringandlinux-keyutils.cargo test -p fission-cli --lockedpasses.cargo run -p fission-cli --bin fission -- site check --project-dir documentation --releasepasses.cargo run -p fission-cli --bin fission -- package --project-dir documentation --target site --format static --releasepasses.